We don't allow clauses of form `condition -> effect` currently, so we can't.
Also, it it theoretically possible to write something like "if b is true then block is called" (which is more sensible IMO, because then we can do smartcast *inside* lambda), but it not supported in the compiler itself yet.


Thanks for the feedback, the idea of this experiment was just to show which lines in the code are critical for performance and how we could optimize them with minimal changes. The parallel change was the last resort for increasing the performance and I agree with you that it should be avoided as it would probably cause an overhead for smaller projects.
After reading your second post and analyzing the current code I realized that you are completely right, the excluding logic can be done more efficiently so I will make another version which will include the changes that you suggested.


[tests/testthat/test-CalcDARLEQ.R:11:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/dcdfa97a266d9df75530e8373b0a7222739fd71f/tests/testthat/test-CalcDARLEQ.R#L11) *style:* **Variable or function name should be snake_case.**
```r
    badData <- data.frame(sampleID = c("1", "2", "3"),
    ^~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:29:3:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/dcdfa97a266d9df75530e8373b0a7222739fd71f/tests/testthat/test-CalcDARLEQ.R#L29) *style:* **Variable or function name should be snake_case.**
```r
  darleqTaxonDictionary  <-  read.csv(system.file("extdata",
  ^~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:36:3:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/dcdfa97a266d9df75530e8373b0a7222739fd71f/tests/testthat/test-CalcDARLEQ.R#L36) *style:* **Variable or function name should be snake_case.**
```r
  lookUpDARLEQ2 <- phytobenthosMetrics:::LookUpDARLEQ2
  ^~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:54:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/dcdfa97a266d9df75530e8373b0a7222739fd71f/tests/testthat/test-CalcDARLEQ.R#L54) *style:* **Variable or function name should be snake_case.**
```r
    riverAquaMetrics  <-  read.csv(system.file("extdata",
    ^~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:58:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/dcdfa97a266d9df75530e8373b0a7222739fd71f/tests/testthat/test-CalcDARLEQ.R#L58) *style:* **Variable or function name should be snake_case.**
```r
    lakesAquaMetrics  <-  read.csv(system.file("extdata",
    ^~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:63:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/dcdfa97a266d9df75530e8373b0a7222739fd71f/tests/testthat/test-CalcDARLEQ.R#L63) *style:* **Variable or function name should be snake_case.**
```r
    riverDARLEQRResults  <-  read.csv(system.file("extdata",
    ^~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:67:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/dcdfa97a266d9df75530e8373b0a7222739fd71f/tests/testthat/test-CalcDARLEQ.R#L67) *style:* **Variable or function name should be snake_case.**
```r
    lakesDARLEQRResults  <-  read.csv(system.file("extdata",
    ^~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:72:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/dcdfa97a266d9df75530e8373b0a7222739fd71f/tests/testthat/test-CalcDARLEQ.R#L72) *style:* **Variable or function name should be snake_case.**
```r
    riverAquaMetricsResults <- CalcDARLEQ(riverAquaMetrics, metric = "rivers")
    ^~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:73:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/dcdfa97a266d9df75530e8373b0a7222739fd71f/tests/testthat/test-CalcDARLEQ.R#L73) *style:* **Variable or function name should be snake_case.**
```r
    riverAquaMetricsResults <- data.frame(riverAquaMetricsResults[1])
    ^~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:75:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/dcdfa97a266d9df75530e8373b0a7222739fd71f/tests/testthat/test-CalcDARLEQ.R#L75) *style:* **Variable or function name should be snake_case.**
```r
    lakeAquaMetricsResults <- CalcDARLEQ(lakesAquaMetrics, metric = "lakes")
    ^~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:76:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/dcdfa97a266d9df75530e8373b0a7222739fd71f/tests/testthat/test-CalcDARLEQ.R#L76) *style:* **Variable or function name should be snake_case.**
```r
    lakeAquaMetricsResults <- data.frame(lakeAquaMetricsResults[1])
    ^~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:79:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/dcdfa97a266d9df75530e8373b0a7222739fd71f/tests/testthat/test-CalcDARLEQ.R#L79) *style:* **Variable or function name should be snake_case.**
```r
    roundExcel <- function(x, n) {
    ^~~~~~~~~~
```


More than one empty lines


In fact only `isString` is in use below


I actually did not mean to commit this file, this was to see why my macro wasn't working correctly.


Operators supposed to surrounded with whitespaces. A guy talked about this last week on the demo, I'll ask his presentation for you! 😄


@CaoHoa1 Please see all closed issues on this project https://github.com/gauravsacc/MMM-GoogleAssistant/issues?q=is%3Aissue+is%3Aclosed


So the first number in those tuples is where the bit mask data begins for each province in TAMRIEL.MNU? I'm looking near the end of the file and I think the scattered groups of numbers like 0x00, 0xF8, 0xFC, and 0xFF are the bit masks you're talking about, but I'm not sure how to interpret the data. Those province positions listed above are rectangles (for the 320x200 image?), but I thought Arena listens for a mouse click at some XY coordinate and then looks up which province it is, so the actual click areas aren't rectangles. Could you elaborate on it a bit more?


I recommend using different formatting here to make it more readable and maintainable. Here is my recommendation, using new functions for SSE_local and SST_local, which I recommended above. Using tabs to maintain structure is consistent with Python style, and removes the need to use lots of indents to line everything up inside the dictionary. Minimizing the amount of indentation also gives you more room for code on each line. Placing json.dumps on the return line separates the steps and removes the need to create another variable for the output.

computation_output = {
    'output': {
        'SSE_local': calc_SSE_local(...),
        'SST_local': calc_SST_local(...),
        'varX_matrix_local': np.dot(biased_X.T, biased_X),
        'computation_phase': computation_phase,
    }
}

return json.dumps(computation_output, sort_keys=True, indent=4, separators=(',', ': '))


:metal: :metal:  :metal:  the only suggestion i have is the one we talked about today, that maybe you can clear the long line up by creating variables for the last character and the first part of the word


I mention that condition is not "always false" here. For example:

```
fun isString(x: Any?): Boolean {
    if (someRandomlyDeterminedCondition()) return false
    else return x is String
}
```


ApplicationThreadLocals.setUserId(2L); why is this ?


Assignment 1 API Design version 1.0


What if we remove subject and write `isString(x)` just in when entry?


How many more times we have to remind you where to right business logic ?


It's being matched against "Sai", which is a dagger type listed in a separate file; this appears to be loaded in and combined with the general types.


If we would work together, I'd ask you to write the classes functional descriptions on the top of your code, so I can find what them easier if I want to add a feature for eg.


[tests/testthat/test-CalcDARLEQ.R:11:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/f9a3aa50c7a722a2b8b77278a0de01331e83e227/tests/testthat/test-CalcDARLEQ.R#L11) *style:* **Variable or function name should be snake_case.**
```r
    badData <- data.frame(sampleID = c("1", "2", "3"),
    ^~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:29:3:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/f9a3aa50c7a722a2b8b77278a0de01331e83e227/tests/testthat/test-CalcDARLEQ.R#L29) *style:* **Variable or function name should be snake_case.**
```r
  darleqTaxonDictionary  <-  read.csv(system.file("extdata",
  ^~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:36:3:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/f9a3aa50c7a722a2b8b77278a0de01331e83e227/tests/testthat/test-CalcDARLEQ.R#L36) *style:* **Variable or function name should be snake_case.**
```r
  lookUpDARLEQ2 <- phytobenthosMetrics:::LookUpDARLEQ2
  ^~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:54:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/f9a3aa50c7a722a2b8b77278a0de01331e83e227/tests/testthat/test-CalcDARLEQ.R#L54) *style:* **Variable or function name should be snake_case.**
```r
    riverAquaMetrics  <-  read.csv(system.file("extdata",
    ^~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:58:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/f9a3aa50c7a722a2b8b77278a0de01331e83e227/tests/testthat/test-CalcDARLEQ.R#L58) *style:* **Variable or function name should be snake_case.**
```r
    lakesAquaMetrics  <-  read.csv(system.file("extdata",
    ^~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:63:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/f9a3aa50c7a722a2b8b77278a0de01331e83e227/tests/testthat/test-CalcDARLEQ.R#L63) *style:* **Variable or function name should be snake_case.**
```r
    riverDARLEQRResults  <-  read.csv(system.file("extdata",
    ^~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:67:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/f9a3aa50c7a722a2b8b77278a0de01331e83e227/tests/testthat/test-CalcDARLEQ.R#L67) *style:* **Variable or function name should be snake_case.**
```r
    lakesDARLEQRResults  <-  read.csv(system.file("extdata",
    ^~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:72:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/f9a3aa50c7a722a2b8b77278a0de01331e83e227/tests/testthat/test-CalcDARLEQ.R#L72) *style:* **Variable or function name should be snake_case.**
```r
    riverAquaMetricsResults <- CalcDARLEQ(riverAquaMetrics, metric = "rivers")
    ^~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:73:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/f9a3aa50c7a722a2b8b77278a0de01331e83e227/tests/testthat/test-CalcDARLEQ.R#L73) *style:* **Variable or function name should be snake_case.**
```r
    riverAquaMetricsResults <- data.frame(riverAquaMetricsResults[1])
    ^~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:75:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/f9a3aa50c7a722a2b8b77278a0de01331e83e227/tests/testthat/test-CalcDARLEQ.R#L75) *style:* **Variable or function name should be snake_case.**
```r
    lakeAquaMetricsResults <- CalcDARLEQ(lakesAquaMetrics, metric = "lakes")
    ^~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:76:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/f9a3aa50c7a722a2b8b77278a0de01331e83e227/tests/testthat/test-CalcDARLEQ.R#L76) *style:* **Variable or function name should be snake_case.**
```r
    lakeAquaMetricsResults <- data.frame(lakeAquaMetricsResults[1])
    ^~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:79:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/f9a3aa50c7a722a2b8b77278a0de01331e83e227/tests/testthat/test-CalcDARLEQ.R#L79) *style:* **Variable or function name should be snake_case.**
```r
    roundExcel <- function(x, n) {
    ^~~~~~~~~~
```


Should that be changed for every instance? I'd be hesitant to change it in just one place.


I agree. I think this entire system is pretty brain-damaged. On the other hand, I don't have time to fix it properly, and we already have an incompatibleTypes list; I was quite surprised that "incompatibleTypes" wasn't consulted when testing to see if something is a compatible type.

This feels like it moves the code further towards the principle of no surprise.


I recommend breaking this out into multiple lines, one line per parameter.

```python
clf = sklearn.linear_model.Ridge(
    alpha=lamb,
    fit_intercept=True,
    normalize=False,
    copy_X=True,
    max_iter=None,
    tol=0.001,
    solver='auto',
    random_state=None
)
```


Ternary 🆒


>  adding two memset calls to pngrutil.c does stop the three "use of uninitialized value" reports.
Makes sense. msan sees the `memset` initialization and does not complain even though it does not see the real initialization in the non-instrumented code.

>  the source for the "converage" reports seems to be lagging behind the GIT repo by a couple of weeks.

One or two *days* would be expected, but not two weeks. @oliverchang, did we have any disruptions with coverage?

> Would it make sense for me to create a libpng branch that includes the zlib sources too?

Using a branch is always a risk that the branch will go out of sync/
Better just change Dockerfile/build.sh to download zli and build it.
However, if you've solved the problem with memset, it's good enough.
Another alternative, is to wait for us to provide msan-ified zlib (we have this in future plans)


But why it can't be used in official source?


Budget**Cheack**Helper, is it a spelling mistake ?
Avoid suffixes like **Helper** every source code are helpers only.


> If they were all initially present in the same libseccomp release, I'd think that representing them all with level '3' would be fine.

The only value in splitting them up would be at the distro level where a package maintainer wanted to backport, for example, the logging changes (level '3') but not the process kill changes (level '4'). However, that feature backport model breaks down completely if the package maintainer wanted to backport the process kill changes but not the logging changes since the process kill changes are a higher API level. Therefore, I think that the API level should only be assigned at a libseccomp release granularity and not at an individual feature granularity.


I recommend separating this into a separate function, as it is a lot to unpack in a list comprehension. It also seems like something we will probably need to reuse elsewhere.

2*(1-stats.t.cdf(np.abs(t),dof))


I got mentioned because of this :'(


Can combine these last two lines into a single line.


TeamCity Code :: 1. Development :: DDK :: Feature [Build 455](http://mp-ci.centralus.cloudapp.azure.com/viewLog.html?buildId=31490&buildTypeId=Code_Development_Ddk_Feature) is now running


you can avoid code duplication if you create a variable for the number of ears. this is what you return at the base case so the code becomes more dynamic \o/

then after the (first) else you increment this number by numberOfEars(number - 1), and include the if even part after for adding 1 to the ears variable and also return this one at the end. but it's like 1 line more so tit for tat i guess :D


@markbubel Don't know what went wrong here. Did I make a typo or more major error when trying to update the code?


Created multidev environment [myeap2#ci-5](https://dashboard.pantheon.io/sites/707d6be3-751a-41e9-8b65-45e6cf277199#ci-5).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-5-myeap2.pantheonsite.io/)


modified


soy marcos


For these last 3 lines, I recommend using assignment operators.

https://www.tutorialspoint.com/python/assignment_operators_example.htm


[tests/testthat/test-CalcDARLEQ.R:11:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/64bc1ea312edfa8f80dbda17bb5d9c489079f48c/tests/testthat/test-CalcDARLEQ.R#L11) *style:* **Variable or function name should be snake_case.**
```r
    badData <- data.frame(sampleID = c("1", "2", "3"),
    ^~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:29:3:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/64bc1ea312edfa8f80dbda17bb5d9c489079f48c/tests/testthat/test-CalcDARLEQ.R#L29) *style:* **Variable or function name should be snake_case.**
```r
  darleqTaxonDictionary  <-  read.csv(system.file("extdata",
  ^~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:36:3:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/64bc1ea312edfa8f80dbda17bb5d9c489079f48c/tests/testthat/test-CalcDARLEQ.R#L36) *style:* **Variable or function name should be snake_case.**
```r
  lookUpDARLEQ2 <- phytobenthosMetrics:::LookUpDARLEQ2
  ^~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:54:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/64bc1ea312edfa8f80dbda17bb5d9c489079f48c/tests/testthat/test-CalcDARLEQ.R#L54) *style:* **Variable or function name should be snake_case.**
```r
    riverAquaMetrics  <-  read.csv(system.file("extdata",
    ^~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:58:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/64bc1ea312edfa8f80dbda17bb5d9c489079f48c/tests/testthat/test-CalcDARLEQ.R#L58) *style:* **Variable or function name should be snake_case.**
```r
    lakesAquaMetrics  <-  read.csv(system.file("extdata",
    ^~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:63:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/64bc1ea312edfa8f80dbda17bb5d9c489079f48c/tests/testthat/test-CalcDARLEQ.R#L63) *style:* **Variable or function name should be snake_case.**
```r
    riverDARLEQRResults  <-  read.csv(system.file("extdata",
    ^~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:67:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/64bc1ea312edfa8f80dbda17bb5d9c489079f48c/tests/testthat/test-CalcDARLEQ.R#L67) *style:* **Variable or function name should be snake_case.**
```r
    lakesDARLEQRResults  <-  read.csv(system.file("extdata",
    ^~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:72:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/64bc1ea312edfa8f80dbda17bb5d9c489079f48c/tests/testthat/test-CalcDARLEQ.R#L72) *style:* **Variable or function name should be snake_case.**
```r
    riverAquaMetricsResults <- CalcDARLEQ(riverAquaMetrics, metric = "rivers")
    ^~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:73:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/64bc1ea312edfa8f80dbda17bb5d9c489079f48c/tests/testthat/test-CalcDARLEQ.R#L73) *style:* **Variable or function name should be snake_case.**
```r
    riverAquaMetricsResults <- data.frame(riverAquaMetricsResults[1])
    ^~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:75:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/64bc1ea312edfa8f80dbda17bb5d9c489079f48c/tests/testthat/test-CalcDARLEQ.R#L75) *style:* **Variable or function name should be snake_case.**
```r
    lakeAquaMetricsResults <- CalcDARLEQ(lakesAquaMetrics, metric = "lakes")
    ^~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:76:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/64bc1ea312edfa8f80dbda17bb5d9c489079f48c/tests/testthat/test-CalcDARLEQ.R#L76) *style:* **Variable or function name should be snake_case.**
```r
    lakeAquaMetricsResults <- data.frame(lakeAquaMetricsResults[1])
    ^~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-CalcDARLEQ.R:79:5:](https://github.com/aquaMetrics/phytobenthosMetrics/blob/64bc1ea312edfa8f80dbda17bb5d9c489079f48c/tests/testthat/test-CalcDARLEQ.R#L79) *style:* **Variable or function name should be snake_case.**
```r
    roundExcel <- function(x, n) {
    ^~~~~~~~~~
```


@markbubel likewise for this file. Though this wouldn't be a large change but the commit really messed up the page.


TeamCity Code :: 1. Development :: DDK :: Feature [Build 455](http://mp-ci.centralus.cloudapp.azure.com/viewLog.html?buildId=31490&buildTypeId=Code_Development_Ddk_Feature) outcome was **SUCCESS**
Summary: Tests passed: 64 Build time: 00:02:52


@mcsnetworks once I get everything working as its supposed to in 1.10.2, I will plan on releasing it for the other versions


Created multidev environment [natalie-sandbox#pr-universi](https://dashboard.pantheon.io/sites/ee1a9f88-1cc8-4eca-a8a6-7dc1433bb37e#pr-universi).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-universi-natalie-sandbox.pantheonsite.io/)


See my comment above about computation_output in local.py.


anyone know why this hasn't made it into master yet?


interesting, I originally started on 9.3 I believe. I am currently on 9.5, but it may be all those paths carried over somehow. I assumed they would not carry over though, since you have to reinitialize the service after upgrading between point releases.


add pseudo package

generally, avoid use of `you` and `your` in code comments.  We generally don't use those pronouns in other documentation either.


wow this is so clever!! :D 👍


ChestRunner actually is being tested here - the stash parsing uses those to determine the GearType. That said, it turns out the line I added isn't necessary (it's imported from Data.xml) so I'm undoing the change to ChestRunner; only the change to DaggerRunner is needed.


TeamCity Glyssen :: Glyssen pull requests [Build *.*.625.5c6cdd1cd54a7d1859c45dbe67edfb4b5204cca6](http://build.palaso.org/viewLog.html?buildId=97954&buildTypeId=Glyssen_GlyssenPullRequests) outcome was **SUCCESS**
Summary: Tests passed: 1728, ignored: 18 Build time: 00:10:49


Beyond1Airloop-Part2 (mjwitte) - Win64-Windows-7-VisualStudio-14: OK (2761 of 2767 tests passed, 523 test warnings)

Messages:

 * 529 tests had: BND diffs.
 * 90 tests had: AUD diffs.
 * 135 tests had: EIO diffs.
 * 6 tests had: Table big diffs.
 * 50 tests had: ESO small diffs.
 * 40 tests had: MTR small diffs.
 * 36 tests had: Table small diffs.
 * 4 tests had: ESO big diffs.
 * 3 tests had: ERR diffs.

Failures:

regression Test Summary
 * Passed: 600
 * Failed: 6

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.78%25-yellow.png)


what does this mean ? where is this `after_create` ?


Okay. I think I understand. The `ror()` instruction is circular rotation to the right, yes? I had to Google search that, and there will be a copy of it in my `Bytes` class. Looks like the original developers had some knowledge of cryptography (my knowledge is lacking, though).

I think I would implement it like this:
```C++
const std::string interiorBaseName; // Obtain from voxel ID.
const uint16_t doorID = (doorY << 8) + doorX;
const uint8_t doorValue = (Bytes::ror(doorID, 4) ^ doorID) & 0xFF;
const uint8_t mifID = (doorValue % 8) + 1;
const std::string mifName = interiorBaseName + std::to_string(mifID);
```

I assume the `interiorBaseName` would be inferred based on the voxel ID (given that it is a tavern block, etc.).


Yeah, that's a decent test. I will add it.


nice job, bit too "spacey"


I am new to Maven. Could you please include a guide to add this project to my project dependencies?


indentation! :)


indentation again :)


Yes, but they are not needed as all 10 masks start after the palette and follow each other.

If the click is in the menu entry rectangle, than its relative position is looked up in the bitmask, if the corresponding bit is set, the menu entry (here, a province) is selected. Bits in the bytes are tested from the most significant bit to last, so for High Rock there is a 57*11 byte bitmask at relative offset 0, for Hammerfell 62*12 at the relative offset 0xx273, etc.
So if the user clicked at (55,40), one should check the bit `7-(55-37)%8=5` in the byte `(40-32)*11+(55-37)/8=90` of the bitmasks data.


There is a method after_create in the Application class that create catalogs after the object is created.


district website


OMG, `Entity` inherits from `Object` from `dace.model.object`! I read (too fast) `object`, a bit confusing


I'm pretty sure that there is no "real initialization" in the zlib code.  Libpng predicts how big the zlib decoded buffer will be and mallocs space for it.  But if something goes wrong, as it does in the three fuzzed test files, zlib doesn't completely fill the buffer, leaving some of it uninitialized.  It looks to me as though oss-fuzz did detect that situation correctly.

OK I will not pursue making a libpng branch that includes zlib.  Where does the fuzzer get zlib now?  As far as I can tell it's using zlib-1.2.11.

May I get access to the zlib project results? (zlib is an essential part of libpng)


hi


ndabhona amagambo yalineza


Added Makarov


Please i18n from the start (if it is not too much work?)


> By the way, the source for the "converage" reports seems to be lagging
behind the GIT repo by a couple of weeks.

May I ask where you are seeing this lagging?

Our latest coverage report at https://oss-fuzz.com/coverage_report/fuzzer/libFuzzer_libpng_read_fuzzer/latest is pulling sources from 397c7eea385c22b6033e0310badfadbd9f578422 which seems to have been commited 2 days ago.


Created multidev environment [shlomko#pr-storm](https://dashboard.pantheon.io/sites/aa024b33-115f-4ca9-b30c-1994524fbf92#pr-storm).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-storm-shlomko.pantheonsite.io/)


Bluemix [toolchain](https://console.bluemix.net/devops/toolchains/ea66e1b3-f1ec-4993-8fcf-6787b7ced813 "InterfacePOCTest"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/57b50cba-d824-4c02-aa3b-c29cf770fffe "interface-test") deployed [interface-test](https://github.com/mildevops/interface-test/releases/tag/deploy-ibm-yp-us-south-mlabs50-deployment-20170921-175914 "deploy-ibm-yp-us-south-mlabs50-deployment-20170921-175914") to [deployment](https://console.bluemix.net/apps/81ff5aeb-b9ad-439f-91f7-6838ae776acf?env_id=ibm:yp:us-south "ibm:yp:us-south:mlabs50:deployment"), including this commit


Dear @Rysieku,
I am sorry to inform you that your submitted release, "RunAsConsole" (v1.4), for the project [RunasConsole-RAC](https://poggit.pmmp.io/ci/Rysieku/RunAsConsole/RunasConsole-RAC) on 2017-09-15 16:07:05 has been rejected.

Your [plugin.yml](https://github.com/Rysieku/RunAsConsole/blob/0f645c8722248e871170193e4fa034358ae4a9e4/plugin.yml#L12) permissions dose not follow PQRS [section 3](https://github.com/poggit/support/blob/master/pqrs.md#3-permissions) ```all permissions SHOULD inherit in the inheritance as its name. For example, the permission node named foo.bar should be the child permission of the permission node named foo```

Your plugin also wouldnt run on latest version due to your [hinttype](https://github.com/Rysieku/RunAsConsole/blob/0f645c8722248e871170193e4fa034358ae4a9e4/src/Rysieeku/RunAsConsole/Main.php#L31)

Minors:

I see no reason for this [line](https://github.com/Rysieku/RunAsConsole/blob/0f645c8722248e871170193e4fa034358ae4a9e4/src/Rysieeku/RunAsConsole/Main.php#L35) as there's nothing wrong to run as console even if it's on console

i see no reason for this [redundant permission check](https://github.com/Rysieku/RunAsConsole/blob/0f645c8722248e871170193e4fa034358ae4a9e4/src/Rysieeku/RunAsConsole/Main.php#L39) you should only check for permissions as forcefully checking for OP might break other server's setup (say giving OP but dont want to allow others to run as console normal way of using -perm.node in permissions manager wouldnt work due to this)

Please resolve the above-listed issues and submit the updated plugin again.


I'm not sure I see what's wrong. I just pulled your changes into my local working copy and the website seems to be fine.

Is there a specific error you're seeing while viewing the website or something Git is telling you?


I have a pull request in the ESPN FF API repo that will default to the latest week (see here https://github.com/dtcarls/ff_bot/issues/1) but this may be a good stop gap so I (and others that have deployed) don't need to manually update it each week.


We should throw an exception here instead of just printing a message.

```python
else:
    raise ValueError('Invalid value for computation_phase')
```


LocalNodeNetworkTry5 (XuanLuoLBL) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1558 of 1558 tests passed, 1 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-38.79%25-green.svg)


Indentation, and a bit too "spammy" here's a solution that fits the function agenda we are pursuing:

public class Checkerboard {

    public static void mainDraw(Graphics graphics){
      // fill the canvas with a checkerboard pattern.
        for (int i = 0; i < 17; i++) {
            for (int j = 0; j < 17; j++) {
                drawSquare(graphics, i, j);
            }
        }
        for (int i = 1; i < 17; i+=2) {
            for (int j = 1; j < 17; j+=2) {
                drawSquare2(graphics, i, j);
            }
        }
    }

    static void drawSquare(Graphics g1, int i, int j) {
            if (i % 2 == 0 && j % 2 == 0 ) {
                g1.setColor(Color.black);
                g1.fillRect(i * 20, j * 20, 20, 20);
            } else {
                g1.setColor(Color.red);
                g1.fillRect(i*20, j * 20, 20, 20);
            }
    }

    static void drawSquare2(Graphics g1, int i, int j) {
            g1.setColor(Color.black);
            g1.fillRect(i * 20, 20*j, 20, 20);


+missing empty line after the last block closing bracket ü but you usually do this so... 👍


@GuardianRM maybe it's best to restart the LTC test with the correct [0,4] bounds?


Bluemix [toolchain](https://console.bluemix.net/devops/toolchains/58986715-3eb6-496e-a30a-adc938e0efe4 "skyfall-blog-frontend"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/d6485d42-7d6d-446a-9ba3-cdc5c0fde25f "skyfall-blog-frontend-pepiline") deployed [gama_blog_frontend](https://github.com/gmreis/gama_blog_frontend/releases/tag/deploy-ibm-yp-us-south-reis.geraldomateus-blog-dev-20170921-180520 "deploy-ibm-yp-us-south-reis.geraldomateus-blog-dev-20170921-180520") to [blog-dev](https://console.bluemix.net/apps/69da4f52-6773-4eff-8120-bdc60a3dd865?env_id=ibm:yp:us-south "ibm:yp:us-south:reis.geraldomateus:blog-dev"), including this commit


Missing whitespaces around operator, but again, in other cases  it's okay 👍


Thanks for correcting!


Nice indentation maybe just a couple extra rows.


like here


Seems owner and group of the max_brightness cause that error. Found this now:

-rw-r--r-- 1 system system 4096 1970-01-17 01:05 brightness
-rw-rw-r-- 1 root   root   4096 2017-09-21 19:58 cabc
lrwxrwxrwx 1 root   root      0 2017-09-21 19:58 device -> ../../../leds-qpnp-24
-rw-r--r-- 1 system system 4096 1970-01-17 01:05 max_brightness
drwxr-xr-x 2 root   root      0 1970-01-17 01:05 power
-rw-rw-r-- 1 root   root   4096 2017-09-21 19:58 seg
lrwxrwxrwx 1 root   root      0 2017-09-21 19:58 subsystem -> ../../../../class/leds
-rw-r--r-- 1 root   root   4096 2017-09-21 19:58 trigger
-rw-r--r-- 1 root   root   4096 1970-01-17 01:05 uevent
amami:/ # ls -l /sys/class/leds/lcd-backlight/
ls -l /sys/class/leds/lcd-backlight/
total 0
-rw-r--r-- 1 system system 4096 1970-01-17 01:05 brightness
lrwxrwxrwx 1 root   root      0 2017-09-21 19:58 device -> ../../../qcom,mdss_fb_primary.170
-rw-r--r-- 1 root   root   4096 2017-09-21 19:58 max_brightness
drwxr-xr-x 2 root   root      0 1970-01-17 01:05 power
lrwxrwxrwx 1 root   root      0 2017-09-21 19:58 subsystem -> ../../../../../class/leds
-rw-r--r-- 1 root   root   4096 2017-09-21 19:58 trigger
-rw-r--r-- 1 root   root   4096 1970-01-17 01:05 uevent
amami:/ #


Lab 2 stuff


Nice, obvious naming on methods!


If I look at files in
https://oss-fuzz.com/coverage_report/job/libfuzzer_asan_libpng/latest
such as libpng_read_fuzzer.cc or png.c, the "last changed" info in comments
near the
top is August 24, libpng-1.6.32, while the GIT repo used for crash reports
is current (libpng-1.6.33).
I can't give you a link to those now because there are no current crashes.

Glenn


![](https://github.trello.services/images/mini-trello-icon.png) [Create RunRun project in Github](https://trello.com/c/xspnk4qD/1-create-runrun-project-in-github)


For some reason, I cant see all your commits.


sick commit


Well sorted code, comprehensible variables, following the Java Styleguide


Couple of extra empty lines


![](https://github.trello.services/images/mini-trello-icon.png) [Fix issue with the states not being found](https://trello.com/c/dzeNc9jj/2-fix-issue-with-the-states-not-being-found)


This bracket is lonely.


Same as the previous one. I can only see commits without any content by you.


Missing empty line maybe? 😄


I think it makes sense to have the week calculated or just fork their API. I think I have backstroke.us to keep your code in sync my fork of ff_bot. I then have that fork linked with Heroku so it should auto-deploy.

It looks like the cawdev/ff_bot fork is making a lot of progress with some features and functionality.


![](https://github.trello.services/images/mini-trello-icon.png) [finalize project as sample template for future games](https://trello.com/c/EgT9omN6/3-finalize-project-as-sample-template-for-future-games)


The base is getting better, keep up the good work!!!


Nice one


Created multidev environment [natalie-sandbox#pr-universi](https://dashboard.pantheon.io/sites/ee1a9f88-1cc8-4eca-a8a6-7dc1433bb37e#pr-universi).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-universi-natalie-sandbox.pantheonsite.io/)


[R/config.R:144:4:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/config.R#L144) *style:* **Commented code should be removed.**
```r
  ## create a new config file in '_config/_config.yml'
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/generator.R:123:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/generator.R#L123) *style:* **Lines should not be more than 100 characters.**
```r
#' @param layout    Tibble with layout metadata. Tibble format: tabName, menuItemName, icon, moduleName.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:287:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L287) *style:* **Lines should not be more than 100 characters.**
```r
        p("This module imports several MPB climate suitability scenarios (using four different indices: `S`, `L`, `R`, `G`) for use as model drivers.",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:289:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L289) *style:* **Lines should not be more than 100 characters.**
```r
          "The Regniere suitability index (`R`) is based on MPB cold tolerance (i.e., winter survival) (Regniere et al. 2007).",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:290:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L290) *style:* **Lines should not be more than 100 characters.**
```r
          "The Safranyik suitability index (`S`) is based on aspects of both summer temperatures and winter survival (Safranyik et al. 1975).",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:291:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L291) *style:* **Lines should not be more than 100 characters.**
```r
          "Finally, the composite SLR index (`G`) takes the geometric mean of the `S`, `L`, and `R` models.",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:292:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L292) *style:* **Lines should not be more than 100 characters.**
```r
          "These are described in further detail in Nealis et al. (2008 and 2014) and in their respective publications cited above."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:293:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L293) *style:* **Lines should not be more than 100 characters.**
```r
        p("BioSim was used to generate the maps (see Bentz et al. 2010; Logan et al. 2003; Safranyik et al. 2010)."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:296:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L296) *style:* **Lines should not be more than 100 characters.**
```r
        p("Bentz, B J, J R\u00e9gni\u00e8re, C J Fettig, E M Hansen, J L Hayes, J A Hicke, R. G. Kelsey, J. F. Negr\u00f3n, and S. J. Seybold. 2010. \"Climate Change and Bark Beetles of the Western United States and Canada: Direct and Indirect Effects.\" BioScience 60(8):602-13. doi:10.1525/bio.2010.60.8.6."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:297:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L297) *style:* **Lines should not be more than 100 characters.**
```r
        p("Logan, Jesse A, Jacques R\u00e9gni\u00e8re, and James A Powell. 2003. \"Assessing the impacts of global warming on forest pest dynamics.\" Frontiers in Ecology and the Environment 1(3):130-37. doi:10.1890/1540-9295(2003)001[0130:ATIOGW]2.0.CO;2."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:298:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L298) *style:* **Lines should not be more than 100 characters.**
```r
        p("Nealis, Vince G, and Barry J Cooke. 2014. \"Risk assessment of the threat of mountain pine beetle to Canada's boreal and eastern pine forests.\" Ottawa, ON: Canadian Council of Forest Ministers. http://cfs.nrcan.gc.ca/publications?id=35406."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:299:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L299) *style:* **Lines should not be more than 100 characters.**
```r
        p("Nealis, Vince G, and Brian Peter. 2008. \"Risk assessment of the threat of mountain pine beetle to Canada's boreal and eastern pine forests.\" Infromation Report. Victoria, BC: Natural Resources Canada, Canadian Forest Service, Pacific Forestry Centre."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:300:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L300) *style:* **Lines should not be more than 100 characters.**
```r
        p("R\u00e9gni\u00e8re, Jacques, and Barbara Bentz. 2007. \"Modeling cold tolerance in the mountain pine beetle, Dendroctonus ponderosae.\" Journal of Insect Physiology 53(6): 559-72. doi:10.1016/j.jinsphys.2007.02.007."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:301:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L301) *style:* **Lines should not be more than 100 characters.**
```r
        p("Safranyik, Les, Allan L Carroll, Jacques R\u00e9gni\u00e8re, David W Langor, William G Riel, Terry L Shore, Brian Peter, Barry J Cooke, Vince G Nealis, and Stephen W Taylor. 2010. \"Potential for range expansion of mountain pine beetle into the boreal forest of North America.\" The Canadian Entomologist 142(5):415-42. doi:10.4039/n08-CPA01."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:302:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L302) *style:* **Lines should not be more than 100 characters.**
```r
        p("Safranyik, L.; Shrimpton, D.M.; Whitney, H.S. 1975. \"An interpretation of the interaction between lodgepole pine, the mountain pine beetle, and its associated blue stain fungi in western Canada.\" In Management of Lodgepole Pine Ecosystems Symposium Proceedings, edited by D M Baumgartner, 406-28. Pullman, WA: Washington State University Coop. Extension Service. http://wfiwc.org/sites/default/files/Safranyik_Shrimpton_Whitney_1975.pdf.")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:307:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L307) *style:* **Lines should not be more than 100 characters.**
```r
        p("MPB aerial survey data for BC and AB are provided by those provinces as point and polygon data."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:308:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L308) *style:* **Lines should not be more than 100 characters.**
```r
        p("Cooke & Carroll (in press) describes the methodology by which MPB attack data for AB (derived from spatial points) and BC (derived from polygons) have been rasterized and merged into a single `RasterLayer`:"),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:309:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L309) *style:* **Lines should not be more than 100 characters.**
```r
        tags$blockquote("To provide an unbiased perspective on MPB damage in the two provinces, the two data sets were rasterized to a common resolution, allowing impact to be expressed in common units (hectares attacked per 4 km2 cell).",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:310:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L310) *style:* **Lines should not be more than 100 characters.**
```r
                        "For BC data, raster cells were weighted according to polygon-wide average infestation rates and areas calculated from the proportion of a polygon infested within each raster cell, assuming an average stem density of 1125 mature stems per hectare, which is typical for beetle-prone lodgepole pine stands (Whitehead and Russo, 2005).",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:311:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L311) *style:* **Lines should not be more than 100 characters.**
```r
                        "Data were weighted and calculated for each year in the sequence, and then summed. For Alberta data, the number of attacked trees per point attack cluster was determined from provincial government records, based on a ground survey, and summed across years within each 4 km2 raster cell."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:312:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L312) *style:* **Lines should not be more than 100 characters.**
```r
        p("NOTE: We produced finer-resolusion rasters (250m x 250m) to match the resolution of the kNN pine maps."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:313:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L313) *style:* **Lines should not be more than 100 characters.**
```r
        p("NOTE: currently, only the data up to and including 2011 are being used, as more recent data for BC have not yet been acquired (we have AB aerial survey data up to and including 2016)."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:316:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L316) *style:* **Lines should not be more than 100 characters.**
```r
        p("Cooke, Barry J, and Allan L Carroll. in press. \"The risk of mountain pine beetle spread to eastern pine forests: what can we predict?\""),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:317:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L317) *style:* **Lines should not be more than 100 characters.**
```r
        p("Whitehead, R J, Russo, G L. 2005. \"\'Beetle-proofed\' lodgepole pine stands in interior British Columbia have less damage from mountain pine beetle\". Info. Rep. No. BC-X-402. Natural Resources Canada, Canadian Forest Service, Pacific Forestry Centre, Victoria, B.C.")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:322:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L322) *style:* **Lines should not be more than 100 characters.**
```r
        p("Beaudoin et al. (2014) produced estimates of percent cover for several major tree species across Canada, including lodgepole pine and jack pine, at 250m resolution.",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:323:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L323) *style:* **Lines should not be more than 100 characters.**
```r
          "These estimates are used to provide a base map of the proportion pine available to MPB in each pixel."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:326:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/simInfo.R#L326) *style:* **Lines should not be more than 100 characters.**
```r
        p("Beaudoin, A, P Y Bernier, L Guindon, P Villemaire, X J Guo, G Stinson, T Bergeron, S Magnussen, and R J Hall. 2014. \"Mapping attributes of Canada's forests at moderate resolution through kNN and MODIS imagery.\" Canadian Journal of Forest Research 44: 521-32. doi:10.1139/cjfr-2013-0401.")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/tilesUpdater.R:46:5:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/tilesUpdater.R#L46) *style:* **Variable and function names should not be longer than 30 characters.**
```r
    addLayersControlParametersCombined <- c(
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/timeSinceFire.R:135:5:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/timeSinceFire.R#L135) *style:* **Variable or function name should be lowerCamelCase.**
```r
    Nbreaks <- ceiling(maxValue(ras1) / 10)
    ^~~~~~~
```
[R/timeSinceFire.R:192:33:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/timeSinceFire.R#L192) *style:* **Commas should always have a space after.**
```r
    sp <- SpatialPoints(cbind(x,y), proj4string = crs(pol))
                                ^
```
[R/timeSinceFire.R:216:69:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/timeSinceFire.R#L216) *style:* **Commas should always have a space after.**
```r
                      polygonIndivIdsColum[[colNam]], ": ", polyVal,"<br>",
                                                                    ^
```
[R/timeSinceFire.R:218:49:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/timeSinceFire.R#L218) *style:* **Commas should always have a space after.**
```r
                      "Lat/Long: ", round(y, 4),", ", round(x, 4))
                                                ^
```
[R/timeSinceFire.R:220:13:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/ee1eb1f448e07ba2915da6d0c2260a8ddb9b245a/R/timeSinceFire.R#L220) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
    proxy %>% clearPopups() %>% addPopups(x, y, popup = content)
          ~~^
```


Line 665 of src/services/keycloak.core.service.ts

```
if (!configuration) {
         configUrl = 'keycloak.json';
} else if (typeof configuration === 'string') {
        configUrl = this.config;
}

```
In the else-if block, did you perhaps intend to set ``configUrl = configuration`` if the precondition was met?  The previous code assigned the same value, but also tested whether this.config was a string in its conditional.


use .gitignore please, commit more often


removed because it's not an issue


added description


![](https://github.trello.services/images/mini-trello-icon.png) [NFR22](https://trello.com/c/3zAIAR8T/29-nfr22)


TeamCity Code :: 1. Development :: DDK :: Feature [Build 456](http://mp-ci.centralus.cloudapp.azure.com/viewLog.html?buildId=31497&buildTypeId=Code_Development_Ddk_Feature) is now running


What all versions of Kafka supported by this app ?


TeamCity Code :: 1. Development :: DDK :: Feature [Build 456](http://mp-ci.centralus.cloudapp.azure.com/viewLog.html?buildId=31497&buildTypeId=Code_Development_Ddk_Feature) outcome was **SUCCESS**
Summary: Tests passed: 64 Build time: 00:01:28


Bluemix [toolchain](https://console.bluemix.net/devops/toolchains/af947d52-1356-4d0f-a9d9-8bcc12ce76cf "simple-toolchain-20170921133759548"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/b5890fa7-545b-4025-97a1-7330848e5801 "simple-toolchain-20170921133759548") deployed [simple-toolchain-20170921133759548](https://github.com/wlad267/simple-toolchain-20170921133759548/releases/tag/deploy-ibm-yp-us-south-stefan.ghita-ro.ibm.com-dev2-20170921-181558 "deploy-ibm-yp-us-south-stefan.ghita-ro.ibm.com-dev2-20170921-181558") to [dev2](https://console.bluemix.net/apps/86b83c15-86fd-4732-aabf-c8032048fbeb?env_id=ibm:yp:us-south "ibm:yp:us-south:stefan.ghita@ro.ibm.com:dev2"), including this commit


This is a digit count. The excersise was to add the separated digits value, so 126 supposed to return 1 + 2 + 6 = **9**


But this is just for showing the chart code. Is there a better way to do that? I check permissions for the whole action in a before_action callback, but to see the chart code a user must pass that check *and* be medical or dev.


No downloads?


hello:) this regex matches strings that begin with a capital letter from A to I and then contain "anything" after.  i don't think you need this here :D

since it doesn't match any part of your test string, the condition will always be false, plus you don't use the pre variable anywhere, but you don't really need it either!

the base case is perfect, try building up what you return at the end using the 2 substrings you have :)


VAVDesignMinFlow6327 (mjwitte) - i386-Windows-7-VisualStudio-14: OK (2764 of 2767 tests passed, 0 test warnings)

Failures:

EnergyPlusFixture Test Summary
 * Passed: 534
 * Failed: 3

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.89%25-yellow.png)


LocalNodeNetworkTry5 (XuanLuoLBL) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2799 of 2814 tests passed, 1 test warnings)

 * 14 tests had: AUD diffs.
 * 13 tests had: BND diffs.
 * 1 test had: ESO small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.47%25-yellow.svg)


@Baycken as you had the quotation problem, could you please try out whether this version still breaks?
@MrPointer as you contributed the whole new example system among other major improvements, would you be so kind to test whether I broke something during merging?
@Souler and could you please validate the AESLib assembly still compiles (assembles?) with after updating to this commit?


i think this is perfect ^^


[R/config.R:144:4:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/config.R#L144) *style:* **Commented code should be removed.**
```r
  ## create a new config file in '_config/_config.yml'
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/generator.R:123:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/generator.R#L123) *style:* **Lines should not be more than 100 characters.**
```r
#' @param layout    Tibble with layout metadata. Tibble format: tabName, menuItemName, icon, moduleName.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:287:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L287) *style:* **Lines should not be more than 100 characters.**
```r
        p("This module imports several MPB climate suitability scenarios (using four different indices: `S`, `L`, `R`, `G`) for use as model drivers.",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:289:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L289) *style:* **Lines should not be more than 100 characters.**
```r
          "The Regniere suitability index (`R`) is based on MPB cold tolerance (i.e., winter survival) (Regniere et al. 2007).",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:290:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L290) *style:* **Lines should not be more than 100 characters.**
```r
          "The Safranyik suitability index (`S`) is based on aspects of both summer temperatures and winter survival (Safranyik et al. 1975).",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:291:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L291) *style:* **Lines should not be more than 100 characters.**
```r
          "Finally, the composite SLR index (`G`) takes the geometric mean of the `S`, `L`, and `R` models.",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:292:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L292) *style:* **Lines should not be more than 100 characters.**
```r
          "These are described in further detail in Nealis et al. (2008 and 2014) and in their respective publications cited above."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:293:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L293) *style:* **Lines should not be more than 100 characters.**
```r
        p("BioSim was used to generate the maps (see Bentz et al. 2010; Logan et al. 2003; Safranyik et al. 2010)."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:296:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L296) *style:* **Lines should not be more than 100 characters.**
```r
        p("Bentz, B J, J R\u00e9gni\u00e8re, C J Fettig, E M Hansen, J L Hayes, J A Hicke, R. G. Kelsey, J. F. Negr\u00f3n, and S. J. Seybold. 2010. \"Climate Change and Bark Beetles of the Western United States and Canada: Direct and Indirect Effects.\" BioScience 60(8):602-13. doi:10.1525/bio.2010.60.8.6."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:297:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L297) *style:* **Lines should not be more than 100 characters.**
```r
        p("Logan, Jesse A, Jacques R\u00e9gni\u00e8re, and James A Powell. 2003. \"Assessing the impacts of global warming on forest pest dynamics.\" Frontiers in Ecology and the Environment 1(3):130-37. doi:10.1890/1540-9295(2003)001[0130:ATIOGW]2.0.CO;2."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:298:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L298) *style:* **Lines should not be more than 100 characters.**
```r
        p("Nealis, Vince G, and Barry J Cooke. 2014. \"Risk assessment of the threat of mountain pine beetle to Canada's boreal and eastern pine forests.\" Ottawa, ON: Canadian Council of Forest Ministers. http://cfs.nrcan.gc.ca/publications?id=35406."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:299:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L299) *style:* **Lines should not be more than 100 characters.**
```r
        p("Nealis, Vince G, and Brian Peter. 2008. \"Risk assessment of the threat of mountain pine beetle to Canada's boreal and eastern pine forests.\" Infromation Report. Victoria, BC: Natural Resources Canada, Canadian Forest Service, Pacific Forestry Centre."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:300:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L300) *style:* **Lines should not be more than 100 characters.**
```r
        p("R\u00e9gni\u00e8re, Jacques, and Barbara Bentz. 2007. \"Modeling cold tolerance in the mountain pine beetle, Dendroctonus ponderosae.\" Journal of Insect Physiology 53(6): 559-72. doi:10.1016/j.jinsphys.2007.02.007."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:301:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L301) *style:* **Lines should not be more than 100 characters.**
```r
        p("Safranyik, Les, Allan L Carroll, Jacques R\u00e9gni\u00e8re, David W Langor, William G Riel, Terry L Shore, Brian Peter, Barry J Cooke, Vince G Nealis, and Stephen W Taylor. 2010. \"Potential for range expansion of mountain pine beetle into the boreal forest of North America.\" The Canadian Entomologist 142(5):415-42. doi:10.4039/n08-CPA01."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:302:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L302) *style:* **Lines should not be more than 100 characters.**
```r
        p("Safranyik, L.; Shrimpton, D.M.; Whitney, H.S. 1975. \"An interpretation of the interaction between lodgepole pine, the mountain pine beetle, and its associated blue stain fungi in western Canada.\" In Management of Lodgepole Pine Ecosystems Symposium Proceedings, edited by D M Baumgartner, 406-28. Pullman, WA: Washington State University Coop. Extension Service. http://wfiwc.org/sites/default/files/Safranyik_Shrimpton_Whitney_1975.pdf.")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:307:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L307) *style:* **Lines should not be more than 100 characters.**
```r
        p("MPB aerial survey data for BC and AB are provided by those provinces as point and polygon data."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:308:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L308) *style:* **Lines should not be more than 100 characters.**
```r
        p("Cooke & Carroll (in press) describes the methodology by which MPB attack data for AB (derived from spatial points) and BC (derived from polygons) have been rasterized and merged into a single `RasterLayer`:"),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:309:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L309) *style:* **Lines should not be more than 100 characters.**
```r
        tags$blockquote("To provide an unbiased perspective on MPB damage in the two provinces, the two data sets were rasterized to a common resolution, allowing impact to be expressed in common units (hectares attacked per 4 km2 cell).",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:310:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L310) *style:* **Lines should not be more than 100 characters.**
```r
                        "For BC data, raster cells were weighted according to polygon-wide average infestation rates and areas calculated from the proportion of a polygon infested within each raster cell, assuming an average stem density of 1125 mature stems per hectare, which is typical for beetle-prone lodgepole pine stands (Whitehead and Russo, 2005).",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:311:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L311) *style:* **Lines should not be more than 100 characters.**
```r
                        "Data were weighted and calculated for each year in the sequence, and then summed. For Alberta data, the number of attacked trees per point attack cluster was determined from provincial government records, based on a ground survey, and summed across years within each 4 km2 raster cell."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:312:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L312) *style:* **Lines should not be more than 100 characters.**
```r
        p("NOTE: We produced finer-resolusion rasters (250m x 250m) to match the resolution of the kNN pine maps."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:313:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L313) *style:* **Lines should not be more than 100 characters.**
```r
        p("NOTE: currently, only the data up to and including 2011 are being used, as more recent data for BC have not yet been acquired (we have AB aerial survey data up to and including 2016)."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:316:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L316) *style:* **Lines should not be more than 100 characters.**
```r
        p("Cooke, Barry J, and Allan L Carroll. in press. \"The risk of mountain pine beetle spread to eastern pine forests: what can we predict?\""),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:317:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L317) *style:* **Lines should not be more than 100 characters.**
```r
        p("Whitehead, R J, Russo, G L. 2005. \"\'Beetle-proofed\' lodgepole pine stands in interior British Columbia have less damage from mountain pine beetle\". Info. Rep. No. BC-X-402. Natural Resources Canada, Canadian Forest Service, Pacific Forestry Centre, Victoria, B.C.")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:322:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L322) *style:* **Lines should not be more than 100 characters.**
```r
        p("Beaudoin et al. (2014) produced estimates of percent cover for several major tree species across Canada, including lodgepole pine and jack pine, at 250m resolution.",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:323:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L323) *style:* **Lines should not be more than 100 characters.**
```r
          "These estimates are used to provide a base map of the proportion pine available to MPB in each pixel."),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simInfo.R:326:1:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/simInfo.R#L326) *style:* **Lines should not be more than 100 characters.**
```r
        p("Beaudoin, A, P Y Bernier, L Guindon, P Villemaire, X J Guo, G Stinson, T Bergeron, S Magnussen, and R J Hall. 2014. \"Mapping attributes of Canada's forests at moderate resolution through kNN and MODIS imagery.\" Canadian Journal of Forest Research 44: 521-32. doi:10.1139/cjfr-2013-0401.")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/tilesUpdater.R:46:5:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/tilesUpdater.R#L46) *style:* **Variable and function names should not be longer than 30 characters.**
```r
    addLayersControlParametersCombined <- c(
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/timeSinceFire.R:135:5:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/timeSinceFire.R#L135) *style:* **Variable or function name should be lowerCamelCase.**
```r
    Nbreaks <- ceiling(maxValue(ras1) / 10)
    ^~~~~~~
```
[R/timeSinceFire.R:192:33:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/timeSinceFire.R#L192) *style:* **Commas should always have a space after.**
```r
    sp <- SpatialPoints(cbind(x,y), proj4string = crs(pol))
                                ^
```
[R/timeSinceFire.R:216:69:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/timeSinceFire.R#L216) *style:* **Commas should always have a space after.**
```r
                      polygonIndivIdsColum[[colNam]], ": ", polyVal,"<br>",
                                                                    ^
```
[R/timeSinceFire.R:218:49:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/timeSinceFire.R#L218) *style:* **Commas should always have a space after.**
```r
                      "Lat/Long: ", round(y, 4),", ", round(x, 4))
                                                ^
```
[R/timeSinceFire.R:220:13:](https://github.com/PredictiveEcology/SpaDES.shiny/blob/643188bb2a95e7a4284009bdb724c795d2219acd/R/timeSinceFire.R#L220) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
    proxy %>% clearPopups() %>% addPopups(x, y, popup = content)
          ~~^
```


LocalNodeNetworkTry5 (XuanLuoLBL) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Nice and clean :)


About the name, I think I can see how you arrived at this spelling - it is `OpenSSL Error Stack`, minus the spaces, with the leading character lower-cased. That's reasonable. However, I think `opensslErrorStack` would make slightly more sense, for consistency with the only other place (that I have found) that "openssl" in any case-variant shows up in the node API: `process.versions.openssl`. There are also CLI and configure flags, but since they lower-case everything, that isn't a precedent. This is a small thing, but as someone with a terrible memory, predictable spelling helps me a lot.  What do other people think?


I'm not crazy about making `struct parahotplug_request *req` more global, but I can live with it.


Hmm I may be missing something here then. Would you be able to give me a
call to help me understand what you mean exactly?

My number is 801-949-5782

On Sep 21, 2017 11:34 AM, "Isaac Sloan" <notifications@github.com> wrote:

Again this boils down to access all: :all.

All of the access should be limited here per role instead of in the actions.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/IanEarley/IanEarley-rails-competency-test/commit/e3de727e99dfb912fede8de5e0a8c2be9f2ee8db#commitcomment-24466979>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AbyAKWNxEApqYbpRd6jpi1OFyRptT9knks5skp4NgaJpZM4Pe62l>
.


Looks good.  You might want to mention it in the read me as well. So people are aware it exists.


Fix onCompleteRender (#1592)

Preview: documentation
Coverage: core | datetime


I really like the way you solved these :) Good work man!!!


Cool but Aze said just yesterday, (and today to me, again, on this same exercise), that a sout shouldn't be used from the inside of the function..


Ща бы забирать респонсобилити с языка и вручную парсить значения


I would love to help and improve your code but its pretty perfect can't really add anything :/


Great to see you used so many different types of form fields!


👍 to `required` attribute


Выпендрежник
Ты же понимаешь, что ты теперь ты будет просто банально умножать все числа? Сколько бы их не было через пробел в StdIn. Нарушил тз


Great to see you using the `vh/vw` units!


Just a thought. You are currently supporting from 5.3. No real need. Have a look at php version usage. You could move to 5.6 minimum with a major version BC break and leave V 1 for those who need it.


i think this is perfect 👍


Glad we found this for you!


I think the problem was that I did not roxygenize the package after I added
the newline (the .Rd file had not been updated with the change). I think it
probably doesn't need the space but I added one anyway. It's fixed now on
the website.

-John

On Wed, Sep 20, 2017 at 10:23 PM, Nathan Sheffield <notifications@github.com
> wrote:

> Are you sure this fixes it? I just regenerated the documentation and it
> looks the same. Do you need a space there? There is a space on the
> corresponding lines on other spots I checked.
>
> After you fix this can you regenerate the pkgdown page? there are
> instructions on how to do it in the readme of that repository.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/databio/MIRA/commit/c1edeee67b91bcaa93ff2feaaff0d0d1edd179c4#commitcomment-24448561>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AVRSxrxi5ZvVz5bAmY-V2CKdFGCWoXp0ks5skcilgaJpZM4Petvz>
> .
>


Nice work incorporating the carousel into your project.  Hopefully, you are happier with the final product now that we've ironed out some of those last remaining kinks!


I would consider switching to to 2GB. Then we at least can handle the same traces as the server itself.


```eval``` 🤦♂🤦♂🤦♂
Опять нарушил тз, кстати


**shopplistid**


![](https://github.trello.services/images/mini-trello-icon.png) [[iOS] [Tidepool Mobile] UI Bug: When day changes, "Today" and "Yesterday" time strings are out of date](https://trello.com/c/ozQwoeIu/84-ios-tidepool-mobile-ui-bug-when-day-changes-today-and-yesterday-time-strings-are-out-of-date)


One reminder is to have consistancy with class/id names in terms of if you write them like `firstSecond` or `first-second` 😄


![](https://github.trello.services/images/mini-trello-icon.png) [[iOS] [Tidepool Mobile] UI Bug: When a new note is added, usually any Dexcom events are back 3 hours, and user is not allowed to scroll back to them](https://trello.com/c/3yWQcu7o/85-ios-tidepool-mobile-ui-bug-when-a-new-note-is-added-usually-any-dexcom-events-are-back-3-hours-and-user-is-not-allowed-to-scroll)


Created multidev environment [natalie-sandbox#ci-17](https://dashboard.pantheon.io/sites/ee1a9f88-1cc8-4eca-a8a6-7dc1433bb37e#ci-17).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-17-natalie-sandbox.pantheonsite.io/)


I'm new on github so sorry if there is an obvious answer to this. Does this mean that this fix will be in the next release of Cura? And is there an estimated release date?
Is there a way for me to implement this change now on the installed Cura 2.7 on my computer?
This is very much needed on one of my printers.


![](https://github.trello.services/images/mini-trello-icon.png) [[iOS] [Tidepool Mobile] Update graphs if appropriate on upload of new local bg samples](https://trello.com/c/BYLf9TxZ/90-ios-tidepool-mobile-update-graphs-if-appropriate-on-upload-of-new-local-bg-samples)


Done


Great stuff working through the effects that you wanted!


Indentation is nice, the code is easily readable.


Great job incorporating both grid and flex into your final project! 💯


Ну нафига ты делаешь? 🤦♂🤦♂🤦♂


LocalNodeNetworkTry5 (XuanLuoLBL) - x86_64-MacOS-10.9-clang: OK (2774 of 2774 tests passed, 15 test warnings)

Messages:

 * 14 tests had: AUD diffs.
 * 13 tests had: BND diffs.
 * 1 test had: ESO small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


Got it, thanks. I'll be making a fix for this issue shortly.


Change the folder path/to to code by using code blocks (i.e. a single \` backtick before and after) like this:

```
`wp-content/mu-plugins`
```

which will display then as:

`wp-content/mu-plugins`


Bluemix [toolchain](https://console.bluemix.net/devops/toolchains/6b8b7163-1ec8-4616-82fa-aa467a17af03 "storybook-toolchain-v2"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/b84aaac8-8484-4a1e-902a-ebb526eb7998 "storybook-toolchain-v2") deployed [carbon-components-react](https://github.com/carbon-design-system/carbon-components-react/releases/tag/deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170921-183102 "deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170921-183102") to [Bluemix Design System](https://console.bluemix.net/apps/3d620683-f4db-4002-9670-b38a990f67a3?env_id=ibm:yp:us-south "ibm:yp:us-south:chrisdhanaraj_org:Bluemix Design System"), including this commit


I was able to test it out on FreeBSD 12 and can confirm the history test still fails there, so we're good.


Ахахаха, неверных ответов не будет, если не давать пользователю играть, пока не будет введен правильный ответ)


You want to wrap your code in backticks instead of single quotations.

For the URI, use the SSH on instead of the HTTPS.


Nicely commented


zookeeper configuration file for master1


Well, it was not the final commit, as seen in the history.


Имхо, разделять вопросы и ответы - плохая идея. Тебе же, чтобы изменить вопрос, надо:
0) Изменить вопрос
1) Найти его номер
2) Переместиться в коллекцию с ответами
3) Перейти к этому же номеру
4) Изменить ответ
Сложна


I found a curly bracket here without space :) rather than that everything looks perfect.


but that would mean, overwrite it when laststatus has been set explicitly to zero, while the default won't be changed. I don't agree with this logic.


This Zip contains all files.


This code is actually the same as in the commit before. Honestly spoken, I do not really know what the goal of this commit was.


This commit just removes some of the automatically created content of `create-react-app` and sets up a basic `Hello` text.


Change the folder path/to to code by using code blocks (i.e. a single ` backtick before and after) like this:
```
`wp-content/plugins/gallery`
```
which will display then as:

`wp-content/plugins/gallery`

Then repeat for the other folder mu-plugins.

## Gulp, Node, npm

These are doing anything in this plugin.  Right?  Therefore, you can remove these.


I think we can omit `and portable` here.


Okay !
And domain buttons par unke naam hai... Aur ye hardcoded nahi hai... database se fetch ho ke aa rhe hai.


Depending on when the post is published, this can become "this week" :)


Thats odd. When I synced my commit and viewed the changes on the chatbot site I saw a paragraph worth of code on the main site where the header and body was.


Is Dotty officially referred to as Scala 3.x?


I think the word `core` here is redundant.


This plugin doesn't require asset optimization.  Therefore, Gulp and the associated node modules are not being used.  You can remove it from the repository.


I suggest we omit `def`.


Make sure PHP files end with an empty line.


Doesn't an empty string meet this condition?


OMG


Updated RH Research link


`in Dotty` is not quite precise here. We decided to retire the current macros in Scala - regardless of whether it's Scala 2.x or Scala 3.x.


You can create a styled version of any HTML/SVG element with this template literal. Inside the literal you can write CSS.


Yes. I commented the code out here because when I was downloading all the wheels from different platforms, I had to specify the platform, abi, python version and implementation. Then with that `Command Error`, I had to add `--only-binary=:all:` too. But `cryptography` contains `pycparser`, which is not a binary file. If I restrict pip to only download binary files, then `pycparser` will not be downloaded. That's why I commented the if statement out. But I'm not sure if this is the best way to handle this case. Do you have any suggestions on this? Thank you!


This `gulpfile.js` file is not being used in this project.  There is no Sass or scripts.  Therefore, just remove it.


Taking my previous examples in the near past, it s good to have a glance at https://google.github.io/styleguide/javaguide.html :)


This file is not needed, as this plugin has no asset optimization or task requirements.  Go ahead and remove it.


@grumpysi: this lib may be useful for what you needed the other day.


Since this post comes from the Scala Center, `we` can be misleading. I'd propose `Eugene Burmako and his team have been working` (with the link to my PhD for full credits).


PHP files should end with an empty space.


nice and clean/cut method :)


As the height of an element depends on its children we need to set it to center on the viewport.


Simple, understandable and it works.


This commit uses styled components to center our content.


Not sure whether we can get away with this. There's no "scala.reflect macros" at the moment. There's just "scala macros".


Remove the `()` for the `include`:

```
include __DIR__ . '/' . $file;
```


Ну вот когда в модуле есть и инстанс, и класс методы, то принято разносить по модулям. При взгляде на такой модуль все сразу понятно, не приходится задумываться "А куда попадут эти методы?"


The JSX markup can use elements that are in scope.


Intellij


the recommendation?


This commit creates a custom react component.


I think this paragraph should be in a new section.


This line and the next are unnecessary.  Why?  Both lines 2 and  6 are PHP.


how to start the server? pls help me


I guess it doesn't. JS.


Тут всего один метод класса, лаконичнее через `self.included` записать


Remove the `()` for the `include`.


Good execution, the size and the starting point is easily changeable.


The closing `?>` is unnecessary.  Go ahead and remove it.


We define `BarChart`, a `PureComponent`. A `PureComponent` only updates if one of its attributes (called `props`) or its `state` changes. More on that later.


Should the `dbFile` be hard-coded.  The config path is `database.connection.filename`, but we aren't respecting `filename` at all here.  The user configured `filename` value is just being ignored and instead `ghost.db` or `ghost-dev.db` is always used instead.


Be consistent with your code style.  Remove the 2 extra empty lines, i.e. line 39 and 49.


VAVDesignMinFlow6327 (mjwitte) - Win64-Windows-7-VisualStudio-14: OK (2762 of 2767 tests passed, 0 test warnings)

Messages:

 * 2 tests had: EIO diffs.
 * 2 tests had: Table big diffs.

Failures:

EnergyPlusFixture Test Summary
 * Passed: 534
 * Failed: 3

regression Test Summary
 * Passed: 604
 * Failed: 2

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.82%25-yellow.png)


Код страшненько выглядит. Создай методы для доступа к переменной и используй их


yup, JS :(


Код не относящийся к курсу лучше держать в отдельном репозитории


Be consistent with your code style.  A function's DocBlock should be just above the function declaration, with no empty space in between.


cc @darko-mijic


It is working fine


Attributes (called `props`) can be any javascript expression. Note that the attribute `width` is different from the CSS style `width` defined above. The attribute `width` defines the width of the `svg` coordinate system whereas the CSS style `width` defines the *visual* width of the element (that's why a unit is needed).


Ну и зачем это условие? Если массив не пустой, значит его длина всяко больше 0


An import starting with `.` is resolved relative to the current file.


Не надо пробелы перед скобками ставить


Еще отмечу, что в `find` не надо аргументов передавать, если элемент не найден итак `nil` вернется


poor demo keeps trying to shake it but nobody wanted ot see it, can't get no love


I tried to go through this site to make it much clearer: https://google.github.io/styleguide/javaguide.html


Reverted by 5084cddb6e2db764f4498266609c3ef179614876


I like the way you solved this problem, very clean and tidy.


Needs a space between n and = in line 5, but otherwise really good job.


That's a view thing. There's no access check on this action as a whole at the moment, actually (or rather there is, but it's integrated into the action when it should be split out into a before_action). Checking for showing the chart code is a view check.


`$ heroku stack:set heroku-16 -a <app name>`


This is my solution for this exe:
 public static int countingRecursion(int n) {

        if (n < 10) {
            return n;
        } else {
            return n%10 + countingRecursion(n/10);
        }
    }


Your plugin _automatically enqueues_ the assets. However, what if the developer wants to incorporate the asset requirements into the theme to minimize the number of HTTP requests?  Hmm, how can we give him/her that option?

1. Option 1: You can write documentation to alert the developer to `remove_action`, which would disable the plugin's enqueuing.
2. Option 2: Build an interface in the backend and then let the developer set if s/he wants to have the plugin enqueue or not.
3. Option 3: Make the assets configurable by passing them through a filter and then doing the enqueue process.  You'd want to write instructions to alert the developer about the configurable filter:

```
$assets_to_enqueue = apply_filters('gallery_assets_to_load', array( 'gallery_style', 'dashicons', 'font-awesome' ) );

// then handle it here
```

You'll need to decide how you want to handle it.  I prefer option 3.


#6320-Some-_ExternalInterface--test-files-not-transitioned-properly-for-new-field-in-ZoneHVACIdealLoadAirSystem (rraustad) - x86_64-MacOS-10.9-clang: OK (2768 of 2768 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


very understandable coding. cant find any mistake at all.


Nicely done


Remove the `()` from the `include` like this:

```
include __DIR__ .'/src/plugin.php';
```


`average(...grades)`
po staremu: `average.apply(null, grades)`


Why do we care about `atomic_writes` mismatch? It is not changing the file format at all.

Why exactly must we refuse the operation? If `ALGORITHM=COPY` is allowed, then a table rebuild with `ALGORITHM=INPLACE` should be just fine. `ALGORITHM=INPLACE` can rebuild a table perfectly fine if the `ROW_FORMAT` is changed. Why should these attributes be different? Why can’t `innobase_need_rebuild()` simply determine that a rebuild is needed if these attributes are changed?

(Yes, the name ‘inplace’ is unfortunate and misleading; I hope some day MDEV-13134 will fix that.)


thx.


Reformat to WordPress standards to line-up all of the `=>`.


I am keen to try this out. Was wondering when this will be good to try out again?


Reformat to WordPress standards to line-up everything.


good solution with very clean coding.


Reformat to WordPress standards to line-up all of the =>.


Isn't this `document` variable supposed to refer to react-document`?


Remove the `()` around the `require` like this:
```
require GALLERY_DIR . 'config/' . $filename . '.php';
```


![](https://github.trello.services/images/mini-trello-icon.png) [NFR24](https://trello.com/c/9pyHj50w/31-nfr24)


awesome


Reformat to WordPress coding standards to get the closing `);` to line up.


We need to remove this line from the tux package, as it's no longer needed there.


looks very tidy and understandable 👍


this is awesome too!


what is this


[tests/testthat/test09_afwijkendeMetingen.R:259:18:](https://github.com/inbo/dhcurve/blob/2fcb884a6869c7b98b1bc41716a86dd5ba4f7426/tests/testthat/test09_afwijkendeMetingen.R#L259) *style:* **Place a space before left parenthesis, except in a function call.**
```r
<U+200B>    expect_equal((afwijkendeMetingen(Dataset, 2) %>%
                 ^
```
[tests/testthat/test09_afwijkendeMetingen.R:266:18:](https://github.com/inbo/dhcurve/blob/2fcb884a6869c7b98b1bc41716a86dd5ba4f7426/tests/testthat/test09_afwijkendeMetingen.R#L266) *style:* **Place a space before left parenthesis, except in a function call.**
```r
<U+200B>    expect_equal((afwijkendeMetingen(Dataset, 5) %>%
                 ^
```
[tests/testthat/test09_afwijkendeMetingen.R:273:18:](https://github.com/inbo/dhcurve/blob/2fcb884a6869c7b98b1bc41716a86dd5ba4f7426/tests/testthat/test09_afwijkendeMetingen.R#L273) *style:* **Place a space before left parenthesis, except in a function call.**
```r
<U+200B>    expect_equal((afwijkendeMetingen(Dataset, 8) %>%
                 ^
```
[tests/testthat/test10_validatie.R:124:18:](https://github.com/inbo/dhcurve/blob/2fcb884a6869c7b98b1bc41716a86dd5ba4f7426/tests/testthat/test10_validatie.R#L124) *style:* **Place a space before left parenthesis, except in a function call.**
```r
<U+200B>    expect_equal((validatie.basis(Basismodel, AantalDomHogeRMSE = 2) %>%
                 ^
```
[tests/testthat/test10_validatie.R:131:18:](https://github.com/inbo/dhcurve/blob/2fcb884a6869c7b98b1bc41716a86dd5ba4f7426/tests/testthat/test10_validatie.R#L131) *style:* **Place a space before left parenthesis, except in a function call.**
```r
<U+200B>    expect_equal((validatie.basis(Basismodel, AantalDomHogeRMSE = 5) %>%
                 ^
```
[tests/testthat/test10_validatie.R:138:18:](https://github.com/inbo/dhcurve/blob/2fcb884a6869c7b98b1bc41716a86dd5ba4f7426/tests/testthat/test10_validatie.R#L138) *style:* **Place a space before left parenthesis, except in a function call.**
```r
<U+200B>    expect_equal((validatie.basis(Basismodel, AantalDomHogeRMSE = 8) %>%
                 ^
```
[tests/testthat/test11_outputIVANHO.R:35:69:](https://github.com/inbo/dhcurve/blob/2fcb884a6869c7b98b1bc41716a86dd5ba4f7426/tests/testthat/test11_outputIVANHO.R#L35) *style:* **Put spaces around all infix operators.**
```r
<U+200B>                              20 + 7 * log(Omtrek) + 4 * log(Omtrek)^2,
                                                                   ~^~
```
[tests/testthat/test11_outputIVANHO.R:36:69:](https://github.com/inbo/dhcurve/blob/2fcb884a6869c7b98b1bc41716a86dd5ba4f7426/tests/testthat/test11_outputIVANHO.R#L36) *style:* **Put spaces around all infix operators.**
```r
<U+200B>                              20 + 5 * log(Omtrek) - 6 * log(Omtrek)^2),
                                                                   ~^~
```
[tests/testthat/test11_outputIVANHO.R:57:69:](https://github.com/inbo/dhcurve/blob/2fcb884a6869c7b98b1bc41716a86dd5ba4f7426/tests/testthat/test11_outputIVANHO.R#L57) *style:* **Put spaces around all infix operators.**
```r
<U+200B>                              20 + 7 * log(Omtrek) + 4 * log(Omtrek)^2,
                                                                   ~^~
```
[tests/testthat/test11_outputIVANHO.R:58:69:](https://github.com/inbo/dhcurve/blob/2fcb884a6869c7b98b1bc41716a86dd5ba4f7426/tests/testthat/test11_outputIVANHO.R#L58) *style:* **Put spaces around all infix operators.**
```r
<U+200B>                              20 + 5 * log(Omtrek) - 6 * log(Omtrek)^2),
                                                                   ~^~
```
[tests/testthat/test11_outputIVANHO.R:82:66:](https://github.com/inbo/dhcurve/blob/2fcb884a6869c7b98b1bc41716a86dd5ba4f7426/tests/testthat/test11_outputIVANHO.R#L82) *style:* **Put spaces around all infix operators.**
```r
<U+200B>                     Hoogte = 15 + 15 * log(Omtrek) + log(Omtrek)^2,
                                                                ~^~
```


Good and clear commit messages


like the way you solved this task, I cant find anything else to improve it. looks awesome :)


This works; `path.join(".", "foo")` and `path.join(".", "/foo")` and `path.join(".", "./foo")` all produce `"foo"`, which is what's expected here.


Good usage of a foreach loop


I think we should consider passing as std::shared_ptr as well as storing as std::shared_ptr.


Hi I just changed it to return `True` and tested on local. But it failed to download all the wheels now. I think it's because this command was used in other files, so it affects other parts of the program. It's having an exception with `TypeError: bad operand type for unary -: 'NoneType'`


spaces are missing, else its prettttty good


TeamCity Market :: INFRA :: Graphouse :: Graphouse on change [Build 158](https://teamcity.yandex-team.ru/viewLog.html?buildId=10777328&buildTypeId=MarketInfra_Graphouse_GraphouseOnChangeOpensource) outcome was **SUCCESS**
Summary: Tests passed: 14 Build time: 00:00:24


There shouldn`t be an empty line here


*.ps1	 diff=astextplain


Method names are written in lowerCamelCase


otherwise very nice


![](https://github.trello.services/images/mini-trello-icon.png) [NFR25](https://trello.com/c/gdGM9ry7/32-nfr25)


Good indentation, clean and easily readable


I was afraid of losing those important  5 lines of code. 👍


"Remvoe" --> "Remove"


in recent talks (e.g. Scala Days 2017) Martin has stated unequivocally that Dotty = Scala 3


Thanks for explaining @lyw07 :)

Once we have migrated the logic of building these pex files to a separate repo, it might be better to have an inheritor class of `DownloadCommand` or copy out and adapt the few lines of code in `DownloadCommand.run` that populates the `build_dir`.


You don't want to use `esc_html_e` for the URL. Instead, use `esc_url` like this:
```
<?php echo esc_url($post_thumbnail_url); ?>
```


Nevermind this then, it's the above in the `run` method that's decisive.


To avoid the weird spaces in the DOM, combine lines 8-10 into one line.


Nicely done, you can use different parameters for the values


nice, file-by-file commit structure 👍


Version
> if (ss->statScore > 0 && (ss-1)->statScore <= 0)
> r -= ONE_PLY;
>
> else if (ss->statScore < 0 && (ss-1)->statScore >= 0)
> r += ONE_PLY;

looks more accurate if you follow the logic of the patch and needs verification. but most likely it would give a yellow result, since 50k games for the original version are quite a lot. at least in case of success combo it might look pretty good.


Nice commit messages


Esse daqui foi para reparar o erro no travis anterior.