[R/helper_funs.R:63:21:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/helper_funs.R#L63) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
    factor_levels %>% str_split(":", simplify = TRUE) %>%
                  ~~^
```
[R/processing.R:55:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/processing.R#L55) *style:* **Lines should not be more than 80 characters.**
```r
    message(sprintf(paste0("\n'sperrorest()': Non-convergence during model fit.",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/processing.R:122:16:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/processing.R#L122) *warning:* **no visible global function definition for ‘remove_missing_levels’**
```r
    nd_test <- remove_missing_levels(fit, nd_test)
               ^~~~~~~~~~~~~~~~~~~~~
```
[R/processing.R:181:18:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/processing.R#L181) *warning:* **no visible global function definition for ‘remove_missing_levels’**
```r
      nd_test <- remove_missing_levels(fit, nd_test)
                 ^~~~~~~~~~~~~~~~~~~~~
```
[R/processing.R:189:41:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/processing.R#L189) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
    if (is.null(current_res[[j]]$test)) { # nocov start
                                        ^
```
[R/processing.R:320:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/processing.R#L320) *style:* **Lines should not be more than 80 characters.**
```r
  # then is_factor_prediction is not set within runfolds and we need to set it here
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/processing.R:379:7:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/processing.R#L379) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if ((do_gc >= 1) & (do_gc < 2)) {
      ^
```
[R/resample.R:60:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/resample.R#L60) *style:* **Lines should not be more than 80 characters.**
```r
    stop(paste0("'strat' must either be a vector of factor type, or the name", # nocov
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/resample.R:154:27:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/resample.R#L154) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
  if (is.null(param$fac)) { # nocov start
                          ^
```
[R/sperrorest_error.R:3:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_error.R#L3) *style:* **Lines should not be more than 80 characters.**
```r
#' @description Calculate a variety of accuracy measures from observations and predictions
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sperrorest_error.R:70:25:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_error.R#L70) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
  if (any(is.na(pred))) { # nocov start
                        ^
```
[R/sperrorest_error.R:91:30:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_error.R#L91) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
      if (nlevels(obs) == 2) { # nocov start
                             ^
```
[R/sperrorest_error.R:122:18:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_error.R#L122) *warning:* **no visible global function definition for ‘prediction’**
```r
      predobj <- prediction(pred, obs)
                 ^~~~~~~~~~
```
[R/sperrorest_error.R:123:16:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_error.R#L123) *warning:* **no visible global function definition for ‘performance’**
```r
      auroc <- performance(predobj, measure = "auc")@y.values[[1]]
               ^~~~~~~~~~~
```
[R/sperrorest_error.R:174:34:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_error.R#L174) *style:* **Place a space before left parenthesis, except in a function call.**
```r
                rmse = sqrt(mean((obs - pred)^2)), mad = mad(obs - pred),
                                 ^
```
[R/sperrorest_error.R:174:46:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_error.R#L174) *style:* **Put spaces around all infix operators.**
```r
                rmse = sqrt(mean((obs - pred)^2)), mad = mad(obs - pred),
                                            ~^~
```
[R/sperrorest_misc.R:44:32:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_misc.R#L44) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
    if (method == "euclidian") { # nocov start
                               ^
```
[R/sperrorest_misc.R:301:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_misc.R#L301) *style:* **Lines should not be more than 80 characters.**
```r
tile_neighbors <- function(nm, tileset, iterate = 0, diagonal = FALSE) { # nocov start
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sperrorest_misc.R:301:72:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_misc.R#L301) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
tile_neighbors <- function(nm, tileset, iterate = 0, diagonal = FALSE) { # nocov start
                                                                       ^
```
[R/sperrorest_misc.R:470:13:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_misc.R#L470) *warning:* **no visible global function definition for ‘validate.resampling’**
```r
  stopifnot(validate.resampling(object))
            ^~~~~~~~~~~~~~~~~~~
```
[R/sperrorest_misc.R:508:38:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_misc.R#L508) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
print.resampling <- function(x, ...) { # nocov start
                                     ^
```
[R/sperrorest_misc.R:575:27:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_misc.R#L575) *warning:* **no visible binding for global variable ‘validate.resampling’**
```r
  valid <- sapply(object, validate.resampling)
                          ^~~~~~~~~~~~~~~~~~~
```
[R/sperrorest_misc.R:576:20:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_misc.R#L576) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
  if (any(!valid)) { # nocov start
                   ^
```
[R/sperrorest_misc.R:591:41:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_misc.R#L591) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
print.represampling <- function(x, ...) { # nocov start
                                        ^
```
[R/sperrorest_misc.R:632:45:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_misc.R#L632) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
summary.resampling <- function(object, ...) { # nocov start
                                            ^
```
[R/sperrorest_resampling.R:72:20:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_resampling.R#L72) *warning:* **no visible global function definition for ‘as.resampling’**
```r
      resampler <- as.resampling(resampler)
                   ^~~~~~~~~~~~~
```
[R/sperrorest_resampling.R:77:19:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_resampling.R#L77) *warning:* **no visible global function definition for ‘as.represampling’**
```r
    resampling <- as.represampling(resampling)
                  ^~~~~~~~~~~~~~~~
```
[R/sperrorest_resampling.R:158:15:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_resampling.R#L158) *warning:* **no visible global function definition for ‘as.represampling’**
```r
    repres <- as.represampling(repres)
              ^~~~~~~~~~~~~~~~
```
[R/sperrorest_resampling.R:211:12:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_resampling.R#L211) *warning:* **no visible global function definition for ‘as.resampling’**
```r
    fac <- as.resampling(fac)
           ^~~~~~~~~~~~~
```
[R/sperrorest_resampling.R:218:17:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_resampling.R#L218) *warning:* **no visible global function definition for ‘as.represampling’**
```r
    represmp <- as.represampling(represmp)
                ^~~~~~~~~~~~~~~~
```
[R/sperrorest_resampling.R:266:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_resampling.R#L266) *style:* **Lines should not be more than 80 characters.**
```r
    warning("'nfold' should be <= nlevels(fac); using nfold=nlevels(fac)\n") # nocov
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sperrorest_resampling.R:414:36:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_resampling.R#L414) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
  } else if (rotation == "random") { # nocov start
                                   ^
```
[R/sperrorest_resampling.R:467:30:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_resampling.R#L467) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
    if (length(dsplit) == 1) { # nocov start
                             ^
```
[R/sperrorest_resampling.R:482:40:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_resampling.R#L482) *style:* **Put spaces around all infix operators.**
```r
      r <- phi[as.character(cnt)] * 180/pi # nocov start
                                      ~^~
```
[R/sperrorest_resampling.R:495:31:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_resampling.R#L495) *style:* **Put spaces around all infix operators.**
```r
      x_delta <- diff(x_range)/nsplit[1]
                             ~^~
```
[R/sperrorest_resampling.R:496:31:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_resampling.R#L496) *style:* **Put spaces around all infix operators.**
```r
      y_delta <- diff(y_range)/nsplit[2]
                             ~^~
```
[R/sperrorest_resampling.R:520:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_resampling.R#L520) *style:* **Lines should not be more than 80 characters.**
```r
      x_split <- seq(x_range[1], x_range[2] + x_delta, by = x_delta) # nocov start
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sperrorest_resampling.R:543:47:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_resampling.R#L543) *warning:* **no visible global function definition for ‘as.tilename’**
```r
          tile[sel_x & sel_y] <- as.character(as.tilename(c(ix, iy)))
                                              ^~~~~~~~~~~
```
[R/sperrorest_resampling.R:550:16:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_resampling.R#L550) *warning:* **no visible global function definition for ‘get_small_tiles’**
```r
    s_tiles <- get_small_tiles(tile, min_n = min_n, min_frac = min_frac)
               ^~~~~~~~~~~~~~~
```
[R/sperrorest_resampling.R:553:21:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_resampling.R#L553) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
      if (reassign) { # nocov start
                    ^
```
[R/sperrorest_resampling.R:582:15:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_resampling.R#L582) *warning:* **no visible global function definition for ‘as.resampling’**
```r
      tile <- as.resampling(tile)
              ^~~~~~~~~~~~~
```
[R/sperrorest_resampling.R:691:15:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_resampling.R#L691) *warning:* **no visible global function definition for ‘as.resampling’**
```r
      tile <- as.resampling(tile)
              ^~~~~~~~~~~~~
```
[R/sperrorest_resampling.R:696:19:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_resampling.R#L696) *warning:* **no visible global function definition for ‘as.represampling’**
```r
    resampling <- as.represampling(resampling)
                  ^~~~~~~~~~~~~~~~
```
[R/sperrorest_resampling.R:833:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_resampling.R#L833) *style:* **Lines should not be more than 80 characters.**
```r
        warning(paste0("empty training set in 'partition_disc': 'buffer'", # nocov
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sperrorest_resampling.R:1167:12:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_resampling.R#L1167) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
  if (oob) { # nocov start
           ^
```
[R/sperrorest_resampling.R:1256:22:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest_resampling.R#L1256) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
  if (missing(data)) { # nocov start
                     ^
```
[R/sperrorest.R:326:48:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L326) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
    if (class(par_args$par_mode) == "numeric") { # nocov start
                                               ^
```
[R/sperrorest.R:327:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L327) *style:* **Lines should not be more than 80 characters.**
```r
      stop("'par_mode' has to be specified using an explicit parallel mode name.")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sperrorest.R:407:27:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L407) *warning:* **no visible global function definition for ‘availableCores’**
```r
    par_args$par_units <- availableCores()
                          ^~~~~~~~~~~~~~
```
[R/sperrorest.R:434:12:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L434) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
    } else { # nocov end
           ^
```
[R/sperrorest.R:461:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L461) *style:* **Lines should not be more than 80 characters.**
```r
        message(sprintf("Using 'parApply' parallel mode with %s cores.", # nocov start
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sperrorest.R:526:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L526) *style:* **Lines should not be more than 80 characters.**
```r
            stop(paste0("No output was received from sperrorest.\n", # nocov start
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sperrorest.R:538:9:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L538) *warning:* **no visible global function definition for ‘plan’, Did you mean 'lag'?**
```r
        plan(par_args$par_option, workers = par_args$par_units) # nocov
        ^~~~
```
[R/sperrorest.R:541:9:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L541) *warning:* **no visible global function definition for ‘plan’, Did you mean 'lag'?**
```r
        plan(par_args$par_option, workers = par_args$par_units)
        ^~~~
```
[R/sperrorest.R:585:5:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L585) *warning:* **no visible global function definition for ‘registerDoFuture’**
```r
    registerDoFuture()
    ^~~~~~~~~~~~~~~~
```
[R/sperrorest.R:594:13:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L594) *warning:* **no visible global function definition for ‘makeCluster’**
```r
      cl <- makeCluster(par_args$par_units, outfile = out_progress, ...)
            ^~~~~~~~~~~
```
[R/sperrorest.R:595:7:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L595) *warning:* **no visible global function definition for ‘plan’, Did you mean 'lag'?**
```r
      plan(cluster, workers = cl)
      ^~~~
```
[R/sperrorest.R:595:12:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L595) *warning:* **no visible binding for global variable ‘cluster’**
```r
      plan(cluster, workers = cl)
           ^~~~~~~
```
[R/sperrorest.R:601:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L601) *style:* **Lines should not be more than 80 characters.**
```r
        message(paste0("Please see 'sperrorest_progress' in your current", # nocov
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sperrorest.R:602:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L602) *style:* **Lines should not be more than 80 characters.**
```r
                       " working directory for progress output on Windows.")) # nocov
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sperrorest.R:606:7:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L606) *warning:* **no visible global function definition for ‘plan’, Did you mean 'lag'?**
```r
      plan(sequential)
      ^~~~
```
[R/sperrorest.R:606:12:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L606) *warning:* **no visible binding for global variable ‘sequential’**
```r
      plan(sequential)
           ^~~~~~~~~~
```
[R/sperrorest.R:616:45:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L616) *warning:* **local variable ‘pooled_pred_train’ assigned but may not be used**
```r
                        pooled_obs_train <- pooled_pred_train <- c()
                                            ^~~~~~~~~~~~~~~~~
```
[R/sperrorest.R:617:44:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L617) *warning:* **local variable ‘pooled_pred_test’ assigned but may not be used**
```r
                        pooled_obs_test <- pooled_pred_test <- c()
                                           ^~~~~~~~~~~~~~~~
```
[R/sperrorest.R:620:25:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L620) *warning:* **local variable ‘current_impo’ assigned but may not be used**
```r
                        current_impo <- resamp[[i]]
                        ^~~~~~~~~~~~
```
[R/sperrorest.R:623:40:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L623) *warning:* **no visible global function definition for ‘map’, Did you mean 'mad'?**
```r
                        current_res <- map(resamp[[i]], unclass)
                                       ^~~
```
[R/sperrorest.R:725:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L725) *style:* **Lines should not be more than 80 characters.**
```r
                                       not_converged_folds = runfolds_merged$not_converged_folds)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sperrorest.R:729:15:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L729) *warning:* **no visible global function definition for ‘stopCluster’**
```r
      on.exit(stopCluster(cl))
              ^~~~~~~~~~~
```
[R/sperrorest.R:744:15:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L744) *warning:* **no visible global function definition for ‘map’, Did you mean 'mad'?**
```r
  check_na <- map(my_res, function(x) all(is.na(x)))
              ^~~
```
[R/sperrorest.R:766:17:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L766) *warning:* **no visible global function definition for ‘transfer_parallel_output’**
```r
  my_res_mod <- transfer_parallel_output(my_res, res, impo, pooled_error)
                ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sperrorest.R:802:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/sperrorest.R#L802) *style:* **Lines should not be more than 80 characters.**
```r
    cat(sprintf("%s folds of %s total folds (%s rep * %s folds) did not converge.",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/summary_functions.R:52:37:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/summary_functions.R#L52) *style:* **Variable or function name should be snake_case.**
```r
                                    na.rm = TRUE, ...) {
                                    ^~~~~
```
[R/summary_functions.R:112:59:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/summary_functions.R#L112) *style:* **Variable or function name should be snake_case.**
```r
summary.sperrorestreperror <- function(object, level = 0, na.rm = TRUE, ...) {
                                                          ^~~~~
```
[R/summary_functions.R:140:61:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/summary_functions.R#L140) *style:* **Variable or function name should be snake_case.**
```r
summary.sperrorestimportance <- function(object, level = 0, na.rm = TRUE,
                                                            ^~~~~
```
[R/summary_functions.R:161:12:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/summary_functions.R#L161) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
    } else { # when does this happen?
           ^
```
[R/summary_functions.R:249:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/summary_functions.R#L249) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/summary_functions.R:250:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/summary_functions.R#L250) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/summary_functions.R:251:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/R/summary_functions.R#L251) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test-processing.R:81:11:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-processing.R#L81) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
          ^
```
[tests/testthat/test-processing.R:81:22:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-processing.R#L81) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                     ^
```
[tests/testthat/test-processing.R:81:39:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-processing.R#L81) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                                      ^
```
[tests/testthat/test-processing.R:81:50:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-processing.R#L81) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                                                 ^
```
[tests/testthat/test-processing.R:86:63:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-processing.R#L86) *style:* **Commas should always have a space after.**
```r
    if (!is.null(fac)) pred <- majority_filter(pred, newdata[,fac])
                                                              ^
```
[tests/testthat/test-processing.R:121:71:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-processing.R#L121) *style:* **Commas should always have a space after.**
```r
  mypred_rpart <- function(object, newdata) predict(object, newdata)[,2]
                                                                      ^
```
[tests/testthat/test-processing.R:169:63:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-processing.R#L169) *style:* **Commas should always have a space after.**
```r
    if (!is.null(fac)) pred <- majority_filter(pred, newdata[,fac])
                                                              ^
```
[tests/testthat/test-processing.R:194:3:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-processing.R#L194) *style:* **Variable or function name should be snake_case.**
```r
  imp.one.rep <- readRDS("inst/test-objects/imp.one.rep.rda")
  ^~~~~~~~~~~
```
[tests/testthat/test-processing.R:219:3:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-processing.R#L219) *style:* **Variable or function name should be snake_case.**
```r
  imp.one.rep <- readRDS("inst/test-objects/imp.one.rep.rda")
  ^~~~~~~~~~~
```
[tests/testthat/test-processing.R:270:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-processing.R#L270) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test-resample.R:13:52:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-resample.R#L13) *style:* **Only use double-quotes.**
```r
                              param = list(strat = 'slides', nstrat = 100))
                                                   ^~~~~~~~
```
[tests/testthat/test-resample.R:15:32:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-resample.R#L15) *style:* **Only use double-quotes.**
```r
  expect_equal(sum(d$slides == 'TRUE'), 100) # == 100
                               ^~~~~~
```
[tests/testthat/test-resample.R:25:55:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-resample.R#L25) *style:* **Only use double-quotes.**
```r
  d <- resample_uniform(ecuador, param = list(strat = 'slides', n = 400))
                                                      ^~~~~~~~
```
[tests/testthat/test-resample.R:28:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-resample.R#L28) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test-sperrorest-resampling.R:23:48:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest-resampling.R#L23) *style:* **Only use double-quotes.**
```r
  parti <- partition_cv_strat(ecuador, strat = 'slides', nfold = 5,
                                               ^~~~~~~~
```
[tests/testthat/test-sperrorest-resampling.R:37:44:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest-resampling.R#L37) *style:* **Only use double-quotes.**
```r
  parti <- partition_factor(ecuador, fac = 'zclass')
                                           ^~~~~~~~
```
[tests/testthat/test-sperrorest-resampling.R:49:47:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest-resampling.R#L49) *style:* **Only use double-quotes.**
```r
  parti <- partition_factor_cv(ecuador, fac = 'zclass', nfold = 5)
                                              ^~~~~~~~
```
[tests/testthat/test-sperrorest-resampling.R:131:63:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest-resampling.R#L131) *style:* **Commas should always have a space after.**
```r
  parti <- represampling_tile_bootstrap(ecuador, nsplit = c(4,2),
                                                              ^
```
[tests/testthat/test-sperrorest-resampling.R:143:65:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest-resampling.R#L143) *style:* **Commas should always have a space after.**
```r
  parti <- represampling_kmeans_bootstrap(ecuador, nsplit = c(4,2),
                                                                ^
```
[tests/testthat/test-sperrorest-resampling.R:172:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest-resampling.R#L172) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test-sperrorest-resampling.R:173:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest-resampling.R#L173) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test-sperrorest-summary.R:241:11:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest-summary.R#L241) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
          ^
```
[tests/testthat/test-sperrorest-summary.R:241:22:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest-summary.R#L241) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                     ^
```
[tests/testthat/test-sperrorest-summary.R:241:39:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest-summary.R#L241) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                                      ^
```
[tests/testthat/test-sperrorest-summary.R:241:50:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest-summary.R#L241) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                                                 ^
```
[tests/testthat/test-sperrorest-summary.R:263:57:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest-summary.R#L263) *style:* **Commas should always have a space after.**
```r
  out <- sperrorest(fo, data = maipo, coords = c("utmx","utmy"),
                                                        ^
```
[tests/testthat/test-sperrorest.R:46:67:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L46) *style:* **Commas should always have a space after.**
```r
            out <- sperrorest(fo, data = maipo, coords = c("utmx","utmy"),
                                                                  ^
```
[tests/testthat/test-sperrorest.R:74:73:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L74) *style:* **Commas should always have a space after.**
```r
                                                              newdata)[,2]
                                                                        ^
```
[tests/testthat/test-sperrorest.R:101:13:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L101) *style:* **Variable or function name should be snake_case.**
```r
            par.nsp.res <- sperrorest(data = ecuador, formula = fo,
            ^~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:103:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L103) *style:* **Lines should not be more than 80 characters.**
```r
                                      model_args = list(cost = 10000, gamma = 0.0001,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:208:21:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L208) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                  x[ fac == lev ] <- majority(x[ fac == lev ])
                    ^
```
[tests/testthat/test-sperrorest.R:208:32:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L208) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                  x[ fac == lev ] <- majority(x[ fac == lev ])
                               ^
```
[tests/testthat/test-sperrorest.R:208:49:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L208) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                  x[ fac == lev ] <- majority(x[ fac == lev ])
                                                ^
```
[tests/testthat/test-sperrorest.R:208:60:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L208) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                  x[ fac == lev ] <- majority(x[ fac == lev ])
                                                           ^
```
[tests/testthat/test-sperrorest.R:214:73:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L214) *style:* **Commas should always have a space after.**
```r
              if (!is.null(fac)) pred <- majority_filter(pred, newdata[,fac])
                                                                        ^
```
[tests/testthat/test-sperrorest.R:228:67:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L228) *style:* **Commas should always have a space after.**
```r
            out <- sperrorest(fo, data = maipo, coords = c("utmx","utmy"),
                                                                  ^
```
[tests/testthat/test-sperrorest.R:259:11:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L259) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
          ^
```
[tests/testthat/test-sperrorest.R:259:22:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L259) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                     ^
```
[tests/testthat/test-sperrorest.R:259:39:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L259) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                                      ^
```
[tests/testthat/test-sperrorest.R:259:50:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L259) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                                                 ^
```
[tests/testthat/test-sperrorest.R:265:63:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L265) *style:* **Commas should always have a space after.**
```r
    if (!is.null(fac)) pred <- majority_filter(pred, newdata[,fac])
                                                              ^
```
[tests/testthat/test-sperrorest.R:279:57:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L279) *style:* **Commas should always have a space after.**
```r
  out <- sperrorest(fo, data = maipo, coords = c("utmx","utmy"),
                                                        ^
```
[tests/testthat/test-sperrorest.R:402:11:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L402) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
          ^
```
[tests/testthat/test-sperrorest.R:402:22:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L402) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                     ^
```
[tests/testthat/test-sperrorest.R:402:39:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L402) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                                      ^
```
[tests/testthat/test-sperrorest.R:402:50:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L402) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                                                 ^
```
[tests/testthat/test-sperrorest.R:408:63:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L408) *style:* **Commas should always have a space after.**
```r
    if (!is.null(fac)) pred <- majority_filter(pred, newdata[,fac])
                                                              ^
```
[tests/testthat/test-sperrorest.R:418:68:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L418) *style:* **Commas should always have a space after.**
```r
  res_lda_sp_par <- sperrorest(fo, data = maipo, coords = c("utmx","utmy"),
                                                                   ^
```
[tests/testthat/test-sperrorest.R:469:67:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L469) *style:* **Commas should always have a space after.**
```r
            out <- sperrorest(fo, data = maipo, coords = c("utmx","utmy"),
                                                                  ^
```
[tests/testthat/test-sperrorest.R:499:73:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L499) *style:* **Commas should always have a space after.**
```r
                                                              newdata)[,2]
                                                                        ^
```
[tests/testthat/test-sperrorest.R:639:1:](https://github.com/pat-s/sperrorest/blob/dfaa3a9f0601a1185ebd7aab512823a178bfba35/tests/testthat/test-sperrorest.R#L639) *style:* **Lines should not be more than 80 characters.**
```r
  readRDS("/Users/pjs/Servers/GIServer/home/shares/data/LIFE/mod/survey_data/data-clean.rda") %>%
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


Prakticno i mocna opcija za rad generlano na github sam mislio :+1:


Hello


Actually I didn't know how to run the haxe tests suite properly. Otherwise I should have caught this.


In Docker it will put all data to user home. Since container will be destroyed after execution, all data will be removed.


Added a file to process the json response returned from the task-definition.


/cc @jcredding - this diff is bad but I just removed the wrapper function and decreased the indentation accordingly.  FYI.


d me,


im tryin pak. slowly but sure


Not a bit deal. The bigger concern is that utest might use it...


This commit has been mentioned on **Discourse Meta**. There might be relevant details there:

https://meta.discourse.org/t/send-a-personal-message-to-an-email-address/70737/1


建議 Service 可以在建構子 new 往後要改 IOC 也方便


I think you can remove this.grid entirely then.


class Account
{
	int id;
	int balance;
	char *name;

public:
	Account();
	Account(char* _name, int _id, int _bal);
	Account(const Account& acc);
	~Account();

	void AddMoney(int n);
	void MinMoney(int n);
	void PrintBalance();
};


@aduth shouldn't those missing whitespaces be caught by Eslint run on CirclrCI?


@rejurime creo que es porque en la maquina del laburo tengo la 4.6.1 =/


This should solve ![image](https://user-images.githubusercontent.com/307571/30819055-d2ce516e-a21d-11e7-9c11-7105243e7200.png)


方法建議可以用動詞來命名 只有 List 看起來就是怪怪的


Can do. The short version of it is it was a bad merge on my part.


Oh I see -- yeah I don't know why this compiled either. I think this is from a previous iteration of the code, I will clean this up.


Both in one commit, because I fucked up...


Is it possible to use the `searchTerm = generateSearchTerms(accountDao);` for all types of accounts including google?

The original Gmail search string method was not behaving well for some users.


Regarding Trade, Account, and Chart, it does appear that process is correct. If you're waiting to trade until TimePointk+1, then that's not an issue.

I still think the robot training incorrectly calculates the price change, per the explanation I wrote in Google Groups.


And it does indeed use it... looks like you have to save me from another one of these "u" haxelibs. ;)


can you use constant NO_HOST_POOL_ID in place of a 0?


Voici la variable liker avec la **_MKMapView_**


package.json  第20行多了个逗号，麻烦安卓高德sdk，更新到最新版，谢谢。


this is now probably called "dev" instead of "usb" (in both lines)


that would need to be "feldev_handle *dev" instead of libusb_device_handle *usb, otherwise re-generation of the code will fail to compile and link


but kvetinac97 said that he will fix it


and here we need "dev" instead of "usb" as well


This will cause problems for languages with regional variations. Two notable examples: Brazilian Portuguese (pt_BR) and Chinese traditional (Taiwan) vs simplified (China). The apps are small enough that it's likely requests for English and Spanish variants won't show up.

So it's better to use %locale_with_underscore%.


Created multidev environment [shlomko#pr-init2com](https://dashboard.pantheon.io/sites/aa024b33-115f-4ca9-b30c-1994524fbf92#pr-init2com).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-init2com-shlomko.pantheonsite.io/)


bool isTypingNumber = false;
        enum PhepToan { Cong, Tru, Nhan, Chia};
        PhepToan pheptoan;

        double nho;

        private void NhapSo(object sender, EventArgs e)
        {
            Button btn = (Button)sender;
            NhapSo(btn.Text);
        }

        private void NhapSo(string so)
        {
            if (isTypingNumber)
                lblDisplay.Text = lblDisplay.Text + so;
            else
            {
                lblDisplay.Text = so;
                isTypingNumber = true;
            }
        }

        private void NhapPhepToan(object sender, EventArgs e)
        {
            Button btn = (Button)sender;
            switch (btn.Text)
            {
                case "+": pheptoan = PhepToan.Cong; break;
                case "-": pheptoan = PhepToan.Tru; break;
                case "*": pheptoan = PhepToan.Nhan; break;
                case "/": pheptoan = PhepToan.Chia; break;

            }
            double nho = double.Parse(lblDisplay.Text);
            isTypingNumber = false;
        }
    }
}


maybe at least some checks if player can play specified sound at the moment


Hola, perdona por la abrupta modificación, quería haberme puesto en contacto contigo pero no sabía muy bien cómo. Como ves he preferido tutear al jugador ya que me parece que casa más con la idea de proximidad del juego, ya que los desarrolladores tienden a usar expresiones coloquiales o informales en inglés. Algunos cambios supongo que son manías mías como el uso del término contenedor. Tengo el mismo usuario en Discord para que hablemos en futuras ocaciones.


:angry: constructor with name and age as parameter (name should be optional [default "Unknown"])


For later references "latest "spark version" is Spark 2.2.0


lol. Delete this commit. @Souldiv


I am looking into it right now.


Вот эти все ишью и ветки - это всё тут, в html-agnecy делать же?


tipe data sudah di ubah dan sesuai


Thanks, I've fixed that.


Cloudflare restored H2 Push.


TeamCity libpalaso :: palaso-linux64-master Continuous [Build 4.0.377.54f94f49f8bd250712dedd1f5619e5cd3ec99dc8](http://build.palaso.org/viewLog.html?buildId=98111&buildTypeId=Libpalaso_PalasoLinux64masterContinuous) outcome was **FAILURE**
Summary: Execution timeout (new) Build time: 00:35:11


Bluemix [toolchain](https://console.bluemix.net/devops/toolchains/9b053dd5-9cb5-448c-ab30-973db9ac8d9d "toolchain-demo-apmdemo-3"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/d3e88580-10a7-438a-96da-33b11745528f "catalog-api-toolchain-demo-apmdemo-3") deployed [catalog-api-toolchain-demo-apmdemo-3](https://github.com/apmdemo-3/catalog-api-toolchain-demo-apmdemo-3/releases/tag/deploy-ibm-yp-us-south-apmdemo-3-dev-20170925-163135 "deploy-ibm-yp-us-south-apmdemo-3-dev-20170925-163135") to [dev](https://console.bluemix.net/apps/3ccfb04a-7e13-4d43-9271-d73f8cf5401b?env_id=ibm:yp:us-south "ibm:yp:us-south:apmdemo-3:dev"), including this commit


Use ProtocolLib?


上面這段有點瘋狂，這案例剛好非常適合擴充方法，要不要寫寫看？


The active revision of the document will be tombstoned.  If there are non-tombstoned conflicting revisions, they will become the active revision.


I think yes but I must test it.


你這樣的寫法就把所有的職責都讓 controller 做了，建議抽出 service 層


@3d-gussner I can't compile your branch, but I also can't compile the base firmware either, so either something is broken in the current Prusa commits, or there is something up with my Arduino install.... I've also tried with the Get-PrusaFwDevEnv-master Powershell script. Have you been able to compile your version?


I can't find this being implemented, so you probably want to remote this line


Fixed by 92576b77e9e.


Overall looks good to me, super-readable & comprehensible, +1 to merge.  Some questions below:

I realize this issue precedes this change, but shouldn't `$session_querystring` be named `$session_querystring_sqlsafe`, since it is assembled in an SQL-safe manner from SQL-safe components?  Or do we not use that convention for the actual query string variables?  (I guess the same question applies to `$count_dates_query` in `check_session_dates()` later on.)

Performance-wise, I worry about `check_session_dates()`.  The way it works is that it will open and close the DB once for each session.  (Do you notice any slowness in the report generation when you test?)  If that function took an array of session IDs, then it could open the DB once, loop over them, and return an array of just the IDs that were in session during those dates.  If there are no performance issues, then maybe it doesn't matter; it's just that when I see DB open/close overhead effectively inside a loop, which this is via the caller, I worry a bit.

Do lines 242-245 have literal TAB characters for indentation?  (Should be spaces.)  Fine w/ that being fixed after merge, if so.


I think this need to be keyword arguments like pastAnimations and currentAnimations. Also, in the examples, this function is called with kwargs.


Ты че поехал?
Забыл <br>, отдельные куски какие-то запушил. Мат не приветствуется.


你用了自訂驗證，但沒有補上自訂驗證前端驗證的部分


test_should_create_product now fails, because it tries to create test product one again, which is now disallowed as price is required to be unique. will fix this


**Whoops!**

There were *2 warnings* that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.

**WARNINGS**
[`src/content/en/shows/designer-vs-developer/podcast/DVDS2E05-designing-for-the-next-billion-users.md`](https://github.com/Google/WebFundamentals/blame/6a319cd625d54bca9517d5d8714f2d4f42f48470/src/content/en/shows/designer-vs-developer/podcast/DVDS2E05-designing-for-the-next-billion-users.md) - No `wf_blink_components` field found in metadata. Add if appropriate.
[`src/content/en/shows/designer-vs-developer/podcast/DVDS2E05-designing-for-the-next-billion-users.md#L43`](https://github.com/Google/WebFundamentals/blame/6a319cd625d54bca9517d5d8714f2d4f42f48470/src/content/en/shows/designer-vs-developer/podcast/DVDS2E05-designing-for-the-next-billion-users.md#L43) - Line must be at most 100 characters


Whoops, that commit msg should have been "v0.2.0" of course.


commiting changes


Very helpful of you, such a baller.


View Model 後綴務必加上 ViewModel 字樣


如果有指定回傳筆數的需求，請做一個可以只回傳X筆的 Service


Ok


Well good luck
I actually encountered similar errors to the ones you are currently getting while bringing up EAS on my 3.10 kernel
https://github.com/GlassROM-devices/android_kernel_oneplus_msm8994/commit/f978a5610bfca47772de731b036713a1acfe5e9a

If seems we have to cleanup the code to fix some errors
This one's the cfs throttling one which I got when co


試試看使用 RazorHelper 寫，你會發現世界不同了
而且你應該只需要判斷後傳回 danger or primary 就好


Something like the following looks more economical for me:
```
        val instrumentationClasspath =
            depSourceDirectorySets.fold(sourceSet!!.compileClasspath) { acc, v -> acc + v }.asPath.also {
                logger.info("Using following dependency source dirs: $it")
            }
```


It should be always `http`, since oAuth1.0a is only possible under `http`.


As part of the refactoring, I made it load like other CSS files (https://github.com/sinedied/hads/commit/9dceab7d150d5f28730920c35da14e65b9058474#diff-293a7a4e8fcaad023772a6a9dfb47e42R88) so you can edit your custom CSS and just hit F5 to see the changes instead of restarting the server 😉


The string `Make a block...` is capitalized, but `find blocks...` is not? I don't know if this would add any more work for translators, but it seems like either both or neither should be capitalized (just so they're consistent).


Service 內不應該直接 saveChanges 這樣會讓你的 service 很難用


@hategan This is going to break. It doesn't take into account that file may be located in the Girder's userspace. In that case first `dict` doesn't have a `name` property. You mentioned that `path_utilgetResourcePath` was introduced in later version of girder. Instead of reinventing it, let's bump the requirement.


cvb fv


Maybe "verbatim" -> "unchanged"?


what a code


Thanks!


Hah! Guess I must've been lucky with all my drivers so far; I'll convert everything to `vec4` tonight. As for when `std140` became core, I have no idea :(


nice


you're right, this is reusing the existing translation strings. Reusing existing translation strings is currently more important than consistency in English, because we have so many translations by the community that aren't always kept up to date.


success


`return newlist;` would be enough here, there's no need to create another new list.


Name styling: `newList` instead of `newlist`.


`state` is the blockstate at the breaker from what I can see. So this would probably still crash with IE.


Откати тогда :(
Через вебверсию ужасно комитить


Cannot implicitly convert type 'void' to 'System.Collections.Generic.List<int>'
The name 'oddElements' does not exist in the current context
The name 'OriginalList' does not exist in the current context


Won't this invite video recording issues again?


You don't use `Linq`, so this line should be deleted.


Eu uso a pillow backpack no global, ela tem 24 slots


I didn't see that I deleted this line, will be added back in with next push.


PrepFor88 (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (2779 of 2779 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


I doubt it would break unless your CLI would call `drawHandleLocation`. Which would be weird for a CLI.
However, this is just a helper function that actually doesn't do anything with the handle (it's a static function). So it would be well possible to should move it into some sort of "util" file and call it "drawDottedCircle" or leave it as "drawHandleLocation". The only reason why it's here is because it's loosely related to the distance check in `getHandleForLocation`.

However, if you are also commenting on the drawing functions of the different annotations; then yes, might be a little off here. Suggestions? (They still wouldn't break in a CLI interface, because the CLI would not call the drawing methods)


哎，你也保重，别被抓了


updated


Naming: `i` is not a descriptive name. You could use for example `email` instead.


as discussed in channel, this will require redeclaration in android module. Alone it will not change anything. The fact we are using DNS classes in our android SDK is a general requirement for anyone using the android extension? It seems to me we are trying to push a particular solution issue into the project. What happens with the rest of project using android-jain.sip-ext which are not configured to use the DNS classes?


You forgot to change the first letters uppercase.


Created multidev environment [natalie-sandbox#ci-136](https://dashboard.pantheon.io/sites/ee1a9f88-1cc8-4eca-a8a6-7dc1433bb37e#ci-136).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-136-natalie-sandbox.pantheonsite.io/)


Git commits from Pycharm.  It's painful.


Угу.
Ну и обычно для такой инструкции используют README.md


Course Assignment Sept 25th


That's really nice that you thought about the case when the word is already in your dictionary! :)


You are splitting the string 2 times, i looks more readable , if you do it in two step. And you are also swapping the first latter to upper case in the same function which could be elsewhere! Single responsibility! ;)


Yes, they should. Uncertain whether this is not reflected because we don't have the correct rule enabled, or because we're running an older version. I'd planned to put together a PR to bring us to the latest ESLint version and will take a look.


x264_nvenc  is not right.  h264 not x264


TUDO MALL


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (2171 of 2171 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


`@Scripts.Render("~/bundles/jqueryval") `
應該已經載完 jquery.validate 了，建議砍掉他


The `KeyValuePair<string, string>` could be a `var`, because in that Dictionary it can not be else.


is this standard in git-core? You could use puts() which avoids the relatively costly format interpretation.


Лишняя пустая строка


Version analysis for protocol definitions in this commit:

## Diffs

### `S_LOADING_SCREEN_CONTROL_INFO` 1 => 2
```diff
--- a/protocol/S_LOADING_SCREEN_CONTROL_INFO.1.def
+++ b/protocol/S_LOADING_SCREEN_CONTROL_INFO.2.def
@@ -1,1 +1,1 @@
-byte unk
+bool enableCustom # false = use built-in loading screens, true = use loading screens from DownloadedResources.dat
\ No newline at end of file
```


I noticed the ZDA parser stores a four digit year, which is assumed to be a two digit year by minmea_gettime. This part is a trivial fix.

An additional fix that that won't affect most users of the library is shifting the window to interpret two digit years from 2000-2099 to 1980-2079 to match the GPS epoch. This allows the correct decoding of a date that occurs before the turn of the century. Why is this important? Because some GPS receivers will report a date of 1999-08-22 when the 10-bit GPS week number rolls over after 2019-04-06. The standard approach to correct for this this is to add multiples of a GPS cycle worth of seconds (1024 * 7 * 24 * 60 * 60) to the parsed time_t until it occurs after some known date, but to do this the correct time in 1999 needs to be recoverable. For reference, here's u-blox's implementation: https://forum.u-blox.com/index.php?qa=60&qa_1=what-week-rollover-roll-over-and-handled-blox-gnss-receivers. Users of the library might still have to correct the time reported by a receiver using this technique when it's ~20 years since the build date of the receiver firmware, but thankfully we can use the same technique, using the build date of user software as a reference to check against. I feel like an implementation these corrections might be out of the scope of this project, but at the very least the library needs to report the correct time in 1999 to allow the user to correct it later.

This is my first GitHub contribution, please give me feedback if you have any.


not important


Бесполезный return. В конце функции он не нужен


Комменты не стоит оставлять в коде


To get the power data for FRBs detection when Dibas run in SETI observation mode, we made a slight firmware revise based on the original version. The FFT block signal was split to a new streamline, which include correlator, accumulator, packetizer and Ethernet. Due to the whole 8 ten-GbE ports were occupied by SETI data output, the FRB data will be sent through an one-GbE port.


what happend with old endpoints ? they where in Database.cs module


Yeah, that sounds like a good idea.


Fixed in a1b3f12a716a4be399a8987979c39792cbd7ca64.


are you sure the name is normalized? You use count_slashes, so a name like a//b could confuse things.


Можно String.valueOf(value)


Так решено верно


@hamidbg86 Depending on your existing Python skills you might want to check out the free course on Python for Network engineers that I run:

https://pynet.twb-tech.com/email-signup.html

While this started in August, I have left the sign-up open so you can still join.


Sure, thanks for the suggestion, I'm fixing it


Write next 6 values(a,b,c,d,e,f) via space and press Enter
5
9
9
8
13
9
Houses cannot be built on the plot

А должны помещаться


test


hehe


This could be a const, since it wont change, and after this you updated it a more `magic string`. It is similar as the magic numbers, we wont leave them in the code!


This function should **return** with a `List` instead being `void`.


Стоило вот так написать:

public static boolean isPositive(double number) {
    return number > 0;
}

С isZero также


Лишняя пустая строка


`List<string>` could be a `var` since the functions is givin the type.


В целом за дз 7,5. Вторая решена не до конца


Expenditure: $25 for parking, estimated $15 for gas round trip.

Total: $40


Comment #1


I've opened a PR here to set this as the default metaphysics sort order: https://github.com/artsy/metaphysics/pull/755


It works but the input should be a parameter of a function.


You started well, it's a petty that you haven't finished your solution.
You just need a new list in which you should add the current element off your input list (`numbers[i]`).


Бесполезный счётчик. Так делать не стоит. Лучше было while использовать:

        while (result < number) {
            ...
        }


Пустые строки


This comment is for all the commits: Please use a `.gitignore` file next time, because you uploaded all the binaries to GitHub, which is a realy bad practice.


Тут всё верно.

За ДЗ 7,5. С рекурсией не сделано


It was one of the suggestion I got earlier and is available at [1].
And was removed in the patch update [2].
Less usage of puts() function in the codebase was the primary reason
behind using the printf() function here.
[1]: https://public-inbox.org/git/20170724215220.GC92874@google.com/
[2]: https://public-inbox.org/git/20170731205621.24305-6-pc44800@gmail.com/


Hi,
At least strongSwan still hangs on exit due to SCardCancel() not terminating SCardGetStatusChange() call. I've created pull request #24 with a patch that appears to fix this...


if you go through this path, you'll try to free("") at cleanup, which seems wrong.


Let me know when you have PR ready for review. I'd like to experiment with Prettier integration with Eslint. I saw such integrations in a few projects. It runs as pre-commit hook in 'eslint --fix' mode. I'm wondering if it would run Prettier first and then apply all whitespace modifications. It would perfectly fit our ise case 😃


is this OK on windows too?


ocay


Don't leave outcommented code parts in your commits.


use xstrdup("")


Added this method to the struct to check if something is adjacent. Can be used for interaction.
North, South, East, West.


You have a lot of `using` here which you don't use. These `using`s should be deleted.


Yes, the simpler the better. Maybe, you can leave the sentence as a footnote for more "advanced" readers but not sure if this is necessary.


Sure, you are most welcome..


It is fixed. Thank you


new changes


The `List<int>` could be a `var` here!


teste


Unnecessary empty line here.


Is this to handle options or values that do not exist anymore?


fixes #475


Cool solution! :)


`{:.1%}` on `value` has the same effect as `{:.1f}` with `value * 100`.


to be fair...

[dequeue is also a noun](https://en.m.wikipedia.org/wiki/Double-ended_queue)


Bluemix [toolchain](https://console.bluemix.net/devops/toolchains/9b99c3b8-c499-4d1b-947e-994e4af95156 "UI-yp-SimpleTC0925T131657"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/9981edd0-a89a-4e8b-ab12-e547bb4f0d75 "UI-yp-SimpleTC0925T131657") deployed [UI-yp-SimpleTC0925T131657](https://github.com/idsb3t1/UI-yp-SimpleTC0925T131657/releases/tag/deploy-ibm-yp-us-south-idsb3t4-us.ibm.com-dev-20170925-172234 "deploy-ibm-yp-us-south-idsb3t4-us.ibm.com-dev-20170925-172234") to [dev](https://console.bluemix.net/apps/05e9eb9c-c2d6-49d3-bd1d-9805e20148e5?env_id=ibm:yp:us-south "ibm:yp:us-south:idsb3t4@us.ibm.com:dev"), including this commit


TeamCity SayMore :: SayMore pull requests [Build *.*.54.aa839c60f1b85309592ee2bb5451d7c13465b335](http://build.palaso.org/viewLog.html?buildId=98115&buildTypeId=SayMore_SayMorePullRequests) outcome was **FAILURE**
Summary: Tests failed: 3 (3 new), passed: 655, ignored: 4 Build time: 00:00:58
### Failed tests
```
SayMoreTests.dll: SayMoreTests.Model.SessionWorkflowInformantTests.GetCategorizedSessionsByField_PassGenre_ReturnsTwoLists: <no details avaliable>

SayMoreTests.dll: SayMoreTests.Model.SessionWorkflowInformantTests.GetCategorizedSessionsFromListByField_FromSpecifiedList_ReturnsTwoLists: <no details avaliable>

SayMoreTests.dll: SayMoreTests.Model.SessionWorkflowInformantTests.GetCategorizedSessionsFromDoubleKey_PassGenreAndStatus_Return: <no details avaliable>

```


`KeyValuePair<string, string>` could be a `var` here.


EVERITHING WORKING


You have both the `firstname` and the `lastname`, why do you return with just the `firstname`?
You also forgot to change the first letters to uppercase.


Tip: You could return the searchword immediately, when you find it! ;)


Bluemix [toolchain](https://console.bluemix.net/devops/toolchains/f0e7223a-eb60-4bd9-b564-6343acddb6dd "simple-toolchain-20170919131320993"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/26a11e58-fd8d-428e-8769-7b5e485fe7bf "simple-toolchain-20170919131320993") deployed [simple-toolchain-20170919131320993](https://github.com/facciod/simple-toolchain-20170919131320993/releases/tag/deploy-ibm-yp-us-south-BluemixGarageMethod-dev-20170925-172427 "deploy-ibm-yp-us-south-BluemixGarageMethod-dev-20170925-172427") to [dev](https://console.bluemix.net/apps/1d9c7551-3ef5-407f-966e-00ca232c4ce0?env_id=ibm:yp:us-south "ibm:yp:us-south:BluemixGarageMethod:dev"), including this commit


Created multidev environment [badcamp-2017#ci-642](https://dashboard.pantheon.io/sites/8d658997-7a61-4db8-9be8-0f16b8b62022#ci-642).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-642-badcamp-2017.pantheonsite.io/)


Сега, ако махнете и String частите: "Area = " и "Perimeter = " и работата ще заспи на шест без косъм. :)


PrepFor88 (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


Please use functional component style
` const componentName = (props) => render`
 for those that have no use for lifecycle methods.


storage area for messages, will be sorted according to the chat_id


Follow indentation rules and lint your components before they are pushed.


Bitte nicht so, die Änderungen beißen sich dann mit dem Upstream ...


If you use the negate `!` operator in the if statement, you do not need an else part and you could avoid the `return;`, which is a bad practice, we do not return a void like... ever :)


Created multidev environment [natalie-sandbox#pr-narrativ](https://dashboard.pantheon.io/sites/ee1a9f88-1cc8-4eca-a8a6-7dc1433bb37e#pr-narrativ).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-narrativ-natalie-sandbox.pantheonsite.io/)


> Another option would be `no if $] >= 5.022, warnings => 'redundant';` (`if` is core since 5.6.2).

Thanks, applied.


edi shing


edi waw


This `List<string>` could be a `var`, since it is not a primitive type.


Début classe Matrix WIP / Ajout méthode rgbToColor et colorToRgb dans la classe Color / des trucs en plus / A commenter / optimiser et rapport avec Point ?


Since this string is something similar like a magic number, this could be a `const`.


REPORT:

1. Close collapsed navbar on click(mobile view)
2. Grades:
	If prep id is not null:
	Prep ID - 1st year and 2nd Year
    Curriculum Id- 3rd year and 4th Year)
4. Linked app logo
5. Responsive design of 404
6. Installed fonts
7. Monosync logo
8. Removed timestamp in upload
9. sapilitan update your profile. -> has_profile
10. Link monosync and orgs fb acc
11. Changed from online to Web
12. Catch student profile method not allowed error
13. Design in home(dati may automatic na horizontal na scroll, may lumalagpas. oks na)
14. Code: Order by desc all
15. Waiting layout(di ko magets sinasabi mo..)
16. Home navbar transparent-> gray on small screens
17. Loading profile photo.(Pati sa cp)
18. Disable change pic on load
19. Image Upload: -laravel intervention
	1. Checks if image is 160x160 pixels or 2x2 already - upload
	2. Checks if image is has equals sides/a square - resize to 160x160
	3. If image is a rectangle - resize then crop.
		-sakto sa mga mag pipicture sa cam ng phone at iuupload.

20. Load new image after upload
21. Error message of upload

//-------------------------

22. Home hello design - center and fullscreen on all common mobile screen sizes ** di pa ayos
23. Home login--redirect ** di pa ayos


1st comment


We don't want to execute ruby (aside from helper methods) in the view. You're already doing `Topic.find(params[:topic_id])` in the controller, and setting it to `@topic`, so you should just use `@topic` here.


@Sami32 Ok, why?


This will hang your application! You gotta get rid of it.


This should be at the base indentation level, instead of in line with the `:email` validation stuff


@Sami32 I reverted them back to be more efficient. Checking ```streamtype``` is very quick (an enum, what happens behind the scene is that a simple int value is compared). String operations are slow, so we don't want to start evaluating string equality if ```streamType``` isn't video.


Bluemix [toolchain](https://console.bluemix.net/devops/toolchains/f0e7223a-eb60-4bd9-b564-6343acddb6dd "simple-toolchain-20170919131320993"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/26a11e58-fd8d-428e-8769-7b5e485fe7bf "simple-toolchain-20170919131320993") deployed [simple-toolchain-20170919131320993](https://github.com/facciod/simple-toolchain-20170919131320993/releases/tag/deploy-ibm-yp-us-south-BluemixGarageMethod-dev-20170925-173356 "deploy-ibm-yp-us-south-BluemixGarageMethod-dev-20170925-173356") to [dev](https://console.bluemix.net/apps/163356ce-0591-4546-8dc7-c2da81c8731e?env_id=ibm:yp:us-south "ibm:yp:us-south:BluemixGarageMethod:dev"), including this commit


There's an extra space in your list initialization.


Both "new macros" and "Scalamacros" are very bad names because in conversation, you have to pause and qualify with either "Scala 2.x production macros" or "Scalamacros, you know, the new ones". It's entirely unclear. I would just omit naming it here?


Thanks for the fast review, @kfogel!

I think that we only use the `_sqlsafe` extension for variables that were passed from the client, like `$end_date_sqlsafe`.  Variables that we construct on the server side are assumed to be safe.

I took your advice about performance and made a change to address it in d0f5404e3b918ac2ad66548e37d628212bcefab0.  Thanks for catching that!

Those lines don't have TABs.  I think the way GitHub highlights the diff might make it look that way.


mkk


test


TeamCity libpalaso :: palaso-win-master Continuous [Build 4.0.102.54f94f49f8bd250712dedd1f5619e5cd3ec99dc8](http://build.palaso.org/viewLog.html?buildId=98122&buildTypeId=Libpalaso_PalasoWinmasterContinuous) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:16


This works, but the task was to create a function for this purpose.
You just need to wrap the previous 8 lines to a function like `public static List<int> OddFilter(List<int> numbers)`.


@Sami32 I changed it so it doesn't need it. I think you had a null check there. When doing equals, you must make sure that the object you run equal on isn't null. The argument can be null. Since we know that FormatConfiguration.AVI is never null (as it's a constant), this is safe even if ```media.getContainer``` is null. What will crash is if ```media``` is null, but it's used so many places there that I assumed it had been handled above.


```
module kernel(real: real) = {
  type dtype = real.t
  let main(nq : i32, start : i32, stop : i32, call_details : []i32,
           values : []dtype, q_input : []dtype, cutoff : f32): []dtype =
     let x  = q_input[0]
     let arr = map (real.* x) q_input
     let arr' = arr[0:nq+1]
     in arr'
}

module kernel_f32 = kernel f32
module kernel_f64 = kernel f64

entry kernel_f32 (arg: (i32, i32, i32, []i32, []f32, []f32, f32)): []f32 =
  kernel_f32.main arg

entry kernel_f64 (arg: (i32, i32, i32, []i32, []f64, []f64, f32)): []f64 =
  kernel_f64.main arg
```


added new component


There's a lot of `using`s here that you don't use. These should be deleted.


Created multidev environment [natalie-sandbox#pr-narrativ](https://dashboard.pantheon.io/sites/ee1a9f88-1cc8-4eca-a8a6-7dc1433bb37e#pr-narrativ).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-narrativ-natalie-sandbox.pantheonsite.io/)


@Sami32 I've reverted your reverts 😉


Good morning!
I have a problem with this code, it is not working, i run this code and it show me temperature -1 and humidity -1 always!, someone can help me please! Thanks.


OK, so making a PR and immediately merging it would be good for you?


@Sami32 I'm happy to add formats as long as they're properly handled/tested. I can't see a reason to *not* add a format unless it leads to bugs.


F-Project


Note that CMutableTransaction is only added for bitcoin congruence at the moment; CTransaction is NOT immutable at the moment.


TeamCity SayMore :: SayMore pull requests [Build *.*.55.9ebe5db8751ab80f26727a3476c1b3b1cd33b864](http://build.palaso.org/viewLog.html?buildId=98124&buildTypeId=SayMore_SayMorePullRequests) outcome was **SUCCESS**
Summary: Tests passed: 658, ignored: 4 Build time: 00:02:49


Actually I've decided against changing the test. Floating enable should have something  like moves_focus_from_ancestor.


Also, deserialization is not added yet. Remind me why I didn't do this in my private repo?;)


@bradmerlin I don't like this way of defining a method inside an `if` statement. I think it's better to put the `if` statement inside the method, e.g.

```
def student_view_data(self, context=None):
    if settings.FEATURES.get('HTML_XMODULE_STUDENT_VIEW_DATA'):
        return {'enabled': True, 'html': self.get_html()}
    else:
        return {'enabled': False}


Splash screen code


Should quickstart-ec2.md be added to the index?


@geoffhendrey Do we want to add a default (type=unknown failure) statement here because there might be other undocumented error codes?


TeamCity Architecture Team :: Java Platform :: otj-kafka :: otj-kafka [Build 52](https://teamcity.otenv.com/viewLog.html?buildId=7080739&buildTypeId=ArchitectureTeam_JavaPlatform_OtjKafka_OtjKafka) is now running


Nope, none of the plots were generated.


Thanks for Adding Z00L as Official Device


TeamCity Architecture Team :: Java Platform :: otj-kafka :: otj-kafka [Build 53](https://teamcity.otenv.com/viewLog.html?buildId=7080740&buildTypeId=ArchitectureTeam_JavaPlatform_OtjKafka_OtjKafka) is now running


Fix #162


TeamCity Architecture Team :: Java Platform :: otj-kafka :: otj-kafka [Build 54](https://teamcity.otenv.com/viewLog.html?buildId=7080741&buildTypeId=ArchitectureTeam_JavaPlatform_OtjKafka_OtjKafka) is now running


TeamCity Architecture Team :: Java Platform :: otj-kafka :: otj-kafka [Build 52](https://teamcity.otenv.com/viewLog.html?buildId=7080739&buildTypeId=ArchitectureTeam_JavaPlatform_OtjKafka_OtjKafka) outcome was **SUCCESS**
Summary: Tests passed: 2 Build time: 00:00:47


TeamCity Architecture Team :: Java Platform :: otj-kafka :: otj-kafka [Build 53](https://teamcity.otenv.com/viewLog.html?buildId=7080740&buildTypeId=ArchitectureTeam_JavaPlatform_OtjKafka_OtjKafka) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 1 Build time: 00:00:26
### Failed tests
```
com.opentable.kafka.EmbeddedZookeeperTest.testBoots: <no details avaliable>

```


Dear f# team,
For one year or so it was said that a RFC for supporting open static classes is in planning, but nothing happened (Source: https://fslang.uservoice.com/forums/245727-f-language/suggestions/6958404-allow-opening-of-static-classes-matching-the-c-d).
Ist out of consideration or could we expect that in future a RFC is created for it?


nevermind didn't see the UNHANDLED_NON_200


TeamCity Architecture Team :: Java Platform :: otj-kafka :: otj-kafka [Build 54](https://teamcity.otenv.com/viewLog.html?buildId=7080741&buildTypeId=ArchitectureTeam_JavaPlatform_OtjKafka_OtjKafka) outcome was **SUCCESS**
Summary: Tests passed: 2 Build time: 00:00:39


Why aren't we just using Base + AbstractArrays for this?


Project+Test


"Regarding Trade, Account, and Chart, it does appear that process is correct. If you're waiting to trade until TimePointk+1, then that's not an issue."
Can you please post it on the forum as well? Thanks


Thanks


The task was to **return**  the result, not just print it.


Remove it and use lots_visible

On Mon, Sep 25, 2017 at 6:05 PM, pimodoo <notifications@github.com> wrote:

> Why do you need it? Why not use 'has_tracking'
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/odoo-dev/odoo/commit/aeff8997e978e95973ced5bd28f440ea3591e65e#commitcomment-24547742>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ADp7ew-tqiSarxRscL_qkaXWtMstaceCks5sl888gaJpZM4Pi7Ik>
> .
>


Sure (as long as its a merge commit or CLI fast-forward and not squashmerge/rebasemerge), the only reason to wait is if there's some kind of non-editorial review that might be needed (unlikely on the agenda)


Most likely it's not necessary, it's just the old CUBLAS code. PR welcome if you want to get rid of it


## Global

| Changed            |   Status |
|:-------------------|---------:|
| `metadata_passing` |       +1 |
| `metadata_total`   |       +1 |
| `nodes_count`      |      +61 |
| `texts_passing`    |       +1 |
| `texts_total`      |       +1 |

## Words

| Changed   |   Status |
|:----------|---------:|
| `grc`     |    +6989 |

## Units

| Changed                                               | Status   |
|:------------------------------------------------------|:---------|
| `./data/tlg0062/tlg038/__cts__.xml`                   | New      |
| `./data/tlg0062/tlg038/tlg0062.tlg038.1st1K-grc1.xml` | New      |
| `./data/tlg0062/tlg038/__cts__.xml`                   | Passing  |
| `./data/tlg0062/tlg038/tlg0062.tlg038.1st1K-grc1.xml` | Passing  |

*[Hook UI build recap](http://ci.perseids.org/repo/OpenGreekAndLatin/First1KGreek/2777)*


acidentaly


Scan a WMV video and check by yourself ;)


Why was this added in the first place? It just makes it easier for spoons.


I was messing around with the GitHub desktop repository and I think that is
what might of happened.  A few of my commits were also missing, thankfully
I had saved multiple versions of my project so I just made new commits (so
if you notice that all of my commits happened within a 1 hour period that
is why).  I also was able to find some flooring!

Gwendolyn J. Poillucci
*University of Pittsburgh*
*Pitt Business Class of 2017*
*412-551-1054*

On Mon, Sep 25, 2017 at 9:38 AM, benmiller314 <notifications@github.com>
wrote:

> Re: tile images, where have you looked so far?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/gjpoillucci/CDM-Project-1/commit/20b320341e09cc0c93a51eb2ef0b7a9df2e28b42#commitcomment-24544279>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AeLJ6U8sphAz5KeGh-UuXA8tZfOP33LDks5sl6zMgaJpZM4PiGMe>
> .
>


Thanks for pointing this out, I'll update this asap.


why don't I just make all my code really ugly and confusing and obfusticate everything? that would make it hard, wouldn't it?

nobody remembers PocketMine-Soft... how sad


![](https://github.trello.services/images/mini-trello-icon.png) [Controllare vincoli e gestione dei valori di input nei form](https://trello.com/c/pXt2TGtG/26-controllare-vincoli-e-gestione-dei-valori-di-input-nei-form)


+1 okay great


PrepFor88 (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1561 of 1561 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-38.82%25-green.png)


i m unix admin


Correction made by Atom editor.


Correction made by Atom editor


Which part of the behavior exactly? The old behavior could lead to very strange cases. For example could it happend that a .jpg file has the binary content of a zip file.


Мега отступы


Why did you get rid of this?


У тебя прямо в условии значение занятого места меняется, что делает проверку бессмысленной


А если "проверка" проходит, то занятое место дважды занимается


Changed default colorScheme to light--full
light--full: white background with a grey border.


Если в модуле только методы класса описаны, то их можно в самом модуле и описать, а его подключить через `extend`. Т.е. так:
```ruby
module SomeModule
  def foo
    puts 'foo'
  end
end

class A
  extend SomeModule
end

A.foo
```


typo in the commit message: `uniqed` 😄


Test


I don't think this is the right approach. Checking if there is a new version does not mean this version is going to be compatible with the current environment. I know what you have in mind is to check for new version of the distribution package but seems to me this component should probably be less generic and made specific to the environment extension only (if really needed).

For installed extensions there is upgrade plan job that can be used (you can indicate a specific extension in the job request).


I styled the Dropdown Message Box but I still have an issue showing it!
I will solve this issue as soon as possible! 👍


This is very good!


Nice.  To your point about the `TwoButtonShutter` operating something that is not a shutter, maybe we should change `open` to `out` and `close` to `in` so that the words make sense for the diode and yag in the cube behind tardis?

We can still name the actuated device for dark images `ssh` for slow shutter and reserve `fsh` for the fast shutter or can the `ssh` something like `beam_blk`?


this will create additional verbose output. I do not get the idea?


I mean the renaming of the asset to the uploaded file Name.

The behavior of only allowing the same type is totally fine.


I used the powershell version for a while but now i use Arduino IDE 1.8.4:
Checkout: https://github.com/prusa3d/Prusa-Firmware/pull/77

My Preferences / Addition Board URL:
https://github.com/esp8266/Arduino/releases/download/2.4.0-rc1/package_esp8266com_index.json
https://raw.githubusercontent.com/ultimachine/ArduinoAddons/master/package_ultimachine_index.json

and via board manager just search for Rambo and installed it.

Just downloaded the zip file from my github to make sure that my local version is the same as the github and i can compile it without 'any'  (except some normal warnings) problems.

You have to copy the variants\1_75mm_MK2-RAMBo13a-E3Dv6full.h to the Firmware folder and rename it to Configuration_prusa.h

For pull requests i need to edit the 1_75mm_MK2-RAMBo13a-E3Dv6full.h files and delete the Configuration_prusa.h file to be compliant with their github version.


Hm... Maybe it's a better option to rename the file extension only if it changes but not the complete file name? If we don't rename the file extension then we could end up in a .jpg file with a psd file content...


У тебя история становится общей для всех экземпляров класса:
```ruby
class A
  include Acessors

  attr_acessor_with_history :a
end

a1 = A.new
a2 = A.new
a1.a = 1
puts a1.a_history # тут корректно выведется `[1]`
puts a2.a_history # тут тоже выведется `[1]`, хотя мы не устанавливали значение `a`
```


Created multidev environment [natalie-sandbox#pr-narrativ](https://dashboard.pantheon.io/sites/ee1a9f88-1cc8-4eca-a8a6-7dc1433bb37e#pr-narrativ).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-narrativ-natalie-sandbox.pantheonsite.io/)


Не нужно к строке приводить, `send` и символы понимает


It works, however there's a more simple solution:
```
string[] emailParts = email.Split('.', '@');
string firstName = char.ToUpper(emailParts[0][0]) + emailParts[0].Substring(1);
string firstName = char.ToUpper(emailParts[1][0]) + emailParts[1].Substring(1);
return string.Format("{0} {1}", lastName, firstName);
```


Возвращать `true` должен не этот метод, а `valid?`. Этот метод - команда, а команды результатов вообще не возвращают


TeamCity libpalaso :: palaso-win32-master Continuous [Build 4.0.409.54f94f49f8bd250712dedd1f5619e5cd3ec99dc8](http://build.palaso.org/viewLog.html?buildId=98130&buildTypeId=Libpalaso_PalasoWin32masterContinuous) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:06


I think we can make this configurable, let me give that a go (so you can use Open/Close In/Out Up/Down) etc.

By NSLS-II naming, the shutter (PPS) should be PSh (Photon Shutter). The CCD shutter is really the 'EPS' shutter as it is not a safety device. I like `fsh` but would stay clear of `ssh`


Anh hai sửa lỗi với cho ví dụ giùm em nha


TeamCity libpalaso :: palaso-win32-master Continuous [Build 4.0.410.54f94f49f8bd250712dedd1f5619e5cd3ec99dc8](http://build.palaso.org/viewLog.html?buildId=98131&buildTypeId=Libpalaso_PalasoWin32masterContinuous) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


Relacionado esta esto con issue #125


TeamCity libpalaso :: palaso-win32-master Continuous [Build 4.0.411.54f94f49f8bd250712dedd1f5619e5cd3ec99dc8](http://build.palaso.org/viewLog.html?buildId=98132&buildTypeId=Libpalaso_PalasoWin32masterContinuous) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


1. Не надо в `send` кастить к строке, этот метод и символы понимает
2. Один и тот же код повтоярется в каждом методе валидации. Это лучше прямо в цикле делать, а в методы уже проверяемый значения присылать


Podia trocar `mobile-demo` por um nome que faça sentido né?


henlo i comment so i can show up in #dev


Почему тут сам `name` на формат проверяется? Это ведь просто имя атрибута, а нам надо его значение проверять


- Updated routes to have a custom route that lets you search by artist and receive all their songs
- Created music search controller action that finds all of the artists songs
- Made a view that renders the artists songs after searching for them (corresponds to action above)
- Created an ajax request for the new controller action
- Updated Music actions to have a thunk action to the ajax request I just made
- Updated my music search items to have an artist modal (artist form) that pops up on click, which displays the artists songs, when it closes it opens the post create for that song
- Updated my postform to have a more specific close modal --> closeSongModal


This function should **return** the result, not just printing it.


This function should also **return** the result, so `void` is not acceptable here.


English words will be the `Value`s in your dictionary, not the `Key`s.


I don't get the point of that, either. It's just a few patches that change configuration options


I don't think that would buy us much, the documentation also says that they are quite expensive:

```
This is ordinarily too costly, but may be more efficient than alternatives when traversal operations vastly outnumber mutations
```

 The lock contention in SongTimeline isn't that bad - `writeState` is just a special case doing very expensive stuff on the whole queue.


So then `beam_blk` or would your rather something else for the fccd dark images actuator.


This is implied in C++, but it doesn't hurt...


Naming: local variables should start with lowercase letters. So `urlsFromHandles` instead of `UrlsFromHandles`.


-Automatic Packaging and Distribution of Bioinformatics Pipelines (Sequencing PipelinE Workflow SPEW)


`url` instead of `Url`.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 4.0.412.54f94f49f8bd250712dedd1f5619e5cd3ec99dc8](http://build.palaso.org/viewLog.html?buildId=98133&buildTypeId=Libpalaso_PalasoWin32masterContinuous) outcome was **SUCCESS**
Summary: Tests passed: 3835, ignored: 191 Build time: 00:04:40


Tá misturando jQuery com vanilla js a todo momento.
Tenta colocar uma padronização. Sugiro, já que tá usando jQuery trocar:

```javascript
document.getElementById('info').innerHTML = " Encontrado:  " + JSON.parse(data).length + " profissionais próximos de você.<br>";
```

por

```javascript
var people = JSON.parse(data);
$('#info').html(" Encontrado:  " + people.length + " profissionais próximos de você.<br>");
```


Oh, now I see why you did that. Alright, renaming the file extension would be fine then, I guess?


Wrong indentation.


Missing `{ }` brackets here.


E já pode aproveitar o código de cima pra não precisar fazer o `JSON.parse` de novo. Só usar a variável `people` 😄


TeamCity Chorus :: chorus-win32-master Continuous [Build 3.0.27.89f70d7689282642d4b3000822a2eb8f8e1e7878](http://build.palaso.org/viewLog.html?buildId=98135&buildTypeId=Chorus_Win32masterContinuous) outcome was **SUCCESS**
Summary: Running Build time: 00:01:22


Ok updated per your comment https://github.com/couchbaselabs/couchbase-mobile-portal/commit/4e611bbdfa683c340c803dc68f636cf4f20b7cf4.


You can move this to a `.yarnrc` file so that no-one has to run it manually; see:

https://github.com/graphile/graphile-build/blob/master/.yarnrc

(Also I'm not sure if it's needed any more?)


Yes I think this would be an acceptable solution for everybody ;-)


You're right; I did say 3 problems. Let's compromise at 4? AllEvenIterator and SecretBox are low-hanging fruit.


oh nice, I've tried to achieve this but failed ;)


I recommend considering adding  `engines: { yarn: ">= 1.0.2", node: ">=4" }` to the `package.json`; yarn for stable workspaces support (it was a bit flakey in 1.0.1 and below) and node because it's the min version for PostGraphile.


You can shorten this:

```
.then(_.map(format))
```


Why ? its less efficient, IMO !
Many unecessary video check, so the second test will occur, and that will be avoided if "tga" test is done first.

I disapprove your change.


Is this accurate? Seems weird that satgeId is set to be equal to rdd.id.


@ambarb not sure `esh` ?

Also just made the 2 state device more generic, it is untested however


This should be renamed.


Adding additional information:


TeamCity libpalaso :: palaso-win-master Continuous [Build 4.0.103.54f94f49f8bd250712dedd1f5619e5cd3ec99dc8](http://build.palaso.org/viewLog.html?buildId=98136&buildTypeId=Libpalaso_PalasoWinmasterContinuous) outcome was **SUCCESS**
Summary: Tests passed: 3829, ignored: 191 Build time: 00:07:23


Created multidev environment [natalie-sandbox#pr-narrativ](https://dashboard.pantheon.io/sites/ee1a9f88-1cc8-4eca-a8a6-7dc1433bb37e#pr-narrativ).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-narrativ-natalie-sandbox.pantheonsite.io/)


I think this should be Automatic by default, so this can be a required field and doesn't have to be a Maybe type:

```
|> required "authorizedOverride" authorizedDecoder
```


See above, doesn't have to be Maybe.


Ok.  SO we need to make testing time for tomorrow?

I think `esh`is confusing and probably difficult for a user to related to.  e for EPS shutter?  Maybe as @wen-hu and @cmazzoli .


The metadata do not support using Javadoc tag. Can you please remove it?


@409H Not really sure. I think it came from the Google Docs.


Thanks :)


If you find yourself doing this a lot, it might be worth defining a ``maybeText`` function that you would use instead of ``text`` that would take a ``Maybe String``, so you'd have:

```
td [] [ maybeText customer.name ]
```


It's correct to do this. Is it necessary? Perhaps not now, but someday it might be. Code it right today, you don't pay tomorrow.


I find these three lines odd... why not assume `*c == DefaultEtcdConfig` and just `err := unmarshal(c)`?


This (and the one above) seems atypical. Usually structs are defined outside and then used in here. i.e.
```
type EtcdConfig strict {
        ....
        Firing Firing
        ....
}

type Firing struct {
        ....
}
```


Для C++ более традиционно `#pragma once`, хотя дело вкуса. По крайней мере, не надо придумывать уникальные для всего проекта имена переменных препроцессора.


И лучше всё-таки сделать пуллреквест, комментировать коммиты неудобно.


Actually why not just use `Firing EtcdAlertConf` and `Resolved EtcdAlertConf`? The structs look the same


Типы чаще всего именуются с заглавной. Ну, по крайней мере, раз BST именуется с заглавной, то и Vert должен бы


У структур видимость по умолчанию public, так что эта структура --- гигантское нарушение инкапсуляции


This commit was break the Profile editor


Make `"firing"` a package constant, same with `"resolved"`


No, it doesn't. ProtocolLib has memory leaks.


Перед `{` ставится пробел


<!DOCTYPE html>
<html lang="en">
<head>
<title>Running-in-the-90's</title>
<meta charset=utf-8>
</head>
make more like this


@georgehazan, but this cause untranslated menu item


PrepFor88 (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2819 of 2819 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


5 пробелов между типом и именем параметра --- никогда в промышленном коде такого не видел. Если это попытка выровнять код по вертикали, то так лучше не делать, это не сильно улучшает читаемость, но сильно замедляет рефакторинг программы


# Changes:
1. Component name from `CustomButton` to `AsylumConnectButton`
2. Add `onClick` function.


PrepFor88 (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Is there a reason [http.Post](https://golang.org/pkg/net/http/#Post) doesn't work here?


do you want this in 17.7.4?


is this a spelling mistake? Looks like `NSTemporaryDirectoryPatg` should be `NSTemporaryDirectoryPath`


@chadmazilly please review


Bitte Vorsicht mit dem Löschen von Strings. Je nach dem um welches Gerät und Android-Version können unterschiedliche strings benötigt werden.
Auf welcher Grundlage wurden oben die Strings gelöscht?


В C++ не рекомендуется начинать поля (и вообще что-либо) с подчёркивания, такие имена зарезервированы для реализации компилятора и стандартной библиотеки. То же самое касается двойного подчёркивания, оно не должно встречаться в идентификаторе не только сначала, но и вообще.


I personally think a range check would be more readable here, or throwing this in a function like:

```
func httpResponseClass(code int) int {
        return (code/100)*100
}

....
if httpResponseClass(code) == 200 {
        ....
}
```


So people don't have to add existing configs that they haven't upgraded/changed. If they've only switched the digest to SHA256 they don't need to specify the non-changed secret, for instance.

```ruby
config.action_dispatch.cookies_rotations.rotate :signed, digest: "SHA1"
```

Thus making it much clearer what config you're rotating out.


knknkn


Thanks!


Он вложенный класс, он и так друг BST :)


17.7.5 is also good, no rush here. I just wanted to test the et-pro ruleset but missed an account :)


I wasn't sure if this would work, since ARM pushes and pops registers in order from highest to lowest. However, I tested this out and it does work. I've added this in 95ed315bf99238d169bce77207c36019d8321b05.


Created multidev environment [natalie-sandbox#ci-141](https://dashboard.pantheon.io/sites/ee1a9f88-1cc8-4eca-a8a6-7dc1433bb37e#ci-141).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-141-natalie-sandbox.pantheonsite.io/)


## Global

| Changed         |   Status |
|:----------------|---------:|
| `coverage`      |     0.08 |
| `nodes_count`   |    18    |
| `texts_passing` |     2    |
| `texts_total`   |     1    |

## Words

| Changed   |   Status |
|:----------|---------:|
| `eng`     |    +3956 |
| `grc`     |    +3027 |

## Units

| Changed                                                 | Status   |
|:--------------------------------------------------------|:---------|
| `./data/tlg0059/tlg033/tlg0059.tlg033.perseus-eng2.xml` | New      |
| `./data/tlg0059/tlg033/tlg0059.tlg033.perseus-grc1.xml` | Deleted  |
| `./data/tlg0059/tlg033/tlg0059.tlg033.perseus-grc2.xml` | New      |
| `./data/tlg0059/tlg033/tlg0059.tlg033.perseus-eng2.xml` | Passing  |
| `./data/tlg0059/tlg033/tlg0059.tlg033.perseus-grc2.xml` | Passing  |

*[Hook UI build recap](http://ci.perseids.org/repo/PerseusDL/canonical-greekLit/2778)*


@vegasvin27 Not anymore. haha You're gone, deleted.


@AdSchellevis  and should I set this to be a devel package only and push to the build tomorrow? I think that would be a yes, although it's better to lower the version number in this case just to be sure....


ok, will skip, thanks


@fichtner yes please :) you can lower the version if you want


The commit comment which has `#3` on the body was not intended


[Documentation on package.json ](https://docs.npmjs.com/files/package.json)


test


Oh, I've just found the answer if you are curious:
> The `std140` and `std430` packing layouts are named for the version of the shading language with which they were introduced - `std140` with GLSL 1.40, which was part of OpenGL 3.1, and `std430` with GLSL 4.30, which was the version released with OpenGL 4.3.

_quote from OpenGL SuperBible 7th Edition_


@nfeske, @chelmuth: please try


Один оператор должен быть на одной строке, иначе отлаживаться неудобно, и не очень читаемо. И очень желательно заключать в фигурные скобки тело, даже если там один оператор


commited with new changes


Нужны всё-таки настоящие юнит-тесты. Рекомендую https://github.com/google/googletest