No it's not, see https://github.com/marmelab/admin-on-rest/blob/master/docs/RestClients.md#available-clients


var scope this please.


var scope as well.


Forgot to mention:
    - Included an example within the header file of how to use the raw time stamp values


so, if I understood, to use dictionary is a good suggestion because we need only one key like duona and all duona has a value maistas.


Server requires a specified port number as a command line argument as per direction of Jon and Ryan on previous pull request.


I am being curious now, but why `remove` and `rem` like the rest?


![](https://github.trello.services/images/mini-trello-icon.png) [Building the Story from DB](https://trello.com/c/xDLxnDBI/23-building-the-story-from-db)


@tractorcow Do you know why this was needed? I couldn’t figure out when it was NOT meant to be `ASSETS_DIR`


We implement thins in Lithuanian because we a thinking about program in lt. also, after this exception we get error and all work is continue as we want.


I feel like there's already a method for this in Apache Commons string util class.


Good catch!  I refactored this method so many times I lost track of what I had varred!


Looks good but that AWS String Utils class looks pretty redundant next to the Apache Commons String utils class in some ways.


yeah, this whole class is just to get the S3 Mock library to work with the version of the S3 library used by AEM. It is only used for testing.


Thank you for the explanation I expected as much. Although math expressions in celestialbody's are unexpected. But if you find a diffrent way of doing this without limiting the capabilities thats great.


Created multidev environment [myeap2#ci-4](https://dashboard.pantheon.io/sites/b7553ca9-57c9-419b-aeb3-8107cbda2704#ci-4).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-4-myeap2.pantheonsite.io/)


I'm looking at you latest log again more closely.   I see what you mean about the events arriving in groups!  If you decode the tick value you see these events are spaced at 1 second intervals.  Yet they arrive 2 or 3 in a single notification!  😨   Maybe this is an indication that there are networking issues and things are getting backed up.  I'm puzzled. 😕


<img width="966" alt="captura de pantalla 2017-10-03 a las 23 47 42" src="https://user-images.githubusercontent.com/20599326/31150801-4d15ec8e-a895-11e7-91de-49c46bf9d8e1.png">

It doesn't work for me. UnityTile error after returning back to the "MapScene". None of the map components are DontDestroyOnLoad


Oh, it's my mistake! I'm sorry.
Thanks for the quick reply


```
   function insertMarket(
        bytes _marketQuestion,
        uint _duration,
        address _marketId)
        public
        returns(uint index)
    {
        MarketStruct memory newMarketStruct;
        newMarketStruct.marketQuestion = _marketQuestion;
        newMarketStruct.duration = _duration;
        newMarketStruct.marketOwner = msg.sender;
        newMarketStruct.index = MarketsIndex.push(msg.sender)-1;
        MarketStructs[_marketId] = newMarketStruct;
        LogMarketCreation( _marketQuestion, msg.sender );
        return newMarketStruct.index;
    }
```

seems to work, am I on the right track?


Resolves: https://github.com/atomia/puppet-atomia/issues/271


Input file


Typo!


address: 0x05Dd62c007CDe143B402fA5Da3937C40c70b4B14

![image](https://user-images.githubusercontent.com/2313704/31151003-af4d192a-a88d-11e7-88c8-8d5208765a2f.png)


Where are we planning to use this font?


FixIntervalScheduleInterpolation (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (2177 of 2177 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-71.95%25-green.svg)


Created multidev environment [dgreat#pr-migs](https://dashboard.pantheon.io/sites/41cad7fe-472d-43a9-a470-d391b9622376#pr-migs).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-migs-dgreat.pantheonsite.io/)


Electrical Readout of NV^- Centers in Diamond


Good work! Thanks!


Wir sollten leere Namen eigentlich schon im Importer verbieten. Den Workaround können wir trotzdem behalten, auch wenn der dann dazu noch eine Fehlermeldung loggen sollte


Created multidev environment [myeap2#ci-5](https://dashboard.pantheon.io/sites/b7553ca9-57c9-419b-aeb3-8107cbda2704#ci-5).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-5-myeap2.pantheonsite.io/)


I recommend not using the '/' character because of Windows compatibility.

Instead of this

```python
smri_data = glob.glob(input_bids_dir + '/sub*/*/*T1w*.nii.gz')
```

I recommend doing this

```python
glob_str = os.path.join('sub*', '*', '*T1w*.nii.gz')
smri_data = glob.glob(os.path.join(input_bids_dir, glob_str))
```


a) some of the extra casts are there because I removed the implicit type operator which was done because I wanted to avoid any unforeseen random behavior in future. IMHO this is the safer way.
b) with mstring::ilength... if you see a need for this, feel free to implement. I, for one, dislike choosing data range which explicitly leaves room for misuse if there is basically no usecase for the extra freedoms.
c) ok, first letter shouldn't be lowercase, also makes it confusing WRT hungarian notation. I will refactor tActionId to TActionId if nobody objects. Or EActionId. I don't have a strong opinion here.
d) not sure which conversions are still needed. I was assuming to have hit everything. Please show an example.
e) Yes, I converted that to a generator function now in the last commits. Makes it more safe WRT incorrect use, and there is also some security consideration.
f) Not sure where one would want it to be a class. It can be implemented if the design changes to carry additional data along with the action context, but in the current I cannot see or imagine a such requirement.


Если что, я вернулся в какой нибудь 71 год, когда было установлено около 15 роутеров arpanet по универститету. Мтс закрыли, всё его сети положили на лопатки. Теперь у меня другой провайдер у которого 1 мб стоит 2 цента, и сеть настолько забита блокировками что даже через тор ребята такие как вк думают что я робот и даже капчу мне не доверяют.


Thanks! I fixed it in https://github.com/discourse/discourse/commit/9ff1c23a38cea1bbee247de3e842a0624e1460cd


Каждое упоминание о впн заблокировано, тор работает, но соц сети думают что я робот даже при прохождении капчи. Тут даже некоторые запросы со с ключевыми словами поиска блокируют, даже в 71 первом году у ограниченного числа пользователей arpanet было больше доступа к сети чем у меня


I recommend only using while loops if you don't know how many iterations you'll need ahead of time. Otherwise, I think a for loop is cleaner.

Instead of this

```python
while i<len(smri_data):
    gz=smri_data[i]
```

I recommend this

```python
for gz in smri_data:
```


В общем дружище, я такой '' райской'' сетью пользоваться не собираюсь. Буду иногда держать связь с тобой отсюда. Но пока что я пропаду на некоторое время пока не найду более удобный способ коммуникации чем это говно диктаторское


do not pay attention to this. It was my mistake with git.


Ooooh, this is cool! When will it be up?


fixes issue #28


Удачного и приятного кодинга Дорош, ps Malic.


uyusucnkbkc


И удали эти комментарии


Right, but that commit is actually still an error. You're no longer supposed to upload the full text of the license like you did, but rather just upload a simple template like in this commit. That was hard to figure out!


We more or less manually installed Hack on most of the desktops anyways, and several of us have terminalrc's configured to use Hack or a similar font as well...


OH. Oops! Glad you figured that out.


This is actually broken. How is `context.currentUser.teams` set? Can the team keys in that object be the team `slug` instead of the `name`? It would help a lot here.


I like this syntax better, as it's more compact.

```python
os.makedirs(path, exist_ok=True)
```


Comes from here: https://github.com/meedan/check-api/blob/develop/app/models/user.rb#L139. I don't know if something would break if we change this.


Looks like it was (also/instead) moved in the other direction?


searching `currentUser.teams` in `check-web/src` seems to return this usage only


Start timer starts an interval timer.  It does not stop until told to or destroyed.  Therefore, it only need be started  immediately after it is created, which is how the code was before.


Actually, three inputs. First three inputs all need to be real, positive values.


Fix for #15


VALID_DIR instead of TRAIN_DIR


test


Again, I recommend using the [Python OS path functions](https://docs.python.org/3/library/os.path.html).

Instead of this

```python
sub_id = gz.split('/')[-3]
```

I recommend this

```python
sub_id = os.path.dirname(os.path.dirname(gz))
```

Even though this is more verbose, it's compatible with all OSs, and you can leave the low-level directory parsing to Python.


I recommend using ```os.path.join```.


I recommend using ```os.path.join``` for each of those paths in this string.


Good point - I've added this as a task IN https://github.com/silverstripe/silverstripe-framework/issues/7419#issuecomment-333884325. At some point, a subset of this pull request would become part of 4.0 (foundational work, avoiding further htaccess changes), and the rest would become part of 4.1 (actual support for public webroot)


There isn't a root .htaccess in the installer project, it's auto-generated through `Installer.php` in framework


commit 1


I just replaced all the servers: any with server: Server.
I didn't change the code behavior, normally all tests always pass.


To save space, sorry.


Please see my earlier comment on ```os.makedirs```.


Sorry for that one and thanks for fixing it!!


Good points, added tasks in https://github.com/silverstripe/silverstripe-framework/issues/7419#issuecomment-333884325 ("Allow public/ to be moved out of BASE_PATH")


I recommend defining these parameters as constants at the beginning of the file.


I returned and undone this the compiled my own version, and the problem i mentioned [here ](https://github.com/SubtitleEdit/subtitleedit/issues/2590)was fixed


tmcell.tm


it returned to working properly.


I also recommend renaming ```gz``` to something more descriptive, like ```zip_file_path```.


Fair enough! Laravel still supports operation without rewrite support (https://laravel.com/docs/5.5/installation). I'm not sure how valueable that is really though. With `silverstripe/serve`, we have a lightweight way of running a local webserver (which supports "internal rewrites"). And if you're running another webserver, it simply should require rewrite capabilities. Nobody wants to deploy a site with `index.php` based URLs, right?


This causes it to kick out of the function every time after the first record. If there's not a match it should continue on to the next item and check again.


Why would we need to support that? There's a few hacks in core to ensure that you can't spoof the `url` parameter - it's always been a workaround, and doesn't look like it's necessary any more. Projects need to change their `.htaccess` when upgrading to 4.x, but I think that's a reasonable demand as long as we document it clearly.


Heya, the default needs to be updated to default='instance'


I'm not sure about the context surrounding this script, but it seems like 'T1w' should be set as a constant at the beginning of the file. Hypothetically, say you wanted to process T2 weighted scans. You would have to change every instance of 'T1w' to 'T2w'. I think it's best to just define this at the beginning of your file, and use that variable throughout the code. For example:

```python
SCAN_TYPE = 'T1w'
```


I believe the confusion here is that these are fixed-function only, and they are not, HLSL is different than GLSL. In DirectX11 you use the semantics to convey meaning about the intended use of the attribute. This is why YoYoGames has them, and I believe they just ignore them in OpenGL, which seems pretty harmless.
https://docs.yoyogames.com/source/dadiospice/002_reference/shaders/vertex%20formats/vertex_format_add_custom.html

Because removing these has stopped the DX systems from compiling and they do make sense in that context, I am going to add them back and they can simply be ignored for OpenGL.
https://gamedev.stackexchange.com/questions/70821/do-the-predefined-hlsl-semantics-carry-any-meaning


These joins work perfectly, but you should try to do these using sub-queries instead.


I'm so excited about this new topic I'm dealing with; as much as standing in front of a coffee shop to make my favorite new order with them!


not sure If I'm doing this correctly !! the commit changes button, didn't show up to me anywhere on my page?!


wrong readme


For long sets of parameters, I recommend the following syntax. It is easy to read and gives you a lot of space to work with.

```python
interface = Function(
    input_names='normalized_class_images',
    output_names='list_norm_images',
    function=transform_list
)
list_normalized_images = pe.Node(interface=interface, name='list_normalized_images')
```


this is `ir.qweb.field` by now: https://github.com/OCA/OCB/blob/10.0/odoo/addons/base/ir/ir_qweb/fields.py#L47


address
0x2A7D04018D7295D8069Ec9721eE415c4Bdc57909

![image](https://user-images.githubusercontent.com/2313704/31152774-8834128c-a895-11e7-88ff-bc19fb1b004b.png)


I'm going to remove this useless variable


this probably should be https://github.com/OCA/OCB/blob/10.0/odoo/addons/base/ir/ir_qweb/fields.py#L85 by now


**Whoops!**

There were *8 warnings* that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.

**WARNINGS**
[`src/data/glossary.yaml`](https://github.com/Google/WebFundamentals/blame/1c7e6454f6c8d1cc98da43035e5bfa2fcc3a3f28/src/data/glossary.yaml) - add to home screen is missing description
[`src/data/glossary.yaml`](https://github.com/Google/WebFundamentals/blame/1c7e6454f6c8d1cc98da43035e5bfa2fcc3a3f28/src/data/glossary.yaml) - first contentful paint is missing description
[`src/data/glossary.yaml`](https://github.com/Google/WebFundamentals/blame/1c7e6454f6c8d1cc98da43035e5bfa2fcc3a3f28/src/data/glossary.yaml) - first meaningful paint is missing description
[`src/data/glossary.yaml`](https://github.com/Google/WebFundamentals/blame/1c7e6454f6c8d1cc98da43035e5bfa2fcc3a3f28/src/data/glossary.yaml) - requestanimationframe is missing description
[`src/data/glossary.yaml`](https://github.com/Google/WebFundamentals/blame/1c7e6454f6c8d1cc98da43035e5bfa2fcc3a3f28/src/data/glossary.yaml) - requestidlecallback is missing description
[`src/data/glossary.yaml`](https://github.com/Google/WebFundamentals/blame/1c7e6454f6c8d1cc98da43035e5bfa2fcc3a3f28/src/data/glossary.yaml) - time to first byte is missing description
[`src/data/glossary.yaml`](https://github.com/Google/WebFundamentals/blame/1c7e6454f6c8d1cc98da43035e5bfa2fcc3a3f28/src/data/glossary.yaml) - time to first paint is missing description
[`src/data/glossary.yaml`](https://github.com/Google/WebFundamentals/blame/1c7e6454f6c8d1cc98da43035e5bfa2fcc3a3f28/src/data/glossary.yaml) - time to interactive is missing description


These one-line ```for``` and ```if``` statements save a little space but are generally frowned upon in most programming languages. For better readability, I recommend using two lines for even simple for loops like this.


… does it still look good?


s/Development/Documentation/


Probably a typo, shouldn't it say "I don't know that one!" or "I don't recognise that one!"

cheers,
Fannar


This line is pretty hard for me to understand. How about we break it up into multiple lines by defining some variables with these parameters and combine them in the final vbm_preprocess.connect() statement?


How do you know if you have error_alloc and error_eptystack at the same time? Print log at the moment, when error appears. I'll show you a good version of C-style log system, when we will start processor.


new


`chrome` and `browser` are equivalent and cross-browser?


@icomrade this change here


Fair call.


Please see my earlier comment on ```os.path.join```.


Please see my earlier comment on one-line ```if``` and ```for``` statements.


You can either run the bot via VSC or using the .bat file.


Yes, I tested on Firefox too


Need breaks for these


You don't understand me, I meant that you should declare fields like size, capacity, etc. in .c file, if you're on C code, but you're on C++ code, you can declare fields above as a private, or get rid of c++ code and declare it like a C structure.


Ahh yes it is that..at least my icon is right...


`cuda-memcheck` shows an error here:
```
========= Program hit cudaErrorInvalidResourceHandle (error 33) due to "invalid resource handle" on CUDA API call to cudaLaunch.
```
It goes away if I add a CudaDeviceScope() immediately before this line.

This doesn't fix my test errors, but it should still probably be fixed.


You don't check return value of fopen. What if you can't open file...


@timse this commit is the reason for https://github.com/Jimdo/typings-for-css-modules-loader/issues/20


I recommend writing a function to do this. In that function, I recommend creating this programmatically using saved parameters like fwhm. Will the prefixes ever charge? For example, is it possible that you won't have c2, depending on your earlier settings?


Check the return value of calloc too. You always need to google "man <name of library func>" and read description, return values and error, which occurs, before use it.


npm run errors out if we have this, I tried to find where we replace it but we don't seem to anywhere (not even in the build processes), verified that by checking a build SDK and it was still `__VERSION__`


Eurgh need to remove this :/


Same advice here. I recommend creating a function to do this part.


About code-style. The good style is start functions without brace at the same line, e.g.:
stack_t :: ~stack_t ()
{


@Alex-the-666 What version will this be implemented in?


This commit is pretty much a 'throw away' commit to get most of the noise around line-endings and the `'use strict`' additions out of the way


The used positions are :
- `5R2/8/2k5/8/8/8/8/8 w - -` (forbidden columns and rows)
- `8/8/8/8/2r5/8/K7/8 w - -` (negative opportunity)
- `8/8/8/8/2r5/8/8/K7 b - -` (positive opportunity)
- `1k5b/1nnpp1p1/8/5N2/3P4/8/1r6/8 w - -` (simple position to solve)

We also get ~7% gain of speed.


Delete such comments before commit, commit should be clear :)


Done in https://github.com/qgis/QGIS/commit/4f34f9442c18ce74268c75de21ac4ef1eb0b7695, thanks


This commit was done by running eslint manually (no grunt) with the `--fix` option, I believe it mostly 'fixes' whitespace and stylistic things, separated from the cli/ to reduce noise and allow easier focus on cli/ (the more important one to make sure aint broke)


teste


How do I download and use this function? I've got the package velox installed, but I don't quite know how to install your forked version. Any advice?


This breaks `resnet50_trainer.py`:
```
E1003 23:06:58.207180  6118 operator_schema.cc:99] Argument 'is_test' is required for Operator 'ImageInput'.
```


This commit was done by running eslint manually (no grunt) with the `--fix` option, I believe it mostly 'fixes' whitespace and stylistic things, it's probably deserving of a cursory review


This version changes the datastore format. Please revert it or get this PR accepted ASAP: https://github.com/NixOS/nixpkgs/pull/29942 , so that at least manual upgrades are possible, since the built-in migration is broken on NixOS. As it stands, anyone who enables the ipfs service and uses this change will be dealing with an ipfs service that doesn;t start anymore.


This commit was done by fixing all of the remaining warnings by hand, I was not brutal in my updating of var to let/const to avoid any unnecessary problems, I just aimed to keep eslint happy


There is no JSC_URL constant, I'm not sure where to grab that from or if this should be removed


It's usually frowned upon to catch all exceptions with no differentiation. In this case, how does COINSTAC deal with stderr? Will the error message bubble up to anyone? If so, will they be Python users who can understand a stack trace? I recommend figuring out what exceptions you expect to occur and then handling each one separately with its own custom message. Also, please follow up with Ross and let me know how stderr is handled with Docker.


GET


@csuwildcat, this is the change I made to get the recursion error to clear.

Is this what you meant from your comment on issue https://github.com/x-tag/core-2/issues/3


[R/GetAvailablePoints.R:5:3:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/GetAvailablePoints.R#L5) *warning:* **no visible global function definition for ‘.init_global_vars’**
```r
  .init_global_vars()
  ^~~~~~~~~~~~~~~~~
```
[R/GetAvailablePoints.R:10:53:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/GetAvailablePoints.R#L10) *warning:* **no visible global function definition for ‘.create_counter_env’**
```r
    test_file(test_file, reporter = "silent", env = .create_counter_env())
                                                    ^~~~~~~~~~~~~~~~~~~
```
[R/GetAvailablePoints.R:13:10:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/GetAvailablePoints.R#L13) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  return (.add_points(.GlobalEnv$test_available_points, .GlobalEnv$file_points, .GlobalEnv$map_to_desc))
         ^
```
[R/GetAvailablePoints.R:13:11:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/GetAvailablePoints.R#L13) *warning:* **no visible global function definition for ‘.add_points’**
```r
  return (.add_points(.GlobalEnv$test_available_points, .GlobalEnv$file_points, .GlobalEnv$map_to_desc))
          ^~~~~~~~~~~
```
[R/GetAvailablePoints.R:30:10:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/GetAvailablePoints.R#L30) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  return (all_available_points)
         ^
```
[R/GetAvailablePoints.R:35:3:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/GetAvailablePoints.R#L35) *warning:* **no visible global function definition for ‘.define_counter_functions’**
```r
  .define_counter_functions(test_env)
  ^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/GetAvailablePoints.R:36:10:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/GetAvailablePoints.R#L36) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  return (test_env)
         ^
```
[R/GetAvailablePoints.R:40:3:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/GetAvailablePoints.R#L40) *warning:* **no visible global function definition for ‘.source_files’**
```r
  .source_files(test_env)
  ^~~~~~~~~~~~~
```
[R/ResultsCreator.R:8:15:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/ResultsCreator.R#L8) *warning:* **no visible global function definition for ‘.get_status_for_test’**
```r
    status <- .get_status_for_test(test)
              ^~~~~~~~~~~~~~~~~~~~
```
[R/ResultsCreator.R:9:16:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/ResultsCreator.R#L9) *warning:* **no visible global function definition for ‘.create_message_for_test’**
```r
    message <- .create_message_for_test(test)
               ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ResultsJsonParser.R:7:51:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/ResultsJsonParser.R#L7) *warning:* **no visible global function definition for ‘unbox’, Did you mean 'box'?**
```r
    results[[length(results) + 1]] <- list(name = unbox(desc), points = points)
                                                  ^~~~~
```
[R/ResultsJsonParser.R:9:10:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/ResultsJsonParser.R#L9) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  return (results)
         ^
```
[R/ResultsJsonParser.R:16:25:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/ResultsJsonParser.R#L16) *warning:* **no visible global function definition for ‘.create_json_test_result’**
```r
    test_json_result <- .create_json_test_result(test_result)
                        ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ResultsJsonParser.R:35:20:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/ResultsJsonParser.R#L35) *warning:* **no visible global function definition for ‘toJSON’**
```r
  json <- enc2utf8(toJSON(results, pretty = FALSE))
                   ^~~~~~
```
[R/ResultsJsonParser.R:36:11:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/ResultsJsonParser.R#L36) *warning:* **no visible global function definition for ‘prettify’, Did you mean 'pretty'?**
```r
  json <- prettify(json)
          ^~~~~~~~
```
[R/RunTests.R:12:19:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/RunTests.R#L12) *warning:* **no visible global function definition for ‘.run_tests_project’**
```r
  test_results <- .run_tests_project(project_path)
                  ^~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:14:19:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/RunTests.R#L14) *warning:* **no visible global function definition for ‘.create_json_results’**
```r
  json_results <- .create_json_results(test_results)
                  ^~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:15:3:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/RunTests.R#L15) *warning:* **no visible global function definition for ‘.write_json’**
```r
  .write_json(json_results, ".results.json")
  ^~~~~~~~~~~
```
[R/RunTests.R:18:5:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/RunTests.R#L18) *warning:* **no visible global function definition for ‘.print_results_from_json’**
```r
    .print_results_from_json(json_results)
    ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:31:21:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/RunTests.R#L31) *warning:* **no visible global function definition for ‘.run_tests_file’**
```r
    file_results <- .run_tests_file(test_file, test_env)
                    ^~~~~~~~~~~~~~~
```
[R/RunTests.R:31:48:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/RunTests.R#L31) *warning:* **no visible binding for global variable ‘test_env’**
```r
    file_results <- .run_tests_file(test_file, test_env)
                                               ^~~~~~~~
```
[R/RunTests.R:39:3:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/RunTests.R#L39) *warning:* **no visible global function definition for ‘.define_tester_functions’**
```r
  .define_tester_functions(test_env)
  ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:41:12:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/RunTests.R#L41) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
  tryCatch({.source_files(test_env)},
           ^
```
[R/RunTests.R:41:13:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/RunTests.R#L41) *warning:* **no visible global function definition for ‘.source_files’**
```r
  tryCatch({.source_files(test_env)},
            ^~~~~~~~~~~~~
```
[R/RunTests.R:43:10:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/RunTests.R#L43) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  return (test_env)
         ^
```
[R/RunTests.R:55:5:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/RunTests.R#L55) *warning:* **no visible global function definition for ‘test_that’**
```r
    test_that(desc, code)
    ^~~~~~~~~
```
[R/RunTests.R:68:3:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/RunTests.R#L68) *warning:* **no visible global function definition for ‘test_file’**
```r
  test_file_output <- test_file(file_path, reporter = "silent", env = .create_test_env())
  ^~~~~~~~~
```
[R/RunTests.R:68:71:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/RunTests.R#L68) *warning:* **no visible global function definition for ‘.create_test_env’**
```r
  test_file_output <- test_file(file_path, reporter = "silent", env = .create_test_env())
                                                                      ^~~~~~~~~~~~~~~~
```
[R/RunTests.R:70:24:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/RunTests.R#L70) *warning:* **no visible global function definition for ‘.create_file_results’**
```r
  test_file_results <- .create_file_results(test_file_output, points, .GlobalEnv$points_for_all_tests)
                       ^~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:78:3:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/RunTests.R#L78) *warning:* **no visible global function definition for ‘.write_json’**
```r
  .write_json(list(list(backtrace = list())), ".results.json")
  ^~~~~~~~~~~
```
[R/RunTests.R:85:3:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/RunTests.R#L85) *warning:* **no visible global function definition for ‘run_tests’**
```r
  run_tests(getwd(), bol)
  ^~~~~~~~~
```
[R/RunTests.R:93:23:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/RunTests.R#L93) *warning:* **no visible global function definition for ‘.get_available_points’**
```r
  available_points <- .get_available_points(project_path)
                      ^~~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:95:19:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/RunTests.R#L95) *warning:* **no visible global function definition for ‘.create_available_points_json_results’**
```r
  json_results <- .create_available_points_json_results(available_points)
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:96:3:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/R/RunTests.R#L96) *warning:* **no visible global function definition for ‘.write_json’**
```r
  .write_json(json_results, ".available_points.json")
  ^~~~~~~~~~~
```
[tests/testthat/resources/simple_source_code_error/R/main.R:1:1:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/tests/testthat/resources/simple_source_code_error/R/main.R#L1) *style:* **Variable or function name should be snake_case.**
```r
RetTrue <- function() {
^~~~~~~
```
[tests/testthat/resources/simple_source_code_error/R/main.R:6:19:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/tests/testthat/resources/simple_source_code_error/R/main.R#L6) *style:* **Place a space before left parenthesis, except in a function call.**
```r
RetOne <- function() {
                  ^
```
[tests/testthat/resources/simple_source_code_error/R/main.R:6:22:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/tests/testthat/resources/simple_source_code_error/R/main.R#L6) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
RetOne <- function() {
                     ^
```
[tests/testthat/resources/simple_source_code_error/R/main.R:7:9:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/tests/testthat/resources/simple_source_code_error/R/main.R#L7) *error:* **unexpected 'in'**
```r
  error in source code
        ^
```
[tests/testthat/resources/simple_source_code_error/tests/testthat/helperTMC.R:4:1:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/tests/testthat/resources/simple_source_code_error/tests/testthat/helperTMC.R#L4) *style:* **Variable or function name should be snake_case.**
```r
pointsForAllTests <- function(points) {
^~~~~~~~~~~~~~~~~
```
[tests/testthat/resources/simple_source_code_error/tests/testthat/helperTMC.R:12:3:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/tests/testthat/resources/simple_source_code_error/tests/testthat/helperTMC.R#L12) *warning:* **no visible global function definition for ‘test_that’**
```r
  test_that(desc, code)
  ^~~~~~~~~
```
[tests/testthat/resources/simple_source_code_error/tests/testthat/testMain.R:1:9:](https://github.com/RTMC/tmc-r-tester/blob/2f7349d056b37b4d6751983dd1d0e5bc95ea277d/tests/testthat/resources/simple_source_code_error/tests/testthat/testMain.R#L1) *style:* **Only use double-quotes.**
```r
library('testthat')
        ^~~~~~~~~~
```


Yes this is something that I was going to discuss with Ross.

On Tue, Oct 3, 2017 at 5:13 PM, everner-ds <notifications@github.com> wrote:

> It's usually frowned upon to catch all exceptions with no differentiation.
> In this case, how does COINSTAC deal with stderr? Will the error message
> bubble up to anyone? If so, will they be Python users who can understand a
> stack trace? I recommend figuring out what exceptions you expect to occur
> and then handling each one separately with its own custom message. Also,
> please follow up with Ross and let me know how stderr is handled with
> Docker.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/MRN-Code/Coinstac_VBM_computation/commit/243ffbbbe38e3750e4a57e855e189c3a21347495#commitcomment-24741064>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AFKj-18VhWEzVsmWFXVhNIML5aW88BWjks5sor-CgaJpZM4Psvdk>
> .
>


The only problem with that is you will see the bar when it first goes into the vision screen because cal_status starts off as CALIBRATION_UNCALIBRATED so after a split sec the bar goes away when the real value is set.


This commit was done by fixing all of the remaining warnings by hand, I was not brutal in my updating of var to let/const to avoid any unnecessary problems, I just aimed to keep eslint happy. I've ran through some basic building smokes with the changes but nothing too heavy, again it probably deserves a cursory review and the module creation/build processes exercising


I completely forgot there was a .js file underneath templates, so errr this commit adds that to the setup and lints it


__apiary.manifest contains reference to non-existent file in repository.__ (Autogenerated message from apiary.io)
+ apiary.apib


How is 'success' used by the pipeline in COINSTAC? In single-shot ridge regression, this parameter doesn't exist. Again, probably worth discussing as a group.


The above scenario is for when it is already calibrated.


Oh, well. Thanks a lot! I didn't anticipate this in a minor version…


![](https://github.trello.services/images/mini-trello-icon.png) [(5) Bootstrap missing from heroku](https://trello.com/c/ROS4SK4A/55-5-bootstrap-missing-from-heroku)


remove extra space


![](https://github.trello.services/images/mini-trello-icon.png) [(3) Rework Queries](https://trello.com/c/avFF9Gyo/50-3-rework-queries)


As you use this block twice in your code, I recommend placing it into a function called 'cleanup_tmp_files' or something.


![](https://github.trello.services/images/mini-trello-icon.png) [(3) Rework Routes](https://trello.com/c/HnlfIdMK/51-3-rework-routes)


![](https://github.trello.services/images/mini-trello-icon.png) [(3) Fix Server Side Rendering](https://trello.com/c/Tgy5m8M0/52-3-fix-server-side-rendering)


![](https://github.trello.services/images/mini-trello-icon.png) [(2) Update to HttpClient](https://trello.com/c/g9KQIKPQ/53-2-update-to-httpclient)


I recommend moving this outside your loop, which will remove the need for the ```if``` statement.


I recommend saving error messages as constants at the top of your file, in case you want to use them elsewhere.


This is the commit that has broken the build: https://github.com/shazChaudhry/ci-stack/commit/99f334cdacda8fc33c3690f21e5937fed7b28273


Hi Biye,

Just a note, you just made your `keys.json` file public by pushing it to this repo.

Thanks,
Simon Mo


yeah, let's just change how cal_status is initialized in ui.c
```int cal_perc = CALIBRATION_CALIBRATED;```


Resolves: https://github.com/atomia/puppetmaster-gui/issues/162


how do you guys know what to change in these updates to make it 1.2?


Why are we still trying this? It has already been pointed out that Time.optimium() is NOT EVER going to work as a way to scale this, due to the speeds of different machines.

This test, when it fails, will be the 46th consecutive failed test with the nearly the EXACT same idea.

Please. for your sanity and for mine, move on to a new idea.


Coolio, that'll work!


Possible workarounds(?):
- Move the hook to the next instruction after
- Each time a dll loads, check for INT3 on NtQIP and delay the hook until it's gone
- Copy the bytes from the on-disk version of ntdll instead (if they are modified in memory)
- Use InstrumentationCallback as a post-syscall-execution hook to change the parameters/result


Maybe I'm wrong, but I thought that VBM was supposed to optionally accept data in a non-BIDS format. Is that the case, or are we only accepting data in BIDS format?


Oh! Great Thanks!..  Thanks for the notice!


Try calling `TryExtractParamter` instead of `Evaluate` that would generate and return a parameter instead of ConstantExpression which would get inlined in the SQL.


Todo código foi feito em apenas um commit


ok


There were conflicts in the code and you just merged the changes with the conflicts... I think you didnt diff your changes..


Ajuste de formatação é necessário


Please see my comment below on one-line ```for``` and ```if``` statements.


Ignorar a pasta bin


saw approval from jedmccaleb
at https://github.com/MonsieurNicolas/stellar-core/commit/50e6169edbf9c8b314ba3e5c528c16b357aae29e


merging MonsieurNicolas/stellar-core/ledgerDeltaAsserts = 50e6169e into auto


MonsieurNicolas/stellar-core/ledgerDeltaAsserts = 50e6169e merged ok, testing candidate = 8157facf


diff your changes before committing.. This is definitely not right.


não existe implementação de herança no fonte, precisa ter no mínimo duas classes


[R/plotting.R:569:13:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/R/plotting.R#L569) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          if(length(whPlotObj)==0 | !layerFromPlotObj) {
            ^
```
[R/plotting.R:569:31:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/R/plotting.R#L569) *style:* **Put spaces around all infix operators.**
```r
          if(length(whPlotObj)==0 | !layerFromPlotObj) {
                             ~^~~
```
[tests/testthat/test-Plot-nonVisual.R:1:58:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L1) *style:* **Commas should always have a space after.**
```r
test_that("Plotting types without visual checking works",{
                                                         ^
```
[tests/testthat/test-Plot-nonVisual.R:4:1:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L4) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[tests/testthat/test-Plot-nonVisual.R:7:1:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L7) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[tests/testthat/test-Plot-nonVisual.R:8:18:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L8) *style:* **Commas should always have a space after.**
```r
  s1 <- stack(r1,r2)
                 ^
```
[tests/testthat/test-Plot-nonVisual.R:11:1:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L11) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[tests/testthat/test-Plot-nonVisual.R:12:5:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L12) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(interactive()) {
    ^
```
[tests/testthat/test-Plot-nonVisual.R:14:1:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L14) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[tests/testthat/test-Plot-nonVisual.R:17:38:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L17) *style:* **Put spaces around all infix operators.**
```r
    expect_true(length(a$isBaseLayer)==1)
                                    ~^~~
```
[tests/testthat/test-Plot-nonVisual.R:18:49:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L18) *style:* **Put spaces around all infix operators.**
```r
    expect_true(length(a$curr@quickPlotGrobList)==1)
                                               ~^~~
```
[tests/testthat/test-Plot-nonVisual.R:19:1:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L19) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[tests/testthat/test-Plot-nonVisual.R:20:44:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L20) *style:* **Put spaces around all infix operators.**
```r
    expect_silent(Plot(r1, axes = TRUE, new=TRUE))
                                          ~^~
```
[tests/testthat/test-Plot-nonVisual.R:22:38:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L22) *style:* **Put spaces around all infix operators.**
```r
    expect_true(length(a$isBaseLayer)==2)
                                    ~^~~
```
[tests/testthat/test-Plot-nonVisual.R:23:49:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L23) *style:* **Put spaces around all infix operators.**
```r
    expect_true(length(a$curr@quickPlotGrobList)==2)
                                               ~^~~
```
[tests/testthat/test-Plot-nonVisual.R:24:52:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L24) *style:* **Put spaces around all infix operators.**
```r
    expect_true(length(a$curr@quickPlotGrobList$r1)==1)
                                                  ~^~~
```
[tests/testthat/test-Plot-nonVisual.R:25:1:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L25) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[tests/testthat/test-Plot-nonVisual.R:28:38:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L28) *style:* **Put spaces around all infix operators.**
```r
    expect_true(length(a$isBaseLayer)==2)
                                    ~^~~
```
[tests/testthat/test-Plot-nonVisual.R:29:49:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L29) *style:* **Put spaces around all infix operators.**
```r
    expect_true(length(a$curr@quickPlotGrobList)==2)
                                               ~^~~
```
[tests/testthat/test-Plot-nonVisual.R:30:52:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L30) *style:* **Put spaces around all infix operators.**
```r
    expect_true(length(a$curr@quickPlotGrobList$r1)==2)
                                                  ~^~~
```
[tests/testthat/test-Plot-nonVisual.R:31:1:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L31) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[tests/testthat/test-Plot-nonVisual.R:34:38:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L34) *style:* **Put spaces around all infix operators.**
```r
    expect_true(length(a$isBaseLayer)==3)
                                    ~^~~
```
[tests/testthat/test-Plot-nonVisual.R:35:49:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L35) *style:* **Put spaces around all infix operators.**
```r
    expect_true(length(a$curr@quickPlotGrobList)==3)
                                               ~^~~
```
[tests/testthat/test-Plot-nonVisual.R:36:52:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L36) *style:* **Put spaces around all infix operators.**
```r
    expect_true(length(a$curr@quickPlotGrobList$r2)==1)
                                                  ~^~~
```
[tests/testthat/test-Plot-nonVisual.R:37:1:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L37) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[tests/testthat/test-Plot-nonVisual.R:40:38:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L40) *style:* **Put spaces around all infix operators.**
```r
    expect_true(length(a$isBaseLayer)==5)
                                    ~^~~
```
[tests/testthat/test-Plot-nonVisual.R:41:49:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L41) *style:* **Put spaces around all infix operators.**
```r
    expect_true(length(a$curr@quickPlotGrobList)==5)
                                               ~^~~
```
[tests/testthat/test-Plot-nonVisual.R:42:62:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L42) *style:* **Put spaces around all infix operators.**
```r
    expect_true(length(a$curr@quickPlotGrobList$`s1$layer.1`)==1)
                                                            ~^~~
```
[tests/testthat/test-Plot-nonVisual.R:43:1:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L43) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[tests/testthat/test-Plot-nonVisual.R:46:38:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L46) *style:* **Put spaces around all infix operators.**
```r
    expect_true(length(a$isBaseLayer)==5)
                                    ~^~~
```
[tests/testthat/test-Plot-nonVisual.R:47:49:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L47) *style:* **Put spaces around all infix operators.**
```r
    expect_true(length(a$curr@quickPlotGrobList)==5)
                                               ~^~~
```
[tests/testthat/test-Plot-nonVisual.R:48:62:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L48) *style:* **Put spaces around all infix operators.**
```r
    expect_true(length(a$curr@quickPlotGrobList$`s1$layer.1`)==2)
                                                            ~^~~
```
[tests/testthat/test-Plot-nonVisual.R:49:1:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L49) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[tests/testthat/test-Plot-nonVisual.R:55:1:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L55) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[tests/testthat/test-Plot-nonVisual.R:58:38:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L58) *style:* **Put spaces around all infix operators.**
```r
    expect_true(length(a$isBaseLayer)==5)
                                    ~^~~
```
[tests/testthat/test-Plot-nonVisual.R:59:49:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L59) *style:* **Put spaces around all infix operators.**
```r
    expect_true(length(a$curr@quickPlotGrobList)==5)
                                               ~^~~
```
[tests/testthat/test-Plot-nonVisual.R:60:62:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L60) *style:* **Put spaces around all infix operators.**
```r
    expect_true(length(a$curr@quickPlotGrobList$`s1$layer.1`)==2)
                                                            ~^~~
```
[tests/testthat/test-Plot-nonVisual.R:61:52:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L61) *style:* **Put spaces around all infix operators.**
```r
    expect_true(length(a$curr@quickPlotGrobList$r1)==2)
                                                  ~^~~
```
[tests/testthat/test-Plot-nonVisual.R:62:1:](https://github.com/PredictiveEcology/quickPlot/blob/f1816628d8fa3d0aba371b0f6847e1bafba173f8/tests/testthat/test-Plot-nonVisual.R#L62) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```


I also recommend saving these paths as strings at the top of the file.


colocar nomes significativos para os testes


whoops, you're right!


Está testando apenas a classe gerente, implementar testes de funcionário.
Usar métodos da classe "pai" no testes de gerente


Todo fonte foi versionando em apenas um commit, importante ter vários


remover os arquivos da compilação


why is this better please?


Gerente? Esse código compila?


@mlynch do you have any plan to support masks on ion-input?


`$identifierField` is undefined


Esse teste não verifica nada, precisa de assert... com alguma coisa


Closes #3


That is the first test case we are going to start with, I checked this with
Vince. It is also simple enough where the coinstac UI can read the
directory in which the BIDS data lies and go from there. I will add the
other case later. I kind of created an MVP to begin with that is working
with Coinstac, that takes BIDS data and creates the VMB output.

On Tue, Oct 3, 2017 at 5:28 PM, everner-ds <notifications@github.com> wrote:

> Maybe I'm wrong, but I thought that VBM was supposed to optionally accept
> data in a non-BIDS format. Is that the case, or are we only accepting data
> in BIDS format?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/MRN-Code/Coinstac_VBM_computation/commit/243ffbbbe38e3750e4a57e855e189c3a21347495#commitcomment-24741298>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AFKj-0rc_wzsexyLP0i-mqT0s2CGXqUyks5sosMfgaJpZM4Psvdk>
> .
>


we're gonna have to talk about what this cog is about :P


OK


Not that I don't like it, but I have to ask. Why did you decide to replace the Bugzilla icon with this?


Já arrumado!


Yep, looks like that's what is for me also. I'll merge you at some point. Don't worry about my branch until you guys have submitted Herring.


Ha!  Thanks for pointing this out.  I will update those files as well.


Thanks you for updating and maintaining! Using this in production


[R/GetAvailablePoints.R:5:3:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/GetAvailablePoints.R#L5) *warning:* **no visible global function definition for ‘.init_global_vars’**
```r
  .init_global_vars()
  ^~~~~~~~~~~~~~~~~
```
[R/GetAvailablePoints.R:10:53:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/GetAvailablePoints.R#L10) *warning:* **no visible global function definition for ‘.create_counter_env’**
```r
    test_file(test_file, reporter = "silent", env = .create_counter_env())
                                                    ^~~~~~~~~~~~~~~~~~~
```
[R/GetAvailablePoints.R:13:10:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/GetAvailablePoints.R#L13) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  return (.add_points(.GlobalEnv$test_available_points, .GlobalEnv$file_points, .GlobalEnv$map_to_desc))
         ^
```
[R/GetAvailablePoints.R:13:11:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/GetAvailablePoints.R#L13) *warning:* **no visible global function definition for ‘.add_points’**
```r
  return (.add_points(.GlobalEnv$test_available_points, .GlobalEnv$file_points, .GlobalEnv$map_to_desc))
          ^~~~~~~~~~~
```
[R/GetAvailablePoints.R:30:10:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/GetAvailablePoints.R#L30) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  return (all_available_points)
         ^
```
[R/GetAvailablePoints.R:35:3:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/GetAvailablePoints.R#L35) *warning:* **no visible global function definition for ‘.define_counter_functions’**
```r
  .define_counter_functions(test_env)
  ^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/GetAvailablePoints.R:36:10:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/GetAvailablePoints.R#L36) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  return (test_env)
         ^
```
[R/GetAvailablePoints.R:40:3:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/GetAvailablePoints.R#L40) *warning:* **no visible global function definition for ‘.source_files’**
```r
  .source_files(test_env)
  ^~~~~~~~~~~~~
```
[R/ResultsCreator.R:8:15:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/ResultsCreator.R#L8) *warning:* **no visible global function definition for ‘.get_status_for_test’**
```r
    status <- .get_status_for_test(test)
              ^~~~~~~~~~~~~~~~~~~~
```
[R/ResultsCreator.R:9:16:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/ResultsCreator.R#L9) *warning:* **no visible global function definition for ‘.create_message_for_test’**
```r
    message <- .create_message_for_test(test)
               ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ResultsJsonParser.R:7:51:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/ResultsJsonParser.R#L7) *warning:* **no visible global function definition for ‘unbox’, Did you mean 'box'?**
```r
    results[[length(results) + 1]] <- list(name = unbox(desc), points = points)
                                                  ^~~~~
```
[R/ResultsJsonParser.R:9:10:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/ResultsJsonParser.R#L9) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  return (results)
         ^
```
[R/ResultsJsonParser.R:16:25:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/ResultsJsonParser.R#L16) *warning:* **no visible global function definition for ‘.create_json_test_result’**
```r
    test_json_result <- .create_json_test_result(test_result)
                        ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ResultsJsonParser.R:19:36:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/ResultsJsonParser.R#L19) *warning:* **no visible global function definition for ‘unbox’, Did you mean 'box'?**
```r
  json_results <- list(runStatus = unbox("success"), backtrace = list(), testResults = json_test_results)
                                   ^~~~~
```
[R/ResultsJsonParser.R:36:20:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/ResultsJsonParser.R#L36) *warning:* **no visible global function definition for ‘toJSON’**
```r
  json <- enc2utf8(toJSON(results, pretty = FALSE))
                   ^~~~~~
```
[R/ResultsJsonParser.R:37:11:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/ResultsJsonParser.R#L37) *warning:* **no visible global function definition for ‘prettify’, Did you mean 'pretty'?**
```r
  json <- prettify(json)
          ^~~~~~~~
```
[R/RunTests.R:12:19:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/RunTests.R#L12) *warning:* **no visible global function definition for ‘.run_tests_project’**
```r
  test_results <- .run_tests_project(project_path)
                  ^~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:14:19:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/RunTests.R#L14) *warning:* **no visible global function definition for ‘.create_json_results’**
```r
  json_results <- .create_json_results(test_results)
                  ^~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:15:3:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/RunTests.R#L15) *warning:* **no visible global function definition for ‘.write_json’**
```r
  .write_json(json_results, ".results.json")
  ^~~~~~~~~~~
```
[R/RunTests.R:18:5:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/RunTests.R#L18) *warning:* **no visible global function definition for ‘.print_results_from_json’**
```r
    .print_results_from_json(json_results)
    ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:31:21:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/RunTests.R#L31) *warning:* **no visible global function definition for ‘.run_tests_file’**
```r
    file_results <- .run_tests_file(test_file, test_env)
                    ^~~~~~~~~~~~~~~
```
[R/RunTests.R:31:48:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/RunTests.R#L31) *warning:* **no visible binding for global variable ‘test_env’**
```r
    file_results <- .run_tests_file(test_file, test_env)
                                               ^~~~~~~~
```
[R/RunTests.R:39:3:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/RunTests.R#L39) *warning:* **no visible global function definition for ‘.define_tester_functions’**
```r
  .define_tester_functions(test_env)
  ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:41:12:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/RunTests.R#L41) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
  tryCatch({.source_files(test_env)},
           ^
```
[R/RunTests.R:41:13:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/RunTests.R#L41) *warning:* **no visible global function definition for ‘.source_files’**
```r
  tryCatch({.source_files(test_env)},
            ^~~~~~~~~~~~~
```
[R/RunTests.R:43:10:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/RunTests.R#L43) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  return (test_env)
         ^
```
[R/RunTests.R:55:5:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/RunTests.R#L55) *warning:* **no visible global function definition for ‘test_that’**
```r
    test_that(desc, code)
    ^~~~~~~~~
```
[R/RunTests.R:68:3:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/RunTests.R#L68) *warning:* **no visible global function definition for ‘test_file’**
```r
  test_file_output <- test_file(file_path, reporter = "silent", env = .create_test_env())
  ^~~~~~~~~
```
[R/RunTests.R:68:71:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/RunTests.R#L68) *warning:* **no visible global function definition for ‘.create_test_env’**
```r
  test_file_output <- test_file(file_path, reporter = "silent", env = .create_test_env())
                                                                      ^~~~~~~~~~~~~~~~
```
[R/RunTests.R:70:24:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/RunTests.R#L70) *warning:* **no visible global function definition for ‘.create_file_results’**
```r
  test_file_results <- .create_file_results(test_file_output, points, .GlobalEnv$points_for_all_tests)
                       ^~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:78:3:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/RunTests.R#L78) *warning:* **no visible global function definition for ‘.write_json’**
```r
  .write_json(list(runStatus = unbox("sourcing_failed"), backtrace = list(), testResults = list()), ".results.json")
  ^~~~~~~~~~~
```
[R/RunTests.R:78:32:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/RunTests.R#L78) *warning:* **no visible global function definition for ‘unbox’, Did you mean 'box'?**
```r
  .write_json(list(runStatus = unbox("sourcing_failed"), backtrace = list(), testResults = list()), ".results.json")
                               ^~~~~
```
[R/RunTests.R:85:3:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/RunTests.R#L85) *warning:* **no visible global function definition for ‘run_tests’**
```r
  run_tests(getwd(), bol)
  ^~~~~~~~~
```
[R/RunTests.R:93:23:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/RunTests.R#L93) *warning:* **no visible global function definition for ‘.get_available_points’**
```r
  available_points <- .get_available_points(project_path)
                      ^~~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:95:19:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/RunTests.R#L95) *warning:* **no visible global function definition for ‘.create_available_points_json_results’**
```r
  json_results <- .create_available_points_json_results(available_points)
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:96:3:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/R/RunTests.R#L96) *warning:* **no visible global function definition for ‘.write_json’**
```r
  .write_json(json_results, ".available_points.json")
  ^~~~~~~~~~~
```
[tests/testthat/resources/simple_source_code_error/R/main.R:1:1:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/tests/testthat/resources/simple_source_code_error/R/main.R#L1) *style:* **Variable or function name should be snake_case.**
```r
RetTrue <- function() {
^~~~~~~
```
[tests/testthat/resources/simple_source_code_error/R/main.R:6:19:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/tests/testthat/resources/simple_source_code_error/R/main.R#L6) *style:* **Place a space before left parenthesis, except in a function call.**
```r
RetOne <- function() {
                  ^
```
[tests/testthat/resources/simple_source_code_error/R/main.R:6:22:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/tests/testthat/resources/simple_source_code_error/R/main.R#L6) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
RetOne <- function() {
                     ^
```
[tests/testthat/resources/simple_source_code_error/R/main.R:7:9:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/tests/testthat/resources/simple_source_code_error/R/main.R#L7) *error:* **unexpected 'in'**
```r
  error in source code
        ^
```
[tests/testthat/resources/simple_source_code_error/tests/testthat/helperTMC.R:4:1:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/tests/testthat/resources/simple_source_code_error/tests/testthat/helperTMC.R#L4) *style:* **Variable or function name should be snake_case.**
```r
pointsForAllTests <- function(points) {
^~~~~~~~~~~~~~~~~
```
[tests/testthat/resources/simple_source_code_error/tests/testthat/helperTMC.R:12:3:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/tests/testthat/resources/simple_source_code_error/tests/testthat/helperTMC.R#L12) *warning:* **no visible global function definition for ‘test_that’**
```r
  test_that(desc, code)
  ^~~~~~~~~
```
[tests/testthat/resources/simple_source_code_error/tests/testthat/testMain.R:1:9:](https://github.com/RTMC/tmc-r-tester/blob/a7c58574be18e82ac1413e1688e0e07e1bff3377/tests/testthat/resources/simple_source_code_error/tests/testthat/testMain.R#L1) *style:* **Only use double-quotes.**
```r
library('testthat')
        ^~~~~~~~~~
```


Shouldn't that be s2?


Yes, it just pushes everything closer to the panel edges.

https://cdn.scrot.moe/images/2017/09/29/Screenshot_2017-09-28_20-08-16.png