TeamCity libpalaso :: palaso-win32-master Continuous [Build 4.0.442.878feaf3baee63287b87ca11c96288bd64ccd130](http://build.palaso.org/viewLog.html?buildId=99824&buildTypeId=Libpalaso_PalasoWin32masterContinuous) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-master Continuous [Build 4.0.441.6aefffd97084a9065e20f0404579f44be8473529](http://build.palaso.org/viewLog.html?buildId=99823&buildTypeId=Libpalaso_PalasoWin32masterContinuous) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.477.dc5cf77e349fd8f0740cc217c9dcf80bba3357a2](http://build.palaso.org/viewLog.html?buildId=99870&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3513, ignored: 128 Build time: 00:02:30


TeamCity libpalaso :: palaso-win32-master Continuous [Build 4.0.444.54cf3bbdaa6ccc4a9a36b9a142e67d05a63b1790](http://build.palaso.org/viewLog.html?buildId=99826&buildTypeId=Libpalaso_PalasoWin32masterContinuous) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-master Continuous [Build 4.0.443.e97e2e5d14107ec6aa02c8f19462e49080dfaa9f](http://build.palaso.org/viewLog.html?buildId=99825&buildTypeId=Libpalaso_PalasoWin32masterContinuous) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.479.ad60fbbde97ef0775d0679cc087a474ba363a50e](http://build.palaso.org/viewLog.html?buildId=99872&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.480.2570ac2317fcf3af278a6b2b697e461c98754009](http://build.palaso.org/viewLog.html?buildId=99873&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.481.a48f2e3916c650cad3ae95535929f3f8dd953661](http://build.palaso.org/viewLog.html?buildId=99874&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.482.c330f71682afec40ddef1b6a3dfcec83a2af8141](http://build.palaso.org/viewLog.html?buildId=99875&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.483.213c67723c29d874120bed792f132270f27ff424](http://build.palaso.org/viewLog.html?buildId=99876&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.484.bad02f496db0477a94e18f0283a986cc7b6af733](http://build.palaso.org/viewLog.html?buildId=99877&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.486.0fe000def43645f2a330382ada1affcdda8d4d7d](http://build.palaso.org/viewLog.html?buildId=99879&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.487.b10c474935b29f5cc7e20637896c3257fc05afa9](http://build.palaso.org/viewLog.html?buildId=99880&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.488.c26c5936cab58daeac1c34ed26cc0f9e2bed6aaf](http://build.palaso.org/viewLog.html?buildId=99881&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.489.273791114506562cb7ca98cb25658b5a276e9d4b](http://build.palaso.org/viewLog.html?buildId=99882&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.490.94bfc1ffeffeb63231084277c00f4ccdc4887602](http://build.palaso.org/viewLog.html?buildId=99883&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.491.01a07324ad9073b3f407286e63df1373d3ce48b9](http://build.palaso.org/viewLog.html?buildId=99884&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.492.d5dbacbdfa02d0a65058ea95808eac8a0b5bee39](http://build.palaso.org/viewLog.html?buildId=99885&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.494.ecd07d30b26e61385afe57dc4470e5c5f4109ac4](http://build.palaso.org/viewLog.html?buildId=99887&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.493.25dd3f30cb3183ced4edb1f3c984b5ce9bc5f024](http://build.palaso.org/viewLog.html?buildId=99886&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.497.0d58f801092012be15cdfaf7cb4a5a4e147b91a4](http://build.palaso.org/viewLog.html?buildId=99890&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.498.f3ecd030fde96b344b12c5ee47240bdc966f0f26](http://build.palaso.org/viewLog.html?buildId=99891&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.499.5bba9bda5eb5d9b41ccea623e7d48e4b0cca4c91](http://build.palaso.org/viewLog.html?buildId=99892&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.500.ac5f96d8076bba6c9ab58e566e65218d750a1229](http://build.palaso.org/viewLog.html?buildId=99893&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


You haven't even run timings on the match response endpoint. Saying that chat response is the cause is a complete shot in the dark.

We also can't programmatically pull up a user's chat history through discord logs.


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.501.68d3b14f1607f93c983f47adf2e878a0d1dffd01](http://build.palaso.org/viewLog.html?buildId=99894&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.503.d907b4eba4558b71a84940bf1b9ce2f3929ec2bd](http://build.palaso.org/viewLog.html?buildId=99896&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.504.97d1875822be195ef7c075f00c68717426adcac1](http://build.palaso.org/viewLog.html?buildId=99897&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


gulpfile.jsはgulp lint にかけてないから直接かけるとこんな感じになるねん。

```
/Users/eiel/Documents/ghq/github.com/nkhr7/nSpeech/gulpfile.js
    1:1   error  'use strict' is unnecessary inside of modules           strict
    1:14  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
    2:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
    3:12  error  'require' is not defined                                no-undef
    3:28  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
    4:15  error  'require' is not defined                                no-undef
    4:44  error  A space is required after '{'                           object-curly-spacing
    4:55  error  A space is required before '}'                          object-curly-spacing
    4:58  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
    5:21  error  'require' is not defined                                no-undef
    5:45  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
    6:21  error  'require' is not defined                                no-undef
    6:45  error  Expected comment to be above code                       line-comment-position
    6:45  error  Unexpected comment inline with code                     no-inline-comments
    6:54  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
    7:14  error  'require' is not defined                                no-undef
    7:32  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
    8:14  error  'require' is not defined                                no-undef
    8:46  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
    9:15  error  'require' is not defined                                no-undef
    9:34  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   10:11  error  'require' is not defined                                no-undef
   10:26  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   11:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   12:5   error  Identifier 'autoprefixer_setting' is not in camel case  camelcase
   12:29  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   13:33  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   14:17  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   15:2   error  Missing semicolon                                       semi
   15:2   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   16:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   17:12  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   18:14  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   19:16  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   20:15  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   21:3   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   22:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   23:5   error  Identifier 'nSpeech_path' is not in camel case          camelcase
   23:47  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   24:5   error  Identifier 'nSpeech_dist_path' is not in camel case     camelcase
   24:50  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   25:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   26:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   27:32  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   28:19  error  There should be no linebreak after '['                  array-bracket-newline
   28:20  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   29:33  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   30:3   error  There should be no linebreak before ']'                 array-bracket-newline
   30:5   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   31:3   error  Expected dot to be on same line as object               dot-location
   31:35  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   32:3   error  Expected dot to be on same line as object               dot-location
   32:22  error  A space is required after '{'                           object-curly-spacing
   32:44  error  A space is required before '}'                          object-curly-spacing
   32:82  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   33:3   error  Expected dot to be on same line as object               dot-location
   33:52  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   34:3   error  Expected dot to be on same line as object               dot-location
   34:36  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   35:3   error  Expected dot to be on same line as object               dot-location
   35:29  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   36:3   error  Expected dot to be on same line as object               dot-location
   36:30  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   36:30  error  Missing semicolon                                       semi
   37:4   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   38:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   39:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   40:40  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   41:21  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   42:13  error  Unexpected line break after this opening brace          object-curly-newline
   42:14  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   43:31  error  Expected comment to be above code                       line-comment-position
   43:31  error  Unexpected comment inline with code                     no-inline-comments
   43:49  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   44:5   error  Unexpected line break before this closing brace         object-curly-newline
   44:6   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   45:6   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   46:4   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   47:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   48:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   49:34  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   50:24  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   51:4   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   52:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   53:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   54:28  error  Missing space before function parentheses               space-before-function-paren
   54:34  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   55:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   56:15  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   57:12  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   58:13  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   59:20  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   60:18  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   61:18  error  There should be no linebreak after '['                  array-bracket-newline
   61:19  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   62:32  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   63:7   error  There should be no linebreak before ']'                 array-bracket-newline
   63:8   error  A space is required after ','                           comma-spacing
   63:21  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   64:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   65:18  error  There should be no linebreak after '['                  array-bracket-newline
   65:19  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   66:32  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   67:7   error  There should be no linebreak before ']'                 array-bracket-newline
   67:8   error  A space is required after ','                           comma-spacing
   67:19  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   68:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   69:18  error  There should be no linebreak after '['                  array-bracket-newline
   69:19  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   70:30  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   71:7   error  There should be no linebreak before ']'                 array-bracket-newline
   71:22  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   72:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   73:23  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   74:19  error  Identifier 'nSpeech_path' is not in camel case          camelcase
   74:45  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   75:19  error  Identifier 'nSpeech_dist_path' is not in camel case     camelcase
   75:54  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   76:17  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   77:6   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   78:5   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   79:4   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   80:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   81:28  error  Missing space before function parentheses               space-before-function-paren
   81:32  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   82:24  error  Unexpected line break after this opening brace          object-curly-newline
   82:25  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   83:12  error  Identifier 'nSpeech_path' is not in camel case          camelcase
   83:24  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   84:3   error  Unexpected line break before this closing brace         object-curly-newline
   84:19  error  Missing space before function parentheses               space-before-function-paren
   84:29  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   85:29  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   86:40  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   87:20  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   88:8   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   89:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   90:29  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   91:36  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   92:20  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   93:8   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   94:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   95:28  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   96:39  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   97:19  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   98:8   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
   99:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  100:30  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  101:38  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  102:23  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  103:21  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  104:8   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  105:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  106:29  error  There should be a linebreak after this element          array-element-newline
  106:34  error  There should be a linebreak after this element          array-element-newline
  106:38  error  There should be a linebreak after this element          array-element-newline
  106:46  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  107:6   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  108:4   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  109:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  110:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  111:32  error  Missing space before function parentheses               space-before-function-paren
  111:36  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  112:20  error  Identifier 'nSpeech_dist_path' is not in camel case     camelcase
  112:39  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  113:3   error  Expected dot to be on same line as object               dot-location
  113:37  error  Missing semicolon                                       semi
  113:37  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  114:4   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  115:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  116:28  error  Missing space before function parentheses               space-before-function-paren
  116:32  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  117:25  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  118:12  error  Identifier 'nSpeech_path' is not in camel case          camelcase
  118:25  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  119:54  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  120:19  error  Missing space before function parentheses               space-before-function-paren
  120:29  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  121:26  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  122:42  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  123:23  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  124:21  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  125:8   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  126:6   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  127:4   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  128:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  129:27  error  Missing space before function parentheses               space-before-function-paren
  129:31  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  130:20  error  Identifier 'nSpeech_path' is not in camel case          camelcase
  130:34  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  131:3   error  Expected dot to be on same line as object               dot-location
  131:26  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  132:3   error  Expected dot to be on same line as object               dot-location
  132:33  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  133:3   error  Expected dot to be on same line as object               dot-location
  133:42  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  134:4   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  135:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  136:28  error  Missing space before function parentheses               space-before-function-paren
  136:32  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  137:24  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  138:4   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  139:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  140:46  error  There should be a linebreak after this element          array-element-newline
  140:58  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  141:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  142:33  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  143:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  144:29  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  145:1   error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style
  146:28  error  There should be a linebreak after this element          array-element-newline
  146:39  error  Expected linebreaks to be 'LF' but found 'CRLF'         linebreak-style

✖ 212 problems (212 errors, 0 warnings)
  190 errors, 0 warnings potentially fixable with the `--fix` option.
```


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.505.6cd7ef34f7977e3d9c9f7699c1a3aa1585028324](http://build.palaso.org/viewLog.html?buildId=99898&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.506.a91117961f92830042db9fb15ec6b2e2483bed98](http://build.palaso.org/viewLog.html?buildId=99899&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.508.2614928b2fbc163e0e061840108e2ddc958dc904](http://build.palaso.org/viewLog.html?buildId=99901&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.507.db9ce679301f12d411d2373c2ba4b9b2391e5c09](http://build.palaso.org/viewLog.html?buildId=99900&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:09


Declare any magic numbers as constants or private class variables


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.510.fb5532e45dee2b00729b6b23c1cddc1b618bf810](http://build.palaso.org/viewLog.html?buildId=99903&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.511.df52d77e462f00eae34e42c22deff4108bb18da3](http://build.palaso.org/viewLog.html?buildId=99904&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


I wanna ask you for help, when I use my own dataset to conduct a classification task with the DBN code, the result always turn to be all the datas are classified into same class, can you help to explain that?


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.512.1ac76ddf9bfaf29348fe6bd5687b73b6f1ee58b7](http://build.palaso.org/viewLog.html?buildId=99905&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.513.03396cd04f2b0a3e5f8fb8fc8599a22b289ce15d](http://build.palaso.org/viewLog.html?buildId=99906&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.514.9b32e274cf9a6abf2056540b777a24c556bb3ced](http://build.palaso.org/viewLog.html?buildId=99907&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.515.88c96549572b8e4aab7beb8be2d194f825957bfc](http://build.palaso.org/viewLog.html?buildId=99908&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.516.52a90ef82cc3692290afe03910e3a5b36ee09982](http://build.palaso.org/viewLog.html?buildId=99909&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.517.4c97f84b1cfa716659946e235ca6d99eeb0b8dec](http://build.palaso.org/viewLog.html?buildId=99910&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.518.dc225a520f006185f5b00eddeb5f130e3f57dd0d](http://build.palaso.org/viewLog.html?buildId=99911&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.519.25ea38d35ee92ae40ecb6c7360c9b2f874057a6a](http://build.palaso.org/viewLog.html?buildId=99912&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.520.0ecd728c22b748ecc2065f65cb20cd0fae0b44a5](http://build.palaso.org/viewLog.html?buildId=99913&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.521.1cb4e2879912b302f36b676bddef6a4f17dc8a9d](http://build.palaso.org/viewLog.html?buildId=99914&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.522.5bdbf3a319d9825b142da678148f2f3f319837e5](http://build.palaso.org/viewLog.html?buildId=99915&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.523.1aa2d340a0b6dbfbb448c8200c5382c0a0b8e719](http://build.palaso.org/viewLog.html?buildId=99916&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.524.12348780c81091648390409b7ba3e8364ac0856b](http://build.palaso.org/viewLog.html?buildId=99917&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.478.9d153564549cbafd05fe1d92e92c458adde4727b](http://build.palaso.org/viewLog.html?buildId=99871&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3513, ignored: 128 Build time: 00:02:32


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.525.58febfd362711e2465cb672f49a04796043260e8](http://build.palaso.org/viewLog.html?buildId=99918&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.526.834c3a62f460370f3e0cb54776cae50d18637f12](http://build.palaso.org/viewLog.html?buildId=99919&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


Couldn't the current post one be used? I'm not sure if there's something in it that's specific to the post page type. I was simply using what already existed and noticed the weird pointer string.


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.528.35d7c4ad2ffa8fa1d34d15ee7a55086c751e2af6](http://build.palaso.org/viewLog.html?buildId=99921&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.529.dafc44b901ca7d777a38cb5a320999143aa510ca](http://build.palaso.org/viewLog.html?buildId=99922&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.530.58682ccd6528076fc2d345a311a6aae5cefbecca](http://build.palaso.org/viewLog.html?buildId=99923&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.531.da907ff51055635efbf70a34968549f0164dee40](http://build.palaso.org/viewLog.html?buildId=99924&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.533.adb0bcf1ea3202faaa6f91d867e948709047618e](http://build.palaso.org/viewLog.html?buildId=99926&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.532.c1c4fbf07ace457ad53b133b09c76ae7f374f8f2](http://build.palaso.org/viewLog.html?buildId=99925&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.535.6da852b6f4f3141e7f04dcff5da8f62c7628113b](http://build.palaso.org/viewLog.html?buildId=99928&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


altitude in degrees? wow!


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.536.e17112ffded48745541289de497fe6ac0b8c810b](http://build.palaso.org/viewLog.html?buildId=99929&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.537.4a0adfca968b72e635f75e2432903e36400fa2fb](http://build.palaso.org/viewLog.html?buildId=99930&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.538.1b0b4ac785544e4787b4d584f4c8ac3a780dc395](http://build.palaso.org/viewLog.html?buildId=99931&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.539.88b30b4c9574ebb9effc58996f2c5e57be74f7ee](http://build.palaso.org/viewLog.html?buildId=99932&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.540.a0e02e6d3f0c3ddab8808cecc8c937a9d468900c](http://build.palaso.org/viewLog.html?buildId=99933&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.541.6aa38bc001ef3143f4856e4233e91ed4e4b76e34](http://build.palaso.org/viewLog.html?buildId=99934&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.542.cfc0f828d2b83a9e2a0d7a47d2acc99e10e5718e](http://build.palaso.org/viewLog.html?buildId=99935&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.543.ca14af490f50283d1fd03039bc8b1e9f6aeaaa73](http://build.palaso.org/viewLog.html?buildId=99936&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.544.13ef298569fa42d866890bce5300248fb819587f](http://build.palaso.org/viewLog.html?buildId=99937&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.545.e21f77d4e6cfbfc6dbf88906c865d74f99b0bd55](http://build.palaso.org/viewLog.html?buildId=99938&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.546.eb0bd62f6c55bce0df2154987ffea6523b7d0364](http://build.palaso.org/viewLog.html?buildId=99939&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.547.1168095c4cca95e40e57e4982415341591dfde69](http://build.palaso.org/viewLog.html?buildId=99940&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


Your warnings are being cause by the titleInfo expecting a string but you are passing in a number. Use String(this.state.curFilterObj._minimumPrice)

Also, the underscore variables are supposed to be private so I would use the getters (I don't think there are any, so I'll add some)


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.548.1168095c4cca95e40e57e4982415341591dfde69](http://build.palaso.org/viewLog.html?buildId=99941&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.549.374c09ca2b4ad105b4c0d870ff86a292995706ec](http://build.palaso.org/viewLog.html?buildId=99942&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.550.f0d14e0836c4a85c698be4e68e98a250ef8e92f1](http://build.palaso.org/viewLog.html?buildId=99943&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.551.be5672ae9ebe08ea3b8a733df5152a0527566e1e](http://build.palaso.org/viewLog.html?buildId=99944&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.552.7a907cc897daefe154fdd70c9b1cdf59546fbcf9](http://build.palaso.org/viewLog.html?buildId=99945&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.553.299517ae4b28f36b7cfcd569783d481e29a27dda](http://build.palaso.org/viewLog.html?buildId=99946&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.556.9681a05473ad1e99ad70855c3ed97ed5df2d9fff](http://build.palaso.org/viewLog.html?buildId=99949&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.557.b186e0bbed4ba98dab0dc3452fb3b8db5cb86f6c](http://build.palaso.org/viewLog.html?buildId=99950&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.558.9792a79e80418e94d987e6df1a14b1a3f1d25bb4](http://build.palaso.org/viewLog.html?buildId=99951&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.559.702b6947576d16093338ad7bb57d429ff4022635](http://build.palaso.org/viewLog.html?buildId=99952&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.560.1a1ce12cac1bad3e9a15a2f0185e9609f10fed4a](http://build.palaso.org/viewLog.html?buildId=99953&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.561.5b7c75a5332fcfc6dcd45d01a26785a5eb99d2cb](http://build.palaso.org/viewLog.html?buildId=99954&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.562.6aefffd97084a9065e20f0404579f44be8473529](http://build.palaso.org/viewLog.html?buildId=99955&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.563.878feaf3baee63287b87ca11c96288bd64ccd130](http://build.palaso.org/viewLog.html?buildId=99956&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.564.c054df2ea79f8ad3982c1faf856301cca7837c96](http://build.palaso.org/viewLog.html?buildId=99957&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.565.f841efb44ec68465da3ee9e1b493376412851c16](http://build.palaso.org/viewLog.html?buildId=99958&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.566.df28bda1ffec43afc9c3c6e6a3c3dba55fa3b86d](http://build.palaso.org/viewLog.html?buildId=99959&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.567.488aceddab6b61598b6ce0532ba3d790c3abb503](http://build.palaso.org/viewLog.html?buildId=99960&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.568.39164c96ca6808dc3193a9c021b1bddf54de9c69](http://build.palaso.org/viewLog.html?buildId=99961&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.569.d94299f451b14925058af88c6bda026043621c74](http://build.palaso.org/viewLog.html?buildId=99962&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.570.e97e2e5d14107ec6aa02c8f19462e49080dfaa9f](http://build.palaso.org/viewLog.html?buildId=99963&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.571.3d52ad7503b4f870d9fca703002c11f406e99611](http://build.palaso.org/viewLog.html?buildId=99964&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


That's my preferred way of measuring it tbh


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.572.83079ab39b20735eafa248064bb8a63d7e2baca1](http://build.palaso.org/viewLog.html?buildId=99965&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:03


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.573.54cf3bbdaa6ccc4a9a36b9a142e67d05a63b1790](http://build.palaso.org/viewLog.html?buildId=99966&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.574.adde91cb49664d864d5d39809abffb178f0f6641](http://build.palaso.org/viewLog.html?buildId=99967&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.575.5419d612f7698be939a9ef6ce5e7a838c38d5b28](http://build.palaso.org/viewLog.html?buildId=99968&buildTypeId=bt223) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.527.1bf5f1bb0350f0a5e980faab965f1da312333979](http://build.palaso.org/viewLog.html?buildId=99920&buildTypeId=bt223) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 3560, ignored: 128 Build time: 00:02:48
### Failed tests
```
SIL.Windows.Forms.Tests.dll: SIL.Windows.Forms.Tests.ImageToolbox.PalasoImageTests.Image_FromFile_GivesImage: <no details avaliable>

```


What was the issue? Now they are adding taxes to TADA or it was always like that and LH was not doing that?


We should use enums instead of strings here


The reason comments.html is in posts and not partials is because the content has to be rendered when using Staticman. For Disqus, it can just be called as a partial. Since there isn't a partials/comments.html, you'll get the pointer. I am going to think on the best way to fix this so you can allow itemized comments that won't cause issues later. Feel free to create an issue for it.


It's actually annoying that Flow doesn't point this out since I made the same mistake a bunch of times. Yay javascript.


TeamCity libpalaso :: palaso-win-master Continuous [Build 4.0.125.9681a05473ad1e99ad70855c3ed97ed5df2d9fff](http://build.palaso.org/viewLog.html?buildId=100116&buildTypeId=Libpalaso_PalasoWinmasterContinuous) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:05


TeamCity libpalaso :: palaso-win-master Continuous [Build 4.0.126.5b7c75a5332fcfc6dcd45d01a26785a5eb99d2cb](http://build.palaso.org/viewLog.html?buildId=100117&buildTypeId=Libpalaso_PalasoWinmasterContinuous) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


I generally put comments above the line that I am referencing (and it's what I've seen in all the industry code I've worked on). Also wrap the line once you hit 80 characters across


TeamCity libpalaso :: palaso-win-master Continuous [Build 4.0.127.6aefffd97084a9065e20f0404579f44be8473529](http://build.palaso.org/viewLog.html?buildId=100118&buildTypeId=Libpalaso_PalasoWinmasterContinuous) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win-master Continuous [Build 4.0.128.878feaf3baee63287b87ca11c96288bd64ccd130](http://build.palaso.org/viewLog.html?buildId=100119&buildTypeId=Libpalaso_PalasoWinmasterContinuous) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity libpalaso :: palaso-win-master Continuous [Build 4.0.129.c054df2ea79f8ad3982c1faf856301cca7837c96](http://build.palaso.org/viewLog.html?buildId=100120&buildTypeId=Libpalaso_PalasoWinmasterContinuous) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


TeamCity LCM :: liblcm-win32-master Continuous [Build 72](http://build.palaso.org/viewLog.html?buildId=100115&buildTypeId=Liblcm_LiblcmWin32masterContinuous) outcome was **FAILURE**
Summary: NUnit error running tests in 'C:\BuildAgent\work\8a4ced8090a4a0ab\artifacts\Release\SIL.LCModel.Core.Tests.dll' assembly
Loading assembly is compiled for v4.0.30319, MSIL
NUnit runner runtime is v4.0.30319, x86
System.IO.FileNotFoundException: Could ... Build time: 00:00:35


TeamCity libpalaso :: palaso-win-master Continuous [Build 4.0.130.39164c96ca6808dc3193a9c021b1bddf54de9c69](http://build.palaso.org/viewLog.html?buildId=100121&buildTypeId=Libpalaso_PalasoWinmasterContinuous) outcome was **FAILURE**
Summary: Failed to start build Build time: 00:00:04


I'd still like to maintain an option to disable comments on itemized types. Like I mentioned in the commit, for my use case I don't want them. I would argue there's no backwards compatibility for having them disabled by default if they never really worked to begin with. But that can be enabled by default if that would be better.


Angle-brackets are frameworks and double-quotes are my custom classes.


Hey,
Greetings !
There seems to be a miss, defaultSorting should be in single quotes. Could you please include this change.
![default sorting](https://user-images.githubusercontent.com/24544276/31605996-73c5218e-b285-11e7-8d97-ec39c8155ea8.JPG)


are we sure that there is no risk that this leads to multiple items with the same `form-container` key in the list ? I imagine that there is only 1 container


this commit contains more than flow annotations (style, fixes, etc)


App moved to View


En fait c'est une "DetailView" pour Petition car ça affiche une pétition, mais ça permet de signer, et donc effectivement de créer une "Signature" ^^


Correction: leaving the version check out makes `ActiveRecord::Base.connection.exec_sql` work with bindings but breaks queries generated by the ActiveRecord query interface.


__apiary.manifest contains reference to non-existent file in repository.__ (Autogenerated message from apiary.io)
+ swagger.yaml


ah oui :p


ok I see, that the if before is modified also so we can not post a top post without subject on 1 column


@raffis
makes sense. thx for the explanation


@andrerom Here's the failing build: https://travis-ci.org/netgen/TagsBundle/builds/288488283


i=1として宣言して、i<=10までfor文を回すようにすると10回まわすことが分かりやすいように思います。


Thanks!


<iframe src="https://calendar.google.com/calendar/embed?src=equipohingenia%40gmail.com&ctz=Europe/Madrid" style="border: 0" width="800" height="600" frameborder="0" scrolling="no"></iframe>


no worries, at least now we have a simple unit test that covers that


thx a lot. I really appreciate it :-)


if(num % 2   == 0)の条件文でも通ります。
もしよければお試しください。


@nataly2012 Зачем строку и так в строку преобразовывать?


Hey @amyhagelin. Your mongodb is still exposed.


do we really need parenthesis here ?


if(c) あるいは　if(c == true)の条件文に変える必要があります。
条件演算子を確認してみて下さい。
等しい場合は==です。


重载后的空布局


@vkurennov Спасибо.


I'm pretty sure `activity_count` is an integer.


> @emodric: I was rather hoping you'd volunteer to fix it here by PR to Solr Bundle :grinning:

I could, but as @MarioBlazek says, the issue is bigger than just this repo, as it includes changes to docs, writing best practices and so on :)

As for `Tests\SPI`, I'm not sure how I feel about that naming, it could collide with naming in non test use cases. I'd rather go with something more discoverable, like `Tests\\TestCase\\*`


oh, nice catch !


Example.
Curious if this would improve battery time.


@hauke
PPTP compilation is now broken in buildbot (since yesterday).
For example
https://downloads.lede-project.org/snapshots/faillogs/mips_24kc/base/ppp/default/compile.txt

I noticed the PPTP breakage yesterday evening also in my own build, but did not have time to look for reasons. I have not yet tried reverting this commit, but this looks like a probably suspect for the breakage.


pjekny


rech 69


div


This middleware isn't used in current app. There are no separate frontednd and backend domains (urls), are there?


Sorry this didn't fix #72 but rather fixed #68


> The two maps overlap somewhat as some locations could spawn either randomly (is that even possible in TC?).

Via pool_template.


Now I konw how to set environment label without fancy .env file. :)


You're right. My eye has skipped app parameter of http.createServer function.


keep a constant for `topPosts` to avoid to call this transformation multiple times


> May I leave this *16 multipler?

Sure you can, but it's still a static limit. That is, you won't hit this limit when shooting through 2048 imp corpses, but when you add another one... I admit, this is a very unlikely case, but for this exact reason I am not for raising a static limit that drastically.

I am still undecided how to proceed with this for Crispy. On the one hand I'd like to remove the INTERCEPTS limit altogether and be done with it. On the other hand, checking intercepts is a real performance killer! As I am only targetting Vanilla compatibility and Vanilla would crash after `MAXINTERCEPTS_ORIGINAL + 61` intercepts have been checked (well, sooner or later, that is), I think I'll just exit the loop after this number has been reached, just as I recommended before.


Thanks for fixing this! However I just tested your latest commit and it seems like on https `$this->grav['uri']->scheme()` find http instead of https.


Yep, I wanted to search for it myself. Thx.


I guess setpoint_address needs to be optional in this case.


have you checked this with Fred ? (I prefer those also but in the acceptance tests, it was "in favor"/"not in favor")


Technically, we might also do the KeLoaderBlock != NULL check here.


:+1: :clap: :clap:


What is in `$_SERVER['HTTPS']`?


Sounds reasonable :+1:


So this is special case middleware. I guess that Express implementation of `use` uses javascript style function overloading to treat this one as exception handler. It was a bit strange to me.


yeah had this locally, forgot to push it.


cane


This was me exercising promises.


No, it isn't since it is all on the same domain. However, this was a preparation to allow them running react and node code separately and not worry about proxying requests from react to node. I decided to put this for 2 main reasons: 1) show them how it's done, and 2) allow them to skip the proxy setup process of react application (and for the tutors to skip the entire explanation of what the proxy does)


Strange, because there is `PHP_ADD_INCLUDE(liblzf)` directive and I thought it added `liblz`  to the search path.


Yeah, it was weird to me as well at the beginning, however I've learned to accept it.

Here are some more details on the topic: http://expressjs.com/en/guide/error-handling.html


hello world


Magic numbers like this should be put into a constant at the top so it is clear what they mean, for example:

```js
const ACTIVE_PORTAL_THRESHOLD = 60 * 60 * 24 * 2; // 2 days
```


TeamCity Selenium POM :: CI [Build 98](https://teamcity.sponte.uk/viewLog.html?buildId=1370&buildTypeId=SeleniumPom_Ci) is now running


@mdoering related to this change, during testing I was able to trigger the following Freemarker error:

> The following has evaluated to null or missing:
> ==> requestURL  [in template "WEB-INF/pages/inc/menu.ftl" at line 42, column 30]

To reproduce the error, you can use a query similar to:

`http://localhost:8080/ipt/about.do?""" style%3D"background:url(javascript:alert(6268))" "`


@staeff Would you mind to change that to: nvm  (Node Version Manager) that is the right spelling according to their website :)


TeamCity Selenium POM :: CI [Build 98](https://teamcity.sponte.uk/viewLog.html?buildId=1370&buildTypeId=SeleniumPom_Ci) outcome was **FAILURE**
Summary: Tests failed: 7, passed: 10; failed to start sauce connect: Error launching Sauce Connect (new) Build time: 00:00:56
### Failed tests
```
uk.sponte.automation.seleniumpom.tests.DependencyInjectionTest.canUseMyOwnDependencyInjection: <no details avaliable>

uk.sponte.automation.seleniumpom.tests.ui.AnimationsTest: <no details avaliable>

uk.sponte.automation.seleniumpom.tests.ui.FrameTest: <no details avaliable>

uk.sponte.automation.seleniumpom.tests.ui.PageTest: <no details avaliable>

uk.sponte.automation.seleniumpom.tests.ui.CachingWithoutImplictInvalidateTest: <no details avaliable>

uk.sponte.automation.seleniumpom.tests.ui.CachingTest: <no details avaliable>

uk.sponte.automation.seleniumpom.tests.ui.BritishAirwaysTest.useOfCalendars: <no details avaliable>

```


Good catch, fixed by https://github.com/sdeleuze/spring-boot-kotlin-demo/commit/9486ba32016934926112dda232cb75818676d47e.


Main tests included and main API written.


@petrgrishin перед нами стояла задача быстрого импорта/обновления базы с геоданными. Конечно, нужно сделать рефакторинг и не претендуем на "красоту" и эстетичность кода в этой очень прикладной задаче. Спасибо за замечание 👍


fixed some grammatical issues in networking.md


![](https://github.trello.services/images/mini-trello-icon.png) [Git-Repo aufräumen](https://trello.com/c/HZ3ngQg0/10-git-repo-aufr%C3%A4umen)


No problem. I am too old to remember this :-)


Nebylo by lepší z toho udělat konstantu? vidím to už podruhé


I tried on another mac:
Here I don't get pink frames (but these clips on this mac don't have audio), but I get some crashes. "an_mlv_..." was causing the crash the log told. Same for the cocoa version - here without crash, but the app stopped responding.


Pokud má něco min-width, width je možno nastavit na 100%


@alviteri I don't have an Oreo install at the moment to test with, I hope set that up soon.

For the issues you describe, could you get a logcat?


konstanta, proměnná ... .


@Utumno  will do.  In my initial grep through the source, these files will need to be modified:

```
basher/saves_links.py
bish.py
bolt.py
bosh/faces.py
bosh/__init__.py
bosh/_saves.py
bosh/save_files.py
bosh/bsa_files.py
bosh/mods_metadata.py
brec.py
env.py
parsers.py
patcher/patchers/multitweak_names.py
record_groups.py
```


napsal bych do komentu důvod té velikosti


I'm fine with your correction. Although, C++ standard prohibits better readable code.


If `ENV["BUNDLE_PATH"] = "vendor/bundle"`, `FileUtils.rm_rf("vendor/bundle")` accidentally removes installed gems.
And actually the symbolic link is for the migration from hardcoded `"vendor/bundle"` to shared `ENV["BUNDLE_PATH"]` for our environments. Once the migration has done, we can remove the symbolic link that is no longer needed.


## Global

| Changed            |   Status |
|:-------------------|---------:|
| `metadata_passing` |       +4 |
| `metadata_total`   |       +4 |
| `nodes_count`      |   +24947 |
| `texts_passing`    |       +4 |
| `texts_total`      |       +4 |

## Words

| Changed   |   Status |
|:----------|---------:|
| `grc`     |  +826678 |

## Units

| Changed                                               | Status   |
|:------------------------------------------------------|:---------|
| `./data/tlg0592/tlg002/__cts__.xml`                   | New      |
| `./data/tlg0592/tlg002/tlg0592.tlg002.1st1K-grc1.xml` | New      |
| `./data/tlg0592/tlg004/__cts__.xml`                   | New      |
| `./data/tlg0592/tlg004/tlg0592.tlg004.1st1K-grc1.xml` | New      |
| `./data/tlg0592/tlg005/__cts__.xml`                   | New      |
| `./data/tlg0592/tlg005/tlg0592.tlg005.1st1K-grc1.xml` | New      |
| `./data/tlg5026/tlg001/__cts__.xml`                   | New      |
| `./data/tlg5026/tlg001/tlg5026.tlg001.1st1K-grc1.xml` | New      |
| `./data/tlg0592/tlg002/__cts__.xml`                   | Passing  |
| `./data/tlg0592/tlg002/tlg0592.tlg002.1st1K-grc1.xml` | Passing  |
| `./data/tlg0592/tlg004/__cts__.xml`                   | Passing  |
| `./data/tlg0592/tlg004/tlg0592.tlg004.1st1K-grc1.xml` | Passing  |
| `./data/tlg0592/tlg005/__cts__.xml`                   | Passing  |
| `./data/tlg0592/tlg005/tlg0592.tlg005.1st1K-grc1.xml` | Passing  |
| `./data/tlg5026/tlg001/__cts__.xml`                   | Passing  |
| `./data/tlg5026/tlg001/tlg5026.tlg001.1st1K-grc1.xml` | Passing  |

*[Hook UI build recap](http://ci.perseids.org/repo/OpenGreekAndLatin/First1KGreek/3122)*


Hi :-)


gdghhh


pkill -> kill


No problem, you are already helping a lot, thank you
If you have questions about the code please feel free to join the contributing team on the chat here
https://framateam.org/signup_user_complete/?id=x1ay4zdjdffh5j67xzkfsofpyw


Hmm, where can I find this?


Here should be ....
``` typescript
export interface CameraComponentParams { ... }
```


@PierreBesson in the [current documentation](https://www.elastic.co/guide/en/elasticsearch/reference/current/docker.html), they still remain ulimit & mem_limit settings.
Why did you decide to remove them? Juste to know. Thanks.


prueba comentario


(we love to help)


saw approval from MonsieurNicolas
at https://github.com/stellar/stellar-core/commit/ce2f4f8bfe6eb710f64505cee35cc358b30e198c


merging stellar/stellar-core/dm/usage = ce2f4f8b into auto


stellar/stellar-core/dm/usage = ce2f4f8b merged ok, testing candidate = b9f1b5c4


![](https://github.trello.services/images/mini-trello-icon.png) [[Core Feature 6] Front end - User Interface/Event Handler](https://trello.com/c/gYmpqqIH/112-core-feature-6-front-end-user-interface-event-handler)


ouch, nice spot.


wtf


TeamCity Selenium POM :: CI [Build 99](https://teamcity.sponte.uk/viewLog.html?buildId=1376&buildTypeId=SeleniumPom_Ci) is now running


cool :)


TeamCity Selenium POM :: CI [Build 99](https://teamcity.sponte.uk/viewLog.html?buildId=1376&buildTypeId=SeleniumPom_Ci) outcome was **FAILURE**
Summary: Tests failed: 7, passed: 10; failed to start sauce connect: Error launching Sauce Connect Build time: 00:01:00
### Failed tests
```
uk.sponte.automation.seleniumpom.tests.ui.CachingTest: <no details avaliable>

uk.sponte.automation.seleniumpom.tests.ui.PageTest: <no details avaliable>

uk.sponte.automation.seleniumpom.tests.ui.CachingWithoutImplictInvalidateTest: <no details avaliable>

uk.sponte.automation.seleniumpom.tests.ui.FrameTest: <no details avaliable>

uk.sponte.automation.seleniumpom.tests.ui.BritishAirwaysTest.useOfCalendars: <no details avaliable>

uk.sponte.automation.seleniumpom.tests.DependencyInjectionTest.canUseMyOwnDependencyInjection: <no details avaliable>

uk.sponte.automation.seleniumpom.tests.ui.AnimationsTest: <no details avaliable>

```


sddd


Remove this, maybe just keep the newline. but the `=====` seperator is useless.


Just tried on non-https, and it works: $this->grav['uri']->scheme() has http and port 80 is found.

On https port is 443 but scheme found is http


WARNING:


> As for Tests\SPI, I'm not sure how I feel about that naming, it could collide with naming in non test use cases. I'd rather go with something more discoverable, like Tests\\TestCase\\*

Hmm, yes, that's more clear and direct, however I also aimed here to move our `SetupFactory`, to have some common place for test-related-stuff that needs to be accessed by 3rd party libraries.


Mám trošku problém s takovým velkým množstvím hodnot napevno. Pokud se rozhodneme upravit tlačítka v budoucnu, bude se to měnit zas na 100 místech, místo několika proměnných.


credit @hai dang
on discord for noticing it


It is indeed, although it never occurs as we typically do not map the same page twice. Anyway I fixed the sematic in place.
@chelmuth : shall I better generate a fixup commit that removes the bugfix, and re-commit it separatly?
@m-stein: thanks for the attentive review


Ať už jde o velikost fontu či šířky atd.


solo es para comprobar


Sure, this is fair.


So I guess I didn't get what was the important point here:
https://github.com/presscustomizr/customizr/issues/1183
:(

Though not sure the commit here is what we want.
That's what I get:
ul

And even worse ol:

(that absolute positioning and a width of 1em doesn't seem to be good)


it was merged, so I created a separate PR to fix this https://github.com/WhitestormJS/whs.js/pull/335


![](https://github.trello.services/images/mini-trello-icon.png) [Week 7 - Putting it in practice](https://trello.com/c/2nV3aco3/44-week-7-putting-it-in-practice)


ya sure from next time bhai..


okay bhai..


Obecně hlavně proměnné. Nevím jestli to má cenu přepisovat, nebo o tom alespoň přemýšlet


I can't see the where do you use closure.


Shouldn't this involve the function name rather than the input name?


error:回滚到之前的代码


saw approval from MonsieurNicolas
at https://github.com/stellar/stellar-core/commit/ce2f4f8bfe6eb710f64505cee35cc358b30e198c


merging stellar/stellar-core/dm/usage = ce2f4f8b into auto


stellar/stellar-core/dm/usage = ce2f4f8b merged ok, testing candidate = 59149264


solid


Good stuff :)


Documentation, examples/tests & changelog please!


@pascalgrimaud @PierreBesson I'll try to PR that.
I'm not a big fan of extend mechanism either because [lots of keywords are not shared between services](https://docs.docker.com/compose/extends/#extending-services): links, volumes_from, and depends_on.
I don't have a better idea than merging them ;)


good


> Hmm, yes, that's more clear and direct, however I also aimed here to move our `SetupFactory`, to have some common place for test-related-stuff that needs to be accessed by 3rd party libraries.

Hm, okay. Makes sense I guess :)


I did this! I'm so proud of myself. But I forgot to log in 🍡 🍡 🍡


Correct. Infect the prev one will be merged with the last patch :-)


Hi @looeee,

Great job with new additions to FBXLoader.

It seems to work well almost all the times. However, I found a problem with two models (created in 3DMax and exported with default exporter, binary format) where the texture applies _**per face**_.

It's the technician and the device he's holding (2 different FBX models), below. In the scene, there are many other individual FBX models loaded, that don't seem to have that problem. We already investigated the parameters and everything looks the same, both in Max as well in the Three models and their textures (and maps).

Previous FBXLoader:
![captura de pantalla 2017-10-16 a las 11 50 06](https://user-images.githubusercontent.com/4103411/31608803-07bf22ea-b272-11e7-94b9-e542fb5a33c7.png)

New FBXLoader at dev branch:
![captura de pantalla 2017-10-16 a las 12 32 36](https://user-images.githubusercontent.com/4103411/31608823-17813718-b272-11e7-8f78-a149c887465a.png)

Do you think there's some error in our export or model design, or is it a bug in FBXLoader?
Thanks,
sntsdev


I would prefer this version to track remove(fork parent) version.


asdasdsad


Removed this change. Thanks.


Seems associated with the `paypie.net` scam as a lot of links direct back to that phishing domain.


thanks @megastef


thanks @megastef . Next time I'll apply command .


Use `TEST_ASSERT_NOT_NULL(data);` which is more verbose in case of failure.


Not at the moment. The conversion is just done by this little AWK script right now. You can see the output in `build/BUILTIN_SYNTAX.h` after running `make`. I might think about compression if the bundled files grow a lot in the future, but I don't think the saving would be worth the extra dependency just yet.


They were needed because of a previous version of the elasticsearch docker image was buggy. It's default configuration did not let you run a basic elasticsearch instance properly without tweaking the ulimit.

The Elasticsearch team are working on improving support for docker (now everything is written in their docs). This is a hard problem as it's not super easy to do system tuning in docker. For example the ulimits (limits in number of files opened) must be set as root but a container created directly from a docker image might not give you the root access needed to tweak this value. Also last time I checked kubernetes didn't support setting ulimits.
I tried many things to fix those problems but in the end I think this is better to keep it simple.
See https://github.com/pires/docker-elasticsearch for an elasticsearch production setup with docker.


White spaces: `void *data`.


I think that

```
 unless game.save_move(selected_square)
    puts "Ups.. Try again. Allowed moves: a1, a2, a3, b1, b2, b3, c1, c2, c3"
    next
 end

```

would be more readable.

Good that you try to use shorter way but in this case it just looks like "what is going on here?"


世界如此美好


@romaindequidt Also their doc is changing all the time ! If you have ideas for improvements please PR 😄.


[R/AddinServer.R:16:26:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L16) *warning:* **no visible global function definition for ‘.get_title_and_message’**
```r
    title_and_message <- .get_title_and_message(response = response)
                         ^~~~~~~~~~~~~~~~~~~~~~
```
[R/AddinServer.R:40:29:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L40) *style:* **Use <-, not =, for assignment.**
```r
    tests_passed_procentage = tests_passed_procentage(test_results)
                            ^
```
[R/AddinServer.R:48:42:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L48) *style:* **Put spaces around all infix operators.**
```r
                                    index=i,message=test_result$message)
                                        ~^~
```
[R/AddinServer.R:48:45:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L48) *style:* **Commas should always have a space after.**
```r
                                    index=i,message=test_result$message)
                                            ^
```
[R/AddinServer.R:48:52:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L48) *style:* **Put spaces around all infix operators.**
```r
                                    index=i,message=test_result$message)
                                                  ~^~
```
[R/AddinServer.R:51:29:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L51) *warning:* **no visible global function definition for ‘.create_single_result_display’**
```r
      test_result_output <- .create_single_result_display(test_results = test_results)
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/AddinServer.R:55:1:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L55) *style:* **Lines should not be more than 120 characters.**
```r
      tags$style(HTML(paste(sep = "", ".progressBar { position: relative; width: 100%; background-color: red; border-radius: 0px; }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/AddinServer.R:83:54:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L83) *style:* **Commas should always have a space after.**
```r
.create_test_result_element <- function(name, status,index=NULL,message=NULL) {
                                                     ^
```
[R/AddinServer.R:83:65:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L83) *style:* **Commas should always have a space after.**
```r
.create_test_result_element <- function(name, status,index=NULL,message=NULL) {
                                                                ^
```
[R/AddinServer.R:86:12:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L86) *style:* **Use <-, not =, for assignment.**
```r
  elements = tags$p(paste(name, ":", status),
           ^
```
[R/AddinServer.R:89:5:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L89) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(status!="pass"){
    ^
```
[R/AddinServer.R:89:12:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L89) *style:* **Put spaces around all infix operators.**
```r
  if(status!="pass"){
          ~^~~
```
[R/AddinServer.R:90:14:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L90) *style:* **Use <-, not =, for assignment.**
```r
    elements = list(elements,.create_detailed_message_with_button(index,message))
             ^
```
[R/AddinServer.R:90:30:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L90) *style:* **Commas should always have a space after.**
```r
    elements = list(elements,.create_detailed_message_with_button(index,message))
                             ^
```
[R/AddinServer.R:90:30:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L90) *warning:* **no visible global function definition for ‘.create_detailed_message_with_button’**
```r
    elements = list(elements,.create_detailed_message_with_button(index,message))
                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/AddinServer.R:90:73:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L90) *style:* **Commas should always have a space after.**
```r
    elements = list(elements,.create_detailed_message_with_button(index,message))
                                                                        ^
```
[R/AddinServer.R:94:61:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L94) *style:* **Commas should always have a space after.**
```r
.create_detailed_message_with_button <- function(index=NULL,message=NULL){
                                                            ^
```
[R/AddinServer.R:95:7:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L95) *style:* **Use <-, not =, for assignment.**
```r
  btn = tags$button(id=paste("button_",index,sep=""),"Toggle details")
      ^
```
[R/AddinServer.R:95:9:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L95) *warning:* **no visible binding for global variable ‘tags’, Did you mean 'rtags'?**
```r
  btn = tags$button(id=paste("button_",index,sep=""),"Toggle details")
        ^~~~
```
[R/AddinServer.R:95:23:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L95) *style:* **Put spaces around all infix operators.**
```r
  btn = tags$button(id=paste("button_",index,sep=""),"Toggle details")
                     ~^~
```
[R/AddinServer.R:95:40:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L95) *style:* **Commas should always have a space after.**
```r
  btn = tags$button(id=paste("button_",index,sep=""),"Toggle details")
                                       ^
```
[R/AddinServer.R:95:46:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L95) *style:* **Commas should always have a space after.**
```r
  btn = tags$button(id=paste("button_",index,sep=""),"Toggle details")
                                             ^
```
[R/AddinServer.R:95:49:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L95) *style:* **Put spaces around all infix operators.**
```r
  btn = tags$button(id=paste("button_",index,sep=""),"Toggle details")
                                               ~^~
```
[R/AddinServer.R:95:54:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L95) *style:* **Commas should always have a space after.**
```r
  btn = tags$button(id=paste("button_",index,sep=""),"Toggle details")
                                                     ^
```
[R/AddinServer.R:96:11:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L96) *style:* **Use <-, not =, for assignment.**
```r
  message = tags$p(style = "display:none",paste("message:", message),
          ^
```
[R/AddinServer.R:96:43:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L96) *style:* **Commas should always have a space after.**
```r
  message = tags$p(style = "display:none",paste("message:", message),
                                          ^
```
[R/AddinServer.R:97:22:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L97) *style:* **Put spaces around all infix operators.**
```r
                   id=paste("message_",index,sep=""))
                    ~^~
```
[R/AddinServer.R:97:40:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L97) *style:* **Commas should always have a space after.**
```r
                   id=paste("message_",index,sep=""))
                                       ^
```
[R/AddinServer.R:97:46:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L97) *style:* **Commas should always have a space after.**
```r
                   id=paste("message_",index,sep=""))
                                             ^
```
[R/AddinServer.R:97:49:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L97) *style:* **Put spaces around all infix operators.**
```r
                   id=paste("message_",index,sep=""))
                                               ~^~
```
[R/AddinServer.R:98:10:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L98) *style:* **Use <-, not =, for assignment.**
```r
  script = tags$script(paste("$(\"#button_",index,
         ^
```
[R/AddinServer.R:98:45:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L98) *style:* **Commas should always have a space after.**
```r
  script = tags$script(paste("$(\"#button_",index,
                                            ^
```
[R/AddinServer.R:100:36:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L100) *style:* **Commas should always have a space after.**
```r
                             index,"\").toggle()});",sep=""))
                                   ^
```
[R/AddinServer.R:100:54:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L100) *style:* **Commas should always have a space after.**
```r
                             index,"\").toggle()});",sep=""))
                                                     ^
```
[R/AddinServer.R:100:57:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L100) *style:* **Put spaces around all infix operators.**
```r
                             index,"\").toggle()});",sep=""))
                                                       ~^~
```
[R/AddinServer.R:101:23:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L101) *style:* **Commas should always have a space after.**
```r
  return(list(message,btn,script))
                      ^
```
[R/AddinServer.R:101:27:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L101) *style:* **Commas should always have a space after.**
```r
  return(list(message,btn,script))
                          ^
```
[R/AddinServer.R:111:47:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L111) *style:* **Put spaces around all infix operators.**
```r
                                         index=i,message=result$message))
                                             ~^~
```
[R/AddinServer.R:111:50:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L111) *style:* **Commas should always have a space after.**
```r
                                         index=i,message=result$message))
                                                 ^
```
[R/AddinServer.R:111:57:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L111) *style:* **Put spaces around all infix operators.**
```r
                                         index=i,message=result$message))
                                                       ~^~
```
[R/AddinServer.R:115:10:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/AddinServer.R#L115) *warning:* **no visible global function definition for ‘.create_test_result_element’**
```r
  return(.create_test_result_element(name = "All tests", status = "pass"))
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/Authentication.R:45:5:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/Authentication.R#L45) *style:* **Commented code should be removed.**
```r
  # url <- "https://tmc.mooc.fi/api/v8/core/org/hy/courses"
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/TestResultsStats.R:8:14:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/TestResultsStats.R#L8) *style:* **Use <-, not =, for assignment.**
```r
      passed = passed + 1
             ^
```
[R/TestResultsStats.R:13:52:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/TestResultsStats.R#L13) *style:* **Put spaces around all infix operators.**
```r
  return(paste(sep = "", toString(passed_procentage*100), "%"))
                                                  ~^~
```
[R/TMC_plugin.R:8:9:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/TMC_plugin.R#L8) *warning:* **no visible binding for global variable ‘.ui’, Did you mean 'ui'?**
```r
  ui <- .ui
        ^~~
```
[R/TMC_plugin.R:10:13:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/R/TMC_plugin.R#L10) *warning:* **no visible binding for global variable ‘.server’, Did you mean 'server'?**
```r
  server <- .server
            ^~~~~~~
```
[tests/testthat/testLintr.R:3:5:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/tests/testthat/testLintr.R#L3) *style:* **Commented code should be removed.**
```r
#   context("lints")
    ^~~~~~~~~~~~~~~~
```
[tests/testthat/testLintr.R:5:7:](https://github.com/RTMC/tmc-rstudio/blob/e78cd90c6b0cd9dd7eadee3c1ac45d2f94588882/tests/testthat/testLintr.R#L5) *style:* **Commented code should be removed.**
```r
#     lintr::expect_lint_free()
      ^~~~~~~~~~~~~~~~~~~~~~~~~
```


Hi Sigmund :)

Just letting you know the double test , as in `[[ condition ]]`,  is a bashism so shebang should be changed accordingly. There is probably quite a few of those that escape us. Someone might want default `sh` to be dash or ash.

Actually, I the `<<<` syntax is too. That might be my bad! (in various other scripts too)


Lecture 01


@romaindequidt Now you know what to do to get a free T-Shirt : https://hacktoberfest.digitalocean.com/


First of all:

- `var` is a name that tells me nothing
-  `board_filled_in_with ` and `square_filled_in_with ` as names are very similar but do completly diffrent things
- and last but not least: what is the point of using method from Board class and then pass its result to another method of Board class without any additional value?


also this #1275


please deploy


I merge this commit and the commit "IB/uverbs: ib pd using new context uobject " . So the transition to the new shared PD will happen in single commit to avoid the need to use "ib_ctx_uobj_first" functions on ib_pd. As for helper function I agree. Will do that. Thanks.


> The AuthorDate is not touched by the rebase.

Right. My problem is that SourceTree shows the commit date.

> > and the branching off point.

> What is it used for?

Nothing, I just don't see any strong reasons to spend effort rewriting the history of the commits, especially since I have a slight preference for the original history anyway.


This is causing an error in the use of pytest (which expects to do `from psychopyApp import PsychoPyApp`)
Is there a need for the import to happen within the `start_app` function?


and function 'save'


I suggest to get priority of the current thread (Thread::get_priority ()) and set lower priority of the created thread. This is done to be sure that after starting of the created thread, test thread will not be preempted immediately.


Good Looking


[R/processing.R:32:8:](https://github.com/pat-s/sperrorest/blob/4989decf346ec5f5c50787551b6627ff10b40667/R/processing.R#L32) *style:* **Variable or function name should be snake_case.**
```r
  data$FID <- seq(1:nrow(data))
       ^~~
```
[R/resample.R:63:1:](https://github.com/pat-s/sperrorest/blob/4989decf346ec5f5c50787551b6627ff10b40667/R/resample.R#L63) *style:* **Lines should not be more than 80 characters.**
```r
    stop(paste0("'strat' must either be a vector of factor type, or the name", # nocov
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sperrorest_misc.R:44:32:](https://github.com/pat-s/sperrorest/blob/4989decf346ec5f5c50787551b6627ff10b40667/R/sperrorest_misc.R#L44) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
    if (method == "euclidian") { # nocov start
                               ^
```
[R/sperrorest.R:544:1:](https://github.com/pat-s/sperrorest/blob/4989decf346ec5f5c50787551b6627ff10b40667/R/sperrorest.R#L544) *style:* **Lines should not be more than 80 characters.**
```r
            stop(paste0("No output was received from sperrorest.\n", # nocov start
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-processing.R:121:71:](https://github.com/pat-s/sperrorest/blob/4989decf346ec5f5c50787551b6627ff10b40667/tests/testthat/test-processing.R#L121) *style:* **Commas should always have a space after.**
```r
  mypred_rpart <- function(object, newdata) predict(object, newdata)[,2]
                                                                      ^
```
[tests/testthat/test-sperrorest.R:202:21:](https://github.com/pat-s/sperrorest/blob/4989decf346ec5f5c50787551b6627ff10b40667/tests/testthat/test-sperrorest.R#L202) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                  x[ fac == lev ] <- majority(x[ fac == lev ])
                    ^
```
[tests/testthat/test-sperrorest.R:202:32:](https://github.com/pat-s/sperrorest/blob/4989decf346ec5f5c50787551b6627ff10b40667/tests/testthat/test-sperrorest.R#L202) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                  x[ fac == lev ] <- majority(x[ fac == lev ])
                               ^
```
[tests/testthat/test-sperrorest.R:202:49:](https://github.com/pat-s/sperrorest/blob/4989decf346ec5f5c50787551b6627ff10b40667/tests/testthat/test-sperrorest.R#L202) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                  x[ fac == lev ] <- majority(x[ fac == lev ])
                                                ^
```
[tests/testthat/test-sperrorest.R:202:60:](https://github.com/pat-s/sperrorest/blob/4989decf346ec5f5c50787551b6627ff10b40667/tests/testthat/test-sperrorest.R#L202) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                  x[ fac == lev ] <- majority(x[ fac == lev ])
                                                           ^
```
[tests/testthat/test-sperrorest.R:253:11:](https://github.com/pat-s/sperrorest/blob/4989decf346ec5f5c50787551b6627ff10b40667/tests/testthat/test-sperrorest.R#L253) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
          ^
```
[tests/testthat/test-sperrorest.R:253:22:](https://github.com/pat-s/sperrorest/blob/4989decf346ec5f5c50787551b6627ff10b40667/tests/testthat/test-sperrorest.R#L253) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                     ^
```
[tests/testthat/test-sperrorest.R:253:39:](https://github.com/pat-s/sperrorest/blob/4989decf346ec5f5c50787551b6627ff10b40667/tests/testthat/test-sperrorest.R#L253) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                                      ^
```
[tests/testthat/test-sperrorest.R:253:50:](https://github.com/pat-s/sperrorest/blob/4989decf346ec5f5c50787551b6627ff10b40667/tests/testthat/test-sperrorest.R#L253) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                                                 ^
```
[tests/testthat/test-sperrorest.R:417:11:](https://github.com/pat-s/sperrorest/blob/4989decf346ec5f5c50787551b6627ff10b40667/tests/testthat/test-sperrorest.R#L417) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
          ^
```
[tests/testthat/test-sperrorest.R:417:22:](https://github.com/pat-s/sperrorest/blob/4989decf346ec5f5c50787551b6627ff10b40667/tests/testthat/test-sperrorest.R#L417) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                     ^
```
[tests/testthat/test-sperrorest.R:417:39:](https://github.com/pat-s/sperrorest/blob/4989decf346ec5f5c50787551b6627ff10b40667/tests/testthat/test-sperrorest.R#L417) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                                      ^
```
[tests/testthat/test-sperrorest.R:417:50:](https://github.com/pat-s/sperrorest/blob/4989decf346ec5f5c50787551b6627ff10b40667/tests/testthat/test-sperrorest.R#L417) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                                                 ^
```


Missing description of the test case.


Strange. As long as an action is derived from BaseAction (which all actions do) this returns always a value, nulls are impossible: https://github.com/gbif/ipt/blob/master/src/main/java/org/gbif/ipt/action/BaseAction.java#L113


Oops:)
Too noticeable place to notice 😄


[R/AddinLoginTab.R:22:24:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/R/AddinLoginTab.R#L22) *warning:* **no visible global function definition for ‘.getTitleAndMessage’**
```r
    titleAndMessage <- .getTitleAndMessage(response = response)
                       ^~~~~~~~~~~~~~~~~~~
```
[R/AddinSubmitTab.R:27:30:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/R/AddinSubmitTab.R#L27) *warning:* **no visible global function definition for ‘.testsPassedPercentage’, Did you mean 'testsPassedPercentage'?**
```r
    testsPassedPercentage <- .testsPassedPercentage(testResults)
                             ^~~~~~~~~~~~~~~~~~~~~~
```
[R/AddinSubmitTab.R:38:27:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/R/AddinSubmitTab.R#L38) *warning:* **no visible global function definition for ‘createSingleResultDisplay’**
```r
      testResultOutput <- createSingleResultDisplay(testResults = testResults)
                          ^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/AddinSubmitTab.R:66:32:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/R/AddinSubmitTab.R#L66) *warning:* **no visible global function definition for ‘.createDetailedMessageWithButton’**
```r
    elements <- list(elements, .createDetailedMessageWithButton(index, message))
                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/AddinSubmitTab.R:73:10:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/R/AddinSubmitTab.R#L73) *warning:* **no visible binding for global variable ‘tags’, Did you mean 'rtags'?**
```r
  btn <- tags$button(id = paste("button_", index, sep = ""), "Toggle details")
         ^~~~
```
[R/AddinSubmitTab.R:94:10:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/R/AddinSubmitTab.R#L94) *warning:* **no visible global function definition for ‘.createTestResultElement’**
```r
  return(.createTestResultElement(name = "All tests", status = "pass"))
         ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/Authentication.R:40:5:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/R/Authentication.R#L40) *style:* **Commented code should be removed.**
```r
  # url <- "https://tmc.mooc.fi/api/v8/core/org/hy/courses"
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/TMC_plugin.R:22:23:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/R/TMC_plugin.R#L22) *warning:* **no visible binding for global variable ‘.loginTab’**
```r
    shiny::callModule(.loginTab, "login")
                      ^~~~~~~~~
```
[R/TMC_plugin.R:23:23:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/R/TMC_plugin.R#L23) *warning:* **no visible binding for global variable ‘.courseTab’**
```r
    shiny::callModule(.courseTab, "courses")
                      ^~~~~~~~~~
```
[R/TMC_plugin.R:24:23:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/R/TMC_plugin.R#L24) *warning:* **no visible binding for global variable ‘.submitTab’**
```r
    shiny::callModule(.submitTab, "testAndSubmit")
                      ^~~~~~~~~~
```
[R/Zipper.R:2:1:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/R/Zipper.R#L2) *style:* **Variable or function name should be lowerCamelCase.**
```r
.tmc_zip <- function(folder, target) {
^~~~~~~~
```
[R/Zipper.R:3:3:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/R/Zipper.R#L3) *style:* **Variable or function name should be lowerCamelCase.**
```r
  files_to_zip <- dir(folder, full.names = TRUE)
  ^~~~~~~~~~~~
```
[R/Zipper.R:7:1:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/R/Zipper.R#L7) *style:* **Variable or function name should be lowerCamelCase.**
```r
.tmc_unzip <- function(zipfile_name, target_folder) {
^~~~~~~~~~
```
[R/Zipper.R:7:24:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/R/Zipper.R#L7) *style:* **Variable or function name should be lowerCamelCase.**
```r
.tmc_unzip <- function(zipfile_name, target_folder) {
                       ^~~~~~~~~~~~
```
[R/Zipper.R:7:38:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/R/Zipper.R#L7) *style:* **Variable or function name should be lowerCamelCase.**
```r
.tmc_unzip <- function(zipfile_name, target_folder) {
                                     ^~~~~~~~~~~~~
```
[R/Zipper.R:11:1:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/R/Zipper.R#L11) *style:* **Variable or function name should be lowerCamelCase.**
```r
.tmc_tar <- function(folder, target) {
^~~~~~~~
```
[R/Zipper.R:12:3:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/R/Zipper.R#L12) *style:* **Variable or function name should be lowerCamelCase.**
```r
  files_to_tar <- dir(folder, full.names = TRUE)
  ^~~~~~~~~~~~
```
[R/Zipper.R:16:1:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/R/Zipper.R#L16) *style:* **Variable or function name should be lowerCamelCase.**
```r
.tmc_untar <- function(tarfile_name, target_folder) {
^~~~~~~~~~
```
[R/Zipper.R:16:24:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/R/Zipper.R#L16) *style:* **Variable or function name should be lowerCamelCase.**
```r
.tmc_untar <- function(tarfile_name, target_folder) {
                       ^~~~~~~~~~~~
```
[R/Zipper.R:16:38:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/R/Zipper.R#L16) *style:* **Variable or function name should be lowerCamelCase.**
```r
.tmc_untar <- function(tarfile_name, target_folder) {
                                     ^~~~~~~~~~~~~
```
[tests/testthat/testLintr.R:3:5:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/tests/testthat/testLintr.R#L3) *style:* **Commented code should be removed.**
```r
#   context("lints")
    ^~~~~~~~~~~~~~~~
```
[tests/testthat/testLintr.R:5:7:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/tests/testthat/testLintr.R#L5) *style:* **Commented code should be removed.**
```r
#     lintr::expect_lint_free()
      ^~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/testZipper.R:1:1:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/tests/testthat/testZipper.R#L1) *style:* **Variable or function name should be lowerCamelCase.**
```r
test_resources_dir <- paste(sep = "", getwd(), "/resources")
^~~~~~~~~~~~~~~~~~
```
[tests/testthat/testZipper.R:3:1:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/tests/testthat/testZipper.R#L3) *style:* **Variable or function name should be lowerCamelCase.**
```r
pack_folder_path <- paste(sep = "", test_resources_dir, "/pack")
^~~~~~~~~~~~~~~~
```
[tests/testthat/testZipper.R:5:1:](https://github.com/RTMC/tmc-rstudio/blob/f71903d718f41fb07f118b45b954e04a3c6ed12c/tests/testthat/testZipper.R#L5) *style:* **Variable or function name should be lowerCamelCase.**
```r
.clean_dirs <- function() {
^~~~~~~~~~~
```


:D


Ready-to-go tweet data containing Clinton's name


You just moved ` win_combinations` to separate method in Board class. But still the Board class decides what is a win_combination ;)

What I wanted you to do was more something like in Game class:

```
def check_winner
win_combinations = [["a1", "a2", "a3"], ["b1", "b2", "b3"], ....] # etc

win_combinations.any? { |row| @board.board_filled_in_with(row, @current_user) }
end
```

and the in Board#board_filled_in_with you need to find a way to check if e.g. `["a1", "a2", "a3"]` is filled in with "X" or "O" (depending on what current_user is).

Can you re-think it, please? @cool-beetles