Comment on bbd36889191b4d4b36e98a3d256971299c3355de.

There are 25 results for the section c/cpp spacing. They have been shortened and will not be shown inline because they are more than 10.

| Message | File | Line |
|---|---|---|
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 6 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 7 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 8 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 9 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 10 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 11 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 12 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 13 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 14 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 15 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 16 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 17 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 18 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 19 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 20 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 21 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 22 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 23 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 24 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 25 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 26 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 27 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 28 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 29 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 30 |

Until GitMate provides an online UI to show a better overview, you can run [coala](https://coala.io/) locally for more details.


When I ran this code, I got this output:

*************************************
Current Status in Round 1:
Current player is: Computer

Computer: 0
You: 0

Die1: 6; Die2: 2

Round Score: 8
Potential Score: 8

Die1: 4; Die2: 3

Round Score: 15
Potential Score: 15

Die1: 4; Die2: 3

Round Score: 22
Potential Score: 22

*************************************
Current Status in Round 2:
Current player is: Human

Computer: 22
You: 0

Die1: 1; Die2: 3

Busted!

*************************************
Current Status in Round 3:
Current player is: Computer

Computer: 22
You: 0

Die1: 6; Die2: 6

Round Score: 12
Potential Score: 34

Die1: 2; Die2: 1

Busted!

*************************************
Current Status in Round 4:
Current player is: Human

Computer: 22
You: 0

Die1: 3; Die2: 5

Round Score: 8
Potential Score: 8

Take another turn (y/n)?
Y
Die1: 1; Die2: 2

Busted!

*************************************
Current Status in Round 5:
Current player is: Computer

Computer: 22
You: 0

Die1: 6; Die2: 3

Round Score: 9
Potential Score: 31

Die1: 2; Die2: 5

Round Score: 16
Potential Score: 38

Die1: 4; Die2: 6

Round Score: 26
Potential Score: 48

*************************************
Current Status in Round 6:
Current player is: Human

Computer: 48
You: 0

Die1: 4; Die2: 4

Round Score: 8
Potential Score: 8

Take another turn (y/n)?
y
Die1: 2; Die2: 2

Round Score: 12
Potential Score: 12

Take another turn (y/n)?
y
Die1: 3; Die2: 3

Round Score: 18
Potential Score: 18

Take another turn (y/n)?
y
Die1: 4; Die2: 6

Round Score: 28
Potential Score: 28

Take another turn (y/n)?
y
*************************************
Current Status in Round 7:
Current player is: Computer

Computer: 28
You: 0

Die1: 4; Die2: 2

Round Score: 6
Potential Score: 34

Die1: 5; Die2: 4

Round Score: 15
Potential Score: 43

Die1: 3; Die2: 2

Round Score: 20
Potential Score: 48

*************************************
Current Status in Round 8:
Current player is: Human

Computer: 48
You: 0

Die1: 3; Die2: 3

Round Score: 6
Potential Score: 6

Take another turn (y/n)?

---------------------------
in round 6, Human turn, The answer was 'Y' and then it automatically went to computer's turn, without telling the user if they were busted or anything


@Madmonkey1907 Do you think this would work?

Will there be a problem taking out `cryptsetup close root-crypt`?


@MarfGamer it make no sense that PMMP could work on the same machine but JRakNet couldn't. :O


@TimothyGu let's make #84 version 5.0, as it's also a breaking change.


Comment on 142dc3ed019eb2f7ceff58b9a8264e1827a07530.

There are 23 results for the section c/cpp spacing. They have been shortened and will not be shown inline because they are more than 10.

| Message | File | Line |
|---|---|---|
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 7 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 8 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 9 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 10 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 11 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 12 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 13 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 14 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 15 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 16 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 17 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 18 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 19 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 20 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 21 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 22 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 23 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 24 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 25 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 26 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 27 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 28 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | 2017/SEPT/SEPT17/CHEFPDIG/CHEFPDIG.cpp | 29 |

Until GitMate provides an online UI to show a better overview, you can run [coala](https://coala.io/) locally for more details.


chd still does not play, i think we need this too(or its android equivalent) in android's main makefile:

```
HAVE_CHD = 1

ifeq ($(HAVE_CHD), 1)
   CHDLIBDIR = $(CORE_DIR)/core/cd_hw/libchdr
endif

ifeq ($(HAVE_CHD), 1)
	DEFINES += -DUSE_LIBCHDR -DPACKAGE_VERSION=\"1.3.2\" -DFLAC_API_EXPORTS -DFLAC__HAS_OGG=0 -DHAVE_LROUND -DHAVE_STDINT_H -DHAVE_SYS_PARAM_H -D_7ZIP_ST
endif
```


[R/GetAvailablePoints.R:15:3:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/R/GetAvailablePoints.R#L15) *warning:* **local variable ‘original_path’ assigned but may not be used**
```r
  original_path <- getwd()
  ^~~~~~~~~~~~~
```
[R/ResultsCreator.R:8:15:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/R/ResultsCreator.R#L8) *warning:* **no visible global function definition for ‘.get_status_for_test’**
```r
    status <- .get_status_for_test(test)
              ^~~~~~~~~~~~~~~~~~~~
```
[R/ResultsCreator.R:9:16:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/R/ResultsCreator.R#L9) *warning:* **no visible global function definition for ‘.create_message_for_test’**
```r
    message <- .create_message_for_test(test)
               ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ResultsJsonParser.R:2:51:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/R/ResultsJsonParser.R#L2) *style:* **Variable or function name should be snake_case.**
```r
.create_available_points_json_results <- function(testthatOutput) {
                                                  ^~~~~~~~~~~~~~
```
[R/ResultsJsonParser.R:9:31:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/R/ResultsJsonParser.R#L9) *style:* **Put spaces around all infix operators.**
```r
      results[[length(results)+1]] <- list(name=unbox(name), points=points)
                             ~^~
```
[R/ResultsJsonParser.R:9:48:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/R/ResultsJsonParser.R#L9) *style:* **Put spaces around all infix operators.**
```r
      results[[length(results)+1]] <- list(name=unbox(name), points=points)
                                              ~^~
```
[R/ResultsJsonParser.R:9:49:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/R/ResultsJsonParser.R#L9) *warning:* **no visible global function definition for ‘unbox’, Did you mean 'box'?**
```r
      results[[length(results)+1]] <- list(name=unbox(name), points=points)
                                                ^~~~~
```
[R/ResultsJsonParser.R:9:68:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/R/ResultsJsonParser.R#L9) *style:* **Put spaces around all infix operators.**
```r
      results[[length(results)+1]] <- list(name=unbox(name), points=points)
                                                                  ~^~
```
[R/ResultsJsonParser.R:13:10:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/R/ResultsJsonParser.R#L13) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  return (results)
         ^
```
[R/ResultsJsonParser.R:20:25:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/R/ResultsJsonParser.R#L20) *warning:* **no visible global function definition for ‘.create_json_test_result’**
```r
    test_json_result <- .create_json_test_result(test_result)
                        ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ResultsJsonParser.R:39:20:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/R/ResultsJsonParser.R#L39) *warning:* **no visible global function definition for ‘toJSON’**
```r
  json <- enc2utf8(toJSON(results, pretty = FALSE))
                   ^~~~~~
```
[R/ResultsJsonParser.R:40:11:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/R/ResultsJsonParser.R#L40) *warning:* **no visible global function definition for ‘prettify’, Did you mean 'pretty'?**
```r
  json <- prettify(json)
          ^~~~~~~~
```
[R/RunTests.R:12:19:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/R/RunTests.R#L12) *warning:* **no visible global function definition for ‘.run_tests_project’**
```r
  test_results <- .run_tests_project(project_path)
                  ^~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:14:19:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/R/RunTests.R#L14) *warning:* **no visible global function definition for ‘.create_json_results’**
```r
  json_results <- .create_json_results(test_results)
                  ^~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:15:3:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/R/RunTests.R#L15) *warning:* **no visible global function definition for ‘.write_json’**
```r
  .write_json(json_results, ".results.json")
  ^~~~~~~~~~~
```
[R/RunTests.R:18:5:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/R/RunTests.R#L18) *warning:* **no visible global function definition for ‘.print_results_from_json’**
```r
    .print_results_from_json(json_results)
    ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:33:21:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/R/RunTests.R#L33) *warning:* **no visible global function definition for ‘.run_tests_file’**
```r
    file_results <- .run_tests_file(test_file)
                    ^~~~~~~~~~~~~~~
```
[R/RunTests.R:43:3:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/R/RunTests.R#L43) *warning:* **no visible global function definition for ‘test_file’**
```r
  test_file_output <- test_file(file_path, reporter = "silent")
  ^~~~~~~~~
```
[R/RunTests.R:45:24:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/R/RunTests.R#L45) *warning:* **no visible global function definition for ‘.create_file_results’**
```r
  test_file_results <- .create_file_results(test_file_output, points, .GlobalEnv$points_for_all_tests)
                       ^~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:51:3:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/R/RunTests.R#L51) *warning:* **no visible global function definition for ‘run_tests’**
```r
  run_tests(getwd(), bol)
  ^~~~~~~~~
```
[R/RunTests.R:59:23:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/R/RunTests.R#L59) *warning:* **no visible global function definition for ‘.get_available_points’**
```r
  available_points <- .get_available_points(project_path)
                      ^~~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:61:19:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/R/RunTests.R#L61) *warning:* **no visible global function definition for ‘.create_available_points_json_results’**
```r
  json_results <- .create_available_points_json_results(available_points)
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:62:3:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/R/RunTests.R#L62) *warning:* **no visible global function definition for ‘.write_json’**
```r
  .write_json(json_results, ".available_points.json")
  ^~~~~~~~~~~
```
[tests/testthat/resources/simple_all_tests_fail/tests/testthat/helperTMC.R:12:3:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/tests/testthat/resources/simple_all_tests_fail/tests/testthat/helperTMC.R#L12) *warning:* **no visible global function definition for ‘test_that’**
```r
  test_that(desc, code)
  ^~~~~~~~~
```
[tests/testthat/resources/simple_all_tests_pass/tests/testthat/helperTMC.R:12:3:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/tests/testthat/resources/simple_all_tests_pass/tests/testthat/helperTMC.R#L12) *warning:* **no visible global function definition for ‘test_that’**
```r
  test_that(desc, code)
  ^~~~~~~~~
```
[tests/testthat/resources/simple_some_tests_fail/tests/testthat/helperTMC.R:12:3:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/tests/testthat/resources/simple_some_tests_fail/tests/testthat/helperTMC.R#L12) *warning:* **no visible global function definition for ‘test_that’**
```r
  test_that(desc, code)
  ^~~~~~~~~
```
[tests/testthat/testLintr.R:2:5:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/tests/testthat/testLintr.R#L2) *style:* **Commented code should be removed.**
```r
#   context("lints")
    ^~~~~~~~~~~~~~~~
```
[tests/testthat/testLintr.R:4:7:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/tests/testthat/testLintr.R#L4) *style:* **Commented code should be removed.**
```r
#     lintr::expect_lint_free()
      ^~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/testRunTests.R:74:1:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/tests/testthat/testRunTests.R#L74) *style:* **Lines should not be more than 160 characters.**
```r
  expected_json_result[[4]] <- list(status = "fail", name = "ret_false returns true", message = "Failed with call: expect_true, ret_false()\nret_false() isn't true.\n", backtrace = list(), points = list("r1", "r1.5"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/testRunTests.R:95:37:](https://github.com/RTMC/tmc-r-tester/blob/74edc1f5d84e735e3ee0f9d4c46661b2dddc7d3e/tests/testthat/testRunTests.R#L95) *style:* **Put spaces around all infix operators.**
```r
  available_points_path <- paste(sep="", simple_all_tests_pass_project_path, "/.available_points.json")
                                   ~^~
```


Why the *2?


[R/GetAvailablePoints.R:5:3:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/GetAvailablePoints.R#L5) *warning:* **no visible global function definition for ‘.init_global_vars’**
```r
  .init_global_vars()
  ^~~~~~~~~~~~~~~~~
```
[R/GetAvailablePoints.R:10:53:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/GetAvailablePoints.R#L10) *warning:* **no visible global function definition for ‘.create_counter_env’**
```r
    test_file(test_file, reporter = "silent", env = .create_counter_env())
                                                    ^~~~~~~~~~~~~~~~~~~
```
[R/GetAvailablePoints.R:13:10:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/GetAvailablePoints.R#L13) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  return (.add_points(.GlobalEnv$test_available_points, .GlobalEnv$file_points, .GlobalEnv$map_to_desc))
         ^
```
[R/GetAvailablePoints.R:13:11:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/GetAvailablePoints.R#L13) *warning:* **no visible global function definition for ‘.add_points’**
```r
  return (.add_points(.GlobalEnv$test_available_points, .GlobalEnv$file_points, .GlobalEnv$map_to_desc))
          ^~~~~~~~~~~
```
[R/GetAvailablePoints.R:30:10:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/GetAvailablePoints.R#L30) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  return (all_available_points)
         ^
```
[R/GetAvailablePoints.R:35:3:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/GetAvailablePoints.R#L35) *warning:* **no visible global function definition for ‘.define_counter_functions’**
```r
  .define_counter_functions(test_env)
  ^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/GetAvailablePoints.R:36:10:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/GetAvailablePoints.R#L36) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  return (test_env)
         ^
```
[R/GetAvailablePoints.R:40:3:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/GetAvailablePoints.R#L40) *warning:* **no visible global function definition for ‘.source_files’**
```r
  .source_files(test_env)
  ^~~~~~~~~~~~~
```
[R/GetAvailablePoints.R:58:23:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/GetAvailablePoints.R#L58) *warning:* **no visible global function definition for ‘.get_available_points’**
```r
  available_points <- .get_available_points(project_path)
                      ^~~~~~~~~~~~~~~~~~~~~
```
[R/GetAvailablePoints.R:60:19:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/GetAvailablePoints.R#L60) *warning:* **no visible global function definition for ‘.create_available_points_json_results’**
```r
  json_results <- .create_available_points_json_results(available_points)
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/GetAvailablePoints.R:61:3:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/GetAvailablePoints.R#L61) *warning:* **no visible global function definition for ‘.write_json’**
```r
  .write_json(json_results, ".available_points.json")
  ^~~~~~~~~~~
```
[R/ResultsCreator.R:8:15:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/ResultsCreator.R#L8) *warning:* **no visible global function definition for ‘.get_status_for_test’**
```r
    status <- .get_status_for_test(test)
              ^~~~~~~~~~~~~~~~~~~~
```
[R/ResultsCreator.R:9:16:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/ResultsCreator.R#L9) *warning:* **no visible global function definition for ‘.create_message_for_test’**
```r
    message <- .create_message_for_test(test)
               ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ResultsJsonParser.R:7:10:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/ResultsJsonParser.R#L7) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  return (results)
         ^
```
[R/ResultsJsonParser.R:14:25:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/ResultsJsonParser.R#L14) *warning:* **no visible global function definition for ‘.create_json_test_result’**
```r
    test_json_result <- .create_json_test_result(test_result)
                        ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ResultsJsonParser.R:17:36:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/ResultsJsonParser.R#L17) *warning:* **no visible global function definition for ‘unbox’, Did you mean 'box'?**
```r
  json_results <- list(runStatus = unbox("success"), backtrace = list(), testResults = json_test_results)
                                   ^~~~~
```
[R/ResultsJsonParser.R:34:20:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/ResultsJsonParser.R#L34) *warning:* **no visible global function definition for ‘toJSON’**
```r
  json <- enc2utf8(toJSON(results, pretty = FALSE))
                   ^~~~~~
```
[R/ResultsJsonParser.R:35:11:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/ResultsJsonParser.R#L35) *warning:* **no visible global function definition for ‘prettify’, Did you mean 'pretty'?**
```r
  json <- prettify(json)
          ^~~~~~~~
```
[R/RunTests.R:12:19:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/RunTests.R#L12) *warning:* **no visible global function definition for ‘.run_tests_project’**
```r
  test_results <- .run_tests_project(project_path)
                  ^~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:14:19:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/RunTests.R#L14) *warning:* **no visible global function definition for ‘.create_json_results’**
```r
  json_results <- .create_json_results(test_results)
                  ^~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:15:3:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/RunTests.R#L15) *warning:* **no visible global function definition for ‘.write_json’**
```r
  .write_json(json_results, ".results.json")
  ^~~~~~~~~~~
```
[R/RunTests.R:18:5:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/RunTests.R#L18) *warning:* **no visible global function definition for ‘.print_results_from_json’**
```r
    .print_results_from_json(json_results)
    ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:33:21:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/RunTests.R#L33) *warning:* **no visible global function definition for ‘.run_tests_file’**
```r
    file_results <- .run_tests_file(test_file, test_env)
                    ^~~~~~~~~~~~~~~
```
[R/RunTests.R:33:48:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/RunTests.R#L33) *warning:* **no visible binding for global variable ‘test_env’**
```r
    file_results <- .run_tests_file(test_file, test_env)
                                               ^~~~~~~~
```
[R/RunTests.R:41:3:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/RunTests.R#L41) *warning:* **no visible global function definition for ‘.define_tester_functions’**
```r
  .define_tester_functions(test_env)
  ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:43:13:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/RunTests.R#L43) *warning:* **no visible global function definition for ‘.source_files’**
```r
  tryCatch({.source_files(test_env)},
            ^~~~~~~~~~~~~
```
[R/RunTests.R:45:10:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/RunTests.R#L45) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  return (test_env)
         ^
```
[R/RunTests.R:50:3:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/RunTests.R#L50) *warning:* **no visible global function definition for ‘.define_tester_functions’**
```r
  .define_tester_functions(test_env)
  ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:51:13:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/RunTests.R#L51) *warning:* **no visible global function definition for ‘.source_from_test_file’**
```r
  tryCatch({.source_from_test_file(test_file, test_env)},
            ^~~~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:53:10:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/RunTests.R#L53) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  return (test_env)
         ^
```
[R/RunTests.R:65:5:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/RunTests.R#L65) *warning:* **no visible global function definition for ‘test_that’**
```r
    test_that(desc, code)
    ^~~~~~~~~
```
[R/RunTests.R:90:3:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/RunTests.R#L90) *warning:* **no visible global function definition for ‘test_file’**
```r
  test_file_output <- test_file(file_path, reporter = "silent", env = .create_test_env())
  ^~~~~~~~~
```
[R/RunTests.R:90:71:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/RunTests.R#L90) *warning:* **no visible global function definition for ‘.create_test_env’**
```r
  test_file_output <- test_file(file_path, reporter = "silent", env = .create_test_env())
                                                                      ^~~~~~~~~~~~~~~~
```
[R/RunTests.R:92:24:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/RunTests.R#L92) *warning:* **no visible global function definition for ‘.create_file_results’**
```r
  test_file_results <- .create_file_results(test_file_output, points, .GlobalEnv$points_for_all_tests)
                       ^~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:100:3:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/RunTests.R#L100) *warning:* **no visible global function definition for ‘.write_json’**
```r
  .write_json(list(runStatus = unbox("sourcing_failed"), backtrace = list(), testResults = list()), ".results.json")
  ^~~~~~~~~~~
```
[R/RunTests.R:100:32:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/R/RunTests.R#L100) *warning:* **no visible global function definition for ‘unbox’, Did you mean 'box'?**
```r
  .write_json(list(runStatus = unbox("sourcing_failed"), backtrace = list(), testResults = list()), ".results.json")
                               ^~~~~
```
[tests/testthat/resources/simple_source_code_error/R/main.R:6:20:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/tests/testthat/resources/simple_source_code_error/R/main.R#L6) *style:* **Place a space before left parenthesis, except in a function call.**
```r
ret_one <- function() {
                   ^
```
[tests/testthat/resources/simple_source_code_error/R/main.R:7:9:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/tests/testthat/resources/simple_source_code_error/R/main.R#L7) *error:* **unexpected 'in'**
```r
  error in source code
        ^
```
[tests/testthat/resources/simple_source_code_error/tests/testthat/helperTMC.R:12:3:](https://github.com/RTMC/tmc-r-tester/blob/ccad1d3c105b76250c48c400e5855834e97c5399/tests/testthat/resources/simple_source_code_error/tests/testthat/helperTMC.R#L12) *warning:* **no visible global function definition for ‘test_that’**
```r
  test_that(desc, code)
  ^~~~~~~~~
```


inital


An interner implementation is just ~20 lines of code. We previously depended on Google's Guava library, which is 2.5MB and brings transitive dependencies.

We also only used two components from Guava, one being the interner, the other being a single use of `ComparisonChain`.

So I decided to trade a 2.5MB+ dependency for 20 lines of code.


Arbitrary unicode should be fine. I wanted the PR for a place to discuss the change. :)


Something went wrong when running [your job](https://github.com/JuliaLang/julia/commit/894b6502c22f929c52331f6f0c311b591761ee2d#commitcomment-24997611):
```
NanosoldierError: failed to run benchmarks against primary commit: stored type BenchmarkTools.ParametersPreV006 does not match currently loaded type
```
Logs and partial data can be found [here](https://github.com/JuliaCI/BaseBenchmarkReports/blob/fcaba560f14f9b1536ef0be5627ee29bf756b6db/daily_2017_10_16/report.md)
cc @ararslan


oh also the sprayer and guard classes have nice and proper sight ranges to make them not op


This is better.
I added the Stack class to make it IDeliverable (which allows the warehouse to fullfill the request) and to have a possibility to add logic later, like ignore metadata, or oredic äquivalent.


COOL thx for the update! :D :D
been looking forward to this for 2+ years ;)

Could I suggest/persuade modifying the changes list for v2.0.1 to increase readability . ^_^
Try to regroup it by what was changed and/or maybe alphabetically order....
pretty please ;) :D :D lol


f8cf733 --> #381


Project name updates


finishing


Comment on 42e8e43


97b534c cherry-picked to #373.


Normalement, ça fonctionne ... Au pire, j'ai tout sur ma clé.
Mon commentaire aurait été :
Détails de "Acheter carte", "Détruire carte" et "Composer deck"

Ajout documentation de "Acheter carte"
Ajout documentation de "Détruire carte"
Ajout documentation de "Composer deck"
Création et documentation de "Sélectionner carte"
Création et documentation de "Rechercher carte"
Ajout de liens :
- "Acheter" / "Détruire" include "Sélectionner carte"
- "Rechercher carte" extend "Sélectionner" et "Composer"

Notes :
Ouais, c'est long et un peu lourd.
Il faut que je redemande au prof comment représenter un use case
Ajout/Modifier/Supprimer, parce que c'est ce qu'il faut pour Composer
et pour relier Acheter et Détruire carte.
Mais je ferais ça plus tard ¯\_(ツ)_/¯'


e71e30e cherry-picked to #373.


Bluemix [toolchain](https://console.bluemix.net/devops/toolchains/c74f8248-fea8-440b-bfd4-822ecb10c7be "emma-toolchain"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/0811a336-3049-4159-ba04-aaf43efd0023 "emma") deployed [leave](https://github.com/goyal-sidd/leave/releases/tag/deploy-ibm-yp-us-south-sid22-leave-20171016-060548 "deploy-ibm-yp-us-south-sid22-leave-20171016-060548") to [leave](https://console.bluemix.net/apps/0e816a54-7da8-4450-8e72-70dc537dc333?env_id=ibm:yp:us-south "ibm:yp:us-south:sid22:leave"), including this commit


The ca0b74e change is in #373.


08172f4 cherry-picked to #379.


[controller fix test.zip](https://github.com/DanTheMan827/hakchi2/files/1386339/controller.fix.test.zip)


23c65d3 cherry-picked to #380.


9072ca8 `cherry-pick`ed to #377.


4710b8e `cherry-pick`ed to #377.


Comment on 6ba5bcb


3feff95 `cherry-pick`ed to #377.


非常好