[inst/examples/Wolf-Sheep-Predation/Wolf-Sheep-Predation.R:249:8:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/inst/examples/Wolf-Sheep-Predation/Wolf-Sheep-Predation.R#L249) *style:* **Place a space before left parenthesis, except in a function call.**
```r
while ((NLany(sheep) | NLany(wolves)) & time < maxTime) {
       ^
```
[inst/examples/Wolf-Sheep-Predation/WolfSheepPredation/WolfSheepPredation.R:64:1:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/inst/examples/Wolf-Sheep-Predation/WolfSheepPredation/WolfSheepPredation.R#L64) *style:* **Variable or function name should be lowerCamelCase.**
```r
doEvent.WolfSheepPredation <- function(sim, eventTime, eventType, debug = FALSE) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/Classes.R:94:12:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/R/Classes.R#L94) *style:* **Variable or function name should be lowerCamelCase.**
```r
  function(.Object="agentMatrix", coords, ..., levelsAM) {
           ^~~~~~~
```
[R/Classes.R:178:11:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/R/Classes.R#L178) *style:* **Place a space before left parenthesis, except in a function call.**
```r
      if ((is.matrix(dotCols[[1]]) & is.numeric(dotCols[[1]])) | is(dotCols[[1]], "agentMatrix"))
          ^
```
[R/Classes.R:699:1:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/R/Classes.R#L699) *style:* **Variable or function name should be lowerCamelCase.**
```r
head.agentMatrix <- function(x, n = 6L, ...) {
^~~~~~~~~~~~~~~~
```
[R/Classes.R:708:1:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/R/Classes.R#L708) *style:* **Variable or function name should be lowerCamelCase.**
```r
tail.agentMatrix <- function(x, n = 6L, ...) {
^~~~~~~~~~~~~~~~
```
[R/Classes.R:730:36:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/R/Classes.R#L730) *style:* **Variable or function name should be lowerCamelCase.**
```r
cbind.agentMatrix <- function(..., deparse.level) {
                                   ^~~~~~~~~~~~~
```
[R/Classes.R:755:36:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/R/Classes.R#L755) *style:* **Variable or function name should be lowerCamelCase.**
```r
rbind.agentMatrix <- function(..., deparse.level = 1) {
                                   ^~~~~~~~~~~~~
```
[R/NetLogoR-classes.R:503:11:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/R/NetLogoR-classes.R#L503) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    floor((cellNum - 1) / b[2]) + seq.int(from = 1, to = prod(b),
          ^
```
[R/turtle-functions.R:93:32:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/R/turtle-functions.R#L93) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    coords <- cbind(xcor = rep(((maxPxcor(world) - minPxcor(world)) / 2) + minPxcor(world), n),
                               ^
```
[R/turtle-functions.R:93:33:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/R/turtle-functions.R#L93) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    coords <- cbind(xcor = rep(((maxPxcor(world) - minPxcor(world)) / 2) + minPxcor(world), n),
                                ^
```
[R/turtle-functions.R:94:32:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/R/turtle-functions.R#L94) *style:* **Place a space before left parenthesis, except in a function call.**
```r
                    ycor = rep(((maxPycor(world) - minPycor(world)) / 2) + minPycor(world), n))
                               ^
```
[R/turtle-functions.R:94:33:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/R/turtle-functions.R#L94) *style:* **Place a space before left parenthesis, except in a function call.**
```r
                    ycor = rep(((maxPycor(world) - minPycor(world)) / 2) + minPycor(world), n))
                                ^
```
[R/turtle-functions.R:454:35:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/R/turtle-functions.R#L454) *style:* **Place a space before left parenthesis, except in a function call.**
```r
                          xcor = ((world@extent@xmax - world@extent@xmin) / 2) +
                                  ^
```
[R/turtle-functions.R:456:35:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/R/turtle-functions.R#L456) *style:* **Place a space before left parenthesis, except in a function call.**
```r
                          ycor = ((world@extent@ymax - world@extent@ymin) / 2) +
                                  ^
```
[tests/testthat/test-agentMatrix.R:164:15:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-agentMatrix.R#L164) *style:* **Use <-, not =, for assignment.**
```r
           a1 = st_point(cbind(1, 3))
              ^
```
[tests/testthat/test-agentMatrix.R:165:15:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-agentMatrix.R#L165) *style:* **Use <-, not =, for assignment.**
```r
           a2 = st_point(cbind(2, 4))
              ^
```
[tests/testthat/test-agentMatrix.R:166:15:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-agentMatrix.R#L166) *style:* **Use <-, not =, for assignment.**
```r
           a3 = st_point(cbind(5, 6))
              ^
```
[tests/testthat/test-agentMatrix.R:167:14:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-agentMatrix.R#L167) *style:* **Use <-, not =, for assignment.**
```r
           d =  data = data.frame(
             ^
```
[tests/testthat/test-agentMatrix.R:167:22:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-agentMatrix.R#L167) *style:* **Use <-, not =, for assignment.**
```r
           d =  data = data.frame(
                     ^
```
[tests/testthat/test-agentMatrix.R:170:19:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-agentMatrix.R#L170) *style:* **Use <-, not =, for assignment.**
```r
           d$geom = st_sfc(a1, a2, a3)
                  ^
```
[tests/testthat/test-agentMatrix.R:171:15:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-agentMatrix.R#L171) *style:* **Use <-, not =, for assignment.**
```r
           df = st_as_sf(d)
              ^
```
[tests/testthat/test-turtle-functions.R:725:6:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L725) *style:* **Put spaces around all infix operators.**
```r
  ws <-stackWorlds(w1, w2)
     ^~~
```
[tests/testthat/test-turtle-functions.R:744:51:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L744) *style:* **Commas should always have a space after.**
```r
  expect_identical(tExist(turtles = t1, who = c(3,11, 9)), c(TRUE, FALSE, TRUE))
                                                  ^
```
[tests/testthat/test-turtle-functions.R:745:51:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L745) *style:* **Commas should always have a space after.**
```r
  expect_identical(tExist(turtles = t1, who = c(3,11, 9), breed = "sheep"), c(TRUE, FALSE, FALSE))
                                                  ^
```
[tests/testthat/test-turtle-functions.R:746:51:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L746) *style:* **Commas should always have a space after.**
```r
  expect_identical(tExist(turtles = t1, who = c(3,11, 9), breed = c("sheep", "wolf")),
                                                  ^
```
[tests/testthat/test-turtle-functions.R:791:33:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L791) *style:* **Commas should always have a space after.**
```r
  expect_equivalent(noTurtles(),t16)
                                ^
```
[tests/testthat/test-turtle-functions.R:865:25:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L865) *style:* **Commas should always have a space after.**
```r
  expect_equivalent(t10,t6)
                        ^
```
[tests/testthat/test-turtle-functions.R:982:1:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L982) *style:* **Lines should not be more than 100 characters.**
```r
  t5 <- turtlesOwn(turtles = t1, tVar = "female", tVal = c("TRUE", "TRUE", "FALSE", "FALSE", "FALSE"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-turtle-functions.R:1039:93:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L1039) *style:* **Commas should always have a space after.**
```r
  p5 <- other(agents = patches(ws), except = cbind(pxcor = c(0, 1, 2, 2), pycor = c(0, 1, 2,2)))
                                                                                ^
```
[tests/testthat/test-turtle-functions.R:1087:3:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L1087) *style:* **Variable or function name should be lowerCamelCase.**
```r
  w1_1 <- of(world = w1, agents = patch(w1, 0, 4))
  ^~~~
```
[tests/testthat/test-turtle-functions.R:1089:3:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L1089) *style:* **Variable or function name should be lowerCamelCase.**
```r
  w1_12 <- of(world = w1, agents = patch(w1, c(0, 1), c(4, 4)))
  ^~~~~
```
[tests/testthat/test-turtle-functions.R:1091:3:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L1091) *style:* **Variable or function name should be lowerCamelCase.**
```r
  w1_all <-of(world = w1, agents = patches(w1))
  ^~~~~~
```
[tests/testthat/test-turtle-functions.R:1091:10:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L1091) *style:* **Put spaces around all infix operators.**
```r
  w1_all <-of(world = w1, agents = patches(w1))
         ^~~
```
[tests/testthat/test-turtle-functions.R:1093:3:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L1093) *style:* **Variable or function name should be lowerCamelCase.**
```r
  w1_31 <- of(world = w1, agents = patch(w1, c(2, 0), c(4, 4)))
  ^~~~~
```
[tests/testthat/test-turtle-functions.R:1098:3:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L1098) *style:* **Variable or function name should be lowerCamelCase.**
```r
  w1_1 <- of(world = w3, var = "w1", agents = patch(w1, 0, 4))
  ^~~~
```
[tests/testthat/test-turtle-functions.R:1100:3:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L1100) *style:* **Variable or function name should be lowerCamelCase.**
```r
  w1_12 <- of(world = w3, var = "w1", agents = patch(w1, c(0, 1), c(4, 4)))
  ^~~~~
```
[tests/testthat/test-turtle-functions.R:1102:3:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L1102) *style:* **Variable or function name should be lowerCamelCase.**
```r
  w1_all <-of(world = w3, var = "w1", agents = patches(w1))
  ^~~~~~
```
[tests/testthat/test-turtle-functions.R:1102:10:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L1102) *style:* **Put spaces around all infix operators.**
```r
  w1_all <-of(world = w3, var = "w1", agents = patches(w1))
         ^~~
```
[tests/testthat/test-turtle-functions.R:1104:3:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L1104) *style:* **Variable or function name should be lowerCamelCase.**
```r
  w1_31 <- of(world = w3, var = "w1", agents = patch(w1, c(2, 0), c(4, 4)))
  ^~~~~
```
[tests/testthat/test-turtle-functions.R:1107:3:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L1107) *style:* **Variable or function name should be lowerCamelCase.**
```r
  w2_1 <- of(world = w3, var = "w2", agents = patch(w1, 0, 4))
  ^~~~
```
[tests/testthat/test-turtle-functions.R:1109:3:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L1109) *style:* **Variable or function name should be lowerCamelCase.**
```r
  w2_12 <- of(world = w3, var = "w2", agents = patch(w1, c(0, 1), c(4, 4)))
  ^~~~~
```
[tests/testthat/test-turtle-functions.R:1111:3:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L1111) *style:* **Variable or function name should be lowerCamelCase.**
```r
  w2_all <-of(world = w3, var = "w2", agents = patches(w1))
  ^~~~~~
```
[tests/testthat/test-turtle-functions.R:1111:10:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L1111) *style:* **Put spaces around all infix operators.**
```r
  w2_all <-of(world = w3, var = "w2", agents = patches(w1))
         ^~~
```
[tests/testthat/test-turtle-functions.R:1113:3:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L1113) *style:* **Variable or function name should be lowerCamelCase.**
```r
  w2_31 <- of(world = w3, var = "w2", agents = patch(w1, c(2, 0), c(4, 4)))
  ^~~~~
```
[tests/testthat/test-turtle-functions.R:1127:29:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L1127) *style:* **Commas should always have a space after.**
```r
  theading <- of(agents = t,var = "heading")
                            ^
```
[tests/testthat/test-turtle-functions.R:1182:52:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L1182) *style:* **Put spaces around all infix operators.**
```r
  expect_equivalent(t2@coords, of(agents = t1, var =c("xcor", "ycor")))
                                                   ^~
```
[tests/testthat/test-turtle-functions.R:1188:66:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L1188) *style:* **Commas should always have a space after.**
```r
  expect_equivalent(colnames(sp1Turtles@.Data), c("xcor", "ycor","who", "heading", "prevX", "prevY",
                                                                 ^
```
[tests/testthat/test-turtle-functions.R:1196:59:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-turtle-functions.R#L1196) *style:* **Commas should always have a space after.**
```r
  expect_equivalent(colnames(sp2@.Data), c("xcor", "ycor","who", "heading", "prevX", "prevY",
                                                          ^
```
[tests/testthat/test-world-functions.R:66:7:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-world-functions.R#L66) *style:* **Put spaces around all infix operators.**
```r
  r1[]<-runif(100)
     ~^~~
```
[tests/testthat/test-world-functions.R:68:7:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-world-functions.R#L68) *style:* **Put spaces around all infix operators.**
```r
  r2[]<-runif(100)
     ~^~~
```
[tests/testthat/test-world-functions.R:76:3:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-world-functions.R#L76) *style:* **Variable or function name should be lowerCamelCase.**
```r
  r1_ <- world2raster(w1)
  ^~~
```
[tests/testthat/test-world-functions.R:77:3:](https://github.com/PredictiveEcology/NetLogoR/blob/2d21405d88d29068405069b5d33d9dc3019c537d/tests/testthat/test-world-functions.R#L77) *style:* **Variable or function name should be lowerCamelCase.**
```r
  rs_ <- world2raster(ws)
  ^~~
```


#blameMojang


This should be default in code so we don't have to enable individual tests


fixed


👎 1 call to append I think it's better.


It could, I've just acquired the habit of writing directly to proc.


ok


Failed tests are from plugins backend and blockly due to massive changes to those plugins, the tests have to be corrected.


Checkmarx scan results 03 Oct 2017 15:25 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

e187c437c0c6bbff82b5b325121c8bdd2d9cf597	@web-flow


 - remove postfix Impl - fixed
- add prefix I to interfaces - fixed


TT


Test Line Kommentar


This needs to be tested on all platforms/DPIs again. It would be my guess that pointsize automatically includes the scaling we use _em_height for. Also 1px != 1pt, so I would be surprised if this didn’t dramatically alter font sizes in the application


Und hier noch eins


Это не ссылка.
https://habrahabr.ru/company/mailru/blog/321306/


Test Kommentar


@emrevarol @oleksiys Good points. I'm going to rework this code a little bit today.


@Tabjones @memnone

Guys, just found that the 8 we are having is exactly the value of the kernel parameter powered to 3, now it is set to 2.0 [here](https://github.com/pacman-project/gaussian-object-modelling/blob/boris_devel/src/gp_node.cpp#L949), if I change to 1 I get 1, and if I change it to 0.5 I get 0.125, no variation whatsoever in the rest of parameters around

I see several changes on this matter coming back and forth from the choleski computation, but the question remains, don't know why it is not working in the current setup

The query point is being demean and normalized [here](https://github.com/pacman-project/gaussian-object-modelling/blob/boris_devel/src/gp_node.cpp#L213), so it is in the same frame and scale as the rest of the GP model

I'm running out of ideas, do you have any on this matter, or recall anything about it?


https://github.com/Jackett/Jackett/blob/master/src/Jackett/Indexers/Feeds/AnimeTosho.cs#L16
The third argument of the base() call (currently the empty string) is the description
`base("Anime Tosho", "https://animetosho.org/", "<DESCRIPTION GOES EHRE>", configService, client, logger, new ConfigurationData(), p)`


wow I didn't saw, I'll compile master!


Checkmarx scan results 03 Oct 2017 15:29 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

d8daabc5d7e290e0c818bfbfb95567abe6ef5a96	@web-flow


Checkmarx scan results 03 Oct 2017 15:30 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

d8daabc5d7e290e0c818bfbfb95567abe6ef5a96	@web-flow


Thanks again, fixed in 4a5ff4e7f947da6130a25900443317c18e879acf.


handle `KeyboardInterrupt`


Но это, конечно, лишнее усложнение для такой простой программы. Вообще, не советую ни сейчас ни в будущем не усложнять решение, помни о принципе [KISS](https://ru.wikipedia.org/wiki/KISS_(%D0%BF%D1%80%D0%B8%D0%BD%D1%86%D0%B8%D0%BF)), он еще не раз поможет.


Тут лучше найти сначала гипотенузу (можно использовать массивы для этого, если умеешь) и затем один раз вычислить уравнение.


Нужно еще уметь на равносторонность проверять.


Ah, I misread the whole issue. Osmium checks the validity in 4326 and throws away anything invalid. But a valid 4326 polygon might still be invalid after projecting, so it has to be checked *again*. So my comment above makes no sense, since a polygon that is broken will not even make it this far; this extra check is only about polygons that are valid in OSM in 4326 but break when projecting to whatever the user of osm2pgsql has asked for. Which means that using some code to try and repair a polygon would not hurt here. Sorry for the confusion.


Do not ask if no changes in file.


Benefit of all those package-split changes:
```
root@quadbox /usr/lib/python2.7 # find . -name *.py
root@quadbox /usr/lib/python2.7 #
```

No .py files in /usr/lib/python2.7 anymore, slightly reducing image size and reducing package debris when uninstalling packages.


Дублирование проверки. Гораздо лучше использовать вариант с if/elsif/else


Good


Зачем вычислять квадратный корень дважды? Помести значение в переменную и используй ее


(really, the whole setup of the given function is suspect; the abstraction is wrong)


This wiped out other peoples names.


Commit Referente a seção-15 de tratamento de erros


1. переменные в руби принято называть с мальенькой буквы, с большой - классы и модули. Это важно.
2. Если дискрминант будет меньше нуля, то здесь будет исключение (нельзя вычислять кв. корень из отрицательного числа) и программа аварийно завершится, а если он будет нулевой, то нет смысла вычилсять кв. корень. Его нужно вычислять только при положительном дискриминанте.


okay


LOLOL


No description provided.


Checkmarx scan results 03 Oct 2017 15:40 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

bdf184ffe971fbb5d64d442e95ecadefc82d81b3	@web-flow


硬编码现象较严重


The premis:size element isn't under premis:fixity  It's one level up under premis:objectCharacteristics.   I changed the code to this and it worked:
```
objchar_elem = root.find('.//premis:objectCharacteristics', namespaces=utils.NSMAP)
size = objchar_elem.findtext(
       'premis:size', namespaces=utils.NSMAP)
```


Is this constructor required?


please use an indentation larger than 2 spaces (4 for example)
old people like me need that to see clearly ;-)


And I am a pilgrim on that road.

On Tue, Oct 3, 2017 at 8:26 AM, Tom Elliott <notifications@github.com>
wrote:

> There is no shame. Only progress.
>
> --
> Tom Elliott, Ph.D.
> Associate Director for Digital Programs and Senior Research Scholar
> Institute for the Study of the Ancient World (NYU)
> http://isaw.nyu.edu/people/staff/tom-elliott
>
> Humanities Commons: @paregorios <https://hcommons.org/members/paregorios/>
> OrcID: 0000-0002-4114-6677 <http://orcid.org/0000-0002-4114-6677>
>
> On Mon, Oct 2, 2017 at 5:47 PM, David M. Ratzan <notifications@github.com>
> wrote:
>
> > Thanks. I am ashamed how long it took me to figure out how to do it
> "right"
> >
> > D.
> >
> > On Mon, Oct 2, 2017 at 6:39 PM, Patrick J. Burns <
> notifications@github.com
> > >
> > wrote:
> >
> > > Good catch (and a successful PR)!
> > >
> > > —
> > > You are receiving this because you are subscribed to this thread.
> > > Reply to this email directly, view it on GitHub
> > > <https://github.com/isaw-ga-3024/isaw-dh-syllabus/commit/
> > 0f2bf53d27497faae98ed1841f6f8dcb1971c433#commitcomment-24714005>,
> > > or mute the thread
> > > <https://github.com/notifications/unsubscribe-
> auth/APDstYw3BI-5FeaxFij-
> > XwcCFvizaL3jks5soWY1gaJpZM4PrWZ8>
> > > .
> > >
> >
> >
> >
> > --
> > Dr. David M. Ratzan
> > Head Librarian
> > Institute for the Study of the Ancient World <
> http://isaw.nyu.edu/library>
> > New York University
> > 15 East 84th St
> <https://maps.google.com/?q=15+East+84th+St&entry=gmail&source=g>.
> > <https://maps.google.com/?q=15+East+84th+St.+%0D+New+York,
> +NY+10028&entry=gmail&source=g>
> > New York, NY 10028
> > 212-992-7832 <(212)%20992-7832> <(212)%20992-7832>
> > @ISAWlib <http://twitter.com/ISAWLib> and @papyrologus
> > <http://twitter.com/papyrologus>
> > ISAW Library Blog <http://isaw.nyu.edu/library/blog> and the ISAW
> Library
> > Facebook page <http://www.facebook.com/pages/ISAW-Library/
> 170583562953314>
> >
> > —
> > You are receiving this because you are subscribed to this thread.
> > Reply to this email directly, view it on GitHub
> > <https://github.com/isaw-ga-3024/isaw-dh-syllabus/commit/
> 0f2bf53d27497faae98ed1841f6f8dcb1971c433#commitcomment-24714233>,
> > or mute the thread
> > <https://github.com/notifications/unsubscribe-auth/
> AAQEdSOg79bqXPdZzu3Rf8FZT4uvpcW4ks5soWgDgaJpZM4PrWZ8>
> > .
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/isaw-ga-3024/isaw-dh-syllabus/commit/0f2bf53d27497faae98ed1841f6f8dcb1971c433#commitcomment-24727313>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/APDstcAVQB2nTkzBFJ1zqiZZfyleO-DDks5soifcgaJpZM4PrWZ8>
> .
>

--
Dr. David M. Ratzan
Head Librarian
Institute for the Study of the Ancient World <http://isaw.nyu.edu/library>
New York University
15 East 84th St.
New York, NY  10028
212-992-7832
@ISAWlib <http://twitter.com/ISAWLib> and @papyrologus
<http://twitter.com/papyrologus>
ISAW Library Blog <http://isaw.nyu.edu/library/blog> and the ISAW Library
Facebook page <http://www.facebook.com/pages/ISAW-Library/170583562953314>


add empty lines before every, not first #region and after every, not last #endregion


Checkmarx scan results 03 Oct 2017 15:42 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

d275628f4d323f303b99d5613e63849dbb65d785	@web-flow


too many returns in method


**[unitTests_js_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_js_branches/44923/testReport/) for this commit**


extra:
think about how you could optimise this?
do we really have to check all values?
perhaps half would be enough?
and perhaps we could stop looking as soon as we found the first divisor that makes it not a prime?


[inst/examples/Wolf-Sheep-Predation/Wolf-Sheep-Predation.R:249:8:](https://github.com/PredictiveEcology/NetLogoR/blob/624bd2ccaf9f0760224683929b0729f7f4791693/inst/examples/Wolf-Sheep-Predation/Wolf-Sheep-Predation.R#L249) *style:* **Place a space before left parenthesis, except in a function call.**
```r
while ((NLany(sheep) | NLany(wolves)) & time < maxTime) {
       ^
```
[inst/examples/Wolf-Sheep-Predation/WolfSheepPredation/WolfSheepPredation.R:64:1:](https://github.com/PredictiveEcology/NetLogoR/blob/624bd2ccaf9f0760224683929b0729f7f4791693/inst/examples/Wolf-Sheep-Predation/WolfSheepPredation/WolfSheepPredation.R#L64) *style:* **Variable or function name should be lowerCamelCase.**
```r
doEvent.WolfSheepPredation <- function(sim, eventTime, eventType, debug = FALSE) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/Classes.R:94:12:](https://github.com/PredictiveEcology/NetLogoR/blob/624bd2ccaf9f0760224683929b0729f7f4791693/R/Classes.R#L94) *style:* **Variable or function name should be lowerCamelCase.**
```r
  function(.Object="agentMatrix", coords, ..., levelsAM) {
           ^~~~~~~
```
[R/Classes.R:178:11:](https://github.com/PredictiveEcology/NetLogoR/blob/624bd2ccaf9f0760224683929b0729f7f4791693/R/Classes.R#L178) *style:* **Place a space before left parenthesis, except in a function call.**
```r
      if ((is.matrix(dotCols[[1]]) & is.numeric(dotCols[[1]])) | is(dotCols[[1]], "agentMatrix"))
          ^
```
[R/Classes.R:699:1:](https://github.com/PredictiveEcology/NetLogoR/blob/624bd2ccaf9f0760224683929b0729f7f4791693/R/Classes.R#L699) *style:* **Variable or function name should be lowerCamelCase.**
```r
head.agentMatrix <- function(x, n = 6L, ...) {
^~~~~~~~~~~~~~~~
```
[R/Classes.R:708:1:](https://github.com/PredictiveEcology/NetLogoR/blob/624bd2ccaf9f0760224683929b0729f7f4791693/R/Classes.R#L708) *style:* **Variable or function name should be lowerCamelCase.**
```r
tail.agentMatrix <- function(x, n = 6L, ...) {
^~~~~~~~~~~~~~~~
```
[R/Classes.R:730:36:](https://github.com/PredictiveEcology/NetLogoR/blob/624bd2ccaf9f0760224683929b0729f7f4791693/R/Classes.R#L730) *style:* **Variable or function name should be lowerCamelCase.**
```r
cbind.agentMatrix <- function(..., deparse.level) {
                                   ^~~~~~~~~~~~~
```
[R/Classes.R:755:36:](https://github.com/PredictiveEcology/NetLogoR/blob/624bd2ccaf9f0760224683929b0729f7f4791693/R/Classes.R#L755) *style:* **Variable or function name should be lowerCamelCase.**
```r
rbind.agentMatrix <- function(..., deparse.level = 1) {
                                   ^~~~~~~~~~~~~
```
[R/NetLogoR-classes.R:503:11:](https://github.com/PredictiveEcology/NetLogoR/blob/624bd2ccaf9f0760224683929b0729f7f4791693/R/NetLogoR-classes.R#L503) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    floor((cellNum - 1) / b[2]) + seq.int(from = 1, to = prod(b),
          ^
```
[R/turtle-functions.R:93:32:](https://github.com/PredictiveEcology/NetLogoR/blob/624bd2ccaf9f0760224683929b0729f7f4791693/R/turtle-functions.R#L93) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    coords <- cbind(xcor = rep(((maxPxcor(world) - minPxcor(world)) / 2) + minPxcor(world), n),
                               ^
```
[R/turtle-functions.R:93:33:](https://github.com/PredictiveEcology/NetLogoR/blob/624bd2ccaf9f0760224683929b0729f7f4791693/R/turtle-functions.R#L93) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    coords <- cbind(xcor = rep(((maxPxcor(world) - minPxcor(world)) / 2) + minPxcor(world), n),
                                ^
```
[R/turtle-functions.R:94:32:](https://github.com/PredictiveEcology/NetLogoR/blob/624bd2ccaf9f0760224683929b0729f7f4791693/R/turtle-functions.R#L94) *style:* **Place a space before left parenthesis, except in a function call.**
```r
                    ycor = rep(((maxPycor(world) - minPycor(world)) / 2) + minPycor(world), n))
                               ^
```
[R/turtle-functions.R:94:33:](https://github.com/PredictiveEcology/NetLogoR/blob/624bd2ccaf9f0760224683929b0729f7f4791693/R/turtle-functions.R#L94) *style:* **Place a space before left parenthesis, except in a function call.**
```r
                    ycor = rep(((maxPycor(world) - minPycor(world)) / 2) + minPycor(world), n))
                                ^
```
[R/turtle-functions.R:454:35:](https://github.com/PredictiveEcology/NetLogoR/blob/624bd2ccaf9f0760224683929b0729f7f4791693/R/turtle-functions.R#L454) *style:* **Place a space before left parenthesis, except in a function call.**
```r
                          xcor = ((world@extent@xmax - world@extent@xmin) / 2) +
                                  ^
```
[R/turtle-functions.R:456:35:](https://github.com/PredictiveEcology/NetLogoR/blob/624bd2ccaf9f0760224683929b0729f7f4791693/R/turtle-functions.R#L456) *style:* **Place a space before left parenthesis, except in a function call.**
```r
                          ycor = ((world@extent@ymax - world@extent@ymin) / 2) +
                                  ^
```
[tests/testthat/test-agentMatrix.R:164:15:](https://github.com/PredictiveEcology/NetLogoR/blob/624bd2ccaf9f0760224683929b0729f7f4791693/tests/testthat/test-agentMatrix.R#L164) *style:* **Use <-, not =, for assignment.**
```r
           a1 = st_point(cbind(1, 3))
              ^
```
[tests/testthat/test-agentMatrix.R:165:15:](https://github.com/PredictiveEcology/NetLogoR/blob/624bd2ccaf9f0760224683929b0729f7f4791693/tests/testthat/test-agentMatrix.R#L165) *style:* **Use <-, not =, for assignment.**
```r
           a2 = st_point(cbind(2, 4))
              ^
```
[tests/testthat/test-agentMatrix.R:166:15:](https://github.com/PredictiveEcology/NetLogoR/blob/624bd2ccaf9f0760224683929b0729f7f4791693/tests/testthat/test-agentMatrix.R#L166) *style:* **Use <-, not =, for assignment.**
```r
           a3 = st_point(cbind(5, 6))
              ^
```
[tests/testthat/test-agentMatrix.R:167:14:](https://github.com/PredictiveEcology/NetLogoR/blob/624bd2ccaf9f0760224683929b0729f7f4791693/tests/testthat/test-agentMatrix.R#L167) *style:* **Use <-, not =, for assignment.**
```r
           d =  data = data.frame(
             ^
```
[tests/testthat/test-agentMatrix.R:167:22:](https://github.com/PredictiveEcology/NetLogoR/blob/624bd2ccaf9f0760224683929b0729f7f4791693/tests/testthat/test-agentMatrix.R#L167) *style:* **Use <-, not =, for assignment.**
```r
           d =  data = data.frame(
                     ^
```
[tests/testthat/test-agentMatrix.R:170:19:](https://github.com/PredictiveEcology/NetLogoR/blob/624bd2ccaf9f0760224683929b0729f7f4791693/tests/testthat/test-agentMatrix.R#L170) *style:* **Use <-, not =, for assignment.**
```r
           d$geom = st_sfc(a1, a2, a3)
                  ^
```
[tests/testthat/test-agentMatrix.R:171:15:](https://github.com/PredictiveEcology/NetLogoR/blob/624bd2ccaf9f0760224683929b0729f7f4791693/tests/testthat/test-agentMatrix.R#L171) *style:* **Use <-, not =, for assignment.**
```r
           df = st_as_sf(d)
              ^
```


always add brackets


Checkmarx scan results 03 Oct 2017 15:44 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

7ec282eabc0c9a5b89da5568264b140cb1ef9819	@web-flow


too many returns


@fantix could you please release 0.5.4 with this fix?


@thet Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.z3cform/57/violations
```
plone/app/z3cform/inline_validation.py:15:5: C901 'InlineValidationView.__call__' is too complex (15)
plone/app/z3cform/widget.py:111:25: C812 missing trailing comma
plone/app/z3cform/widget.py:117:49: C812 missing trailing comma
plone/app/z3cform/widget.py:179:20: C812 missing trailing comma
plone/app/z3cform/widget.py:394:26: C812 missing trailing comma
plone/app/z3cform/widget.py:502:36: C812 missing trailing comma
plone/app/z3cform/widget.py:517:26: C812 missing trailing comma
plone/app/z3cform/widget.py:616:29: C812 missing trailing comma
plone/app/z3cform/widget.py:618:36: C812 missing trailing comma
plone/app/z3cform/widget.py:649:47: C812 missing trailing comma
plone/app/z3cform/widget.py:653:19: T000 Todo note found.
plone/app/z3cform/widget.py:667:47: T000 Todo note found.
plone/app/z3cform/widget.py:671:66: C812 missing trailing comma
plone/app/z3cform/widget.py:672:30: C812 missing trailing comma
plone/app/z3cform/widget.py:673:26: C812 missing trailing comma
plone/app/z3cform/widget.py:674:22: C812 missing trailing comma
plone/app/z3cform/widget.py:689:46: C812 missing trailing comma
plone/app/z3cform/widget.py:714:42: C812 missing trailing comma
plone/app/z3cform/widget.py:716:38: C812 missing trailing comma
plone/app/z3cform/widget.py:736:36: C812 missing trailing comma
plone/app/z3cform/widget.py:835:29: C812 missing trailing comma
plone/app/z3cform/widget.py:836:48: C812 missing trailing comma
plone/app/z3cform/widget.py:846:68: C812 missing trailing comma
plone/app/z3cform/widget.py:848:18: C812 missing trailing comma
plone/app/z3cform/templates.py:19:17: C812 missing trailing comma
plone/app/z3cform/utils.py:99:43: C812 missing trailing comma
plone/app/z3cform/utils.py:106:34: C812 missing trailing comma
plone/app/z3cform/converters.py:105:11: T000 Todo note found.
plone/app/z3cform/converters.py:323:33: C812 missing trailing comma
plone/app/z3cform/wysiwyg/widget.py:49:27: C812 missing trailing comma
plone/app/z3cform/tests/tests.py:47:10: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:84:38: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:135:14: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:185:56: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:190:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:259:37: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:288:56: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:293:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:297:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:445:43: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:459:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:460:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:477:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:478:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:495:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:496:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:515:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:516:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:534:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:535:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:547:62: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:561:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:562:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:573:62: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:587:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:588:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:600:62: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:614:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:615:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:625:43: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:668:52: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:673:36: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:746:32: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:758:37: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:760:14: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:773:37: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:775:14: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:872:75: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1006:41: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1010:41: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1014:41: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1033:32: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1070:50: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1074:49: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1078:50: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1082:55: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1104:50: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1108:49: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1112:50: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1116:55: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1153:51: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1181:30: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1206:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1224:68: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1244:36: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1310:25: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1333:21: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1343:25: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1353:25: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1363:21: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1480:44: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1493:33: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1506:36: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1519:36: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1543:33: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1549:20: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1555:20: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1561:45: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1567:36: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1573:36: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1579:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1585:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1589:19: C812 missing trailing comma
plone/app/z3cform/tests/test_utils.py:14:33: C812 missing trailing comma
plone/app/z3cform/tests/test_utils.py:25:33: C812 missing trailing comma
plone/app/z3cform/tests/test_utils.py:36:33: C812 missing trailing comma
plone/app/z3cform/tests/test_utils.py:47:33: C812 missing trailing comma
plone/app/z3cform/tests/test_utils.py:66:18: C812 missing trailing comma
plone/app/z3cform/tests/test_utils.py:67:14: C812 missing trailing comma
plone/app/z3cform/tests/test_utils.py:82:18: C812 missing trailing comma
plone/app/z3cform/tests/test_utils.py:83:14: C812 missing trailing comma
plone/app/z3cform/tests/test_utils.py:88:33: C812 missing trailing comma
plone/app/z3cform/tests/test_utils.py:111:42: C812 missing trailing comma
plone/app/z3cform/tests/test_utils.py:117:40: C812 missing trailing comma
plone/app/z3cform/tests/test_utils.py:123:31: C812 missing trailing comma
plone/app/z3cform/tests/layer.py:34:41: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Checkmarx scan results 03 Oct 2017 15:46 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

89715b65534b8b36cf855fe102a465d56d13fa3f	@web-flow


You seem to have committed my solutions zipfile to your respository
I comment here, cause I can't comment on a binary file in this commit

Please never check in binary files into repositories
[https://development.robinwinslow.uk/2013/06/11/dont-ever-commit-binary-files-to-git/]

and definitely not my sources!
please remove that file asap!!!


I have added issue https://github.com/pyldap/pyldap/issues/124.


should rather be written if (GDAL_VERSION_MAJOR >2 || (GDAL_VERSION_MAJOR >= 2 && GDAL_VERSION_MINOR >= 2)) in case there's a GDAL 3 someday


Late comment, I know. But what `.sln/.vcxproj` create a DLL-file named like that? AFAICS, it should be `libmicrohttpd-dll.dll`.

And why 2 `.rc.in` files? Would be simpler with only 1 for *all* Windows targets.


Checkmarx scan results 03 Oct 2017 15:48 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

221246c22af05d584115c1116fe0dda370a17005	@web-flow


Add dot at the end of every sentence in summary descriptions, in all files.


return Check(certificate, untrustedCertificates) != null;


`return Check(certificate, untrustedCertificates) != null;`


nice and clean makefile!

but I spotted another binary file: echoage (just below in this commit)
please don't commit binary files


description missing


could be removed


Is the graph api version change is essentially needed ?   I have a problem with  access token authentication  when i have created a new facebook app with version 2.10, and got the access token and that access token is not authenticated... how to make this compatible for latest version of Facebook apps


Oh, it was. I just dropped it to 5 percent earlier last evening.

~
This message was made with 100% thumbs.

On Oct 3, 2017 08:17, "Devin Weaver" <notifications@github.com> wrote:

> Fascinating. I always thought this was 100%.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/newhavenio/hubot/commit/01091b897ac9320535b679208e3a45330e9d4224#commitcomment-24727137>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAAzFexeFqdez8eFQfaKLunfnP_s4rB9ks5soiXQgaJpZM4PsBLX>
> .
>


Can do. Is there by any change a GDAL_VERSION I can just do numerical comparisons on? (100*GDAL_VERSION_MAJOR + GDAL_VERSION_MINOR) ? Or is that left as an exercise for the reader?


Here I changed ```link=static``` to ```link=shared,static```


please indent constructor member initialiser lists too


consider starting class names with capital letters


using Xamarin.Forms.Platform.Tizen


it should call Remove(alias)
then You can remove try/catch here


no need to be verbose here
```
return real == c.real && imaginary == c.imaginary;
```
does the same thing, and is easier to read


Here I changed ```./bootstrap.sh --with-libraries=$BOOST_LIBS_COMMA```
to ```./bootstrap.sh --without-libraries=python```


#regions missing


too many returns


У меня строковый класс сообщений уже в каком-то смысле имеет буффер(  согласна это надо доработать)
форматтер я перенесла в класс сообщений, а сэйвер остался в контроллере, потому что пока было такое задание.
 А так да, удобно и логично перенести его в Мессаджи.
А вот числовые сообщения не должны храниться в буффере, должна храниться только конечная сумма, так лучше, как сказал Евгений.


Hey @SunburnedGoose, why did you reverted this? The replace wasn't working?


Good Job Alyssa!
I was able to determine your logic flow and coding style through this code. Just make sure that the syntax and the names are neat and clean!


You need to use the global environment variables (E.g: $mongo_host, $mongo_port, $mongo_db_name, etc).


memset(dp, -1, sizeof(dp));


Почитал, понял, поправлю в след. коммите.


Yea which is why I left it commented out. :)


Tests are rarely written in a header, and definitely not in the header of the unit under test

Your test code base should be separate from your business code base


You need to remove this example or put it like a comment example.


each class should be located in separate file


If you don't need to support GDAL < 1.10, then you can rewrite that as

#if GDAL_VERSION_NUM >= GDAL_COMPUTE_VERSION(2, 2, 0)

or if you need to support ancient GDAL

#if GDAL_VERSION_NUM >= 2020000


PFA !! Sorry for the delay.. I have made some updates to the project but
haven't pushed the changes yet to the repository. Make sure to check it by
the end of the week  for the updated version.. The database is for the
updated version, but will still work.

On Tue, Oct 3, 2017 at 4:33 AM, Bryan Mancía <notifications@github.com>
wrote:

> Database file please:)
> ~Amazing Job.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/aliasgar12/BlogPlus/commit/42b90a20f2f9d5e8a07b0043f7fd569f80d1b659#commitcomment-24723241>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AVup_hfTq6sNdtSUPzsyqpiZFHuE51MPks5sofFSgaJpZM4MxNWS>
> .
>


Checkmarx scan results 03 Oct 2017 15:57 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

52ef6bc26519bdef26c3824e6c9cf9fcb1fde1ed	@web-flow


**[unitTests_js_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_js_branches/44924/testReport/) for this commit**


Checkmarx scan results 03 Oct 2017 15:57 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

d7be925185bfdf5cc5e6d09b0d7753642a4c9dc7	@web-flow

52ef6bc26519bdef26c3824e6c9cf9fcb1fde1ed	@web-flow

221246c22af05d584115c1116fe0dda370a17005	@web-flow


**[unitTests_js_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_js_branches/44925/testReport/) for this commit**


It doesn't matter where it will be stored.
Description should say what is it for.
Missing <summary> descriptions and /#regions in this file


add empty line


Commit #1000!


zabx uah duaig widga bsd awhgdbiha diasd hsdouah doasdjnaosdh aosubxnd


I wonder if having a variable equal to `msg.value / 2` will save you gas.


brackets


das ist die erste rote Zeile....


Why not use the same `balances[`?


Речь о пробеле после фигурной скобке?


cadfafadbjb  ia dgiuab diagd agsbi


let's see mmmh und was nun. das ist nur ein Kommentar...


You already have `balances(addr)` because the mapping is public.


aha das ist ein Realy


Requires DB update: https://github.com/cmangos/classic-db/commit/1a55599f333d13aff477212960bdfb535ce55e62


it shouldn't be here.
define it in dedicated file, config or somewhat


Why did you not prefer `throw` or `revert()`?


move this string to dedicated file


**[unitTests_js_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_js_branches/44926/testReport/) for this commit**


empty line


see earlier remark about not putting test code in the header of the unit under test


Can you update the`\since` to 3.0 and maybe add a `previously buffer() since QGIS 2.1.`.


Wouldn't you want to have this interaction visible in the report?

If so, I'd give it a description:

```typescript
const AcceptAlert = () => Interaction.where(`#actor accepts the alert popup`,
    actor => BrowseTheWeb.as(actor).acceptAlert()
);
```


Maybe `DismissAlert` would be more consistent with `AcceptAlert`?


conversion functions, like this one, should return new values


you didn't use use these local variables


How about the address of the exchanger is part of `secretsHash`, so you transmit only 1 piece of info. Plus you save gas on storage.


`console.warn` is probably not needed here?


brackets


describe the logic. there are lot of conditional statements and just this description.


empty line, brackets


I'm doing some C today, I'll try to do it tomorrow.
Also, here is where I had the question about the tuples. Isn't anything inside a tuple also a tuple since it can not be changed by default?


@nyxgear your signature typo? :P


too many returns


you seem to have committed my solutions
please remove them asap!


This looks like a change caused by auto-formatting?


Hi!

Would you want to propose a PR I can merge back for that improvement ?


Checkmarx scan results 03 Oct 2017 16:03 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

3ad45f17049d669e4eb1a2792ac6997aae395201	@


What is the simplification here? Using `ExecStart` instead of `script` seems more verbose...


Also, once an exchanger has collected, the hash of this exchanger is known, so this is no longer a secret.


It could be cheaper with `bytes32` here too.


`embed_type` usually returns sth like `:youtube_video`...


typo


As determined in https://github.com/busches/refined-github/commit/1a99b20d7a19ae9994314b386fef030d25423fef#comments


As part of `sendRemittance` you should check that `exchangerAddressHash` was not 0, otherwise you are stuck here.


Otherwise,
The kernel Won't boot??


not really sure about the difference between `embed_node` and `embedded_node`. maybe something like `type_specific_node` would be better...


接收端改成了逐行读取


Might not be a problem for the teaser implementation, but `dispose` is also executed on cut and when dragged, which means if you cut or drag the teaser all the teaser will disappear.

But, as said, the teaser is not allowed to be moved or cut so might not be a problem?


That's cool :-) I'm not sure if you wanted to submit this script as part of this PR?


exists


maybe the defaults for height and width should go into a method as well?


add empty line before next descipion


Awesome, thanks for the PR, @nbarrett! I've allowed myself to add some comments :-)


consider using a list/generator comprehension instead of filter


@vgrange  Sera-t-il possible d'avoir un retour sur ce morceaux de code ? Je me dis qu'il est possible de faire plus pyt


居然有这样的坑 :joy:


missing spaces before Certificate and Data


consider using string.format
```
print "{},{}".format(dx, dy)
```


no deploy for any fork


This should resolve #1386.


missing regions


Shrinking apk size....


GroupDisplayBinding, move to new line


GroupShortNameBinding move to new line


ItemSelected move to new line


We implement one protocol per protocol class.
Never should a class have more than one responsibility!


Grid.Row="1" move to new line


Upgrade to django 1.11


brackets


TeamCity Glyssen :: Glyssen pull requests [Build *.*.651.18aecc738c5d9e643261db7744f7071893e5c125](http://build.palaso.org/viewLog.html?buildId=98887&buildTypeId=Glyssen_GlyssenPullRequests) outcome was **SUCCESS**
Summary: Tests passed: 1777, ignored: 18 Build time: 00:09:59


bad design, never should a class have more than one responsibility


This is a test comment. I love commits.


Got it


Outlet should the the abstraction of a single outlet.
Containing only functions to set the power on/off for a single outlet


I just realised that if the bishop is already in the center, my version is not giving a bonus. :(


> Does the new GISTIC work with just SEG files? Is there any benefit to generating a "markers" file now?

Looks like it does work without them. Probably better to ignore "markers" (although yes, I already tested with segments start/endpoints as markers and worked, too).


move comment before block which it describes


why keep track of this?


consider using Capitals for class names


Why do you use these strange URLs in your extension? They have weird domain names which appear untrustworthy.


remove empty line


indendation ..


I'm ready for the new storport driver!


Высота и сторона могут быть не целыми


sweet hairstyle


Зачем делить, когда можно на 0.5 умножить - одной операцией меньше


Значения могут быть не целыми


just so you know: variable lengths aren't supported by all versions of the C language


При нулевом дискриминанте не имеет смысла считать кв. корень и второй корень уравнения - ты делаешь лишнюю работу.


Стороны могут быть не целыми


this might be overkill ;)


R Studio Version 1.0.153
Author: Yousri Hajri

The aim of this programming assignment (of week4 of the module "Getting and cleaning data" of the "Data Science Specialization" of Coursera) is to merge and combine the following datasets:

- X_test : 2947 obs. of 561 variables
- X_train: 7352 obs. of 561 variables
- y_test: 2947 obs. of 1 variable
- y_train: 7352 obs. of 1 variable
- subject_test: 2947 obs. of 1 variable
- subject_train: 2947 obs. of 1 variable
- activity_labels: 6 obs. of 2 variables
- features: 561 obs. of 2 variables


why this is error?


brackets


there is "DataManager.Save". So it saves, no "adds"


See #2857


remove comment


You hardcoded 10 here


not sure this testcase is needed, as the functionality is tested later again.


@AlexandreCantin, avec une "list comprehension" (http://www.secnetix.de/olli/Python/list_comprehensions.hawk):

rome_codes = [romes for romes in romes_to_boost if romes not in romes_code]


add empty line


i assume that state==state2 and an assert would be useful here to check that.


empty line


After creating a full dataframe, the job is to choose some variables then aggregate means on unique (subject-activity label) combination.


add empty line before loop block


not sure this testcase is very useful, later testcases do test this functionality better.


cool!


add empty line after loop block


add empty line before #endregion


The final result is a dataframe "meandata" of 180 obs. of 81 variables.


Thanks!


great testcase, maybe also try it out with corrupted cyphertext and corrupted ad, and make sure both raise valueerrors.


updated shiny app 20171003


Decrypted data or null if any error occurs.


very nice test, check for corrupted cyphertexts and ads raising also valuerrors


empty line before if


That assumes a flawless summary by a human ;). But since the releases will now be much more frequently, I can of course just inspect the full diff manually through https://github.com/google/guava/compare/v23.0...v23.1. Maybe.


empty line after variable declaration


updating master and printshop to be of same commit


i love the elaborate testcases at the end <3


[R/GetAvailablePoints.R:15:3:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/GetAvailablePoints.R#L15) *warning:* **local variable ‘original_path’ assigned but may not be used**
```r
  original_path <- getwd()
  ^~~~~~~~~~~~~
```
[R/ResultsCreator.R:8:15:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/ResultsCreator.R#L8) *warning:* **no visible global function definition for ‘.get_status_for_test’**
```r
    status <- .get_status_for_test(test)
              ^~~~~~~~~~~~~~~~~~~~
```
[R/ResultsCreator.R:9:16:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/ResultsCreator.R#L9) *warning:* **no visible global function definition for ‘.create_message_for_test’**
```r
    message <- .create_message_for_test(test)
               ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ResultsJsonParser.R:2:51:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/ResultsJsonParser.R#L2) *style:* **Variable or function name should be snake_case.**
```r
.create_available_points_json_results <- function(testthatOutput) {
                                                  ^~~~~~~~~~~~~~
```
[R/ResultsJsonParser.R:3:11:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/ResultsJsonParser.R#L3) *style:* **Use <-, not =, for assignment.**
```r
  results = list()
          ^
```
[R/ResultsJsonParser.R:9:31:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/ResultsJsonParser.R#L9) *style:* **Put spaces around all infix operators.**
```r
      results[[length(results)+1]] <- list(name=unbox(name), points=points)
                             ~^~
```
[R/ResultsJsonParser.R:9:48:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/ResultsJsonParser.R#L9) *style:* **Put spaces around all infix operators.**
```r
      results[[length(results)+1]] <- list(name=unbox(name), points=points)
                                              ~^~
```
[R/ResultsJsonParser.R:9:49:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/ResultsJsonParser.R#L9) *warning:* **no visible global function definition for ‘unbox’, Did you mean 'box'?**
```r
      results[[length(results)+1]] <- list(name=unbox(name), points=points)
                                                ^~~~~
```
[R/ResultsJsonParser.R:9:68:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/ResultsJsonParser.R#L9) *style:* **Put spaces around all infix operators.**
```r
      results[[length(results)+1]] <- list(name=unbox(name), points=points)
                                                                  ~^~
```
[R/ResultsJsonParser.R:13:7:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/ResultsJsonParser.R#L13) *style:* **Commented code should be removed.**
```r
  #   print(test_result)
      ^~~~~~~~~~~~~~~~~~
```
[R/ResultsJsonParser.R:14:7:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/ResultsJsonParser.R#L14) *style:* **Commented code should be removed.**
```r
    # testName <- test_result$test
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ResultsJsonParser.R:15:7:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/ResultsJsonParser.R#L15) *style:* **Commented code should be removed.**
```r
    # testPoints <- test_result$points
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ResultsJsonParser.R:17:7:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/ResultsJsonParser.R#L17) *style:* **Commented code should be removed.**
```r
    # results[[length(results)+1]] <- list(name=unbox(testName), points=unbox(testPoints))
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ResultsJsonParser.R:19:10:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/ResultsJsonParser.R#L19) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  return (results)
         ^
```
[R/ResultsJsonParser.R:26:25:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/ResultsJsonParser.R#L26) *warning:* **no visible global function definition for ‘.create_json_test_result’**
```r
    test_json_result <- .create_json_test_result(test_result)
                        ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ResultsJsonParser.R:45:20:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/ResultsJsonParser.R#L45) *warning:* **no visible global function definition for ‘toJSON’**
```r
  json <- enc2utf8(toJSON(results, pretty = FALSE))
                   ^~~~~~
```
[R/ResultsJsonParser.R:46:11:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/ResultsJsonParser.R#L46) *warning:* **no visible global function definition for ‘prettify’, Did you mean 'pretty'?**
```r
  json <- prettify(json)
          ^~~~~~~~
```
[R/RunTests.R:6:23:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/RunTests.R#L6) *warning:* **no visible global function definition for ‘.get_available_points’**
```r
  available_points <- .get_available_points(project_path)
                      ^~~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:8:19:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/RunTests.R#L8) *warning:* **no visible global function definition for ‘.create_available_points_json_results’**
```r
  json_results <- .create_available_points_json_results(available_points)
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:9:3:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/RunTests.R#L9) *warning:* **no visible global function definition for ‘.write_json’**
```r
  .write_json(json_results, ".available_points.json")
  ^~~~~~~~~~~
```
[R/RunTests.R:26:19:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/RunTests.R#L26) *warning:* **no visible global function definition for ‘.run_tests_project’**
```r
  test_results <- .run_tests_project(project_path)
                  ^~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:28:19:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/RunTests.R#L28) *warning:* **no visible global function definition for ‘.create_json_results’**
```r
  json_results <- .create_json_results(test_results)
                  ^~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:29:3:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/RunTests.R#L29) *warning:* **no visible global function definition for ‘.write_json’**
```r
  .write_json(json_results, ".results.json")
  ^~~~~~~~~~~
```
[R/RunTests.R:32:5:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/RunTests.R#L32) *warning:* **no visible global function definition for ‘.print_results_from_json’**
```r
    .print_results_from_json(json_results)
    ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:47:21:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/RunTests.R#L47) *warning:* **no visible global function definition for ‘.run_tests_file’**
```r
    file_results <- .run_tests_file(test_file)
                    ^~~~~~~~~~~~~~~
```
[R/RunTests.R:57:3:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/RunTests.R#L57) *warning:* **no visible global function definition for ‘test_file’**
```r
  test_file_output <- test_file(file_path, reporter = "silent")
  ^~~~~~~~~
```
[R/RunTests.R:59:24:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/RunTests.R#L59) *warning:* **no visible global function definition for ‘.create_file_results’**
```r
  test_file_results <- .create_file_results(test_file_output, points, .GlobalEnv$points_for_all_tests)
                       ^~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:65:3:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/R/RunTests.R#L65) *warning:* **no visible global function definition for ‘run_tests’**
```r
  run_tests(getwd(), bol)
  ^~~~~~~~~
```
[tests/testthat/resources/simple_all_tests_fail/tests/testthat/helperTMC.R:12:3:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/tests/testthat/resources/simple_all_tests_fail/tests/testthat/helperTMC.R#L12) *warning:* **no visible global function definition for ‘test_that’**
```r
  test_that(desc, code)
  ^~~~~~~~~
```
[tests/testthat/resources/simple_all_tests_pass/tests/testthat/helperTMC.R:12:3:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/tests/testthat/resources/simple_all_tests_pass/tests/testthat/helperTMC.R#L12) *warning:* **no visible global function definition for ‘test_that’**
```r
  test_that(desc, code)
  ^~~~~~~~~
```
[tests/testthat/resources/simple_some_tests_fail/tests/testthat/helperTMC.R:12:3:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/tests/testthat/resources/simple_some_tests_fail/tests/testthat/helperTMC.R#L12) *warning:* **no visible global function definition for ‘test_that’**
```r
  test_that(desc, code)
  ^~~~~~~~~
```
[tests/testthat/testLintr.R:2:5:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/tests/testthat/testLintr.R#L2) *style:* **Commented code should be removed.**
```r
#   context("lints")
    ^~~~~~~~~~~~~~~~
```
[tests/testthat/testLintr.R:4:7:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/tests/testthat/testLintr.R#L4) *style:* **Commented code should be removed.**
```r
#     lintr::expect_lint_free()
      ^~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/testRunTests.R:71:1:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/tests/testthat/testRunTests.R#L71) *style:* **Lines should not be more than 120 characters.**
```r
  expected_json_result[[1]] <- list(status = "pass", name = "ret_true works.", message = "", backtrace = list(), points = list("r1", "r1.1"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/testRunTests.R:72:1:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/tests/testthat/testRunTests.R#L72) *style:* **Lines should not be more than 120 characters.**
```r
  expected_json_result[[2]] <- list(status = "pass", name = "ret_one works.", message = "", backtrace = list(), points = list("r1", "r1.2"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/testRunTests.R:73:1:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/tests/testthat/testRunTests.R#L73) *style:* **Lines should not be more than 120 characters.**
```r
  expected_json_result[[3]] <- list(status = "pass", name = "add works.", message = "", backtrace = list(), points = list("r1", "r1.3", "r1.4"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/testRunTests.R:74:1:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/tests/testthat/testRunTests.R#L74) *style:* **Lines should not be more than 120 characters.**
```r
  expected_json_result[[4]] <- list(status = "fail", name = "ret_false returns true", message = "Failed with call: expect_true, ret_false()\nret_false() isn't true.\n", backtrace = list(), points = list("r1", "r1.5"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/testRunTests.R:75:1:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/tests/testthat/testRunTests.R#L75) *style:* **Lines should not be more than 120 characters.**
```r
  expected_json_result[[5]] <- list(status = "pass", name = "ret_true works but there are no points.", message = "", backtrace = list(), points = list("r1"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/testRunTests.R:82:1:](https://github.com/RTMC/tmc-r-tester/blob/77a1ddae73127d2c0b585b20210a83139c5dc515/tests/testthat/testRunTests.R#L82) *style:* **Lines should not be more than 120 characters.**
```r
  expect_output(run_tests(simple_all_tests_pass_project_path, print = TRUE), "ret_true works.: pass\nret_one works.: pass\nadd works.: pass")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


no, tuples can contain anything, and you can change those object's states, just can't remove or add anything to the tuple itself
(the immutability is not viral)

```
>>> class Foo: pass
...
>>> t = (1,42, Foo())
>>> t[2].bla = 666
>>>
>>> t[2]
<__main__.Foo object at 0x1035e67f0>
>>> t[2].bla
666
```


@TysonAndre Thank you very much!


Угу.  как его назвать буфер или накопитель или сообщение зависит от фантазии разработчика


I realized the attr should be a reader, because we don't to modify it or create it
variables I need from the CLI, the genre and the movie


Definitely a problem in some instances. Well worth looking into. Thanks!


scrape rating should be normalizing text, from 90% to 90


@link to @movie_link, to be specific and not get lost in variables


Line too long

move comment before line it describes

```
//Generate initialization vector for AesCbc, in your App change it to YOUR RANDOM string e.g. form /dev/random
byte[] random = Encoding.ASCII.GetBytes("3ivs1Uhl!KgdAAa1");

// Cipher class suports different Algorythms check api for more information
AesCbcCipherParameters aes = new AesCbcCipherParameters();
```


__apiary.manifest contains reference to non-existent file in repository.__ (Autogenerated message from apiary.io)
+ swagger.yaml


vscode 的 tslint 插件并不能捕捉到全部错误信息，部分需要类型检查的选项无法提示。
具体请看这里：https://github.com/Microsoft/vscode-tslint/issues/70#issuecomment-241041929
简单来说就是因为实时更新的代价太大，没有必要。如果你一定要这个功能，可以使用 typescript server 插件自己搭建一个。


J


brackets


initialized the @movie at the top instead of inside method


firefoxの場合はasync/awaitやめてArray.reduce()で繋ぐか。


use `#1DA1F2`
see: https://about.twitter.com/content/dam/about-twitter/company/brand-resources/en_us/Twitter_Brand_Guidelines_V2.0.pdf


need to test if I can do this "description_in = Nokogiri::HTML(open(self.movie_link))"


dimentions === lack of morning coffee 😉


The RX-event is "armed" at the first instance of data arriving.  If data arrives in a **continuous stream** no event is fired unless the buffer become more than 1/2 full.   After a 'gap' in the stream is detected, then the event is fired.

Can you tell anything about the data messages arriving?  Like, are they complete transmissions up until the RX-events go away?  Can you tell that the GPS device is still sending data after that point (LED blinking for example)?


"Sign in with Google: https://developers.google.com/identity/branding-guidelines


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20171003-134513 "deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20171003-134513") to [prod](https://console.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19?env_id=ibm:yp:us-south "ibm:yp:us-south:user@ibm.com:prod"), including this commit


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20171003-134519 "deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20171003-134519") to [prod](https://console.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19?env_id=ibm:yp:us-south "ibm:yp:us-south:user@ibm.com:prod"), including this commit


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-Prod-20171003-134524 "deployed-2-env-Prod-20171003-134524") to [Prod](https://console.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19?env_id=ibm:yp:us-south "There was a problem retrieving the space name"), including this commit


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20171003-134533 "deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20171003-134533") to [prod](https://console.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19?env_id=ibm:yp:us-south "ibm:yp:us-south:user@ibm.com:prod"), including this commit


`h` comes before `i`, so these two lines are switched :P it's not really a big deal, though.


?, el Key no deberia ser un objeto


Will fix


"Continue with Facebook" https://developers.facebook.com/docs/facebook-login/web/login-button


Huh, I've never seen this before. That's cool.


No se dejan comentarios


uninitialised data


I'm sure you can find better name for this variable, `start` is a little bit misleading


Is this app fake?

it can't be written like this. if application has to execute diffrent code it should be configured in config

bool Emulator = true

then use conditional statement here


```
(char*)a
```
would have been sufficient


In your application, can write a log entry each time you receive a message with a timestamp and the number of bytes received?


emty line / brackets
```
Certificate c =  Get(alias, password);
```


WHAT? por que complicarse tanto? "unselected" es una clase que deberia estar por defecto, o en rigor un estado normal


Nice!


Try to declare new variables in the head of the method


Tampoco se dejan logs


Aaaand that dictionary is not a primitive type, so it could be a var :)


Just curious, why is this neede. Imo it should work with the ns class too.


I noticed you also committed the compiled binary of this source file.
Please avoid committing binary files to repositories
[https://development.robinwinslow.uk/2013/06/11/dont-ever-commit-binary-files-to-git/](url)


What it means dwr ? What's the porpouse?


indentation


Divide the different methods with an empty line


Bien, uno deberia siempre usar === en vez de ==, menos cuando quieres saber si un objeto es vacio, `obj == null` es igual a `obj == null || obj == undefined`


Do you want to have a Skype about strlen and memcopy?


If you add `using System.IO` then its enough to use `File.WriteAllLines` alone, because the namespace is already includid via the using above


The filesystem API isn't namespaced.


comentarios, si vas  a dejar comentarios a diestra y siniestra al menos deja un comentario que los justifique, como (esto es temporal y cambiara en la siguiente version) los comentarios son para informar no para dejar codigo


Hi @ngeegoh some example would look like this:

```

import jenkins.model.Jenkins

node
{
  withContext(
    new com.sumologic.jenkins.jenkinssumologicplugin.sender.LogListener(
        env.JOB_NAME,
        env.BUILD_NUMBER))
    {
        script
        {
            currentBuild.result = "SUCCESS"
        }
        echo 'Hello World'
    }
    step([$class: 'com.sumologic.jenkins.jenkinssumologicplugin.SumoBuildNotifier'])
}
```

Where the `withContext` block will forward any output to Sumo Logic as logs and `step([$class: 'com.sumologic.jenkins.jenkinssumologicplugin.SumoBuildNotifier']) ` will emit single json log line to Sumo Logic with build status (intended to be used at the very end of your build pipeline script).


Thank you very much @AFADoomer for recent fixes, i surely wouldn't been able to track or fix them... Btw I have noticed and in extremely rarely occasions enemies still turns as ghosts, plus noticed as well that when this happen they may break "freeze" commands though (they idle continuously until I unfreeze)


[R/GetAvailablePoints.R:15:3:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/GetAvailablePoints.R#L15) *warning:* **local variable ‘original_path’ assigned but may not be used**
```r
  original_path <- getwd()
  ^~~~~~~~~~~~~
```
[R/ResultsCreator.R:8:15:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/ResultsCreator.R#L8) *warning:* **no visible global function definition for ‘.get_status_for_test’**
```r
    status <- .get_status_for_test(test)
              ^~~~~~~~~~~~~~~~~~~~
```
[R/ResultsCreator.R:9:16:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/ResultsCreator.R#L9) *warning:* **no visible global function definition for ‘.create_message_for_test’**
```r
    message <- .create_message_for_test(test)
               ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ResultsJsonParser.R:2:51:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/ResultsJsonParser.R#L2) *style:* **Variable or function name should be snake_case.**
```r
.create_available_points_json_results <- function(testthatOutput) {
                                                  ^~~~~~~~~~~~~~
```
[R/ResultsJsonParser.R:3:11:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/ResultsJsonParser.R#L3) *style:* **Use <-, not =, for assignment.**
```r
  results = list()
          ^
```
[R/ResultsJsonParser.R:9:31:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/ResultsJsonParser.R#L9) *style:* **Put spaces around all infix operators.**
```r
      results[[length(results)+1]] <- list(name=unbox(name), points=points)
                             ~^~
```
[R/ResultsJsonParser.R:9:48:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/ResultsJsonParser.R#L9) *style:* **Put spaces around all infix operators.**
```r
      results[[length(results)+1]] <- list(name=unbox(name), points=points)
                                              ~^~
```
[R/ResultsJsonParser.R:9:49:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/ResultsJsonParser.R#L9) *warning:* **no visible global function definition for ‘unbox’, Did you mean 'box'?**
```r
      results[[length(results)+1]] <- list(name=unbox(name), points=points)
                                                ^~~~~
```
[R/ResultsJsonParser.R:9:68:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/ResultsJsonParser.R#L9) *style:* **Put spaces around all infix operators.**
```r
      results[[length(results)+1]] <- list(name=unbox(name), points=points)
                                                                  ~^~
```
[R/ResultsJsonParser.R:13:7:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/ResultsJsonParser.R#L13) *style:* **Commented code should be removed.**
```r
  #   print(test_result)
      ^~~~~~~~~~~~~~~~~~
```
[R/ResultsJsonParser.R:14:7:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/ResultsJsonParser.R#L14) *style:* **Commented code should be removed.**
```r
    # testName <- test_result$test
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ResultsJsonParser.R:15:7:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/ResultsJsonParser.R#L15) *style:* **Commented code should be removed.**
```r
    # testPoints <- test_result$points
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ResultsJsonParser.R:17:7:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/ResultsJsonParser.R#L17) *style:* **Commented code should be removed.**
```r
    # results[[length(results)+1]] <- list(name=unbox(testName), points=unbox(testPoints))
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ResultsJsonParser.R:19:10:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/ResultsJsonParser.R#L19) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  return (results)
         ^
```
[R/ResultsJsonParser.R:26:25:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/ResultsJsonParser.R#L26) *warning:* **no visible global function definition for ‘.create_json_test_result’**
```r
    test_json_result <- .create_json_test_result(test_result)
                        ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ResultsJsonParser.R:45:20:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/ResultsJsonParser.R#L45) *warning:* **no visible global function definition for ‘toJSON’**
```r
  json <- enc2utf8(toJSON(results, pretty = FALSE))
                   ^~~~~~
```
[R/ResultsJsonParser.R:46:11:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/ResultsJsonParser.R#L46) *warning:* **no visible global function definition for ‘prettify’, Did you mean 'pretty'?**
```r
  json <- prettify(json)
          ^~~~~~~~
```
[R/RunTests.R:6:23:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/RunTests.R#L6) *warning:* **no visible global function definition for ‘.get_available_points’**
```r
  available_points <- .get_available_points(project_path)
                      ^~~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:8:19:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/RunTests.R#L8) *warning:* **no visible global function definition for ‘.create_available_points_json_results’**
```r
  json_results <- .create_available_points_json_results(available_points)
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:9:3:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/RunTests.R#L9) *warning:* **no visible global function definition for ‘.write_json’**
```r
  .write_json(json_results, ".available_points.json")
  ^~~~~~~~~~~
```
[R/RunTests.R:26:19:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/RunTests.R#L26) *warning:* **no visible global function definition for ‘.run_tests_project’**
```r
  test_results <- .run_tests_project(project_path)
                  ^~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:28:19:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/RunTests.R#L28) *warning:* **no visible global function definition for ‘.create_json_results’**
```r
  json_results <- .create_json_results(test_results)
                  ^~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:29:3:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/RunTests.R#L29) *warning:* **no visible global function definition for ‘.write_json’**
```r
  .write_json(json_results, ".results.json")
  ^~~~~~~~~~~
```
[R/RunTests.R:32:5:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/RunTests.R#L32) *warning:* **no visible global function definition for ‘.print_results_from_json’**
```r
    .print_results_from_json(json_results)
    ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:47:21:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/RunTests.R#L47) *warning:* **no visible global function definition for ‘.run_tests_file’**
```r
    file_results <- .run_tests_file(test_file)
                    ^~~~~~~~~~~~~~~
```
[R/RunTests.R:57:3:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/RunTests.R#L57) *warning:* **no visible global function definition for ‘test_file’**
```r
  test_file_output <- test_file(file_path, reporter = "silent")
  ^~~~~~~~~
```
[R/RunTests.R:59:24:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/RunTests.R#L59) *warning:* **no visible global function definition for ‘.create_file_results’**
```r
  test_file_results <- .create_file_results(test_file_output, points, .GlobalEnv$points_for_all_tests)
                       ^~~~~~~~~~~~~~~~~~~~
```
[R/RunTests.R:65:3:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/R/RunTests.R#L65) *warning:* **no visible global function definition for ‘run_tests’**
```r
  run_tests(getwd(), bol)
  ^~~~~~~~~
```
[tests/testthat/resources/simple_all_tests_fail/tests/testthat/helperTMC.R:12:3:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/tests/testthat/resources/simple_all_tests_fail/tests/testthat/helperTMC.R#L12) *warning:* **no visible global function definition for ‘test_that’**
```r
  test_that(desc, code)
  ^~~~~~~~~
```
[tests/testthat/resources/simple_all_tests_pass/tests/testthat/helperTMC.R:12:3:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/tests/testthat/resources/simple_all_tests_pass/tests/testthat/helperTMC.R#L12) *warning:* **no visible global function definition for ‘test_that’**
```r
  test_that(desc, code)
  ^~~~~~~~~
```
[tests/testthat/resources/simple_some_tests_fail/tests/testthat/helperTMC.R:12:3:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/tests/testthat/resources/simple_some_tests_fail/tests/testthat/helperTMC.R#L12) *warning:* **no visible global function definition for ‘test_that’**
```r
  test_that(desc, code)
  ^~~~~~~~~
```
[tests/testthat/testLintr.R:2:5:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/tests/testthat/testLintr.R#L2) *style:* **Commented code should be removed.**
```r
#   context("lints")
    ^~~~~~~~~~~~~~~~
```
[tests/testthat/testLintr.R:4:7:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/tests/testthat/testLintr.R#L4) *style:* **Commented code should be removed.**
```r
#     lintr::expect_lint_free()
      ^~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/testRunTests.R:71:1:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/tests/testthat/testRunTests.R#L71) *style:* **Lines should not be more than 120 characters.**
```r
  expected_json_result[[1]] <- list(status = "pass", name = "ret_true works.", message = "", backtrace = list(), points = list("r1", "r1.1"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/testRunTests.R:72:1:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/tests/testthat/testRunTests.R#L72) *style:* **Lines should not be more than 120 characters.**
```r
  expected_json_result[[2]] <- list(status = "pass", name = "ret_one works.", message = "", backtrace = list(), points = list("r1", "r1.2"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/testRunTests.R:73:1:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/tests/testthat/testRunTests.R#L73) *style:* **Lines should not be more than 120 characters.**
```r
  expected_json_result[[3]] <- list(status = "pass", name = "add works.", message = "", backtrace = list(), points = list("r1", "r1.3", "r1.4"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/testRunTests.R:74:1:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/tests/testthat/testRunTests.R#L74) *style:* **Lines should not be more than 120 characters.**
```r
  expected_json_result[[4]] <- list(status = "fail", name = "ret_false returns true", message = "Failed with call: expect_true, ret_false()\nret_false() isn't true.\n", backtrace = list(), points = list("r1", "r1.5"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/testRunTests.R:75:1:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/tests/testthat/testRunTests.R#L75) *style:* **Lines should not be more than 120 characters.**
```r
  expected_json_result[[5]] <- list(status = "pass", name = "ret_true works but there are no points.", message = "", backtrace = list(), points = list("r1"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/testRunTests.R:82:1:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/tests/testthat/testRunTests.R#L82) *style:* **Lines should not be more than 120 characters.**
```r
  expect_output(run_tests(simple_all_tests_pass_project_path, print = TRUE), "ret_true works.: pass\nret_one works.: pass\nadd works.: pass")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/testRunTests.R:91:37:](https://github.com/RTMC/tmc-r-tester/blob/609f44e364f5722a8ee316824c2d248fe9b06f5d/tests/testthat/testRunTests.R#L91) *style:* **Put spaces around all infix operators.**
```r
  available_points_path <- paste(sep="", simple_all_tests_pass_project_path, "/.available_points.json")
                                   ~^~
```


Let's not talk about compiling applications locally at this time.
```
... environment is required for submitting Apache Beam 2.0 applications to the Streaming Analytics service in Bluemix.
```


做得不错，只是循环完一次pause就总停在循环开始了。顺便python3没有自带的音频流播放库吗？依赖pyaudio还要自己下感觉略麻烦了。


I like the \0 first!  (that's called Yoda conditions)


虽然修改了一些，但是可以继续将switch通过数学公式转化掉


Never ever leave commented code in the commits :)


I would print this from inside the loop
now only the last one will be printed


ese key en el `<li />` esta de mas


sobrecomplicando las cosas (ver comentarios de commits anteriores)


NOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO, NO MANEJES LOS DOOOOOOOOOOOOOOOOOOOOOOOOMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM LA 2^*&%^ &*^*&(^ *% *((^ (*^ *(^


Whenever someone put commented code in the commit, a bunny dies :(


My vote would be to drop any reference to the QSE. However, we should still state that this environment variable should be unset for our purposes.


haha thanks XD


Bluemix [toolchain](https://console.bluemix.net/devops/toolchains/c57b5a1c-4199-431d-a0f5-379810322233 "simpletimes"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/9069cae9-620c-4956-aeee-7579ec940bae "simpletimes") deployed [showtime](https://github.com/no404here/showtime/releases/tag/deploy-ibm-yp-us-south-Getaris-damiana-20171003-135642 "deploy-ibm-yp-us-south-Getaris-damiana-20171003-135642") to [damiana](https://console.bluemix.net/apps/2655c36a-34fe-470d-9d53-bafa7a715202?env_id=ibm:yp:us-south "ibm:yp:us-south:Getaris:damiana"), including this commit


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20171003-135654 "deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20171003-135654") to [prod](https://console.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19?env_id=ibm:yp:us-south "ibm:yp:us-south:user@ibm.com:prod"), including this commit


Small typo 'inspirantion' => 'inspiration'


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20171003-135659 "deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20171003-135659") to [prod](https://console.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19?env_id=ibm:yp:us-south "ibm:yp:us-south:user@ibm.com:prod"), including this commit


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-Prod-20171003-135705 "deployed-2-env-Prod-20171003-135705") to [Prod](https://console.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19?env_id=ibm:yp:us-south "There was a problem retrieving the space name"), including this commit


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20171003-135714 "deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20171003-135714") to [prod](https://console.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19?env_id=ibm:yp:us-south "ibm:yp:us-south:user@ibm.com:prod"), including this commit


Does this work? Doesn't `createCollection` assume no collection exists?


It sounds like this function should fail (by returning error for example) if arguments aren't as expected


Hello Malte, why did you add the X-Robots-Tag?
According to [1], this prevents indexing.

[1] https://developers.google.com/search/reference/robots_meta_tag?hl=en#valid-indexing--serving-directives


The Appveyor build was broken with this commit. There is a slash missing in this comment. As far as I can tell, that's what's causing the issue.


Why did you remove the retry logic?


assertThat(set.translate(null, null, sqlEx), (DuplicateKeyException.class));
해당 부분 api가 바뀐건지 버전때문에 안된건지 고민하고 있었는데 instanceof + is(true) 이용했구먼 참고합니다


Los botones deberian ser componentes, no estamos en los 2000'  para que es todo el proposito de usar react? puedes hacer un container SeatForm, que contenga un Seat, y que el Seat contenga un boton, y este boton tendra cada logica, esto es horrible, que pasaria si tienes que agregar 100 asientos mas? vas a copiar y pegar 100 veces estos bloques y le vas a cambiar el numerito?


__apiary.manifest contains reference to non-existent file in repository.__ (Autogenerated message from apiary.io)
+ swagger.yaml


With this change works. Thank you M. Shibuya.


why isn't this deck part of master? It seems allright to me
I would merge this branch with master


to be sure: do you realise that you're binary and-ing the result of these functions bit by bit?


ignoredups = [re.compile(val) for val in args.ignoredups]``


r+


 public static <T> org.hamcrest.Matcher<T> is(java.lang.Class<T> type)
해당 메소드는 Deprecated, 클래스 넣어서 비교할꺼면 아래 메소드 이용하라고 하네요
public static <T> org.hamcrest.Matcher<T> isA(java.lang.Class<T> type)


There is an extra backtick by `--vcapServices` that shouldn't be there (applies to item below as well.


My name is Bjørn Erik, not Bjørn.


Ok, seems to build...


@mvdbeek The new `dependency_manager` parameter is not used (yet).


1. Description: The absolute path to the extracted `com.ibm.streams.beam-1.0.0` directory
2. Should be `$STREAMS_RUNNER_HOME/samples/bin`
3. Markdown list inside table issue here. HTML tags are viewable.


is this solution in here twice?


I notice you've also committed the binary version of this file
Please refrain from committing binary files into repositories


## This is a markdown file


yes boi


Cool exception handling! (It's an overkill, but still awesome!)


Mission:
HireUp’s mission is to bring diversity to the tech industry by promoting polished talent with internships at reputable companies. These young professionals possess both soft and technical skills as well as a solid foundation of college credits in Java Programming. With higher education and career preparation, HireUp professionals utilize their own personal challenges to fuel change in their lives and career. Hiring HireUp for your business, not only means bringing on resourceful, fresh talent, it means finding potential leaders to pioneer Corporate America. ScaleUp with HireUp!


please do proper indentation, if not you code becomes very hard to read


Grabao a piedra


saw approval from vogel
at https://github.com/MonsieurNicolas/stellar-core/commit/00e1ead68900da646293cf59237a178188f0b6e9


merging MonsieurNicolas/stellar-core/fixMAINTENANCESTARTUP = 00e1ead6 into auto


MonsieurNicolas/stellar-core/fixMAINTENANCESTARTUP = 00e1ead6 merged ok, testing candidate = bacd1879


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20171003-140522 "deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20171003-140522") to [prod](https://console.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19?env_id=ibm:yp:us-south "ibm:yp:us-south:user@ibm.com:prod"), including this commit


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20171003-140529 "deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20171003-140529") to [prod](https://console.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19?env_id=ibm:yp:us-south "ibm:yp:us-south:user@ibm.com:prod"), including this commit


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-Prod-20171003-140534 "deployed-2-env-Prod-20171003-140534") to [Prod](https://console.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19?env_id=ibm:yp:us-south "There was a problem retrieving the space name"), including this commit