[inst/extdata/asalmon_mcw/main.r:2:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/inst/extdata/asalmon_mcw/main.r#L2) *style:* **Variable or function name should be snake_case.**
```r
LAMBDA_var <- 0.1 #Thin plate spline smoothing. Lambda=0 would be interpolation.
^~~~~~~~~~
```
[inst/extdata/asalmon_mcw/main.r:3:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/inst/extdata/asalmon_mcw/main.r#L3) *style:* **Variable or function name should be snake_case.**
```r
RESOLUTION_var <- 500 #Plot width in pixels
^~~~~~~~~~~~~~
```
[inst/extdata/asalmon_mcw/main.r:5:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/inst/extdata/asalmon_mcw/main.r#L5) *style:* **Lines should not be more than 80 characters.**
```r
#TODO change path. make sure this main.r script is just outside the diagram_retina folder.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/extdata/asalmon_mcw/main.r:8:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/inst/extdata/asalmon_mcw/main.r#L8) *style:* **Lines should not be more than 80 characters.**
```r
#todo verify these. see the tutorial here: https://github.com/bc/retina/blob/master/tutorial.md search for the part that starts with "#[V point of the tear,"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/extdata/asalmon_mcw/main.r:10:10:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/inst/extdata/asalmon_mcw/main.r#L10) *style:* **Commas should always have a space after.**
```r
    c(59,52,67),
         ^
```
[inst/extdata/asalmon_mcw/main.r:10:13:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/inst/extdata/asalmon_mcw/main.r#L10) *style:* **Commas should always have a space after.**
```r
    c(59,52,67),
            ^
```
[inst/extdata/asalmon_mcw/main.r:11:10:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/inst/extdata/asalmon_mcw/main.r#L11) *style:* **Commas should always have a space after.**
```r
    c(79,73,85),
         ^
```
[inst/extdata/asalmon_mcw/main.r:11:13:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/inst/extdata/asalmon_mcw/main.r#L11) *style:* **Commas should always have a space after.**
```r
    c(79,73,85),
            ^
```
[inst/extdata/asalmon_mcw/main.r:12:10:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/inst/extdata/asalmon_mcw/main.r#L12) *style:* **Commas should always have a space after.**
```r
    c(34,31,37))
         ^
```
[inst/extdata/asalmon_mcw/main.r:12:13:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/inst/extdata/asalmon_mcw/main.r#L12) *style:* **Commas should always have a space after.**
```r
    c(34,31,37))
            ^
```
[inst/extdata/asalmon_mcw/main.r:13:69:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/inst/extdata/asalmon_mcw/main.r#L13) *error:* **unexpected ')'**
```r
                                                                    )
                                                                    ^
```
[R/composite.R:2:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/composite.R#L2) *style:* **Lines should not be more than 80 characters.**
```r
##' @description This is a subfunction, that is useful when creating average maps.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/composite.R:3:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/composite.R#L3) *style:* **Lines should not be more than 80 characters.**
```r
##' @param retina_list A list containing retina objects, with names(retina_list) all defined.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/composite.R:4:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/composite.R#L4) *style:* **Lines should not be more than 80 characters.**
```r
##' @param rotation_indices Each value in this vector will correspond to the amount of rotation applied to each retina in the list.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/composite.R:5:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/composite.R#L5) *style:* **Lines should not be more than 80 characters.**
```r
##' @param ... Arguments passed from other functions. You can access the thin plate spline interpolator here.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/composite.R:6:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/composite.R#L6) *style:* **Lines should not be more than 80 characters.**
```r
##' @return sum_mat The sum of all retina objects in the list, with respect to the rotation indices.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/composite.R:9:14:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/composite.R#L9) *warning:* **no visible global function definition for ‘mat_from_ret_obj’**
```r
  sum_mat <- mat_from_ret_obj(retina_list[[1]], rotation = 0, ...)
             ^~~~~~~~~~~~~~~~
```
[R/matrix_retobj.R:3:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/matrix_retobj.R#L3) *style:* **Lines should not be more than 80 characters.**
```r
##' You can decide how much to rotate the retina before returning the matrix. You can also pass arguments to the polar plotter.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/matrix_retobj.R:6:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/matrix_retobj.R#L6) *style:* **Lines should not be more than 80 characters.**
```r
##' @param n the number by which to divide the matrix by. Useful when generating partial averages.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/matrix_retobj.R:7:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/matrix_retobj.R#L7) *style:* **Lines should not be more than 80 characters.**
```r
##' @param reflect logical, by default it is TRUE, in order to view the retina from outside the eye (rather than from within.)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/matrix_retobj.R:20:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/matrix_retobj.R#L20) *style:* **Lines should not be more than 80 characters.**
```r
  az <- mapproject(x = retina_object$trimmed_data[, 2], retina_object$trimmed_data[,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/matrix_retobj.R:27:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/matrix_retobj.R#L27) *style:* **Lines should not be more than 80 characters.**
```r
  map2fit <- fit_plot_azimuthal(x2, y2, z2, plot_suppress = TRUE, extrapolate = TRUE,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/matrix_retobj.R:28:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/matrix_retobj.R#L28) *style:* **Lines should not be more than 80 characters.**
```r
    outer_radius = pi/2, falciform_coords = retina_object$azimuthal_data.falciform[[1]],
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/matrix_retobj.R:28:22:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/matrix_retobj.R#L28) *style:* **Put spaces around all infix operators.**
```r
    outer_radius = pi/2, falciform_coords = retina_object$azimuthal_data.falciform[[1]],
                    ~^~
```
[R/matrix_retobj.R:30:3:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/matrix_retobj.R#L30) *style:* **Variable or function name should be snake_case.**
```r
  MAT <- map2fit[[2]]$z
  ^~~
```
[R/matrix_retobj.R:32:13:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/matrix_retobj.R#L32) *style:* **Put spaces around all infix operators.**
```r
  return(MAT/n)
           ~^~
```
[R/plotting_functions.R:3:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L3) *style:* **Lines should not be more than 80 characters.**
```r
##' Extracts xy and falciform coordinates from datapoints collected from retistruct. Falc and Datapoints are stacked upon one another
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:5:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L5) *style:* **Lines should not be more than 80 characters.**
```r
##' @param datapoints_from_retistruct data structure that comes from the datapoints.csv, which is automatically generated by Retistruct.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:7:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L7) *style:* **Lines should not be more than 80 characters.**
```r
##' @return L list of pixel xy positions, and falciform coordinates in [1] and [2], respectively
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:9:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L9) *style:* **Lines should not be more than 80 characters.**
```r
extract_xy_and_falciform <- function(datapoints_from_retistruct, number_of_sampling_sites) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:10:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L10) *style:* **Use spaces to indent, not tabs.**
```r
	pixel_xy_positions <- datapoints_from_retistruct[1:number_of_sampling_sites,]
^
```
[R/plotting_functions.R:10:78:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L10) *style:* **Commas should always have a space after.**
```r
	pixel_xy_positions <- datapoints_from_retistruct[1:number_of_sampling_sites,]
                                                                             ^
```
[R/plotting_functions.R:11:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L11) *style:* **Lines should not be more than 80 characters.**
```r
	falciform_len <- length(datapoints_from_retistruct[,1]) - length(pixel_xy_positions[,1])
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:11:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L11) *style:* **Use spaces to indent, not tabs.**
```r
	falciform_len <- length(datapoints_from_retistruct[,1]) - length(pixel_xy_positions[,1])
^
```
[R/plotting_functions.R:11:2:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L11) *warning:* **local variable ‘falciform_len’ assigned but may not be used**
```r
	falciform_len <- length(datapoints_from_retistruct[,1]) - length(pixel_xy_positions[,1])
 ^~~~~~~~~~~~~
```
[R/plotting_functions.R:11:54:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L11) *style:* **Commas should always have a space after.**
```r
	falciform_len <- length(datapoints_from_retistruct[,1]) - length(pixel_xy_positions[,1])
                                                     ^
```
[R/plotting_functions.R:11:87:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L11) *style:* **Commas should always have a space after.**
```r
	falciform_len <- length(datapoints_from_retistruct[,1]) - length(pixel_xy_positions[,1])
                                                                                ^
```
[R/plotting_functions.R:12:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L12) *style:* **Use spaces to indent, not tabs.**
```r
	xy_len <- length(pixel_xy_positions[,1])
^
```
[R/plotting_functions.R:12:39:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L12) *style:* **Commas should always have a space after.**
```r
	xy_len <- length(pixel_xy_positions[,1])
                                      ^
```
[R/plotting_functions.R:13:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L13) *style:* **Use spaces to indent, not tabs.**
```r
	total_len <- length(datapoints_from_retistruct[,1])
^
```
[R/plotting_functions.R:13:50:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L13) *style:* **Commas should always have a space after.**
```r
	total_len <- length(datapoints_from_retistruct[,1])
                                                 ^
```
[R/plotting_functions.R:14:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L14) *style:* **Use spaces to indent, not tabs.**
```r
	falciform_coordinates <- datapoints_from_retistruct[(xy_len+1):total_len,]
^
```
[R/plotting_functions.R:14:61:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L14) *style:* **Put spaces around all infix operators.**
```r
	falciform_coordinates <- datapoints_from_retistruct[(xy_len+1):total_len,]
                                                           ~^~
```
[R/plotting_functions.R:14:75:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L14) *style:* **Commas should always have a space after.**
```r
	falciform_coordinates <- datapoints_from_retistruct[(xy_len+1):total_len,]
                                                                          ^
```
[R/plotting_functions.R:15:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L15) *style:* **Use spaces to indent, not tabs.**
```r
	return(list(pixel_xy_positions, falciform_coordinates))
^
```
[R/plotting_functions.R:20:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L20) *style:* **Lines should not be more than 80 characters.**
```r
##' ImageJ values don't always show up the right way, because Y values get larger and positive while moving down the image.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:22:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L22) *style:* **Lines should not be more than 80 characters.**
```r
##' @param falciform_xy_coordinates 2 columns of coordinate (X,Y) data in ImageJ pixel format
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:26:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L26) *style:* **Lines should not be more than 80 characters.**
```r
reflect_IJ_y_values_for_falciform <- function(falciform_xy_coordinates, xy_img_dimensions){
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:26:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L26) *style:* **Variable and function names should not be longer than 30 characters.**
```r
reflect_IJ_y_values_for_falciform <- function(falciform_xy_coordinates, xy_img_dimensions){
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:26:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L26) *style:* **Variable or function name should be snake_case.**
```r
reflect_IJ_y_values_for_falciform <- function(falciform_xy_coordinates, xy_img_dimensions){
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:27:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L27) *style:* **Use spaces to indent, not tabs.**
```r
		falciform_xy_coordinates_transformed <- falciform_xy_coordinates #make a copy
^~
```
[R/plotting_functions.R:27:3:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L27) *style:* **Variable and function names should not be longer than 30 characters.**
```r
		falciform_xy_coordinates_transformed <- falciform_xy_coordinates #make a copy
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:28:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L28) *style:* **Use spaces to indent, not tabs.**
```r
		falc_y <- falciform_xy_coordinates[,2]
^~
```
[R/plotting_functions.R:28:39:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L28) *style:* **Commas should always have a space after.**
```r
		falc_y <- falciform_xy_coordinates[,2]
                                      ^
```
[R/plotting_functions.R:29:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L29) *style:* **Use spaces to indent, not tabs.**
```r
		half_of_vertical_pixels <- xy_img_dimensions[2]/2
^~
```
[R/plotting_functions.R:29:50:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L29) *style:* **Put spaces around all infix operators.**
```r
		half_of_vertical_pixels <- xy_img_dimensions[2]/2
                                                ~^~
```
[R/plotting_functions.R:30:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L30) *style:* **Lines should not be more than 80 characters.**
```r
		falciform_xy_coordinates_transformed$cyan <- (falc_y-half_of_vertical_pixels)*-1 + half_of_vertical_pixels
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:30:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L30) *style:* **Use spaces to indent, not tabs.**
```r
		falciform_xy_coordinates_transformed$cyan <- (falc_y-half_of_vertical_pixels)*-1 + half_of_vertical_pixels
^~
```
[R/plotting_functions.R:30:55:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L30) *style:* **Put spaces around all infix operators.**
```r
		falciform_xy_coordinates_transformed$cyan <- (falc_y-half_of_vertical_pixels)*-1 + half_of_vertical_pixels
                                                     ~^~
```
[R/plotting_functions.R:30:80:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L30) *style:* **Put spaces around all infix operators.**
```r
		falciform_xy_coordinates_transformed$cyan <- (falc_y-half_of_vertical_pixels)*-1 + half_of_vertical_pixels
                                                                              ~^~
```
[R/plotting_functions.R:31:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L31) *style:* **Use spaces to indent, not tabs.**
```r
		return(falciform_xy_coordinates_transformed)
^~
```
[R/plotting_functions.R:35:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L35) *style:* **Lines should not be more than 80 characters.**
```r
##' Shows a visualization of the outline, as well as the location of each datapoint, with fit plot.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:37:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L37) *style:* **Lines should not be more than 80 characters.**
```r
##' @param pixel_xy_positions 2 columns of coordinate (X,Y) data in ImageJ pixel format
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:38:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L38) *style:* **Lines should not be more than 80 characters.**
```r
##' @param z_vector numerical vector of density values for each of the coordinates
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:39:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L39) *style:* **Lines should not be more than 80 characters.**
```r
##' @param xy_outline_points 2 columns of coordinate(X,Y) data in ImageJ pixel format for the outline coordinates.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:42:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L42) *style:* **Lines should not be more than 80 characters.**
```r
traditional_flatmount_plot <- function(pixel_xy_positions,z_vector, xy_outline_points){
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:42:59:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L42) *style:* **Commas should always have a space after.**
```r
traditional_flatmount_plot <- function(pixel_xy_positions,z_vector, xy_outline_points){
                                                          ^
```
[R/plotting_functions.R:43:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L43) *style:* **Lines should not be more than 80 characters.**
```r
	fit <- Tps(pixel_xy_positions, z_vector)  # fits a surface to ozone measurements.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:43:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L43) *style:* **Use spaces to indent, not tabs.**
```r
	fit <- Tps(pixel_xy_positions, z_vector)  # fits a surface to ozone measurements.
^
```
[R/plotting_functions.R:43:9:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L43) *warning:* **no visible global function definition for ‘Tps’, Did you mean 'Ops'?**
```r
	fit <- Tps(pixel_xy_positions, z_vector)  # fits a surface to ozone measurements.
        ^~~
```
[R/plotting_functions.R:44:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L44) *style:* **Use spaces to indent, not tabs.**
```r
	set.panel(2,2)
^
```
[R/plotting_functions.R:44:2:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L44) *warning:* **no visible global function definition for ‘set.panel’**
```r
	set.panel(2,2)
 ^~~~~~~~~
```
[R/plotting_functions.R:44:14:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L44) *style:* **Commas should always have a space after.**
```r
	set.panel(2,2)
             ^
```
[R/plotting_functions.R:45:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L45) *style:* **Use spaces to indent, not tabs.**
```r
	plot(fit) # four diagnostic plots of  fit and residuals.
^
```
[R/plotting_functions.R:46:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L46) *style:* **Use spaces to indent, not tabs.**
```r
	set.panel()
^
```
[R/plotting_functions.R:46:2:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L46) *warning:* **no visible global function definition for ‘set.panel’**
```r
	set.panel()
 ^~~~~~~~~
```
[R/plotting_functions.R:47:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L47) *style:* **Use spaces to indent, not tabs.**
```r
	# summary of fit and estimates of lambda the smoothing parameter
^
```
[R/plotting_functions.R:48:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L48) *style:* **Use spaces to indent, not tabs.**
```r
	summary(fit)
^
```
[R/plotting_functions.R:49:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L49) *style:* **Use spaces to indent, not tabs.**
```r
	surface(fit) # Quick image/contour plot of GCV surface.
^
```
[R/plotting_functions.R:49:2:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L49) *warning:* **no visible global function definition for ‘surface’**
```r
	surface(fit) # Quick image/contour plot of GCV surface.
 ^~~~~~~
```
[R/plotting_functions.R:50:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L50) *style:* **Use spaces to indent, not tabs.**
```r
	return(fit)
^
```
[R/plotting_functions.R:58:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L58) *style:* **Lines should not be more than 80 characters.**
```r
##' Shows a visualization of the outline, as well as the location of each datapoint so the user can identify where the tears are.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:61:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L61) *style:* **Lines should not be more than 80 characters.**
```r
##' @param path_to_retina_data_folder The path to the folder that contains the outline.roi file.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:62:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L62) *style:* **Lines should not be more than 80 characters.**
```r
##' @return roi_coordinates XY vals of pixel coordinates of the outline points, in order.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:66:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L66) *style:* **Use spaces to indent, not tabs.**
```r
	roi_object <- read.ijroi(file.path(path_to_retina_data_folder, "outline.roi"))
^
```
[R/plotting_functions.R:66:16:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L66) *warning:* **no visible global function definition for ‘read.ijroi’**
```r
	roi_object <- read.ijroi(file.path(path_to_retina_data_folder, "outline.roi"))
               ^~~~~~~~~~
```
[R/plotting_functions.R:69:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L69) *style:* **Use spaces to indent, not tabs.**
```r
		## ImageJ ROI format plots has the coordinate (0, 0) in the top
^~
```
[R/plotting_functions.R:70:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L70) *style:* **Use spaces to indent, not tabs.**
```r
		  ## left.  We have the coordinate (0, 0) in the bottom left. We need
^~
```
[R/plotting_functions.R:71:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L71) *style:* **Use spaces to indent, not tabs.**
```r
		  ## to transform P so that the outline appears in the correct
^~
```
[R/plotting_functions.R:72:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L72) *style:* **Use spaces to indent, not tabs.**
```r
		  ## orientation.
^~
```
[R/plotting_functions.R:73:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L73) *style:* **Use spaces to indent, not tabs.**
```r
			im <- NULL
^~~
```
[R/plotting_functions.R:74:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L74) *style:* **Use spaces to indent, not tabs.**
```r
		  roi_XY_coords <- roi_object$coords
^~
```
[R/plotting_functions.R:74:5:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L74) *style:* **Variable or function name should be snake_case.**
```r
		  roi_XY_coords <- roi_object$coords
    ^~~~~~~~~~~~~
```
[R/plotting_functions.R:75:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L75) *style:* **Use spaces to indent, not tabs.**
```r
		  offset <- ifelse(is.null(im), max(roi_XY_coords[,2]), nrow(im))
^~
```
[R/plotting_functions.R:75:54:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L75) *style:* **Commas should always have a space after.**
```r
		  offset <- ifelse(is.null(im), max(roi_XY_coords[,2]), nrow(im))
                                                     ^
```
[R/plotting_functions.R:76:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L76) *style:* **Use spaces to indent, not tabs.**
```r
		  roi_XY_coords[,2] <- offset - roi_XY_coords[,2]
^~
```
[R/plotting_functions.R:76:20:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L76) *style:* **Commas should always have a space after.**
```r
		  roi_XY_coords[,2] <- offset - roi_XY_coords[,2]
                   ^
```
[R/plotting_functions.R:76:50:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L76) *style:* **Commas should always have a space after.**
```r
		  roi_XY_coords[,2] <- offset - roi_XY_coords[,2]
                                                 ^
```
[R/plotting_functions.R:79:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L79) *style:* **Lines should not be more than 80 characters.**
```r
	plot(roi_XY_coords, type="l", col='#d3d3d3', asp=1, xlab='X Pixels', ylab='Y Pixels');
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:79:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L79) *style:* **Use spaces to indent, not tabs.**
```r
	plot(roi_XY_coords, type="l", col='#d3d3d3', asp=1, xlab='X Pixels', ylab='Y Pixels');
^
```
[R/plotting_functions.R:79:26:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L79) *style:* **Put spaces around all infix operators.**
```r
	plot(roi_XY_coords, type="l", col='#d3d3d3', asp=1, xlab='X Pixels', ylab='Y Pixels');
                        ~^~
```
[R/plotting_functions.R:79:35:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L79) *style:* **Put spaces around all infix operators.**
```r
	plot(roi_XY_coords, type="l", col='#d3d3d3', asp=1, xlab='X Pixels', ylab='Y Pixels');
                                 ~^~
```
[R/plotting_functions.R:79:36:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L79) *style:* **Only use double-quotes.**
```r
	plot(roi_XY_coords, type="l", col='#d3d3d3', asp=1, xlab='X Pixels', ylab='Y Pixels');
                                   ^~~~~~~~~
```
[R/plotting_functions.R:79:50:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L79) *style:* **Put spaces around all infix operators.**
```r
	plot(roi_XY_coords, type="l", col='#d3d3d3', asp=1, xlab='X Pixels', ylab='Y Pixels');
                                                ~^~
```
[R/plotting_functions.R:79:58:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L79) *style:* **Put spaces around all infix operators.**
```r
	plot(roi_XY_coords, type="l", col='#d3d3d3', asp=1, xlab='X Pixels', ylab='Y Pixels');
                                                        ~^~
```
[R/plotting_functions.R:79:59:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L79) *style:* **Only use double-quotes.**
```r
	plot(roi_XY_coords, type="l", col='#d3d3d3', asp=1, xlab='X Pixels', ylab='Y Pixels');
                                                          ^~~~~~~~~~
```
[R/plotting_functions.R:79:75:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L79) *style:* **Put spaces around all infix operators.**
```r
	plot(roi_XY_coords, type="l", col='#d3d3d3', asp=1, xlab='X Pixels', ylab='Y Pixels');
                                                                         ~^~
```
[R/plotting_functions.R:79:76:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L79) *style:* **Only use double-quotes.**
```r
	plot(roi_XY_coords, type="l", col='#d3d3d3', asp=1, xlab='X Pixels', ylab='Y Pixels');
                                                                           ^~~~~~~~~~
```
[R/plotting_functions.R:80:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L80) *style:* **Lines should not be more than 80 characters.**
```r
	text(roi_XY_coords[,1],roi_XY_coords[,2], labels=1:length(roi_XY_coords[,1]), cex=0.5)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:80:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L80) *style:* **Use spaces to indent, not tabs.**
```r
	text(roi_XY_coords[,1],roi_XY_coords[,2], labels=1:length(roi_XY_coords[,1]), cex=0.5)
^
```
[R/plotting_functions.R:80:22:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L80) *style:* **Commas should always have a space after.**
```r
	text(roi_XY_coords[,1],roi_XY_coords[,2], labels=1:length(roi_XY_coords[,1]), cex=0.5)
                     ^
```
[R/plotting_functions.R:80:25:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L80) *style:* **Commas should always have a space after.**
```r
	text(roi_XY_coords[,1],roi_XY_coords[,2], labels=1:length(roi_XY_coords[,1]), cex=0.5)
                        ^
```
[R/plotting_functions.R:80:40:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L80) *style:* **Commas should always have a space after.**
```r
	text(roi_XY_coords[,1],roi_XY_coords[,2], labels=1:length(roi_XY_coords[,1]), cex=0.5)
                                       ^
```
[R/plotting_functions.R:80:50:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L80) *style:* **Put spaces around all infix operators.**
```r
	text(roi_XY_coords[,1],roi_XY_coords[,2], labels=1:length(roi_XY_coords[,1]), cex=0.5)
                                                ~^~
```
[R/plotting_functions.R:80:75:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L80) *style:* **Commas should always have a space after.**
```r
	text(roi_XY_coords[,1],roi_XY_coords[,2], labels=1:length(roi_XY_coords[,1]), cex=0.5)
                                                                          ^
```
[R/plotting_functions.R:80:83:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L80) *style:* **Put spaces around all infix operators.**
```r
	text(roi_XY_coords[,1],roi_XY_coords[,2], labels=1:length(roi_XY_coords[,1]), cex=0.5)
                                                                                ~^~
```
[R/plotting_functions.R:81:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L81) *style:* **Lines should not be more than 80 characters.**
```r
 	message('If you are getting this message, you are using a special feature. Contact me at brian.cohn@usc.edu and I will happily teach you how to use it.')
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:81:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L81) *style:* **Use spaces to indent, not tabs.**
```r
 	message('If you are getting this message, you are using a special feature. Contact me at brian.cohn@usc.edu and I will happily teach you how to use it.')
^~
```
[R/plotting_functions.R:81:11:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L81) *style:* **Only use double-quotes.**
```r
 	message('If you are getting this message, you are using a special feature. Contact me at brian.cohn@usc.edu and I will happily teach you how to use it.')
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:82:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L82) *style:* **Use spaces to indent, not tabs.**
```r
	return(roi_XY_coords)
^
```
[R/plotting_functions.R:89:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L89) *style:* **Lines should not be more than 80 characters.**
```r
##' @description Creates a markup.csv file. One of the dorsal_outline_index or nasal_outline_index must be filled in. Not both.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:92:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L92) *style:* **Lines should not be more than 80 characters.**
```r
##' @param dorsal_outline_index The index of the point that points toward dorsal, or NA.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:93:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L93) *style:* **Lines should not be more than 80 characters.**
```r
##' @param nasal_outline_index The index of the opint that points toward nasal, or NA.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:94:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L94) *style:* **Lines should not be more than 80 characters.**
```r
##' @param path_to_retina_data_folder The path where the markup.csv file will be saved.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:96:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L96) *style:* **Lines should not be more than 80 characters.**
```r
assemble_markup_file <- function(eye_left_or_right, path_to_retina_data_folder, dorsal_outline_index=NA, nasal_outline_index=NA) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:99:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L99) *style:* **Use spaces to indent, not tabs.**
```r
	firstup <- function(x) {
^
```
[R/plotting_functions.R:100:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L100) *style:* **Lines should not be more than 80 characters.**
```r
	##firstup function sourced from https://stackoverflow.com/questions/18509527/first-letter-to-upper-case
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:100:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L100) *style:* **Use spaces to indent, not tabs.**
```r
	##firstup function sourced from https://stackoverflow.com/questions/18509527/first-letter-to-upper-case
^
```
[R/plotting_functions.R:101:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L101) *style:* **Use spaces to indent, not tabs.**
```r
	   substr(x, 1, 1) <- toupper(substr(x, 1, 1))
^
```
[R/plotting_functions.R:102:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L102) *style:* **Use spaces to indent, not tabs.**
```r
	x
^
```
[R/plotting_functions.R:103:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L103) *style:* **Use spaces to indent, not tabs.**
```r
	}
^
```
[R/plotting_functions.R:104:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L104) *style:* **Use spaces to indent, not tabs.**
```r
	eye_side_string <- firstup(eye_left_or_right)
^
```
[R/plotting_functions.R:105:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L105) *style:* **Use spaces to indent, not tabs.**
```r
	if (is.na(dorsal_outline_index)){
^
```
[R/plotting_functions.R:106:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L106) *style:* **Use spaces to indent, not tabs.**
```r
	line2 <- paste0('NA,',
^
```
[R/plotting_functions.R:106:18:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L106) *style:* **Only use double-quotes.**
```r
	line2 <- paste0('NA,',
                 ^~~~~
```
[R/plotting_functions.R:107:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L107) *style:* **Use spaces to indent, not tabs.**
```r
									nasal_outline_index,
^~~~~~~~~
```
[R/plotting_functions.R:108:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L108) *style:* **Use spaces to indent, not tabs.**
```r
									',0,NA,TRUE,"',
^~~~~~~~~
```
[R/plotting_functions.R:109:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L109) *style:* **Use spaces to indent, not tabs.**
```r
									eye_side_string,
^~~~~~~~~
```
[R/plotting_functions.R:110:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L110) *style:* **Use spaces to indent, not tabs.**
```r
									'"')
^~~~~~~~~
```
[R/plotting_functions.R:111:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L111) *style:* **Use spaces to indent, not tabs.**
```r
	} else {
^
```
[R/plotting_functions.R:112:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L112) *style:* **Use spaces to indent, not tabs.**
```r
		line2 <- paste0(dorsal_outline_index,
^~
```
[R/plotting_functions.R:113:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L113) *style:* **Use spaces to indent, not tabs.**
```r
										',NA',
^~~~~~~~~~
```
[R/plotting_functions.R:113:11:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L113) *style:* **Only use double-quotes.**
```r
										',NA',
          ^~~~~
```
[R/plotting_functions.R:114:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L114) *style:* **Use spaces to indent, not tabs.**
```r
										',0,NA,TRUE,"',
^~~~~~~~~~
```
[R/plotting_functions.R:115:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L115) *style:* **Use spaces to indent, not tabs.**
```r
										eye_side_string,
^~~~~~~~~~
```
[R/plotting_functions.R:116:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L116) *style:* **Use spaces to indent, not tabs.**
```r
										'"')
^~~~~~~~~~
```
[R/plotting_functions.R:117:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L117) *style:* **Use spaces to indent, not tabs.**
```r
	}
^
```
[R/plotting_functions.R:118:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L118) *style:* **Use spaces to indent, not tabs.**
```r
	line1 = '"iD","iN","phi0","iOD","DVflip","side"'
^
```
[R/plotting_functions.R:118:8:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L118) *style:* **Use <-, not =, for assignment.**
```r
	line1 = '"iD","iN","phi0","iOD","DVflip","side"'
       ^
```
[R/plotting_functions.R:119:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L119) *style:* **Use spaces to indent, not tabs.**
```r
	output_path <- file.path(path_to_retina_data_folder, "markup.csv")
^
```
[R/plotting_functions.R:120:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L120) *style:* **Use spaces to indent, not tabs.**
```r
	file.create(output_path)
^
```
[R/plotting_functions.R:121:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L121) *style:* **Use spaces to indent, not tabs.**
```r
	write(line1,file=output_path,append=TRUE)
^
```
[R/plotting_functions.R:121:14:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L121) *style:* **Commas should always have a space after.**
```r
	write(line1,file=output_path,append=TRUE)
             ^
```
[R/plotting_functions.R:121:18:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L121) *style:* **Put spaces around all infix operators.**
```r
	write(line1,file=output_path,append=TRUE)
                ~^~
```
[R/plotting_functions.R:121:31:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L121) *style:* **Commas should always have a space after.**
```r
	write(line1,file=output_path,append=TRUE)
                              ^
```
[R/plotting_functions.R:121:37:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L121) *style:* **Put spaces around all infix operators.**
```r
	write(line1,file=output_path,append=TRUE)
                                   ~^~
```
[R/plotting_functions.R:122:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L122) *style:* **Use spaces to indent, not tabs.**
```r
	write(line2, file=output_path, append=TRUE)
^
```
[R/plotting_functions.R:122:19:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L122) *style:* **Put spaces around all infix operators.**
```r
	write(line2, file=output_path, append=TRUE)
                 ~^~
```
[R/plotting_functions.R:122:39:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L122) *style:* **Put spaces around all infix operators.**
```r
	write(line2, file=output_path, append=TRUE)
                                     ~^~
```
[R/plotting_functions.R:123:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L123) *style:* **Lines should not be more than 80 characters.**
```r
	message(paste('Wrote markup file to ',output_path, '\n Check that it exists beside your outline.roi file'))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:123:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L123) *style:* **Use spaces to indent, not tabs.**
```r
	message(paste('Wrote markup file to ',output_path, '\n Check that it exists beside your outline.roi file'))
^
```
[R/plotting_functions.R:123:16:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L123) *style:* **Only use double-quotes.**
```r
	message(paste('Wrote markup file to ',output_path, '\n Check that it exists beside your outline.roi file'))
               ^~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:123:40:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L123) *style:* **Commas should always have a space after.**
```r
	message(paste('Wrote markup file to ',output_path, '\n Check that it exists beside your outline.roi file'))
                                       ^
```
[R/plotting_functions.R:123:53:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L123) *style:* **Only use double-quotes.**
```r
	message(paste('Wrote markup file to ',output_path, '\n Check that it exists beside your outline.roi file'))
                                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:124:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L124) *style:* **Use spaces to indent, not tabs.**
```r
	print(line1)
^
```
[R/plotting_functions.R:125:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L125) *style:* **Use spaces to indent, not tabs.**
```r
	print(line2)
^
```
[R/plotting_functions.R:126:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L126) *style:* **Use spaces to indent, not tabs.**
```r
	return(0)
^
```
[R/plotting_functions.R:134:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L134) *style:* **Lines should not be more than 80 characters.**
```r
##' @param tear_coordinates_dataframe the dataframe of 3 columns, with c("V0","VB","VF"), and n columns, where n= number of tears
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:135:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L135) *style:* **Lines should not be more than 80 characters.**
```r
##' @param path_to_retina_data_folder The path where the T.csv file will be saved.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:139:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L139) *style:* **Lines should not be more than 80 characters.**
```r
assemble_tear_file <- function(tear_coordinates_dataframe, path_to_retina_data_folder){
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:140:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L140) *style:* **Use spaces to indent, not tabs.**
```r
	output_path <- file.path(path_to_retina_data_folder, "T.csv")
^
```
[R/plotting_functions.R:141:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L141) *style:* **Use spaces to indent, not tabs.**
```r
	colnames(tear_coordinates_dataframe)<- c("V0","VB","VF")
^
```
[R/plotting_functions.R:141:38:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L141) *style:* **Put spaces around all infix operators.**
```r
	colnames(tear_coordinates_dataframe)<- c("V0","VB","VF")
                                    ~^
```
[R/plotting_functions.R:141:48:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L141) *style:* **Commas should always have a space after.**
```r
	colnames(tear_coordinates_dataframe)<- c("V0","VB","VF")
                                               ^
```
[R/plotting_functions.R:141:53:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L141) *style:* **Commas should always have a space after.**
```r
	colnames(tear_coordinates_dataframe)<- c("V0","VB","VF")
                                                    ^
```
[R/plotting_functions.R:142:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L142) *style:* **Lines should not be more than 80 characters.**
```r
	write.table(tear_coordinates_dataframe, output_path, sep=',', row.names = FALSE)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:142:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L142) *style:* **Use spaces to indent, not tabs.**
```r
	write.table(tear_coordinates_dataframe, output_path, sep=',', row.names = FALSE)
^
```
[R/plotting_functions.R:142:58:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L142) *style:* **Put spaces around all infix operators.**
```r
	write.table(tear_coordinates_dataframe, output_path, sep=',', row.names = FALSE)
                                                        ~^~
```
[R/plotting_functions.R:142:59:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L142) *style:* **Only use double-quotes.**
```r
	write.table(tear_coordinates_dataframe, output_path, sep=',', row.names = FALSE)
                                                          ^~~
```
[R/plotting_functions.R:143:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L143) *style:* **Lines should not be more than 80 characters.**
```r
	message(paste('Wrote tear file to ',output_path, '\n Check that it exists beside your outline.roi file'))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:143:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L143) *style:* **Use spaces to indent, not tabs.**
```r
	message(paste('Wrote tear file to ',output_path, '\n Check that it exists beside your outline.roi file'))
^
```
[R/plotting_functions.R:143:16:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L143) *style:* **Only use double-quotes.**
```r
	message(paste('Wrote tear file to ',output_path, '\n Check that it exists beside your outline.roi file'))
               ^~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:143:38:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L143) *style:* **Commas should always have a space after.**
```r
	message(paste('Wrote tear file to ',output_path, '\n Check that it exists beside your outline.roi file'))
                                     ^
```
[R/plotting_functions.R:143:51:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L143) *style:* **Only use double-quotes.**
```r
	message(paste('Wrote tear file to ',output_path, '\n Check that it exists beside your outline.roi file'))
                                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:144:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L144) *style:* **Use spaces to indent, not tabs.**
```r
	return(tear_coordinates_dataframe)
^
```
[R/plotting_functions.R:151:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L151) *style:* **Lines should not be more than 80 characters.**
```r
##' @param path_to_retina_data_folder The path where the P.csv file will be saved.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:155:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L155) *style:* **Lines should not be more than 80 characters.**
```r
assemble_point_coordinates_file <- function(outline_coordinates, path_to_retina_data_folder){
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:155:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L155) *style:* **Variable and function names should not be longer than 30 characters.**
```r
assemble_point_coordinates_file <- function(outline_coordinates, path_to_retina_data_folder){
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:156:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L156) *style:* **Use spaces to indent, not tabs.**
```r
	output_path <- file.path(path_to_retina_data_folder, "P.csv")
^
```
[R/plotting_functions.R:157:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L157) *style:* **Use spaces to indent, not tabs.**
```r
	colnames(outline_coordinates)<- c("V1","V2")
^
```
[R/plotting_functions.R:157:31:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L157) *style:* **Put spaces around all infix operators.**
```r
	colnames(outline_coordinates)<- c("V1","V2")
                             ~^
```
[R/plotting_functions.R:157:41:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L157) *style:* **Commas should always have a space after.**
```r
	colnames(outline_coordinates)<- c("V1","V2")
                                        ^
```
[R/plotting_functions.R:158:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L158) *style:* **Use spaces to indent, not tabs.**
```r
	write.table(outline_coordinates, output_path, sep=',', row.names = F)
^
```
[R/plotting_functions.R:158:51:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L158) *style:* **Put spaces around all infix operators.**
```r
	write.table(outline_coordinates, output_path, sep=',', row.names = F)
                                                 ~^~
```
[R/plotting_functions.R:158:52:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L158) *style:* **Only use double-quotes.**
```r
	write.table(outline_coordinates, output_path, sep=',', row.names = F)
                                                   ^~~
```
[R/plotting_functions.R:159:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L159) *style:* **Lines should not be more than 80 characters.**
```r
	message(paste('Wrote coordinates file to ',output_path, '\n Check that it exists beside your outline.roi file'))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:159:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L159) *style:* **Use spaces to indent, not tabs.**
```r
	message(paste('Wrote coordinates file to ',output_path, '\n Check that it exists beside your outline.roi file'))
^
```
[R/plotting_functions.R:159:16:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L159) *style:* **Only use double-quotes.**
```r
	message(paste('Wrote coordinates file to ',output_path, '\n Check that it exists beside your outline.roi file'))
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:159:45:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L159) *style:* **Commas should always have a space after.**
```r
	message(paste('Wrote coordinates file to ',output_path, '\n Check that it exists beside your outline.roi file'))
                                            ^
```
[R/plotting_functions.R:159:58:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L159) *style:* **Only use double-quotes.**
```r
	message(paste('Wrote coordinates file to ',output_path, '\n Check that it exists beside your outline.roi file'))
                                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:160:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L160) *style:* **Use spaces to indent, not tabs.**
```r
	return(outline_coordinates)
^
```
[R/plotting_functions.R:170:42:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L170) *style:* **Commas should always have a space after.**
```r
plot_original_xy_locations <- function(x,y) {
                                         ^
```
[R/plotting_functions.R:171:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L171) *style:* **Use spaces to indent, not tabs.**
```r
	points(x+0.005,y,pch=4, cex=0.5, col="gainsboro")
^
```
[R/plotting_functions.R:171:10:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L171) *style:* **Put spaces around all infix operators.**
```r
	points(x+0.005,y,pch=4, cex=0.5, col="gainsboro")
        ~^~
```
[R/plotting_functions.R:171:17:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L171) *style:* **Commas should always have a space after.**
```r
	points(x+0.005,y,pch=4, cex=0.5, col="gainsboro")
                ^
```
[R/plotting_functions.R:171:19:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L171) *style:* **Commas should always have a space after.**
```r
	points(x+0.005,y,pch=4, cex=0.5, col="gainsboro")
                  ^
```
[R/plotting_functions.R:171:22:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L171) *style:* **Put spaces around all infix operators.**
```r
	points(x+0.005,y,pch=4, cex=0.5, col="gainsboro")
                    ~^~
```
[R/plotting_functions.R:171:29:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L171) *style:* **Put spaces around all infix operators.**
```r
	points(x+0.005,y,pch=4, cex=0.5, col="gainsboro")
                           ~^~
```
[R/plotting_functions.R:171:38:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L171) *style:* **Put spaces around all infix operators.**
```r
	points(x+0.005,y,pch=4, cex=0.5, col="gainsboro")
                                    ~^~
```
[R/plotting_functions.R:172:12:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L172) *style:* **Commas should always have a space after.**
```r
  points(x,y,pch=4, cex=0.5, col="black")
           ^
```
[R/plotting_functions.R:172:14:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L172) *style:* **Commas should always have a space after.**
```r
  points(x,y,pch=4, cex=0.5, col="black")
             ^
```
[R/plotting_functions.R:172:17:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L172) *style:* **Put spaces around all infix operators.**
```r
  points(x,y,pch=4, cex=0.5, col="black")
               ~^~
```


157643005-ddress-limitations-and-overshooting-problem-using-ZTM1 (lgu1234) - Win64-Windows-7-VisualStudio-14: OK (2926 of 2927 tests passed, 11 test warnings)

Messages:

 * 11 tests had: AUD diffs.
 * 1 test had: EIO diffs.
 * 1 test had: ESO big diffs.
 * 1 test had: MTR big diffs.
 * 1 test had: Table big diffs.

Failures:

regression Test Summary
 * Passed: 622
 * Failed: 1

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.97%25-yellow.png)


While using the alphabet will come up with a semi-same result, it would be easier to use the preset ones, that use the characters: "I", "l", "1"

This is because in multiple editors they look the same and it's hard to tell the difference.

Examples:
Il1Ill1Illl1ll1Ill
Illll1Ill1Illl1Illll
Ill1lIll1IlllIl11I
(note github displays 1's differently, than other editors)


Tutorial for Pickit3 loading programs on to PIC32: https://www.elprocus.com/pic-microcontroller-programming-using-c-language/


@sidmitra What SDK version are you using?


Shouldn't the email be hello@cdcamp.de for github stuff?


Best rom


So what URL can be used?


He failed to start when I still had a password on my mongo db, so it seems like he does contact it


Or just guthub link?


@mrcasual Can you create a new branch off of `develop` with this (named like `feature/filter-field-picker`), then create a PR into `develop`?


Pinta runs on more than just ubuntu


Changes


@Alex-302 You can use this URL: https://zerodot1.github.io/CoinBlockerLists/list.txt
I'm still working on Gitlab to move to when everything is ready I'll let you know about the new URL.


`return false;`


`return ( err.message === 'Converting circular structure to JSON' );`


Хм... Я сейчас переименовал у себя эти dll и получил ругательства от XR_3DA.exe по поводу отсутствия api-ms-win-core-errorhandling-l1-1-1.dll. Кто с таким сталкивался?


Temporary variable allocation is not necessary.


Nothing about this function is specific to a "seen" array. Reading the description makes me think that whatever this function does is tailored to such an array. Instead,

> Tests if an array contains a search value.


```
arr - input array
```


`contains( arr, searchValue ) {...}`


Баги:
1. Если нажимать на стрелочку "вниз" на колонке "unit price" несколько раз, то будет меняться направление сортировки, но иконка, показывающая направление остаётся неизменной:
![image](https://user-images.githubusercontent.com/12238150/40940764-803aa9ac-6851-11e8-9f41-400e20321715.png)
2. Если включить сортировку по любому полю, а потом применить фильтрацию, то сортировка слетает.
3. Скорее недопонимание чем баг:
![image](https://user-images.githubusercontent.com/12238150/40941368-49d879f0-6853-11e8-8991-af480efcbd4a.png)
В поле поиска есть кнопочка с лупой, она предназначена для запуска поиска. У тебя же поиск происходит всякий раз как пользоватеь вводит новый символ.
Это работает быстро и эффективно на локальном дата сэте, но представь что у тебя при каждом поиске отправляется запрос на сервер и возвращается список заказов каждый раз. Будет много запросов и много ненужного траффика по сети.


Ok, thanks.


horizontal scrolling isn't disabled when only columns w/o data (#2556)

Preview: documentation | landing | table


1. Пункты меню должны быть кликабельны и вести на другие страницы (быть ссылками). То есть нужно помещать текст внутри тега `<a>` - `<li><a href="info.html">ИНФОРМАЦИЯ</a></li>`.
2. Мы будем верстать не все страницы, поэтому на пустые страницы нужно поставить атрибут `href="#"`.


немного табуляция поехала, но это мелочь


> Object-like values **include** `objects` (except for `null`), `array`, `functions`, regular expressions, `Date` objects, and any other JavaScript object to which properties may be bound.


I do not think it is safe to call `apply_autostash()` here already, as that function really expects to be called at the end of an *interactive* rebase for now.

You will want to insert a separate commit to teach `sequencer.c` the trick to know about the different state directories for the different rebase types, first.

Maybe just leave the `apply_autostash()` part for a teeny tiny bit later?


It might be confusing to have one field_group logged but cumulative results without an indication of which specific results correspond. I think we should use a "reduce with index" (`Stream.with_index` passed to reduce is one way), and log something like, "#{inspect __MODULE__}.batch_write X of Y" indicating where we are in the chunks, then logging only the results for this DynamoDB operation. Also, why not simply accumulate the results, which seem only intended for logging, as a straight list of what we get? That would simplify the `accumulate_batch_write_data` function to `++ [batch_write_attempt]`, if I'm not mistaken.


wew lad, that is useless then. will revert


Remove the trailing period.


thx


Есть хорошая практика: если тебе нужен CSS класс, который ты планируешь использовать в JS, то лучше создать новый с приставкой "js".
Т.е. на стилей используем одни классы, а если нужно обратиться к элементу по классу из скрипта, даём ему префикс.
"js-all-orders"


Yeah, correct. Fixed in https://github.com/zulip/zulip-electron/commit/f7696cc04de42cd0a5360c649aeb7a9fc8e5f3a7.


Где-то используешь отступ в 2 пробела, где-то в 4. Нужно единообразие.


Wait...why?

```
$ typeof /.*/ === 'object'
true
```


Немного не понятен прицип выбора: когда используешь ID, а когда классы.


Точно не выборка по тэгу :)


ERC20 dependencies for RankToken


Yikes!  So if I dynamically load a new page, how am I supposed to generate analytics for the new page?


@mwwa Do you remember details about what the failure was here?  I'd like to upstream this but they'll surely want more details about the problems this fixed.


Okay, this test passes, but is misleading. The reason it passes is not because they are invalid inputs, but because they do not have circular references. This should be fixed.


Пока не нашел смысла в этой функциональности. Похоже, что всегда будет отрабатывать "keyup".


@andrew-morris we need to get the package hosted and centralized to avoid folks forking and building cool additions that aren't captured in the core client.


Perhaps move these values to the next test.


@sanex3999 , if you pick your preference of one of three equivalent options
1)
```
            if (!domain) {
```
2)
```
            if (!("~" > domain)) {
```
3)
```
            if (!("~||$HOME" + that["part"] > domain)) {
```
then I can make a new squashed pull request.  Or keep as is?

This is only a matter of style.  No functional difference.

Sorry I added to the open pull request, only then noticed guideline preferring squashed pull requests.


Название функции "updateSidebar" - в центре внимания сущность "sidebar", хотя мы имеем дело со списком заказов.


This will generate an error if `key` is not a property of the map. Is that intentional?
```
iex(1)> a = %{}
%{}
iex(2)> cond do
...(2)> Map.has_key?(a[:x], :y) ->
...(2)> 5
...(2)> true ->
...(2)> 6
...(2)> end
** (BadMapError) expected a map, got: nil
    (stdlib) :maps.is_key(:y, nil)
```


I suggest we remove the master doc URL, as it contains the credentials to the Django admin. Though the data is public in a sense, anyone with it's access can tamper the data.


In general, you should take a more expansive view of "object". Anything to which properties can be bound can have circular references. `null` is an object but cannot have properties.


Почему тут "Orders" с большой буквы, а в "createOrderItem" - "order" с маленькой?


@mapx-

Fyi, [**Platinum Popup**](https://tribulant.com/blog/tag/platinum-popup/), [**Custom Popup Builder**](https://wordpress.org/plugins/m-wp-popup/) and [**WP Super Popup**](https://wordpress.org/plugins/wp-super-popup/) are also blocked if you want to whitelist them.


Постаралась исправить все недочеты. Footer переписала еще раз. Надеюсь лишних пробелов не будет.
Проблема с фильтром по стоимости и сортировкой. Вообще нет идей как делать. Radio-button и checkbox сделала


Аналогично с нечитабельностью.


That is not the correct parameter. We're in C here, so you have to feed `remove_dir_recursively()` the correct absolute path.

We will want a separate enum for the rebase type, anyway, and a function that takes this type and then uses the appropriate parameter to `git_path()` to generate said absolute path.


The problem here is that it fixes it for Kathmandu but breaks it for Accra. This function could generate CRSs that work around the world (source: http://geocompr.robinlovelace.net/reproj-geo-data.html#which-crs-to-use ):

```r
lonlat2UTM = function(lonlat) {
  utm = (floor((lonlat[1] + 180) / 6) %% 60) + 1
  if(lonlat[2] > 0) utm + 32600 else
    utm + 32700
}
```


Блок `recomendations` идет сразу после блока `reason1` как на странице так и в разметке.


TotalPrice желательно не хардкодить ;)


Approaches and Solutions with formatting errors removed


Fix so that you see a cursor only on your own turn


Delete comments 🔥


Везде где встречаются "портянки HTML" нужно что-то придумать..


IBM Cloud [toolchain](https://console.ng.bluemix.net/devops/toolchains/7fec7843-f498-4a4e-a7c3-de4b3767be47?env_id=ibm%3Ayp%3Aus-south "cloud-native-toolchain-tutorial-20180604200709567"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/abc858be-93c4-496b-ad6d-92002a7871cc?env_id=ibm%3Ayp%3Aus-south "sample-cloud-native-toolchain-tutorial-20180604200709567") deployed [sample-cloud-native-toolchain-tutorial-20180604200709567](https://github.com/vpovar/sample-cloud-native-toolchain-tutorial-20180604200709567/releases/tag/deploy-ibm-yp-us-south-bmtutor-us.ibm.com-KPMG-20180604-211326 "deploy-ibm-yp-us-south-bmtutor-us.ibm.com-KPMG-20180604-211326") to [KPMG](https://console.bluemix.net/apps/b4da66cd-6afb-4c5f-939b-40886367e7c3?env_id=ibm:yp:us-south "ibm:yp:us-south:bmtutor@us.ibm.com:KPMG"), including this commit


Функция во многом copypaste "displayProducts". Copypaste - это зло. Старайся переиспользовать код.


Единообразие в написании текста. Где-то всё большими буквами, где-то маленькими.


конструкция if else - выглядит избыточно.
Можно просто:
`return order.id === id;`


Завтра обсудим ещё именование классов :)


Okay, so this command line has to be constructed *in* this function.

As I mentioned earlier, it boils down to `. git-rebase--<backend-type> && git_rebase_<type>`. You need to construct this by using an `strbuf` here, and you need to take care of using an enum (that you still need to define!) to specify the backend type, and then use that to fill in the placeholders in the command line.


check `this gemfile` out


I see. Great that this is fixed!


always try to delete the files that you are not using, like this one 🔥


Зачем делать цикл в котором поднимаешься по дереву элементов от ребёнка к предку?

Ты же в курсе про event delegation, согласно этому, пузырьки сами вызовут событие на нужном таргете, нужно лишь понять что ты имеешь дело именно с тем таргетом!


Можно просто:
`if (value)`


@geeknik - we could add a command line switch to disable them and alter the behavior if passed such that the tool would return `0` if there is an exception. Or, perhaps more valuable would be a new tool (that is not specific to mapbox-streets vector tiles) that could be used for fuzzing and accept specific options that are useful for fuzzing. What do you think?


157643005-ddress-limitations-and-overshooting-problem-using-ZTM1 (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2966 of 2967 tests passed, 11 test warnings)

Messages:

 * 11 tests had: AUD diffs.
 * 1 test had: EIO diffs.
 * 1 test had: ESO big diffs.
 * 1 test had: MTR big diffs.
 * 1 test had: Table big diffs.

Failures:

regression Test Summary
 * Passed: 642
 * Failed: 1

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.97%25-yellow.png)


hey awesome! You'll likely have noted that I've started a new repo ([`flowlayers`](https://github.com/ATFutures/flowlayers)) to get all the code in fully reproducible form. I'll slot that straight in there. Thanks


Can singlenode be implemented using the regular "clustered" plan with a micro_params.json file that includes a single node configuration?


See #1100, there's an instance to update on extra/yaml.factor


Недостаток этого метода (и clientInfoState) в том, что каждый раз, как будет добавляться новая таба (ну заказчик захотел), тебе придётся править код во всех местах, убирая и добавляя классы ко вновь добавленным табам.
Не очень гибкое решение. Можно что-нибудь с этим сделать.


removing this one variable allows the dictionary to work now?


Why repeat default parameter values here? This seems redundant.


Good idea!


Please use single quotes for imports


🥇
Но эффективнее так: Array.prototype.slice.call
Разница в том, что не будет выделено памяти под пустой массив. Но это мелочь, в реальной жизни прироста производительности заметного не будет.


Different fix than what you mean, I think. This avoids the regeneration and recompilation of the dictionary even when nothing has changed. `make -C build ; make -C build` used to even do work on the second make. This avoids that.


And don't judge: that was really impacting my productivity here...


usa una variable que represente el valor del 60000. ejemplo `const oneMinute = 60000` p `const minutes  = 60000;`


utiliza es6, utiliza let en este caso.


When will be the GIMP?


por qué esto fue necesario?


The demo programs and examples that you have no seem to have pretty good coverage of the code as they already are, so maybe we could just modify them and add fuzzing flag that silences the "useless to fuzzing" exceptions and maybe adds in a shim for AFL?  For example, here is a fuzzing harness for FreeType that uses AFL's special persistent mode:

```
#include <ft2build.h>
#include FT_FREETYPE_H

int main(int argc, char *argv[]){
    FT_Library lib = NULL;
    FT_Face face = NULL;
    FT_Init_FreeType(&lib);

    while(__AFL_LOOP(1000)) {
        face = NULL;
        FT_New_Face(lib, argv[1], 0, &face);
        FT_Done_Face(face);
    }

    return 0;
}
```

__AFL_LOOP(1000) is a macro that detects if the program is running under AFL. If it is, the loop will run 1000 times and 1000 different inputs will be fed to the library. After that, the process is torn down then restarted by AFL. This ensures we regularly replace the process to avoid memory leaks. And if the harness is run on it's own, the loop only runs once.


очень-очень строго?


не более одной пустой строки подряд


тут пустая строка не нужна


That'd be great, thanks much for taking the time to discuss this with me!


вместо этого используйте es6 аргументы по умолчанию https://learn.javascript.ru/es-function


В функции `parseInt` желательно ВСЕГДА передавать `radix`, вот почему:

If radix is undefined or 0 (or absent), JavaScript assumes the following:
- If the input string begins with "0x" or "0X", radix is 16 (hexadecimal) and the remainder of the string is parsed.
- If the input string begins with "0", radix is eight (octal) or 10 (decimal).  Exactly which radix is chosen is implementation-dependent.  ECMAScript 5 specifies that 10 (decimal) is used, but not all browsers support this yet.  For this reason always specify a radix when using parseInt.
- If the input string begins with any other value, the radix is 10 (decimal).

Источник: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt


If it's `alreadyDone`, then put an `X` in it or just a `space`.
Move ` ${this.things[i].getName()}` outside from the if block, because we want to add this after each case. It's code duplication.
Short version:
``console.log(`[${this.things[i].alreadyDone() ? 'X' : ' '}] ${this.things[i].getName()}`);``


Issue correspondiente: #28


пока функция выглядит очень путанно


Всё что в case'ах, желательно выности в константы.


сложные методы и куски кода требуют комментариев


Функция похожа на "searchOrder", код можно переиспользовать.


тут лучше смотрится reduce


с учетом написанного слева от ||, написанное справа не имеет смысла


это не нужно делать


Did you delete the camera auto focus/volume update call on purpose?


`} else {`


я не фанат таких вольностей форматирования, сделайте многострочный if здесь и далее


Please pay attention to indentations


array.prototype.some тут сыграет лучше


array.prototype.some


лишняя пустая строка


![](https://github.trello.services/images/mini-trello-icon.png) [navbar.html - enforce padding on mobile to stop it overlapping onto page](https://trello.com/c/4nvTRMPx/21-navbarhtml-enforce-padding-on-mobile-to-stop-it-overlapping-onto-page)


![](https://github.trello.services/images/mini-trello-icon.png) [Research third party plugins](https://trello.com/c/rIrMKDBU/3-research-third-party-plugins)


Gracias, tenía esa duda respecto a las variables


а вот тут пустые строки нужны


Hi Raaja,
Requirements.txt must be a correct zip bundle. You can zip this file to
produce requirements.zip and run that upload command again with "True" as
the 3rd parameter.

On Tue, Jun 5, 2018, 1:03 AM Raajarajan <notifications@github.com> wrote:

> @vietma <https://github.com/vietma> What is the third argument denotes in
> Upload action?
> I am getting below error.
> === Response Code ===
> 412
> === Response Content ===
> Zip Indexing request; file extension must be .zip
>
> python3 cms_netstorage.py -H testxxxxxx-nsu.akamaihd.net -k testxxx -K
> xxxx31zPXl7UacqUxxxxxxxxxxxxxxx -a upload requirements.txt
> /123456/testdir/file.txt test.zip
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/akamai/NetStorageKit-Python/commit/aae4e65af91344e1ca8cf722a761000809843b0a#commitcomment-29234881>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ASRg6BR_41Tqu60SGOEq6IwVOul6JWTQks5t5Uw6gaJpZM4UZQcY>
> .
>


Don't forget the types for loop variables


Created multidev environment [pantheon-d8-composer-demo#ci-2](https://dashboard.pantheon.io/sites/77a78b39-b86c-4f35-8439-2dc87247ef5e#ci-2).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-2-pantheon-d8-composer-demo.pantheonsite.io/)


No ha funcionado


How to find Missing Number in an array 1 to 100


Nope, with this plan we don't want the setup with client + master + data nodes.

We could add a logic that checks that we only have one client node and no master nor data node, but I prefer having a dedicated plan for that which is more meaningful form a user perspective.


Nicely done! Next time put each class into separate `.ts` file


It is, but I want to have the same params that in the `abb.yml` here.


Yup, it is now done inside Scene::Preprocess () too.


Solo estaba probando, la diferencia entre BITCOIN_CONFIG e importarlo de esa manera y quizás mostrar de dónde se obtienen los datos.


It looks like this commit fixed #9.


digo que independiente que funcione o no, teóricamente debería ir en las lineas que te menciono ya que  `cy.clock().then` es una operación asíncrona, por la tanto la corroboración debe hacerse en ese momento del tiempo.


The tests don't work. Unless we find a way to run tests that require an x11 server in Alpine aports in general, we won't get them to work any time soon. So what we have here is dead code, and I would prefer if we would not carry that around.


Hm curious as to what it stores. I'll see what it does if it does anything at all.


Closes #1


cuando hay solo 1 parametro en una arrow function, omitir parentesis. `then((clock) =>` debería ser `then(clock =>`


Cualquier duda acerca de ese push, porfi hablar conmigo. 😊


identar.


I think this had some unintended consequences. https://code-golf.io/scores now shows this for me, with the higher scores towards the bottom:

1st | fraff | 100 | (1 hole) | 10 Jan
2nd | bduggan | 92 | (1 hole) | 19 Oct
3rd | perlpilot | 88 | (1 hole) | 19 Sep
4th | harshdays | 39 | (1 hole) | 23 Apr
5th | philipper905 | 84 | (1 hole) | 10 Apr
6th | mhgump | 72 | (1 hole) | 28 Jan
6th | blakehurlburt | 72 | (1 hole) | 20 Mar
6th | user202729 | 72 | (1 hole) | 11 Apr
6th | fclaude | 72 | (1 hole) | 13 Apr
6th | martica | 72 | (1 hole) | 19 May
6th | Everlone | 72 | (1 hole) | 27 May
6th | AriaOutten | 72 | (1 hole) | 27 May
13th | angetheo | 60 | (1 hole) | 19 Jan


what's the point ? if stdup() fails, better exit() as fast as possible.
that's a command line tool !


It's at NVSL/RocksDB-nvm and NOVA-hackers have write permission.

Thanks,
Andiry

On Mon, Jun 4, 2018 at 7:04 AM, JunghanKim <notifications@github.com> wrote:
> Where can I access the RocksDB-nvm repo?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.


sefewagtreagtes


https://github.com/gpincheiraa/bln-frontend-project1/blob/master/webpack.config.js#L42 esto es provisto acá. No incluir en otras partes.


Don't forget the types for loop variables


Very nice! 👍


Es bestehen weiterhin Probleme mit dem Hinzufügen sowie bearbeiten von Aufträgen // es darf gerne drüber geschaut werden


antes de inicializar la tabla deberia existir una función que limpie los datos actuales. algo así como `Array.from(document.querySelector('tbody tr td')).forEach(column => column.innerHTML = '');`


Ah, ok. I had not seen it there.


dado mi ejemplo, estoy recomendándote que uses programación lo más funcional posible.


Created multidev environment [pantheon-d8-composer-demo#ci-3](https://dashboard.pantheon.io/sites/77a78b39-b86c-4f35-8439-2dc87247ef5e#ci-3).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-3-pantheon-d8-composer-demo.pantheonsite.io/)


you can open a pull request to propose your own way of fixing the issue


Thanks, fixed in 6cffe6d0589c24ac0147bc378aa884285df9b034.

Regarding reviews before merging: I'm making all changes to the Python code as pull requests, unless they are critical bug fixes like a missing comma in `pmb/config/__init__.py` that was preventing `plasma-mobile` from working.

Aports are another story, when I notice on the builder that packages won't build I try to fix that instantly and bypass the review process, so the time where packages are broken in the repo stays as small as possible. This is also how Alpine handles their aports repository.

For both the Python code and aports I would make typo fixes *in comments* directly to `master`, as they should not break anything.

Does that make sense? If not, I'd be happy to discuss this workflow more to improve it and make it more robust.

Thanks guys for going through the commit and commenting it :+1:


![](https://github.trello.services/images/mini-trello-icon.png) [Fix composer dependencies](https://trello.com/c/4lfJpHPh/8-fix-composer-dependencies)


concuerdo en que debería quedar más claro de donde provienen esas palabras. Quizás podría ir un comentario en la parte inicial del código que lo explique o un nombre de variable más explicativo. Si tienes una propuesta de como representarlo mejor bienvenido sea.


@pardo-bsso Can you please look into this bug report related to your code adjustments: https://bugs.limesurvey.org/view.php?id=13738

It looks like the adjustment is missing backwards compatibility. Maybe we can implement this suggested fix:
_....add (validateFiles = TRUE) to RPC method add_response that we can set to false to maintain backward compatibility_ ?


Thanks man your loaders really inspired me


`abstract play();`


Shouldn't this type be in Tds.Ecto instead? :)


I'm using a `.xib`, but thanks for the tip anyway :)


Use single quotes for strings


test


It's a pure string, use single quotes instead of template string


makes for better stack traces


Perfect!


supposed to be the default, but it's not


isparta is no longer maintained; nyc is the istanbul command line utility


peer dep for eslint-plugin-react


eslint-config-airbnb


added to allow emission of source maps in the webpack build process


157643005-ddress-limitations-and-overshooting-problem-using-ZTM1 (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1679 of 1679 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-40.33%25-green.png)


first


this is the shiny new way to run build stuff that needs to be done with dev dependencies; it runs on install if you don't pass --only=production, and before you push to npm


"load"


in the event you need to debug something during the tests, this is pretty nice


Missing spaces inside the object: `{ a: 2, b: 1 }`


"load"~


this complains because babel-polyfill is a dev dependency and not a production one, which is only OK because we are transpiling before production and babel will inline the needful things


needed to bump the minor version here because of features added to the public interface


ps. if Tor is something you use, then I have an even stronger idea that could be made, that is if you would like to test it with your tor set up, no one else has yet used Tor so I've had my idea on hold.


@Lythrayr is right, use of the serial comma here would be grammatically incorrect, furthermore it also looks cleaner without the comma.


god


@johnvbk -- So what's the decision? Is it on or is it off? I can't take the suspense!


Why?


Perfect! 👌


MSDN says of the `lpEnvironment` parameter:

> A pointer to the environment block for the new process. If this parameter is `NULL`, the new process uses the environment of the calling process.

That seems to answer the question.  Of course, "Do I believe the documentation?" and "Is there a catch?" are both valid questions to be asking.


This should be /mostly/ backwards compatible. The breaking changes are that `start()` and `handle()` don't chain any more; instead, they return promises. Semver is even technically OK with that because the major version is 0.


Use empty lines between class functions for better readability.


Use single quotes for strings


This should be /mostly/ backwards compatible. The breaking changes are that start() and handle() don't chain any more; instead, they return promises. Semver is even technically OK with that because the major version is 0.


Thanks


:cry:


I added tests for the fancy new `handle()`-returns-value feature, and reworked the tests to be compatible with async stuff since `start()` and `handle()` don't chain anymore.


Bump minor version because the public API got more features.


Pay attention to indentation. Use `ctrl + shift + f` before save and commit to fix these issues.


Use spaces inside curly: `{ Animal }`


Eso lo experimenté yo jajajaja si hacés click en el error te sale una lista de los disponibles; de todas formas se pueden sobreescribir en el css de material design


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


Do not use space after `super` keyword, but use inside the parentheses to separate parameters.


Please add the following additional part numbers to the patch:

00-5107-01 - 0x4b
00-5103-31 - 0x20
00-5103-01 - 0x4c
00-5108-01 - 0x4c


Ojo si van a hacer modificaciones que en app.css tiene que ser para tooooda la aplicacion; sino tienen que hacer otro css y nombrarlo en routes.js


Ehsan, it's really good! Pay attention to indentations, missing semicolons/spaces, and use single quotes for strings. 👍


This eliminates some absurd number of vulns reported by `npm audit` by updating packages, as well as rejiggering the babel compilation pipeline. By polyfilling less and judicious selection of target platforms, the gzipped UMD compilation size is even reduced by ~200kB, even after the async transition code is added. (Truth in advertising: if you add another couple of years of old browsers, the size goes up to ~4.5kB. This is probably only an issue if you needed iOS < 10.3 support though.)


Nice one smartass


You can take `toString` and `equals` implementations from `AbstractList` from the standard library.


You should use `@classmethod`, and then `cls` instead of hard-coding `User`. The fact that `@staticmethod` even exists is mostly an oversight.

Also, `cls.query.filter_by(id=user_id)` is preferred over `db.session.query...`


Don't forget the types for loop variables.


It looks perfect. 👌


Server-side code for adding the ability to view relative abundance averaged across a group by variable.


Very good!


Missing return type


All the printing code is temporary. None will survive to PR (unless I suppose you want it to)


Looks like this commit broke being able to bazel fetch. Running bazel build works fine.

The error is:

ERROR: Evaluation of query "deps(//source/...)" failed: errors were encountered while computing transitive closure

Aborting evaluation due to com.google.devtools.build.lib.skyframe.TargetMarkerFunction$TargetMarkerFunctionException: com.google.devtools.build.lib.packages.NoSuchTargetException: no such target '//external:python_headers': target 'python_headers' not declared in package 'external' defined by /home/wdecoste/workspaces/envoy/WORKSPACE while evaluating TARGET_MARKER://external:python_headers


copy-paste --> Missing semicolons + missing return types


For what reason?


It should still work. At this point the compiler doesn't care, you simply tell it that a class with this name exists (within the namespace where you make the forward-declaration).


import React from'react';
import { render } from 'react-dom';
import { createStore } from 'redux';

const reducer = (state = 0, action) => {
    switch(action.type) {
        case 'increment':
             return state + 1;
        case 'decrement':
             return state -1;
        case 'reset':
             return state = 0;
        default:
             return state;
    }
}

const store = createStore(reducer);

const Counter = ({ value, onIncrement, onDecrement, onReset }) => {

{value}

        <button onClick={onIncrement}></button>
        <button onClick={onReset}>Reset</button>
        <button onClick={onDecrement}></button>

}

 const r = () => {
     render(
         <Counter
        value={store.getState()}
        onIncrement={() => store.dispatch({type: 'increment'})}
        onDecrement={() => store.dispatch({type: 'decrement'})}
        onReset={() => store.dispatch({type: 'reset'})}
        />,
        document.getElementById('root')
    )

}

r();

store.subscribe(r)


`getCodeBooking(): string {`


Missing type as well


Hmm, failure may be unrelated (although the above points seem worth addressing anyway), found this in log:

```
Jun 03 20:21:18 gravity hydra-queue-runner[893]: terminate called after throwing an instance of 'std::logic_error'
Jun 03 20:21:18 gravity hydra-queue-runner[893]:   what():  basic_string::_M_construct null not valid
Jun 03 20:21:19 gravity postgresql-start[621]: LOG:  could not receive data from client: Connection reset by peer
Jun 03 20:21:19 gravity postgresql-start[621]: LOG:  unexpected EOF on client connection with an open transaction
Jun 03 20:21:19 gravity nix-daemon[941]: unexpected Nix daemon error: interrupted by the user
Jun 03 20:21:19 gravity systemd[1]: hydra-queue-runner.service: Main process exited, code=killed, status=6/ABRT
Jun 03 20:21:20 gravity systemd[1]: hydra-queue-runner.service: Failed with result 'signal'.
Jun 03 20:21:20 gravity systemd[1]: hydra-queue-runner.service: Service hold-off time over, scheduling restart.
Jun 03 20:21:20 gravity systemd[1]: hydra-queue-runner.service: Scheduled restart job, restart counter is at 1.
```

It does upload a variety of files before encountering this, dunno.


Pay attention to indentations


![](https://github.trello.services/images/mini-trello-icon.png) [navbar.html - enforce padding on mobile to stop it overlapping onto page](https://trello.com/c/4nvTRMPx/21-navbarhtml-enforce-padding-on-mobile-to-stop-it-overlapping-onto-page)


![](https://github.trello.services/images/mini-trello-icon.png) [resume.html - clear up excess CSS classes](https://trello.com/c/ycMXEHXG/5-resumehtml-clear-up-excess-css-classes)


Missing return types


Use single quotes for strings


Yea I realized that +2 bytes isn't exactly friendly. Could you do max_depth_ without recursive storage (and without excessive recursive search/computation either)?

Also, removing w_ per that gamma issue thingy would also be good savings. Plenty of avenues to pursue besides just removing depth variables.


Thanks! I suspect the NonNull annotation never was needed; I'll see about cleaning that up on our side.


![](https://github.trello.services/images/mini-trello-icon.png) [resume.html - set picture width to %](https://trello.com/c/8b2lWXXy/13-resumehtml-set-picture-width-to)


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|