[R/berekenLSVIbasis.R:264:1:](https://github.com/inbo/LSVI/blob/100ab1ebdcece789048f9f4841a9f19a879c4286/R/berekenLSVIbasis.R#L264) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>        .data$Habitattype,   #en hier zouden extra gegevens uit Data_habitat moeten toegevoegd worden
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/combinerenVoorwaarden.R:31:1:](https://github.com/inbo/LSVI/blob/100ab1ebdcece789048f9f4841a9f19a879c4286/R/combinerenVoorwaarden.R#L31) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>    #nog testen of Formule bestaat uit EN, OF, haakjes en VoorwaardeID's (en evt. andere tekens die logische berekening toelaten)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/invoercontroleData_soortenKenmerken.R:95:1:](https://github.com/inbo/LSVI/blob/100ab1ebdcece789048f9f4841a9f19a879c4286/R/invoercontroleData_soortenKenmerken.R#L95) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>    Kenmerken <- Data_soortenKenmerken #naamsverandering is omdat code verplaatst is
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/invoercontroleData_soortenKenmerken.R:97:1:](https://github.com/inbo/LSVI/blob/100ab1ebdcece789048f9f4841a9f19a879c4286/R/invoercontroleData_soortenKenmerken.R#L97) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>    #Voorlopig worden enkel soorten gekoppeld, maar er zouden ook genera, ondersoorten, varieteiten,... gekoppeld moeten worden.  Zodra de db hiervoor in orde is: Taxontype.Naam AS Taxontype opslaan en hierop selecteren om de lijst te formatteren;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/invoercontroleData_soortenKenmerken.R:106:46:](https://github.com/inbo/LSVI/blob/100ab1ebdcece789048f9f4841a9f19a879c4286/R/invoercontroleData_soortenKenmerken.R#L106) *style:* **Commented code should be removed.**
```r
<U+200B>      filter(is.na(.data$TaxonTypeId)) %>%  #Taxontype == "Soort"
                                             ^~~~~~~~~~~~~~~~~~~~
```
[R/invoercontroleData_soortenKenmerken.R:122:1:](https://github.com/inbo/LSVI/blob/100ab1ebdcece789048f9f4841a9f19a879c4286/R/invoercontroleData_soortenKenmerken.R#L122) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>    #ophalen lijst voor genera.  Idee is om deze te koppelen aan de soortenlijst, zodra de NBNkeys beschikbaar zijn
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/invoercontroleData_voorwaarden.R:47:1:](https://github.com/inbo/LSVI/blob/100ab1ebdcece789048f9f4841a9f19a879c4286/R/invoercontroleData_voorwaarden.R#L47) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>    #misschien best ook testen dat die indicator-criterium-combinatie in de databank voorkomt?  En of deze voor dat habitattype voorkomt, maar dat best verderop doen
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/invoercontroleData_voorwaarden.R:48:1:](https://github.com/inbo/LSVI/blob/100ab1ebdcece789048f9f4841a9f19a879c4286/R/invoercontroleData_voorwaarden.R#L48) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>    #Voorwaarde ook verplichten?  Anders wel testen of het ok is als het aanwezig is.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/s4_aantal.R:116:1:](https://github.com/inbo/LSVI/blob/100ab1ebdcece789048f9f4841a9f19a879c4286/R/s4_aantal.R#L116) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>setMethod(           #bij deze methode nog rekening houden met eventuele dubbels in de soortenlijst!!!
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/s4_bedekking.R:40:13:](https://github.com/inbo/LSVI/blob/100ab1ebdcece789048f9f4841a9f19a879c4286/R/s4_bedekking.R#L40) *style:* **Commented code should be removed.**
```r
<U+200B>    #       (.data$WaardeMin + .data$WaardeMax) / 2
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/s4_bedekking.R:43:1:](https://github.com/inbo/LSVI/blob/100ab1ebdcece789048f9f4841a9f19a879c4286/R/s4_bedekking.R#L43) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>    #onderstaande is om te testen of het concept werkt, berekening moet nog aangepast worden!!!
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/s4_bedekking.R:59:7:](https://github.com/inbo/LSVI/blob/100ab1ebdcece789048f9f4841a9f19a879c4286/R/s4_bedekking.R#L59) *style:* **Commented code should be removed.**
```r
<U+200B>    # BedekkingMin <- BedekkingGem * 0.9
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/s4_bedekking.R:60:7:](https://github.com/inbo/LSVI/blob/100ab1ebdcece789048f9f4841a9f19a879c4286/R/s4_bedekking.R#L60) *style:* **Commented code should be removed.**
```r
<U+200B>    # BedekkingMax <- BedekkingGem * 1.1
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/selecteerKenmerkenInOpname.R:45:1:](https://github.com/inbo/LSVI/blob/100ab1ebdcece789048f9f4841a9f19a879c4286/R/selecteerKenmerkenInOpname.R#L45) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>      #Hier moet nog toegevoegd worden dat subsoorten opgehaald worden als de soorten zelf niet in de kenmerkenlijst staan (zie berekenAantalSoorten en selecteerSoortenInOpname)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/zzz.R:31:13:](https://github.com/inbo/LSVI/blob/100ab1ebdcece789048f9f4841a9f19a879c4286/R/zzz.R#L31) *warning:* **no visible binding for global variable 'ConnectiePool'**
```r
<U+200B>  poolClose(ConnectiePool)
            ^~~~~~~~~~~~~
```
[inst/tests/testthat/test_berekenLSVIbasis.R:26:3:](https://github.com/inbo/LSVI/blob/100ab1ebdcece789048f9f4841a9f19a879c4286/inst/tests/testthat/test_berekenLSVIbasis.R#L26) *style:* **Commented code should be removed.**
```r
<U+200B># save(Resultaat, file = "inst/vbdata/Resultaat_test.Rdata")
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/tests/testthat/test_berekenLSVIbasis.R:27:3:](https://github.com/inbo/LSVI/blob/100ab1ebdcece789048f9f4841a9f19a879c4286/inst/tests/testthat/test_berekenLSVIbasis.R#L27) *style:* **Commented code should be removed.**
```r
<U+200B># load("inst/vbdata/Resultaat_test.Rdata")
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/tests/testthat/test_berekenLSVIbasis.R:485:1:](https://github.com/inbo/LSVI/blob/100ab1ebdcece789048f9f4841a9f19a879c4286/inst/tests/testthat/test_berekenLSVIbasis.R#L485) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>    #nog testen: "Niet alle te evalueren soorten zijn opgenomen onder Data_soorten\\$Soort_Latijn, er wordt van uitgegaan dat de niet opgenomen soorten niet waargenomen zijn"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/tests/testthat/test_berekenLSVIbasis.R:486:1:](https://github.com/inbo/LSVI/blob/100ab1ebdcece789048f9f4841a9f19a879c4286/inst/tests/testthat/test_berekenLSVIbasis.R#L486) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>    #nog extra tests toevoegen voor genera en habitatsubtypes als de ontwikkeling hiervoor op punt staat
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/tests/testthat/test_s4_Aantal.R:189:1:](https://github.com/inbo/LSVI/blob/100ab1ebdcece789048f9f4841a9f19a879c4286/inst/tests/testthat/test_s4_Aantal.R#L189) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>  #nog toevoegen als het opzoeken van soorten in subniveaus opgelost is: de aggregatie van bedekkingen gebeurt correct
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


Yes, I saw it yesterday evening so I changed it here, too.


@TetianaP End of Line is missing.


Oops, was for https://github.com/phetsims/tasks/issues/930


i'd use '->' just a *nix systems report a link


internal function, this check is not needed.


same here, no check needed


This field is redundant, since requestAutomationPattern already caches the pattern.


The implementations of getValueFromIAccessible and setValueFromIAccessible seem to be equal in AutomationButton and AutomationTextBox. Why not use default method implementations in LegacyAccessible, like in the other interfaces (e.g. Valueable)? You don't need an implementation then in AutomationButton and AutomationTextBox, just the "implements".


This is inconsistent with the other getter/setter which throw a PatternNotFoundException in case of an error. Otherwise, the result is indistinguishable from some element returning "<Empty>" as real value.


//这里主要是进行实例和数据库的驼峰命名转换


=item link ?


Are you referring to the lack of a `ReadContentAsAsync` equivalent, comparable to the above `resultProperty` block?

I think this is short enough that it reads fine, but if you like you can do the same thing:
```
object statusCode =  await ReadStatusCodeAsAsync(info, statusCodePropertyType).ConfigureAwait(false);
statusCodeProperty.SetValue(response, statusCode, null);
isStatusCodeHandled = true;
```

With lines 84-90 inside the method.


//接下来是MyBatis实现持久层的代码


Absent descriptions


If `resultProperty` got renamed, this variable should too.


do we need a `launchWithDirectoryAndRedirect` or something like this for consistency?


This looks good!

Make sure to add the rendered .html output, too.


I believe `private set` should work, just like for `Headers`.


Was this change intended or just a typo?


Absent description.


This looks great, good work!


Looks good


Ah, no, @NateMerritt and I had discussed putting this logic in to the response itself, rather than modifying the request logic.


I dOn'T nEeD tHiS


In that case, you are right: we need the `isStatusCodeHandled` logic here.


Looks like there have been some additional commits to the head branch since #15 was first opened. I'll rebase it for you to ensure it's running the latest tests. (It'll take me a couple of minutes.)


Not included custom params (desirable one more test for custom, this rename to default suffix)


I'm not a native English speaker, but I found [Tabulable](https://www.merriam-webster.com/dictionary/tabulable) in the dictionary, [Tableable](https://www.merriam-webster.com/dictionary/tableable) not...


Move params to consts


Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

- @insertinterestingnamehere were added to conda-forge. Welcome to conda-forge!"
  Go to https://github.com/orgs/conda-forge/invitation see your invitation.

- @insertinterestingnamehere were added to this feedstock maintenance team.
  You should get push access to this feedstock and CI services.

Feel free to join the community [chat room](https://gitter.im/conda-forge/conda-forge.github.io).

NOTE: Please make sure to not push to the repository directly.
      Use branches in your fork for any changes and send a PR.
      More details [here](https://conda-forge.org/docs/conda-forge_gotchas.html#using-a-fork-vs-a-branch-when-updating-a-recipe)


Something looks strange on the long tail plots. The curves are cumulative fractions of people satisfied, they should never decrease. Double check your code and see if you can find a bug, we can debug together if that helps.


thanks for this! @sidforhbc


I'm not sure how thorough the existing tests are, but I see a couple added code-paths reasonably worth exercising:

* `StatusCode` is an `int`
* `StatusCode` is something unhelpful, like a `string`
* The `Headers` property is set properly


@gabemeola Can you provide an example (ideally a [sandbox](https://codesandbox.io)) of what you are talking about? This shouldn't have any effect on a pathless `<Route>`. The `<Router>` sets a default `match` at the root level, so the only time a pathless `<Route>` inherits a `null` parent is if it inside a `<Route children>` that does not match, in which case that should be the expected behavior.


请问你们在做事？？？？


Initial program was in Java


Dear Poggit user,

This is an automatic message from Poggit-CI. Poggit-CI was triggered by this commit, but failed to create builds due to the following error:

You are trying to create too many projects. We only allow creating up to 10
new projects per week.

Contact @SOF3 [on Discord](https://discord.gg/NgHf9jt) to request for extra
quota. We will increase your quota **for free** if you are really trying to
build **your own plugins**, i.e. not forks or copied code.

**Do not try to use another account just to overcome this limit**, or you
may be **banned** from Poggit.

As a result, no builds could be created from this commit. More details might be available for repo admins at [the webhook delivery response log](https://github.com/LegendryDileo/CloudSystem/settings/hooks) — see the webhook starting with `https://poggit.pmmp.io/webhooks.gh.repo` and look for the delivery with ID `c135d738-74a4-11e8-8e16-417e97f45652`.

Shall you need any assistance, you may contact us on [on Discord](https://discord.gg/NgHf9jt), or more publicly, [on GitHub](https://github.com/poggit/support/issues). Commenting on this commit directly will **not** notify any Poggit staff.

Regards,
Poggit Bot (@poggit-bot)
The official Poggit automation account


Please revert this commit... I will clean up the `.text-gamma` entries.


Dear Poggit user,

This is an automatic message from Poggit-CI. Poggit-CI was triggered by this commit, but failed to create builds due to the following error:

You are trying to create too many projects. We only allow creating up to 10
new projects per week.

Contact @SOF3 [on Discord](https://discord.gg/NgHf9jt) to request for extra
quota. We will increase your quota **for free** if you are really trying to
build **your own plugins**, i.e. not forks or copied code.

**Do not try to use another account just to overcome this limit**, or you
may be **banned** from Poggit.

As a result, no builds could be created from this commit. More details might be available for repo admins at [the webhook delivery response log](https://github.com/LegendryDileo/CloudSystem/settings/hooks) — see the webhook starting with `https://poggit.pmmp.io/webhooks.gh.repo` and look for the delivery with ID `e3ac3118-74a4-11e8-9b49-0e3252b18dfb`.

Shall you need any assistance, you may contact us on [on Discord](https://discord.gg/NgHf9jt), or more publicly, [on GitHub](https://github.com/poggit/support/issues). Commenting on this commit directly will **not** notify any Poggit staff.

Regards,
Poggit Bot (@poggit-bot)
The official Poggit automation account


You can delete lines 23 through 30 and line 36 from this file to resolve the merge conflict. It's just a bit of old code that was hanging around.


Your solution for the long tail plots look good, but the others are missing. Make sure to do them!

Also, it looks like you have a merge conflict in your movielens.Rmd file, left you a note on how to fix that.


It is unclear what the cause is, but I experience occasional lag when wifi is used.


Dear Poggit user,

This is an automatic message from Poggit-CI. Poggit-CI was triggered by this commit, but failed to create builds due to the following error:

You are trying to create too many projects. We only allow creating up to 10
new projects per week.

Contact @SOF3 [on Discord](https://discord.gg/NgHf9jt) to request for extra
quota. We will increase your quota **for free** if you are really trying to
build **your own plugins**, i.e. not forks or copied code.

**Do not try to use another account just to overcome this limit**, or you
may be **banned** from Poggit.

As a result, no builds could be created from this commit. More details might be available for repo admins at [the webhook delivery response log](https://github.com/LegendryDileo/CloudSystem/settings/hooks) — see the webhook starting with `https://poggit.pmmp.io/webhooks.gh.repo` and look for the delivery with ID `01d057e6-74a5-11e8-819c-cd9f437006c0`.

Shall you need any assistance, you may contact us on [on Discord](https://discord.gg/NgHf9jt), or more publicly, [on GitHub](https://github.com/poggit/support/issues). Commenting on this commit directly will **not** notify any Poggit staff.

Regards,
Poggit Bot (@poggit-bot)
The official Poggit automation account


This being set to `private` causes `SetValue` to throw an `ArgumentException`.


Dear Poggit user,

This is an automatic message from Poggit-CI. Poggit-CI was triggered by this commit, but failed to create builds due to the following error:

You are trying to create too many projects. We only allow creating up to 10
new projects per week.

Contact @SOF3 [on Discord](https://discord.gg/NgHf9jt) to request for extra
quota. We will increase your quota **for free** if you are really trying to
build **your own plugins**, i.e. not forks or copied code.

**Do not try to use another account just to overcome this limit**, or you
may be **banned** from Poggit.

As a result, no builds could be created from this commit. More details might be available for repo admins at [the webhook delivery response log](https://github.com/LegendryDileo/CloudSystem/settings/hooks) — see the webhook starting with `https://poggit.pmmp.io/webhooks.gh.repo` and look for the delivery with ID `0c73b3fa-74a5-11e8-9359-b619a418a552`.

Shall you need any assistance, you may contact us on [on Discord](https://discord.gg/NgHf9jt), or more publicly, [on GitHub](https://github.com/poggit/support/issues). Commenting on this commit directly will **not** notify any Poggit staff.

Regards,
Poggit Bot (@poggit-bot)
The official Poggit automation account


default parameters never 'override' anything, but it's a good idea to not have them, to avoid bugs where you forget to set them explicitly.


Can you add the rendered movielens.html file when you have a chance so I can check out the plots?


this was a bug! good catch.


number = 6
product = number

for num in range(1, number):
    product *= num

print(product)


Good job


The anatomy of the long tail plots look good, nice work!

One note on the distribution of movie popularity plot in section 2.1: try using x = num_ratings (no y) and geom_histogram (instead of geom_point).


python basics


Can you render and commit the latest movielens.html output so I can check the plots? Thanks!


Looks great, nice work!


OKie dokey.


My profil on linkedin


Created multidev environment [nhtv#ci-125](https://dashboard.pantheon.io/sites/a5faca03-4b4c-4936-95b8-6410ab7b2c55#ci-125).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-125-nhtv.pantheonsite.io/)


Allow-Multiple-AirLoops-in-Airflow-Netwrok-Model (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2972 of 2972 tests passed, 12 test warnings)

Messages:

 * 11 tests had: AUD diffs.
 * 1 test had: BND diffs.

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


ngSubmit을 통해 호출이 정상적으로 처리되지 않음. 확인 필요


Hat jetzt aber nix dem Textmode zu tun?


Just updating this for when you return. I don't see anything in autogen.pl or its output indicating that it does anything with the python script. Can you recheck that? I have run multiple configurations and cannot see anything where that script gets called unless one asks for the bindings to be built.

Also, I went ahead and implemented your simplification - thanks!


Just added movielens.html just now!


@aslushnikov Congratulations on the 1000th commit!


issue-6790-VRP-D-term (EnergyArchmage) - x86_64-MacOS-10.9-clang: OK (2924 of 2929 tests passed, 8 test warnings)

Messages:

 * 8 tests had: AUD diffs.
 * 4 tests had: EIO diffs.
 * 2 tests had: ESO small diffs.
 * 2 tests had: MTR small diffs.
 * 5 tests had: SSZ big diffs.
 * 2 tests had: Table small diffs.

Failures:

regression Test Summary
 * Passed: 618
 * Failed: 5

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.png)


Java game. RxLoader, RxJava in MVP.


Interesting....!! :grin:


segmentInterval seems to better reflect the meaning of the underlying variable.


Created multidev environment [rail-uga-stellar#pr-19](https://dashboard.pantheon.io/sites/05f5afa3-c1ec-448f-915a-9234103f2409#pr-19).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-19-rail-uga-stellar.pantheonsite.io/)


Allow-Multiple-AirLoops-in-Airflow-Netwrok-Model (lgu1234) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


please try to attack it i dont know how can you help me to mine and attack that shitcoin:) But I think its impossible cause of Proof of activity PLC has Proof of stake too 51% maybe dont work;)


Created multidev environment [dgreat#pr-tandem2](https://dashboard.pantheon.io/sites/41cad7fe-472d-43a9-a470-d391b9622376#pr-tandem2).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-tandem2-dgreat.pantheonsite.io/)


It's supposed to be `$Id$` with an uppercase `I`.


Really? Is that new in Net Standard? What's the `ArgumentException`?

It works just fine in LinqPad:

```
 void Main()
{
	var property = GetProperty(typeof(Foo), "Bar").Dump();
	var foo = new Foo();
	property.SetValue(foo, "test", null);
	foo.Dump();
}

// Define other methods and classes here
public class Foo
{
	public string Bar { get; private set; }
}

private static PropertyInfo GetProperty(Type type, string propertyName)
{
	return type.GetRuntimeProperties().FirstOrDefault(x => x.GetMethod != null && !x.GetMethod.IsStatic && string.Equals(x.Name, propertyName, StringComparison.OrdinalIgnoreCase));
}
```


ok understood


let's leave it as rivet-react to go along with the `rivet-*` family


`params[:ids]` has string values (not integers) which can be id or ref, you need to use `ParseIdsRefs.match`


issue-6790-VRP-D-term (EnergyArchmage) - i386-Windows-7-VisualStudio-14: OK (2929 of 2929 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


Fixed in later commit (tomorrow will rebase it)


Aside from using a closure instead of a constructor to store `testSources` and `testDiaSources`, this seems identical to `_ButlerStub`. I certainly could do it this way, but I don't really see the benefit.


seems like you are adding unneeded import?


revert?


Wrong type


The work we did together on the dashboard tester file (index.tsx) didn't get pushed/saved. Apply all the fixes we did to that file.


well, that makes the fetch more or less single threaded right? It's not really an issue, just to clarify


No need to quote me it's ok, I'm not doing it for the glory ^^ but it's nice


Italian translation


Removed LGBT event from "Latest Additions"
Added "Upcoming Accessibility Webinar" to "Latest Additions"
Removed the LGBT event


<!DOCTYPE html>

        <meta charset="utf-8">
        <title> 조준과 반응속도 연습 미니게임 </title>

 조준과 반응속도 연습 미니게임

                             조준연습
                             반응연습

                             점수화면


pushed changes.


empty file


May I know the reason why we keep setValues() methods?


This will be fixed once a new version of Metro is deployed to npm, which should happen today.


I thought it might be an issue with older versions, but VS9/2008's `cl.exe` also understands `-D`, seemingly for definition macros AND flags. So yes, this appears to not be needed.


Fixed in f22c74f509afc4be53943c24d0022b955d94b808 !


Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

- @oliveira-esss were added to conda-forge. Welcome to conda-forge!"
  Go to https://github.com/orgs/conda-forge/invitation see your invitation.

- @oliveira-esss were added to this feedstock maintenance team.
  You should get push access to this feedstock and CI services.

Feel free to join the community [chat room](https://gitter.im/conda-forge/conda-forge.github.io).

NOTE: Please make sure to not push to the repository directly.
      Use branches in your fork for any changes and send a PR.
      More details [here](https://conda-forge.org/docs/conda-forge_gotchas.html#using-a-fork-vs-a-branch-when-updating-a-recipe)


`readonly` ??


BluetoothGattCharacteristic and BluetoothGattDescriptor are part of Android API, not this lib.


forgot `fit`


![](https://github.trello.services/images/mini-trello-icon.png) [KeepSettings command is back](https://trello.com/c/Ql86x91Z/16-keepsettings-command-is-back)


`fit`???


I just moved it all to src/higher.jl. Not sure why it doesn't show up as a rename on here.


`fit`?


![](https://github.trello.services/images/mini-trello-icon.png) [Make lockdown work per-user instead of globally](https://trello.com/c/iudt5Zla/3-make-lockdown-work-per-user-instead-of-globally)


@bnmnetp, `os.uname` is only available on Unix platforms, so this crashes my unit tests. I'll submit a PR changing this to use `sys.platform` instead -- will that work?


![](https://github.trello.services/images/mini-trello-icon.png) [admintoolbox_enable Config Setting](https://trello.com/c/ehPxTfGG/12-admintoolboxenable-config-setting)


Love where this is heading


все же странноватый метод...
я тебе уже в прошлый раз намекал
у тебя этот метод вызывается в коде 4 раза и все 4 раза после него следует строка `train = gets.strip.to_i`
можно было ее добавить в этот же метод....  и это было бы правильно )


wow, right on brother, some serious stuff, i have NOOO idea what's going on

![bitmoji](https://render.bitstrips.com/v2/cpanel/d8e66e64-ec9c-495f-947e-9bfe52d2523f-176b83cd-a6fc-4ba2-8354-576c6fcfed61-v1.png?transparent=1&palette=1&width=246)


Hmm. Ok, thanks for the background info.


Then in the `docker-compose.yml` file, shouldn't we set a  `container_name` value for each service ?


Created multidev environment [wilder#ci-591](https://dashboard.pantheon.io/sites/14808007-3d80-488e-b078-193b788aa4a3#ci-591).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-591-wilder.pantheonsite.io/)


I think the cli should not randomly plot a sinus


@pshrmn Thanks for the quick response! Issue occurs when using this method directly with a static route config (similar route declaration to `react-router-config`).

Example:
```js
const fourOhFour = {
  // No path specified
  exact: false,
  component: NotFound
}

const home = {
  path: '/',
  exact: true,
  component: Home
}

matchPath('/', home) // return: { path: '/', url: '/', isExact: true, params: {} }
// This should match?
matchPath('/blahblah', fourOhFour) // return: undefined
```
 Code SandBox: https://codesandbox.io/s/xp9wzop774

Not sure if this is the intended behavior, but that's what I assumed from the [docs](https://reacttraining.com/react-router/web/api/matchPath)


Created multidev environment [rail-uga-stellar#pr-19](https://dashboard.pantheon.io/sites/05f5afa3-c1ec-448f-915a-9234103f2409#pr-19).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-19-rail-uga-stellar.pantheonsite.io/)


Created multidev environment [rail-uga-stellar#ci-186](https://dashboard.pantheon.io/sites/05f5afa3-c1ec-448f-915a-9234103f2409#ci-186).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-186-rail-uga-stellar.pantheonsite.io/)


<details>

<summary>Submitting the task to Taskcluster failed. Details</summary>

You do not have sufficient scopes. You are missing the following scopes:

{
  "AnyOf": \[
    {
      "AnyOf": \[
        "queue:create\-task:highest:aws\-provisioner\-v1/servo\-docker\-worker",
        "queue:create\-task:very\-high:aws\-provisioner\-v1/servo\-docker\-worker",
        "queue:create\-task:high:aws\-provisioner\-v1/servo\-docker\-worker",
        "queue:create\-task:medium:aws\-provisioner\-v1/servo\-docker\-worker",
        "queue:create\-task:low:aws\-provisioner\-v1/servo\-docker\-worker",
        "queue:create\-task:very\-low:aws\-provisioner\-v1/servo\-docker\-worker",
        "queue:create\-task:lowest:aws\-provisioner\-v1/servo\-docker\-worker"
      \]
    },
    {
      "AnyOf": \[
        "queue:create\-task:aws\-provisioner\-v1/servo\-docker\-worker",
        {
          "AllOf": \[
            "queue:define\-task:aws\-provisioner\-v1/servo\-docker\-worker",
            "queue:task\-group\-id:taskcluster\-github/dMTXXtEWTnqTnsHjqza\_qg",
            "queue:schedule\-task:taskcluster\-github/dMTXXtEWTnqTnsHjqza\_qg/dMTXXtEWTnqTnsHjqza\_qg"
          \]
        }
      \]
    }
  \]
}

You have the scopes:

```
\[
  "assume:project:taskcluster:mozilla\-github\-repository",
  "assume:repo:github.com/servo/servo:pull\-request",
  "notify:email:\*",
  "notify:irc\-channel:\*",
  "notify:irc\-user:\*",
  "queue:create\-task:aws\-provisioner\-v1/github\-worker",
  "queue:create\-task:aws\-provisioner\-v1/github\-worker\-windows",
  "queue:create\-task:aws\-provisioner\-v1/servo",
  "queue:create\-task:aws\-provisioner\-v1/win2012r2",
  "queue:route:garbage.\*",
  "queue:route:index.garbage.\*",
  "queue:route:notify.email.\*",
  "queue:route:notify.irc\-channel.\*",
  "queue:route:notify.irc\-user.\*",
  "queue:scheduler\-id:taskcluster\-github",
  "secrets:get:garbage/\*",
  "secrets:set:garbage/\*"
\]
```

This request requires you to satisfy this scope expression:

```
{
  "AllOf": \[
    {
      "AnyOf": \[
        {
          "AllOf": \[
            "queue:scheduler\-id:taskcluster\-github",
            {
              "AnyOf": \[
                "queue:create\-task:highest:aws\-provisioner\-v1/servo\-docker\-worker",
                "queue:create\-task:very\-high:aws\-provisioner\-v1/servo\-docker\-worker",
                "queue:create\-task:high:aws\-provisioner\-v1/servo\-docker\-worker",
                "queue:create\-task:medium:aws\-provisioner\-v1/servo\-docker\-worker",
                "queue:create\-task:low:aws\-provisioner\-v1/servo\-docker\-worker",
                "queue:create\-task:very\-low:aws\-provisioner\-v1/servo\-docker\-worker",
                "queue:create\-task:lowest:aws\-provisioner\-v1/servo\-docker\-worker"
              \]
            }
          \]
        },
        {
          "AnyOf": \[
            "queue:create\-task:aws\-provisioner\-v1/servo\-docker\-worker",
            {
              "AllOf": \[
                "queue:define\-task:aws\-provisioner\-v1/servo\-docker\-worker",
                "queue:task\-group\-id:taskcluster\-github/dMTXXtEWTnqTnsHjqza\_qg",
                "queue:schedule\-task:taskcluster\-github/dMTXXtEWTnqTnsHjqza\_qg/dMTXXtEWTnqTnsHjqza\_qg"
              \]
            }
          \]
        }
      \]
    }
  \]
}
```
----
method:     createTask
errorCode:  InsufficientScopes
statusCode: 403
time:       2018-06-20T16:47:58.083Z

</details>


these 2 lines should be written at the 1-line
```haskell
getUnitD = fmap getUd
```
instead.  Same idea for all cases of a `Maybe` datatype.


@iopietro Here I have prepared the code for Enable (Disable) the new mechanics of the embassy.

You only need to enclose this code in:

```php
if(NEW_FUNCTIONS_EMBASSY_MECHANICS == false) {
    echo "old code (it needs to be restored because now only the new mechanics work)";
} else {
    echo "new code (New Alliance & Embassy Mechanics https://github.com/Shadowss/TravianZ/wiki/New-Alliance-&-Embassy-Mechanics)";
}
```


What's the motive for putting `cursor` in the test cases instead of in `setUp`?


Sorry, we are NOT going to stop using icons in menus. Lots of people objected when GNOME tried to disable them unconditionally in an early version of GTK 3.10 and GNOME then changed that to deprecated rather than removed.

We are not GNOME, and the GNOME HIG ("Human Interface Guidelines") for GNOME 3 play no role in our decisions.


Created multidev environment [rail-uga-stellar#pr-16](https://dashboard.pantheon.io/sites/05f5afa3-c1ec-448f-915a-9234103f2409#pr-16).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-16-rail-uga-stellar.pantheonsite.io/)


Mfw I added a new error


```haskell
getUd a = a ^. defn : getNP (a ^. term)
```
is more efficient.


Confused the commit message with another project, correct message:

_Added span tag for circuit breaker._


We can piggy back this into the final update KIP probably, but that means we'd better extract this part out of the current PR so that it does not need to be blocked until the KIP is adopted.


<details>

<summary>Submitting the task to Taskcluster failed. Details</summary>

You do not have sufficient scopes. You are missing the following scopes:

{
  "AnyOf": \[
    {
      "AnyOf": \[
        "queue:create\-task:highest:aws\-provisioner\-v1/servo\-docker\-worker",
        "queue:create\-task:very\-high:aws\-provisioner\-v1/servo\-docker\-worker",
        "queue:create\-task:high:aws\-provisioner\-v1/servo\-docker\-worker",
        "queue:create\-task:medium:aws\-provisioner\-v1/servo\-docker\-worker",
        "queue:create\-task:low:aws\-provisioner\-v1/servo\-docker\-worker",
        "queue:create\-task:very\-low:aws\-provisioner\-v1/servo\-docker\-worker",
        "queue:create\-task:lowest:aws\-provisioner\-v1/servo\-docker\-worker"
      \]
    },
    {
      "AnyOf": \[
        "queue:create\-task:aws\-provisioner\-v1/servo\-docker\-worker",
        {
          "AllOf": \[
            "queue:define\-task:aws\-provisioner\-v1/servo\-docker\-worker",
            "queue:task\-group\-id:taskcluster\-github/WJy\-Bto3TM\-M0M4eUQlp1g",
            "queue:schedule\-task:taskcluster\-github/WJy\-Bto3TM\-M0M4eUQlp1g/WJy\-Bto3TM\-M0M4eUQlp1g"
          \]
        }
      \]
    }
  \]
}

You have the scopes:

```
\[
  "assume:project:taskcluster:mozilla\-github\-repository",
  "assume:repo:github.com/servo/servo:pull\-request",
  "notify:email:\*",
  "notify:irc\-channel:\*",
  "notify:irc\-user:\*",
  "queue:create\-task:aws\-provisioner\-v1/github\-worker",
  "queue:create\-task:aws\-provisioner\-v1/github\-worker\-windows",
  "queue:create\-task:aws\-provisioner\-v1/servo",
  "queue:create\-task:aws\-provisioner\-v1/win2012r2",
  "queue:route:garbage.\*",
  "queue:route:index.garbage.\*",
  "queue:route:notify.email.\*",
  "queue:route:notify.irc\-channel.\*",
  "queue:route:notify.irc\-user.\*",
  "queue:scheduler\-id:taskcluster\-github",
  "secrets:get:garbage/\*",
  "secrets:set:garbage/\*"
\]
```

This request requires you to satisfy this scope expression:

```
{
  "AllOf": \[
    {
      "AnyOf": \[
        {
          "AllOf": \[
            "queue:scheduler\-id:taskcluster\-github",
            {
              "AnyOf": \[
                "queue:create\-task:highest:aws\-provisioner\-v1/servo\-docker\-worker",
                "queue:create\-task:very\-high:aws\-provisioner\-v1/servo\-docker\-worker",
                "queue:create\-task:high:aws\-provisioner\-v1/servo\-docker\-worker",
                "queue:create\-task:medium:aws\-provisioner\-v1/servo\-docker\-worker",
                "queue:create\-task:low:aws\-provisioner\-v1/servo\-docker\-worker",
                "queue:create\-task:very\-low:aws\-provisioner\-v1/servo\-docker\-worker",
                "queue:create\-task:lowest:aws\-provisioner\-v1/servo\-docker\-worker"
              \]
            }
          \]
        },
        {
          "AnyOf": \[
            "queue:create\-task:aws\-provisioner\-v1/servo\-docker\-worker",
            {
              "AllOf": \[
                "queue:define\-task:aws\-provisioner\-v1/servo\-docker\-worker",
                "queue:task\-group\-id:taskcluster\-github/WJy\-Bto3TM\-M0M4eUQlp1g",
                "queue:schedule\-task:taskcluster\-github/WJy\-Bto3TM\-M0M4eUQlp1g/WJy\-Bto3TM\-M0M4eUQlp1g"
              \]
            }
          \]
        }
      \]
    }
  \]
}
```
----
method:     createTask
errorCode:  InsufficientScopes
statusCode: 403
time:       2018-06-20T16:50:15.138Z

</details>


Fix #12


OK outdated are they ;) I see.


This issue has been resolved in the official DCMTK repo in the following commits:
* http://git.dcmtk.org/?p=dcmtk.git;a=commit;h=54755ae134d23a2a5e301436d595f8b89ff1a896
* http://git.dcmtk.org/?p=dcmtk.git;a=commit;h=6f08a4c66270aa93d01e304e48948edc90bf652b


We should remove this case from the tests entirely.  Arrays are not supposed to be constructable from vectors since array size needs to be known at compile time.  When in debug mode -- in order to get the full level of debug support that I need while ensuring all of the necessary functionality is in place -- I implement arrays using vectors.  We should probably actively disable the extra functionality that involves, and certainly not test for it (I would think, at least...)


dossier boris.md


Great, looks good!


Читабельней будет не 'H', а :hit
Также и с другим выбором


Created multidev environment [wilder#ci-592](https://dashboard.pantheon.io/sites/14808007-3d80-488e-b078-193b788aa4a3#ci-592).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-592-wilder.pantheonsite.io/)


What I did for the icons I added to M-S-D's display popup menu was to make the icon loading conditional on the value of the "menus-have-icons" gsettings key. I packed a box into the menuitem (which can have only one child), and into the box packed the image conditionally and the label unconditionally, using this code in msd-xrandr.manager.c:
```
        /*Load the icon unless the user has icons in menus turned off*/
        icon_settings = g_settings_new ("org.mate.interface");
        if (g_settings_get_boolean (icon_settings, "menus-have-icons")){
            gtk_container_add (GTK_CONTAINER (box), image);
            }
        gtk_container_add (GTK_CONTAINER (box), label);
        gtk_container_add (GTK_CONTAINER (item), box);

```
To see how it works, open mate-control-center, go to "display" and set it to add a tray icon. Turn icons in menus on and off, popping up this menu each time. You will see that this can indeed be user selectable


I don't think you want this here?


![](https://github.trello.services/images/mini-trello-icon.png) [Per class damage control config](https://trello.com/c/h8rukZnV/9-per-class-damage-control-config)


@rachmadaniHaryono I made this change to get rid of this constant nuisance. Is there any better way to fix the continuous build breaks


Get rid of this and pass in the @Autowired ConceptService below.


![](https://github.trello.services/images/mini-trello-icon.png) [Player Stats Kills/Teamkills/Deaths](https://trello.com/c/cBLZufnc/5-player-stats-kills-teamkills-deaths)


Look for a linter rule that warns when you've imported something not used.

For example:

import {XXXX} from 'some_module';

But XXXX is never used in that file.


when you're done with "poppler-qt4-mac" here, would you please push it into macports-ports main? there are 2 ports that rely on it: py*-poppler-at4 and texworks. Those ports are currently broken, and you can be their savior! Thx!


Removing poppler-qt4-mac breaks 2 ports: py*-poppler-qt4 and texworks. I think @kencu has a fix for this breakage in one of his repos, and hopefully he'll push it into main macports-ports soonish.


@szymczdm right, I had forgotten already...


Allow-Multiple-AirLoops-in-Airflow-Netwrok-Model (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1681 of 1682 tests passed, 0 test warnings)

Failures:

EnergyPlusFixture Test Summary
 * Passed: 642
 * OTHER_FAULT: 1

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-40.1%25-green.png)


@olabini Does this make sense?


I understand the limitation of the cache slot size. But why limiting the number of slot and so the overall size of the cache? I fail to understand how it can solve timing issue unless by pure luck, it could only increase the card read execution time.


This: "Note, though, that the long-term public key has its own expiration time."


Pas eu le temps de tout regarder encore mais il faut revert a priori : ça ne fixe pas, ça casse :
- l'url JO du PJL transparence devient celle du PJLO
- on ne veut pas d'étape commission pour la lecture définitive

(mes derniers commits corrigeaient justement ces deux problèmes :p )


Такого быть не должно и следующей стрчки тоже


logger.error("тут твоё сообщение об ошибке", e); вот так


"What Up!!!!!"- Alex


vérifié trop vite, j'ai rien dit pardon ;)
faut que je review ça en prenant plus le temps


Hello Peeps- Alex


It says unable to deduce type of mock when i remove it from mockbean.


R code


👍  typo


Note:
Internally, Abstract Factory use Factory design pattern for creating objects. But it can also use Builder design pattern and prototype design pattern for creating objects. It completely depends upon your implementation for creating objects.

Abstract Factory can be used as an alternative to Facade to hide platform-specific classes.

When Abstract Factory, Builder, and Prototype define a factory for creating the objects, we should consider the following points :

Abstract Factory use the factory for creating objects of several classes.

Builder use the factory for creating a complex object by using simple objects and a step by step approach.

Prototype use the factory for building a object by copying an existing object.


Much better!


Removed in `master`.


I'm concerned about the performance impact of this safety check, done just "in case" someone later decides to json.dump() the context. Isn't that a misplaced fix?
Wouldn't make sense to fix the root injection of non-json-safe content, or the root cause of the crash, i.e. the place where the context is dumped? Either option would seem much cheaper...

/cc @antonylesuisse


@smiths This note isn't in the generated/stable PDF - do I add it or just not worry about making this change?


I assume you're worry here is that length will have to traverse the list? For the most part these lists should be less than 5 elements and a very high percentage of the time will have exactly 0 or 1 elements so I'm inclined to keep the length call for clarity. Though maybe a macro for ?IS_EMPTY_LIST vs ?IS_NON_EMPTY_LIST with the pattern match or equality check would be fine?


The data used for this analysis consisted of a dataset of fully completed survey responses and another data set that did not have full response. In the completed dataset, the number of responses was totaled at 10,000 responses with the following categories: salary, age, education level, model of primary car, zip code, credit limit, and brand of computer. While the incomplete survey had only 5,000 responses with the same categories yet the brand of computer attribute did not have any pertinent customer information. Therefore, the process of this analysis consisted of developing and training a model from the completed survey data to predict customer computer preference in the incomplete survey data. The first step in the both data sets was inspecting the data for missing values and transforming specific attributes into data that can be analyzed. This including transitions the attributes type of cars, zip code, and computer brand to factors and changing the attribute education level to ordinal. Then, I proceeded to develop testing and training datasets to determine the best predictive model utilizing the algorithms, K Nearest Neighbor (KNN) and Random Forrest. In building this model, the complete survey data were split into 75% of data (training) and 25$ (testing). Each of the algorithms were applied to the Complete Survey data and the training and testing data sets in order to build an effective model to more accurately predict customer computer brand


thanks for reply


@swiss42 If you move these consts into the OrderRequest itself, you can refer to them here instead of having 2 sources of truth


get it


Thanks.  The polarization corrections are applied to the data directly in
prime and cxi.merge, since they do not (yet) use reflection tables.  No
lorentz correction is computed.  I like how you are adding your computation
as a new column in the table, that seems sensible.

On Wed, Jun 20, 2018 at 1:05 AM, James Parkhurst <notifications@github.com>
wrote:

> Hi Aaron,
>
> No problem! I've been doing a little bit of work on profile modelling and
> integration for synchrotron stills and I've been looking at the nXDS and
> Eval papers which both mentioned a lorentz correction. I've added the
> equation for the lorentz correction given in the nXDS paper but the
> polarization correction is the same as in the rotation case I think.
> Currently, these are not used in the main dials processing for stills, only
> in my experimental program "dials.potato" in dials_scratch! Currently, in
> my script, after integrating the reflections, I compute the lp correction
> and add it as a column in the output of the reflection data as done for
> rotation data. How are the corrections applied in prime and cxi.merge?
>
> James
> ________________________________
> From: Aaron S. Brewster <notifications@github.com>
> Sent: 19 June 2018 19:46:48
> To: dials/dials
> Cc: Parkhurst, James (DLSLtd,RAL,LSCI); Author
> Subject: Re: [dials/dials] Added lp correction for stills (e24d25d)
>
>
> Hi @jmp1985<https://github.com/jmp1985>, can you provide some context
> about this commit?
>
> * What is the formula and/or reference you are using to apply polarization
> correction for stills?
> * How does this compare to how PRIME and cxi.merge apply polarization
> correction? See https://github.com/cctbx/cctbx_project/blob/master/
> prime/postrefine/postrefine.py#L103-L111 and https://github.com/cctbx/
> cctbx_project/blob/master/xfel/command_line/cxi_merge.py#L1201-L1228.
> * Reading integrator.py, compute_corrections is not called by
> IntegratorStills, so for stills processing it is moot. So what is the use
> case for this?
>
> Thanks, just trying to understand :)
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub<https://github.com/
> dials/dials/commit/e24d25d204bc5148fb8dd65404d857c63b4f2f64#commitcomment-
> 29421836>, or mute the thread<https://github.com/
> notifications/unsubscribe-auth/ACI1YYQNGkLgtZkaRv9JI3aRgCDAl6
> xLks5t-UcXgaJpZM4UuCp9>.
>
> --
> This e-mail and any attachments may contain confidential, copyright and or
> privileged material, and are for the use of the intended addressee only. If
> you are not the intended addressee or an authorised recipient of the
> addressee please notify us of receipt by returning the e-mail and do not
> use, copy, retain, distribute or disclose the information in or attached to
> the e-mail.
> Any opinions expressed within this e-mail are those of the individual and
> not necessarily of Diamond Light Source Ltd.
> Diamond Light Source Ltd. cannot guarantee that this e-mail or any
> attachments are free from viruses and we cannot accept liability for any
> damage which you may sustain as a result of software viruses which may be
> transmitted in or with the message.
> Diamond Light Source Limited (company no. 4375679). Registered in England
> and Wales with its registered office at Diamond House, Harwell Science and
> Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/dials/dials/commit/e24d25d204bc5148fb8dd65404d857c63b4f2f64#commitcomment-29428378>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AM2OygN6cyvKMhtx71LiYpVieRCKiGssks5t-gIzgaJpZM4UuCp9>
> .
>


isn't the `refdb` in the `SystemInformation` ?  Shouldn't you be getting it from there?


Created multidev environment [rail-uga-stellar#ci-189](https://dashboard.pantheon.io/sites/05f5afa3-c1ec-448f-915a-9234103f2409#ci-189).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-189-rail-uga-stellar.pantheonsite.io/)


See https://github.com/mate-desktop/mate-panel/pull/820
please review and test, this makes loading menu icons conditional on whether you have the icons turned on or off. Affects everything changed by the commit in question here, does not affect main menu menuitems or a few outliers I will try to track down


```
System.ArgumentException : Property set method not found.
   at System.Reflection.RuntimePropertyInfo.SetValue(Object obj, Object value, BindingFlags invokeAttr, Binder binder, Object[] index, CultureInfo culture)
   at System.Reflection.RuntimePropertyInfo.SetValue(Object obj, Object value, Object[] index)
   at Faithlife.WebRequests.Json.AutoWebServiceRequest`1.<HandleResponseCoreAsync>d__6.MoveNext() in C:\Code\FaithlifeWebRequests\src\Faithlife.WebRequests\Json\AutoWebServiceRequest.cs:line 87
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()
   at Faithlife.WebRequests.WebServiceRequestBase`1.<HandleResponseAsync>d__6.MoveNext() in C:\Code\FaithlifeWebRequests\src\Faithlife.WebRequests\WebServiceRequestBase.cs:line 278
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()
   at Faithlife.WebRequests.WebServiceRequestBase`1.<GetResponseAsync>d__1.MoveNext() in C:\Code\FaithlifeWebRequests\src\Faithlife.WebRequests\WebServiceRequestBase.cs:line 165
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at Faithlife.WebRequests.Tests.EchoTests.<EchoExplicitStatusResponse>d__6.MoveNext() in C:\Code\FaithlifeWebRequests\tests\Faithlife.WebRequests.Tests\EchoTests.cs:line 144
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at NUnit.Framework.Internal.AsyncInvocationRegion.AsyncTaskInvocationRegion.WaitForPendingOperationsToComplete(Object invocationResult)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.RunAsyncTestMethod(TestExecutionContext context)
```


Created multidev environment [wilder#ci-593](https://dashboard.pantheon.io/sites/14808007-3d80-488e-b078-193b788aa4a3#ci-593).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-593-wilder.pantheonsite.io/)


Yes, we need this note in the generated/stable version.  The note contains the rationale information for selecting the minimum and maximum d values.  If we don't retain the explanation, then in the future the numbers will appear as if they aren't based on anything.  We have discussed previously that the design of Drasil should include a way to capture rationale information.  There isn't currently a mechanism designed into Drasil, but there will be in the future.  For now, keep the text so that we will be ready for future language improvements.


Changes


nit: Notice how the delegate report warning is personal? It uses the word "your", which I think gives the reader a clear sense that this is something that is *their* responsibility.

I might consider rewording this a bit. Maybe this: "Please submit results for this competition. You can do so <here>" ?

Whatever you think is best!


perfectly match


Version 10.0 was outdated


You don't like f-strings? :)


I'll look into making the icon loading conditional on user having menus in icons turned on later today


There is an issue with this commit https://github.com/buefy/buefy/issues/746


![screen shot 2018-06-20 at 1 16 18 pm](https://user-images.githubusercontent.com/289994/41673833-269d018c-748c-11e8-8a7c-f72a3dcabc8d.png)
I recommend using zsh + oh my ssh + conda to manage environments  - no need to use python3 if you can clearly see what's going on and command prompt.  because you're fixing one problem - it's going to cascade when other programs don't work and you have to chase tail around fixing other things.


hello


![](https://github.trello.services/images/mini-trello-icon.png) [Help command](https://trello.com/c/1N1Elx69/4-help-command)


Actually, @smiths, this whole region is missing in the gen code...

![missingfromgen](https://user-images.githubusercontent.com/35857611/41673870-43e17f20-748c-11e8-8d2b-8d4530c5402d.JPG)

...and Figure 3 exists here before the output data constraints table (which is in the gen code).

![fig3](https://user-images.githubusercontent.com/35857611/41673949-79bd06aa-748c-11e8-9eb5-dfef54203429.png)

Should I add the table and the picture, too?


This makes the mocking very explicit: "in this test method, I'm mocking this specific thing".

As far as what its testing and what it is mocking, it is no different from what your previous test was.


@AnnZhouCcc 'Elligibility' is still mis-spelled. It only has one 'l' between E and i.


Making it a `MagicMock` spec'ed on the Butler means it will appear to behave like a butler, so if other Butler methods get called, they'll be available.


I think this URL needs to be the HTTPS URL else I get the following error:
```Cannot validate default version.
hudson.plugins.git.GitException: Command "git ls-remote -h git@github.com:Accenture/adop-pluggable-scm-jenkinsfile.git" returned status code 128:
stdout:
stderr: Unable to negotiate with 192.30.253.113 port 22: no matching key exchange method found. Their offer: curve25519-sha256@libssh.org,ecdh-sha2-nistp256,ecdh-sha2-nistp384,ecdh-sha2-nistp521,diffie-hellman-group-exchange-sha256

fatal: Could not read from remote repository.```


###Lipsum `Realy?```


to fix 3d tiles test add ` #if defined(DEBUG)` before use `showOutline`


But that means that it is necessary functionality in debug mode, right? My instinct would be that if we need this constructor (`emp::array(std::vector)`) in debug mode we should have a test that confirms that it works in debug mode. I'm open to being convinced otherwise, though.


man, I hope this package doesn't double in size every major release ....


This change might have some side effects, but I needed to reduce the specificity of the `.btn` border.


If unexpected Butler methods get called, they'll return a... default-initialized Mock object? Seems like the test would fail anyway.


bom nome pasofk


Is stream-output support coming soon?


@wz1000 are you sure this is safe? There was a reason for using this weird `getCanonicalFileNameSafe`, IIRC it should not fail if the file doesn't exist or something like that.


This resolves #524


[R/plotting-colours.R:89:1:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-colours.R#L89) *style:* **Lines should not be more than 100 characters.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-colours.R:89:32:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-colours.R#L89) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                              ~^~~
```
[R/plotting-colours.R:89:35:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-colours.R#L89) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                 ~^~~
```
[R/plotting-colours.R:89:41:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-colours.R#L89) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                        ^
```
[R/plotting-colours.R:106:1:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-colours.R#L106) *style:* **Lines should not be more than 100 characters.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-colours.R:106:32:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-colours.R#L106) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                              ~^~~
```
[R/plotting-colours.R:106:35:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-colours.R#L106) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                 ~^~~
```
[R/plotting-colours.R:106:41:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-colours.R#L106) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                        ^
```
[R/plotting-colours.R:131:1:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-colours.R#L131) *style:* **Lines should not be more than 100 characters.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-colours.R:131:32:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-colours.R#L131) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                              ~^~~
```
[R/plotting-colours.R:131:35:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-colours.R#L131) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                 ~^~~
```
[R/plotting-colours.R:131:41:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-colours.R#L131) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                        ^
```
[R/plotting-colours.R:284:75:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-colours.R#L284) *style:* **Put spaces around all infix operators.**
```r
    isFac <- any(raster::is.factor(grobToPlot)) & all(na.omit(grobToPlot[]%%1)==0)
                                                                         ~^~~
```
[R/plotting-colours.R:284:79:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-colours.R#L284) *style:* **Put spaces around all infix operators.**
```r
    isFac <- any(raster::is.factor(grobToPlot)) & all(na.omit(grobToPlot[]%%1)==0)
                                                                             ~^~~
```
[R/plotting-helpers.R:1023:44:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L1023) *style:* **Commas should always have a space after.**
```r
          grobToPlot <- grobToPlot[polySeq,]
                                           ^
```
[R/plotting-helpers.R:1028:38:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L1028) *style:* **Commas should always have a space after.**
```r
        grobToPlot <- grobToPlot[a[1,],]
                                     ^
```
[R/plotting-helpers.R:1028:40:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L1028) *style:* **Commas should always have a space after.**
```r
        grobToPlot <- grobToPlot[a[1,],]
                                       ^
```
[R/plotting-helpers.R:1291:41:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L1291) *style:* **Put spaces around all infix operators.**
```r
            if (all(na.omit(grobToPlot[]%%1)==0)) {
                                       ~^~~
```
[R/plotting-helpers.R:1291:45:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L1291) *style:* **Put spaces around all infix operators.**
```r
            if (all(na.omit(grobToPlot[]%%1)==0)) {
                                           ~^~~
```
[R/plotting-helpers.R:1380:1:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L1380) *style:* **Lines should not be more than 100 characters.**
```r
    grid.rect(x = 0, height = unit(1 + needsNewTitle * inherits(grobToPlot, "Raster") * 0.20 / (nRows / 2), "npc"),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2511:1:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L2511) *style:* **Lines should not be more than 100 characters.**
```r
#'          jitter(sort(rbeta(nPoints, betaPar, betaPar) * (maxY - minY) + minY, decreasing = TRUE)),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2589:1:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L2589) *style:* **Variable or function name should be lowerCamelCase.**
```r
thin.SpatialPolygons <- function(x, tolerance = NULL, returnDataFrame = FALSE, minCoordsToThin = 0,
^~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2610:8:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L2610) *style:* **Commented code should be removed.**
```r
      #xyOrd[["out"]] <- xyOrd[["out"]][thinRes, ]# thin line
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2633:50:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L2633) *style:* **Commas should always have a space after.**
```r
            dat <- x@data[as.numeric(names1) + 1,]
                                                 ^
```
[R/plotting-helpers.R:2634:14:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L2634) *style:* **Commented code should be removed.**
```r
            #row.names(dat) <- as.character(seq_len(length(xyOrd)))
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2666:1:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L2666) *style:* **Variable or function name should be lowerCamelCase.**
```r
thin.default <- function(x, tolerance, returnDataFrame, minCoordsToThin, ...) {
^~~~~~~~~~~~
```
[R/plotting-helpers.R:2701:3:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L2701) *style:* **Variable or function name should be lowerCamelCase.**
```r
  IDs <- tryCatch(unlist(lapply(ordSeq, function(xx) {
  ^~~
```
[R/plotting-helpers.R:2726:7:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L2726) *style:* **Commented code should be removed.**
```r
    # Polygons <- rep(rep(seq(numPolygons), numPolygon), idLength$V1) # sequential numbering
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2727:5:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L2727) *style:* **Variable or function name should be lowerCamelCase.**
```r
    Polygons <- rep(rep(IDs, numPolygon), idLength$V1) # actual ID labelling
    ^~~~~~~~
```
[R/plotting-helpers.R:2728:5:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L2728) *style:* **Variable or function name should be lowerCamelCase.**
```r
    Polygon <- rep(unlist(lapply(numPolygon, seq)), idLength$V1)
    ^~~~~~~
```
[R/plotting-helpers.R:2735:36:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L2735) *style:* **Commas should always have a space after.**
```r
    return(data.frame(lat = xyOrd[,1], long = xyOrd[,2], order = orders,
                                   ^
```
[R/plotting-helpers.R:2735:54:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L2735) *style:* **Commas should always have a space after.**
```r
    return(data.frame(lat = xyOrd[,1], long = xyOrd[,2], order = orders,
                                                     ^
```
[R/plotting-helpers.R:2737:1:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L2737) *style:* **Lines should not be more than 100 characters.**
```r
                      #group = paste0(as.character(Polygons), ".", as.character(Polygon)))) # the actual fortify
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2740:40:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L2740) *style:* **Commas should always have a space after.**
```r
    out <- setDT(data.frame(x = xyOrd[,1], y = xyOrd[,2], groups = groups))
                                       ^
```
[R/plotting-helpers.R:2740:55:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L2740) *style:* **Commas should always have a space after.**
```r
    out <- setDT(data.frame(x = xyOrd[,1], y = xyOrd[,2], groups = groups))
                                                      ^
```
[R/plotting-helpers.R:2755:1:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L2755) *style:* **Lines should not be more than 100 characters.**
```r
    which(polygon@data$Shape_Area>(sort(polygon@data$Shape_Area, decreasing = TRUE)[maxNumPolygons]))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2755:34:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L2755) *style:* **Put spaces around all infix operators.**
```r
    which(polygon@data$Shape_Area>(sort(polygon@data$Shape_Area, decreasing = TRUE)[maxNumPolygons]))
                                ~^~
```
[R/plotting-helpers.R:2755:35:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L2755) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    which(polygon@data$Shape_Area>(sort(polygon@data$Shape_Area, decreasing = TRUE)[maxNumPolygons]))
                                  ^
```
[R/plotting-helpers.R:2778:26:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-helpers.R#L2778) *style:* **Commas should always have a space after.**
```r
          totalAvailable," polygons in this view. See options('reproducuble.maxNumPolygons')")
                         ^
```
[R/plotting-other.R:202:48:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-other.R#L202) *style:* **Put spaces around all infix operators.**
```r
  if (any(raster::is.factor(ras1)) & all(ras1[]%%1==0)) {
                                              ~^~~
```
[R/plotting-other.R:202:51:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-other.R#L202) *style:* **Put spaces around all infix operators.**
```r
  if (any(raster::is.factor(ras1)) & all(ras1[]%%1==0)) {
                                                 ~^~~
```
[R/plotting-other.R:251:30:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-other.R#L251) *style:* **Commas should always have a space after.**
```r
    if (sum(corners$coords[1,] - corners$coords[2,]) %==% 0) {
                             ^
```
[R/plotting-other.R:251:51:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-other.R#L251) *style:* **Commas should always have a space after.**
```r
    if (sum(corners$coords[1,] - corners$coords[2,]) %==% 0) {
                                                  ^
```
[R/plotting-other.R:335:27:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-other.R#L335) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
    if (length(row) == 0) { # above the plot
                          ^
```
[R/plotting-other.R:338:30:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting-other.R#L338) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
    if (length(column) == 0) { # above the plot
                             ^
```
[R/plotting.R:308:6:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting.R#L308) *style:* **Commented code should be removed.**
```r
    #whFrame <- grep(scalls, pattern = "^Plot|^quickPlot::Plot")
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting.R:318:8:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/R/plotting.R#L318) *style:* **Commented code should be removed.**
```r
      #dotObjs <- mget(dotNames[!noName], envir = plotFrame, inherits = TRUE)
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-clickExtent.R:10:3:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/tests/testthat/test-clickExtent.R#L10) *style:* **Variable or function name should be lowerCamelCase.**
```r
  Sr1 <- Polygon(coords1)
  ^~~
```
[tests/testthat/test-clickExtent.R:11:3:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/tests/testthat/test-clickExtent.R#L11) *style:* **Variable or function name should be lowerCamelCase.**
```r
  Srs1 <- Polygons(list(Sr1), "s1")
  ^~~~
```
[tests/testthat/test-clickExtent.R:13:1:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/tests/testthat/test-clickExtent.R#L13) *style:* **Lines should not be more than 100 characters.**
```r
  crs(shpEcozone) <- "+init=epsg:4326 +proj=longlat +datum=WGS84 +no_defs +ellps=WGS84 +towgs84=0,0,0"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-clickExtent.R:21:1:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/tests/testthat/test-clickExtent.R#L21) *style:* **Lines should not be more than 100 characters.**
```r
                       url = "http://www.ec.gc.ca/data_donnees/STB-DGST/003/Boreal-ecosystem-anthropogenic-disturbance-vector-data-2008-2010.zip")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-clickExtent.R:23:1:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/tests/testthat/test-clickExtent.R#L23) *style:* **Lines should not be more than 100 characters.**
```r
  bb <- raster::shapefile(file.path(dirname(tempdir()), "EC_borealdisturbance_polygonal_2008_2010_FINAL_ALBERS.shp"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-examples.R:11:15:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/tests/testthat/test-examples.R#L11) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
    setwd(owd)}
              ^
```
[tests/testthat/test-Plot-do-call.R:8:3:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/tests/testthat/test-Plot-do-call.R#L8) *style:* **Variable or function name should be lowerCamelCase.**
```r
  Sr1 <- Polygon(coords1)
  ^~~
```
[tests/testthat/test-Plot-do-call.R:9:3:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/tests/testthat/test-Plot-do-call.R#L9) *style:* **Variable or function name should be lowerCamelCase.**
```r
  Srs1 <- Polygons(list(Sr1), "s1")
  ^~~~
```
[tests/testthat/test-Plot-do-call.R:11:1:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/tests/testthat/test-Plot-do-call.R#L11) *style:* **Lines should not be more than 100 characters.**
```r
  crs(shpEcozone) <- "+init=epsg:4326 +proj=longlat +datum=WGS84 +no_defs +ellps=WGS84 +towgs84=0,0,0"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-Plot-do-call.R:17:24:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/tests/testthat/test-Plot-do-call.R#L17) *style:* **Commas should always have a space after.**
```r
  r <- raster(extent(0,10,0,10), res = 1, vals = 1:100)
                       ^
```
[tests/testthat/test-Plot-do-call.R:17:27:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/tests/testthat/test-Plot-do-call.R#L17) *style:* **Commas should always have a space after.**
```r
  r <- raster(extent(0,10,0,10), res = 1, vals = 1:100)
                          ^
```
[tests/testthat/test-Plot-do-call.R:17:29:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/tests/testthat/test-Plot-do-call.R#L17) *style:* **Commas should always have a space after.**
```r
  r <- raster(extent(0,10,0,10), res = 1, vals = 1:100)
                            ^
```
[tests/testthat/test-Plot-nonVisual.R:65:21:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/tests/testthat/test-Plot-nonVisual.R#L65) *style:* **Commented code should be removed.**
```r
  library(raster); #on.exit(detach("package:raster"), add = TRUE)
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-Plot-nonVisual.R:70:3:](https://github.com/PredictiveEcology/quickPlot/blob/e8f801fe3cd09a7a2dd8dd894401c3add8c7c856/tests/testthat/test-Plot-nonVisual.R#L70) *style:* **Variable or function name should be lowerCamelCase.**
```r
  N <- ncol * nrow
  ^
```


@Mierunski This looks like it was a typo/mistake to place under uart0


### Lipsum really?

So we _really_ were not able to find better filler text?


ok


I've also been less than happy while downloading the source (my net is incredibly sloooow since I moved to the countryside...). Actually I'd like to break this up into sub-packages for various languages. What do you think?


Some simplification rules removed due to unnecessity and one resulting in a bug where a stackoverflow was produced. A new issue must be opened for this bug.


+worker: node bot.js


issue-6790-VRP-D-term (EnergyArchmage) - Win64-Windows-7-VisualStudio-14: OK (2924 of 2929 tests passed, 11 test warnings)

Messages:

 * 11 tests had: AUD diffs.
 * 4 tests had: EIO diffs.
 * 2 tests had: ESO small diffs.
 * 2 tests had: MTR small diffs.
 * 5 tests had: SSZ big diffs.
 * 2 tests had: Table small diffs.

Failures:

regression Test Summary
 * Passed: 618
 * Failed: 5

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.png)


__[API Description file `simulationapi`](https://app.apiary.io/simulationapi/editor) has not been updated in Apiary.io__ due to server timeout.
Please try it later by trying to redeliver the associated [web hook in settings](api.github.com/3DSIM/simulation-api-specification/settings/hooks) of this repository. (Autogenerated message from apiary.io)


quita este print


usa guard let


Created multidev environment [composer-digital-initiatives#pr-41](https://dashboard.pantheon.io/sites/3d35643a-2d94-44d8-ac78-4f1526e12dcf#pr-41).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-41-composer-digital-initiatives.pantheonsite.io/)


agrega un espacio despues del "" en la validacion del if


Created multidev environment [rail-uga-stellar#pr-16](https://dashboard.pantheon.io/sites/05f5afa3-c1ec-448f-915a-9234103f2409#pr-16).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-16-rail-uga-stellar.pantheonsite.io/)


I used to like having the ability to serialize everything (i.e. also simple RegExp, functions). So I am kind of curious: Why did you decide to set ‘isJSON’ to ‘true’?


que viene siendo ese 5? es algo confuso


Poor function 'DAISIE_sim_core_checked', being deleted here.  Put it back in 6dd2e9a345884e2e4b6b948094cef0a64eb68bde :+1:


Лучше выводить через метод. Стэйшнс это ведь массив объектов, и мы не хотим видеть руби объекты, а хотим видеть названия станций


### Lipsum really?

So we __really__ were not able to find *better* filler text?


тоже самое с поездами маршрутами и вагонами


quita este comentario


tbh, I'm not sure. I remember once staring at the definition of `getCanonicalFileNameSafe` for a quite a while, only to conclude that it was quite useless in our case. I don't recall how or why though.


зачем тут промежуточная переменная wagon?


Updated the path to remove the following warning:
***************************************************************************
* WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING *
***************************************************************************
Please update your scripts to use /sbin/tini or simply tini going forward.
Previous path has been preserved for backwards compatibility,
but WILL BE REMOVED in the future. (around Jenkins >= 2.107.2+)
Now sleeping 2 minutes...


In-person: Oh! The compiler's eliding the unused `private` property setter, and we're missing an `&& statusCodeProperty.CanWrite` on line 82 above.


Was this intentionally removed?


Thanks! Can you update to do following?

1) Place the button at the bottom of the processes page with a clear description of what it does.
2) Make 1) appear only if there are more than 1 failed process.

I think we could also group failed tasks by Apps (service) and let user rerun failed tasks of specific App.


I don't think so since the method is using non static and unshared arguments (not changed and not changeable anywhere else) and also because each call to that method will have its own stack. I could as well go with a non static method (i.e instanciating PdfBuilder with args and then make a call to its méthod buildPdf()) if you want to make sure there's no concurrency or blocking issue.


Did you try running the tests? I think we have a test for the case where the remapped file doesn't exist and I guess if that works it might be fine.


селф тут можно отбросить


別の方法を考えた方がよさそう


you can close this issue.


yes


Fixed and sorted: https://github.com/OpenPLi/openpli-oe-core/pull/494


good afternoon i. having  problem
![1](https://user-images.githubusercontent.com/40438785/41675700-6aa2678c-7491-11e8-92fa-6bfa72cbfd12.JPG)
 with the code


Эту проверку можно смешать с проверкой в начале метода, и не выполнять ничего, если они не пройдут.


keys changed for security reasons


## Jenkins Build Summary

Built from [this commit](https://github.com/mellery451/rippled/commit/cf2fbe0596b97798b08dff63c79889118e5d762e)

Built at __20180620 - 17:55:13__

### Test Results

Build Type | Log | Result | Status
---------- | --- | ------ | ------
rpm | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/mellery-rebeast/70//artifact/rpm.txt) | 1032 cases, 0 failed, t: n/a | PASS :white_check_mark:
gcc.Release
-Dassert=true,
MANUAL_TESTS=true | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/mellery-rebeast/70//artifact/gcc.Release_Dassert_true_MANUAL_TESTS_true.txt) | 1101 cases, 0 failed, t: 952s | PASS :white_check_mark:
docs | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/mellery-rebeast/70//artifact/docs.txt) | 1 cases, 0 failed, t: 2s | PASS :white_check_mark:
gcc.Debug
-Dcoverage=ON | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/mellery-rebeast/70//artifact/gcc.Debug_Dcoverage_ON.txt) | 1032 cases, 0 failed, t: 847s | PASS :white_check_mark:
clang.Debug
-Dunity=OFF | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/mellery-rebeast/70//artifact/clang.Debug_Dunity_OFF.txt) | no test results, t: 1s | FAIL :red_circle:
clang.Debug | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/mellery-rebeast/70//artifact/clang.Debug.txt) | 1032 cases, 0 failed, t: 272s | PASS :white_check_mark:
gcc.Debug
-Dunity=OFF | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/mellery-rebeast/70//artifact/gcc.Debug_Dunity_OFF.txt) | no test results, t: 0s | FAIL :red_circle:
gcc.Debug | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/mellery-rebeast/70//artifact/gcc.Debug.txt) | 1032 cases, 0 failed, t: 287s | PASS :white_check_mark:
msvc.Debug | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/mellery-rebeast/70//artifact/msvc.Debug.txt) | 1029 cases, 0 failed, t: 529s | PASS :white_check_mark:
clang.Release
-Dassert=true | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/mellery-rebeast/70//artifact/clang.Release_Dassert_true.txt) | 1032 cases, 0 failed, t: 391s | PASS :white_check_mark:
gcc.Release
-Dassert=true | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/mellery-rebeast/70//artifact/gcc.Release_Dassert_true.txt) | 1032 cases, 0 failed, t: 414s | PASS :white_check_mark:
gcc.Debug
-Dstatic=true | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/mellery-rebeast/70//artifact/gcc.Debug_Dstatic_true.txt) | 1032 cases, 0 failed, t: 284s | PASS :white_check_mark:
clang.Debug
-Dunity=OFF -Dsan=address,
PARALLEL_TESTS=false,
DEBUGGER=false | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/mellery-rebeast/70//artifact/clang.Debug_Dunity_OFF_Dsan_address_PARALLEL_TESTS_false_DEBUGGER_false.txt) | no test results, t: 1s | FAIL :red_circle:
clang.Debug
-Dunity=OFF -Dsan=undefined,
PARALLEL_TESTS=false | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/mellery-rebeast/70//artifact/clang.Debug_Dunity_OFF_Dsan_undefined_PARALLEL_TESTS_false.txt) | no test results, t: 1s | FAIL :red_circle:
msvc.Debug,
NINJA_BUILD=true | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/mellery-rebeast/70//artifact/msvc.Debug_NINJA_BUILD_true.txt) | 1029 cases, 0 failed, t: 545s | PASS :white_check_mark:
msvc.Debug
-Dunity=OFF | [console](http://ci.ops.ripple.com/job/mellery-rippled/job/mellery-rebeast/70//console) | no test results, t: n/a | FAIL :red_circle:
gcc.Debug,
NINJA_BUILD=true | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/mellery-rebeast/70//artifact/gcc.Debug_NINJA_BUILD_true.txt) | 1032 cases, 0 failed, t: 262s | PASS :white_check_mark:
msvc.Release | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/mellery-rebeast/70//artifact/msvc.Release.txt) | 1029 cases, 0 failed, t: 384s | PASS :white_check_mark:


![](https://github.trello.services/images/mini-trello-icon.png) [Add database backup to repository](https://trello.com/c/V56BG02G/7-add-database-backup-to-repository)


И вообще в классе у нас не должно быть puts никаких. Мы хотим что-б работало как-то так в интерфэйсе
```
if @train.wagon_add(wagon)
  wagon_added_message # какой-нибудь метод, или константа отвечающие только за вывод
else
  unable_to_add_message # метод, или константа импортированные из файла отвечающего за вывод
end
```


I left in km was goingto do mph but we call it points on our liscense not demerit points just seemed odd to do it by us standard


Licencia GNU


Missing the `%s` here?


also, regarding the loop: waiting for a Future to complete doesn't prevent other future to run and finish its own task before being removed from the pool (that's why I keep all the Future objects in a TreeMap). This loop is actually an optimization for starting adding a Page as soon as its image is available, without waiting for all the Future to complete (i.e, for the Pool to be empty). So as soon as image x is ready page x is added along with all subsequent "ready" images up until one image is not ready.


Correcciones creadas


Corregido


Revert to previous revision.


This won't fire on tx-fn failures/exceptions.  Do you want to know the user hit "stage" or only that the txfn suceeded


so it seems the only reason we have tesseract is for the mayan port that you wanted.  So if you want to split the final product into subpackages, that's fine with me.  (just adopt the port).
On that topic, does mayan-ng work?  I imported it a while back but didn't hear any feedback on it.


Yes, that's correct, and is pretty much what the TODO expects I think.

The problem with your initial wording is that it suggests that the presence of the curve25519 key in the response to `/keys/query` is enough on its own to verify that the message has come from the claimed user. It might be difficult to write this paragraph in a meaningful way before a section about device verification has landed.


I've experienced this missing proteins issue when there are runs represented in the fractions sheet that are not in design sheet (e.g. using only channels from two of three 8-plexes).  So proteins that only appear in "missing" runs have all rows removed.


(by the way, I think https://github.com/matrix-org/matrix-js-sdk/blob/master/src/crypto/index.js#L571 is the relevant bit in the js-sdk here.)


@webknjaz Hi. New code still bad?


Created multidev environment [dgreat#pr-tandem2](https://dashboard.pantheon.io/sites/41cad7fe-472d-43a9-a470-d391b9622376#pr-tandem2).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-tandem2-dgreat.pantheonsite.io/)


Oh my, I am out of practice! I thought I was on a branch. Really sorry, I will keep an eye on whether this causes problems and revert as needed.

Encountered while trying to port Unitful to 0.7. CC @ajkeller34


Created multidev environment [therapyrealm-d8#pr-1](https://dashboard.pantheon.io/sites/1e2f72fb-b1d6-4944-b76a-de18b38c3d0c#pr-1).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-1-therapyrealm-d8.pantheonsite.io/)


i didnt upload the config/database.js because it content some private infos. Here is the content:

> if (process.env.NODE_ENV === 'production') {
>   module.exports = {
>     mongoURI: 'username://password@databasename/dtq',
>     secret: 'my secret phrase'
>   }
> } else {
>   module.exports = {
>     mongoURI: 'mongodb://localhost/dtq',
>     secret: 'my secret phrase'
>   }
> }


No, remove it.


@endelwar Is it intended to be .env-dist and not .env.dist?


Nit: indentation. Running `cargo fmt` should fix this :)


# getting code


Yes


I cannot comment on that.