[inst/extdata/asalmon_mcw/main.r:2:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L2) *style:* **Variable or function name should be snake_case.**
```r
LAMBDA_var <- 0.1 #Thin plate spline smoothing. Lambda=0 would be interpolation.
^~~~~~~~~~
```
[inst/extdata/asalmon_mcw/main.r:3:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L3) *style:* **Variable or function name should be snake_case.**
```r
RESOLUTION_var <- 500 #Plot width in pixels
^~~~~~~~~~~~~~
```
[inst/extdata/asalmon_mcw/main.r:5:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L5) *style:* **Lines should not be more than 80 characters.**
```r
#TODO change path. make sure this main.r script is just outside the diagram_retina folder.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/extdata/asalmon_mcw/main.r:8:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L8) *style:* **Lines should not be more than 80 characters.**
```r
#todo verify these. see the tutorial here: https://github.com/bc/retina/blob/master/tutorial.md search for the part that starts with "#[V point of the tear,"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/extdata/asalmon_mcw/main.r:10:10:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L10) *style:* **Commas should always have a space after.**
```r
    c(59,52,67),
         ^
```
[inst/extdata/asalmon_mcw/main.r:10:13:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L10) *style:* **Commas should always have a space after.**
```r
    c(59,52,67),
            ^
```
[inst/extdata/asalmon_mcw/main.r:11:10:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L11) *style:* **Commas should always have a space after.**
```r
    c(79,73,85),
         ^
```
[inst/extdata/asalmon_mcw/main.r:11:13:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L11) *style:* **Commas should always have a space after.**
```r
    c(79,73,85),
            ^
```
[inst/extdata/asalmon_mcw/main.r:12:10:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L12) *style:* **Commas should always have a space after.**
```r
    c(34,31,37))
         ^
```
[inst/extdata/asalmon_mcw/main.r:12:13:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L12) *style:* **Commas should always have a space after.**
```r
    c(34,31,37))
            ^
```
[inst/extdata/asalmon_mcw/main.r:15:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L15) *style:* **Lines should not be more than 80 characters.**
```r
assemble_markup_file('left', path_to_retina_data_folder, nasal_outline_index=1, dorsal_outline_index=NA)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/extdata/asalmon_mcw/main.r:15:22:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L15) *style:* **Only use double-quotes.**
```r
assemble_markup_file('left', path_to_retina_data_folder, nasal_outline_index=1, dorsal_outline_index=NA)
                     ^~~~~~
```
[inst/extdata/asalmon_mcw/main.r:15:77:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L15) *style:* **Put spaces around all infix operators.**
```r
assemble_markup_file('left', path_to_retina_data_folder, nasal_outline_index=1, dorsal_outline_index=NA)
                                                                           ~^~
```
[inst/extdata/asalmon_mcw/main.r:15:101:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L15) *style:* **Put spaces around all infix operators.**
```r
assemble_markup_file('left', path_to_retina_data_folder, nasal_outline_index=1, dorsal_outline_index=NA)
                                                                                ~^~
```
[inst/extdata/asalmon_mcw/main.r:29:21:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L29) *style:* **Commas should never have a space before.**
```r
        height = 45 ,# height of the counting frame in microns
                   ~^
```
[inst/extdata/asalmon_mcw/main.r:29:22:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L29) *style:* **Commas should always have a space after.**
```r
        height = 45 ,# height of the counting frame in microns
                     ^
```
[inst/extdata/asalmon_mcw/main.r:34:28:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L34) *style:* **Commas should never have a space before.**
```r
        extrapolate = TRUE ,          #Predicts densities to the equator.
                          ~^
```
[inst/extdata/asalmon_mcw/main.r:36:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L36) *style:* **Lines should not be more than 80 characters.**
```r
        rotation_ccw = -90, # when set to -90 degrees, the rotation is unaltered from the measured orientation.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/extdata/asalmon_mcw/main.r:37:22:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L37) *style:* **Put spaces around all infix operators.**
```r
        plot_suppress=TRUE)
                    ~^~
```
[inst/extdata/asalmon_mcw/main.r:39:29:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L39) *style:* **Put spaces around all infix operators.**
```r
retinaplot(my_retina, lambda=0.001, polynomial_m=   2, rotation=0)
                           ~^~
```
[inst/extdata/asalmon_mcw/main.r:39:49:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L39) *style:* **Put spaces around all infix operators.**
```r
retinaplot(my_retina, lambda=0.001, polynomial_m=   2, rotation=0)
                                               ~^
```
[inst/extdata/asalmon_mcw/main.r:39:64:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L39) *style:* **Put spaces around all infix operators.**
```r
retinaplot(my_retina, lambda=0.001, polynomial_m=   2, rotation=0)
                                                              ~^~
```
[inst/extdata/asalmon_mcw/main.r:40:10:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L40) *style:* **Put spaces around all infix operators.**
```r
par(mfrow=c(2,2))
        ~^~
```
[inst/extdata/asalmon_mcw/main.r:40:15:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/inst/extdata/asalmon_mcw/main.r#L40) *style:* **Commas should always have a space after.**
```r
par(mfrow=c(2,2))
              ^
```
[R/composite.R:2:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/composite.R#L2) *style:* **Lines should not be more than 80 characters.**
```r
##' @description This is a subfunction, that is useful when creating average maps.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/composite.R:3:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/composite.R#L3) *style:* **Lines should not be more than 80 characters.**
```r
##' @param retina_list A list containing retina objects, with names(retina_list) all defined.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/composite.R:4:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/composite.R#L4) *style:* **Lines should not be more than 80 characters.**
```r
##' @param rotation_indices Each value in this vector will correspond to the amount of rotation applied to each retina in the list.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/composite.R:5:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/composite.R#L5) *style:* **Lines should not be more than 80 characters.**
```r
##' @param ... Arguments passed from other functions. You can access the thin plate spline interpolator here.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/composite.R:6:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/composite.R#L6) *style:* **Lines should not be more than 80 characters.**
```r
##' @return sum_mat The sum of all retina objects in the list, with respect to the rotation indices.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/composite.R:9:16:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/composite.R#L9) *warning:* **no visible global function definition for ‘mat_from_ret_obj’**
```r
    sum_mat <- mat_from_ret_obj(retina_list[[1]], rotation = 0, ...)
               ^~~~~~~~~~~~~~~~
```
[R/composite.R:12:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/composite.R#L12) *style:* **Lines should not be more than 80 characters.**
```r
        sum_mat <- sum_mat + mat_from_ret_obj(retina_list[[i]], rotation_indices[i],
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/composite.R:12:85:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/composite.R#L12) *style:* **Trailing whitespace is superfluous.**
```r
        sum_mat <- sum_mat + mat_from_ret_obj(retina_list[[i]], rotation_indices[i],
                                                                                ^
```
[R/matrix_retobj.R:3:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/matrix_retobj.R#L3) *style:* **Lines should not be more than 80 characters.**
```r
##' You can decide how much to rotate the retina before returning the matrix. You can also pass arguments to the polar plotter.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/matrix_retobj.R:6:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/matrix_retobj.R#L6) *style:* **Lines should not be more than 80 characters.**
```r
##' @param n the number by which to divide the matrix by. Useful when generating partial averages.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/matrix_retobj.R:7:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/matrix_retobj.R#L7) *style:* **Lines should not be more than 80 characters.**
```r
##' @param reflect logical, by default it is TRUE, in order to view the retina from outside the eye (rather than from within.)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/matrix_retobj.R:12:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/matrix_retobj.R#L12) *style:* **Lines should not be more than 80 characters.**
```r
mat_from_ret_obj <- function(retina_object, rotation = 0, n = 1, reflect = TRUE,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/matrix_retobj.R:12:81:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/matrix_retobj.R#L12) *style:* **Trailing whitespace is superfluous.**
```r
mat_from_ret_obj <- function(retina_object, rotation = 0, n = 1, reflect = TRUE,
                                                                                ^
```
[R/matrix_retobj.R:17:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/matrix_retobj.R#L17) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/matrix_retobj.R:20:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/matrix_retobj.R#L20) *style:* **Lines should not be more than 80 characters.**
```r
    az <- mapproject(x = retina_object$trimmed_data[, 2], retina_object$trimmed_data[,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/matrix_retobj.R:20:87:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/matrix_retobj.R#L20) *style:* **Trailing whitespace is superfluous.**
```r
    az <- mapproject(x = retina_object$trimmed_data[, 2], retina_object$trimmed_data[,
                                                                                ^
```
[R/matrix_retobj.R:25:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/matrix_retobj.R#L25) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/matrix_retobj.R:27:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/matrix_retobj.R#L27) *style:* **Lines should not be more than 80 characters.**
```r
    map2fit <- fit_plot_azimuthal(x2, y2, z2, plot_suppress = TRUE, extrapolate = TRUE,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/matrix_retobj.R:27:88:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/matrix_retobj.R#L27) *style:* **Trailing whitespace is superfluous.**
```r
    map2fit <- fit_plot_azimuthal(x2, y2, z2, plot_suppress = TRUE, extrapolate = TRUE,
                                                                                ^
```
[R/matrix_retobj.R:28:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/matrix_retobj.R#L28) *style:* **Lines should not be more than 80 characters.**
```r
        outer_radius = pi/2, falciform_coords = retina_object$azimuthal_data.falciform[[1]],
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/matrix_retobj.R:28:26:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/matrix_retobj.R#L28) *style:* **Put spaces around all infix operators.**
```r
        outer_radius = pi/2, falciform_coords = retina_object$azimuthal_data.falciform[[1]],
                        ~^~
```
[R/matrix_retobj.R:28:93:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/matrix_retobj.R#L28) *style:* **Trailing whitespace is superfluous.**
```r
        outer_radius = pi/2, falciform_coords = retina_object$azimuthal_data.falciform[[1]],
                                                                                ^
```
[R/matrix_retobj.R:30:5:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/matrix_retobj.R#L30) *style:* **Variable or function name should be snake_case.**
```r
    MAT <- map2fit[[2]]$z
    ^~~
```
[R/matrix_retobj.R:32:15:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/matrix_retobj.R#L32) *style:* **Put spaces around all infix operators.**
```r
    return(MAT/n)
             ~^~
```
[R/plotting_functions.R:3:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L3) *style:* **Lines should not be more than 80 characters.**
```r
##' Extracts xy and falciform coordinates from datapoints collected from retistruct. Falc and Datapoints are stacked upon one another
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:5:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L5) *style:* **Lines should not be more than 80 characters.**
```r
##' @param datapoints_from_retistruct data structure that comes from the datapoints.csv, which is automatically generated by Retistruct.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:7:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L7) *style:* **Lines should not be more than 80 characters.**
```r
##' @return L list of pixel xy positions, and falciform coordinates in [1] and [2], respectively
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:9:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L9) *style:* **Lines should not be more than 80 characters.**
```r
extract_xy_and_falciform <- function(datapoints_from_retistruct, number_of_sampling_sites) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:10:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L10) *style:* **Lines should not be more than 80 characters.**
```r
    pixel_xy_positions <- datapoints_from_retistruct[1:number_of_sampling_sites,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:10:81:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L10) *style:* **Trailing whitespace is superfluous.**
```r
    pixel_xy_positions <- datapoints_from_retistruct[1:number_of_sampling_sites,
                                                                                ^
```
[R/plotting_functions.R:12:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L12) *style:* **Lines should not be more than 80 characters.**
```r
    falciform_len <- length(datapoints_from_retistruct[, 1]) - length(pixel_xy_positions[,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:12:91:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L12) *style:* **Trailing whitespace is superfluous.**
```r
    falciform_len <- length(datapoints_from_retistruct[, 1]) - length(pixel_xy_positions[,
                                                                                ^
```
[R/plotting_functions.R:16:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L16) *style:* **Lines should not be more than 80 characters.**
```r
    falciform_coordinates <- datapoints_from_retistruct[(xy_len + 1):total_len, ]
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:22:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L22) *style:* **Lines should not be more than 80 characters.**
```r
##' ImageJ values don't always show up the right way, because Y values get larger and positive while moving down the image.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:24:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L24) *style:* **Lines should not be more than 80 characters.**
```r
##' @param falciform_xy_coordinates 2 columns of coordinate (X,Y) data in ImageJ pixel format
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:28:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L28) *style:* **Lines should not be more than 80 characters.**
```r
reflect_IJ_y_values_for_falciform <- function(falciform_xy_coordinates, xy_img_dimensions) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:28:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L28) *style:* **Variable and function names should not be longer than 30 characters.**
```r
reflect_IJ_y_values_for_falciform <- function(falciform_xy_coordinates, xy_img_dimensions) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:28:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L28) *style:* **Variable or function name should be snake_case.**
```r
reflect_IJ_y_values_for_falciform <- function(falciform_xy_coordinates, xy_img_dimensions) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:29:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L29) *style:* **Lines should not be more than 80 characters.**
```r
    falciform_xy_coordinates_transformed <- falciform_xy_coordinates  #make a copy
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:29:5:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L29) *style:* **Variable and function names should not be longer than 30 characters.**
```r
    falciform_xy_coordinates_transformed <- falciform_xy_coordinates  #make a copy
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:31:52:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L31) *style:* **Put spaces around all infix operators.**
```r
    half_of_vertical_pixels <- xy_img_dimensions[2]/2
                                                  ~^~
```
[R/plotting_functions.R:32:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L32) *style:* **Lines should not be more than 80 characters.**
```r
    falciform_xy_coordinates_transformed$cyan <- (falc_y - half_of_vertical_pixels) *
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:32:86:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L32) *style:* **Trailing whitespace is superfluous.**
```r
    falciform_xy_coordinates_transformed$cyan <- (falc_y - half_of_vertical_pixels) *
                                                                                ^
```
[R/plotting_functions.R:38:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L38) *style:* **Lines should not be more than 80 characters.**
```r
##' Shows a visualization of the outline, as well as the location of each datapoint, with fit plot.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:40:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L40) *style:* **Lines should not be more than 80 characters.**
```r
##' @param pixel_xy_positions 2 columns of coordinate (X,Y) data in ImageJ pixel format
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:41:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L41) *style:* **Lines should not be more than 80 characters.**
```r
##' @param z_vector numerical vector of density values for each of the coordinates
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:42:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L42) *style:* **Lines should not be more than 80 characters.**
```r
##' @param xy_outline_points 2 columns of coordinate(X,Y) data in ImageJ pixel format for the outline coordinates.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:45:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L45) *style:* **Lines should not be more than 80 characters.**
```r
traditional_flatmount_plot <- function(pixel_xy_positions, z_vector, xy_outline_points) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:46:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L46) *style:* **Lines should not be more than 80 characters.**
```r
    fit <- Tps(pixel_xy_positions, z_vector)  # fits a surface to ozone measurements.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:46:12:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L46) *warning:* **no visible global function definition for ‘Tps’, Did you mean 'Ops'?**
```r
    fit <- Tps(pixel_xy_positions, z_vector)  # fits a surface to ozone measurements.
           ^~~
```
[R/plotting_functions.R:47:5:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L47) *warning:* **no visible global function definition for ‘set.panel’**
```r
    set.panel(2, 2)
    ^~~~~~~~~
```
[R/plotting_functions.R:49:5:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L49) *warning:* **no visible global function definition for ‘set.panel’**
```r
    set.panel()
    ^~~~~~~~~
```
[R/plotting_functions.R:52:5:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L52) *warning:* **no visible global function definition for ‘surface’**
```r
    surface(fit)  # Quick image/contour plot of GCV surface.
    ^~~~~~~
```
[R/plotting_functions.R:61:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L61) *style:* **Lines should not be more than 80 characters.**
```r
##' Shows a visualization of the outline, as well as the location of each datapoint so the user can identify where the tears are.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:64:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L64) *style:* **Lines should not be more than 80 characters.**
```r
##' @param path_to_retina_data_folder The path to the folder that contains the outline.roi file.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:65:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L65) *style:* **Lines should not be more than 80 characters.**
```r
##' @return roi_coordinates XY vals of pixel coordinates of the outline points, in order.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:69:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L69) *style:* **Lines should not be more than 80 characters.**
```r
    roi_object <- read.ijroi(file.path(path_to_retina_data_folder, "outline.roi"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:69:19:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L69) *warning:* **no visible global function definition for ‘read.ijroi’**
```r
    roi_object <- read.ijroi(file.path(path_to_retina_data_folder, "outline.roi"))
                  ^~~~~~~~~~
```
[R/plotting_functions.R:70:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L70) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/plotting_functions.R:72:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L72) *style:* **Lines should not be more than 80 characters.**
```r
    # format plots has the coordinate (0, 0) in the top left.  We have the coordinate
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:73:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L73) *style:* **Lines should not be more than 80 characters.**
```r
    # (0, 0) in the bottom left. We need to transform P so that the outline appears
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:76:5:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L76) *style:* **Variable or function name should be snake_case.**
```r
    roi_XY_coords <- roi_object$coords
    ^~~~~~~~~~~~~
```
[R/plotting_functions.R:80:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L80) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/plotting_functions.R:81:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L81) *style:* **Lines should not be more than 80 characters.**
```r
    plot(roi_XY_coords, type = "l", col = "#d3d3d3", asp = 1, xlab = "X Pixels",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:81:81:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L81) *style:* **Trailing whitespace is superfluous.**
```r
    plot(roi_XY_coords, type = "l", col = "#d3d3d3", asp = 1, xlab = "X Pixels",
                                                                                ^
```
[R/plotting_functions.R:83:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L83) *style:* **Lines should not be more than 80 characters.**
```r
    text(roi_XY_coords[, 1], roi_XY_coords[, 2], labels = 1:length(roi_XY_coords[,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:83:83:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L83) *style:* **Trailing whitespace is superfluous.**
```r
    text(roi_XY_coords[, 1], roi_XY_coords[, 2], labels = 1:length(roi_XY_coords[,
                                                                                ^
```
[R/plotting_functions.R:85:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L85) *style:* **Lines should not be more than 80 characters.**
```r
    message("If you are getting this message, you are using a special feature. Contact me at brian.cohn@usc.edu and I will happily teach you how to use it.")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:93:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L93) *style:* **Lines should not be more than 80 characters.**
```r
##' @description Creates a markup.csv file. One of the dorsal_outline_index or nasal_outline_index must be filled in. Not both.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:96:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L96) *style:* **Lines should not be more than 80 characters.**
```r
##' @param dorsal_outline_index The index of the point that points toward dorsal, or NA.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:97:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L97) *style:* **Lines should not be more than 80 characters.**
```r
##' @param nasal_outline_index The index of the opint that points toward nasal, or NA.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:98:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L98) *style:* **Lines should not be more than 80 characters.**
```r
##' @param path_to_retina_data_folder The path where the markup.csv file will be saved.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:100:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L100) *style:* **Lines should not be more than 80 characters.**
```r
assemble_markup_file <- function(eye_left_or_right, path_to_retina_data_folder, dorsal_outline_index = NA,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:100:107:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L100) *style:* **Trailing whitespace is superfluous.**
```r
assemble_markup_file <- function(eye_left_or_right, path_to_retina_data_folder, dorsal_outline_index = NA,
                                                                                ^
```
[R/plotting_functions.R:103:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L103) *style:* **Lines should not be more than 80 characters.**
```r
        ## https://stackoverflow.com/questions/18509527/first-letter-to-upper-case
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:109:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L109) *style:* **Lines should not be more than 80 characters.**
```r
        line2 <- paste0("NA,", nasal_outline_index, ",",phi0,",NA,TRUE,\"", eye_side_string,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:109:57:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L109) *style:* **Commas should always have a space after.**
```r
        line2 <- paste0("NA,", nasal_outline_index, ",",phi0,",NA,TRUE,\"", eye_side_string,
                                                        ^
```
[R/plotting_functions.R:109:62:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L109) *style:* **Commas should always have a space after.**
```r
        line2 <- paste0("NA,", nasal_outline_index, ",",phi0,",NA,TRUE,\"", eye_side_string,
                                                             ^
```
[R/plotting_functions.R:109:93:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L109) *style:* **Trailing whitespace is superfluous.**
```r
        line2 <- paste0("NA,", nasal_outline_index, ",",phi0,",NA,TRUE,\"", eye_side_string,
                                                                                ^
```
[R/plotting_functions.R:112:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L112) *style:* **Lines should not be more than 80 characters.**
```r
        line2 <- paste0(dorsal_outline_index, ",NA", ",",phi0,",NA,TRUE,\"", eye_side_string,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:112:58:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L112) *style:* **Commas should always have a space after.**
```r
        line2 <- paste0(dorsal_outline_index, ",NA", ",",phi0,",NA,TRUE,\"", eye_side_string,
                                                         ^
```
[R/plotting_functions.R:112:63:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L112) *style:* **Commas should always have a space after.**
```r
        line2 <- paste0(dorsal_outline_index, ",NA", ",",phi0,",NA,TRUE,\"", eye_side_string,
                                                              ^
```
[R/plotting_functions.R:112:94:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L112) *style:* **Trailing whitespace is superfluous.**
```r
        line2 <- paste0(dorsal_outline_index, ",NA", ",",phi0,",NA,TRUE,\"", eye_side_string,
                                                                                ^
```
[R/plotting_functions.R:120:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L120) *style:* **Lines should not be more than 80 characters.**
```r
    message(paste("Wrote markup file to ", output_path, "\n Ensure that it exists beside your outline.roi file"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:130:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L130) *style:* **Lines should not be more than 80 characters.**
```r
##' @param tear_coordinates_dataframe the dataframe of 3 columns, with c('V0','VB','VF'), and n columns, where n= number of tears
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:131:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L131) *style:* **Lines should not be more than 80 characters.**
```r
##' @param path_to_retina_data_folder The path where the T.csv file will be saved.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:135:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L135) *style:* **Lines should not be more than 80 characters.**
```r
assemble_tear_file <- function(tear_coordinates_dataframe, path_to_retina_data_folder) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:138:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L138) *style:* **Lines should not be more than 80 characters.**
```r
    write.table(tear_coordinates_dataframe, output_path, sep = ",", row.names = FALSE)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:139:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L139) *style:* **Lines should not be more than 80 characters.**
```r
    message(paste("Wrote tear file to ", output_path, "\n Check that it exists beside your outline.roi file"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:147:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L147) *style:* **Lines should not be more than 80 characters.**
```r
##' @param path_to_retina_data_folder The path where the P.csv file will be saved.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:151:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L151) *style:* **Lines should not be more than 80 characters.**
```r
assemble_point_coordinates_file <- function(outline_coordinates, path_to_retina_data_folder) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:151:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L151) *style:* **Variable and function names should not be longer than 30 characters.**
```r
assemble_point_coordinates_file <- function(outline_coordinates, path_to_retina_data_folder) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:155:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L155) *style:* **Lines should not be more than 80 characters.**
```r
    message(paste("Wrote coordinates file to ", output_path, "\n Check that it exists beside your outline.roi file"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:177:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L177) *style:* **Variable and function names should not be longer than 30 characters.**
```r
plot_degree_label_for_latitudes <- function(outer_radius, circle.rads) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:177:59:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L177) *style:* **Variable or function name should be snake_case.**
```r
plot_degree_label_for_latitudes <- function(outer_radius, circle.rads) {
                                                          ^~~~~~~~~~~
```
[R/plotting_functions.R:178:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L178) *style:* **Lines should not be more than 80 characters.**
```r
    axis(2, pos = -1.25 * outer_radius, at = sort(union(circle.rads, -circle.rads)),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:178:85:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L178) *style:* **Trailing whitespace is superfluous.**
```r
    axis(2, pos = -1.25 * outer_radius, at = sort(union(circle.rads, -circle.rads)),
                                                                                ^
```
[R/plotting_functions.R:180:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L180) *style:* **Lines should not be more than 80 characters.**
```r
    text(-1.26 * outer_radius, sort(union(circle.rads, -circle.rads)), sort(union(circle.rads,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:180:95:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L180) *style:* **Trailing whitespace is superfluous.**
```r
    text(-1.26 * outer_radius, sort(union(circle.rads, -circle.rads)), sort(union(circle.rads,
                                                                                ^
```
[R/plotting_functions.R:195:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L195) *style:* **Lines should not be more than 80 characters.**
```r
    fields::image.plot(legend.only = TRUE, col = col, zlim = zlim, family = "Palatino")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:202:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L202) *style:* **Lines should not be more than 80 characters.**
```r
##' @param endpoints a 4 element numeric vector describing the xy and x'y' for the line segment.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:206:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L206) *style:* **Lines should not be more than 80 characters.**
```r
    segments(endpoints[1], endpoints[2], endpoints[3], endpoints[4], col = color_hex)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:216:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L216) *style:* **Lines should not be more than 80 characters.**
```r
##' @param endpoints vector of 4 numerics, x,y and x',y' defining the line segment
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:217:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L217) *style:* **Lines should not be more than 80 characters.**
```r
write_labels_at_endpoint_locations <- function(r_label, l_label, degree, endpoints) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:217:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L217) *style:* **Variable and function names should not be longer than 30 characters.**
```r
write_labels_at_endpoint_locations <- function(r_label, l_label, degree, endpoints) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:226:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L226) *style:* **Lines should not be more than 80 characters.**
```r
##' @description We do not need points plotted in the corners of the plotted circle.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:233:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L233) *style:* **Lines should not be more than 80 characters.**
```r
nullify_vals_outside_the_circle <- function(minitics, spatial_res, heatmap_matrix,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:233:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L233) *style:* **Variable and function names should not be longer than 30 characters.**
```r
nullify_vals_outside_the_circle <- function(minitics, spatial_res, heatmap_matrix,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:233:83:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L233) *style:* **Trailing whitespace is superfluous.**
```r
nullify_vals_outside_the_circle <- function(minitics, spatial_res, heatmap_matrix,
                                                                                ^
```
[R/plotting_functions.R:235:5:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L235) *style:* **Variable and function names should not be longer than 30 characters.**
```r
    matrix_position_is_within_the_circle <- function() {
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:238:5:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L238) *style:* **Variable or function name should be snake_case.**
```r
    markNA <- matrix(minitics, ncol = spatial_res, nrow = spatial_res)
    ^~~~~~
```
[R/plotting_functions.R:246:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L246) *style:* **Lines should not be more than 80 characters.**
```r
##' @description Find the location to put the label around the circle at each of the lines
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:251:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L251) *style:* **Variable and function names should not be longer than 30 characters.**
```r
compute_longitude_label_location <- function(axis.rads, outer_radius) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:251:46:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L251) *style:* **Variable or function name should be snake_case.**
```r
compute_longitude_label_location <- function(axis.rads, outer_radius) {
                                             ^~~~~~~~~
```
[R/plotting_functions.R:252:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L252) *style:* **Lines should not be more than 80 characters.**
```r
    return(c(RMat(axis.rads) %*% matrix(c(1.1, 0, -1.1, 0) * outer_radius, ncol = 2)))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:252:14:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L252) *warning:* **no visible global function definition for ‘RMat’, Did you mean 'hat'?**
```r
    return(c(RMat(axis.rads) %*% matrix(c(1.1, 0, -1.1, 0) * outer_radius, ncol = 2)))
             ^~~~
```
[R/plotting_functions.R:261:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L261) *style:* **Lines should not be more than 80 characters.**
```r
    endpoints <- zapsmall(c(RMat(axis_radian) %*% matrix(c(1, 0, -1, 0) * outer_radius,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:261:88:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L261) *style:* **Trailing whitespace is superfluous.**
```r
    endpoints <- zapsmall(c(RMat(axis_radian) %*% matrix(c(1, 0, -1, 0) * outer_radius,
                                                                                ^
```
[R/plotting_functions.R:263:5:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L263) *warning:* **no visible global function definition for ‘draw_line_segments’**
```r
    draw_line_segments(endpoints)
    ^~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:267:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L267) *style:* **Lines should not be more than 80 characters.**
```r
##' @description put a degree label at the ends of the endpoints for each longitude
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:274:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L274) *style:* **Lines should not be more than 80 characters.**
```r
plot_longitudinal_labels <- function(axis.rad, outer_radius, r_label, l_label, degree) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:274:38:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L274) *style:* **Variable or function name should be snake_case.**
```r
plot_longitudinal_labels <- function(axis.rad, outer_radius, r_label, l_label, degree) {
                                     ^~~~~~~~
```
[R/plotting_functions.R:275:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L275) *style:* **Lines should not be more than 80 characters.**
```r
    write_labels_at_endpoint_locations(r_label, l_label, degree, compute_longitude_label_location(axis.rad,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:275:108:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L275) *style:* **Trailing whitespace is superfluous.**
```r
    write_labels_at_endpoint_locations(r_label, l_label, degree, compute_longitude_label_location(axis.rad,
                                                                                ^
```
[R/plotting_functions.R:285:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L285) *style:* **Variable or function name should be snake_case.**
```r
RMat <- function(radians) {
^~~~
```
[R/plotting_functions.R:286:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L286) *style:* **Lines should not be more than 80 characters.**
```r
    return(matrix(c(cos(radians), sin(radians), -sin(radians), cos(radians)), ncol = 2))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:290:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L290) *style:* **Lines should not be more than 80 characters.**
```r
##' @description plots radial lines, degree label for latitudes, and plots radial spokes with labels
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:295:5:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L295) *warning:* **no visible global function definition for ‘plot_circle_radial_lines’**
```r
    plot_circle_radial_lines(radius_vals)
    ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:296:5:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L296) *warning:* **no visible global function definition for ‘plot_degree_label_for_latitudes’**
```r
    plot_degree_label_for_latitudes(outer_radius, radius_vals)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:297:5:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L297) *warning:* **no visible global function definition for ‘plot_radial_spokes_and_labels’**
```r
    plot_radial_spokes_and_labels(outer_radius)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:324:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L324) *style:* **Variable and function names should not be longer than 30 characters.**
```r
define_color_breaks_based_on_source <- function(col_breaks_source, z, Mat) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:324:71:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L324) *style:* **Variable or function name should be snake_case.**
```r
define_color_breaks_based_on_source <- function(col_breaks_source, z, Mat) {
                                                                      ^~~
```
[R/plotting_functions.R:329:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L329) *style:* **Lines should not be more than 80 characters.**
```r
    } else if ((length(col_breaks_source) == 2) & (is.numeric(col_breaks_source))) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:346:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L346) *style:* **Lines should not be more than 80 characters.**
```r
##' @param extrapolate whether to predict out to the equator of the eye, even if no data exists nearby.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:347:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L347) *style:* **Lines should not be more than 80 characters.**
```r
interpolate_input_data <- function(minitics, x, y, z, lambda, polynomial_m, extrapolate) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:348:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L348) *style:* **Lines should not be more than 80 characters.**
```r
    grid.list = list(x = minitics, y = minitics)  #choose locations to predict at
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:348:5:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L348) *style:* **Variable or function name should be snake_case.**
```r
    grid.list = list(x = minitics, y = minitics)  #choose locations to predict at
    ^~~~~~~~~
```
[R/plotting_functions.R:348:15:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L348) *style:* **Use <-, not =, for assignment.**
```r
    grid.list = list(x = minitics, y = minitics)  #choose locations to predict at
              ^
```
[R/plotting_functions.R:349:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L349) *style:* **Lines should not be more than 80 characters.**
```r
    t <- Tps(cbind(x, y), z, lambda = lambda, m = polynomial_m)  #computationally intensive
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:349:10:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L349) *warning:* **no visible global function definition for ‘Tps’, Did you mean 'Ops'?**
```r
    t <- Tps(cbind(x, y), z, lambda = lambda, m = polynomial_m)  #computationally intensive
         ^~~
```
[R/plotting_functions.R:350:12:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L350) *warning:* **no visible global function definition for ‘predictSurface’**
```r
    tmp <- predictSurface(t, grid.list, extrap = extrapolate)
           ^~~~~~~~~~~~~~
```
[R/plotting_functions.R:351:5:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L351) *style:* **Variable or function name should be snake_case.**
```r
    Mat <- tmp$z
    ^~~
```
[R/plotting_functions.R:363:5:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L363) *style:* **Variable or function name should be snake_case.**
```r
    axis.rads <- c(0, pi/6, pi/3, pi/2, 2 * pi/3, 5 * pi/6)
    ^~~~~~~~~
```
[R/plotting_functions.R:363:25:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L363) *style:* **Put spaces around all infix operators.**
```r
    axis.rads <- c(0, pi/6, pi/3, pi/2, 2 * pi/3, 5 * pi/6)
                       ~^~
```
[R/plotting_functions.R:363:31:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L363) *style:* **Put spaces around all infix operators.**
```r
    axis.rads <- c(0, pi/6, pi/3, pi/2, 2 * pi/3, 5 * pi/6)
                             ~^~
```
[R/plotting_functions.R:363:37:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L363) *style:* **Put spaces around all infix operators.**
```r
    axis.rads <- c(0, pi/6, pi/3, pi/2, 2 * pi/3, 5 * pi/6)
                                   ~^~
```
[R/plotting_functions.R:363:47:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L363) *style:* **Put spaces around all infix operators.**
```r
    axis.rads <- c(0, pi/6, pi/3, pi/2, 2 * pi/3, 5 * pi/6)
                                             ~^~
```
[R/plotting_functions.R:363:57:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L363) *style:* **Put spaces around all infix operators.**
```r
    axis.rads <- c(0, pi/6, pi/3, pi/2, 2 * pi/3, 5 * pi/6)
                                                       ~^~
```
[R/plotting_functions.R:364:5:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L364) *style:* **Variable or function name should be snake_case.**
```r
    r.labs <- c(90, 60, 30, 0, 330, 300)
    ^~~~~~
```
[R/plotting_functions.R:365:5:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L365) *style:* **Variable or function name should be snake_case.**
```r
    l.labs <- c(270, 240, 210, 180, 150, 120)
    ^~~~~~
```
[R/plotting_functions.R:367:9:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L367) *warning:* **no visible global function definition for ‘plot_longitudinal_lines’**
```r
        plot_longitudinal_lines(axis.rads[i], outer_radius)
        ^~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:368:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L368) *style:* **Lines should not be more than 80 characters.**
```r
        plot_longitudinal_labels(axis.rads[i], outer_radius, r.labs[i], l.labs[i],
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:368:83:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L368) *style:* **Trailing whitespace is superfluous.**
```r
        plot_longitudinal_labels(axis.rads[i], outer_radius, r.labs[i], l.labs[i],
                                                                                ^
```
[R/plotting_functions.R:389:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L389) *style:* **Lines should not be more than 80 characters.**
```r
##' @description Useful for making the falciform process look more smooth and refined. This is purely aesthetic.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:390:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L390) *style:* **Lines should not be more than 80 characters.**
```r
##' @details enhance the resolution of a polygon vertices dataframe by creating a spline along each vertex.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:391:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L391) *style:* **Lines should not be more than 80 characters.**
```r
##' @param xy vertices in dataframe with x and y columns, in order (not all are used).
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:398:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L398) *style:* **Lines should not be more than 80 characters.**
```r
##' @references http://gis.stackexchange.com/questions/24827/how-to-smooth-the-polygons-in-a-contour-map
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:407:5:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L407) *style:* **Variable or function name should be snake_case.**
```r
    data.spline <- spline(1:(n + 2 * k), data[, 1], n = vertices, ...)
    ^~~~~~~~~~~
```
[R/plotting_functions.R:411:1:](https://github.com/bc/retina/blob/07fa212b346b641cec5f57344a6c32c888bfcb9d/R/plotting_functions.R#L411) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```


this contains the rest of the fix for #941, accidentally collapsed my commits while users were bugging me for more changes (VB remap)


First of all thank you for the detailed explanation I understand where you're coming from now.

> a single key setup is either highly inconvenient or insecure. It’s not best practices. Mandating its use in the protocol seems myopic.

I made an assumption that since nearly everyone uses single key p2pkh it would be logical to use only the keyID and save some block space because hopefully they wouldn't be doing any weird key splitting stuff. I'm glad you pointed out the issues with that thinking.

For an extra few bytes we gain a lot, and it seems like a good idea to me. I'm going to talk to Paul about it asap but I'm pretty sure he will agree as well.

> [Or, maybe, as a NSA plot to put out a purposefully easy to foot-gun crypto protocol, if you believe such things.])
My tinfoil hat allows me to see that this is the truth! :)


1. ARTICLE is not a valid in action type name, as article refers to journal article in display type
2. Action type should be renamed into ACADEMIC_PUBLICATIONS_COUNT_TOTAL_LOADED (or equivalent) and existing ACADEMIC_PUBLICATIONS_COUNT_LOADED should be renamed into more appropriate to its role, eg it loads publications count per display type - ACADEMIC_PUBLICATIONS_COUNT_PER_TYPE_LOADED


@timjb Is Agda 2.5.4 getting worse than the version you were running? I could not even finish `EM1HSpaceAssoc` in timjb/AgdaInfiniteLoopBug.


not to pass publications count all the way from the top, why not add a container for DashboardArticleCount to get its data directly from the store?


Fixed a security vulnerability with one of mocha's dependencies, growl. Updating to 4.0.0 updated the dependency to a safe version.


shouldn't it be just {... authorArticleCount} if all props have same name? eg ```<StandardCard {...txt.noResultsFound}>```


처음 시작.


## Words

| Changed   |   Status |
|:----------|---------:|
| `lat`     |       -1 |

*[Hook UI build recap](http://ci.perseids.org/repo/PerseusDL/canonical-latinLit/4370)*


My first text file
Lorem ipsum dolor sit amet, consectetuer adipiscing elit.
Lorem ipsum dolor sit amet, consectetuer adipiscing elit.
Lorem ipsum dolor sit amet, consectetuer adipiscing elit.
Lorem ipsum dolor sit amet, consectetuer adipiscing elit.
Lorem ipsum dolor sit amet, consectetuer adipiscing elit.
Lorem ipsum dolor sit amet, consectetuer adipiscing elit.
Lorem ipsum dolor sit amet, consectetuer adipiscing elit.


모바일에선 어떻게 보일까요?


コメントです。
Materiapps Live ver2.0a版で作業を行いました。
ser@malive:~$  tar zcvf /home/user/ma-akaikkr-20180520-1.tar.gz akaikkr_20180520
でないとインストールできませんでした。
インストール後も旧バージョンが有効となっており、最新バージョンのakaikkrが起動しませんでした。
従来のエラーが出たのを確認


maybe time for refactoring - component should be PureComponent, add container not to pass props around?


should be renamed to publicationTotalCount


This file can be run in SQL to create tables, relationship, constraints, and triggers for data solutions.


Hello, just want to learn how to use blender and maybe someday work making videogames.


잘 보이는데, 오른쪽에 너무 딱 붙어 있네요. 수정하겠습니다.


####JOHN CLOUD SR.,####


container can pass all required props to the component


画面を添付します。

[ma-akaikkrエラー20180618.pptx](https://github.com/cmsi/ma-akaikkr/files/2109676/ma-akaikkr.20180618.pptx)


[R/mc_utils.R:184:5:](https://github.com/ropensci/drake/blob/bea026a2f4ddb64d6688922661ddcbd4210ac51a/R/mc_utils.R#L184) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(identical("failed", get_progress_single(target, cache = config$cache))){
    ^
```


Build version: __`0.10.0-master.165`__ :crossed_fingers: [`master`](https://github.com/streamich/ci-scripts/tree/master) on [*CircleCI*](https://circleci.com/gh/streamich/ci-scripts/165) :tada:


Build version: __`0.10.0-master.249`__ :crossed_fingers: [`master`](https://github.com/streamich/ci-scripts/tree/master) on [*Travis*](https://travis-ci.org/streamich/ci-scripts/builds/393454535) :tada:


[R/mc_utils.R:184:5:](https://github.com/ropensci/drake/blob/5924575b0da3d1b8e499644d0afffb7e7d4b796f/R/mc_utils.R#L184) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(identical("failed", get_progress_single(target, cache = config$cache))){
    ^
```


@alexmozzhakov Fixed all junk commits.


Collaborator: Review for this commit was created. [Link to review](http://73bd9c29.ngrok.io/ui#review:id=321)


@DarkknightAK Hi Andreas. Plasma not use dash symbol "-" on file names. Need moved `video-card-inactive` to file `video.svgz` and remove file `video-card.svgz`


@FelixZett is right. For his case it is really not the right translation. Is there a way to support both cases @bradymholt ? F.e. when it is not daily (f.e. only workdays, only on Sunday)


not just PCFX, but PCE, PCE-CD, SuperGrafx… all NEC systems now using proper roman numerals in labels.


There's an edit missing on the Mac OS install which still points to v1.13


I think we should not use this method, as Zip can freely add some ExtraFields, for example to handle zip64


I am a histotech


Why do you need two tags? You can use M_BUSDMA_XEN for all the allocations related to Xen busdma.


and the specification tell to ignore unknown extra field


Collaborator: Review for this commit was created. [Link to review](http://217.170.125.19:40101/ui#review:id=19)


开始懂了


See comment below...


job description


As  commented on previous patches, please don't base your patches on top of previously wrong code. You have based this on top of your previous busdma tag allocation patch, which makes it harder to review because you add new code and delete the previous wrong code in the same patch, making it harder to review.


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


Заменяется на map


unsigned int


Should be max_segments AFAICT, since this is the initial number of segments provided when allocating the tag, which relates to the maximum number of segments per map.


This construct could be greatly simplified if `pXboxController->Gamepad.wButtons` was just initialized to zero.


Ну и удаляешь из коллекции этот товар после того как сервер ответит (ну или до того как сервер ответит, зависит от реализации)


The _dangerous void_ created by `selfdestruct` is that there is no longer any code at the address, by this address can still receive transactions and Ethers. These ethers are lost because there is no contract or private key to send them on.
The `onlyIfRunning` modifier is there to bounce transactions when "it is not running". Thus avoiding the void.
Of course, a _bricked_ contract is still part of the state, unlike a killed contract. So there are discussions in the Eth research team on how to incentivise developers to kill their contracts and thereby shrink the state.
That's a trade-off among many others here.


Во избежание конфликтов стилей твоих и библиотеки лучше избегать префикса webix_ в именах классов (по крайней мере до тех пор пока ты не расширяешь стили самой библиотеки)


gref_head doesn't need to be stored in bus_dmamap_xen AFAICT.


tar -zcvf archive_name.tar.gz folder_to_compress


// make all other states turn into preictal so that there are only two states;


big changes? Anything that could better inform the user which function is causing the problem.


It mist be massive lol. Please remove :)


Um, I thought since you could see exactly the lines that were changed, and not the whole thing, it would be _easier_ for you to review. Guess I was wrong. I'll keep it in mind next time. Sorry.


I thought it would be better. I'll remove the new one.


Trying this on artificial plugins that `add_copy_spec` the same directory with symlinks (i.e. mimicking 2 plugins adding same symlink at the same time), I get uncaught exception:

    # cat sos_logs/qpid4-plugin-errors.txtTraceback (most recent call last):
      File "/root/sos-bmr-reentrant-archive/sos/sosreport.py", line 1320, in collect_plugin
        plug.collect()
      File "/root/sos-bmr-reentrant-archive/sos/plugins/__init__.py", line 940, in collect
        self._collect_copy_specs()
      File "/root/sos-bmr-reentrant-archive/sos/plugins/__init__.py", line 898, in _collect_copy_specs
        self._do_copy_path(path)
      File "/root/sos-bmr-reentrant-archive/sos/plugins/__init__.py", line 435, in _do_copy_path
        self._copy_dir(srcpath)
      File "/root/sos-bmr-reentrant-archive/sos/plugins/__init__.py", line 381, in _copy_dir
        self._do_copy_path(os.path.join(srcpath, afile), dest=None)
      File "/root/sos-bmr-reentrant-archive/sos/plugins/__init__.py", line 435, in _do_copy_path
        self._copy_dir(srcpath)
      File "/root/sos-bmr-reentrant-archive/sos/plugins/__init__.py", line 381, in _copy_dir
        self._do_copy_path(os.path.join(srcpath, afile), dest=None)
      File "/root/sos-bmr-reentrant-archive/sos/plugins/__init__.py", line 435, in _do_copy_path
        self._copy_dir(srcpath)
      File "/root/sos-bmr-reentrant-archive/sos/plugins/__init__.py", line 381, in _copy_dir
        self._do_copy_path(os.path.join(srcpath, afile), dest=None)
      File "/root/sos-bmr-reentrant-archive/sos/plugins/__init__.py", line 435, in _do_copy_path
        self._copy_dir(srcpath)
      File "/root/sos-bmr-reentrant-archive/sos/plugins/__init__.py", line 381, in _copy_dir
        self._do_copy_path(os.path.join(srcpath, afile), dest=None)
      File "/root/sos-bmr-reentrant-archive/sos/plugins/__init__.py", line 435, in _do_copy_path
        self._copy_dir(srcpath)
      File "/root/sos-bmr-reentrant-archive/sos/plugins/__init__.py", line 381, in _copy_dir
        self._do_copy_path(os.path.join(srcpath, afile), dest=None)
      File "/root/sos-bmr-reentrant-archive/sos/plugins/__init__.py", line 431, in _do_copy_path
        self._copy_symlink(srcpath)
      File "/root/sos-bmr-reentrant-archive/sos/plugins/__init__.py", line 353, in _copy_symlink
        self.archive.add_link(reldest, dstpath)
      File "/root/sos-bmr-reentrant-archive/sos/archive.py", line 304, in add_link
        dest = self._check_path(link_name, P_LINK)
      File "/root/sos-bmr-reentrant-archive/sos/archive.py", line 216, in _check_path
        raise ValueError(ve_msg % (dest, "symbolic link"))
    ValueError: path '/var/tmp/sos.NXAtt5/sosreport-pmoravec-sat63-2018-06-18-pqiwmrv/var/lib/qpidd/.qpidd/qls/jrnl2/celery/e9d1ddd0-9b0f-42e1-a83b-ec2a8e2373aa.jrnl' exists and is not a symbolic link

    # file /var/lib/qpidd/.qpidd/qls/jrnl2/celery/e9d1ddd0-9b0f-42e1-a83b-ec2a8e2373aa.jrnl
    /var/lib/qpidd/.qpidd/qls/jrnl2/celery/e9d1ddd0-9b0f-42e1-a83b-ec2a8e2373aa.jrnl: symbolic link to `/var/lib/qpidd/.qpidd/qls/p001/efp/2048k/in_use/e9d1ddd0-9b0f-42e1-a83b-ec2a8e2373aa.jrnl'
    #


All right. I'll change it.


Also, I don't think nsegments should be unsigned int. This is passed to tag create as an int.


+ надо предусмотреть обработку ошибок (при провалившейся попытке удаления товара надо показать какое-то сообщение юзеру и:
- вернуть товар на место если он был удален не дожидаясь ответа с сервера
ИЛИ
- удалить товар если сервер не прислал никакой ошибки, и мы дожидались ответа с сервера для удаления


hi!  i say  how are you?


same issue...

```
~$ sudo helm version
Client: &version.Version{SemVer:"v2.8.0", GitCommit:"14af25f1de6832228539259b821949d20069a222", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.8.0", GitCommit:"14af25f1de6832228539259b821949d20069a222", GitTreeState:"clean"}
```


Yes. I click left. But problem is in right side.


Since we are allocating the grant references per map, I think it should be stored for each map, so it represents the grant entries allocated for each map. Why do you think it is better stored in bus_dma_tag_xen?


Hahaha – cant even remember why I consoled that – the only joy in my life is making console logs with funny messages

All removed

From: Dino H [mailto:notifications@github.com]
Sent: 18 June 2018 11:17
To: MacmillanCancerSupport/pattern-library <pattern-library@noreply.github.com>
Cc: Aston Haigh <AHaigh@macmillan.org.uk>; Author <author@noreply.github.com>
Subject: Re: [MacmillanCancerSupport/pattern-library] High low fix (19bddd8)

This Message originated outside your organisation.
________________________________

It mist be massive lol. Please remove :)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://github.com/MacmillanCancerSupport/pattern-library/commit/19bddd80cbcb13869fa8b64b8972a531c3244fa0#commitcomment-29398303>, or mute the thread<https://github.com/notifications/unsubscribe-auth/Ak3wksCVmE7Vbynm-OoJVMioYMPwHMcbks5t934NgaJpZM4UrfZj>.
**********************************************************************************
This message is confidential. It may not be disclosed to, or used by, anyone other than the addressee, without the consent of the sender.
If you receive this message in error, please advise the sender immediately.  The contents of this email including any attachment(s) may contain software viruses, which could damage your computer system. While Macmillan has taken every reasonable precaution to minimise this risk, we cannot accept liability for any damage, which you sustain as a result of software viruses. You should carry out your own virus checks before opening the attachment.

A list of trustees and directors of Macmillan Cancer Support is available for inspection at our registered office, 89 Albert Embankment, London, SE1 7UQ

Macmillan Cancer Support, registered charity in England and Wales (261017), Scotland (SC039907) and the Isle of Man (604). A company limited by guarantee.

Registered in England and Wales company number 2400969. Isle of Man company number 4694F.
Registered office: 89 Albert Embankment, London SE1 7UQ.
**********************************************************************************


Write a commit message that describes your changes.
Click Commit changes button.


Please, remove commented code.


Just new steps follow tutorial.


Personalizando el dominio


But we use it later during unload. Is it better to use gnttab_end_foreign_access_ref() instead to free the entries?


AFAICT you should do `segcount = *segp + 1;` see for example the code that implements load_bio:

http://fxr.watson.org/fxr/source/kern/subr_bus_dma.c#L451


IBM Cloud [toolchain](https://console.bluemix.net/devops/toolchains/6fbc7a48-a08d-4d4d-ace7-cb823c753512?env_id=ibm%3Ayp%3Aeu-de "CloudCo"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/0eb57583-e6a6-4415-8ed2-7e12e1803f7c?env_id=ibm%3Ayp%3Aeu-de "bot (master)") deployed [cloudco-insurance-bot](https://github.com/VidyasagarMSC/cloudco-insurance-bot/releases/tag/deploy-ibm-yp-eu-de-vidyasagar.msc-in.ibm.com-Demo-20180618-103255 "deploy-ibm-yp-eu-de-vidyasagar.msc-in.ibm.com-Demo-20180618-103255") to [Demo](https://console.bluemix.net/apps/a49c91ae-9ece-49fc-8e60-000c790cf422?env_id=ibm:yp:eu-de "ibm:yp:eu-de:vidyasagar.msc@in.ibm.com:Demo"), including this commit


@milouk of course it's better
it just increase cores freq to max during screen-on sequence
Also i'm testing a new input_boost from sultan which has this driver internally


That's likely not true. segp will likely be `-1` before calling `_bus_dmamap_load_phys`, and will point to the last used segment after the call to `_bus_dmamap_load_phys`. So you have to do *segp++ in order to get the number of segments used.


You don't need the cast here.


✅ [Jenkins job](http://xamarin-jenkins.guest.corp.microsoft.com:8080/job/macios/job/xcode10/17/display/redirect) (on internal Jenkins) succeeded

✅ [Build succeeded](http://xamarin-jenkins.guest.corp.microsoft.com:8080/job/macios/job/xcode10/17//console)
✅ [API Diff (from stable)](http://xamarin-storage/jenkins/xamarin-macios/xcode10/2aaee04e56b9b639d160a839d950eeaa7ae7b711/17/jenkins-results/api-diff/index.html)
✅ [API Diff (from PR only)](http://xamarin-storage/jenkins/xamarin-macios/xcode10/2aaee04e56b9b639d160a839d950eeaa7ae7b711/17/jenkins-results/apicomparison/index.html) (please review changes)
✅ [Generator Diff](http://xamarin-storage/jenkins/xamarin-macios/xcode10/2aaee04e56b9b639d160a839d950eeaa7ae7b711/17/jenkins-results/generator-diff/index.html) (only version changes)
✅ [Test run succeeded](http://xamarin-storage/jenkins/xamarin-macios/xcode10/2aaee04e56b9b639d160a839d950eeaa7ae7b711/17/jenkins-results/tests/index.html)


Remember you can use WordPress functions like `get_site_url()` in acceptance tests. They just don't run in the same request obviously so you can use hooks.


Yeah, I noticed. But [busdma_bounce.c:645](http://fxr.watson.org/fxr/source/x86/x86/busdma_bounce.c#L645) says:

> segp contains the starting segment on entrace, and the ending segment on exit.

So I think this more accurately computes the value of segcount.

Also, while there is no comment in busdma_dmar.c saying this, but the code there does the same. It increments segp by the number of segments used, so I don't think it is implementation specific.


@Xottab-DUTY So he cut everything...


@Artemex, true 1935


Try now? Should have perms ...


Like I said in a comment above, [busdma_bounce.c:645](http://fxr.watson.org/fxr/source/x86/x86/busdma_bounce.c#L645) says this.


Seems to cure issue #35!

See there is more work to do:
[    2s] Found files matching debian.*, running debian transformer...
[    2s] None of the files looks like a usable source tarball.
[    2s] ** Started: debtransform /var/tmp/build-root/Debian_9.0-x86_64/usr/src/packages/SOURCES /var/tmp/build-root/Debian_9.0-x86_64/usr/src/packages/SOURCES/cfg2html.dsc /var/tmp/build-root/Debian_9.0-x86_64/usr/src/packages/SOURCES.DEB
[    2s] No DEBTRANSFORM-TAR line in the .dsc file.
[    2s] Attempting automatic discovery of a suitable source archive.
[    2s] debian transforming failed.
[    2s]
[    2s] dell failed "build cfg2html.dsc" at Mon Jun 18 10:36:49 UTC 2018.


I've seen the above code repeated in three different places. You should add a helper that does:
1. Alloc xenmap->refs
2. Alloc grant references.
3. Calls gnttab_grant_foreign_access_ref in order to perform the granting.


Actually, now that I think about it, this is probably the better way.


Why do you do the gnttab_grant_foreign_access_ref here instead of doing it on _load functions?


Ok. Will do.


@Alvipe Of course i did tried open [Open MYO](https://github.com/Alvipe/Open-Myo)
but i ended up having slower frames than [myo_raw_dzhu](https://github.com/dzhu/myo-raw)
Do you know what may be the problem , Knowing that um using the  Bluetooth OF Raspberry-pi


This fixes issue #14


You can pass -1 on the _load functions in order to signal that there are no segments allocated at all (segs == NULL). But when you create the busdma tag, a negative value is not allowed, hence here using unsigned int to store the maximum number of segments seems more correct to me.


Does this actually improve internet Speed have you tested it? @mortezadadgar


@szerintedmi & @reyrodrigez @ what do you think about this? pls check the [preview](https://nav-separation--augmint.netlify.com/).
i think in the future at one point, when the user is "logged in/connected" then the button should probably say something like `Account` or similar, instead of `Use A-EUR`.
but now if you open augmint in another tab (not in the tab you are already connected) then it will say use A-EUR again (as static pages do not connect).
i can change it back to `Use A-EUR` for now, i just wanted to show the ux feeling of it.


@Alvipe Of course i did tried open [Open MYO](https://github.com/Alvipe/Open-Myo)
but i ended up having slower frames than [myo_raw_dzhu](https://github.com/dzhu/myo-raw)
Do you know what may be the problem , Knowing that um using the ordinary Bluetooth dongle of the myo
and all i have changed to receive an 512*8 numpy array
`
def process_emg(emg):
    #print(emg)
    global b
    b= np.append(b,[[emg[0],emg[1],emg[2],emg[3],emg[4],emg[5],emg[6],emg[7]]],0)
    if b.shape[0]==512:
        final(b)`


OK, that's fine, but then there are other things that you need to fix. For example in the _complete handler you have:
```C
	for (i = 0; i < xenmap->nrefs; i++)
 		gnttab_grant_foreign_access_ref(refs[i], domid, segs[i].ds_addr, 0);
```
Here you don't take segp into account, this should be:

```C
	for (i = *inital_segp; i < xenmap->nrefs; i++)
 		gnttab_grant_foreign_access_ref(refs[i], domid, segs[i].ds_addr, 0);
```
Where `initial_segp = (*segp == -1) ? 0 : *segp;` I think.


no need to flush as we close stream in next line?


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


Published :)


Thanks, it worked: https://pypi.org/project/dependency_injection/1.2.0/


php artisan make:controller Admin\TagsController --resource


@jknack I'm using Jooby 1.4.0 release, which, as far as I can tell.,  doesn't support Java10.
I thought I would be required to follow this commit in my own pom to make it work.
Are you saying just changing `java.source.version` would take care of all the Java10+ changes?


php artisan make:controller Admin\CategoriesController --resource


Lofty's suggestion:

```asm
xor ax,ax
or ax,[si]
shl ax,8
or ax,[si]
```


A generated website with your changes can be accessed here: https://doc-review.qlikcore.com/880


Simply because it is convenient. It is not trivial to access the segs array from the load functions. What the upper layer functions do is call the load with segs as `NULL` (check [sys/kern/subr_bus_dma.c:317](http://fxr.watson.org/fxr/source/kern/subr_bus_dma.c#L317)). So, the segs we see in our load is a NULL pointer and the segment array is stored in the parent tag ([sys/x86/x86/busdma_bounce.c:714](http://fxr.watson.org/fxr/source/x86/x86/busdma_bounce.c#L714)).

If I want to grant the access in _load functions, I'll have to access the [segments array](http://fxr.watson.org/fxr/source/x86/x86/busdma_bounce.c#L74) in the parent tag. This would mean I am doing something assuming something about the implementation I'm not supposed to know. Any change to the tag would break our code.

But in map_complete(), the parent's code returns us the array, so it is safe and convenient to use.


@milouk yeah wifi bonding could improve net speed but didn't test it on my own


@mortezadadgar im gonna give it a spin


The changes to  db/install.xml (commentsformat and dpocommentformat) are not reflected in the update.php file.

As a result my sites do not pass the check database schema test
 + php admin/cli/check_database_schema.php
 -------------------------------------------------------------------------------
 tool_dataprivacy_request
  * column 'commentsformat' is missing
  * column 'dpocommentformat' is missing
 -------------------------------------------------------------------------------


Ok. I'll change it to unsigned int.


为什么我的还没更新啊？


looks like 500k games LTC tuning makes wonders, congrats!


Thanks for pointing it out. I'll fix it.


Congratulations, an outstanding performance!


Why don't rename it to be like sensor.vendor?


Updating to gcc 7.3.0 causes many undefined reference to __imp___acrt_iob_func


Failing to alloc the grant references shouldn't be fatal. As said, grant references are scarce, and a shortage can happen. Instead you should find a way to use `gnttab_request_free_callback` (or some similar method) so that you can get notified when grant references are available.


Test name: Duration.fromObject is zero duration if the initial object has no units


like above


Amazing! Congrats!


I think that after calling `_bus_dmamap_load_buffer` you have the segment array in `segs` but if you think it's more convenient to do it here that's fine.


Great!


IBM Cloud [toolchain](https://console.bluemix.net/devops/toolchains/6fbc7a48-a08d-4d4d-ace7-cb823c753512?env_id=ibm%3Ayp%3Aeu-de "CloudCo"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/e22ae7db-4e76-4b76-a0a4-f91631e52c4f?env_id=ibm%3Ayp%3Aeu-de "dashboard (master)") deployed [cloudco-insurance-dashboard](https://github.com/VidyasagarMSC/cloudco-insurance-dashboard/releases/tag/deploy-ibm-yp-eu-de-vidyasagar.msc-in.ibm.com-Demo-20180618-110546 "deploy-ibm-yp-eu-de-vidyasagar.msc-in.ibm.com-Demo-20180618-110546") to [Demo](https://console.bluemix.net/apps/4a4fa941-6906-497a-9096-e34d42f5c9f2?env_id=ibm:yp:eu-de "ibm:yp:eu-de:vidyasagar.msc@in.ibm.com:Demo"), including this commit


@luckyh hi I dived deeper to the problem and it seems it is caused by aexpect 1.5.1, which is installed since in requirements.txt is line
`aexpect>=1.3.1,!=1.5.0`
If I downgrade aexpect to 1.4.0 (or 1.3.1), it works. So sorry for that hassle.
@ldoktor please take a look on it as you blacklisted aexpect 1.5.0 https://github.com/avocado-framework/avocado-vt/commit/e90ea4c7d07e6577a8565162020cb4b6849ab77b, version 1.5.1 may also need to be on blacklist. thanks


is this commit solve the credential issue ?


@favonia It's not unexpected that timjb/AgdaInfiniteLoopBug checks successfully. With this repository I tried to reproduce an infinite-loop bug in Agda 2.5.3 but I must have missed some essential thing. I never was so sad to see Agda succeed checking a project.

To me, Agda 2.5.4 seems to be a bit more buggy than 2.5.3, but I think that it may also be the case that Agda 2.5.3's bugs have already been worked around in the code base, while those of 2.5.4 haven't. I'm currently working with 2.5.3 and will stay on that version for that reason.


ok bye balaji


Ok


On Mon, 18 Jun 2018, Amilcar Lucas wrote:

> My bad, on a quick look, it looked like that code was running all the time.
> Where does it make sure to set only once?

https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_RTC/AP_RTC.cpp#L43


Ok. I'll try to get it to work.


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


The interface it's slightly more complex that what I expected. So it seems like the _load functions can be called multiple times and the `segs` array can be increased by those multiple calls. Let's revisit this once you have split the code into a generic helper used by all the _load functions.


done, thank you and split all these small files out.


#1786 This looks like the buggy line


Done, but haven't linked it up to Splitter yet, it's in its own file.


@rdkdd it's actually the opposite. The 1.5.1 was finally released which means we can re-send all the `>1.5.0` dependent features and update the requirements to require `>1.5.1`.

(the 1.5.0+ is incompatible with <1.5.0 in some aspects like fd passing, but it is py2/py3 compatible. That's why it's important for Avocado-vt)


ah i see the point about shrinking the state, thank you very much xavier. so I should leave that kill where it is so the owner can clean up the state, set isRunning in kill() to false as a first line and then require(isRunning) in every transaction?


Will do :-)


Для совместимости браузеров плагин самостоятельно добавляет. Как и те самые префиксы.


Про скобки буду знать.


hmm? while we serialize+deserialize we won't receive any events. but the udev database and mountinfo/swap tables will see them. So we need to catch up when coming back, and we do that by looking at the database/tables. What we see there lost all temporal relationship, so we need to make the best of everything we read from it, and thus act on it only after we learnt the full new state, and thus a bitmask is pretty handy as it allows us to figure out the full state first, and then in the final "catchup" state act on the fully new state view.


Thank you both, I knew that point but missed that point completely if you see what I mean. I'll take a look.


A generated website with your changes can be accessed here: https://doc-review.qlikcore.com/881


Thank you :-)


@poacher2k I've tweaked the CSS a little bit, so the avatar and stuff is aligned center vertically and we don't have to add `margin` anymore.


@timjb Sorry for being unclear. I expected that it type-checked according to your message, but (just got the numbers) I did not expect it would take 773 seconds on my machine. I will try 2.5.4.1 some time.


Fixed, cheers.


Congratulations! And its scales nice!


hi @sofianehaddad, you see I tried to start to work on osx with this commit, but I gave up


Nice, looking good!


I notice PassedFile is now asymmetric, which is something that tuning patches have been rejected for in the past.


A generated website with your changes can be accessed here: https://doc-review.qlikcore.com/883


@candirufish
Why test directly at LTC?


IBM Cloud [toolchain](https://console.bluemix.net/devops/toolchains/6fbc7a48-a08d-4d4d-ace7-cb823c753512?env_id=ibm%3Ayp%3Aeu-de "CloudCo"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/e22ae7db-4e76-4b76-a0a4-f91631e52c4f?env_id=ibm%3Ayp%3Aeu-de "dashboard (master)") deployed [cloudco-insurance-dashboard](https://github.com/VidyasagarMSC/cloudco-insurance-dashboard/releases/tag/deploy-ibm-yp-eu-de-vidyasagar.msc-in.ibm.com-Demo-20180618-112813 "deploy-ibm-yp-eu-de-vidyasagar.msc-in.ibm.com-Demo-20180618-112813") to [Demo](https://console.bluemix.net/apps/42deaa68-7361-45a5-a40b-7beaced0e50c?env_id=ibm:yp:eu-de "ibm:yp:eu-de:vidyasagar.msc@in.ibm.com:Demo"), including this commit


So your rear camera can work with the source?


This looks to be a typo :)


I think so. I have S5K4ECGX rear sensor and SR200PC20 for the front


@milouk you should first cherry-pick quick thaw


Congrats!!


I think I am in the same case as you :D. Why is sam messing thing up!??


'#' + currentID


Do you think we need both checks?
Is there a realistic situation where the variable would be defined but empty?


@Halolo The patch Add-Mali-Node.patch does not apply to this kernel.


I understand, because the mapping between address and balance is by default 0 for any address. Definitely agree re > 0. Wasted gas. Fixed.


@mortezadadgar  i thought so. could you point me to the commit?


Fix. Cells could not to attached to snake when snake C-tor is called.


A test should not be marked as skipped if it was evaluated successfully, thus there should not be an exception thrown here.


Congrats!


Instead of calling `assertTrue(false)`, please call `fail()`. And do it directly after the line that is expected to throw, like visible [here](http://errorprone.info/bugpattern/MissingFail).


changed for japan prius


This should revert the 1.5.0+ changes https://github.com/avocado-framework/avocado-vt/pull/1623


My Grand Prime VE has full camera source codes working on N luckily
Before that, I had to merge tons of files from sprd kernel to Sammy's, which took plenty of my time

Sadly, I lost the phone. Now I have to play with core33g. Time story once again begins


功能需求建模


@Alvipe  I discovered where is the problem :D
so the problem of slowness was because of using EMG_Filtered instead of EMG_RAW
Further more when I use Filtered_EMG i got 8 column of data in each frame like this ::

![f](https://user-images.githubusercontent.com/26032494/41533687-f099527a-72fb-11e8-8b8e-78ffcec19c7f.PNG)
But when i use RAW_EMG i get 2 sets of frames at a time ,, Can you tell what is this for please ?? @Alvipe

![ff](https://user-images.githubusercontent.com/26032494/41533783-4cfb537e-72fc-11e8-8101-537a10a1ef55.PNG)


No, I don't think so. I just wanted to exactly keep the existing behavior.
In fact, it may be better to run the deployment script if a user defines `CODACY_PROJECT_TOKEN` or `GH_TOKEN` as empty, Otherwise, the (probable) fault will be shadowed.


### Results for event id: 464c83b8-46fd-4974-8b9e-9c2ec5408660
DockerServerless : Deploy to Lambda (3a2d1e) Execution completed.

**output tail (194 lines total):**

```
...
CloudFormation - UPDATE_COMPLETE - AWS::ApiGateway::Stage - ApiGatewayStage
CloudFormation - UPDATE_COMPLETE_CLEANUP_IN_PROGRESS - AWS::CloudFormation::Stack - sample-kms-dev-master
CloudFormation - DELETE_IN_PROGRESS - AWS::ApiGateway::Deployment - ApiGatewayDeployment1529109962278
CloudFormation - DELETE_COMPLETE - AWS::ApiGateway::Deployment - ApiGatewayDeployment1529109962278
CloudFormation - UPDATE_COMPLETE - AWS::CloudFormation::Stack - sample-kms-dev-master
Serverless: Stack update finished...
Service Information
service: sample-kms
stage: dev
region: ap-southeast-2
stack: sample-kms-dev
api keys:
  None
endpoints:
  GET - https://b6krzg11sl.execute-api.ap-southeast-2.amazonaws.com/dev/sample-kms/{id}
functions:
  sample-kms: sample-kms-dev-sample-kms

Stack Outputs
ApiGatewayRestApiRootResource: yjaihomsia
ApiGatewayRestApi: b6krzg11sl
SampleDashkmsLambdaFunctionArn: arn:aws:lambda:ap-southeast-2:347186442473:function:sample-kms-dev-sample-kms
ServiceEndpoint: https://b6krzg11sl.execute-api.ap-southeast-2.amazonaws.com/dev
ServerlessDeploymentBucketName: sample-kms-dev-serverlessdeploymentbucket-kf11d97ottnc
ServerlessAliasReference: REFERENCE

Serverless: Removing old service versions...
Done in 116.49s.
ALL DEPLOYS SUCCESSFUL

```

https://github.com/apocas/dockerode


@milouk No find yourself LOL
here : https://github.com/mortezadadgar/bullhead/commit/8a6c9fea53b6240f692ae7c989efc82b2d619c9c#diff-0abef55a5d7f7f413fd54daed6ebb61a


Using static imports would make this better readable.


Дошло наконец...


@ldoktor ok thanks. I tried it with aexpect 1.5.1 and without https://github.com/avocado-framework/avocado-vt/pull/1605 and it works.


hmm typo


Ah, ok!