[inst/extdata/asalmon_mcw/main.r:2:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/inst/extdata/asalmon_mcw/main.r#L2) *style:* **Variable or function name should be snake_case.**
```r
LAMBDA_var <- 0.1 #Thin plate spline smoothing. Lambda=0 would be interpolation.
^~~~~~~~~~
```
[inst/extdata/asalmon_mcw/main.r:3:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/inst/extdata/asalmon_mcw/main.r#L3) *style:* **Variable or function name should be snake_case.**
```r
RESOLUTION_var <- 500 #Plot width in pixels
^~~~~~~~~~~~~~
```
[inst/extdata/asalmon_mcw/main.r:5:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/inst/extdata/asalmon_mcw/main.r#L5) *style:* **Lines should not be more than 80 characters.**
```r
#TODO change path. make sure this main.r script is just outside the diagram_retina folder.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/extdata/asalmon_mcw/main.r:8:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/inst/extdata/asalmon_mcw/main.r#L8) *style:* **Lines should not be more than 80 characters.**
```r
#todo verify these. see the tutorial here: https://github.com/bc/retina/blob/master/tutorial.md search for the part that starts with "#[V point of the tear,"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/extdata/asalmon_mcw/main.r:10:10:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/inst/extdata/asalmon_mcw/main.r#L10) *style:* **Commas should always have a space after.**
```r
    c(59,52,67),
         ^
```
[inst/extdata/asalmon_mcw/main.r:10:13:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/inst/extdata/asalmon_mcw/main.r#L10) *style:* **Commas should always have a space after.**
```r
    c(59,52,67),
            ^
```
[inst/extdata/asalmon_mcw/main.r:11:10:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/inst/extdata/asalmon_mcw/main.r#L11) *style:* **Commas should always have a space after.**
```r
    c(79,73,85),
         ^
```
[inst/extdata/asalmon_mcw/main.r:11:13:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/inst/extdata/asalmon_mcw/main.r#L11) *style:* **Commas should always have a space after.**
```r
    c(79,73,85),
            ^
```
[inst/extdata/asalmon_mcw/main.r:12:10:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/inst/extdata/asalmon_mcw/main.r#L12) *style:* **Commas should always have a space after.**
```r
    c(34,31,37))
         ^
```
[inst/extdata/asalmon_mcw/main.r:12:13:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/inst/extdata/asalmon_mcw/main.r#L12) *style:* **Commas should always have a space after.**
```r
    c(34,31,37))
            ^
```
[inst/extdata/asalmon_mcw/main.r:13:69:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/inst/extdata/asalmon_mcw/main.r#L13) *error:* **unexpected ')'**
```r
                                                                    )
                                                                    ^
```
[R/composite.R:2:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/composite.R#L2) *style:* **Lines should not be more than 80 characters.**
```r
##' @description This is a subfunction, that is useful when creating average maps.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/composite.R:3:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/composite.R#L3) *style:* **Lines should not be more than 80 characters.**
```r
##' @param retina_list A list containing retina objects, with names(retina_list) all defined.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/composite.R:4:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/composite.R#L4) *style:* **Lines should not be more than 80 characters.**
```r
##' @param rotation_indices Each value in this vector will correspond to the amount of rotation applied to each retina in the list.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/composite.R:5:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/composite.R#L5) *style:* **Lines should not be more than 80 characters.**
```r
##' @param ... Arguments passed from other functions. You can access the thin plate spline interpolator here.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/composite.R:6:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/composite.R#L6) *style:* **Lines should not be more than 80 characters.**
```r
##' @return sum_mat The sum of all retina objects in the list, with respect to the rotation indices.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/composite.R:9:14:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/composite.R#L9) *warning:* **no visible global function definition for ‘mat_from_ret_obj’**
```r
  sum_mat <- mat_from_ret_obj(retina_list[[1]], rotation = 0, ...)
             ^~~~~~~~~~~~~~~~
```
[R/matrix_retobj.R:3:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/matrix_retobj.R#L3) *style:* **Lines should not be more than 80 characters.**
```r
##' You can decide how much to rotate the retina before returning the matrix. You can also pass arguments to the polar plotter.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/matrix_retobj.R:6:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/matrix_retobj.R#L6) *style:* **Lines should not be more than 80 characters.**
```r
##' @param n the number by which to divide the matrix by. Useful when generating partial averages.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/matrix_retobj.R:7:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/matrix_retobj.R#L7) *style:* **Lines should not be more than 80 characters.**
```r
##' @param reflect logical, by default it is TRUE, in order to view the retina from outside the eye (rather than from within.)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/matrix_retobj.R:20:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/matrix_retobj.R#L20) *style:* **Lines should not be more than 80 characters.**
```r
  az <- mapproject(x = retina_object$trimmed_data[, 2], retina_object$trimmed_data[,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/matrix_retobj.R:27:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/matrix_retobj.R#L27) *style:* **Lines should not be more than 80 characters.**
```r
  map2fit <- fit_plot_azimuthal(x2, y2, z2, plot_suppress = TRUE, extrapolate = TRUE,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/matrix_retobj.R:28:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/matrix_retobj.R#L28) *style:* **Lines should not be more than 80 characters.**
```r
    outer_radius = pi/2, falciform_coords = retina_object$azimuthal_data.falciform[[1]],
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/matrix_retobj.R:28:22:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/matrix_retobj.R#L28) *style:* **Put spaces around all infix operators.**
```r
    outer_radius = pi/2, falciform_coords = retina_object$azimuthal_data.falciform[[1]],
                    ~^~
```
[R/matrix_retobj.R:30:3:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/matrix_retobj.R#L30) *style:* **Variable or function name should be snake_case.**
```r
  MAT <- map2fit[[2]]$z
  ^~~
```
[R/matrix_retobj.R:32:13:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/matrix_retobj.R#L32) *style:* **Put spaces around all infix operators.**
```r
  return(MAT/n)
           ~^~
```
[R/plotting_functions.R:3:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L3) *style:* **Lines should not be more than 80 characters.**
```r
##' Extracts xy and falciform coordinates from datapoints collected from retistruct. Falc and Datapoints are stacked upon one another
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:5:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L5) *style:* **Lines should not be more than 80 characters.**
```r
##' @param datapoints_from_retistruct data structure that comes from the datapoints.csv, which is automatically generated by Retistruct.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:7:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L7) *style:* **Lines should not be more than 80 characters.**
```r
##' @return L list of pixel xy positions, and falciform coordinates in [1] and [2], respectively
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:9:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L9) *style:* **Lines should not be more than 80 characters.**
```r
extract_xy_and_falciform <- function(datapoints_from_retistruct, number_of_sampling_sites) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:10:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L10) *style:* **Use spaces to indent, not tabs.**
```r
	pixel_xy_positions <- datapoints_from_retistruct[1:number_of_sampling_sites,]
^
```
[R/plotting_functions.R:10:78:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L10) *style:* **Commas should always have a space after.**
```r
	pixel_xy_positions <- datapoints_from_retistruct[1:number_of_sampling_sites,]
                                                                             ^
```
[R/plotting_functions.R:11:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L11) *style:* **Lines should not be more than 80 characters.**
```r
	falciform_len <- length(datapoints_from_retistruct[,1]) - length(pixel_xy_positions[,1])
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:11:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L11) *style:* **Use spaces to indent, not tabs.**
```r
	falciform_len <- length(datapoints_from_retistruct[,1]) - length(pixel_xy_positions[,1])
^
```
[R/plotting_functions.R:11:2:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L11) *warning:* **local variable ‘falciform_len’ assigned but may not be used**
```r
	falciform_len <- length(datapoints_from_retistruct[,1]) - length(pixel_xy_positions[,1])
 ^~~~~~~~~~~~~
```
[R/plotting_functions.R:11:54:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L11) *style:* **Commas should always have a space after.**
```r
	falciform_len <- length(datapoints_from_retistruct[,1]) - length(pixel_xy_positions[,1])
                                                     ^
```
[R/plotting_functions.R:11:87:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L11) *style:* **Commas should always have a space after.**
```r
	falciform_len <- length(datapoints_from_retistruct[,1]) - length(pixel_xy_positions[,1])
                                                                                ^
```
[R/plotting_functions.R:12:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L12) *style:* **Use spaces to indent, not tabs.**
```r
	xy_len <- length(pixel_xy_positions[,1])
^
```
[R/plotting_functions.R:12:39:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L12) *style:* **Commas should always have a space after.**
```r
	xy_len <- length(pixel_xy_positions[,1])
                                      ^
```
[R/plotting_functions.R:13:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L13) *style:* **Use spaces to indent, not tabs.**
```r
	total_len <- length(datapoints_from_retistruct[,1])
^
```
[R/plotting_functions.R:13:50:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L13) *style:* **Commas should always have a space after.**
```r
	total_len <- length(datapoints_from_retistruct[,1])
                                                 ^
```
[R/plotting_functions.R:14:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L14) *style:* **Use spaces to indent, not tabs.**
```r
	falciform_coordinates <- datapoints_from_retistruct[(xy_len+1):total_len,]
^
```
[R/plotting_functions.R:14:61:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L14) *style:* **Put spaces around all infix operators.**
```r
	falciform_coordinates <- datapoints_from_retistruct[(xy_len+1):total_len,]
                                                           ~^~
```
[R/plotting_functions.R:14:75:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L14) *style:* **Commas should always have a space after.**
```r
	falciform_coordinates <- datapoints_from_retistruct[(xy_len+1):total_len,]
                                                                          ^
```
[R/plotting_functions.R:15:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L15) *style:* **Use spaces to indent, not tabs.**
```r
	return(list(pixel_xy_positions, falciform_coordinates))
^
```
[R/plotting_functions.R:20:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L20) *style:* **Lines should not be more than 80 characters.**
```r
##' ImageJ values don't always show up the right way, because Y values get larger and positive while moving down the image.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:22:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L22) *style:* **Lines should not be more than 80 characters.**
```r
##' @param falciform_xy_coordinates 2 columns of coordinate (X,Y) data in ImageJ pixel format
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:26:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L26) *style:* **Lines should not be more than 80 characters.**
```r
reflect_IJ_y_values_for_falciform <- function(falciform_xy_coordinates, xy_img_dimensions){
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:26:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L26) *style:* **Variable and function names should not be longer than 30 characters.**
```r
reflect_IJ_y_values_for_falciform <- function(falciform_xy_coordinates, xy_img_dimensions){
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:26:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L26) *style:* **Variable or function name should be snake_case.**
```r
reflect_IJ_y_values_for_falciform <- function(falciform_xy_coordinates, xy_img_dimensions){
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:27:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L27) *style:* **Use spaces to indent, not tabs.**
```r
		falciform_xy_coordinates_transformed <- falciform_xy_coordinates #make a copy
^~
```
[R/plotting_functions.R:27:3:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L27) *style:* **Variable and function names should not be longer than 30 characters.**
```r
		falciform_xy_coordinates_transformed <- falciform_xy_coordinates #make a copy
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:28:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L28) *style:* **Use spaces to indent, not tabs.**
```r
		falc_y <- falciform_xy_coordinates[,2]
^~
```
[R/plotting_functions.R:28:39:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L28) *style:* **Commas should always have a space after.**
```r
		falc_y <- falciform_xy_coordinates[,2]
                                      ^
```
[R/plotting_functions.R:29:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L29) *style:* **Use spaces to indent, not tabs.**
```r
		half_of_vertical_pixels <- xy_img_dimensions[2]/2
^~
```
[R/plotting_functions.R:29:50:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L29) *style:* **Put spaces around all infix operators.**
```r
		half_of_vertical_pixels <- xy_img_dimensions[2]/2
                                                ~^~
```
[R/plotting_functions.R:30:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L30) *style:* **Lines should not be more than 80 characters.**
```r
		falciform_xy_coordinates_transformed$cyan <- (falc_y-half_of_vertical_pixels)*-1 + half_of_vertical_pixels
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:30:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L30) *style:* **Use spaces to indent, not tabs.**
```r
		falciform_xy_coordinates_transformed$cyan <- (falc_y-half_of_vertical_pixels)*-1 + half_of_vertical_pixels
^~
```
[R/plotting_functions.R:30:55:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L30) *style:* **Put spaces around all infix operators.**
```r
		falciform_xy_coordinates_transformed$cyan <- (falc_y-half_of_vertical_pixels)*-1 + half_of_vertical_pixels
                                                     ~^~
```
[R/plotting_functions.R:30:80:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L30) *style:* **Put spaces around all infix operators.**
```r
		falciform_xy_coordinates_transformed$cyan <- (falc_y-half_of_vertical_pixels)*-1 + half_of_vertical_pixels
                                                                              ~^~
```
[R/plotting_functions.R:31:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L31) *style:* **Use spaces to indent, not tabs.**
```r
		return(falciform_xy_coordinates_transformed)
^~
```
[R/plotting_functions.R:35:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L35) *style:* **Lines should not be more than 80 characters.**
```r
##' Shows a visualization of the outline, as well as the location of each datapoint, with fit plot.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:37:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L37) *style:* **Lines should not be more than 80 characters.**
```r
##' @param pixel_xy_positions 2 columns of coordinate (X,Y) data in ImageJ pixel format
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:38:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L38) *style:* **Lines should not be more than 80 characters.**
```r
##' @param z_vector numerical vector of density values for each of the coordinates
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:39:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L39) *style:* **Lines should not be more than 80 characters.**
```r
##' @param xy_outline_points 2 columns of coordinate(X,Y) data in ImageJ pixel format for the outline coordinates.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:42:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L42) *style:* **Lines should not be more than 80 characters.**
```r
traditional_flatmount_plot <- function(pixel_xy_positions,z_vector, xy_outline_points){
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:42:59:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L42) *style:* **Commas should always have a space after.**
```r
traditional_flatmount_plot <- function(pixel_xy_positions,z_vector, xy_outline_points){
                                                          ^
```
[R/plotting_functions.R:43:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L43) *style:* **Lines should not be more than 80 characters.**
```r
	fit <- Tps(pixel_xy_positions, z_vector)  # fits a surface to ozone measurements.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:43:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L43) *style:* **Use spaces to indent, not tabs.**
```r
	fit <- Tps(pixel_xy_positions, z_vector)  # fits a surface to ozone measurements.
^
```
[R/plotting_functions.R:43:9:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L43) *warning:* **no visible global function definition for ‘Tps’, Did you mean 'Ops'?**
```r
	fit <- Tps(pixel_xy_positions, z_vector)  # fits a surface to ozone measurements.
        ^~~
```
[R/plotting_functions.R:44:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L44) *style:* **Use spaces to indent, not tabs.**
```r
	set.panel(2,2)
^
```
[R/plotting_functions.R:44:2:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L44) *warning:* **no visible global function definition for ‘set.panel’**
```r
	set.panel(2,2)
 ^~~~~~~~~
```
[R/plotting_functions.R:44:14:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L44) *style:* **Commas should always have a space after.**
```r
	set.panel(2,2)
             ^
```
[R/plotting_functions.R:45:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L45) *style:* **Use spaces to indent, not tabs.**
```r
	plot(fit) # four diagnostic plots of  fit and residuals.
^
```
[R/plotting_functions.R:46:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L46) *style:* **Use spaces to indent, not tabs.**
```r
	set.panel()
^
```
[R/plotting_functions.R:46:2:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L46) *warning:* **no visible global function definition for ‘set.panel’**
```r
	set.panel()
 ^~~~~~~~~
```
[R/plotting_functions.R:47:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L47) *style:* **Use spaces to indent, not tabs.**
```r
	# summary of fit and estimates of lambda the smoothing parameter
^
```
[R/plotting_functions.R:48:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L48) *style:* **Use spaces to indent, not tabs.**
```r
	summary(fit)
^
```
[R/plotting_functions.R:49:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L49) *style:* **Use spaces to indent, not tabs.**
```r
	surface(fit) # Quick image/contour plot of GCV surface.
^
```
[R/plotting_functions.R:49:2:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L49) *warning:* **no visible global function definition for ‘surface’**
```r
	surface(fit) # Quick image/contour plot of GCV surface.
 ^~~~~~~
```
[R/plotting_functions.R:50:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L50) *style:* **Use spaces to indent, not tabs.**
```r
	return(fit)
^
```
[R/plotting_functions.R:58:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L58) *style:* **Lines should not be more than 80 characters.**
```r
##' Shows a visualization of the outline, as well as the location of each datapoint so the user can identify where the tears are.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:61:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L61) *style:* **Lines should not be more than 80 characters.**
```r
##' @param path_to_retina_data_folder The path to the folder that contains the outline.roi file.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:62:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L62) *style:* **Lines should not be more than 80 characters.**
```r
##' @return roi_coordinates XY vals of pixel coordinates of the outline points, in order.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:66:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L66) *style:* **Use spaces to indent, not tabs.**
```r
	roi_object <- read.ijroi(file.path(path_to_retina_data_folder, "outline.roi"))
^
```
[R/plotting_functions.R:66:16:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L66) *warning:* **no visible global function definition for ‘read.ijroi’**
```r
	roi_object <- read.ijroi(file.path(path_to_retina_data_folder, "outline.roi"))
               ^~~~~~~~~~
```
[R/plotting_functions.R:69:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L69) *style:* **Use spaces to indent, not tabs.**
```r
		## ImageJ ROI format plots has the coordinate (0, 0) in the top
^~
```
[R/plotting_functions.R:70:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L70) *style:* **Use spaces to indent, not tabs.**
```r
		  ## left.  We have the coordinate (0, 0) in the bottom left. We need
^~
```
[R/plotting_functions.R:71:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L71) *style:* **Use spaces to indent, not tabs.**
```r
		  ## to transform P so that the outline appears in the correct
^~
```
[R/plotting_functions.R:72:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L72) *style:* **Use spaces to indent, not tabs.**
```r
		  ## orientation.
^~
```
[R/plotting_functions.R:73:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L73) *style:* **Use spaces to indent, not tabs.**
```r
			im <- NULL
^~~
```
[R/plotting_functions.R:74:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L74) *style:* **Use spaces to indent, not tabs.**
```r
		  roi_XY_coords <- roi_object$coords
^~
```
[R/plotting_functions.R:74:5:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L74) *style:* **Variable or function name should be snake_case.**
```r
		  roi_XY_coords <- roi_object$coords
    ^~~~~~~~~~~~~
```
[R/plotting_functions.R:75:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L75) *style:* **Use spaces to indent, not tabs.**
```r
		  offset <- ifelse(is.null(im), max(roi_XY_coords[,2]), nrow(im))
^~
```
[R/plotting_functions.R:75:54:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L75) *style:* **Commas should always have a space after.**
```r
		  offset <- ifelse(is.null(im), max(roi_XY_coords[,2]), nrow(im))
                                                     ^
```
[R/plotting_functions.R:76:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L76) *style:* **Use spaces to indent, not tabs.**
```r
		  roi_XY_coords[,2] <- offset - roi_XY_coords[,2]
^~
```
[R/plotting_functions.R:76:20:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L76) *style:* **Commas should always have a space after.**
```r
		  roi_XY_coords[,2] <- offset - roi_XY_coords[,2]
                   ^
```
[R/plotting_functions.R:76:50:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L76) *style:* **Commas should always have a space after.**
```r
		  roi_XY_coords[,2] <- offset - roi_XY_coords[,2]
                                                 ^
```
[R/plotting_functions.R:79:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L79) *style:* **Lines should not be more than 80 characters.**
```r
	plot(roi_XY_coords, type="l", col='#d3d3d3', asp=1, xlab='X Pixels', ylab='Y Pixels');
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:79:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L79) *style:* **Use spaces to indent, not tabs.**
```r
	plot(roi_XY_coords, type="l", col='#d3d3d3', asp=1, xlab='X Pixels', ylab='Y Pixels');
^
```
[R/plotting_functions.R:79:26:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L79) *style:* **Put spaces around all infix operators.**
```r
	plot(roi_XY_coords, type="l", col='#d3d3d3', asp=1, xlab='X Pixels', ylab='Y Pixels');
                        ~^~
```
[R/plotting_functions.R:79:35:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L79) *style:* **Put spaces around all infix operators.**
```r
	plot(roi_XY_coords, type="l", col='#d3d3d3', asp=1, xlab='X Pixels', ylab='Y Pixels');
                                 ~^~
```
[R/plotting_functions.R:79:36:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L79) *style:* **Only use double-quotes.**
```r
	plot(roi_XY_coords, type="l", col='#d3d3d3', asp=1, xlab='X Pixels', ylab='Y Pixels');
                                   ^~~~~~~~~
```
[R/plotting_functions.R:79:50:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L79) *style:* **Put spaces around all infix operators.**
```r
	plot(roi_XY_coords, type="l", col='#d3d3d3', asp=1, xlab='X Pixels', ylab='Y Pixels');
                                                ~^~
```
[R/plotting_functions.R:79:58:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L79) *style:* **Put spaces around all infix operators.**
```r
	plot(roi_XY_coords, type="l", col='#d3d3d3', asp=1, xlab='X Pixels', ylab='Y Pixels');
                                                        ~^~
```
[R/plotting_functions.R:79:59:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L79) *style:* **Only use double-quotes.**
```r
	plot(roi_XY_coords, type="l", col='#d3d3d3', asp=1, xlab='X Pixels', ylab='Y Pixels');
                                                          ^~~~~~~~~~
```
[R/plotting_functions.R:79:75:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L79) *style:* **Put spaces around all infix operators.**
```r
	plot(roi_XY_coords, type="l", col='#d3d3d3', asp=1, xlab='X Pixels', ylab='Y Pixels');
                                                                         ~^~
```
[R/plotting_functions.R:79:76:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L79) *style:* **Only use double-quotes.**
```r
	plot(roi_XY_coords, type="l", col='#d3d3d3', asp=1, xlab='X Pixels', ylab='Y Pixels');
                                                                           ^~~~~~~~~~
```
[R/plotting_functions.R:80:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L80) *style:* **Lines should not be more than 80 characters.**
```r
	text(roi_XY_coords[,1],roi_XY_coords[,2], labels=1:length(roi_XY_coords[,1]), cex=0.5)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:80:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L80) *style:* **Use spaces to indent, not tabs.**
```r
	text(roi_XY_coords[,1],roi_XY_coords[,2], labels=1:length(roi_XY_coords[,1]), cex=0.5)
^
```
[R/plotting_functions.R:80:22:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L80) *style:* **Commas should always have a space after.**
```r
	text(roi_XY_coords[,1],roi_XY_coords[,2], labels=1:length(roi_XY_coords[,1]), cex=0.5)
                     ^
```
[R/plotting_functions.R:80:25:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L80) *style:* **Commas should always have a space after.**
```r
	text(roi_XY_coords[,1],roi_XY_coords[,2], labels=1:length(roi_XY_coords[,1]), cex=0.5)
                        ^
```
[R/plotting_functions.R:80:40:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L80) *style:* **Commas should always have a space after.**
```r
	text(roi_XY_coords[,1],roi_XY_coords[,2], labels=1:length(roi_XY_coords[,1]), cex=0.5)
                                       ^
```
[R/plotting_functions.R:80:50:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L80) *style:* **Put spaces around all infix operators.**
```r
	text(roi_XY_coords[,1],roi_XY_coords[,2], labels=1:length(roi_XY_coords[,1]), cex=0.5)
                                                ~^~
```
[R/plotting_functions.R:80:75:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L80) *style:* **Commas should always have a space after.**
```r
	text(roi_XY_coords[,1],roi_XY_coords[,2], labels=1:length(roi_XY_coords[,1]), cex=0.5)
                                                                          ^
```
[R/plotting_functions.R:80:83:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L80) *style:* **Put spaces around all infix operators.**
```r
	text(roi_XY_coords[,1],roi_XY_coords[,2], labels=1:length(roi_XY_coords[,1]), cex=0.5)
                                                                                ~^~
```
[R/plotting_functions.R:81:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L81) *style:* **Lines should not be more than 80 characters.**
```r
 	message('If you are getting this message, you are using a special feature. Contact me at brian.cohn@usc.edu and I will happily teach you how to use it.')
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:81:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L81) *style:* **Use spaces to indent, not tabs.**
```r
 	message('If you are getting this message, you are using a special feature. Contact me at brian.cohn@usc.edu and I will happily teach you how to use it.')
^~
```
[R/plotting_functions.R:81:11:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L81) *style:* **Only use double-quotes.**
```r
 	message('If you are getting this message, you are using a special feature. Contact me at brian.cohn@usc.edu and I will happily teach you how to use it.')
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:82:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L82) *style:* **Use spaces to indent, not tabs.**
```r
	return(roi_XY_coords)
^
```
[R/plotting_functions.R:89:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L89) *style:* **Lines should not be more than 80 characters.**
```r
##' @description Creates a markup.csv file. One of the dorsal_outline_index or nasal_outline_index must be filled in. Not both.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:92:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L92) *style:* **Lines should not be more than 80 characters.**
```r
##' @param dorsal_outline_index The index of the point that points toward dorsal, or NA.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:93:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L93) *style:* **Lines should not be more than 80 characters.**
```r
##' @param nasal_outline_index The index of the opint that points toward nasal, or NA.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:94:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L94) *style:* **Lines should not be more than 80 characters.**
```r
##' @param path_to_retina_data_folder The path where the markup.csv file will be saved.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:96:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L96) *style:* **Lines should not be more than 80 characters.**
```r
assemble_markup_file <- function(eye_left_or_right, path_to_retina_data_folder, dorsal_outline_index=NA, nasal_outline_index=NA) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:99:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L99) *style:* **Use spaces to indent, not tabs.**
```r
	firstup <- function(x) {
^
```
[R/plotting_functions.R:100:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L100) *style:* **Lines should not be more than 80 characters.**
```r
	##firstup function sourced from https://stackoverflow.com/questions/18509527/first-letter-to-upper-case
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:100:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L100) *style:* **Use spaces to indent, not tabs.**
```r
	##firstup function sourced from https://stackoverflow.com/questions/18509527/first-letter-to-upper-case
^
```
[R/plotting_functions.R:101:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L101) *style:* **Use spaces to indent, not tabs.**
```r
	   substr(x, 1, 1) <- toupper(substr(x, 1, 1))
^
```
[R/plotting_functions.R:102:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L102) *style:* **Use spaces to indent, not tabs.**
```r
	x
^
```
[R/plotting_functions.R:103:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L103) *style:* **Use spaces to indent, not tabs.**
```r
	}
^
```
[R/plotting_functions.R:104:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L104) *style:* **Use spaces to indent, not tabs.**
```r
	eye_side_string <- firstup(eye_left_or_right)
^
```
[R/plotting_functions.R:105:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L105) *style:* **Use spaces to indent, not tabs.**
```r
	if (is.na(dorsal_outline_index)){
^
```
[R/plotting_functions.R:106:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L106) *style:* **Use spaces to indent, not tabs.**
```r
	line2 <- paste0('NA,',
^
```
[R/plotting_functions.R:106:18:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L106) *style:* **Only use double-quotes.**
```r
	line2 <- paste0('NA,',
                 ^~~~~
```
[R/plotting_functions.R:107:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L107) *style:* **Use spaces to indent, not tabs.**
```r
									nasal_outline_index,
^~~~~~~~~
```
[R/plotting_functions.R:108:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L108) *style:* **Use spaces to indent, not tabs.**
```r
									',0,NA,TRUE,"',
^~~~~~~~~
```
[R/plotting_functions.R:109:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L109) *style:* **Use spaces to indent, not tabs.**
```r
									eye_side_string,
^~~~~~~~~
```
[R/plotting_functions.R:110:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L110) *style:* **Use spaces to indent, not tabs.**
```r
									'"')
^~~~~~~~~
```
[R/plotting_functions.R:111:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L111) *style:* **Use spaces to indent, not tabs.**
```r
	} else {
^
```
[R/plotting_functions.R:112:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L112) *style:* **Use spaces to indent, not tabs.**
```r
		line2 <- paste0(dorsal_outline_index,
^~
```
[R/plotting_functions.R:113:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L113) *style:* **Use spaces to indent, not tabs.**
```r
										',NA',
^~~~~~~~~~
```
[R/plotting_functions.R:113:11:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L113) *style:* **Only use double-quotes.**
```r
										',NA',
          ^~~~~
```
[R/plotting_functions.R:114:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L114) *style:* **Use spaces to indent, not tabs.**
```r
										',0,NA,TRUE,"',
^~~~~~~~~~
```
[R/plotting_functions.R:115:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L115) *style:* **Use spaces to indent, not tabs.**
```r
										eye_side_string,
^~~~~~~~~~
```
[R/plotting_functions.R:116:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L116) *style:* **Use spaces to indent, not tabs.**
```r
										'"')
^~~~~~~~~~
```
[R/plotting_functions.R:117:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L117) *style:* **Use spaces to indent, not tabs.**
```r
	}
^
```
[R/plotting_functions.R:118:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L118) *style:* **Use spaces to indent, not tabs.**
```r
	line1 = '"iD","iN","phi0","iOD","DVflip","side"'
^
```
[R/plotting_functions.R:118:8:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L118) *style:* **Use <-, not =, for assignment.**
```r
	line1 = '"iD","iN","phi0","iOD","DVflip","side"'
       ^
```
[R/plotting_functions.R:119:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L119) *style:* **Use spaces to indent, not tabs.**
```r
	output_path <- file.path(path_to_retina_data_folder, "markup.csv")
^
```
[R/plotting_functions.R:120:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L120) *style:* **Use spaces to indent, not tabs.**
```r
	file.create(output_path)
^
```
[R/plotting_functions.R:121:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L121) *style:* **Use spaces to indent, not tabs.**
```r
	write(line1,file=output_path,append=TRUE)
^
```
[R/plotting_functions.R:121:14:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L121) *style:* **Commas should always have a space after.**
```r
	write(line1,file=output_path,append=TRUE)
             ^
```
[R/plotting_functions.R:121:18:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L121) *style:* **Put spaces around all infix operators.**
```r
	write(line1,file=output_path,append=TRUE)
                ~^~
```
[R/plotting_functions.R:121:31:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L121) *style:* **Commas should always have a space after.**
```r
	write(line1,file=output_path,append=TRUE)
                              ^
```
[R/plotting_functions.R:121:37:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L121) *style:* **Put spaces around all infix operators.**
```r
	write(line1,file=output_path,append=TRUE)
                                   ~^~
```
[R/plotting_functions.R:122:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L122) *style:* **Use spaces to indent, not tabs.**
```r
	write(line2, file=output_path, append=TRUE)
^
```
[R/plotting_functions.R:122:19:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L122) *style:* **Put spaces around all infix operators.**
```r
	write(line2, file=output_path, append=TRUE)
                 ~^~
```
[R/plotting_functions.R:122:39:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L122) *style:* **Put spaces around all infix operators.**
```r
	write(line2, file=output_path, append=TRUE)
                                     ~^~
```
[R/plotting_functions.R:123:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L123) *style:* **Lines should not be more than 80 characters.**
```r
	message(paste('Wrote markup file to ',output_path, '\n Check that it exists beside your outline.roi file'))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:123:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L123) *style:* **Use spaces to indent, not tabs.**
```r
	message(paste('Wrote markup file to ',output_path, '\n Check that it exists beside your outline.roi file'))
^
```
[R/plotting_functions.R:123:16:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L123) *style:* **Only use double-quotes.**
```r
	message(paste('Wrote markup file to ',output_path, '\n Check that it exists beside your outline.roi file'))
               ^~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:123:40:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L123) *style:* **Commas should always have a space after.**
```r
	message(paste('Wrote markup file to ',output_path, '\n Check that it exists beside your outline.roi file'))
                                       ^
```
[R/plotting_functions.R:123:53:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L123) *style:* **Only use double-quotes.**
```r
	message(paste('Wrote markup file to ',output_path, '\n Check that it exists beside your outline.roi file'))
                                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:124:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L124) *style:* **Use spaces to indent, not tabs.**
```r
	print(line1)
^
```
[R/plotting_functions.R:125:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L125) *style:* **Use spaces to indent, not tabs.**
```r
	print(line2)
^
```
[R/plotting_functions.R:126:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L126) *style:* **Use spaces to indent, not tabs.**
```r
	return(0)
^
```
[R/plotting_functions.R:134:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L134) *style:* **Lines should not be more than 80 characters.**
```r
##' @param tear_coordinates_dataframe the dataframe of 3 columns, with c("V0","VB","VF"), and n columns, where n= number of tears
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:135:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L135) *style:* **Lines should not be more than 80 characters.**
```r
##' @param path_to_retina_data_folder The path where the T.csv file will be saved.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:139:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L139) *style:* **Lines should not be more than 80 characters.**
```r
assemble_tear_file <- function(tear_coordinates_dataframe, path_to_retina_data_folder){
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:140:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L140) *style:* **Use spaces to indent, not tabs.**
```r
	output_path <- file.path(path_to_retina_data_folder, "T.csv")
^
```
[R/plotting_functions.R:141:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L141) *style:* **Use spaces to indent, not tabs.**
```r
	colnames(tear_coordinates_dataframe)<- c("V0","VB","VF")
^
```
[R/plotting_functions.R:141:38:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L141) *style:* **Put spaces around all infix operators.**
```r
	colnames(tear_coordinates_dataframe)<- c("V0","VB","VF")
                                    ~^
```
[R/plotting_functions.R:141:48:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L141) *style:* **Commas should always have a space after.**
```r
	colnames(tear_coordinates_dataframe)<- c("V0","VB","VF")
                                               ^
```
[R/plotting_functions.R:141:53:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L141) *style:* **Commas should always have a space after.**
```r
	colnames(tear_coordinates_dataframe)<- c("V0","VB","VF")
                                                    ^
```
[R/plotting_functions.R:142:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L142) *style:* **Lines should not be more than 80 characters.**
```r
	write.table(tear_coordinates_dataframe, output_path, sep=',', row.names = FALSE)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:142:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L142) *style:* **Use spaces to indent, not tabs.**
```r
	write.table(tear_coordinates_dataframe, output_path, sep=',', row.names = FALSE)
^
```
[R/plotting_functions.R:142:58:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L142) *style:* **Put spaces around all infix operators.**
```r
	write.table(tear_coordinates_dataframe, output_path, sep=',', row.names = FALSE)
                                                        ~^~
```
[R/plotting_functions.R:142:59:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L142) *style:* **Only use double-quotes.**
```r
	write.table(tear_coordinates_dataframe, output_path, sep=',', row.names = FALSE)
                                                          ^~~
```
[R/plotting_functions.R:143:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L143) *style:* **Lines should not be more than 80 characters.**
```r
	message(paste('Wrote tear file to ',output_path, '\n Check that it exists beside your outline.roi file'))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:143:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L143) *style:* **Use spaces to indent, not tabs.**
```r
	message(paste('Wrote tear file to ',output_path, '\n Check that it exists beside your outline.roi file'))
^
```
[R/plotting_functions.R:143:16:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L143) *style:* **Only use double-quotes.**
```r
	message(paste('Wrote tear file to ',output_path, '\n Check that it exists beside your outline.roi file'))
               ^~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:143:38:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L143) *style:* **Commas should always have a space after.**
```r
	message(paste('Wrote tear file to ',output_path, '\n Check that it exists beside your outline.roi file'))
                                     ^
```
[R/plotting_functions.R:143:51:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L143) *style:* **Only use double-quotes.**
```r
	message(paste('Wrote tear file to ',output_path, '\n Check that it exists beside your outline.roi file'))
                                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:144:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L144) *style:* **Use spaces to indent, not tabs.**
```r
	return(tear_coordinates_dataframe)
^
```
[R/plotting_functions.R:151:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L151) *style:* **Lines should not be more than 80 characters.**
```r
##' @param path_to_retina_data_folder The path where the P.csv file will be saved.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:155:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L155) *style:* **Lines should not be more than 80 characters.**
```r
assemble_point_coordinates_file <- function(outline_coordinates, path_to_retina_data_folder){
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:155:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L155) *style:* **Variable and function names should not be longer than 30 characters.**
```r
assemble_point_coordinates_file <- function(outline_coordinates, path_to_retina_data_folder){
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:156:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L156) *style:* **Use spaces to indent, not tabs.**
```r
	output_path <- file.path(path_to_retina_data_folder, "P.csv")
^
```
[R/plotting_functions.R:157:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L157) *style:* **Use spaces to indent, not tabs.**
```r
	colnames(outline_coordinates)<- c("V1","V2")
^
```
[R/plotting_functions.R:157:31:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L157) *style:* **Put spaces around all infix operators.**
```r
	colnames(outline_coordinates)<- c("V1","V2")
                             ~^
```
[R/plotting_functions.R:157:41:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L157) *style:* **Commas should always have a space after.**
```r
	colnames(outline_coordinates)<- c("V1","V2")
                                        ^
```
[R/plotting_functions.R:158:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L158) *style:* **Use spaces to indent, not tabs.**
```r
	write.table(outline_coordinates, output_path, sep=',', row.names = F)
^
```
[R/plotting_functions.R:158:51:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L158) *style:* **Put spaces around all infix operators.**
```r
	write.table(outline_coordinates, output_path, sep=',', row.names = F)
                                                 ~^~
```
[R/plotting_functions.R:158:52:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L158) *style:* **Only use double-quotes.**
```r
	write.table(outline_coordinates, output_path, sep=',', row.names = F)
                                                   ^~~
```
[R/plotting_functions.R:159:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L159) *style:* **Lines should not be more than 80 characters.**
```r
	message(paste('Wrote coordinates file to ',output_path, '\n Check that it exists beside your outline.roi file'))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:159:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L159) *style:* **Use spaces to indent, not tabs.**
```r
	message(paste('Wrote coordinates file to ',output_path, '\n Check that it exists beside your outline.roi file'))
^
```
[R/plotting_functions.R:159:16:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L159) *style:* **Only use double-quotes.**
```r
	message(paste('Wrote coordinates file to ',output_path, '\n Check that it exists beside your outline.roi file'))
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:159:45:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L159) *style:* **Commas should always have a space after.**
```r
	message(paste('Wrote coordinates file to ',output_path, '\n Check that it exists beside your outline.roi file'))
                                            ^
```
[R/plotting_functions.R:159:58:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L159) *style:* **Only use double-quotes.**
```r
	message(paste('Wrote coordinates file to ',output_path, '\n Check that it exists beside your outline.roi file'))
                                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting_functions.R:160:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L160) *style:* **Use spaces to indent, not tabs.**
```r
	return(outline_coordinates)
^
```
[R/plotting_functions.R:170:42:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L170) *style:* **Commas should always have a space after.**
```r
plot_original_xy_locations <- function(x,y) {
                                         ^
```
[R/plotting_functions.R:171:1:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L171) *style:* **Use spaces to indent, not tabs.**
```r
	points(x+0.005,y,pch=4, cex=0.5, col="gainsboro")
^
```
[R/plotting_functions.R:171:10:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L171) *style:* **Put spaces around all infix operators.**
```r
	points(x+0.005,y,pch=4, cex=0.5, col="gainsboro")
        ~^~
```
[R/plotting_functions.R:171:17:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L171) *style:* **Commas should always have a space after.**
```r
	points(x+0.005,y,pch=4, cex=0.5, col="gainsboro")
                ^
```
[R/plotting_functions.R:171:19:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L171) *style:* **Commas should always have a space after.**
```r
	points(x+0.005,y,pch=4, cex=0.5, col="gainsboro")
                  ^
```
[R/plotting_functions.R:171:22:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L171) *style:* **Put spaces around all infix operators.**
```r
	points(x+0.005,y,pch=4, cex=0.5, col="gainsboro")
                    ~^~
```
[R/plotting_functions.R:171:29:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L171) *style:* **Put spaces around all infix operators.**
```r
	points(x+0.005,y,pch=4, cex=0.5, col="gainsboro")
                           ~^~
```
[R/plotting_functions.R:171:38:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L171) *style:* **Put spaces around all infix operators.**
```r
	points(x+0.005,y,pch=4, cex=0.5, col="gainsboro")
                                    ~^~
```
[R/plotting_functions.R:172:12:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L172) *style:* **Commas should always have a space after.**
```r
  points(x,y,pch=4, cex=0.5, col="black")
           ^
```
[R/plotting_functions.R:172:14:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L172) *style:* **Commas should always have a space after.**
```r
  points(x,y,pch=4, cex=0.5, col="black")
             ^
```
[R/plotting_functions.R:172:17:](https://github.com/bc/retina/blob/c61436aefba6ca4cb103b3daa2f2d86baf59d17c/R/plotting_functions.R#L172) *style:* **Put spaces around all infix operators.**
```r
  points(x,y,pch=4, cex=0.5, col="black")
               ~^~
```


Мы называем массивы по типу данных, которые они содержат. Массив который содержит список станции, должен называться "станции". Тогда просто читая название переменной можно понять, что внутри


IBM Cloud [toolchain](https://console.ng.bluemix.net/devops/toolchains/b6559c33-fca2-40dc-931c-089f0a59ff82?env_id=ibm%3Ayp%3Aus-south "cloud-native-toolchain-tutorial-20180531174034316"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/e104c0b3-80c1-4bf7-b438-ef5636633b5a?env_id=ibm%3Ayp%3Aus-south "sample-cloud-native-toolchain-tutorial-20180531174034316") deployed [WebUI](https://github.com/BudBlocks/WebUI/releases/tag/deploy-ibm-yp-us-south-bobbiejc-us.ibm.com-test-20180604-171128 "deploy-ibm-yp-us-south-bobbiejc-us.ibm.com-test-20180604-171128") to [test](https://console.bluemix.net/apps/d220d7ad-24e3-4935-8ef8-043ff32435fe?env_id=ibm:yp:us-south "ibm:yp:us-south:bobbiejc@us.ibm.com:test"), including this commit


sys/xen/interface/grant_table.h:68 says so. It says we need to use wmb() to update the grant entries in a concurrency safe manner. I'll admit, I don't clearly understand all that's written there. So I used wmb() to be on the safe side.

grant_table.c:167,183,289, also use it.

Should I remove it?


Oh, I see.


sadasd


Thanks for pointing them out. I'll fix them.


It seems now I got it, thank you


do you have logs handy? I can look at it in a couple of days, but libqb/master is not a target for el6 at the moment.


IBM Cloud [toolchain](https://console.ng.bluemix.net/devops/toolchains/092a639d-7f22-4486-86f1-24136b3613d7?env_id=ibm%3Ayp%3Aus-south "BudblocksUI"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/c6b28fc5-8b7c-4783-b75b-35a2c5e48174?env_id=ibm%3Ayp%3Aus-south "BudblocksUI") deployed [WebUI](https://github.com/BudBlocks/WebUI/releases/tag/deploy-ibm-yp-us-south-weford99-gmail.com-dev-20180604-171441 "deploy-ibm-yp-us-south-weford99-gmail.com-dev-20180604-171441") to [dev](https://console.bluemix.net/apps/ee6161e5-dc1d-4508-95a8-81159a09ad88?env_id=ibm:yp:us-south "ibm:yp:us-south:weford99@gmail.com:dev"), including this commit


Тут мы хотим хранить экземпляры классов станций, а не их имена


пробел между названием метода и скобкой с аргументами не нужен


А вот после = нужен


IBM Cloud [toolchain](https://console.ng.bluemix.net/devops/toolchains/b6559c33-fca2-40dc-931c-089f0a59ff82?env_id=ibm%3Ayp%3Aus-south "cloud-native-toolchain-tutorial-20180531174034316"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/e104c0b3-80c1-4bf7-b438-ef5636633b5a?env_id=ibm%3Ayp%3Aus-south "sample-cloud-native-toolchain-tutorial-20180531174034316") deployed [WebUI](https://github.com/BudBlocks/WebUI/releases/tag/deploy-ibm-yp-us-south-bobbiejc-us.ibm.com-test-20180604-171710 "deploy-ibm-yp-us-south-bobbiejc-us.ibm.com-test-20180604-171710") to [test](https://console.bluemix.net/apps/67e44b25-79f2-4d11-9be4-a9a93010b799?env_id=ibm:yp:us-south "ibm:yp:us-south:bobbiejc@us.ibm.com:test"), including this commit


:sweat_smile::sweat_smile::sweat_smile::sweat_smile:


Hols


don't need this one


Como puedo descargar el checker?


or this one


IBM Cloud [toolchain](https://console.ng.bluemix.net/devops/toolchains/9edf40cd-3673-43dd-828a-79a9d4bb45b3?env_id=ibm%3Ayp%3Aus-south "cloud-native-toolchain-tutorial-20180604143058105"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/6980a251-437a-47cc-944e-f5558edabbea?env_id=ibm%3Ayp%3Aus-south "sample-cloud-native-toolchain-tutorial-20180604143058105") deployed [sample-cloud-native-toolchain-tutorial-20180604143058105](https://github.com/marciojalbernaz/sample-cloud-native-toolchain-tutorial-20180604143058105/releases/tag/deploy-ibm-yp-us-south-marcioja-br.ibm.com-test-20180604-171953 "deploy-ibm-yp-us-south-marcioja-br.ibm.com-test-20180604-171953") to [test](https://console.bluemix.net/apps/d15e5cd8-40d4-4543-bfcd-1d98c58e0433?env_id=ibm:yp:us-south "ibm:yp:us-south:marcioja@br.ibm.com:test"), including this commit


OMG


"unexpected" is misspelled


This wouldn't be my first choice of names as I can only really see your thinking when I look into the code to see what it does. Consider `claimRemittance()` for example.


That's good.


Curious as to what made you pick '7' specifically in this context?


Why do we need a sign extension for unconditional branches?


эта реализация уже лучше )
1. все-таки убери из `valid?` "путс" , ни к месту он там


```TypeError: Cannot read property 'Program' of null
    at c (/home/jpate/6-0/vm/migadmin/node_modules/acorn/dist/walk.js:45:16)
    at Object.ancestor (/home/jpate/6-0/vm/migadmin/node_modules/acorn/dist/walk.js:48:5)
    at parseFile (/home/jpate/6-0/vm/migadmin/js/tests/callcatcher_js/count.js:748:15)
    at files.map.name (/home/jpate/6-0/vm/migadmin/js/tests/callcatcher_js/count.js:853:20)
    at Array.map (<anonymous>)
    at parseFiles (/home/jpate/6-0/vm/migadmin/js/tests/callcatcher_js/count.js:851:10)
    at safeParseFiles (/home/jpate/6-0/vm/migadmin/js/tests/callcatcher_js/count.js:231:9)
    at callcatcher_count (/home/jpate/6-0/vm/migadmin/js/tests/callcatcher_js/count.js:96:9)
    at Object.<anonymous> (/home/jpate/6-0/vm/migadmin/js/tests/callcatcher_js/count.js:26:5)
    at Module._compile (module.js:652:30)
[jpate@PeaceMoonII migadmin]$ grep version node_modules/acorn/package.json
  "version": "5.6.1"
```

I don't think you caught all the cases, i.e. `acornWalk.ancestor(ast, visitors, null, state);` still has this problem


Bryan is reworking the fix set.


IBM Cloud [toolchain](https://console.ng.bluemix.net/devops/toolchains/9edf40cd-3673-43dd-828a-79a9d4bb45b3?env_id=ibm%3Ayp%3Aus-south "cloud-native-toolchain-tutorial-20180604143058105"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/6980a251-437a-47cc-944e-f5558edabbea?env_id=ibm%3Ayp%3Aus-south "sample-cloud-native-toolchain-tutorial-20180604143058105") deployed [sample-cloud-native-toolchain-tutorial-20180604143058105](https://github.com/marciojalbernaz/sample-cloud-native-toolchain-tutorial-20180604143058105/releases/tag/deploy-ibm-yp-us-south-marcioja-br.ibm.com-prod-20180604-172300 "deploy-ibm-yp-us-south-marcioja-br.ibm.com-prod-20180604-172300") to [prod](https://console.bluemix.net/apps/9ee92e7f-5288-4a0a-9eae-704c2f4b834c?env_id=ibm:yp:us-south "ibm:yp:us-south:marcioja@br.ibm.com:prod"), including this commit


And now the secret ... even though the logic of the hashing and passwords is right, there is non-obvious problem, in principle.

The problem arises because the passwords will be known to all observers _before this transaction is mined_. I will give you some time to think carefully about how that is possible.


Finally. This dude was so annoying.


This is deprecated. Why not stick with `org.json.simple.JSONObject`? You could also consider using [Gson](https://github.com/google/gson/blob/master/UserGuide.md#TOC-Using-Gson)


@MichaIng

hmm, the v6.8 patch for ```rm /DietPi/dietpi/.dietpi-process_tool``` should of prevented this. The user reports this happen after doing a backup, but even with a restore, the old ```dietpi-process_tool``` and its config would be loaded before services are restarted.

Maybe would could simply have a file check before loading it, to ensure its as expected. Leave it with me, will take a look.


Bravo pentru metoda aleasa la rezolvarea temei de acasa.
O implementare mai buna a metodei switch ar fi urmatoarea:
            String gnd = Console.ReadLine().ToUpper();
            switch (gnd) {
                case "M": gender = Gender.Male;
                    break;
                case "F":
                    gender = Gender.Female;
                    break;
                default:
                    Console.WriteLine("Va rugam introduceti una dintre obtiuni!");
                    goto retry;
            }


эта реализация уже лучше ) но все-таки убери из `valid?` "путс" , ни к месту он там


:+1: I was looking to report this. I have [`docker/.env`](https://docs.docker.com/compose/env-file/) that was ignored by this


Use more descriptive names, even if they are long. Something like `trs` isn't immediately comprehensible.


原来可以这样。。。学到了


This isn't serving any purpose other than cluttering terminal output.


pls keep right authorship atleast.


Avoid random blank lines


так, тут мы хотим обратиться к writer'у.


Why put two different data items together and restrict your api?


suggested cname without www


Методы у нас должны возвращать данные. Это сообщение тут не нужно, да и оно немного сводит с толку. Оно как-бы говорит, что станция не найдена, хотя этот блок выполнится, только если станция будет найдена и удалена.


Not completely -> Pink Highlights... Is it possible, that the calcualtion of "highest_green" is not correct for dual iso?!


По условию первую и последнюю станции удалять нельзя


Yeah, I had the same problem. You need a server.js file that will render a server for you, and the add it to your package.json file and finally this Procfile that tells Heroku to run the 'node server.js'
I used this article that explains it very well: [https://medium.com/techtrument/deploying-a-vuejs-standalone-app-to-heroku-aa95820cc49a](https://medium.com/techtrument/deploying-a-vuejs-standalone-app-to-heroku-aa95820cc49a)
In the heroku console I use GitHub to deploy, but deploying through Heroku git works the same.


Use specific exceptions. This helps immediately understand what could go wrong, while letting us know if something else does.


This is fine with me, too. However, the message formatting should be consistent (we're doing away with '%s').


need nSplitRewardBlock now...


Essentially there was a code change 10 months ago that looks like it was never pulled to the Picasso Prod server.

the addition of the previous change shifted the parameters so that multiple report suites cases failed.
Parameters are now explicitly stated.


@MichaIng
Should be resolved with https://github.com/Fourdee/DietPi/commit/7e49642dc5dd72a0b0bb68c20626ae5d9f31db55


Thanks, A friend did the new logo :)


Raquel Batista


Handle exceptions (The train no. could be wrong, giving NPE)


With chunked downloads, the file does not play, and I get the following
checksum:
52ec85818245269ae1a630bc2b6e09db  electricsheep.244.00022.01530_
electricsheep.244.00022.01530.webm

instead of (expected):
b7409c67812cc453c2c8ab5a48375ff6  electricsheep.244.00022.01530_
electricsheep.244.00022.01530.webm

Changing the "w" option to "wb", in line 321, downloads the file correctly:
b7409c67812cc453c2c8ab5a48375ff6  electricsheep.244.00022.01530_
electricsheep.244.00022.01530.webm
I also noticed that during the download process, it produced a temporary
file prefixed with "incomplete_". This did not happen with the "w" option.

On 4 June 2018 at 18:38, Daniel Koch <notifications@github.com> wrote:

> Remove || rand() part. This will cause download every start
>
> Am 4. Juni 2018 18:34:37 MESZ schrieb arman68 <notifications@github.com>:
> >Running on Windows 10. Thanks for the credits, this will speed up
> >testing.
> >I am waiting for the first chunked download, and I'll let you know once
> >done. Then I can try the w to wb change.
> >
> >On 4 June 2018 at 18:32, Daniel Koch <notifications@github.com> wrote:
> >
> >> You could check if changing "w" to "wb" makes any difference for you
> >here
> >> 8d78e60#diff-1f15fcf5421eecd6ca1b61337c319495R321
> >>
> ><https://github.com/kochd/electricsheep-hd-client/commit/
> 8d78e6008c8c2f4641aacae5fd98258c97b5650d#diff-
> 1f15fcf5421eecd6ca1b61337c319495R321>
> >>
> >> —
> >> You are receiving this because you commented.
> >> Reply to this email directly, view it on GitHub
> >>
> ><https://github.com/kochd/electricsheep-hd-client/commit/
> 8d78e6008c8c2f4641aacae5fd98258c97b5650d#commitcomment-29236222>,
> >> or mute the thread
> >>
> ><https://github.com/notifications/unsubscribe-auth/
> AFxSntyDNluK2CGCdVcd1XnDQReYoJblks5t5WEYgaJpZM4UZHnO>
> >> .
> >>
> >
> >
> >--
> >You are receiving this because you commented.
> >Reply to this email directly or view it on GitHub:
> >https://github.com/kochd/electricsheep-hd-client/commit/
> 8d78e6008c8c2f4641aacae5fd98258c97b5650d#commitcomment-29236250
>
> --
> Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail
> gesendet.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/kochd/electricsheep-hd-client/commit/8d78e6008c8c2f4641aacae5fd98258c97b5650d#commitcomment-29236301>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AFxSnoBx6Qoff9h18yNFUWerKJNPz_nmks5t5WJ0gaJpZM4UZHnO>
> .
>


Называем внутренние переменные по их содержимому. Просто прочти этот метод в отрыве от всего остального кода.
```
def show
  self.list.each { |elem| print "#{elem} -> "}
end
```
Что тут вообще происходит? А вот в этом что происходит?
```
def render_stations
  @stations.each { |station| puts station.name }
end
```


Maybe print something more helpful like where the file was put, its name and how to run it ?


Yeah, heres a radical idea: don't catch anything. A real error will arise, someone would make a PR to fix it, and all will be well in the world.

Ps. I generally disagree with "defensive programming" -- its brought nothing but ill fortune to me. :P


This change breaks cases where the `maven-dependency-plugin` is leveraged to intentionally unpack an archive to an arbitrary directory -- was this intended?


IBM Cloud [toolchain](https://console.ng.bluemix.net/devops/toolchains/092a639d-7f22-4486-86f1-24136b3613d7?env_id=ibm%3Ayp%3Aus-south "BudblocksUI"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/c6b28fc5-8b7c-4783-b75b-35a2c5e48174?env_id=ibm%3Ayp%3Aus-south "BudblocksUI") deployed [WebUI](https://github.com/BudBlocks/WebUI/releases/tag/deploy-ibm-yp-us-south-weford99-gmail.com-dev-20180604-173753 "deploy-ibm-yp-us-south-weford99-gmail.com-dev-20180604-173753") to [dev](https://console.bluemix.net/apps/ee6161e5-dc1d-4508-95a8-81159a09ad88?env_id=ibm:yp:us-south "ibm:yp:us-south:weford99@gmail.com:dev"), including this commit


просто trains по конвенциям, как я уже писал выше


Currently, headless implies no public routes. I guess this means you want to fix fissile so public ports get created regardless of headlessness?


Tests?  ``kv`` isn't very descriptive name?


The main problem with this, apart from lack of exception handling, is that this isn't reusable. Try structuring your code into different classes, such that main class acts as an interface to the class that handles feching and processing of train data. That way the train processing class could be used easily in other projects.


These `KeyboardManager` changes are wonderful :purple_heart:


These solutions blow me away. :)


Fixed in https://github.com/SUSE/fissile/wiki/Pod-Management-using-Role-Manifest-Tags/_compare/64053e6d3dc0e04be00e69f71a3eec5eae04037b...68ab7df7e4ba0d46bf3f2f83675cd212b40c21ed


IBM Cloud [toolchain](https://console.ng.bluemix.net/devops/toolchains/b6559c33-fca2-40dc-931c-089f0a59ff82?env_id=ibm%3Ayp%3Aus-south "cloud-native-toolchain-tutorial-20180531174034316"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/e104c0b3-80c1-4bf7-b438-ef5636633b5a?env_id=ibm%3Ayp%3Aus-south "sample-cloud-native-toolchain-tutorial-20180531174034316") deployed [WebUI](https://github.com/BudBlocks/WebUI/releases/tag/deploy-ibm-yp-us-south-bobbiejc-us.ibm.com-test-20180604-173944 "deploy-ibm-yp-us-south-bobbiejc-us.ibm.com-test-20180604-173944") to [test](https://console.bluemix.net/apps/86e260d0-4575-41cd-8575-317b54e4b278?env_id=ibm:yp:us-south "ibm:yp:us-south:bobbiejc@us.ibm.com:test"), including this commit


Changed in https://github.com/SUSE/fissile/wiki/Pod-Management-using-Role-Manifest-Tags/_compare/64053e6d3dc0e04be00e69f71a3eec5eae04037b...68ab7df7e4ba0d46bf3f2f83675cd212b40c21ed

Trello card added: https://trello.com/c/KurtVjRI/


Please give meaningful names to your commits. Numbered and/or duplicate commits beat the purpose of version control.


Давай мы сначала построим станцию, а только потом туда приедут поезда. В инишалайзер не стоит передавать поезда. Инициализируй с пустым массивом. Для добавления поезда у тебя есть метод take_train


:) не очень ясна твоя логика...
ты переписал то же самое, но другим способом "определил метод"
записи `def validate` и `define_method('validate')` аналогичны, т.е. делают одно и то же...
т.е. как раньше у тебя валидации запускались при прочтении класса, так и теперь будут запускаться
вот смотри:
```
$ irb
2.5.1 :001 > module A; def self.included(base); base.extend CM; end; module CM; def validate; puts 'validate'; end; end; end;
 => :validate
2.5.1 :002 > class B; include A; validate; end;
validate
 => nil
```
я определил класс, влключил в него модуль, написал в теле класса вызов метода и содержимое метода исполнилось сразу при прочтении класса... но у тебя в методе запуск валидаций, поэтому они будут запущены сразу же... что неверно
вот твой новый способ:
```
$ irb
2.5.1 :001 > module A; def self.included(base); base.extend CM; end; module CM; define_method('validate') do; puts 'validate'; end; end; end;
 => :validate
2.5.1 :002 > class B; include A; validate; end;
validate
 => nil
```
как видишь - результат тот же самый - метод выполнил код, что вполне логично


Пробел между методом и скобкой не нужен


@Svisstack Seems the docs haven't yet been updated for this. Could you provide examples of what ints are sent?


oh really sorry. It keeps on showing error in eclipse. It goes away only on removing the argument. I was going to ask someone in JOSM about it.


Fixed in fd26597c2eccc6f40ba33704c54da9b41e214c3a. Apparently, you can't have the same name for a figure and the main TeX file. So when it compiled event_histogram.tex and looked for Event_histogram.png somehow it really, *really* wanted to include event_histogram.pdf, which didn't exist yet. I renamed the figure and all is well. Much easier to fix locally, ;-)!


How do you think about to throw a C++ exception?


Novo branch


Is this the best way to do the `it[i]` ?


Sorry I have resolved the problem. Can you please recheck ?
https://saikat1152.github.io/coursera-test/


Обращаемся к ридеру, и лучше прямо передавать экземпляр класса поезда


The `incomplete_` mechanism was introduced with the chunked download no matter if "w" or "wb" is used.
So "wb" fixes this issue ?


It kept complaining about int vs nat types. Wasn't sure if there is another notation for it
(such as... it_i%nat or something)


Same thing here (I feel it looks a bit ugly..)


-Added Review object and removed it from Route Model, to give rating and author possibilities to reviews.


dor is right


can we change this to `import ray.dataframe as pd`


#metoo


can we leave this as `import pandas`? i think it will still be clear which is being tested.


I am having a type issue here:
```
The term "t_" has type "Vector_SExpRec double" while it is expected to have type
 "Vector_SExpRec int"
```
I am not quite sure how to handle this regarding the source code as well. Do you have an idea @Mbodin ?


Теперь train_list это массив из массивов. Давай лучше так @trains < train


New-Feature---Account-for-fan-heat-is-zone-cooling-coils (rraustad) - i386-Windows-7-VisualStudio-14: OK (2924 of 2924 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


@biswesh456 You are probably compiling against a JOSM version before 13729, after that version JOSM requires an argument for this method. Are you sure the JOSM sources on your machine are up to date?


я тебе в прошлый раз уже подсказывал:

> по сути `validate` должен "сохранить валидации" чтобы `validate!` их потом мог запустить, при вызове

т.е. код в этом методе не должен запускть валидации, как ты это написал
он должен их "запомнить" и потом метод `validate!` эти валидации должен запустить... сохраненные к примеру в переменной... над форматом хранения подумай
но получается тебе нужно сохранить имя валидируемого аттрибута, тип проверки и возможные дополнительные опции
валидаций может быть несколько у одного аттрибута или одна и та же у нескольких или все вперемешку...
т.е. в классе может быть написано вот так:
```ruby
validate :name, :presence
validate :name, :type, String
validate :number, :presence
validate :number, Format
```
и это все должно быть сохранено и при необходимости вызвано


I find this adjustment questionable because [the desired check will be omitted if the preprocessor symbol “`NDEBUG`” would be defined](http://en.cppreference.com/w/c/error/assert "Description for the usage of assert()").


Yes, I did not see the incomplete prefix with the w option. Instead, the
full filename appeared straightaway, with a length of 0 bytes. Once the
download completed, the size changed to 245MB. Which was incorrect, as it
should have been 233MB.

With wb, it seems to work fine.

I'll do some more testing, on the next small sequence, with w, wb, and
before the change.

On Mon 4. Jun 2018 at 19:44, Daniel Koch <notifications@github.com> wrote:

> The incomplete_ mechanism was introduced with the chunked download no
> matter if "w" or "wb" is used.
> So "wb" fixes this issue ?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/kochd/electricsheep-hd-client/commit/8d78e6008c8c2f4641aacae5fd98258c97b5650d#commitcomment-29237123>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AFxSnjyrOJv_R01Gtn1_ISVUAjDZMhz_ks5t5XH7gaJpZM4UZHnO>
> .
>


Apr results were only for the most trace. I had forgotten this. New results match previous LC runs of MTOM. Thanks for the comments.


I'm generally happy to have more settings shared, because it makes stuff more predictable. However, last time that Samuel shared a lot of settings, we had actually trouble using them together for these reasons:
* settings were stored with OS specific line endings, thereby toggling between Windows and Unix.
* settings are "enhanced" by additional plugins. E.g. instead of having separate files, some plugins seem to add XML snippets to existing files. People not using the same plugins don't have those sections and they get lost on editing.
* Files were touched by my IDE again and again, without me actually changing any setting.

That's why I'm still hesitant. I could give it a try by using your settings on my machine and see how that goes...


Ты ж моя хорошая:)


Yes i am currently testing as well. Looks good to me. Anyone reading: This is a windows specific bug


Please read this for use instructions.


Glad he's gone in all honesty. LONG LIVE TX.


также писал в прошлый раз:

> проверять ты должен значение аргумента, к примеру есть у класса аргументы тип и нейм, вот ты и должен проверить, что тип аргумента соответсвует правильному классу (и присутствует), а нейм соответствует формату... но проверять ты конечно же должен ЗНАЧЕНИЯ этих аргументов.... у тебя мне кажется идет проверка названия аргумента )))

опять же ничего не поменялось... ты принимаешь в метод "валидейт" значением аргумента имя аттрибута и именно его проверяешь... а нужно значение аттрибута с этим именем


note, actual commit of this security update was judsonhayes (myself). Lightsys (owners of the page) can support this.


We can put last_produced_block_time back in. It won't be an issue.


Add everything except `src` and `lib` to `.gitignore`. Other files will be automatically generated based on the system and ide.


честно не пойму, что от меня требуется)))


Мы только начали, а тут уже путаница. Ты принимаешь поезд как аргумент? Или это номер поезда? А что ты расчитываешь вернет train_list.include?(train) - ведь train_list у нас массив из массивов? Если бы ты пользовался объектами, то это выглядело бы так например
```
def handle_train_departure(train)
  trains.delete(train)
end
```


сразу еще одна рекомендация:
лучше разнести проверки на три разных метода, потому что нет смысла их связывать между собой в одном методе... и каждый метод назвать "тематически"... к примеру `validate_presence`


Hello, i have a question, first, you had done a very great work with this firewall, it is very usefull, my question is,  can i apply firewall rules for an entire net, for example, allow ICMP messages between my host and entire net 192.168.50.0/24? have i to modify some code?. I am sorry for my english. i hope you understand me.


Based SciresM.


Yes I guess that was the problem. But now that I am using 13880, I don't see any error. Once again extremely sorry, I thought previous code had a bug.


New-Feature---Account-for-fan-heat-is-zone-cooling-coils (rraustad) - x86_64-MacOS-10.9-clang: OK (2890 of 2924 tests passed, 9 test warnings)

Messages:

 * 8 tests had: AUD diffs.
 * 34 tests had: EIO diffs.
 * 12 tests had: ESO small diffs.
 * 33 tests had: Table big diffs.
 * 4 tests had: ERR diffs.
 * 21 tests had: ESO big diffs.
 * 7 tests had: MTR big diffs.
 * 2 tests had: MTR small diffs.

Failures:

regression Test Summary
 * Passed: 589
 * Failed: 34

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.84%25-yellow.png)


что-то не очень понятно мне откуда возьмется переменная `@name`... где ты присваиваешь ей значение ?


И все автоматический усложняется. Теперь мы обращаемся к магическому elem[1]. Попробуй переписать использовав метод select. И заметь, что нужно вернуть, а не вывести


так проверяются ЗНАЧЕНИЯ)))


more to memory


preseving => preserving

(a few occurrences in this commit)


Consider using code-blocks like this:

```
javac -d bin -cp "lib/*" src/TrainSchedule.java
java -cp "bin:lib/*" TrainSchedule
```

Also these commands are shorter and allow for new libs to be added in future.


No problem. You can have a look to [Jenkins](https://josm.openstreetmap.de/jenkins/job/JOSM-Plugins/), all plugins are built every night against latest JOSM core. And all must compile :)


Then don't use them !!


получается твой метод может работать для проверки только одного аттрибута... значение же в переменной лежит одно, т.е. будте вызвано поочереди для одного аттрибута три проверки... есть они для этого аттрибута или нет, все равно будут вызваны...
но только для одного, два аттрибута уже не проверишь
а нужно любое количество аттрубутов иметь возможность валидировать... что будем делать ?


Я сеттер ты использовал только для current_station в других классах. Значит остальные методы нужно убрать в ридер


Confirmed: "w" corrupts the chunked download on Windows 10, and "wb" fixes
the problem.

b387d4901811ce2226a1c244aa0b4703
*w_electricsheep.244.00022.01530_electricsheep.244.00023.02047.webm
ca0e3731abb975291efb309384d26666
*wb_electricsheep.244.00022.01530_electricsheep.244.00023.02047.webm
ca0e3731abb975291efb309384d26666
*previous_electricsheep.244.00022.01530_electricsheep.244.00023.02047.webm

In addition, the w_ version is oversized (39,436,288 bytes instead
of 39,280,640 bytes).

On 4 June 2018 at 19:50, Daniel Koch <notifications@github.com> wrote:

> Yes i am currently testing as well. Looks good to me. Anyone reading: This
> is a windows specific bug
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/kochd/electricsheep-hd-client/commit/8d78e6008c8c2f4641aacae5fd98258c97b5650d#commitcomment-29237186>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AFxSnqOlF9qkfFBS5migs5HsuYfIkmzdks5t5XNVgaJpZM4UZHnO>
> .
>


This is an unnecessary hurdle. Why not make TrainSchedule the root? You could place `LICENSE` and `README` there.


You're right, should be 0xC280 👍


What version? This can make or break your app.


Thanks for digging this @arman68. I just published a new installer that introduces the chunked download for windows users as it should be stable now.


Объекты говорят между собой методами. Когда ты добавляешь что-то в аксэсор, то эта вещь становится доступна в публичном интерфэйсе класса. Грубо говоря, я запустив твою программу и создав поезд, могу написать train.detail = "привет". И сломаю твою программу, потому-что у тебя detail массив массивов, и все твои обращения к индексам массива извне (что является грубым нарушением инкапсуляции) начнут выбрасывать исключения.


IBM Cloud [toolchain](https://console.ng.bluemix.net/devops/toolchains/092a639d-7f22-4486-86f1-24136b3613d7?env_id=ibm%3Ayp%3Aus-south "BudblocksUI"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/c6b28fc5-8b7c-4783-b75b-35a2c5e48174?env_id=ibm%3Ayp%3Aus-south "BudblocksUI") deployed [WebUI](https://github.com/BudBlocks/WebUI/releases/tag/deploy-ibm-yp-us-south-weford99-gmail.com-dev-20180604-180242 "deploy-ibm-yp-us-south-weford99-gmail.com-dev-20180604-180242") to [dev](https://console.bluemix.net/apps/ee6161e5-dc1d-4508-95a8-81159a09ad88?env_id=ibm:yp:us-south "ibm:yp:us-south:weford99@gmail.com:dev"), including this commit