🔥 [Jenkins job](http://xamarin-jenkins.guest.corp.microsoft.com:8080/job/macios/job/xcode10/6/display/redirect) (on internal Jenkins) failed in stage 'Test run' 🔥 : hudson.AbortException: script returned exit code 2

✅ [Build succeeded](http://xamarin-jenkins.guest.corp.microsoft.com:8080/job/macios/job/xcode10/6//console)
✅ [API Diff (from stable)](http://xamarin-storage/jenkins/xamarin-macios/xcode10/a2b33d1d1d516a90b8aba464d67c8528493c85c2/6/jenkins-results/api-diff/index.html)
✅ [API Diff (from PR only)](http://xamarin-storage/jenkins/xamarin-macios/xcode10/a2b33d1d1d516a90b8aba464d67c8528493c85c2/6/jenkins-results/apicomparison/index.html) (please review changes)
✅ [Generator Diff](http://xamarin-storage/jenkins/xamarin-macios/xcode10/a2b33d1d1d516a90b8aba464d67c8528493c85c2/6/jenkins-results/generator-diff/index.html) (please review changes)
🔥 [Test run failed](http://xamarin-storage/jenkins/xamarin-macios/xcode10/a2b33d1d1d516a90b8aba464d67c8528493c85c2/6/jenkins-results/tests/index.html) 🔥

# Test results

8 tests failed, 217 tests passed.

## Failed tests

 * apitest/Mac Unified 32-bit: BuildFailure
 * apitest/Mac Unified XM45 32-bit: BuildFailure
 * dont link/Mac Unified 32-bit: BuildFailure
 * dont link/Mac Unified XM45 32-bit: BuildFailure
 * introspection/Mac Unified 32-bit: BuildFailure
 * xammac tests/Mac/Debug: Failed (Test run failed.)
 * xammac tests/Mac/Release (all optimizations): Failed (Test run failed.)
 * MTouch tests/NUnit: Failed (Execution failed with exit code 1)


Nice! 😊


Thanks


mybad about the wiki, i later changed to give these "yet unexported features" a prefix but forgot about extraflags.
As killerwife already stated on cmangos-discord `important memo, for the next couple of days tbc-db can be in a bit of a broken state because we will be doing some refurbishing, just be patient and if necessary rollback to earlier state`

I guess its no biggy to export the core commit to add this ExtraFlag.


to apply a complete patch, you need above commit and also the following one:
https://github.com/greenplum-db/gpdb/commit/ed2b3f8f99d59550f5f743435e3aaaed2690cc03


There may be a problem either with the name of the method (GetWindow()) or with what the method does. Currently it assigns a member variable fCloneWindow without checking whether it is NULL. So if GetWindow() is called more than once, a previous value for fCloneWindow is overwritten, leading either to multiple open windows, or memory leaks. If this method is supposed to create the window "lazily", i.e. delay creation of the window until it is actually needed, indicated by the call to GetWindow(), then fCloneWindow needs to be checked:
if (fCloneWindow == NULL)
    fCloneWindow = new...
return fCloneWindow;

If on the other hand a new window shall be created by this method, it needs to be renamed to CreateWindow(), and then no member variable should be assigned, or the member variable should be renamed as well, such as "fLastCloneWindow".


Trukash


fds


Feel free be yourself


I was wondering where you use the result of kmeans. Can you describe how you connect the result from kmeans to tsne?


The variable names in this block of code are not so good. "pd" in particular. If you want to avoid long lines of code, you could also do something like this:

FetchProgressType& fetchProgress = pd->fetch_progress;

And then access fetch_progress fields via fetchProgress variable, rather than indirectly via "pd". (Which should still be renamed.)


The cookie "arg" is leaked when the thread exits.


You allocate it here and pass it to the thread, this transferes ownership to the thread and you need to free it there, see above.


Thanks for your combinations.


Try to compare === 0


我玩一下pr


Remove this again


very nice!


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


Basic structure


body{
	padding:0px;
	margin:0px;
	font-family:Arial;
}
#container{
	background-color:#FFFFFF;
	border-radius:0.5em;
	width:80%;
	height:auto;
	margin:0px auto;
}
#header{
	width:100%;
	background-color:#000000;
	font-family:serif;
	font-size:36px;
	padding:1%;
	color:#FFFFFF;
	float:left;
}
#header p,#header img{
	padding:3px 5%;
	float:left;
}
#nav{
	width:100%;
	background-color:#999999;
	padding:1%;
	float:left;
}
#nav a{
	padding:1% 3%;
	margin:0.2% 1%;
	border-radius:0.5em;
	background-color:#666666;
	text-decoration:none;
	color:#FFFFFF;
	float:left;
}
#nav a:hover{
	cursor:pointer;
	color:#FF0000;
}
#section{
	width:100%;
	background-color:#E8E8E8;
	padding:1%;
	float:left;
}
#footer{
	width:100%;
	background-color:#000000;
	color:#FFFFFF;
	padding:1%;
	float:left;
}
#footer p{
	text-align:center;
	padding:10px 0px;
}
#abt_us{
	text-align:center;
	width:70%;
	margin:0px auto;
}
#products{
	width:50%;
	margin:0px auto;
}
#products a{
	width:40%;
	padding:1em 5em;
	margin:1em 15%;
	background-color:#161616;
	text-decoration:none;
	color:#FFFFFF;
	text-align:center;
	border-radius:2em;
	float:left;
}
#products a:hover{
	background-color:#959595;
}
figure{
	width:30%;
	margin:1.5%;
	text-align:center;
	float:left;
}
img:hover{
	cursor:pointer;
	opacity:0.9;
}
figure img{
		width:100%;
		height:270px;
		overflow:hidden;
}
#social_icon{
	width:15%;
	margin:1% auto;
}
#social_icon a{
	 padding:5%;
}
address{
 	line-height:2em;
	text-align:left;
}
#products ol{
	margin-left:10px;
	padding-left:0px;
}
ol li{
	line-height:2em;
}
#abt_us p,#products p{
	text-align:justify;
	line-height:2em;
}
#map{
	width:90%;
	margin:1% auto;
	height:350px;
}
.office{
	width:31%;
	margin:1%;
	float:left;
}
iframe {
	width:98%;
	height:98%;
}


source


I'm not good at writing code. I like this computer, but why do not I like to write code. I may not be good at English.    [url=https://www.skinnerjones.com]เที่ยวเมืองไทยที่ไหนดี[/url]


I read killerwife statement and I understand very well that pushing lots of things at one time can be tricky. ;-)
Don't mind me, I think this flag is a good one, I would just have prefer the core update to precede this DB update, especially as some core updates were already made in preparation of the TBC-DB release.


A script generates reads


Often it leads to more easy to read code, if you use structs a bit like classes. They can have their own methods, their own constructor and destructor, too. And "param" isn't a very descriptive name either. How about "CloneParameters"? I think I'll try to rewrite this part of the code where you pass data between threads as an example how the code can be made more readable. At the moment, it contains too much stuff which just distracts from what is actually going on.


@AHelpfulRayquaza if we use Cerberus-E instead of Bot's username there would be a problem with logging in because Cerberus-E is registered


actually, you should insist on for a another while, now is a turning point about OS and chip in China.


Would be nice to have a more complex example of nested sets to illustrate the power of this feature


I think you can safely remove the second part of this function. This should work too:

```sh
contains() {
    string="$1"
    substring="$2"
    test "${string#*$substring}" != "$string"
}
```

.


Great!!!


Why not "fCloneWindow->PostMessage(kCancel)"? This will create a new BMessage(kCancel) and send it to the fCloneWindow BLooper, with the fCloneWindow itself as the default handler.


Maybe move to sources ?


this is necessary.


@jensens Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.discussion/66/violations
```
plone/app/discussion/comment.py:41:1: I004 isort found an unexpected blank line in imports
plone/app/discussion/comment.py:42:1: I004 isort found an unexpected blank line in imports
plone/app/discussion/comment.py:123:40: C812 missing trailing comma
plone/app/discussion/comment.py:167:80: C812 missing trailing comma
plone/app/discussion/comment.py:181:41: C812 missing trailing comma
plone/app/discussion/comment.py:182:19: C812 missing trailing comma
plone/app/discussion/comment.py:289:19: C812 missing trailing comma
plone/app/discussion/comment.py:293:38: C812 missing trailing comma
plone/app/discussion/comment.py:355:33: C812 missing trailing comma
plone/app/discussion/comment.py:356:14: C812 missing trailing comma
plone/app/discussion/comment.py:358:28: C812 missing trailing comma
plone/app/discussion/comment.py:425:14: C812 missing trailing comma
plone/app/discussion/comment.py:427:28: C812 missing trailing comma
plone/app/discussion/interfaces.py:62:80: C812 missing trailing comma
plone/app/discussion/interfaces.py:177:31: C812 missing trailing comma
plone/app/discussion/interfaces.py:178:10: C812 missing trailing comma
plone/app/discussion/interfaces.py:183:52: C812 missing trailing comma
plone/app/discussion/interfaces.py:185:23: C812 missing trailing comma
plone/app/discussion/interfaces.py:219:75: C812 missing trailing comma
plone/app/discussion/interfaces.py:233:56: C812 missing trailing comma
plone/app/discussion/interfaces.py:247:22: C812 missing trailing comma
plone/app/discussion/interfaces.py:253:48: C812 missing trailing comma
plone/app/discussion/interfaces.py:263:44: C812 missing trailing comma
plone/app/discussion/interfaces.py:350:47: C812 missing trailing comma
plone/app/discussion/interfaces.py:362:54: C812 missing trailing comma
plone/app/discussion/interfaces.py:369:22: C812 missing trailing comma
plone/app/discussion/testing.py:95:33: C812 missing trailing comma
plone/app/discussion/testing.py:122:36: C812 missing trailing comma
plone/app/discussion/conversation.py:41:1: I004 isort found an unexpected blank line in imports
plone/app/discussion/conversation.py:42:1: I004 isort found an unexpected blank line in imports
plone/app/discussion/conversation.py:43:1: I001 isort found an import in the wrong position
plone/app/discussion/conversation.py:423:24: C812 missing trailing comma
plone/app/discussion/catalog.py:79:80: E501 line too long (90 > 79 characters)
plone/app/discussion/tests/test_indexers.py:73:37: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:85:37: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:89:46: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:94:46: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:141:42: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:156:45: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:163:53: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:167:53: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:171:52: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:178:44: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:182:37: C812 missing trailing comma
plone/app/discussion/tests/test_functional.py:31:46: C812 missing trailing comma
plone/app/discussion/tests/test_contentrules.py:33:44: C812 missing trailing comma
plone/app/discussion/tests/test_contentrules.py:99:57: C812 missing trailing comma
plone/app/discussion/tests/test_contentrules.py:115:31: C812 missing trailing comma
plone/app/discussion/tests/test_contentrules.py:123:33: C812 missing trailing comma
plone/app/discussion/tests/test_contentrules.py:131:36: C812 missing trailing comma
plone/app/discussion/tests/test_contentrules.py:139:42: C812 missing trailing comma
plone/app/discussion/tests/test_contentrules.py:147:39: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:83:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:91:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:105:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:147:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:154:38: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:163:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:177:38: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:222:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:231:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:244:44: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:251:40: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:280:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:289:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:302:39: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:310:35: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:346:40: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:351:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:394:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:441:18: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:457:40: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:535:36: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:588:14: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:593:41: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:600:22: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:606:41: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:617:51: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:630:21: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:634:18: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:638:20: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:656:66: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:665:14: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:692:54: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:693:14: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:726:71: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:740:67: C815 missing trailing comma in Python 3.5+
plone/app/discussion/tests/test_robot.py:26:57: C812 missing trailing comma
plone/app/discussion/tests/test_notifications.py:179:41: C812 missing trailing comma
plone/app/discussion/tests/test_notifications.py:222:16: C812 missing trailing comma
plone/app/discussion/tests/test_notifications.py:226:16: C812 missing trailing comma
plone/app/discussion/tests/test_notifications.py:232:16: C812 missing trailing comma
plone/app/discussion/tests/test_notifications.py:238:16: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:29:49: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:33:49: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:37:48: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:41:48: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:82:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:84:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:102:66: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:108:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:110:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:119:46: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:131:66: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:137:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:139:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:144:46: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:153:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:155:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:160:46: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:168:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:170:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:188:66: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:195:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:197:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:208:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:210:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:220:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:222:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:231:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:233:42: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:246:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:248:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:275:66: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:280:57: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:281:14: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:295:54: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:300:52: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:301:14: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:333:57: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:334:14: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:360:31: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:365:31: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:370:33: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:385:76: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:392:73: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:393:14: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:399:28: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:419:55: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:434:57: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:441:57: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:447:28: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:462:33: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:480:33: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:555:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:557:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:570:43: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:32:43: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:43:14: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:54:18: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:65:18: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:76:18: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:102:25: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:113:23: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:124:17: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:130:68: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:137:18: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:170:34: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:171:14: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:182:34: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:183:14: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:190:34: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:191:14: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:205:41: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:214:44: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:221:35: C812 missing trailing comma
plone/app/discussion/tests/test_events.py:155:57: C812 missing trailing comma
plone/app/discussion/tests/test_events.py:176:57: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:71:42: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:82:42: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:91:42: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:112:33: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:124:33: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:160:62: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:168:50: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:176:67: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:184:48: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:194:54: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:203:65: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:233:66: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:240:37: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:242:38: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:246:57: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:257:30: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:265:66: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:293:69: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:297:77: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:301:76: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:309:49: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:333:66: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:374:57: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:411:57: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:447:57: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:456:60: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:465:63: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:474:66: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:479:38: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:483:48: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:487:41: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:492:38: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:497:34: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:499:44: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:504:41: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:509:37: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:511:47: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:516:44: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:23:1: I004 isort found an unexpected blank line in imports
plone/app/discussion/tests/test_conversation.py:24:1: I004 isort found an unexpected blank line in imports
plone/app/discussion/tests/test_conversation.py:25:1: I001 isort found an import in the wrong position
plone/app/discussion/tests/test_conversation.py:77:34: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:85:33: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:283:34: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:331:34: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:401:11: T000 Todo note found.
plone/app/discussion/tests/test_conversation.py:517:56: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:521:61: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:531:64: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:535:41: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:545:64: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:549:41: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:623:11: T000 Todo note found.
plone/app/discussion/tests/test_conversation.py:631:38: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:637:43: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:641:40: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:649:54: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:673:43: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:686:40: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:692:34: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:852:59: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:857:59: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:863:61: C812 missing trailing comma
plone/app/discussion/tests/test_moderation_view.py:82:59: C812 missing trailing comma
plone/app/discussion/tests/test_moderation_view.py:90:59: C812 missing trailing comma
plone/app/discussion/tests/test_moderation_view.py:98:59: C812 missing trailing comma
plone/app/discussion/tests/test_moderation_view.py:184:33: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:50:34: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:51:14: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:64:28: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:66:24: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:128:54: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:222:61: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:264:31: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:265:14: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:273:31: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:274:14: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:284:31: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:285:14: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:290:41: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:296:31: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:297:14: C812 missing trailing comma
plone/app/discussion/browser/comment.py:5:1: I001 isort found an import in the wrong position
plone/app/discussion/browser/controlpanel.py:37:46: C812 missing trailing comma
plone/app/discussion/browser/controlpanel.py:71:44: C812 missing trailing comma
plone/app/discussion/browser/controlpanel.py:74:39: C812 missing trailing comma
plone/app/discussion/browser/controlpanel.py:95:40: C812 missing trailing comma
plone/app/discussion/browser/controlpanel.py:96:14: C812 missing trailing comma
plone/app/discussion/browser/comments.py:35:1: I004 isort found an unexpected blank line in imports
plone/app/discussion/browser/comments.py:42:38: C812 missing trailing comma
plone/app/discussion/browser/comments.py:49:33: C812 missing trailing comma
plone/app/discussion/browser/comments.py:56:49: C812 missing trailing comma
plone/app/discussion/browser/comments.py:61:39: C812 missing trailing comma
plone/app/discussion/browser/comments.py:181:15: T000 Todo note found.
plone/app/discussion/browser/comments.py:185:16: T000 Todo note found.
plone/app/discussion/browser/comments.py:232:47: C812 missing trailing comma
plone/app/discussion/browser/comments.py:244:34: C812 missing trailing comma
plone/app/discussion/browser/comments.py:247:69: C812 missing trailing comma
plone/app/discussion/browser/comments.py:297:17: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


I am using the clustering results in the scatter plot in order to colour the points appropriately. The sklea n docs provide a good introduction to that http://scikit-learn.org/stable/modules/clustering.html


Created multidev environment [nhtv#ci-62](https://dashboard.pantheon.io/sites/a5faca03-4b4c-4936-95b8-6410ab7b2c55#ci-62).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-62-nhtv.pantheonsite.io/)


Who is ever freeing the strings allocated here? I don't see it anywhere in the code above. If you change the type inside the array from "const char*" or "char*" to "BString", there is not much difference in how the code would be written, but you wouldn't need to worry about managing memory.


Hi Syed - Thank so much for sharing this. Are there additional files you planned to share? I got through all the steps of the Read.me until I reached:
+Download the source code of my bash script from here: "startffmpeg.sh"
+(provided in documentation files)

and it would seem that the documentation files / startffmpeg.sh are not yet available. If you could share, I'd love to try it out!


hohohoho


We use what is called "sentance casing" in all the Haiku interface. So that would be "Add all files".


Created multidev environment [aufundab-composer#ci-5](https://dashboard.pantheon.io/sites/d09b2f4f-71a4-4b26-8cf1-ab5795277f6f#ci-5).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-5-aufundab-composer.pantheonsite.io/)


@DScheglov python 2.7 is deprecated and out of support in April 2020. It like NodeJS 4.x in 2018


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


pas trop mal!


bienvenue les mens in black, bienvenue, bienvenue


@jensens Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.discussion/67/violations
```
plone/app/discussion/comment.py:121:40: C812 missing trailing comma
plone/app/discussion/comment.py:165:80: C812 missing trailing comma
plone/app/discussion/comment.py:179:41: C812 missing trailing comma
plone/app/discussion/comment.py:180:19: C812 missing trailing comma
plone/app/discussion/comment.py:287:19: C812 missing trailing comma
plone/app/discussion/comment.py:291:38: C812 missing trailing comma
plone/app/discussion/comment.py:353:33: C812 missing trailing comma
plone/app/discussion/comment.py:354:14: C812 missing trailing comma
plone/app/discussion/comment.py:356:28: C812 missing trailing comma
plone/app/discussion/comment.py:423:14: C812 missing trailing comma
plone/app/discussion/comment.py:425:28: C812 missing trailing comma
plone/app/discussion/interfaces.py:62:80: C812 missing trailing comma
plone/app/discussion/interfaces.py:177:31: C812 missing trailing comma
plone/app/discussion/interfaces.py:178:10: C812 missing trailing comma
plone/app/discussion/interfaces.py:183:52: C812 missing trailing comma
plone/app/discussion/interfaces.py:185:23: C812 missing trailing comma
plone/app/discussion/interfaces.py:219:75: C812 missing trailing comma
plone/app/discussion/interfaces.py:233:56: C812 missing trailing comma
plone/app/discussion/interfaces.py:247:22: C812 missing trailing comma
plone/app/discussion/interfaces.py:253:48: C812 missing trailing comma
plone/app/discussion/interfaces.py:263:44: C812 missing trailing comma
plone/app/discussion/interfaces.py:350:47: C812 missing trailing comma
plone/app/discussion/interfaces.py:362:54: C812 missing trailing comma
plone/app/discussion/interfaces.py:369:22: C812 missing trailing comma
plone/app/discussion/testing.py:95:33: C812 missing trailing comma
plone/app/discussion/testing.py:122:36: C812 missing trailing comma
plone/app/discussion/conversation.py:421:24: C812 missing trailing comma
plone/app/discussion/catalog.py:79:80: E501 line too long (90 > 79 characters)
plone/app/discussion/tests/test_indexers.py:5:1: I001 isort found an import in the wrong position
plone/app/discussion/tests/test_indexers.py:73:37: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:85:37: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:89:46: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:94:46: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:141:42: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:156:45: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:163:53: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:167:53: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:171:52: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:178:44: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:182:37: C812 missing trailing comma
plone/app/discussion/tests/test_functional.py:31:46: C812 missing trailing comma
plone/app/discussion/tests/test_contentrules.py:33:44: C812 missing trailing comma
plone/app/discussion/tests/test_contentrules.py:99:57: C812 missing trailing comma
plone/app/discussion/tests/test_contentrules.py:115:31: C812 missing trailing comma
plone/app/discussion/tests/test_contentrules.py:123:33: C812 missing trailing comma
plone/app/discussion/tests/test_contentrules.py:131:36: C812 missing trailing comma
plone/app/discussion/tests/test_contentrules.py:139:42: C812 missing trailing comma
plone/app/discussion/tests/test_contentrules.py:147:39: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:83:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:91:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:105:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:147:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:154:38: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:163:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:177:38: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:222:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:231:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:244:44: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:251:40: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:280:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:289:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:302:39: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:310:35: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:346:40: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:351:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:394:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:441:18: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:457:40: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:535:36: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:588:14: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:593:41: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:600:22: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:606:41: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:617:51: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:630:21: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:634:18: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:638:20: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:656:66: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:665:14: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:692:54: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:693:14: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:726:71: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:740:67: C815 missing trailing comma in Python 3.5+
plone/app/discussion/tests/test_robot.py:26:57: C812 missing trailing comma
plone/app/discussion/tests/test_notifications.py:179:41: C812 missing trailing comma
plone/app/discussion/tests/test_notifications.py:222:16: C812 missing trailing comma
plone/app/discussion/tests/test_notifications.py:226:16: C812 missing trailing comma
plone/app/discussion/tests/test_notifications.py:232:16: C812 missing trailing comma
plone/app/discussion/tests/test_notifications.py:238:16: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:29:49: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:33:49: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:37:48: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:41:48: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:82:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:84:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:102:66: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:108:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:110:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:119:46: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:131:66: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:137:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:139:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:144:46: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:153:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:155:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:160:46: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:168:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:170:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:188:66: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:195:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:197:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:208:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:210:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:220:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:222:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:231:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:233:42: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:246:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:248:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:275:66: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:280:57: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:281:14: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:295:54: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:300:52: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:301:14: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:333:57: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:334:14: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:360:31: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:365:31: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:370:33: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:385:76: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:392:73: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:393:14: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:399:28: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:419:55: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:434:57: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:441:57: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:447:28: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:462:33: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:480:33: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:555:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:557:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:570:43: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:32:43: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:43:14: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:54:18: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:65:18: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:76:18: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:102:25: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:113:23: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:124:17: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:130:68: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:137:18: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:170:34: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:171:14: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:182:34: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:183:14: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:190:34: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:191:14: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:205:41: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:214:44: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:221:35: C812 missing trailing comma
plone/app/discussion/tests/test_events.py:155:57: C812 missing trailing comma
plone/app/discussion/tests/test_events.py:176:57: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:71:42: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:82:42: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:91:42: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:112:33: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:124:33: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:160:62: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:168:50: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:176:67: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:184:48: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:194:54: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:203:65: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:233:66: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:240:37: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:242:38: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:246:57: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:257:30: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:265:66: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:293:69: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:297:77: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:301:76: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:309:49: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:333:66: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:374:57: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:411:57: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:447:57: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:456:60: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:465:63: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:474:66: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:479:38: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:483:48: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:487:41: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:492:38: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:497:34: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:499:44: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:504:41: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:509:37: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:511:47: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:516:44: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:75:34: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:83:33: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:281:34: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:329:34: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:399:11: T000 Todo note found.
plone/app/discussion/tests/test_conversation.py:515:56: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:519:61: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:529:64: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:533:41: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:543:64: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:547:41: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:621:11: T000 Todo note found.
plone/app/discussion/tests/test_conversation.py:629:38: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:635:43: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:639:40: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:647:54: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:671:43: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:684:40: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:690:34: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:850:59: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:855:59: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:861:61: C812 missing trailing comma
plone/app/discussion/tests/test_moderation_view.py:82:59: C812 missing trailing comma
plone/app/discussion/tests/test_moderation_view.py:90:59: C812 missing trailing comma
plone/app/discussion/tests/test_moderation_view.py:98:59: C812 missing trailing comma
plone/app/discussion/tests/test_moderation_view.py:184:33: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:50:34: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:51:14: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:64:28: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:66:24: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:128:54: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:222:61: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:264:31: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:265:14: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:273:31: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:274:14: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:284:31: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:285:14: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:290:41: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:296:31: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:297:14: C812 missing trailing comma
plone/app/discussion/browser/controlpanel.py:37:46: C812 missing trailing comma
plone/app/discussion/browser/controlpanel.py:71:44: C812 missing trailing comma
plone/app/discussion/browser/controlpanel.py:74:39: C812 missing trailing comma
plone/app/discussion/browser/controlpanel.py:95:40: C812 missing trailing comma
plone/app/discussion/browser/controlpanel.py:96:14: C812 missing trailing comma
plone/app/discussion/browser/comments.py:41:38: C812 missing trailing comma
plone/app/discussion/browser/comments.py:48:33: C812 missing trailing comma
plone/app/discussion/browser/comments.py:55:49: C812 missing trailing comma
plone/app/discussion/browser/comments.py:60:39: C812 missing trailing comma
plone/app/discussion/browser/comments.py:180:15: T000 Todo note found.
plone/app/discussion/browser/comments.py:184:16: T000 Todo note found.
plone/app/discussion/browser/comments.py:231:47: C812 missing trailing comma
plone/app/discussion/browser/comments.py:243:34: C812 missing trailing comma
plone/app/discussion/browser/comments.py:246:69: C812 missing trailing comma
plone/app/discussion/browser/comments.py:296:17: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


A heartbeat should arrive every second. But what happens if it does not?

A very simple (simplified) example situation: First, everything works, heartbeat is used during the stream. Then network connection is dropped during the open connection. When does the connection now timeout? If I understood the [code](https://github.com/achillean/shodan-python/blob/915a5e50d846890ebd09bd68ff8af67fc7422e4b/shodan/stream.py#L34) correctly, it does not timeout at all, because it assumes that the heartbeat is always transferred correctly once the stream started.


@2maz I will check, but not this month ...


@pbauer Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-borg.localrole/32/violations
```
borg/localrole/tests.py:53:26: Q000 Remove bad quotes.
borg/localrole/tests.py:53:46: Q000 Remove bad quotes.
borg/localrole/tests.py:63:78: C812 missing trailing comma
borg/localrole/tests.py:72:35: C812 missing trailing comma
borg/localrole/tests.py:77:78: C812 missing trailing comma
borg/localrole/tests.py:79:35: C812 missing trailing comma
borg/localrole/interfaces.py:8:58: C812 missing trailing comma
borg/localrole/interfaces.py:13:78: C812 missing trailing comma
borg/localrole/__init__.py:20:24: C812 missing trailing comma
borg/localrole/utils.py:25:9: T003 print function found.
borg/localrole/utils.py:25:15: Q000 Remove bad quotes.
borg/localrole/utils.py:25:15: S001 found module formatter
borg/localrole/utils.py:35:27: P002 found "hasattr", consider replacing it
borg/localrole/workspace.py:22:5: Q000 Remove bad quotes.
borg/localrole/workspace.py:24:14: Q000 Remove bad quotes.
borg/localrole/workspace.py:24:50: C812 missing trailing comma
borg/localrole/workspace.py:32:17: C812 missing trailing comma
borg/localrole/workspace.py:44:42: C812 missing trailing comma
borg/localrole/workspace.py:45:14: C812 missing trailing comma
borg/localrole/workspace.py:137:0: P102 docstring does contain unindexed parameters
borg/localrole/workspace.py:267:13: D001 found directlyProvides( replace it with zope.interface.provider
borg/localrole/workspace.py:268:13: D001 found directlyProvides( replace it with zope.interface.provider
borg/localrole/workspace.py:376:17: Q000 Remove bad quotes.
borg/localrole/workspace.py:379:34: Q000 Remove bad quotes.
borg/localrole/workspace.py:388:16: P002 found "hasattr", consider replacing it
borg/localrole/workspace.py:442:19: T000 Todo note found.
borg/localrole/workspace.py:446:46: C812 missing trailing comma
borg/localrole/workspace.py:452:75: C812 missing trailing comma
borg/localrole/workspace.py:456:5: C901 'WorkspaceLocalRoleManager.checkLocalRolesAllowed' is too complex (14)
borg/localrole/workspace.py:480:15: T000 Todo note found.
borg/localrole/workspace.py:508:22: T000 Todo note found.
borg/localrole/workspace.py:514:7: T000 Todo note found.
borg/localrole/factory_adapter.py:68:13: D001 found directlyProvides( replace it with zope.interface.provider
borg/localrole/factory_adapter.py:84:13: D001 found directlyProvides( replace it with zope.interface.provider
borg/localrole/factory_adapter.py:95:0: P102 docstring does contain unindexed parameters
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Actually... I can't publish at the moment because https://github.com/wupdigital/android-maven-publish/issues/20

I'll keep you posted


what's wrong with it?


これ、どうして `@` が付いているの？他も同様に


problem？


improved in 9bccdb9.

btw is github finally not making it super hard fiding source comments anymore? Seems like this is still visible from #2046


too good to say bye, just ``good luck`` for u and ``goodbye`` for deepin~


"Close" should be taken from lang package.


Err yes. Should be fixed now. Well spotted :)


Good luck


Please remove the `connection` statements, and create the connections one by one.


Good luck.


### Results for event id: 7a1894b7-5b0e-4485-b338-392116909029
DockerServerless : Deploy to Lambda (e930a1) Docker output validation failed for outputRegex

**output tail (26 lines total):**

```
...
An error occurred (AuthorizationHeaderMalformed) when calling the PutObject operation: The authorization header is malformed; a non-empty Access Key (AKID) must be provided in the credential.

>>> uploading dependency bundle to s3: deps-b782fefaa879d5a30a97f18f978c1026.tar.gz
>>> packaging dependency bundle: deps-b782fefaa879d5a30a97f18f978c1026.tar.gz from /usr/workspace/clone/node_modules
DEPS_FOUND=
Done in 54.33s.
[4/4] Building fresh packages...
[3/4] Linking dependencies...
info "fsevents@1.2.3" is an optional dependency and failed compatibility check. Excluding it from installation.
info fsevents@1.2.3: The platform "linux" is incompatible with this module.
[2/4] Fetching packages...
[1/4] Resolving packages...
yarn install v1.7.0
>>> running custom build commmand..
An error occurred (AuthorizationHeaderMalformed) when calling the ListObjects operation: The authorization header is malformed; a non-empty Access Key (AKID) must be provided in the credential.

>>> setting aws creds.
IAM_ENABLED=
S3_DEPENDENCY_BUCKET=gtmstorage2
AWS_S3_PROXY=
DEPS_DIR=/usr/workspace/clone/node_modules
DEPS_SUM=b782fefaa879d5a30a97f18f978c1026
BUILD_TYPE=nodejs
>>> checking for packaged deps
Cloning into 'clone'...
>>> cloning repo..

```

https://github.com/apocas/dockerode


Also use `BEGIN` or `START TRANSACTION WITH CONSISTENT SNAPSHOT` instead of only using `set autocommit=0`.


Created multidev environment [aufundab-composer#ci-8](https://dashboard.pantheon.io/sites/d09b2f4f-71a4-4b26-8cf1-ab5795277f6f#ci-8).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-8-aufundab-composer.pantheonsite.io/)


Why not `"{$this->username}"`? That way you can spare an assertion and just convert the null into a string.
If you spare assertions to the places where you actually want to assume something then your application will run much faster.


Given that it is at most a single row, I would suggest using `SELECT *` instead of or in addition to `SELECT COUNT(*)`.


### Results for event id: d660ccb9-2fcd-45f3-b038-922724b6946b
DockerServerless : Deploy to Lambda (e930a1) Docker output validation failed for outputRegex

**output tail (26 lines total):**

```
...
An error occurred (AuthorizationHeaderMalformed) when calling the PutObject operation: The authorization header is malformed; a non-empty Access Key (AKID) must be provided in the credential.

>>> uploading dependency bundle to s3: deps-b782fefaa879d5a30a97f18f978c1026.tar.gz
>>> packaging dependency bundle: deps-b782fefaa879d5a30a97f18f978c1026.tar.gz from /usr/workspace/clone/node_modules
DEPS_FOUND=
Done in 50.39s.
[4/4] Building fresh packages...
[3/4] Linking dependencies...
info "fsevents@1.2.3" is an optional dependency and failed compatibility check. Excluding it from installation.
info fsevents@1.2.3: The platform "linux" is incompatible with this module.
[2/4] Fetching packages...
[1/4] Resolving packages...
yarn install v1.7.0
>>> running custom build commmand..
An error occurred (AuthorizationHeaderMalformed) when calling the ListObjects operation: The authorization header is malformed; a non-empty Access Key (AKID) must be provided in the credential.

>>> setting aws creds.
IAM_ENABLED=
S3_DEPENDENCY_BUCKET=gtmstorage2
AWS_S3_PROXY=
DEPS_DIR=/usr/workspace/clone/node_modules
DEPS_SUM=b782fefaa879d5a30a97f18f978c1026
BUILD_TYPE=nodejs
>>> checking for packaged deps
Cloning into 'clone'...
>>> cloning repo..

```

https://github.com/apocas/dockerode


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


### Results for event id: a1ad8631-99ff-4049-b8d9-71b5dd213fc4
DockerServerless : Deploy to Lambda (e930a1) Docker output validation failed for outputRegex

**output tail (26 lines total):**

```
...
An error occurred (AuthorizationHeaderMalformed) when calling the PutObject operation: The authorization header is malformed; a non-empty Access Key (AKID) must be provided in the credential.

>>> uploading dependency bundle to s3: deps-b782fefaa879d5a30a97f18f978c1026.tar.gz
>>> packaging dependency bundle: deps-b782fefaa879d5a30a97f18f978c1026.tar.gz from /usr/workspace/clone/node_modules
DEPS_FOUND=
Done in 56.89s.
[4/4] Building fresh packages...
[3/4] Linking dependencies...
info "fsevents@1.2.3" is an optional dependency and failed compatibility check. Excluding it from installation.
info fsevents@1.2.3: The platform "linux" is incompatible with this module.
[2/4] Fetching packages...
[1/4] Resolving packages...
yarn install v1.7.0
>>> running custom build commmand..
An error occurred (AuthorizationHeaderMalformed) when calling the ListObjects operation: The authorization header is malformed; a non-empty Access Key (AKID) must be provided in the credential.

>>> setting aws creds.
IAM_ENABLED=
S3_DEPENDENCY_BUCKET=gtmstorage2
AWS_S3_PROXY=
DEPS_DIR=/usr/workspace/clone/node_modules
DEPS_SUM=b782fefaa879d5a30a97f18f978c1026
BUILD_TYPE=nodejs
>>> checking for packaged deps
Cloning into 'clone'...
>>> cloning repo..

```

https://github.com/apocas/dockerode


Should read the length of the file...


This should be a `static` or `inline` function in ha_innodb.cc.
I would avoid excessive indentation by adding early `return` like this:
```c
if (lock_table_get_n_locks(table)) {
	return false;
}
if (trx->id == 0) {
	return !MVCC::is_view_active(trx->read_view)
		|| trx->read_view->low_limit_id()
		>= table->query_cache_inv_id;
}
return trx->id >= table->query_cache_inv_id && …;
```


### Results for event id: a816036c-d911-4286-9976-72ea72d80a84
DockerServerless : Deploy to Lambda (e930a1) Docker output validation failed for outputRegex

**output tail (26 lines total):**

```
...
An error occurred (AuthorizationHeaderMalformed) when calling the PutObject operation: The authorization header is malformed; a non-empty Access Key (AKID) must be provided in the credential.

>>> uploading dependency bundle to s3: deps-b782fefaa879d5a30a97f18f978c1026.tar.gz
>>> packaging dependency bundle: deps-b782fefaa879d5a30a97f18f978c1026.tar.gz from /usr/workspace/clone/node_modules
DEPS_FOUND=
Done in 77.34s.
[4/4] Building fresh packages...
[3/4] Linking dependencies...
info "fsevents@1.2.3" is an optional dependency and failed compatibility check. Excluding it from installation.
info fsevents@1.2.3: The platform "linux" is incompatible with this module.
[2/4] Fetching packages...
[1/4] Resolving packages...
yarn install v1.7.0
>>> running custom build commmand..
An error occurred (AuthorizationHeaderMalformed) when calling the ListObjects operation: The authorization header is malformed; a non-empty Access Key (AKID) must be provided in the credential.

>>> setting aws creds.
IAM_ENABLED=
S3_DEPENDENCY_BUCKET=gtmstorage2
AWS_S3_PROXY=
DEPS_DIR=/usr/workspace/clone/node_modules
DEPS_SUM=b782fefaa879d5a30a97f18f978c1026
BUILD_TYPE=nodejs
>>> checking for packaged deps
Cloning into 'clone'...
>>> cloning repo..

```

https://github.com/apocas/dockerode


@CRtEurope You maybe do not have `file` binary installed? That extension wasn't a problem for me, but 10b85656d5a should fix it.


Après compilation mode 'prod' le fichier css fait 0.55 kb ! Wahou !!!


@mareknovotny #396 #397


layer mismatch
the last layer should be `tiny_dnn::tanh_layer(32, 32, 1);`


### Results for event id: 5a5489e0-7f4c-4e49-b9be-79b2457fec74
DockerServerless : Deploy to Lambda (e930a1) Docker output validation failed for outputRegex

**output tail (26 lines total):**

```
...
An error occurred (InvalidAccessKeyId) when calling the PutObject operation: The AWS Access Key Id you provided does not exist in our records.

>>> uploading dependency bundle to s3: deps-b782fefaa879d5a30a97f18f978c1026.tar.gz
>>> packaging dependency bundle: deps-b782fefaa879d5a30a97f18f978c1026.tar.gz from /usr/workspace/clone/node_modules
DEPS_FOUND=
Done in 49.78s.
[4/4] Building fresh packages...
[3/4] Linking dependencies...
info "fsevents@1.2.3" is an optional dependency and failed compatibility check. Excluding it from installation.
info fsevents@1.2.3: The platform "linux" is incompatible with this module.
[2/4] Fetching packages...
[1/4] Resolving packages...
yarn install v1.7.0
>>> running custom build commmand..
An error occurred (InvalidAccessKeyId) when calling the ListObjects operation: The AWS Access Key Id you provided does not exist in our records.

>>> setting aws creds.
IAM_ENABLED=
S3_DEPENDENCY_BUCKET=gtmstorage2
AWS_S3_PROXY=
DEPS_DIR=/usr/workspace/clone/node_modules
DEPS_SUM=b782fefaa879d5a30a97f18f978c1026
BUILD_TYPE=nodejs
>>> checking for packaged deps
Cloning into 'clone'...
>>> cloning repo..

```

https://github.com/apocas/dockerode


Is there any planned changes to update minSdk?


hh


Ahh. Varianten med .reduce() såg jag faktiskt i ett youtube-klipp på tunnelbanan på väg till jobbet i morse.

Och felet i j-dice.html tror jag kommer sig från att jag från början hade för avsikt att göra allting static så att man slapp initiera objekten utan bara kunde göra D6.Roll() direkt.


<html>
  <head>
    <!-- ... -->
  </head>
  <body>
    <!-- ... -->
    <script src="https://cdn.passprotect.io/passprotect.min.js"></script>
  </body>
</html>


try\catch выведен в main из метода


Done: https://github.com/ipfs/go-ipfs/issues/5123


What is in the `^gc.log`?


create table jsp_member
(
  id varchar2(50) not null primary KEY
  ,password varchar2(50) not null
  ,name varchar2(50) not null
  ,gender varchar2(10)
  ,birth date
  ,mail varchar2(100)
  ,phone varchar2(50)
  ,address varchar2(100)
  ,reg date default sysdate
);


This looks wrong to me. A queue address should not need to be multicast, it should be anycast.


`test
`


My comment id: aa8cdd5


Since the stream is no longer initialised in the ``try`` it will not be closed
Probably better to have ``InputStream stream = null`` before the ``try``
and close if not ``null`` in ``finally`` block


apayah


ok, thanks @yurloc !


was that wanted?


I think that as part of this fix, we should rename `query_cache_inv_id` back to `query_cache_inv_trx_id`, like it was before the 5.7 changes.


Good luck


### Results for event id: fc96c1b7-4cd6-4b16-a789-a993ce1ac6c9
DockerServerless : Deploy to Lambda (e930a1) Docker output validation failed for outputRegex

**output tail (26 lines total):**

```
...
An error occurred (AuthorizationHeaderMalformed) when calling the PutObject operation: The authorization header is malformed; a non-empty Access Key (AKID) must be provided in the credential.

>>> uploading dependency bundle to s3: deps-b782fefaa879d5a30a97f18f978c1026.tar.gz
>>> packaging dependency bundle: deps-b782fefaa879d5a30a97f18f978c1026.tar.gz from /usr/workspace/clone/node_modules
DEPS_FOUND=
Done in 56.34s.
[4/4] Building fresh packages...
[3/4] Linking dependencies...
info "fsevents@1.2.3" is an optional dependency and failed compatibility check. Excluding it from installation.
info fsevents@1.2.3: The platform "linux" is incompatible with this module.
[2/4] Fetching packages...
[1/4] Resolving packages...
yarn install v1.7.0
>>> running custom build commmand..
An error occurred (AuthorizationHeaderMalformed) when calling the ListObjects operation: The authorization header is malformed; a non-empty Access Key (AKID) must be provided in the credential.

>>> setting aws creds.
IAM_ENABLED=
S3_DEPENDENCY_BUCKET=gtmstorage2
AWS_S3_PROXY=
DEPS_DIR=/usr/workspace/clone/node_modules
DEPS_SUM=b782fefaa879d5a30a97f18f978c1026
BUILD_TYPE=nodejs
>>> checking for packaged deps
Cloning into 'clone'...
>>> cloning repo..

```

https://github.com/apocas/dockerode


ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ


안창피해요? ㅋㅋㅋㅋㅋ


I don't think you have manually eta-expand the second component?


🔥 [Jenkins job](http://xamarin-jenkins.guest.corp.microsoft.com:8080/job/macios/job/d15-8/8/display/redirect) (on internal Jenkins) failed in stage 'Test run' 🔥 : hudson.AbortException: script returned exit code 143

✅ [Build succeeded](http://xamarin-jenkins.guest.corp.microsoft.com:8080/job/macios/job/d15-8/8//console)
✅ [API Diff (from stable)](http://xamarin-storage/jenkins/xamarin-macios/d15-8/8b4f80065cd9fe312678c4bee26c35a66ab43317/8/jenkins-results/api-diff/index.html)
✅ [API Diff (from PR only)](http://xamarin-storage/jenkins/xamarin-macios/d15-8/8b4f80065cd9fe312678c4bee26c35a66ab43317/8/jenkins-results/apicomparison/index.html) (no change)
✅ [Generator Diff](http://xamarin-storage/jenkins/xamarin-macios/d15-8/8b4f80065cd9fe312678c4bee26c35a66ab43317/8/jenkins-results/generator-diff/index.html) (only version changes)


@teoric it looks like you didn't set up email bound to your GitHub account in yout local Git. You may want to fix this.


In `lock_release()` we are unnecessarily reading `max_trx_id` if `trx->undo_no == 0`. I’d do something like this:
```c
trx_id_t max_trx_id = trx->undo_no ? trx_sys_get_max_trx_id() : 0;
```
and then later in the function, replace
```c
			dict_table_t*	table;

			table = lock->un_member.tab_lock.table;

			if (lock_get_mode(lock) != LOCK_IS
			    && trx->undo_no != 0) {

				/* The trx may have modified the table. We
				block the use of the MySQL query cache for
				all currently active transactions. */

				table->query_cache_inv_id = max_trx_id;
			}
```
with
```c
			if (max_trx_id && lock_get_mode(lock) != LOCK_IS) {
				/* The trx may have modified the table. We
				block the use of the query cache for
				all currently active transactions. */
				lock->un_member.tab_lock.table
					->query_cache_inv_trx_id = max_trx_id;
			}
```


@webknjaz: Yes, probably, but it's too late for anonymity, anyway ;-).


String interpolation with an implicit `null` to `string` conversion is a rather obscure solution and an absolute micro optimization. If you're really into squeezing out the tiniest bit of performance, then you would have called `$user->username` in the first place ;)


### Results for event id: 82cf1270-b452-4739-8ff8-f710dc58c315
DockerServerless : Deploy to Lambda (e930a1) Docker output validation failed for outputRegex

**output tail (26 lines total):**

```
...
An error occurred (InvalidAccessKeyId) when calling the PutObject operation: The AWS Access Key Id you provided does not exist in our records.

>>> uploading dependency bundle to s3: deps-b782fefaa879d5a30a97f18f978c1026.tar.gz
>>> packaging dependency bundle: deps-b782fefaa879d5a30a97f18f978c1026.tar.gz from /usr/workspace/clone/node_modules
DEPS_FOUND=
Done in 48.92s.
[4/4] Building fresh packages...
[3/4] Linking dependencies...
info "fsevents@1.2.3" is an optional dependency and failed compatibility check. Excluding it from installation.
info fsevents@1.2.3: The platform "linux" is incompatible with this module.
[2/4] Fetching packages...
[1/4] Resolving packages...
yarn install v1.7.0
>>> running custom build commmand..
An error occurred (InvalidAccessKeyId) when calling the ListObjects operation: The AWS Access Key Id you provided does not exist in our records.

>>> setting aws creds.
IAM_ENABLED=
S3_DEPENDENCY_BUCKET=gtmstorage2
AWS_S3_PROXY=
DEPS_DIR=/usr/workspace/clone/node_modules
DEPS_SUM=b782fefaa879d5a30a97f18f978c1026
BUILD_TYPE=nodejs
>>> checking for packaged deps
Cloning into 'clone'...
>>> cloning repo..

```

https://github.com/apocas/dockerode


I had several side effects of using coverage from inside of pytest vs pytest inside of coverage. Especially when the test env is a Django test env. There happend things like a whole function was green but its prototype was red.

Further aiohttp-json-rpc is a pytest plugin it self, and the coverage output of aiohttp_json_rpc.pytest seemed broken to me some times.

We had the same issue on labgrid and solved it with fixing some import issues, but this solution clashed with the django import order.

So i decided i need a general and more simple solution and kicked pytest-cov out


Done


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


那个匹配的规则永远置顶，和我的 adbyby plus 规则冲突了


I mean you could add the email to your account, so GH would link commit to profile


:-)

Passing on the congratulations to @ENT8R as well

Why do you think that it will reduce the number of notes?

On June 15, 2018 9:22:18 AM GMT+02:00, Mateusz Konieczny <notifications@github.com> wrote:
>Congratulations!
>
>Not only it was one of the most requested quests, but it also should
>significantly reduce how many notes are generated by StreetComplete and
>it resulted in significant improvements to how building scheme is
>documented on Wiki.


検索ダイアログの間違い


zhimz here,,,, like buliding progressive websites


ok, gracias.

Sixto Herrera García
 Grupo de Meteorología
 Depto. Matemática Aplicada y CC de la Computación
 Universidad de Cantabria
 [ETSI Caminos; Despacho 1038; Planta +1, (+34) 942 20 13 63]
 [EPI Minas y Energía; Despacho 240; Planta +2, (+34) 942 84 65 44]
________________________________
De: miturbide <notifications@github.com>
Enviado: viernes, 15 de junio de 2018 11:13:47
Para: SantanderMetGroup/loadeR.ECOMS
Cc: Subscribed
Asunto: Re: [SantanderMetGroup/loadeR.ECOMS] update CFS dictionary (624dd14)

Done

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<https://github.com/SantanderMetGroup/loadeR.ECOMS/commit/624dd14b16e9187f878f2bb2f1817555859bb55a#commitcomment-29376512>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFiMDGUhqWKdh3cnDIQ_qGGT_NPLPfCdks5t83rLgaJpZM4UoK81>.


Nop, debugging leftover. Good catch.


"zero value" is "zero value".  It is exact same to "time.Time{}"
It is well defined in Go.


k


good luck


But how you use to draw the plot is based on tfs_embedded, but not the kmeans result?!


Hi I'm curious as to why this change was made?


well, fortunately for a ByteArrayInputStream the close() method has no effect


Good luck, poor developer.


### Results for event id: 765b9d09-5acc-4e0c-9f90-d0e7892e6b11
DockerServerless : Deploy to Lambda (e930a1) Docker output validation failed for outputRegex

**output tail (26 lines total):**

```
...
An error occurred (InvalidAccessKeyId) when calling the PutObject operation: The AWS Access Key Id you provided does not exist in our records.

>>> uploading dependency bundle to s3: deps-b782fefaa879d5a30a97f18f978c1026.tar.gz
>>> packaging dependency bundle: deps-b782fefaa879d5a30a97f18f978c1026.tar.gz from /usr/workspace/clone/node_modules
DEPS_FOUND=
Done in 75.68s.
[4/4] Building fresh packages...
[3/4] Linking dependencies...
info "fsevents@1.2.3" is an optional dependency and failed compatibility check. Excluding it from installation.
info fsevents@1.2.3: The platform "linux" is incompatible with this module.
[2/4] Fetching packages...
[1/4] Resolving packages...
yarn install v1.7.0
>>> running custom build commmand..
An error occurred (InvalidAccessKeyId) when calling the ListObjects operation: The AWS Access Key Id you provided does not exist in our records.

>>> setting aws creds.
IAM_ENABLED=
S3_DEPENDENCY_BUCKET=gtmstorage2
AWS_S3_PROXY=
DEPS_DIR=/usr/workspace/clone/node_modules
DEPS_SUM=b782fefaa879d5a30a97f18f978c1026
BUILD_TYPE=nodejs
>>> checking for packaged deps
Cloning into 'clone'...
>>> cloning repo..

```

https://github.com/apocas/dockerode


You should use built-in random tensors from Pytorch


всегда в API стоит делать паджинацию


remove comment


extract this logic from `app.js`


### Results for event id: 55a1bf14-3dd6-47a2-8d96-f2fac94ea8a7
DockerServerless : Deploy to Lambda (e930a1) Docker output validation failed for outputRegex

**output tail (504 lines total):**

```
...
[601] /usr/workspace/clone/node_modules/aws-sdk/clients/all.js 5.42 KiB {0} [built]
[765] ./src/index.js 6.48 KiB {0} [built]
    + 751 hidden modules

WARNING in /usr/workspace/clone/node_modules/dtrace-provider/dtrace-provider.js
Module not found: Error: Can't resolve './src/build' in '/usr/workspace/clone/node_modules/dtrace-provider'
 @ /usr/workspace/clone/node_modules/dtrace-provider/dtrace-provider.js 18:22-85
 @ /usr/workspace/clone/node_modules/bunyan/lib/bunyan.js
 @ ./src/index.js
Serverless: Zip function: /usr/workspace/clone/packages/sample-kms/.build/.webpack/sample-kms [94 ms]
Serverless: Packaging service...
Serverless: Remove /usr/workspace/clone/packages/sample-kms/.build/.webpack

  Serverless Error ---------------------------------------

  Unsupported role provided: "undefined"

  Get Support --------------------------------------------
     Docs:          docs.serverless.com
     Bugs:          github.com/serverless/serverless/issues
     Issues:        forum.serverless.com

  Your Environment Information -----------------------------
     OS:                     linux
     Node Version:           8.11.1
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.

     Serverless Version:     1.27.3

```

https://github.com/apocas/dockerode


create `utils` file and move compareHashTag to `utils`


I checked https://github.com/mysql/mysql-server/commit/b0ebbb963c266b8e06f9efa6a97e5c8e3e7cd59b (which broke this upstream) and https://github.com/mysql/mysql-server/commit/5cca468f6284f91bc9ef2db96a6b0cb9eba95400 (which attempted to fix this). Their condition reads:
```c
	if (lock_table_get_n_locks(table) == 0
	    && ((trx->id != 0 && trx->id >= table->query_cache_inv_id)
		|| !MVCC::is_view_active(trx->read_view)
		|| trx->read_view->low_limit_id()
		>= table->query_cache_inv_trx_id)) {
```
Before the breakage and fix, it was:
```c
	if (lock_table_get_n_locks(table) == 0
	    && trx->id >= table->query_cache_inv_trx_id) {
```
Clearly, the condition has to be more complex, because read-only transactions will carry `trx->id=0`.
It looks like
```c
((trx->id != 0 && trx->id >= table->query_cache_inv_id)
```
should have been replaced with
```c
trx->id ? trx->id >= table->query_cache_inv_id :
```
to get the correct intention (use the old logic for read-write transactions, and the new logic for read-only transactions).


tôi không biết gì cả


create `service` layer


@wonder-sk , this created a regression; rule-based rules aren't  shown in the layers panel anymore when a layer is placed in a group.


The fix 10b8565 helped and worked. Thanks a lot for the hint.


We must use `MVCC::is_view_active(trx->read_view)` instead of merely checking `trx->read_view == NULL`, because `MVCC::view_close()` would set the least significant bit of the pointer.


use `let`


code duplication - check lines 10-12


Done.


try not to commit console.log


First commit!


missing `;`


I'm still having a hard time figuring out what the Developers of Incredible Power did intentionnaly or not.


`/galerie.php`


### Results for event id: a1401a9a-bd33-4afe-b1d4-ebb7ca642bdf
DockerServerless : Deploy to Lambda (e930a1) Execution completed.

**output tail (529 lines total):**

```
...
ALL DEPLOYS SUCCESSFUL
Done in 95.89s.

ServerlessDeploymentBucketName: sample-kms-dev-serverlessdeploymentbucket-iq998uufi1jg
ServiceEndpoint: https://o9tib744fd.execute-api.ap-southeast-2.amazonaws.com/dev
SampleDashkmsLambdaFunctionQualifiedArn: arn:aws:lambda:ap-southeast-2:347186442473:function:sample-kms-dev-sample-kms:2
Stack Outputs

  sample-kms: sample-kms-dev-sample-kms
functions:
  GET - https://o9tib744fd.execute-api.ap-southeast-2.amazonaws.com/dev/sample-kms/{id}
endpoints:
  None
api keys:
stack: sample-kms-dev
region: ap-southeast-2
stage: dev
service: sample-kms
Service Information
Serverless: Stack update finished...
CloudFormation - UPDATE_COMPLETE - AWS::CloudFormation::Stack - sample-kms-dev
CloudFormation - DELETE_COMPLETE - AWS::ApiGateway::Deployment - ApiGatewayDeployment1529045002475
CloudFormation - DELETE_IN_PROGRESS - AWS::ApiGateway::Deployment - ApiGatewayDeployment1529045002475
CloudFormation - DELETE_SKIPPED - AWS::Lambda::Version - SampleDashkmsLambdaVersion8W3InqAe8VQzmsZ0C8DV9DSoWNioovgA39W8HijQ
CloudFormation - UPDATE_COMPLETE_CLEANUP_IN_PROGRESS - AWS::CloudFormation::Stack - sample-kms-dev
CloudFormation - CREATE_COMPLETE - AWS::ApiGateway::Deployment - ApiGatewayDeployment1529055996584
CloudFormation - CREATE_IN_PROGRESS - AWS::ApiGateway::Deployment - ApiGatewayDeployment1529055996584
CloudFormation - CREATE_IN_PROGRESS - AWS::ApiGateway::Deployment - ApiGatewayDeployment1529055996584
CloudFormation - CREATE_COMPLETE - AWS::Lambda::Version - SampleDashkmsLambdaVersion9KV6wM0jY7ZoKkrtazeUqyaka2TGd9GZmitHnlQ5A

```

https://github.com/apocas/dockerode


oh, that means we'll need to do another release without the pin I guess, @dLobatog I check this PR worked fine with net-ssh 5.0.1 so I think we can just drop the pin


Hey, you can use the compatible version Ameba version now: https://github.com/veelenga/ameba/releases/tag/v0.7.0


rangerk: "You cannot have a justice system without the initiation of force."

Not sure what school of libertarian thought you once subscribed to, but as far as I understand, the most effective justice system, that human's have so far designed, is generally supposed to be a physically defensive force, not an offensive one.

By 'force' is meant physical force, since only a fool would argue he has been victimized by superior force of argument. And so the initiation of (physical)force refers to the the use of non-defensive force. This is the all-important distinction to make, which is never - or rarely - taught or debated in public education institutions i.e. is the physical force offensive or defensive.

The core of the NAP(Non-Aggression Principle) is that it is *never* okay to use offensive physical force, including the threat of physical force. And it is always okay - even honorable - to use defensive physical force, in proportion to the initiation of physical force.

So 'force' is always physical force, and aggression is the initiation of such force i.e. the offensive, rather than defensive, use of physical force.

The NAP is not a promise to solve human problems. It just puts those, who hold it as a core value, in a far superior position to solve human problems.


This is the kind of changes where i would prefer we have a PR.
It modifies code someone else did.
It's the case where i think that ``V3BwFile`` should be have all the functionality for creating/parsing v3bw files, and it should be able to write.


IBM Cloud [toolchain](https://console.ng.bluemix.net/devops/toolchains/5a11b016-c44b-49c4-88ec-e129a433c66d?env_id=ibm%3Ayp%3Aus-south "flasky0001"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/b55ef3b5-f9a9-47cf-af29-0e1c663889c7?env_id=ibm%3Ayp%3Aus-south "flasky0001") deployed [flasky0001](https://github.com/StepR/flasky0001/releases/tag/deploy-ibm-yp-us-south-stereimann-DemoSpace-20180615-094933 "deploy-ibm-yp-us-south-stereimann-DemoSpace-20180615-094933") to [DemoSpace](https://console.bluemix.net/apps/3b863b11-b50c-4911-beb1-e3cc06e9f234?env_id=ibm:yp:us-south "ibm:yp:us-south:stereimann:DemoSpace"), including this commit


Виконано


append instead of insertBefore when the document does not already contain a script tag.


I actually wanted to change ``V3BWLine`` to ``V3BwLine`` and not the other way around.
I didn't do it because that was code you created.


good luck


logs from garbage collection runs. If you use jdk9 they are in `gc.log` and `gc.log.00`, etc. For jdk8 `gc.log.0.current` etc.


ACK deecfcdc3ef1f5b5d162cf78cfa9fbd9459bf2f3


Tips med options, försök att undvika .get

if (opt.isDefined) opt.get + 1 else x

Vs.

opt.map(_ + 1).getOrElse(x)


Thanks :+1:


But in this way is necessary create a config.XML file into that path ???


### Results for event id: a9b21916-84c2-4a3d-82ca-a0988b41bad3
DockerServerless : Deploy to Lambda (e930a1) Execution completed.

**output tail (522 lines total):**

```
...
CloudFormation - UPDATE_IN_PROGRESS - AWS::Lambda::Function - SampleDashkmsLambdaFunction
CloudFormation - UPDATE_COMPLETE - AWS::Lambda::Function - SampleDashkmsLambdaFunction
CloudFormation - CREATE_IN_PROGRESS - AWS::ApiGateway::Deployment - ApiGatewayDeployment1529056458507
CloudFormation - CREATE_IN_PROGRESS - AWS::ApiGateway::Deployment - ApiGatewayDeployment1529056458507
CloudFormation - CREATE_COMPLETE - AWS::ApiGateway::Deployment - ApiGatewayDeployment1529056458507
CloudFormation - UPDATE_COMPLETE_CLEANUP_IN_PROGRESS - AWS::CloudFormation::Stack - sample-kms-dev
CloudFormation - DELETE_IN_PROGRESS - AWS::ApiGateway::Deployment - ApiGatewayDeployment1529055996584
ALL DEPLOYS SUCCESSFUL
Done in 83.02s.

ServerlessDeploymentBucketName: sample-kms-dev-serverlessdeploymentbucket-iq998uufi1jg
ServiceEndpoint: https://o9tib744fd.execute-api.ap-southeast-2.amazonaws.com/dev
SampleDashkmsLambdaFunctionQualifiedArn: arn:aws:lambda:ap-southeast-2:347186442473:function:sample-kms-dev-sample-kms:2
Stack Outputs

  sample-kms: sample-kms-dev-sample-kms
functions:
  GET - https://o9tib744fd.execute-api.ap-southeast-2.amazonaws.com/dev/sample-kms/{id}
endpoints:
  None
api keys:
stack: sample-kms-dev
region: ap-southeast-2
stage: dev
service: sample-kms
Service Information
Serverless: Stack update finished...
CloudFormation - UPDATE_COMPLETE - AWS::CloudFormation::Stack - sample-kms-dev
CloudFormation - DELETE_COMPLETE - AWS::ApiGateway::Deployment - ApiGatewayDeployment1529055996584

```

https://github.com/apocas/dockerode


@fgrcon Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.namedfile/85/violations
```
plone/namedfile/marshaler.py:16:1: I003 isort expected 1 blank line in imports, found 0
plone/namedfile/marshaler.py:17:1: E302 expected 2 blank lines, found 1
plone/namedfile/marshaler.py:60:9: T002 import for pdb found as pdb
plone/namedfile/marshaler.py:60:19: E702 multiple statements on one line (semicolon)
plone/namedfile/marshaler.py:66:17: T002 import for pdb found as pdb
plone/namedfile/marshaler.py:66:27: E702 multiple statements on one line (semicolon)
plone/namedfile/marshaler.py:73:36: C812 missing trailing comma
plone/namedfile/storages.py:12:1: I003 isort expected 1 blank line in imports, found 0
plone/namedfile/testing.py:18:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/namedfile/testing.py:22:36: C812 missing trailing comma
plone/namedfile/file.py:25:1: I003 isort expected 1 blank line in imports, found 0
plone/namedfile/file.py:266:9: Q001 Remove bad quotes from multiline string.
plone/namedfile/file.py:307:9: Q001 Remove bad quotes from multiline string.
plone/namedfile/handler.py:11:23: C812 missing trailing comma
plone/namedfile/interfaces.py:17:25: C812 missing trailing comma
plone/namedfile/scaling.py:33:1: I003 isort expected 1 blank line in imports, found 0
plone/namedfile/scaling.py:192:25: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:195:5: C901 'DefaultImageScalingFactory.__call__' is too complex (15)
plone/namedfile/scaling.py:202:25: C816 missing trailing comma in Python 3.6+
plone/namedfile/scaling.py:242:29: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:406:21: C816 missing trailing comma in Python 3.6+
plone/namedfile/scaling.py:433:25: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:445:25: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:459:21: C816 missing trailing comma in Python 3.6+
plone/namedfile/scaling.py:485:29: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:499:17: C816 missing trailing comma in Python 3.6+
plone/namedfile/utils/__init__.py:19:1: I003 isort expected 1 blank line in imports, found 0
plone/namedfile/utils/__init__.py:83:66: C812 missing trailing comma
plone/namedfile/utils/__init__.py:150:15: T000 Todo note found.
plone/namedfile/utils/__init__.py:155:73: C812 missing trailing comma
plone/namedfile/utils/__init__.py:175:15: T000 Todo note found.
plone/namedfile/utils/__init__.py:182:18: C812 missing trailing comma
plone/namedfile/utils/__init__.py:187:1: C901 'rotate_image' is too complex (20)
plone/namedfile/utils/__init__.py:218:14: C812 missing trailing comma
plone/namedfile/utils/__init__.py:270:25: F821 undefined name 'StringIO'
plone/namedfile/utils/__init__.py:275:1: E302 expected 2 blank lines, found 1
plone/namedfile/utils/__init__.py:279:1: E302 expected 2 blank lines, found 1
plone/namedfile/utils/tiff_utils.py:11:1: C901 'process_tiff' is too complex (11)
plone/namedfile/utils/tiff_utils.py:20:7: T000 Todo note found.
plone/namedfile/utils/tiff_utils.py:81:7: T000 Todo note found.
plone/namedfile/utils/tiff_utils.py:82:7: T000 Todo note found.
plone/namedfile/tests/test_blobfile.py:40:31: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:45:35: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:50:46: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:55:32: C812 missing trailing comma
plone/namedfile/tests/test_scaling.py:85:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:102:80: E501 line too long (81 > 79 characters)
plone/namedfile/tests/test_scaling.py:133:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:156:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:178:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:200:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_image.py:25:80: E501 line too long (80 > 79 characters)
plone/namedfile/tests/test_doctests.py:17:1: E302 expected 2 blank lines, found 1
plone/namedfile/tests/test_doctests.py:20:19: F821 undefined name 're'
plone/namedfile/tests/test_doctests.py:21:19: F821 undefined name 're'
plone/namedfile/tests/test_doctests.py:22:19: F821 undefined name 're'
plone/namedfile/tests/test_doctests.py:25:20: C812 missing trailing comma
plone/namedfile/tests/test_doctests.py:39:51: C812 missing trailing comma
plone/namedfile/tests/test_doctests.py:41:10: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:116:28: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:146:70: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:153:76: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:164:74: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:197:75: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:202:78: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


![](https://github.trello.services/images/mini-trello-icon.png) [대량의 Trained Data, Test Data 생성](https://trello.com/c/DDTWCiGs/54-%EB%8C%80%EB%9F%89%EC%9D%98-trained-data-test-data-%EC%83%9D%EC%84%B1)


`context` is not used - it shouldn't be an argument to this function (this is a hangover from when we needed to access `context['request'].is_secure()`. Also, you have reinvented `url_from_path` in `utils/utils.py`.


No objections from me as far as I can remember :innocent:


The logic in this patch (revised to use `MVCC::is_view_active()`) would do
```c++
!lock_table_get_n_locks(table)
&& (trx->id
    ? (trx->id >= table->query_cache_inv_trx_id
       && (!MVCC::is_view_active(trx->read_view)
           || trx->read_view->low_limit_id()
           >= table->query_cache_inv_id)
    : (!MVCC::is_view_active(trx->read_view)
       || trx->read_view->low_limit_id()
       >= table->query_cache_inv_id))
```
(Correct me if I transformed it wrong.) This could be further simplified to
```c++
!lock_table_get_n_locks(table)
&& (!trx->id || trx->id >= table->query_cache_inv_trx_id)
&& (!MVCC::is_view_active(trx->read_view)
    || trx->read_view->low_limit_id()
    >= table->query_cache_inv_id)
```
Which one looks more correct, the above, or what I think that the original fix in upstream should have been:
```c++
!lock_table_get_n_locks(table)
&& (trx->id
    ? trx->id >= table->query_cache_inv_id
    : (!MVCC::is_view_active(trx->read_view)
       || trx->read_view->low_limit_id()
       >= table->query_cache_inv_trx_id))
```


This function will be redundant once the changes to `path_to_url` above are done.


@if $number > 1 and $gutter > 0


Created multidev environment [dgreat#pr-qlclass](https://dashboard.pantheon.io/sites/41cad7fe-472d-43a9-a470-d391b9622376#pr-qlclass).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-qlclass-dgreat.pantheonsite.io/)


htp:/gitscm


//failed


//running


he, I found some mark down syntax are not correct, the text will not be displayed correctly. You need to do some investigate and fix them.


tfjob//running


I doubt that prohibiting "zweifel" is the correct solution.


good


move to html-select directory, add docs for common HTML props

Preview: documentation | landing | table


The 434 SkillLine.dbc has 173 entries..
The skill store only 128 slots..
Therefor I initialize only the professions needed..  (calling skill's one by one looks very bad :-) )

the 434 SkillLine.dbc has only 7 columns.. there is no flag to see what profession must pre-init and what not.. ( the WoD skill store has 128 slots to.. so i guess the part  && pSkill->unk_1 != 0x1080 reduce it)

Then I was afraid, that our core is misunderstand a new empty entry on other places.
Therefor I initialize the init entry's as temporary and not as unchanged.. maybe this is over complicated to..

have you a good idea how to init, using the SkillLine.dbc??


@tranleduy2000 I did not quite understand, but I look forward to the next updates good luck and good work :)


Created multidev environment [online-orientation#pr-12](https://dashboard.pantheon.io/sites/714bd05e-1a33-4f35-93a2-e9d6add67063#pr-12).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-12-online-orientation.pantheonsite.io/)


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


This line looks as if it could be related to issue #1942 with failures on macOS


This line looks as if it could be related to issue #1942 with failures on macOS.


Hi can I please be included, email addy is shawndauman@gmail.com


*responsivo


Created multidev environment [sfgov#ci-394](https://dashboard.pantheon.io/sites/91d50373-c4cf-40e4-a646-cb73e16a140c#ci-394).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-394-sfgov.pantheonsite.io/)


// declaration of variables must be first
var a = "Blowing from the west\n";
var b = "Fallen leaves gather\n";
var c = "In the east.";
var haiku = a+b+c;

console.log(haiku);


As long as you've tested and it works..


Forgot to make this chainable - the subsequent commit fixes that


Build version: __`0.10.0-renovate/docker-circleci-node-8.11.236`__ :crossed_fingers: [`renovate/docker-circleci-node-8.11`](https://github.com/streamich/ci-scripts/tree/renovate/docker-circleci-node-8.11) on [*Travis*](https://travis-ci.org/streamich/ci-scripts/builds/392954944) :tada:


This block isn't part of the parent project


And ditto for this block


@wolfbeast @janekptacijarabaci what is the reason for this revert?


158403977_Issue#6470 (lgu1234) - Win64-Windows-7-VisualStudio-14: OK (2927 of 2927 tests passed, 11 test warnings)

Messages:

 * 11 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)