Hi @amadanso, Can I ask why you are commenting on the code solutions?


Does this mean that operators can be either at the beginning or the end of lines?


aapt1 will no longer receive updates.


LGTM 👍 (for real)


Why ? Isn't it convenient for the create to just push a temporary id ?


Yes, it's used to check whether there isn't already a (hanging) background process running. I'm thinking about reimplementing some kind of pkill at start to make sure any hanging background processes are killed first. Thoughts?


On Tue, 12 Jun 2018, Markus Elfring wrote:

>
>       …, but that would be X[...].
>
> How should the software work with special cases like the following?
>
>  *  The array variable (or a function parameter) name can be “delete”, can't
>     it?

Not in C++.  In C++ delete is a keyword, not an identifier.

>  *  Does the SmPL ellipsis handle also empty source code?

I believe so.  You can easily test this.

julia

> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the
> thread.[AAesmhHgc_PCWCa3DVxHfjacTkeZLf0Jks5t74hdgaJpZM4UjJ2l.gif]
>
>
>


@pbauer Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.users/58/violations
```
plone/app/users/schema.py:22:21: Q000 Remove bad quotes.
plone/app/users/schema.py:24:16: Q000 Remove bad quotes.
plone/app/users/schema.py:34:11: T000 Todo note found.
plone/app/users/schema.py:78:31: Q000 Remove bad quotes.
plone/app/users/schema.py:97:21: Q000 Remove bad quotes.
plone/app/users/schema.py:98:21: Q000 Remove bad quotes.
plone/app/users/schema.py:99:21: Q000 Remove bad quotes.
plone/app/users/schema.py:99:76: C812 missing trailing comma
plone/app/users/schema.py:100:10: C812 missing trailing comma
plone/app/users/schema.py:112:31: Q000 Remove bad quotes.
plone/app/users/schema.py:113:23: Q000 Remove bad quotes.
plone/app/users/schema.py:117:25: Q000 Remove bad quotes.
plone/app/users/schema.py:118:17: Q000 Remove bad quotes.
plone/app/users/schema.py:158:16: S001 found module formatter
plone/app/users/schema.py:172:48: C812 missing trailing comma
plone/app/users/schema.py:175:13: Q000 Remove bad quotes.
plone/app/users/schema.py:176:22: Q000 Remove bad quotes.
plone/app/users/schema.py:177:22: Q000 Remove bad quotes.
plone/app/users/schema.py:178:22: Q000 Remove bad quotes.
plone/app/users/schema.py:179:22: Q000 Remove bad quotes.
plone/app/users/schema.py:180:22: Q000 Remove bad quotes.
plone/app/users/schema.py:181:22: Q000 Remove bad quotes.
plone/app/users/vocabularies.py:3:1: I001 isort found an import in the wrong position
plone/app/users/vocabularies.py:42:80: E501 line too long (130 > 79 characters)
plone/app/users/vocabularies.py:116:25: S001 found module formatter
plone/app/users/field_extender.py:29:15: Q000 Remove bad quotes.
plone/app/users/field_extender.py:30:21: Q000 Remove bad quotes.
plone/app/users/field_extender.py:45:5: D001 found adapts( replace it with zope.component.adapter
plone/app/users/field_extender.py:74:56: Q000 Remove bad quotes.
plone/app/users/utils.py:22:65: C812 missing trailing comma
plone/app/users/utils.py:23:10: C812 missing trailing comma
plone/app/users/setuphandlers.py:5:1: I003 isort expected 1 blank line in imports, found 0
plone/app/users/upgrades.py:17:25: Q000 Remove bad quotes.
plone/app/users/upgrades.py:40:31: Q000 Remove bad quotes.
plone/app/users/upgrades.py:41:23: Q000 Remove bad quotes.
plone/app/users/upgrades.py:52:31: Q000 Remove bad quotes.
plone/app/users/upgrades.py:53:23: Q000 Remove bad quotes.
plone/app/users/upgrades.py:54:23: Q000 Remove bad quotes.
plone/app/users/upgrades.py:65:31: Q000 Remove bad quotes.
plone/app/users/upgrades.py:66:23: Q000 Remove bad quotes.
plone/app/users/upgrades.py:67:23: Q000 Remove bad quotes.
plone/app/users/upgrades.py:81:72: C812 missing trailing comma
plone/app/users/upgrades.py:98:33: Q000 Remove bad quotes.
plone/app/users/upgrades.py:114:9: E128 continuation line under-indented for visual indent
plone/app/users/upgrades.py:115:20: C812 missing trailing comma
plone/app/users/browser/account.py:28:1: F401 'six' imported but unused
plone/app/users/browser/account.py:33:16: Q000 Remove bad quotes.
plone/app/users/browser/account.py:34:16: Q000 Remove bad quotes.
plone/app/users/browser/account.py:38:16: Q000 Remove bad quotes.
plone/app/users/browser/account.py:39:16: Q000 Remove bad quotes.
plone/app/users/browser/account.py:40:16: Q000 Remove bad quotes.
plone/app/users/browser/account.py:79:44: C812 missing trailing comma
plone/app/users/browser/account.py:93:39: P002 found "hasattr", consider replacing it
plone/app/users/browser/account.py:140:24: Q000 Remove bad quotes.
plone/app/users/browser/account.py:141:26: Q000 Remove bad quotes.
plone/app/users/browser/account.py:172:20: P101 format string does contain unindexed parameters
plone/app/users/browser/account.py:189:41: Q000 Remove bad quotes.
plone/app/users/browser/account.py:234:57: Q000 Remove bad quotes.
plone/app/users/browser/account.py:235:60: Q000 Remove bad quotes.
plone/app/users/browser/account.py:237:13: S001 found module formatter
plone/app/users/browser/account.py:237:68: C812 missing trailing comma
plone/app/users/browser/membersearch.py:18:46: C812 missing trailing comma
plone/app/users/browser/register.py:53:41: C812 missing trailing comma
plone/app/users/browser/register.py:63:13: Q000 Remove bad quotes.
plone/app/users/browser/register.py:64:19: Q000 Remove bad quotes.
plone/app/users/browser/register.py:79:62: Q000 Remove bad quotes.
plone/app/users/browser/register.py:100:59: Q000 Remove bad quotes.
plone/app/users/browser/register.py:101:17: Q000 Remove bad quotes.
plone/app/users/browser/register.py:102:17: Q000 Remove bad quotes.
plone/app/users/browser/register.py:103:17: Q000 Remove bad quotes.
plone/app/users/browser/register.py:108:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:109:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:110:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:111:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:111:50: C812 missing trailing comma
plone/app/users/browser/register.py:125:49: C812 missing trailing comma
plone/app/users/browser/register.py:129:5: C901 'BaseRegistrationForm.generate_user_id' is too complex (12)
plone/app/users/browser/register.py:206:12: P002 found "hasattr", consider replacing it
plone/app/users/browser/register.py:217:22: Q000 Remove bad quotes.
plone/app/users/browser/register.py:217:22: S001 found module formatter
plone/app/users/browser/register.py:276:5: C901 'BaseRegistrationForm.validate_registration' is too complex (17)
plone/app/users/browser/register.py:352:29: Q000 Remove bad quotes.
plone/app/users/browser/register.py:353:29: Q000 Remove bad quotes.
plone/app/users/browser/register.py:360:29: Q000 Remove bad quotes.
plone/app/users/browser/register.py:361:29: Q000 Remove bad quotes.
plone/app/users/browser/register.py:371:29: Q000 Remove bad quotes.
plone/app/users/browser/register.py:372:29: Q000 Remove bad quotes.
plone/app/users/browser/register.py:380:37: Q000 Remove bad quotes.
plone/app/users/browser/register.py:381:29: Q000 Remove bad quotes.
plone/app/users/browser/register.py:388:67: C812 missing trailing comma
plone/app/users/browser/register.py:404:11: T000 Todo note found.
plone/app/users/browser/register.py:413:5: C901 'BaseRegistrationForm.handle_join_success' is too complex (13)
plone/app/users/browser/register.py:450:69: Q000 Remove bad quotes.
plone/app/users/browser/register.py:493:35: Q000 Remove bad quotes.
plone/app/users/browser/register.py:494:27: Q000 Remove bad quotes.
plone/app/users/browser/register.py:495:27: Q000 Remove bad quotes.
plone/app/users/browser/register.py:505:35: Q000 Remove bad quotes.
plone/app/users/browser/register.py:506:27: Q000 Remove bad quotes.
plone/app/users/browser/register.py:507:27: Q000 Remove bad quotes.
plone/app/users/browser/register.py:553:19: Q000 Remove bad quotes.
plone/app/users/browser/register.py:611:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:612:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:613:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:614:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:621:19: Q000 Remove bad quotes.
plone/app/users/browser/register.py:662:65: C812 missing trailing comma
plone/app/users/browser/register.py:671:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:672:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:673:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:674:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:674:79: C812 missing trailing comma
plone/app/users/browser/register.py:680:67: C812 missing trailing comma
plone/app/users/browser/register.py:709:69: Q000 Remove bad quotes.
plone/app/users/browser/register.py:713:15: Q000 Remove bad quotes.
plone/app/users/browser/personalpreferences.py:34:46: C812 missing trailing comma
plone/app/users/browser/personalpreferences.py:36:20: Q000 Remove bad quotes.
plone/app/users/browser/personalpreferences.py:43:20: Q000 Remove bad quotes.
plone/app/users/browser/personalpreferences.py:44:23: C812 missing trailing comma
plone/app/users/browser/personalpreferences.py:82:41: C812 missing trailing comma
plone/app/users/browser/personalpreferences.py:88:50: C812 missing trailing comma
plone/app/users/browser/personalpreferences.py:95:13: Q000 Remove bad quotes.
plone/app/users/browser/personalpreferences.py:96:13: Q000 Remove bad quotes.
plone/app/users/browser/personalpreferences.py:96:47: C812 missing trailing comma
plone/app/users/browser/personalpreferences.py:99:13: Q000 Remove bad quotes.
plone/app/users/browser/personalpreferences.py:100:13: Q000 Remove bad quotes.
plone/app/users/browser/personalpreferences.py:100:32: C812 missing trailing comma
plone/app/users/browser/registersettingspanel.py:15:15: Q000 Remove bad quotes.
plone/app/users/browser/registersettingspanel.py:16:21: Q000 Remove bad quotes.
plone/app/users/browser/registersettingspanel.py:17:19: Q000 Remove bad quotes.
plone/app/users/browser/registersettingspanel.py:33:20: C812 missing trailing comma
plone/app/users/browser/registersettingspanel.py:51:49: C812 missing trailing comma
plone/app/users/browser/registersettingspanel.py:53:21: Q000 Remove bad quotes.
plone/app/users/browser/registersettingspanel.py:55:21: Q000 Remove bad quotes.
plone/app/users/browser/registersettingspanel.py:56:65: Q000 Remove bad quotes.
plone/app/users/browser/passwordpanel.py:30:21: Q000 Remove bad quotes.
plone/app/users/browser/passwordpanel.py:37:21: Q000 Remove bad quotes.
plone/app/users/browser/passwordpanel.py:38:13: Q000 Remove bad quotes.
plone/app/users/browser/passwordpanel.py:61:21: Q000 Remove bad quotes.
plone/app/users/browser/passwordpanel.py:76:45: C812 missing trailing comma
plone/app/users/browser/passwordpanel.py:93:29: Q000 Remove bad quotes.
plone/app/users/browser/passwordpanel.py:113:28: C812 missing trailing comma
plone/app/users/browser/passwordpanel.py:139:38: Q000 Remove bad quotes.
plone/app/users/browser/passwordpanel.py:139:45: C812 missing trailing comma
plone/app/users/browser/passwordpanel.py:144:15: Q000 Remove bad quotes.
plone/app/users/browser/passwordpanel.py:144:41: Q000 Remove bad quotes.
plone/app/users/browser/passwordpanel.py:144:47: C812 missing trailing comma
plone/app/users/browser/schemaeditor.py:49:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:50:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:51:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:52:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:53:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:54:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:55:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:56:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:57:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:58:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:59:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:60:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:61:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:98:15: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:111:21: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:139:30: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:146:17: S001 found module formatter
plone/app/users/browser/schemaeditor.py:220:33: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:225:28: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:226:31: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:229:17: B901 blind except: statement
plone/app/users/browser/schemaeditor.py:232:26: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:233:26: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:238:31: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:238:46: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:240:21: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:240:21: S001 found module formatter
plone/app/users/browser/schemaeditor.py:242:21: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:242:21: S001 found module formatter
plone/app/users/browser/schemaeditor.py:251:25: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:251:25: S001 found module formatter
plone/app/users/browser/schemaeditor.py:302:19: C812 missing trailing comma
plone/app/users/browser/schemaeditor.py:312:19: C812 missing trailing comma
plone/app/users/browser/userdatapanel.py:46:37: Q000 Remove bad quotes.
plone/app/users/browser/userdatapanel.py:78:53: C812 missing trailing comma
plone/app/users/browser/userdatapanel.py:84:59: C812 missing trailing comma
plone/app/users/browser/userdatapanel.py:103:41: C812 missing trailing comma
plone/app/users/tests/base.py:11:1: F401 'plone.app.testing.setRoles' imported but unused
plone/app/users/tests/base.py:12:1: I001 isort found an import in the wrong position
plone/app/users/tests/base.py:72:14: D001 found declarePrivate( replace it with AccessControl.ClassSecurityInfo.private
plone/app/users/tests/base.py:132:58: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:5:1: F401 'plone.app.users.testing.PLONE_APP_USERS_FUNCTIONAL_TESTING' imported but unused
plone/app/users/tests/test_exportimport.py:18:80: E501 line too long (438 > 79 characters)
plone/app/users/tests/test_exportimport.py:20:80: E501 line too long (81 > 79 characters)
plone/app/users/tests/test_exportimport.py:27:80: E501 line too long (84 > 79 characters)
plone/app/users/tests/test_exportimport.py:35:80: E501 line too long (85 > 79 characters)
plone/app/users/tests/test_exportimport.py:43:80: E501 line too long (101 > 79 characters)
plone/app/users/tests/test_exportimport.py:52:80: E501 line too long (82 > 79 characters)
plone/app/users/tests/test_exportimport.py:57:80: E501 line too long (89 > 79 characters)
plone/app/users/tests/test_exportimport.py:67:80: E501 line too long (85 > 79 characters)
plone/app/users/tests/test_exportimport.py:93:80: E501 line too long (83 > 79 characters)
plone/app/users/tests/test_exportimport.py:107:41: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:110:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:112:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:115:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:117:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:120:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:122:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:125:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:129:26: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:131:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:133:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:136:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:137:80: E501 line too long (81 > 79 characters)
plone/app/users/tests/test_exportimport.py:138:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:141:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:143:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:146:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:148:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:151:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:153:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:156:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:158:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:161:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:163:23: Q000 Remove bad quotes.
plone/app/users/tests/test_pam.py:2:1: I001 isort found an import in the wrong position
plone/app/users/tests/test_pam.py:4:1: F401 'plone.app.users.browser.userdatapanel.UserDataPanel' imported but unused
plone/app/users/tests/test_pam.py:5:1: F401 'plone.app.users.testing.PLONE_APP_USERS_FUNCTIONAL_TESTING' imported but unused
plone/app/users/tests/test_pam.py:6:1: I001 isort found an import in the wrong position
plone/app/users/tests/test_pam.py:7:1: I001 isort found an import in the wrong position
plone/app/users/tests/test_pam.py:8:1: I001 isort found an import in the wrong position
plone/app/users/tests/test_pam.py:9:1: I001 isort found an import in the wrong position
plone/app/users/tests/test_pam.py:10:1: I001 isort found an import in the wrong position
plone/app/users/tests/test_pam.py:11:1: I001 isort found an import in the wrong position
plone/app/users/tests/test_pam.py:12:1: I001 isort found an import in the wrong position
plone/app/users/tests/test_pam.py:14:1: F401 'zExceptions.NotFound' imported but unused
plone/app/users/tests/test_pam.py:15:1: F401 'zope.i18n.translate' imported but unused
plone/app/users/tests/test_pam.py:17:1: F401 'transaction.commit' imported but unused
plone/app/users/tests/test_pam.py:17:1: I001 isort found an import in the wrong position
plone/app/users/tests/test_pam.py:18:1: F401 'unittest' imported but unused
plone/app/users/tests/test_pam.py:19:1: I003 isort expected 1 blank line in imports, found 0
plone/app/users/tests/test_pam.py:20:1: E302 expected 2 blank lines, found 1
plone/app/users/tests/test_pam.py:37:10: Q000 Remove bad quotes.
plone/app/users/tests/test_pam.py:46:44: S001 found module formatter
plone/app/users/tests/test_pam.py:46:80: E501 line too long (96 > 79 characters)
plone/app/users/tests/test_pam.py:48:80: E501 line too long (100 > 79 characters)
plone/app/users/tests/test_new_user.py:13:62: C812 missing trailing comma
plone/app/users/tests/test_new_user.py:30:68: C812 missing trailing comma
plone/app/users/tests/test_new_user.py:43:62: C812 missing trailing comma
plone/app/users/tests/test_new_user.py:64:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:66:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:67:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:84:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:85:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:87:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:88:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:104:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:105:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:107:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:108:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:126:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:127:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:129:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:130:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:148:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:150:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:154:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:172:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:173:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:175:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:179:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_schema_types.py:6:1: F401 'plone.app.testing.bbb.PloneTestCase' imported but unused
plone/app/users/tests/test_schema_types.py:8:1: F401 'plone.app.users.testing.PLONE_APP_USERS_FUNCTIONAL_TESTING' imported but unused
plone/app/users/tests/test_schema_types.py:11:1: I001 isort found an import in the wrong position
plone/app/users/tests/test_schema_types.py:20:80: E501 line too long (438 > 79 characters)
plone/app/users/tests/test_schema_types.py:22:80: E501 line too long (81 > 79 characters)
plone/app/users/tests/test_schema_types.py:29:80: E501 line too long (84 > 79 characters)
plone/app/users/tests/test_schema_types.py:37:80: E501 line too long (85 > 79 characters)
plone/app/users/tests/test_schema_types.py:45:80: E501 line too long (101 > 79 characters)
plone/app/users/tests/test_schema_types.py:54:80: E501 line too long (82 > 79 characters)
plone/app/users/tests/test_schema_types.py:59:80: E501 line too long (89 > 79 characters)
plone/app/users/tests/test_schema_types.py:69:80: E501 line too long (85 > 79 characters)
plone/app/users/tests/test_schema_types.py:95:80: E501 line too long (83 > 79 characters)
plone/app/users/tests/test_schema_types.py:117:27: Q000 Remove bad quotes.
plone/app/users/tests/test_schema_types.py:123:41: Q000 Remove bad quotes.
plone/app/users/tests/test_schema_types.py:123:80: E501 line too long (80 > 79 characters)
plone/app/users/tests/test_schema_types.py:124:80: E501 line too long (116 > 79 characters)
plone/app/users/tests/test_schema_types.py:124:87: Q000 Remove bad quotes.
plone/app/users/tests/test_schema_types.py:124:100: Q000 Remove bad quotes.
plone/app/users/tests/test_schema_types.py:144:80: E501 line too long (84 > 79 characters)
plone/app/users/tests/test_doctests.py:30:1: E302 expected 2 blank lines, found 1
plone/app/users/tests/test_doctests.py:37:40: C812 missing trailing comma
plone/app/users/tests/test_user_data_panel.py:2:1: F401 'plone.app.testing.applyProfile' imported but unused
plone/app/users/tests/test_user_data_panel.py:4:1: F401 'plone.app.users.testing.PLONE_APP_USERS_FUNCTIONAL_TESTING' imported but unused
plone/app/users/tests/test_user_data_panel.py:16:30: C812 missing trailing comma
plone/app/users/tests/test_user_data_panel.py:28:62: C812 missing trailing comma
plone/app/users/tests/test_account.py:2:1: I001 isort found an import in the wrong position
plone/app/users/tests/test_account.py:4:1: F401 'plone.app.users.tests.base.BaseTestCase' imported but unused
plone/app/users/tests/test_account.py:7:1: I001 isort found an import in the wrong position
plone/app/users/tests/test_account.py:8:1: I003 isort expected 1 blank line in imports, found 0
plone/app/users/tests/test_robot.py:2:1: F401 'plone.app.users.testing.PLONE_APP_USERS_ACCEPTANCE_TESTING' imported but unused
plone/app/users/tests/test_robot.py:3:1: F401 'plone.testing.layered' imported but unused
plone/app/users/tests/test_robot.py:6:1: F401 'robotsuite' imported but unused
plone/app/users/tests/test_robot.py:13:53: Q000 Remove bad quotes.
plone/app/users/tests/test_robot.py:14:9: F841 local variable 'testfilepath' is assigned to but never used
plone/app/users/tests/test_robot.py:14:37: Q000 Remove bad quotes.
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Fixes #38


после "ретерн" не нужно отступать код


Environment


@murilohns a versão aqui se refere à versão da API, correto? Que tal se adicionar mais um header, pra dizer qual seria a "versão" deste módulo? Por exemplo:

```php
$headers = array(
    'X-PagarMe-Api-Version' => '2017-08-28',
    'X-PagarMe-Module-Version' => 'v1.2.3', // <- valor de exemplo =P
);
```

O que acha?


@lamhieu-vk
no problem. I refactored the component a bit and published a new major version to npm. Please check all changes in this commit https://github.com/maslianok/react-resize-detector/commit/523514e1bbe0820ae736763b5a7dcc3cbad42fb0#diff-6b06e44e83da431500ceb62801b523b3R1

BTW, good job! Thanks for working on this feature! :)


опять ненужный отступ


you can! just use the `short` module param - it is in fact a `u16` since [3.14](https://elixir.bootlin.com/linux/v3.14-rc1/source/kernel/params.c)


I wanted to keep the convention of calling it `ppa` and `pos` because this is the reverse of the function `int64_t lnvm_chunk_pos_from_ppa(LnvmCtrl *ln, uint64_t ppa)`.


@murilohns qual o propósito do campo `external_id`? Se ele foi feito para alguma funcionalidade externa, e não for obrigatório, acho que seria legal deixar o usuário livre para usá-lo como quiser, ao invés de passar um `customer_id`. O que acha?


hey nice work dude


It's also in anticipation of the order management to come


Yes, pos is the position in the `chunk_meta` array that is initialized in the `void lnvm_chunk_meta_init(...)` function.


@LienReyserhove Would update to is described in the source paper Zieritz et al. 2017 (page x)


why logging this as error?


thats incorrect


Não precisa desses espaços extras na chamada de `trim()`, pode usar da forma abaixo:

```php
'name'  	  => trim($order->billing_first_name . ' ' . $order->billing_last_name),
```


change to `final Call call`


heinomol säts wäri neiss


Rest of this looks fine to me :)


Dropa esse comentário por favor :D


we should probably just use get_template, let me dbl check ;)


Commits from the past


A gente não comita os `pyc`. Sugiro adicioná-lo no `.gitignore`.


That seems to break a bit the contract of the Terminal.  I would suggest you could bring back the `Writer` on the `Terminal` interface instead (it was removed by https://github.com/aeshell/aesh-readline/commit/efa3b27159c54e3becb7c5a3788aaed1a4bb6db2#diff-b1a04485265b44d60a131e2a98919111) and move back the encoding to the `Terminal` as it was initially. That said, if it works for you...


Coloca mais alguma info no seu readme. Tá bem pobrinho :-)


my intention was to make the bluenet id same as the userID. This method here is currently just for debugging purpose.


Dois espaços entre os import e a declaração da classe. Veja a PEP8. Use o `flake8` para identificar isso.


Resistance Variables not needed anymore. See commit bbbad9a3767839a87d9b7b2e99bb982ed4f30911


Isso aqui funciona? `20` não é iterável.


Naming Convention


Юхууууу, слежу за творчеством "гуру" кодинга с 2к15, контент улучшается, всё в работе становится лучше)


Essa expressão talvez possa ser resumida em um list comprehension.


Esse comentário também


тролль детектед )). В 2015ом мы еще знакомы даже не были ;)


They should most certainly _not_ be the same thing. You need to come up with a simple application layer protocol for exchanging information like that.


v.1.0 #


Isso não funciona (e vc tá programando C em Python).


Ч орт, спалили)


Но я ценю ваше нынешнее внимание к моему творчеству ))


I know this is already merged in and the new Gavel version already consumed in Dredd, BUT on one old buildserver, I had a serious problem due to this change.

Git v 2.1 does not support fetching via https+git

Example output from that server:
```
$ git --version
git version 2.1.2
$ git ls-remote -h -t https://git@github.com/josdejong/jsonlint.git
fatal: Unable to find remote helper for 'https'
```

For another build server with slightly more recent git it works as expected:
```
$ git --version
git version 2.3.3
$ git ls-remote -h -t https://git@github.com/josdejong/jsonlint.git
850473c5a6c44c43ddc06c10980a43ec25ac1454	refs/heads/gh-pages
85a19d77126771f3177582e3d09c6ffae185d391	refs/heads/master
e48d7b93b4c0196acd22d7b7263bd28994309274	refs/tags/v1.0.1
280ccc5121c9ff11a44c30b07ab1f380085a3c3b	refs/tags/v1.1.0
cfda950c3c60dbfaa540f5bfd277b38338170d10	refs/tags/v1.1.1
cdd45ca8ad12893c7ca3b70f336e200f7402232e	refs/tags/v1.2.0
c42d2abffcb028793021721b4dadccb0ef405985	refs/tags/v1.3.2
c07fb3db3bf5c36cb14f537fd21555b30a78160c	refs/tags/v1.4.0
cb82cc205d59e05f5fb9f151fa2d3f5617ef19aa	refs/tags/v1.4.1
5c5ad5acf00cb015bb0e4d3abf7a52d41c535156	refs/tags/v1.5.0
5f3ad28c8fd92ba2b2f70cd55fd5c51c2a7aced1	refs/tags/v1.6.0
fca1f5f84624875c3aba99d766d3f7dc16d07eb1	refs/tags/v1.6.0^{}
```

I will probably add this as a separate issue, in order to be able to track it


After every release. In general, the requirement from Kubernetes is that it should be a stable version, so I guess it can't be "latest". Which means that we'll have to update it as a post-release task.


`$(cat $LFILE)` can be shortened to `$(<$LFILE)` (also removes dependency on `cat`).


Doesn't this break the MVVM design pattern, because the viewmodel is interacting with the view directly?


The last statement also needs changing as Perl 6 uses `+&=` and `~&=` for the numeric and string bitwise assignment operators.


In `helm search`. Added.


@mvukov Milan, up to this line (so everything up), check if it looks good. Also, I am not sure on how to implement the functions below - what is the mathmaticla reasoning behind them? I will explain my doubts over email


tempat mebel forniture 01


o WPCS (WordPress Code Standards) pede que os parâmetros dentro da função sejam separados por espaço.
Por exemplo:

```php
$this->getCustomerName( $customer_id );
```


Patches accepted  :-)  That last bit was just reformatted.


@abartlet should "mem_ctx" used here as second argument? Or it should be removed, as it is unused.


Must remember to use Markdown preview before publishing...


Chưa được đọc thông tin gì luôn


`external_id` é um campo obrigatório :(
É uma forma de identificar o comprador na plataforma do lojista.


Good point, thanks!


develop (lgu1234) - x86_64-MacOS-10.9-clang: OK (2304 of 2304 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


Pode usar aspas simples aqui (aspas duplas servem mais para quando fazemos interpolação de string).


Updated


Vou estudar como colocar a versão do módulo dinamicamente nesse campo, daí já faço essa alteração =p


In which version I can find these updates?


Tested with source, user, password: OK.


Se não há problemas em passar `null` nesses valores, as validação `if(empty(foo)` não são necessárias.


Through what countries does the Rhine flow?


In general yes, but someone may want to create their own image which is based on `hazelcast/hazelcast-kubernetes` and use it in Helm Chart. It's a general practice to do it this way.


>In C++ delete is a keyword, …

Yes, of course.

>not an identifier.

This view can be correct according to the standard specification.

Can any setting trigger to handle such source code eventually as a “reserved identifier” by the semantic patch language?

>I believe so.

I am curious on the circumstances when specific source code should be treated as “empty”.


new to this platform, and willing to learn


TextExposeSeeMoreLink":" see_more_link(?: .*)?$","SnowliftBigCloseButton":"(?: _xlt(?: .*)? _418x(?: .*)?$| _418x(?: .*)? _xlt(?: .*)?$)


See gustavohenke/test-repo@ea798f3


Dropar comentário :D


Yup, definitely right. Fixed.


E se for CNPJ?


Será que não tem uma outra forma mais limpa para identificarmos se é pessoa física ou jurídica?


I am sure that I put in that nbsp.
I think the Github editor "helpfully" replaces it.


It's fixed:
https://github.com/LimeSurvey/LimeSurvey/commit/e352ce9fbb5f51f2aefd50f2a99824ca07a5a327


This is already done in getAvailableTasts


Esses valores não podem ser nulos, eles são obrigatórios e devem estar preenchidos


That's how it should be done ;) Thought you don't really need the `OldFunc, ...` parameters so just leave it blank.


IBM Cloud [toolchain](https://console.ng.bluemix.net/devops/toolchains/8edf1624-7104-46d5-b103-2edd36763ee7?env_id=ibm%3Ayp%3Aus-south "ebooklibrary"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/979a3933-3acf-4c32-abc8-bca50f288858?env_id=ibm%3Ayp%3Aus-south "ebooklibrary") deployed [ebook-library-vanilla](https://github.com/piotrekkmt/ebook-library-vanilla/releases/tag/deploy-ibm-yp-us-south-peterpoliwoda-ie.ibm.com-dev-20180612-142158 "deploy-ibm-yp-us-south-peterpoliwoda-ie.ibm.com-dev-20180612-142158") to [dev](https://console.bluemix.net/apps/7b180650-7347-4097-b840-90e273f23a35?env_id=ibm:yp:us-south "ibm:yp:us-south:peterpoliwoda@ie.ibm.com:dev"), including this commit


Sorry – I should have actually asked which info you prefer here. Just fixed it!

I also reduced the <author>-data in the meta.xml to your name – ok with that or should I swap that with your studios name too?


Das hier kann so nicht funktionieren, da der zellenname input.name nicht das gleiche ist wie implementation.name

eher INNER JOIN input ON input.implementation_id = implementation.id


AV-40711 #commit


No problem! And yes, using the studio name is more appropriate. Thanks!


Test comment for IRC bot.


Lines 17 and 22 can be removed because nothing is being returned and an if statement doesn't require a return statement (however functions do). Everything else is ok.


develop (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2324 of 2324 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


Sure, will do.


We don't need to support IE 8.


Danke Dir :)


Yeah, you may be right. Do we have any recommendations for good default Hazelcast values?


Gern geschehen :)


Why remove this? Just use the correct folder.


Why did you remove the script? You just had to point it to the correct folder.


Liveness probe will work anyway, because it uses /health endpoint which available even if REST is off. There are two different variables in Hazelcast: `hazelcast.http.healthcheck.enabled` and `hazelcast.rest.enabled`


@chunlinyao please let us know if we can help test this feature.  We are interested in offering `SBPL` to our list of languages.


I see that the optional 'pynacl' extra is omitted.  Moving forward, are clients expected to always verify Ed25519 signatures in pure Python.


Cautela ao usar `print_r`:

- Sem o segundo parêmetro como `true` (default é `false`), a função escreve direto para o browser. Ou seja, use como `print_r($foo, true)`p para que a função retorne o conteúdo da variável ao invés de mandar direto para o output.
- Se o conteúdo de `$downloadable_items` for muito grande (imagina um array com mais de 3 níveis, cada um com mais e mais níveis, como normalmente são arrays que trazem info do carrinho), usar `print_r()` pode gerar estouro de memória e fazer o site travar.

Prefira escrever somente o necessário nos logs. Por exemplo, é mesmo necessário descrever todos os ítens no log?


yeah, only alpha is not allowed. Redis uses it [1] and it's often given as an example of how to create Helm Charts. So, I'd assume it's fine.

[1] https://github.com/kubernetes/charts/blob/master/stable/redis/templates/redis-slave-deployment.yaml#L1


Linha extra


develop (lgu1234) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


Is there some way to import all the uintXX_t definitions into this file? Or will I have to define them like in stand/i386/libi386/multiboot.h


Hello, could you enable accentuation in the code so that it is possible to use the Portuguese language with your accented words?


omae wa mou shindeiru


Esse log tá sobrando, esqueci de tirar, valeu!


Esse comentário é estranho, não? `Set the installment data`, mas o método se chama `get_installments`.


Sounds good! Just double checking.  Thanks!


O que a variável tá fazendo aqui?


Hmmm one thing I'd change is to use metamagicdata as an object. Doing these bitwise operations is poor form. I think there's alresdy something similar in place?


Could you write the example code that actually yields this output? How do you get to optimal design from concrete data and model? This would be very helpful!


boa pergunta :joy:


Essa URL está correta? Lembro que já usamos antes URLs que não deveríamos usar, como está o versionamento desse arquivo?


USEQ code of ICPR 2016.


Merge from thiagopena/djangoSIGE


Muito espaço entre `$customer` e `= array(`


Boa!


Maybe increased/decreased dependence on previousScore by using different constants for line 373 can help


How exactly do I add these to the mod? Your forge page has no updates since last year. I want to be able to use this on my multiplayer server I'm starting up again, and this is one of my favorite mod addons.


Dropa esse comentário :D


Está correta =)
E esse arquivo está com os [headers da nova versão de API](https://github.com/pagarme/pagarme-checkout/commit/ae53309a221dca911db2d41bb7b757ddfa428bb8)


@gnodet , thank-you. The encoding has been moved to TerminalConnection, it is shared by Terminals. I will keep  @stalep design there and simply add this path specific to Windows10+ terminal.
Sincere thanks for your review, it saved us quite a lot of future debugging!


This is overly permissive. Vibrator hal shouldn't have write access to als sysfs. Looks like your're doing your policies with audit2allow which is bad.


multiboot.h from the multiboot2 spec already contain the types that it needs, see:
```C
typedef unsigned char           multiboot_uint8_t;
typedef unsigned short          multiboot_uint16_t;
typedef unsigned int            multiboot_uint32_t;
typedef unsigned long long      multiboot_uint64_t;
```
I don't think you need to import anything.


Добавил в контроллере логику на проверку выбранного цвета. Если цвет выбран в DetailView в колонке color Отобразится соответствующий цвет. Если цвет не выбран или не существует, то передаю в ново созданный объект белый цвет (фон)
$codecol->code = 'FFFFFF';
и соответсвенно отправляю объект во вью
'codecol' => $codecol,


Se não for `cpf`, só pode ser `cnpj`, correto? Se sim, podemos dropar esse `else` aqui:

```javascript
type = 'cnpj';
if ( '1' === $( '#billing_persontype' ).val() ) {
    type = 'cpf';
}
```


Why not on SSL mode?


merge EmojiDirectory files


There's no need to wrap `new Promise` around functions that return promises. `Promise.then` returns a promise which is resolved with the result of the `then` callback.

So these two are equivalent:
```js
return new Promise((resolve) => {
  someRequest().then((response) => {
    resolve(response.data)
  })
})
```

```js
return someRequest().then(response => response.data)
```

Except that the first is slightly slower (since it has to go through an extra layer of promise resolution) and it silently swallows errors (since `reject` is never called).


right, thanks


Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

- @tomaugspurger, @mrocklin were added to this feedstock maintenance team.
  You should get push access to this feedstock and CI services.

Feel free to join the community [chat room](https://gitter.im/conda-forge/conda-forge.github.io).

NOTE: Please make sure to not push to the repository directly.
      Use branches in your fork for any changes and send a PR.
      More details [here](https://conda-forge.org/docs/conda-forge_gotchas.html#using-a-fork-vs-a-branch-when-updating-a-recipe)


Mostly aesthetic, but I think a positional argument would be more appropriate for `file` since there is no default value.


I meant to say "stop", but I'll allow it.


Hey Martin,
Many thanks! I got the same error when I tried it last week. I resolved it by updating my browser. Not sure that's your issue but would be curious.
-C


IBM Cloud [toolchain](https://console.ng.bluemix.net/devops/toolchains/4b2f79a8-1274-46ee-86d3-b1e8948fffcb?env_id=ibm%3Ayp%3Aus-south "cloud-native-toolchain-tutorial-20180611185853847"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/a397c5c7-3aa3-411d-aba4-de552633f7b8?env_id=ibm%3Ayp%3Aus-south "sample-cloud-native-toolchain-tutorial-20180611185853847") deployed [sample-cloud-native-toolchain-tutorial-20180611185853847](https://github.com/blheath/sample-cloud-native-toolchain-tutorial-20180611185853847/releases/tag/deploy-ibm-yp-us-south-bheath-aggienetwork.com-test-20180612-144441 "deploy-ibm-yp-us-south-bheath-aggienetwork.com-test-20180612-144441") to [test](https://console.bluemix.net/apps/6d5d93e2-ca42-4cca-9619-5ae03122ba1c?env_id=ibm:yp:us-south "ibm:yp:us-south:bheath@aggienetwork.com:test"), including this commit


getip.py - Pegar IP de sites utilizando o Python.


Oops this is my bad. Thanks for fixing @ZogStriP :heart:


All current `peerDependencies` should be normal `dependencies`, and `webpack` should be a `peerDependency`, since it's a `peerDependency` of `pdfjs-dist`


Should this be <GL/glu.h> ?


XXX


Trouble installing the app to a phone.


Should revert this.


Looks good. I just made some changes as well. Thanks.


Main Folder


Also


> expire ~~~in~~~ after 7 days


This change will reduce security for iOS apps, which will disable HTTPS enforcement.

It might be better to enable this configuration only for DEBUG builds, see https://gist.github.com/kishikawakatsumi/9dff1d419c070d44bb63204bf08a900d


Again


This stage of the app is running very well. Next stage gets rid of the battery bug.


IBM Cloud [toolchain](https://console.ng.bluemix.net/devops/toolchains/4b2f79a8-1274-46ee-86d3-b1e8948fffcb?env_id=ibm%3Ayp%3Aus-south "cloud-native-toolchain-tutorial-20180611185853847"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/a397c5c7-3aa3-411d-aba4-de552633f7b8?env_id=ibm%3Ayp%3Aus-south "sample-cloud-native-toolchain-tutorial-20180611185853847") deployed [sample-cloud-native-toolchain-tutorial-20180611185853847](https://github.com/blheath/sample-cloud-native-toolchain-tutorial-20180611185853847/releases/tag/deploy-ibm-yp-us-south-bheath-aggienetwork.com-prod-20180612-144832 "deploy-ibm-yp-us-south-bheath-aggienetwork.com-prod-20180612-144832") to [prod](https://console.bluemix.net/apps/f9c9641b-c41a-4f02-af80-cfb2cf344953?env_id=ibm:yp:us-south "ibm:yp:us-south:bheath@aggienetwork.com:prod"), including this commit


I don't think we need that much details (part about default expiration)


Podemos simplificar aqui:

```javascript
document.type = type;
field = '#billing_cpf';
if ('cnpj' === type) {
    field = '#billing_cnpj';
}

document.number = getNumbers( $( field ).val() );
documents.push(document);

return documents;
```

O que acha?


@thinkyhead: I notice you do this in a couple places. What does a `do {} while(0);` accomplish and how is it different than just plain curly braces?


Yes, will modify in the next commit


Foi preciso inverter aqui?


Esse log é necessário ou foi usado só pra debug?


It was device settings. App runs superbly. I like!!