I think we should update our test cases to prevent this from regressing.


looks good. thanks.

Nicholas May

Research Engineer (Research Data)
Research Capability
Research & Innovation Portfolio
RMIT University

T: 03 992 54069
E: nicholas.may@rmit.edu.au
ORCID: 0000-0002-1298-1622 <https://orcid.org/0000-0002-1298-1622>
Building 88, Level 10, Desk, 37.
440 Elizabeth Street, Melbourne
CRICOS provider code 00122A

On 15 August 2018 at 08:35, Manodeep Sinha <notifications@github.com> wrote:

> Update .zenodo.json
>
> @nooriyahp @nrmay - please check that your details are
> correct/appropriate. I will send in a pull request to upstream if
> everything looks good.
>
> --
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub:
> https://github.com/rse-aunz/international-survey/commit/
> a28abcb2743bef601cfd35f1b3feb4293b9e1133
> <https://github.com/rse-aunz/international-survey/commit/a28abcb2743bef601cfd35f1b3feb4293b9e1133>
>


Another bigger question is why "flag_reviewed" is firing when you delete a post with zero flags....


3. angle=(input("the value of angle:"))
π=3.14
r=(input("the value of r:"))
a.s=angle/360*(π*r**2)
print(a.s)
4. s=(input("input the value of s:"))
area of square=s**2
print(area of square)
r=(input("input the value of r:"))
h=(input("input the value of h:"))
area of cylinder=2*π*r(r+h)
print(area of cylinder)
b=(input("input the value of b:"))
height=(input("input the value of height:"))
area of triangle=1/2*b*h
print(area of triangle)
higt=(input("input the 6 of higt:"))
b1=(input("input the value of b1:"))
b2=(input("input the value of b2:"))
area of a trapeziod=1/2*h*(b1+b2)
print(area of trapeziod)


Also completed the individual percentage tracker.


Interesting analysis! I always thought one of the main advantages of the ANN methods, especially Annoy, is that it helps to avoid the curse of dimensionality which can occur when you have high dimensional embeddings. For example, the distance measures (cos, etc) start to break down after 150+ dimensions: all items are equally far from each other. Did you see anything like this? I think it would be manifest in NN quality in cos vs annoy....


It's the [spread operator](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax) - it takes an array and converts it to individual arguments.


#6888-EngRefEquationFixPart2 (RKStrand) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (2354 of 2354 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-71.56%25-green.png)


#6888-EngRefEquationFixPart2 (RKStrand) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


Ah, thank you. Do you know if there are any dependencies or versions of other libraries that are required for it? Until recently I was using log4js with no issues, but now I receive this when performing a gradle build:

`/.../node_modules/karma/node_modules/log4js/lib/layouts.js:69
  ) + util.format(...loggingEvent.data);
                  ^^^

SyntaxError: Unexpected token ...
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:414:25)
    ...
`


@tgxworld I was actually waiting to invest what @SamSaffron noted before writing a spec 😉

> On 15 Aug 2018, at 01:46, Sam <notifications@github.com> wrote:
>
> Another bigger question is why "flag_reviewed" is firing when you delete a post with zero flags....
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.


It needs node v6 or later. If you're using node v4, then you can enable support by supplying the `--harmony` flag.


is it real one?


Checkmarx scan results 15 Aug 2018 02:59 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

a23cad998261c81bf63aa21ac681a2e8b5303e7c	@web-flow


Congrats Stephane!


Will get_mg_token() work with character/avatar task?


Esta não é a resolução do Exercicio 2. Não sei porque foi incluida aqui junto com ela.


Pode usar o Junit4 e colocar a exceção no @Test(expected=IllegalArgumentException.class).
Talvez para ti seja melhor aprender com o JUnit4  para aprender os fundamentos primeiro.


asdas


Hey Gerrit:

You mentioned a couple of months ago that you would take a look at the Reset issue mentioned above.  Any progress on that?

Also, I have recently started using an Xbox controller with key mapping software to operate my machine.  Works really well, but I've run into a few issues:

I rely heavily on Disconnect/Reconnect button to zero out the machine.  It's so much simpler than using G54-59.  It would be really nice if this button had a key mapped to it, as it is I cannot set it up on my controller because it has no key map.

Also, ditto for the Home, Special Position 1 and 2 buttons.  I use those a lot, it would be really nice if they had keys mapped as well.

Thanks Gerrit


Why removing this file?. I would rather see failing unit test than just a few functional. Removal does not ensure proper behaviour and should be listed in the Future work portion of your report


Please finish this off and submit your report, your deadline for this was Sunday :(


return_codes_pull_request (michael-okeefe) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1716 of 1716 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-40.56%25-green.png)


Yeah, not sure my overwinter fixes got `undone` in upstream...


this is test assignment


this line before deadline


there's one commit to add a line after deadline, and hence not captured in grading branching


Basically I am trying to use the same targets like Npgsql. Probably Npgsql has this Target, too. I will see, if it can be removed.


fixed


first commit


added a line


Why would resultList be null?


removed the star


remove console.log


to suppress error here, just in case


Completed:

Clearance
Updated figaro and used omniauth2
Listing new/show/edit/update
Created tags and listingtags
Connected to AWS


Change to number variables


develop (mjwitte) - i386-Windows-7-VisualStudio-14: OK (2348 of 2348 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


pedantic: `targeted`


Thanks Ali !


It's a fix for this bug report. Allofich has a good description of the cause here.
https://forums.dfworkshop.net/viewtopic.php?f=24&t=1178


portfolio


I attempted to rebase.

There is something new with the following line

#LineNames=GetSimplyLoveOptionsLineNames()

This is causing issues. When I revert this line to the old format of listing individual line names it works fine

GetSimplyLoveOptionsLineNames()
Must be defined somewhere, I just need be to find it

Then, I see some other issues but they may be related to merging code when I am tired. I will try again tomorrow with fresh eyes


Could we please rename this to `onMessagesSeen` as we send an array?


Yes


Just out of curiosity, what is the reasoning behind moving the invocation of `markMessagesAsRead` to another method?


мы можем здесь использовать преимущество миксов и обращаться уже к блоку user-account
т.е. header__user-account--name и header__user-account--exit :)


Is Proxer a legitimate/trustworthy metadata provider? Take a look at this user's logs here:
https://emby.media/community/index.php?/topic/61712-emby-server-library-not-updating-properly/
Notice these lines in the server log:
2018-08-12 14:09:59.675 Info HttpClient: GET http://analytics.proxer.me/js/?idsite=1
Those apparently are image urls that came from proxer.


а здесь добавить второй класс-блок user-navigation


The `autoload` cause this exception while startup.

```elisp
bugger entered--Lisp error: (void-function lsp-define-stdio-client)
  (lsp-define-stdio-client lsp-java "java" (function (lambda nil lsp-java-workspace-dir)) (lsp-java--ls-command) :ignore-regexps '("^SLF4J: " "^Listening for transport dt_socket at address: ") :extra-init-params (list :workspaceFolders (mapcar 'lsp--path-to-uri lsp-java--workspace-folders) :settings (lsp-java--settings) :extendedClientCapabilities (list :progressReportProvider t :classFileContentsSupport t) :bundles lsp-java-bundles) :initialize 'lsp-java--client-initialized)
  eval-buffer(#<buffer  *load*-772135>
```


давай по БЭМ еще раз созвонимся :)


Checkmarx scan results 14 Aug 2018 06:31 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

a23cad998261c81bf63aa21ac681a2e8b5303e7c	@web-flow


Nice unit test!


This covers all the quest changes I think, just for documentation purposes I guess

>rotors reduced to 4 coins the same

pipes reduced to 4 coins the same

all rods reduced from 64 to 16 as a rewarard, coins stayed the same

EV+ parts removed, you get them at IV and LuV when 32 of an ingot is almost worth nothing, so asking the player to make them all is more tham reasonable, as it's much easier. 16 Tungsten at LuV is nothing close to 16 steel in MV

Changed electrum rod quest to reward 16 electrum rods instead of 2 robot arms

Removed rocket replacement quests until something can be done about recycling them for extra parts

Ingot amounts lowered to 16 coins the same

rubber bars lowered to 16 coins the same

rubber sheet quest changed to give 16 rubber sheets instead of rubber bars

better rubber quests removed

rubber rings to 16 coins the same, better rubber rings removed

creosote changed to 16 cells in/out coins the same

oil/oxygen/hydrogen/nitrogen gated to MV machine hull, and reduced to 16 cells in/out coins the same

Methane, light/heavy fuel gated to HV machine hull, reduced to 16 cells in/out coins the same

Added naptha coin quest, gated to HV, same cost as Light/heavy fuels

Removed Diesel/Cetane diesel, too much free power and it's essentially the motors/pumps/etc.. of the oil side of things

Polyethylene removed for the same reason

Steam cells added for purchase for oil cracking 64 cells for 5 chem coins

Ethanol/sulfuric acid quest added, gated T4, 50 chem coins for 16 cells

Left the gt++ pump quest alone but that's probably something that should have something done about it. Like a recipe for the pumps instead of a quest

Retiered the wire quests to cables for the same tier, and wires for tier+1 as theyre clearly for motors

Added useful but cheap AE related EV tiered rewards [processors for 100 tech coins for 8 processors, 100 tech for 24 glass cable, 100 tech coins for 24 fluix crystals]


Why r u calling him a hero? script For m16 and akm still not working well.
Compensation is too much .. even after changing basic times the recoil is all over the place. i m sorry but STILL NOT WORKING WELL.


Does it still happen with the latest version of the code?  It may have happened because of corruption since map was not protected from concurrent access.


So what exactly happened to the old terrain mask implementation? From this commit it looks like it's still there?


Having an invocation count works, but you can also inspect and verify if the method on spy was invoked by using `toHaveBeenCalledTimes(N)`. I am happy with this either way 👍


@minglich Pls bro give us correct recoil tables? thnx in advance.


Changes are looking great, just a couple of comments, mostly to clarify it, and a minor change on the event name. When are you planning to send the changes with a pull request to the main repo? 🥇 🎉


Is it actually safe to return a reference to the string returned from `lua_tolstring`?


Why are these here and not in the general Lua file with other utility functions?


这是一列


:rofl:


Yeah "raw" doesn't really get the idea across, I think. How about "auto"?


I'm not so sure if it's as strange as it sounds though. From what I recall when working with terrain masks a few days ago, it seemed like... if you read the terrain as a square grid, the top left most tile is missing?


		    		中国人寿综合意外保障卡

吉祥卡D(SC100元-2)(成年人)

尊享幸福，共创和谐，给您关爱!

查看详情 >


IBM Cloud [toolchain](https://console.ng.bluemix.net/devops/toolchains/5a7e57bc-5410-437d-95a5-d427815f5ebc?env_id=ibm%3Ayp%3Aus-south "sportman-loopback"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/db4be768-68e6-447f-9187-7d1ee9f620cc?env_id=ibm%3Ayp%3Aus-south "sportman-loopback") deployed [sportman-loopback](https://github.com/jims10d/sportman-loopback/releases/tag/deploy-ibm-yp-us-south-jims10d-simpleSpace-20180814-033916 "deploy-ibm-yp-us-south-jims10d-simpleSpace-20180814-033916") to [simpleSpace](https://console.bluemix.net/apps/12384bdb-7ac1-45d2-b63b-7d0a3532c568?env_id=ibm:yp:us-south "ibm:yp:us-south:jims10d:simpleSpace"), including this commit


Still, I don't think it's safe.
This single found ALOAD may contain a different value written by another ASTORE.
I'd check that it has only `astore` as a source of its value


The same problem here.
And a bit of code duplication


My first source Code..Yasss


Not valid -- Percentage is double and not nullable object.


Yes, still happen, so I push this review


I further checked the script Auto loot also not working.. And m4s recoil is also very bad. DO u even check ur scripts @Minglich


I think representing the line as a string is causing the precision problem you mentioned. Why not represent the line as a tuple (m, b)? And convert to a string when you print the results?


Also, you incur the string convert perf hit for every line regardless of whether it is in the result set.


develop (mjwitte) - Win64-Windows-7-VisualStudio-14: OK (2348 of 2348 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


Once the external login verifies my Facebook account, it will always use the same FB account. How can I switch to another FB account for login? Or is there any caching or cookies I should clear for this?


@abz53378 this is conflict


Executing the daily benchmark build, I will reply here when finished:

@nanosoldier `runbenchmarks(ALL, isdaily = true)`


You should allocate PAGE_SIZE, not sizeof(int)

buff must be all 1, and must have PAGA_SIZE size.


Write 1 in the entire PAGE_SIZE memory, not a single integer.

memset(buffer1, 1, sizeof(char));


Can you use mdst? This avoids the need to have station data in code and allows to have maps and coordinates as well. If you want I can make a pull request for your repo for this. Just ping me if you want me to go over your code


char *buff1, *buff2, *buff3;


I'm not familiar with this SQL-like notation in C# (actually, I have no experience with C#). Can you explain what's happening here?


buff1 = malloc(sizeof(char)*PAGE_SIZE);

No need to be calloc, because right after this, you will write the 1, 2 or 3.


用于修复 #3


Think I goofed!


pom


What is the case where the vector pair has already been run?


TCP instead of tcp


Give proper spaces in this line. Use the line which I have provided below:

it can use kind = EXPERIMENTAL (as in \RFC{6994})


remove this extra line


me parece que tenes que revisar el char


the magic number forms the first two bytes in option content field to differrentiate experimental options


the magic number forms the first 2 bytes of the option content field


we need to skip two bytes (kind + length) to reach the option content field


Thank you!


The body of this "if" statement is not as per ns-3 formatting.

Put it like this:

if (option->GetExID() == magicNumber)
  {
     return (*i);
  }


fixed in e70b3d505a9ed97db1ae38c929ef9ebe4ad1ca61 thx


Get's kernel loading, immediate crash, but progress.


One space after GetTypeId


One space after TypeId


One space after Print


// Write e0b


// Write ceb


// Write e1b


this is awful


one space after WriteHtonU16


One space after WriteU8


Change this:
result = ssd -> event_arrive(WRITE, i, 1, start_time, buff1);
to this:
result = ssd -> event_arrive(WRITE, i, 1, (double)(300*i), buff1);


what the heck is this ?


// Read e0b


// Read ceb


// Read e1b


Include NS_LOG_FUNCTION in all the methods


one space after }


Add some comments here, so we don`t forget why this value

#define 262144 // This is the number of pages that represents 1GB data (considering page size 4KB)


Check the indentation


remove this extra space


`
 <el-table-column min-width="90px" label="会员等级" :filters="levelFilter" filterable">
            <template slot-scope="scope">
                <span>{{ scope.row.name}}</span>
            </template>
        </el-table-column>
`

2.4.6 怎么不会生效


correct the indentation of comment


one space before (0)


indent according to ns-3 format


Give one space after each comma.

accEcn should be AccEcn


你好，

我是波场的BD Manager杨博衡，在此寻求与你们的商务合作。

根基据coinmarketcap (https://coinmarketcap.com)数据显示，波场的市值一直位于加密货币排行前10。自波场主网上线以来，我们的社区不断在扩大。TPS比以太坊快近100倍，交易费用更低且虚拟机更加安全。

波场虚拟机准备在月底上线，为此会有更多的dapp开发者参与进来。我们了解到你们在Neo开发的Neo.girls很不错，也深知你们对dapp的理解。所以波场希望与你们有更多的合作机会。

以下是我的联系方式：
微信：ybhgenius
QQ:545979175
电话：15652825996

希望你们能与波场建立联系，一起展开未来的深度合作。


remove extra line


one space after AddOptionAccEcn


indent as per ns-3 format


Bienvenido a la aplicación


Comments should be full sentences. See https://github.com/golang/go/wiki/CodeReviewComments#comment-sentences.


done


Remove.


try catch를 왜 써야 되는지 다시 한번 보는게 좋겠다.


Full sentence.


니 프로그램은 한번만 입력받을 수 있으니까 딱!!!! 한번을 잘 입력해야 되겠다 그치?


A few minor style comments. @cheyang


수정 하겠습니다..ㅎ


Hi @phcoder I'm not familiar with mdst/proto buffer. Please go a head, it will be great.


하..하하하핳............. 넵.. 수정하겠습니다.


Thank you


When I ran this I had the `mn` script in the current directory when I executed the first command

```
mn create-app example --profile cli
```

We then `cd` into the `example` subdirectory, so the `mn` script is in the parent directory and needs to be invoked with `../mn`. This may be different for a different setup.


**To create user entity**
 >>  php bin/console doctrine:generate:entity --entity="AppBundle:User" --no-interaction

**To Publish the Assets**
 >> php bin/console assets:install --symlink web


你好，

我是波场的BD Manager杨博衡，在此寻求与你们的商务合作。

根基据coinmarketcap (https://coinmarketcap.com)数据显示，波场的市值一直位于加密货币排行前10。自波场主网上线以来，我们的社区不断在扩大。TPS比以太坊快近100倍，交易费用更低且虚拟机更加安全。

波场虚拟机准备在月底上线，为此会有更多的dapp开发者参与进来。我们了解到你们在Neo开发的Last trip很不错，也深知你们对dapp的理解。所以波场希望与你们有更多的合作机会。

以下是我的联系方式：
微信：ybhgenius
QQ:545979175
电话：15652825996

希望你们能与波场建立联系，一起展开未来的深度合作。


не забывай удалять закоментированный код - он только захламляет исходники


#6888-EngRefEquationFixPart2 (RKStrand) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


Relying on load() to be called before rm() seems unintuitive to me. Also, `path` isn't inherently a property of a ProfessionTemplate, so I don't think it should be a member variable. Maybe a separate function to remove a profession file would be better.


If you use bash or shell you should get syntax highlighting _and_ not fail `mdbook test`.


Sorry for the delay, I have updated the repo with Assignment now.


This will get logged only to stderr.log, where most users won't ever look, so if this error condition is hit, it will appear to simply fail silently. (That behavior is fine for the message above, though.) It would be better to use `out.printerr(str [, format params])` if you have a `color_ostream` (usually named `out`) in the current scope. That doesn't appear to be the case here, so Core::printerr would work as an alternative. printerr() logs a visible error to the DFHack console as well as to stderr.log.


commond


I expected to find a wrapper for remove() in modules/Filesystem.cpp, but apparently this is portable and we didn't need one (so this is good).


Oh crap, thanks I'll fix it


Should probably use printerr() instead of cerr here too


Profesor, si llega a ver esto me equivoqué al hacer el push, yo pensé que se haría archivo por archivo, pero si se subió la carpeta completa. Por eso dice en el nombre "Archivo html".
Una disculpa jejeje


Тут надо использовать алиас в пути: @bower/bootstrap/.....
Так никогда не будет проблем с путями.
Все предустановленые алиасы можно узнать тут: https://www.yiiframework.com/doc/guide/2.0/en/concept-aliases#predefined-aliases


What is this for? The `workerSuffix` is just `-worker`. Does it make sense as a label?


Oh, and we also need to remove obsolete certificates upon renewal.


Вместо замены каждому контроллеру, можно прописывать в конфиге:

`$cofig['layout'] = 'adminlte';`


Same here. `-launcher` seems like a weird label.


Importing the turtle library


@cheyang


Thanks for pointing this out, I will remove it. It is not clear to me why this is happening, it loads fine on the travis.


Cuando haces un query request a la Youtube Data API para pedir datos de una playlist puedes pedir los datos minimos (id, etag) y no pedir el snippet (donde vienen las canciones). Si el etag no ha cambiado esto implica que no hay cambios en la lista de reproduccion. Asi puedes evitar costes de queries a la API de youtube ;)


This is the only portability issue I've found - this is a C99 feature, which isn't part of the C++11 standard, and I didn't expect it to work in any C++ compiler we support. Maybe it works in a new GCC without flags or something, but I wouldn't expect it to work in MSVC (Visual Studio). At any rate, the struct initializer just has one field, so hopefully leaving off the `.name` isn't too bad for readability.

(Besides this, and other than some minor DFHack-specific idioms, these changes are good-quality in general - better than some code in DFHack currently.)


Maybe it's clearer to call this `launcherLabel`?


`workerLabel`?


review your code. you have typo errors and variables missing.
the matrix is assumed to be square invertible.


Every changes you made are good


`certbot delete -d ...` should do the trick here - but the corresponding nginx site config must also be removed!


commit


I cannot find and run it!


Would you mind giving an example of how you're using these two methods? It looks like this could be a much simpler OAuth flow for an app I'm working on, but my OAuth knowledge is spotty, and it's not clear how to make use of these two changes.


## Jenkins Build Summary

Built from [this commit](https://github.com/mellery451/rippled/commit/d440918cb9ab71ba362377544a7a4ae59bfd806f)

Built at __20180814 - 04:48:27__

### Test Results

Build Type | Log | Result | Status
---------- | --- | ------ | ------
msvc.Debug | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/allow-sign/1//artifact/msvc.Debug.txt) | 1032 cases, 0 failed, t: 755s | PASS :white_check_mark:
rpm | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/allow-sign/1//artifact/rpm.txt) | 1034 cases, 0 failed, t: n/a | PASS :white_check_mark:
msvc.Debug,
NINJA_BUILD=true | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/allow-sign/1//artifact/msvc.Debug_NINJA_BUILD_true.txt) | 1032 cases, 0 failed, t: 620s | PASS :white_check_mark:
gcc.Release
-Dassert=ON,
MANUAL_TESTS=true | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/allow-sign/1//artifact/gcc.Release_Dassert_ON_MANUAL_TESTS_true.txt) | 1101 cases, 0 failed, t: 938s | PASS :white_check_mark:
docs | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/allow-sign/1//artifact/docs.txt) | 1 cases, 0 failed, t: 2s | PASS :white_check_mark:
gcc.Debug
-Dcoverage=ON | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/allow-sign/1//artifact/gcc.Debug_Dcoverage_ON.txt) | 1035 cases, 0 failed, t: 849s | PASS :white_check_mark:
clang.Debug | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/allow-sign/1//artifact/clang.Debug.txt) | 1035 cases, 0 failed, t: 283s | PASS :white_check_mark:
gcc.Debug | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/allow-sign/1//artifact/gcc.Debug.txt) | 1035 cases, 0 failed, t: 293s | PASS :white_check_mark:
msvc.Debug
-Dunity=OFF | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/allow-sign/1//artifact/msvc.Debug_Dunity_OFF.txt) | 1032 cases, 0 failed, t: 1169s | PASS :white_check_mark:
clang.Debug
-Dunity=OFF | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/allow-sign/1//artifact/clang.Debug_Dunity_OFF.txt) | 1035 cases, 0 failed, t: 697s | PASS :white_check_mark:
msvc.Release | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/allow-sign/1//artifact/msvc.Release.txt) | 1031 cases, 0 failed, t: 401s | PASS :white_check_mark:
gcc.Debug
-Dunity=OFF | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/allow-sign/1//artifact/gcc.Debug_Dunity_OFF.txt) | 1035 cases, 0 failed, t: 637s | PASS :white_check_mark:
clang.Release
-Dassert=ON | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/allow-sign/1//artifact/clang.Release_Dassert_ON.txt) | 1034 cases, 0 failed, t: 403s | PASS :white_check_mark:
gcc.Debug
-Dstatic=OFF | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/allow-sign/1//artifact/gcc.Debug_Dstatic_OFF.txt) | 1035 cases, 0 failed, t: 294s | PASS :white_check_mark:
gcc.Release
-Dassert=ON | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/allow-sign/1//artifact/gcc.Release_Dassert_ON.txt) | 1034 cases, 0 failed, t: 429s | PASS :white_check_mark:
gcc.Debug
-Dstatic=OFF -DBUILD_SHARED_LIBS=ON | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/allow-sign/1//artifact/gcc.Debug_Dstatic_OFF_DBUILD_SHARED_LIBS_ON.txt) | 1035 cases, 0 failed, t: 294s | PASS :white_check_mark:
gcc.Debug,
NINJA_BUILD=true | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/allow-sign/1//artifact/gcc.Debug_NINJA_BUILD_true.txt) | 1035 cases, 0 failed, t: 275s | PASS :white_check_mark:
clang.Debug
-Dunity=OFF -Dsan=address,
PARALLEL_TESTS=false,
DEBUGGER=false | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/allow-sign/1//artifact/clang.Debug_Dunity_OFF_Dsan_address_PARALLEL_TESTS_false_DEBUGGER_false.txt) | 1035 cases, 0 failed, t: 1117s | PASS :white_check_mark:
clang.Debug
-Dunity=OFF -Dsan=undefined,
PARALLEL_TESTS=false | [logfile](http://ci.ops.ripple.com/job/mellery-rippled/job/allow-sign/1//artifact/clang.Debug_Dunity_OFF_Dsan_undefined_PARALLEL_TESTS_false.txt) | 1035 cases, 0 failed, t: 1048s | PASS :white_check_mark:


Сделай в подклассах метод, проверяющий соответсвие типа, а в базовом просто вызывай этот метод.


Sorry, fixed it :)


No problem. cast() will do for now.


@AlexeyRaga actually finding this more sane than starting a `KafkaConsumer` or `KafkaProducer`. I don't think we have a more convenient way of creating a thing that `HasKafka`.


В методе добавления вагонов к поезду еще было условие, из предыдущего задания: вагоны можно добавлять только если поезд остановлен.


Dude! Show me how your vim looks, okay? Maybe Add screenshots to the repo itself?


Good catch. Maybe add a test for this? @cheyang


If you will store state machine using session store and reload state on page refresh / everything will be undated. Just in state management constructor use session storage API for load and only then initialize with default values, and in mutation phase, on state change, write it back to storage


Which MacBook did you buy? Uspe bhi i3 use karta hai kya?


Разумно. Но думаю, что на этом этапе не стоит с этим запариваться. Можно сделать 2 депо в интерфэйсе. Одно депо для грузовых, другое для пассажирских вагонов. И доставать/оставлять вагоны из соответствующего депо.


PS. the story is real and I work with both people on my team at work.  I loathe reading the second developer's code.


Tutorial update of readme.md


Nombre Y Matricula


Is there any specific reason for this? `IReadOnlyCollection` is more simple than `IReadOnlyList`, and we don't use List's features (in fact, the only thing we do - we iterate through with `foreach`).


bbxbxb


лучше вместо detect использовать .any? - тогда не нужно будет двойное отрицание для перевода в булево значение


Trying to get #4 to work


Тоже самое можно сделать так
```
@stations.map(&:name)
```
Это вернет новый массив с названиями. &: - синтактический сахар. Это тоже самое, что и
```
@stations.each { |station| station.name }
```


Просто у тебя names локальная переменная, которая нигде не используется


need decode() here since zipfile.ZipFile.read() returns bytes


I've looked at this too. It's not related to ipfw rules, kernel module load and required 5-6 seconds on my VM to unblock squid in the rc.ipfw script. It seems to be purely bad luck... oO


можно  .any?


前辈，有个小错误哈，是
  ‘以及 webpack 基础知识’
不是
  ‘已经 webpack 基础知识’


need `decode()` here since `zipfile.ZipFile().read()` returns `bytes`


This is a good one, I liked the changes for the sake of consistency (public+sealed, private constructor in `ProjectReader` to reduce duplication). Although I would make all sites that have `IList`/`IReadOnlyList` be `IReadOnlyCollection` if possible (as generic as possible). What do you intend to do with this branch?


muito bom, onde consigo falar com vc ?


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2368 of 2368 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


А какое отношение поезд имеет к созданию маршрута? Это метод создания маршрута, и логика должна относится только к созданию маршрута. Сплат аргументы не самая хорошая идея в данном случае, потому-что читая метод не понятно, что там за аргументы используются.


Why no destructor for TypingMachine?


Oh. yes. I didn't test it from packaged one.


It has two fields now. See line 633. If the specific field to assign to is not specified, the first one will be used, which may be the wrong one, and that may result in a bug that manifests itself down the road in the form of malformed variables, and is therefore hard to locate. The witness to that is that you yourself did not notice this. I actually fell for it.

I do not know what the best practice regarding assignment to `struct` with more than one field is. Some research must be in order.


Indentation is broken


Marlin\src\gcode\feature\leds\M7219.cpp: In static member function 'static void GcodeSuite::M7219()':
Marlin\src\gcode\feature\leds\M7219.cpp:47:28: error: 'Max7219_register_setup' was not declared in this scope

Max7219_register_setup();

Compiling .pioenvs\megaatmega2560\src\src\gcode\feature\pause\M603.cpp.o
*** [.pioenvs\megaatmega2560\src\src\gcode\feature\leds\M7219.cpp.o]

Error 1


왜 앞이 아니라 뒤에 _를 넣어셨는지요?


two ';' can be changed into one ';'


Update


이 Break는 불필요한거 같은데요?


(Node*) casting is not required


템플릿 코드와 Node 클래스 구현을 분리된 커밋으로 나누면 커밋을 이해하기 더 좋지 않았을까 생각합니다.


LGTM


// Write down the comment


이 Break보다는
if  (temp == nullptr) break;
currentNode_ = temp;
로 하는게 어떨런지요?


Node*와 Node *가 혼재되어 있는것 같은데
통일하면 더 좋을거 같습니다.


can remove duplicated line like below.

       if (previousNode != nullptr) {
		previousNode->nextNode = newNode;
		newNode->previousNode = previousNode;
	}

 	previousNode = newNode;
	newNode->nextNode = this;


node.h 에 별도로 선언하신 멤버 변수(prev, next) 들에 대해서 초기화가 필요한 것 같습니다


ditto


생성자에서 Prev 가 nullptr 로 초기화 되었다면,
if 문 사용 없이 return Prev 를 해주더라도 문제 없을것 같습니다


This ns3 code contains and simulates the COC SON. When we have an eNB outage.


여기도 조건문이 필요 없을것 같습니다


next_of_next는 작명센스 좋네요 ^^
removed_node는 이제 제거될 node이긴 한데.. 뜻이 조금 애매한거 같기도 하네요 ^^;


typing machine class 에서 head,tail node pointer 멤버를 추가하면, HOME, END 이동시 좀 더 효율적일것 같습니다.


Use member initialization list instead of assigning values in constructor body.


pPriv 나 pNext 가 nullptr 인지 판단하지 말고 그대로 return 하면 되지 않을까요?


How about deallocating all nodes from destructor for potential memory leak?


No need, outdated idiom


o to nullptr change  looks good to me.


s/bukkit/nukkit


node.cc / node.h 는 LGTM!!


thank you for this. can you provide a unit test to validate your change ?


Check length more strictly. "mLength >= 100" instead of "mLength == 100"


Puzzle `131-d561a8f9` discovered in   [`pages/README.md`](  https://github.com/fidals/refarm-site/blob/master/pages/README.md)   and submitted as #159. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


How about using 'unsigned int' instead of 'int'


Puzzle `510-1f23f5f0` discovered in   [`front/less/vendors/bootstrap/dropdowns.less`](  https://github.com/fidals/shopelectro/blob/master/front/less/vendors/bootstrap/dropdowns.less)   and submitted as #513. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


이 Else는 필요하지 않은 듯 합니다.


Puzzle `510-6d408411` discovered in   [`front/less/vendors/bootstrap/variables.less`](  https://github.com/fidals/shopelectro/blob/master/front/less/vendors/bootstrap/variables.less)   and submitted as #514. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


Не до конца вырезали
```
//// VIP_Core.sp
//
// vip/Info.sp(1) : error 017: undefined symbol "FIX_CSGO_MOTD"
//
// 1 Error.
//
// Compilation Time: 0,97 sec
// ----------------------------------------
```


이 안에 문장이 없는데요?


This is duplicated,,, Outside of this parathenthis, previes node will be set regardless of this block condition..@mj


Suggesting to put a prefix 'm_' for all private member. Then remove 'this->' from implementation.


node.h node.cc - Looks Good To Me


Indent 가 맞지 않네요. 원래 코드와 스타일을 맞추는 것이 좋을 것 같습니다.

Visual Studiow Exress 2013 에서는 "도구" > "옵션" 의 텍스트 편집기 항목의 Basic 이나 C/C++ 의 탭 항목에서 탭 크기 및 Indent 문자를 설정할 수 있고..
Ctrl + K, D 로 자동으로 소스 포맷팅을 할 수 있습니다.


for better readability, why don't you use temporal variable instead of chined pointer (previousNode->previousNode->nextNode)


간혹 indentation 이 안맞는 부분이 있네요 ^^;


I guess, this line is not meaningful...


How about aligning the starting column in line #46, #47.


need to edit the Author field


Please check inline comments for TypingMachine class


(2칸/4칸)으로 indentation이 다르게 사용되는 경우가 있습니다. 맞추어 주시면 좋을 것같습니다.


Node Class 내부에서만 사용하는 Primitive Data Type에 대한 접근 지시자를 명시하는게 좋을것 같습니다.


Try using the "find all" feature of your text editor. Many of them allow you to search entire folders.


Node *temp = GetNextNode();
와 같이 한줄에 작성하면 보기 좋을 것 같습니다.


Same as above duplication...


간소화를 위해 else를 삭제하고 return nullptr만 남기는게 좋아 보입니다.


prev null check 가 필요해 보입니다.


please modify the pointer name like previous pointer. (newNode)


Node *DellNode = GetPreviousNode();
와 같이 한줄에 작성하면 좋을 것 같습니다.


node.cc, node.h
- Node* t - 변수명이 t 이어서 의미파악이 어려움.
- m_prev->m_prev->m_next - 포인터의 내부 private 변수를 직접 접근.
    getter 메소드를 사용하는 방법이 좋아보임
- 주석추가 필요

(Optional - 맞는 가이드인지는 잘 모르겠음)
- 가독성을 위해 if 문 내부를 명확히 서술
if(m_prev) => if(m_prev != NULL)
if(!m_prev) => if(m_prev == NULL)
- 내부변수에 this 키워드를 명시적으로 사용
return m_prev;  => return this->m_prev;
m_next->m_prev = new_node;  => this->m_next->m_prev = new_node;


How about aligning the starting column in line #62, #63.


I think we can just use 'prevNode' for all internal usage


next 에 null check 가 필요해 보입니다.


How about aligning the starting column in line #77, #78.


This condition check is not necessary (already checked at line #65)


I leave a short message for noce.cc


new operation이 실패했을 경우의 예외 처리가 필요해 보입니다. if (temp_node == nullptr) return nullptr;


node.cc, node.h
•Node* t - 변수명이 t 이어서 의미파악이 어려움.
•m_prev->m_prev->m_next - 포인터의 내부 private 변수를 직접 접근.
getter 메소드를 사용하는 방법이 좋아보임
•주석추가 필요

(Optional - 맞는 가이드인지는 잘 모르겠음)
•가독성을 위해 if 문 내부를 명확히 서술
if(m_prev) => if(m_prev != NULL)
 if(!m_prev) => if(m_prev == NULL)
•내부변수에 this 키워드를 명시적으로 사용
return m_prev; => return this->m_prev;
 m_next->m_prev = new_node; => this->m_next->m_prev = new_node;


This condition check is not necessary (already checked at line #80)


<Author>에 이름 넣으셔야 하지 않을까요?


previousNode set nullptr here, and then delete previousNode at next line because tempNode was set previousNode.
Could you check again this line(previousNode = nullptr;) is necessary?


if condition is not needed.


I think you need to align the indentation. Public and private members have different indentations.


Comment 달았으니 의견 부탁 드리겠습니다.


ditto


아래 1줄의 statement 를 가진 if 문과 코딩 스타일의 일관성이 없는거 같습니다.


looks good to me.


code reivew for node.cc
 - 잘 구현하셔서 특이사항이 없는 것 같습니다.
 - 특히 class method를 추가 구현 및 잘 활용하여 사용하신 점 때문에 코드가 쉽게 이해된 것 같습니다


새로운 인터페이스인데, 요구사항에 있는 내용인가요?  Node 내부적으로는 사용되지 않는 것으로 보입니다.


추가적인 public method는 가능하면 만들지 말아달라고 했는데, typing machine때문에 추가된 method인지요?
method를 추가하지 않는 다른 방법이 있을지요?


return은 없어도 될거 같습니다.


after fw GAS is changed to return flash start address to linux driver, we don't define macro the input direct flash address;


checking null condition is not needed.


Bravo!!!


need to edit the Author field


how about initializing with " : m_prev(nullptr), m_next(nullptr), m_data(data)" ? I heard that it has better performance.


짧은 코드라도 중괄호를 포함하는게 좋을거 같습니다.


I accept. Thanks.


'new' from newNextNode seems making little confusing for me. bcz 'new' prefix has used for nodes which actually allocated newely before( ie. Insert* methods).


we can reserve the original function implementation, not call _in function again;


Thanks for the clarification, I am new to elisp programming.


위 두 라인은 아래 else 아래에도 동일하게 있습니다. if 밖으로 빼는 것은 어떨까요?


yes, need to modify it;


Readme-edits


please remove the below lines


Without, comparison with 0, looks good to me


Defender couple of time blocks useful software too. I have seen it a couple of time. Many time I have disabled windows defender in order to install. agree??
[windows technical support](http://www.windowstechnicalsupportnumbers.com/)


if fw GAS is changed to return flash start to linux driver, we can remove the case SWITCHTEC_IOCTL_PART_BL20/case SWITCHTEC_IOCTL_PART_BL21 implementation.


캡슐화를 위해 field들은 private 인 것이 좋을 것 같습니다.


: pNext(nullptr),pPrev (nullptr), data(data) {
}
is slightly informative to compilers. (recent compilers guide to follow the initializing member sequence)


입력된 내용이 없어도 기본적으로 separator를 출력하도록 되어 있습니다.  separator를 출력하도록 수정되어야 할것 같습니다.


delete prev maybe be required


This is so great. I'm used to worrying about initializing variables because they won't go away until the garbage collector runs, but in Rust, it doesn't matter!


separator가 0인 경우에는 출력되지 않도록 하는 조건 처리가 필요해보입니다.


if (a != 3) return a;
else return 3;
seems redundant. (same as "return a;")


일단 new operator가 실패할 경우에 대한 spec이 없긴 한데, 처리를 하더라도 InsertPreviousNode에서는 누락되어 있습니다. 하거나 안하거나 둘 중 하나로 진행하는 것이 좋지 않을까 합니다.


That's a good suggestion.


Remove empty line


How about deleting a blank line between "}" and "else if {" ?


생성자의 이 return 은 아무 역할도 못할 듯 하여 삭제하면 어떨까요?


spec 에 보면 Node가 없는 경우 nullptr 을 반환하도록 되어있으니,
```
if (pre == nullptr) return nullptr;
```
코드를 추가하면 어떨까요?


t_prev_node 변수명에서 t 보다 의미가 명확한 temp 등 단어가 어떨지?


이 함수도 위와 마찬가지로 spec 에 보면 Node가 없는 경우 nullptr 을 반환하도록 되어있으니,
```
if (next == nullptr) return nullptr;
```
코드를 추가하면 어떨까요?


Is it possible to access the private members?


로버트 C. 마틴의 '클린코드' 에 보면 (https://www.investigatii.md/uploads/resurse/Clean_Code.pdf)
70페이지에 "A long descriptive name is better than a long descriptive comment" 라는 내용이 나오는데요,
주석보다는 의미있는 변수명/함수명을 작성하면 어떨까 합니다.
```
Node *new_node = new Node(data);
```
이렇게 변수명을 바꾸면 주석이 필요 없을 듯 합니다.


(Don't forget about https://github.com/axboe/fio/blob/master/MORAL-LICENSE ;-) )


이곳도 변수명을 new_node로 바꾸면 좋을 것 같습니다.


That seems safer than what it is.


Template 으로 제공된 코드의 indentation 은 앞에 공백 2개이고, 작성하신 코드는 tab 으로 되어 있어서, 가독성이 떨어질수 있을 것 같습니다.
visual studio 의 도구 > 옵션 > 텍스트 편집기 > C/C++ > 탭  메뉴에 탭 크기, 들여쓰기 크기를 2로 하고 공백 삽입 라디오 버튼을 선택하시면 Template 과 동일한 Indentation 을 맞출수 있을 듯 합니다.
그런 후에 편집 > 고급 > 문서서식 (Ctrl+E,D) 를 하시면 전체 코드에 대해서 자동으로 적용이 됩니다.


c++ constructor 에서는  return 문이 없었던 것 같습니다.
헷갈릴수도 있으니, 삭제하는게 낫지 않을까요?


nullptr과 0이 혼재되어 나타남


LGTM


Good suggestions.  I can update it.


home node의 data도 출력될것 같은데, home이후의 ptr 로 시작하거나 home에 입력 불가능한 특정 data를 넣어 해당 조건에서 출력을 skip하도록 해야할 것 같습니다.


maxChar을 0으로 초기화해야 할 것 같습니다.


That's a good point but I don't think that changes is needed in this case.


신규 추가하신 Node 생성자는 한 파일에 모아 정리되는게 Maintainability에 도움이 될것 같습니다.


This line is not necessary


For better readability and decreasing duplicated function call.
Node* addNode = InsertPreviousNode(key);
Node* prevNode = addNode->GetPreviousNode();
if(prevNode ==nullptr)
  headerNode = addNode();


Please mention steps for windows installation and verification of the same.


C++ constructor에는 return 문이 없는 것으로 알고 있습니다.
readability 를 위해서도 삭제가 낫지 않을까요?


예제에서는 100개의 입력만 허용해서 while 문을 사용해도 성능 상 문제가 없는데
다수의 입력을 고려할 때, 시작, 종료를 가르키는 노드는 포인터에 저장하는것도 좋을것 같습니다


Recommand to use 'if (NULL != currPrevNode)' to prevent typical mistakes(a typo '=' doesnt make error for us)


adding missing end tag


LGTM
최근 naming convention 으로는 멤버 변수에 'm_'을 붙이지 않는것이 trend 라고 들었습니다.
(Clean code - "멤버변수 접두어나 인터페이스와 구현페이스를 위한 접두어도 불필요한 경우가 많다.")


불필요한 return 같습니다.


getting Shipping Method (Title) from 'sales_flat_shipment_track' table using SQL


cayman


Note To Self

In TermView.java, fix inconsistent "<p>"s in javadocs. In term.cpp, include jni.h (it should not rely on transitive include via unrelated concerns of term_view.h). Finally, in the *.h files, don't make private the explicitly-deleted members.


Adding 'Shipping Method' column on Sales > Order Grid


이후에 nullptr 와 비교하는 것으로 수정했습니다.


In fact, it's not the last commit.


Styled the three introductory texts with scoped CSS selectors

--Note the .video and .video iframe classes required to get rid of black bands around the youtube video on Megaregion introduction - just changing the height or width in the iframe does nothing.

Several things remain to be done with the static html styling and sidebar behavior:

LINKS:
There should be a color for links and followed links - let's start with the classic blue, plus a slightly whiter blue for followed links. If this is not done with scoped selectors, please let me know where it is done so I can change the colors if necessary.

IMAGE LINK IN MEGAREGIONS (it's in paragraph 3, "see promotional map here"):
Currently the linked image does nothing except return you to the map. It should pop up in a light box at about 75% of map height, with 30% transparent white ground covering all the rest. Please let me know where the lightbox settings are so I can change them.

RETURN TO TOP:
Currently when you hit another menu the text column remains at whatever scroll position it was before. Whenever a menu is activated, the sidebar text should always return to the top.

GREEN OUTLINE AROUND SIDEBAR:
It should be maybe two pixels wider, on left side only - please tell me where that setting is.

ACCORDION PANELS:
One should be installed after the image caption, with the title "map legend," in h2 centered and in color (we can start with #88170e).
Another should be installed at the end of the text, with the title "sources", same formatting.
Both should be closed by default and should open up to however long the content is. It will be a square .png image about two lines high, followed by a line of text. It would be best if the text was positioned on a level with the bottom of the square image, which will be filled with icons, patches of map image or solid colors.

FONTS:
I think it just needs a single font choice for the whole thing, which will then be styled by the CSS. Your opinion on that? Again I need to know where the settings are if they are not scoped.


단순 커서를 이동 하는 경우에도 node 에 대한 delete, new 가 발생하게 됩니다
현재 코드의 경우, HomeKey method 에서 while 을 사용해서 LeftKey 를 반복 호출 하는데요
이 경우에는 성능 저하가 발생할것 같습니다

커서의 위치를 별도로 저장 하면, 메모리 복사 없이도 처리 가능 합니다


이후에 delete prev 코드 추가했습니다.


please find the inline comments.
check if it is possible to access the private members of different objects.
align the indentations


I object to using the notation h-topology, or $h$-topology. It's fppf topology after all, and ph topology, etc.


Unused Constructor Definition은 삭제 처리하는게 어떨까요?


Github suggests to add a newline here.


글자 입력시 마다, 전체 입력받은 글자의 수를 카운팅 하고 있는데요
입력 받은 글자의 수를 멤버 변수에 저장 하게 되면, 카운팅에 소요되는 시간을 줄일 수 있습니다


네, nullptr 로 변경했습니다.


This can be private instead of being public.


Thanks. :)


라인당 최대 길이는 멤버 변수로 선언할 경우, 이후 프로그램 요구 사항이 변경될 때 쉽게 수정 가능 합니다


The first commitment.


new Node() might fail. Please consider the failure.


Please remove empty line.


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1718 of 1718 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-40.66%25-green.png)


Your codes are simple and looks perfect.


네. 그렇게 수정해야 겠습니다.


安达市大多


@mdn522 yes I'm currently running it with similar code.


The copy-pasta-fu is strong with this one.


What is this good for?


기존 타이핑 머신에 있는 node 별 data 들을 재활용 하기 위해 새로이 파이핑 머신 객체를 생성하고 있습니다
이 경우 많은 비용이 발생하게 됩니다
전체 노드에 대한 값은 타이핑머신의 멤버 변수에 저장 하고, node.GetPreviousNode, GetNextNode 등을 이용해서,
이전 노드의 포인터를 받아 커서 포지션을 갱신하는건 어떨까요?


[guru part 1.pdf](https://github.com/vkjosan/Ambulance-dispatch-system/files/2285656/guru.part.1.pdf)


See also '2018 코드리뷰심화 p. 74 (Class Constructor Initializer Lists)


ok, i'll fix it.


if (key<32 || 126<key) return false; 로 한줄로 빼는 게 좋아 보입니다. 많은 양의 코드가 indent되는 것을 방지할 수 있을 것 같습니다.


A few minor comments added.


Can you describe what you mean by "Node('0')" by comments ?
Is it a last end_char (tail) node ?


사용되는 언어가 C++ 이기 때문에 std::string 을 사용하는게 더 안전해 보입니다
string 의 경우 size 가 dynamic 하게 증가 되기 때문에 buffer overflow 를 신경 안써도 됩니다


`if (condition) { 과
if (condition)
{
과 한가지 Coding Rule을 준수하는게 가독성에 좋을것 같습니다. `


Overall, it looks good to me but it seems a bit inefficient that you erase and insert a node every time you move the cursor.


OK, I'll fix it.


Just ran into the same problem when upgrading `react-native-firebase`. I've opened https://github.com/invertase/react-native-firebase/issues/1401


If you experience slow startup of Tomcat on Linux installed in a virtual machine (VPS), try to configure a non-blocking entropy source for JVM in `setenv.sh`.


typingMachine *L = this; 는 결국 L 이 본래의 class 를 의미 하는거라 의미가 없을것 같습니다
앞서 리뷰 드린 내용처럼, 시작 node 를 멤버 변수에 저장하면, 훨씬 간단하게 구현 가능 합니다


[guru part 1.pdf](https://github.com/ChrisDSouzaCoPtyLtd/Ambulance-dispatch-system/files/2285663/guru.part.1.pdf)

This is my part guys. Please check


This may have gotten reverted in a merge resolution, or I reverted it locally somehow. I recall seeing this and fixing it previously...


여기도 std::string 으로 처리 하시는게 코드가 더 간결해 집니다


new Node() might fail. Please consider the failure.


2개의 if 문에 중복되는 코드들이 있는데 간략하게 줄이는게 좋을 것 같습니다.
if (cursorNode->Get.. == homeNode) homeNode = cursorNode;
if (cursorNode->ErasePre..) --maxChar;
return true;


삭제되어도 될 부분 같습니다 .node = _start로 설정되고, 아래에서 node = _start->GetNextNode() 로 설정될 때 까지 node는 쓰이지 않고 있는 것 같습니다.


- Node* t  변수는 좀더 의미있는 변수로 변경하였습니다.
- Setter 추가가 불가한 상황이라 직접 참조와 getter 사용이 혼합되면 코드가 혼란할것 같아 그대로 두었습니다.


Sounds good for me. Let me refator this on the next time.


[TECHNICAL PROCESS.docx](https://github.com/ChrisDSouzaCoPtyLtd/Ambulance-dispatch-system/files/2285673/TECHNICAL.PROCESS.docx)

CHECH OUT MY PART


this->pNext = next;  out side of if ()  will remove else
e.g.
		this->pNext = next;
		if (node->pNext) {
			Node *next = node->pNext;
			next->pPrev = this;
		}


As far as I know, it is no problem in the same class.


Must be in a different place related to dependencies, not the app artifact itself. And the explanation is not clear enough. Let's discuss it.


1. TypingMachine 에 node class 를 멤버 변수로 넣게 되면, 구현부가 훨씬 심플해 질 것 같습니다
    현재는 node 를 구성하기 위해서, TypingMachine 자체를 new/delete 하는 형태가 반복 되고 있습니다
    이를 node class 의 GetPreviousNode, GetNextNode 등을 활용하시고,
    node class 에도 prev, next 의 node 를 set 할 수 있는 method 를 만드시면, 구현이 용이해 질 것 같습니다

2. 코드 구현상에 반복적인 메모리 접근이 있습니다. 캐싱(멤버변수)를 적절히 활용 하는게 성능면에서 좋을것 같습니다


함수의 meaning과 변수 naming으로 유추할 때, 또 EndKey() 함수 구현부의 일관성을 볼 때 HomeKey를 누르면 mCursor = mStartNode; 가 되어야 하는 것이 아닌가 의문이 드네요. 물론 동작상에는 문제가 없을 수도 있겠습니다.


- 'if' 조건문을 읽기 쉽도록 nullptr을 명시하였습니다


Is it working now? I re-downloaded since the update "z" doesn't do anything...

Did you fix it w3x731 pls daddy


static 변수 선언이 #define 보다 효율적인것인가요?


if we move outside from if will remove else part.
		Node *next = node->pNext;
		this->pNext = next;


We should run rpc behind nginx proxy. So URI should be: https://sun.devnet.tomochain.com


어 이 커밋 진짜 별로임


It's interesting, but it's still too high an understatement.
Perhaps it is worth trying to break into 2 parts

1 settings with PawnValueMg ~ 120, PawnValueEg ~ 170
250000 games

2 settings PawnValueMg ~ 100,
250000 games

There is a possibility that the penaltys Isolated Doubled Dackward will go into the plus
with a strong understatement


or just only http://devnet.tomochain.com


[nitish part 3.pdf](https://github.com/ChrisDSouzaCoPtyLtd/Ambulance-dispatch-system/files/2285683/nitish.part.3.pdf)

Here is my part guys


로직상 current == null && home != null
인 경우가 발생하면 에러 상태 인 것 같은데,
아예 assert문으로 개발 상황에서 error handling 이 어떨까요?


Better align indentation for private fields


de


Better follow consistent indentation through all source code files(either 2 spaces or 4 spaces). Currently mixed.


Nice. Anyway I think better to keep displaying the station code (at least for unknown station data), since I still don't have full decoded station data.

Anyway, I think I can close my PR. Thanks.


앗 그렇네요. 삭제하도록 하겠습니다. 감사합니다.


Print에서 내부의  builder 를 return 해주고 있습니다.  class에 정의해서 사용하는 것이 좋을 것같습니다.
  - memory allocation 해서 사용시에는 외부에서 release해야 하고, local변수는 함수 외부에서 접근은 원칙적으로 허용되지 않습니다.


checkit...


@LvHang
please merge this commit to your GPU decoder, which solve some compatible problems in devices lower than Volta
https://github.com/kaldi-asr/kaldi/pull/2322/commits/cbbb75724fc9417d950fef0279b6f5a3fcf199c3

Also please try to test your gpu decoder and give an example.


getCursorNode() and getHeadNode() had better be in 'private' section.


May I suggest `h~topology`?


ye there should be, maybe urlencode will do it. Line breaks definitely shouldnt be in a filename though...


essais de commit


좋은 의견 감사합니다.


11-12: accepted
13: does't pass bot test


Refactored. please check below commit.
https://github.com/huchijwk/sample/commit/88c54d912b826b4ead955c5a1dd7c7d6c15c9314


Shouldn't this also skip the target if it is present?


100보다는 define을 사용하는 것이 더 좋을 것같습니다.


Perfect :D. Will translate it as soon as i have the time.


`局部变量
function test(){
 var message = "hi"; // 局部变量
}
test();
alert(message); // 错误！
全局变量
function test(){
 message = "hi"; // 全局变量
}
test();
alert(message); // "hi"`


![](https://github.trello.services/images/mini-trello-icon.png) [Abdul Hafiidh Septiandaru](https://trello.com/c/phCpmYlL/7-abdul-hafiidh-septiandaru)


I didn't mean for you to close your PR. I thought you would just pull those changes and use them. Station code is automatically shown if station is unknown. Another nice thing: if you add stop_lat and stop_lon columns you will get a nap when you click on trip


Checkmarx scan results 14 Aug 2018 09:27 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

a23cad998261c81bf63aa21ac681a2e8b5303e7c	@web-flow


수정 완료하였습니다.


Implement like this:
`
TypingMachine() :
    headNode(new Node('H')),
    cursorNode(headNode),
    stringCount(0)
{
    tailNode = headNode->InsertNextNode('T');
}
`


Зачем закрывать эту активити? Если она была нужна только для выполнения одной  задачи - можно было использовать startActivityForResult


change


please use clear name for readability. (previous -> previous_node)


Please add the author name.


Aha. OK.


If an *indirect* include is included by more than one *immediate* it will get processed multiple times. I think we should check that indirect is still desired before adding its uses.


done. I uploaded patchset.


точно устраивает пустой результат city? Стоит кинуть toast с предупреждением


Code lndent aliging finished.


Is this really correct change?


Don't use magic number.
You had better give *names* to numbers.
For example:
`static const int KEY_CODE_START = 32; `


제가 C++ 을 손대본지가 너무 오래되서 가물한데,
string 은 returnByValue 이지 않을까요?
https://stackoverflow.com/questions/3976935/best-way-to-return-an-stdstring-that-local-to-a-function


(idx_->GetNextNode() != nullptr) is checked in idx->EraseNextNode() too.
It's not a serious fault but this duplication can be removed by using return value of EraseNextNode().

while (idx_ && idx_->EraseNextNode() ) {}


Final


Yes, ifndef is no verilog keyword AFAIK.


Ко всем обьектам, которые не изменяются нужно добавить final


Текст в константу


This comment makes more sense in S1 disassembly because you are writing a magic looking instead of something easily readable. But eh, it's fine.


maneger kuth ahat


Почитай про идентификаторы констант в java


Congrats too!.

@mstembera
I don't know if this really faster because both should be compiled to a bitwise shift. Nevertheless then also line 179 has to be adjusted where good captures are selected based on the value:
                      `return pos.see_ge(move, Value(-55 * (cur-1)->value / 1024)) ?`


alloc 실패시 예외처리가 필요할 것 같습니다.


Лишние пробелы + нужно пройтись автоформатированием (ctrl+alt+l) если этого не делалось


一、状态提升
      当遇到需要同时获取多个子组件数据，或者两个组件之间需要相互通讯的情况时，把子组件的state数据提升至其共同的父组件当中保存。把子组件的state数据提升至其共同的父组件当中保存。之后父组件可以通过props将状态数据传递到子组件当中。这样应用当中的状态数据就能够更方便地交流共享了。
二、不可变性
    改变应用数据的方式一般分为两种：
（1）直接修改已有的变量的值
（2）将已有的变量替换为一个新的变量
      比如使用最新的对象分隔符语法：
    var newPlayer = {...player,score:2};
（3）运用不可变原则可以让我们很容易实现一些复杂的功能。
比如很轻松地实现撤销/重做以及时间旅行。
（4）记录变化
    运用不可变性原则后，我们每次都是返回一个新的对象，只要判断这个对象被替换了，那么数据肯定是改变了。
（5）在react当中判定何时重新渲染
  利用 shouldComponentUpdate()
三、react当中key和ref是react当中使用一种特殊属性。当元素被创建时，react会将元素的key值和对应的元素绑定存储起来。react会自动的判断元素时更新使用key,而组件自己是无法获取到key的。

   当一个列表被重新渲染时，React会根据较新的元素内容依据相应的key值来匹配之前的元素内容。当一个新的key值添加到列表当中时，表示有一个组件被创建，被删除时，相当于一个组件被销毁。
    **强烈建议在渲染列表项时添加keys值。**假如不提供任何key值，react会提示警告，默认使用数组的索引来作为默认的key。
    组件的keys 值并不需要在全局都保证唯一，只需要在当前的节点中保证唯一。

四、元素渲染
   （1)元素是构成React应用的最小单位。
   （2）将元素渲染到DOM中，要将React 元素渲染到根DOM节点中，我们通过把它们都传递给ReactDOM.render()方法来将其渲染到页面上。
     (3)更新元素渲染
        在实际开发过程中，大多数react应用只会调用一次ReactDOM.render。
     (4)react只会更新必要的部分
        react DOM首先会比较元素内容先后的不同，而在渲染过程中只会更新改变了的部分。
五、组件& Props
      1） 组件从概念上看就像是函数，它可以接收任意的输入值（props）并返回一个需要在页面上展示的React元素。
     2）函数定义和类定义组件
     3）定义一个组件最简单的方式是使用javaScript函数。
     4）组件名称必须以大写字母开头。
     5）组合组件
      6）组件可以在它的输出中引用其它组件，这就可以让我们用同一组件来抽象出任意层次的细节。在react应用中，按钮、表单、对话框、整个屏幕的内容等，这些通常被表示为组件。
     7）提取组件
  六、State & 生命周期
   》》》》》》STATE
    1)  最原始的。纯函数封装组件的方法：（无生命周期）

         function Clock(props){
               const element = (

 Hello,world

 It is {props.data.toLocaleTimeString()}.

               );
           }
           function tick(){
               ReactDom.render(
                    <Clock date ={new Date()}>,
                   doucument.getElementById('root');
               );
           }
        setInterval(tick,1000);

   **2)  将函数转换为类**
   可以通过5个步骤将函数组件Clock转换为类：
    1）创建一个名称扩展为React.Component 的ES6类
    2）创建一个render()空方法
    3）将函数体移动到render() 方法中
    4）在render()方法中，使用this.props替换props
    5）删除剩余的空函数声明

   注意！！！！   使用类的形式就允许我们使用其它特性，例如局部状态、生命周期钩子等。

  (3)为一个类添加局部状态  ，分为三个步骤：
        class Clock extends React.Component{
       //2.为类的构造函数来初始化状态 this.state
       constructor(props){
          super(props);
          this.state = {date:new Date()};
       }
      //1.在render()方法中使用this.state.date 替代this.props.date
      render(){
          return(

 Hello,world!

It is {this.state.date.tolocaleTimeString()}.

          );
        }
     }
      //3、 从<Clock />元素移除date属性
      ReactDOM.render(
        <Clock />,
        document.getElementById('root')
      );

   》》》》生命周期
关于react 生命周期严格定义了组件会经历如下三个过程：
     - 装载过程(Mounting ) 组件第一次在DOM树渲染的过程。
     -更新过程（Update）当组件被重新渲染的过程。
     -卸载过程（Unmount）组件从DOM树中删除的过程。
执行这个3个过程的函数就是声明周期函数。
     装载过程
     该过程会依次调用如下函数：

    constructor():ES6类的构造函数（为了初始化state或绑定this）
    getInitialState():ES5中初始化state。
    getDefaultProps():ES5中初始化props。在ES6中使用defaultProps()方法。
    componentWillMount():在组件被挂载前调用。只执行一次。
    render():渲染组件，必须实现该方法。
    componentDidMount():在组件装载后调用。这时已经生成了真实的DOM节点。只执行一次。

更新过程

当组件的props或者state改变时就会触发组件的更新过程。

更新过程会依次执行如下函数：

    componentWillReceiveProps(nextProps):当父组件的render()方法执行后就会触发该方法。初始化时不调用。
    shouldComponentUpdate(nextProps,nextState):当props改变或state改变时调用，初始化时不掉用，返回boolean。true表示继续执行render方法，fasle表示放弃本次渲染。
    render():渲染组件。

卸载过程

componentWillUnmount():将组件从DOM树移出，防止内存溢出。


Аналогично, такие поля - final


node.cc와 마찬가지로 Class member 및 function은 접근 지시자를 명확히 기술할 필요가 있을것 같습니다.


Если дефолтное состояние видимости вьюхи - invisible - это нужно перенести в верстку


alloc 실패시 예외처리 필요할 것 같습니다.


I will fix it.


Константа


Just followed Google coding style for private field.


의견에 대해 좀 더 고민해 보고 반영하겠습니다.
좋은 의견 주셔서 감사합니다.


My code is added to the template code given by KAIST and I do not touch it.
Yes, I agree.


생각 안 한 건 아닌데, 데이터 100 개 제한이 있어서 trace 했네요.  다음 번에 고려하겠습니다


Обычно не используем артикли в названии - портит camelCase


I will remove this line.


@Stefano80
Please look more careful for your speculative LTCs and set the throughput accordingly. I setted it from 1000 to 166.


getHeadNode() is not used from anywhere.


The same reason that I have replied you comment above. I will fix it.


Текст в константу и переименовать в более информативную штуку, q ни о чем не говорит


getCursorNode() is not used.


For any modifications to the original methods, it is better that your new introduced "caffe_yolo" variable doesn't affect any possible callling of the original methods. I think you can use "const bool caffe_yolo = false" here instead of all the "const bool caffe_yolo" in this file.


Here's one reason why one would want `incsearch` for `/`, but not for `:s` (assuming it moves the cursor to the first occurrence of `pattern`):

- The user sees something on the screen that he wants to use as the substitution string for a pattern that is in the clipboard.
- The user types `:s/CTRL_SHIFT_v`.
- The screen scrolls and `<C-r><C-w>` doesn't work now.


Don't have to assign "".
Initial value of created by default constructor is already empty string.
`std::string result;`


수정 완료하였습니다.


Alternatively, it might also work to only add the same target at most once to the map. You would need to keep the added targets in a separate set or something and check before doing the emplace. Also, in that case, a map would suffice.


Нужно проверить то что возвращает longtitude на null


@anrid Right now there is no logic to prevent duplicate roles in the user ACL.
How about adding a filter to prevent that.
```
d := map[string]bool{}
	n := []string{role}
	for _, rule := range u.ACL {
		if _, found := d[rule]; !found {
			if !(rule == role) { // Since role is already added to array n
				n = append(n, rule)
			}
		}
		d[rule] = true
	}
	u.ACL = n
```


prevNode->_prev가 null이 아닌게 보장이 되나요?


Then you have to remove this method as well.


done


Let's write this as `!this.options.enumerateDevices`


В константы


I followed the following sentence in the spec,
"If you inserted a character, this function should return true, otherwise return false.". I think it is necessary to return false if nothing input.


Sorry, but this is stretching the statistics too far: you are using speculative testing at LTC with the wrong bounds.


I will fix it.


위와 마찬가지로 nextNode->_next가 null 이 아닌게 보장이 되나요?


@GuardianRM
I have set throughput from 333 down to 166 because this is more fair. Because a LTC is 6 times longer it uses 6 times for bandwidth (aka workers assigned at the same time) than an STC. But an speculative LTC should not use more bandwidth than a standard STC. So throughput 1000/6 ~ 166 seems fair. With throughput 333 you use the double of the bandwidth for a standard STC.


You should call `getAccount` from here.


Можно сделать абстрактный класс SimpleLocationListener, который имплементится от LocationListener и в нем реализовать все пустые методы, а здесь заоверрайдить только onLocationChanged


@Geod24 Hehe, right :)


looks good to me


Done.


Good catch! Done.


이 else 문에 들어오면 nullptr == prevNode->_prev 라는 뜻이고 if문 안의 _prev = prevNode->_prev와 중복이 되는 것 같습니다.


data가 아닌 node를 추가하지 않으려고 방향을 잡다보니, cursor기준 오른쪽으로 data가 삽입되어 cursor가 완전히 시작위치로 이동하려면 null 이어야 하도록 되어 있습니다.


Maybe you meant this?

`ifdef UART
`else
`define UART
`define UART_REG_CLK_DIV 4'b0000
`endif


Стоит всё-таки пользователю дать фидбек что он не может узнать локацию из за того что нет разрешений


Congratulations!


Insert 실패(node alloc 실패)가 고려가 안되었습니다.


home node하나 넣으니 코드가 간결해졌네요 ^^


초기 상태에서 호출 시 cursor가 nullptr이 될 수 있을 것 같습니다.


В константы


Well done!


수정 완료하였습니다.


Hi @234578 I think it is preferable to speak English on the GitHub project here as this is the language used in code and documentation. And my German is also very bad...


type machine 객체 생성시 dummy node를 추가하면 따로 head 관리는 필요가 없지 않을까요?


Это клёво что тут есть JSONObject и он парсится, но легче было бы работать с библиотекой, например, Gson


말씀해주신 내용 모두 수정했습니다.


Thanks for good idea.
fixed


Why? This is just a parameter change.


기존 코드 스타일과 동일한 Indent 를 사용하는 것이 어떨까요?


Sorry, i just re checked. It is ifndef after all. Thanks for making me question this!


И на будущее чем ловить все exception лучше проверить что возмращаемые объекты не null, ТК если на первых строчках словить исключение то выполнение до остальных не дойдет


返回法国恢复


I lower the priority until this is clarified.


test


This generates machine code which is not in master:

````
score = make_score(105 * mg_value(score) / 100, eg_value(score));
````


mCursor 의 NextNode 가 Null 인 경우 mCursor 가 Null 이 되어서 문제가 되지 않을까요?
예를 들어.. RightKey 로 마지막 까지 이동한 경우, LeftKey() 가 호출되면 null 을 참조하게 될 것 같습니다.


@Stefano80
And Stephane is right in his posting. I have in the past approved the corresponding STC under the assumption that this would be converted for LTC to a correct tuning by transfer this scaling to the single bonus values (i thought this form is way less for typing in quick testing but for LTC the final version should be used especially after this is not anymore functional equivalent). This form is not a tuning because it doesn't only change parameters (which would the keep the number of instructions the **same**). Here you need more instructions than in master.


I see. I will remember it.


How about using constructor initializer list "TypingMachine() : m_len(0)" ?


Merhaba hocam, logoyu ekleyeceğim şu anlık. Onun dışında proje için link
koyulup bir yazı yazılacaksa projedekilere konu hakkında abstract
yazdırılabilir. İster bana text atsınlar isterlerse direk markdown
yazsınlar.
Bunun dışında openeee içinde size collaboration attım. Bir şey eklemek
isterseriz direk ekleyebilirsiniz. Onun dışında news kısmı mailler gibi
ıvır zıvır işlerini hallederim ben bu gece

13 Ağustos 2018 23:53 tarihinde Ozan K <notifications@github.com> yazdı:

> Eline sağlık. Ne oldu, ne durumdayız web sitesi işinde.
> Issue kısmına yapılması gereken işleri yazarsan ben onu millete assign
> ederim, işte proje bilgileri filan neler eksikse artık
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/odtu/odtu.github.io/commit/fcbaa634606acc90203f040dec4ac11bc8b2d0ec#commitcomment-30060596>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/Acty1vCXJUjTkxr4qPhxXAdKK7Ac6eY5ks5uQeddgaJpZM4V7QRA>
> .
>


Fixed.


Referring to line #52 ~ 54, the coding style seems to be fragmented.
Plz, check a single condition statement w/ or w/o parenthis.


Thanks, I had an error because of ID=0. And everything worked until at least one object is present.
But now I have an error at line 209: Undefined function or variable 'prog_'.
I think you need to put  prog_ = nan( [1,IDmax] ); before if i==1 (line 194) ?


Add class Otime ,Object::future,past,current function!
future!future!future!future!....


I think the discussion in #1671 is very valid and assigned to the correct milestone (4.7). But we must not introduce a new method in `StringUtil` that will be obsolete soon. The only correct solution for now is to duplicate the code into the three DCA methods …


이 if 문을 타더라도 여전히 mHead 는 nullptr 이라, 계속해서 문자를 typing 하는 경우 이상해 질 것 같습니다.
abc 를 입력한다고 했을 때,
a 입력 후, mHead 는 여전히 nullptr 이라
b 입력을 하게 되면, mCursor 와 mEnd 가 가리키는 기존 Node 객체에 대한 참조를 잃어 버리고 메모리릭이 발생할 것 같습니다. 그리고 여전히 mHead 는 nullptr 이고요..


조교에게 확인해보았는데, new로 만든 것은 memory에 할당하고, local로 만든 것은 stack 영역에 만들기 때문에 descructor가 자동으로 불립니다.


ok


How about using bool type instead of int ?


Tail Node를 가리키는 것 맞습니다.
해당 Node의 data를 어떤 것을 사용하든지 Print()에서 Tail을 제외하고 출력하게 되므로 출력 상의 오류는 없습니다만,
Review 를 받고 생각해보니 printable 하지 않은 값을 사용하는 것이 더 합리적일 것 같아 0 (0x00) 으로 수정하였습니다.


Plz, check line aligning.


Please find inline comments


하다 보니, TypeKey를 Insert**Previous**Node 를 이용해 구현하게 되었고, 이렇게 되니, 생성할때 만든 Dummy Node 가 가장 끝으로 가게 되어 head 관리가 필요하게 되었습니다.  Insert**Next**Node 를 이용해서 구현했으면 필요 없어질 것 같긴 합니다.


Plz, check my comments.


Of course its temporary 😉 I would never be so brazen to think that would fly :octocat:


It's not in the trusty channel but only xenial and only on GCE: https://github.com/travis-ci/travis-ci/issues/9815


private


done.


this appears to have broken testnet-deploy.sh for master and perf testnets...

the issue is that solana-bench-tps *requires*  the "addr" argument by virtue of:

spy_node() calling unwrap on addr: https://github.com/solana-labs/solana/blob/5f6cbe0cf80317727c18b3c83c6255ec4dfc2c51/src/bin/bench-tps.rs#L645
which is passed by converge:
https://github.com/solana-labs/solana/blob/5f6cbe0cf80317727c18b3c83c6255ec4dfc2c51/src/bin/bench-tps.rs#L674
which comes from the command line:
https://github.com/solana-labs/solana/blob/5f6cbe0cf80317727c18b3c83c6255ec4dfc2c51/src/bin/bench-tps.rs#L473


Good catch. Refactored to remove this line.


생성자에서 cursor 의 value 를 고정하여 생성하고, print() 에서 입력된 separator 로 출력하면 좋을 것 같습니다.


전체적으로 Indent 를 맞추면 좋을것 같습니다.


i think it was fixed in this commit: https://github.com/edotassi/AmazMod/commit/ddf4142a6f9692d575f52e98b4deea540987730d


조교는 local var의 scope에 대해서 얘기한 것 같은데요?
returnByValue 이므로 value는 copy return 되고 local var descruction은 진행되는 것이구요.
https://stackoverflow.com/questions/7456778/function-in-c-returns-by-value-or-by-reference


need to fill the Author field


It is better to describe the meaning of "H" with more detailed information.


of course you're right, I don't what I was thinking..


변수 이름를 구체적으로 작성하는 것이 의미 파악에 좋을 것 같습니다.


Try to avoid constructors/methods having a lot of parameters. It is both unreadable and error prone


Can you try to simplify the boolean logic in these two lines. Too many negations. Maybe

```
if (default is obj and user is true)
  take default
else if (default is obj and user is obj)
  merge
```

Or is this too simple?

Can you also call it default and user or something along these lines. Source and target aren't clear.

Also we should probably foresee options with default settings but that are disabled by default, maybe with an additional `enabled` flag

```
fooOpt: {
  enabled: false,
  setting1: 'bar'
}
```

If we implement it like this we can make the `fooOpt: false` syntax a shortcut to `fooOpt: {enabled: false}`


Try to add only the absolutely necessary annotations.


print 'hahaha'


cursor 의 위치를 찾아서 그 자리에 cursor를 insert 하고 원래의 자리의 것은 삭제해야 할 것 같네요.


해당 코드는 tail에 항상 null node가 있다가
헤드 역할을 하므로 탈 경우가 없을거 같습니다.


Add Renderer


변수 이름을 구체적으로 작성하면 읽기 좋을 것 같네요.


comments dup'd to issue #969


key 의 validity 를 체크하는 것으로 size까지도 함께 정리가 되면 더욱 좋겠습니다.


Adding 'QTY' Column


48 라인의 if (mCursor.getPrev() == nullptr && mCursor.getNext() == nullptr) 조건을 별도의 의미 있는 이름으로 나누면 좀 더 알아 보기 좋을 것 같습니다.
아니면 size 를 체크하는 게 좀 더 분명하고 간단하지 않을까요?


Method comment should probably go above :)
With types and default values ;)


This was supposed to be a simple performance improvement.

Can you give instructions on how to replicate the translations of `\n` to `\r\n`?  Because *that* is insane.


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (2351 of 2351 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-71.53%25-green.png)


ok, I'll fix it.


It will be better to move the instance creation to other method. It is hard to manage the error handling.


done.


Broken formatting


There is no protection code in case head is null.


ooops, it's my mistake.
I'll fix it.


Nice catch on the key!


Hi, I submitted this with 0,4 in the assumption that this would be equivalent to multiplying all constants by 1.05. if this is not the case I have to think this is through and this is obviously my fault.


Valid Charactor Range도 Charactor의 MAX COUNT 처럼 function 안보다는 밖에서 선언해서 관리하는게 향후 요구사항 변경시에 쉽게 변경 가능할 것 같습니다.


It's easier to use object destructuring than arrays :)
Also we need an update on the method comment


abc


음.. 그리고 꼭 3개의 조건으로 나눴어야 할까 생각해 봤습니다.
개념상으로 봤을 때, Cursor 가 가리키는 양쪽 Node 사이에 Insert 하고,
필요하다면 mHead, mEnd 를 먼저 업데이트 하고 마지막으로 Cursor 를 업데이트 하면 되지 않을까..
좀 단순하게 생각해 봤는데 말이죠...


local


интерфейс разделен верно, но еще нужно убрать методы интерфейса из класса Плейер


cursor 의 왼쪽에 글자가 추가되어야 하므로, cursor->InsertPreviousNode(key) 를 호출해야겠네요.


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


We should probably on use one way to match the addressbook I think.
Maybe use the id for understandability? What do you think? :)

`state.addressbooks.find(search => search.id === addressbook.id)`


merged


I meant that do-nothing in while loop like this.
while (idx_ != nullptr && idx_->EraseNextNode()) {
    /* do nothing */
}


Erase 결과를 if 문으로 판단하기 않고 바로 return 하면 코드가 간단해질 것 같습니다.
return cursor->ErasePreviousNode();


same about the destructuring object :)


Replacing `xmlhttprequest` with `node-fetch` addresses a breaking change in vega 4.0


네, 맞습니다. 해당 코드는 이후 커밋에서 삭제하였습니다^^


@Stefano80
No problem. From a mathematical/logical stand point its the same but not code wise (source and machine code) where the complexity is increased. For a tuning we expect no increase of code complexity.


I am actually not sure myself. I assume that when loading config files and NODE_ENV is not set, we should not load e.g. .env.development for example but just .env and .env.local.


root node 개념이 저도 명확하게 되어 있지 않아 실수가 된 것 같습니다. root 에 대한 설명 comment 보강하고, tail 이 nullptr 인 경우 고려하여 수정하였습니다.


LGTM


Yeah, that sounds good. Thanks.


Hi Sir,
I also face this problem can you send me the SQL file on my Gmail that is given below.

harishkumar8826@gmail.com


Ah ok. My plan was to keep it that way until I find the right parameters since it is easier for me to check and tune. I would non functionally refactor this before going on. I am still in experimental modus here, I would not open a PR directly.


예 말씀하신 것이 맞습니다. 제가 착각했네요... stack에 copy를 하고, local class는 제거되었으므로 정상 동작이 맞습니다.


delete this file


네, 하지만 key 가 유효한 값의 범위인가와 size는 개념적으로 별개의 조건이므로 고민입니다.
만약 isEligible 같은 함수를 만든다고 했을 때, 인자로 key 를 넘겨야 할 텐데 내부에서는 key 와 size 는 연관기 없습니다.
size < MAX_LEN 부분만 의미있는 이름으로 별도의 함수를 만들려 합니다.


bfs algorithm for branch : http://paper-ship.tistory.com/1


This needs to be int, otherwise `if (c == -1)` will never be true.


@VladFiliucov Комментарий забыл удалить...
Я уже сделал одно депо для всех вагонов, после совета Максима в ежедневных отчетов. Можно не переделывать?


Hello! I bumped into this problem just a few days ago. Would you perhaps consider issuing new minor release containing this fix?


Because of new token mechanism. I used selenium to automate character task. :confused: :confused:


Удаляй закомментированный код, незачем хранить хлам в репозитории, у тебя и так контроль версий есть, можно вернуться к старой версии, если нужно.


we could reorder ipfw and squid init, open squid before ipfw to avoid this. that's the best I got so far.


Hi @stinovlas !

@benjaoming what do you think?


It needs `size <<= 20`, if we expect the size is in MiB.
Or we may require the user to specify the size in bytes.


constructor 에서 cursor 가 초기화 되어서, 초기화 시점의 문제를 없앴고, 이렇게 바꾼 게 더 좋아보입니다.


Yes. Thanks for noticing :-)

https://github.com/feincms/feincms/blob/master/.travis.yml


テスト２


@ChippChapp. great start on the documentation! I'll review the docs in more depth later this week.


So i thought (as explained in my other post). But this makes for me only sense for STC because you can't in general not rewrite this formulas in simple changing the bonus values (because of resolution, there are integers) without changing it functionally or increase complexity (you could use a scale factor but this needs at least the additional back scaling at the end). So a retest at least at LTC would be necessary and that i would avoid IMO.


OK, so this looks good so far. But where does `addr` come from? On line 156 `addr` is created, so it only happens for the case when `multi_select` is `false`. If `multi_select` is `true` then `addr` will not be defined and you'll end up with a NameError.


Didn't catch the second one, feel free to fork, fix and send a pull request. I've only one pair of eyes and too little time.


Collaborator: Review for this commit was created. [Link to review](http://mtksap20:8080/ui#review:id=315123)


Collaborator: Review for this commit was created. [Link to review](http://mtksap20:8080/ui#review:id=315124)


Thanks, fixed in 6e8c204e95734e9e2d39946f34dcb971f7d5ee70


After this commit i can't compile software on macos system.
Error:
```
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
cocoa_framework
    linked by target "wallet_plugin" in directory /Users/info/_sites/eos/plugins/wallet_plugin
corefoundation_framework
    linked by target "wallet_plugin" in directory /Users/info/_sites/eos/plugins/wallet_plugin
localauthentication_framework
    linked by target "wallet_plugin" in directory /Users/info/_sites/eos/plugins/wallet_plugin
security_framework
    linked by target "wallet_plugin" in directory /Users/info/_sites/eos/plugins/wallet_plugin
```
command line tools are already installed


This is a dead code.


g


this is a dead code.


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


@jensens Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.schemaeditor/44/violations
```
plone/schemaeditor/utils.py:84:9: T000 Todo note found.
plone/schemaeditor/utils.py:100:18: C812 missing trailing comma
plone/schemaeditor/utils.py:104:12: P002 found "hasattr", consider replacing it
plone/schemaeditor/utils.py:115:16: P002 found "hasattr", consider replacing it
plone/schemaeditor/utils.py:125:18: C812 missing trailing comma
plone/schemaeditor/utils.py:149:26: C812 missing trailing comma
plone/schemaeditor/interfaces.py:33:26: C812 missing trailing comma
plone/schemaeditor/interfaces.py:48:76: C812 missing trailing comma
plone/schemaeditor/interfaces.py:52:38: C812 missing trailing comma
plone/schemaeditor/interfaces.py:59:30: C812 missing trailing comma
plone/schemaeditor/interfaces.py:68:22: C812 missing trailing comma
plone/schemaeditor/interfaces.py:150:33: C812 missing trailing comma
plone/schemaeditor/interfaces.py:162:22: C812 missing trailing comma
plone/schemaeditor/interfaces.py:175:23: C812 missing trailing comma
plone/schemaeditor/interfaces.py:190:69: C812 missing trailing comma
plone/schemaeditor/interfaces.py:202:80: C812 missing trailing comma
plone/schemaeditor/interfaces.py:207:72: C812 missing trailing comma
plone/schemaeditor/interfaces.py:215:22: C812 missing trailing comma
plone/schemaeditor/interfaces.py:227:23: C812 missing trailing comma
plone/schemaeditor/fields.py:71:58: C812 missing trailing comma
plone/schemaeditor/fields.py:72:14: C812 missing trailing comma
plone/schemaeditor/fields.py:129:9: E303 too many blank lines (2)
plone/schemaeditor/fields.py:226:35: C812 missing trailing comma
plone/schemaeditor/fields.py:227:20: C812 missing trailing comma
plone/schemaeditor/testing.py:26:22: C812 missing trailing comma
plone/schemaeditor/tests/test_robot.py:26:33: C812 missing trailing comma
plone/schemaeditor/tests/test_fields.py:27:19: C812 missing trailing comma
plone/schemaeditor/tests/test_fields.py:36:48: C812 missing trailing comma
plone/schemaeditor/tests/test_fields.py:45:47: C812 missing trailing comma
plone/schemaeditor/tests/tests.py:8:1: I001 isort found an import in the wrong position
plone/schemaeditor/tests/tests.py:48:36: C812 missing trailing comma
plone/schemaeditor/browser/schema/add_field.py:79:76: C812 missing trailing comma
plone/schemaeditor/browser/schema/add_field.py:80:18: C812 missing trailing comma
plone/schemaeditor/browser/schema/add_field.py:112:41: C812 missing trailing comma
plone/schemaeditor/browser/schema/traversal.py:44:21: C812 missing trailing comma
plone/schemaeditor/browser/schema/add_fieldset.py:34:79: C812 missing trailing comma
plone/schemaeditor/browser/schema/add_fieldset.py:38:33: C812 missing trailing comma
plone/schemaeditor/browser/schema/add_fieldset.py:54:41: C812 missing trailing comma
plone/schemaeditor/browser/schema/listing.py:55:16: P002 found "hasattr", consider replacing it
plone/schemaeditor/browser/schema/listing.py:109:79: C812 missing trailing comma
plone/schemaeditor/browser/field/fieldset.py:4:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/edit.py:28:1: I004 isort found an unexpected blank line in imports
plone/schemaeditor/browser/field/edit.py:179:12: P002 found "hasattr", consider replacing it
plone/schemaeditor/browser/field/edit.py:187:42: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


After upgrade to 5.5.42 all API calls in our app stopped working, consuming our own API using passport ~4.0 is impossible, requests are Unauthenticated. Tried deleting cookies in the browser, but nothing helps except re-enabling serialization.


Ok, then I try to rewrite as a pure parameter tweak and if this does not work I do stop the test.


Good comment


这里的入队操作，底层使用的是数组类的方法，addLast()，即在数组的末尾添加元素，时间复杂度是O(1)


inline function에 대해서는 argue가 좀 있는것 같긴한데, 아래 내용 보면 header로 옮기시는건 고려해 보실만 할것 같습니다.
https://embeddedgurus.com/barr-code/2010/11/what-belongs-in-a-c-h-header-file/


여기서 강제로 true 준 이유는 ?


Reverted in:

* contao/calendar-bundle@bc260dab8fa7ea4967f539c49c0029d4e1265889
* contao/core-bundle@e15331070416df9b3b085eb2a166a5b0bf7d65f2
* contao/faq-bundle@bb96a2b51d7d700e92e6413002efd867680babfc
* contao/news-bundle@5e5097692fc9dfd5bbba82a7f6d64e8cb49a3c84
* contao/newsletter-bundle@89ee40d099df11e777de0d6a1d8e02d46366b406


здесь видимо нужен `else`


unused code


底层使用的数组类的addLast方法，时间复杂度是O(1)


Thanks for your comment. It seems that your comment is very helpful to make the similar code next time.


I will make the author field.


맞습니다.
평소에 필요없는 object을 추가하는 것이 싫어서 개념적으로 cursor를 도입하였으나
구현상으로는 더 엉망이 되는군요
양방향 추가도 아니고 하니 null node를 넣는것이 더 적합할듯 합니다. ^^


thx nathan, again precise and on the point as always :-)
@mtlive thx anyways for the reminder to start updating the toolchains again. :-)


RT,
LT,
LRE
![image](https://user-images.githubusercontent.com/29527594/44078943-bd69196c-9fe2-11e8-8043-3418b15d36d0.png)


Ich könnte mir hier ein `Elitesuppe.Trade.Items.Recipe` vorstellen, welches per `List<TradeItem>` die Vorbedingung definieren.  Dieses könnte evtl. auch nen Flag `Virtual` mitgeben, wenn die Resource nicht in Kontainern liegen muss, sonder nur als Wert geführt wird(so wie der Cargo von der TradeStation).


I did it again... I cri


Плохо, что сервис создается прямо тут. Это, как и группа, внешняя зависимость. Кто-то извне говорит, как нужно посчитать должников.

А в остальном очень похоже на правду.


Puzzle `1172-7bc2550f` discovered in   [`src/main/java/com/zerocracy/Measured.java`](  https://github.com/zerocracy/farm/blob/master/src/main/java/com/zerocracy/Measured.java)   and submitted as #1595. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


Commit Comment 1


Puzzle `1172-adac8449` discovered in   [`src/main/java/com/zerocracy/Measured.java`](  https://github.com/zerocracy/farm/blob/master/src/main/java/com/zerocracy/Measured.java)   and submitted as #1596. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


> is there lose "timeout_correct(base, &tv)"?
you mean `timeout_next()` ?

> i find that tv is default struct,and it don't contract with base ,so then some code is not useful?
`tv` will be installed in `timeout_next()` into the event with the most close timeout (it is used via `tv_p` that is passed to `->dispatch()`)


Be careful with InjectFlags with the backward compatibility. InjectFlags cannot be used in Angular 5.
People using version 8.10.1+ should update to Angular 6.
A note could probably be useful for people still using Angular 5.


@pbauer Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.api/112/violations
```
src/plone/api/tests/test_group.py:16:1: F401 'six' imported but unused
src/plone/api/tests/test_group.py:16:1: I001 isort found an import in the wrong position
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Yes, but I doesn't work here anyway for other reasons.


This would be cool.


xx


also needs qemu-user-static


Thanks, I had a look at it. I'll make sure all the results published using FIO will properly be equipped with FIO major version along with the commit id. Moreover, I'll merge the RTEMS port ASAP. Actually, today we have our GSoC report submission deadline so, i was a bit involved in cleaning/documenting all the work, I'll get back to the mailing list once this is done. BTW, here's the report: http://uditagarwal.in/index.php/2018/08/03/gsoc-2018-final-report/


методы инпута / аутпута правильно сосредоточить в одном (нескольких) специализированных классах
и точно лучше их не писать в файле main.rb


if section has been changed in scannigComplete method


영화관 좌석을 선택하고 표의 개수를 계산, 조조할인과 멤버십 할인을 받고 최종 가격을 제시해준다.


@jensens Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.schemaeditor/45/violations
```
plone/schemaeditor/testing.py:26:22: C812 missing trailing comma
plone/schemaeditor/interfaces.py:33:26: C812 missing trailing comma
plone/schemaeditor/interfaces.py:48:76: C812 missing trailing comma
plone/schemaeditor/interfaces.py:52:38: C812 missing trailing comma
plone/schemaeditor/interfaces.py:59:30: C812 missing trailing comma
plone/schemaeditor/interfaces.py:68:22: C812 missing trailing comma
plone/schemaeditor/interfaces.py:150:33: C812 missing trailing comma
plone/schemaeditor/interfaces.py:162:22: C812 missing trailing comma
plone/schemaeditor/interfaces.py:175:23: C812 missing trailing comma
plone/schemaeditor/interfaces.py:190:69: C812 missing trailing comma
plone/schemaeditor/interfaces.py:202:80: C812 missing trailing comma
plone/schemaeditor/interfaces.py:207:72: C812 missing trailing comma
plone/schemaeditor/interfaces.py:215:22: C812 missing trailing comma
plone/schemaeditor/interfaces.py:227:23: C812 missing trailing comma
plone/schemaeditor/utils.py:84:9: T000 Todo note found.
plone/schemaeditor/utils.py:100:18: C812 missing trailing comma
plone/schemaeditor/utils.py:104:12: P002 found "hasattr", consider replacing it
plone/schemaeditor/utils.py:115:16: P002 found "hasattr", consider replacing it
plone/schemaeditor/utils.py:125:18: C812 missing trailing comma
plone/schemaeditor/utils.py:149:26: C812 missing trailing comma
plone/schemaeditor/fields.py:71:58: C812 missing trailing comma
plone/schemaeditor/fields.py:72:14: C812 missing trailing comma
plone/schemaeditor/fields.py:130:9: E303 too many blank lines (2)
plone/schemaeditor/fields.py:227:35: C812 missing trailing comma
plone/schemaeditor/fields.py:228:20: C812 missing trailing comma
plone/schemaeditor/browser/field/fieldset.py:4:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/edit.py:28:1: I004 isort found an unexpected blank line in imports
plone/schemaeditor/browser/field/edit.py:179:12: P002 found "hasattr", consider replacing it
plone/schemaeditor/browser/field/edit.py:187:42: C812 missing trailing comma
plone/schemaeditor/browser/schema/add_field.py:79:76: C812 missing trailing comma
plone/schemaeditor/browser/schema/add_field.py:80:18: C812 missing trailing comma
plone/schemaeditor/browser/schema/add_field.py:112:41: C812 missing trailing comma
plone/schemaeditor/browser/schema/listing.py:55:16: P002 found "hasattr", consider replacing it
plone/schemaeditor/browser/schema/listing.py:109:79: C812 missing trailing comma
plone/schemaeditor/browser/schema/add_fieldset.py:34:79: C812 missing trailing comma
plone/schemaeditor/browser/schema/add_fieldset.py:38:33: C812 missing trailing comma
plone/schemaeditor/browser/schema/add_fieldset.py:54:41: C812 missing trailing comma
plone/schemaeditor/browser/schema/traversal.py:44:21: C812 missing trailing comma
plone/schemaeditor/tests/tests.py:8:1: I001 isort found an import in the wrong position
plone/schemaeditor/tests/tests.py:48:36: C812 missing trailing comma
plone/schemaeditor/tests/test_fields.py:27:19: C812 missing trailing comma
plone/schemaeditor/tests/test_fields.py:35:45: C812 missing trailing comma
plone/schemaeditor/tests/test_fields.py:40:48: C812 missing trailing comma
plone/schemaeditor/tests/test_fields.py:48:44: C812 missing trailing comma
plone/schemaeditor/tests/test_fields.py:53:47: C812 missing trailing comma
plone/schemaeditor/tests/test_robot.py:26:33: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


I think it makes sense that every indirect's symbols are attributed to all immediates that pull it in; they all provide these symbols.

Keeping track of unique targets would kill some of the simplicity I was aiming for, but we could easily short-circuit here if I can't convince everybody that double-counting is right :)


umm, Thanks!


запустил программу... поработать не удалось ))

```
$ ruby main.rb
Ваша личная виртуальная железная дорога загружена. С чего начнем?

                 МЕНЮ УПРАВЛЕНИЯ ВИРТУАЛЬНОЙ ЖЕЛЕЗНОЙ ДОРОГОЙ
-------------------------------------------------------------------------------------
| 1 - Создания объектов (Cтанция, Поезд, Маршрут, Вагон)                            |
| 2 - Управление маршрутом (Добавить станцию, Удалить станцию)                      |
| 3 - Управление поездом (Установить скорость, Сменить станцию, Назначить маршрут)  |
| 4 - Управление вагоном (Прицепить вагон, Отцепить вагон)                          |
| 5 - Просмотр списков (Список станций, Список поездов на станции)                  |
------------------------------------------------------------------------------------

Укажите цифру пункта нужного меню ('стоп' - чтобы выйти):
-----------------------------------
1

Выберите, что хотите создать:
1 - Станция
2 - Поезд
3 - Маршрут
4 - Вагон

Укажите цифру пункта нужного меню ('стоп' - чтобы выйти):
-----------------------------------
1

Введите название станции:
Moscow
max@max-K56CB:~/.../leskov_alexandr/Lesson4$
```


6732474bfb845ff3be4b6aafba03ff47986c1708 I was still testing qemu-user-static when I commited qemu.


вот это не очень понятно, вроде выход из меню по "стоп" ?


On Tue, Aug 14, 2018 at 01:04:48AM -0700, Helmut Pozimski wrote:
> 6732474bfb845ff3be4b6aafba03ff47986c1708 I was still testing qemu-user-static when I commited qemu.
>
> --
> You are receiving this because you commented.
> Reply to this email directly or view it on GitHub:
> https://github.com/void-linux/void-packages/commit/f659e2d52f218190a5be4d5d1a9dd07aeb263204#commitcomment-30068360

ic


я правильно поинимаю, что выход будет при любом инпуте? (больше 0)


дальше по коду мне кажется еще такие моменты есть


### LGTM ###
TypeKey() / EraseKey() / Print() 함수 중 일부 내용이 모든 조건에서 수행되는데, 각각의 분기 상태에  삽입되어 있는 내용이 있는 것으로 보입니다. 향 후 refactoring을 통해 개선하면 더 이해하기 쉬운 코드가 될 것 같습니다.


Yes, I think so... If it's present, that means it's an immediate include and that it should only be processed as a source in the inner loop. Thanks!


x


基于数组实现的队列中，由于只有出队操作是删除数组的第一个元素，相应的元素就要进行移动，时间复杂度是O（n），解决的方法是循环队列，采用两个front和tail两个变量来维护，队首的元素。


здесь и далее по коду:
- в блоках `case` рекомендуется выравнивать `when` с `case` по уровню отступа
- не очень ясен смысл строки 95 - отстутсвует тело ветви
- лучше не писать сложный код в каждой ветви - более удачный вариант - в каждой из ветвей вызывать метод, куда и перенести код по каждому из вариантов


It is also possible to extend the idea to "almost draws", when instead of `value == VALUE_DRAW` we would say  `abs(value) <= 10` (or whatever the bound).


и кстати не ясно... где определяется локальная переменная `input` ?


价格修改


@flack Would it make sense to have an additional 3.3.4.2 release for this?


also removed applicationinsight as i dont feel its needed here..


Modification required... This is for 3*1 X matrix only


If don't write "Super::BeginPlay();" code, Can't use Actor Tick.


@kleuser75 Fixed https://github.com/R1KO/VIP-Core/commit/463054342b1230d7df7b27f16955c101c29b2a21


in tensorflow@1.10.0 WARNING: "calling reduce_max (from tensorflow.python.ops.math_ops) with keep_dims is deprecated and will be removed in a future version." so need change keep_dims to keepdims


обычно для таких целей (кратковременная, динамически определяемая переменная) используется локальные переменные
если нужно передать значение в другой метод - лучше это сделать явно через аргументы
основное предназначение инстанс-переменных - хранить состояние объекта, т.е. хранить некие аттрибуты, характеристики объекта
можно оставить и так, и работать будет, но не рекомендую


Restored in https://github.com/cBioPortal/cbioportal/pull/4057/commits/776fc8b2526669dad891b77bed0a8d18912fcbc0 in PR https://github.com/cBioPortal/cbioportal/pull/4057 which has the latest feature branch.


Isn't `mRequest != null` redundant? `mRequest instanceof ReadRequest` alone should be enough.


'' -<F2>: F2键盘\''


здесь, и в аналогичных случаях далее по коду использование инстанс-переменной не оправданно
1. уже писал выше про @input
2. насколько я вижу в данном случае использование переменной даже не выходит за рамки этого метода, т.е. значение не нужно нигде, кроме текущего метода - явный признак, что это на самом деле локальная переменная


Yes, you're right. I wasn't aware of this. It will look much cleaner without null checks.


@vAnArhist , this address is right when it is used without bootloader but normally we will use a bootloader. In the uploaded code should be always the by default address that in this case is 0x0800C000. Please change that.


This one is actually used here: https://github.com/verejnedigital/verejne.digital/blob/master/client/src/components/Verejne/PanelRow.js#L14


Amazing, do you plan on making a pull request ?


#158531941-VerticalVenetianBlindCoefficients (vidanovic) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


You could use the main tag here


Wrong


Fixed in 46b82ae24e87271907522e5f85a8607f17479aa6


Done (https://github.com/macports/macports-ports/pull/2384)


@nohanna thx didn't realize that. i've reverted the change for 8.10 branch. Saving a few breaking ng6 changes for 9.x.


searchMovie is a bit vague function name.  It would help quite a lot with a getSearchMovie :)


Automated Test Suite Message


Again searchMovieWithTag is not a super specific name. Maybe getMoviesWithTag. Now its clear that something is returned. I like your use of the functions, the parameters and the things they return really nice!


NICE :) It does EXACTLY what the function name says.


Very nice!


не совсем понял логику теста  - т.е. ты отдаешь туда каки-либо данные и в результате получаешь ТРУ, чтобы не делал метод?


Not a big fan of this function being inside of the resolve of the fetch. This function should be on global scope and then just takes the parameters it needs.


@cpitclaudel What about `abort` being an option that does an `Abort All` *at the end* of the Coq snippet?
So
```
.. coqtop:: in

   Goal True.

.. coqtop:: none

   Abort.
```

becomes

```
.. coqtop:: in abort

   Goal True.
```

It would be especially beneficial compared to `.. coqtop:: undo` when some new definitions / variables are introduced.


This should be
```
if [[ ! -f $gradle_build_file ]]; then
```
I suppose?


Maybe not tag but tagValue or what about ratingValue


NIce :)


Да, неудобно. Тогда, действительно, лучше передавать то, что ячейке сейчас необходимо.


Update app

On Mon, Aug 13, 2018 at 8:41 PM Denis Zharkov <notifications@github.com>
wrote:

> The same problem here.
> And a bit of code duplication
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/JetBrains/kotlin/commit/03817c9113371515c93bfb31e35e6b3e775c5b35#commitcomment-30063448>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AZDnGU6oj-7qCKtM2gGJ5OaAIjwQL1iOks5uQkbPgaJpZM4V7vgR>
> .
>
--
null


![](https://github.trello.services/images/mini-trello-icon.png) [README rework - Group functions](https://trello.com/c/zQp2hVze/153-readme-rework-group-functions)


Cleanup browser


if you want to set sort order by city it can it 'city' or it can be anything from AddresssCollection


감사해요


Hi. Because Milestone was limited by finish at the end of the previous week we used AP-Sinapse version of context engine, communication drivers and sd card driver. Otherwise milestone would take time according to original estimate. Several files from the base code was not compiling and had deeply integrated dependencies for some components that we don't have in current project. FreeRTOS is not necessary and will be removed on these week. It was leaved in the code to speed getting MVP. Also if it is necessary, versions of libraries that was originally in the project could be integrated in current code.


The Object will be resurrected.哈哈哈


제가 감사하죠


Thanks for the catch-up! I'll update it


test comment


期待很久了, 終止有不用root的版本. 最近比較忙, 有空時一定要試一下. 多謝老師的無私奉獻.
請問android系統最低要求是什麼版本?


Tight solution @pankaj28843 :)


good catch


Apart from ${args} change we need to remove `--skip-coulumn_names` for printing Write node info properly.

1.4.9 output
```
Write node info
+----------------+--------------+------+---------+---------+
| hostname       | hostgroup_id | port | weight  | comment |
+----------------+--------------+------+---------+---------+
| 192.168.100.10 | 10           | 3306 | 1000000 | WRITE   |
+----------------+--------------+------+---------+---------+
```

New output.
```
Write node info
192.168.100.10  10      3306    1000000 WRITE
```


@DanielCoulbourne This change broke the dingo/api package. Why was this change necessary?

Is it a valid workaround if I use the old method in the package?
Discussion: dingo/api#1555


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


Since everyone comes to office after having breakfast, we stopped it 😂


Automated Test Suite Message


is test


Any plans on merging and releasing this?


This should be `committed_items`. 🙂


Seems broken:
https://kitchen.haiku-os.org/master/x86_64/buildruns/1846/builds/11468.log

CMake Error at /boot/system/data/cmake/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
  Could NOT find GLEW (missing: GLEW_INCLUDE_DIR GLEW_LIBRARY)


Indentation please! Movie promise does not do anything. It just resolves after a 0 second timeout. Why is this here?


it's dummynet, and I think I have a proper fix.


This is not the response but just the promise.


Very nice chaining!


my first publish of php programing
sorry for rough publish
image:[https://imgur.com/a/w0aSglu](url)

it has 3 link function

・today
・previous month
・next month

use get method
and
color design
・sunday :red
・saturday:blue
・today:bold


Ok, I understand. Anyway I would like to:

- Remove unnecessary code like FreeRTOS
- Use last version of the context engine, at least the communication code (M95 and transport)
- Use original Definitions.h and locales.c to customize the FW instead of parametrizacion.c (Not very important)

I will create tasks for these requirements in order to manage them.

Question:

What files were creating problems? why?


mBot workshop 追加