I think there is something wrong with the 'emulator = conn.emulator()' because after implementing your code, here is what I see:
![image](https://user-images.githubusercontent.com/39150122/45558438-96aee300-b848-11e8-8b64-c090d8a7341e.png)
It looks kind of the rows are not on the right place thing.
Can you check?


The given URL wasn't working, this seems to:
https://help.heroku.com/3Y1HEXGJ/why-doesn-t-ruby-2-3-7-work-in-my-ci-tests


Created multidev environment [rescue-x#oct-18](https://dashboard.pantheon.io/sites/605af1d3-e9e6-4fd7-b8b6-363fcc961427#oct-18).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://oct-18-rescue-x.pantheonsite.io/)


The intention is that you use the defines for everything, so I really need to clean this up a little to get rid of some of the numbers (other than the ones used in the defines of USB_SD_ONBOARD etc.). Really none of this configuration should take place in the pins file, but I'm not really sure how board specific stuff like this should be handled.

Yes the default is odd, but it basically gives you the same configuration as the current 2.0 builds.


I tried to adopt this upgrade in Django 1.11 and was getting 404s since the select2 files aren't held within /admin. Idk if it's just me? I don't see any corresponding changes outside this file that adjust the path for the select2 resources.


Ah, comme c'était dans 2 PR différents, je ne sais plus trop comment j'avais pu vérifier. Cool!


Why is it need to be run in the background? I don't see Redis checkpoint does that. @harlow


Tested I2c backpack on auto.  Auto was not able to read all sensors and process the requirements for the I2c backpack all within a strict time slot.  LCD display will have to continue being wired with regular wiring coming from the controller.


I copy from https://github.com/BlocknetDX/BlockDX/blob/e649db2ad5140474bb4cf26f104f3eafaaf34163/src/xbridge/xbridgeexchange.cpp#L369
It looks like if erase happens here, new order transaction in packet won't have to wait for timer


Back to first version


commit POM.xml to Master


It would be nicer to formulate it as` type_of(capturedPiece ) == QUEEN`


Make a constant of the string that to describe what it is


Oh and if you want to try it with m22 instead of M21 the code that calls it is here:
https://github.com/gloomyandy/Marlin/blob/mysbase/Marlin/src/lcd/ultralcd.cpp#L1165


There is side effect when sending first response directly to snode `hubAddress`, it would not get into https://github.com/BlocknetDX/BlockDX/blob/3807e6a9a45f6ebd9b595225939f11ef65b2d480/src/xbridge/xbridgeapp.cpp#L570

Before it was broadcast, so we need to capture `hubAddress` packets for new orders, otherwise order never is received by service node


Ok thanks ! I did'nt know that


Successfully aliased the URL <https://simple-now-app-isxihefpjt.zeit.sh> to the following alias.

* https://simple-now-app.zeit.sh


You have a typo here.


Thanks @jmroot


TeamCity Bvcms / Build Application [Build 156](https://builds.tpsdb.com/viewLog.html?buildId=354&buildTypeId=Bvcms_BuildApplication) is now running


Just was about to report this... - thanks @fingolfin


Remove this. The database already requires an unique ID and there is already a trait. You would NEVER generate the ID and pass it into the model.


You don't pass in a UUID - it is generated by the model (just like a regular ID)


Successfully aliased the URL <https://simple-now-app-gmiawxsukt.zeit.sh> to the following alias.

* https://simple-now-app.zeit.sh


This pc culture bullshit is getting out of hand...


Created multidev environment [lawhelp#ci-1268](https://dashboard.pantheon.io/sites/9ec12d94-c804-44b7-968e-166a0b49fdc0#ci-1268).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-1268-lawhelp.pantheonsite.io/)


so red is old and green is new? and red delete green add?


Added 3 emojis


The kegg gene is a composite? Because then the number of nodes in the unflatten graph should be 6 right?


:metal: :+1: :1st_place_medal:


I think I have fixed this in 6.2.22.
Thanks for reporting this.


The rule validates that a **name** of the process is not duplicated, and in the case of the Update: it excludes the $existing row.
This change fix the rule, since initially Nolan write `$rules['name'] .= ',' . $existing->uuid . ',uuid';`, but it has a problem, because $existing->uuid is binary, and fails when is has invalid utf8 characters.


It looks like you tried to add "aws-xray-sdk" twice.  Perhaps you meant to add "aws-sdk" and "aws-xray-sdk".

And it looks like you also remove the X-Ray include/require from "DevOps/3_XRay/uni-api/app/read.js" file , when you were fixing the build_response function.


@sasamil - to produce the performance graph I had to play with some code changes, including producing a sub-set of the Tote data for each permutation.

To do that, I had to switch from passing ArrayList objects around to passing List objects.  I've left the change in this code, since it seems architecturally tidier.

Happy to discuss further, if necessary.


Thanks!


Possible, accidental removal of AWS XRay Library in the XRay lab.


merging


закомментированного кода не надо


лучше здесь internalfail


Created multidev environment [ecrac#ci-94](https://dashboard.pantheon.io/sites/1291b6c7-9029-4c6d-867f-caf641f6fade#ci-94).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-94-ecrac.pantheonsite.io/)


I suppose they could be..


while this indeed fixes #8961, it is somewhat inefficient because now you make one additional round through the while loop for almost every single non-empty line (except for the first one and for the ones following an empty line and for the lines more than 1 char shorter than the previous one)...


Troque:
$sql = "INSERT INTO pessoa (nome, endereco, telefone, email, sexo) VALUES(?,?,?,?,?)";
Por:
$sql = ("INSERT INTO pessoa (nome, endereco, telefone, email, sexo) VALUES(?,?,?,?,?)");


Created multidev environment [lawhelp#ci-1270](https://dashboard.pantheon.io/sites/9ec12d94-c804-44b7-968e-166a0b49fdc0#ci-1270).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-1270-lawhelp.pantheonsite.io/)


Немного ошибся в формуле и поэтому перезагрузил


Классный комит!))))


yes that's is what it means **static::$DO_NOT_SEND**, the user and category are not send to the API call.
Since the **assertModelCreationFails** helper uses the factory(Process)->make() to build a temporal array of process attributes, used to call the POST /processes, the factory() populates all the attributes including user and category. Then as you said the Model generates the uuids for each models.


IBM Cloud [toolchain](https://console.ng.bluemix.net/devops/toolchains/053bd62a-c155-46de-8e88-9fa676ecb34a?env_id=ibm%3Ayp%3Aus-south "github-toolchain"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/8934cd2b-705c-436f-a5c1-469f7bee0b13?env_id=ibm%3Ayp%3Aus-south "implantar") deployed [teste-app-java](https://github.com/dmoutinho/teste-app-java/releases/tag/deploy-ibm-yp-us-south-cloud-dmoutinho-development-20180914-153632 "deploy-ibm-yp-us-south-cloud-dmoutinho-development-20180914-153632") to [development](https://console.bluemix.net/apps/ade5a05d-9035-4790-9578-7df38ba7556b?env_id=ibm:yp:us-south "ibm:yp:us-south:cloud-dmoutinho:development"), including this commit


We need to replace "Master" with "teddy bear". and Slave with "Gummy Bear". That way everyone knows not to get offended.


Additianly i sugest to add one in build prop since in some cases values from init dotn get loaded


@Wilfred do you plan to submit this for inclusion in MELPA?


@ruphin I am receiving updates and just saw your last comment about polyfilling String iteration with single index access per character. Is it not going to break apps that iterate on Unicode Strings? For sure, if such an app runs on IE11, it must already include a polyfill, but depending on when webcomponentjs is loading, it may replace the existing polyfill with a "wrong" one and prevent the existing to load since one is already defined.

What do you think about using the polyfill from Mozilla doc?

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/codePointAt#Polyfill

It seems to come from https://github.com/mathiasbynens/String.prototype.codePointAt, which include tests.


Thank you @nicolaasuni. Version 6.2.22 prevents the attack again. 👍


Cool ! Thanks for the improvement.


Arduino FSR giving value of grasping force in handshake


TeamCity Architecture Team :: Java Platform :: otj-metrics :: BuildTest [Build 247](https://teamcity.otenv.com/viewLog.html?buildId=9362066&buildTypeId=ArchitectureTeam_JavaPlatform_OtjMetrics_BuildTest) is now running


TeamCity Architecture Team :: Java Platform :: otj-metrics :: BuildTest [Build 247](https://teamcity.otenv.com/viewLog.html?buildId=9362066&buildTypeId=ArchitectureTeam_JavaPlatform_OtjMetrics_BuildTest) outcome was **SUCCESS**
Summary: Tests passed: 34 Build time: 00:01:02


IBM Cloud [toolchain](https://console.ng.bluemix.net/devops/toolchains/053bd62a-c155-46de-8e88-9fa676ecb34a?env_id=ibm%3Ayp%3Aus-south "github-toolchain"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/8934cd2b-705c-436f-a5c1-469f7bee0b13?env_id=ibm%3Ayp%3Aus-south "implantar") deployed [teste-app-java](https://github.com/dmoutinho/teste-app-java/releases/tag/deploy-ibm-yp-us-south-cloud-dmoutinho-development-20180914-154835 "deploy-ibm-yp-us-south-cloud-dmoutinho-development-20180914-154835") to [development](https://console.bluemix.net/apps/1b4007f6-58de-40de-957a-d0d53aff54a5?env_id=ibm:yp:us-south "ibm:yp:us-south:cloud-dmoutinho:development"), including this commit


- New action types: `APPLICATION_STORE_SET_HIDE_LIBRARY: null`, `APPLICATION_STORE_SET_SEARCH_QUERY: null`, `APPLICATION_STORE_DIRECTORY_SEARCH_UPDATE: null`, `ENTITLEMENT_CODE_REDEEM_SUCCESS: null`,
- User settings section removed: `GAMES`
- New user settings sections: `GAME_ACTIVITY`, `GAME_LIBRARY`
- New overlay event type: `STORAGE_SYNC`
- New analytic location: `URI Scheme`
- New constants:
```js
t.DirectoryLocations = {
    HOME: "1",
    BROWSE: "2"
},
t.StoreApplicationSort = {
    FEATURED: "1",
    NEW_RELEASES: "2",
    BEST_SELLERS: "3",
    ALPHABETICAL: "4",
    REVERSE_ALPHABETICAL: "5",
    PREMIUM: "6"
},
t.StoreApplicationPriceType = {
    PREMIUM: "1",
     DISTRIBUTION: "2",
    COMING_SOON: "3"
}
```

## Endpoints
#### New
- `ENTITLEMENT_REDEEM_CODE: "/users/@me/entitlements/redeem-code"`
- `APPLICATION_STORE_BROWSE: "/store/browse"`
#### Updated
```diff
- USER_ACTIVITY_METADATA: "/users/:user/sessions/:session/activity/metadata"
+ USER_ACTIVITY_METADATA: "/users/:user/sessions/:session/activities/:activity/metadata"
- USER_ACTIVITY_JOIN: "/users/:user/sessions/:session/activity/" + m.JOIN
+ USER_ACTIVITY_JOIN: "/users/:user/sessions/:session/activities/:activity/" + m.JOIN
- USER_ACTIVITY_SPECTATE: "/users/:user/sessions/:session/activity/" + m.SPECTATE
+ USER_ACTIVITY_SPECTATE: "/users/:user/sessions/:session/activities/:activity/" + m.SPECTATE
- USER_ACTIVITY_JOIN_REQUEST: "/users/:user/sessions/:session/activity/" + m.JOIN_REQUEST
+ USER_ACTIVITY_JOIN_REQUEST: "/users/:user/sessions/:session/activities/:activity/" + m.JOIN_REQUEST
- USER_ACTIVITY_JOIN_INVITE: "/users/:user/sessions/:session/activity/" + m.JOIN_REQUEST + "/" + t
+ USER_ACTIVITY_JOIN_INVITE: "/users/:user/sessions/:session/activities/:activity/" + m.JOIN_REQUEST + "/" + t
- STORE_ASSET: "/store/applications/:application/assets/:hash.jpg"
+ STORE_ASSET: "/store/applications/:application/assets/:hash.:filetype"
```

## Strings
#### New
- `GUILD_SETTINGS_AUDIT_LOG_GUILD_AFK_CHANNEL_ID_CLEAR: "**Cleared** the afk channel"`
- `USER_SETTINGS_GAMES_SHORTCUTS: "Game Shortcuts"`
- `USER_SETTINGS_GAMES_SHORTCUTS_DESKTOP: "Create Desktop Shortcut"`
- `USER_SETTINGS_GAMES_SHORTCUTS_DESKTOP_NOTE: "When installing games from the Discord Store."`
- `USER_SETTINGS_GAMES_SHORTCUTS_START_MENU: "Create Start Menu Shortcut"`
- `USER_SETTINGS_GAMES_SHORTCUTS_START_MENU_NOTE: "When installing games from the Discord Store. Also makes your games discoverable via windows search."`
- `USER_SETTINGS_GAME_ACTIVITY: "Game Activity"`
- `USER_SETTINGS_GAME_LIBRARY: "Game Library"`
- `BILLING_APPLICATION_CONSUMABLE_REFUND_TEXT_UNABLE: "In-game content cannot be refunded. If there is an issue with your purchase, [please contact our support.]({supportURL})"`
- `BILLING_REFUND_PLAY_TIME_SUBHEADER: "TIME PLAYED"`
- `BILLING_REFUND_PLAY_TIME_NEVER_PLAYED: "Never played"`
- `BILLING_REDEEM_CODES: "Redeem Codes"`
- `APPLICATION_CONTEXT_MENU_CREATE_DESKTOP_SHORTCUT: "Create Desktop Shortcut"`
- `APPLICATION_UNINSTALL_PROMPT_TITLE: "Uninstall {gameName}?"`
- `APPLICATION_UNINSTALL_PROMPT_BODY: "Say goodbye to all of {gameName}'s data on your computer. Press the red button and it will be no more."`
- `APPLICATION_UNINSTALL_PROMPT_CANCEL: "Nevermind"`
- `APPLICATION_UNINSTALL_PROMPT_CONFIRM: "Uninstall"`
- `APPLICATION_STORE_RESTRICTED: "Unavailable in your region"`
- `APPLICATION_STORE_FREE_TO_PLAY: "Free to play"`
- `APPLICATION_STORE_FREE_PURCHASE_GENERIC_ERROR: "Something went wrong. Please try again later or contact support."`
- `APPLICATION_STORE_FILTER_TYPE_ALL: "all games"`
- `APPLICATION_STORE_FILTER_TYPE_PREMIUM: "all Nitro games"`
- `APPLICATION_STORE_FILTER_TYPE_DISTRIBUTION: "all Store games"`
- `APPLICATION_STORE_BROWSE_BY_TYPE_LABEL: "Browsing:"`
- `APPLICATION_STORE_FILTER_BY_TITLE: "Filter by title"`
- `APPLICATION_STORE_SORT_BY: "Sort by:"`
- `APPLICATION_STORE_HIDE_GAMES_IN_LIBRARY: "Hide games in my library"`
- `APPLICATION_STORE_HOME_FILTERS_FEATURED: "Featured"`
- `APPLICATION_STORE_HOME_FILTERS_NEW_RELEASES: "New Releases"`
- `APPLICATION_STORE_HOME_FILTERS_BEST_SELLERS: "Best Sellers"`
- `APPLICATION_STORE_HOME_VIEW_ALL_APPLICATIONS: "View All Games"`
- `APPLICATION_STORE_HOME_VIEW_ALL_PREMIUM_APPLICATIONS: "View All Nitro Games"`
- `APPLICATION_STORE_HOME_ANNOUNCING_NITRO: "Announcing Nitro"`
- `APPLICATION_STORE_BROWSE: "Browse"`
- `APPLICATION_STORE_BROWSE_SEARCH_PLACEHOLDER: "Search"`
- `APPLICATION_STORE_BROWSE_SORT_NEW_RELEASES: "Newest"`
- `APPLICATION_STORE_BROWSE_SORT_BEST_SELLERS: "Best Sellers"`
- `APPLICATION_STORE_BROWSE_SORT_TITLE_ALPHABETICAL: "Title (A-Z)"`
- `APPLICATION_STORE_BROWSE_SORT_TITLE_REVERSE_ALPHABETICAL: "Title (Z-A)"`
- `APPLICATION_ENTITLEMENT_CODE_REDEMPTION_PROMPT: "Received a code for a game? Enter it below:"`
- `APPLICATION_ENTITLEMENT_CODE_REDEMPTION_REDEEM: "Redeem"`
- `APPLICATION_ENTITLEMENT_CODE_REDEMPTION_INVALID: "Invalid code entered"`
- `APPLICATION_ENTITLEMENT_CODE_REDEMPTION_CONFIRMATION_TITLE: "You got it!"`
- `APPLICATION_ENTITLEMENT_CODE_REDEMPTION_CONFIRMATION_BLURB: "You were granted access to **{skuName}**! Check it out in your library."`
- `APPLICATION_ENTITLEMENT_CODE_REDEMPTION_GO_TO_LIBRARY: "Go to library"`
#### Updated
```diff
- `SETTINGS_GAMES_REMOVED_LIBRARY_APPLICATIONS_LABEL: "Removed Library Games"`
+ `SETTINGS_GAMES_HIDDEN_LIBRARY_APPLICATIONS_LABEL: "Hidden Games"`

- `USER_SETTINGS_GAMES_INSTALL_LOCATIONS: "Game install locations"`
+ `USER_SETTINGS_GAMES_INSTALL_LOCATIONS: "Install locations"`

- `APPLICATION_CONTEXT_MENU_SHOW: "Add to Library"`
- `APPLICATION_CONTEXT_MENU_HIDE: "Remove from Library"`
+ `APPLICATION_CONTEXT_MENU_SHOW: "Show game in Library"`
+ `APPLICATION_CONTEXT_MENU_HIDE: "Hide game from Library"`

- `APPLICATION_STORE_PURCHASE_HEADER_DISTRIBUTION_CONSUMABLE: "Buy Consumable"`
+ `APPLICATION_STORE_PURCHASE_HEADER_DISTRIBUTION_CONSUMABLE: "Buy In-App Item"`

- `APPLICATION_STORE_PURCHASE_HEADER_CONSUMABLES_DIFFERENT: "Consumables"`
- `APPLICATION_STORE_PURCHASE_HEADER_CONSUMABLES_SAME: "More Consumables"`
+ `APPLICATION_STORE_PURCHASE_HEADER_CONSUMABLES_DIFFERENT: "In-App Item"`
+ `APPLICATION_STORE_PURCHASE_HEADER_CONSUMABLES_SAME: "More In-App Items"`

- `APPLICATION_STORE_PURCHASE_HEADER_PREMIUM_APPLICATION: "Get Game"`
- `APPLICATION_STORE_PURCHASE_HEADER_PREMIUM_DLC: "Get DLC"`
- `APPLICATION_STORE_PURCHASE_HEADER_PREMIUM_CONSUMABLE: "Get Consumable"`
- `APPLICATION_STORE_PURCHASE_HEADER_PREMIUM_BUNDLE: "Get Bundle"`
+ `APPLICATION_STORE_PURCHASE_HEADER_FREE_APPLICATION: "Get Game"`
+ `APPLICATION_STORE_PURCHASE_HEADER_FREE_DLC: "Get DLC"`
+ `APPLICATION_STORE_PURCHASE_HEADER_FREE_CONSUMABLE: "Get In-App Item"`
+ `APPLICATION_STORE_PURCHASE_HEADER_FREE_BUNDLE: "Get Bundle"`
```


sda


Thank you @zebastian . It work very well.


![](https://github.trello.services/images/mini-trello-icon.png) [As a User I should able to create basic user profile through the user interface.](https://trello.com/c/FnZ01eFW/1-as-a-user-i-should-able-to-create-basic-user-profile-through-the-user-interface)


Added correct Greenland label. This needs to be deleted in Mapbox


Initial Commit


TeamCity Architecture Team :: Java Platform :: otj-filterorder :: BuildTest [Build 62](https://teamcity.otenv.com/viewLog.html?buildId=9362113&buildTypeId=ArchitectureTeam_JavaPlatform_OtjFilterorder_BuildTest) is now running


TeamCity Architecture Team :: Java Platform :: otj-filterorder :: BuildTest [Build 62](https://teamcity.otenv.com/viewLog.html?buildId=9362113&buildTypeId=ArchitectureTeam_JavaPlatform_OtjFilterorder_BuildTest) outcome was **SUCCESS**
Summary: Tests passed: 7 Build time: 00:00:23


i've tried everything on this one, even tried using the already supplied functions of taskmetadatamodel getall() and it won't call the function.


Created multidev environment [ecrac#ci-95](https://dashboard.pantheon.io/sites/1291b6c7-9029-4c6d-867f-caf641f6fade#ci-95).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-95-ecrac.pantheonsite.io/)


TeamCity Architecture Team :: Java Platform :: otj-kafka :: BuildTest [Build 215](https://teamcity.otenv.com/viewLog.html?buildId=9362117&buildTypeId=ArchitectureTeam_JavaPlatform_OtjKafka_BuildTest) is now running


TeamCity Architecture Team :: Java Platform :: otj-logging :: otj-logging [Build 172](https://teamcity.otenv.com/viewLog.html?buildId=9362118&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_OtjLogging) is now running


siunit_macros (drewyh) - Win64-Windows-7-VisualStudio-14: OK (3006 of 3006 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


Thanks very much!


По моему строки документации надо писать внутри функции


TeamCity Architecture Team :: Java Platform :: otj-kafka :: BuildTest [Build 215](https://teamcity.otenv.com/viewLog.html?buildId=9362117&buildTypeId=ArchitectureTeam_JavaPlatform_OtjKafka_BuildTest) outcome was **SUCCESS**
Summary: Tests passed: 9 Build time: 00:01:15


TeamCity Architecture Team :: Java Platform :: otj-logging :: otj-logging [Build 172](https://teamcity.otenv.com/viewLog.html?buildId=9362118&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_OtjLogging) outcome was **SUCCESS**
Summary: Tests passed: 15 Build time: 00:01:07


New-Feature---Account-for-fan-heat-is-zone-cooling-coils (rraustad) - x86_64-MacOS-10.9-clang: OK (2760 of 3007 tests passed, 20 test warnings)

Messages:

 * 192 tests had: EIO diffs.
 * 30 tests had: ESO small diffs.
 * 240 tests had: Table big diffs.
 * 154 tests had: ESO big diffs.
 * 85 tests had: MTR big diffs.
 * 28 tests had: ERR diffs.
 * 11 tests had: MTR small diffs.
 * 17 tests had: Table small diffs.

Failures:

regression Test Summary
 * Passed: 384
 * Failed: 247

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-91.79%25-yellow.png)


Nope :D Der Methodenname soll beschreiben was darin passiert. Also eher incrementAndReturnCounter.


![](https://github.trello.services/images/mini-trello-icon.png) [Set an age limit on duplicate posts](https://trello.com/c/mhIYBenD/2-set-an-age-limit-on-duplicate-posts)


changed from yesterday


No answers changed, just the verbiage.


genau so :)


TeamCity Architecture Team :: Java Platform :: otj-spring-archetypes :: BuildTest [Build 74](https://teamcity.otenv.com/viewLog.html?buildId=9362143&buildTypeId=ArchitectureTeam_JavaPlatform_OtjSpringArchetypes_Buil) is now running


@pbauer Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.customerize/22/violations
```
plone/app/customerize/testing.py:13:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/customerize/testing.py:16:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/customerize/testing.py:19:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/customerize/registration.py:16:1: I001 isort found an import in the wrong position
plone/app/customerize/registration.py:49:15: P002 found "hasattr", consider replacing it
plone/app/customerize/registration.py:51:11: T000 Todo note found.
plone/app/customerize/registration.py:74:15: T000 Todo note found.
plone/app/customerize/registration.py:112:35: C812 missing trailing comma
plone/app/customerize/registration.py:135:31: C812 missing trailing comma
plone/app/customerize/registration.py:155:7: T000 Todo note found.
plone/app/customerize/tool.py:31:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/customerize/tests/testDocTests.py:31:63: C812 missing trailing comma
plone/app/customerize/tests/testDocTests.py:32:14: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Die Instanz die getestet werde nenne ich immer `systemUnderTest`. Damit ist ueberall klar welches Objekt getestet wird und es vermeidet Sachen wir Counter.countCounter


TeamCity Architecture Team :: Java Platform :: otj-spring-archetypes :: BuildTest [Build 74](https://teamcity.otenv.com/viewLog.html?buildId=9362143&buildTypeId=ArchitectureTeam_JavaPlatform_OtjSpringArchetypes_Buil) outcome was **SUCCESS**
Summary: Running Build time: 00:01:16


The MobilityBonus already contains mobiity values for mob=0, 1,2, 3, 4 etc
You should make your changes directly there instead of adding unnecessary complexity.

The bishop mobiity values are
```
{ S(-48,-59), S(-20,-23), S( 16, -3), S( 26, 13), S( 38, 24), S( 51, 42), // Bishops
      S( 55, 54), S( 63, 57), S( 63, 65), S( 68, 73), S( 81, 78), S( 81, 86),
      S( 91, 88), S( 98, 97) },
```

So this test, for example, would be the same as
```
{ S(-48-8,-59), S(-20-8,-23), S( 16-8, -3), S( 26-8, 13), S( 38-8, 24), S( 51+4, 42), // Bishops
      S( 55+4, 54), S( 63+4, 57), S( 63+4, 65), S( 68+4, 73), S( 81+4, 78), S( 81+4, 86),
      S( 91+4, 88), S( 98+4, 97) },
```

However, random changes like this are not likely to work.


Hier ist der Variablenname etwas ungluecklich. Der Test erwartet nicht dass der Wert zufaellig ist (wie es der Variablenname vermuten lassen koennte), sondern dass der Startwert gesetzt ist.


@typingArtist I see that you removed the `(* parallel case *)` Verilog attribute.

There are tools (including Yosys) that only support parallel case this way, and not with the // synopsys case.

If there are tools that don't like this, there should  an option to generate one or the other.

Tom


-_- BOI


This function is not necessary as anyone can always know anyone else's balance.


New-Feature---Account-for-fan-heat-is-zone-cooling-coils (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (2379 of 2379 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-71.75%25-green.png)


This `withdrawnFunds` has no attached logic. It's only a historical value. It is difficult to justify its presence, and cost, in the contract code.


Hier hast du schon ein Anti-Pattern entdeckt, naemlich Tests die voneinander abhaengig sind. Wird der erste Test nicht ausgefuehrt, dann schlaegt der Zweite fehl.

Besser: Verschiebe die Initialisierung aus Zeile 4/5 in die Tests oder in eine beforeEach Methode (dazu mehr im Jest Video). Damit hast du in jedem Test eine frische Instanz. Der erste Test kann dann so bleiben, der zweite ruft zwei mal die countCounter auf, erwartet beim ersten Mal den Startwert und bei jedem weiteren Aufruf einen um 1 erhoehten Wert.


New-Feature---Account-for-fan-heat-is-zone-cooling-coils (rraustad) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


Du kannst Zeilen 6-8 zu `return this._value++;` zusammenfassen, da ein `variable++` den Wert erst nach dem Lesen erhoeht. `++variable` ist das Gegenstueck dazu.


@tubbo How is minitest coming along?


No problem here:

```
Successfully built 3063495db50e
Successfully tagged dachs:chbrandt
Creating myPostgres ... done
Creating myDachs    ... done
Attaching to myPostgres, myDachs
myPostgres  |
myPostgres  | ===================================================
myPostgres  | This is the PostgreSQL counterpart of DaCHS server.
myPostgres  | Unless you want to put your hands on the databse,
myPostgres  | you should be good to go and deal with the DaCHS
myPostgres  | server main conatiner itself.
myPostgres  |
myPostgres  | To make use of this guy here, just make sure to
myPostgres  | run "dachs:server" with docker "--link" option
myPostgres  | pointing to this container here.
myPostgres  | ===================================================
myPostgres  |
myPostgres  | 2018-09-14 15:47:20 UTC [11-1] LOG:  redirecting log output to logging collector process
myPostgres  | 2018-09-14 15:47:20 UTC [11-2] HINT:  Future log output will appear in directory "pg_log".
myDachs     |
myDachs     | ================================================
myDachs     | This the (main) DaCHS server container, where
myDachs     | DaCHS daemon is meant to run.
myDachs     | This container expects to use another container
myDachs     | as the PostgreSQL databse server.
myDachs     |
myDachs     | The Postgres container must be named *postgres*.
myDachs     | Using the proper name will make the connection
myDachs     | "just work".
myDachs     |
myDachs     | Apart from that restriction, DaCHS management
myDachs     | proceed as usual (imp, pub, etc.).
myDachs     | ================================================
myDachs     |
myDachs     | Waiting for postgres to come up...
myDachs     | /usr/lib/python2.7/dist-packages/gavo/base/config.py:539: UserWarning: /var/gavo/etc/defaultmeta.txt does not exist, registry interface  will be broken
myDachs     |   srcPath)
```


Yes! It is here only for clarity, to complete the set: receivedFunds(), unsplittedFunds(), remainingFunds()


Just "parent relationship"


Because you do the split at withdraw time you are reduced to doing some acrobatics using `this.balance`, which is not advised.
Instead, split right when you receive the funds, like this you only care about `msg.value`.


@harlow Thank you!


How is the project timeline coming along.


@paneq this sounds super familiar; see https://github.com/mbj/mutant#the-crash--stuck-problem-mri

Do you have a stable reproduction?


Re-added, had time to fix it


I think it would be more readable if you:

```solidity
else if (msg.sender == partyB) {
} else {
    revert();
}
```


@smokills :
No, in core 2.0 Object will be renamed as Structure.
Please fix this commit for compatibility with future version.


Oh oh oh. Yeah ok. sorry


Should this line just be removed?


Better emit the event before the transfer:

* you protect yourself from yet-unknown re-entrance attack
* the events will be emitted in the right order if the recipient also emits


@paneq Especially can you try this one: https://github.com/mbj/mutant/issues/265#issuecomment-61018644


@harlow The error that might be occurred is not handled here. What do you think if we provide an error channel so the consumer knows what to do if the checkpoint throws an error?


How hard is this to fix?


test


If you remove the `await`, does it still work? I think so, this is not a promisified call, but a sync' one.


You should use your promisified `.eth.getTransactionPromise(`.


`const txCost`


`const txDetails = `.


yt


I think this creates 3 global variables because they are not declared beforehand.


By the way, I guess we should put minerWallets into Map.


do file


1 Ether is a big amount in a test. More readable `web3.toWei(1)`.


Yes!
I had done as you said in the commit https://github.com/mriccobene/b9lab_splitter/commit/614e3cb7b5d4309a25be6518b1353a80006d4ccd
Then I redesigned the contract to have a fallback function that consumes less than 2300 gas so I can use the splitter whenever I use an external owning address. Is this is a wrong idea?


Also here used the promisified version.


> I just loved it so much that i Put it on Poggit.

Poggit is not Facebook. You don't put plugins on Poggit just because you love it.

If you want it to be available on Poggit, you should ask the original authors @GiantQuartz @room17 to release it on Poggit.


`assert.equal(user2BalanceEnd.toString(), user2BalanceStart.toString())` and the error message will be more readable.


This change couples function state to scope. Before I was able to noop out scope methods to avoid unneeded overhead but now it looks like scope iteration is required to see if we're in a function (async, generator, otherwise).


Why?


This commit broke the app.
`Neo-Sharp

Unhandled Exception: System.AggregateException: One or more errors occurred. (Value cannot be null.
Parameter name: currentBlock) ---> System.ArgumentNullException: Value cannot be null.
Parameter name: currentBlock
   at NeoSharp.Core.Blockchain.Processing.BlockProcessor.Run(Block currentBlock) in /repo/neo-sharp/src/NeoSharp.Core/Blockchain/Processing/BlockProcessor.cs:line 52
   at NeoSharp.Core.Blockchain.Blockchain.InitializeBlockchain() in /repo/neo-sharp/src/NeoSharp.Core/Blockchain/Blockchain.cs:line 67
   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at NeoSharp.Application.Client.Prompt.StartPrompt(String[] args) in /repo/neo-sharp/src/NeoSharp.Application/Client/Prompt.cs:line 136
   at NeoSharp.Application.Program.Main(String[] args) in /repo/neo-sharp/src/NeoSharp.Application/Program.cs:line 28
Aborted (core dumped)`


That the fallback uses less 2300 gas is less important in our exercise. You can even block it off.


Oops:

```
Successfully built f455b9c9616f
Successfully tagged dachs:chbrandt
Creating myPostgres ... done
Creating myDachs    ... done
Attaching to myPostgres, myDachs
myPostgres  |
myPostgres  | ===================================================
myPostgres  | This is the PostgreSQL counterpart of DaCHS server.
myPostgres  | Unless you want to put your hands on the databse,
myPostgres  | you should be good to go and deal with the DaCHS
myPostgres  | server main conatiner itself.
myPostgres  |
myPostgres  | To make use of this guy here, just make sure to
myPostgres  | run "dachs:server" with docker "--link" option
myPostgres  | pointing to this container here.
myPostgres  | ===================================================
myPostgres  |
myPostgres  | 2018-09-14 16:03:27 UTC [11-1] LOG:  redirecting log output to logging collector process
myPostgres  | 2018-09-14 16:03:27 UTC [11-2] HINT:  Future log output will appear in directory "pg_log".
myDachs     |
myDachs     | ================================================
myDachs     | This the (main) DaCHS server container, where
myDachs     | DaCHS daemon is meant to run.
myDachs     | This container expects to use another container
myDachs     | as the PostgreSQL databse server.
myDachs     |
myDachs     | The Postgres container must be named *postgres*.
myDachs     | Using the proper name will make the connection
myDachs     | "just work".
myDachs     |
myDachs     | Apart from that restriction, DaCHS management
myDachs     | proceed as usual (imp, pub, etc.).
myDachs     | ================================================
myDachs     |
myDachs     | Waiting for postgres to come up...
myDachs     | /usr/lib/python2.7/dist-packages/gavo/base/config.py:600: UserWarning: /var/gavo/etc/defaultmeta.txt does not exist, registry interface  will be broken
myDachs     |   srcPath)
myDachs     | /usr/lib/python2.7/dist-packages/gavo/user/initdachs.py:315: UserWarning: SQL script file for /usr/share/postgresql/contrib/q3c.sql not found.  There are many reasons why that may be ok, but unless you know what you are doing, you probably should install the corresponding postgres extension.
myDachs     |   " extension."%scriptPath)
myDachs     | /usr/lib/python2.7/dist-packages/gavo/user/initdachs.py:332: UserWarning: SQL script file /usr/share/postgresql/contrib/q3c.sql failed.  Try running manually using psql.  While it hasn't run, the q3c extension is not available.
myDachs     |   " available."%(scriptPath, sourceName))
myDachs     | Traceback (most recent call last):
myDachs     |   File "/usr/bin/gavo", line 11, in <module>
myDachs     |     load_entry_point('gavodachs==1.2', 'console_scripts', 'gavo')()
myDachs     |   File "/usr/lib/python2.7/dist-packages/gavo/user/cli.py", line 151, in main
myDachs     |     sys.exit(initdachs.main())
myDachs     |   File "/usr/lib/python2.7/dist-packages/gavo/user/initdachs.py", line 455, in main
myDachs     |     initDB(dsn)
myDachs     |   File "/usr/lib/python2.7/dist-packages/gavo/user/initdachs.py", line 428, in initDB
myDachs     |     _importBasicResources()
myDachs     |   File "/usr/lib/python2.7/dist-packages/gavo/user/initdachs.py", line 415, in _importBasicResources
myDachs     |     importing.process(rsc.getParseOptions(), [rdId])
myDachs     |   File "/usr/lib/python2.7/dist-packages/gavo/user/importing.py", line 111, in process
myDachs     |     res = api.makeData(dd, parseOptions=opts, connection=connection)
myDachs     |   File "/usr/lib/python2.7/dist-packages/gavo/rsc/data.py", line 466, in makeData
myDachs     |     processSource(res, forceSource, feeder, parseOptions, connection)
myDachs     |   File "/usr/lib/python2.7/dist-packages/gavo/rsc/data.py", line 195, in __exit__
myDachs     |     self._exitSuccess()
myDachs     |   File "/usr/lib/python2.7/dist-packages/gavo/rsc/data.py", line 178, in _exitSuccess
myDachs     |     feeder.__exit__(None, None, None)
myDachs     |   File "/usr/lib/python2.7/dist-packages/gavo/rsc/dbtable.py", line 104, in __exit__
myDachs     |     table._Feeder.__exit__(self, *args)
myDachs     |   File "/usr/lib/python2.7/dist-packages/gavo/rsc/table.py", line 146, in __exit__
myDachs     |     self.table.importFinished()
myDachs     |   File "/usr/lib/python2.7/dist-packages/gavo/rsc/dbtable.py", line 402, in importFinished
myDachs     |     self.runScripts("postCreation")
myDachs     |   File "/usr/lib/python2.7/dist-packages/gavo/rsc/table.py", line 252, in runScripts
myDachs     |     self._runScripts(self, phase, **kwargs)
myDachs     |   File "/usr/lib/python2.7/dist-packages/gavo/rscdef/scripting.py", line 252, in runScripts
myDachs     |     runner.run(table, **kwargs)
myDachs     |   File "/usr/lib/python2.7/dist-packages/gavo/rscdef/scripting.py", line 118, in run
myDachs     |     dbTable.query(statement.replace("%", "%%"))
myDachs     |   File "/usr/lib/python2.7/dist-packages/gavo/rsc/dbtable.py", line 581, in query
myDachs     |     return DBMethodsMixin.query(self, query, data)
myDachs     |   File "/usr/lib/python2.7/dist-packages/gavo/base/sqlsupport.py", line 901, in query
myDachs     |     self.connection.execute(query, data)
myDachs     |   File "/usr/lib/python2.7/dist-packages/gavo/base/sqlsupport.py", line 322, in execute
myDachs     |     cursor.execute(query, args)
myDachs     | psycopg2.ProgrammingError: type spoint does not exist
myDachs     |
```


![](https://github.trello.services/images/mini-trello-icon.png) [Rename DriverHelper](https://trello.com/c/lsBFTVYE/15-rename-driverhelper)


Do we know the perf hit for switching to getters for this?


Какую бд ты тут предполагаешь? Лучше в явном виде указать mysql


I find a way to answer my first question @guillep ;)


а активировать venv?


cool


Hello.
Can you help me?
I use the Libvlc3.0.4 library for my music player, I have developed it on C # .net.
All the functions I expect have finished and run very well. But I need more "height change module" to use it. But I did not find any functionality in libvlc to do that.
Can you guide me?
I think in libvlc3.0.4 did not update this function. But the Vlc Player application has been updated and used. Can you and development team update this functionality into Libvlc3.0.5 in the next release?
Thank you!


What this PR does / why we need it: Add additional documentation to TCP/UPD proxy support in ingress.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:  The need to define a port on the Ingress Service was not immediately obvious, at-least to me and various hits on Google indicated that other people were seeing the behavior of not being able to reach the proxied port.

This was tested and confirmed working on a bare metal cluster using metallb and ingress-nginx.


I like the name of the commit! 😄


what's the reasoning for starting ids at 1?


> Dear @KhoaGamingVN:
> I regret to inform you that the release you submitted, named "**KeepInventory**" (v1.1), for the project [KeepInventory](https://poggit.pmmp.io/ci/KhoaGamingVN/KeepInventory/KeepInventory) on 2018-09-10T01:50:30.000Z, has been rejected.

"Some changes" is an invalid changelog. In addition, the change is wrong; please test it. See this page for reference: https://stackoverflow.com/q/21343646/3990767

> Please resolve the issues listed above and submit the updated plugin again.
> Note: This comment is created here because this is the last commit when the released build was created.


That was blazingly fast!

But I think:

  'ebup'  => 'application/epub+zip',

ebup should be epub
I


Eh. I'd inherit from std::runtime_error so you don't have to define any of this (though you'll have to use what() instead of message())


oo_plant_load_profile (drewyh) - i386-Windows-7-VisualStudio-14: OK (3006 of 3006 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


👍 Happy to help!


# أنماط لتجاهل عند بناء الحزم.
# هذا يدعم مطابقة glob shell ومسار المسار النسبي و
# نفي (مسبوقة بـ!). نمط واحد فقط لكل سطر.
.DS_Store
. بوابة


You could save serious gas by saving `remittanceStructs[msg.sender].amount` into a variable instead of reading it 3 times.


I can steal from your contract until it is empty. Can you find how?


the nav header is sitting right against the browser ceiling.  lowering it  a little could improve its visibility.


![](https://github.trello.services/images/mini-trello-icon.png) [Разобраться с классами в выписке баллов](https://trello.com/c/xJPqdBZw/27-%D1%80%D0%B0%D0%B7%D0%BE%D0%B1%D1%80%D0%B0%D1%82%D1%8C%D1%81%D1%8F-%D1%81-%D0%BA%D0%BB%D0%B0%D1%81%D1%81%D0%B0%D0%BC%D0%B8-%D0%B2-%D0%B2%D1%8B%D0%BF%D0%B8%D1%81%D0%BA%D0%B5-%D0%B1%D0%B0%D0%BB%D0%BB%D0%BE%D0%B2)


Created multidev environment [ecrac#ci-98](https://dashboard.pantheon.io/sites/1291b6c7-9029-4c6d-867f-caf641f6fade#ci-98).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-98-ecrac.pantheonsite.io/)


You don't need this function because you already made the mapping public.


No longer used.


Why use `web3.eth.accounts` when you have: `module.exports = function(deployer, network, accounts) {`


IBM Cloud [toolchain](https://console.ng.bluemix.net/devops/toolchains/32fead6c-aeed-4efb-a3ce-ce71df79b27e?env_id=ibm%3Ayp%3Aus-south "cloud-native-toolchain-tutorial-20180914111522678"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/2c6e7459-e954-438e-b51a-3e98d83cebf6?env_id=ibm%3Ayp%3Aus-south "sample-cloud-native-toolchain-tutorial-20180914111522678") deployed [sample-cloud-native-toolchain-tutorial-20180914111522678](https://github.com/RobMariano/sample-cloud-native-toolchain-tutorial-20180914111522678/releases/tag/deploy-ibm-yp-us-south-rmariano-us.ibm.com-dev-20180914-163000 "deploy-ibm-yp-us-south-rmariano-us.ibm.com-dev-20180914-163000") to [dev](https://console.bluemix.net/apps/3bf46806-981c-4e27-9306-bc3228c5e717?env_id=ibm:yp:us-south "ibm:yp:us-south:rmariano@us.ibm.com:dev"), including this commit


`.then(function(txObj) {`. Don't throw this piece of info.


Can you flatten the promise chain?


I'd expect it to be positive, since we're doing a lot less work setting and restoring flags, but I didn't measure.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


Use smaller amounts in tests. `.toWei(10, "finney")` for instance.


Use `const etherToSeed`.


@mmoskal I think you've merged some pktserial branch stuff into this repo's master? (these functions only exist in https://github.com/lancaster-university/codal-core/tree/pktserial/)


Not really sure about that one


Thanks! That should make these more broadly applicable.


Aren't we merging pkt serial into master soon?


delete test


need to handle large strings (either larger array or allocate)


Resolves https://github.com/hedgehoglabs/xor/issues/6


True enough, I'll ignore the travis emails 😃


Created multidev environment [ecrac#ci-99](https://dashboard.pantheon.io/sites/1291b6c7-9029-4c6d-867f-caf641f6fade#ci-99).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-99-ecrac.pantheonsite.io/)


Created multidev environment [newupstream#ci-363](https://dashboard.pantheon.io/sites/8be50dbc-4463-43b5-bd18-d83046623820#ci-363).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-363-newupstream.pantheonsite.io/)


for both the value_array and node_array, add a kill to make sure that we are within the array bounds


we should start documenting our systems, eg this.


This shouldn't be needed.


Removing this __shouldn't__ be needed either


space before (


Cool. I'm guessing once usage of v6 picks up if there's a notable hit folks will pop-in.


space before if


Good catch, that is embarrassingly bad, thank you. I am traveling but when I get back home I will fix that.


Find out, if


space before }


Created multidev environment [newupstream#ci-364](https://dashboard.pantheon.io/sites/8be50dbc-4463-43b5-bd18-d83046623820#ci-364).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-364-newupstream.pantheonsite.io/)


thanks for this 👍


Created multidev environment [ecrac#ci-101](https://dashboard.pantheon.io/sites/1291b6c7-9029-4c6d-867f-caf641f6fade#ci-101).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-101-ecrac.pantheonsite.io/)


needed -> required, have gotten -> have been


object Main extends App{
    val iterator = Iterator
    .from(1)
  .take(100)

  iterator
    .take(1)
    .foreach(println)

  println(iterator.isEmpty)

  iterator.take(1).foreach(println)
}
,2.11,2.12 and 2.13 return different result


Successfully aliased the URL <https://simple-now-app-eyvzezrrxc.zeit.sh> to the following alias.

* https://simple-now-app.zeit.sh


@marijnh Does this mean you're not worried about ES3 compatibility anymore? Even with transpilation getters are going to rely on ES5+ APIs.


We do not need to ...


import { ActivatedRoute } from '@angular/router';
import { CategoryService } from './../category.service';
import { ProductService } from './../product.service';
import { Component, OnInit } from '@angular/core';

@Component({
  selector: 'app-products',
  templateUrl: './products.component.html',
  styleUrls: ['./products.component.css']
})
export class ProductsComponent implements OnInit {

  products: Product[];
  filteredProducts: Product[];
  categories$;
  category: string;
  constructor(private productService: ProductService, private categoryService: CategoryService, route: ActivatedRoute) {
    productService.getAll().subscribe(products =>{
      this.products = products;
    });
    this.categories$ = this.categoryService.getAll();

    route.queryParamMap.subscribe(parms =>{
      this.category = parms.get('category');
      this.filteredProducts = (this.category) ? this.products.filter(p=>p.category == this.category) :
      this.products;
    });
  }

  ngOnInit() {
  }

}


This is first commit


Fumbling a little


@milicag It looks like you overwrote my edits from https://github.com/lbl-srg/obc/commit/9554e96f951e2f82bf99032981820adda8b37d69. I will change it back and try to integrate your text as far as possible.


yeah, good idea. wanna send a pull request?


Created multidev environment [ecrac#ci-104](https://dashboard.pantheon.io/sites/1291b6c7-9029-4c6d-867f-caf641f6fade#ci-104).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-104-ecrac.pantheonsite.io/)


@vladzamfir clean up your unused imports <3


a


Collaborator: Review for this commit was created. [Link to review](https://localhost:8443/ui#review:id=1)


Collaborator cannot find remote user mapping for author


@benoitf Do you think it is safe to call `WorkspaceManager.update()` here ?


@benoitf Do you think it is safe to call `WorkspaceDao.update()` here ?


Looks like some white space/alignment issues here


ok later i try to fork and do it

can i also send a PR for translating the strings to italian?


`private`? I am pretty sure this is vital information for players.


@maxtaco I committed this by mistake as part of another PR, are you ok with the changes to this file? (sig_chain.go)


[R/clusDropVar2.R:21:13:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/clusDropVar2.R#L21) *style:* **Commas should never have a space before.**
```r
  vte = c() ,
           ~^
```
[R/clusDropVar2.R:41:29:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/clusDropVar2.R#L41) *style:* **Commas should always have a space after.**
```r
        ddm1 <- dudi.mix(x[,vtu1[-i]], add.square = FALSE, scannf = F, nf = ncol(x))
                            ^
```
[R/clusDropVar2.R:51:34:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/clusDropVar2.R#L51) *style:* **Commas should always have a space after.**
```r
          pam1 <- clara(ddm1$li[,1:length(ddm1$eig[ddm1$eig > 1])], k = j, samples = 50)
                                 ^
```
[R/clusDropVar2.R:57:44:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/clusDropVar2.R#L57) *style:* **Commas should always have a space after.**
```r
            print(paste("i: ", i, " | k: ",j," | sil: ",sil1, " | var: ",vtu1[i], sep = ""));flush.console()
                                           ^
```
[R/clusDropVar2.R:57:46:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/clusDropVar2.R#L57) *style:* **Commas should always have a space after.**
```r
            print(paste("i: ", i, " | k: ",j," | sil: ",sil1, " | var: ",vtu1[i], sep = ""));flush.console()
                                             ^
```
[R/clusDropVar2.R:57:57:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/clusDropVar2.R#L57) *style:* **Commas should always have a space after.**
```r
            print(paste("i: ", i, " | k: ",j," | sil: ",sil1, " | var: ",vtu1[i], sep = ""));flush.console()
                                                        ^
```
[R/clusDropVar2.R:57:74:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/clusDropVar2.R#L57) *style:* **Commas should always have a space after.**
```r
            print(paste("i: ", i, " | k: ",j," | sil: ",sil1, " | var: ",vtu1[i], sep = ""));flush.console()
                                                                         ^
```
[R/clusDropVar2.R:71:109:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/clusDropVar2.R#L71) *style:* **Commas should always have a space after.**
```r
      print(paste("Dropping var: ", varToDrop, " | Best Score : ", max(scores1Df$score), " | vtu1 length: ",length(vtu1) , sep = ""));flush.console()
                                                                                ^
```
[R/clusDropVar2.R:71:122:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/clusDropVar2.R#L71) *style:* **Commas should never have a space before.**
```r
      print(paste("Dropping var: ", varToDrop, " | Best Score : ", max(scores1Df$score), " | vtu1 length: ",length(vtu1) , sep = ""));flush.console()
                                                                                ~^
```
[R/cnn.R:13:19:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/cnn.R#L13) *style:* **Commas should always have a space after.**
```r
    print(paste(i,": ", colnames(dataset)[i], " | ", class(dataset[,i]), sep=""))
                  ^
```
[R/cnn.R:13:69:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/cnn.R#L13) *style:* **Commas should always have a space after.**
```r
    print(paste(i,": ", colnames(dataset)[i], " | ", class(dataset[,i]), sep=""))
                                                                    ^
```
[R/cnn.R:13:77:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/cnn.R#L13) *style:* **Put spaces around all infix operators.**
```r
    print(paste(i,": ", colnames(dataset)[i], " | ", class(dataset[,i]), sep=""))
                                                                           ~^~
```
[R/convert_date.R:36:3:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/convert_date.R#L36) *style:* **Variable and function names should not use underscores.**
```r
  dateind_a <- names(xx[sapply(xx,function(x)is(x,"POSIXct"))])
  ^~~~~~~~~
```
[R/convert_date.R:36:35:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/convert_date.R#L36) *style:* **Commas should always have a space after.**
```r
  dateind_a <- names(xx[sapply(xx,function(x)is(x,"POSIXct"))])
                                  ^
```
[R/convert_date.R:36:51:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/convert_date.R#L36) *style:* **Commas should always have a space after.**
```r
  dateind_a <- names(xx[sapply(xx,function(x)is(x,"POSIXct"))])
                                                  ^
```
[R/convert_date.R:37:3:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/convert_date.R#L37) *style:* **Variable and function names should not use underscores.**
```r
  dateind_b <- names(xx[sapply(xx,function(x)is(x,"POSIXt"))])
  ^~~~~~~~~
```
[R/convert_date.R:37:35:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/convert_date.R#L37) *style:* **Commas should always have a space after.**
```r
  dateind_b <- names(xx[sapply(xx,function(x)is(x,"POSIXt"))])
                                  ^
```
[R/convert_date.R:37:51:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/convert_date.R#L37) *style:* **Commas should always have a space after.**
```r
  dateind_b <- names(xx[sapply(xx,function(x)is(x,"POSIXt"))])
                                                  ^
```
[R/convert_date.R:38:23:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/convert_date.R#L38) *style:* **Variable and function names should not use underscores.**
```r
  dateind <- unique(c(dateind_a, dateind_b))
                      ^~~~~~~~~
```
[R/convert_date.R:38:34:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/convert_date.R#L38) *style:* **Variable and function names should not use underscores.**
```r
  dateind <- unique(c(dateind_a, dateind_b))
                                 ^~~~~~~~~
```
[R/convert_date.R:40:7:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/convert_date.R#L40) *style:* **Only use double-quotes.**
```r
  cat('found ',length(dateind), ' dates : \n' )
      ^~~~~~~~
```
[R/convert_date.R:40:16:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/convert_date.R#L40) *style:* **Commas should always have a space after.**
```r
  cat('found ',length(dateind), ' dates : \n' )
               ^
```
[R/convert_date.R:40:33:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/convert_date.R#L40) *style:* **Only use double-quotes.**
```r
  cat('found ',length(dateind), ' dates : \n' )
                                ^~~~~~~~~~~~~
```
[R/convert_date.R:41:18:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/convert_date.R#L41) *style:* **Commas should always have a space after.**
```r
  lapply(dateind,function(x) cat(x,' --- \n'))
                 ^
```
[R/convert_date.R:41:36:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/convert_date.R#L41) *style:* **Commas should always have a space after.**
```r
  lapply(dateind,function(x) cat(x,' --- \n'))
                                   ^
```
[R/convert_date.R:41:36:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/convert_date.R#L41) *style:* **Only use double-quotes.**
```r
  lapply(dateind,function(x) cat(x,' --- \n'))
                                   ^~~~~~~~~
```
[R/convert_date.R:43:7:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/convert_date.R#L43) *style:* **Commas should always have a space after.**
```r
  xx[,dateind] <- data.frame(lapply(dateind,function(x) as.Date(xx[,x])))
      ^
```
[R/convert_date.R:43:45:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/convert_date.R#L43) *style:* **Commas should always have a space after.**
```r
  xx[,dateind] <- data.frame(lapply(dateind,function(x) as.Date(xx[,x])))
                                            ^
```
[R/convert_date.R:43:69:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/convert_date.R#L43) *style:* **Commas should always have a space after.**
```r
  xx[,dateind] <- data.frame(lapply(dateind,function(x) as.Date(xx[,x])))
                                                                    ^
```
[R/convert_date.R:47:1:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/convert_date.R#L47) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/convert_date.R:48:1:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/convert_date.R#L48) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/convert_date.R:49:1:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/convert_date.R#L49) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/convert_date.R:50:1:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/convert_date.R#L50) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/convert_date.R:51:1:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/convert_date.R#L51) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/convert_date.R:52:1:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/convert_date.R#L52) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/exportGBMtoPDF.R:16:28:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L16) *style:* **Variable and function names should not use underscores.**
```r
exportGBMtoPDF <- function(gbm_object,file_path,file_name){
                           ^~~~~~~~~~
```
[R/exportGBMtoPDF.R:16:39:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L16) *style:* **Commas should always have a space after.**
```r
exportGBMtoPDF <- function(gbm_object,file_path,file_name){
                                      ^
```
[R/exportGBMtoPDF.R:16:39:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L16) *style:* **Variable and function names should not use underscores.**
```r
exportGBMtoPDF <- function(gbm_object,file_path,file_name){
                                      ^~~~~~~~~
```
[R/exportGBMtoPDF.R:16:49:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L16) *style:* **Commas should always have a space after.**
```r
exportGBMtoPDF <- function(gbm_object,file_path,file_name){
                                                ^
```
[R/exportGBMtoPDF.R:16:49:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L16) *style:* **Variable and function names should not use underscores.**
```r
exportGBMtoPDF <- function(gbm_object,file_path,file_name){
                                                ^~~~~~~~~
```
[R/exportGBMtoPDF.R:17:12:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L17) *style:* **Variable and function names should not use underscores.**
```r
  if(class(gbm_object) != "gbm")
           ^~~~~~~~~~
```
[R/exportGBMtoPDF.R:19:12:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L19) *style:* **Variable and function names should not use underscores.**
```r
  if(class(file_path) != "character")
           ^~~~~~~~~
```
[R/exportGBMtoPDF.R:21:12:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L21) *style:* **Variable and function names should not use underscores.**
```r
  if(class(file_name) != "character")
           ^~~~~~~~~
```
[R/exportGBMtoPDF.R:23:9:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L23) *style:* **Put spaces around all infix operators.**
```r
  sgbm1 <-summary(gbm_object)
        ^~~
```
[R/exportGBMtoPDF.R:23:19:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L23) *style:* **Variable and function names should not use underscores.**
```r
  sgbm1 <-summary(gbm_object)
                  ^~~~~~~~~~
```
[R/exportGBMtoPDF.R:24:13:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L24) *style:* **Variable and function names should not use underscores.**
```r
  if(substr(file_name,nchar(file_name)-4+1,nchar(file_name)) == ".pdf") {
            ^~~~~~~~~
```
[R/exportGBMtoPDF.R:24:23:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L24) *style:* **Commas should always have a space after.**
```r
  if(substr(file_name,nchar(file_name)-4+1,nchar(file_name)) == ".pdf") {
                      ^
```
[R/exportGBMtoPDF.R:24:29:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L24) *style:* **Variable and function names should not use underscores.**
```r
  if(substr(file_name,nchar(file_name)-4+1,nchar(file_name)) == ".pdf") {
                            ^~~~~~~~~
```
[R/exportGBMtoPDF.R:24:39:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L24) *style:* **Put spaces around all infix operators.**
```r
  if(substr(file_name,nchar(file_name)-4+1,nchar(file_name)) == ".pdf") {
                                     ~^~
```
[R/exportGBMtoPDF.R:24:41:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L24) *style:* **Put spaces around all infix operators.**
```r
  if(substr(file_name,nchar(file_name)-4+1,nchar(file_name)) == ".pdf") {
                                       ~^~
```
[R/exportGBMtoPDF.R:24:44:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L24) *style:* **Commas should always have a space after.**
```r
  if(substr(file_name,nchar(file_name)-4+1,nchar(file_name)) == ".pdf") {
                                           ^
```
[R/exportGBMtoPDF.R:24:50:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L24) *style:* **Variable and function names should not use underscores.**
```r
  if(substr(file_name,nchar(file_name)-4+1,nchar(file_name)) == ".pdf") {
                                                 ^~~~~~~~~
```
[R/exportGBMtoPDF.R:25:15:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L25) *style:* **Variable and function names should not use underscores.**
```r
    pdf(paste(file_path,file_name,sep = "\\"),height = 11, width = 10)
              ^~~~~~~~~
```
[R/exportGBMtoPDF.R:25:25:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L25) *style:* **Commas should always have a space after.**
```r
    pdf(paste(file_path,file_name,sep = "\\"),height = 11, width = 10)
                        ^
```
[R/exportGBMtoPDF.R:25:25:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L25) *style:* **Variable and function names should not use underscores.**
```r
    pdf(paste(file_path,file_name,sep = "\\"),height = 11, width = 10)
                        ^~~~~~~~~
```
[R/exportGBMtoPDF.R:25:35:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L25) *style:* **Commas should always have a space after.**
```r
    pdf(paste(file_path,file_name,sep = "\\"),height = 11, width = 10)
                                  ^
```
[R/exportGBMtoPDF.R:25:47:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L25) *style:* **Commas should always have a space after.**
```r
    pdf(paste(file_path,file_name,sep = "\\"),height = 11, width = 10)
                                              ^
```
[R/exportGBMtoPDF.R:26:5:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L26) *warning:* **no visible global function definition for 'grid.table'**
```r
    grid.table(sgbm1)
    ^~~~~~~~~~
```
[R/exportGBMtoPDF.R:27:13:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L27) *style:* **Variable and function names should not use underscores.**
```r
    summary(gbm_object,main = "Variable Importance Plot")
            ^~~~~~~~~~
```
[R/exportGBMtoPDF.R:27:24:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L27) *style:* **Commas should always have a space after.**
```r
    summary(gbm_object,main = "Variable Importance Plot")
                       ^
```
[R/exportGBMtoPDF.R:28:36:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L28) *style:* **Variable and function names should not use underscores.**
```r
    for (i in as.character(summary(gbm_object,plotit = F)$var)) {
                                   ^~~~~~~~~~
```
[R/exportGBMtoPDF.R:28:47:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L28) *style:* **Commas should always have a space after.**
```r
    for (i in as.character(summary(gbm_object,plotit = F)$var)) {
                                              ^
```
[R/exportGBMtoPDF.R:29:12:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L29) *style:* **Variable and function names should not use underscores.**
```r
      plot(gbm_object,i,type = 'response')
           ^~~~~~~~~~
```
[R/exportGBMtoPDF.R:29:23:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L29) *style:* **Commas should always have a space after.**
```r
      plot(gbm_object,i,type = 'response')
                      ^
```
[R/exportGBMtoPDF.R:29:25:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L29) *style:* **Commas should always have a space after.**
```r
      plot(gbm_object,i,type = 'response')
                        ^
```
[R/exportGBMtoPDF.R:29:32:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L29) *style:* **Only use double-quotes.**
```r
      plot(gbm_object,i,type = 'response')
                               ^~~~~~~~~~
```
[R/exportGBMtoPDF.R:30:55:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L30) *style:* **Commas should always have a space after.**
```r
      title(main = paste("Partial Dependence Plot of",toString(i),sep=" "))
                                                      ^
```
[R/exportGBMtoPDF.R:30:67:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L30) *style:* **Commas should always have a space after.**
```r
      title(main = paste("Partial Dependence Plot of",toString(i),sep=" "))
                                                                  ^
```
[R/exportGBMtoPDF.R:30:70:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L30) *style:* **Put spaces around all infix operators.**
```r
      title(main = paste("Partial Dependence Plot of",toString(i),sep=" "))
                                                                    ~^~
```
[R/exportGBMtoPDF.R:36:15:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L36) *style:* **Variable and function names should not use underscores.**
```r
    pdf(paste(file_path,"\\",file_name,".pdf",sep =""),height = 11, width = 10)
              ^~~~~~~~~
```
[R/exportGBMtoPDF.R:36:25:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L36) *style:* **Commas should always have a space after.**
```r
    pdf(paste(file_path,"\\",file_name,".pdf",sep =""),height = 11, width = 10)
                        ^
```
[R/exportGBMtoPDF.R:36:30:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L36) *style:* **Commas should always have a space after.**
```r
    pdf(paste(file_path,"\\",file_name,".pdf",sep =""),height = 11, width = 10)
                             ^
```
[R/exportGBMtoPDF.R:36:30:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L36) *style:* **Variable and function names should not use underscores.**
```r
    pdf(paste(file_path,"\\",file_name,".pdf",sep =""),height = 11, width = 10)
                             ^~~~~~~~~
```
[R/exportGBMtoPDF.R:36:40:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L36) *style:* **Commas should always have a space after.**
```r
    pdf(paste(file_path,"\\",file_name,".pdf",sep =""),height = 11, width = 10)
                                       ^
```
[R/exportGBMtoPDF.R:36:47:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L36) *style:* **Commas should always have a space after.**
```r
    pdf(paste(file_path,"\\",file_name,".pdf",sep =""),height = 11, width = 10)
                                              ^
```
[R/exportGBMtoPDF.R:36:51:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L36) *style:* **Put spaces around all infix operators.**
```r
    pdf(paste(file_path,"\\",file_name,".pdf",sep =""),height = 11, width = 10)
                                                  ^~
```
[R/exportGBMtoPDF.R:36:56:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L36) *style:* **Commas should always have a space after.**
```r
    pdf(paste(file_path,"\\",file_name,".pdf",sep =""),height = 11, width = 10)
                                                       ^
```
[R/exportGBMtoPDF.R:37:5:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L37) *warning:* **no visible global function definition for 'grid.table'**
```r
    grid.table(sgbm1)
    ^~~~~~~~~~
```
[R/exportGBMtoPDF.R:38:13:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L38) *style:* **Variable and function names should not use underscores.**
```r
    summary(gbm_object,main = "Variable Importance Plot")
            ^~~~~~~~~~
```
[R/exportGBMtoPDF.R:38:24:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L38) *style:* **Commas should always have a space after.**
```r
    summary(gbm_object,main = "Variable Importance Plot")
                       ^
```
[R/exportGBMtoPDF.R:39:36:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L39) *style:* **Variable and function names should not use underscores.**
```r
    for (i in as.character(summary(gbm_object,plotit = F)$var)) {
                                   ^~~~~~~~~~
```
[R/exportGBMtoPDF.R:39:47:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L39) *style:* **Commas should always have a space after.**
```r
    for (i in as.character(summary(gbm_object,plotit = F)$var)) {
                                              ^
```
[R/exportGBMtoPDF.R:40:12:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L40) *style:* **Variable and function names should not use underscores.**
```r
      plot(gbm_object,i,type = 'response')
           ^~~~~~~~~~
```
[R/exportGBMtoPDF.R:40:23:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L40) *style:* **Commas should always have a space after.**
```r
      plot(gbm_object,i,type = 'response')
                      ^
```
[R/exportGBMtoPDF.R:40:25:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L40) *style:* **Commas should always have a space after.**
```r
      plot(gbm_object,i,type = 'response')
                        ^
```
[R/exportGBMtoPDF.R:40:32:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L40) *style:* **Only use double-quotes.**
```r
      plot(gbm_object,i,type = 'response')
                               ^~~~~~~~~~
```
[R/exportGBMtoPDF.R:41:55:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L41) *style:* **Commas should always have a space after.**
```r
      title(main = paste("Partial Dependence Plot of",toString(i),sep=" "))
                                                      ^
```
[R/exportGBMtoPDF.R:41:67:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L41) *style:* **Commas should always have a space after.**
```r
      title(main = paste("Partial Dependence Plot of",toString(i),sep=" "))
                                                                  ^
```
[R/exportGBMtoPDF.R:41:70:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/exportGBMtoPDF.R#L41) *style:* **Put spaces around all infix operators.**
```r
      title(main = paste("Partial Dependence Plot of",toString(i),sep=" "))
                                                                    ~^~
```
[R/hiFreqFact.R:18:27:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/hiFreqFact.R#L18) *style:* **Commas should always have a space after.**
```r
  rt1 <- rt1[rt1$Freq > y,]
                          ^
```
[R/hiFreqFact.R:19:32:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/hiFreqFact.R#L19) *style:* **Only use double-quotes.**
```r
  x <- ifelse(x %in% rt1$x, x, 'other')
                               ^~~~~~~
```
[R/hiFreqFact.R:23:1:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/hiFreqFact.R#L23) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/hiFreqFact.R:24:1:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/hiFreqFact.R#L24) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/hiFreqFact.R:25:1:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/hiFreqFact.R#L25) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/hiFreqFact.R:26:1:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/hiFreqFact.R#L26) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/ls.objects.R:26:49:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/ls.objects.R#L26) *style:* **Put spaces around all infix operators.**
```r
    out <- out[order(out[[order.by]], decreasing=decreasing), ]
                                               ~^~
```
[R/lsos.R:18:26:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/lsos.R#L18) *style:* **Put spaces around all infix operators.**
```r
  lsObjects(..., order.by="Size", decreasing=TRUE, head=TRUE, n=n)
                        ~^~
```
[R/lsos.R:18:45:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/lsos.R#L18) *style:* **Put spaces around all infix operators.**
```r
  lsObjects(..., order.by="Size", decreasing=TRUE, head=TRUE, n=n)
                                           ~^~
```
[R/lsos.R:18:56:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/lsos.R#L18) *style:* **Put spaces around all infix operators.**
```r
  lsObjects(..., order.by="Size", decreasing=TRUE, head=TRUE, n=n)
                                                      ~^~
```
[R/lsos.R:18:64:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/lsos.R#L18) *style:* **Put spaces around all infix operators.**
```r
  lsObjects(..., order.by="Size", decreasing=TRUE, head=TRUE, n=n)
                                                              ~^~
```
[R/naHandler.R:31:1:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/naHandler.R#L31) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/profileDat.R:13:3:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L13) *style:* **Variable and function names should not use underscores.**
```r
  pro_df <- data.frame(row_num = 1:ncol(x), col_name = names(x))
  ^~~~~~
```
[R/profileDat.R:14:3:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L14) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$row_cnt <- nrow(x)
  ^~~~~~
```
[R/profileDat.R:14:10:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L14) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$row_cnt <- nrow(x)
         ^~~~~~~
```
[R/profileDat.R:16:3:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L16) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$uniq_val <- sapply(x, function(x) length(unique(x)))
  ^~~~~~
```
[R/profileDat.R:16:10:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L16) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$uniq_val <- sapply(x, function(x) length(unique(x)))
         ^~~~~~~~
```
[R/profileDat.R:18:3:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L18) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$na_cnt <- sapply(x, function(x) sum(is.na(x)))
  ^~~~~~
```
[R/profileDat.R:18:10:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L18) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$na_cnt <- sapply(x, function(x) sum(is.na(x)))
         ^~~~~~
```
[R/profileDat.R:20:3:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L20) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$blank_cnt <- sapply(x, function(x) length(x[!is.na(x) & as.character(x) == '']))
  ^~~~~~
```
[R/profileDat.R:20:10:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L20) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$blank_cnt <- sapply(x, function(x) length(x[!is.na(x) & as.character(x) == '']))
         ^~~~~~~~~
```
[R/profileDat.R:20:85:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L20) *style:* **Only use double-quotes.**
```r
  pro_df$blank_cnt <- sapply(x, function(x) length(x[!is.na(x) & as.character(x) == '']))
                                                                                ^~
```
[R/profileDat.R:21:3:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L21) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$top_val <- sapply(x, function(x) rankTab(x)[1,'x'])
  ^~~~~~
```
[R/profileDat.R:21:10:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L21) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$top_val <- sapply(x, function(x) rankTab(x)[1,'x'])
         ^~~~~~~
```
[R/profileDat.R:21:56:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L21) *style:* **Commas should always have a space after.**
```r
  pro_df$top_val <- sapply(x, function(x) rankTab(x)[1,'x'])
                                                       ^
```
[R/profileDat.R:21:56:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L21) *style:* **Only use double-quotes.**
```r
  pro_df$top_val <- sapply(x, function(x) rankTab(x)[1,'x'])
                                                       ^~~
```
[R/profileDat.R:23:3:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L23) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$na_pct <- round(pro_df$na_cnt / pro_df$row_cnt, 4)
  ^~~~~~
```
[R/profileDat.R:23:10:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L23) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$na_pct <- round(pro_df$na_cnt / pro_df$row_cnt, 4)
         ^~~~~~
```
[R/profileDat.R:23:26:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L23) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$na_pct <- round(pro_df$na_cnt / pro_df$row_cnt, 4)
                         ^~~~~~
```
[R/profileDat.R:23:33:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L23) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$na_pct <- round(pro_df$na_cnt / pro_df$row_cnt, 4)
                                ^~~~~~
```
[R/profileDat.R:23:42:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L23) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$na_pct <- round(pro_df$na_cnt / pro_df$row_cnt, 4)
                                         ^~~~~~
```
[R/profileDat.R:23:49:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L23) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$na_pct <- round(pro_df$na_cnt / pro_df$row_cnt, 4)
                                                ^~~~~~~
```
[R/profileDat.R:24:3:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L24) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$blank_pct <- round(pro_df$blank_cnt / pro_df$row_cnt, 4)
  ^~~~~~
```
[R/profileDat.R:24:10:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L24) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$blank_pct <- round(pro_df$blank_cnt / pro_df$row_cnt, 4)
         ^~~~~~~~~
```
[R/profileDat.R:24:29:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L24) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$blank_pct <- round(pro_df$blank_cnt / pro_df$row_cnt, 4)
                            ^~~~~~
```
[R/profileDat.R:24:36:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L24) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$blank_pct <- round(pro_df$blank_cnt / pro_df$row_cnt, 4)
                                   ^~~~~~~~~
```
[R/profileDat.R:24:48:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L24) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$blank_pct <- round(pro_df$blank_cnt / pro_df$row_cnt, 4)
                                               ^~~~~~
```
[R/profileDat.R:24:55:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L24) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$blank_pct <- round(pro_df$blank_cnt / pro_df$row_cnt, 4)
                                                      ^~~~~~~
```
[R/profileDat.R:26:3:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L26) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$top_5_val_pct <- round(sapply(x, function(x) sum(sum(rankTab(x)[1:5, "Freq"], na.rm = TRUE)) / length(x)), 4)
  ^~~~~~
```
[R/profileDat.R:26:10:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L26) *style:* **Variable and function names should not use underscores.**
```r
  pro_df$top_5_val_pct <- round(sapply(x, function(x) sum(sum(rankTab(x)[1:5, "Freq"], na.rm = TRUE)) / length(x)), 4)
         ^~~~~~~~~~~~~
```
[R/profileDat.R:29:10:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/profileDat.R#L29) *style:* **Variable and function names should not use underscores.**
```r
  return(pro_df)
         ^~~~~~
```
[R/rankTab.R:12:34:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/rankTab.R#L12) *style:* **Commas should always have a space after.**
```r
  tab1 <- tab1[order(-tab1$Freq),]
                                 ^
```
[R/setTypes.R:16:39:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/setTypes.R#L16) *style:* **Only use double-quotes.**
```r
    df1 <- data.frame(var = i, type = '', stringsAsFactors = F)
                                      ^~
```
[R/setTypes.R:18:30:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/setTypes.R#L18) *style:* **Commas should always have a space after.**
```r
    print(as.character(x[1:5,i]));flush.console()
                             ^
```
[R/setTypes.R:20:11:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/setTypes.R#L20) *style:* **Commas should always have a space after.**
```r
    df1[1,'type'] <- readline(' Type - f / n / c ?   ')
          ^
```
[R/setTypes.R:20:11:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/setTypes.R#L20) *style:* **Only use double-quotes.**
```r
    df1[1,'type'] <- readline(' Type - f / n / c ?   ')
          ^~~~~~
```
[R/setTypes.R:20:31:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/setTypes.R#L20) *style:* **Only use double-quotes.**
```r
    df1[1,'type'] <- readline(' Type - f / n / c ?   ')
                              ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/setTypes.R:26:30:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/setTypes.R#L26) *style:* **Only use double-quotes.**
```r
  charVar <- df2[df2$type == 'c','var']
                             ^~~
```
[R/setTypes.R:26:34:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/setTypes.R#L26) *style:* **Commas should always have a space after.**
```r
  charVar <- df2[df2$type == 'c','var']
                                 ^
```
[R/setTypes.R:26:34:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/setTypes.R#L26) *style:* **Only use double-quotes.**
```r
  charVar <- df2[df2$type == 'c','var']
                                 ^~~~~
```
[R/setTypes.R:27:29:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/setTypes.R#L27) *style:* **Only use double-quotes.**
```r
  numVar <- df2[df2$type == 'n','var']
                            ^~~
```
[R/setTypes.R:27:33:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/setTypes.R#L27) *style:* **Commas should always have a space after.**
```r
  numVar <- df2[df2$type == 'n','var']
                                ^
```
[R/setTypes.R:27:33:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/setTypes.R#L27) *style:* **Only use double-quotes.**
```r
  numVar <- df2[df2$type == 'n','var']
                                ^~~~~
```
[R/setTypes.R:28:30:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/setTypes.R#L28) *style:* **Only use double-quotes.**
```r
  factVar <- df2[df2$type == 'f','var']
                             ^~~
```
[R/setTypes.R:28:34:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/setTypes.R#L28) *style:* **Commas should always have a space after.**
```r
  factVar <- df2[df2$type == 'f','var']
                                 ^
```
[R/setTypes.R:28:34:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/setTypes.R#L28) *style:* **Only use double-quotes.**
```r
  factVar <- df2[df2$type == 'f','var']
                                 ^~~~~
```
[R/setTypes.R:30:6:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/setTypes.R#L30) *style:* **Commas should always have a space after.**
```r
  x[,charVar] <- as.data.frame(lapply(x[,charVar], as.character))
     ^
```
[R/setTypes.R:30:42:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/setTypes.R#L30) *style:* **Commas should always have a space after.**
```r
  x[,charVar] <- as.data.frame(lapply(x[,charVar], as.character))
                                         ^
```
[R/setTypes.R:31:6:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/setTypes.R#L31) *style:* **Commas should always have a space after.**
```r
  x[,numVar] <- as.data.frame(lapply(x[,numVar], function(x) return(as.numeric(as.character(x)))))
     ^
```
[R/setTypes.R:31:41:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/setTypes.R#L31) *style:* **Commas should always have a space after.**
```r
  x[,numVar] <- as.data.frame(lapply(x[,numVar], function(x) return(as.numeric(as.character(x)))))
                                        ^
```
[R/setTypes.R:32:6:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/setTypes.R#L32) *style:* **Commas should always have a space after.**
```r
  x[,factVar] <- as.data.frame(lapply(x[,factVar], as.factor))
     ^
```
[R/setTypes.R:32:42:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/R/setTypes.R#L32) *style:* **Commas should always have a space after.**
```r
  x[,factVar] <- as.data.frame(lapply(x[,factVar], as.factor))
                                         ^
```
[tests/testthat/test-clusDropVar2.R:7:81:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/tests/testthat/test-clusDropVar2.R#L7) *style:* **Put spaces around all infix operators.**
```r
  d <- clusDropVar(iris, 3:5, threshold = .6, vte = "Species", xLoopsBeforePrint=1)
                                                                               ~^~
```
[tests/testthat/test-lint.R:5:5:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/tests/testthat/test-lint.R#L5) *style:* **Variable and function names should not use underscores.**
```r
    my_linters <- list(
    ^~~~~~~~~~
```
[tests/testthat/test-lint.R:6:28:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/tests/testthat/test-lint.R#L6) *style:* **Put spaces around all infix operators.**
```r
      absolute_paths_linter=absolute_paths_linter,
                          ~^~
```
[tests/testthat/test-lint.R:7:24:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/tests/testthat/test-lint.R#L7) *style:* **Put spaces around all infix operators.**
```r
      assignment_linter=assignment_linter,
                      ~^~
```
[tests/testthat/test-lint.R:8:26:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/tests/testthat/test-lint.R#L8) *style:* **Put spaces around all infix operators.**
```r
      closed_curly_linter=closed_curly_linter,
                        ~^~
```
[tests/testthat/test-lint.R:9:20:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/tests/testthat/test-lint.R#L9) *style:* **Put spaces around all infix operators.**
```r
      commas_linter=commas_linter,
                  ~^~
```
[tests/testthat/test-lint.R:11:26:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/tests/testthat/test-lint.R#L11) *style:* **Put spaces around all infix operators.**
```r
      infix_spaces_linter=infix_spaces_linter,
                        ~^~
```
[tests/testthat/test-lint.R:12:25:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/tests/testthat/test-lint.R#L12) *style:* **Put spaces around all infix operators.**
```r
      line_length_linter=line_length_linter,
                       ~^~
```
[tests/testthat/test-lint.R:13:20:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/tests/testthat/test-lint.R#L13) *style:* **Put spaces around all infix operators.**
```r
      no_tab_linter=no_tab_linter,
                  ~^~
```
[tests/testthat/test-lint.R:14:26:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/tests/testthat/test-lint.R#L14) *style:* **Put spaces around all infix operators.**
```r
      object_usage_linter=object_usage_linter,
                        ~^~
```
[tests/testthat/test-lint.R:15:24:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/tests/testthat/test-lint.R#L15) *style:* **Put spaces around all infix operators.**
```r
      snake_case_linter=snake_case_linter,
                      ~^~
```
[tests/testthat/test-lint.R:16:27:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/tests/testthat/test-lint.R#L16) *style:* **Put spaces around all infix operators.**
```r
      multiple_dots_linter=multiple_dots_linter,
                         ~^~
```
[tests/testthat/test-lint.R:17:27:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/tests/testthat/test-lint.R#L17) *style:* **Put spaces around all infix operators.**
```r
      object_length_linter=object_length_linter,
                         ~^~
```
[tests/testthat/test-lint.R:18:24:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/tests/testthat/test-lint.R#L18) *style:* **Put spaces around all infix operators.**
```r
      open_curly_linter=open_curly_linter,
                      ~^~
```
[tests/testthat/test-lint.R:19:27:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/tests/testthat/test-lint.R#L19) *style:* **Put spaces around all infix operators.**
```r
      single_quotes_linter=single_quotes_linter,
                         ~^~
```
[tests/testthat/test-lint.R:20:27:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/tests/testthat/test-lint.R#L20) *style:* **Put spaces around all infix operators.**
```r
      spaces_inside_linter=spaces_inside_linter,
                         ~^~
```
[tests/testthat/test-lint.R:22:34:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/tests/testthat/test-lint.R#L22) *style:* **Put spaces around all infix operators.**
```r
      trailing_blank_lines_linter=trailing_blank_lines_linter,
                                ~^~
```
[tests/testthat/test-lint.R:23:33:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/tests/testthat/test-lint.R#L23) *style:* **Put spaces around all infix operators.**
```r
      trailing_whitespace_linter=trailing_whitespace_linter
                               ~^~
```
[tests/testthat/test-lint.R:25:36:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/tests/testthat/test-lint.R#L25) *style:* **Put spaces around all infix operators.**
```r
    lintr::expect_lint_free(linters=my_linters)
                                  ~^~
```
[tests/testthat/test-lint.R:25:37:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/tests/testthat/test-lint.R#L25) *style:* **Variable and function names should not use underscores.**
```r
    lintr::expect_lint_free(linters=my_linters)
                                    ^~~~~~~~~~
```
[tests/testthat/test-naHandler.R:15:7:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/tests/testthat/test-naHandler.R#L15) *style:* **Commas should always have a space after.**
```r
  x[1,] <- NA
      ^
```
[tests/testthat/test-naHandler.R:17:18:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/tests/testthat/test-naHandler.R#L17) *style:* **Only use double-quotes.**
```r
  expect_is(nas, 'list')
                 ^~~~~~
```
[tests/testthat/test-rankTab.R:10:28:](https://github.com/barrenWuffet/convPkg/blob/7c0c629aa6f31ab5afe8eaad58303f891042a72e/tests/testthat/test-rankTab.R#L10) *style:* **Commas should always have a space after.**
```r
  expect_equal(dim(d), c(3,2))
                           ^
```


Also I am not sure about `!` on a `uint`.


# Download the All_Indian_Trains.csv also


Not sure why this change isn't showing up? I added `return (` to the code after `render() {`.


I think endpoint should reside in Io.Net module to avoid dependency of Io.Net to Region.


Created multidev environment [ecrac#pr-11](https://dashboard.pantheon.io/sites/1291b6c7-9029-4c6d-867f-caf641f6fade#pr-11).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-11-ecrac.pantheonsite.io/)


And tests should be fixed also


Created multidev environment [ecrac#ci-107](https://dashboard.pantheon.io/sites/1291b6c7-9029-4c6d-867f-caf641f6fade#ci-107).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-107-ecrac.pantheonsite.io/)