<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:minHeight="@dimen/list_item_height"
    android:orientation="horizontal">

    <ImageView
        android:id="@+id/imageresource"
        android:layout_width="@dimen/list_item_height"
        android:layout_height="@dimen/list_item_height" />

    <LinearLayout
        android:id="@+id/text_container"
        android:layout_width="match_parent"
        android:layout_height="@dimen/list_item_height"
        android:background="@color/category_numbers"
        android:paddingLeft="16dp"
        android:paddingRight="16dp">

        <LinearLayout
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            android:orientation="horizontal">

            <LinearLayout
                android:layout_width="0dp"
                android:layout_height="match_parent"
                android:layout_weight="1"
                android:orientation="vertical">

                <TextView
                    android:id="@+id/miwok_text_view"
                    android:layout_width="match_parent"
                    android:layout_height="0dp"
                    android:layout_weight="1"
                    android:gravity="bottom"
                    android:text="hhh"
                    android:textAppearance="?android:textAppearanceMedium"
                    android:textColor="@android:color/white"
                    android:textStyle="bold" />

                <TextView
                    android:id="@+id/default_text_view"
                    android:layout_width="match_parent"
                    android:layout_height="0dp"
                    android:layout_weight="1"
                    android:gravity="top"
                    android:text="ggsggg"
                    android:textAppearance="?android:textAppearanceMedium"
                    android:textColor="@android:color/white" />
            </LinearLayout>

            <ImageButton
                android:layout_width="wrap_content"
                android:layout_height="wrap_content"
                android:layout_gravity="center_vertical"
                android:src="@drawable/ic_play_arrow" />
        </LinearLayout>

    </LinearLayout>

</LinearLayout>


This is what I did but my audio did not play after running the app. Please what could have happen.

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:minHeight="@dimen/list_item_height"
    android:orientation="horizontal">

    <ImageView
        android:id="@+id/imageresource"
        android:layout_width="@dimen/list_item_height"
        android:layout_height="@dimen/list_item_height" />

    <LinearLayout
        android:id="@+id/text_container"
        android:layout_width="match_parent"
        android:layout_height="@dimen/list_item_height"
        android:background="@color/category_numbers"
        android:paddingLeft="16dp"
        android:paddingRight="16dp">

        <LinearLayout
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            android:orientation="horizontal">

            <LinearLayout
                android:layout_width="0dp"
                android:layout_height="match_parent"
                android:layout_weight="1"
                android:orientation="vertical">

                <TextView
                    android:id="@+id/miwok_text_view"
                    android:layout_width="match_parent"
                    android:layout_height="0dp"
                    android:layout_weight="1"
                    android:gravity="bottom"
                    android:text="hhh"
                    android:textAppearance="?android:textAppearanceMedium"
                    android:textColor="@android:color/white"
                    android:textStyle="bold" />

                <TextView
                    android:id="@+id/default_text_view"
                    android:layout_width="match_parent"
                    android:layout_height="0dp"
                    android:layout_weight="1"
                    android:gravity="top"
                    android:text="ggsggg"
                    android:textAppearance="?android:textAppearanceMedium"
                    android:textColor="@android:color/white" />
            </LinearLayout>

            <ImageButton
                android:layout_width="wrap_content"
                android:layout_height="wrap_content"
                android:layout_gravity="center_vertical"
                android:src="@drawable/ic_play_arrow" />
        </LinearLayout>

    </LinearLayout>

</LinearLayout>


Deployment failed with the following error:

~~~
Cloud v2 deployments must be type "docker"
~~~


There are a few things left to do here, but it's a start.


finally an elo gainer, it's been a while! Congrats!


if you just `return;` in the error block and do not provide an error response to the client, than it will wait for it until timeout.
Here you could use something like:
```
res.status(500).json({
   message: 'Unknown error happened.',
});
```


试了几次 只要重启防火墙 就可以了


I think it is community at the moment.


@edolstra  @matthewbauer  this was backported to 18.09 in  95f31078f5a , so that should be reverted as well.


Nevermind, I see it's already done.


Hi glucee,
I'm interested in running this script for my driving school, but i am having issues with it running.
Any help would be most appreciated.
Kind regards
Chris


See discussion here: https://github.com/jnunemaker/httparty/issues/472


Ok. Hoe moet dan de situatie waarin het VBO nog niet bestond en er naast een hoofdadres tegelijkertijd ook een nevenadres wordt opgevoerd, worden aangepakt ? Dan zijn we rond....  :-)


Хорошо бы перенести в сервис для работы с корзиной, напрмиер: CartService


I believe destructors suffer from #8525 too, if `=destroy` (or `=deepcopy`) is defined _after_ the type's been already used (in the linked case `let global = Ref()` generates a `Ref` type without the `=destroy` attached) we lose that piece of information.


I would personally not make this an else-if, but rather a separate if block. If you have `validate_hostname` set in the config, `allow_insecure` would do nothing in this case, which might be confusing.


Nope.


It looks like the second URI has a typo: 'Linving'.
Ok, and a canonical URI doesn't have to resolve, but it feels a bit strange that a user should 'know' that it can be resolved via Simplifier (there is no reference to Simplifier).


I don't know how the Mac nightly script is structured but, in theory, anything that triggers a build on the other platforms should trigger it on the Mac too. There is no code change in this commit, only shaders. If the Mac script starts a build only when core code is changed, then probably the above change will not cause nightly build generation.


The new code of conduct:
1. NO SJW
2. NO SJW
3. NO SJW
4. NO SJW
5. NO SJW


the API specification requested that you return the results in the format of:
```
 { posts: [....]
}
```

So the actual result should be accessible by the key `posts` first.
You can achieve it by using:
```
res.json({
posts: rows
});
```


In the early developments of CTRL + click feature highlight we were under the impression that `dragRotate` was capturing the CTRL + click events. Maybe we were wrong... At least I can confirm that on OSX *Cmd* + click is working, even if `dragRotate` is *not* disabled.

I think this should be validated on Windows as well with *Ctrl* + click.


Awesome, this feedback was gold. Thanks for that.

Btw, when you say:

> "every test locks down something about your system; be careful to only lock down the things that matter"

Is that quote yours or from somebody else? Do you have the source?


You should do this in every case where you can have DB errors.


Just move this conditions to the top!


You can use this in a better format, where the `mysql` module do the actual formatting.
Eg. in this case:
```
conn.query(`INSERT INTO posts (title, url) VALUES (?, ?);`, [title, url], (err, result) => {
```


You can use this format in every query in your code.


@mjbvz can you take this?


Include SW model QFX5100-48S-6Q to use rpc_call_without_information.


could use:
```
conn.query('SELECT * FROM posts WHERE id = ?;', [result.insertId](err, newPost)
```


There is no point checking the `id` variable as it **must** exists. `req.params` from the path always has to exists, because if the client would have requested the path `/posts/upvote` than this endpoint definition would not match this with missing id.


Falta promedio.


@ZakMan228 Чаще всего метод вызывают от самой переменной-строки или от литерала строки. Попробуй такие варианты:
`'fdsgffd43543gdfs'.isdigit()`
``````


Dear jiaozizhao,

Thank you for the interest in our work.
We use the ImageNet pre-training for each stream separately; we have K=6 different streams each one being pre-trained on ImageNet.
We did not use ImageNet VID at all.
I hope this helps.


Same comment as in the upvote part


Nodejs frontend


My listview remain unclickable after adding the play button but if I delete the button Image view everything works perfectly again. Please what are may doing wrong with with code above? Thanks


Cara Download Nya Dong atau Ada Yang Bisa Bantuu


- set the activities' orientation to portrait
- edited the main activity so it looks better on different screens
- edited the bottom navigation menu's text and icons


It was on purpose to have it fixed, so you always know that you are not looking at the latest release. Could you change this back?


已经修复了


I'm scratching my head on this one as I was trying to use new Context API to write redux-like Provider and connect(), but I think it can just *not* work with server-side rendering :(

The most important thing is that one root component == one store, so you can call `createStore` for each request and render your component with given store in the tree, without fearing for race conditions between two independent requests which would use the same data.

That was OK with old Context API, as it was attached to the actual tree. Now it's attached to an external object we're doomed: in your current implementation (and I could not find better idea), you have only one global context, so if you have two trees, using `<Provider store={store}>…`, with two different stores, you will face race conditions as the first tree will suddenly be udpated by the second one.

It will work now, because between createElement() and renderToString() everything is synchronous, but that smells bad :(

Do you have any idea how to solve this?


It is not necessarily to describe both variants, but provide the most accurate description.
`# if true, replace all BC by the adiabatic one`. This should be your one, but it is useless for comparison with `laser_as_bc`.
Indeed, I suggested the other version: `# if true, replace all (except the laser one) BC by the adiabatic one`


Change Input


🙋♂ According to https://moneyadviceservice.tpondemand.com/restui/board.aspx?#page=userstory/9369&searchPopup=userstory/9588, the tag id is different, it should be `GTM-MPK3QX`, since [`GTM-WVFLH9` is the one for MAS frontend instead](https://github.com/moneyadviceservice/frontend/blob/23b4535bf776fe725252021e9cbeb2a1768bd9a7/config/application.rb#L29), right? 🤔


重新改过了 可以试试


__API Description file syntax error on line 172__: the use of tab(s) '\t' in source data isn't currently supported, please contact makers (Autogenerated message from apiary.io)


I think that we should only declare `status` in the branch where `fil_space_crypt_get_status()` is called, and move all `fields[x]->store(status.y)` calls into that branch.

If information about encryption is not available, then we should return `NULL` for all columns for which with this patch we would return 0.


Dzięki niej można w sensowny sposób przywrócić coś co kiedyś było możliwe (zanim stało się multiselectem).


groupedBy and summerise function


好的


This is super old commit. See https://github.com/TrinityCore/TrinityCore/pull/17793

Also this contains tons of old code. I will check for an updated version if you remind me in a few days.


newline


`setUp` is a method that would run for each test
you should use it to make sure each test is clean and isolated, so that a test wouldn't have to clean up after itself like in this line


Thanx, i have same problem with Romanian.


Thanx, I have same problem with Romanian.


You can use this in a better format, where the `mysql` module do the actual formatting.
Eg. in this case:
```
conn.query('INSERT INTO posts (title, url) VALUES (?, ?);', [req.body.title, req.body.url], (err, result) => {
```


use that in every query


為什麼要把這個刪掉 XDDD
這個是刻意留著的


Commit part #2 "2.- Do not display the Check button" was a bad idea. I removed it in a newer commit.


Set the status to indicate **that there was an error**.
Eg.
`res.status(500).json({
  err: err.message
});`


![](https://github.trello.services/images/mini-trello-icon.png) [CheckTokenIndices calls to blockchain multiple times.](https://trello.com/c/3rlJ65oL/197-checktokenindices-calls-to-blockchain-multiple-times)


Oh yes my bad. It's caught...but the message isn't very explicit. I will fix it.


Задачи HTML


if you choose to use capital letters in the sql statements, use it everywhere :)
`SELECT * FROM posts WHERE id=...`


Would it be possible to parametrize `generateTestData()` as we discussed some time ago:
```
List<Page> generateTestData(int numerOfPartitionColumns, int numberOfDataColumns, int numberOfPartitionRows, int preOrderedColumns)
```

and:
* when `preOrderedColumns <= numerOfGroupColumns` that means window operator has some `preGroupedChannels`, but `preSortedChannelPrefix=0` (edited)
* when `preOrderedColumns > numerOfGroupColumns` that means window operator has fully `preGroupedChannels` and `preSortedChannelPrefix = preOrderedColumns-numerOfGroupColumns`


// <link rel="shortcut icon" href="druga.ico">


We always set the host variable to just point to `http://localhost:3030`, so then later on when you need to create different requests to different endpoints you can just concatenate the missing path to `host`


这样检测也不行,重新拨号连上外网获取到ip 就不会重启了....


Hello Cisco


I would replace `DICT_HDR_FIRST_ID` with `MIX_STATE` and add
```c
compile_time_assert(DICT_HDR_FIRST_ID == MIX_STATE);
```


Is this revision correct? What happened to the previous approach of supporting multiple languages and throwing an exception for unsupported languages?


The answer is that the button is stealing the focus from the list item.   Put this in the button and both will be clickable.
android:focusable="false"
I learned this. I don't quite get why the button still works but it does. :)

Enjoy the course. It's excellent.

Sent from Yahoo Mail on Android

  On Mon, Sep 24, 2018 at 10:08, semiu adeyemi biliaminu<notifications@github.com> wrote:
My listview remain unclickable after adding the play button but if I delete the button Image view everything works perfectly again. Please what are may doing wrong with with code above? Thanks

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


Oh yeah, I see. Apparently this doesn't work as expected in the `<div>` with `width: 100%;` coming from `.toast`.
I'll think of something …


This is beautiful piece of functional programming that we can use an NPM module


@sdvillal did you really mean to write `/home/santi/` here?


Thank you for the offer. I don't care much about Windows in general since I'm not a Windows user, so I'm not motivated enough to research into how to publish Chocolatey packages myelf. If someone sends me a PR where they set up everything to auto-publish Chocolatey packages on release, then I would review and accept it, but otherwise I'd rather just leave it up to the community.


Remove the pointer indirection, and declare `crypt_threads_list` as an integral part of `fil_system_t`, like the other lists are.


string


Revert the typo.
Declare the `typedef` inside `fil_system_t`, not in global scope.


Falling behind :)


Remove the `*` and write a Doxygen comment (starting with `/**` instead of `/*`) that explains what the data structure is for. (You should also mention which mutex protects it, but more importantly, what it is for.)


Ultra Master


Сохранить?


parameters[partnerIdName] This will lead to Exception, if partnerIdName is not present in dictionary.


tt


this is only for testing purposes, should remove


There is only a warning. Resolved.


This would be leaving an uninitialized member in `export_vars`. This field was added in MDEV-11738/MDEV-11581 commit 50eb40a2a8aa3af6cc271f6028f4d6d74301d030.

If we keep the variable, then test coverage should be improved. Else, we should document that the variable no longer exists. Maybe this variable has limited use, compared to reading details from `INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION`.


setup a status code (the default is `200 - OK` which is not true right now), eg. use 500

```
if (err) {
  res.status(500).json({
    error: err.message,
});
}
```


optionnal


Same here
```context.HttpContext.Items[partnerIdName]``` will lead to exception if ```partnerIdName``` is not in dictionary.
use TryGetValue


it's preferable to use hard coded values as the expected values (e.g. `1` instead of `WorkScheduler8.sunday_protools.employee_amount.get('x')`)
This way, it's very clear to the reader what is the expected value, and more importantly it prevents false positives if the code used for the expected value is incorrect


The unknown value should be dumped as well.

This check should be as early as possible. It seems that at least the call to `ibuf_update_max_tablespace_id()` is too early (and perhaps should be skipped if `srv_read_only_mode` is set).


But, also sending back the actual error message is not useful (the client won't be able to make sense of a DB error message, so what would happen in real life that we log the actual error message to the server and then send back a short message about error to the client.

Like:

```
if (err) {
console.log(err.message);

  res.status(500).json({
    error: 'An unexpected error happened',
  });
}
```


![qq 20180924173220](https://user-images.githubusercontent.com/26851715/45945643-b7cdbb80-c020-11e8-84ad-13ad23f44f6e.png)
这是个问题


ah thanks, feel free to open a pr :+1:


nice :)


OK, I thought it was still stored as a string because of this line:

https://github.com/commontk/CTK/blob/3508c054430ce5aa2efd1dd483d364131adf06b5/Libs/QtTesting/ctkXMLEventSource.cpp#L147

and this one:

https://github.com/commontk/CTK/blob/3508c054430ce5aa2efd1dd483d364131adf06b5/Libs/QtTesting/ctkXMLEventObserver.cpp#L155


If there's a pending removal we need to disable the button. We can add it here I guess.


Hvad er »..«?  Der er punktummer og udeladelsesprikker, hvad røv er to prikker?


加个延时呢


я думал, что там имя используется, в таком случае все норм тогда =)


Use `'single quotes'` for string literals. `"Double quotes"` in the SQL standard are reserved for quoting identifiers.
(By default, MySQL and MariaDB use backticks for that purpose, deviating from the standard. I would keep the tests as close to standard SQL as possible.)


You can use this in a better format, where the `mysql` module do the actual formatting.
Eg. in this case:
```
conn.query('INSERT INTO posts (title, url) VALUES (?, ?);', [postTitle, postURL], (err, result) => {
```


wonder how that made it there! will fix and force push everything


This through 216 only needed because line 130 has < not <=. May change line 130


This Commit changes my covered folder and adds coverage module to my requirements file.
I have yet to cover  two functions in my tests.


I think that this file should also include the following options:
```
--innodb_buffer_pool_load_at_startup=0
--innodb_encrypt_tables=ON
```
In that way, the .test file would not have to duplicate these parameters.

Why are we disabling the buffer pool load at startup?


I would make the test expect an exception to be raised, so in the implementation you would raise an exception if an illegal addition is attempted


![22280924174300](https://user-images.githubusercontent.com/26851715/45945802-4c381e00-c021-11e8-8dc2-ce00f5126ae5.png)
如果每秒监测的话  没问题


最好加个计数器 3次就kill 插件


Looking at ur comments


Maybe revert this? This can complicate porting plugins that use scoreboards packets. Like a BTLP.


Contrôle de saisie d'un formulaire côté navigateur.


Oh yes, you are right, I should pay more attention when doing copy & paste.

Fixed in 5d265bd


Cái này chỉ cần apply một lần ở root cho tất cả những element, không cần phải gọi riêng lẻ đâu. Với lại browser support giờ tốt nên không cần prefix nữa 😉

Ref: https://css-tricks.com/box-sizing/#article-header-id-6

    html {
      box-sizing: border-box;
    }

    *, *::before, *::after {
      box-sizing: inherit;
    }


Sorry. I will exclude this change.


Successfully aliased the URL <https://pebble-pzyvxzzvkl.now.sh> to the following alias.

* https://pebble.now.sh


echo "# rsschool-profile" >> README.md
git init
git add README.md
git commit -m "first commit"
git remote add origin https://github.com/AnastasiyaBaranovskaya/rsschool-profile.git
git push -u origin master
AnastasiyaBaranovskaya
https://www.codecademy.com/users/AnastasiyaBaranovskaya/achievements


I guess you also need to re-bump the buld number to 3? I have 2 on my system


qqqq


Should be 2.8.

The whole module probably should be in the "crypto" folder instead of adding an "openssh" module namespace.


`The comment added to the private key` (btw. - aren't comments only added to public keys?)


size has a default value, it always exists


Successfully aliased the URL <https://pebble-dcdaqfrdai.now.sh> to the following alias.

* https://pebble.now.sh


`len(fingerprint.split())-1` can be replaced by `-1` to refer to the last element (https://stackoverflow.com/questions/509211/understanding-pythons-slice-notation)


my plan was to force push this to our channel, then you would need to invalidate your local package cache if you wanna play with it (but anyway it is not worth, it is just a warning that you could have seen)


you should first assert that the list is not empty, otherwise the test might return a false positive (run 0 iterations)


```
dt = pd.read_csv("C:\Users\lisam\Downloads\titanic.csv")
```


OK, what do I do to invalidate the package cache? I want to test it as I will blog about this soon in the context of new imstore/packages and want to make sure things work first.


Where are your files???????


Not oops, the `model/stl` one was simply not defined back when these MIME types were first written down ;)


Oh, oops. How'd I miss that?


Конечно, это же WIP коммит. Документация по методам добавлена в [релизной версии](https://github.com/ArthurAm/cryptoprocessing.php/releases), так же её можно посмотреть в документации к api


done


conda clean -tipy
(conda clean --help)


nitpick, `s/binary//`

The Scala binary version of 2.11.12 is 2.11


Argh, I was hoping for a smaller hammer. I don't enjoy downloading >3Gb of packages..... we dont all have 100Mbit internet :cry:


Still can't play my audio. Thanks


Isn't it cleaner just to bump the build number?


Should work now. Changes from ofVec2f to glm::vec2 made some parts of the example not to work. I quick fixed it with a uncomment. so it should compile. the funktion needs though to be set differently.
good luck


updated packages are now up


❌ [Build was (probably) aborted](https://jenkins.internalx.com/job/macios/job/artifacts-add-in-updateinfo/1/display/redirect)

🔥 [Jenkins job](https://jenkins.internalx.com/job/macios/job/artifacts-add-in-updateinfo/1/display/redirect) (on internal Jenkins) failed in stage(s) 'Running XM tests on '10.14', Test docs' 🔥 : hudson.AbortException: Xamarin.Mac tests on macOS 10.14 failed (xammac_tests)

✅ [Build succeeded](https://jenkins.internalx.com/job/macios/job/artifacts-add-in-updateinfo/1//console)
✅ [API Diff (from stable)](http://xamarin-storage/jenkins/xamarin-macios/artifacts-add-in-updateinfo/a7eea45c09e19c3dbe697142932e624436acc992/1/jenkins-results/api-diff/index.html)
ℹ [API Diff (from PR only)](http://xamarin-storage/jenkins/xamarin-macios/artifacts-add-in-updateinfo/a7eea45c09e19c3dbe697142932e624436acc992/1/jenkins-results/apicomparison/index.html) (please review changes)
ℹ [Generator Diff](http://xamarin-storage/jenkins/xamarin-macios/artifacts-add-in-updateinfo/a7eea45c09e19c3dbe697142932e624436acc992/1/jenkins-results/generator-diff/index.html) (please review changes)
🔥 [Xamarin.Mac tests on macOS 10.14 failed (xammac_tests)](https://jenkins.internalx.com/job/macios/job/artifacts-add-in-updateinfo/1/display/redirect) 🔥
✅ [Test run succeeded](http://xamarin-storage/jenkins/xamarin-macios/artifacts-add-in-updateinfo/a7eea45c09e19c3dbe697142932e624436acc992/1/jenkins-results/tests/index.html)


That didn't seem to make any difference. There is no change in the display. I made a simplified page to ensure nothing else was involved.

This is the order I am using to load the files.

`<link rel="stylesheet" href="/css/jqui/jquery-ui.min.css">
<link rel="stylesheet" href="/css/jqui/jquery-ui.theme.min.css">
<link href="https://fonts.googleapis.com/css?family=Noto+Sans|Noto+Serif+KR" rel="stylesheet">
<link rel="stylesheet" href="/css/bs/bootstrap.min.css">
<link rel="stylesheet" href="/Templates/css/template.css">

<link href="/test/summernote/summernote-bs4.css" rel="stylesheet" />
<link href="/test/elFinder/css/elfinder.min.css" rel="stylesheet" />

`

This is the simple form I am using to test the code. The form will not submit and no js code to process the form is included because the editor does not work at this point.

`<form action="/test/test.php" enctype="multipart/form-data">

Test Form

<input type="hidden" name="html" value="" />

<input type="button" name="frmSubmit" value="Submit Form" />
</form>`


I think the details of EmergencyOfEmergencyWithdrawal ought to include the amount withdrawn. A purist would say it's knowable but it seems like a pretty important detail that should be part of the log.


On a very picky level, "owner" is a de facto standard that could confuse reviewers about the meaning of this, so I would probably go with "sender".


Successfully aliased the URL <https://website-ydjuucbifw.now.sh> to the following aliases.

* https://ko.parceljs.org
* https://pt.parceljs.org
* https://zh.parceljs.org
* https://parceljs.org
* https://pl.parceljs.org
* https://ru.parceljs.org
* https://en.parceljs.org
* https://es.parceljs.org
* https://fr.parceljs.org
* https://it.parceljs.org


`remittanceStructs` as a naming convention will help out when more complex structures are in play. camelCase and plural will help everyone remember exactly what is in the indexed storage. They are RemittanceStruct(s).


http://tests.stockfishchess.org/tests/view/5ba96d160ebc592439f61f5b
Scheduling 8 variants of a patch at the same time leaves a very disproportionately small amount of resources for other peoples patches to run.  What do you think about putting some on Pri -1 hold when scheduling?


Ha ha


View of welcome screen


Thats pretty handy to know, thank you.  Two thoughts:

1) Is it worth keeping a document of these results somewhere?  On the one
hand it might be nice to have some data, on the other, keepting it up to
date and accurate might a a real pita

2) I wonder if its worth enhancing test mode to take an integer argument on
the command line representing number of iterations before exit, so that you
can get a consistent number of iterations without having to wait on the
console to ctrl-c out of it.  0 could represent unlimited iterations.
Thoughts?

On Mon, Sep 24, 2018 at 5:46 PM Lonnie Abelbeck <notifications@github.com>
wrote:

> Thanks @nhorman <https://github.com/nhorman> for adding the volatile and
> doing the research.
>
> I spent most of the day testing, and I thought I would share performance
> results on two common VM cases, Vultr and Linode. Both single core, Vultr
> 2.4 GHz and Linode 2.8 GHz CPU's. Both KVM based.
>
> Vultr 1-CPU 1-GB RAM - https://www.vultr.com/pricing/
>
> vultr ~ # lspci
> 00:00.0 Host bridge: Intel Corporation 440FX - 82441FX PMC [Natoma] (rev 02)
> 00:01.0 ISA bridge: Intel Corporation 82371SB PIIX3 ISA [Natoma/Triton II]
> 00:01.1 IDE interface: Intel Corporation 82371SB PIIX3 IDE [Natoma/Triton II]
> 00:01.2 USB controller: Intel Corporation 82371SB PIIX3 USB [Natoma/Triton II] (rev 01)
> 00:01.3 Bridge: Intel Corporation 82371AB/EB/MB PIIX4 ACPI (rev 03)
> 00:02.0 VGA compatible controller: Cirrus Logic GD 5446
> 00:03.0 Ethernet controller: Red Hat, Inc. Virtio network device
> 00:04.0 SCSI storage controller: Red Hat, Inc. Virtio block device
> 00:05.0 Unclassified device [00ff]: Red Hat, Inc. Virtio memory balloon
> 00:06.0 Unclassified device [00ff]: Red Hat, Inc. Virtio RNG
>
> # rdrand without aes-ni
> vultr ~ # rngd -t -x hwrng -x jitter -O rdrand:use_aes:0
>
> Entropy gathered: 6.348600e+08 bits
> ...
> Entropy gathered: 6.771800e+08 bits
>
> Entropy rate:  639.3 Mbits/sec averaged over 31 iterations for  31.01 seconds
>
>
> # rdrand with aes-ni
> vultr ~ # rngd -t -x hwrng -x jitter -O rdrand:use_aes:1
>
> Entropy gathered: 1.260000e+06 bits
> ...
> Entropy gathered: 1.280000e+06 bits
>
> Entropy rate:  1.197 Mbits/sec averaged over 27 iterations for  27.21 seconds
>
>
> # virtio_rng
> vultr ~ # rngd -t -x rdrand -x jitter
>
> Entropy gathered: 3.260000e+06 bits
> ...
> Entropy gathered: 4.280000e+06 bits
>
> Entropy rate:  3.787 Mbits/sec averaged over 36 iterations for  36.11 seconds
>
>
> # jitter
> vultr ~ # rngd -t -x hwrng -x rdrand
>
> Entropy gathered: 2.000000e+04 bits
> ...
> Entropy gathered: 2.000000e+04 bits
>
> Entropy rate:  19.53 Kbits/sec averaged over 52 iterations for  52.01 seconds
>
> Linode 1-CPU 1-GB RAM - https://www.linode.com/pricing
>
> linode ~ # lspci
> 00:00.0 Host bridge: Intel Corporation 82G33/G31/P35/P31 Express DRAM Controller
> 00:01.0 VGA compatible controller: Device 1234:1111 (rev 02)
> 00:02.0 SCSI storage controller: Red Hat, Inc. Virtio SCSI
> 00:03.0 Ethernet controller: Red Hat, Inc. Virtio network device
> 00:1f.0 ISA bridge: Intel Corporation 82801IB (ICH9) LPC Interface Controller (rev 02)
> 00:1f.2 SATA controller: Intel Corporation 82801IR/IO/IH (ICH9R/DO/DH) 6 port SATA Controller [AHCI mode] (rev 02)
> 00:1f.3 SMBus: Intel Corporation 82801I (ICH9 Family) SMBus Controller (rev 02)
>
>
> # rdrand without aes-ni
> linode ~ # rngd -t -x hwrng -x jitter -O rdrand:use_aes:0
>
> Entropy gathered: 6.786800e+08 bits
> ...
> Entropy gathered: 6.801800e+08 bits
>
> Entropy rate:  648.3 Mbits/sec averaged over 42 iterations for  42.01 seconds
>
>
> # rdrand with aes-ni
> linode ~ # rngd -t -x hwrng -x jitter -O rdrand:use_aes:1
>
> Entropy gathered: 1.280000e+06 bits
> ...
> Entropy gathered: 1.280000e+06 bits
>
> Entropy rate:  1.206 Mbits/sec averaged over 39 iterations for  39.44 seconds
>
>
> # No virtio_rng support
>
>
> # jitter
> linode ~ # rngd -t -x hwrng -x rdrand
>
> Entropy gathered: 2.000000e+04 bits
> ...
> Entropy gathered: 2.000000e+04 bits
>
> Entropy rate:  19.53 Kbits/sec averaged over 66 iterations for  66.01 seconds
>
> I was somewhat surprised rdrand without aes-ni had more than 500x
> performance than with aes-ni. It may be related to how KVM implements
> aes-ni.
>
> As a point of reference, here is the performance of a bare-metal 4-thread
> Intel Core i3-6100U CPU @ 2.30GHz
>
> # rdrand without aes-ni
> linode ~ # rngd -t -x hwrng -x jitter -O rdrand:use_aes:0
>
> Entropy gathered: 2.911400e+08 bits
> ...
> Entropy gathered: 2.911400e+08 bits
>
> Entropy rate:  277.6 Mbits/sec averaged over 41 iterations for     41 seconds
>
>
> # rdrand with aes-ni
> linode ~ # rngd -t -x hwrng -x jitter -O rdrand:use_aes:1
>
> Entropy gathered: 1.295600e+08 bits
> ...
> Entropy gathered: 1.302000e+08 bits
>
> Entropy rate:  122.7 Mbits/sec averaged over 45 iterations for     45 seconds
>
>
> # No virtio_rng support
>
>
> # jitter
> linode ~ # rngd -t -x hwrng -x rdrand
>
> Entropy gathered: 5.400000e+05 bits
> ...
> Entropy gathered: 6.000000e+04 bits
>
> Entropy rate:  197.3 Kbits/sec averaged over 74 iterations for     79 seconds
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/nhorman/rng-tools/commit/989730d2a5e6f27d2e63afbe086022c06af5dea9#commitcomment-30627614>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AA_C3tUcgJbJMRGr1A4UFQK39wghQhJ0ks5ueVKzgaJpZM4W3gyN>
> .
>


P.S.I also noticed here the large disrepancy of rdrand entropy with and
without AES.  I wonder if its worth changing the default

On Mon, Sep 24, 2018 at 8:10 PM Neil Horman <nhorman@gmail.com> wrote:

> Thats pretty handy to know, thank you.  Two thoughts:
>
> 1) Is it worth keeping a document of these results somewhere?  On the one
> hand it might be nice to have some data, on the other, keepting it up to
> date and accurate might a a real pita
>
> 2) I wonder if its worth enhancing test mode to take an integer argument
> on the command line representing number of iterations before exit, so that
> you can get a consistent number of iterations without having to wait on the
> console to ctrl-c out of it.  0 could represent unlimited iterations.
> Thoughts?
>
> On Mon, Sep 24, 2018 at 5:46 PM Lonnie Abelbeck <notifications@github.com>
> wrote:
>
>> Thanks @nhorman <https://github.com/nhorman> for adding the volatile and
>> doing the research.
>>
>> I spent most of the day testing, and I thought I would share performance
>> results on two common VM cases, Vultr and Linode. Both single core, Vultr
>> 2.4 GHz and Linode 2.8 GHz CPU's. Both KVM based.
>>
>> Vultr 1-CPU 1-GB RAM - https://www.vultr.com/pricing/
>>
>> vultr ~ # lspci
>> 00:00.0 Host bridge: Intel Corporation 440FX - 82441FX PMC [Natoma] (rev 02)
>> 00:01.0 ISA bridge: Intel Corporation 82371SB PIIX3 ISA [Natoma/Triton II]
>> 00:01.1 IDE interface: Intel Corporation 82371SB PIIX3 IDE [Natoma/Triton II]
>> 00:01.2 USB controller: Intel Corporation 82371SB PIIX3 USB [Natoma/Triton II] (rev 01)
>> 00:01.3 Bridge: Intel Corporation 82371AB/EB/MB PIIX4 ACPI (rev 03)
>> 00:02.0 VGA compatible controller: Cirrus Logic GD 5446
>> 00:03.0 Ethernet controller: Red Hat, Inc. Virtio network device
>> 00:04.0 SCSI storage controller: Red Hat, Inc. Virtio block device
>> 00:05.0 Unclassified device [00ff]: Red Hat, Inc. Virtio memory balloon
>> 00:06.0 Unclassified device [00ff]: Red Hat, Inc. Virtio RNG
>>
>> # rdrand without aes-ni
>> vultr ~ # rngd -t -x hwrng -x jitter -O rdrand:use_aes:0
>>
>> Entropy gathered: 6.348600e+08 bits
>> ...
>> Entropy gathered: 6.771800e+08 bits
>>
>> Entropy rate:  639.3 Mbits/sec averaged over 31 iterations for  31.01 seconds
>>
>>
>> # rdrand with aes-ni
>> vultr ~ # rngd -t -x hwrng -x jitter -O rdrand:use_aes:1
>>
>> Entropy gathered: 1.260000e+06 bits
>> ...
>> Entropy gathered: 1.280000e+06 bits
>>
>> Entropy rate:  1.197 Mbits/sec averaged over 27 iterations for  27.21 seconds
>>
>>
>> # virtio_rng
>> vultr ~ # rngd -t -x rdrand -x jitter
>>
>> Entropy gathered: 3.260000e+06 bits
>> ...
>> Entropy gathered: 4.280000e+06 bits
>>
>> Entropy rate:  3.787 Mbits/sec averaged over 36 iterations for  36.11 seconds
>>
>>
>> # jitter
>> vultr ~ # rngd -t -x hwrng -x rdrand
>>
>> Entropy gathered: 2.000000e+04 bits
>> ...
>> Entropy gathered: 2.000000e+04 bits
>>
>> Entropy rate:  19.53 Kbits/sec averaged over 52 iterations for  52.01 seconds
>>
>> Linode 1-CPU 1-GB RAM - https://www.linode.com/pricing
>>
>> linode ~ # lspci
>> 00:00.0 Host bridge: Intel Corporation 82G33/G31/P35/P31 Express DRAM Controller
>> 00:01.0 VGA compatible controller: Device 1234:1111 (rev 02)
>> 00:02.0 SCSI storage controller: Red Hat, Inc. Virtio SCSI
>> 00:03.0 Ethernet controller: Red Hat, Inc. Virtio network device
>> 00:1f.0 ISA bridge: Intel Corporation 82801IB (ICH9) LPC Interface Controller (rev 02)
>> 00:1f.2 SATA controller: Intel Corporation 82801IR/IO/IH (ICH9R/DO/DH) 6 port SATA Controller [AHCI mode] (rev 02)
>> 00:1f.3 SMBus: Intel Corporation 82801I (ICH9 Family) SMBus Controller (rev 02)
>>
>>
>> # rdrand without aes-ni
>> linode ~ # rngd -t -x hwrng -x jitter -O rdrand:use_aes:0
>>
>> Entropy gathered: 6.786800e+08 bits
>> ...
>> Entropy gathered: 6.801800e+08 bits
>>
>> Entropy rate:  648.3 Mbits/sec averaged over 42 iterations for  42.01 seconds
>>
>>
>> # rdrand with aes-ni
>> linode ~ # rngd -t -x hwrng -x jitter -O rdrand:use_aes:1
>>
>> Entropy gathered: 1.280000e+06 bits
>> ...
>> Entropy gathered: 1.280000e+06 bits
>>
>> Entropy rate:  1.206 Mbits/sec averaged over 39 iterations for  39.44 seconds
>>
>>
>> # No virtio_rng support
>>
>>
>> # jitter
>> linode ~ # rngd -t -x hwrng -x rdrand
>>
>> Entropy gathered: 2.000000e+04 bits
>> ...
>> Entropy gathered: 2.000000e+04 bits
>>
>> Entropy rate:  19.53 Kbits/sec averaged over 66 iterations for  66.01 seconds
>>
>> I was somewhat surprised rdrand without aes-ni had more than 500x
>> performance than with aes-ni. It may be related to how KVM implements
>> aes-ni.
>>
>> As a point of reference, here is the performance of a bare-metal 4-thread
>> Intel Core i3-6100U CPU @ 2.30GHz
>>
>> # rdrand without aes-ni
>> linode ~ # rngd -t -x hwrng -x jitter -O rdrand:use_aes:0
>>
>> Entropy gathered: 2.911400e+08 bits
>> ...
>> Entropy gathered: 2.911400e+08 bits
>>
>> Entropy rate:  277.6 Mbits/sec averaged over 41 iterations for     41 seconds
>>
>>
>> # rdrand with aes-ni
>> linode ~ # rngd -t -x hwrng -x jitter -O rdrand:use_aes:1
>>
>> Entropy gathered: 1.295600e+08 bits
>> ...
>> Entropy gathered: 1.302000e+08 bits
>>
>> Entropy rate:  122.7 Mbits/sec averaged over 45 iterations for     45 seconds
>>
>>
>> # No virtio_rng support
>>
>>
>> # jitter
>> linode ~ # rngd -t -x hwrng -x rdrand
>>
>> Entropy gathered: 5.400000e+05 bits
>> ...
>> Entropy gathered: 6.000000e+04 bits
>>
>> Entropy rate:  197.3 Kbits/sec averaged over 74 iterations for     79 seconds
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/nhorman/rng-tools/commit/989730d2a5e6f27d2e63afbe086022c06af5dea9#commitcomment-30627614>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/AA_C3tUcgJbJMRGr1A4UFQK39wghQhJ0ks5ueVKzgaJpZM4W3gyN>
>> .
>>
>


can you git amend the message?


`string beneficiary` is confusing. It's okay to write things out for clarity. I think you mean

`function returnHash(address exchangeAddr, string beneficiarySecret) public view ...`

I see some confusion below so it's not clear to me that you're on track here.

This is a `view` function, which means clients can safely use it without revealing the arguments to the network (which would be bad). So

1. Alice tells Bob the password (off-chain)
2. Alice passes the exchange's address and Bob's password into this function to generate the hash OFF-chain.
3. Now that Alice has the magic hash, she sends funds, the hash, and other details to `createRemittance`.
4. Bob gives Carol the secret word (off-chain)
5. Carol calls `claimRemittance`, this time msg.sender and Bob's password magically match the hash stored in the contract and the money comes out.

To ensure no difference between the hash function Alice is using and the hash function the contract is using, this function should be used internally as well as by Alice.


Yeah, but that one's a bit more important for people to know.


I am a python newbie,  but very experienced programmer.

On the page you have the expression...
   -5 != False != True #=> True

This made absolutely no sense to me as a newbie, as I read that expression as being equivalent to
  (-5 != False) != True

Which is of course False,  Not True.

Until I saw further down the page...
   # Comparisons can be chained!

I would suggest you move that expression to the 'chained' section, and then add the explanation...
  -5 != False != True #=> True
  # chained to be equivalent to   (-5 != False) and (False != True)

Remember this doc is for newbies (like me), and you should not example something before it is introduced.

Thank you
Anthony


Have you ever considered possible false positives of this regex? Are you aware of the fact that this is a generated code and you're matching some generated helper variable? I can't even find a good parable to express how bad and insane this is.

If you can't find any better workaround, write a patch file (with at least 3 lines of context), not a regexp.


read message works, we are getting somewhere!


Done. As a consequence, the commit we are commenting on is now no longer a part of master.


`function createRemittance(bytes32 hash, address exchangeAddr) public payable ...`

This is where Alice passes it in. There is a security issue that gets plugged by being very explicit about who is allowed to claim this, otherwise the address argument wouldn't be necessary.

You can optionally decide how you want to handle deadlines. It could be the same for all, or an argument passed in here.


Hi hi


This would be a good place to re-use the `returnHash()` function. The code is a little hard on the eyes and it's vital that it gets done the same way in all contexts.


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


Ok thanks


It’s no biggie, leave in if easier. We can always mass-change with a script. I’d suggest the binary that comes with phpcs for auto-fixing things, once it’s merged in and happy with the rules. There’s also plugins like https://github.com/FriendsOfPHP/PHP-CS-Fixer

Many changes does make the SVN release to wp.org slow, but freemius is the biggest offender there. AWS, too, but I’m set to replace with a minimal S3 lib soon as possible. I was struggling last time with the AWS hmac256(?) auth signing, but recently conquered that style in a Ruby Freemius API in another repo, so ready for a rematch. The smaller filesize the plugin the better, so even if we have some needed commenting for devs, we can strip out in a release script.


I prefer this.props.notifications.map instead of populating a variable in a loop.  Style choice


Scores: 2/2


scores: 2/2


redux state should not be mutated.


I see you did. In case it isn't clear, `public` create a function for you. Since the mapping points to RemittanceStructs, you get all this:

```
function remittanceStructs(bytes32 index) public view(returns uint, uint, address, address) {
  return (
    remittanceStructs[index].balance,
    remittanceStructs[index].deadline,
    remittanceStructs[index].exchange,
    remittanceStructs[index].owner);
}
```


This looks like a really solid start to me!


return { ...state, state.notifications.concat(action.payload)}


Cuadro de texto


`0.0f` is used to define a `float`. You can just use `0` to define `double`


That's ***OUR*** code. Don't be a meanie!


Botón!


hoooooooooooooooooooooo


addNotification would be a more accurate name


[sadatnfs/02_linter_fails.R:2:8:](https://github.com/sadatnfs/rt-code-review/blob/12a0132399424bbb23c299cebb4c5c9ce53a3992/sadatnfs/02_linter_fails.R#L2) *style:* **Put spaces around all infix operators.**
```r
rm(list=ls())
      ~^~
```


dfffffffffffff


center option already at line 75 in this commit?


Great!


Farid Uddin Khan


Total scores: 10/10


Successfully aliased the URL <https://micro-jwt-usahyyapgs.now.sh> to the following alias.

* https://jwt.wezeit.co


### Lipsum Really?

So we __really__ were not able to find better filler text?


### Lipsum Really?

So we __really__ were not able to find *better* filler text?


Successfully aliased the URL <https://micro-jwt-osopqxfrlu.now.sh> to the following alias.

* https://jwt.wezeit.co


wsss


Learning to use python....?

Making edits


The text here is a little off. can we use this instead to make it country-agnostic. "Invalid zip code entered."


I identify as a variable (`var`, `vars`), and the `const` keyword goes against everything that I am.
Therefore, if you reject my PR to remove all `const` keywords, you are being discriminatory against variables.


hh what


Added a new text file


shouldn't this check if the zip field exists first? otherwise it will throw more airbrakes


> Apache/PHP default upload size is 2MB, which we’re now under, preventing loss of users who can’t manually upload it.

Aah, so that's where removing comments came into play... well, FWIW, you could always move S3 support to the paid version which isn't restricted by the WP repository's no-remote-download rule (if you think free users are less likely to be invested in S3 - I'd bet they're an edge case, though WP repository's rules make checking up on that impossible... d'oh).


**Question:** OK if I mark up this PR with "???" comments where I see potentially-dangerous filesystem calls and the like? (e.g. `file_put_contents()` w/o a prior check to confirm `is_writeable()`)


(... well, more aptly, that'd need to be a recursive search of parent directory/directories until it's confirmed that `$path` or nearest-existing `dirname()` `is_writeable()` ...)


Código modificado e de acordo com a necessidade requisitada.


IBM Cloud [toolchain](https://console.ng.bluemix.net/devops/toolchains/f094bbc3-fc3f-402f-b769-7d23d4d5533c?env_id=ibm%3Ayp%3Aus-south "hive764"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/8e16040c-6017-478f-90c4-f224ad9a140e?env_id=ibm%3Ayp%3Aus-south "HIVE764") deployed [hive](https://github.com/WEITAO764/hive/releases/tag/deploy-ibm-yp-us-south-wtao-deakin.edu.au_1532874841224-dev-20180925-005323 "deploy-ibm-yp-us-south-wtao-deakin.edu.au_1532874841224-dev-20180925-005323") to [dev](https://console.bluemix.net/apps/247b1604-f5f3-41a1-b4ba-3af134758235?env_id=ibm:yp:us-south "ibm:yp:us-south:wtao@deakin.edu.au_1532874841224:dev"), including this commit


scores: 2/2


sdsa s assasadas


Remoção Da diciplina Ciencias


Check the logic here. When age <= 50. It will always go into this section.


scores: 1/2


oo_plant_load_profile (drewyh) - Win64-Windows-7-VisualStudio-14: OK (3033 of 3033 tests passed, 9 test warnings)

Messages:

 * 9 tests had: ESO small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


what if `e3.salary <= h.salary`?


Total scores: 10/10


IBM Cloud [toolchain](https://console.ng.bluemix.net/devops/toolchains/f094bbc3-fc3f-402f-b769-7d23d4d5533c?env_id=ibm%3Ayp%3Aus-south "hive764"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/8e16040c-6017-478f-90c4-f224ad9a140e?env_id=ibm%3Ayp%3Aus-south "HIVE764") deployed [hive](https://github.com/WEITAO764/hive/releases/tag/deploy-ibm-yp-us-south-wtao-deakin.edu.au_1532874841224-dev-20180925-010059 "deploy-ibm-yp-us-south-wtao-deakin.edu.au_1532874841224-dev-20180925-010059") to [dev](https://console.bluemix.net/apps/247b1604-f5f3-41a1-b4ba-3af134758235?env_id=ibm:yp:us-south "ibm:yp:us-south:wtao@deakin.edu.au_1532874841224:dev"), including this commit


bug it must be 'combined'


Nice question, I did it year ago, I can't recall why.

Possible options:
* Is a [bias](https://en.wiktionary.org/wiki/if_all_you_have_is_a_hammer,_everything_looks_like_a_nail),
* I don't know this option before,
* Or maybe this function return parent name.

:thinking:

Anyway I take a look when I can, but you can open a PR ;)


Great job!


Total scores: 10/10
For the `tripleSalary` function. We'd better not modify the employee data in this `public void tripleSalary(Employee employee)`. In stead we'd better write a function in `Employee` class called `public void raiseSalary(double byPercent)`. Then in `tripleSalary` we just call `employee.raiseSalary(percent);`
Good job!
Upload the java file next time.


Authors@R is the right way to do it for the future anyway.


Total scores: 10/10
Good job! Really impressed!
Feel free to upload the java file next time. No need to paste into a PDF.


original


Base Dijkstra


scores: 2/2
We'd better not modify the employee data in this funtion.
In stead we'd better write a function in `Employee` class called `public void raiseSalary(double byPercent)`.
Then in `tripleSalary` we just call `employee.raiseSalary(percent);`


Good


scores: 2/2


This file has been deleted: Unicode Error.


please print names here.


Looks great


scores: 1/1


Total scores: 2/2


Thanks, I appreciate the edits --- I think that (much like the code) these docs will need a lot of editing before they're "production ready" :) I've mainly just been trying to get some rough stuff written down so it can be iterated on further, so I'm not attached to any of the writing here.


the coolest typo


Removed in c017b9a4602821f3ef6f70337a307789c88a7fdf .


thanks!


`https: //api.heureka. [TLD] / certifikace obchodu / v2 / [ACTION] "


[CodeFactor](https://www.codefactor.io/repository/github/quinntdip/quinntdip/overview/master) found an issue: Duplicate Code

It's currently on:
[assets\sass\libs\_vendor.scss:257-285
](https://www.codefactor.io/repository/github/quinntdip/quinntdip/source/master/assets/sass/libs/_vendor.scss#L257)[assets\sass\libs\_functions.scss:6-34
](https://www.codefactor.io/repository/github/quinntdip/quinntdip/source/master/assets/sass/libs/_functions.scss#L6)Commit 94c2c20edff23848f3318379687c27b612364d0b


Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

- @lincrosenbach was added to conda-forge. Welcome to conda-forge!
  Go to https://github.com/orgs/conda-forge/invitation see your invitation.

You should get push access to this feedstock and CI services.

Feel free to join the community [chat room](https://gitter.im/conda-forge/conda-forge.github.io).

NOTE: Please make sure to not push to the repository directly.
      Use branches in your fork for any changes and send a PR.
      More details [here](https://conda-forge.org/docs/conda-forge_gotchas.html#using-a-fork-vs-a-branch-when-updating-a-recipe)


@dee9205 i have not deleted any redme file


Successfully aliased the URL <https://next-calorie-bmbmfvltgu.now.sh> to the following alias.

* https://calorie.now.sh


There's only a single `<input name="emailHash">` now?


Good job!


Total scores: 10/10


scores: 2/2


What's the logic here? The old resampling function has been working and it just stopped today?
I cannot figure out what has changed, the server side?


Good job


oo_boiler_refactor (drewyh) - i386-Windows-7-VisualStudio-14: OK (3034 of 3034 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


Should we just add this whole file to `.eslintignore`?


Can we add a link to where this shim/polyfill came from?


Good work with the MVP JP.
You have solid understanding of basics of testing.
Try and work on stretch goals


Add a link to the repo where all this code came from?

https://github.com/polycrypt/polycrypt


Should have sent a poet.


I introduced a bug a couple versions ago when I modified the code to resample one channel at a time. I thought this modification would fix it. You are getting an error?


ValueError: Expected 2D array, got 1D array instead:
array=[ 0.49000001  0.28999999  0.47999999  0.5         0.56        0.23999999
  0.34999999].
Reshape your data either using array.reshape(-1, 1) if your data has a single feature or array.reshape(1, -1) if it contains a single sample.
About this problem，can you tell me how to solve it？ thanks


> 1) Is it worth keeping a document of these results somewhere?

Things change so much, so often, the half-life is probably too short to be worth it.

> 2) I wonder if its worth enhancing test mode to take an integer argument on
the command line representing number of iterations before exit

Having a consistent value of `n` does not matter much in my testing, rdrand is very stable, jitter is more variable and has to run longer.  I think comparisons can be made with different iteration values.

The most benefit I see for an `n` option would be for use in a script collecting results, though the `timeout` command could be used to gracefully limit the time with results.

I have no major opinion to add it or leave it as is.

> P.S.I also noticed here the large disrepancy of rdrand entropy with and
without AES.  I wonder if its worth changing the default

The really huge discrepancy is on the KVM, on bare metal is it 2x in favor of without aes-ni.

So that begs the question, in a VM is the `rdrand` always a trustworthy, transparent forwarding from the host's CPU ?  If the answer is yes, then defaulting to that might be the better default.

BTW, In AstLinux we set our init.d script to always use `-O rdrand:use_aes:0`


I see. I think I know what's going on (It's on my end). I updated your function on Friday, but never ran this function until today. I guess the version I was using then was fine. It is almost a coincidence that you choose to fix this function today.... Thanks!

I still have a question: why you have to resample by channel?  Does the following code have some unwanted result?
r_filter = ResampleFilter(eeg, resample_freq)
eeg = r_filter.filter()


Great.  😄


Great job!


yess


Hmm. Why aren't these changes merged with the master? I don't know who to fork from.


Total scores: 10/10


@benjohnde , i can handle #351, but that means you want to split ZXCapture.* outside ZXingObjC ? If not, how about the rest in `client` folder ?


scores: 2/2


Good job.


An (easier) alternative is to stick with v3. It's not that obvious, but the main bootswatch page has a link to previous versions which in this case is [https://bootswatch.com/3/](https://bootswatch.com/3/). Note that MVC project template also uses NuGet Bootstrap v3.... if using v3 then no need to upgrade this package either.


已修复，具体查看https://github.com/EmptyCup20/easy-tool/commit/44946a214653fdb806778d1df60e8c5dea078ada


IBM Cloud [toolchain](https://console.ng.bluemix.net/devops/toolchains/f094bbc3-fc3f-402f-b769-7d23d4d5533c?env_id=ibm%3Ayp%3Aus-south "hive764"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/8e16040c-6017-478f-90c4-f224ad9a140e?env_id=ibm%3Ayp%3Aus-south "HIVE764") deployed [hive](https://github.com/WEITAO764/hive/releases/tag/deploy-ibm-yp-us-south-wtao-deakin.edu.au_1532874841224-dev-20180925-015321 "deploy-ibm-yp-us-south-wtao-deakin.edu.au_1532874841224-dev-20180925-015321") to [dev](https://console.bluemix.net/apps/247b1604-f5f3-41a1-b4ba-3af134758235?env_id=ibm:yp:us-south "ibm:yp:us-south:wtao@deakin.edu.au_1532874841224:dev"), including this commit


Sample to show adding notification from other components


Hacky stuff to make the menu work easily for stub component


哈？不好意思，没看懂什么意思，补充什么选题？


Add action to component prop


maybe this should go in the notification action.  Or maybe notification should expose info, error, and alert actions.


cap nhat


No need for local state.  Pure functional component works fine.


已修复成fransform，具体查看https://github.com/EmptyCup20/easy-tool/commit/9c7f082bf2b3d8983ce2683b94605760be38510b


scores: 1/2
Please print all the names.
We'd better not modify the data in each employee. Just find a way to print their names in order.


This gives access to props.notifications.  It should stay updated as long as redux state is managed appropriately through actions.


完了，那我一颗星都拿不到了


scores: 1/2
Again, don't put these functions in the `Employee` class.
However, put `public void raiseSalary(double byPercent) {` in the `Employee` class.


Making sure to not modify the state.  Only return new state.


IBM Cloud [toolchain](https://console.ng.bluemix.net/devops/toolchains/f094bbc3-fc3f-402f-b769-7d23d4d5533c?env_id=ibm%3Ayp%3Aus-south "hive764"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/8e16040c-6017-478f-90c4-f224ad9a140e?env_id=ibm%3Ayp%3Aus-south "HIVE764") deployed [hive](https://github.com/WEITAO764/hive/releases/tag/deploy-ibm-yp-us-south-wtao-deakin.edu.au_1532874841224-dev-20180925-015901 "deploy-ibm-yp-us-south-wtao-deakin.edu.au_1532874841224-dev-20180925-015901") to [dev](https://console.bluemix.net/apps/247b1604-f5f3-41a1-b4ba-3af134758235?env_id=ibm:yp:us-south "ibm:yp:us-south:wtao@deakin.edu.au_1532874841224:dev"), including this commit


scores: 2/2


Total scores: 10/10


Does this fix https://github.com/openai/gym/issues/748 ?


i haven't finished the modal just noticed


We should check if the feature type source was not found , i.e. ``NULL``, and throw an exception (like is done for the data store). Otherwise ``NULL`` will be returned and interpreted as: no index was configured, instead of: an index was configured but the source type not found.


although the modal is working fine it needs a little more css


Should be dist...


em vez de alinhar a imagem com o texto alinhei o texto com a imagem
adicionei um id para no css consguir identificar apenas esse elemento p


Oh it reverted to my original commit, sorry, misread :)


corrigi isso noutro commit


How about adding a server config for this one?


ja esta no cmmit mais recente


Ok, thanks!


I'm so happy for this change!
I just had to tell someone so I'll use this comment :D


oo_boiler_refactor (drewyh) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2950 of 3074 tests passed, 33 test warnings)

Messages:

 * 157 tests had: BND diffs.
 * 152 tests had: MDD diffs.
 * 157 tests had: MTD diffs.
 * 152 tests had: RDD diffs.
 * 124 tests had: Table big diffs.
 * 132 tests had: ESO small diffs.
 * 99 tests had: MTR small diffs.
 * 92 tests had: EIO diffs.
 * 2 tests had: AUD diffs.

Failures:

regression Test Summary
 * Passed: 527
 * Failed: 124

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-95.97%25-yellow.png)


sdsdsdsd


I would add:
```
/** field of the external type (e.g. Solr document) that will be used as an index **/
```


Update the schame! 😝

![](https://media.giphy.com/media/Ob7p7lDT99cd2/giphy.gif)


[Capstone ideas.docx](https://github.com/Zeinagkoub/test/files/2414742/Capstone.ideas.docx)


This check was correct. When setting the `new default value`, if the value was the same as the `old default value`, the value needs to be set to the `new default value`.

For some reason it makes the application not reading some preferences correctly. Fixed in 1f700e9b5f141968589145c67b109e5b3c958936


这里为什么要判断是不是触屏呢，触摸事件不是可以触发鼠标事件的吗，这样做没必要啊


I would sugest:
```
 /**
  * Field of the external type (e.g. Solr document) that will be used as an index. Will be NULL
  * if no external index is being used.
  */
```


Hm, so either this commit didn't work, or somewhere further in the output chain the newlines are modified or translated. This does not seem to happen in our code, so maybe in Java's PrintWriter/OutputStream stuff: https://github.com/arduino/Arduino/blob/2f6d2112cf13532ae541cae464a0f4a54a7a92c9/arduino-core/src/processing/app/legacy/PApplet.java#L313-L327


You should probably be using Debug.write() and Info.write() instead of print statements (here and other places)


changed already


Typo


IBM Cloud [toolchain](https://console.ng.bluemix.net/devops/toolchains/ebb9fcb3-a4f8-46bb-9dc6-2ec5d208f3b1?env_id=ibm%3Ayp%3Aus-south "acqol-deux"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/1a74dd51-73bc-4fa3-a136-fcfd99e0daa2?env_id=ibm%3Ayp%3Aus-south "acqol-deux") deployed [acqol-deux](https://github.com/SIT782ACQOLDEUX/acqol-deux/releases/tag/deploy-ibm-yp-us-south-ansley-deakin.edu.au-dev-20180925-101218 "deploy-ibm-yp-us-south-ansley-deakin.edu.au-dev-20180925-101218") to [dev](https://console.bluemix.net/apps/d8c0e304-cee4-4124-a831-708af13fa45c?env_id=ibm:yp:us-south "ibm:yp:us-south:ansley@deakin.edu.au:dev"), including this commit


oo_boiler_refactor (drewyh) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


Yes it's `PrintWriter.println()` that outputs the newline according to the current system standard


测试账号内置了私钥。就是那个游客登录按钮。


You know, it is possible for a contract to have its balance increase without a transaction.
When someone does `selfdestruct(yourContract)` from their own contract, `yourContract` will see its balance increase, even if you did not allow it in the code.
So `B` will "have more".


@yanli2017 Have you revoked the generated token on the screenshot?


Yes these testing print statements have been removed in the subsequent commit before being pushed to the repo


Can you refactor so that there can be many splits in flight for anyone?
Hint, A and B are no longer defined in the constructor:

```solidity
function split(address bob, address carol) payable {
```


@dellis1972 The idea of this commit is totally correct, but unfortunately, it has a typo on it!

You can see the tag `AndroidAap2LinkExtraArgs ` must be `AndroidAapt2LinkExtraArgs`

This is neccesary to your rule to work.

Should I made a PR, or you're OK fixing it by yourself?


小程序不支持单页应用的路由跳转，否则就不是以page维度的应用了。这个需要配合小程序的router系统，自己修改。


Please take 5 minutes too look at this class before you add code to it and then after you add code to it, do you notice any difference ? Was the code flow easy to follow ? Did the methods had a clear meaning ?


I don't really see the advantage of doing that.

Also: "When the language value is really an attribute of or metadata about some external content, then xml:lang is not an appropriate choice." -> I guess that applies.


Not sure why `onlyOwner` ensures fair play. Also you are negating the benefits of public blockchain whereby you would have a robust contract that ensures fair play by code and let others do the necessary actions.


To remove.


Then I think you can remove the `onlyOneParty` modifier and save gas.


Please link JBEAP jira here ....


IBM Cloud [toolchain](https://console.eu-de.bluemix.net/devops/toolchains/4295545d-7c62-4e10-ba0d-abbafb106524?env_id=ibm%3Ayp%3Aeu-de "cloud-native-toolchain-tutorial-20180711095018056"): [Delivery Pipeline](https://console.eu-de.bluemix.net/devops/pipelines/e36d8f9d-907a-4e06-913a-ecf3e7bc1d6e?env_id=ibm%3Ayp%3Aeu-de "sample-cloud-native-toolchain-tutorial-20180711095018056") deployed [sample-cloud-native-toolchain-tutorial-20180711095018056](https://github.com/kheymann/sample-cloud-native-toolchain-tutorial-20180711095018056/releases/tag/deploy-ibm-yp-eu-de-Katrin.Heymann_org-test-20180925-101849 "deploy-ibm-yp-eu-de-Katrin.Heymann_org-test-20180925-101849") to [test](https://console.bluemix.net/apps/110dd19b-d2bf-4df6-805f-0addc1054b96?env_id=ibm:yp:eu-de "ibm:yp:eu-de:Katrin.Heymann_org:test"), including this commit


It is very unsettling to not see any accounting done here. I know, your unconventional way of using the balance and a subtraction ensures it works in this specific case...


remove this parameter please!


Now could not deploy this pull request as it was unable to determine the deployment type.
The repo contains both a Dockerfile and a package.json.

To fix this, set the type field in now.json.

For more information on now.json visit https://zeit.co/docs/features/configuration#now.json.


В классе CafeSwallow поле menuList немного некорректно. Нужно просто menu


If you want, you can change `lni-facebook-filled` for `lni-github`.


Looks like this is doing the same thing as the method ``private Set<String> extractAttributesNames(TypeMapping typeMapping)`` just above. Is nice to use new Java features, but is Java 8 streams really helping here ? And please add a comment saying what does this method is suppose to do.


Для проекта выбрана СУБД - MS SQL Server 2016.
Причины:
1) Лидер отрасли (Входит в тройку самых популярны РСУБД)
2) Возможность бесплатной разработки (MS SQL Server Developer Edition)
3) Расширенные функции безопасности (SQL Server — это база данных, которая
уже шесть лет признается наименее уязвимой по результатам тестов на
уязвимость в Национальном институте стандартов и технологий США (NIST).)
4) Высокая степень интеграция с другими продуктами Microsoft

вт, 25 сент. 2018 г. в 15:21, Viktor Krasikov <notifications@github.com>:

> Как это можно прочитать?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/Programmer86/BlindsManufactureSystem/commit/20d9a2947cfc40d111dd678e0a117b49cbd608cc#commitcomment-30635282>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AofmL-n-N6_uZhG8ARThu01Fn4hCY94xks5uegO0gaJpZM4W4TmJ>
> .
>


What is going on here ?


Se queres fazer dessa forma, apagamos o javascript original do mapa. Mas não dava para corrigir só o que estava mal?


@ThomasHabets it seems that this change broke the plugin for OpenVPN, rolling back to previous version fixed the problem


Missing white line  and extra ``*``.


Ummm... why are these deleted?


first commit


If ? the suspense is killing me.


Nota:
Realicé este commit y el anterior unos minutos después de enviar el mail. Son dos correcciones mínimas (una mini modificación de estilo y una errata en un string). Quería aclararlo por las dudas, porque puede ser confuso que haya modificado el proyecto tras su entrega y quiero dejar constancia de que esta es la versión final y no realizaré más cambios. Mil disculpas por la pequeña desprolijidad y saludos.


Created multidev environment [gtweb#ci-97](https://dashboard.pantheon.io/sites/48c6fbf0-589a-40de-bda2-16e7cd7c267d#ci-97).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-97-gtweb.pantheonsite.io/)


なんだこれ


Can be replaced with ``for each``.


Unnecessary cast.


ただ書いただけだった；


I have a feeling this method was partial copy \ paste from somewhere. This looks like the usual App-Schema code style.


Thank you for providing the proper coding process to Avoid using "router" context property. Such an useful information you are sharing with us. If anyone who want to know about entire process of it, then i suggest you to contact with **[Netgear Support Number](url)** for more help.


Thanks for the fix @quentinneyraud :-)


Can you elaborate this? What do you mean for "accounting" in this case? In a preceding version I was using two variables, remainingAFunds and remainingBFunds, to store the amounts. I choosed to eliminate remainingBFunds to reduce gas usage. It is not sufficient to maintain the fallback function below 2300 but it is a gas reduction anyway. There is another question: if I use two variables then I need to provide a way to get stored funds when received via selfdestruct(myContract). Is this a wrong line of thinking?


i don't understand how 2 flags work together, C++0x a-la C++11 for stdlib and GLIBCXX*CXX11 is set to false.


everything seems fine but when i open the numbers list i dont see any text can anybody help me please


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


这个辅助索引为什么就降低了性能，使用username搜索的时候辅助索引不是提升了搜索的性能么？


Sorry, my english is very basic and bad. I wanted to prevent payments due to someone's mistake


Why has this been removed?


o problema é aparecer aquela cena do developer mode, por causa da chave


搜索id的时候性能不变，搜索username的时候因为辅助索引性能提升-= =


throw annotation considered bad practice


@arswright I'm just about ready for that kind of review. I'd like to get all the functionality back first that I've been chopping and changing. Then I'll be happy to lock down master and starting working in feature/bugfix  branches for anything else.


Muito bem :)


oo_boiler_refactor (drewyh) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1770 of 1770 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-41.34%25-green.png)


额，辅助索引是可以提升搜索性能的，但是现在确实不需要了，因为登录的机制改变了


Looks like a test method, so probably should be moved


Atualiza a documentação


Why? Doesn‘t work?


Please remove hardcoded path


Was this here left from testing?


Use a separator like in other formats, i.e. `?`


I believe `HUGO_BUILD_TAGS=extended` does not work with the new installation instructions for fetching Hugo from sources.


Saw same compiler options above, we should probably extract them into 1 variable


same repetition for linker flags


Excited to start working with you !


@pulimento thanks for the report. I should be able to do a PR for that today.


переменная @first_station и @last_station лишние


这里是我设置有误，返回的都不是必须的，请求的的参数是有必须的，因为graphql不是用户想返回什么就返回什么么- =我这样写了反而是有问题的


seems that this commit breaks stream-button in responsive design. Transcoding Button works - document.portForm.fname is not used there.

TypeError: document.portForm.fname is undefined[Weitere Informationen] openwebif-1.2.18.min.js:1:30799


说的不是这里，这里没问题，比如下面那一个ProjectResponse，code和msg都不应该是必须的，用户想返回什么就可以返回什么


getDecryptionKey should work like an OpenGL/Vulkan function, you give it the length variable as a reference (or pointer) with the maximum length of the output array, then the function returns actual length of the output array it would like to have returned.


make that 16 for starters.


good


不过好像设置了也没用，页面和服务器都不会报错


@dlee I think we could even get rid of 'constant'. It was only ever used in iOS 11.0.


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


Do we need empy destructor instead of an auto-generated one?


Do we need empty constructor instead of an auto-generated one?


![](https://github.trello.services/images/mini-trello-icon.png) [Fix host deletion](https://trello.com/c/NyUdxL13/38-fix-host-deletion)


done


This was an attempt to get rid off lines that are seemingly superfluous. For a while seems works fine.


ja corrigi isso


ja esta


커밋


Mistake in syntax, it should be branch=master AND fork = false
Already fixed


Please write the description for variables, arguments and returns properly


Surely, it is safer to put `path.mkdir` in the sequential part of the script, but we would need to duplicate some code if we take it out of the function... I guess making a dir is a high-speed action, that's why I have left that inside the function, we could take it out..

I think there's no need to open an issue here, we can talk about this in Madrid.


Resources referenced for hiding keyboard:
https://stackoverflow.com/questions/1109022/close-hide-the-android-soft-keyboard#
https://stackoverflow.com/questions/4165414/how-to-hide-soft-keyboard-on-android-after-clicking-outside-edittext


It is better to handle the result of parsing


I suggest this method can be static.


> Speaker in calling will die

i just want to die


Do we really need this private variables?
I suggest no, as this variable exists as parameters in parser method


Added counter and "Finish" message


You didn't open Pull request, as you just send me link to the commit.
I suggest that all modification should be done on the branch, and merged with Pull Request.


You have not checked whether there is something at `pendingWithdrawals[passwordHash]`.
I am confused about your use of 2 different hashing mechanisms.


འདི་9/25ཉིན་ཀྱི་ཞུ་དག་བྱས་ཟིན་པ་དག་ཡིན། གོང་དུ་ཟླ་ཚེས་རྒྱག་ཡ་ནོར་འདུག


Better do actions after the checks.
Not only to protect your contract, but also to be a good citizen. You are asking miners to do work they may roll back in case a `require` fails.


![](https://github.trello.services/images/mini-trello-icon.png) [Make server directly executable when it is installed](https://trello.com/c/9BdzqVBx/15-make-server-directly-executable-when-it-is-installed)


bye


This is always true.
In general, don't bother with `require`s in `view` functions.


no


say hi eric


it also fix a memory leak issue. Even try to NSLog(notification.userInfo. managedObjectContext) will fire a memory leak.


Solid kode!


Thanks!


집적적인은 의도한 표현인가요?
직접적인으로 고치려다가 코멘트만 남겨봅니다.


This function is a rare `view` one where `require`s are warranted. Because you do not want to let users believe they have a valid hash if they passed wrong arguments.


浅田
全体に対して指摘します。
コメントが不足している部分があります、必ず1行に1コメントお願いします。
mainでは必ずretun0を付けてください。意味については調べてみてください。
余分なスペースが多いように感じます。周りと演算子の位置をそろえるなど意味のある空白であれば良いのですが、そうでないように感じます。


DeepCode analyzed this commit and found no issues.


Successfully aliased the URL <https://pebble-ejyykmbqsv.now.sh> to the following alias.

* https://pebble.now.sh


Collaborator: Review for this commit was created. [Link to review](http://217.170.125.19:40101/ui#review:id=19)


This still leads to false positives.
https://www.tera-online.ru/?didcmd=login

May be: `/popup/log$~xmlhttprequest,~subdocument`


unnötige Zeile


@crapo, this won't work. DId you commit it by accident?


Yes, not seeing a number go down, with say `-=`, is unsettling.

At this stage, you should not worry too much about funds sent your way with `selfdestruct`.


this is a very dangerous approach, think about when the format will evolve to take a scene-graph and you will have an arbitrary chain of parent-child links before you even get a reference to the meshes!


Cette ligne me semble étrange ...


I think if we expose this constructor, we should add the workspaceId parameter to it also. It is used in `GetUserDataByIdAndWorkspace` for User SQL Get.


Do we really need to check if the chat is public?
What would be the value if it's private? --> random

Better to call `chat->getNumPreviewers();` in all cases


<img width="197" alt="screenshot" src="https://user-images.githubusercontent.com/26359433/46011646-88f12d00-c094-11e8-939c-4d957da00eb3.png">


Same than above


Updated view of widget


@ghik thanks a lot!
Recompilation of the whole benchmark module fixed it.


this is in order not to have overruns on `decrKey` when you provide a too small output.


maybe find if there is a newline beginning with `v`


You’re welcome to help with a cohesive proposal for how it should work.

We didn’t remove it because we want to make your life difficult. We removed it because it was half-baked and there were several unresolved questions to which we didn’t find good solutions.


Det er meget efter ånden af den oprindelige kode.  Bare fordi @nqpz synes det er lokumskode betyder ikke nødvendigvis at jeg gør.  Men hvis han har problemer med det, kan han jo selv gøre det.


TeamCity WeSay :: wesay1.6-win32-install [Build 1.6.8.0.61.0ea32e50b63d0b69b35157809274823d332e5fbb](http://build.palaso.org/viewLog.html?buildId=130097&buildTypeId=WeSay15_Wesay16win32install) outcome was **FAILURE**
Summary: Execution timeout (new); tests failed: 3 (3 new), passed: 1383, ignored: 34 Build time: 00:35:40
### Failed tests
```
WeSay.Project.Tests.dll: WeSay.Project.Tests.ChorusBackupMakerTests.BackupNow_RemoveFile_RemovedFromBackupDir: <no details avaliable>

WeSay.Project.Tests.dll: WeSay.Project.Tests.WeSayWordsProjectTests.GetLexEntryRepository_LiftIsBad_NotfiesUser: <no details avaliable>

WeSay.UI.Tests.dll: WeSay.UI.Tests.AutoCompleteWithCreationBoxTests.SetPreviouslyEmptyItem: <no details avaliable>

```


1 part


I think `bdan:` and `bdac:` should have that too


Setting eyeVector to zero vector may not be the ideal solution here. I think the best fix would be to ensure that we don't try to set halfVector, unless the new shading models are in use, I.e.
```
#if OOSPECULAR_NEW_MODEL
	vec3 halfVector = normalize(lightVector + eyeVector);
#endif
```

Can you please try with this fix and see if you get errors on older ships? I would prefer this one if it works.


maybe a version with  begin and end iterators would be useful (can make it work with static or plain C-style arrays)


Successfully aliased the URL <https://pebble-uobcksvyef.now.sh> to the following alias.

* https://pebble.now.sh


[Feature](url)


请问怎么使用你这个库？没有看到使用说明文档


This could be done in more simple and S.O.l.i.d. (current changes violate SRP and OCP) way by creating a decorator class for `IQueue<ITask>` which `#put(T)` method will look like:

```Java
void put(ITask task) {
    IScope scope = /* current scope */;

    decorated.put(
        () -> {
            /* set current scope to value of "scope" */
            task.run();
        }
    );
}
```

(all other methods are delegated to decorated queue instance)

Such decorator will work with any possible implementation of `IQueue<ITask>` (with current changes we'll have to support the copy-pasted code for blocking and non-blocking versions of queue) and doesn't require modification of exist code.


Why not use python enums for this?


"with us telling you what we hoped to achieve"
Jag föredrar att inte försöka skriva som om VI pratar direkt med läsaren.


you don't need a vector, no GPU supports more than 16bit per dimension of addressing (so that texel addresses are 32bit)

Hence only max 17 mip-maps are possible.


![](https://github.trello.services/images/mini-trello-icon.png) [kldsjflkdsfjg](https://trello.com/c/uA9zyxsi/2-kldsjflkdsfjg)


The scalefactor sf that you are trying to adjust will be used later in evaluate.cpp and will be divided by SCALE_FACTOR_NORMAL which is 64
```
ScaleFactor sf = scale_factor(eg_value(score));
     v =  mg_value(score) * int(me->game_phase())
        + eg_value(score) * int(PHASE_MIDGAME - me->game_phase()) * sf / SCALE_FACTOR_NORMAL;
```

The difference between (sf)/64 and (sf + 3)/64 is really not very significant, so your results will be yellowish or close to.

Now about your new criteria involving the king position.
Do you have some specific positions in mind ?

I will have to think more, but you are duplicating what is already computed in passed() where we use some king distance too. Maybe it will be better to try tweaking something there...

I don't know for the case where there is many pawns.
But if there is only 2, it is normal that the weak side will use one bishop to stop a pawn, and use the king for the other. As long as the weak king is in front of the strong pawn, the weak side should be ok...


I know sizeof(char) is 1.


This looks like a general fix, or is it related to mqtt5? If not, I would separate it in another commit/PR.


because one can attempt to create an invalid mip-chain (its easy) the constructors should be protected and forwarded through to by  static `create*` functions


it was determined that this sort of thing is fine in Lua & that there isn't really a difference between a "Lua calculated fps" and the "game_sa fps"


Jeg vil i stedet bruge lejligheden til at citere et af de citater Simon har fundet ifm. #138:

> Hastigheden hvormed du flytter dig betyder intet, så længe du ikke stopper.

– Confucius


once you define m_mipmaps to be a static array of 17 mipmaps this will no longer be necessary


If "opts" stands for "options" I would definitely go for the better readable name "options".


If this is not used, can't we just remove it completely?


this is the cool and exciting part xD


Features


Mip-map format validation rules:
1) at least one mip-map should have a format other than `ECF_UKNOWN`
2) all present (not nullptr) mip-maps whose format is not `ECF_UNKNOWN` should have exactly the same format

function should spit out bool if this is correct or not