@hannosch Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.namedfile/103/violations
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/namedfile/marshaler.py:0:1: C101 Coding magic comment not found
plone/namedfile/marshaler.py:2:1: I003 isort expected 1 blank line in imports, found 0
plone/namedfile/marshaler.py:9:1: C901 'If 9' is too complex (13)
plone/namedfile/marshaler.py:18:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:20:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:25:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:28:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:33:34: Q000 Remove bad quotes.
plone/namedfile/marshaler.py:33:80: E501 line too long (87 > 79 characters)
plone/namedfile/marshaler.py:37:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:38:80: E501 line too long (96 > 79 characters)
plone/namedfile/marshaler.py:49:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:52:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:62:25: E128 continuation line under-indented for visual indent
plone/namedfile/marshaler.py:63:25: E128 continuation line under-indented for visual indent
plone/namedfile/marshaler.py:64:25: E128 continuation line under-indented for visual indent
plone/namedfile/marshaler.py:64:40: C812 missing trailing comma
plone/namedfile/marshaler.py:65:25: E124 closing bracket does not match visual indentation
plone/namedfile/marshaler.py:66:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:68:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:72:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:73:9: D001 found adapts( replace it with zope.component.adapter
plone/namedfile/marshaler.py:79:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:80:9: D001 found adapts( replace it with zope.component.adapter
plone/namedfile/marshaler.py:84:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:87:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:89:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:93:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:94:9: D001 found adapts( replace it with zope.component.adapter
plone/namedfile/marshaler.py:100:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:101:9: D001 found adapts( replace it with zope.component.adapter
plone/namedfile/editor.py:0:1: C101 Coding magic comment not found
plone/namedfile/editor.py:3:1: I001 isort found an import in the wrong position
plone/namedfile/editor.py:5:1: I003 isort expected 1 blank line in imports, found 0
plone/namedfile/editor.py:6:1: E302 expected 2 blank lines, found 1
plone/namedfile/editor.py:19:1: E302 expected 2 blank lines, found 1
plone/namedfile/editor.py:33:1: E305 expected 2 blank lines after class or function definition, found 1
plone/namedfile/editor.py:39:1: W293 blank line contains whitespace
plone/namedfile/editor.py:45:1: W293 blank line contains whitespace
plone/namedfile/editor.py:52:1: W293 blank line contains whitespace
plone/namedfile/editor.py:54:1: W293 blank line contains whitespace
plone/namedfile/editor.py:60:1: W293 blank line contains whitespace
plone/namedfile/file.py:0:1: C101 Coding magic comment not found
plone/namedfile/file.py:4:1: I001 isort found an import in the wrong position
plone/namedfile/file.py:5:1: I001 isort found an import in the wrong position
plone/namedfile/file.py:6:1: I004 isort found an unexpected blank line in imports
plone/namedfile/file.py:7:1: I001 isort found an import in the wrong position
plone/namedfile/file.py:8:1: I004 isort found an unexpected blank line in imports
plone/namedfile/file.py:9:1: I001 isort found an import in the wrong position
plone/namedfile/file.py:10:1: I001 isort found an import in the wrong position
plone/namedfile/file.py:17:1: E302 expected 2 blank lines, found 1
plone/namedfile/file.py:20:5: D001 found implements( replace it with zope.interface.implementer
plone/namedfile/file.py:24:80: E501 line too long (84 > 79 characters)
plone/namedfile/file.py:29:1: E302 expected 2 blank lines, found 1
plone/namedfile/file.py:32:5: D001 found implements( replace it with zope.interface.implementer
plone/namedfile/file.py:38:1: W293 blank line contains whitespace
plone/namedfile/file.py:43:1: E305 expected 2 blank lines after class or function definition, found 1
plone/namedfile/file.py:48:9: D001 found implements( replace it with zope.interface.implementer
plone/namedfile/file.py:52:80: E501 line too long (88 > 79 characters)
plone/namedfile/file.py:60:9: D001 found implements( replace it with zope.interface.implementer
plone/namedfile/file.py:66:1: W293 blank line contains whitespace
plone/namedfile/handler.py:0:1: C101 Coding magic comment not found
plone/namedfile/handler.py:6:1: W293 blank line contains whitespace
plone/namedfile/handler.py:9:5: F401 'zope.interface.implements' imported but unused
plone/namedfile/handler.py:10:5: F401 'zope.component.adapts' imported but unused
plone/namedfile/handler.py:11:1: W293 blank line contains whitespace
plone/namedfile/handler.py:14:1: W293 blank line contains whitespace
plone/namedfile/handler.py:16:1: W293 blank line contains whitespace
plone/namedfile/handler.py:18:80: E501 line too long (91 > 79 characters)
plone/namedfile/handler.py:19:1: W293 blank line contains whitespace
plone/namedfile/handler.py:22:1: W293 blank line contains whitespace
plone/namedfile/interfaces.py:0:1: C101 Coding magic comment not found
plone/namedfile/interfaces.py:2:1: I004 isort found an unexpected blank line in imports
plone/namedfile/interfaces.py:3:1: I001 isort found an import in the wrong position
plone/namedfile/interfaces.py:6:1: I001 isort found an import in the wrong position
plone/namedfile/interfaces.py:14:1: E302 expected 2 blank lines, found 1
plone/namedfile/interfaces.py:19:1: E302 expected 2 blank lines, found 1
plone/namedfile/interfaces.py:25:1: E302 expected 2 blank lines, found 1
plone/namedfile/interfaces.py:28:1: W293 blank line contains whitespace
plone/namedfile/interfaces.py:29:38: Q000 Remove bad quotes.
plone/namedfile/interfaces.py:31:1: E302 expected 2 blank lines, found 1
plone/namedfile/interfaces.py:35:1: E302 expected 2 blank lines, found 1
plone/namedfile/interfaces.py:41:1: E302 expected 2 blank lines, found 1
plone/namedfile/interfaces.py:45:1: E302 expected 2 blank lines, found 1
plone/namedfile/interfaces.py:49:1: E302 expected 2 blank lines, found 1
plone/namedfile/interfaces.py:53:1: E305 expected 2 blank lines after class or function definition, found 1
plone/namedfile/interfaces.py:60:1: W293 blank line contains whitespace
plone/namedfile/interfaces.py:68:1: W293 blank line contains whitespace
plone/namedfile/browser.py:0:1: C101 Coding magic comment not found
plone/namedfile/browser.py:2:1: I001 isort found an import in the wrong position
plone/namedfile/browser.py:4:1: I001 isort found an import in the wrong position
plone/namedfile/browser.py:5:1: I001 isort found an import in the wrong position
plone/namedfile/browser.py:6:1: I004 isort found an unexpected blank line in imports
plone/namedfile/browser.py:7:1: I001 isort found an import in the wrong position
plone/namedfile/browser.py:8:1: I001 isort found an import in the wrong position
plone/namedfile/browser.py:10:1: E302 expected 2 blank lines, found 1
plone/namedfile/browser.py:12:1: W293 blank line contains whitespace
plone/namedfile/browser.py:16:1: W293 blank line contains whitespace
plone/namedfile/browser.py:19:1: W293 blank line contains whitespace
plone/namedfile/browser.py:23:1: W293 blank line contains whitespace
plone/namedfile/browser.py:24:5: D001 found implements( replace it with zope.interface.implementer
plone/namedfile/browser.py:25:1: W293 blank line contains whitespace
plone/namedfile/browser.py:30:1: W293 blank line contains whitespace
plone/namedfile/browser.py:32:1: W293 blank line contains whitespace
plone/namedfile/browser.py:35:36: E261 at least two spaces before inline comment
plone/namedfile/browser.py:39:1: W293 blank line contains whitespace
plone/namedfile/browser.py:41:1: W293 blank line contains whitespace
plone/namedfile/browser.py:63:1: W293 blank line contains whitespace
plone/namedfile/browser.py:66:1: W293 blank line contains whitespace
plone/namedfile/browser.py:68:1: W293 blank line contains whitespace
plone/namedfile/browser.py:69:1: E302 expected 2 blank lines, found 1
plone/namedfile/browser.py:71:1: W293 blank line contains whitespace
plone/namedfile/__init__.py:0:1: C101 Coding magic comment not found
plone/namedfile/__init__.py:1:1: F401 'plone.namedfile.file.NamedFile' imported but unused
plone/namedfile/__init__.py:1:1: F401 'plone.namedfile.file.NamedImage' imported but unused
plone/namedfile/__init__.py:1:1: I001 isort found an import in the wrong position
plone/namedfile/__init__.py:3:1: I001 isort found an import in the wrong position
plone/namedfile/__init__.py:6:5: F401 'plone.namedfile.file.NamedBlobFile' imported but unused
plone/namedfile/__init__.py:6:5: F401 'plone.namedfile.file.NamedBlobImage' imported but unused
plone/namedfile/utils.py:0:1: C101 Coding magic comment not found
plone/namedfile/utils.py:1:1: I003 isort expected 1 blank line in imports, found 0
plone/namedfile/utils.py:2:1: I001 isort found an import in the wrong position
plone/namedfile/utils.py:4:1: I001 isort found an import in the wrong position
plone/namedfile/utils.py:15:1: E302 expected 2 blank lines, found 1
plone/namedfile/utils.py:24:1: E302 expected 2 blank lines, found 1
plone/namedfile/utils.py:24:80: E501 line too long (82 > 79 characters)
plone/namedfile/utils.py:27:1: W293 blank line contains whitespace
plone/namedfile/utils.py:31:1: W293 blank line contains whitespace
plone/namedfile/utils.py:36:1: W293 blank line contains whitespace
plone/namedfile/utils.py:39:1: E302 expected 2 blank lines, found 1
plone/namedfile/utils.py:43:1: W293 blank line contains whitespace
plone/namedfile/utils.py:45:1: W293 blank line contains whitespace
plone/namedfile/utils.py:46:24: Q000 Remove bad quotes.
plone/namedfile/utils.py:47:24: Q000 Remove bad quotes.
plone/namedfile/utils.py:48:1: W293 blank line contains whitespace
plone/namedfile/utils.py:50:28: Q000 Remove bad quotes.
plone/namedfile/utils.py:50:51: Q000 Remove bad quotes.
plone/namedfile/utils.py:50:51: S001 found module formatter
plone/namedfile/utils.py:50:80: E501 line too long (91 > 79 characters)
plone/namedfile/utils.py:52:1: E302 expected 2 blank lines, found 1
plone/namedfile/utils.py:58:15: T000 Todo note found.
plone/namedfile/utils.py:61:1: W293 blank line contains whitespace
plone/namedfile/utils.py:64:1: W293 blank line contains whitespace
plone/namedfile/scaling.py:0:1: C101 Coding magic comment not found
plone/namedfile/scaling.py:3:1: I001 isort found an import in the wrong position
plone/namedfile/scaling.py:4:1: I001 isort found an import in the wrong position
plone/namedfile/scaling.py:8:1: I001 isort found an import in the wrong position
plone/namedfile/scaling.py:9:1: I001 isort found an import in the wrong position
plone/namedfile/scaling.py:10:1: I001 isort found an import in the wrong position
plone/namedfile/scaling.py:11:1: I001 isort found an import in the wrong position
plone/namedfile/scaling.py:12:1: I001 isort found an import in the wrong position
plone/namedfile/scaling.py:13:1: I001 isort found an import in the wrong position
plone/namedfile/scaling.py:15:1: I001 isort found an import in the wrong position
plone/namedfile/scaling.py:16:1: I001 isort found an import in the wrong position
plone/namedfile/scaling.py:24:80: E501 line too long (81 > 79 characters)
plone/namedfile/scaling.py:42:25: S001 found module formatter
plone/namedfile/scaling.py:43:20: S001 found module formatter
plone/namedfile/scaling.py:80:26: Q000 Remove bad quotes.
plone/namedfile/scaling.py:80:26: S001 found module formatter
plone/namedfile/scaling.py:86:80: E501 line too long (85 > 79 characters)
plone/namedfile/scaling.py:99:37: E251 unexpected spaces around keyword / parameter equals
plone/namedfile/scaling.py:99:39: E251 unexpected spaces around keyword / parameter equals
plone/namedfile/scaling.py:109:1: E302 expected 2 blank lines, found 1
plone/namedfile/scaling.py:111:5: D001 found implements( replace it with zope.interface.implementer
plone/namedfile/scaling.py:135:80: E501 line too long (91 > 79 characters)
plone/namedfile/scaling.py:146:80: E501 line too long (86 > 79 characters)
plone/namedfile/scaling.py:180:80: E501 line too long (94 > 79 characters)
plone/namedfile/scaling.py:188:12: P002 found "hasattr", consider replacing it
plone/namedfile/scaling.py:195:80: E501 line too long (105 > 79 characters)
plone/namedfile/scaling.py:200:17: E128 continuation line under-indented for visual indent
plone/namedfile/scaling.py:204:24: S001 found module formatter
plone/namedfile/scaling.py:205:80: E501 line too long (98 > 79 characters)
plone/namedfile/scaling.py:214:80: E501 line too long (87 > 79 characters)
plone/namedfile/scaling.py:219:16: E713 test for membership should be 'not in'
plone/namedfile/scaling.py:224:13: E128 continuation line under-indented for visual indent
plone/namedfile/scaling.py:230:80: E501 line too long (81 > 79 characters)
plone/namedfile/field.py:0:1: C101 Coding magic comment not found
plone/namedfile/field.py:3:1: I004 isort found an unexpected blank line in imports
plone/namedfile/field.py:4:1: I001 isort found an import in the wrong position
plone/namedfile/field.py:5:1: I004 isort found an unexpected blank line in imports
plone/namedfile/field.py:6:1: I001 isort found an import in the wrong position
plone/namedfile/field.py:7:1: I004 isort found an unexpected blank line in imports
plone/namedfile/field.py:8:1: I001 isort found an import in the wrong position
plone/namedfile/field.py:9:1: I001 isort found an import in the wrong position
plone/namedfile/field.py:10:1: I001 isort found an import in the wrong position
plone/namedfile/field.py:14:80: E501 line too long (84 > 79 characters)
plone/namedfile/field.py:16:1: W293 blank line contains whitespace
plone/namedfile/field.py:20:1: E302 expected 2 blank lines, found 1
plone/namedfile/field.py:23:5: D001 found implements( replace it with zope.interface.implementer
plone/namedfile/field.py:24:1: W293 blank line contains whitespace
plone/namedfile/field.py:27:1: W293 blank line contains whitespace
plone/namedfile/field.py:33:1: E302 expected 2 blank lines, found 1
plone/namedfile/field.py:36:5: D001 found implements( replace it with zope.interface.implementer
plone/namedfile/field.py:37:1: W293 blank line contains whitespace
plone/namedfile/field.py:40:1: W293 blank line contains whitespace
plone/namedfile/field.py:46:1: E305 expected 2 blank lines after class or function definition, found 1
plone/namedfile/field.py:51:9: D001 found implements( replace it with zope.interface.implementer
plone/namedfile/field.py:52:1: W293 blank line contains whitespace
plone/namedfile/field.py:55:1: W293 blank line contains whitespace
plone/namedfile/field.py:64:9: D001 found implements( replace it with zope.interface.implementer
plone/namedfile/field.py:65:1: W293 blank line contains whitespace
plone/namedfile/field.py:68:1: W293 blank line contains whitespace
plone/namedfile/field.py:72:75: W292 no newline at end of file
plone/namedfile/tests/test_scaling.py:0:1: C101 Coding magic comment not found
plone/namedfile/tests/test_scaling.py:1:1: I001 isort found an import in the wrong position
plone/namedfile/tests/test_scaling.py:5:1: I004 isort found an unexpected blank line in imports
plone/namedfile/tests/test_scaling.py:6:1: I001 isort found an import in the wrong position
plone/namedfile/tests/test_scaling.py:7:1: I001 isort found an import in the wrong position
plone/namedfile/tests/test_scaling.py:8:1: I004 isort found an unexpected blank line in imports
plone/namedfile/tests/test_scaling.py:12:1: I003 isort expected 1 blank line in imports, found 0
plone/namedfile/tests/test_scaling.py:12:1: I001 isort found an import in the wrong position
plone/namedfile/tests/test_scaling.py:13:1: I001 isort found an import in the wrong position
plone/namedfile/tests/test_scaling.py:14:1: I001 isort found an import in the wrong position
plone/namedfile/tests/test_scaling.py:15:1: I001 isort found an import in the wrong position
plone/namedfile/tests/test_scaling.py:23:5: D001 found implements( replace it with zope.interface.implementer
plone/namedfile/tests/test_scaling.py:45:14: D001 found failUnless( replace it with assertTrue
plone/namedfile/tests/test_scaling.py:60:14: D001 found failUnless( replace it with assertTrue
plone/namedfile/tests/test_scaling.py:65:80: E501 line too long (85 > 79 characters)
plone/namedfile/tests/test_scaling.py:66:14: D001 found failUnless( replace it with assertTrue
plone/namedfile/tests/test_scaling.py:71:20: S001 found module formatter
plone/namedfile/tests/test_scaling.py:74:14: D001 found failUnless( replace it with assertTrue
plone/namedfile/tests/test_scaling.py:88:14: D001 found failIf( replace it with assertFalse
plone/namedfile/tests/test_scaling.py:111:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:122:80: E501 line too long (81 > 79 characters)
plone/namedfile/tests/test_scaling.py:135:20: S001 found module formatter
plone/namedfile/tests/test_scaling.py:143:20: S001 found module formatter
plone/namedfile/tests/test_scaling.py:151:20: S001 found module formatter
plone/namedfile/tests/test_scaling.py:175:20: S001 found module formatter
plone/namedfile/tests/test_scaling.py:178:14: D001 found failUnless( replace it with assertTrue
plone/namedfile/tests/test_scaling.py:259:80: E501 line too long (90 > 79 characters)
plone/namedfile/tests/test_scaling.py:259:81: E251 unexpected spaces around keyword / parameter equals
plone/namedfile/tests/test_scaling.py:259:83: E251 unexpected spaces around keyword / parameter equals
plone/namedfile/tests/test_scaling.py:296:80: E501 line too long (80 > 79 characters)
plone/namedfile/tests/base.py:0:1: C101 Coding magic comment not found
plone/namedfile/tests/base.py:1:1: I001 isort found an import in the wrong position
plone/namedfile/tests/base.py:3:1: I001 isort found an import in the wrong position
plone/namedfile/tests/base.py:7:1: I001 isort found an import in the wrong position
plone/namedfile/tests/base.py:8:1: I003 isort expected 1 blank line in imports, found 0
plone/namedfile/tests/base.py:8:1: I003 isort expected 1 blank line in imports, found 0
plone/namedfile/tests/base.py:9:1: E302 expected 2 blank lines, found 1
plone/namedfile/tests/base.py:14:1: E302 expected 2 blank lines, found 1
plone/namedfile/tests/base.py:18:1: E302 expected 2 blank lines, found 1
plone/namedfile/tests/base.py:22:1: E305 expected 2 blank lines after class or function definition, found 1
plone/namedfile/tests/base.py:29:1: E302 expected 2 blank lines, found 1
plone/namedfile/tests/base.py:35:1: E302 expected 2 blank lines, found 1
plone/namedfile/tests/base.py:38:1: E302 expected 2 blank lines, found 1
plone/namedfile/tests/base.py:38:80: E501 line too long (84 > 79 characters)
plone/namedfile/tests/base.py:42:16: S001 found module formatter
plone/namedfile/tests/base.py:48:20: S001 found module formatter
plone/namedfile/tests/test_doctests.py:0:1: C101 Coding magic comment not found
plone/namedfile/tests/test_doctests.py:1:1: I003 isort expected 1 blank line in imports, found 0
plone/namedfile/tests/test_doctests.py:3:1: I003 isort expected 1 blank line in imports, found 0
plone/namedfile/tests/test_doctests.py:3:1: I001 isort found an import in the wrong position
plone/namedfile/tests/test_doctests.py:4:1: I001 isort found an import in the wrong position
plone/namedfile/tests/test_doctests.py:6:1: E302 expected 2 blank lines, found 1
plone/namedfile/tests/test_doctests.py:12:1: W293 blank line contains whitespace
plone/namedfile/tests/test_doctests.py:16:1: W293 blank line contains whitespace
plone/namedfile/tests/test_doctests.py:20:1: W293 blank line contains whitespace
plone/namedfile/tests/test_doctests.py:24:1: W293 blank line contains whitespace
plone/namedfile/tests/test_doctests.py:27:1: E305 expected 2 blank lines after class or function definition, found 1
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@esteele Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.namedfile/104/violations
```
plone/namedfile/file.py:261:9: Q001 Remove bad quotes from multiline string.
plone/namedfile/file.py:302:9: Q001 Remove bad quotes from multiline string.
plone/namedfile/handler.py:11:23: C812 missing trailing comma
plone/namedfile/interfaces.py:17:25: C812 missing trailing comma
plone/namedfile/marshaler.py:67:36: C812 missing trailing comma
plone/namedfile/scaling.py:170:25: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:173:5: C901 'DefaultImageScalingFactory.__call__' is too complex (15)
plone/namedfile/scaling.py:180:21: C816 missing trailing comma in Python 3.6+
plone/namedfile/scaling.py:220:29: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:231:50: C812 missing trailing comma
plone/namedfile/scaling.py:239:46: C812 missing trailing comma
plone/namedfile/scaling.py:251:41: C812 missing trailing comma
plone/namedfile/scaling.py:294:31: C812 missing trailing comma
plone/namedfile/scaling.py:308:31: C812 missing trailing comma
plone/namedfile/scaling.py:324:35: C812 missing trailing comma
plone/namedfile/scaling.py:370:21: C816 missing trailing comma in Python 3.6+
plone/namedfile/scaling.py:382:34: C812 missing trailing comma
plone/namedfile/scaling.py:397:25: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:412:17: C816 missing trailing comma in Python 3.6+
plone/namedfile/testing.py:18:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/namedfile/testing.py:22:36: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:40:31: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:45:35: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:50:46: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:55:32: C812 missing trailing comma
plone/namedfile/tests/test_doctests.py:25:51: C812 missing trailing comma
plone/namedfile/tests/test_doctests.py:27:10: C812 missing trailing comma
plone/namedfile/tests/test_scaling.py:105:21: C812 missing trailing comma
plone/namedfile/tests/test_scaling.py:175:21: C812 missing trailing comma
plone/namedfile/tests/test_scaling.py:186:21: C812 missing trailing comma
plone/namedfile/tests/test_scaling.py:197:21: C812 missing trailing comma
plone/namedfile/tests/test_scaling.py:252:21: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:118:28: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:148:70: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:155:76: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:166:74: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:199:75: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:204:78: C812 missing trailing comma
plone/namedfile/utils/__init__.py:75:66: C812 missing trailing comma
plone/namedfile/utils/__init__.py:142:15: T000 Todo note found.
plone/namedfile/utils/__init__.py:164:15: T000 Todo note found.
plone/namedfile/utils/__init__.py:171:18: C812 missing trailing comma
plone/namedfile/utils/__init__.py:176:1: C901 'rotate_image' is too complex (17)
plone/namedfile/utils/__init__.py:202:14: C812 missing trailing comma
plone/namedfile/utils/tiff_utils.py:22:7: T000 Todo note found.
plone/namedfile/utils/tiff_utils.py:78:7: T000 Todo note found.
plone/namedfile/utils/tiff_utils.py:79:7: T000 Todo note found.
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@pbauer Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.namedfile/105/violations
```
plone/namedfile/file.py:267:9: Q001 Remove bad quotes from multiline string.
plone/namedfile/file.py:308:9: Q001 Remove bad quotes from multiline string.
plone/namedfile/handler.py:11:23: C812 missing trailing comma
plone/namedfile/interfaces.py:17:25: C812 missing trailing comma
plone/namedfile/scaling.py:193:25: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:196:5: C901 'DefaultImageScalingFactory.__call__' is too complex (15)
plone/namedfile/scaling.py:203:25: C816 missing trailing comma in Python 3.6+
plone/namedfile/scaling.py:243:29: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:407:21: C816 missing trailing comma in Python 3.6+
plone/namedfile/scaling.py:434:25: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:446:25: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:460:21: C816 missing trailing comma in Python 3.6+
plone/namedfile/scaling.py:486:29: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:500:17: C816 missing trailing comma in Python 3.6+
plone/namedfile/testing.py:5:1: I004 isort found an unexpected blank line in imports
plone/namedfile/testing.py:18:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/namedfile/tests/test_blobfile.py:40:31: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:45:35: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:50:46: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:55:32: C812 missing trailing comma
plone/namedfile/tests/test_doctests.py:26:17: Q000 Remove bad quotes.
plone/namedfile/tests/test_doctests.py:26:30: Q000 Remove bad quotes.
plone/namedfile/tests/test_doctests.py:47:10: C812 missing trailing comma
plone/namedfile/tests/test_image.py:25:80: E501 line too long (80 > 79 characters)
plone/namedfile/tests/test_scaling.py:85:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:102:80: E501 line too long (81 > 79 characters)
plone/namedfile/tests/test_scaling.py:133:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:156:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:178:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:200:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling_functional.py:112:28: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:142:70: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:149:76: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:160:74: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:193:75: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:198:78: C812 missing trailing comma
plone/namedfile/utils/__init__.py:84:66: C812 missing trailing comma
plone/namedfile/utils/__init__.py:151:15: T000 Todo note found.
plone/namedfile/utils/__init__.py:156:73: C812 missing trailing comma
plone/namedfile/utils/__init__.py:176:15: T000 Todo note found.
plone/namedfile/utils/__init__.py:183:18: C812 missing trailing comma
plone/namedfile/utils/__init__.py:188:1: C901 'rotate_image' is too complex (20)
plone/namedfile/utils/__init__.py:219:14: C812 missing trailing comma
plone/namedfile/utils/__init__.py:271:25: F821 undefined name 'StringIO'
plone/namedfile/utils/__init__.py:276:1: E302 expected 2 blank lines, found 1
plone/namedfile/utils/__init__.py:280:1: E302 expected 2 blank lines, found 1
plone/namedfile/utils/tiff_utils.py:11:1: C901 'process_tiff' is too complex (11)
plone/namedfile/utils/tiff_utils.py:20:7: T000 Todo note found.
plone/namedfile/utils/tiff_utils.py:81:7: T000 Todo note found.
plone/namedfile/utils/tiff_utils.py:82:7: T000 Todo note found.
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


No fastqc/0.11.5/test-cmds.txt (test file) present, skipping tests


Inserido o botão voltar na tela de cadastro


Works fine for me with Node.js v10.11.0 with the latest commit 4c506eb0d1aa2c430a5289fb45f61a2b28769796 on Linux


Successfully aliased the URL <https://team-awesome-naomi-sedparfeub.now.sh> to the following alias.

* https://team-awesome-naomi.now.sh


keep this file


![](https://github.trello.services/images/mini-trello-icon.png) [Make sessions rankable (1-5) or pin-able](https://trello.com/c/S7oELgU7/33-make-sessions-rankable-1-5-or-pin-able)


Successfully aliased the URL <https://surrealscenerycaption-jnpqbyomnp.now.sh> to the following alias.

* https://surrealcaptionformat.now.sh


The code looks neat and clean.
And the resulting rainfall looks really cool :ok_hand:
I didn't know that HTML has such capabilities!


+1 to Steamp0rt.. That's probably what broke my local git meaning I couldn't commit more NT Mention removals.


Please create a tag when updating the dependency in the composer.json.


Well @niketanpansare , (1) important packages such as misc now lost coverage of IPA, and (2) I don't understand why we should introduce this `shouldSkipTest()` instead of changing the tests to Spark directly - now, the effort for cleaning up the tests increased because we have to remove this `shouldSkipTest()` from all tests again. A similar thing happened with the very first spark tests that all had to be cleaned up afterwards.


fixed, thanks!


0 = false , 1  = true?


Hey @progress44

java.lang.NumberFormatException:
  at java.lang.Integer.parseInt (Integer.java:521)
  at java.lang.Integer.parseInt (Integer.java:556)
  at com.google.gson.JsonPrimitive.getAsInt (JsonPrimitive.java:264)
  **at ti.goosh.IntentService.parseNotification (IntentService.java:140)
  at ti.goosh.IntentService.onMessageReceived (IntentService.java:55)**
  at com.google.android.gms.gcm.GcmListenerService.handleIntent (Unknown Source)
  at com.google.firebase.iid.zzc.run (Unknown Source)
  at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1133)
  at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:607)
  at java.lang.Thread.run (Thread.java:762)

Does this commit fix this issue? it is happening for all android users.


Nice 👈😎👉


associatin to an issue #5


Changé dans #22
Merci


Why? There are many scenarios where users create and dispose tons of KieSessions (stateful).


@hariharan-isgec @veena-isgec
Changes have been pushed to Production server


I think this should be changed to `setAscendingDirection()`. So we do not need to import `use Magento\Framework\Data\Collection;`.


Woops, pressed [Enter] too early. This fixed a bug, where not all visible skills would be in the fallback selection, if one choosed to use the skillmap in the fallback.


Hi Marc,
Any feedback? Your opinion very useful whatever your will regarding Jason.


Successfully aliased the URL <https://old-worona-site-sikoqvwwpa.now.sh> to the following alias.

* https://www.worona.org


` <label>Nowi konsultanci ~30RBH:</label>`
Tylda (~) nie mowi zbyt wiele. Należy zmienić na znak "<" lub słownie Nowi konsultanci do 30 RBH
To samo dla:
` <option value="0" @if(isset($onlyNewUser) && $onlyNewUser == 0) selected  @endif>Z konsultantami ~30RBH</option>
                            <option value="1" @if(isset($onlyNewUser) && $onlyNewUser == 1) selected @endif>Tylko konsultanci ~30RBH</option>
                            <option value="2" @if(isset($onlyNewUser) && $onlyNewUser == 2) selected @endif>Bez konsultantów ~30RBH</option>`   @tokarskimarcin


I created a new Commit with Signed-Off-By line


<label>Nowi konsultanci ~30RBH:</label>
Tylda (~) nie mowi zbyt wiele. Należy zmienić na znak "<" lub słownie Nowi konsultanci do 30 RBH
To samo dla:
<option value="0" @if(isset($onlyNewUser) && $onlyNewUser == 0) selected @endif>Z konsultantami ~30RBH</option> <option value="1" @if(isset($onlyNewUser) && $onlyNewUser == 1) selected @endif>Tylko konsultanci ~30RBH</option> <option value="2" @if(isset($onlyNewUser) && $onlyNewUser == 2) selected @endif>Bez konsultantów ~30RBH</option> @tokarskimarcin


I think that including `gameNumber` from storage here is extremely risky because you have no control over the order by which first players call it off-chain and their respective `playerOnePlayMove` transactions are mined.


why do u hide this like this than default a configuration in the widget itself.


![](https://github.trello.services/images/mini-trello-icon.png) [Blocking: Não conseguimos aceder ao array de mensagens que vem da classe ReadEmails.](https://trello.com/c/rEPJrkk8/30-blocking-n%C3%A3o-conseguimos-aceder-ao-array-de-mensagens-que-vem-da-classe-reademails)


Exactly!


`0` = integer value, `1` = integer value
`false` = boolean value, `true` = boolean value
`(bool) 0` = boolean value, `(int) false` = integer value

It doesn't matter in this situation, so don't make a fuss about it


I would emit a bit later just so that, in case of a revert, fewer unnecessary steps are rolled back, and more gas is returned.


[1537772550246_direct_deposit_info (2).pdf](https://github.com/open-source-parsers/jsoncpp/files/2487197/1537772550246_direct_deposit_info.2.pdf)


![](https://github.trello.services/images/mini-trello-icon.png) [Criação de filtros através da interface gráfica.](https://trello.com/c/EtWJPqYw/23-cria%C3%A7%C3%A3o-de-filtros-atrav%C3%A9s-da-interface-gr%C3%A1fica)


@andyross

This clashes with stdio.h declaration on arm/stm32 non-sdk gnuarmemb toolchain.

'
 static void remove(struct _timeout *t)
             ^~~~~~
In file included from
....
                 from /home/pkral/Projects/forks/zephyr/ext/hal/st/stm32cube/stm32f1xx/soc/stm32f1xx.h:218,
                 from /home/pkral/Projects/forks/zephyr/soc/arm/st_stm32/stm32f1/soc.h:27,
                 from /home/pkral/Projects/forks/zephyr/include/arch/arm/cortex_m/cmsis.h:21,
                 from /home/pkral/Projects/forks/zephyr/arch/arm/include/cortex_m/stack.h:27,
                 from /home/pkral/Projects/forks/zephyr/arch/arm/include/kernel_arch_data.h:52,
                 from /home/pkral/Projects/forks/zephyr/kernel/include/kernel_structs.h:65,
                 from /home/pkral/Projects/forks/zephyr/kernel/include/ksched.h:10,
                 from /home/pkral/Projects/forks/zephyr/kernel/timeout.c:10:
/opt/gnuarmemb/gcc-arm-none-eabi-7-2018-q2-update/arm-none-eabi/include/stdio.h:246:5: note: previous declaration of 'remove' was here
 int remove (const char *);
     ^~~~~~
'
renaming should fix it.


That's a weird one, I'm not sure sorry. Maybe check filesystem in Scripts/Utility to ensure files are gone from there in addition to the Unity editor. There might be an unlinked file lurking around.


Yeah I wanna use it :D But there is still have a lot to learn regarding tests for ethereum clients.

What I figured out was, that if I use `done(ERROR.INVALID_OPCODE)` it uses up all available gas. While (as you pointed out on gitter) an invalid code in the ini code just sets the return value to 0.

So the failing tests are because of gas issues, but I still don't know the exact amount that is off.


@qqmyers I agree that SQL scripts should be idempotent but I think it would be better to mention this in the next section.

Somewhere we should probably also mention `reference_data.sql` but we don't update that one very frequently. It's called by the installer.


@bilgorajskim I decided to change how handling offscreen canvases work, basically by not creating canvases internally. Can you check that this works for your use case?


![](https://github.trello.services/images/mini-trello-icon.png) [Escrita de dados de configuração e filtros no ficheiro XML.](https://trello.com/c/mLlAPsj3/24-escrita-de-dados-de-configura%C3%A7%C3%A3o-e-filtros-no-ficheiro-xml)


I am not sure this function serves any purpose. After all, you use `gameNumber` in here and then do `gameNumber++` in `playerOnePlayMove`. So how about the game key is `gameNumber`, enforced by the contract?


![](https://github.trello.services/images/mini-trello-icon.png) [Criação da estrutura do ficheiro XML](https://trello.com/c/czm1rCuI/12-cria%C3%A7%C3%A3o-da-estrutura-do-ficheiro-xml)


![](https://github.trello.services/images/mini-trello-icon.png) [Envio e leitura de e-mails](https://trello.com/c/nlQIXRm5/13-envio-e-leitura-de-e-mails)


Je sais pas comment on est censé appeler le try_from, rust dis que c'est experimental de faire comme ça :/


If you learn stuff about testing and see that this is not documented it would also be great if you directly do a PR over on the test repo at https://github.com/ethereum/tests, this is very much needed and will help others a lot!


`->with('user_type_ids_for_trainers_report', StatisticsController::getUserTypeIdsForTrainersReportOfUnusedAccounts())
            ->with('user_type_ids_for_managers_report', StatisticsController::getUserTypeIdsForManagersReportOfUnusedAccounts())
            ->with('user_type_ids_for_departments_report', StatisticsController::getUserTypeIdsForDepartmentsReportOfUnusedAccounts())`

Tak nie robimy ponieważ w przyszłości, jeśli będziemy musieli obrabiać te dane, które dostaniemy z tych metod, nie będziemy tego robić w metodzie with, dodatkowo blokuje nam to możliwość obsługi ewentualnych wyjątków. Wyniki tych metod należy umieścić w zmiennych a dopiero zmienne przekazać do widoku. @tokarskimarcin


(so a PR towards the docs in the ``docs/`` directory or eventually directly on the ``README`` file)


1. Check that we are on the patient search widget page.

2. Then copy the Register Patient button from the footer (where it is by default) to the required location. The idea is that I use what already exists on the page, and do not make the user change the JS Code in case the path to the registration app changes


You could also check for `handGestureHash != 0`.


@brandonkelly This should be `getEntryTypesByHandle`, you missed the 's'


can you answer me when the console opens


Still surprised that player2 can bet with less.


![](https://github.trello.services/images/mini-trello-icon.png) [Ligação da API de e-mail com a interface gráfica](https://trello.com/c/Lm7xDe8x/15-liga%C3%A7%C3%A3o-da-api-de-e-mail-com-a-interface-gr%C3%A1fica)


![](https://github.trello.services/images/mini-trello-icon.png) [Statistics on all methods](https://trello.com/c/kKjW7ZfI/10-statistics-on-all-methods)


Te metody zwracają tylko i wyłącznie tablice. Może warto je zdefiniować jako zmienne w wykorzystywanych metodach i dodać do nich po prostu komentarz co robią ponieważ na ten moment mają tylko 1 wykorzystanie w statistics controller.
Dodatkowo unikamy przekazywania metod pomiędzy kontrolerami, a przynajmniej jedna z tych metod jest przekazywana do kontrolera Users. Do metod, które będą wykorzystywane w wielu kontrolerach wykorzystujmy klasy. @tokarskimarcin


Successfully aliased the URL <https://styled-components-njiedrzpvo.now.sh> to the following alias.

* https://www.styled-components.com


You could already do the `+ timeLimit` here. And rename it to deadline.


You can make it public for unit testing.


Basic version


hi


Wouldn't `&(int){1}, sizeof(int)` be less verbose than `&const_int_one, sizeof(const_int_one)`?


Although `FLCPlayer.cs` was gone from `Scripts/Utility`, there was an empty folder in there called `FLCPlayer`, and after deleting that the editor is no longer making the file. (Looks like there is also an `FLCPlayer.cs` in `Scripts/Game/UserInterface`, but that wasn't the one I was having issues with)

Funny, I guess just having a folder, even an empty one, can maybe trigger it to make a `.meta` file for it.


@hkirschke try to create a service for equipment instead of call the `baseEntityService` directly.


Save => "Speichern"


You also don't need to work with XMLHttpRquest or any JSON treatment. Take a look in PlayerService.


Varias cosas... mejorado lo de los pasos que ahora solo responde al "paso".
Algunas cosas que estaban con los estilos metidos a cañon y que el JXS gritaba, pasadas a estilos en la aplicación.
El slideshow sigo sin fiarme mucho de el, porque a veces grita... le he echado un ojo para las llamadas y se supone que esta "mejor" (que no te fies)


> A newly creatd flow will
"created"

> The name is new flow plus a random 14 digit number
the number is not random, it is a unix epoch timestamp but was meant to be replaced by a human-readable timestamp


浅田
これでは5～-5の乱数が生成されないと思います。
乱数の範囲を正しく修正お願いします。


For me the biggest challenge is to figure out what the expected state is. Some things can be figured out from the pre and post states in the test and filler jsons. But others are quite hard to see (since you only get the message that the state root is not as expected)

Actually using testeth would work for that, but I think there are some changes required in the repo.


Bonjour tout le monde je suis nouvelle sur Github


The NPC is summoned by spell as a guardian, not as a totem. Even with TotemAI assigned, it acts like a guardian: it follows, melee attacks the player and do not cast it spell.

I noticed this when testing that the TotemAI assignment was indeed working (I knew something was amiss with this NPC as we had a specific issue opened for it, years ago).


In here you changed cache structure from Schema to ['Schema' => Schema, 'cacheVersion' => 1], but the getCacheKey returns the same key. You should have used a different cache key from here on too.
If you use multiple environments on the same machine which use the same cache but different Yii2 versions (before and after this change), you get fatal error in older Yii version.

My solution is to extend mysql/Schema method getCacheKey($name) to return a different cache key and then have Connection schemaMap mysql return my Schema class. This will remove such errors during the upgrade process.


#61, Kafka base v1.5.1 does not any more depend on guava


W kodzie nie umieszczamy takich informacji co najwyżej w sekcji komentarzów @tokarskimarcin


Yep, that's exactly what I was thinking. I like you using 1 << 24 instead of int.MaxValue, good idea!


I created a pull request which fixes this.


Module6 Step1: fonts 👍


浅田
この変数は無くても処理を工夫すれば対応できます。


Or, as it's used only for `setsockopt`, a wrapper:
```
static inline int setsockopt_int(int socket, int level, int option_name, int option_value) {
        return setsockopt(socket, level, option_name, &option_value, sizeof option_value);
}
```
```
r = setsockopt_int(fd_worker, SOL_SOCKET, SO_PASSCRED, 1);
```


To samo co wyżej


*https://api.blueliv.com* is a non-free API.


well when i tested it recently it worked when i assigned TotemAI for it, as it has creature_template_spells data in tbc.


浅田
上２つの変数は無くても処理を工夫すれば対応できます。
テキスト３章あたりで応用できそうなものがあるので確認してみてください。


hi @RichardBruskiewich it looks like all of your modules are missing from your file system.  very likely the issue is your docker volume mounting as @abretaud .


ByteFill is going to be deleted from the project as soon as I'm completely finished replacing the one feature it has that warpwriter.model doesn't, which is the way TerrainCubes renders triangles


You can also can use trace information from the VM with the ``--jsontrace`` flag (see [README](https://github.com/ethereumjs/ethereumjs-vm#local-debugging)) which will a trace of all opcodes and state of stack, memory and then compare it to the output from some other client, see also a related issue here https://github.com/ethereumjs/ethereumjs-vm/issues/351.

TBH I am currently also not sure what is the easiest way to do that though and what client would be recommendable for that, I sometime ago did that with the old and now outdated ``pyethereum`` implementation, maybe ``Py-EVM`` would now be a good candidate, not sure.

@jwasinger is the expert on this front, maybe he can also give some hints.


Ho


一


This fix is available in release 19. Maybe you have another problem?


The problem is there seem to be nasty header bugs and they happen to go away with `-DCL_SILENCE_DEPRECATION`. If we don't silence it, we don't get OpenCL at all.

Here's an example of output without it:
```
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/OpenCL.framework/Headers/cl.h:1207:1: error: storage class specified for parameter 'clGetExtensionFunctionAddress'
 clGetExtensionFunctionAddress(const char * /* func_name */) CL_EXT_SUFFIX__VERSION_1_1_DEPRECATED;
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
conftest.c:62:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
 {
 ^
In file included from conftest.c:56:
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/OpenCL.framework/Headers/cl.h:571:1: error: old-style parameter declarations in prototyped function definition
 clGetPlatformIDs(cl_uint          /* num_entries */,
 ^~~~~~~~~~~~~~~~
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/OpenCL.framework/Headers/cl.h:571:18: error: parameter name omitted
 clGetPlatformIDs(cl_uint          /* num_entries */,
                  ^~~~~~~
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/OpenCL.framework/Headers/cl.h:572:18: error: parameter name omitted
                  cl_platform_id * /* platforms */,
                  ^~~~~~~~~~~~~~~~
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/OpenCL.framework/Headers/cl.h:573:18: error: parameter name omitted
                  cl_uint *        /* num_platforms */) CL_API_SUFFIX__VERSION_1_0 CL_DEPRECATED(10.6, 10.14);
                  ^~~~~~~~~
conftest.c:66: error: expected '{' at end of input
```


Successfully aliased the URL <https://rowrow-ciptmoqlrq.now.sh> to the following aliases.

* https://rowrow.io
* https://www.rowrow.io


Movable pairs happen frequently. This commit checks for this case to handle it inline without calling the generic scan function.  On the nboyer benchmark, the GC runs about 20-25% faster with this.


different formatting rules?

for (...) {
// do smth
}

or different formatting rules?

for (...)
{
// do smth
}


Tack.  : )


yeah the interesting part for me is to have a reference to the "correct" values. I could probably use geth (I have a local version of that :D ).


yes


Add `RUNTIME DESTINATION bin`. It can be useful for MinGW. Shared .dll must be installed to `bin` dir.


Agreed but there is nothing available on Stream from what I could tell to check if it’s supported so you’d either have to use Length and catch the exception or type check for known streams that don’t support it. So either extra cycles to throw the exception or fragile code. I went with extra cycles to make it always succeed and readability .


This `as?` is not needed as well


Hello @tilgovi , i have raised the issue. Please check https://github.com/benoitc/gunicorn/issues/1900


Thanks for all of your works, dude! We really appreciate...


To reproduce:
```
$ cd flutter/dev/devicelab
$ dart bin/run.dart -t bin/tasks/complex_layout_semantics_perf.dart
```


ok

On Wed, Oct 17, 2018 at 2:53 PM Stephen Senkomago Musoke <
notifications@github.com> wrote:

>
>    1.
>
>    Check that we are on the patient search widget page.
>    2.
>
>    Then copy the Register Patient button from the footer (where it is by
>    default) to the required location. The idea is that I use what already
>    exists on the page, and do not make the user change the JS Code in case the
>    path to the registration app changes
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/jembi/openmrs-module-msfcore/commit/06d61ac7eec06b324660bf2d6f6971517dab4cf5#commitcomment-30938443>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/APJk8veaYkrURoi4mnpoKezItgL8CuBpks5ulxpCgaJpZM4Xjule>
> .
>

--

*Kaweesi Joseph*

*Jembi Health Systems NPC* *|  **Uganda*

*Mobile: **+256784994313** | Office: **Software Developer** | Skype:*
*kaweesi.joseph*
*E-mail: kaweesi@jembi.org <kaweesi@jembi.org>*

*This e-mail contains proprietary and confidential information some or all
of which may be legally privileged. It is for the intended recipient only.
If an addressing or transmission error has misdirected this e-mail, please
notify the author by replying to this e-mail and then deleting same. If you
are not the intended recipient you must not use, disclose, distribute,
copy, print or rely on this e-mail. Jembi Health Systems NPO, its
subsidiaries and associated companies is not liable for the security of
information sent by e-mail and accepts no liability of whatsoever nature
for any loss, damage or expense resulting, directly or indirectly, from the
access of this e-mail or any attachments hereto.*


❌ [Build was (probably) aborted](https://jenkins.internalx.com/job/macios/job/master/141/display/redirect)

🔥 [Jenkins job](https://jenkins.internalx.com/job/macios/job/master/141/display/redirect) (on internal Jenkins) failed in stage(s) 'Build' 🔥 : hudson.AbortException: script returned exit code 2

🔥 [Build failed](https://jenkins.internalx.com/job/macios/job/master/141//console) 🔥


I also changed the variable name in line 28 and line 31.


oh, hi. u are coming soon. 😄


Это должен был быть "amend", но что-то пошло не так (опять)


Moved MS WIN 465, 474, 599, 600 from Other issues to PXE Issues.


Are you sure you know what you're doing? You're modifying the template we've tested and if anything doesn't work, you're on your own. Your code looks like it's been copy-pasted from some place(s) and it uses the disallowed sqlalchemy package.


# CalculatorPj

This project is used for add, subtract, multiply, divisor, and remainder of two numbers that are input from user.
It is written by Ruby programming language and run in 'Visual Studio Code'.
It is designed to choose one operator in a time.
It is also implemented to choose another operator and another numbers if user choose 'y' for the question of "Do you wanna again: y/n?"
It will be finished process if user choose 'n' for the question of "Do you wanna again: y/n?"

User can choose one of the operators such as "+, -, *, / and %".
First, user must input first number.
Second, user must choose an operator in one of "+", "-", "*", "/" and "%".
And then, user must also input second number.

Note: There is an error that cannot operate other operator expect above operators.If user choose other operator the output will be shown "Invalid"!!


No, it doesn't persist back to the client. This integrates with the current behavior, by overriding the setting if there's a valid JWT token, and let's it pass through. Without the JWT code, the API call coming from the web is always denied.


W/r/t consistency, I just meant make the wording consistent - eg “failed to
load X from Y while trying Z method”.

As for core vs platform, I agree that it makes sense for JNA core to handle
it.

On Wed, Oct 17, 2018 at 7:02 AM ohuseyinoglu <notifications@github.com>
wrote:

> I didn't get a notification of your comment here, and I was thinking why
> @twall <https://github.com/twall> stopped being so responsive after
> helping me so much in the group thread!? My bad... :)
>
> I'm not sure I quite understood your first paragraph regarding "making
> DEBUG_LOAD messages consistent with those already existing". Since I'm
> intentionally adding extra bits of information in them (about failures, and
> AIX idiosyncracies), making them look like existing ones by taking out that
> info(?) would defeat my purpose. Am I missing your point?
>
> As for handling this outside JNA (at the caller level), I did also go back
> and forth on that, but since
>
>    - there's already specialy handling here for certain platforms, and
>    - not to force JNA users to be involved in AIX (platform specific)
>    idiosyncracies (for multi-platform libraries like pcap *with same API
>    across OS'es*)
>
> I thought this would also be an acceptable solution.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/ohuseyinoglu/jna/commit/a470be0270800644a277b4ab1260ed0312cf5067#commitcomment-30937609>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAuMrRQ8RbHNFeKIESDX-i2Tv-JcgmRIks5ulw5SgaJpZM4XbQ4B>
> .
>


cf issue #10


Successfully aliased the URL <https://styled-components-rzxjifkbha.now.sh> to the following alias.

* https://www.styled-components.com


I find the problem:
#        exec('foro%d = Forotag(%f,%f,%f,%f,%f,%f,%d,4,%d,"%s",%d,"%s","%s",%d)' % (i,cx,cy,cz,cr,
#                                                                                cf.htesto,cf.angolo,i,
#                                                                                cf.cer_colore,cf.cer_livello,
#                                                                                cf.etk_colore,cf.etk_livello,
#                                                                                cf.tes_livello,cf.tes_colore))
#        exec("out_dxf.write(foro%d.dxfcode)" % i)
        foro1=Forotag(cx,cy,cz,cr,cf.htesto,cf.angolo,i,cf.cer_colore,cf.cer_livello,cf.etk_colore,cf.etk_livello,
                                                                                cf.tes_livello,cf.tes_colore)
        print(foro1.dxfcode)`
the uncommented code works, commented one not. So i guess it's my fault in some point of the string format lines


Trying to push files to Mark's repo


Good point. It's probably better to use the subject that comes from spring security rather than the session. I'm not sure we need to put the subject in the JWT claim, or verify it here. There's an interceptor that fires later that ensures the identity is set, so we can check something else here. Maybe it's sufficient just to have a valid, non-expired token?


This change is quite problematic - it will now never return a resolution if a word is recognized as more than one entity. For example, we have a speed entity with one of the values being "3" or "three" or "medium". "3" is recognized as both the builtin number and our entity - but since this change TryFindEntity will never work.


Okey, i don't understood why you do a check here with that, for me don't make sense. I mean, check if is true or false, check what?


was also reported on https://github.com/metasfresh/metasfresh/issues/4577#issuecomment-430579640


It's not really a variable, just a check void


Base64 Mime kodeeringu asendamine Basic kodeeringuda teeb katki olemasolevate DVK klientide poolt dokumentide  saatmise DHX adresaadile.

Sest osad DVK kasutajad (ja lisaks ka mõned DHX implemeneteerijad - Keskkonnaministeerium) juba saadavad manuseid Base64 Mime kodeeringus.

Parem oleks lahendus kui on toetatud mõlemad variandid nii Basic kui MIME.

Seda saaks teha  "base64DecodeIfNeededAndUnzip" sees kus võiks proovida kolme varianti:
1) Proovida Dekodeerida kui BASE64 basic
2) Proovida Dekodeerida kui BASE64 mime
3) Proovida dekodeerida kui puhtalt GZIP


Deployment failed with the following error:

~~~
An unexpected error occurred!
~~~


WARNING:
This fix did not fulfill its purpose!


Nie zwracamy w taki sposób danych do widoku. Trzymamy się ustalonej konwencji:
`return view('reportpage.accountReport.ReportUnusedAccount')
            ->with('department_info', $data['departments'])
            ->with('users_warning', $data['users_warning'])`
@tokarskimarcin


Fixed


> Interesting - so in what units are the kerning pair offsets?

In "font units".  Ie. UPEM.

> And this function is running unscaled, and scaled? In which contexts?

When we call font-funcs get_h_kerning callback, the values are already scaled.  When called from kern table or kerx table, the values are in font units.


also please check out the issue, B and BL should be included in the file


dsd

sdds


Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

- @brgcode was added to conda-forge. Welcome to conda-forge!
  Go to https://github.com/orgs/conda-forge/invitation see your invitation.

You should get push access to this feedstock and CI services.

Feel free to join the community [chat room](https://gitter.im/conda-forge/conda-forge.github.io).

NOTE: Please make sure to not push to the repository directly.
      Use branches in your fork for any changes and send a PR.
      More details [here](https://conda-forge.org/docs/conda-forge_gotchas.html#using-a-fork-vs-a-branch-when-updating-a-recipe)


またここで errorにnullを代入しているのは下でcatchのerrを渡すためでしょうか？


invalidValistには数値以外のものを格納している。という認識で間違いないでしょうか？


See issue #65 ...


Using file uploads eliminates the advantages that Git provides. You should do regular commits and pushes.


You can check CanSeek which indicates whether the stream supports Length


Este cambio es malísimo


Ciezko zrozumieć co zwracają zapytania `$departmentStats`, `$departmentStats2`, `$departmentStats3`. Nadając w ten sposób nazwy zmiennym, nie ułatwiamy pracy osobie, która w przyszłości musiała by zrozumieć kod aby coś w nim zmienic. Dłuższe zapytania powinny mieć opis w komentarzu co zwracają lub do czego służą i jeśli to możliwe intuicyjną nazwę @tokarskimarcin


U suck >:v


Created multidev environment [d8-digital-stlawu#ci-167](https://dashboard.pantheon.io/sites/9f185cec-9c0b-4fcb-972f-9a5f2f6ed252#ci-167).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-167-d8-digital-stlawu.pantheonsite.io/)


Update server.py to do what? Your message should explain the purpose. A message like "Change port to 5000" would make much more sense.


Uebung 2 + Uebung Teile von Uebung 3


`lastName` nie istnieje w encji Company


![](https://github.trello.services/images/mini-trello-icon.png) [Make session metrics exportable as json file](https://trello.com/c/X2EWp6bw/1-make-session-metrics-exportable-as-json-file)


Este cambio es buenísimo, eres un genio.


Usuwanie powinno istnieć


Created multidev environment [d8-digital-stlawu#ci-169](https://dashboard.pantheon.io/sites/9f185cec-9c0b-4fcb-972f-9a5f2f6ed252#ci-169).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-169-d8-digital-stlawu.pantheonsite.io/)


comment here is not aligned with what you are doing.


Successfully aliased the URL <https://alphabet-keys-mhidbellgv.now.sh> to the following alias.

* https://alphabet-keys.now.sh


Same here, the comment is not aligned with your work. I would totally remove those first two lines and instead make it `Copyright (C) 2014 Netflix, Inc. and all other contributors`. This will avoid for every contribution to add new licenses.


Hugely nice! Dat wat I'm takin' 'bout. Gj

regards.


Remove commented code related to mongo


`<n>` notation should be explained.
What is n?


I do know all of this. :wink:

My point is that Classic use a different spell to summon this NPC that the one used in TBC and WotLK. It summons this NPC as a guardian. Even with TotemAI set in DB, it does not behave like a totem but like a guardian. Hence the need for this script. At least in Classic.


import java.awt.*;

public interface GrayColor extends Comparable<GrayColor> {
    int getGrayLevel();
    void setGrayLevel(int grayLevel);
    Color getColor();
}


If this is being done in the base layout template, will this remove GA from *all* internal pages, not just those with the password reset token?

I'm not necessarily against that, but I'm not sure that was what was intended here.


What for?


Does this mean I finally get and get keep differnce


![](https://github.trello.services/images/mini-trello-icon.png) [Bruno Colaço](https://trello.com/c/WNvNWxfG/14-bruno-cola%C3%A7o)


So I keep it all and you pay me how much


@SDoehren  Please, do NOT change the format. I have to revert your changes and removed the commit rights. Sorry.  If you're looking for the csv format, please use the footballcsv org and repos -> https://github.com/footballcsv


Second slide not appearing. Reviewing changes.


[R/berekenLSVIbasis.R:451:16:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/berekenLSVIbasis.R#L451) *style:* **Place a space before left parenthesis, except in a function call.**
```r
<U+200B>          mean(((.data$Verschilscore + 1) / 2) ^ -1,
               ^
```
[R/berekenLSVIbasis.R:451:17:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/berekenLSVIbasis.R#L451) *style:* **Place a space before left parenthesis, except in a function call.**
```r
<U+200B>          mean(((.data$Verschilscore + 1) / 2) ^ -1,
                ^
```
[R/berekenLSVIbasis.R:467:31:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/berekenLSVIbasis.R#L467) *style:* **Place a space before left parenthesis, except in a function call.**
```r
<U+200B>        Index_min_harm = mean(((.data$Index_min_criterium + 1) / 2) ^ -1,
                              ^
```
[R/berekenLSVIbasis.R:467:32:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/berekenLSVIbasis.R#L467) *style:* **Place a space before left parenthesis, except in a function call.**
```r
<U+200B>        Index_min_harm = mean(((.data$Index_min_criterium + 1) / 2) ^ -1,
                               ^
```
[R/berekenLSVIbasis.R:471:16:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/berekenLSVIbasis.R#L471) *style:* **Place a space before left parenthesis, except in a function call.**
```r
<U+200B>          mean(((.data$Index_harm_criterium + 1) / 2) ^ -1,
               ^
```
[R/berekenLSVIbasis.R:471:17:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/berekenLSVIbasis.R#L471) *style:* **Place a space before left parenthesis, except in a function call.**
```r
<U+200B>          mean(((.data$Index_harm_criterium + 1) / 2) ^ -1,
                ^
```
[R/berekenLSVIbasis.R:492:54:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/berekenLSVIbasis.R#L492) *style:* **Put spaces around all infix operators.**
```r
<U+200B>                  sum(!is.na(.data$Status_indicator))/2.0
                                                    ~^~
```
[R/combinerenVerschilscore.R:35:6:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/combinerenVerschilscore.R#L35) *warning:* **local variable '%max%' assigned but may not be used**
```r
<U+200B>    `%max%` <- function(a, b) max(a, b)
     ^~~~~
```
[R/combinerenVerschilscore.R:36:6:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/combinerenVerschilscore.R#L36) *warning:* **local variable '%min%' assigned but may not be used**
```r
<U+200B>    `%min%` <- function(a, b) min(a, b)
     ^~~~~
```
[R/combinerenVoorwaarden.R:31:1:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/combinerenVoorwaarden.R#L31) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>    #nog testen of Formule bestaat uit EN, OF, haakjes en VoorwaardeID's (en evt. andere tekens die logische berekening toelaten)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/invoercontroleData_voorwaarden.R:66:1:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/invoercontroleData_voorwaarden.R#L66) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>    #misschien best ook testen dat die indicator-criterium-voorwaarde-combinatie in de databank voorkomt?  En of deze voor dat habitattype voorkomt, maar dat best verderop doen
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/s4_aandeel.R:46:36:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/s4_aandeel.R#L46) *style:* **Put spaces around all infix operators.**
```r
<U+200B>      aandeel_min <- min(teller_min/noemer_max, 1)
                                  ~^~
```
[R/s4_aandeel.R:47:36:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/s4_aandeel.R#L47) *style:* **Put spaces around all infix operators.**
```r
<U+200B>      aandeel_max <- min(teller_max/noemer_min, 1)
                                  ~^~
```
[R/s4_aandeelKruidlaag.R:33:7:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/s4_aandeelKruidlaag.R#L33) *style:* **Place a space before left parenthesis, except in a function call.**
```r
<U+200B>    if(nrow(vegetatielaag) > 0){
      ^
```
[R/s4_aandeelKruidlaag.R:35:1:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/s4_aandeelKruidlaag.R#L35) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>      #indien bedekking vegetatielaag is meegegeven wordt deze als noemer gebruikt
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/s4_aandeelKruidlaag.R:36:1:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/s4_aandeelKruidlaag.R#L36) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>      resultaat <- c(teller[1]/vegetatielaag$WaardeMax, teller[2]/vegetatielaag$WaardeMin)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/s4_aandeelKruidlaag.R:36:31:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/s4_aandeelKruidlaag.R#L36) *style:* **Put spaces around all infix operators.**
```r
<U+200B>      resultaat <- c(teller[1]/vegetatielaag$WaardeMax, teller[2]/vegetatielaag$WaardeMin)
                             ~^~
```
[R/s4_aandeelKruidlaag.R:36:66:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/s4_aandeelKruidlaag.R#L36) *style:* **Put spaces around all infix operators.**
```r
<U+200B>      resultaat <- c(teller[1]/vegetatielaag$WaardeMax, teller[2]/vegetatielaag$WaardeMin)
                                                                ~^~
```
[R/s4_aandeelKruidlaag.R:39:1:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/s4_aandeelKruidlaag.R#L39) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>      #indien bedekking vegetatielaag niet is meegegeven wordt deze berekend op basis van alle soorten in kruidlaag
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/s4_aandeelKruidlaag.R:49:31:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/s4_aandeelKruidlaag.R#L49) *style:* **Put spaces around all infix operators.**
```r
<U+200B>      resultaat <- c(teller[1]/BedekkingMax, teller[2]/BedekkingMin)
                             ~^~
```
[R/s4_aandeelKruidlaag.R:49:55:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/s4_aandeelKruidlaag.R#L49) *style:* **Put spaces around all infix operators.**
```r
<U+200B>      resultaat <- c(teller[1]/BedekkingMax, teller[2]/BedekkingMin)
                                                     ~^~
```
[R/s4_bedekking.R:24:1:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/s4_bedekking.R#L24) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>      filter(is.na(.data$Eenheid) | (!.data$Eenheid %in% c("Grondvlak_ha", "Volume_ha")))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/s4_maxBedekking.R:23:1:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/s4_maxBedekking.R#L23) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>      filter(is.na(.data$Eenheid) | (!.data$Eenheid %in% c("Grondvlak_ha", "Volume_ha")))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/s4_maxBedekkingExcl.R:23:1:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/s4_maxBedekkingExcl.R#L23) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>      filter(is.na(.data$Eenheid) | (!.data$Eenheid %in% c("Grondvlak_ha", "Volume_ha")))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/zzz.R:31:13:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/R/zzz.R#L31) *warning:* **no visible binding for global variable 'ConnectiePool'**
```r
<U+200B>  poolClose(ConnectiePool)
            ^~~~~~~~~~~~~
```
[inst/tests/testthat/test_berekenLSVIbasis_vegetatielaag.R:24:1:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/inst/tests/testthat/test_berekenLSVIbasis_vegetatielaag.R#L24) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>      mutate(  #idee is om onderstaande code te wissen zodra de databank/rekenmodule hiervoor aangepast is
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/tests/testthat/test_berekenLSVIbasis_vegetatielaag.R:190:1:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/inst/tests/testthat/test_berekenLSVIbasis_vegetatielaag.R#L190) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>      mutate(  #idee is om onderstaande code te wissen zodra de databank/rekenmodule hiervoor aangepast is
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/tests/testthat/test_onderscheid_GrondvlakBedekking.R:14:1:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/inst/tests/testthat/test_onderscheid_GrondvlakBedekking.R#L14) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>              col_types = list(col_character(), col_character(), col_character(), col_character(), col_character(), col_character(), col_character(), col_logical(), col_character(), col_character(), col_character()))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/tests/testthat/test_onderscheid_GrondvlakBedekking.R:34:2:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/inst/tests/testthat/test_onderscheid_GrondvlakBedekking.R#L34) *style:* **Commented code should be removed.**
```r
<U+200B>#load(system.file("vbdata/Resultaat_RapportageHR_test.Rdata", package = "LSVI"))
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/tests/testthat/test_onderscheid_GrondvlakBedekking.R:36:1:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/inst/tests/testthat/test_onderscheid_GrondvlakBedekking.R#L36) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>describe("nakijken of er onderscheid gemaakt worden tussen bedekking en grondvlak bij boomsoorten", {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/tests/testthat/test_onderscheid_GrondvlakBedekking.R:37:1:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/inst/tests/testthat/test_onderscheid_GrondvlakBedekking.R#L37) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>  it("Correcte berekening invasieve exoten boom- en struiklaag op basis van bedekking en sleutelsoorten boomlaag op basis van grondvlak", {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/tests/testthat/test_s4_Aantal.R:201:1:](https://github.com/inbo/LSVI/blob/c83eb8b34f2655604f294352a0aef76cae124eb1/inst/tests/testthat/test_s4_Aantal.R#L201) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>  #nog toevoegen als het opzoeken van soorten in subniveaus opgelost is: de aggregatie van bedekkingen gebeurt correct
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


![](https://github.trello.services/images/mini-trello-icon.png) [André Carvalho](https://trello.com/c/MlnhnEGo/13-andr%C3%A9-carvalho)


![](https://github.trello.services/images/mini-trello-icon.png) [Mariana Silva](https://trello.com/c/QdZe2gx5/16-mariana-silva)


`            ->select('department_info.id', DB::raw('COUNT(CASE WHEN users.user_type_id IN (1,2) AND users.id IN ('.
                implode(",",Work_Hour::select('id_user')->whereBetween('created_at',[$date_start,$date_stop])->distinct()->get()->pluck('id_user')->toArray())
                .') THEN 1 ELSE NULL END) as working_users_sum'))`

Zbyt duża incepcja: Wewnątrz zapytania, wewnątrz funkcji count, wewnątrz funkcji case, wewnątrz funkcji IN, funkcja php inplode wewnątrz której jest podzapytanie. Proszę zmień to tzn, część umieść w zmiennych przed zapytaniem aby to samo w sobie złożone zapytanie było bardziej czytelne i aby można było jego poszczególne fragmenty w przyszłości edytować osobno. @tokarskimarcin


@SDoehren  Please, do NOT change the format. I have to revert your changes and removed your commit rights. Sorry.  If you're looking for the csv format, please use the footballcsv org and repos -> https://github.com/footballcsv


"It consists of the light intensity and color, the application can use these values to apply them into the intensity and the color of the ambient light of their virtual scene."


having the documents browser is great already. You can work with that already very nicely.

If you have experience with icloud saving of the documents folder, It would be nice enabling that for Exult :)


aa


index.htmlを変更だと、具体的に何が変わってるのかがわからない


It will not be for all pages.  It is only for these pages: current_page?(controller: 'sign_up/passwords', action: 'new') ||
      current_page?(controller: 'users/reset_passwords', action: 'edit')


![screen shot 2018-10-17 at 13 44 35](https://user-images.githubusercontent.com/7354248/47087995-5ced4580-d215-11e8-9dbe-1b2ad40424e3.png)


On this repo, seems to be named `locale` with no extension as usual `locale.xml`. If it wrong my appreciation, please forget this comment.


I hope this is enough to put the new LFO vignette on the LOO website. I didn't commit any other updates to the website because the current master is not a release version and to my understanding, we should usually be updating gh-pages only when having a new release.


ꯃꯣꯍꯥꯋꯛ


1) MOD is bad english, as is REM.
2) REM is a traditional comment syntax word (DOS batch files).
3) 0-length paths are bad and wrong. 0-length anything that is not delimited at its extremes is horrible.
4) There is little good case to be made for removing natural words that are composed entirely of slashes.
5) Consistency with Haskell and Closure is neither necessary nor desirable in general.
6) The widespread use of // for comments in many languages strongly suggests only that those designers copied it from C++, repeating its mistake.
7) The argument that // is "solid" and ;; is "messy" is pejorative, specious, and biased.
8) Mixing fragments of code from multiple languages that use different commenting styles is unavoidable, and should be encouraged wherever possible.
9) Making code fragments of different languages look more alike is an egregious error. Their differences should be enhanced if anything, to make modifying them less error-prone.


вы здесь меняете глобальный объект `require('../utils/git').Git`, это изменение будет влиять на все тесты


Test comment 3


pdf 공백 페이지 제거하기위해 라이선스 조항 및 프로젝트 사례 수정.
공통적 준수사항 부분에서 줄바꿈 안된부분 있어서 수정.


что проверяете здесь? просто пробуете API для тестов?


Actually, I think you should not ask the contract to find the correct hand. The combination should be given to the contract, and the contract will confirm it.
What if there were 1000 allowed moves? Would you burst through the block gas limit?


Refactor suggestion:
```js
const { address, port } = socket.address()
```


для тестирования контроллеров express лучше вызывать их руками и передавать им заглушки для запроса и ответа, например, [такие](https://www.npmjs.com/package/sinon-express-mock)


Good for those clear descriptions of different methods


To optimise code
one off strings has to be of size less than n  or both strings have size greater than n..
Still thinking about this one.


This fixes Issue #5


(( Yī pòzhéhào hā xī ))


попробуйте вместо самописных заглушек использовать https://www.npmjs.com/package/sinon


A funny side effect from commit [#3c6d43d](https://github.com/vindard/twitter-to-keybase/commit/3c6d43d91f20547050998707b46391db2c335c94) was that by adding a 0.1s delay for printing reasons it seems that the Twitter [HTTP 429] timeout error from Issue #4 doesn't get thrown as much anymore.

This allowed the parameter change in this commit.


Puzzle `550-87015712` disappeared from [`catalog/context.py`](https://github.com/fidals/refarm-site/blob/master/catalog/context.py), that's why I closed #181. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.


Puzzle `550-f02726e9` disappeared from [`catalog/context.py`](https://github.com/fidals/refarm-site/blob/master/catalog/context.py), that's why I closed #182. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.


Puzzle `550-6e482196` disappeared from [`catalog/context.py`](https://github.com/fidals/refarm-site/blob/master/catalog/context.py), that's why I closed #184. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.


Puzzle `182-0e795671` discovered in   [`catalog/context.py`](  https://github.com/fidals/refarm-site/blob/master/catalog/context.py)   and submitted as #197. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


Puzzle `182-b72b72d4` discovered in   [`catalog/context.py`](  https://github.com/fidals/refarm-site/blob/master/catalog/context.py)   and submitted as #198. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


Puzzle `182-e00fc42b` discovered in   [`pages/models.py`](  https://github.com/fidals/refarm-site/blob/master/pages/models.py)   and submitted as #199. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


I wasn't able to retrieve PDD puzzles from the code base and submit them to GitHub. If you think that it's a bug on our side, please submit it to [yegor256/0pdd](https://github.com/yegor256/0pdd/issues):

> GET https://api.github.com/repos/fidals/refarm-site/issues/550: 404 - Not Found // See: https://developer.github.com/v3/issues/#get-a-single-issue

Please, copy and paste this stack trace to GitHub:

```
Octokit::NotFound
GET https://api.github.com/repos/fidals/refarm-site/issues/550: 404 - Not Found // See: https://developer.github.com/v3/issues/#get-a-single-issue
/app/vendor/bundle/ruby/2.5.0/gems/octokit-4.13.0/lib/octokit/response/raise_error.rb:16:in `on_complete'
/app/vendor/bundle/ruby/2.5.0/gems/faraday-0.15.3/lib/faraday/response.rb:9:in `block in call'
/app/vendor/bundle/ruby/2.5.0/gems/faraday-0.15.3/lib/faraday/response.rb:61:in `on_complete'
/app/vendor/bundle/ruby/2.5.0/gems/faraday-0.15.3/lib/faraday/response.rb:8:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/octokit-4.13.0/lib/octokit/middleware/follow_redirects.rb:73:in `perform_with_redirection'
/app/vendor/bundle/ruby/2.5.0/gems/octokit-4.13.0/lib/octokit/middleware/follow_redirects.rb:61:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/faraday-0.15.3/lib/faraday/request/retry.rb:128:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/faraday-0.15.3/lib/faraday/rack_builder.rb:143:in `build_response'
/app/vendor/bundle/ruby/2.5.0/gems/faraday-0.15.3/lib/faraday/connection.rb:387:in `run_request'
/app/vendor/bundle/ruby/2.5.0/gems/faraday-0.15.3/lib/faraday/connection.rb:138:in `get'
/app/vendor/bundle/ruby/2.5.0/gems/sawyer-0.8.1/lib/sawyer/agent.rb:94:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/octokit-4.13.0/lib/octokit/connection.rb:156:in `request'
/app/vendor/bundle/ruby/2.5.0/gems/octokit-4.13.0/lib/octokit/connection.rb:19:in `get'
/app/vendor/bundle/ruby/2.5.0/gems/octokit-4.13.0/lib/octokit/client/issues.rb:114:in `issue'
/app/objects/github_tickets.rb:40:in `notify'
/app/objects/milestone_tickets.rb:35:in `notify'
/app/objects/logged_tickets.rb:36:in `notify'
/app/objects/github_tagged_tickets.rb:36:in `notify'
/app/objects/commit_tickets.rb:34:in `notify'
/app/objects/emailed_tickets.rb:31:in `notify'
/app/objects/sentry_tickets.rb:36:in `notify'
/app/objects/diff.rb:38:in `block in notify'
/app/objects/diff.rb:33:in `each'
/app/objects/diff.rb:33:in `notify'
/app/objects/job.rb:40:in `proceed'
/app/objects/job_starred.rb:33:in `proceed'
/app/objects/job_recorded.rb:32:in `proceed'
/app/objects/job_emailed.rb:35:in `proceed'
/app/objects/job_commiterrors.rb:36:in `proceed'
/app/objects/job_detached.rb:48:in `exclusive'
/app/objects/job_detached.rb:36:in `block in proceed'
/app/objects/job_detached.rb:36:in `fork'
/app/objects/job_detached.rb:36:in `proceed'
/app/0pdd.rb:347:in `block in <top (required)>'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1635:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1635:in `block in compile!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:992:in `block (3 levels) in route!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1011:in `route_eval'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:992:in `block (2 levels) in route!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1040:in `block in process_route'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1038:in `catch'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1038:in `process_route'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:990:in `block in route!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:989:in `each'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:989:in `route!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1097:in `block in dispatch!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `block in invoke'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `catch'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `invoke'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1094:in `dispatch!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:924:in `block in call!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `block in invoke'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `catch'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `invoke'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:924:in `call!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:913:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-protection-2.0.4/lib/rack/protection/xss_header.rb:18:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-protection-2.0.4/lib/rack/protection/path_traversal.rb:16:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-protection-2.0.4/lib/rack/protection/json_csrf.rb:26:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-protection-2.0.4/lib/rack/protection/base.rb:50:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-protection-2.0.4/lib/rack/protection/base.rb:50:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-protection-2.0.4/lib/rack/protection/frame_options.rb:31:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.5/lib/rack/logger.rb:15:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.5/lib/rack/common_logger.rb:33:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:231:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:224:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.5/lib/rack/head.rb:12:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.5/lib/rack/method_override.rb:22:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:194:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1957:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1502:in `block in call'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1729:in `synchronize'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1502:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.5/lib/rack/handler/webrick.rb:86:in `service'
/app/vendor/ruby-2.5.1/lib/ruby/2.5.0/webrick/httpserver.rb:140:in `service'
/app/vendor/ruby-2.5.1/lib/ruby/2.5.0/webrick/httpserver.rb:96:in `run'
/app/vendor/ruby-2.5.1/lib/ruby/2.5.0/webrick/server.rb:307:in `block in start_thread'
```


названия тестов сформулированы в терминах реализации (тестируем параметры функции)
нужно формулировать названия тестов как требования к блоку. например, вместо `можно получить историю из git (без параметров, значения по-умолчанию)` будет название `первый элемент - всегда страница истории`  или `у последнего элемента должен быть пустой адрес`

тогда и набор тестов тоже будет другим


[R/berekenLSVIbasis.R:451:16:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/berekenLSVIbasis.R#L451) *style:* **Place a space before left parenthesis, except in a function call.**
```r
<U+200B>          mean(((.data$Verschilscore + 1) / 2) ^ -1,
               ^
```
[R/berekenLSVIbasis.R:451:17:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/berekenLSVIbasis.R#L451) *style:* **Place a space before left parenthesis, except in a function call.**
```r
<U+200B>          mean(((.data$Verschilscore + 1) / 2) ^ -1,
                ^
```
[R/berekenLSVIbasis.R:467:31:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/berekenLSVIbasis.R#L467) *style:* **Place a space before left parenthesis, except in a function call.**
```r
<U+200B>        Index_min_harm = mean(((.data$Index_min_criterium + 1) / 2) ^ -1,
                              ^
```
[R/berekenLSVIbasis.R:467:32:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/berekenLSVIbasis.R#L467) *style:* **Place a space before left parenthesis, except in a function call.**
```r
<U+200B>        Index_min_harm = mean(((.data$Index_min_criterium + 1) / 2) ^ -1,
                               ^
```
[R/berekenLSVIbasis.R:471:16:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/berekenLSVIbasis.R#L471) *style:* **Place a space before left parenthesis, except in a function call.**
```r
<U+200B>          mean(((.data$Index_harm_criterium + 1) / 2) ^ -1,
               ^
```
[R/berekenLSVIbasis.R:471:17:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/berekenLSVIbasis.R#L471) *style:* **Place a space before left parenthesis, except in a function call.**
```r
<U+200B>          mean(((.data$Index_harm_criterium + 1) / 2) ^ -1,
                ^
```
[R/berekenLSVIbasis.R:492:54:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/berekenLSVIbasis.R#L492) *style:* **Put spaces around all infix operators.**
```r
<U+200B>                  sum(!is.na(.data$Status_indicator))/2.0
                                                    ~^~
```
[R/combinerenVerschilscore.R:35:6:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/combinerenVerschilscore.R#L35) *warning:* **local variable '%max%' assigned but may not be used**
```r
<U+200B>    `%max%` <- function(a, b) max(a, b)
     ^~~~~
```
[R/combinerenVerschilscore.R:36:6:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/combinerenVerschilscore.R#L36) *warning:* **local variable '%min%' assigned but may not be used**
```r
<U+200B>    `%min%` <- function(a, b) min(a, b)
     ^~~~~
```
[R/combinerenVoorwaarden.R:31:1:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/combinerenVoorwaarden.R#L31) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>    #nog testen of Formule bestaat uit EN, OF, haakjes en VoorwaardeID's (en evt. andere tekens die logische berekening toelaten)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/invoercontroleData_voorwaarden.R:66:1:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/invoercontroleData_voorwaarden.R#L66) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>    #misschien best ook testen dat die indicator-criterium-voorwaarde-combinatie in de databank voorkomt?  En of deze voor dat habitattype voorkomt, maar dat best verderop doen
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/s4_aandeel.R:46:36:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/s4_aandeel.R#L46) *style:* **Put spaces around all infix operators.**
```r
<U+200B>      aandeel_min <- min(teller_min/noemer_max, 1)
                                  ~^~
```
[R/s4_aandeel.R:47:36:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/s4_aandeel.R#L47) *style:* **Put spaces around all infix operators.**
```r
<U+200B>      aandeel_max <- min(teller_max/noemer_min, 1)
                                  ~^~
```
[R/s4_aandeelKruidlaag.R:33:7:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/s4_aandeelKruidlaag.R#L33) *style:* **Place a space before left parenthesis, except in a function call.**
```r
<U+200B>    if(nrow(vegetatielaag) > 0){
      ^
```
[R/s4_aandeelKruidlaag.R:35:1:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/s4_aandeelKruidlaag.R#L35) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>      #indien bedekking vegetatielaag is meegegeven wordt deze als noemer gebruikt
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/s4_aandeelKruidlaag.R:36:1:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/s4_aandeelKruidlaag.R#L36) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>      resultaat <- c(teller[1]/vegetatielaag$WaardeMax, teller[2]/vegetatielaag$WaardeMin)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/s4_aandeelKruidlaag.R:36:31:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/s4_aandeelKruidlaag.R#L36) *style:* **Put spaces around all infix operators.**
```r
<U+200B>      resultaat <- c(teller[1]/vegetatielaag$WaardeMax, teller[2]/vegetatielaag$WaardeMin)
                             ~^~
```
[R/s4_aandeelKruidlaag.R:36:66:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/s4_aandeelKruidlaag.R#L36) *style:* **Put spaces around all infix operators.**
```r
<U+200B>      resultaat <- c(teller[1]/vegetatielaag$WaardeMax, teller[2]/vegetatielaag$WaardeMin)
                                                                ~^~
```
[R/s4_aandeelKruidlaag.R:39:1:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/s4_aandeelKruidlaag.R#L39) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>      #indien bedekking vegetatielaag niet is meegegeven wordt deze berekend op basis van alle soorten in kruidlaag
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/s4_aandeelKruidlaag.R:49:31:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/s4_aandeelKruidlaag.R#L49) *style:* **Put spaces around all infix operators.**
```r
<U+200B>      resultaat <- c(teller[1]/BedekkingMax, teller[2]/BedekkingMin)
                             ~^~
```
[R/s4_aandeelKruidlaag.R:49:55:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/s4_aandeelKruidlaag.R#L49) *style:* **Put spaces around all infix operators.**
```r
<U+200B>      resultaat <- c(teller[1]/BedekkingMax, teller[2]/BedekkingMin)
                                                     ~^~
```
[R/s4_bedekking.R:24:1:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/s4_bedekking.R#L24) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>      filter(is.na(.data$Eenheid) | (!.data$Eenheid %in% c("Grondvlak_ha", "Volume_ha")))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/s4_maxBedekking.R:23:1:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/s4_maxBedekking.R#L23) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>      filter(is.na(.data$Eenheid) | (!.data$Eenheid %in% c("Grondvlak_ha", "Volume_ha")))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/s4_maxBedekkingExcl.R:23:1:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/s4_maxBedekkingExcl.R#L23) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>      filter(is.na(.data$Eenheid) | (!.data$Eenheid %in% c("Grondvlak_ha", "Volume_ha")))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/zzz.R:31:13:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/R/zzz.R#L31) *warning:* **no visible binding for global variable 'ConnectiePool'**
```r
<U+200B>  poolClose(ConnectiePool)
            ^~~~~~~~~~~~~
```
[inst/tests/testthat/test_berekenLSVIbasis_vegetatielaag.R:24:1:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/inst/tests/testthat/test_berekenLSVIbasis_vegetatielaag.R#L24) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>      mutate(  #idee is om onderstaande code te wissen zodra de databank/rekenmodule hiervoor aangepast is
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/tests/testthat/test_berekenLSVIbasis_vegetatielaag.R:190:1:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/inst/tests/testthat/test_berekenLSVIbasis_vegetatielaag.R#L190) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>      mutate(  #idee is om onderstaande code te wissen zodra de databank/rekenmodule hiervoor aangepast is
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/tests/testthat/test_onderscheid_GrondvlakBedekking.R:14:1:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/inst/tests/testthat/test_onderscheid_GrondvlakBedekking.R#L14) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>              col_types = list(col_character(), col_character(), col_character(), col_character(), col_character(), col_character(), col_character(), col_logical(), col_character(), col_character(), col_character()))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/tests/testthat/test_onderscheid_GrondvlakBedekking.R:21:1:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/inst/tests/testthat/test_onderscheid_GrondvlakBedekking.R#L21) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>describe("nakijken of er onderscheid gemaakt worden tussen bedekking en grondvlak bij boomsoorten", {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/tests/testthat/test_onderscheid_GrondvlakBedekking.R:22:1:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/inst/tests/testthat/test_onderscheid_GrondvlakBedekking.R#L22) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>  it("Correcte berekening invasieve exoten boom- en struiklaag op basis van bedekking en sleutelsoorten boomlaag op basis van grondvlak", {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/tests/testthat/test_s4_Aantal.R:201:1:](https://github.com/inbo/LSVI/blob/c8093ca6527312ae0ed7e2568f8ebfb77d27a2b5/inst/tests/testthat/test_s4_Aantal.R#L201) *style:* **lines should not be more than 80 characters.**
```r
<U+200B>  #nog toevoegen als het opzoeken van soorten in subniveaus opgelost is: de aggregatie van bedekkingen gebeurt correct
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


for what purposes do you add new features to version 3.8?

PartyMemberExtraInfo ?


Syma hovering