@Rotonen Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.testing/66/violations
```
plone/app/testing/bbb.py:55:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/bbb.py:99:9: Q001 Remove bad quotes from multiline string.
plone/app/testing/cleanup.py:39:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/helpers.py:432:16: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/testing/helpers.py:442:25: C812 missing trailing comma
plone/app/testing/helpers.py:488:41: C812 missing trailing comma
plone/app/testing/layers.py:100:32: C812 missing trailing comma
plone/app/testing/layers.py:135:45: C812 missing trailing comma
plone/app/testing/layers.py:161:21: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/testing/layers.py:197:11: T000 Todo note found.
plone/app/testing/layers.py:221:15: C812 missing trailing comma
plone/app/testing/layers.py:247:31: C812 missing trailing comma
plone/app/testing/layers.py:258:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/layers.py:352:39: C812 missing trailing comma
plone/app/testing/layers.py:374:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/layers.py:376:29: C812 missing trailing comma
plone/app/testing/layers.py:380:28: C812 missing trailing comma
plone/app/testing/layers.py:385:25: C812 missing trailing comma
plone/app/testing/layers.py:389:27: C812 missing trailing comma
plone/app/testing/selenium_layers.py:21:35: C812 missing trailing comma
plone/app/testing/selenium_layers.py:32:1: E305 expected 2 blank lines after class or function definition, found 1
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


btw všude by měla být v příkladu vlastně jen 1, je to jediný kontrakt který máme


@Rotonen Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.testing/67/violations
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/app/__init__.py:0:1: C101 Coding magic comment not found
plone/app/testing/__init__.py:0:1: C101 Coding magic comment not found
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PLONE_ZSERVER' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PLONE_FIXTURE' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PLONE_FTP_SERVER' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PloneTestLifecycle' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PLONE_INTEGRATION_TESTING' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.FunctionalTesting' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.IntegrationTesting' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PloneFixture' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PLONE_FUNCTIONAL_TESTING' imported but unused
plone/app/testing/__init__.py:2:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:3:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:4:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:5:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:6:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:7:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:9:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:10:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:11:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:12:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:13:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:14:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:15:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:16:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.quickInstallProduct' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.tearDownMultiPluginRegistration' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.PloneWithPackageLayer' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.applyProfile' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.popGlobalRegistry' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.setRoles' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.ploneSite' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.logout' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.pushGlobalRegistry' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.PloneSandboxLayer' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.login' imported but unused
plone/app/testing/__init__.py:17:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:18:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:19:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:20:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:21:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:22:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:23:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:24:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:25:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:26:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:27:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:28:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:29:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:30:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:31:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:32:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:33:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:33:30: C812 missing trailing comma
plone/app/testing/__init__.py:34:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:35:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:36:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.PLONE_SITE_ID' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.SITE_OWNER_PASSWORD' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.TEST_USER_ID' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.DEFAULT_LANGUAGE' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.PLONE_SITE_TITLE' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.TEST_USER_PASSWORD' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.TEST_USER_ROLES' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.SITE_OWNER_NAME' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.TEST_USER_NAME' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.ROBOT_TEST_LEVEL' imported but unused
plone/app/testing/__init__.py:37:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:38:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:39:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:40:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:41:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:42:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:43:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:44:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:45:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:46:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:47:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:48:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:49:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:50:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:51:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:52:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:53:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:54:1: F401 'plone.app.testing.cleanup.cleanUpMultiPlugins' imported but unused
plone/app/testing/__init__.py:54:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:55:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:56:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:57:1: I004 isort found an unexpected blank line in imports
plone/app/testing/bbb.py:0:1: C101 Coding magic comment not found
plone/app/testing/bbb.py:4:1: I001 isort found an import in the wrong position
plone/app/testing/bbb.py:6:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/bbb.py:6:1: I001 isort found an import in the wrong position
plone/app/testing/bbb.py:7:1: I001 isort found an import in the wrong position
plone/app/testing/bbb.py:10:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/bbb.py:11:1: E302 expected 2 blank lines, found 1
plone/app/testing/bbb.py:49:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/bbb.py:63:80: E501 line too long (87 > 79 characters)
plone/app/testing/bbb.py:92:9: Q001 Remove bad quotes from multiline string.
plone/app/testing/cleanup.py:0:1: C101 Coding magic comment not found
plone/app/testing/cleanup.py:5:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/cleanup.py:14:5: F401 'Products.PluggableAuthService.zcml' imported but unused
plone/app/testing/cleanup.py:21:80: E501 line too long (83 > 79 characters)
plone/app/testing/cleanup.py:37:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/helpers.py:0:1: C101 Coding magic comment not found
plone/app/testing/helpers.py:4:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/helpers.py:6:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:7:1: I004 isort found an unexpected blank line in imports
plone/app/testing/helpers.py:8:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:9:1: I004 isort found an unexpected blank line in imports
plone/app/testing/helpers.py:10:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:11:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:12:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:13:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:14:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:15:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:112:21: S001 found module formatter
plone/app/testing/helpers.py:306:17: E128 continuation line under-indented for visual indent
plone/app/testing/helpers.py:311:23: Q000 Remove bad quotes.
plone/app/testing/helpers.py:311:23: S001 found module formatter
plone/app/testing/helpers.py:314:13: E128 continuation line under-indented for visual indent
plone/app/testing/helpers.py:393:16: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/testing/helpers.py:421:5: E125 continuation line with same indent as next logical line
plone/app/testing/helpers.py:421:9: E128 continuation line under-indented for visual indent
plone/app/testing/helpers.py:443:30: Q000 Remove bad quotes.
plone/app/testing/helpers.py:445:30: Q000 Remove bad quotes.
plone/app/testing/helpers.py:446:17: E128 continuation line under-indented for visual indent
plone/app/testing/helpers.py:446:17: Q000 Remove bad quotes.
plone/app/testing/interfaces.py:0:1: C101 Coding magic comment not found
plone/app/testing/interfaces.py:5:20: Q000 Remove bad quotes.
plone/app/testing/interfaces.py:11:28: E231 missing whitespace after ','
plone/app/testing/layers.py:0:1: C101 Coding magic comment not found
plone/app/testing/layers.py:5:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:6:1: I004 isort found an unexpected blank line in imports
plone/app/testing/layers.py:10:1: I004 isort found an unexpected blank line in imports
plone/app/testing/layers.py:11:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:12:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:13:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:14:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:15:1: I004 isort found an unexpected blank line in imports
plone/app/testing/layers.py:16:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:17:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:18:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:19:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:20:1: I004 isort found an unexpected blank line in imports
plone/app/testing/layers.py:21:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:22:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:22:28: C812 missing trailing comma
plone/app/testing/layers.py:23:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:25:1: E302 expected 2 blank lines, found 1
plone/app/testing/layers.py:39:52: E203 whitespace before ','
plone/app/testing/layers.py:40:52: E203 whitespace before ','
plone/app/testing/layers.py:41:52: E203 whitespace before ','
plone/app/testing/layers.py:43:52: E203 whitespace before ','
plone/app/testing/layers.py:44:52: E203 whitespace before ','
plone/app/testing/layers.py:45:52: E203 whitespace before ','
plone/app/testing/layers.py:47:52: E203 whitespace before ','
plone/app/testing/layers.py:48:52: E203 whitespace before ','
plone/app/testing/layers.py:50:52: E203 whitespace before ','
plone/app/testing/layers.py:51:52: E203 whitespace before ','
plone/app/testing/layers.py:52:52: E203 whitespace before ','
plone/app/testing/layers.py:54:52: E203 whitespace before ','
plone/app/testing/layers.py:55:52: E203 whitespace before ','
plone/app/testing/layers.py:56:52: E203 whitespace before ','
plone/app/testing/layers.py:58:52: E203 whitespace before ','
plone/app/testing/layers.py:59:52: E203 whitespace before ','
plone/app/testing/layers.py:60:52: E203 whitespace before ','
plone/app/testing/layers.py:62:52: E203 whitespace before ','
plone/app/testing/layers.py:63:52: E203 whitespace before ','
plone/app/testing/layers.py:65:52: E203 whitespace before ','
plone/app/testing/layers.py:66:52: E203 whitespace before ','
plone/app/testing/layers.py:67:52: E203 whitespace before ','
plone/app/testing/layers.py:69:52: E203 whitespace before ','
plone/app/testing/layers.py:71:52: E203 whitespace before ','
plone/app/testing/layers.py:73:52: E203 whitespace before ','
plone/app/testing/layers.py:74:52: E203 whitespace before ','
plone/app/testing/layers.py:76:52: E203 whitespace before ','
plone/app/testing/layers.py:77:52: E203 whitespace before ','
plone/app/testing/layers.py:79:52: E203 whitespace before ','
plone/app/testing/layers.py:80:52: E203 whitespace before ','
plone/app/testing/layers.py:82:52: E203 whitespace before ','
plone/app/testing/layers.py:83:52: E203 whitespace before ','
plone/app/testing/layers.py:84:52: E203 whitespace before ','
plone/app/testing/layers.py:86:52: E203 whitespace before ','
plone/app/testing/layers.py:87:52: E203 whitespace before ','
plone/app/testing/layers.py:101:80: E501 line too long (87 > 79 characters)
plone/app/testing/layers.py:134:80: E501 line too long (112 > 79 characters)
plone/app/testing/layers.py:139:80: E501 line too long (96 > 79 characters)
plone/app/testing/layers.py:158:21: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/testing/layers.py:192:11: T000 Todo note found.
plone/app/testing/layers.py:216:19: C812 missing trailing comma
plone/app/testing/layers.py:224:17: E128 continuation line under-indented for visual indent
plone/app/testing/layers.py:225:17: E128 continuation line under-indented for visual indent
plone/app/testing/layers.py:226:17: E128 continuation line under-indented for visual indent
plone/app/testing/layers.py:227:17: E128 continuation line under-indented for visual indent
plone/app/testing/layers.py:228:13: E124 closing bracket does not match visual indentation
plone/app/testing/layers.py:250:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/layers.py:252:1: E302 expected 2 blank lines, found 1
plone/app/testing/layers.py:290:9: E303 too many blank lines (2)
plone/app/testing/layers.py:317:1: E302 expected 2 blank lines, found 1
plone/app/testing/layers.py:321:1: E302 expected 2 blank lines, found 1
plone/app/testing/layers.py:331:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/layers.py:331:80: E501 line too long (96 > 79 characters)
plone/app/testing/layers.py:332:25: E221 multiple spaces before operator
plone/app/testing/layers.py:332:80: E501 line too long (94 > 79 characters)
plone/app/testing/layers.py:334:14: E221 multiple spaces before operator
plone/app/testing/layers.py:334:80: E501 line too long (110 > 79 characters)
plone/app/testing/layers.py:335:17: E221 multiple spaces before operator
plone/app/testing/layers.py:335:80: E501 line too long (115 > 79 characters)
plone/app/testing/selenium_layers.py:0:1: C101 Coding magic comment not found
plone/app/testing/selenium_layers.py:1:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/selenium_layers.py:3:1: I004 isort found an unexpected blank line in imports
plone/app/testing/selenium_layers.py:4:1: I001 isort found an import in the wrong position
plone/app/testing/selenium_layers.py:5:1: I001 isort found an import in the wrong position
plone/app/testing/selenium_layers.py:6:1: I001 isort found an import in the wrong position
plone/app/testing/selenium_layers.py:7:1: I001 isort found an import in the wrong position
plone/app/testing/selenium_layers.py:8:1: I001 isort found an import in the wrong position
plone/app/testing/selenium_layers.py:18:13: S001 found module formatter
plone/app/testing/selenium_layers.py:28:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/selenium_layers.py:31:10: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:34:10: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:60:20: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:61:28: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:63:22: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:66:31: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:79:5: Q001 Remove bad quotes from multiline string.
plone/app/testing/selenium_layers.py:80:80: E501 line too long (82 > 79 characters)
plone/app/testing/selenium_layers.py:81:80: E501 line too long (86 > 79 characters)
plone/app/testing/selenium_layers.py:82:80: E501 line too long (80 > 79 characters)
plone/app/testing/selenium_layers.py:83:80: E501 line too long (81 > 79 characters)
plone/app/testing/selenium_layers.py:87:30: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:88:42: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:100:17: S001 found module formatter
plone/app/testing/selenium_layers.py:100:27: E228 missing whitespace around modulo operator
plone/app/testing/selenium_layers.py:112:21: Q000 Remove bad quotes.
plone/app/testing/tests.py:0:1: C101 Coding magic comment not found
plone/app/testing/tests.py:2:1: I001 isort found an import in the wrong position
plone/app/testing/tests.py:3:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/tests.py:14:5: E265 block comment should start with '# '
plone/app/testing/tests.py:17:5: E265 block comment should start with '# '
plone/app/testing/tests.py:22:1: E122 continuation line missing indentation or outdented
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


这里有什么问题吗？


@rubickcz když jsem to kontroloval tam byl jen commit..


It's a replacing `word` constant with `integer`. Is it correct?


nitpick and sorry, i didn't think about this earlier: this quietly changes the cgroup involved. it might be ok given the system is unlikely to use such long names, therefore rt-app is almost certainly the only user so why care about the name; but it might not, if somebody plays with the task group in a separate script.

what i think should happen in the very unlikely case that `FILENAME_MAX < strlen (path) + strlen (tg_ctrl.mount_point)`, is that rt-app complains and terminates.

so, while it is probably not going to make any practical difference, i'd suggest to check for the length being sufficient, error out if not, else strcat the strings without looking at the length again.


Test AMK


Puzzle `10-367b8283` discovered in   [`seeds-db/src/test/java/com/github/smallcreep/cucumber/seeds/db/steps/StpDefConnectionTest.java`](  https://github.com/smallcreep/cucumber-seeds/blob/master/seeds-db/src/test/java/com/github/smallcreep/cucumber/seeds/db/steps/StpDefConnectionTest.java)   and submitted as #17. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


Puzzle `10-e62debd8` discovered in   [`seeds-db/src/main/java/com/github/smallcreep/cucumber/seeds/db/steps/Suit.java`](  https://github.com/smallcreep/cucumber-seeds/blob/master/seeds-db/src/main/java/com/github/smallcreep/cucumber/seeds/db/steps/Suit.java)   and submitted as #18. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


Puzzle `10-8101f1eb` discovered in   [`seeds-db/src/main/java/com/github/smallcreep/cucumber/seeds/db/steps/Scenario.java`](  https://github.com/smallcreep/cucumber-seeds/blob/master/seeds-db/src/main/java/com/github/smallcreep/cucumber/seeds/db/steps/Scenario.java)   and submitted as #19. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


Puzzle `10-4feee286` discovered in   [`seeds-db/src/main/java/com/github/smallcreep/cucumber/seeds/db/steps/Context.java`](  https://github.com/smallcreep/cucumber-seeds/blob/master/seeds-db/src/main/java/com/github/smallcreep/cucumber/seeds/db/steps/Context.java)   and submitted as #20. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


Puzzle `10-30907043` discovered in   [`seeds-db/src/main/java/com/github/smallcreep/cucumber/seeds/db/steps/Context.java`](  https://github.com/smallcreep/cucumber-seeds/blob/master/seeds-db/src/main/java/com/github/smallcreep/cucumber/seeds/db/steps/Context.java)   and submitted as #21. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


Successfully aliased the URL <https://videos-hacktoberfest-uxkxlkiqkw.now.sh> to the following alias.

* https://hacktoberfest.evanw.uk


You are going to use pointers.
If you had stayed with an array, you should have passed `oldAddressIndex` as an argument to the function. The "find recipient" would have been done off-chain, and the contract would only have verified that the information is correct then act. Don't make the contract search for something when it can be fed its solution and verify the solution.


[tests/testthat/test-mbd_loglik.R:16:1:](https://github.com/Giappo/mbd/blob/f45b899f98657839f8bc34cb689f9a98cada9269/tests/testthat/test-mbd_loglik.R#L16) *style:* **Lines should not be more than 80 characters.**
```r
test_that("number of items to replace is not a multiple of replacement length", {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


This is redundant. All balances are set to `0`.


Afaik racial leaders don't have any aggro or combat texts


哈哈，没有问题，我在学习这里的代码，同时熟悉熟悉Github的使用。


this might change the name behind the user's back. i'd suggest that it really just checks for it and bails out if not..?


This nukes my system pretty bad :D Can we undo it?


> non-smoothed weapon re-positioning

I'd say that's expected, because you introduce a hard break in the `player->bob` value.


Tested with input file : SA DJ C2 H9 HK


"in reality, the cpu can overwrite this address or retrigger pdp_begin"

based on comments I think what happens in system11 if that once it enters an infinite loop the slave ends up watchdog resetting and therefore being ready for another command, so maybe it's the same here?  (of course, we still need to work out how it really distributes across all the slaves there, rather than overclocking a single one one of them and ignoring the others)


Este código pertenece realmente a la versión 3, en la cual se utiliza la clase usuario.


@HinTak in that sourceforge page of yours, I can't find a binary downloads for windows for the current 2.1.2 version. To run FontValidator.exe on Windows, one needs to build from source?


`xcrun --show-sdk-path` doesn't work on Mac OS X 10.7 or earlier.


If you have an unbounded loop, there comes a time when the loop is long enough for the function call to require more gas then the block gas limit. This then means that this function is bricked. Luckily, in your case, you could remove recipients, although that defeats the purpose.
On the other hand, if your `removeRecipient` function was zeroing an address instead of shrinking the whole array, and if your loop here had a `if (recipients[i] != 0)`, then your function would be bricked, and `removeRecipient` would change nothing. Until the block gas limit increases.

If you insist on having `n` recipients, how about `function split(address[] recipients)`? If your array is too long, then your client side can slice the array in 2 smaller arrays and send different `msg.value` accordingly.


Comment on 5400fa036de66215553fa1ec438ccce1838b2df1.

There are 98 results for the section all.cpp. They have been shortened and will not be shown inline because they are more than 10.

| Message | File | Line |
|---|---|---|
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 2 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 3 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 5 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 6 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 7 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 8 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 10 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 11 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 13 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 15 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 17 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 19 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | MegeSort.cpp | 21 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 23 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 25 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | MegeSort.cpp | 27 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 29 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 31 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 33 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 35 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 37 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | MegeSort.cpp | 39 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 41 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 43 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 45 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 47 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 49 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 51 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 53 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 55 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 57 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 59 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | MegeSort.cpp | 61 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 63 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 65 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 67 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 69 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 71 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 73 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 75 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 77 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | MegeSort.cpp | 79 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 81 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 83 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 85 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 87 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 89 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 91 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 93 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 95 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | MegeSort.cpp | 97 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 99 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 101 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 103 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 105 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 107 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 109 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 110 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 112 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 113 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 117 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 118 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 120 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 122 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 124 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 126 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 128 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 130 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 132 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 134 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 136 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 138 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 140 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 142 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 143 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 145 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 149 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 150 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 152 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 154 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 156 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 158 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 159 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 161 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 164 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 165 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 167 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 169 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 171 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 173 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 175 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 177 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 179 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 181 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 183 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 185 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | MegeSort.cpp | 187 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. | MegeSort.cpp | 188 |

Until GitMate provides an online UI to show a better overview, you can run [coala](https://coala.io/) locally for more details.


Comment on 5400fa036de66215553fa1ec438ccce1838b2df1.

There are 116 results for the section all.cpplint. They have been shortened and will not be shown inline because they are more than 10.

| Message | File | Line |
|---|---|---|
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 2 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 3 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 5 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 6 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 7 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 8 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 10 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 11 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | MegeSort.cpp | 11 |
| Redundant blank line at the start of a code block should be deleted.  [whitespace/blank_line] [2] | MegeSort.cpp | 12 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 13 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 15 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 17 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 19 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 23 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 25 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 29 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 31 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 33 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 35 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 37 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 41 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 43 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 45 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 47 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 49 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | MegeSort.cpp | 49 |
| Redundant blank line at the start of a code block should be deleted.  [whitespace/blank_line] [2] | MegeSort.cpp | 50 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 51 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 53 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | MegeSort.cpp | 53 |
| Redundant blank line at the start of a code block should be deleted.  [whitespace/blank_line] [2] | MegeSort.cpp | 54 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 55 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 57 |
| Redundant blank line at the end of a code block should be deleted.  [whitespace/blank_line] [3] | MegeSort.cpp | 58 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 59 |
| An else should appear on the same line as the preceding }  [whitespace/newline] [4] | MegeSort.cpp | 61 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 63 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | MegeSort.cpp | 63 |
| Redundant blank line at the start of a code block should be deleted.  [whitespace/blank_line] [2] | MegeSort.cpp | 64 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 65 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 67 |
| Redundant blank line at the end of a code block should be deleted.  [whitespace/blank_line] [3] | MegeSort.cpp | 68 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 69 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 71 |
| Redundant blank line at the end of a code block should be deleted.  [whitespace/blank_line] [3] | MegeSort.cpp | 72 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 73 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 75 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 81 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 83 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | MegeSort.cpp | 83 |
| Redundant blank line at the start of a code block should be deleted.  [whitespace/blank_line] [2] | MegeSort.cpp | 84 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 85 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 87 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 89 |
| Redundant blank line at the end of a code block should be deleted.  [whitespace/blank_line] [3] | MegeSort.cpp | 90 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 91 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 93 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 99 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 101 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | MegeSort.cpp | 101 |
| Redundant blank line at the start of a code block should be deleted.  [whitespace/blank_line] [2] | MegeSort.cpp | 102 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 103 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 105 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 107 |
| Redundant blank line at the end of a code block should be deleted.  [whitespace/blank_line] [3] | MegeSort.cpp | 108 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 109 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 110 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 112 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 117 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 118 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | MegeSort.cpp | 118 |
| Redundant blank line at the start of a code block should be deleted.  [whitespace/blank_line] [2] | MegeSort.cpp | 119 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 120 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 122 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | MegeSort.cpp | 122 |
| Redundant blank line at the start of a code block should be deleted.  [whitespace/blank_line] [2] | MegeSort.cpp | 123 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 124 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 126 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 128 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 130 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 132 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 134 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 136 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 138 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 140 |
| Redundant blank line at the end of a code block should be deleted.  [whitespace/blank_line] [3] | MegeSort.cpp | 141 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 142 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 143 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 145 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 149 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 150 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | MegeSort.cpp | 150 |
| Redundant blank line at the start of a code block should be deleted.  [whitespace/blank_line] [2] | MegeSort.cpp | 151 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 152 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 154 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 156 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 158 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 159 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 161 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 164 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 165 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | MegeSort.cpp | 165 |
| Redundant blank line at the start of a code block should be deleted.  [whitespace/blank_line] [2] | MegeSort.cpp | 166 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 167 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 169 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 171 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 173 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 175 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 177 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 179 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 181 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 183 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 185 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 187 |
| Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4] | MegeSort.cpp | 188 |

Until GitMate provides an online UI to show a better overview, you can run [coala](https://coala.io/) locally for more details.


`const Splitter`?


Comment on 8b4e201414c259a333d9cfb6b52dfa648602ce90.

There are 71 results for the section all.cpp. They have been shortened and will not be shown inline because they are more than 10.

| Message | File | Line |
|---|---|---|
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 6 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 7 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 9 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 10 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 11 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 12 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 13 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 14 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 15 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 16 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 17 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 18 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 19 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 20 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 21 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 22 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 24 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 25 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 26 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 27 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 31 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 32 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 34 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 36 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 37 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | quicksort/Cpp/quick_sort.cpp | 38 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 6 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 7 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 8 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 9 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 10 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 11 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 12 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 13 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 14 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 15 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 16 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 17 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 19 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 20 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 21 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 22 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 23 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 27 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 28 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 29 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 30 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 32 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 33 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 34 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 35 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 36 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 37 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 38 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 39 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 40 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 41 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 42 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 44 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 45 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 46 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 47 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 48 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 50 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 54 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 55 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 57 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 59 |
| Line contains following spacing inconsistencies: - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 60 |
| Line contains following spacing inconsistencies: - Trailing whitespaces. - Spaces used instead of tabs. | shell_sort/Cpp/shell_sort.cpp | 61 |
| Line contains following spacing inconsistencies: - No newline at EOF. | shell_sort/Cpp/shell_sort.cpp | 62 |

Until GitMate provides an online UI to show a better overview, you can run [coala](https://coala.io/) locally for more details.


Nakon `if` ide space. Baci oko tu -> https://github.com/infinum/frontend-handbook/blob/master/JavaScript/Styleguide.md


Thanks!


Hey Xavier, do you mean in this file or in general?

This file was just an ownable contract I found on the internet. The splitter contract is my work.


I haven't kept sourceforge up to date due to the windows build being a bit late - explained in the 2.1.2 download release note about harfbuzz :-).


this is a commit comment


Preferiraj `Object.keys` umjesto `for ... in` -> https://leftshift.io/4-javascript-optimisations-you-should-know


Nije li dovoljno samo `if (value === undefined)`?


Define "new". We're not working on a refreshed icon theme right now, this just overrides some upstream app icons as we transition them from older internal versions to flathub.


Se había cometido un pequeño error en la 4 versión ahora corregido


test-git should be in capital letter


This should not default to `'/'`. It is breaking local development.

The condition below will always return `'/'`, even when the user didn't set the `CLIENT_PUBLIC_PATH` variable.
```js
  const clientPublicPath =
    dotenv.raw.CLIENT_PUBLIC_PATH ||
    (IS_DEV ? `http://${dotenv.raw.HOST}:${devServerPort}/` : '/');
```


Hey Rob, thanks for all your comments!

W.r.t this ownable file, it's not mine (just an ownable contact I found on the internet). I was importing it from their github to provide the owner functionality (but I thought i'd include it here in case it helped other people run the splitter contract as the dependency is here with it). I can go back to importing from the github if preferred.


Should be == instead of =


I tried loading and printing what various other parsers would like this YAML file to optimally look like, and the only thing they seem to agree on is that all the options starting with a `-` should be quoted.
Either way, I'm going to restructure some parts and clean up the quoting, if it's to be consistent then I actually want it to be consistent, not using two different types of quotes and in three different layouts of them.


this should not be not a problem anymore: there exists the local package (installation instructions [here](https://github.com/sirfoga/pygce#install))


this is not right: for instance, my user name is `sirfoga` but my user id is something like `43289-vf432-4324-vre`


You removed the new parts though


Zasto si ove funkcije sve izvadio izvan `var dom = (function() {` bloka?


I should have worked this thing out with e261727618b6c395d106eb2d5fc5a49b675bc25b


Successfully aliased the URL <https://packagephobia-hcgmbdtcxj.now.sh> to the following alias.

* https://packagephobia.now.sh


I've realized similar idea (that existence of deployment isn't required), but @akharlamov has banned this idea


mislim da je dovoljno i if ( value ) , ali ne znam koji je pravi nacin


This is actually correct; we are adding a number to the stack pointer: the addend (`width`) can never be anything other than an integer -- specifically, it cannot ever be a pointer. Because the SP is both incremented and decremented, I choose to go with an signed integer.


True that. `CREATE OR REPLACE` does the thing. I forgot to remove this `DROP`.


reformat


我的竹鼠QQ


Oui je l'ai trouvé dans le package.json, ty !


%kun


I see. Not that I have a problem doing this I guess it's just now more pronounced IF it's done after the fact due to the published docs not getting updated.


cooool 👍


maybe separate those two from the other


accidentally committed an experiment, next commit restore previous status


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


main fixes are here
bad highliting because of formatting changes


Quando chegar vamos verificar juntos essa abordagem do service e responsabilidades, dessa forma, a gente já mata 2 coisas numa só :)


[R/mbd_pmb.R:34:1:](https://github.com/Giappo/mbd/blob/2aab35cb82557ac1a33459bc36578eaf0e949b1a/R/mbd_pmb.R#L34) *style:* **Trailing whitespace is superfluous.**
```r

^~
```


better to write generic names that describe the function and not the specific framework name currently used, like tracing_server_ip


Setting $i = 0 in a foreach loop means, that every loop will end up in $i = 1.
If there are more than one array within $top, $day, $hour you would overwrite index 1 every time.
Just my 2 cents


yeah this color is gud


Thanks for clarifying this in detail @ttaylorr!  I'm just getting started with git lfs in a project and ran into this warning a couple of times. I think it's safe to remove this to avoid confusion for new users.

I've submitted a pull request in #3301. Also, @git-lfs/core is a private team—I don't think you can use this tag when you're not a member in the @git-lfs org, but I've already tagged a core team member. Thanks again! 🍄


Great idea!


`As of react-scripts >=2 you must specify targeted browsers.`


the display_errors is basically for catching the run time command errors
what is the role of args.context here


Um detalhe que fiquei pensando é que você faz referência de `'posts'` mais de uma vez. Para evitar erro de digitação, a boa prática é manter em uma constante. Se tiver outros valores com essa mesma proposta tente sempre ir pela abordagem de constante que deixa o código mais seguro


`nomeArquivo`


yeah it's good


what is the use of arg_parser here. Instead of using arg_parser we can use Keras library and it will extract the all the tools of NLP toolkit and it will improvise efficiency too


I think tracing alone is a better name,
and import only the decorator without utils for shorter text


Correctif #2


redundant


yay! 👍


missing part of comment


I agree with your point. I used random template to keep the ability to keep target 6 that was introduced in TBC-DB (which is not possible to keep with standard text action). Other possibilities:
- dropping the target (are we even sure we need it?)
- splitting this script in two: one for setting the rangeAI mode, one for the two actions 54 with eventflags 32

I'll update this script based on your liking.


Vamos seguir pt-br também, acho que dá pra traduzir para `etiquetaDaImagem`, não fica legal mas seria algo próximo disso kkkk


@minouHub


we haven't extract the (--context) text  which which will pretokenize the content of the file and result in overfitting
The efficiency of this can be improvise by replacing the parser syntax with
                                                   catch (MethodAndArgsCaller caller) {
                                                                          caller.run();
                                                                                }


Fiquei na dúvida se vale a pena a pena trocar para o verbo `publicar`, não lembro do verbo 'postar' se algo natural, o que acha?


Pa nema tu baš "pravog načina" - ovisno šta želiš napraviti. Kod `if (value)` bi bio problem što odbijaš sve falsy vrijednosti. Npr šta kada baš želiš postaviti da je style[attr] = `null` da ga poništiš? Zato mislim da je ok gledati striktno ako je `undefined` da onda zapravo ne settaš vrijednost nego ju gettaš. To je u biti i nekakva konceptualna razlika između `null` i `undefined`.

A `typeof value === 'undefined'` i `value === undefined` rade identičnu stvar ovdje samo je ova druga varijanta malo čitljivija. Postoji jedan trik kada je zgodno koristiti typeof. Evo copy pejst nekog odgovora negdje:

> For undeclared variables, typeof foo will return the string literal "undefined", whereas the identity check foo === undefined would trigger the error "foo is not defined". For local variables (which you know are declared somewhere), no such error would occur, hence the identity check.

Dakle ako ne znaš je li `value` varijabla uopće deklarirana u scopeu onda će ti `if (value === undefined)` potencijalno puknuti sa "value is not defined" errorom dok typeof nikada neće errorat.


Is there any reason to have a "raised" version of crosswalk? If there are any - then you should add "uncontrolled", "traffic_signals", "uncontrolled raised", "traffic_signals raised" templates too.

I think it's better drop "raised" versions and just add `traffic_calming` to editor in the same way as `kerb` and `tactile_paving`.

> iD has never supported uncontrolled or traffic_signal

It's time to move forward and drop support of going to extinct `marked` garbage and add support for standard and widely used `uncontrolled` and `traffic_signals`.

> uncontrolled | 661 122
> zebra | 525 573
> traffic_signals | 514 832
> marked | 8 422


@darshan1205 it needs kernel headers via soong :'V


Successfully aliased the URL <https://lingonsaft-hacktober-demdbkiemg.now.sh> to the following alias.

* https://hacktoberfest.lingonsaft.com


Good, then we can get rid of this as well when we move to 2.x ;)
_(eta before our 3.0 planned for Q1 next year)_


why not wrap the func?


Successfully aliased the URL <https://lingonsaft-hacktober-snlupttqbx.now.sh> to the following alias.

* https://hacktoberfest.lingonsaft.com


space after :


review


I think it is not.


Successfully aliased the URL <https://lingonsaft-hacktober-lhetegzkhf.now.sh> to the following alias.

* https://hacktoberfest.lingonsaft.com


@ChicoXYC FYI. Please be alerted when you see the strange output. The `\ufeff` does not appear in the regular data. The CSV is also fixed: https://github.com/hupili/python-for-data-and-media-communication-gitbook/commit/a7b4e837420d5b56e728e045e1c0f8cb04d698c8


space


collections/the university of manchester/Persian_MS_3.xml

Thanks Andrew
We must have copied this from an earlier file. I have corrected this here and found/corrrected a few other files (for the same author) which had the same error.
Best wishes
Elizabeth

Elizabeth Gow l The University of Manchester l Tel +44 (0)161 2753541
elizabeth.gow@manchester.ac.uk<mailto:elizabeth.gow@manchester.ac.uk>

From: Andrew Morrison <notifications@github.com>
Sent: 01 October 2018 11:14
To: fihristorg/fihrist-mss <fihrist-mss@noreply.github.com>
Cc: Elizabeth Gow <elizabeth.gow@manchester.ac.uk>; Mention <mention@noreply.github.com>
Subject: Re: [fihristorg/fihrist-mss] Codicological information added (8c6722f)

Hi @ElizabethGow<https://github.com/ElizabethGow>,

On line 48 in Persian_MS_3.xml, you've used a Library of Congress identifier for a person. It was agreed back in July that VIAF should be used (which includes all of the person names in the Library of Congress Name Authority). So, in this case, it should be key="person_74086465").

Andrew.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/fihristorg/fihrist-mss/commit/8c6722f985832af322051b7869b31ba902075b82#commitcomment-30714943>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AlV1mM84QPYdQ_oPEIMRF_FAvIb95kDRks5ugerwgaJpZM4XBwzk>.


targeting only makes sense if there is a target shortcut in the text but there isnt?
```
('-461','Aber?  Is that you...?  Oh...I\'m so hungry, Aber!  SO HUNGRY!!','0','0','0','314','0'),
('-460','Wait...you are not my husband.  But he must have sent you.  And you...look..delicious!','0','0','7','314','0'),
```
action 54 targeting needs something like %s $r $n, i'll revert tbc edition back to
```
('31402','314','4','0','100','0','0','0','0','0','0','0','57','1','35','0','1','-460','-461','0','0','0','0','0','Eliza - Enable Caster Mode and Say on Aggro'),
``` and readd text 461.


[tests/testthat/test-pmb_loglik.R:85:1:](https://github.com/Giappo/mbd/blob/094cc9505cf8a65acd285b747f16329b9b6461c9/tests/testthat/test-pmb_loglik.R#L85) *style:* **Trailing whitespace is superfluous.**
```r

^~
```


ext_emconf.php still to adjust.


Mhh... 🙄The move to `HOMEBREW_TRAVIS_CI ` and `HOMEBREW_TRAVIS_SUDO` (probably) have broken some taps running on Travis CI. I was wondering for ~1 month why these jobs were failing, I first thought Travis had changed their images and that somehow the Xcode was now too old. Anyway, I'll mention this change in the [tutorial](https://gist.github.com/maelvalais/068af21911c7debc4655cdaa41bbf092/edit) I maintain on automatically building bottles for taps 😁


On 04/10/18 13:01, fpalombini wrote:
> You removed the new parts though

Sorry for that. I'll go back to this and try to restore what was lost.

/Ludwig

--
Ludwig Seitz, PhD
Security Lab, RISE
Phone +46(0)70-349 92 51


Aliasing failed with the following error:

~~~
Error! The alias thiccify is a deployment URL or it's in use by a different team.
~~~


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


Thanks! :)


Editorial: "in accuracies" -> "inaccuracies"


s/JSONRule/JsonRule/


Now could not deploy this pull request since it contains the following references to invalid secrets in the `env` sections of the `now.json` file:

* `appname-mysql-host` (in env: `MYSQL_HOST)`
* `appname-mysql-user` (in env: `MYSQL_USER)`
* `appname-mysql-password` (in env: `MYSQL_PASSWORD)`
* `appname-mysql-db-name` (in env: `MYSQL_DB_NAME)`

Add those secrets or remove them from the `env` maps in the `now.json` file.


Are you sure this was properly upstreamed? I just upgraded to your 4.18.11 release and the ethernet on the surface dock fails again. I just get a ton of:
`r8152 2-3.2:1.0 enxbc8385f9e591: Tx status -71`
in my logs until the system gives up on ethernet.


[tests/testthat/test-pmb_loglik.R:17:5:](https://github.com/Giappo/mbd/blob/3d99807d435c5649b2f897d28433517319caa9e0/tests/testthat/test-pmb_loglik.R#L17) *style:* **Commented code should be removed.**
```r
  # pars[4] = q
    ^~~~~~~~~~~
```
[tests/testthat/test-pmb_loglik.R:29:5:](https://github.com/Giappo/mbd/blob/3d99807d435c5649b2f897d28433517319caa9e0/tests/testthat/test-pmb_loglik.R#L29) *style:* **Commented code should be removed.**
```r
  # pars[3] = nu
    ^~~~~~~~~~~~
```
[tests/testthat/test-pmb_loglik.R:41:5:](https://github.com/Giappo/mbd/blob/3d99807d435c5649b2f897d28433517319caa9e0/tests/testthat/test-pmb_loglik.R#L41) *style:* **Commented code should be removed.**
```r
  # pars[3] = nu
    ^~~~~~~~~~~~
```
[tests/testthat/test-pmb_loglik.R:121:1:](https://github.com/Giappo/mbd/blob/3d99807d435c5649b2f897d28433517319caa9e0/tests/testthat/test-pmb_loglik.R#L121) *style:* **Trailing whitespace is superfluous.**
```r

^~
```


No.


Successfully aliased the URL <https://videos-hacktoberfest-ijckpldxdo.now.sh> to the following alias.

* https://hacktoberfest.evanw.uk


Cool. I'll do the same here.


Team, this repo is public, are you sure that emails are appropriate here (even for owners files)?


On 04/10/18 13:46, fpalombini wrote:
> Thanks! :)
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/ace-wg/ace-oscore-profile/commit/6dfd0905ebcdf19a8139fa5bc672a263a4f828c9#commitcomment-30768276>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABChtGkwDACBcHOktoTbhGi9hrUvwowZks5uhfUegaJpZM4XH3Qp>.
>

Can't see what new parts I removed, at least not in that commit. I looks
to me that I only removed old text. Can you double-check?

/Ludwig

--
Ludwig Seitz, PhD
Security Lab, RISE
Phone +46(0)70-349 92 51


I now get an exception on line 590 because connection is now a future :-(
(I use fbsimctl <MY_ID> boot --connect-bridge

```
	0   CoreFoundation                      0x00007fff31db82db __exceptionPreprocess + 171
	1   libobjc.A.dylib                     0x00007fff58f68c76 objc_exception_throw + 48
	2   CoreFoundation                      0x00007fff31e50db4 -[NSObject(NSObject) doesNotRecognizeSelector:] + 132
	3   CoreFoundation                      0x00007fff31d2e820 ___forwarding___ + 1456
	4   CoreFoundation                      0x00007fff31d2e1e8 _CF_forwarding_prep_0 + 120
	5   FBSimulatorControl                  0x00000001006a0f52 __31-[FBSimulatorBootStrategy boot]_block_invoke.373 + 242
	6   FBControlCore                       0x000000010084a125 __25-[FBFuture onQueue:fmap:]_block_invoke + 405
	7   FBControlCore                       0x000000010084cffb __27-[FBFuture fireAllHandlers]_block_invoke + 75
	8   libdispatch.dylib                   0x000000010053bcae _dispatch_call_block_and_release + 12
	9   libdispatch.dylib                   0x0000000100533d8f _dispatch_client_callout + 8
	10  libdispatch.dylib                   0x000000010053fe09 _dispatch_main_queue_callback_4CF + 549
	11  CoreFoundation                      0x00007fff31d70c19 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 9
	12  CoreFoundation                      0x00007fff31d32dfa __CFRunLoopRun + 2586
	13  CoreFoundation                      0x00007fff31d32153 CFRunLoopRunSpecific + 483
	14  Foundation                          0x00007fff33e2ef26 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277
	15  Foundation                          0x00007fff33eb5055 -[NSRunLoop(NSRunLoop) runUntilDate:] + 114
	16  FBControlCore                       0x000000010080de7b -[NSRunLoop(FBControlCore) spinRunLoopWithTimeout:untilTrue:] + 267
	17  FBControlCore                       0x000000010080e68e -[NSRunLoop(FBControlCore) awaitCompletionOfFuture:timeout:didTimeout:error:] + 270
	18  FBControlCore                       0x000000010080e95f -[NSRunLoop(FBControlCore) awaitCompletionOfFuture:timeout:error:] + 111
	19  FBControlCore                       0x000000010080ea3e -[FBFuture(NSRunLoop) awaitWithTimeout:error:] + 94
	20  FBControlCore                       0x000000010080e9d7 -[FBFuture(NSRunLoop) await:] + 71
	21  FBSimulatorControlKit               0x000000010034991e $S21FBSimulatorControlKit12FutureRunnerV3runAA13CommandResultVyF + 462
	22  FBSimulatorControlKit               0x000000010034a2eb $S21FBSimulatorControlKit12FutureRunnerVyxGAA0E0A2aEP3runAA13CommandResultVyFTW + 59
	23  FBSimulatorControlKit               0x0000000100337947 $S21FBSimulatorControlKit21SimulatorActionRunnerV3runAA13CommandResultVyF + 1047
	24  FBSimulatorControlKit               0x000000010033b349 $S21FBSimulatorControlKit21SimulatorActionRunnerVAA0F0A2aDP3runAA13CommandResultVyFTW + 41
	25  FBSimulatorControlKit               0x0000000100369554 $S21FBSimulatorControlKit14SequenceRunnerV3runAA13CommandResultVyF + 516
	26  FBSimulatorControlKit               0x00000001003b1424 $S21FBSimulatorControlKit12ActionRunnerV3runAA13CommandResultVyF + 6900
	27  FBSimulatorControlKit               0x00000001003ae345 $S21FBSimulatorControlKit13CommandRunnerV3runAA0D6ResultVyF + 1925
	28  FBSimulatorControlKit               0x00000001003ad30a $S21FBSimulatorControlKit17BaseCommandRunnerV3runAA0E6ResultVyF + 1578
	29  FBSimulatorControlKit               0x000000010031b0ab $S21FBSimulatorControlKit9CLIRunnerV3runAA13CommandResultVyF + 251
	30  FBSimulatorControlKit               0x000000010031a610 $S21FBSimulatorControlKit9CLIRunnerV12runForStatuss5Int32VyF + 64
	31  FBSimulatorControlKit               0x0000000100318dc3 $S21FBSimulatorControlKit15CLIBootstrapperC9bootstraps5Int32VyFZ + 739
	32  FBSimulatorControlKit               0x000000010031ae18 $S21FBSimulatorControlKit15CLIBootstrapperC9bootstraps5Int32VyFZTo + 24
	33  fbsimctl                            0x0000000100001509 main + 57
	34  libdyld.dylib                       0x00007fff59b82015 start + 1
	35  ???                                 0x0000000000000004 0x0 + 4

```


Needed?


:laughing:


fffff


Я понимаю, что это внешние отступы, но меня пугает то, что они присваиваются всем элементам автоматически из-за чего часто блоки начинают друг на друга заезжать .


> Ty but Turkey have a new update and wfbot not working pls update tr to :)

Wait patiently in line: #289
Don't comment on commits for issues that are unrelated to them!


Did you mean to say, `is a value regardless of whether rigid`?


Does this work for you if you undo the changes that I marked as "needed?"

Gigya is not rolled out uniformly across regions (annoying as hell), so I can't test this.

The grant type change is interesting to me, as "password" did work for me, back when i was covered by Gigya, but I know Plex uses the shield_authentication.


@jensens Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.z3cform/124/violations
```
plone/app/z3cform/converters.py:106:11: T000 Todo note found.
plone/app/z3cform/widget.py:5:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:667:19: T000 Todo note found.
plone/app/z3cform/widget.py:681:47: T000 Todo note found.
plone/app/z3cform/inline_validation.py:15:5: C901 'InlineValidationView.__call__' is too complex (15)
plone/app/z3cform/tests/test_widgets.py:6:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/test_widgets.py:159:50: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:169:60: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:170:18: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Please refer to our code style sort doc in confluence regrading imports


clearer if comment appears on the same line as const defined

please use uppercase/lowercase consistently for comment so either:

// NT is Not a Token

or

// NT is not a token


True...


`@Unstable` ?


з методом run() новий потік не стартане


Why are you changing the name of the project templates ?


I don't understand the difference between the 2 APIs. The javadoc seem the same for both. What am I missing?


Mais fácil deletar o arquivo


BTW missing some `@param` for the xcontext in the javadoc


the (root_path) of the directory is displayed by the (exec_url)  file and the tokenize tool (emr_log_url) and (hex_string) is appended with the joint path directory and the error_text.append can be extracted with the keras library with the help of sci-kye kit of the keras.


this is a commit comment


Successfully aliased the URL <https://pebble-uevrhjraqh.now.sh> to the following alias.

* https://pebble.now.sh


@nedrichards You forgot the Steam icon, Inkscape, Telegram, GCompris, Minetest and others


This could be info and move this to the start


Successfully aliased the URL <https://lingonsaft-hacktober-qsyuwwizvs.now.sh> to the following alias.

* https://hacktoberfest.lingonsaft.com


Comment on d2ae490c1bdeda8de103b967e63b122832955454.

There are 31 results for the section all.cpplint. They have been shortened and will not be shown inline because they are more than 10.

| Message | File | Line |
|---|---|---|
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | merge_sort/C/mergesort.c | 6 |
| Missing space after ,  [whitespace/comma] [3] | merge_sort/C/mergesort.c | 7 |
| Missing spaces around =  [whitespace/operators] [4] | merge_sort/C/mergesort.c | 15 |
| Missing spaces around <  [whitespace/operators] [3] | merge_sort/C/mergesort.c | 15 |
| Missing space after ;  [whitespace/semicolon] [3] | merge_sort/C/mergesort.c | 15 |
| Missing spaces around =  [whitespace/operators] [4] | merge_sort/C/mergesort.c | 17 |
| Missing spaces around <  [whitespace/operators] [3] | merge_sort/C/mergesort.c | 17 |
| Missing space after ;  [whitespace/semicolon] [3] | merge_sort/C/mergesort.c | 17 |
| Missing spaces around <  [whitespace/operators] [3] | merge_sort/C/mergesort.c | 24 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | merge_sort/C/mergesort.c | 25 |
| Missing space before {  [whitespace/braces] [5] | merge_sort/C/mergesort.c | 25 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | merge_sort/C/mergesort.c | 27 |
| Missing space before {  [whitespace/braces] [5] | merge_sort/C/mergesort.c | 27 |
| An else should appear on the same line as the preceding }  [whitespace/newline] [4] | merge_sort/C/mergesort.c | 31 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | merge_sort/C/mergesort.c | 32 |
| Missing space before {  [whitespace/braces] [5] | merge_sort/C/mergesort.c | 32 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | merge_sort/C/mergesort.c | 41 |
| Missing space before {  [whitespace/braces] [5] | merge_sort/C/mergesort.c | 41 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | merge_sort/C/mergesort.c | 49 |
| Missing space before {  [whitespace/braces] [5] | merge_sort/C/mergesort.c | 49 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | merge_sort/C/mergesort.c | 57 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | merge_sort/C/mergesort.c | 59 |
| Missing space before {  [whitespace/braces] [5] | merge_sort/C/mergesort.c | 59 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | merge_sort/C/mergesort.c | 69 |
| Missing spaces around =  [whitespace/operators] [4] | merge_sort/C/mergesort.c | 71 |
| Missing spaces around <  [whitespace/operators] [3] | merge_sort/C/mergesort.c | 71 |
| Missing space after ;  [whitespace/semicolon] [3] | merge_sort/C/mergesort.c | 71 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | merge_sort/C/mergesort.c | 72 |
| Missing space before {  [whitespace/braces] [5] | merge_sort/C/mergesort.c | 72 |
| Missing space after ,  [whitespace/comma] [3] | merge_sort/C/mergesort.c | 73 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | merge_sort/C/mergesort.c | 79 |

Until GitMate provides an online UI to show a better overview, you can run [coala](https://coala.io/) locally for more details.


I'm not sure we should have the same API names since the behavior seem different for both APIs. The new one seem to force loading of the attachment.


então, como tinha que renomear o teu para o mesmo do invalido, preferi renomear primeiro para invalido
logo em seguida já deletei e fiz outro commit


Our rule is to not prefix by "test"


is \r possible in this context ?


The sentence is unclear, and the part on "tracing enabled" is redundant


Successfully aliased the URL <https://pebble-njwnmcacuy.now.sh> to the following alias.

* https://pebble.now.sh


可読性を落とす可能性があるため、不要な改行がないか見直しましょう。
佐藤


no more errors anymore (probably)


:+1: I like that you made a new version that is in sync with the mupdf version upgrade to 1.14.0. This makes it a lot easier for distributors to select the correct llpp version for the mupdf version they have in the distributions repository!


This is wrapped better than the existing flask wrapper?


Я делаю нижний отступ этому блоку для того, чтобы расширить пространство  секции . Сейчас поняла, что эта ошибка поспособствует дальнейшему расширению блока, когда это будет ненужно . Например, я увеличу текст или другие компоненты блока, а вместе с ними расползется секция .


Comment on de4bbb47f7eade1f32dbe1d81bae8802d1201a5e.

There are 31 results for the section all.cpplint. They have been shortened and will not be shown inline because they are more than 10.

| Message | File | Line |
|---|---|---|
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | merge_sort/C/mergesort.c | 6 |
| Missing space after ,  [whitespace/comma] [3] | merge_sort/C/mergesort.c | 7 |
| Missing spaces around =  [whitespace/operators] [4] | merge_sort/C/mergesort.c | 15 |
| Missing spaces around <  [whitespace/operators] [3] | merge_sort/C/mergesort.c | 15 |
| Missing space after ;  [whitespace/semicolon] [3] | merge_sort/C/mergesort.c | 15 |
| Missing spaces around =  [whitespace/operators] [4] | merge_sort/C/mergesort.c | 17 |
| Missing spaces around <  [whitespace/operators] [3] | merge_sort/C/mergesort.c | 17 |
| Missing space after ;  [whitespace/semicolon] [3] | merge_sort/C/mergesort.c | 17 |
| Missing spaces around <  [whitespace/operators] [3] | merge_sort/C/mergesort.c | 24 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | merge_sort/C/mergesort.c | 25 |
| Missing space before {  [whitespace/braces] [5] | merge_sort/C/mergesort.c | 25 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | merge_sort/C/mergesort.c | 27 |
| Missing space before {  [whitespace/braces] [5] | merge_sort/C/mergesort.c | 27 |
| An else should appear on the same line as the preceding }  [whitespace/newline] [4] | merge_sort/C/mergesort.c | 31 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | merge_sort/C/mergesort.c | 32 |
| Missing space before {  [whitespace/braces] [5] | merge_sort/C/mergesort.c | 32 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | merge_sort/C/mergesort.c | 41 |
| Missing space before {  [whitespace/braces] [5] | merge_sort/C/mergesort.c | 41 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | merge_sort/C/mergesort.c | 49 |
| Missing space before {  [whitespace/braces] [5] | merge_sort/C/mergesort.c | 49 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | merge_sort/C/mergesort.c | 57 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | merge_sort/C/mergesort.c | 59 |
| Missing space before {  [whitespace/braces] [5] | merge_sort/C/mergesort.c | 59 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | merge_sort/C/mergesort.c | 69 |
| Missing spaces around =  [whitespace/operators] [4] | merge_sort/C/mergesort.c | 71 |
| Missing spaces around <  [whitespace/operators] [3] | merge_sort/C/mergesort.c | 71 |
| Missing space after ;  [whitespace/semicolon] [3] | merge_sort/C/mergesort.c | 71 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | merge_sort/C/mergesort.c | 72 |
| Missing space before {  [whitespace/braces] [5] | merge_sort/C/mergesort.c | 72 |
| Missing space after ,  [whitespace/comma] [3] | merge_sort/C/mergesort.c | 73 |
| { should almost always be at the end of the previous line  [whitespace/braces] [4] | merge_sort/C/mergesort.c | 79 |

Until GitMate provides an online UI to show a better overview, you can run [coala](https://coala.io/) locally for more details.


Syntax fixes


Pradeep told me to remove this


Compatibility for 5.5


download_emr_logs(s3_emr_logs_url, args.output_path) and the bucket name should be
The dump files in the emr_logs can be the extracted with the pipelined analytics
s3 = boto3.resource('s3')     {The bucket name with the emr_log analysis is the entry for the boot resources}
if the s3 is denying to load the emr logs then it will be dumped
args.application_id return the current application fork id


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=1)


[tests/testthat/test-pmb_loglik.R:17:5:](https://github.com/Giappo/mbd/blob/d77c2cb69f850c25a98f5af99c7b1a8dc8e0b6fe/tests/testthat/test-pmb_loglik.R#L17) *style:* **Commented code should be removed.**
```r
  # pars[4] = q
    ^~~~~~~~~~~
```
[tests/testthat/test-pmb_loglik.R:29:5:](https://github.com/Giappo/mbd/blob/d77c2cb69f850c25a98f5af99c7b1a8dc8e0b6fe/tests/testthat/test-pmb_loglik.R#L29) *style:* **Commented code should be removed.**
```r
  # pars[3] = nu
    ^~~~~~~~~~~~
```
[tests/testthat/test-pmb_loglik.R:41:5:](https://github.com/Giappo/mbd/blob/d77c2cb69f850c25a98f5af99c7b1a8dc8e0b6fe/tests/testthat/test-pmb_loglik.R#L41) *style:* **Commented code should be removed.**
```r
  # pars[3] = nu
    ^~~~~~~~~~~~
```


Not 100% sure if case sensitivity matters, or if this was **actually** related to fixing the "onInstall" SQL query being ran, but always good practice to follow the sensitive of the original class name anyway.


needs to be `tasks`, not `task`, i believe..

how about an example config file? i fell into the trap of not using surrounding braces and it took me an embarassingly long time to figure it out.


Fatal error: Declaration of PHPUnitResultFormatter7::addError(PHPUnit\Framework\Test $test, Throwable $e, float $time): void must be compatible with PHPUnit\Framework\TestListener::addError(PHPUnit\Framework\Test $test, Exception $e, $time) in /app/vendor/phing/phing/classes/phing/tasks/ext/phpunit/formatter7/PHPUnitResultFormatter7.php on line 29
[05:27:53]


This more than likely could've been the issue, as I'm sure the Cirf server is set up to have file names case sensitive; and because it is in a function like this (`file_exists("path/to/file")`) an error wouldn't have occurred. This function would've just returned null and ignored the fact it needs to run the SQL query, in order to create the table `civicrm_webtracking`.


\r ?


Right, a pure virtual method implementation seems better


ループ判定の処理を行う際に使う変数を使い回すのは危険です。
きちんとループ用の変数（とくにfor文は例外をのぞいてルールといってもいいと思います）は宣言しましょう。
佐藤


putting title