Well I feel stupid.  Read this when I got up this morning and chewed on it on my commute and it dawned on me that I had put in config overrides in my `config.php`:

```
$config['os']['calix']['bad_if_regexp'][] = '/^(adsl|dsl-fullrate|DSL-FullRate|Dslport|Ont|ont).*/';
$config['os']['calix']['polling']['selected_ports'] = true;
$config['os']['calix']['discovery']['sysObjectId'][] = '.1.3.6.1.4.1.6321.1.2.2.5.4';
```

That was to get the E7-20's to be discovered properly; since at one point we were only discovering `6321.1.1.2.2.5.3`.

Commenting that out, and duplicating my bad_ifdescr and per-port polling for `exa`, and now things are working properly.

Those config overrides sure are a handy thing, but man are they a double edged sword...


I dont know what is exactly wrong but may start from rev1079 to rev1088, the VMC fuction has some new problems (all default config except VMC on) :
1.  GRAN TURISMO 4 (SCAJ_300.07) with VMC on(SCAJ_300.07_0.bin), the game freeze at the opening(no memory card detection icon)
2.  Xenosaga Episode 1(SLUS_204.69) with VMC on(SLUS_204.69_0.bin), just black screen, the game wont start.

I remember the older versions dont have these VMC problems.


Thanks for your great job.


Created multidev environment [tolkeforbundet#ci-4](https://dashboard.pantheon.io/sites/647aa4e3-884c-49e4-a6ab-904856077bf2#ci-4).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-4-tolkeforbundet.pantheonsite.io/)


re


Avoid magic numbers. Add additional constant `PARAMETER`.


thanks to https://gist.github.com/aaroncohen/4630685


infrastruscture => infrastructure


Alter_drop is inherited from Sql_alloc, which overloads `operator new`. In 10.4 it even overloads parameterless `new` version


and calls thd_alloc, respectively


Should not be an input parameter. Just check `EOF` symbol.


intially => initially


How do I save the thinned image into a file as gray image using python? Thanks


single pane of view => single pane of glass


Check the difference between `amount` and `number` in dictionary.


Send meg gjerne en pull request om og når du er klar for det.  Hadde vært fint å få merget dette tilbake!

Mvh, Karl Anders


Line 343:
`if (pos.attacks_from<Pt>(s2) & b & ~attackedBy[Them][ALL_PIECES])`

attackedBy[Them] is under construction at that point, you cannot use it.


Important: not just IT.  (Digital) Business.


Seems "Emit" does add an "~n" (linux newline). For windows files like a dll-.def it sounds like a valid idea to prepend a "~r" (so new line becomes a CRLF instead of only LF).
Toolchains seem to have no trouble handling LF-line endings but be warned to open it in a classic notepad.exe thing ;-)

So maybe it would be good to introduce some EOL_*** constants and a helper method:
EOL_WINDOWS:string = "~r~n"
EOL_LINUX:string = "~n"
EOL_MACOS:string = "~r"
GetEOL(MACOS) returns EOL_MACOS then


adminis => admins
unified same view => unified view


Would renaming MIN/MAX to smallest/biggest circumvent the need to undef/redefine the MIN/MAX macro?


Parandan seda järgmise commitiga


...ja seda ka


"making" -> "make" in the title smh


dicover => discover


I suggest to use user-defined type for `laser_trajectory`. Otherwise, it is not clear what is (:,7), (,8) and so on.


Don't commit


@maxbecker Please use `ilDB::quote` here


Hey, heads up, this commit broke our build here:
https://github.com/zynthian/zynthian-sys/issues/72
cc @piem


Now cannot deploy because all the allocated instances are in use.
You can either [upgrade](https://zeit.co/account/plan) your plan or [down scale](https://zeit.co/docs/getting-started/scaling) existing [deployments](https://zeit.co/dashboard/deployments).


Just ask the next time you want to undo something. [Commits can easily be deleted in the Git history](https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History). 😃


use `STOP` instead of `EXIT`


@maxbecker Please check whether or not the triple `=` operator is what you want here.


Not a bug, but it would be really nice to set the boolean variable back to "FALSE" when we successfully update the pet.


Successfully aliased the URL <https://sass-build-oqzwrrujkq.now.sh> to the following alias.

* https://sass.henderea.com


Put this in a new _vega.styl file instead.


@maxbecker Please use `ilDBInterface::quote` instead!


描述


We could leave out the try.... except blocks for all the generic Exceptions, except for the excepts where we would like to translate a generic exception into a GraphQL exception. For example `Group.DoesNotExist` will be translated into `GraphQLError(COULD_NOT_FIND_GROUP)`


out of box => out of the box


use website.website_domain()


@jensens Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.namedfile/96/violations
```
plone/namedfile/testing.py:18:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/namedfile/testing.py:23:36: C812 missing trailing comma
plone/namedfile/file.py:267:9: Q001 Remove bad quotes from multiline string.
plone/namedfile/file.py:308:9: Q001 Remove bad quotes from multiline string.
plone/namedfile/handler.py:11:23: C812 missing trailing comma
plone/namedfile/interfaces.py:17:25: C812 missing trailing comma
plone/namedfile/scaling.py:193:25: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:196:5: C901 'DefaultImageScalingFactory.__call__' is too complex (15)
plone/namedfile/scaling.py:203:25: C816 missing trailing comma in Python 3.6+
plone/namedfile/scaling.py:243:29: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:407:21: C816 missing trailing comma in Python 3.6+
plone/namedfile/scaling.py:434:25: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:446:25: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:460:21: C816 missing trailing comma in Python 3.6+
plone/namedfile/scaling.py:486:29: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:500:17: C816 missing trailing comma in Python 3.6+
plone/namedfile/utils/__init__.py:84:66: C812 missing trailing comma
plone/namedfile/utils/__init__.py:151:15: T000 Todo note found.
plone/namedfile/utils/__init__.py:156:73: C812 missing trailing comma
plone/namedfile/utils/__init__.py:176:15: T000 Todo note found.
plone/namedfile/utils/__init__.py:183:18: C812 missing trailing comma
plone/namedfile/utils/__init__.py:188:1: C901 'rotate_image' is too complex (20)
plone/namedfile/utils/__init__.py:219:14: C812 missing trailing comma
plone/namedfile/utils/__init__.py:271:25: F821 undefined name 'StringIO'
plone/namedfile/utils/__init__.py:276:1: E302 expected 2 blank lines, found 1
plone/namedfile/utils/__init__.py:280:1: E302 expected 2 blank lines, found 1
plone/namedfile/utils/tiff_utils.py:11:1: C901 'process_tiff' is too complex (11)
plone/namedfile/utils/tiff_utils.py:20:7: T000 Todo note found.
plone/namedfile/utils/tiff_utils.py:81:7: T000 Todo note found.
plone/namedfile/utils/tiff_utils.py:82:7: T000 Todo note found.
plone/namedfile/tests/test_blobfile.py:40:31: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:45:35: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:50:46: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:55:32: C812 missing trailing comma
plone/namedfile/tests/test_scaling.py:85:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:102:80: E501 line too long (81 > 79 characters)
plone/namedfile/tests/test_scaling.py:133:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:156:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:178:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:200:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_image.py:25:80: E501 line too long (80 > 79 characters)
plone/namedfile/tests/test_doctests.py:26:17: Q000 Remove bad quotes.
plone/namedfile/tests/test_doctests.py:26:30: Q000 Remove bad quotes.
plone/namedfile/tests/test_doctests.py:47:10: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:116:28: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:146:70: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:153:76: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:164:74: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:197:75: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:202:78: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


update typo: "import" is "improve"


[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-1-build-tools-164.pantheonsite.io/)

Created multidev environment [ci-1](https://dashboard.pantheon.io/sites/b86b7840-3525-4f42-a76e-0b03a2ea5343#ci-1) for build-tools-164.


swap, not swop


Excellant post!!!. The strategy you have posted on this technology helped me to get into the next level and had lot of information in it.

Blueprism training in Chennai

Blueprism training in Bangalore


h


readme


Now could not deploy this pull request since it contains the following references to invalid secrets in the `env` sections of the `now.json` file:

* `now-token` (in env: `NOW_TOKEN)`

Add those secrets or remove them from the `env` maps in the `now.json` file.


@JKE-be Cool. Also, what about search order? Technically I need the records with a website_id first if any... should I add a hook for the search order too?


Atualização 1.5


@aastlind @joshdholtz,
I think, there is a mistake in creating container arguments:
-ci iCloud.com.badoo.mattermost.dev, should be -g probably.


> @JarryHua and others,
> In CustomersController.cs, class name should be Customer, not Customers:
>
> ```
> [HttpPost]
> public ActionResult Save(Customer customer) {
> ```
> In CustomerForm.cshtml, controller name should be Customers, not Customer:
> `@using (Html.BeginForm("Save", "Customers")) {`

Great, that's the problem. Name of the sent object must be the same as the argument in the form tag.
One more question. MVC will create a foreign key, for instance, MembershipType_Id automatically beside MembershipTypeId that we've created in our domain. How can I prevent these kinds of creations?
Thank's in advance.
Vahid.


check another `Finished`


Successfully aliased the URL <https://lingonsaft-hacktober-fuctfnhxgz.now.sh> to the following alias.

* https://hacktoberfest.lingonsaft.com


Apply this check in `validateSeriesProps` function. Check `this.props.mxObject && this.props.mxObject.inheretsFrom("System.Image")` is `false` and return a validation message atleast before render instead of having it at runtime.


`direction`?


wew


グローバルな変数、関数は危ないので避けましょう。変数やヘルパ関数はクラスの中に書いて、なるべくprivateにするとよいですね！
ちなみにSegueのIdentifierなどの定数であればグローバルでもよいですが、その際も定数専用のクラスを作ってその中に閉じ込めるのが主流です😜


prefer short names for local variables.


![](https://github.trello.services/images/mini-trello-icon.png) [Patchati sigurnosne probleme u OMP-u](https://trello.com/c/X2qPhimQ/352-patchati-sigurnosne-probleme-u-omp-u)


いい感じに命名規則が守られてて素敵です🐧


so eventually politicians on the TAB make it true “there will be no Linux (if I heard 386BSD before)”


`(dim)` already means `vector`.


Koos mid certiga tulid kaks olukordi kui:
1) mitteaktiivne cert leitud (result: "NOT_ACTIVE")
2) cert pole leitud (result: "NOT_FOUND") (vaata: [CertificateRequestBuilder#validateResult(String)](https://github.com/spyroks/mobile-id-java-client/blob/837e4553dfcf9272e719e00bddba3998af149be5/src/main/java/ee/sk/mid/CertificateRequestBuilder.java))

ja kui neid handlida peaksin viskama NotActiveCertificateFound/CertificitaNotFound exceptione seega ma ühendasin MSSPTransactionExpired ja NotActiveCertificateFound = ExpiredExceptioniks, ResponseNotFound ja CertificateNotFound = NotFoundExceptioniks sest mõtte on peaaegu sama.


the previous names were more than fine. Hungarian notation is very outdated. :)


[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-2-build-tools-165.pantheonsite.io/)

Created multidev environment [ci-2](https://dashboard.pantheon.io/sites/40881c79-1bc0-4873-904e-5e8141543640#ci-2) for build-tools-165.


как успехи?)


don't forget to include etcd's NOTICE file.


up merger


This doesn't really work around the UCX issue, since that relates to the HID, not the CID. UCX thinks the ACPI HID syntax is "4 letters followed by 4 hex digits", when it's actually "3 or 4 letters followed by 4 hex digits". CID is already handled correctly as a freeform string.


interface_name is not used at all here, nor anywhere else other than get_interfaces, so it doesn't need to be a class member, just a function argument for get_interface()


Fix grammar in branch and commit names.


時間を扱うときは`Date`型を使うようにしましょう😜
Intで扱っても動くとは思うんですが、変換が面倒だったりするので...


a tah, agora entendi.


project already cloned/screenshotted, don't change git history again. thanks.


Saquei.


Why not return None in check_for_existence? Or even better, just remove this wrapper and call check_for_existence "get_preseed". :)


You have reached the limit of Now deployments through the GitHub integration in a 5 minutes window.

Now will resume accepting new pushes in 2 minutes.


Estava confundindo com o header, porque quando uso o header e não do exit ele parece que executa o codigo debaixo.


:rocket:


あれ、編集した覚えがないぞ


操作步骤4


[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-1-build-tools-174.pantheonsite.io/)

Created multidev environment [ci-1](https://dashboard.pantheon.io/sites/e8546d1b-29f1-45c0-a2e9-817bcf58f5ea#ci-1) for build-tools-174.


Hey


@catborise - do you plan to make some kind of a dashboard instead going directly onto Instaces page on login?


He has the device but not official aex :)


0x86c5c76d1E048DCa4169E07f4E087b938e497FA2

你好，
這就是我解決Walt存款問題的原因，請查看


Think before commenting like @DevanshBajaj


Connect to DB must be in another class, like 'DBController', transfer please


Zazwyczaj w aplikacjach dobrze jest rozdzielać kod na różne kontrolery, zależnie od tego, czym się zajmują. Chociaż to jest prosta i mała praktyka, warto pielęgnować dobre nawyki.


Yes, you're right!
When I developed this I used -ci first, but changed to -g before final commit.


We could add one line before importing `pandas` (PEP8 I guess), to separate native module form third-parties.


This two parameter (user, pass) must be as static final String (in your future class)


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-Products.statusmessages/37/violations
```
Products/statusmessages/tests/test_adapter.py:35:15: D001 found directlyProvides( replace it with zope.interface.provider
Products/statusmessages/tests/test_adapter.py:221:0: P102 docstring does contain unindexed parameters
Products/statusmessages/tests/test_adapter.py:241:15: D001 found directlyProvides( replace it with zope.interface.provider
Products/statusmessages/tests/test_adapter.py:308:0: P102 docstring does contain unindexed parameters
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


This is another method, but in DBController class (transfer)


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-borg.localrole/40/violations
```
borg/localrole/__init__.py:20:24: C812 missing trailing comma
borg/localrole/factory_adapter.py:68:13: D001 found directlyProvides( replace it with zope.interface.provider
borg/localrole/factory_adapter.py:84:13: D001 found directlyProvides( replace it with zope.interface.provider
borg/localrole/factory_adapter.py:95:0: P102 docstring does contain unindexed parameters
borg/localrole/interfaces.py:8:58: C812 missing trailing comma
borg/localrole/interfaces.py:13:78: C812 missing trailing comma
borg/localrole/tests.py:53:26: Q000 Remove bad quotes.
borg/localrole/tests.py:53:46: Q000 Remove bad quotes.
borg/localrole/tests.py:56:34: C812 missing trailing comma
borg/localrole/tests.py:67:78: C812 missing trailing comma
borg/localrole/tests.py:76:35: C812 missing trailing comma
borg/localrole/tests.py:81:78: C812 missing trailing comma
borg/localrole/tests.py:83:35: C812 missing trailing comma
borg/localrole/utils.py:25:9: T003 print function found.
borg/localrole/utils.py:25:15: Q000 Remove bad quotes.
borg/localrole/utils.py:25:15: S001 found module formatter
borg/localrole/utils.py:35:27: P002 found "hasattr", consider replacing it
borg/localrole/workspace.py:6:1: I001 isort found an import in the wrong position
borg/localrole/workspace.py:22:5: Q000 Remove bad quotes.
borg/localrole/workspace.py:24:14: Q000 Remove bad quotes.
borg/localrole/workspace.py:24:50: C812 missing trailing comma
borg/localrole/workspace.py:32:17: C812 missing trailing comma
borg/localrole/workspace.py:44:42: C812 missing trailing comma
borg/localrole/workspace.py:45:14: C812 missing trailing comma
borg/localrole/workspace.py:137:0: P102 docstring does contain unindexed parameters
borg/localrole/workspace.py:268:13: D001 found directlyProvides( replace it with zope.interface.provider
borg/localrole/workspace.py:269:13: D001 found directlyProvides( replace it with zope.interface.provider
borg/localrole/workspace.py:316:80: E501 line too long (84 > 79 characters)
borg/localrole/workspace.py:336:80: E501 line too long (86 > 79 characters)
borg/localrole/workspace.py:378:17: Q000 Remove bad quotes.
borg/localrole/workspace.py:381:34: Q000 Remove bad quotes.
borg/localrole/workspace.py:390:16: P002 found "hasattr", consider replacing it
borg/localrole/workspace.py:444:19: T000 Todo note found.
borg/localrole/workspace.py:448:46: C812 missing trailing comma
borg/localrole/workspace.py:454:75: C812 missing trailing comma
borg/localrole/workspace.py:458:5: C901 'WorkspaceLocalRoleManager.checkLocalRolesAllowed' is too complex (14)
borg/localrole/workspace.py:482:15: T000 Todo note found.
borg/localrole/workspace.py:510:22: T000 Todo note found.
borg/localrole/workspace.py:516:7: T000 Todo note found.
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Not really serious, but this could be a tuple or a generator (slightly more efficient than lists):

We could have `(year for year in range(2008, date.today().year + 1))` and then convert it to a tuple in `__init__` (see further comment).


ssss


don`t need, instead - add him to your list


Beleza


hotelhoster.com


System.out.println("Error while loading DB: " + e.getMessage());


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.alterego/17/violations
```
plone/alterego/dynamic.py:26:18: C812 missing trailing comma
plone/alterego/dynamic.py:33:57: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


ok


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.blob/68/violations
```
src/plone/app/blob/monkey.py:2:3: T000 Todo note found.
src/plone/app/blob/monkey.py:54:12: P002 found "hasattr", consider replacing it
src/plone/app/blob/markings.py:3:3: T000 Todo note found.
src/plone/app/blob/content.py:135:13: T000 Todo note found.
src/plone/app/blob/field.py:47:12: P002 found "hasattr", consider replacing it
src/plone/app/blob/field.py:145:11: T000 Todo note found.
src/plone/app/blob/field.py:281:16: P002 found "hasattr", consider replacing it
src/plone/app/blob/field.py:312:48: T000 Todo note found.
src/plone/app/blob/field.py:316:38: C815 missing trailing comma in Python 3.5+
src/plone/app/blob/field.py:392:12: P002 found "hasattr", consider replacing it
src/plone/app/blob/migrations.py:43:1: C901 'makeMigrator' is too complex (15)
src/plone/app/blob/migrations.py:55:80: E501 line too long (122 > 79 characters)
src/plone/app/blob/migrations.py:83:20: P002 found "hasattr", consider replacing it
src/plone/app/blob/download.py:35:1: C901 'handleRequestRange' is too complex (14)
src/plone/app/blob/tests/test_integration.py:164:41: P101 format string does contain unindexed parameters
src/plone/app/blob/tests/test_integration.py:167:41: P101 format string does contain unindexed parameters
src/plone/app/blob/tests/test_replacements.py:414:9: E731 do not assign a lambda expression, use a def
src/plone/app/blob/tests/utils.py:60:9: T003 print function found.
src/plone/app/blob/tests/utils.py:61:9: T003 print function found.
src/plone/app/blob/tests/utils.py:62:9: T003 print function found.
src/plone/app/blob/tests/utils.py:74:9: T003 print function found.
src/plone/app/blob/tests/utils.py:75:9: T003 print function found.
src/plone/app/blob/tests/utils.py:76:9: T003 print function found.
src/plone/app/blob/tests/patches.py:17:12: P002 found "hasattr", consider replacing it
src/plone/app/blob/browser/maintenance.py:29:12: S001 found module formatter
src/plone/app/blob/browser/size.py:30:19: S001 found module formatter
src/plone/app/blob/browser/size.py:42:16: S001 found module formatter
src/plone/app/blob/browser/size.py:46:9: E731 do not assign a lambda expression, use a def
src/plone/app/blob/browser/migration.py:33:26: C812 missing trailing comma
src/plone/app/blob/browser/migration.py:41:26: C812 missing trailing comma
src/plone/app/blob/subtypes/image.py:24:12: P002 found "hasattr", consider replacing it
src/plone/app/blob/subtypes/image.py:27:15: T000 Todo note found.
src/plone/app/blob/subtypes/image.py:29:12: P002 found "hasattr", consider replacing it
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Zawsze stosujemy query bindings, nawet jeśli operujemy na znanych skalarach jak tutaj. https://www.codeigniter.com/userguide3/database/queries.html?highlight=query%20bindings#query-bindings


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.caching/41/violations
```
plone/app/caching/lookup.py:57:5: C901 'ContentItemLookup.__call__' is too complex (12)
plone/app/caching/purge.py:182:5: C901 'ScalesPurgePaths.getRelativePaths' is too complex (12)
plone/app/caching/testing.py:49:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/caching/utils.py:63:11: T000 Todo note found.
plone/app/caching/browser/controlpanel.py:31:1: I001 isort found an import in the wrong position
plone/app/caching/browser/controlpanel.py:39:12: C812 missing trailing comma
plone/app/caching/browser/controlpanel.py:90:5: C901 'ControlPanel.publishTraverse' is too complex (11)
plone/app/caching/browser/controlpanel.py:172:5: C901 'ControlPanel.processSave' is too complex (33)
plone/app/caching/browser/controlpanel.py:433:45: E231 missing whitespace after ':'
plone/app/caching/browser/controlpanel.py:433:80: E501 line too long (85 > 79 characters)
plone/app/caching/browser/controlpanel.py:562:5: C901 'Purge.processPurge' is too complex (19)
plone/app/caching/browser/edit.py:208:11: T000 Todo note found.
plone/app/caching/browser/edit.py:271:21: C812 missing trailing comma
plone/app/caching/operations/default.py:76:59: C812 missing trailing comma
plone/app/caching/operations/default.py:137:32: C815 missing trailing comma in Python 3.5+
plone/app/caching/operations/default.py:142:5: C901 'BaseCaching.modifyResponse' is too complex (11)
plone/app/caching/operations/default.py:175:15: T000 Todo note found.
plone/app/caching/operations/default.py:234:51: C812 missing trailing comma
plone/app/caching/operations/default.py:287:58: C812 missing trailing comma
plone/app/caching/operations/utils.py:362:1: C901 'isModified' is too complex (14)
plone/app/caching/operations/utils.py:434:7: T000 Todo note found.
plone/app/caching/tests/test_profile_with_caching_proxy.py:150:26: S001 found module formatter
plone/app/caching/tests/test_profile_with_caching_proxy.py:165:26: S001 found module formatter
plone/app/caching/tests/test_profile_with_caching_proxy.py:184:26: S001 found module formatter
plone/app/caching/tests/test_profile_with_caching_proxy.py:230:26: S001 found module formatter
plone/app/caching/tests/test_profile_with_caching_proxy.py:247:26: S001 found module formatter
plone/app/caching/tests/test_profile_with_caching_proxy.py:267:26: S001 found module formatter
plone/app/caching/tests/test_purge.py:43:1: I003 isort expected 1 blank line in imports, found 0
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


どんどん進化してきてとても良い感じです！
もうCoreDataを扱うようになるとは...感激です。

ただ、**気合で解決**しようとしているな！？という面も見られましたので(時刻を文字列に変換するやつとか)、そのへん今後改善していければな〜と思います。

あと、変数名とメソッド名はまだ気になるところが散見されますね。細かい事ではあるのですが、読みやすさには大きく関わってくるので気をつけてください。(先頭小文字でキャメルケース、単語の省略はせずにお願いいたします)

色々文句をいいましたが、1週間でこれはだいぶすごいです。Foo!


good, but transfer to another method


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.contentmenu/37/violations
```
plone/app/contentmenu/menu.py:39:1: I003 isort expected 1 blank line in imports, found 0
plone/app/contentmenu/menu.py:61:50: C812 missing trailing comma
plone/app/contentmenu/menu.py:68:39: C812 missing trailing comma
plone/app/contentmenu/menu.py:98:39: C812 missing trailing comma
plone/app/contentmenu/menu.py:141:39: C812 missing trailing comma
plone/app/contentmenu/menu.py:149:52: C812 missing trailing comma
plone/app/contentmenu/menu.py:190:21: C812 missing trailing comma
plone/app/contentmenu/menu.py:238:5: C901 'DisplayMenu.getMenuItems' is too complex (22)
plone/app/contentmenu/menu.py:243:55: C812 missing trailing comma
plone/app/contentmenu/menu.py:334:36: C812 missing trailing comma
plone/app/contentmenu/menu.py:405:36: C812 missing trailing comma
plone/app/contentmenu/menu.py:412:80: C812 missing trailing comma
plone/app/contentmenu/menu.py:477:43: C812 missing trailing comma
plone/app/contentmenu/menu.py:504:39: C812 missing trailing comma
plone/app/contentmenu/menu.py:516:25: C812 missing trailing comma
plone/app/contentmenu/menu.py:748:5: C901 'WorkflowMenu.getMenuItems' is too complex (13)
plone/app/contentmenu/menu.py:865:60: C812 missing trailing comma
plone/app/contentmenu/menu.py:879:25: C812 missing trailing comma
plone/app/contentmenu/menu.py:894:25: C812 missing trailing comma
plone/app/contentmenu/menu.py:909:24: C812 missing trailing comma
plone/app/contentmenu/menu.py:939:28: E128 continuation line under-indented for visual indent
plone/app/contentmenu/menu.py:939:80: E501 line too long (80 > 79 characters)
plone/app/contentmenu/testing.py:17:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/contentmenu/tests/test_menu.py:28:1: I001 isort found an import in the wrong position
plone/app/contentmenu/tests/test_menu.py:55:51: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:86:66: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:98:54: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:133:48: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:137:48: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:142:52: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:147:52: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:156:67: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:177:48: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:182:9: D001 found directlyProvides( replace it with zope.interface.provider
plone/app/contentmenu/tests/test_menu.py:267:57: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:329:43: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:444:68: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:450:69: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:467:76: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:470:80: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:482:68: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:487:9: D001 found directlyProvides( replace it with zope.interface.provider
plone/app/contentmenu/tests/test_menu.py:795:9: D001 found directlyProvides( replace it with zope.interface.provider
plone/app/contentmenu/tests/test_menu.py:934:1: C901 'If 934' is too complex (11)
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Widoki służą do serwowania kodu HTML. W PHP nigdy nie powinieneś używać "echo".


logic must be without connection


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.contentrules/58/violations
```
plone/app/contentrules/handlers.py:80:12: P002 found "hasattr", consider replacing it
plone/app/contentrules/handlers.py:82:12: P002 found "hasattr", consider replacing it
plone/app/contentrules/handlers.py:89:8: P002 found "hasattr", consider replacing it
plone/app/contentrules/handlers.py:92:8: P002 found "hasattr", consider replacing it
plone/app/contentrules/actions/copy.py:85:45: C812 missing trailing comma
plone/app/contentrules/actions/copy.py:86:18: C812 missing trailing comma
plone/app/contentrules/actions/copy.py:126:56: C812 missing trailing comma
plone/app/contentrules/actions/logger.py:22:60: C812 missing trailing comma
plone/app/contentrules/actions/logger.py:50:10: C812 missing trailing comma
plone/app/contentrules/actions/logger.py:94:18: C812 missing trailing comma
plone/app/contentrules/actions/mail.py:39:22: C812 missing trailing comma
plone/app/contentrules/actions/mail.py:45:57: C812 missing trailing comma
plone/app/contentrules/actions/mail.py:47:23: C812 missing trailing comma
plone/app/contentrules/actions/mail.py:53:67: C812 missing trailing comma
plone/app/contentrules/actions/mail.py:55:22: C812 missing trailing comma
plone/app/contentrules/actions/mail.py:59:80: C812 missing trailing comma
plone/app/contentrules/actions/mail.py:64:22: C812 missing trailing comma
plone/app/contentrules/actions/mail.py:102:5: C901 'MailActionExecutor.__call__' is too complex (13)
plone/app/contentrules/actions/mail.py:106:74: C812 missing trailing comma
plone/app/contentrules/actions/mail.py:129:78: C812 missing trailing comma
plone/app/contentrules/actions/mail.py:152:19: C812 missing trailing comma
plone/app/contentrules/actions/mail.py:165:19: T000 Todo note found.
plone/app/contentrules/actions/mail.py:176:78: C812 missing trailing comma
plone/app/contentrules/actions/move.py:54:52: C812 missing trailing comma
plone/app/contentrules/actions/move.py:91:18: C812 missing trailing comma
plone/app/contentrules/actions/move.py:144:56: C812 missing trailing comma
plone/app/contentrules/browser/assignments.py:24:5: C901 'ManageAssignments.__call__' is too complex (14)
plone/app/contentrules/browser/assignments.py:154:54: C812 missing trailing comma
plone/app/contentrules/browser/controlpanel.py:83:18: C812 missing trailing comma
plone/app/contentrules/browser/elements.py:29:5: C901 'ManageElements.__call__' is too complex (12)
plone/app/contentrules/browser/elements.py:77:45: C812 missing trailing comma
plone/app/contentrules/conditions/fileextension.py:31:22: C812 missing trailing comma
plone/app/contentrules/conditions/fileextension.py:49:50: C812 missing trailing comma
plone/app/contentrules/conditions/fileextension.py:90:78: C812 missing trailing comma
plone/app/contentrules/conditions/fileextension.py:113:78: C812 missing trailing comma
plone/app/contentrules/conditions/group.py:27:77: C812 missing trailing comma
plone/app/contentrules/conditions/group.py:45:60: C812 missing trailing comma
plone/app/contentrules/conditions/group.py:84:70: C812 missing trailing comma
plone/app/contentrules/conditions/group.py:105:70: C812 missing trailing comma
plone/app/contentrules/conditions/portaltype.py:33:72: C812 missing trailing comma
plone/app/contentrules/conditions/portaltype.py:34:10: C812 missing trailing comma
plone/app/contentrules/conditions/portaltype.py:60:50: C812 missing trailing comma
plone/app/contentrules/conditions/portaltype.py:79:16: P002 found "hasattr", consider replacing it
plone/app/contentrules/conditions/portaltype.py:98:34: C812 missing trailing comma
plone/app/contentrules/conditions/portaltype.py:119:26: C812 missing trailing comma
plone/app/contentrules/conditions/role.py:28:76: C812 missing trailing comma
plone/app/contentrules/conditions/role.py:46:59: C812 missing trailing comma
plone/app/contentrules/conditions/role.py:84:51: C812 missing trailing comma
plone/app/contentrules/conditions/role.py:105:51: C812 missing trailing comma
plone/app/contentrules/conditions/wfstate.py:28:63: C812 missing trailing comma
plone/app/contentrules/conditions/wfstate.py:29:10: C812 missing trailing comma
plone/app/contentrules/conditions/wfstate.py:46:59: C812 missing trailing comma
plone/app/contentrules/conditions/wftransition.py:28:68: C812 missing trailing comma
plone/app/contentrules/conditions/wftransition.py:29:10: C812 missing trailing comma
plone/app/contentrules/exportimport/rules.py:30:1: I004 isort found an unexpected blank line in imports
plone/app/contentrules/exportimport/rules.py:138:11: T000 Todo note found.
plone/app/contentrules/exportimport/rules.py:201:5: C901 'RulesXMLAdapter._initRules' is too complex (21)
plone/app/contentrules/tests/test_action_delete.py:12:1: F401 'plone.app.testing.login' imported but unused
plone/app/contentrules/tests/test_action_delete.py:12:1: I001 isort found an import in the wrong position
plone/app/contentrules/tests/test_action_delete.py:13:1: F401 'plone.app.testing.TEST_USER_ID' imported but unused
plone/app/contentrules/tests/test_action_delete.py:13:1: I001 isort found an import in the wrong position
plone/app/contentrules/tests/test_action_delete.py:14:1: F401 'plone.app.testing.TEST_USER_NAME' imported but unused
plone/app/contentrules/tests/test_action_delete.py:14:1: I001 isort found an import in the wrong position
plone/app/contentrules/tests/test_action_delete.py:15:1: F401 'plone.app.testing.setRoles' imported but unused
plone/app/contentrules/tests/test_action_delete.py:15:1: I001 isort found an import in the wrong position
plone/app/contentrules/tests/test_action_logger.py:6:1: F401 'plone.app.testing.TEST_USER_ID' imported but unused
plone/app/contentrules/tests/test_action_mail.py:50:11: T000 Todo note found.
plone/app/contentrules/tests/test_action_mail.py:95:14: C812 missing trailing comma
plone/app/contentrules/tests/test_action_mail.py:250:73: C812 missing trailing comma
plone/app/contentrules/tests/test_action_workflow.py:70:14: C812 missing trailing comma
plone/app/contentrules/tests/test_action_workflow.py:89:14: C812 missing trailing comma
plone/app/contentrules/tests/test_browser.py:2:80: E501 line too long (84 > 79 characters)
plone/app/contentrules/tests/test_cascading_rule.py:3:80: E501 line too long (84 > 79 characters)
plone/app/contentrules/tests/test_condition_wftransition.py:68:18: C812 missing trailing comma
plone/app/contentrules/tests/test_condition_wftransition.py:83:18: C812 missing trailing comma
plone/app/contentrules/tests/test_condition_wftransition.py:98:18: C812 missing trailing comma
plone/app/contentrules/tests/test_configuration.py:90:80: E501 line too long (85 > 79 characters)
plone/app/contentrules/tests/test_events.py:8:11: T000 Todo note found.
plone/app/contentrules/tests/test_events.py:12:11: T000 Todo note found.
plone/app/contentrules/tests/test_rule_assignment_mapping.py:7:1: F401 'plone.app.contentrules.tests.base.ContentRulesTestCase' imported but unused
plone/app/contentrules/tests/test_traversal.py:4:1: I001 isort found an import in the wrong position
plone/app/contentrules/tests/test_traversal.py:5:1: I001 isort found an import in the wrong position
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.customerize/25/violations
```
plone/app/customerize/tool.py:31:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/customerize/registration.py:16:1: I001 isort found an import in the wrong position
plone/app/customerize/registration.py:49:15: P002 found "hasattr", consider replacing it
plone/app/customerize/registration.py:51:11: T000 Todo note found.
plone/app/customerize/registration.py:74:15: T000 Todo note found.
plone/app/customerize/registration.py:112:35: C812 missing trailing comma
plone/app/customerize/registration.py:135:31: C812 missing trailing comma
plone/app/customerize/registration.py:155:7: T000 Todo note found.
plone/app/customerize/testing.py:13:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/customerize/testing.py:16:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/customerize/testing.py:19:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/customerize/tests/testDocTests.py:31:63: C812 missing trailing comma
plone/app/customerize/tests/testDocTests.py:32:14: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


to falando assim: o codigo estava assim <?php echo 'foobar' ?> ai você tirou o comando php e colocou o = e não colocou o echo, esse = vai substituir o 'php' e o comando 'echo'? fazendo devolver a mesma coisa?


Not really serious, but this could be a tuple (slightly more efficient than lists):

```python
self.years = (years,) if isinstance(years, int) else tuple(years)
```

(I'm comparing to `int` because I guess this is how a custom year arrive from the CLI, but we must check this info.)


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.discussion/99/violations
```
plone/app/discussion/catalog.py:17:1: I003 isort expected 1 blank line in imports, found 0
plone/app/discussion/tests/test_indexers.py:5:1: I001 isort found an import in the wrong position
plone/app/discussion/tests/test_functional.py:34:18: C812 missing trailing comma
plone/app/discussion/browser/comment.py:17:1: F811 redefinition of unused 'CommentForm' from line 2
plone/app/discussion/browser/comment.py:17:1: I001 isort found an import in the wrong position
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Created multidev environment [rescue-x#oct-18](https://dashboard.pantheon.io/sites/c8430b75-4272-4aca-bfcd-206b12279315#oct-18).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://oct-18-rescue-x.pantheonsite.io/)


In Python we use a single line between class methods (there are two lines here and elsewhere within this same class).


kandydat do SQL Inejction


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.iterate/76/violations
```
plone/app/iterate/event.py:28:1: I004 isort found an unexpected blank line in imports
plone/app/iterate/event.py:29:1: I001 isort found an import in the wrong position
plone/app/iterate/setuphandlers.py:11:27: C812 missing trailing comma
plone/app/iterate/interfaces.py:321:23: C812 missing trailing comma
plone/app/iterate/interfaces.py:328:22: C812 missing trailing comma
plone/app/iterate/base.py:160:22: W292 no newline at end of file
plone/app/iterate/testing.py:147:80: E501 line too long (83 > 79 characters)
plone/app/iterate/containers.py:72:50: C812 missing trailing comma
plone/app/iterate/containers.py:73:14: C812 missing trailing comma
plone/app/iterate/archiver.py:26:1: I004 isort found an unexpected blank line in imports
plone/app/iterate/archiver.py:27:1: I001 isort found an import in the wrong position
plone/app/iterate/policy.py:57:45: C812 missing trailing comma
plone/app/iterate/policy.py:66:11: T000 Todo note found.
plone/app/iterate/permissions.py:26:1: I003 isort expected 1 blank line in imports, found 0
plone/app/iterate/copier.py:37:1: I001 isort found an import in the wrong position
plone/app/iterate/__init__.py:48:78: C812 missing trailing comma
plone/app/iterate/tests/test_iterate.py:171:80: E501 line too long (97 > 79 characters)
plone/app/iterate/tests/test_iterate_at.py:35:1: I003 isort expected 1 blank line in imports, found 0
plone/app/iterate/tests/test_iterate_at.py:42:5: E301 expected 1 blank line, found 0
plone/app/iterate/tests/test_iterate_at.py:52:80: E501 line too long (85 > 79 characters)
plone/app/iterate/tests/test_iterate_at.py:154:11: T000 Todo note found.
plone/app/iterate/tests/test_iterate_at.py:302:80: E501 line too long (97 > 79 characters)
plone/app/iterate/tests/test_doctests.py:6:1: I003 isort expected 1 blank line in imports, found 0
plone/app/iterate/tests/test_doctests.py:7:1: I003 isort expected 1 blank line in imports, found 0
plone/app/iterate/tests/test_doctests.py:9:5: F401 'Products.ATContentTypes' imported but unused
plone/app/iterate/tests/test_doctests.py:26:54: C812 missing trailing comma
plone/app/iterate/tests/test_doctests.py:34:53: C812 missing trailing comma
plone/app/iterate/dexterity/utils.py:25:18: C812 missing trailing comma
plone/app/iterate/dexterity/copier.py:5:1: I001 isort found an import in the wrong position
plone/app/iterate/dexterity/copier.py:67:19: T000 Todo note found.
plone/app/iterate/dexterity/copier.py:157:50: C812 missing trailing comma
plone/app/iterate/browser/checkout.py:70:33: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Thanks, this looks like a clean way to get tar name. Also the directory in the tar could have a different name than the name of tar file. For this i am thinking of using `tar -tf snappy.tar| head -1| cut -d "/" -f1`


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.linkintegrity/75/violations
```
plone/app/linkintegrity/handlers.py:28:1: I003 isort expected 1 blank line in imports, found 0
plone/app/linkintegrity/handlers.py:32:1: C901 'findObject' is too complex (12)
plone/app/linkintegrity/handlers.py:123:5: T000 Todo note found.
plone/app/linkintegrity/parser.py:3:1: I003 isort expected 1 blank line in imports, found 0
plone/app/linkintegrity/testing.py:61:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/linkintegrity/testing.py:146:50: C812 missing trailing comma
plone/app/linkintegrity/testing.py:151:49: C812 missing trailing comma
plone/app/linkintegrity/testing.py:157:54: C812 missing trailing comma
plone/app/linkintegrity/testing.py:162:53: C812 missing trailing comma
plone/app/linkintegrity/upgrades.py:5:1: I001 isort found an import in the wrong position
plone/app/linkintegrity/upgrades.py:6:1: I001 isort found an import in the wrong position
plone/app/linkintegrity/upgrades.py:7:1: I001 isort found an import in the wrong position
plone/app/linkintegrity/upgrades.py:8:1: I001 isort found an import in the wrong position
plone/app/linkintegrity/upgrades.py:8:25: Q000 Remove bad quotes.
plone/app/linkintegrity/upgrades.py:16:1: I003 isort expected 1 blank line in imports, found 0
plone/app/linkintegrity/upgrades.py:16:1: I003 isort expected 1 blank line in imports, found 0
plone/app/linkintegrity/upgrades.py:16:1: I003 isort expected 1 blank line in imports, found 0
plone/app/linkintegrity/utils.py:8:1: I003 isort expected 1 blank line in imports, found 0
plone/app/linkintegrity/utils.py:15:42: C812 missing trailing comma
plone/app/linkintegrity/utils.py:42:42: C812 missing trailing comma
plone/app/linkintegrity/browser/info.py:15:1: I003 isort expected 1 blank line in imports, found 0
plone/app/linkintegrity/browser/info.py:43:5: C901 'DeleteConfirmationInfo.get_breaches' is too complex (16)
plone/app/linkintegrity/browser/info.py:83:45: C812 missing trailing comma
plone/app/linkintegrity/browser/info.py:87:38: C812 missing trailing comma
plone/app/linkintegrity/browser/info.py:91:45: C812 missing trailing comma
plone/app/linkintegrity/browser/info.py:97:37: C812 missing trailing comma
plone/app/linkintegrity/browser/update.py:14:1: I003 isort expected 1 blank line in imports, found 0
plone/app/linkintegrity/browser/update.py:14:1: I003 isort expected 1 blank line in imports, found 0
plone/app/linkintegrity/browser/update.py:65:16: S001 found module formatter
plone/app/linkintegrity/tests/test_circular.py:90:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/linkintegrity/tests/test_circular.py:92:5: E301 expected 1 blank line, found 0
plone/app/linkintegrity/tests/test_circular.py:92:80: E501 line too long (83 > 79 characters)
plone/app/linkintegrity/tests/test_functional.py:59:11: T000 Todo note found.
plone/app/linkintegrity/tests/test_functional.py:149:65: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:150:14: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:213:59: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:214:14: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:296:59: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:297:14: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:304:34: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:308:34: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:336:65: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:337:14: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:342:34: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:375:65: C812 missing trailing comma
plone/app/linkintegrity/tests/test_functional.py:376:14: C812 missing trailing comma
plone/app/linkintegrity/tests/test_handlers.py:38:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/linkintegrity/tests/test_imagescales.py:69:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/linkintegrity/tests/test_references.py:65:11: T000 Todo note found.
plone/app/linkintegrity/tests/test_references.py:88:23: C812 missing trailing comma
plone/app/linkintegrity/tests/test_references.py:102:23: C812 missing trailing comma
plone/app/linkintegrity/tests/test_references.py:207:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/linkintegrity/tests/test_upgrade.py:5:1: I003 isort expected 1 blank line in imports, found 0
plone/app/linkintegrity/tests/test_upgrade.py:5:1: I003 isort expected 1 blank line in imports, found 0
plone/app/linkintegrity/tests/test_upgrade.py:5:1: I003 isort expected 1 blank line in imports, found 0
plone/app/linkintegrity/tests/test_upgrade.py:11:1: I001 isort found an import in the wrong position
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Can we have a more meaningful variable name? `f` doesn't say much ; )


@lategoodbye Thanks for taking a look - appreciate it.

Good catch - not at all certain.  What's a more appropriate alignment for our architecture/device?


Entendi


Zawsze warto pisać z pełnym wsparciem wersji językowych.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.relationfield/31/violations
```
plone/app/relationfield/event.py:9:1: C901 'extract_relations' is too complex (13)
plone/app/relationfield/testing.py:71:46: C812 missing trailing comma
plone/app/relationfield/testing.py:102:58: C812 missing trailing comma
plone/app/relationfield/testing.py:133:58: C812 missing trailing comma
plone/app/relationfield/schemaeditor.py:36:23: C812 missing trailing comma
plone/app/relationfield/schemaeditor.py:105:6: C812 missing trailing comma
plone/app/relationfield/widget.py:31:19: T000 Todo note found.
plone/app/relationfield/widget.py:71:19: T000 Todo note found.
plone/app/relationfield/widget.py:129:19: T000 Todo note found.
plone/app/relationfield/widget.py:166:19: T000 Todo note found.
plone/app/relationfield/behavior.py:23:56: C812 missing trailing comma
plone/app/relationfield/behavior.py:25:23: C812 missing trailing comma
plone/app/relationfield/behavior.py:33:10: C812 missing trailing comma
plone/app/relationfield/behavior.py:39:32: C812 missing trailing comma
plone/app/relationfield/supermodel.py:17:31: C812 missing trailing comma
plone/app/relationfield/supermodel.py:59:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/relationfield/demo.py:16:56: C812 missing trailing comma
plone/app/relationfield/demo.py:17:10: C812 missing trailing comma
plone/app/relationfield/demo.py:22:52: C812 missing trailing comma
plone/app/relationfield/source.py:30:24: C812 missing trailing comma
plone/app/relationfield/source.py:40:26: C812 missing trailing comma
plone/app/relationfield/tests/test_marshall.py:12:42: C812 missing trailing comma
plone/app/relationfield/tests/test_marshall.py:25:28: C812 missing trailing comma
plone/app/relationfield/tests/test_supermodel.py:32:46: C812 missing trailing comma
plone/app/relationfield/tests/test_schemaeditor.py:20:44: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Zawsze deklarujemy widoczność


boto fé


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.testing/60/violations
```
plone/app/testing/bbb.py:55:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/bbb.py:99:9: Q001 Remove bad quotes from multiline string.
plone/app/testing/bbb_at.py:55:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/bbb_at.py:99:9: Q001 Remove bad quotes from multiline string.
plone/app/testing/cleanup.py:39:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/helpers.py:432:16: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/testing/helpers.py:442:25: C812 missing trailing comma
plone/app/testing/helpers.py:488:41: C812 missing trailing comma
plone/app/testing/layers.py:106:32: C812 missing trailing comma
plone/app/testing/layers.py:141:45: C812 missing trailing comma
plone/app/testing/layers.py:167:21: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/testing/layers.py:203:11: T000 Todo note found.
plone/app/testing/layers.py:227:15: C812 missing trailing comma
plone/app/testing/layers.py:253:31: C812 missing trailing comma
plone/app/testing/layers.py:264:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/layers.py:358:39: C812 missing trailing comma
plone/app/testing/layers.py:380:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/layers.py:382:29: C812 missing trailing comma
plone/app/testing/layers.py:386:28: C812 missing trailing comma
plone/app/testing/layers.py:391:25: C812 missing trailing comma
plone/app/testing/layers.py:395:27: C812 missing trailing comma
plone/app/testing/selenium_layers.py:21:35: C812 missing trailing comma
plone/app/testing/selenium_layers.py:32:1: E305 expected 2 blank lines after class or function definition, found 1
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.users/75/violations
```
plone/app/users/upgrades.py:17:25: Q000 Remove bad quotes.
plone/app/users/upgrades.py:40:31: Q000 Remove bad quotes.
plone/app/users/upgrades.py:41:23: Q000 Remove bad quotes.
plone/app/users/upgrades.py:52:31: Q000 Remove bad quotes.
plone/app/users/upgrades.py:53:23: Q000 Remove bad quotes.
plone/app/users/upgrades.py:54:23: Q000 Remove bad quotes.
plone/app/users/upgrades.py:65:31: Q000 Remove bad quotes.
plone/app/users/upgrades.py:66:23: Q000 Remove bad quotes.
plone/app/users/upgrades.py:67:23: Q000 Remove bad quotes.
plone/app/users/upgrades.py:81:72: C812 missing trailing comma
plone/app/users/upgrades.py:98:33: Q000 Remove bad quotes.
plone/app/users/upgrades.py:114:9: E128 continuation line under-indented for visual indent
plone/app/users/upgrades.py:115:20: C812 missing trailing comma
plone/app/users/setuphandlers.py:7:1: I003 isort expected 1 blank line in imports, found 0
plone/app/users/utils.py:22:65: C812 missing trailing comma
plone/app/users/utils.py:23:10: C812 missing trailing comma
plone/app/users/field_extender.py:29:15: Q000 Remove bad quotes.
plone/app/users/field_extender.py:30:21: Q000 Remove bad quotes.
plone/app/users/field_extender.py:45:5: D001 found adapts( replace it with zope.component.adapter
plone/app/users/field_extender.py:74:56: Q000 Remove bad quotes.
plone/app/users/vocabularies.py:3:1: I001 isort found an import in the wrong position
plone/app/users/vocabularies.py:43:80: E501 line too long (130 > 79 characters)
plone/app/users/vocabularies.py:117:25: S001 found module formatter
plone/app/users/schema.py:22:21: Q000 Remove bad quotes.
plone/app/users/schema.py:24:16: Q000 Remove bad quotes.
plone/app/users/schema.py:34:11: T000 Todo note found.
plone/app/users/schema.py:78:31: Q000 Remove bad quotes.
plone/app/users/schema.py:97:21: Q000 Remove bad quotes.
plone/app/users/schema.py:98:21: Q000 Remove bad quotes.
plone/app/users/schema.py:99:21: Q000 Remove bad quotes.
plone/app/users/schema.py:99:76: C812 missing trailing comma
plone/app/users/schema.py:100:10: C812 missing trailing comma
plone/app/users/schema.py:112:31: Q000 Remove bad quotes.
plone/app/users/schema.py:113:23: Q000 Remove bad quotes.
plone/app/users/schema.py:117:25: Q000 Remove bad quotes.
plone/app/users/schema.py:118:17: Q000 Remove bad quotes.
plone/app/users/schema.py:158:16: S001 found module formatter
plone/app/users/schema.py:172:48: C812 missing trailing comma
plone/app/users/schema.py:175:13: Q000 Remove bad quotes.
plone/app/users/schema.py:176:22: Q000 Remove bad quotes.
plone/app/users/schema.py:177:22: Q000 Remove bad quotes.
plone/app/users/schema.py:178:22: Q000 Remove bad quotes.
plone/app/users/schema.py:179:22: Q000 Remove bad quotes.
plone/app/users/schema.py:180:22: Q000 Remove bad quotes.
plone/app/users/schema.py:181:22: Q000 Remove bad quotes.
plone/app/users/tests/test_pam.py:7:1: I001 isort found an import in the wrong position
plone/app/users/tests/test_pam.py:9:1: F401 'plone.app.users.browser.userdatapanel.UserDataPanel' imported but unused
plone/app/users/tests/test_pam.py:10:1: F401 'plone.app.users.testing.PLONE_APP_USERS_FUNCTIONAL_TESTING' imported but unused
plone/app/users/tests/test_pam.py:13:1: F401 'transaction.commit' imported but unused
plone/app/users/tests/test_pam.py:14:1: F401 'zExceptions.NotFound' imported but unused
plone/app/users/tests/test_pam.py:15:1: F401 'zope.i18n.translate' imported but unused
plone/app/users/tests/test_pam.py:37:10: Q000 Remove bad quotes.
plone/app/users/tests/test_pam.py:46:44: S001 found module formatter
plone/app/users/tests/test_pam.py:46:80: E501 line too long (96 > 79 characters)
plone/app/users/tests/test_pam.py:48:80: E501 line too long (100 > 79 characters)
plone/app/users/tests/test_schema_types.py:7:1: F401 'plone.app.users.testing.PLONE_APP_USERS_FUNCTIONAL_TESTING' imported but unused
plone/app/users/tests/test_schema_types.py:10:1: I001 isort found an import in the wrong position
plone/app/users/tests/test_schema_types.py:19:80: E501 line too long (438 > 79 characters)
plone/app/users/tests/test_schema_types.py:21:80: E501 line too long (81 > 79 characters)
plone/app/users/tests/test_schema_types.py:28:80: E501 line too long (84 > 79 characters)
plone/app/users/tests/test_schema_types.py:36:80: E501 line too long (85 > 79 characters)
plone/app/users/tests/test_schema_types.py:44:80: E501 line too long (101 > 79 characters)
plone/app/users/tests/test_schema_types.py:53:80: E501 line too long (82 > 79 characters)
plone/app/users/tests/test_schema_types.py:58:80: E501 line too long (89 > 79 characters)
plone/app/users/tests/test_schema_types.py:68:80: E501 line too long (85 > 79 characters)
plone/app/users/tests/test_schema_types.py:94:80: E501 line too long (83 > 79 characters)
plone/app/users/tests/test_schema_types.py:116:27: Q000 Remove bad quotes.
plone/app/users/tests/test_schema_types.py:122:41: Q000 Remove bad quotes.
plone/app/users/tests/test_schema_types.py:122:80: E501 line too long (80 > 79 characters)
plone/app/users/tests/test_schema_types.py:123:80: E501 line too long (116 > 79 characters)
plone/app/users/tests/test_schema_types.py:123:87: Q000 Remove bad quotes.
plone/app/users/tests/test_schema_types.py:123:100: Q000 Remove bad quotes.
plone/app/users/tests/test_schema_types.py:143:80: E501 line too long (84 > 79 characters)
plone/app/users/tests/test_account.py:2:1: I001 isort found an import in the wrong position
plone/app/users/tests/test_account.py:4:1: F401 'plone.app.users.tests.base.BaseTestCase' imported but unused
plone/app/users/tests/test_account.py:7:1: I001 isort found an import in the wrong position
plone/app/users/tests/test_account.py:8:1: I003 isort expected 1 blank line in imports, found 0
plone/app/users/tests/test_user_data_panel.py:2:1: F401 'plone.app.testing.applyProfile' imported but unused
plone/app/users/tests/test_user_data_panel.py:4:1: F401 'plone.app.users.testing.PLONE_APP_USERS_FUNCTIONAL_TESTING' imported but unused
plone/app/users/tests/test_user_data_panel.py:16:30: C812 missing trailing comma
plone/app/users/tests/test_user_data_panel.py:28:62: C812 missing trailing comma
plone/app/users/tests/base.py:11:1: F401 'plone.app.testing.setRoles' imported but unused
plone/app/users/tests/base.py:12:1: I001 isort found an import in the wrong position
plone/app/users/tests/base.py:72:14: D001 found declarePrivate( replace it with AccessControl.ClassSecurityInfo.private
plone/app/users/tests/base.py:132:58: Q000 Remove bad quotes.
plone/app/users/tests/test_robot.py:2:1: F401 'plone.app.users.testing.PLONE_APP_USERS_ACCEPTANCE_TESTING' imported but unused
plone/app/users/tests/test_robot.py:3:1: F401 'plone.testing.layered' imported but unused
plone/app/users/tests/test_robot.py:6:1: F401 'robotsuite' imported but unused
plone/app/users/tests/test_robot.py:13:53: Q000 Remove bad quotes.
plone/app/users/tests/test_robot.py:14:9: F841 local variable 'testfilepath' is assigned to but never used
plone/app/users/tests/test_robot.py:14:37: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:5:1: F401 'plone.app.users.testing.PLONE_APP_USERS_FUNCTIONAL_TESTING' imported but unused
plone/app/users/tests/test_exportimport.py:18:80: E501 line too long (438 > 79 characters)
plone/app/users/tests/test_exportimport.py:20:80: E501 line too long (81 > 79 characters)
plone/app/users/tests/test_exportimport.py:27:80: E501 line too long (84 > 79 characters)
plone/app/users/tests/test_exportimport.py:35:80: E501 line too long (85 > 79 characters)
plone/app/users/tests/test_exportimport.py:43:80: E501 line too long (101 > 79 characters)
plone/app/users/tests/test_exportimport.py:52:80: E501 line too long (82 > 79 characters)
plone/app/users/tests/test_exportimport.py:57:80: E501 line too long (89 > 79 characters)
plone/app/users/tests/test_exportimport.py:67:80: E501 line too long (85 > 79 characters)
plone/app/users/tests/test_exportimport.py:93:80: E501 line too long (83 > 79 characters)
plone/app/users/tests/test_exportimport.py:107:41: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:110:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:112:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:115:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:117:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:120:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:122:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:125:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:129:26: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:131:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:133:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:136:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:137:80: E501 line too long (81 > 79 characters)
plone/app/users/tests/test_exportimport.py:138:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:141:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:143:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:146:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:148:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:151:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:153:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:156:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:158:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:161:23: Q000 Remove bad quotes.
plone/app/users/tests/test_exportimport.py:163:23: Q000 Remove bad quotes.
plone/app/users/tests/test_new_user.py:13:62: C812 missing trailing comma
plone/app/users/tests/test_new_user.py:30:68: C812 missing trailing comma
plone/app/users/tests/test_new_user.py:43:62: C812 missing trailing comma
plone/app/users/tests/test_new_user.py:64:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:66:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:67:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:84:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:85:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:87:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:88:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:104:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:105:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:107:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:108:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:126:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:127:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:129:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:130:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:148:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:150:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:154:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:172:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:173:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:175:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_new_user.py:179:14: D001 found assertEquals( replace it with assertEqual
plone/app/users/tests/test_doctests.py:36:80: E501 line too long (86 > 79 characters)
plone/app/users/browser/userdatapanel.py:46:37: Q000 Remove bad quotes.
plone/app/users/browser/userdatapanel.py:78:53: C812 missing trailing comma
plone/app/users/browser/userdatapanel.py:84:59: C812 missing trailing comma
plone/app/users/browser/userdatapanel.py:103:41: C812 missing trailing comma
plone/app/users/browser/registersettingspanel.py:15:15: Q000 Remove bad quotes.
plone/app/users/browser/registersettingspanel.py:16:21: Q000 Remove bad quotes.
plone/app/users/browser/registersettingspanel.py:17:19: Q000 Remove bad quotes.
plone/app/users/browser/registersettingspanel.py:33:20: C812 missing trailing comma
plone/app/users/browser/registersettingspanel.py:51:49: C812 missing trailing comma
plone/app/users/browser/registersettingspanel.py:53:21: Q000 Remove bad quotes.
plone/app/users/browser/registersettingspanel.py:55:21: Q000 Remove bad quotes.
plone/app/users/browser/registersettingspanel.py:56:65: Q000 Remove bad quotes.
plone/app/users/browser/personalpreferences.py:34:46: C812 missing trailing comma
plone/app/users/browser/personalpreferences.py:36:20: Q000 Remove bad quotes.
plone/app/users/browser/personalpreferences.py:43:20: Q000 Remove bad quotes.
plone/app/users/browser/personalpreferences.py:44:23: C812 missing trailing comma
plone/app/users/browser/personalpreferences.py:82:41: C812 missing trailing comma
plone/app/users/browser/personalpreferences.py:88:50: C812 missing trailing comma
plone/app/users/browser/personalpreferences.py:95:13: Q000 Remove bad quotes.
plone/app/users/browser/personalpreferences.py:96:13: Q000 Remove bad quotes.
plone/app/users/browser/personalpreferences.py:96:47: C812 missing trailing comma
plone/app/users/browser/personalpreferences.py:99:13: Q000 Remove bad quotes.
plone/app/users/browser/personalpreferences.py:100:13: Q000 Remove bad quotes.
plone/app/users/browser/personalpreferences.py:100:32: C812 missing trailing comma
plone/app/users/browser/passwordpanel.py:30:21: Q000 Remove bad quotes.
plone/app/users/browser/passwordpanel.py:37:21: Q000 Remove bad quotes.
plone/app/users/browser/passwordpanel.py:38:13: Q000 Remove bad quotes.
plone/app/users/browser/passwordpanel.py:61:21: Q000 Remove bad quotes.
plone/app/users/browser/passwordpanel.py:76:45: C812 missing trailing comma
plone/app/users/browser/passwordpanel.py:93:29: Q000 Remove bad quotes.
plone/app/users/browser/passwordpanel.py:113:28: C812 missing trailing comma
plone/app/users/browser/passwordpanel.py:139:38: Q000 Remove bad quotes.
plone/app/users/browser/passwordpanel.py:139:45: C812 missing trailing comma
plone/app/users/browser/passwordpanel.py:144:15: Q000 Remove bad quotes.
plone/app/users/browser/passwordpanel.py:144:41: Q000 Remove bad quotes.
plone/app/users/browser/passwordpanel.py:144:47: C812 missing trailing comma
plone/app/users/browser/schemaeditor.py:49:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:50:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:51:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:52:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:53:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:54:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:55:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:56:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:57:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:58:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:59:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:60:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:61:5: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:98:15: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:111:21: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:139:30: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:146:17: S001 found module formatter
plone/app/users/browser/schemaeditor.py:220:33: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:225:28: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:226:31: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:229:17: B901 blind except: statement
plone/app/users/browser/schemaeditor.py:232:26: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:233:26: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:238:31: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:238:46: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:240:21: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:240:21: S001 found module formatter
plone/app/users/browser/schemaeditor.py:242:21: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:242:21: S001 found module formatter
plone/app/users/browser/schemaeditor.py:251:25: Q000 Remove bad quotes.
plone/app/users/browser/schemaeditor.py:251:25: S001 found module formatter
plone/app/users/browser/schemaeditor.py:302:19: C812 missing trailing comma
plone/app/users/browser/schemaeditor.py:312:19: C812 missing trailing comma
plone/app/users/browser/register.py:53:41: C812 missing trailing comma
plone/app/users/browser/register.py:63:13: Q000 Remove bad quotes.
plone/app/users/browser/register.py:64:19: Q000 Remove bad quotes.
plone/app/users/browser/register.py:79:62: Q000 Remove bad quotes.
plone/app/users/browser/register.py:100:59: Q000 Remove bad quotes.
plone/app/users/browser/register.py:101:17: Q000 Remove bad quotes.
plone/app/users/browser/register.py:102:17: Q000 Remove bad quotes.
plone/app/users/browser/register.py:103:17: Q000 Remove bad quotes.
plone/app/users/browser/register.py:108:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:109:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:110:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:111:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:111:50: C812 missing trailing comma
plone/app/users/browser/register.py:125:49: C812 missing trailing comma
plone/app/users/browser/register.py:129:5: C901 'BaseRegistrationForm.generate_user_id' is too complex (12)
plone/app/users/browser/register.py:206:12: P002 found "hasattr", consider replacing it
plone/app/users/browser/register.py:217:22: Q000 Remove bad quotes.
plone/app/users/browser/register.py:217:22: S001 found module formatter
plone/app/users/browser/register.py:276:5: C901 'BaseRegistrationForm.validate_registration' is too complex (17)
plone/app/users/browser/register.py:352:29: Q000 Remove bad quotes.
plone/app/users/browser/register.py:353:29: Q000 Remove bad quotes.
plone/app/users/browser/register.py:360:29: Q000 Remove bad quotes.
plone/app/users/browser/register.py:361:29: Q000 Remove bad quotes.
plone/app/users/browser/register.py:371:29: Q000 Remove bad quotes.
plone/app/users/browser/register.py:372:29: Q000 Remove bad quotes.
plone/app/users/browser/register.py:380:37: Q000 Remove bad quotes.
plone/app/users/browser/register.py:381:29: Q000 Remove bad quotes.
plone/app/users/browser/register.py:388:67: C812 missing trailing comma
plone/app/users/browser/register.py:404:11: T000 Todo note found.
plone/app/users/browser/register.py:413:5: C901 'BaseRegistrationForm.handle_join_success' is too complex (13)
plone/app/users/browser/register.py:450:69: Q000 Remove bad quotes.
plone/app/users/browser/register.py:493:35: Q000 Remove bad quotes.
plone/app/users/browser/register.py:494:27: Q000 Remove bad quotes.
plone/app/users/browser/register.py:495:27: Q000 Remove bad quotes.
plone/app/users/browser/register.py:504:35: Q000 Remove bad quotes.
plone/app/users/browser/register.py:505:27: Q000 Remove bad quotes.
plone/app/users/browser/register.py:506:27: Q000 Remove bad quotes.
plone/app/users/browser/register.py:549:19: Q000 Remove bad quotes.
plone/app/users/browser/register.py:607:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:608:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:609:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:610:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:617:19: Q000 Remove bad quotes.
plone/app/users/browser/register.py:658:65: C812 missing trailing comma
plone/app/users/browser/register.py:667:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:668:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:669:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:670:25: Q000 Remove bad quotes.
plone/app/users/browser/register.py:670:79: C812 missing trailing comma
plone/app/users/browser/register.py:676:67: C812 missing trailing comma
plone/app/users/browser/register.py:706:69: Q000 Remove bad quotes.
plone/app/users/browser/register.py:710:15: Q000 Remove bad quotes.
plone/app/users/browser/membersearch.py:18:46: C812 missing trailing comma
plone/app/users/browser/account.py:31:16: Q000 Remove bad quotes.
plone/app/users/browser/account.py:32:16: Q000 Remove bad quotes.
plone/app/users/browser/account.py:36:16: Q000 Remove bad quotes.
plone/app/users/browser/account.py:37:16: Q000 Remove bad quotes.
plone/app/users/browser/account.py:38:16: Q000 Remove bad quotes.
plone/app/users/browser/account.py:77:44: C812 missing trailing comma
plone/app/users/browser/account.py:91:39: P002 found "hasattr", consider replacing it
plone/app/users/browser/account.py:138:24: Q000 Remove bad quotes.
plone/app/users/browser/account.py:139:26: Q000 Remove bad quotes.
plone/app/users/browser/account.py:170:20: P101 format string does contain unindexed parameters
plone/app/users/browser/account.py:187:41: Q000 Remove bad quotes.
plone/app/users/browser/account.py:232:57: Q000 Remove bad quotes.
plone/app/users/browser/account.py:233:60: Q000 Remove bad quotes.
plone/app/users/browser/account.py:235:13: S001 found module formatter
plone/app/users/browser/account.py:235:68: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-2-build-tools-177.pantheonsite.io/)

Created multidev environment [ci-2](https://dashboard.pantheon.io/sites/e5b06e9e-99fb-48ec-9cf4-7c21b7033e27#ci-2) for build-tools-177.


Además ahora todo esta indentado con espacios y no con tabs


Write like [this](http://fortranwiki.org/fortran/show/FAQ#eof)


似たような名前のAttributeがあって役割がわかりにくいかも。
書いている本人はわかるんだけどね...僕が読む時に「なにが違うんだろう」ってなっちまったので...。(すいません)


What does `fd` means? File download? (just out of curiosity I guess)


Nigdy nie przekierowujemy na Referer, przeglądarki nie zawsze go posiadają, to nie jest bezpieczna informacja (można nim dowolnie manipulować) i nawet przy normalnych operacjach może zawierać coś nieporządanego (np. stronę wyników wyszukiwania google)


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.z3cform/122/violations
```
plone/app/z3cform/converters.py:106:11: T000 Todo note found.
plone/app/z3cform/widget.py:5:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:667:19: T000 Todo note found.
plone/app/z3cform/widget.py:681:47: T000 Todo note found.
plone/app/z3cform/inline_validation.py:15:5: C901 'InlineValidationView.__call__' is too complex (15)
plone/app/z3cform/tests/test_widgets.py:6:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/test_widgets.py:161:50: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:171:60: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:172:18: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Salt é o que? é codigos dentro do md5 que juntam com a senha?


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.behavior/12/violations
```
plone/behavior/interfaces.py:33:22: C812 missing trailing comma
plone/behavior/interfaces.py:38:23: C812 missing trailing comma
plone/behavior/interfaces.py:46:23: C812 missing trailing comma
plone/behavior/interfaces.py:52:26: C812 missing trailing comma
plone/behavior/interfaces.py:62:26: C812 missing trailing comma
plone/behavior/interfaces.py:68:25: C812 missing trailing comma
plone/behavior/interfaces.py:89:25: C812 missing trailing comma
plone/behavior/metaconfigure.py:83:65: C812 missing trailing comma
plone/behavior/metaconfigure.py:106:71: C812 missing trailing comma
plone/behavior/metaconfigure.py:111:25: C812 missing trailing comma
plone/behavior/metaconfigure.py:137:35: C812 missing trailing comma
plone/behavior/metaconfigure.py:149:35: C812 missing trailing comma
plone/behavior/metaconfigure.py:156:73: C812 missing trailing comma
plone/behavior/metaconfigure.py:169:21: C812 missing trailing comma
plone/behavior/registration.py:56:39: C812 missing trailing comma
plone/behavior/registration.py:57:14: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.browserlayer/19/violations
```
plone/browserlayer/layer.py:12:31: Q000 Remove bad quotes.
plone/browserlayer/layer.py:29:5: D001 found directlyProvides( replace it with zope.interface.provider
plone/browserlayer/utils.py:37:24: Q000 Remove bad quotes.
plone/browserlayer/utils.py:37:24: S001 found module formatter
plone/browserlayer/testing.py:20:10: Q000 Remove bad quotes.
plone/browserlayer/testing.py:20:40: C812 missing trailing comma
plone/browserlayer/exportimport.py:96:21: Q000 Remove bad quotes.
plone/browserlayer/exportimport.py:102:20: S001 found module formatter
plone/browserlayer/exportimport.py:115:21: Q000 Remove bad quotes.
plone/browserlayer/exportimport.py:121:20: S001 found module formatter
plone/browserlayer/__init__.py:0:1: C101 Coding magic comment not found
plone/browserlayer/tests/test_doctest.py:30:55: C812 missing trailing comma
plone/browserlayer/tests/test_doctest.py:31:10: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Successfully aliased the URL <https://pool-toolz-urixjzxzne.now.sh> to the following alias.

* https://pooltoolz.now.sh


Agora vi


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.caching/14/violations
```
plone/caching/operations.py:30:15: Q000 Remove bad quotes.
plone/caching/operations.py:31:21: Q000 Remove bad quotes.
plone/caching/operations.py:50:30: C812 missing trailing comma
plone/caching/operations.py:60:47: C812 missing trailing comma
plone/caching/operations.py:75:30: C812 missing trailing comma
plone/caching/utils.py:39:21: C812 missing trailing comma
plone/caching/utils.py:118:27: C812 missing trailing comma
plone/caching/hooks.py:39:49: Q000 Remove bad quotes.
plone/caching/hooks.py:81:22: C812 missing trailing comma
plone/caching/hooks.py:92:34: C812 missing trailing comma
plone/caching/hooks.py:115:22: C812 missing trailing comma
plone/caching/hooks.py:173:22: C812 missing trailing comma
plone/caching/hooks.py:214:18: C812 missing trailing comma
plone/caching/tests/test_utils.py:31:28: C812 missing trailing comma
plone/caching/tests/test_utils.py:42:28: C812 missing trailing comma
plone/caching/tests/test_utils.py:52:23: C812 missing trailing comma
plone/caching/tests/test_utils.py:59:28: C812 missing trailing comma
plone/caching/tests/test_utils.py:69:23: C812 missing trailing comma
plone/caching/tests/test_utils.py:73:24: C812 missing trailing comma
plone/caching/tests/test_utils.py:80:28: C812 missing trailing comma
plone/caching/tests/test_utils.py:123:19: C812 missing trailing comma
plone/caching/tests/test_utils.py:143:19: C812 missing trailing comma
plone/caching/tests/test_utils.py:147:19: C812 missing trailing comma
plone/caching/tests/test_utils.py:151:19: C812 missing trailing comma
plone/caching/tests/test_utils.py:171:19: C812 missing trailing comma
plone/caching/tests/test_utils.py:187:28: C812 missing trailing comma
plone/caching/tests/test_operations.py:140:35: C812 missing trailing comma
plone/caching/tests/test_operations.py:151:35: C812 missing trailing comma
plone/caching/tests/test_operations.py:201:35: C812 missing trailing comma
plone/caching/tests/test_operations.py:213:35: C812 missing trailing comma
plone/caching/tests/test_hooks.py:190:35: C812 missing trailing comma
plone/caching/tests/test_hooks.py:212:35: C812 missing trailing comma
plone/caching/tests/test_hooks.py:534:35: C812 missing trailing comma
plone/caching/tests/test_hooks.py:558:35: C812 missing trailing comma
plone/caching/tests/test_hooks.py:852:35: C812 missing trailing comma
plone/caching/tests/test_hooks.py:936:28: C812 missing trailing comma
plone/caching/tests/test_hooks.py:942:35: C812 missing trailing comma
plone/caching/tests/test_hooks.py:991:28: C812 missing trailing comma
plone/caching/tests/test_hooks.py:997:35: C812 missing trailing comma
plone/caching/tests/test_hooks.py:1045:28: C812 missing trailing comma
plone/caching/tests/test_hooks.py:1051:35: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Now cannot deploy because all the allocated instances are in use.
You can either [upgrade](https://zeit.co/account/plan) your plan or [down scale](https://zeit.co/docs/getting-started/scaling) existing [deployments](https://zeit.co/dashboard/deployments).


In Python 3 this way of concatenating is not recommended anymore. May we go with `'Download finished for {}'.format(f)` instead?


po co ten zwracany type? Tego się nie używa.


部署的教程也没有Docker鏡像搜索：doudoubing / openshift


thanks, fixed


adres URL witryny powinien być pobierany z ustawień


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.intelligenttext/22/violations
```
plone/intelligenttext/tests.py:4:1: I003 isort expected 1 blank line in imports, found 0
plone/intelligenttext/tests.py:11:5: T003 print function found.
plone/intelligenttext/tests.py:21:10: C812 missing trailing comma
plone/intelligenttext/transforms.py:4:1: I003 isort expected 1 blank line in imports, found 0
plone/intelligenttext/transforms.py:22:9: P103 other string does contain unindexed parameters
plone/intelligenttext/transforms.py:22:80: E501 line too long (278 > 79 characters)
plone/intelligenttext/transforms.py:23:27: C812 missing trailing comma
plone/intelligenttext/transforms.py:27:27: C812 missing trailing comma
plone/intelligenttext/transforms.py:63:45: Q000 Remove bad quotes.
plone/intelligenttext/transforms.py:68:20: Q000 Remove bad quotes.
plone/intelligenttext/transforms.py:69:32: Q000 Remove bad quotes.
plone/intelligenttext/transforms.py:73:26: Q000 Remove bad quotes.
plone/intelligenttext/transforms.py:79:37: Q000 Remove bad quotes.
plone/intelligenttext/transforms.py:79:54: Q000 Remove bad quotes.
plone/intelligenttext/transforms.py:90:11: T000 Todo note found.
plone/intelligenttext/transforms.py:101:16: S001 found module formatter
plone/intelligenttext/transforms.py:111:16: S001 found module formatter
plone/intelligenttext/transforms.py:154:18: S001 found module formatter
plone/intelligenttext/transforms.py:180:44: C812 missing trailing comma
plone/intelligenttext/transforms.py:183:7: T000 Todo note found.
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Entendi


@hjleesm 확인해본결과 굳이 -1을시켜서 할필요가없엇네!!!


Zawsze używamy klamr przy pełnych IFach, inaczej łatwo o podatność na błędy programistyczne


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.namedfile/97/violations
```
plone/namedfile/handler.py:11:23: C812 missing trailing comma
plone/namedfile/file.py:25:1: I003 isort expected 1 blank line in imports, found 0
plone/namedfile/file.py:261:9: Q001 Remove bad quotes from multiline string.
plone/namedfile/file.py:302:9: Q001 Remove bad quotes from multiline string.
plone/namedfile/scaling.py:33:1: I003 isort expected 1 blank line in imports, found 0
plone/namedfile/scaling.py:192:25: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:195:5: C901 'DefaultImageScalingFactory.__call__' is too complex (15)
plone/namedfile/scaling.py:202:25: C816 missing trailing comma in Python 3.6+
plone/namedfile/scaling.py:242:29: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:406:21: C816 missing trailing comma in Python 3.6+
plone/namedfile/scaling.py:433:25: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:445:25: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:459:21: C816 missing trailing comma in Python 3.6+
plone/namedfile/scaling.py:485:29: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:499:17: C816 missing trailing comma in Python 3.6+
plone/namedfile/interfaces.py:17:25: C812 missing trailing comma
plone/namedfile/testing.py:18:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/namedfile/testing.py:22:36: C812 missing trailing comma
plone/namedfile/storages.py:12:1: I003 isort expected 1 blank line in imports, found 0
plone/namedfile/marshaler.py:67:36: C812 missing trailing comma
plone/namedfile/tests/test_scaling.py:85:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:102:80: E501 line too long (81 > 79 characters)
plone/namedfile/tests/test_scaling.py:133:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:156:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:178:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:200:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_blobfile.py:40:31: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:45:35: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:50:46: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:55:32: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:116:28: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:146:70: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:153:76: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:164:74: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:197:75: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:202:78: C812 missing trailing comma
plone/namedfile/tests/test_doctests.py:25:51: C812 missing trailing comma
plone/namedfile/tests/test_doctests.py:27:10: C812 missing trailing comma
plone/namedfile/utils/tiff_utils.py:11:1: C901 'process_tiff' is too complex (11)
plone/namedfile/utils/tiff_utils.py:20:7: T000 Todo note found.
plone/namedfile/utils/tiff_utils.py:81:7: T000 Todo note found.
plone/namedfile/utils/tiff_utils.py:82:7: T000 Todo note found.
plone/namedfile/utils/__init__.py:19:1: I003 isort expected 1 blank line in imports, found 0
plone/namedfile/utils/__init__.py:83:66: C812 missing trailing comma
plone/namedfile/utils/__init__.py:150:15: T000 Todo note found.
plone/namedfile/utils/__init__.py:155:73: C812 missing trailing comma
plone/namedfile/utils/__init__.py:175:15: T000 Todo note found.
plone/namedfile/utils/__init__.py:182:18: C812 missing trailing comma
plone/namedfile/utils/__init__.py:187:1: C901 'rotate_image' is too complex (20)
plone/namedfile/utils/__init__.py:218:14: C812 missing trailing comma
plone/namedfile/utils/__init__.py:275:1: E302 expected 2 blank lines, found 1
plone/namedfile/utils/__init__.py:279:1: E302 expected 2 blank lines, found 1
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


what generates this image? i'd like to drop the  (in)significant digit from the y-axis


Shouldn't we append `csv_path` to `not_found_files` here?


Ponowne użycie referrera.


This doesn't return a boolean. It accepts an array of available encodings, and returns the encoding that matches the string. I think the point is that you feed a list, and the function accepts from that list that best fits. Feeding it one at a time isn't going to be useful.


No need for this parenthesis, `return translated_files, not_found_files` means exactly the same ; )


Budowa URLa 1) do zupełnej przebudowy na coś bezpiecznego 2) do funkcji


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.registry/20/violations
```
plone/registry/interfaces.py:28:23: C812 missing trailing comma
plone/registry/interfaces.py:32:23: C812 missing trailing comma
plone/registry/interfaces.py:46:67: C812 missing trailing comma
plone/registry/interfaces.py:50:22: C812 missing trailing comma
plone/registry/interfaces.py:68:32: C812 missing trailing comma
plone/registry/interfaces.py:73:70: C812 missing trailing comma
plone/registry/interfaces.py:85:23: C812 missing trailing comma
plone/registry/interfaces.py:112:45: Q000 Remove bad quotes.
plone/registry/interfaces.py:118:22: C812 missing trailing comma
plone/registry/interfaces.py:122:61: C812 missing trailing comma
plone/registry/interfaces.py:195:22: C812 missing trailing comma
plone/registry/interfaces.py:208:22: C812 missing trailing comma
plone/registry/field.py:17:1: I001 isort found an import in the wrong position
plone/registry/field.py:59:13: Q000 Remove bad quotes.
plone/registry/field.py:60:13: Q000 Remove bad quotes.
plone/registry/field.py:60:43: C812 missing trailing comma
plone/registry/field.py:97:17: Q000 Remove bad quotes.
plone/registry/field.py:98:17: Q000 Remove bad quotes.
plone/registry/field.py:101:18: C812 missing trailing comma
plone/registry/field.py:124:42: C812 missing trailing comma
plone/registry/field.py:236:21: Q000 Remove bad quotes.
plone/registry/field.py:237:21: Q000 Remove bad quotes.
plone/registry/field.py:237:63: C812 missing trailing comma
plone/registry/field.py:242:17: Q000 Remove bad quotes.
plone/registry/field.py:243:17: Q000 Remove bad quotes.
plone/registry/field.py:243:75: C812 missing trailing comma
plone/registry/field.py:247:13: Q000 Remove bad quotes.
plone/registry/field.py:249:13: Q000 Remove bad quotes.
plone/registry/field.py:257:25: Q000 Remove bad quotes.
plone/registry/field.py:257:79: C812 missing trailing comma
plone/registry/fieldfactory.py:35:30: Q000 Remove bad quotes.
plone/registry/fieldfactory.py:44:74: C812 missing trailing comma
plone/registry/fieldfactory.py:54:17: Q000 Remove bad quotes.
plone/registry/fieldfactory.py:55:17: Q000 Remove bad quotes.
plone/registry/fieldfactory.py:92:17: Q000 Remove bad quotes.
plone/registry/fieldfactory.py:93:17: Q000 Remove bad quotes.
plone/registry/tests.py:7:1: I001 isort found an import in the wrong position
plone/registry/tests.py:34:12: P002 found "hasattr", consider replacing it
plone/registry/tests.py:56:36: Q000 Remove bad quotes.
plone/registry/tests.py:56:60: Q000 Remove bad quotes.
plone/registry/tests.py:57:34: Q000 Remove bad quotes.
plone/registry/tests.py:64:15: Q000 Remove bad quotes.
plone/registry/tests.py:66:18: C812 missing trailing comma
plone/registry/tests.py:69:15: Q000 Remove bad quotes.
plone/registry/tests.py:70:29: C812 missing trailing comma
plone/registry/tests.py:107:40: Q000 Remove bad quotes.
plone/registry/tests.py:107:60: Q000 Remove bad quotes.
plone/registry/tests.py:148:34: Q000 Remove bad quotes.
plone/registry/tests.py:150:28: Q000 Remove bad quotes.
plone/registry/tests.py:152:36: Q000 Remove bad quotes.
plone/registry/tests.py:162:33: Q000 Remove bad quotes.
plone/registry/tests.py:163:67: Q000 Remove bad quotes.
plone/registry/tests.py:164:61: Q000 Remove bad quotes.
plone/registry/tests.py:178:44: C812 missing trailing comma
plone/registry/tests.py:186:44: C812 missing trailing comma
plone/registry/tests.py:194:44: C812 missing trailing comma
plone/registry/registry.py:24:1: I001 isort found an import in the wrong position
plone/registry/registry.py:25:1: I003 isort expected 1 blank line in imports, found 0
plone/registry/registry.py:60:11: T000 Todo note found.
plone/registry/registry.py:72:32: Q000 Remove bad quotes.
plone/registry/registry.py:79:25: Q000 Remove bad quotes.
plone/registry/registry.py:80:25: Q000 Remove bad quotes.
plone/registry/registry.py:82:33: C812 missing trailing comma
plone/registry/registry.py:83:26: C812 missing trailing comma
plone/registry/registry.py:95:32: Q000 Remove bad quotes.
plone/registry/registry.py:105:21: Q000 Remove bad quotes.
plone/registry/registry.py:106:21: Q000 Remove bad quotes.
plone/registry/registry.py:108:49: C812 missing trailing comma
plone/registry/registry.py:109:22: C812 missing trailing comma
plone/registry/registry.py:124:17: B901 blind except: statement
plone/registry/registry.py:130:32: C812 missing trailing comma
plone/registry/registry.py:141:20: C812 missing trailing comma
plone/registry/registry.py:175:9: Q000 Remove bad quotes.
plone/registry/registry.py:176:9: Q000 Remove bad quotes.
plone/registry/registry.py:177:9: Q000 Remove bad quotes.
plone/registry/registry.py:178:9: Q000 Remove bad quotes.
plone/registry/registry.py:180:9: Q000 Remove bad quotes.
plone/registry/registry.py:192:30: Q000 Remove bad quotes.
plone/registry/registry.py:291:21: Q000 Remove bad quotes.
plone/registry/registry.py:291:68: C812 missing trailing comma
plone/registry/registry.py:308:13: Q000 Remove bad quotes.
plone/registry/registry.py:309:13: Q000 Remove bad quotes.
plone/registry/registry.py:310:31: C812 missing trailing comma
plone/registry/events.py:20:16: Q000 Remove bad quotes.
plone/registry/events.py:20:16: S001 found module formatter
plone/registry/record.py:28:16: Q000 Remove bad quotes.
plone/registry/record.py:34:30: Q000 Remove bad quotes.
plone/registry/record.py:115:16: Q000 Remove bad quotes.
plone/registry/record.py:115:16: S001 found module formatter
plone/registry/__init__.py:2:1: F401 'plone.registry.fieldref.FieldRef' imported but unused
plone/registry/__init__.py:3:1: F401 'plone.registry.record.Record' imported but unused
plone/registry/__init__.py:4:1: F401 'plone.registry.registry.Registry' imported but unused
plone/registry/recordsproxy.py:16:5: F401 'collections.UserDict' imported but unused
plone/registry/recordsproxy.py:33:34: Q000 Remove bad quotes.
plone/registry/recordsproxy.py:47:12: E111 indentation is not a multiple of four
plone/registry/recordsproxy.py:65:16: Q000 Remove bad quotes.
plone/registry/recordsproxy.py:67:43: C812 missing trailing comma
plone/registry/recordsproxy.py:75:28: Q000 Remove bad quotes.
plone/registry/recordsproxy.py:84:32: Q000 Remove bad quotes.
plone/registry/recordsproxy.py:102:29: C812 missing trailing comma
plone/registry/recordsproxy.py:133:30: C812 missing trailing comma
plone/registry/recordsproxy.py:151:19: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@hjleesm 처음에는  이미짤려있는 배열이 배열로 들어가서 문자열로 나뉘어서 저장후 그후에 또다시 문자열로바꿔야하는줄 알았지만  디버깅해본결과 바로 문자열로 나와서 다시 수정


`Date` zamiast Date


Yes, some day, maybe.


eilt nicht. ich kann ja auch mal schauen.


This could be a generator instead:

```python
def filenames(self, extension):
    yield from ('federal-senate-{}.{}'.format(year, extension) for year in self.years)
```