[R/plotting-colours.R:89:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L89) *style:* **Lines should not be more than 100 characters.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-colours.R:89:32:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L89) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                              ~^~~
```
[R/plotting-colours.R:89:35:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L89) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                 ~^~~
```
[R/plotting-colours.R:89:41:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L89) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                        ^
```
[R/plotting-colours.R:106:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L106) *style:* **Lines should not be more than 100 characters.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-colours.R:106:32:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L106) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                              ~^~~
```
[R/plotting-colours.R:106:35:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L106) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                 ~^~~
```
[R/plotting-colours.R:106:41:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L106) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                        ^
```
[R/plotting-colours.R:131:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L131) *style:* **Lines should not be more than 100 characters.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-colours.R:131:32:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L131) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                              ~^~~
```
[R/plotting-colours.R:131:35:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L131) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                 ~^~~
```
[R/plotting-colours.R:131:41:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L131) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                        ^
```
[R/plotting-colours.R:287:35:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L287) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(grobToPlot[]%%1)==0))
                                 ~^~~
```
[R/plotting-colours.R:287:39:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L287) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(grobToPlot[]%%1)==0))
                                     ~^~~
```
[R/plotting-helpers.R:1028:44:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L1028) *style:* **Commas should always have a space after.**
```r
          grobToPlot <- grobToPlot[polySeq,]
                                           ^
```
[R/plotting-helpers.R:1033:38:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L1033) *style:* **Commas should always have a space after.**
```r
        grobToPlot <- grobToPlot[a[1,],]
                                     ^
```
[R/plotting-helpers.R:1033:40:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L1033) *style:* **Commas should always have a space after.**
```r
        grobToPlot <- grobToPlot[a[1,],]
                                       ^
```
[R/plotting-helpers.R:1296:41:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L1296) *style:* **Put spaces around all infix operators.**
```r
            if (all(na.omit(grobToPlot[]%%1)==0)) {
                                       ~^~~
```
[R/plotting-helpers.R:1296:45:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L1296) *style:* **Put spaces around all infix operators.**
```r
            if (all(na.omit(grobToPlot[]%%1)==0)) {
                                           ~^~~
```
[R/plotting-helpers.R:1385:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L1385) *style:* **Lines should not be more than 100 characters.**
```r
    grid.rect(x = 0, height = unit(1 + needsNewTitle * inherits(grobToPlot, "Raster") * 0.20 / (nRows / 2), "npc"),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2516:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2516) *style:* **Lines should not be more than 100 characters.**
```r
#'          jitter(sort(rbeta(nPoints, betaPar, betaPar) * (maxY - minY) + minY, decreasing = TRUE)),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2594:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2594) *style:* **Variable or function name should be lowerCamelCase.**
```r
thin.SpatialPolygons <- function(x, tolerance = NULL, returnDataFrame = FALSE, minCoordsToThin = 0,
^~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2615:8:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2615) *style:* **Commented code should be removed.**
```r
      #xyOrd[["out"]] <- xyOrd[["out"]][thinRes, ]# thin line
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2638:50:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2638) *style:* **Commas should always have a space after.**
```r
            dat <- x@data[as.numeric(names1) + 1,]
                                                 ^
```
[R/plotting-helpers.R:2639:14:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2639) *style:* **Commented code should be removed.**
```r
            #row.names(dat) <- as.character(seq_len(length(xyOrd)))
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2671:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2671) *style:* **Variable or function name should be lowerCamelCase.**
```r
thin.default <- function(x, tolerance, returnDataFrame, minCoordsToThin, ...) {
^~~~~~~~~~~~
```
[R/plotting-helpers.R:2706:3:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2706) *style:* **Variable or function name should be lowerCamelCase.**
```r
  IDs <- tryCatch(unlist(lapply(ordSeq, function(xx) {
  ^~~
```
[R/plotting-helpers.R:2731:7:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2731) *style:* **Commented code should be removed.**
```r
    # Polygons <- rep(rep(seq(numPolygons), numPolygon), idLength$V1) # sequential numbering
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2732:5:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2732) *style:* **Variable or function name should be lowerCamelCase.**
```r
    Polygons <- rep(rep(IDs, numPolygon), idLength$V1) # actual ID labelling
    ^~~~~~~~
```
[R/plotting-helpers.R:2733:5:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2733) *style:* **Variable or function name should be lowerCamelCase.**
```r
    Polygon <- rep(unlist(lapply(numPolygon, seq)), idLength$V1)
    ^~~~~~~
```
[R/plotting-helpers.R:2740:36:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2740) *style:* **Commas should always have a space after.**
```r
    return(data.frame(lat = xyOrd[,1], long = xyOrd[,2], order = orders,
                                   ^
```
[R/plotting-helpers.R:2740:54:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2740) *style:* **Commas should always have a space after.**
```r
    return(data.frame(lat = xyOrd[,1], long = xyOrd[,2], order = orders,
                                                     ^
```
[R/plotting-helpers.R:2742:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2742) *style:* **Lines should not be more than 100 characters.**
```r
                      #group = paste0(as.character(Polygons), ".", as.character(Polygon)))) # the actual fortify
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2745:40:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2745) *style:* **Commas should always have a space after.**
```r
    out <- setDT(data.frame(x = xyOrd[,1], y = xyOrd[,2], groups = groups))
                                       ^
```
[R/plotting-helpers.R:2745:55:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2745) *style:* **Commas should always have a space after.**
```r
    out <- setDT(data.frame(x = xyOrd[,1], y = xyOrd[,2], groups = groups))
                                                      ^
```
[R/plotting-helpers.R:2760:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2760) *style:* **Lines should not be more than 100 characters.**
```r
    which(polygon@data$Shape_Area>(sort(polygon@data$Shape_Area, decreasing = TRUE)[maxNumPolygons]))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2760:34:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2760) *style:* **Put spaces around all infix operators.**
```r
    which(polygon@data$Shape_Area>(sort(polygon@data$Shape_Area, decreasing = TRUE)[maxNumPolygons]))
                                ~^~
```
[R/plotting-helpers.R:2760:35:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2760) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    which(polygon@data$Shape_Area>(sort(polygon@data$Shape_Area, decreasing = TRUE)[maxNumPolygons]))
                                  ^
```
[R/plotting-helpers.R:2783:26:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2783) *style:* **Commas should always have a space after.**
```r
          totalAvailable," polygons in this view. See options('quickPlot.maxNumPolygons')")
                         ^
```
[R/plotting-other.R:202:48:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-other.R#L202) *style:* **Put spaces around all infix operators.**
```r
  if (any(raster::is.factor(ras1)) & all(ras1[]%%1==0)) {
                                              ~^~~
```
[R/plotting-other.R:202:51:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-other.R#L202) *style:* **Put spaces around all infix operators.**
```r
  if (any(raster::is.factor(ras1)) & all(ras1[]%%1==0)) {
                                                 ~^~~
```
[R/plotting-other.R:251:30:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-other.R#L251) *style:* **Commas should always have a space after.**
```r
    if (sum(corners$coords[1,] - corners$coords[2,]) %==% 0) {
                             ^
```
[R/plotting-other.R:251:51:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-other.R#L251) *style:* **Commas should always have a space after.**
```r
    if (sum(corners$coords[1,] - corners$coords[2,]) %==% 0) {
                                                  ^
```
[R/plotting-other.R:335:27:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-other.R#L335) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
    if (length(row) == 0) { # above the plot
                          ^
```
[R/plotting-other.R:338:30:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-other.R#L338) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
    if (length(column) == 0) { # above the plot
                             ^
```
[R/plotting-other.R:511:46:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-other.R#L511) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
  if (isTRUE("tools:rstudio" %in% search())) { # runing in Rstudio
                                             ^
```
[R/plotting.R:290:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting.R#L290) *style:* **Lines should not be more than 100 characters.**
```r
    isDoCall <- grepl("^do.call", scalls) & grepl("\\<Plot\\>", scalls) & !grepl("test_that", scalls)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting.R:308:6:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting.R#L308) *style:* **Commented code should be removed.**
```r
    #whFrame <- grep(scalls, pattern = "^Plot|^quickPlot::Plot")
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting.R:318:8:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting.R#L318) *style:* **Commented code should be removed.**
```r
      #dotObjs <- mget(dotNames[!noName], envir = plotFrame, inherits = TRUE)
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting.R:322:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting.R#L322) *style:* **Lines should not be more than 100 characters.**
```r
        if (is.null(title)) plotArgs$title <- ifelse(nzchar(names(dotObjs2)), names(dotObjs2), dotNames)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-clickExtent.R:11:3:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-clickExtent.R#L11) *style:* **Variable or function name should be lowerCamelCase.**
```r
  Sr1 <- Polygon(coords1)
  ^~~
```
[tests/testthat/test-clickExtent.R:12:3:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-clickExtent.R#L12) *style:* **Variable or function name should be lowerCamelCase.**
```r
  Srs1 <- Polygons(list(Sr1), "s1")
  ^~~~
```
[tests/testthat/test-clickExtent.R:14:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-clickExtent.R#L14) *style:* **Lines should not be more than 100 characters.**
```r
  crs(shpEcozone) <- "+init=epsg:4326 +proj=longlat +datum=WGS84 +no_defs +ellps=WGS84 +towgs84=0,0,0"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-clickExtent.R:24:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-clickExtent.R#L24) *style:* **Lines should not be more than 100 characters.**
```r
  bb <- raster::shapefile(file.path(cacheRepo, "EC_borealdisturbance_polygonal_2008_2010_FINAL_ALBERS.shp"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-examples.R:11:15:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-examples.R#L11) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
    setwd(owd)}
              ^
```
[tests/testthat/test-Plot-do-call.R:8:3:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-Plot-do-call.R#L8) *style:* **Variable or function name should be lowerCamelCase.**
```r
  Sr1 <- Polygon(coords1)
  ^~~
```
[tests/testthat/test-Plot-do-call.R:9:3:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-Plot-do-call.R#L9) *style:* **Variable or function name should be lowerCamelCase.**
```r
  Srs1 <- Polygons(list(Sr1), "s1")
  ^~~~
```
[tests/testthat/test-Plot-do-call.R:11:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-Plot-do-call.R#L11) *style:* **Lines should not be more than 100 characters.**
```r
  crs(shpEcozone) <- "+init=epsg:4326 +proj=longlat +datum=WGS84 +no_defs +ellps=WGS84 +towgs84=0,0,0"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-Plot-do-call.R:13:24:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-Plot-do-call.R#L13) *style:* **Commas should always have a space after.**
```r
  r <- raster(extent(0,10,0,10), res = 1, vals = 1:100)
                       ^
```
[tests/testthat/test-Plot-do-call.R:13:27:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-Plot-do-call.R#L13) *style:* **Commas should always have a space after.**
```r
  r <- raster(extent(0,10,0,10), res = 1, vals = 1:100)
                          ^
```
[tests/testthat/test-Plot-do-call.R:13:29:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-Plot-do-call.R#L13) *style:* **Commas should always have a space after.**
```r
  r <- raster(extent(0,10,0,10), res = 1, vals = 1:100)
                            ^
```
[tests/testthat/test-Plot-nonVisual.R:65:21:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-Plot-nonVisual.R#L65) *style:* **Commented code should be removed.**
```r
  library(raster); #on.exit(detach("package:raster"), add = TRUE)
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-Plot-nonVisual.R:70:3:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-Plot-nonVisual.R#L70) *style:* **Variable or function name should be lowerCamelCase.**
```r
  N <- ncol * nrow
  ^
```


@sciurus That looks like only the requests that made it through to Python, and doesn't count any caching that happens at the Nginx level. Is that what we want to be testing?


Yes I think it's fine to remove the Beken support.  Don't know that anyone
used it besides me with the Beken module pulled from a toy tx.

On Mon, Nov 5, 2018 at 8:30 AM goebish <notifications@github.com> wrote:

> Still, I'm wondering if anyone is still using a Beken transceiver instead
> of a nrf24l01 ... maybe this should be removed as that still produces a
> slight overhead in the .bin
> @hexfet <https://github.com/hexfet> , I'm not 100% sure of that, but I
> think you were the only one using one ?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/DeviationTX/deviation/commit/cb9e3d676ec7a31be58b2e6aa3792df3d42fd003#commitcomment-31175057>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ACp78EapCpOHJ8GIAVyL6YTF2QPioQa3ks5usD1kgaJpZM4YORb2>
> .
>


не должно быть комментариев в коде


избегать использование модификатора доступа по умолчанию


Oh, you missed the opportunity to name the switch `--lite` :)


Maybe we could use the base class here, so that layers are always visible in the list, even if they don't have a specialised implementation of the widget...


а я думал, тебе не понравилась критерия)


Thanks, I'll remove it then.


отступ между классом и полями


что это за странное название TheNew?)


Multiple background-images added to copy section of My Times project.


afecoi-fix (Myoldmopar) - x86_64-Linux-Ubuntu-18.04-gcc-7.3: OK (3060 of 3078 tests passed, 0 test warnings)

Failures:

regression Test Summary
 * Passed: 633
 * Failed: 18

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.42%25-yellow.png)


do my best


@philwo, android builds are failing on Windows with:

```
ERROR: D:/b/bk-worker-windows-java8-91sc/bazel/android-testing/WORKSPACE:4:1: no such package '@androidsdk//': C:/users/b/_bazel_b/2ks2x2wa/external/androidsdk/extras/android/m2repository (Not a directory) and referenced by '//external:android/sdk'
--
  | ERROR: D:/b/bk-worker-windows-java8-91sc/bazel/android-testing/WORKSPACE:4:1: no such package '@androidsdk//': C:/users/b/_bazel_b/2ks2x2wa/external/androidsdk/extras/android/m2repository (Not a directory) and referenced by '//external:android/dx_jar_import'
```

This change seems to be unsetting `ANDROID_HOME`. Is that intended?

cc @meteorcloudy

https://buildkite.com/bazel/android-testing/builds/53#f60cb46c-dbe7-4b3c-ac42-76fb0ebd0cda


Juan primer commit prueba para master


я же говорил, как надо именовать пакеты!


# Great job!


не надо делать отступ в первой строчке метода


Thanks! I appreciate the thoughtful response.


I'll let @kne42 weigh in here. We could maybe do something like at the base widget to the base layer class so there is always something (which can then get updated). Having a check here might still be a good idea, though maybe it's not necessary.


общий паттерн напиши, а не ждя каждого модуля отдельно указывать убирать одни и те же папки и файлы


ok, już wszystko śmiga, dzięki za wytłumaczenie!


I have argued in the past that results of tuning should go directly to LTC testing.  The tuning itself is a sort of test.  Now, if it passes very quickly, I'd like to see a 60,000 game test to verify.  Or we could test for regression at VLTC.


Файл должен заканчиваться новой строкой. В настройках редактора нужно поставить чтобы автоматически добавлял, если пропущена.


also however @kne42 does her inline comments I prefer to what @royerloic just did, as it renders more nicely on the main page of the PR. Not sure what the difference is.


afecoi-fix (Myoldmopar) - x86_64-Linux-Ubuntu-18.04-cppcheck-1.82: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png)


So this is the result of

```
go mod edit --require=github.com/ghodss/yaml@0ca9ea5df5451ffdf184b4428c902747c2c11cd7 --require=gopkg.in/yaml.v2@5420a8b6744d3b0345ab293f6fcba19c978f1183
go test ./kythe/...
```


I found only the TaskFake and it provides a builder. What other Fake objects do you mean?

> Am 07.11.2018 um 16:49 schrieb Jan Galinski <notifications@github.com>:
>
> For all other „fake“ objects we did not use the builder pattern but fluent setters. Though I like builders, i‘d Prefer a compatible api.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.


I'm not sure if I understand the cluttering concern. Consider `import_command`, for which `add` has `"imports data from STDIN or file"` as description. I was thinking that this description can be set in the constructor of `import_command`.

This way, reusing command in a different context yields the same description.


Congrats! I hope.


Большие отступы, используй два [пробела](https://github.com/rubocop-hq/ruby-style-guide#spaces-indentation)


[R/plotting-colours.R:89:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L89) *style:* **Lines should not be more than 100 characters.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-colours.R:89:32:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L89) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                              ~^~~
```
[R/plotting-colours.R:89:35:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L89) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                 ~^~~
```
[R/plotting-colours.R:89:41:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L89) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                        ^
```
[R/plotting-colours.R:106:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L106) *style:* **Lines should not be more than 100 characters.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-colours.R:106:32:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L106) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                              ~^~~
```
[R/plotting-colours.R:106:35:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L106) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                 ~^~~
```
[R/plotting-colours.R:106:41:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L106) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                        ^
```
[R/plotting-colours.R:131:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L131) *style:* **Lines should not be more than 100 characters.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-colours.R:131:32:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L131) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                              ~^~~
```
[R/plotting-colours.R:131:35:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L131) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                 ~^~~
```
[R/plotting-colours.R:131:41:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L131) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                        ^
```
[R/plotting-colours.R:287:35:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L287) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(grobToPlot[]%%1)==0))
                                 ~^~~
```
[R/plotting-colours.R:287:39:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-colours.R#L287) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(grobToPlot[]%%1)==0))
                                     ~^~~
```
[R/plotting-helpers.R:1028:44:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L1028) *style:* **Commas should always have a space after.**
```r
          grobToPlot <- grobToPlot[polySeq,]
                                           ^
```
[R/plotting-helpers.R:1033:38:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L1033) *style:* **Commas should always have a space after.**
```r
        grobToPlot <- grobToPlot[a[1,],]
                                     ^
```
[R/plotting-helpers.R:1033:40:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L1033) *style:* **Commas should always have a space after.**
```r
        grobToPlot <- grobToPlot[a[1,],]
                                       ^
```
[R/plotting-helpers.R:1296:41:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L1296) *style:* **Put spaces around all infix operators.**
```r
            if (all(na.omit(grobToPlot[]%%1)==0)) {
                                       ~^~~
```
[R/plotting-helpers.R:1296:45:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L1296) *style:* **Put spaces around all infix operators.**
```r
            if (all(na.omit(grobToPlot[]%%1)==0)) {
                                           ~^~~
```
[R/plotting-helpers.R:1385:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L1385) *style:* **Lines should not be more than 100 characters.**
```r
    grid.rect(x = 0, height = unit(1 + needsNewTitle * inherits(grobToPlot, "Raster") * 0.20 / (nRows / 2), "npc"),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2516:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2516) *style:* **Lines should not be more than 100 characters.**
```r
#'          jitter(sort(rbeta(nPoints, betaPar, betaPar) * (maxY - minY) + minY, decreasing = TRUE)),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2594:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2594) *style:* **Variable or function name should be lowerCamelCase.**
```r
thin.SpatialPolygons <- function(x, tolerance = NULL, returnDataFrame = FALSE, minCoordsToThin = 0,
^~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2615:8:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2615) *style:* **Commented code should be removed.**
```r
      #xyOrd[["out"]] <- xyOrd[["out"]][thinRes, ]# thin line
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2638:50:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2638) *style:* **Commas should always have a space after.**
```r
            dat <- x@data[as.numeric(names1) + 1,]
                                                 ^
```
[R/plotting-helpers.R:2639:14:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2639) *style:* **Commented code should be removed.**
```r
            #row.names(dat) <- as.character(seq_len(length(xyOrd)))
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2671:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2671) *style:* **Variable or function name should be lowerCamelCase.**
```r
thin.default <- function(x, tolerance, returnDataFrame, minCoordsToThin, ...) {
^~~~~~~~~~~~
```
[R/plotting-helpers.R:2706:3:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2706) *style:* **Variable or function name should be lowerCamelCase.**
```r
  IDs <- tryCatch(unlist(lapply(ordSeq, function(xx) {
  ^~~
```
[R/plotting-helpers.R:2731:7:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2731) *style:* **Commented code should be removed.**
```r
    # Polygons <- rep(rep(seq(numPolygons), numPolygon), idLength$V1) # sequential numbering
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2732:5:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2732) *style:* **Variable or function name should be lowerCamelCase.**
```r
    Polygons <- rep(rep(IDs, numPolygon), idLength$V1) # actual ID labelling
    ^~~~~~~~
```
[R/plotting-helpers.R:2733:5:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2733) *style:* **Variable or function name should be lowerCamelCase.**
```r
    Polygon <- rep(unlist(lapply(numPolygon, seq)), idLength$V1)
    ^~~~~~~
```
[R/plotting-helpers.R:2740:36:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2740) *style:* **Commas should always have a space after.**
```r
    return(data.frame(lat = xyOrd[,1], long = xyOrd[,2], order = orders,
                                   ^
```
[R/plotting-helpers.R:2740:54:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2740) *style:* **Commas should always have a space after.**
```r
    return(data.frame(lat = xyOrd[,1], long = xyOrd[,2], order = orders,
                                                     ^
```
[R/plotting-helpers.R:2742:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2742) *style:* **Lines should not be more than 100 characters.**
```r
                      #group = paste0(as.character(Polygons), ".", as.character(Polygon)))) # the actual fortify
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2745:40:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2745) *style:* **Commas should always have a space after.**
```r
    out <- setDT(data.frame(x = xyOrd[,1], y = xyOrd[,2], groups = groups))
                                       ^
```
[R/plotting-helpers.R:2745:55:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2745) *style:* **Commas should always have a space after.**
```r
    out <- setDT(data.frame(x = xyOrd[,1], y = xyOrd[,2], groups = groups))
                                                      ^
```
[R/plotting-helpers.R:2760:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2760) *style:* **Lines should not be more than 100 characters.**
```r
    which(polygon@data$Shape_Area>(sort(polygon@data$Shape_Area, decreasing = TRUE)[maxNumPolygons]))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2760:34:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2760) *style:* **Put spaces around all infix operators.**
```r
    which(polygon@data$Shape_Area>(sort(polygon@data$Shape_Area, decreasing = TRUE)[maxNumPolygons]))
                                ~^~
```
[R/plotting-helpers.R:2760:35:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2760) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    which(polygon@data$Shape_Area>(sort(polygon@data$Shape_Area, decreasing = TRUE)[maxNumPolygons]))
                                  ^
```
[R/plotting-helpers.R:2783:26:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-helpers.R#L2783) *style:* **Commas should always have a space after.**
```r
          totalAvailable," polygons in this view. See options('quickPlot.maxNumPolygons')")
                         ^
```
[R/plotting-other.R:202:48:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-other.R#L202) *style:* **Put spaces around all infix operators.**
```r
  if (any(raster::is.factor(ras1)) & all(ras1[]%%1==0)) {
                                              ~^~~
```
[R/plotting-other.R:202:51:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-other.R#L202) *style:* **Put spaces around all infix operators.**
```r
  if (any(raster::is.factor(ras1)) & all(ras1[]%%1==0)) {
                                                 ~^~~
```
[R/plotting-other.R:251:30:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-other.R#L251) *style:* **Commas should always have a space after.**
```r
    if (sum(corners$coords[1,] - corners$coords[2,]) %==% 0) {
                             ^
```
[R/plotting-other.R:251:51:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-other.R#L251) *style:* **Commas should always have a space after.**
```r
    if (sum(corners$coords[1,] - corners$coords[2,]) %==% 0) {
                                                  ^
```
[R/plotting-other.R:335:27:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-other.R#L335) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
    if (length(row) == 0) { # above the plot
                          ^
```
[R/plotting-other.R:338:30:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-other.R#L338) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
    if (length(column) == 0) { # above the plot
                             ^
```
[R/plotting-other.R:511:46:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting-other.R#L511) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
  if (isTRUE("tools:rstudio" %in% search())) { # runing in Rstudio
                                             ^
```
[R/plotting.R:290:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting.R#L290) *style:* **Lines should not be more than 100 characters.**
```r
    isDoCall <- grepl("^do.call", scalls) & grepl("\\<Plot\\>", scalls) & !grepl("test_that", scalls)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting.R:308:6:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting.R#L308) *style:* **Commented code should be removed.**
```r
    #whFrame <- grep(scalls, pattern = "^Plot|^quickPlot::Plot")
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting.R:318:8:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting.R#L318) *style:* **Commented code should be removed.**
```r
      #dotObjs <- mget(dotNames[!noName], envir = plotFrame, inherits = TRUE)
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting.R:322:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/R/plotting.R#L322) *style:* **Lines should not be more than 100 characters.**
```r
        if (is.null(title)) plotArgs$title <- ifelse(nzchar(names(dotObjs2)), names(dotObjs2), dotNames)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-clickExtent.R:11:3:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-clickExtent.R#L11) *style:* **Variable or function name should be lowerCamelCase.**
```r
  Sr1 <- Polygon(coords1)
  ^~~
```
[tests/testthat/test-clickExtent.R:12:3:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-clickExtent.R#L12) *style:* **Variable or function name should be lowerCamelCase.**
```r
  Srs1 <- Polygons(list(Sr1), "s1")
  ^~~~
```
[tests/testthat/test-clickExtent.R:14:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-clickExtent.R#L14) *style:* **Lines should not be more than 100 characters.**
```r
  crs(shpEcozone) <- "+init=epsg:4326 +proj=longlat +datum=WGS84 +no_defs +ellps=WGS84 +towgs84=0,0,0"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-clickExtent.R:24:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-clickExtent.R#L24) *style:* **Lines should not be more than 100 characters.**
```r
  bb <- raster::shapefile(file.path(cacheRepo, "EC_borealdisturbance_polygonal_2008_2010_FINAL_ALBERS.shp"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-examples.R:11:15:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-examples.R#L11) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
    setwd(owd)}
              ^
```
[tests/testthat/test-Plot-do-call.R:8:3:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-Plot-do-call.R#L8) *style:* **Variable or function name should be lowerCamelCase.**
```r
  Sr1 <- Polygon(coords1)
  ^~~
```
[tests/testthat/test-Plot-do-call.R:9:3:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-Plot-do-call.R#L9) *style:* **Variable or function name should be lowerCamelCase.**
```r
  Srs1 <- Polygons(list(Sr1), "s1")
  ^~~~
```
[tests/testthat/test-Plot-do-call.R:11:1:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-Plot-do-call.R#L11) *style:* **Lines should not be more than 100 characters.**
```r
  crs(shpEcozone) <- "+init=epsg:4326 +proj=longlat +datum=WGS84 +no_defs +ellps=WGS84 +towgs84=0,0,0"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-Plot-do-call.R:13:24:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-Plot-do-call.R#L13) *style:* **Commas should always have a space after.**
```r
  r <- raster(extent(0,10,0,10), res = 1, vals = 1:100)
                       ^
```
[tests/testthat/test-Plot-do-call.R:13:27:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-Plot-do-call.R#L13) *style:* **Commas should always have a space after.**
```r
  r <- raster(extent(0,10,0,10), res = 1, vals = 1:100)
                          ^
```
[tests/testthat/test-Plot-do-call.R:13:29:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-Plot-do-call.R#L13) *style:* **Commas should always have a space after.**
```r
  r <- raster(extent(0,10,0,10), res = 1, vals = 1:100)
                            ^
```
[tests/testthat/test-Plot-nonVisual.R:65:21:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-Plot-nonVisual.R#L65) *style:* **Commented code should be removed.**
```r
  library(raster); #on.exit(detach("package:raster"), add = TRUE)
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-Plot-nonVisual.R:70:3:](https://github.com/PredictiveEcology/quickPlot/blob/3f24a85665b8da90b9bf1e3edf111e3d4376f74b/tests/testthat/test-Plot-nonVisual.R#L70) *style:* **Variable or function name should be lowerCamelCase.**
```r
  N <- ncol * nrow
  ^
```


IBM Cloud [toolchain](https://console.bluemix.net/devops/toolchains/f9266a68-10cc-4cf7-971b-d48224787d67?env_id=ibm%3Ayp%3Aus-south "cloud-native-toolchain-tutorial-20181105204014906"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/d0d2c159-b5f5-446f-8043-d5da6fbcfd46?env_id=ibm%3Ayp%3Aus-south "sample-cloud-native-toolchain-tutorial-20181105204014906") deployed [sample-cloud-native-toolchain-tutorial-20181105204014906](https://github.com/tcnt/sample-cloud-native-toolchain-tutorial-20181105204014906/releases/tag/deploy-ibm-yp-us-south-theo.thomas-nl.ibm.com-test-20181107-181245 "deploy-ibm-yp-us-south-theo.thomas-nl.ibm.com-test-20181107-181245") to [test](https://console.bluemix.net/apps/cf57bc82-b097-4cd8-b20c-b30416240527?env_id=ibm:yp:us-south "ibm:yp:us-south:theo.thomas@nl.ibm.com:test"), including this commit


Could you explain why is this needed, please?


ta malo


Why not continue using the `DEFAULT_TIMEOUT_IN_MS` constant?


@mppf note that I'm just copying https://github.com/google/re2/commit/c134b8e1f74#diff-72f6cb7f94e698e6598e02d2017b8fceR97 so we're not introducing features that weren't already being used.

I believe re2 only requires c++11 (and I think that's the newest we're currently comfortable requiring with how far HPC compilers lag) -- https://stackoverflow.com/questions/39487065/what-does-return-statement-mean-in-c11


This is the form I found to change the timeout on 'setTimeout' to all helper methods.


But given how often I have similar bit field optimizations in my code (not sure those actually are there but this is standard coding style for me), what may be inconsequential is to only avoid it here ... (-: ... have you ever experienced such a bit-field operation going wrong or is this a case of being overly careful ... ?


Created multidev environment [rescue-x#oct-18](https://dashboard.pantheon.io/sites/c8430b75-4272-4aca-bfcd-206b12279315#oct-18).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://oct-18-rescue-x.pantheonsite.io/)


Why did you delete all these? @agritron


@CP92 @TomG84 @tenmediatech


> sorry about the spurious commit, I didn't notice I was committing more than needed at once. Do you know how can I submit just Layer.cpp?

Git can do everything, but git can be very complicated.

- I would copy Layer.cpp to another folder
- Switch to master
- Create a new branch, based on master
- copy back the Layer.cpp
- commit and create a pull request from this branch


Because I need get the new timeout that the user pass on 'setTimeout', if he do it..


Этот комментарий нужно сделать перед самим методом


## Jenkins Build Summary

Built from [this commit](https://github.com/ximinez/rippled/commit/2a8b0e4b88ed03729506a758615c51b600717d38)

Built at __20181107 - 18:18:37__

### Test Results

Build Type | Log | Result | Status
---------- | --- | ------ | ------
msvc.Debug | [logfile](http://ci.ops.ripple.com/job/ed-rippled/job/develop/27//artifact/msvc.Debug.txt) | 1136 cases, 0 failed, t: 619s | PASS :white_check_mark:
gcc.Release
-Dassert=ON,
MANUAL_TESTS=true | [logfile](http://ci.ops.ripple.com/job/ed-rippled/job/develop/27//artifact/gcc.Release_Dassert_ON_MANUAL_TESTS_true.txt) | 915 cases, 0 failed, t: 6m3s | PASS :white_check_mark:
docs,
TARGET=docs | [logfile](http://ci.ops.ripple.com/job/ed-rippled/job/develop/27//artifact/docs_TARGET_docs.txt) | 1 cases, 0 failed, t: 0m1s | PASS :white_check_mark:
gcc.Debug
-Dcoverage=ON,
TARGET=coverage_report,
SKIP_TESTS=true | [logfile](http://ci.ops.ripple.com/job/ed-rippled/job/develop/27//artifact/gcc.Debug_Dcoverage_ON_TARGET_coverage_report_SKIP_TESTS_true.txt) | 1139 cases, 0 failed, t: 17m8s | PASS :white_check_mark:
clang.Debug | [logfile](http://ci.ops.ripple.com/job/ed-rippled/job/develop/27//artifact/clang.Debug.txt) | 1139 cases, 0 failed, t: 3m12s | PASS :white_check_mark:
msvc.Debug,
NINJA_BUILD=true | [logfile](http://ci.ops.ripple.com/job/ed-rippled/job/develop/27//artifact/msvc.Debug_NINJA_BUILD_true.txt) | 1136 cases, 0 failed, t: 644s | PASS :white_check_mark:
rpm | [logfile](http://ci.ops.ripple.com/job/ed-rippled/job/develop/27//artifact/rpm.txt) | 1139 cases, 0 failed, t: n/a | PASS :white_check_mark:
gcc.Debug | [logfile](http://ci.ops.ripple.com/job/ed-rippled/job/develop/27//artifact/gcc.Debug.txt) | 1139 cases, 0 failed, t: 3m27s | PASS :white_check_mark:
clang.Debug
-Dunity=OFF | [logfile](http://ci.ops.ripple.com/job/ed-rippled/job/develop/27//artifact/clang.Debug_Dunity_OFF.txt) | 1139 cases, 0 failed, t: 7m54s | PASS :white_check_mark:
gcc.Debug
-Dunity=OFF | [logfile](http://ci.ops.ripple.com/job/ed-rippled/job/develop/27//artifact/gcc.Debug_Dunity_OFF.txt) | 1139 cases, 0 failed, t: 0m44s | PASS :white_check_mark:
clang.Release
-Dassert=ON | [logfile](http://ci.ops.ripple.com/job/ed-rippled/job/develop/27//artifact/clang.Release_Dassert_ON.txt) | 1139 cases, 0 failed, t: 5m39s | PASS :white_check_mark:
gcc.Release
-Dassert=ON | [logfile](http://ci.ops.ripple.com/job/ed-rippled/job/develop/27//artifact/gcc.Release_Dassert_ON.txt) | 1139 cases, 0 failed, t: 6m3s | PASS :white_check_mark:
gcc.Debug
-Dstatic=OFF | [logfile](http://ci.ops.ripple.com/job/ed-rippled/job/develop/27//artifact/gcc.Debug_Dstatic_OFF.txt) | 1139 cases, 0 failed, t: 3m24s | PASS :white_check_mark:
gcc.Debug
-Dstatic=OFF -DBUILD_SHARED_LIBS=ON | [logfile](http://ci.ops.ripple.com/job/ed-rippled/job/develop/27//artifact/gcc.Debug_Dstatic_OFF_DBUILD_SHARED_LIBS_ON.txt) | 1139 cases, 0 failed, t: 3m25s | PASS :white_check_mark:
msvc.Debug
-Dunity=OFF | [logfile](http://ci.ops.ripple.com/job/ed-rippled/job/develop/27//artifact/msvc.Debug_Dunity_OFF.txt) | 1136 cases, 0 failed, t: 1277s | PASS :white_check_mark:
gcc.Debug,
NINJA_BUILD=true | [logfile](http://ci.ops.ripple.com/job/ed-rippled/job/develop/27//artifact/gcc.Debug_NINJA_BUILD_true.txt) | 1139 cases, 0 failed, t: 3m1s | PASS :white_check_mark:
msvc.Release | [logfile](http://ci.ops.ripple.com/job/ed-rippled/job/develop/27//artifact/msvc.Release.txt) | 1136 cases, 0 failed, t: 418s | PASS :white_check_mark:
clang.Debug
-Dunity=OFF -Dsan=address,
PARALLEL_TESTS=false,
DEBUGGER=false | [logfile](http://ci.ops.ripple.com/job/ed-rippled/job/develop/27//artifact/clang.Debug_Dunity_OFF_Dsan_address_PARALLEL_TESTS_false_DEBUGGER_false.txt) | 1139 cases, 0 failed, t: 1m8s | PASS :white_check_mark:
clang.Debug
-Dunity=OFF -Dsan=undefined,
PARALLEL_TESTS=false | [logfile](http://ci.ops.ripple.com/job/ed-rippled/job/develop/27//artifact/clang.Debug_Dunity_OFF_Dsan_undefined_PARALLEL_TESTS_false.txt) | 1139 cases, 0 failed, t: 4m43s | PASS :white_check_mark:


I think this adds unnecessary complexity. Could you provide a good argument for the need of it, please?


Pull request #21


Why do we have to specify .Value on the Birthdate?


Yeah it was a false positive. Oddly enough, only one of the variables were complained about but I decided to take care of all of them in case some other paranoid compiler had a slightly different view.


deleted file


Sure, thanks for clarifying.


I create that method only to give a option to the user to change timeout to all tests if he want.
Previously, if he want change timeout to all tests, he needed to pass the argument 'timeout' on all helper methods.


Shoot, I mispelled contributors in the commit title. Oh well.


i tried to upgrade the firmware to 1.65 from rfd tools but it gives me an error saying "cannot find rfd900x in the file"


[R/plotting-colours.R:89:1:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-colours.R#L89) *style:* **Lines should not be more than 100 characters.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-colours.R:89:32:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-colours.R#L89) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                              ~^~~
```
[R/plotting-colours.R:89:35:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-colours.R#L89) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                 ~^~~
```
[R/plotting-colours.R:89:41:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-colours.R#L89) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                        ^
```
[R/plotting-colours.R:106:1:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-colours.R#L106) *style:* **Lines should not be more than 100 characters.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-colours.R:106:32:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-colours.R#L106) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                              ~^~~
```
[R/plotting-colours.R:106:35:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-colours.R#L106) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                 ~^~~
```
[R/plotting-colours.R:106:41:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-colours.R#L106) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                        ^
```
[R/plotting-colours.R:131:1:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-colours.R#L131) *style:* **Lines should not be more than 100 characters.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-colours.R:131:32:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-colours.R#L131) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                              ~^~~
```
[R/plotting-colours.R:131:35:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-colours.R#L131) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                 ~^~~
```
[R/plotting-colours.R:131:41:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-colours.R#L131) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
      if (all(na.omit(object[])%%1==0)) { # some factor rasters are actually real number -- makes no sense
                                        ^
```
[R/plotting-colours.R:287:35:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-colours.R#L287) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(grobToPlot[]%%1)==0))
                                 ~^~~
```
[R/plotting-colours.R:287:39:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-colours.R#L287) *style:* **Put spaces around all infix operators.**
```r
      if (all(na.omit(grobToPlot[]%%1)==0))
                                     ~^~~
```
[R/plotting-helpers.R:1028:44:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L1028) *style:* **Commas should always have a space after.**
```r
          grobToPlot <- grobToPlot[polySeq,]
                                           ^
```
[R/plotting-helpers.R:1033:38:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L1033) *style:* **Commas should always have a space after.**
```r
        grobToPlot <- grobToPlot[a[1,],]
                                     ^
```
[R/plotting-helpers.R:1033:40:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L1033) *style:* **Commas should always have a space after.**
```r
        grobToPlot <- grobToPlot[a[1,],]
                                       ^
```
[R/plotting-helpers.R:1296:41:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L1296) *style:* **Put spaces around all infix operators.**
```r
            if (all(na.omit(grobToPlot[]%%1)==0)) {
                                       ~^~~
```
[R/plotting-helpers.R:1296:45:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L1296) *style:* **Put spaces around all infix operators.**
```r
            if (all(na.omit(grobToPlot[]%%1)==0)) {
                                           ~^~~
```
[R/plotting-helpers.R:1385:1:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L1385) *style:* **Lines should not be more than 100 characters.**
```r
    grid.rect(x = 0, height = unit(1 + needsNewTitle * inherits(grobToPlot, "Raster") * 0.20 / (nRows / 2), "npc"),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2516:1:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L2516) *style:* **Lines should not be more than 100 characters.**
```r
#'          jitter(sort(rbeta(nPoints, betaPar, betaPar) * (maxY - minY) + minY, decreasing = TRUE)),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2594:1:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L2594) *style:* **Variable or function name should be lowerCamelCase.**
```r
thin.SpatialPolygons <- function(x, tolerance = NULL, returnDataFrame = FALSE, minCoordsToThin = 0,
^~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2615:8:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L2615) *style:* **Commented code should be removed.**
```r
      #xyOrd[["out"]] <- xyOrd[["out"]][thinRes, ]# thin line
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2638:50:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L2638) *style:* **Commas should always have a space after.**
```r
            dat <- x@data[as.numeric(names1) + 1,]
                                                 ^
```
[R/plotting-helpers.R:2639:14:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L2639) *style:* **Commented code should be removed.**
```r
            #row.names(dat) <- as.character(seq_len(length(xyOrd)))
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2671:1:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L2671) *style:* **Variable or function name should be lowerCamelCase.**
```r
thin.default <- function(x, tolerance, returnDataFrame, minCoordsToThin, ...) {
^~~~~~~~~~~~
```
[R/plotting-helpers.R:2706:3:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L2706) *style:* **Variable or function name should be lowerCamelCase.**
```r
  IDs <- tryCatch(unlist(lapply(ordSeq, function(xx) {
  ^~~
```
[R/plotting-helpers.R:2731:7:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L2731) *style:* **Commented code should be removed.**
```r
    # Polygons <- rep(rep(seq(numPolygons), numPolygon), idLength$V1) # sequential numbering
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2732:5:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L2732) *style:* **Variable or function name should be lowerCamelCase.**
```r
    Polygons <- rep(rep(IDs, numPolygon), idLength$V1) # actual ID labelling
    ^~~~~~~~
```
[R/plotting-helpers.R:2733:5:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L2733) *style:* **Variable or function name should be lowerCamelCase.**
```r
    Polygon <- rep(unlist(lapply(numPolygon, seq)), idLength$V1)
    ^~~~~~~
```
[R/plotting-helpers.R:2740:36:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L2740) *style:* **Commas should always have a space after.**
```r
    return(data.frame(lat = xyOrd[,1], long = xyOrd[,2], order = orders,
                                   ^
```
[R/plotting-helpers.R:2740:54:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L2740) *style:* **Commas should always have a space after.**
```r
    return(data.frame(lat = xyOrd[,1], long = xyOrd[,2], order = orders,
                                                     ^
```
[R/plotting-helpers.R:2742:1:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L2742) *style:* **Lines should not be more than 100 characters.**
```r
                      #group = paste0(as.character(Polygons), ".", as.character(Polygon)))) # the actual fortify
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2745:40:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L2745) *style:* **Commas should always have a space after.**
```r
    out <- setDT(data.frame(x = xyOrd[,1], y = xyOrd[,2], groups = groups))
                                       ^
```
[R/plotting-helpers.R:2745:55:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L2745) *style:* **Commas should always have a space after.**
```r
    out <- setDT(data.frame(x = xyOrd[,1], y = xyOrd[,2], groups = groups))
                                                      ^
```
[R/plotting-helpers.R:2760:1:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L2760) *style:* **Lines should not be more than 100 characters.**
```r
    which(polygon@data$Shape_Area>(sort(polygon@data$Shape_Area, decreasing = TRUE)[maxNumPolygons]))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting-helpers.R:2760:34:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L2760) *style:* **Put spaces around all infix operators.**
```r
    which(polygon@data$Shape_Area>(sort(polygon@data$Shape_Area, decreasing = TRUE)[maxNumPolygons]))
                                ~^~
```
[R/plotting-helpers.R:2760:35:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L2760) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    which(polygon@data$Shape_Area>(sort(polygon@data$Shape_Area, decreasing = TRUE)[maxNumPolygons]))
                                  ^
```
[R/plotting-helpers.R:2783:26:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-helpers.R#L2783) *style:* **Commas should always have a space after.**
```r
          totalAvailable," polygons in this view. See options('quickPlot.maxNumPolygons')")
                         ^
```
[R/plotting-other.R:202:48:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-other.R#L202) *style:* **Put spaces around all infix operators.**
```r
  if (any(raster::is.factor(ras1)) & all(ras1[]%%1==0)) {
                                              ~^~~
```
[R/plotting-other.R:202:51:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-other.R#L202) *style:* **Put spaces around all infix operators.**
```r
  if (any(raster::is.factor(ras1)) & all(ras1[]%%1==0)) {
                                                 ~^~~
```
[R/plotting-other.R:251:30:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-other.R#L251) *style:* **Commas should always have a space after.**
```r
    if (sum(corners$coords[1,] - corners$coords[2,]) %==% 0) {
                             ^
```
[R/plotting-other.R:251:51:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-other.R#L251) *style:* **Commas should always have a space after.**
```r
    if (sum(corners$coords[1,] - corners$coords[2,]) %==% 0) {
                                                  ^
```
[R/plotting-other.R:335:27:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-other.R#L335) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
    if (length(row) == 0) { # above the plot
                          ^
```
[R/plotting-other.R:338:30:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-other.R#L338) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
    if (length(column) == 0) { # above the plot
                             ^
```
[R/plotting-other.R:511:46:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting-other.R#L511) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
  if (isTRUE("tools:rstudio" %in% search())) { # runing in Rstudio
                                             ^
```
[R/plotting.R:290:1:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting.R#L290) *style:* **Lines should not be more than 100 characters.**
```r
    isDoCall <- grepl("^do.call", scalls) & grepl("\\<Plot\\>", scalls) & !grepl("test_that", scalls)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting.R:308:6:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting.R#L308) *style:* **Commented code should be removed.**
```r
    #whFrame <- grep(scalls, pattern = "^Plot|^quickPlot::Plot")
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting.R:318:8:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting.R#L318) *style:* **Commented code should be removed.**
```r
      #dotObjs <- mget(dotNames[!noName], envir = plotFrame, inherits = TRUE)
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting.R:322:1:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/R/plotting.R#L322) *style:* **Lines should not be more than 100 characters.**
```r
        if (is.null(title)) plotArgs$title <- ifelse(nzchar(names(dotObjs2)), names(dotObjs2), dotNames)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-clickExtent.R:11:3:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/tests/testthat/test-clickExtent.R#L11) *style:* **Variable or function name should be lowerCamelCase.**
```r
  Sr1 <- Polygon(coords1)
  ^~~
```
[tests/testthat/test-clickExtent.R:12:3:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/tests/testthat/test-clickExtent.R#L12) *style:* **Variable or function name should be lowerCamelCase.**
```r
  Srs1 <- Polygons(list(Sr1), "s1")
  ^~~~
```
[tests/testthat/test-clickExtent.R:14:1:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/tests/testthat/test-clickExtent.R#L14) *style:* **Lines should not be more than 100 characters.**
```r
  crs(shpEcozone) <- "+init=epsg:4326 +proj=longlat +datum=WGS84 +no_defs +ellps=WGS84 +towgs84=0,0,0"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-clickExtent.R:24:1:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/tests/testthat/test-clickExtent.R#L24) *style:* **Lines should not be more than 100 characters.**
```r
  bb <- raster::shapefile(file.path(cacheRepo, "EC_borealdisturbance_polygonal_2008_2010_FINAL_ALBERS.shp"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-examples.R:11:15:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/tests/testthat/test-examples.R#L11) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
    setwd(owd)}
              ^
```
[tests/testthat/test-Plot-do-call.R:8:3:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/tests/testthat/test-Plot-do-call.R#L8) *style:* **Variable or function name should be lowerCamelCase.**
```r
  Sr1 <- Polygon(coords1)
  ^~~
```
[tests/testthat/test-Plot-do-call.R:9:3:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/tests/testthat/test-Plot-do-call.R#L9) *style:* **Variable or function name should be lowerCamelCase.**
```r
  Srs1 <- Polygons(list(Sr1), "s1")
  ^~~~
```
[tests/testthat/test-Plot-do-call.R:11:1:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/tests/testthat/test-Plot-do-call.R#L11) *style:* **Lines should not be more than 100 characters.**
```r
  crs(shpEcozone) <- "+init=epsg:4326 +proj=longlat +datum=WGS84 +no_defs +ellps=WGS84 +towgs84=0,0,0"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-Plot-do-call.R:13:24:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/tests/testthat/test-Plot-do-call.R#L13) *style:* **Commas should always have a space after.**
```r
  r <- raster(extent(0,10,0,10), res = 1, vals = 1:100)
                       ^
```
[tests/testthat/test-Plot-do-call.R:13:27:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/tests/testthat/test-Plot-do-call.R#L13) *style:* **Commas should always have a space after.**
```r
  r <- raster(extent(0,10,0,10), res = 1, vals = 1:100)
                          ^
```
[tests/testthat/test-Plot-do-call.R:13:29:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/tests/testthat/test-Plot-do-call.R#L13) *style:* **Commas should always have a space after.**
```r
  r <- raster(extent(0,10,0,10), res = 1, vals = 1:100)
                            ^
```
[tests/testthat/test-Plot-nonVisual.R:65:21:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/tests/testthat/test-Plot-nonVisual.R#L65) *style:* **Commented code should be removed.**
```r
  library(raster); #on.exit(detach("package:raster"), add = TRUE)
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-Plot-nonVisual.R:70:3:](https://github.com/PredictiveEcology/quickPlot/blob/3eec6ef8d417ffdd64f9d464ad11c028a121c203/tests/testthat/test-Plot-nonVisual.R#L70) *style:* **Variable or function name should be lowerCamelCase.**
```r
  N <- ncol * nrow
  ^
```


Not sure what `nbe` is used for in `update_counter()`.
In the same function, rename the `set` variable (maybe to `_set`? idk) because it is a reserved keyword.

Not sure why you have so many misses though. I'll try to debug.


Hi, i used your multi slave example and got 3 esps transferring string data to one esp32. However as i am new to esp32 and programming I am unable to do one thing and that is to to save transfered data into an array. I get four differnt sensor data from  one sender so three senders send 12 data and I want to take an average of each sensor. So i get temp, humidity, moisture and pH from each sender and i want to take average of temp and then humidity. Can you help by sending me an example of how it can be done. I will be grateful.


I didnt intentionally, I dont know if that happened when I wrecked the
program and had to cut and paste from an old file to get it to run again.
Have you put them back in ?

On Wed, Nov 7, 2018 at 1:16 PM Adam Clarkson <notifications@github.com>
wrote:

> Why did you delete all these? @agritron <https://github.com/agritron>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/ATC-Industries/hotspotPrinter/commit/e6b19fd998e19c4b8396d310a61e44da1e2412e0#commitcomment-31210770>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ANP_oHZMG59cNZMOkqzGv75reBAMvW8Rks5usyNtgaJpZM4YS91L>
> .
>


@morrolinux
I saw you did already some useful development on Xournal++, which is not merged back to this repo, right? I think it would may make sense to merge it back to this repo.

Currently I'm merging GTK3 and Master branch, but after we may merge?

ps. yes I know this is offtopic, but I don't know how to contact you...


@darkmorpher see https://forums.lanik.us/viewtopic.php?p=92348#p92348


Reverted


Thanks, Mike! Very much appreciate the help. Will check these out - tricky. :)


Why was this deleted? Was there a previous discussion on Github that I missed? (might well have been the case, I don't know)


Questi controlli possono essere integrati nell'apposito metodo *setCodiceDestinatarioAttribute* della classe **Anagrafica**.


Great, @vak2ve!  Are you ready for me to go into q4 and review a sample of dates?


@andreasb242 Thanks for the hint, I'm working on getting it done :)
As for the "useful developement" I'm glad you like it, I have yet to clean up few things, but yeah after your merge that'd be great :)
You can reach me at morrolinux on my gmail account!


This doesn't do what I think you think it does. The new form opens on line 174, and this method doesn't continue until that one closes. This form isn't released until the other form closes. So clicking back and forth between the two forms still builds up more and more copies of each form. Once one is closed instead of clicking to go back to the other calc type, all of them would be released. So this is an improvement, but doesn't fix the original problem.


DelegateTaskFake, DelegateExecutionFake, DelegateCaseExecutionFake


Possible leak of m_cancel


Added depression. Removed veterans and eln.


haha man


### Loreum Ipsom

Really? Isnt there a *better* way?


Created multidev environment [ci-example-d8-composer#ci-1481](https://dashboard.pantheon.io/sites/c401fd14-f745-4e51-9af2-f30b45146a0c#ci-1481).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-1481-ci-example-d8-composer.pantheonsite.io/)


Very good gegy! After this I will test how rifts work in vanilla and modded dimension after then


In the early days of LASlib / LASzip the 3 legacy flags and the 5 bit classification were declared as a single unsigned char in the LASpoint struct and written / read via bit shift operations. I assume this was safer?


dedö


Disregard - this is a short living object which gets destroyed by the caller when going out of scope. But someone would call this method twice on the same object and would fail to create the session twice too - it would leak/overwrite one instance of m_cancel.
I‘d rather do a release and null on the beginning of that method to ensure only single instances are created/allocated.


Are you sure your code is even correct?

```
#include <iostream>
#include <cstdint>

struct bf
{
    uint8_t big : 5;
    uint8_t f1 : 1;
    uint8_t f2 : 1;
    uint8_t f3 : 1;
};

int main()
{
    uint8_t f = 1;
    bf s;

    memcpy(&s, &f, sizeof(uint8_t));
    std::cerr << "Big/f1/f2/f3 = " <<
        (int)s.big << "/" <<
        (int)s.f1 << "/" <<
        (int)s.f2 << "/" <<
        (int)s.f3 << "!\n";
}
```
```
(pdal) $ g++ -std=c++11 test24.cpp
(pdal) $ a.out
Big/f1/f2/f3 = 1/0/0/0!
```
Is this what you were expecting?


email me so we can work this out
therealrandomblock1@gmail.com


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


You're going from `void` to `self`. Technically those types are invariant which should never be legal. In this particular case it's not dangerous but every other type of invariance is. Since, as you mentioned, PHP does not support covariance/contravariance right now other than dropping the type completely (`mixed`) this should not be an issue since the `TypehintHelper::decideType` already chooses the more specified type.

I think the correct fix would've been to not inherit the phpDoc return type if it is `void` and a native return type is specified. WDYT?


So basically the Ctor code into a cleanup method which gets called at the beginning of that method


resolved


bien


Any explanation for this undocumented, breaking change?  It prevents modifying the message body within the withSwiftMessage callback.


I guess what you're doing matches this (it's not what I would have expected).  But it is only guaranteed on a compiler that comforms to the x86_64 ABI.

Yes, doing masks of chars is safe.


Just a note- the original value is a good use case for [example.com](http://example.com/) (`not-used.net` is available for public purchase)


Sorry meant to PR this...


yaaay :-)


I arranged them so that we had 50% of requests to 'classify_client' and then the rest evenly split


I have originally added these additional hashtags in order to prevent Velocity from outputting extra blank line at the beginning of the HTML file.
One additional way to do this is to use ## comment style for the whole header.


Funcionando ADC/Potenciómetro, UART, Sensor


Like I said in the BugZilla ticket, we can go with just the bare minimum of checks as part of the tests. I did not think it would add a lot of overhead to the tests in order to do so.


Why don't all prpls get a storage backend?


TeamCity ImageHunt / Build Branch [Build 99](http://51.255.204.38:8111/viewLog.html?buildId=234&buildTypeId=ImageHunt_BuildBanch) is now running


Will update to be "with-slash"


Why isn't the fallback/else set to display the input by default?


I can definitely assist in creating the "correctness" version of these tests and focus on these being just load-generating ones.


@martiniil as a followup. Bloom 0.6.8 has been released which includes initial support for v4 index files. Please give it a whirl and report any issues to https://github.com/ros-infrastructure/bloom/issues. Thanks!


Will remove this end point from the load test


Very good! Doesn’t really fix poison pots but witches are scarce and personal poison pots are kinda hard to get and few have them on hand at all times


Will remove this endpoint from the load test


Created multidev environment [pantheon-d8-composer-project-test-bomhof#ci-2](https://dashboard.pantheon.io/sites/df159ff1-c9f6-4ecd-8e9f-3f3a64b1bf33#ci-2).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-2-pantheon-d8-composer-project-test-bomhof.pantheonsite.io/)


VERY nice!


great use of low-level defineproperty


lkp;


This current f18 driver program is temporary scaffolding code.  The -Mx option will, of course, not be present in the actual f18 driver program.

Please consider using some means other than commenting on 8-month old commits to communicate potential problems.


@kstenerud Thanks!


Upload


TeamCity ImageHunt / Build Branch [Build 99](http://51.255.204.38:8111/viewLog.html?buildId=234&buildTypeId=ImageHunt_BuildBanch) outcome was **SUCCESS**
Summary: Tests passed: 377 Build time: 00:03:49


This added line broke connection and I get a bunch of errors when trying to go to LCD4linux-settings from OpenWebif.
Removed that line locally, and now the page opens.


Also as an afterthought, maybe you could make players have mining fatigue from stunned and remove their ability to place blocks while stunned, although your vision is slightly impaired due to being on the floor but you can still place and break blocks


You forgot me ;(


A ver que te parece mi versión sin probar, ignóra el pull request y usa mi fork para ver las diferencias si te resulta mas sencillo,


Successfully aliased the URL <https://webzuerich-lwoiypoiuw.now.sh> to the following alias.

* https://webzueri.ch


I downloaded the housing.csv file and I opened it with Excel. There must be a problem or a mistake .. it isn't a data file at all. Can someone check it out and get back to me at pmcauchi@gmail.com. It is an HTML file... am I looking. I downloaded 2108-11-07. Thanks Peter


This is exactly how I have been using bit fields since the early days of LASlib. If that assumption is violated on any common compiler I should have run into that problem before as there are several other places where I have been using bit fields and accessed them as in the latest commit. I now see the rationale for changing that systematically all across the library in the near future but until then we may just leave this additional instance as is ...


--Sign in file was also added with this commit. It has basic functionality for a form


IBM Cloud [toolchain](https://console.bluemix.net/devops/toolchains/f9266a68-10cc-4cf7-971b-d48224787d67?env_id=ibm%3Ayp%3Aus-south "cloud-native-toolchain-tutorial-20181105204014906"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/d0d2c159-b5f5-446f-8043-d5da6fbcfd46?env_id=ibm%3Ayp%3Aus-south "sample-cloud-native-toolchain-tutorial-20181105204014906") deployed [sample-cloud-native-toolchain-tutorial-20181105204014906](https://github.com/tcnt/sample-cloud-native-toolchain-tutorial-20181105204014906/releases/tag/deploy-ibm-yp-us-south-theo.thomas-nl.ibm.com-test-20181107-185338 "deploy-ibm-yp-us-south-theo.thomas-nl.ibm.com-test-20181107-185338") to [test](https://console.bluemix.net/apps/cf57bc82-b097-4cd8-b20c-b30416240527?env_id=ibm:yp:us-south "ibm:yp:us-south:theo.thomas@nl.ibm.com:test"), including this commit


it seems as if this commit is breaking things for my project that is using typescript, I'm getting:
/Users/zoe/workspace/ARM/repomgr-client/node_modules/antd/lib/layout/Sider.d.ts
(58,30): Cannot find name 'MediaQueryListEvent'.


Hey @tr00tr , Could you send me an email update? luisotaviocintra@gmail.com


afecoi-fix (Myoldmopar) - x86_64-Linux-Ubuntu-18.04-gcc-7.3-UnitTestsCoverage-Debug: OK (1774 of 1774 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-41.57%25-green.png)


Можно короче сделать:
if equ
 puts "Ваш треугольник - равносторонний."
elsif right && iso
  puts "Ваш треугольник - прямоугольный и равнобедренный."
elsif right
 puts "Ваш треугольник - прямоугольный."
else
 puts "Ваш треугольник - не прямоугольный, не равносторонний."
end


ny linje 1


ny linje 2


What about other invariant combinations? Like string in the parent and int in the child? It's often a fix for a bug in parent documentation, that's how people use it :)


@ondrejmirtes Can you provide a code example?


fixed


![](https://github.trello.services/images/mini-trello-icon.png) [(0/2)Interface gráfica/User - parte Gmail](https://trello.com/c/mRnnOwCr/23-0-2interface-gr%C3%A1fica-user-parte-gmail)


If your code were built for an ARM processor, it wouldn't work: http://www.keil.com/support/man/docs/armcc/armcc_chr1360774870320.htm


bra jobbat


IBM Cloud [toolchain](https://console.bluemix.net/devops/toolchains/fe1baa71-ac53-48f2-ab96-b9cbe959c558?env_id=ibm%3Ayp%3Aus-south "pmanagerd"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/90ba99be-1715-41c2-8c01-255ff1bc440a?env_id=ibm%3Ayp%3Aus-south "Pipeline") deployed [pmanager-server](https://github.com/momantai/pmanager-server/releases/tag/deploy-ibm-yp-us-south-alexis.luna-alumnos.udg.mx-dev-20181107-185923 "deploy-ibm-yp-us-south-alexis.luna-alumnos.udg.mx-dev-20181107-185923") to [dev](https://console.bluemix.net/apps/cdc00157-f6c6-4b7d-9c50-e368e08354de?env_id=ibm:yp:us-south "ibm:yp:us-south:alexis.luna@alumnos.udg.mx:dev"), including this commit


for anywone interested, it does not solve #6 but #37
I don't know what came through my mind to come up with the number 6 !


Here should be: `if (reading_opts && param~~/^-.+/) {`

I know. Whistespace bites at first. :)


there is *not* much of a difference


Python class constructors MUST take `self` as the first argument.

Furthermore, what is `halfling` ? It is an argument into the constructor... but it's not used, nor is it clear what it is intended to be.


n


Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

- @mcflugen was added to this feedstock maintenance team.

You should get push access to this feedstock and CI services.

Feel free to join the community [chat room](https://gitter.im/conda-forge/conda-forge.github.io).

NOTE: Please make sure to not push to the repository directly.
      Use branches in your fork for any changes and send a PR.
      More details [here](https://conda-forge.org/docs/conda-forge_gotchas.html#using-a-fork-vs-a-branch-when-updating-a-recipe)


IBM Cloud [toolchain](https://console.bluemix.net/devops/toolchains/f9266a68-10cc-4cf7-971b-d48224787d67?env_id=ibm%3Ayp%3Aus-south "cloud-native-toolchain-tutorial-20181105204014906"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/d0d2c159-b5f5-446f-8043-d5da6fbcfd46?env_id=ibm%3Ayp%3Aus-south "sample-cloud-native-toolchain-tutorial-20181105204014906") deployed [sample-cloud-native-toolchain-tutorial-20181105204014906](https://github.com/tcnt/sample-cloud-native-toolchain-tutorial-20181105204014906/releases/tag/deploy-ibm-yp-us-south-theo.thomas-nl.ibm.com-test-20181107-190105 "deploy-ibm-yp-us-south-theo.thomas-nl.ibm.com-test-20181107-190105") to [test](https://console.bluemix.net/apps/cf57bc82-b097-4cd8-b20c-b30416240527?env_id=ibm:yp:us-south "ibm:yp:us-south:theo.thomas@nl.ibm.com:test"), including this commit


please reformat the code


Некоторые проверки можно убрать:
```
if equ
  puts "Ваш треугольник - равносторонний."
elsif right && iso
  puts "Ваш треугольник - прямоугольный и равнобедренный."
elsif right
  puts "Ваш треугольник - прямоугольный."
elsif iso
  puts "Ваш треугольник - не прямоугольный, зато равнобедренный."
else
  puts "Ваш треугольник не прямоугольный, не равнобедренный"
end
```


Лучше использовать одинарные кавычки для строк, если нет интерполяции


>>Лучше вложенный хеш разбить на 2 значения, с ключами :price и :quentity, то есть не использовать вводимые юзером значения как ключи.
Вот этот момент мне не понятен.
Мой вариант учитывает, что может быть один и тот же товар, но по разным ценам (старый привоз по одной цене и новый привоз по другой цене). если же сделать "разбить на 2 значения, с ключами :price и :quentity", то это означает что один и тот же товар может быть только по одной цене и не получится учесть один и тот же товар с разными ценами. Или я что-то не понимаю и это возможно?


Here `param_parts[0, 1]` is already a list.

This is also possible to simply as:

```ruby
if (param =~ self.opt_long_re) { |param_parts|
   var (opt_name, value) = param_parts[0, 1]
   #...
}
```

Notice that a Match object can also be used as an Array to access its captures.


Created multidev environment [rescue-x#oct-18](https://dashboard.pantheon.io/sites/c8430b75-4272-4aca-bfcd-206b12279315#oct-18).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://oct-18-rescue-x.pantheonsite.io/)


nn


Please see commit d2962c6c0185c66f3e0e7f1d4663b88686ff6f2e in the master - I’ve added new item into list of grids/lines/points.


We need to present different UI for auth requests and text input requests at least, is there any way to handle it in generic way?


dfg


You are calling the `getMod()` method of the `score` object, except you haven't actually defined a `score` object.

Somewhere in the constructor, you need to execute:
```
this.stats = Chr_stat()
```

And then you can access the following:
```
dex_score = this.stats.attributes['DEX'].score
dex_mod = this.stats.getMod('DEX')

# etc
```


The `arm_dev` flag should be killed asap in favor of automated `kha_version` define, so it 'just works'. :) (But in the meantime defining `arm_dev` should also do.)


well done !


Mmm intredasting


So I wrote most of this code a little over a week ago, I don't remember EXACTLY every line but the gist of it- Supply a JSON of the slots with any skin attachment names that are the slots child. As of now I can't figure out a way to figure this out from the spineData or any of the json a spine project will produce, so for the time being it must be done yourself.


Closes #1


return by copy ?


i change the fix now only use with 4.3 branch


Created multidev environment [ilsoy#ci-115](https://dashboard.pantheon.io/sites/1b49470e-4ad3-4b49-90a2-7bb2c2f96788#ci-115).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-115-ilsoy.pantheonsite.io/)


This is partly my fault -- we'll have to fix these import statements.

But what this line _should_ be telling Python is: from this current module (directory), there is a file called chr_stat.py, and we should import the Chr_stat class from that file.


That was the old feature promising to "not store any data/password" in the days of password-based transports :) Sure we need to store tokens now


Got it - thanks for clarifying! Yes, that works too


Give me another few min to commit some global changes to the batch and then I will be! Thanks so much!


Starting to try to get content into columns but am stuck on why the 2 columns below the main will not wrap....urg


@vak2ve, take your time.  Just @ me when it's safe.  =)


Notice yourself repeating the same code over and over? Good signal to convert it to a function in the next iteration.
OR, take a close look at the purpose behind what you're doing.

In this case, the only reason you're doing all this work in this block of code is because you want to be able to get the ability scores from the Race class later on, like:
```
# Assuming we've created an instance of the Race class and named it r:
my_strength_score = r.getScore('STR')
```

So, you would create a class method in Race called `getScore()`:
```
def getScore(self, attribute):
  return this.stats.attributes[attribute]
```