Best to explain this with an example. Let's load two files:
```r
library(MSnbase)
library(BiocParallel)
register(SerialParam())

library(msdata)
fls <- dir(system.file("sciex", package = "msdata"), full.names = TRUE)
od <- readMSData(fls, mode = "onDisk")
h5 <- readHdf5DiskMSData(fls)
```

Subsetting and extraction works as long as we access the first file:

```r
h5[[4]]
Object of class "Spectrum1"
 Retention time: 0:1
 MSn level: 1
 Total ion count: 1664
 Polarity: 1

h5[4][[1]]
Object of class "Spectrum1"
 Retention time: 0:1
 MSn level: 1
 Total ion count: 1664
 Polarity: 1
```

But breaks if we subset to data from a file > 1:

```r
h5_2 <- filterFile(h5, 2)
h5_2[[3]]
Error in rhdf5::h5read(x@hdf5handle, k) :
  Object '1/F2.S003' does not exist in this HDF5 file.

head(fData(h5_2)$fileIdx)
[1] 1 1 1 1 1 1
```

You see, subsetting correctly updated the `fileIdx` column in `featureData` because the subsetted object contains only metadata for spectra from the second file. The respective spectrum data is stored in the HDF5 however with index `2`, because it was from the second file that was read in.

Subsetting (because it used the `[,OnDiskMSnExp` did **not** change/update the content of the hdf5 file (which I think is also OK because that would just slow down things). I would even suggest to have lazy evaluation on all data manipulation operations (as we do have it in `OnDiskMSnExp` objects), i.e. apply data manipulations on-the-fly, and implement a `consolidate` function/method that writes any changes to the hdf5 - but that's another discussion.

So, if we use the file index instead of the file name we run into these problems above on any operation that uses `[` for subsetting (also `filterFile` does that). If we used the file name instead we wouldn't have this problem, as the file name is correctly set by the `[` (obviously, otherwise the `OnDiskMSnExp` would not work at all because that needs to read from the original file).

```r
basename(fileNames(h5))
[1] "20171016_POOL_POS_1_105-134.mzML" "20171016_POOL_POS_3_105-134.mzML"

basename(fileNames(h5_2))
[1] "20171016_POOL_POS_3_105-134.mzML"
```

So that's why I proposed to use the file name instead as hdf5 group name. And based on your concerns with white spaces, weird characters etc, the sha1 of the (full) file name.


private


Dear @dineshbs7 I am afraid, I don't understand your question. Could you open an independent issue where you explain your specific problem, what you are trying to do, what data you are talking about, etc. Thanks !


shallowCopy i deepCopy powinny być testowane w osobnych metodach


Deployment failed with the following error:

~~~
The property `type` is not allowed in now.json when using Now 2.0 – please remove it.
~~~


Does the exception include the topic name in it?

I'm not sure there is value in the "Please see below for further details" in the log message?


I'm pulling about 35 H/s on a mid-2015 MacBook Pro using the WMP docker setup on a lightweight VPS. Thoughts on recompiling under the new mono version to eek out more?


Ok


Rebasing commit to `master` to `polymer1.0` branch.


@davidhenley mainly because of convenience. The enum was introduced to make sure that there's a single place where all message-types are defined. But the problem with that approach is that with every event or command you want to add, you need to update de _Infrastructure.Messaging_ package and push a new version to the nuget feed. When using strings, you can just introduce a new message-type without this need. So I gave up a some "governance" in favor of efficiency and productivity.


Successfully aliased the URL <https://vital-ui-react-jfhgtwjdtx.now.sh> to the following aliases.

* https://vital-ui-react.now.sh
* https://react.vitaluikit.com


oh, and i almost forgot
_takes a chainsaw to the `MIN_FOLLOWERS_DISCOVERY` variable_

**I SAWED THIS VARIABLE IN HALF!**


Successfully aliased the URL <https://pebble-wnhcwwwvxd.now.sh> to the following alias.

* https://pebble.now.sh


Aw gee - screwed up on the Decimal thing.  Sorry - put that in just so I could test and meant to remove it but I guess I forgot. Right now the whole number keypad thing is goofy.  Home/End don't work either because the numpad isn't working correctly.  Anyway, I apologize.  If you'd like me to clear it up I'd be happy to.


adsf


Who made this change


Before the update


Puzzle `SE619-2b30c42e` discovered in   [`tests/ecommerce/tests_views.py`](  https://github.com/fidals/refarm-site/blob/master/tests/ecommerce/tests_views.py)   and submitted as #228. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


Puzzle `SE619-a95dbe3f` discovered in   [`tests/ecommerce/tests_views.py`](  https://github.com/fidals/refarm-site/blob/master/tests/ecommerce/tests_views.py)   and submitted as #229. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


Puzzle `SE619-5f380a04` discovered in   [`pages/models.py`](  https://github.com/fidals/refarm-site/blob/master/pages/models.py)   and submitted as #230. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


write github


aaa


sss


@noobpwnftw I apologize for contacting you via a GitHub mention, but I don't know any more direct means.  Did you mean to disconnect your workers from fishtest?  They're all down.

(Obviously, if you meant to disconnect them, that's OK.  It just seemed unusual, so I thought I would let you know in case there was an issue.)


Please release it as soon as possible.


Dear @A354-PH,
> I regret to inform you that your plugin "**CustomWhitelistReason**" (v1.0.4 submitted on 2018-12-20T06:34:18.000Z) has been rejected.

B1b — No redundant API versions:
> Plugins must not list **redundant** API versions in the plugin.yml. Only the earliest supported API in each major version needs to be listed, e.g. `3.2.0` is not necessary if `3.1.0` is already listed.

Please resolve these issues and submit the plugin again.

> This comment is posted here because this is the last commit when the released build was created.


delete


I wasn't able to retrieve PDD puzzles from the code base and submit them to GitHub. If you think that it's a bug on our side, please submit it to [yegor256/0pdd](https://github.com/yegor256/0pdd/issues):

> set -x && set -e && set -o pipefail && cd /tmp/0pdd20181219-4-123l06u/fidals/refarm-site && git config --local core.autocrlf false && git reset origin/master --hard --quiet && git clean --force -d && git fetch --quiet && git checkout master && git rebase --abort || true && git rebase --autostash...

Please, copy and paste this stack trace to GitHub:

```
Exec::Error
set -x && set -e && set -o pipefail && cd /tmp/0pdd20181219-4-123l06u/fidals/refarm-site && git config --local core.autocrlf false && git reset origin/master --hard --quiet && git clean --force -d && git fetch --quiet && git checkout master && git rebase --abort || true && git rebase --autostash --strategy-option=theirs origin/master [1]:
bash: warning: setlocale: LC_ALL: cannot change locale (UTF-8)
+ set -e
+ set -o pipefail
+ cd /tmp/0pdd20181219-4-123l06u/fidals/refarm-site
+ git config --local core.autocrlf false
+ git reset origin/master --hard --quiet
+ git clean --force -d
+ git fetch --quiet
+ git checkout master
Already on 'master'
+ git rebase --abort
No rebase in progress?
+ true
+ git rebase --autostash --strategy-option=theirs origin/master
fatal: Could not parse object '04e279e040811024b8721d8299875df46a00b6fa^'
Unknown exit code (128) from command: git-merge-recursive 04e279e040811024b8721d8299875df46a00b6fa^ -- HEAD 04e279e040811024b8721d8299875df46a00b6fa

Your branch and 'origin/master' have diverged,
and have 1 and 162 different commits each, respectively.
  (use "git pull" to merge the remote branch into yours)
First, rewinding head to replay your work on top of it...

/app/objects/exec.rb:60:in `block (2 levels) in run'
/app/vendor/ruby-2.5.1/lib/ruby/2.5.0/open3.rb:205:in `popen_run'
/app/vendor/ruby-2.5.1/lib/ruby/2.5.0/open3.rb:95:in `popen3'
/app/objects/exec.rb:54:in `block in run'
/app/vendor/ruby-2.5.1/lib/ruby/2.5.0/timeout.rb:93:in `block in timeout'
/app/vendor/ruby-2.5.1/lib/ruby/2.5.0/timeout.rb:33:in `block in catch'
/app/vendor/ruby-2.5.1/lib/ruby/2.5.0/timeout.rb:33:in `catch'
/app/vendor/ruby-2.5.1/lib/ruby/2.5.0/timeout.rb:33:in `catch'
/app/vendor/ruby-2.5.1/lib/ruby/2.5.0/timeout.rb:108:in `timeout'
/app/objects/exec.rb:53:in `run'
/app/objects/git_repo.rb:110:in `pull'
/app/objects/git_repo.rb:75:in `push'
/app/objects/job.rb:36:in `proceed'
/app/objects/job_starred.rb:33:in `proceed'
/app/objects/job_recorded.rb:32:in `proceed'
/app/objects/job_emailed.rb:35:in `proceed'
/app/objects/job_commiterrors.rb:36:in `proceed'
/app/objects/job_detached.rb:48:in `exclusive'
/app/objects/job_detached.rb:36:in `block in proceed'
/app/objects/job_detached.rb:36:in `fork'
/app/objects/job_detached.rb:36:in `proceed'
/app/0pdd.rb:354:in `block in <top (required)>'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1635:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1635:in `block in compile!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:992:in `block (3 levels) in route!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1011:in `route_eval'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:992:in `block (2 levels) in route!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1040:in `block in process_route'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1038:in `catch'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1038:in `process_route'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:990:in `block in route!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:989:in `each'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:989:in `route!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1097:in `block in dispatch!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `block in invoke'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `catch'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `invoke'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1094:in `dispatch!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:924:in `block in call!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `block in invoke'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `catch'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `invoke'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:924:in `call!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:913:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-protection-2.0.4/lib/rack/protection/xss_header.rb:18:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-protection-2.0.4/lib/rack/protection/path_traversal.rb:16:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-protection-2.0.4/lib/rack/protection/json_csrf.rb:26:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-protection-2.0.4/lib/rack/protection/base.rb:50:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-protection-2.0.4/lib/rack/protection/base.rb:50:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-protection-2.0.4/lib/rack/protection/frame_options.rb:31:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.6/lib/rack/logger.rb:15:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.6/lib/rack/common_logger.rb:33:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:231:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:224:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.6/lib/rack/head.rb:12:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.6/lib/rack/method_override.rb:22:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:194:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1957:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1502:in `block in call'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1729:in `synchronize'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1502:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.6/lib/rack/handler/webrick.rb:86:in `service'
/app/vendor/ruby-2.5.1/lib/ruby/2.5.0/webrick/httpserver.rb:140:in `service'
/app/vendor/ruby-2.5.1/lib/ruby/2.5.0/webrick/httpserver.rb:96:in `run'
/app/vendor/ruby-2.5.1/lib/ruby/2.5.0/webrick/server.rb:307:in `block in start_thread'
```


Can we have proper method, cause it looks to me weird having properties for logger? What's with levels of logging ? info, error and warning ? I understand from our discussion that you agree we should have something like that.


Successfully aliased the URL <https://hackathon2018-team1-ecrzrc7ji.now.sh> to the following alias.

* https://hackathon2018-team1.now.sh


try recursive and iteration both ways to travel  tree


Shouldn't be that configurable? 🙄


Works like a charm, thanks!


Successfully aliased the URL <https://valde-tgfczqjsqi.now.sh> to the following alias.

* https://valde.caurea.org


Two more reasons why it should be a method:
- Your property implies that you are overriding something in the logger, instead of adding. The idea of logging is adding something to some file
- Method can have two arguments. One is message, second one is token which simplify injecting something inside string.


That's clear now, thank you. So yes, I think using a file name (sha1 for example) is the best way forward then.
- I am ignoring all the *udpate-on-write* issues for now - let's tackle these once we have a working prototype, and when we think about processing
- Let's also not forget about `BiocFileCache`.
Thank you!


My proposition is:
[Info] Conversion started: 12/20/2018 08:11 AM
[Info] Arguments:


Successfully aliased the URL <https://personal-website-qfcit54sp.now.sh> to the following alias.

* https://anthony.codes


Successfully aliased the URL <https://karbon14-demo-envbjzeruz.now.sh> to the following alias.

* https://karbon14-demo.now.sh


Use filter_var($string, FILTER_VALIDATE_URL) to validate a tag has contain link or not


Changed one, added one, they're named the exact same way as the old one.


Successfully aliased the URL <https://domain-redirects-7knm29yhx.now.sh> to the following aliases.

* https://www.anthony.codes
* https://thedebug.life
* https://www.thedebug.life
* https://anthony.app
* https://www.anthony.app


You don't need that information cause earlier you printed out arguments - it doesn't make sense duplicate information.


Was looking at a ZC 1.5.5 site then a 1.5.6 site and noticed that after adding a new product to the test examples category that one of the indicators didn't look right.  Realized that the linked product indicator had been moved to the left of the status indicator.  What is the background/driving force on making that move? It looks like the move was made in this particular commit.


От перемены мест слагаемых сумма не меняется. Если только магия не произойдёт..

У нас на OpenXRay тоже вылетает. Этот вылет откуда-то из Зова Чернобыля пришёл..
Надо искать, надо искать решение..


[warning] No arguments found


What about disjoined/overlapped `Slices`?


`xEventGroupWaitBits(wifi_event_group, bits, false, \
false, \
portMAX_DELAY);`

IPV4和IPV6不会都有效，该参数必须为false，否则将卡死
IPV4 and IPV6 will not be valid. This parameter must be false, otherwise it will be stuck.


Successfully aliased the URL <https://an-2cbyka1h8.now.sh> to the following alias.

* https://an.now.sh


Hm fair enough. I guess a black-list config would be best so we don't accidentally forget it and ddos their api at some point?


I have no idea after first look what you are saying here.
[error] Missing parameters. Expected are ....


Don't worry, they will be back.
I'm doing some OS upgrades(in case of holiday happens and nobody is around when something go south).


![](https://github.trello.services/images/mini-trello-icon.png) [48 - Ürün Detayına Yorumların Çekilmesi](https://trello.com/c/bmQt8iBO/48-48-%C3%BCr%C3%BCn-detay%C4%B1na-yorumlar%C4%B1n-%C3%A7ekilmesi)


![](https://github.trello.services/images/mini-trello-icon.png) [06 - Üye Kayıt](https://trello.com/c/HdGHxk57/6-06-%C3%BCye-kay%C4%B1t)


![](https://github.trello.services/images/mini-trello-icon.png) [05 - Kayıt Formu](https://trello.com/c/ZrOfV1NY/5-05-kay%C4%B1t-formu)


TeamCity ImageHunt / Build Branch [Build 145](http://51.255.204.38:8111/viewLog.html?buildId=406&buildTypeId=ImageHunt_BuildBanch) is now running


![](https://github.trello.services/images/mini-trello-icon.png) [01 - Önyüz Template Oluşturma](https://trello.com/c/tvlxphKt/1-01-%C3%B6ny%C3%BCz-template-olu%C5%9Fturma)


[info] Converting data from file: path if it's possible


Rename this listener to `onConversionCompleted`


Just noticed I forgot to copy the sign


Some test failure are unrelated:

* MSBuild/iOS:
    * Xamarin.iOS.Tasks.CodesignAppBundle: https://github.com/mono/mono/issues/12130
    * Xamarin.iOS.Tasks.NativeReferencesNoEmbedding: https://github.com/xamarin/maccore/issues/1289

Some are not (they're regressions caused by this commit):

* xammac_tests tests on macOS 10.9: https://github.com/xamarin/xamarin-macios/issues/5309


Это не помогло


nit: s/statistics/fsid/


I think we should do this in different way. There may be a situation where application will be killed for whatever reason. You won't reach that method and there will not be anything in the logger. Instead of saving at the end of everything to logger open file and write every line whenever you are logging something.


add Release resolve #10


[warning] Application exited with reason:


With the information in the objects[] array, you can actually write a generic helper create_objects() if you like - not critical at all


-> https://github.com/tine20/zendframework1/issues/9


I don't like as well word terminating - it sound like we have killed it, but in fact we are closing app.
[info] Application has been closed


Bingo! :) Thank you!!!


LGTM


Logger is not static class, can we have proper event instead of a callback ? If something goes wrong in logger in case of writing file we should have event for that as well.


Removing triple byte entries as the Registry key that Windows uses to remap keys doesn't support anything but double byte enabled scancodes.


Thanks, merged to staging.


when i run your code, multi-relation is overlapped.

![image](https://user-images.githubusercontent.com/7857571/50270673-54abc380-046d-11e9-882c-9e81a99ee249.png)


I've made some changes with last commit


Dear Poggit user,

This is an automatic message from Poggit-CI. Poggit-CI was triggered by this commit, but failed to create builds due to the following error:

```
Resend this delivery later. This commit is triggered by user InkoHX, who
has created 50 Poggit-CI builds in the past 168 hours.

Contact @SOF3 [on Discord](https://discord.gg/NgHf9jt) to request for extra
quota. We will increase your quota for free if you are really contributing
to open-source plugins actively without abusing Git commits.
```

As a result, no builds could be created from this commit. More details might be available for repo admins at [the webhook delivery response log](https://github.com/VectorNetworkProject/TheMix/settings/hooks) — see the webhook starting with `https://poggit.pmmp.io/webhooks.gh.repo` and look for the delivery with ID `cff71794-042a-11e9-9763-caf3b989509f`.

Shall you need any assistance, you may contact us on [on Discord](https://discord.gg/NgHf9jt), or more publicly, [on GitHub](https://github.com/poggit/support/issues). Commenting on this commit directly will **not** notify any Poggit staff.

Regards,
Poggit Bot (@poggit-bot)
The official Poggit automation account


Now could not deploy this pull request since the `now.json` file does not contain valid JSON.

	Click here to see the contents of `now.json`

{
  "alias": ["wave"],

}

For more information on now.json visit https://zeit.co/docs/features/configuration#now.json.


Refactor elseif statements into simple if to make them better readable. Each one has a return statement, so that there should be no problem.


How can I add the planned trajectory to the path following controller, if my trajectory are discrete points?


sdkfjsdf


sdfsdf


I'd really like that development builds would have cheats enabled and you could also enable them in the release build with a flag passed to Thrive when starting.


foo = foo version 66


First of all, this does not listens for file write, but get callback if a date-log file being read (if exists) or the initial settlement done to initiate the logger class. The logger class has I guess enough handling to fire this callback function at any case. Furthermore, if something weird happens, it's possible that event never fired at all. I just tried to get-over from the usage of event. This should work, I guess.


Congratulations！  You have done it!


>// If specified in the context of an input parameter, the value takes precedence over any passed values

Is this correct? AFAIK, the passed argument takes precedence over the value. See https://github.com/argoproj/argo/blob/master/workflow/common/util.go#L118

	// For each input parameter:
	// 1) check if was supplied as argument. if so use the supplied value from arg
	// 2) if not, use default value.
	// 3) if no default value, it is an error


Thank you @bob3bob3 for the feedback and info. I didn't know this was due to a firmware update.


Add curly brackets - I miss that line when I look first time. Add them to whole condition


gradle update to 4.6


[R/gis.R:59:45:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/gis.R#L59) *style:* **Variable or function name should be lowerCamelCase.**
```r
factorValues2 <- function(x, v, layer, att, append.names, na.rm = FALSE) {
                                            ^~~~~~~~~~~~
```
[R/gis.R:59:59:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/gis.R#L59) *style:* **Variable or function name should be lowerCamelCase.**
```r
factorValues2 <- function(x, v, layer, att, append.names, na.rm = FALSE) {
                                                          ^~~~~
```
[R/LANDIS-II-tables.R:90:56:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LANDIS-II-tables.R#L90) *style:* **Commas should always have a space after.**
```r
  sppEquiv <- sppEquiv[!is.na(sppEquiv[[sppEquivCol]]),]
                                                       ^
```
[R/LANDIS-II-tables.R:131:16:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LANDIS-II-tables.R#L131) *style:* **Commented code should be removed.**
```r
  maxcol <- 13#max(count.fields(file.path(dPath, "species.txt"), sep = ""))
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/LANDIS-II-tables.R:145:43:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LANDIS-II-tables.R#L145) *style:* **Commas should always have a space after.**
```r
  species <- species[col1 != "LandisData",]
                                          ^
```
[R/LANDIS-II-tables.R:146:35:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LANDIS-II-tables.R#L146) *style:* **Commas should always have a space after.**
```r
  species <- species[col1 != ">>",]
                                  ^
```
[R/LANDIS-II-tables.R:152:13:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LANDIS-II-tables.R#L152) *style:* **Only use double-quotes.**
```r
  species[, ':='(seeddistance_eff = gsub(",", "", seeddistance_eff),
            ^~~~
```
[R/LANDIS-II-tables.R:152:17:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LANDIS-II-tables.R#L152) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  species[, ':='(seeddistance_eff = gsub(",", "", seeddistance_eff),
                ^
```
[R/LANDIS-II-tables.R:165:18:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LANDIS-II-tables.R#L165) *style:* **Only use double-quotes.**
```r
  speciesAddon[, ':='(leaflongevity = as.numeric(leaflongevity),
                 ^~~~
```
[R/LANDIS-II-tables.R:165:22:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LANDIS-II-tables.R#L165) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  speciesAddon[, ':='(leaflongevity = as.numeric(leaflongevity),
                     ^
```
[R/LANDIS-II-tables.R:177:13:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LANDIS-II-tables.R#L177) *style:* **Only use double-quotes.**
```r
  species[, ':='(species = paste0(toupper(substring(species1, 1, 1)),
            ^~~~
```
[R/LANDIS-II-tables.R:177:17:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LANDIS-II-tables.R#L177) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  species[, ':='(species = paste0(toupper(substring(species1, 1, 1)),
                ^
```
[R/LANDIS-II-tables.R:181:13:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LANDIS-II-tables.R#L181) *style:* **Only use double-quotes.**
```r
  species[, ':='(species1 = NULL, species2 = NULL)]
            ^~~~
```
[R/LANDIS-II-tables.R:181:17:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LANDIS-II-tables.R#L181) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  species[, ':='(species1 = NULL, species2 = NULL)]
                ^
```
[R/LANDIS-II-tables.R:209:39:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LANDIS-II-tables.R#L209) *style:* **Commas should always have a space after.**
```r
  mainInput <- mainInput[col1 != ">>",]
                                      ^
```
[R/LANDIS-II-tables.R:236:16:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LANDIS-II-tables.R#L236) *style:* **Commented code should be removed.**
```r
  maxcol <- 5 #max(count.fields(file.path(dPath, "ecoregions.txt"), sep = ""))
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/LANDIS-II-tables.R:252:47:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LANDIS-II-tables.R#L252) *style:* **Commas should always have a space after.**
```r
  ecoregion <- ecoregion[col1 != "LandisData",]
                                              ^
```
[R/LANDIS-II-tables.R:253:39:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LANDIS-II-tables.R#L253) *style:* **Commas should always have a space after.**
```r
  ecoregion <- ecoregion[col1 != ">>",]
                                      ^
```
[R/LANDIS-II-tables.R:297:61:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LANDIS-II-tables.R#L297) *style:* **Commas should always have a space after.**
```r
  speciesEcoregion <- speciesEcoregion[col1 != "LandisData",]
                                                            ^
```
[R/LANDIS-II-tables.R:298:53:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LANDIS-II-tables.R#L298) *style:* **Commas should always have a space after.**
```r
  speciesEcoregion <- speciesEcoregion[col1 != ">>",]
                                                    ^
```
[R/LANDIS-II-tables.R:309:22:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LANDIS-II-tables.R#L309) *style:* **Only use double-quotes.**
```r
  speciesEcoregion[, ':='(species = paste0(toupper(substring(species1, 1, 1)),
                     ^~~~
```
[R/LANDIS-II-tables.R:309:26:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LANDIS-II-tables.R#L309) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  speciesEcoregion[, ':='(species = paste0(toupper(substring(species1, 1, 1)),
                         ^
```
[R/LANDIS-II-tables.R:312:22:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LANDIS-II-tables.R#L312) *style:* **Only use double-quotes.**
```r
  speciesEcoregion[, ':='(species1 = NULL, species2 = NULL)]
                     ^~~~
```
[R/LANDIS-II-tables.R:312:26:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LANDIS-II-tables.R#L312) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  speciesEcoregion[, ':='(species1 = NULL, species2 = NULL)]
                         ^
```
[R/LandR.R:40:3:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LandR.R#L40) *style:* **Variable or function name should be lowerCamelCase.**
```r
  specieseco_current <- speciesEcoregion[year <= time]
  ^~~~~~~~~~~~~~~~~~
```
[R/LandR.R:41:3:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LandR.R#L41) *style:* **Variable or function name should be lowerCamelCase.**
```r
  specieseco_current <- na.omit(specieseco_current)
  ^~~~~~~~~~~~~~~~~~
```
[R/LandR.R:42:3:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LandR.R#L42) *style:* **Variable or function name should be lowerCamelCase.**
```r
  specieseco_current <- setkey(specieseco_current[year == max(specieseco_current$year),
  ^~~~~~~~~~~~~~~~~~
```
[R/LandR.R:45:24:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LandR.R#L45) *style:* **Variable or function name should be lowerCamelCase.**
```r
  specieseco_current[, maxB_eco := max(maxB), by = ecoregionGroup]
                       ^~~~~~~~
```
[R/LandR.R:46:1:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LandR.R#L46) *style:* **Lines should not be more than 100 characters.**
```r
  newCohortData <- newCohortData[specieseco_current, on = c("speciesCode", "ecoregionGroup"), nomatch = 0]
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/LandR.R:47:1:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LandR.R#L47) *style:* **Lines should not be more than 100 characters.**
```r
  #newCohortData <- setkey(newCohortData, speciesCode, ecoregionGroup)[specieseco_current, nomatch = 0]
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/LandR.R:47:4:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LandR.R#L47) *style:* **Commented code should be removed.**
```r
  #newCohortData <- setkey(newCohortData, speciesCode, ecoregionGroup)[specieseco_current, nomatch = 0]
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/LandR.R:74:1:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LandR.R#L74) *style:* **Lines should not be more than 100 characters.**
```r
  ## note that sufficentLight is a table of survival probs for each tolerance level (row) by and shade level (column)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/LandR.R:76:17:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LandR.R#L76) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  newCohortData[ , lightProb := sufficientLight[cbind(shadetolerance, siteShade + 2)]]
                ^
```
[R/LandR.R:76:18:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/LandR.R#L76) *style:* **Commas should never have a space before.**
```r
  newCohortData[ , lightProb := sufficientLight[cbind(shadetolerance, siteShade + 2)]]
                ~^
```
[R/maps.R:4:48:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L4) *style:* **Commas should always have a space after.**
```r
                           "speciesProportion","SPP", "totalB"))
                                               ^
```
[R/maps.R:22:29:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L22) *style:* **Variable or function name should be lowerCamelCase.**
```r
defineFlammable <- function(LandCoverClassifiedMap = NULL,
                            ^~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:119:5:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L119) *style:* **Variable or function name should be lowerCamelCase.**
```r
    MixedRas <- speciesStack[[1]]
    ^~~~~~~~
```
[R/maps.R:123:18:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L123) *style:* **Variable or function name should be lowerCamelCase.**
```r
    speciesStack$Mixed <- MixedRas
                 ^~~~~
```
[R/maps.R:127:19:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L127) *style:* **Commas should always have a space after.**
```r
  nas <- is.na(a[,1])
                  ^
```
[R/maps.R:128:25:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L128) *style:* **Commas should always have a space after.**
```r
  maxes <- apply(a[!nas,], 1, function(x) {
                        ^
```
[R/maps.R:163:1:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L163) *style:* **Lines should not be more than 100 characters.**
```r
  # shortcohortdata <- setkey(cohortdata, speciesCode)[setkey(species[, .(speciesCode, speciesGroup)],
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:205:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L205) *style:* **Commented code should be removed.**
```r
  #   species[species == "Pice_mar", speciesGroup := "PICE_MAR"]
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:206:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L206) *style:* **Commented code should be removed.**
```r
  #   species[species == "Pice_gla", speciesGroup := "PICE_GLA"]
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:207:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L207) *style:* **Commented code should be removed.**
```r
  #   species[species == "Abie_sp", speciesGroup := "ABIE"]
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:209:1:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L209) *style:* **Lines should not be more than 100 characters.**
```r
  #   shortcohortdata <- setkey(cohortdata, speciesCode)[setkey(species[, .(speciesCode, speciesGroup)],
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:211:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L211) *style:* **Commented code should be removed.**
```r
  #   shortcohortdata[, totalB := sum(B, na.rm = TRUE), by = pixelGroup]
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:215:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L215) *style:* **Commented code should be removed.**
```r
  #   shortcohortdata[, speciesProportion := speciesGroupB / totalB]
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:217:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L217) *style:* **Commented code should be removed.**
```r
  #   speciesLeading <- NULL
      ^~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:220:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L220) *style:* **Commented code should be removed.**
```r
  #   pixelGroup <- NULL
      ^~~~~~~~~~~~~~~~~~
```
[R/maps.R:221:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L221) *style:* **Commented code should be removed.**
```r
  #   speciesProportion <- NULL
      ^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:222:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L222) *style:* **Commented code should be removed.**
```r
  #   speciesGroup <- NULL
      ^~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:223:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L223) *style:* **Commented code should be removed.**
```r
  #   speciesCode <- NULL
      ^~~~~~~~~~~~~~~~~~~
```
[R/maps.R:224:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L224) *style:* **Commented code should be removed.**
```r
  #   totalB <- NULL
      ^~~~~~~~~~~~~~
```
[R/maps.R:226:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L226) *style:* **Commented code should be removed.**
```r
  #   speciesGroupB <- NULL
      ^~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:236:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L236) *style:* **Commented code should be removed.**
```r
  #   shortcohortdata[is.na(speciesLeading), speciesLeading := 0]
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:237:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L237) *style:* **Commented code should be removed.**
```r
  #   shortcohortdata[, speciesLeading := max(speciesLeading, na.rm = TRUE), by = pixelGroup]
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:238:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L238) *style:* **Commented code should be removed.**
```r
  #   shortcohortdata <- unique(shortcohortdata[, .(pixelGroup, speciesLeading)], by = "pixelGroup")
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:239:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L239) *style:* **Commented code should be removed.**
```r
  #   shortcohortdata[speciesLeading == 0, speciesLeading := 5] # 5 is mixed forests
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:240:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L240) *style:* **Commented code should be removed.**
```r
  #   attritable <- data.table(ID = sort(unique(shortcohortdata$speciesLeading)))
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:245:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L245) *style:* **Commented code should be removed.**
```r
  #   attritable[ID == 5, Factor := "Mixed"]
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:246:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L246) *style:* **Commented code should be removed.**
```r
  #   vegTypeMap <- rasterizeReduced(shortcohortdata, pixelGroupMap, "speciesLeading", "pixelGroup")
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:247:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L247) *style:* **Commented code should be removed.**
```r
  #   vegTypeMap <- setValues(vegTypeMap, as.integer(getValues(vegTypeMap)))
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:248:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L248) *style:* **Commented code should be removed.**
```r
  #   levels(vegTypeMap) <- as.data.frame(attritable)
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:249:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L249) *style:* **Commented code should be removed.**
```r
  #   projection(vegTypeMap) <- projection(pixelGroupMap)
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:295:56:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L295) *style:* **Commas should always have a space after.**
```r
  sppEquiv <- sppEquiv[!is.na(sppEquiv[[sppEquivCol]]),]
                                                       ^
```
[R/maps.R:323:1:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L323) *style:* **Lines should not be more than 100 characters.**
```r
  kNNnames <- as.character(equivalentName(sppNameVector, sppEquiv, column = knnNamesCol, multi = TRUE))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:328:1:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L328) *style:* **Lines should not be more than 100 characters.**
```r
                   knnNamesCol, ".\n Will use remaining matching species, but check if this is correct"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:360:47:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L360) *style:* **Put spaces around all infix operators.**
```r
  if (!all(file_path_sans_ext(names(archives))==file_path_sans_ext(targetFiles)))
                                             ~^~~
```
[R/maps.R:393:1:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L393) *style:* **Lines should not be more than 100 characters.**
```r
  nameChangesNonMerged <- equivalentName(names(speciesLayers)[nameChangeNA], sppEquiv, column = sppEquivCol)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:500:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L500) *style:* **Variable or function name should be lowerCamelCase.**
```r
      LQRastName <- basename(tempfile(fileext = ".tif"))
      ^~~~~~~~~~
```
[R/maps.R:502:9:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L502) *style:* **Variable or function name should be lowerCamelCase.**
```r
        LQCurName <- basename(tempfile(fileext = ".tif"))
        ^~~~~~~~~
```
[R/maps.R:509:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L509) *style:* **Variable or function name should be lowerCamelCase.**
```r
      LQRastInHQcrs <- projectExtent(lowQualityStack, crs = crs(highQualityStack))
      ^~~~~~~~~~~~~
```
[R/maps.R:522:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L522) *style:* **Variable or function name should be lowerCamelCase.**
```r
      LQRast <- raster(LQRastName)
      ^~~~~~
```
[R/maps.R:540:9:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L540) *style:* **Variable or function name should be lowerCamelCase.**
```r
        HQRast <- raster(tmpHQName)
        ^~~~~~
```
[R/maps.R:545:9:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L545) *style:* **Variable or function name should be lowerCamelCase.**
```r
        HQRast <- highQualityStack[[SPP]]
        ^~~~~~
```
[R/maps.R:548:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L548) *style:* **Variable or function name should be lowerCamelCase.**
```r
      LQRast <- lowQualityStack[[SPP]]
      ^~~~~~
```
[R/maps.R:549:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L549) *style:* **Variable or function name should be lowerCamelCase.**
```r
      HQRast <- highQualityStack[[SPP]]
      ^~~~~~
```
[R/maps.R:556:5:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L556) *style:* **Variable or function name should be lowerCamelCase.**
```r
    NAs <- is.na(HQRast[])
    ^~~
```
[R/maps.R:560:5:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L560) *style:* **Variable or function name should be lowerCamelCase.**
```r
    HQRast <- writeRaster(HQRast, datatype = "INT1U",
    ^~~~~~
```
[R/maps.R:570:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L570) *style:* **Variable or function name should be lowerCamelCase.**
```r
      HQRast <- highQualityStack[[SPP]]
      ^~~~~~
```
[R/maps.R:574:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L574) *style:* **Variable or function name should be lowerCamelCase.**
```r
      LQRast <- lowQualityStack[[SPP]]
      ^~~~~~
```
[R/maps.R:578:7:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L578) *style:* **Variable or function name should be lowerCamelCase.**
```r
      HQRast <- highQualityStack[[SPP]]
      ^~~~~~
```
[R/maps.R:606:6:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/maps.R#L606) *style:* **Commented code should be removed.**
```r
    #names(sppMerges) <- equivalentName(names(sppMerges), sppEquiv,  column = sppEquivCol)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plotting.R:59:56:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/plotting.R#L59) *style:* **Commas should always have a space after.**
```r
  sppEquiv <- sppEquiv[!is.na(sppEquiv[[sppEquivCol]]),]
                                                       ^
```
[R/plotting.R:68:13:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/plotting.R#L68) *style:* **Variable or function name should be lowerCamelCase.**
```r
  facLevels$Species <- vtmTypes
            ^~~~~~~
```
[R/plotting.R:76:44:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/plotting.R#L76) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  if (all(na.omit(speciesEN) %in% colorsEN) ){
                                           ^
```
[R/plotting.R:108:1:](https://github.com/PredictiveEcology/pemisc/blob/da9a5868ea581578ee5f541c0943ff99d5a8abb0/R/plotting.R#L108) *style:* **Lines should not be more than 100 characters.**
```r
  setColors(vtm, length(vtmTypes)) <- vtmCols # setColors for factors must have an entry for each row in raster::levels
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


okay so it uses http like the beginning of the web link to search or if its a relative link meaning it only adds a '\' it uses that to search thus giving you your total cool shit


Oh 🤦♂ good solution @franzliedke 👍


You should remove the VS part (and GS if any too)


I haven't say that this does not work. I'm saying that we are not in JavaScript where callbacks are common, we are in AS3 where events are common. I have never had situation that event wasn't received when it was fired - you are implying by that - something is wrong with events system in Flex, but it's not.


Dear Poggit user,

This is an automatic message from Poggit-CI. Poggit-CI was triggered by this commit, but failed to create builds due to the following error:

```
Resend this delivery later. This commit is triggered by user InkoHX, who
has created 50 Poggit-CI builds in the past 168 hours.

Contact @SOF3 [on Discord](https://discord.gg/NgHf9jt) to request for extra
quota. We will increase your quota for free if you are really contributing
to open-source plugins actively without abusing Git commits.
```

As a result, no builds could be created from this commit. More details might be available for repo admins at [the webhook delivery response log](https://github.com/VectorNetworkProject/TheMix/settings/hooks) — see the webhook starting with `https://poggit.pmmp.io/webhooks.gh.repo` and look for the delivery with ID `f58fa62c-042c-11e9-8dfb-3e32e9489b48`.

Shall you need any assistance, you may contact us on [on Discord](https://discord.gg/NgHf9jt), or more publicly, [on GitHub](https://github.com/poggit/support/issues). Commenting on this commit directly will **not** notify any Poggit staff.

Regards,
Poggit Bot (@poggit-bot)
The official Poggit automation account


stored_data_size is used for following size.
pkcs_control_block_data_image.data.local_storage[size]

And I noticed this index would point out of this array. I need to change the implementation.
I am now trying this after:  b6b7efd16a5f02cba95426493569695109903e61

I will keep updating. Thank you.


Puzzle `1086-abf60b5c` discovered in   [`src/test/java/com/jcabi/github/RtBranchesTest.java`](  https://github.com/jcabi/jcabi-github/blob/master/src/test/java/com/jcabi/github/RtBranchesTest.java)   and submitted as #1457. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


Anybody knows why "SafeCheck" parameters are not tuning?


I think, removing this caused the build to fail. @stephanegigandet


asd


It doesn't need for sysui restart. Need to dismiss dialog on init.

https://github.com/aexmod-tmp/platform_frameworks_base/commit/592f26d631284b92f35523d9d1ec3adc4659d447


I wasn't able to retrieve PDD puzzles from the code base and submit them to GitHub. If you think that it's a bug on our side, please submit it to [yegor256/0pdd](https://github.com/yegor256/0pdd/issues):

> set -x && set -e && set -o pipefail && cd /tmp/0pdd20181219-4-123l06u/amihaiemil/docker-java-api && pdd -v -f /tmp/20181220-14996-ps1262 [1]: bash: warning: setlocale: LC_ALL: cannot change locale (UTF-8) + set -e + set -o pipefail + cd /tmp/0pdd20181219-4-123l06u/amihaiemil/docker-java-api + pdd...

Please, copy and paste this stack trace to GitHub:

```
UserError
set -x && set -e && set -o pipefail && cd /tmp/0pdd20181219-4-123l06u/amihaiemil/docker-java-api && pdd -v -f /tmp/20181220-14996-ps1262 [1]:
bash: warning: setlocale: LC_ALL: cannot change locale (UTF-8)
+ set -e
+ set -o pipefail
+ cd /tmp/0pdd20181219-4-123l06u/amihaiemil/docker-java-api
+ pdd -v -f /tmp/20181220-14996-ps1262

My version is 0.20.3
Ruby version is 2.5.1 at x86_64-linux
Reading /tmp/0pdd20181219-4-123l06u/amihaiemil/docker-java-api
111 file(s) found, 68 excluded
Reading src/main/java/com/amihaiemil/docker/Credentials.java...
Reading src/main/java/com/amihaiemil/docker/Swarm.java...
Puzzle 77-48853626 30/DEV at src/main/java/com/amihaiemil/docker/Swarm.java
Reading src/main/java/com/amihaiemil/docker/Volumes.java...
Puzzle 183-9aed8aaf 30/DEV at src/main/java/com/amihaiemil/docker/Volumes.java
Reading src/main/java/com/amihaiemil/docker/Plugins.java...
Puzzle 208-b6677773 30/DEV at src/main/java/com/amihaiemil/docker/Plugins.java
Reading src/main/java/com/amihaiemil/docker/ReadJsonArray.java...
Reading src/main/java/com/amihaiemil/docker/UnixSocketFactory.java...
Reading src/main/java/com/amihaiemil/docker/RtContainer.java...
Puzzle 97-657d9f49 30/DEV at src/main/java/com/amihaiemil/docker/RtContainer.java
Reading src/main/java/com/amihaiemil/docker/Plugin.java...
Reading src/main/java/com/amihaiemil/docker/Containers.java...
Reading src/main/java/com/amihaiemil/docker/PayloadOf.java...
Puzzle 108-8ad4a268 30/DEV at src/main/java/com/amihaiemil/docker/PayloadOf.java
Reading src/main/java/com/amihaiemil/docker/RtImages.java...
Reading src/main/java/com/amihaiemil/docker/RtDockerSystem.java...
Reading src/main/java/com/amihaiemil/docker/Inspection.java...
Reading src/main/java/com/amihaiemil/docker/ResourcesIterator.java...
Reading src/main/java/com/amihaiemil/docker/RemoteDocker.java...
Reading src/main/java/com/amihaiemil/docker/RtSwarm.java...
Reading src/main/java/com/amihaiemil/docker/RtVolumes.java...
Reading src/main/java/com/amihaiemil/docker/RtVolume.java...
Reading src/main/java/com/amihaiemil/docker/Volume.java...
Reading src/main/java/com/amihaiemil/docker/Docker.java...
Reading src/main/java/com/amihaiemil/docker/SslHttpClient.java...
Reading src/main/java/com/amihaiemil/docker/LocalDocker.java...
Reading src/main/java/com/amihaiemil/docker/DockerSystem.java...
Reading src/main/java/com/amihaiemil/docker/RtImage.java...
Reading src/main/java/com/amihaiemil/docker/Image.java...
Reading src/main/java/com/amihaiemil/docker/RtNetwork.java...
Reading src/main/java/com/amihaiemil/docker/Networks.java...
Puzzle 224-36c37640 30/DEV at src/main/java/com/amihaiemil/docker/Networks.java
Reading src/main/java/com/amihaiemil/docker/Exec.java...
Reading src/main/java/com/amihaiemil/docker/RegistryConfigAuth.java...
Reading src/main/java/com/amihaiemil/docker/ListedVolumes.java...
Puzzle 207-c4751857 30/DEV at src/main/java/com/amihaiemil/docker/ListedVolumes.java
Reading src/main/java/com/amihaiemil/docker/Logs.java...
Reading src/main/java/com/amihaiemil/docker/MatchStatus.java...
Reading src/main/java/com/amihaiemil/docker/IdentityToken.java...
Reading src/main/java/com/amihaiemil/docker/Images.java...
Puzzle 98-994768b7 30/DEV at src/main/java/com/amihaiemil/docker/Images.java
Puzzle 152-6918ce7a 30/DEV at src/main/java/com/amihaiemil/docker/Images.java
Reading src/main/java/com/amihaiemil/docker/RtLogs.java...
Puzzle 135-7b38f89f 30/DEV at src/main/java/com/amihaiemil/docker/RtLogs.java
Puzzle 130-0345812b 30/DEV at src/main/java/com/amihaiemil/docker/RtLogs.java
Reading src/main/java/com/amihaiemil/docker/AuthHttpClient.java...
Reading src/main/java/com/amihaiemil/docker/HttpClientEnvelope.java...
Reading src/main/java/com/amihaiemil/docker/UnixHttpClient.java...
Reading src/main/java/com/amihaiemil/docker/RtDocker.java...
Reading src/main/java/com/amihaiemil/docker/RtContainers.java...
Reading src/main/java/com/amihaiemil/docker/SystemDiskSpaceInfo.java...
Reading src/main/java/com/amihaiemil/docker/ListedImages.java...
Reading src/main/java/com/amihaiemil/docker/RtNetworks.java...
Reading src/main/java/com/amihaiemil/docker/ReadString.java...
Reading src/main/java/com/amihaiemil/docker/Container.java...
Reading src/main/java/com/amihaiemil/docker/PlainHttpClient.java...
Reading src/main/java/com/amihaiemil/docker/UncheckedUriBuilder.java...
Reading src/main/java/com/amihaiemil/docker/UnexpectedResponseException.java...
Reading src/main/java/com/amihaiemil/docker/Merged.java...
Reading src/main/java/com/amihaiemil/docker/Auth.java...
Reading src/main/java/com/amihaiemil/docker/ListedNetworks.java...
Puzzle 211-924fe80a 30/DEV at src/main/java/com/amihaiemil/docker/ListedNetworks.java
Reading src/main/java/com/amihaiemil/docker/Network.java...
ERROR: src/main/java/com/amihaiemil/docker/Network.java; puzzle at line #38; Too many leading spaces at 40:3; make sure all lines that include the puzzle body start at position #4.. If you can't understand the cause of this issue or you don't know how to fix it, please submit a GitHub issue, we will try to help you: https://github.com/yegor256/pdd/issues. This tool is still in its beta version and we will appreciate your feedback. Here is where you can find more documentation: https://github.com/yegor256/pdd/blob/master/README.md.
Exit code is 1

/app/objects/git_repo.rb:66:in `rescue in block in xml'
/app/objects/git_repo.rb:63:in `block in xml'
/app/vendor/ruby-2.5.1/lib/ruby/2.5.0/tempfile.rb:295:in `open'
/app/objects/git_repo.rb:62:in `xml'
/app/objects/puzzles.rb:36:in `deploy'
/app/objects/job.rb:38:in `proceed'
/app/objects/job_starred.rb:33:in `proceed'
/app/objects/job_recorded.rb:32:in `proceed'
/app/objects/job_emailed.rb:35:in `proceed'
/app/objects/job_commiterrors.rb:36:in `proceed'
/app/objects/job_detached.rb:48:in `exclusive'
/app/objects/job_detached.rb:36:in `block in proceed'
/app/objects/job_detached.rb:36:in `fork'
/app/objects/job_detached.rb:36:in `proceed'
/app/0pdd.rb:354:in `block in <top (required)>'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1635:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1635:in `block in compile!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:992:in `block (3 levels) in route!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1011:in `route_eval'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:992:in `block (2 levels) in route!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1040:in `block in process_route'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1038:in `catch'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1038:in `process_route'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:990:in `block in route!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:989:in `each'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:989:in `route!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1097:in `block in dispatch!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `block in invoke'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `catch'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `invoke'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1094:in `dispatch!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:924:in `block in call!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `block in invoke'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `catch'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `invoke'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:924:in `call!'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:913:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-protection-2.0.4/lib/rack/protection/xss_header.rb:18:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-protection-2.0.4/lib/rack/protection/path_traversal.rb:16:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-protection-2.0.4/lib/rack/protection/json_csrf.rb:26:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-protection-2.0.4/lib/rack/protection/base.rb:50:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-protection-2.0.4/lib/rack/protection/base.rb:50:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-protection-2.0.4/lib/rack/protection/frame_options.rb:31:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.6/lib/rack/logger.rb:15:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.6/lib/rack/common_logger.rb:33:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:231:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:224:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.6/lib/rack/head.rb:12:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.6/lib/rack/method_override.rb:22:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:194:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1957:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1502:in `block in call'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1729:in `synchronize'
/app/vendor/bundle/ruby/2.5.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1502:in `call'
/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.6/lib/rack/handler/webrick.rb:86:in `service'
/app/vendor/ruby-2.5.1/lib/ruby/2.5.0/webrick/httpserver.rb:140:in `service'
/app/vendor/ruby-2.5.1/lib/ruby/2.5.0/webrick/httpserver.rb:96:in `run'
/app/vendor/ruby-2.5.1/lib/ruby/2.5.0/webrick/server.rb:307:in `block in start_thread'
```


Thanks a lot for looking into this @Hains

But the develop branch of pli-extras is still meant for the develop branch of openpli-oe-core right? (I've been out for some time)
Reason I'm asking is because I have cross-localedef-native 2.25 not 2.27.
I'm getting an error that it can't find version 2.27 of cross-localedef-native.


foo = foo version 4


For me this is no simplification because bestMoveChanges is a double.
Also tuning will become more difficult.


Didn't work. Seems to be an issue with games launched directly from flashcard.


Should be displayEnd...


End


No you're dictating me wrong. I never said event won't receive if it's fired. But what I tried to tell is, if something goes wrong and callback function never fired, that scenario can also happens in case of event-driven structure, when something gone wrong and pointer never able to reach to the point of firing an event. That scenario can be similar between using callback and event fire.


**Update:** It seems to be the issue with the following line:
`opcache.revalidate_freq=0`

When I changed it to the following, the site updates work fine:
`opcache.revalidate_freq=1`


This one breaks plenty of GCP stuff!
In example, `google_dns_managed_zone` got deleted, but it's still present in Terraform.
https://www.terraform.io/docs/providers/google/r/dns_managed_zone.html


Please explain why this is needed :-)


Now could not deploy this pull request since the `now.json` file does not contain valid JSON.

	Click here to see the contents of `now.json`

{
  "alias": ["wave"],

}

For more information on now.json visit https://zeit.co/docs/features/configuration#now.json.


Thank you very much for your prompt reply!


Petite remarque:
le fichier `module.config.ts`` ne devrait pas être commité, ni être directement modifié. Il doit être généré par la commande ``geonature update_module_configuration <nom_module>`` (qui génère un JSON à partir du schéma marshmalow et du fichier conf ``gn_module.toml``


I still can see DB connection string with authentication data in your`s repo history. Fix it,please as fast as possible


Actually, I tried but didn't worked so used something to be on safer side. Will try the init one. Thanks


Thank you also.
Yeah it was a cherry-pick from sumo, that's why version 2.27.
I saw it as well when i tried to build an image for Raspberrypi,
It should be OK now.


I'll try one last shot at it:

`QPixmap` does not have an actual mask, but an alpha channel, with which any assigned mask would be merged. Please see [QPixmap::setMask()](http://doc.qt.io/qt-5/qpixmap.html#setMask), it will explain much better than I ever could.

`useMask` === "use transparency of the **source** pixmap", at least here in wxQt.
- when true:
  - source pixmap is just drawn over the destination, using whatever transparency the source has;
- when false:
  - the source pixmap needs to eventually be drawn over the destination without transparency;
  - for achieving opacity it is converted into an intermediary `Format_RGB32` image;
  - as strange as it may sound, no, `Format_RGB32` is not ARGB, but 0x**ff**RRGGBB. FWIW ARGB is `Format_ARGB32`, see [QImage::Format](http://doc.qt.io/qt-5/qimage.html#Format-enum).


Why not just use func.__qualname__? Isn't inspect kind of slow versus __qualname__?

I just added something like this but I'm using func.__qualname__ on Electron Cash.  Let me know if I'm missing anything...


on update:
  boolean value = Settings.System.getIntForUser(mContext.getContentResolver(), Settings.System.AUDIO_PANEL_VIEW_POSITION, 0, UserHandle.USER_CURRENT) == 0;
             if(value != isRightPosition){
                isRightPosition = value;
                initDialog();
             } else {
                updateRowsH(getActiveRow());
             }


Please squash this commit


Could you add an explanatory comment? It took me a minute to understand that you're checking whether $buildingInfo is a single building or an array of buildings.


Dear Poggit user,

This is an automatic message from Poggit-CI. Poggit-CI was triggered by this commit, but failed to create builds due to the following error:

```
Resend this delivery later. This commit is triggered by user InkoHX, who
has created 50 Poggit-CI builds in the past 168 hours.

Contact @SOF3 [on Discord](https://discord.gg/NgHf9jt) to request for extra
quota. We will increase your quota for free if you are really contributing
to open-source plugins actively without abusing Git commits.
```

As a result, no builds could be created from this commit. More details might be available for repo admins at [the webhook delivery response log](https://github.com/VectorNetworkProject/TheMix/settings/hooks) — see the webhook starting with `https://poggit.pmmp.io/webhooks.gh.repo` and look for the delivery with ID `9d0657aa-042f-11e9-80fb-938af61922ca`.

Shall you need any assistance, you may contact us on [on Discord](https://discord.gg/NgHf9jt), or more publicly, [on GitHub](https://github.com/poggit/support/issues). Commenting on this commit directly will **not** notify any Poggit staff.

Regards,
Poggit Bot (@poggit-bot)
The official Poggit automation account


6? Is this correct?


On update:

boolean value = Settings.System.getIntForUser(mContext.getContentResolver(), Settings.System.AUDIO_PANEL_VIEW_POSITION, 0, UserHandle.USER_CURRENT) == 0;
             if(value != isRightPosition){
                isRightPosition = value;
                initDialog();
             } else {
                updateRowsH(getActiveRow());
             }


Dear Poggit user,

This is an automatic message from Poggit-CI. Poggit-CI was triggered by this commit, but failed to create builds due to the following error:

```
Resend this delivery later. This commit is triggered by user InkoHX, who
has created 50 Poggit-CI builds in the past 168 hours.

Contact @SOF3 [on Discord](https://discord.gg/NgHf9jt) to request for extra
quota. We will increase your quota for free if you are really contributing
to open-source plugins actively without abusing Git commits.
```

As a result, no builds could be created from this commit. More details might be available for repo admins at [the webhook delivery response log](https://github.com/VectorNetworkProject/TheMix/settings/hooks) — see the webhook starting with `https://poggit.pmmp.io/webhooks.gh.repo` and look for the delivery with ID `afe9b4ac-042f-11e9-8a5b-93edf62415cb`.

Shall you need any assistance, you may contact us on [on Discord](https://discord.gg/NgHf9jt), or more publicly, [on GitHub](https://github.com/poggit/support/issues). Commenting on this commit directly will **not** notify any Poggit staff.

Regards,
Poggit Bot (@poggit-bot)
The official Poggit automation account


Hi, you probably meant @Axinex as I did nothing on this work ;-)


Successfully aliased the URL <https://acodingdance-f178no6z6.now.sh> to the following alias.

* https://acodingdance.io


I was thinking the `ResolvedProjectDescription` could take its mutable sibbling in argument so that you don't have to do all of this (just copy the state in an immutable fashion basically).


підсвітка синім вказує що імя quit для змінної не є найкращим. може бути зарезервованим словом


Successfully aliased the URL <https://deem-gtsb5pel3.now.sh> to the following aliases.

* https://deem.theguys.sh
* https://deem.theguys.app
* https://deem.theguys.design


我是赵跨豪


такі коментарі краще робити через # move up а коментарі """move up""" більше підходять для пояснення функції чи класу одразу в наступному рядку після оголошення функції чи класу


визначіться із форматом коментаря і завжди притримуйтесь, у вас то "" то """"""


Successfully aliased the URL <https://dasher-91eu2l849.now.sh> to the following alias.

* https://dasher.sh


- fixed displaying of floating point numbers
- fixed listing of BASIC program "without any lines" (if length of the file is zero)
- fixed listing of runtime variables if the BASIC program doesn't have any


> 稳定性提高了很多

是你 没错了


Yep, that needs to be checked.


下载网易云音乐


Successfully aliased the URL <https://ohjelmointi-19-aqtfapsfza.now.sh> to the following alias.

* https://ohjelmointi-19.mooc.fi


Inquiry Number is as follows 1 3473 76991
Thank you in advance


Related to https://github.com/phalcon/cphalcon/issues/13661


This is fixed now, but please learn what pull requests are.


This is tuning.


Dear Poggit user,

This is an automatic message from Poggit-CI. Poggit-CI was triggered by this commit, and the build was created with the following warnings:

1. Sanitized project name, from "0" to "0"

Shall you need any assistance, you may contact us on [on Discord](https://discord.gg/NgHf9jt), or more publicly, [on GitHub](https://github.com/poggit/support/issues). Commenting on this commit directly will **not** notify any Poggit staff.

Regards,
Poggit Bot (@poggit-bot)
The official Poggit automation account


定数はメソッドの外で定義しましょう。


Successfully aliased the URL <https://dasher-9oq5rx570.now.sh> to the following alias.

* https://dasher.sh


Shapoklyak


Seems like it is not working due to a invalid API


I do wonder, if trailing white space etc. is such an issue why we don't just set up pre-commit hooks to clean clutter?

In some of our projects at DLS we have pre-commit hooks which run black, flake8 and some other odds and ends to ensure that the diffs are always clean - and the resulting code contains no local idiosyncrasies. Did not take long to get used to at all... about 1 commit before the value was clear.


Dear @BrokenItZAndrei100,
> I regret to inform you that your plugin "**ZMusicBox**" (v3.1.0 submitted on 2018-12-20T08:40:55.000Z) has been rejected.

B5 — Only submit your own plugins:
> Do not submit plugins written by others without their prior permission. If the author is inactive, it must be released through @poggit-orphanage. Create an issue at [orphanage office](https://github.com/poggit-orphanage/office/issues/new). You will be allowed to maintain the plugin as a member of @poggit-orphanage upon approval.

Please resolve these issues and submit the plugin again.

> This comment is posted here because this is the last commit when the released build was created.


Hello SOFe , Now i make my plugin , but can you help me? I dont know to add
folders to github , please help!

În Jo, 20 dec. 2018, 10:41 SOFe <notifications@github.com a scris:

> Dear @BrokenItZAndrei100 <https://github.com/BrokenItZAndrei100>,
>
> I regret to inform you that your plugin "*ZMusicBox*" (v3.1.0 submitted
> on 2018-12-20T08:40:55.000Z) has been rejected.
>
> B5 — Only submit your own plugins:
>
> Do not submit plugins written by others without their prior permission. If
> the author is inactive, it must be released through @poggit-orphanage
> <https://github.com/poggit-orphanage>. Create an issue at orphanage office
> <https://github.com/poggit-orphanage/office/issues/new>. You will be
> allowed to maintain the plugin as a member of @poggit-orphanage
> <https://github.com/poggit-orphanage> upon approval.
>
> Please resolve these issues and submit the plugin again.
>
> This comment is posted here because this is the last commit when the
> released build was created.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/BrokenItZAndrei100/ZMusicBox/commit/c5973e2917788f24970487a0b1a7206efb184373#commitcomment-31742030>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ArWWTtHWrnzSrBz0sJVnt-FGQweHVCh7ks5u600wgaJpZM4ZbvOv>
> .
>


should be after get


Welcom to be a Githuber


Yes, I will be checking it soon, once I am near to my lappy.


Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

- @nasimrahaman was added to conda-forge. Welcome to conda-forge!
  Go to https://github.com/orgs/conda-forge/invitation see your invitation.

You should get push access to this feedstock and CI services.

Feel free to join the community [chat room](https://gitter.im/conda-forge/conda-forge.github.io).

NOTE: Please make sure to not push to the repository directly.
      Use branches in your fork for any changes and send a PR.
      More details [here](https://conda-forge.org/docs/conda-forge_gotchas.html#using-a-fork-vs-a-branch-when-updating-a-recipe)


I wonder if the change wouldn't be simplified if `ProjectGenerator` took a `ProjectDescription`. If it did, you wouldn't have to modify all of this and the immutable version of it would be a concern for the project application context only.

Looking at the result, I feel that the immutability version surfaces too much in tests that shouldn't have to care about that.

The resolution part would also be a concern of the `ProjectGenerator`. Right now, it expects to find a bean to `ProjectDirectoryFactory` so it does not strike me as crazy we should provide a resolver as well.

Thoughts?


[R/ggcorrmat.R:367:9:](https://github.com/IndrajeetPatil/ggstatsplot/blob/dd69b5504d56f7be8d6454cd673a45359b17eeb0/R/ggcorrmat.R#L367) *warning:* **local variable ‘n_summary’ assigned but may not be used**
```r
        n_summary <- numdf_summary(corr_df$n)
        ^~~~~~~~~
```
[R/ggscatterstats.R:234:5:](https://github.com/IndrajeetPatil/ggstatsplot/blob/dd69b5504d56f7be8d6454cd673a45359b17eeb0/R/ggscatterstats.R#L234) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
    {
    ^
```
[R/helpers_ggbetween_anova_subtitles.R:297:1:](https://github.com/IndrajeetPatil/ggstatsplot/blob/dd69b5504d56f7be8d6454cd673a45359b17eeb0/R/helpers_ggbetween_anova_subtitles.R#L297) *style:* **Variable and function names should not be longer than 30 characters.**
```r
subtitle_friedman_nonparametric <- function(data,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


修改


We've found a limitation here I guess. `@ProjectGenerationConfiguration` must not be picked up by component scan and I have no idea how we could fix that.

paging @wilkinsona


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


I thought of adding a `@ConditionalOnFacet` but it's a bit tricky considering we can compute them after the evaluation has completed. The same can be said for dependencies so I am not sure what to do.


It used to throw an exception, not to fall back in any way.


remove which returns an object fits the contract for Java Lists, though


Nice.


This is now open as an issue - I do not see way to remove it from the push


Successfully aliased the URL <https://bworks-gfihlptxuy.now.sh> to the following alias.

* https://www.b-works.io


Successfully aliased the URL <https://ohjelmointi-19-iwzzptoepd.now.sh> to the following alias.

* https://ohjelmointi-19.mooc.fi


This should query the `build` and not the description. The container has helpful method to query (and we can add more if we need to).


We should query `build` here


That's right, thanks for catching that!


We should query `build`


was opening the file instead of linking to the wiki (I think I corrected directly on the wiki master and made an error. This is the fix)


no overlap because of post is after all of the computations


usesMagic or doesUseMagic or isMagic/setMagic?


Given the pattern I wonder if we should have an action "if this matches, then invoke this" on the `DependenciesContainer`.


This can be moved if you do not want it here


Dear Poggit user,

This is an automatic message from Poggit-CI. Poggit-CI was triggered by this commit, and the build was created with the following warnings:

1. Sanitized project name, from "0" to "0"

Shall you need any assistance, you may contact us on [on Discord](https://discord.gg/NgHf9jt), or more publicly, [on GitHub](https://github.com/poggit/support/issues). Commenting on this commit directly will **not** notify any Poggit staff.

Regards,
Poggit Bot (@poggit-bot)
The official Poggit automation account


Maybe not necessary


VS_RTCOPY uses tp on the rest


great


![](https://github.trello.services/images/mini-trello-icon.png) [Paneles y vistas de inicio de usuario ,administrador y perfil.](https://trello.com/c/duFlTbEW/13-paneles-y-vistas-de-inicio-de-usuario-administrador-y-perfil)


window pointer here


Good catch. I think we should not modify those tests. Instead we should modify the generator as it uses the new API for Maven Pom and Gradle build.

The goal here is to not modify the tests at all and make sure they still behave as before so I'd like to revert this. I am working on a way to trigger only the build file with the new API so it should be available today hopefully.


xDDDDDD


Successfully aliased the URL <https://bworks-ocxeccddjq.now.sh> to the following alias.

* https://www.b-works.io


灵感天气机器人
微信号：masm123map


What ?

If ps don't use tp there is no need to generate it on the vs. rt_copy is a hack for dx9 date (you can copy the rt without this shader)


I can't follow. Everything is deprecated now?
According to the slide the `alert-<tier>-<severity>`, `alert-<tier>`, `alert-<tier>-<service>` channels should still be used.


And you probably remove the rt define on compilation


No templating here.


Update people db


Dear Poggit user,

This is an automatic message from Poggit-CI. Poggit-CI was triggered by this commit, but failed to create builds due to the following error:

You are trying to create too many projects. We only allow creating up to 6
new projects per week.

Contact @SOF3 [on Discord](https://discord.gg/NgHf9jt) to request for extra
quota. We will increase your quota **for free** if you are really trying to
build **your own plugins**, i.e. not forks or copied code.

**Do not try to use another account just to overcome this limit**, or you
may be **banned** from Poggit.

As a result, no builds could be created from this commit. More details might be available for repo admins at [the webhook delivery response log](https://github.com/BrokenItZAndrei100/TitleCmdAdder/settings/hooks) — see the webhook starting with `https://poggit.pmmp.io/webhooks.gh.repo` and look for the delivery with ID `62276074-0435-11e9-82ad-04d38ef0a2a6`.

Shall you need any assistance, you may contact us on [on Discord](https://discord.gg/NgHf9jt), or more publicly, [on GitHub](https://github.com/poggit/support/issues). Commenting on this commit directly will **not** notify any Poggit staff.

Regards,
Poggit Bot (@poggit-bot)
The official Poggit automation account


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


Since incoming webhooks in a slack app can only be generated for a specific channel, one needs to to this for the duty channels before merging this.


and
```scala
if (cpuCount ==0) cpuCount = something
```
isn’t thread-safe by design. :grin:


I did thought about this. But I see some cases which requires to address properly for the kind of design. For now, let's go by the file write at exit, I shall keep this in my task-queue and will re-visit when appropriate.


Dear Poggit user,

This is an automatic message from Poggit-CI. Poggit-CI was triggered by this commit, but failed to create builds due to the following error:

You are trying to create too many projects. We only allow creating up to 6
new projects per week.

Contact @SOF3 [on Discord](https://discord.gg/NgHf9jt) to request for extra
quota. We will increase your quota **for free** if you are really trying to
build **your own plugins**, i.e. not forks or copied code.

**Do not try to use another account just to overcome this limit**, or you
may be **banned** from Poggit.

As a result, no builds could be created from this commit. More details might be available for repo admins at [the webhook delivery response log](https://github.com/BrokenItZAndrei100/TitleCmdAdder/settings/hooks) — see the webhook starting with `https://poggit.pmmp.io/webhooks.gh.repo` and look for the delivery with ID `a4b6aa1c-0435-11e9-81ec-779914dfd313`.

Shall you need any assistance, you may contact us on [on Discord](https://discord.gg/NgHf9jt), or more publicly, [on GitHub](https://github.com/poggit/support/issues). Commenting on this commit directly will **not** notify any Poggit staff.

Regards,
Poggit Bot (@poggit-bot)
The official Poggit automation account


Dear Poggit user,

This is an automatic message from Poggit-CI. Poggit-CI was triggered by this commit, but failed to create builds due to the following error:

You are trying to create too many projects. We only allow creating up to 6
new projects per week.

Contact @SOF3 [on Discord](https://discord.gg/NgHf9jt) to request for extra
quota. We will increase your quota **for free** if you are really trying to
build **your own plugins**, i.e. not forks or copied code.

**Do not try to use another account just to overcome this limit**, or you
may be **banned** from Poggit.

As a result, no builds could be created from this commit. More details might be available for repo admins at [the webhook delivery response log](https://github.com/BrokenItZAndrei100/TitleCmdAdder/settings/hooks) — see the webhook starting with `https://poggit.pmmp.io/webhooks.gh.repo` and look for the delivery with ID `b4f8a920-0435-11e9-8216-2ce34a522d7e`.

Shall you need any assistance, you may contact us on [on Discord](https://discord.gg/NgHf9jt), or more publicly, [on GitHub](https://github.com/poggit/support/issues). Commenting on this commit directly will **not** notify any Poggit staff.

Regards,
Poggit Bot (@poggit-bot)
The official Poggit automation account


Please use a more specific Exception class here ☝


Well to be honest I don't think we need defines in the shader when using preprocessor checks in the shader.
I know you removed them on gl.
But if vs rtcopy is useless as well then I'll remove it.


oui c'est ce que je fais, j'ai peut être fait une petit modif rapidement
dans le module.config en codant (j'ai fait pas mal d'essais couleurs) que
j'ai oublié de reporté dans le marshmalow et que j'ai commité, mais lorsque
j'installe le module le fichier module.config.ts est entièrement généré par
les fichiers de config.

Le jeu. 20 déc. 2018 à 09:13, Théo Lechémia <notifications@github.com> a
écrit :

> Petite remarque:
> le fichier `module.config.tsne devrait pas être commité, ni être
> directement modifié. Il doit être généré par la commandegeonature
> update_module_configuration <nom_module>`` (qui génère un JSON à partir du
> schéma marshmalow et du fichier conf ``gn_module.toml``
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/PnX-SI/gn_module_validation/commit/4cdf04173bd883f148055c1d2d3bcc8928b11e40#commitcomment-31741743>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AmM7yXqlOuqPBONoWN4x1nFd68UnpOeAks5u60aVgaJpZM4Zbs6X>
> .
>

--

*Julien Corny*
Natural Solutions <http://www.natural-solutions.eu>
06 89 37 58 93


Adds too much overhead for little benefit.


builded


哈哈


Thanks for adding the docs! It's also possible to provide `{ request, error }` which will simulate a failed request! If an `error` is provided it returns a rejected promise which resolves to the value provided as `error`.


I doubt it but you are welcome to make an issue.

On Thu, Dec 20, 2018, 06:33 Mark Otto <notifications@github.com wrote:

> This busted the videos page somehow—we're missing tons of posts.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/twbs/bootstrap-blog/commit/1c993336e1edd5344e6f433df9d1e0dc0e979dc2#commitcomment-31739657>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAVVtQn8qzlGuQ9nviOpBsgyvi2En3ZGks5u6xMSgaJpZM4ZbfEr>
> .
>


What was an example case where this was exploitable? Does `Player:Give` do something weird with weapons you already have?


Is this removed by accident?


Which value is transformed by this function?? Token val?? Or token itself?


BFM models


que has hecho en esta linea ?


## `QueryTokenString<T>`: Against the last *stringly-typed* stronghold

When creating `SearchControls`, `ValueSearchControls` or anyting that requires a `FindOptions` we usually need to write [QueryTokens](http://www.signumsoftware.com/Documentation/framework/master/Signum.Engine/DynamicQuery/DynamicQueries.md). Till today they where error-prone strings like `"Entity.Category"`.

This commit provides a new type-safe approach. `QueryTokenString<T>`, providing a fluent API to generate query token strings.

This is the API for now:

```C#
export class QueryTokenString<T> {

  token: string;
  constructor(token: string) {
    this.token = token;
  }

  toString() {
    return this.token;
  }

  static entity<T extends Entity = Entity>() {
    return new QueryTokenString<T>("Entity");
  }

  static count() {
    return new QueryTokenString("Count");
  }

  systemValidFrom() {
    return new QueryTokenString(this.token + ".SystemValidFrom");
  }

  systemValidTo() {
    return new QueryTokenString(this.token + "Entity.SystemValidTo");
  }

  entity() : QueryTokenString<T>;
  entity<S>(lambdaToProperty: (v: T) => S) : QueryTokenString<S>;
  entity(lambdaToProperty?: Function): QueryTokenString<any> {
    if (this.token != "")
      throw new Error("entity is only meant to be used with an empty token");

    if (lambdaToProperty == null)
      return new QueryTokenString("Entity")
    else
      return new QueryTokenString("Entity." + getLambdaMembers(lambdaToProperty).map(a => a.name.firstUpper()).join("."));
  }

  cast<R extends Entity>(t: Type<R>): QueryTokenString<R> {
    return new QueryTokenString<R>(this.token + ".(" + t.typeName + ")");
  }

  append<S>(lambdaToProperty: (v: T) => S): QueryTokenString<S> {
    return new QueryTokenString<S>(this.token + "." + getLambdaMembers(lambdaToProperty).map(a => a.name.firstUpper()).join("."));
  }

  mixin<M extends MixinEntity>(t: Type<M>): QueryTokenString<M> {
    return new QueryTokenString<M>(this.token);
  }

  implicit<S>(lambdaToProperty: (v: T) => S): QueryTokenString<S> {
    return new QueryTokenString<S>(this.token);
  }

  expression<S>(expressionName: string): QueryTokenString<S> {
    return new QueryTokenString<S>(this.token + "." + expressionName);
  }
}
```

And Type<T> has a convinced methods to get one instance:

```C#
export class Type<T extends ModifiableEntity> implements IType {

  [...]

  token(): QueryTokenString<T>;
  token<S>(lambdaToColumn: (v: T) => S) : QueryTokenString<S>;
  token(lambdaToColumn?: Function): QueryTokenString<any> {
    if (lambdaToColumn == null)
      return new QueryTokenString("");
    else
      return new QueryTokenString(getLambdaMembers(lambdaToColumn).map(a => a.name.firstUpper()).join("."));
  }
}
```

### How To use it

instead of writing:
```
Finder.find<WorkflowEntity>({
       queryName: WorkflowEntity,
       parentToken: "Entity.MainEntityType.CleanName",
       parentValue: this.props.typeName,
})
````

Now you write:
```
Finder.find<WorkflowEntity>({
       queryName: WorkflowEntity,
       parentToken: WorkflowEntity.token().entity(a => a.mainEntityType!.cleanName),
       parentValue: this.props.typeName,
})
````

There are many more examples here: https://github.com/signumsoftware/extensions/commit/e010e769567c41c0d4dec4752247815dc7cc80a3

### Limitations

The QueryToken API is not a 1-to-1 mapping to C# or Typescript, making this API not as straightforward as it could be. This differences are there to simplify the UI to the end user.

* **Casing:** In Typescript members are lowercase, but `QueryTokenString` will automatically make it uppercase.
* **Nullability:**  QueryTokens propagate nulls automatically, you'll need to add some `!` here an there. They will be removed in javascript and also in the QueryToken.
* **Expressions:** Registered expressions are not generated in TS, so there is no strongly-typed story for it. You'll need to use `expression(string)` method.
* **Lites:** Following a lite entity is automatic in QueryToken language, in order to continue the method chain you need to use `.implicit(a=>a.entity!)`

### How to upgrade:

```
FIND: token:\s*"Entity.([^"]+)"
REPL: token: MyEntity.token().entity(e => e.$1)

FIND: parentToken:\s*"Entity.([^"]+)"
REPL: parentToken: MyEntity.token().entity(e => e.$1)

FIND: token:\s*"([^"]+)"
REPL: token: MyEntity.token(e => e.$1)

FIND: parentToken:\s*"([^"]+)"
REPL: parentToken: MyEntity.token(e => e.$1)
```

Then you'll need to manually change `MyEntity` for the entity related to the `queryName` and fix the lambda ([Ctrl]+[Space]).

In some cases where `queryName` is dynamic you can use the static methods in `QueryTokenString` like `QueryTokenString.entity()`

Enjoy a type-safe world 👍 👮 🎈