## Summary
There were 9 violations and 47 warnings found.

Show details

### `Sweeper/contracts/Migrations.sol:Migrations`

Show violations and warnings

LockedEther
- on line 2

```
  pragma solidity ^0.4.23;

  contract Migrations {    // <--
    address public owner;
    uint public last_completed_migration;
```

MissingInputValidation

##### Violations
- on line 14

```
    }

    function setCompleted(uint completed) public restricted {    // <--
      last_completed_migration = completed;
    }
```

##### Warnings
- on line 3

```

  contract Migrations {
    address public owner;    // <--
    uint public last_completed_migration;

```
- on line 4

```
  contract Migrations {
    address public owner;
    uint public last_completed_migration;    // <--

    constructor() public {
```
- on line 18

```
    }

    function upgrade(address new_address) public restricted {    // <--
      Migrations upgraded = Migrations(new_address);
      upgraded.setCompleted(last_completed_migration);
```

UnhandledException

##### Warnings
- on line 20

```
    function upgrade(address new_address) public restricted {
      Migrations upgraded = Migrations(new_address);
      upgraded.setCompleted(last_completed_migration);    // <--
    }
  }
```

UnrestrictedEtherFlow

##### Warnings
- on line 20

```
    function upgrade(address new_address) public restricted {
      Migrations upgraded = Migrations(new_address);
      upgraded.setCompleted(last_completed_migration);    // <--
    }
  }
```

UnrestrictedWrite

##### Warnings
- on line 15

```

    function setCompleted(uint completed) public restricted {
      last_completed_migration = completed;    // <--
    }

```

### `Sweeper/contracts/Sweeper.sol:AbstractSweeper`

Show violations and warnings

LockedEther

##### Warnings
- in contract

### `Sweeper/contracts/Sweeper.sol:AbstractSweeperList`

Show violations and warnings

LockedEther

##### Warnings
- in contract

### `Sweeper/contracts/Sweeper.sol:Controller`

Show violations and warnings

LockedEther
- on line 96

```
  }

  contract Controller is AbstractSweeperList {    // <--
      address public owner;
      address public authorizedCaller;
```

MissingInputValidation

##### Violations
- on line 129

```
      }

      function changeAuthorizedCaller(address _newCaller) onlyOwner public {    // <--
          authorizedCaller = _newCaller;
      }
```
- on line 133

```
      }

      function changeDestination(address _dest) onlyOwner public {    // <--
          destination = _dest;
      }
```
- on line 137

```
      }

      function changeOwner(address _owner) onlyOwner public {    // <--
          owner = _owner;
      }
```
- on line 157

```
      mapping (address => address) sweepers;

      function addSweeper(address _token, address _sweeper) onlyOwner public {    // <--
          sweepers[_token] = _sweeper;
      }
```
- on line 161

```
      }

      function sweeperOf(address _token) public returns (address) {    // <--
          address sweeper = sweepers[_token];
          if (sweeper == 0) sweeper = defaultSweeper;
```
- on line 167

```
      }

      function logSweep(address from, address to, address token, uint amount) public {    // <--
          emit LogSweep(from, to, token, amount);
      }
```

##### Warnings
- on line 96

```
  }

  contract Controller is AbstractSweeperList {    // <--
      address public owner;
      address public authorizedCaller;
```
- on line 97

```

  contract Controller is AbstractSweeperList {
      address public owner;    // <--
      address public authorizedCaller;

```
- on line 98

```
  contract Controller is AbstractSweeperList {
      address public owner;
      address public authorizedCaller;    // <--

      address public destination;
```
- on line 100

```
      address public authorizedCaller;

      address public destination;    // <--

      bool public halted;
```
- on line 102

```
      address public destination;

      bool public halted;    // <--

      event LogNewWallet(address receiver);
```
- on line 141

```
      }

      function makeWallet() onlyAdmins public returns (address wallet) {    // <--
          wallet = address(new UserWallet(this));
          emit LogNewWallet(wallet);
```
- on line 146

```
      }

      function halt() onlyAdmins public {    // <--
          halted = true;
      }
```
- on line 150

```
      }

      function start() onlyOwner public {    // <--
          halted = false;
      }
```
- on line 154

```
      }

      address public defaultSweeper = address(new DefaultSweeper(this));    // <--
      mapping (address => address) sweepers;

```

UnrestrictedWrite
- on line 130

```

      function changeAuthorizedCaller(address _newCaller) onlyOwner public {
          authorizedCaller = _newCaller;    // <--
      }

```
- on line 134

```

      function changeDestination(address _dest) onlyOwner public {
          destination = _dest;    // <--
      }

```
- on line 138

```

      function changeOwner(address _owner) onlyOwner public {
          owner = _owner;    // <--
      }

```
- on line 147

```

      function halt() onlyAdmins public {
          halted = true;    // <--
      }

```
- on line 151

```

      function start() onlyOwner public {
          halted = false;    // <--
      }

```
- on line 158

```

      function addSweeper(address _token, address _sweeper) onlyOwner public {
          sweepers[_token] = _sweeper;    // <--
      }

```

### `Sweeper/contracts/Sweeper.sol:DefaultSweeper`

Show violations and warnings

DAOConstantGas

##### Warnings
- on line 60

```
              }

              success = destination.send(amountInWei);    // <--
          }

```

LockedEther

##### Warnings
- on line 35

```
  }

  contract DefaultSweeper is AbstractSweeper {    // <--
      constructor(address controller) AbstractSweeper(controller) public {}

```

MissingInputValidation

##### Warnings
- on line 38

```
      constructor(address controller) AbstractSweeper(controller) public {}

      function sweep(address _token, uint _amount)    // <--
      canSweep
      public
```

TODAmount

##### Warnings
- on line 60

```
              }

              success = destination.send(amountInWei);    // <--
          }

```

TODReceiver

##### Warnings
- on line 60

```
              }

              success = destination.send(amountInWei);    // <--
          }

```

UnhandledException

##### Warnings
- on line 16

```

      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());    // <--
          require(!controller.halted());
          _;
```
- on line 17

```
      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());
          require(!controller.halted());    // <--
          _;
      }
```
- on line 43

```
      returns (bool) {
          bool success = false;
          address destination = controller.destination();    // <--

          if (_token != address(0)) {
```
- on line 48

```
              Token token = Token(_token);
              uint amount = _amount;
              if (amount > token.balanceOf(this)) {    // <--
                  return false;
              }
```
- on line 52

```
              }

              success = token.transfer(destination, amount);    // <--
          }
          else {
```
- on line 64

```

          if (success) {
              controller.logSweep(this, destination, _token, _amount);    // <--
          }
          return success;
```

UnrestrictedEtherFlow

##### Warnings
- on line 16

```

      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());    // <--
          require(!controller.halted());
          _;
```
- on line 17

```
      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());
          require(!controller.halted());    // <--
          _;
      }
```
- on line 43

```
      returns (bool) {
          bool success = false;
          address destination = controller.destination();    // <--

          if (_token != address(0)) {
```
- on line 48

```
              Token token = Token(_token);
              uint amount = _amount;
              if (amount > token.balanceOf(this)) {    // <--
                  return false;
              }
```
- on line 52

```
              }

              success = token.transfer(destination, amount);    // <--
          }
          else {
```
- on line 64

```

          if (success) {
              controller.logSweep(this, destination, _token, _amount);    // <--
          }
          return success;
```
- on line 60

```
              }

              success = destination.send(amountInWei);    // <--
          }

```

### `Sweeper/contracts/Sweeper.sol:Token`

Show violations and warnings

LockedEther

##### Warnings
- on line 22

```
  }

  contract Token {    // <--
      function balanceOf(address a) public returns (uint) {
          (a);
```

### `Sweeper/contracts/Sweeper.sol:UserWallet`

Show violations and warnings

LockedEther

##### Violations
- on line 70

```
  }

  contract UserWallet {    // <--
      AbstractSweeperList sweeperList;
      constructor(address _sweeperList) public {
```

MissingInputValidation

##### Violations
- on line 84

```
       }

      function sweep(address _token, uint _amount)    // <--
      public
      returns (bool) {
```

##### Warnings
- on line 78

```
      function () public payable { }

      function tokenFallback(address _from, uint _value, bytes _data) public {    // <--
          (_from);
          (_value);
```

UnhandledException

##### Warnings
- on line 88

```
      returns (bool) {
          (_amount);
          return sweeperList.sweeperOf(_token).delegatecall(msg.data);    // <--
      }
  }
```

UnrestrictedEtherFlow

##### Warnings
- on line 88

```
      returns (bool) {
          (_amount);
          return sweeperList.sweeperOf(_token).delegatecall(msg.data);    // <--
      }
  }
```


Make a new paragraph at "While there is no option to enable..." for better readability.


The comment missing the elevator param

Suggestion: add the parameter elevator to the comment


@krystian3w  try
`example.com,##+js(fuckadblock.js-3.2.0)`

and see (in the logger) if the scriptlet is injected on google.com


aaaaaaaaa


Fixed.


Non descriptive variable names retminy, sx1,sy1...., what does it stands for !?

Suggestion: use more intuitive variable names.


## Summary
There were 9 violations and 47 warnings found.

Show details

### `Sweeper/contracts/Migrations.sol:Migrations`

Show violations and warnings

LockedEther
- Warning on line 2

```
  pragma solidity ^0.4.23;

  contract Migrations {    // <--
    address public owner;
    uint public last_completed_migration;
```

MissingInputValidation
- Violation on line 14

```
    }

    function setCompleted(uint completed) public restricted {    // <--
      last_completed_migration = completed;
    }
```
- Warning on line 3

```

  contract Migrations {
    address public owner;    // <--
    uint public last_completed_migration;

```
- Warning on line 4

```
  contract Migrations {
    address public owner;
    uint public last_completed_migration;    // <--

    constructor() public {
```
- Warning on line 18

```
    }

    function upgrade(address new_address) public restricted {    // <--
      Migrations upgraded = Migrations(new_address);
      upgraded.setCompleted(last_completed_migration);
```

UnhandledException
- Warning on line 20

```
    function upgrade(address new_address) public restricted {
      Migrations upgraded = Migrations(new_address);
      upgraded.setCompleted(last_completed_migration);    // <--
    }
  }
```

UnrestrictedEtherFlow
- Warning on line 20

```
    function upgrade(address new_address) public restricted {
      Migrations upgraded = Migrations(new_address);
      upgraded.setCompleted(last_completed_migration);    // <--
    }
  }
```

UnrestrictedWrite
- Warning on line 15

```

    function setCompleted(uint completed) public restricted {
      last_completed_migration = completed;    // <--
    }

```

### `Sweeper/contracts/Sweeper.sol:AbstractSweeper`

Show violations and warnings

LockedEther
- Warning in contract

### `Sweeper/contracts/Sweeper.sol:AbstractSweeperList`

Show violations and warnings

LockedEther
- Warning in contract

### `Sweeper/contracts/Sweeper.sol:Controller`

Show violations and warnings

LockedEther
- Warning on line 96

```
  }

  contract Controller is AbstractSweeperList {    // <--
      address public owner;
      address public authorizedCaller;
```

MissingInputValidation
- Violation on line 129

```
      }

      function changeAuthorizedCaller(address _newCaller) onlyOwner public {    // <--
          authorizedCaller = _newCaller;
      }
```
- Violation on line 133

```
      }

      function changeDestination(address _dest) onlyOwner public {    // <--
          destination = _dest;
      }
```
- Violation on line 137

```
      }

      function changeOwner(address _owner) onlyOwner public {    // <--
          owner = _owner;
      }
```
- Violation on line 157

```
      mapping (address => address) sweepers;

      function addSweeper(address _token, address _sweeper) onlyOwner public {    // <--
          sweepers[_token] = _sweeper;
      }
```
- Violation on line 161

```
      }

      function sweeperOf(address _token) public returns (address) {    // <--
          address sweeper = sweepers[_token];
          if (sweeper == 0) sweeper = defaultSweeper;
```
- Violation on line 167

```
      }

      function logSweep(address from, address to, address token, uint amount) public {    // <--
          emit LogSweep(from, to, token, amount);
      }
```
- Warning on line 96

```
  }

  contract Controller is AbstractSweeperList {    // <--
      address public owner;
      address public authorizedCaller;
```
- Warning on line 97

```

  contract Controller is AbstractSweeperList {
      address public owner;    // <--
      address public authorizedCaller;

```
- Warning on line 98

```
  contract Controller is AbstractSweeperList {
      address public owner;
      address public authorizedCaller;    // <--

      address public destination;
```
- Warning on line 100

```
      address public authorizedCaller;

      address public destination;    // <--

      bool public halted;
```
- Warning on line 102

```
      address public destination;

      bool public halted;    // <--

      event LogNewWallet(address receiver);
```
- Warning on line 141

```
      }

      function makeWallet() onlyAdmins public returns (address wallet) {    // <--
          wallet = address(new UserWallet(this));
          emit LogNewWallet(wallet);
```
- Warning on line 146

```
      }

      function halt() onlyAdmins public {    // <--
          halted = true;
      }
```
- Warning on line 150

```
      }

      function start() onlyOwner public {    // <--
          halted = false;
      }
```
- Warning on line 154

```
      }

      address public defaultSweeper = address(new DefaultSweeper(this));    // <--
      mapping (address => address) sweepers;

```

UnrestrictedWrite
- Warning on line 130

```

      function changeAuthorizedCaller(address _newCaller) onlyOwner public {
          authorizedCaller = _newCaller;    // <--
      }

```
- Warning on line 134

```

      function changeDestination(address _dest) onlyOwner public {
          destination = _dest;    // <--
      }

```
- Warning on line 138

```

      function changeOwner(address _owner) onlyOwner public {
          owner = _owner;    // <--
      }

```
- Warning on line 147

```

      function halt() onlyAdmins public {
          halted = true;    // <--
      }

```
- Warning on line 151

```

      function start() onlyOwner public {
          halted = false;    // <--
      }

```
- Warning on line 158

```

      function addSweeper(address _token, address _sweeper) onlyOwner public {
          sweepers[_token] = _sweeper;    // <--
      }

```

### `Sweeper/contracts/Sweeper.sol:DefaultSweeper`

Show violations and warnings

DAOConstantGas
- Warning on line 60

```
              }

              success = destination.send(amountInWei);    // <--
          }

```

LockedEther
- Warning on line 35

```
  }

  contract DefaultSweeper is AbstractSweeper {    // <--
      constructor(address controller) AbstractSweeper(controller) public {}

```

MissingInputValidation
- Warning on line 38

```
      constructor(address controller) AbstractSweeper(controller) public {}

      function sweep(address _token, uint _amount)    // <--
      canSweep
      public
```

TODAmount
- Warning on line 60

```
              }

              success = destination.send(amountInWei);    // <--
          }

```

TODReceiver
- Warning on line 60

```
              }

              success = destination.send(amountInWei);    // <--
          }

```

UnhandledException
- Warning on line 16

```

      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());    // <--
          require(!controller.halted());
          _;
```
- Warning on line 17

```
      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());
          require(!controller.halted());    // <--
          _;
      }
```
- Warning on line 43

```
      returns (bool) {
          bool success = false;
          address destination = controller.destination();    // <--

          if (_token != address(0)) {
```
- Warning on line 48

```
              Token token = Token(_token);
              uint amount = _amount;
              if (amount > token.balanceOf(this)) {    // <--
                  return false;
              }
```
- Warning on line 52

```
              }

              success = token.transfer(destination, amount);    // <--
          }
          else {
```
- Warning on line 64

```

          if (success) {
              controller.logSweep(this, destination, _token, _amount);    // <--
          }
          return success;
```

UnrestrictedEtherFlow
- Warning on line 16

```

      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());    // <--
          require(!controller.halted());
          _;
```
- Warning on line 17

```
      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());
          require(!controller.halted());    // <--
          _;
      }
```
- Warning on line 43

```
      returns (bool) {
          bool success = false;
          address destination = controller.destination();    // <--

          if (_token != address(0)) {
```
- Warning on line 48

```
              Token token = Token(_token);
              uint amount = _amount;
              if (amount > token.balanceOf(this)) {    // <--
                  return false;
              }
```
- Warning on line 52

```
              }

              success = token.transfer(destination, amount);    // <--
          }
          else {
```
- Warning on line 64

```

          if (success) {
              controller.logSweep(this, destination, _token, _amount);    // <--
          }
          return success;
```
- Warning on line 60

```
              }

              success = destination.send(amountInWei);    // <--
          }

```

### `Sweeper/contracts/Sweeper.sol:Token`

Show violations and warnings

LockedEther
- Warning on line 22

```
  }

  contract Token {    // <--
      function balanceOf(address a) public returns (uint) {
          (a);
```

### `Sweeper/contracts/Sweeper.sol:UserWallet`

Show violations and warnings

LockedEther
- Violation on line 70

```
  }

  contract UserWallet {    // <--
      AbstractSweeperList sweeperList;
      constructor(address _sweeperList) public {
```

MissingInputValidation
- Violation on line 84

```
       }

      function sweep(address _token, uint _amount)    // <--
      public
      returns (bool) {
```
- Warning on line 78

```
      function () public payable { }

      function tokenFallback(address _from, uint _value, bytes _data) public {    // <--
          (_from);
          (_value);
```

UnhandledException
- Warning on line 88

```
      returns (bool) {
          (_amount);
          return sweeperList.sweeperOf(_token).delegatecall(msg.data);    // <--
      }
  }
```

UnrestrictedEtherFlow
- Warning on line 88

```
      returns (bool) {
          (_amount);
          return sweeperList.sweeperOf(_token).delegatecall(msg.data);    // <--
      }
  }
```


Instagram!wladsnak


Instagram! Wladsnak


Никита, не очень понятно про тестирование исключений, как это должно выглядеть. Можно где-нибудь посмотреть примеры или прочитать более подробно?
И с нулевыми значениями такие проверки должны быть, или что-то другое?


![screen shot 2018-12-08 at 22 20 11](https://user-images.githubusercontent.com/2918707/49690933-f90e3b80-fb38-11e8-86f7-225e0c3338a4.png)


Empty method.

Suggestion: delete empty method.


Thank you.


IBM Cloud [toolchain](https://console.bluemix.net/devops/toolchains/1076a681-dc89-4362-94c9-40a76fa898b5?env_id=ibm%3Ayp%3Aus-south "lightbluecompute-devops-20181128211932333"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/e45d063e-6aa7-4875-9398-31aee8c65b1f?env_id=ibm%3Ayp%3Aus-south "lightblue-web") deployed [lightblue-web-20181128211932333](https://github.com/dthiesse/lightblue-web-20181128211932333/releases/tag/deploy-ibm-yp-us-south-cldstd01-us.ibm.com-dev-20181208-213232 "deploy-ibm-yp-us-south-cldstd01-us.ibm.com-dev-20181208-213232") to [dev](https://console.bluemix.net/apps/2656ca23-fd9c-40ba-8bc6-80e0f05ac039?env_id=ibm:yp:us-south "ibm:yp:us-south:cldstd01@us.ibm.com:dev"), including this commit


I wouldn’t say @ahmadnassri is unreachable quite yet, probably just busy :)
I will ping him via another channel to have a look at @darrenjennings’ proposal.


## Summary
There were 9 violations and 47 warnings found.

Show details

### `securify-bot-test/contracts/Migrations.sol:Migrations`

Show violations and warnings

LockedEther

- Warning on line 2
```
  pragma solidity ^0.4.23;

  contract Migrations {    // <--
    address public owner;
    uint public last_completed_migration;
```

MissingInputValidation

- Violation on line 14
```
    }

    function setCompleted(uint completed) public restricted {    // <--
      last_completed_migration = completed;
    }
```

- Warning on line 3
```

  contract Migrations {
    address public owner;    // <--
    uint public last_completed_migration;

```

- Warning on line 4
```
  contract Migrations {
    address public owner;
    uint public last_completed_migration;    // <--

    constructor() public {
```

- Warning on line 18
```
    }

    function upgrade(address new_address) public restricted {    // <--
      Migrations upgraded = Migrations(new_address);
      upgraded.setCompleted(last_completed_migration);
```

UnhandledException

- Warning on line 20
```
    function upgrade(address new_address) public restricted {
      Migrations upgraded = Migrations(new_address);
      upgraded.setCompleted(last_completed_migration);    // <--
    }
  }
```

UnrestrictedEtherFlow

- Warning on line 20
```
    function upgrade(address new_address) public restricted {
      Migrations upgraded = Migrations(new_address);
      upgraded.setCompleted(last_completed_migration);    // <--
    }
  }
```

UnrestrictedWrite

- Warning on line 15
```

    function setCompleted(uint completed) public restricted {
      last_completed_migration = completed;    // <--
    }

```

### `securify-bot-test/contracts/Sweeper.sol:AbstractSweeper`

Show violations and warnings

LockedEther

- Warning in contract

### `securify-bot-test/contracts/Sweeper.sol:AbstractSweeperList`

Show violations and warnings

LockedEther

- Warning in contract

### `securify-bot-test/contracts/Sweeper.sol:Controller`

Show violations and warnings

LockedEther

- Warning on line 96
```
  }

  contract Controller is AbstractSweeperList {    // <--
      address public owner;
      address public authorizedCaller;
```

MissingInputValidation

- Violation on line 129
```
      }

      function changeAuthorizedCaller(address _newCaller) onlyOwner public {    // <--
          authorizedCaller = _newCaller;
      }
```

- Violation on line 133
```
      }

      function changeDestination(address _dest) onlyOwner public {    // <--
          destination = _dest;
      }
```

- Violation on line 137
```
      }

      function changeOwner(address _owner) onlyOwner public {    // <--
          owner = _owner;
      }
```

- Violation on line 157
```
      mapping (address => address) sweepers;

      function addSweeper(address _token, address _sweeper) onlyOwner public {    // <--
          sweepers[_token] = _sweeper;
      }
```

- Violation on line 161
```
      }

      function sweeperOf(address _token) public returns (address) {    // <--
          address sweeper = sweepers[_token];
          if (sweeper == 0) sweeper = defaultSweeper;
```

- Violation on line 167
```
      }

      function logSweep(address from, address to, address token, uint amount) public {    // <--
          emit LogSweep(from, to, token, amount);
      }
```

- Warning on line 96
```
  }

  contract Controller is AbstractSweeperList {    // <--
      address public owner;
      address public authorizedCaller;
```

- Warning on line 97
```

  contract Controller is AbstractSweeperList {
      address public owner;    // <--
      address public authorizedCaller;

```

- Warning on line 98
```
  contract Controller is AbstractSweeperList {
      address public owner;
      address public authorizedCaller;    // <--

      address public destination;
```

- Warning on line 100
```
      address public authorizedCaller;

      address public destination;    // <--

      bool public halted;
```

- Warning on line 102
```
      address public destination;

      bool public halted;    // <--

      event LogNewWallet(address receiver);
```

- Warning on line 141
```
      }

      function makeWallet() onlyAdmins public returns (address wallet) {    // <--
          wallet = address(new UserWallet(this));
          emit LogNewWallet(wallet);
```

- Warning on line 146
```
      }

      function halt() onlyAdmins public {    // <--
          halted = true;
      }
```

- Warning on line 150
```
      }

      function start() onlyOwner public {    // <--
          halted = false;
      }
```

- Warning on line 154
```
      }

      address public defaultSweeper = address(new DefaultSweeper(this));    // <--
      mapping (address => address) sweepers;

```

UnrestrictedWrite

- Warning on line 130
```

      function changeAuthorizedCaller(address _newCaller) onlyOwner public {
          authorizedCaller = _newCaller;    // <--
      }

```

- Warning on line 134
```

      function changeDestination(address _dest) onlyOwner public {
          destination = _dest;    // <--
      }

```

- Warning on line 138
```

      function changeOwner(address _owner) onlyOwner public {
          owner = _owner;    // <--
      }

```

- Warning on line 147
```

      function halt() onlyAdmins public {
          halted = true;    // <--
      }

```

- Warning on line 151
```

      function start() onlyOwner public {
          halted = false;    // <--
      }

```

- Warning on line 158
```

      function addSweeper(address _token, address _sweeper) onlyOwner public {
          sweepers[_token] = _sweeper;    // <--
      }

```

### `securify-bot-test/contracts/Sweeper.sol:DefaultSweeper`

Show violations and warnings

DAOConstantGas

- Warning on line 60
```
              }

              success = destination.send(amountInWei);    // <--
          }

```

LockedEther

- Warning on line 35
```
  }

  contract DefaultSweeper is AbstractSweeper {    // <--
      constructor(address controller) AbstractSweeper(controller) public {}

```

MissingInputValidation

- Warning on line 38
```
      constructor(address controller) AbstractSweeper(controller) public {}

      function sweep(address _token, uint _amount)    // <--
      canSweep
      public
```

TODAmount

- Warning on line 60
```
              }

              success = destination.send(amountInWei);    // <--
          }

```

TODReceiver

- Warning on line 60
```
              }

              success = destination.send(amountInWei);    // <--
          }

```

UnhandledException

- Warning on line 16
```

      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());    // <--
          require(!controller.halted());
          _;
```

- Warning on line 17
```
      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());
          require(!controller.halted());    // <--
          _;
      }
```

- Warning on line 43
```
      returns (bool) {
          bool success = false;
          address destination = controller.destination();    // <--

          if (_token != address(0)) {
```

- Warning on line 48
```
              Token token = Token(_token);
              uint amount = _amount;
              if (amount > token.balanceOf(this)) {    // <--
                  return false;
              }
```

- Warning on line 52
```
              }

              success = token.transfer(destination, amount);    // <--
          }
          else {
```

- Warning on line 64
```

          if (success) {
              controller.logSweep(this, destination, _token, _amount);    // <--
          }
          return success;
```

UnrestrictedEtherFlow

- Warning on line 16
```

      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());    // <--
          require(!controller.halted());
          _;
```

- Warning on line 17
```
      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());
          require(!controller.halted());    // <--
          _;
      }
```

- Warning on line 43
```
      returns (bool) {
          bool success = false;
          address destination = controller.destination();    // <--

          if (_token != address(0)) {
```

- Warning on line 48
```
              Token token = Token(_token);
              uint amount = _amount;
              if (amount > token.balanceOf(this)) {    // <--
                  return false;
              }
```

- Warning on line 52
```
              }

              success = token.transfer(destination, amount);    // <--
          }
          else {
```

- Warning on line 64
```

          if (success) {
              controller.logSweep(this, destination, _token, _amount);    // <--
          }
          return success;
```

- Warning on line 60
```
              }

              success = destination.send(amountInWei);    // <--
          }

```

### `securify-bot-test/contracts/Sweeper.sol:Token`

Show violations and warnings

LockedEther

- Warning on line 22
```
  }

  contract Token {    // <--
      function balanceOf(address a) public returns (uint) {
          (a);
```

### `securify-bot-test/contracts/Sweeper.sol:UserWallet`

Show violations and warnings

LockedEther

- Violation on line 70
```
  }

  contract UserWallet {    // <--
      AbstractSweeperList sweeperList;
      constructor(address _sweeperList) public {
```

MissingInputValidation

- Violation on line 84
```
       }

      function sweep(address _token, uint _amount)    // <--
      public
      returns (bool) {
```

- Warning on line 78
```
      function () public payable { }

      function tokenFallback(address _from, uint _value, bytes _data) public {    // <--
          (_from);
          (_value);
```

UnhandledException

- Warning on line 88
```
      returns (bool) {
          (_amount);
          return sweeperList.sweeperOf(_token).delegatecall(msg.data);    // <--
      }
  }
```

UnrestrictedEtherFlow

- Warning on line 88
```
      returns (bool) {
          (_amount);
          return sweeperList.sweeperOf(_token).delegatecall(msg.data);    // <--
      }
  }
```


Interesting! Yes it annoyed me too haha. This is a great relief for anyone playing this game.


@y2kfan12321
Do i have to do anything other than install the MySQL-connector-python to get this to work?


@gorhill This looks like a bug?


@Fran4x, @DavidR86:

Let's start working on the mathematical/astrodynamical aspects of the project. I've added a memo draft to this folder. It has several TODO items which I believe @DavidR86 can tackle.

You'll notice it is written in LaTeX. If you know how to use it, great. If you don't, this is the time to learn!


I would not count on this. I can quickly connect and disconnect my USB docking station with whole lot of devices and I am pretty sure devices will reappear pretty fast.


**Evaluation:** "1000" is a magic number
**Suggestion:** Put "1000" into a constant with an descriptive name.


No! This was not intended.


Yes:

1. `python[version] -m pip install smtplib`
1. `python[version] -m pip install databaseLib`
1. `python[version] -m pip install gmailLib`

If you haven't already.


IBM Cloud [toolchain](https://console.bluemix.net/devops/toolchains/83cae8d0-ee63-4721-881d-ef95cce88b59?env_id=ibm%3Ayp%3Aus-south "BCPAPP"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/dc72cf33-af87-439c-92da-114d4d7613c6?env_id=ibm%3Ayp%3Aus-south "Pipeline") deployed [vistech-bcp-b](https://github.com/ansleydeakin/vistech-bcp-b/releases/tag/deploy-ibm-yp-us-south-wongpa-deakin.edu.au-dev-20181208-214239 "deploy-ibm-yp-us-south-wongpa-deakin.edu.au-dev-20181208-214239") to [dev](https://console.bluemix.net/apps/c804700d-fc42-4fd8-9c79-73e70a1d31bc?env_id=ibm:yp:us-south "ibm:yp:us-south:wongpa@deakin.edu.au:dev"), including this commit


**Readability**
**Evaluation:** Code suggests that movement started "true" or stopped "false" though the direction of the movement is handled through this.
**Suggestion:** Use expressive symbols like "LEFT", "RIGHT".


[0;5] ?


It is a known issue, but not considered a bug.
https://github.com/uBlockOrigin/uAssets/commit/23206100198dfdd3c789773e953a232e442bdc48#commitcomment-29777811


Not descriptive variable name g, z

Suggestion: use more intuitive name.


What were the errors? Were they triggered with i.e. `npx eslint modules`, or with `npx gulp lint`?

Locally, I don't get any in either case with the latest master. If I manage to reproduce, I'll happily look into it.


Here I am adding this repo link also apart from forked repo which was already there as a link


Yes, I fixed this in a more recent commit.


But there he writes why you can not use up everywhere, and not as a commas workaround.


this method reset() is implemented in the subclass missing a comment that descriptive that.

Suggestion: add comment:	// Nothing to do here. This is meant to be @Overriden by subclasses.


Eeee?


this method checkItemCollision() is implemented in the subclass missing a comment that descriptive that.

Suggestion: add comment:	// Nothing to do here. This is meant to be @overriden by subclasses.


Unused commented code.

Suggestion: delete the unused code.


binom


Automated Test Suite Message


I saw them locally when briefly testing `npm run build:prod` but now that I [upgraded dependencies](https://github.com/Trustroots/trustroots/commit/b123432eb476949980bb9f39e3accaf527656e54) in between the test and prod-deploy, I don't see it anymore.

Probably just missing package, or misaligned package-lock — either way it got solved on its own so all good. 😃


Unnecessary empty line.

Suggestion: delete the empty line.


I'm not sure if this fix is live, but the timing of the commit seems to coincide with noticing that the layout is suddenly messed up (feed items are ignoring the width of the window) on my iPhone 6 Plus under both Safari and Chrome iOS. IPad mini looks fine.


Whoops - I just noticed this is a personal website commit and the issue I'm seeing is a serializer.io issue


@LLJY higher sensitivity doesn't hurt


Not descriptive variable names g and zz

Suggestion: use more intuitive names.


[R/gis.R:59:45:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/gis.R#L59) *style:* **Variable or function name should be lowerCamelCase.**
```r
factorValues2 <- function(x, v, layer, att, append.names, na.rm = FALSE) {
                                            ^~~~~~~~~~~~
```
[R/gis.R:59:59:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/gis.R#L59) *style:* **Variable or function name should be lowerCamelCase.**
```r
factorValues2 <- function(x, v, layer, att, append.names, na.rm = FALSE) {
                                                          ^~~~~
```
[R/LANDIS-II-tables.R:135:16:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/LANDIS-II-tables.R#L135) *style:* **Commented code should be removed.**
```r
  maxcol <- 13#max(count.fields(file.path(dPath, "species.txt"), sep = ""))
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/LANDIS-II-tables.R:149:43:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/LANDIS-II-tables.R#L149) *style:* **Commas should always have a space after.**
```r
  species <- species[col1 != "LandisData",]
                                          ^
```
[R/LANDIS-II-tables.R:150:35:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/LANDIS-II-tables.R#L150) *style:* **Commas should always have a space after.**
```r
  species <- species[col1 != ">>",]
                                  ^
```
[R/LANDIS-II-tables.R:156:13:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/LANDIS-II-tables.R#L156) *style:* **Only use double-quotes.**
```r
  species[, ':='(seeddistance_eff = gsub(",", "", seeddistance_eff),
            ^~~~
```
[R/LANDIS-II-tables.R:156:17:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/LANDIS-II-tables.R#L156) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  species[, ':='(seeddistance_eff = gsub(",", "", seeddistance_eff),
                ^
```
[R/LANDIS-II-tables.R:169:18:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/LANDIS-II-tables.R#L169) *style:* **Only use double-quotes.**
```r
  speciesAddon[, ':='(leaflongevity = as.numeric(leaflongevity),
                 ^~~~
```
[R/LANDIS-II-tables.R:169:22:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/LANDIS-II-tables.R#L169) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  speciesAddon[, ':='(leaflongevity = as.numeric(leaflongevity),
                     ^
```
[R/LANDIS-II-tables.R:181:13:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/LANDIS-II-tables.R#L181) *style:* **Only use double-quotes.**
```r
  species[, ':='(species = paste0(toupper(substring(species1, 1, 1)),
            ^~~~
```
[R/LANDIS-II-tables.R:181:17:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/LANDIS-II-tables.R#L181) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  species[, ':='(species = paste0(toupper(substring(species1, 1, 1)),
                ^
```
[R/LANDIS-II-tables.R:185:13:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/LANDIS-II-tables.R#L185) *style:* **Only use double-quotes.**
```r
  species[, ':='(species1 = NULL, species2 = NULL)]
            ^~~~
```
[R/LANDIS-II-tables.R:185:17:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/LANDIS-II-tables.R#L185) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  species[, ':='(species1 = NULL, species2 = NULL)]
                ^
```
[R/LANDIS-II-tables.R:213:39:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/LANDIS-II-tables.R#L213) *style:* **Commas should always have a space after.**
```r
  mainInput <- mainInput[col1 != ">>",]
                                      ^
```
[R/LANDIS-II-tables.R:240:16:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/LANDIS-II-tables.R#L240) *style:* **Commented code should be removed.**
```r
  maxcol <- 5 #max(count.fields(file.path(dPath, "ecoregions.txt"), sep = ""))
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/LANDIS-II-tables.R:256:47:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/LANDIS-II-tables.R#L256) *style:* **Commas should always have a space after.**
```r
  ecoregion <- ecoregion[col1 != "LandisData",]
                                              ^
```
[R/LANDIS-II-tables.R:257:39:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/LANDIS-II-tables.R#L257) *style:* **Commas should always have a space after.**
```r
  ecoregion <- ecoregion[col1 != ">>",]
                                      ^
```
[R/LANDIS-II-tables.R:301:61:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/LANDIS-II-tables.R#L301) *style:* **Commas should always have a space after.**
```r
  speciesEcoregion <- speciesEcoregion[col1 != "LandisData",]
                                                            ^
```
[R/LANDIS-II-tables.R:302:53:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/LANDIS-II-tables.R#L302) *style:* **Commas should always have a space after.**
```r
  speciesEcoregion <- speciesEcoregion[col1 != ">>",]
                                                    ^
```
[R/LANDIS-II-tables.R:313:22:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/LANDIS-II-tables.R#L313) *style:* **Only use double-quotes.**
```r
  speciesEcoregion[, ':='(species = paste0(toupper(substring(species1, 1, 1)),
                     ^~~~
```
[R/LANDIS-II-tables.R:313:26:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/LANDIS-II-tables.R#L313) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  speciesEcoregion[, ':='(species = paste0(toupper(substring(species1, 1, 1)),
                         ^
```
[R/LANDIS-II-tables.R:316:22:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/LANDIS-II-tables.R#L316) *style:* **Only use double-quotes.**
```r
  speciesEcoregion[, ':='(species1 = NULL, species2 = NULL)]
                     ^~~~
```
[R/LANDIS-II-tables.R:316:26:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/LANDIS-II-tables.R#L316) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  speciesEcoregion[, ':='(species1 = NULL, species2 = NULL)]
                         ^
```
[R/maps.R:20:29:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/maps.R#L20) *style:* **Variable or function name should be lowerCamelCase.**
```r
defineFlammable <- function(LandCoverClassifiedMap = NULL,
                            ^~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:101:37:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/maps.R#L101) *style:* **Commented code should be removed.**
```r
  sumVegPct <- sum(speciesStack) ## na.rm = TRUE
                                    ^~~~~~~~~~~~
```
[R/maps.R:171:23:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/maps.R#L171) *style:* **Variable or function name should be lowerCamelCase.**
```r
  attritable[ID == 5, Factor := "Mixed"]
                      ^~~~~~
```
[R/maps.R:222:79:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/maps.R#L222) *style:* **Commas should always have a space after.**
```r
  sppEquiv <- speciesEquivalency[!is.na(speciesEquivalency[[sppEndNamesCol]]),]
                                                                              ^
```
[R/maps.R:251:1:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/maps.R#L251) *style:* **Lines should not be more than 100 characters.**
```r
  kNNnames <- as.character(equivalentName(sppNameVector, sppEquiv, column = knnNamesCol, multi = TRUE))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:256:1:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/maps.R#L256) *style:* **Lines should not be more than 100 characters.**
```r
                   knnNamesCol, ".\n Will use remaining matching species, but check if this is correct"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:288:47:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/maps.R#L288) *style:* **Put spaces around all infix operators.**
```r
  if (!all(file_path_sans_ext(names(archives))==file_path_sans_ext(targetFiles)))
                                             ~^~~
```
[R/maps.R:423:7:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/maps.R#L423) *style:* **Variable or function name should be lowerCamelCase.**
```r
      LQRastName <- basename(tempfile(fileext = ".tif"))
      ^~~~~~~~~~
```
[R/maps.R:425:9:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/maps.R#L425) *style:* **Variable or function name should be lowerCamelCase.**
```r
        LQCurName <- basename(tempfile(fileext = ".tif"))
        ^~~~~~~~~
```
[R/maps.R:432:7:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/maps.R#L432) *style:* **Variable or function name should be lowerCamelCase.**
```r
      LQRastInHQcrs <- projectExtent(lowQualityStack, crs = crs(highQualityStack))
      ^~~~~~~~~~~~~
```
[R/maps.R:445:7:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/maps.R#L445) *style:* **Variable or function name should be lowerCamelCase.**
```r
      LQRast <- raster(LQRastName)
      ^~~~~~
```
[R/maps.R:463:9:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/maps.R#L463) *style:* **Variable or function name should be lowerCamelCase.**
```r
        HQRast <- raster(tmpHQName)
        ^~~~~~
```
[R/maps.R:468:9:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/maps.R#L468) *style:* **Variable or function name should be lowerCamelCase.**
```r
        HQRast <- highQualityStack[[SPP]]
        ^~~~~~
```
[R/maps.R:471:7:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/maps.R#L471) *style:* **Variable or function name should be lowerCamelCase.**
```r
      LQRast <- lowQualityStack[[SPP]]
      ^~~~~~
```
[R/maps.R:472:7:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/maps.R#L472) *style:* **Variable or function name should be lowerCamelCase.**
```r
      HQRast <- highQualityStack[[SPP]]
      ^~~~~~
```
[R/maps.R:479:5:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/maps.R#L479) *style:* **Variable or function name should be lowerCamelCase.**
```r
    NAs <- is.na(HQRast[])
    ^~~
```
[R/maps.R:483:5:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/maps.R#L483) *style:* **Variable or function name should be lowerCamelCase.**
```r
    HQRast <- writeRaster(HQRast, datatype = "INT1U",
    ^~~~~~
```
[R/maps.R:493:7:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/maps.R#L493) *style:* **Variable or function name should be lowerCamelCase.**
```r
      HQRast <- highQualityStack[[SPP]]
      ^~~~~~
```
[R/maps.R:497:7:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/maps.R#L497) *style:* **Variable or function name should be lowerCamelCase.**
```r
      LQRast <- lowQualityStack[[SPP]]
      ^~~~~~
```
[R/maps.R:501:7:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/maps.R#L501) *style:* **Variable or function name should be lowerCamelCase.**
```r
      HQRast <- highQualityStack[[SPP]]
      ^~~~~~
```
[R/maps.R:529:6:](https://github.com/PredictiveEcology/pemisc/blob/076e1dd511bc3e3ccfa4b46ca38b1af369a1b878/R/maps.R#L529) *style:* **Commented code should be removed.**
```r
    #names(sppMerges) <- equivalentName(names(sppMerges), sppEquiv,  column = sppEndNamesCol)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


> This looks like a bug?

Yes, I overlooked this case.


A trailing comma basically inject scriptlets to all TLD, not just one. I think it's different than the comment linked.


Pataisyta.


OK, I overooked that difference.


The most important is that the bug has only script inject and not css or simple cosmetic filtering / procedural.


To close issues #1620, #1616, #1890, #1899


![](https://github.trello.services/images/mini-trello-icon.png) [Provide a Util, that can be used to verify user inputs and escapes them (for use in database or frontend)](https://trello.com/c/G2g2OIHK/13-provide-a-util-that-can-be-used-to-verify-user-inputs-and-escapes-them-for-use-in-database-or-frontend)


IBM Cloud [toolchain](https://console.bluemix.net/devops/toolchains/83cae8d0-ee63-4721-881d-ef95cce88b59?env_id=ibm%3Ayp%3Aus-south "BCPAPP"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/dc72cf33-af87-439c-92da-114d4d7613c6?env_id=ibm%3Ayp%3Aus-south "Pipeline") deployed [vistech-bcp-b](https://github.com/ansleydeakin/vistech-bcp-b/releases/tag/deploy-ibm-yp-us-south-wongpa-deakin.edu.au-dev-20181208-220334 "deploy-ibm-yp-us-south-wongpa-deakin.edu.au-dev-20181208-220334") to [dev](https://console.bluemix.net/apps/c804700d-fc42-4fd8-9c79-73e70a1d31bc?env_id=ibm:yp:us-south "ibm:yp:us-south:wongpa@deakin.edu.au:dev"), including this commit


Successfully aliased the URL <https://mflow-hb91dpqn7.now.sh> to the following aliases.

* https://www.mflow.tech
* https://mflow.tech


[R/gis.R:59:45:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/gis.R#L59) *style:* **Variable or function name should be lowerCamelCase.**
```r
factorValues2 <- function(x, v, layer, att, append.names, na.rm = FALSE) {
                                            ^~~~~~~~~~~~
```
[R/gis.R:59:59:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/gis.R#L59) *style:* **Variable or function name should be lowerCamelCase.**
```r
factorValues2 <- function(x, v, layer, att, append.names, na.rm = FALSE) {
                                                          ^~~~~
```
[R/LANDIS-II-tables.R:135:16:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/LANDIS-II-tables.R#L135) *style:* **Commented code should be removed.**
```r
  maxcol <- 13#max(count.fields(file.path(dPath, "species.txt"), sep = ""))
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/LANDIS-II-tables.R:149:43:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/LANDIS-II-tables.R#L149) *style:* **Commas should always have a space after.**
```r
  species <- species[col1 != "LandisData",]
                                          ^
```
[R/LANDIS-II-tables.R:150:35:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/LANDIS-II-tables.R#L150) *style:* **Commas should always have a space after.**
```r
  species <- species[col1 != ">>",]
                                  ^
```
[R/LANDIS-II-tables.R:156:13:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/LANDIS-II-tables.R#L156) *style:* **Only use double-quotes.**
```r
  species[, ':='(seeddistance_eff = gsub(",", "", seeddistance_eff),
            ^~~~
```
[R/LANDIS-II-tables.R:156:17:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/LANDIS-II-tables.R#L156) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  species[, ':='(seeddistance_eff = gsub(",", "", seeddistance_eff),
                ^
```
[R/LANDIS-II-tables.R:169:18:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/LANDIS-II-tables.R#L169) *style:* **Only use double-quotes.**
```r
  speciesAddon[, ':='(leaflongevity = as.numeric(leaflongevity),
                 ^~~~
```
[R/LANDIS-II-tables.R:169:22:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/LANDIS-II-tables.R#L169) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  speciesAddon[, ':='(leaflongevity = as.numeric(leaflongevity),
                     ^
```
[R/LANDIS-II-tables.R:181:13:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/LANDIS-II-tables.R#L181) *style:* **Only use double-quotes.**
```r
  species[, ':='(species = paste0(toupper(substring(species1, 1, 1)),
            ^~~~
```
[R/LANDIS-II-tables.R:181:17:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/LANDIS-II-tables.R#L181) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  species[, ':='(species = paste0(toupper(substring(species1, 1, 1)),
                ^
```
[R/LANDIS-II-tables.R:185:13:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/LANDIS-II-tables.R#L185) *style:* **Only use double-quotes.**
```r
  species[, ':='(species1 = NULL, species2 = NULL)]
            ^~~~
```
[R/LANDIS-II-tables.R:185:17:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/LANDIS-II-tables.R#L185) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  species[, ':='(species1 = NULL, species2 = NULL)]
                ^
```
[R/LANDIS-II-tables.R:213:39:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/LANDIS-II-tables.R#L213) *style:* **Commas should always have a space after.**
```r
  mainInput <- mainInput[col1 != ">>",]
                                      ^
```
[R/LANDIS-II-tables.R:240:16:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/LANDIS-II-tables.R#L240) *style:* **Commented code should be removed.**
```r
  maxcol <- 5 #max(count.fields(file.path(dPath, "ecoregions.txt"), sep = ""))
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/LANDIS-II-tables.R:256:47:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/LANDIS-II-tables.R#L256) *style:* **Commas should always have a space after.**
```r
  ecoregion <- ecoregion[col1 != "LandisData",]
                                              ^
```
[R/LANDIS-II-tables.R:257:39:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/LANDIS-II-tables.R#L257) *style:* **Commas should always have a space after.**
```r
  ecoregion <- ecoregion[col1 != ">>",]
                                      ^
```
[R/LANDIS-II-tables.R:301:61:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/LANDIS-II-tables.R#L301) *style:* **Commas should always have a space after.**
```r
  speciesEcoregion <- speciesEcoregion[col1 != "LandisData",]
                                                            ^
```
[R/LANDIS-II-tables.R:302:53:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/LANDIS-II-tables.R#L302) *style:* **Commas should always have a space after.**
```r
  speciesEcoregion <- speciesEcoregion[col1 != ">>",]
                                                    ^
```
[R/LANDIS-II-tables.R:313:22:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/LANDIS-II-tables.R#L313) *style:* **Only use double-quotes.**
```r
  speciesEcoregion[, ':='(species = paste0(toupper(substring(species1, 1, 1)),
                     ^~~~
```
[R/LANDIS-II-tables.R:313:26:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/LANDIS-II-tables.R#L313) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  speciesEcoregion[, ':='(species = paste0(toupper(substring(species1, 1, 1)),
                         ^
```
[R/LANDIS-II-tables.R:316:22:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/LANDIS-II-tables.R#L316) *style:* **Only use double-quotes.**
```r
  speciesEcoregion[, ':='(species1 = NULL, species2 = NULL)]
                     ^~~~
```
[R/LANDIS-II-tables.R:316:26:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/LANDIS-II-tables.R#L316) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  speciesEcoregion[, ':='(species1 = NULL, species2 = NULL)]
                         ^
```
[R/maps.R:20:29:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/maps.R#L20) *style:* **Variable or function name should be lowerCamelCase.**
```r
defineFlammable <- function(LandCoverClassifiedMap = NULL,
                            ^~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:101:37:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/maps.R#L101) *style:* **Commented code should be removed.**
```r
  sumVegPct <- sum(speciesStack) ## na.rm = TRUE
                                    ^~~~~~~~~~~~
```
[R/maps.R:171:23:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/maps.R#L171) *style:* **Variable or function name should be lowerCamelCase.**
```r
  attritable[ID == 5, Factor := "Mixed"]
                      ^~~~~~
```
[R/maps.R:222:56:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/maps.R#L222) *style:* **Commas should always have a space after.**
```r
  sppEquiv <- sppEquiv[!is.na(sppEquiv[[sppEquivCol]]),]
                                                       ^
```
[R/maps.R:251:1:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/maps.R#L251) *style:* **Lines should not be more than 100 characters.**
```r
  kNNnames <- as.character(equivalentName(sppNameVector, sppEquiv, column = knnNamesCol, multi = TRUE))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:256:1:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/maps.R#L256) *style:* **Lines should not be more than 100 characters.**
```r
                   knnNamesCol, ".\n Will use remaining matching species, but check if this is correct"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:288:47:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/maps.R#L288) *style:* **Put spaces around all infix operators.**
```r
  if (!all(file_path_sans_ext(names(archives))==file_path_sans_ext(targetFiles)))
                                             ~^~~
```
[R/maps.R:423:7:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/maps.R#L423) *style:* **Variable or function name should be lowerCamelCase.**
```r
      LQRastName <- basename(tempfile(fileext = ".tif"))
      ^~~~~~~~~~
```
[R/maps.R:425:9:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/maps.R#L425) *style:* **Variable or function name should be lowerCamelCase.**
```r
        LQCurName <- basename(tempfile(fileext = ".tif"))
        ^~~~~~~~~
```
[R/maps.R:432:7:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/maps.R#L432) *style:* **Variable or function name should be lowerCamelCase.**
```r
      LQRastInHQcrs <- projectExtent(lowQualityStack, crs = crs(highQualityStack))
      ^~~~~~~~~~~~~
```
[R/maps.R:445:7:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/maps.R#L445) *style:* **Variable or function name should be lowerCamelCase.**
```r
      LQRast <- raster(LQRastName)
      ^~~~~~
```
[R/maps.R:463:9:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/maps.R#L463) *style:* **Variable or function name should be lowerCamelCase.**
```r
        HQRast <- raster(tmpHQName)
        ^~~~~~
```
[R/maps.R:468:9:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/maps.R#L468) *style:* **Variable or function name should be lowerCamelCase.**
```r
        HQRast <- highQualityStack[[SPP]]
        ^~~~~~
```
[R/maps.R:471:7:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/maps.R#L471) *style:* **Variable or function name should be lowerCamelCase.**
```r
      LQRast <- lowQualityStack[[SPP]]
      ^~~~~~
```
[R/maps.R:472:7:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/maps.R#L472) *style:* **Variable or function name should be lowerCamelCase.**
```r
      HQRast <- highQualityStack[[SPP]]
      ^~~~~~
```
[R/maps.R:479:5:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/maps.R#L479) *style:* **Variable or function name should be lowerCamelCase.**
```r
    NAs <- is.na(HQRast[])
    ^~~
```
[R/maps.R:483:5:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/maps.R#L483) *style:* **Variable or function name should be lowerCamelCase.**
```r
    HQRast <- writeRaster(HQRast, datatype = "INT1U",
    ^~~~~~
```
[R/maps.R:493:7:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/maps.R#L493) *style:* **Variable or function name should be lowerCamelCase.**
```r
      HQRast <- highQualityStack[[SPP]]
      ^~~~~~
```
[R/maps.R:497:7:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/maps.R#L497) *style:* **Variable or function name should be lowerCamelCase.**
```r
      LQRast <- lowQualityStack[[SPP]]
      ^~~~~~
```
[R/maps.R:501:7:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/maps.R#L501) *style:* **Variable or function name should be lowerCamelCase.**
```r
      HQRast <- highQualityStack[[SPP]]
      ^~~~~~
```
[R/maps.R:529:6:](https://github.com/PredictiveEcology/pemisc/blob/2be1912645e974663437447cba55735334403500/R/maps.R#L529) *style:* **Commented code should be removed.**
```r
    #names(sppMerges) <- equivalentName(names(sppMerges), sppEquiv,  column = sppEquivCol)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


IBM Cloud [toolchain](https://console.bluemix.net/devops/toolchains/83cae8d0-ee63-4721-881d-ef95cce88b59?env_id=ibm%3Ayp%3Aus-south "BCPAPP"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/dc72cf33-af87-439c-92da-114d4d7613c6?env_id=ibm%3Ayp%3Aus-south "Pipeline") deployed [vistech-bcp-b](https://github.com/ansleydeakin/vistech-bcp-b/releases/tag/deploy-ibm-yp-us-south-wongpa-deakin.edu.au-dev-20181208-220741 "deploy-ibm-yp-us-south-wongpa-deakin.edu.au-dev-20181208-220741") to [dev](https://console.bluemix.net/apps/c804700d-fc42-4fd8-9c79-73e70a1d31bc?env_id=ibm:yp:us-south "ibm:yp:us-south:wongpa@deakin.edu.au:dev"), including this commit


@tiff You're welcome.
@baarsrj When you assign a issue number in a commit it automatically closes the issue. @f-knorr has fixed the issue of 'space needed after period" error for all languages. I fixed the missing spellings for the languages I am the maintainer.


Successfully aliased the URL <https://mflow-jzqkew6dr.now.sh> to the following aliases.

* https://www.mflow.tech
* https://mflow.tech


first


Please don’t copy-paste bad code. It should in fact be easier to write it cleanly from scratch.


https://github.com/spotify/dh-virtualenv seems to already have enough documentation on how to do this properly.


Return


That’s just `dch -i`, isn’t it?


What is smol? 9 is already the default.


Default are already sanely chosen, there’s no need to override them.


Successfully aliased the URL <https://mflow-89yukszwh.now.sh> to the following aliases.

* https://www.mflow.tech
* https://mflow.tech


After b9d91a3c8d6f4796df310ff52bbb06bc844d13c3 that statement is not valid anymore - right?
The goal is to use the new external logging api.


If we wanted to avoid the nil checks in the caller we could also return a regex that would match anything.


Successfully aliased the URL <https://docs-nstvrysarj.zeit.sh> to the following alias.

* https://docs.zeit.sh


E


Very good


Got me, weird errors:

```shell
make[3]: Entering directory '/home/x394/Dev/crispy-doom/src'
  CC       d_loop.o
  CC       i_cdmus.o
  CC       i_endoom.o
  CC       i_glob.o
d_loop.c: In function ‘TryRunTics’:
d_loop.c:711:20: warning: unused variable ‘leveltime’ [-Wunused-variable]
         extern int leveltime;
                    ^~~~~~~~~
d_loop.c:732:44: error: ‘leveltime’ undeclared (first use in this function); did you mean ‘oldleveltime’?
     if (counts == 0 && crispy->uncapped && leveltime > oldleveltime && screenvisible)
                                            ^~~~~~~~~
                                            oldleveltime
d_loop.c:732:44: note: each undeclared identifier is reported only once for each function it appears in
Makefile:1018: recipe for target 'd_loop.o' failed
```


Ok, so the recommended way to flash a newer version of the firmware is to use this flasher and then call `zigate.erase_persistent`?


@Vizvezdenec This was inspired by discussion in https://github.com/official-stockfish/Stockfish/pull/1804
Basically its a test to uncover how reliable STC testing is:
This should in theory have +0.0 ELO effect


Yeah, and it's also a disease that kills you!

Maybe it could go in the pirate ship list, but I can't see merchant captains wanting to name their ship "Cancer" any more than they might choose "Heartburn" or "Syphilis".


Ah, thanks. And thanks again for your help on all this.


файл с стилями нужно называть на анлг. и логично, обычно это style.css


hey, I'm the drone guy, and I see some builds are getting stuck in pending. If you change this from `arm32` to `arm` it should work :) ... I need to add some yaml validation so that invalid architectures return an error. But in the meantime, figured I would give you a hint >Thanks for trying out Drone!


ORIG_Z_MAX_PIN is wrong.
Should be 2, not 9.


This sounds like https://github.com/endless-sky/endless-sky/pull/2262 and maybe https://github.com/endless-sky/endless-sky/issues/2419 to me.


![](https://github.trello.services/images/mini-trello-icon.png) [Cannot upgrade buildings](https://trello.com/c/hNDYu79n/65-cannot-upgrade-buildings)


Added program for hdmi lcd for iq display-


Successfully aliased the URL <https://mflow-36okvmk30.now.sh> to the following aliases.

* https://www.mflow.tech
* https://mflow.tech


20 GRA


@cardil A jak Tobie podoba się ta wersja?


commit message fail: add Scanner for command line input


@picatz I'm not totally sure but at least users can add it if they want. Maybe it should be the default since it's mandated by the RFC. But a lot of servers don't do it.


классы тоже именуются на англ., данный можно назвать допустим name или title и так как это главный заголовок можно применить тег h1, а не p


Cool stuff! 👍


really bad at this :(


1-. django-admin startapp images
2-. add to INSTALLED_APPS
3-. edit models.py of the images app
4-. python manage.py makemigrations images
5-. python manage.py migrate
6-. edit admin.py of the images app
![registrado](https://user-images.githubusercontent.com/4213047/49691549-753d5a80-fb0a-11e8-94df-af43e27bcbbf.JPG)


Successfully aliased the URL <https://mflow-ie1o18trf.now.sh> to the following aliases.

* https://www.mflow.tech
* https://mflow.tech


стили для картинки стоит писать в файле стилей, а не в атрибутах тега (width и height)


`leveltime` has been declared in the wrong place. Looks like @fabiangreffrath didn't compile before pushing. Also declaring variables `extern` in .c files instead of .h files is generally a bad idea. It can lead to type mismatches and UB. Declaring variables `extern` inside a function is also ugly.


Unidade 3 - Redes Neurais/denoisingClassifier_SAE_MLP.py

A notação estava correta. 1e-5 = 1*10⁻⁵. [Fonte.](https://stackoverflow.com/questions/26174531/what-is-the-meaning-of-number-1e5)


нет смысла h2 оборачивать в <p>


![](https://github.trello.services/images/mini-trello-icon.png) [to add autoredirect for locale-free URLs (e.g. wir.by/about -> wir.by/be/about)](https://trello.com/c/m7AXhUHq/295-to-add-autoredirect-for-locale-free-urls-eg-wirby-about-wirby-be-about)


список на то и список, что состоит из нескольких элементов, в данном случае нет смысла применять ul и li так как всего один элемент, можно просто <p>


Successfully aliased the URL <https://mflow-mnlp32ssd.now.sh> to the following aliases.

* https://www.mflow.tech
* https://mflow.tech


тут та же история, можно просто <a>, без ul и li


Successfully aliased the URL <https://mflow-94gnexwq6.now.sh> to the following aliases.

* https://www.mflow.tech
* https://mflow.tech


тут тоже, можно просто <p>, без ul и li


you think it should be [0,5]?


I guess the reasoning was that this is reintroducing code, for which also in the past [0,4] has been used. However, if it needs further tweaking of params, I think it is right better to use [0,5].


combo problem BTW is there a myCombo
![combo](https://user-images.githubusercontent.com/12769564/49691589-f2201100-fbaa-11e8-8d3d-45b2fe268267.JPG)


well, seems like ur right. still it dosn't break anything. it just reduces the key from 128 to 120 bit (which is both pretty low)


![](https://github.trello.services/images/mini-trello-icon.png) [Ability to sell houses](https://trello.com/c/6PGOMjj2/66-ability-to-sell-houses)


Agregado administrador, olvidé escribirlo. Fijarse en la base de datos.


You are pushing commits at a very fast pace (accross the whole organization).
Due to that, we cannot deploy the commit 0c4856e6a7410ba94d94dd16cc5bd5cc404c7efa.

You can try again later or [upgrade](https://zeit.co/account/plan) your plan.


каждое правило стилей нужно писать с новой строки


он и так на всю ширину, это можно удалить


thanks, i will try to remember :) now that you have fixed them, they will not be replicated when i copy & paste


الحمد لله الداتابيز اتكريتت وشغل عمرو على الماستر
لو حد عاوز يكمل إن شاء الله يكمل بسلام

[https://ipmcdn.avast.com/images/icons/icon-envelope-tick-round-orange-animated-no-repeat-v1.gif]<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=icon>    Virus-free. www.avast.com<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=link>


Successfully aliased the URL <https://mflow-p9hn2xafd.now.sh> to the following aliases.

* https://www.mflow.tech
* https://mflow.tech


effects


Does this remove/corrupt the DLLs PDB file? After building I am unable to debug the DLL (tried everything I could think of to load the PDB file -- to no avail).  I created another test application and was not able to step into the DLL. Any debug suggestions?


Matt, be aware this makes these values mutable. Only the container object is readonly, not it's contents. In general do not make anything but basic types readonly. Access to pixel origins/directions should be via a property which returns a copy of the array.


Sorry, "START GAME!!" isn't causing this problem. Someone can delete this upload.


![](https://github.trello.services/images/mini-trello-icon.png) [Health Bar on top of unit (make it more pretty)](https://trello.com/c/N1lgVjU1/68-health-bar-on-top-of-unit-make-it-more-pretty)


Why is this added? Did wallet_api has problema with syncing?


classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"


зачем тут айди? привыкай использовать только классы для стилизации


; Controle de uma LCD a partir de uma controle remoto SONY


@brammool Thanks very much for your reply.

> That is not possible, because we do not know if inside the executed command "silent" was used, in which case msg_col is invalid.

If this is the case, inside `command` `msg_col` is invalid anyway. Why bother to set it to 0 before running `command`?

> We can keep the column if the output is displayed.

I totally agree on this. At least, we should not let later output to overwrite existing output; especially when error message is displayed. So this should not only cover the case `mode == ''`, but also when `mode == 'silent'` and error is encountered inside `command`. Something like `mode == "silent" && (mode != "silent!" || did_emsg)` to be met to restore `msg_col`.

> I'll add some tweaks for when the mode argument is empty

Thanks again for your time.


@johnbillion You can encourage users

- to document
- to declare
- and to check

the PHP enviroment in PHP code! -> https://github.com/szepeviktor/debian-server-tools/blob/master/webserver/php-env-check.php#L55


Aliasing failed with the following error:

~~~
Error! No permission to access domain theguys.design under theguysdesign
~~~


Nice commit dude


Please revert. Cancer (crab) is one of the twelve classical Zodiac constellations (and corresponding astrological symbols). Excluding it would be similar to disqualifying August from a list of months because Hiroshima and Nagasaki happened to be bombed in August (1945).


Updated with improvements in the user stories


![](https://github.trello.services/images/mini-trello-icon.png) [Make farmers a partisan esc troop.](https://trello.com/c/bzOu02NH/58-make-farmers-a-partisan-esc-troop)


![](https://github.trello.services/images/mini-trello-icon.png) [Ocultar usuário e senha no código do NodeMCU](https://trello.com/c/xJhTtiiW/7-ocultar-usu%C3%A1rio-e-senha-no-c%C3%B3digo-do-nodemcu)


yeah this was a mistake as it turns out the formatting isnt preserved


The return inside the initialize function prevented aragon publish to generate the artifact:
![image](https://user-images.githubusercontent.com/5030059/49681193-d5e27e00-fa9d-11e8-9c57-91e7f9e3ac46.png)


Successfully aliased the URL <https://braydengirard-client-kgrz9ge4n.now.sh> to the following alias.

* https://braydengirard.com


PEP 508 URL dependencies.


ada script create order voucher pulsa caping ga?


Successfully aliased the URL <https://redirects-gl6qpgyb9.now.sh> to the following aliases.

* https://www.anthony.codes
* https://thedebug.life
* https://www.thedebug.life
* https://anthony.app
* https://www.anthony.app


Thank you. This is good information.  At this stage i am learning what
affect what.  I wasn't going to do a pr for this.

On Fri, Dec 7, 2018, 7:49 PM miguel-l <notifications@github.com wrote:

> I disagree with this as a simplification.
>
>    1. is_ok calls from_sq and to_sq which are more expensive than
>    checking for equality with a constant.
>    2. MOVE_NULL and MOVE_NONE imply subtleties which I feel might be
>    better to leave explicitly clearer. MOVE_NONE generally indicates the
>    lack of a move, say in the end of a movepicker list or in the case of a
>    rootNode, a missing move for (ss-1). MOVE_NULL indicates something to
>    do with null move pruning, where we try to evaluate a position if one side
>    passes/skips their turn. This is useful for catching that behavior in
>    certain plies, to avoid immediately having a recursion, or to speed up eval.
>
> As an example and also to explain the bench change, it happens somewhere
> around line 743, MOVE_NULL means our opponent passed and so we can speed
> up the evaluation for this position, by taking the evaluation of the
> previous position (which remains the same) and add some tempo bonus (line
> 753). By using is_ok here, we start to check also for MOVE_NONE which
> only really happens in the rootNode case. Of course, getting the eval
> from (ss-1) wouldn't make sense in that case, since we have not evaluated
> anything yet.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/protonspring/Stockfish/commit/8983860fdf5e1cb6fe8c25fc3257e42ec3a148fc#commitcomment-31606215>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AcVnSAa4EmvUglVVvXsKkwwwD4NYIX8Zks5u2yiugaJpZM4ZJbGT>
> .
>


parâmetro --mca necessário para evitar a mensagem "Read -1, expected 5120, errno = 1" durante a execução no docker


partos?


这个撤去的方式也是够特殊的了


acho q dá pra mudar esse huh


This is my first attempt to use Git Hub


I had a reason to do it in a new thread, but I don't remember haha, so we need to stay alert if something went wrong here


Created multidev environment [rescue-x#oct-18](https://dashboard.pantheon.io/sites/c8430b75-4272-4aca-bfcd-206b12279315#oct-18).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://oct-18-rescue-x.pantheonsite.io/)


Acho aquele 1 e o só meio informal demais tanto pro Ralsei quanto dentro da própria frase. Usar antecedência e só na mesma frase para o Ralsei eu não considero muito bom, mas você que sabe.


We can remove it because we add focused component on setPlayer method


When will there be specific instructions on authz-dummy and ambassador?
thanks Rubykube team


I did this because the World was in charge of processing ClientSystem therefore calling the update method, but at this point we didn't have a running world, we should delete this logic or find out another solution.


![2 5d_snip](https://user-images.githubusercontent.com/42807889/49681320-bc294280-fa6d-11e8-8f18-78739a8c034f.JPG)


We need to handle the Next and Prev button clicks and call the corresponding functions to change the image.


![](https://github.trello.services/images/mini-trello-icon.png) [Decrease wall pillar detection box](https://trello.com/c/4xmnOxeE/46-decrease-wall-pillar-detection-box)


![](https://github.trello.services/images/mini-trello-icon.png) [Show player if their placement position is invalid](https://trello.com/c/ZaOEiBDj/57-show-player-if-their-placement-position-is-invalid)


IBM Cloud [toolchain](https://console.bluemix.net/devops/toolchains/fb05ff98-4eea-4e00-8d7f-07b8a282fae2?env_id=ibm%3Ayp%3Aus-south "nyu-devops-wishlists-f18"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/182b4af3-6883-4de0-b8f0-01a98c71cb2f?env_id=ibm%3Ayp%3Aus-south "nyu-devops-wishlists-f18-pipeline") deployed [wishlists](https://github.com/NYU-Wishlists/wishlists/releases/tag/deploy-ibm-yp-us-south-nyu-devops-wishlists-f18-dev-20181208-032042 "deploy-ibm-yp-us-south-nyu-devops-wishlists-f18-dev-20181208-032042") to [dev](https://console.bluemix.net/apps/cc0dcc54-4a4c-498c-97a9-a6a377b89280?env_id=ibm:yp:us-south "ibm:yp:us-south:nyu-devops-wishlists-f18:dev"), including this commit


第一次修改


嘎嘎嘎


uhg, of course it would. :man_facepalming:

Should've stuck with the original idea of testing each item for Record(). Will get it fixed.


[Jenkins vg tests](http://jenkins.cgcloud.info/job/vg/2407/) complete for merge to master.  View the [full report here](http://vg-data.s3.amazonaws.com/vg_ci/jenkins_reports/branch/master/index.html).

19 tests passed, 0 tests failed and 10 tests skipped in 22200 seconds

Tests produced 2825 warnings. 2824 were for lower-than-expected alignment scores


第二个文件


### Lipsum Really?

So we __really__ were not able to find better filler text?


Essa mudança, que aparentemente é pra evitar quebra de linha, não resultou em algo que faz muito sentido ao meu ver.


@abhishek818 you have not rollbacked the changes on master, and second remove console.log() from your code. Its not a wise thing to do in production.


this is how you revert `git revert <oldest_commit_hash>..<latest_commit_hash>`


This is the final report of the project


thay đổi phiên bản nhá


@gfgtdf Those are both good points ...

I had removed the warnings because I actually want the game to crash.  First, if I did the fix right, there should be no crash.  Second, this only happens under very specific (and exceedingly rare) conditions, so I want to make sure it is noticed.  Thus, I'd prefer a crash rather than a warning that is easily missed or ignored.  But an assert here is of course much better than one in map.hpp.  So I added that.

As for `ai_leaders_` not being updated:  Yeah, that's true too.  I had created a test case for the other warning, but not for this one.  I have now and it turns out that your code would not have prevented the crash either, it would have segfaulted later, at l.1692.  Also, updating `ai_leaders_` in the same way as the moves does not work, as this is _inside_ a loop over this variable.  So, having the `continue`, but without the warning (as this is perfectly acceptable use of WML) is actually the right thing to do, I think.  And then re-finding the AI leaders later.

Too many words.  I made the changes that I think are what should be done and takes care of both problems: 6824f9bced5


ơ có 2 phiên bản thui á ^^


thế thôi,


Created multidev environment [ilsoy#ci-297](https://dashboard.pantheon.io/sites/1b49470e-4ad3-4b49-90a2-7bb2c2f96788#ci-297).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-297-ilsoy.pantheonsite.io/)


ok


@154189salmansagheer post lab missing


@154189salmansagheer max size should be equal to size.


getting somewhere


@154189salmansagheer incorrect implementation, you were to insert element on index == length.
you are comparing index values with length


ahihi t chức cao quá


ok đấy m


Để giáo sư Phúc làm nhé!


Created multidev environment [ilsoy#ci-299](https://dashboard.pantheon.io/sites/1b49470e-4ad3-4b49-90a2-7bb2c2f96788#ci-299).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-299-ilsoy.pantheonsite.io/)


ここで LIBS の設定が消えてしまうようです。削除でよい?


> scanFiles() will now remove delete allocated identifiers from cache if the files are dirty.

It's either just "remove" or "delete", I clearly am not paying attention.


Good!


change domain name


changed some text


VERSION 1.0 (ABM PAGE. NO LOGIN. WORKING 100%)


cd lrm-install


@154287MuhammadFawadZafar sort implementation missing.


@154287MuhammadFawadZafar should be part of constructor


@154287MuhammadFawadZafar post lab missing


这是第一个


@16L4033AhmadMaqbool index of array not printed


@16L4033AhmadMaqbool you are inserting on all indices the values


Lflggllgvlglfog


Kxgkkgogohoohobo


@16L4033AhmadMaqbool B part of postlab mising


CCache_Ninja (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.3-IntegrationCoverage-Debug: OK (2420 of 2420 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-72.28%25-green.png)


good


CCache_Ninja (jmarrec) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (2 of 2 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


@164080alisalmanahmed simple list size was expected to be returned


not necessary 3 lines


@164390fahadHussain incorrect. will return max size here


@164390fahadHussain why didn't you accessed array index directly ?


Recentering (PA 956-FaiRd) for US 19 here


@164390fahadHussain not correct implementation


@166341Aqeedat implementation missing. Postlab is missing


@174080maryamMukhtar B part of post lab is missing


@l174096manha max size not given value


あっ確かに。消し忘れですね。


Successfully aliased the URL <https://web-rljp6fyyk.now.sh> to the following aliases.

* https://digipiggybank.com
* https://www.digipiggybank.com


raw JUnit Testing


Build version: __`0.10.0-master.434`__ :crossed_fingers: [`master`](https://github.com/streamich/ci-scripts/tree/master) on [*CircleCI*](https://circleci.com/gh/streamich/ci-scripts/434) :tada:


Build version: __`0.10.0-master.672`__ :crossed_fingers: [`master`](https://github.com/streamich/ci-scripts/tree/master) on [*Travis*](https://travis-ci.org/streamich/ci-scripts/builds/465243071) :tada:


Executing the daily benchmark build, I will reply here when finished:

@nanosoldier `runbenchmarks(ALL, isdaily = true)`


@l174096manha remove not implemented


Successfully aliased the URL <https://muhfajar-hugo-now-dimhlid6a.now.sh> to the following alias.

* https://muhfajar.id


@174104michelleAkaishi will cause errors. Learn how to delete 1D array


due to loop.


This build resolved the SLF4J error msg as mentioned in https://github.com/mars-sim/mars-sim/issues/74


@174104michelleAkaishi this code is not necessary


Error message upon make clean & make!

Makefile:13: *** recipe commences before first target.  Stop.

Pls check. 73