frappe/frappe-bench/apps/frappe/frappe/desk/query_report.py", line 18, in <module>
    from frappe.utils.file_manager import get_file
ModuleNotFoundError: No module named 'frappe.utils.file_manager'


Im not able to find frappe.utils.file_manager module


Deployment failed with the following error:

~~~
One or more build specification(s) were not referenced
~~~


Warum machst du kein Overriede von dem Konstruktor in Spieler Klasse?


![screen shot 2018-12-08 at 11 34 59 pm](https://user-images.githubusercontent.com/2034781/49689079-ecdaac00-fb41-11e8-9b80-a93606eee3dd.png)


Szarvashiba volt.


And what is the link to the discord channel?


Bade log


Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

Check the render method of `Characters`.
-------------------------

Reorganized my code to see if I can spot the error better. It looks like i'm correctly importing/exporting the components despite the error.


was passiert wenn man die Farbe des Spielers nach dem Beginn des Spieles? würde es in deinem Code als Fehler behandelt?


I get it now. Thanks for taking the time to explain that.

BTW If x was not a bool in` If (x == true)`  it would be a very bad(buggy) expression since it evaluates to` if (x == 1)`  rather then` if (x != 0)`


Classic FP


Successfully aliased the URL <https://mflow-8qfhaav0j.now.sh> to the following aliases.

* https://www.mflow.tech
* https://mflow.tech


In a world where you don't exist? :p


Thanks for giving me a break ;)


Puzzle `74-de2402e3` disappeared from [`main.cpp`](https://github.com/DronMDF/zond/blob/master/main.cpp), that's why I closed #79. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.


Yes. Thanks! https://dev.clojure.org/jira/browse/CLJS-3008


I noticed that cljs-oops newly reports 'null' in exception causes chain:
https://travis-ci.org/binaryage/cljs-oops/builds/465263336#L880

Don't you want to consider generating at least some generic message, something like "Error in macro-expansion of ...", instead of using  `(ex-info nil ...)`?

Some background info:
1. cljs-oops can throw in macros to deliberately stop on errors
2. it does it via throwing analyzer error this way:
https://github.com/binaryage/cljs-oops/blob/dc052c9fd810271bb88ae520e4c5c9493301abb7/src/lib/oops/compiler.clj#L100
3. the resulting error stack trace looks like this (leiningen) - note the `clojure.lang.ExceptionInfo: null`
```
Compiling ClojureScript...
Compiling ["resources/public/.compiled/playground/main.js"] from ["src/playground"]...
Compiling ["resources/public/.compiled/playground/main.js"] failed.
clojure.lang.ExceptionInfo: failed compiling file:src/playground/oops/playground/main.cljs {:file #object[java.io.File 0x77604a86 "src/playground/oops/playground/main.cljs"], :clojure.error/phase :compilation}
	at clojure.core$ex_info.invokeStatic(core.clj:4739)
	at clojure.core$ex_info.invoke(core.clj:4739)
	at cljs.compiler$compile_file$fn__3885.invoke(compiler.cljc:1706)
	at cljs.compiler$compile_file.invokeStatic(compiler.cljc:1666)
	at cljs.compiler$compile_file.invoke(compiler.cljc:1642)
	at cljs.closure$compile_file.invokeStatic(closure.clj:653)
	at cljs.closure$compile_file.invoke(closure.clj:631)
	at cljs.closure$fn__5363.invokeStatic(closure.clj:727)
	at cljs.closure$fn__5363.invoke(closure.clj:721)
	at cljs.closure$fn__5276$G__5269__5283.invoke(closure.clj:549)
	at cljs.closure$compile_sources$iter__5489__5493$fn__5494.invoke(closure.clj:1088)
	at clojure.lang.LazySeq.sval(LazySeq.java:40)
	at clojure.lang.LazySeq.seq(LazySeq.java:49)
	at clojure.lang.Cons.next(Cons.java:39)
	at clojure.lang.RT.next(RT.java:706)
	at clojure.core$next__5108.invokeStatic(core.clj:64)
	at clojure.core$dorun.invokeStatic(core.clj:3134)
	at clojure.core$doall.invokeStatic(core.clj:3140)
	at clojure.core$doall.invoke(core.clj:3140)
	at cljs.closure$compile_sources.invokeStatic(closure.clj:1084)
	at cljs.closure$compile_sources.invoke(closure.clj:1073)
	at cljs.closure$build.invokeStatic(closure.clj:3014)
	at cljs.closure$build.invoke(closure.clj:2922)
	at cljs.build.api$build.invokeStatic(api.clj:208)
	at cljs.build.api$build.invoke(api.clj:189)
	at cljs.build.api$build.invokeStatic(api.clj:195)
	at cljs.build.api$build.invoke(api.clj:189)
	at cljsbuild.compiler$compile_cljs$fn__718.invoke(compiler.clj:61)
	at cljsbuild.compiler$compile_cljs.invokeStatic(compiler.clj:60)
	at cljsbuild.compiler$compile_cljs.invoke(compiler.clj:48)
	at cljsbuild.compiler$run_compiler.invokeStatic(compiler.clj:168)
	at cljsbuild.compiler$run_compiler.invoke(compiler.clj:129)
	at user$eval847$iter__895__899$fn__900$fn__926.invoke(form-init2899398398991177083.clj:1)
	at user$eval847$iter__895__899$fn__900.invoke(form-init2899398398991177083.clj:1)
	at clojure.lang.LazySeq.sval(LazySeq.java:40)
	at clojure.lang.LazySeq.seq(LazySeq.java:49)
	at clojure.lang.RT.seq(RT.java:528)
	at clojure.core$seq__5124.invokeStatic(core.clj:137)
	at clojure.core$dorun.invokeStatic(core.clj:3125)
	at clojure.core$doall.invokeStatic(core.clj:3140)
	at clojure.core$doall.invoke(core.clj:3140)
	at user$eval847.invokeStatic(form-init2899398398991177083.clj:1)
	at user$eval847.invoke(form-init2899398398991177083.clj:1)
	at clojure.lang.Compiler.eval(Compiler.java:7062)
	at clojure.lang.Compiler.eval(Compiler.java:7052)
	at clojure.lang.Compiler.load(Compiler.java:7514)
	at clojure.lang.Compiler.loadFile(Compiler.java:7452)
	at clojure.main$load_script.invokeStatic(main.clj:278)
	at clojure.main$init_opt.invokeStatic(main.clj:280)
	at clojure.main$init_opt.invoke(main.clj:280)
	at clojure.main$initialize.invokeStatic(main.clj:311)
	at clojure.main$null_opt.invokeStatic(main.clj:345)
	at clojure.main$null_opt.invoke(main.clj:342)
	at clojure.main$main.invokeStatic(main.clj:424)
	at clojure.main$main.doInvoke(main.clj:387)
	at clojure.lang.RestFn.applyTo(RestFn.java:137)
	at clojure.lang.Var.applyTo(Var.java:702)
	at clojure.main.main(main.java:37)
Caused by: clojure.lang.ExceptionInfo: null #:clojure.error{:source "src/playground/oops/playground/main.cljs", :line 5, :column 1, :phase :macroexpansion, :symbol oops.core/oget}
	at clojure.core$ex_info.invokeStatic(core.clj:4739)
	at clojure.core$ex_info.invoke(core.clj:4739)
	at cljs.analyzer$macroexpand_1_STAR_$fn__2509.invoke(analyzer.cljc:3761)
	at cljs.analyzer$macroexpand_1_STAR_.invokeStatic(analyzer.cljc:3756)
	at cljs.analyzer$macroexpand_1_STAR_.invoke(analyzer.cljc:3743)
	at cljs.analyzer$macroexpand_1.invokeStatic(analyzer.cljc:3806)
	at cljs.analyzer$macroexpand_1.invoke(analyzer.cljc:3802)
	at cljs.analyzer$analyze_seq.invokeStatic(analyzer.cljc:3839)
	at cljs.analyzer$analyze_seq.invoke(analyzer.cljc:3819)
	at cljs.analyzer$analyze_form.invokeStatic(analyzer.cljc:4028)
	at cljs.analyzer$analyze_form.invoke(analyzer.cljc:4025)
	at cljs.analyzer$analyze_STAR_.invokeStatic(analyzer.cljc:4078)
	at cljs.analyzer$analyze_STAR_.invoke(analyzer.cljc:4069)
	at cljs.analyzer$analyze.invokeStatic(analyzer.cljc:4098)
	at cljs.analyzer$analyze.invoke(analyzer.cljc:4081)
	at cljs.compiler$emit_source.invokeStatic(compiler.cljc:1524)
	at cljs.compiler$emit_source.invoke(compiler.cljc:1497)
	at cljs.compiler$compile_file_STAR_$fn__3854.invoke(compiler.cljc:1609)
	at cljs.compiler$with_core_cljs.invokeStatic(compiler.cljc:1417)
	at cljs.compiler$with_core_cljs.invoke(compiler.cljc:1406)
	at cljs.compiler$compile_file_STAR_.invokeStatic(compiler.cljc:1593)
	at cljs.compiler$compile_file_STAR_.invoke(compiler.cljc:1586)
	at cljs.compiler$compile_file$fn__3885.invoke(compiler.cljc:1691)
	... 55 more
Caused by: clojure.lang.ExceptionInfo: Oops, Unexpected nil target object at line 5 src/playground/oops/playground/main.cljs {:file "src/playground/oops/playground/main.cljs", :line 5, :column 1, :tag :cljs/analysis-error}
	at clojure.core$ex_info.invokeStatic(core.clj:4739)
	at clojure.core$ex_info.invoke(core.clj:4739)
	at cljs.analyzer$error.invokeStatic(analyzer.cljc:743)
	at cljs.analyzer$error.invoke(analyzer.cljc:739)
	at cljs.analyzer$error.invokeStatic(analyzer.cljc:741)
	at cljs.analyzer$error.invoke(analyzer.cljc:739)
	at oops.compiler$error_BANG_.invokeStatic(compiler.clj:100)
	at oops.compiler$error_BANG_.doInvoke(compiler.clj:97)
	at clojure.lang.RestFn.invoke(RestFn.java:423)
	at oops.reporting$report_BANG_.invokeStatic(reporting.clj:17)
	at oops.reporting$report_BANG_.doInvoke(reporting.clj:14)
	at clojure.lang.RestFn.invoke(RestFn.java:423)
	at oops.reporting$report_if_needed_BANG_.invokeStatic(reporting.clj:23)
	at oops.reporting$report_if_needed_BANG_.doInvoke(reporting.clj:20)
	at clojure.lang.RestFn.invoke(RestFn.java:410)
	at oops.codegen$validate_object_statically.invokeStatic(codegen.clj:267)
	at oops.codegen$validate_object_statically.invoke(codegen.clj:262)
	at oops.codegen$gen_oget.invokeStatic(codegen.clj:397)
	at oops.codegen$gen_oget.invoke(codegen.clj:396)
	at oops.core$oget.invokeStatic(core.clj:11)
	at oops.core$oget.doInvoke(core.clj:9)
	at clojure.lang.RestFn.applyTo(RestFn.java:146)
	at clojure.core$apply.invokeStatic(core.clj:661)
	at clojure.core$apply.invoke(core.clj:652)
	at cljs.analyzer$macroexpand_1_STAR_$fn__2509.invoke(analyzer.cljc:3757)
	... 75 more
Error encountered performing task 'cljsbuild' with profile(s): 'base,system,user,provided,dev,playground'
Subprocess failed
```


Thanks. We'll see if the AVR compiler is smart enough.


Yep, several section in the admin tool are no longer necessary. I just fixed this one on the side while looking for issues easy to close and did not think about its usefulness. I guess I should add a note / link on that page to point the users to the function in the EM.


Successfully aliased the URL <https://karbon14-demo-fzhmidujwu.now.sh> to the following alias.

* https://karbon14-demo.now.sh


Ultimo apartado


Micsoda hülyeség volt részemről!


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


Thanks for the tip.


*code not cold


![](https://github.trello.services/images/mini-trello-icon.png) [The user should be able to return to the main menu in the game mode](https://trello.com/c/mPl88rQe/28-the-user-should-be-able-to-return-to-the-main-menu-in-the-game-mode)


Salut ! Ok pour moi.


Would not the reference to the code have been more helpful? Of course, it most probably has been deliberately removed, so you might have your reasons.


Aliasing failed with the following error:

~~~
Error! No permission to access domain theguys.sh under theguysdesign
~~~


Sorry, now I see it references our discussion and not that at awesome. Well played.


From lint-staged script


¡Cuidado con la identanción!


LEer


Extra comma?


Faltó la desactivación de la herramienta de agregación en las secciones:
- Limpiado del canvas
- DockPanel


Successfully aliased the URL <https://mflow-34g6rgjzl.now.sh> to the following aliases.

* https://www.mflow.tech
* https://mflow.tech


![](https://github.trello.services/images/mini-trello-icon.png) [3.6 - Selección de project admins](https://trello.com/c/xTp28Fbu/20-36-selecci%C3%B3n-de-project-admins)


This much creates crashes applying palette elements to list selections - see https://musescore.org/en/node/279662.

In general, the reason we do these copies is because you get crashes and other very problems when looping over a list if the code within the loop modifies the list.  That's why we are so careful to create copies of lists before iterating over them in general.  Probably most of these were done for that reason.


Ups,, the advantage of this mistake is that it get's now injected into every website on planet earth. ;)


looks good


Nombre de método mal nombrado.


Successfully aliased the URL <https://mflow-4l50tmvu3.now.sh> to the following aliases.

* https://www.mflow.tech
* https://mflow.tech


The general idea of setting `nil` messages was copied from Clojure. See for example https://github.com/clojure/clojure/blob/master/src/clj/clojure/main.clj#L412

But, if there are specific cases we should consider, maybe open a JIRA?


this just in: also sent for mind flay (???)

```
ServerToClient: MSG_CHANNEL_START (0x0A15) Length: 16 ConnIdx: 2 Time: 07/25/2012 23:21:10.020 Number: 29038
GUID: Full: 0x200000002CDF9E3 Type: Player Low: 47053283 Name: Háyden
Spell ID: 15407 (15407)
Duration: 2323
Has castflag Immunity: false
Has castflag HealPrediction: false

ServerToClient: SMSG_SPELL_UPDATE_CHAIN_TARGETS (0x6006) Length: 24 ConnIdx: 2 Time: 07/25/2012 23:21:10.020 Number: 29039
Caster GUID: Full: 0x200000002CDF9E3 Type: Player Low: 47053283 Name: Háyden
Spell ID: 15407 (15407)
Count: 1
Chain target: Full: 0xF130B6A100000C24 Type: Creature Entry: 46753 Low: 3108
```

the crowd grows confused.
i looked at it in the client, targets are just saved in caster entity, then channel states are set up (animations, tracking target, etc). Nothing too useful, why is this opcode a thing?


Don't think `!== null` will make any difference from `!= null`


@JaeyeongYang

Seems like I've accounted for all possible differences between `hBayesDM` & `rstanarm`,
but 'clean and rebuild' in RStudio (ccsl server) does **not** work...

Here's the error message:
```
==> R CMD INSTALL --preclean --no-multiarch --with-keep.source hBayesDM

* installing to library ‘/home/dlemfh96/R/x86_64-pc-linux-gnu-library/3.4’
* installing *source* package ‘hBayesDM’ ...
"/usr/lib/R/bin/Rscript" -e "source(file.path('..', 'tools', 'make_cc.R')); make_cc(commandArgs(TRUE))" stan_files/ug_bayes.stan
** libs
Makevars:17: recipe for target 'stan_files/ug_bayes.cc' failed
Error in file(con, "r") : invalid 'description' argument
Calls: make_cc -> cat -> readLines -> file
Execution halted
make: *** [stan_files/ug_bayes.cc] Error 1
ERROR: compilation failed for package ‘hBayesDM’
* removing ‘/home/dlemfh96/R/x86_64-pc-linux-gnu-library/3.4/hBayesDM’
* restoring previous ‘/home/dlemfh96/R/x86_64-pc-linux-gnu-library/3.4/hBayesDM’

Exited with status 1.
```

(Pretty sure it's not `ug_bayes`'s fault, because removing ug_bayes I get the same error message with just another model.)


Successfully aliased the URL <https://mflow-cxs0l0bj4.now.sh> to the following aliases.

* https://www.mflow.tech
* https://mflow.tech


Commit 1: el sol no se mueve hacia arriba.


Indentación incorrecta.


comment


I think this should still be included


Code was not recognized as API Description file. Not updating.


Deployment failed with the following error:

~~~
Invalid request: config should NOT have additional properties
~~~


I think this should still be included. I think a bunch of the lines from this section should still be included.


BTW, this is going to go back down. Way too big still.


Primer commit realizado #1


No worries, I wanted to avoid delaying the pull request more :)


Ok


Just fixed an obvious issue in case.


No worries. All good. Just wanted to make it clear it was a temporary measure.


Ok, I don't have a strong opinion. Thanks for the reply.


Successfully aliased the URL <https://mflow-qd40scr54.now.sh> to the following aliases.

* https://www.mflow.tech
* https://mflow.tech


ايه يا رجالة .. لا اسكت الله لكم حسا 😊


It's a convention not everyone follows, but I hope to encourage more people to adopt it.
In my opinion code should try to be explicit about what it's doing, even at the cost of being a little bit more verbose.

I'm upset that `x == true` actually compiles, I would have hoped it would be ambiguous (i.e. the compiler can't decide whether to cast the `int` to `bool` or the `bool` to `int`).
(I'd like to know exactly what part of the standard specifies that `bool` becomes `int` instead of `int` becoming `bool`, because that seems really backwards. I might have a look if I get chance.)


Successfully aliased the URL <https://mflow-o7fwnlohq.now.sh> to the following aliases.

* https://www.mflow.tech
* https://mflow.tech


random seed #8 works


The variable name SPEED_FIREB isn't intuitive and doesn't match the variable which named ID_FIREBALL.

Suggestion: change the name to SPEED_FIREBALL

`public static final int SPEED_FIREBALL = 12;`


very nice source code i made my own skidded exploit


stopped working.


гавно


The line is too long and should be wrapped.

Suggestion: should break it after a comma.


IBM Cloud [toolchain](https://console.bluemix.net/devops/toolchains/1076a681-dc89-4362-94c9-40a76fa898b5?env_id=ibm%3Ayp%3Aus-south "lightbluecompute-devops-20181128211932333"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/e45d063e-6aa7-4875-9398-31aee8c65b1f?env_id=ibm%3Ayp%3Aus-south "lightblue-web") deployed [lightblue-web-20181128211932333](https://github.com/dthiesse/lightblue-web-20181128211932333/releases/tag/deploy-ibm-yp-us-south-cldstd01-us.ibm.com-dev-20181208-191712 "deploy-ibm-yp-us-south-cldstd01-us.ibm.com-dev-20181208-191712") to [dev](https://console.bluemix.net/apps/2656ca23-fd9c-40ba-8bc6-80e0f05ac039?env_id=ibm:yp:us-south "ibm:yp:us-south:cldstd01@us.ibm.com:dev"), including this commit


Math.round thi is nice method


Successfully aliased the URL <https://mflow-dsyqsbla1.now.sh> to the following aliases.

* https://www.mflow.tech
* https://mflow.tech


@rafael180496  agregar estas dependencias aqui no tiene mucho sentido pues ya esten en el archivo .csproj las dependencias serian mejor las generales como por ejemplo el  dotnet core SDK y la respectivata version


Buen uso del .gitignore 👍


Now it says:
`  _set [prefix] character    - change command prefix`

... but the "prefix" variable name is not optional as the [] brackets suggest:
```
>_set _
That variable is not supported.
```


where it is? it not exists as i see


Updated Aura Mod fanart courtesy  of @drinfernoo


Sorry, it isn't clear. Try: set prefix _

On Sat, Dec 8, 2018 at 11:19 AM Tomáš Windsor <notifications@github.com>
wrote:

> Now it says:
> _set [prefix] character - change command prefix
>
> ... but the "prefix" variable name is not optional as the [] brackets
> suggest:
>
> >_set _
> That variable is not supported.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/MUME/MMapper/commit/4eb4db199fb5766d6bc9a3c0974d3632a40490af#commitcomment-31608824>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AFQAoXvhqv4JsrzBZ41cKBEmSrotyW9bks5u3BDYgaJpZM4ZI1vT>
> .
>


Successfully aliased the URL <https://mflow-7dpxjbq13.now.sh> to the following aliases.

* https://www.mflow.tech
* https://mflow.tech


Así miro muchas gracias por el comentario es parecido la sintaxis a sqlkata
para creaciones de querés

https://github.com/sqlkata/querybuilder

El sáb., 8 de dic. de 2018 1:28 p. m., Luis Palacios <
notifications@github.com> escribió:

> @rafael180496 <https://github.com/rafael180496>
> Debido a que la sintaxys es mas corta normalmente preferimos fluent
> expression en ver de query Comparasion aqui
> <https://stackoverflow.com/questions/214500/fluent-and-query-expression-is-there-any-benefits-of-one-over-other>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/rafael180496/newsSystem/commit/e34e1f023290521423694efbac752a7b1e61dab9#commitcomment-31608843>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AabNJ--4nB2rn9V-xS47jCifFe6pNLWnks5u3BLKgaJpZM4ZJx89>
> .
>


@rafael180496
Los archivos de migraciones ya deberian estar en el repositorio de tal forma que alguien mas para hacer set up del proyecto no debe agregar migraciones solo ejectuarlas con `dotnet ef database update`


Successfully aliased the URL <https://mdx-ygswjujqke.now.sh> to the following aliases.

* https://mdxjs.com
* https://www.mdxjs.com


![](https://github.trello.services/images/mini-trello-icon.png) [3.6 - Selección de project admins](https://trello.com/c/xTp28Fbu/20-36-selecci%C3%B3n-de-project-admins)


Merge ke mana bro? 😅


delete this line


@murb hulde!


Só passando o que aprendi: quase todo ", huh?" costuma ser ", é?" pela minha experiência traduzindo jogos, apesar de fazermos um barulho parecido com "hm/hã" no final, mas pra evitar confusão eu coloco "é" porque é o mesmo sentido. Mas sim, nunca é huh numa versão brasileira.


Automatic build report for commit 990009dda57b326de5ece5ca036d2063d32a9c92:

[![Unit Tests](https://img.shields.io/badge/unittests-13%20/%2013-brightgreen.svg)](#)
[![PyLint](https://img.shields.io/badge/pylint-9.77-brightgreen.svg)](#)


Successfully aliased the URL <https://mdx-gdlzdmiprb.now.sh> to the following aliases.

* https://mdxjs.com
* https://www.mdxjs.com


مفخوت في تصليح الماستر


wtf


> wtf

what dude


😲 ليه كدة؟؟


> > wtf
>
> what dude

oh shut it


Making it check for existing optimization parameter might make the code confusing to read unless it is separated as a function. I agree that changing the order might be the easiest and most readable fix.


You are pushing commits at a very fast pace (accross the whole organization).
Due to that, we cannot deploy the commit 70e95158cbfb6d9e3c6045fdff9e04c93221c417.

You can try again later or [upgrade](https://zeit.co/account/plan) your plan.


Si es que yo los pensaba subir cuando terminara la relación ya que me
estaba dando un nulo en el seed data de noticias.

El sáb., 8 de dic. de 2018 1:31 p. m., Luis Palacios <
notifications@github.com> escribió:

> @rafael180496 <https://github.com/rafael180496>
> Los archivos de migraciones ya deberian estar en el repositorio de tal
> forma que alguien mas para hacer set up del proyecto no debe agregar
> migraciones solo ejectuarlas con dotnet ef database update
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/rafael180496/newsSystem/commit/e34e1f023290521423694efbac752a7b1e61dab9#commitcomment-31608854>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AabNJ3qeotPEKqgq3btOfwtCpCwbIPOTks5u3BOWgaJpZM4ZJx89>
> .
>


Correcto, lo unico que mas tipado


closing [issue #1](#1) based on this commit.


Successfully aliased the URL <https://mdx-zsuvbzsaar.now.sh> to the following aliases.

* https://mdxjs.com
* https://www.mdxjs.com


Ich glaube da ist beim commiten etwas schief gelaufen, das scheint die falsche Datei zu sein.


The variable r and p are not descriptive.

Suggestion: change variable name r and p to random and player
`public Random r = new Random();``public Player player = new Player();`


Had to modify 0001-xen-privcmd-Add-IOCTL_PRIVCMD_DM_OP.patch while all other applied cleanly. This patch had conflicts for arm architecture - thus eliminated that code since it anyways not our target.


iptv y plex @anonimux y @Clay_was de telegram

iptv plex y Netflix contactar con @anonimux o Clay_was


Successfully aliased the URL <https://mflow-o6qovscm5.now.sh> to the following aliases.

* https://www.mflow.tech
* https://mflow.tech


Closes #644 and #643


@roschaefer seems to be related to merge conflicts. This one was resolved multiple times.


@mvl22 the PHP solution looks like it is per request (as it has `'REQUEST_METHOD'` and `'REQUEST_TIME'`) but here this is when the application is first initialized.  I don't think there is a Rails way of picking up the server name.

Given we hardcode `cyclescape.org` in the apache template I assume that other sites must do some alterations already. I can revert this if you like.


One note, In VTI Image currently only Zero 4k and hopefully also newer (Duo 4k) supports Vp9 profile 1 & profile 2. Older Vu+ 4k Boxes only support Vp9 profile 1.

see vp9 column in table
https://wiki.vuplus-support.org/index.php?title=Vu%2B_STB_Vergleichstabelle


не удобно так делать. лучше сделать наоборот
```
if (!(vector instanceof Vector)) {
    throw new Error('...');
}
// прочий код функции
```
так и вложенность уменьшится


nice tokens you accidentally left in there.


почему SyntaxError?


hiiiii


I don't think you necessarily wanted to leave these in there.


тут тоже надо сделать наизнанку - сначала ошибки. давай везде так сделаем


Available on AUR: https://aur.archlinux.org/packages/qt5-pbfimageplugin/


You are pushing commits at a very fast pace (accross the whole organization).
Due to that, we cannot deploy the commit 54cd15dbd38c58d94c92395e70d5b1a3214b91e2.

You can try again later or [upgrade](https://zeit.co/account/plan) your plan.


а зачем тернарник? выглядит ненужным


if выглядит излишним, сейчас это аналогично:
```
if (x) {
    return true;
} else {
   return false;
}
```

то есть, условный оператор можно оторвать


Great job! I always typed scripts to edit this variable. Now it is much simpler.


return undefined бесполезно в конце метода


Just pass `NULL` for `lParam` and you'll get the required size. No need to use a guessing loop.


Successfully aliased the URL <https://mflow-77g7kk07d.now.sh> to the following aliases.

* https://www.mflow.tech
* https://mflow.tech


Successfully aliased the URL <https://docs-acdfxfcukx.zeit.sh> to the following alias.

* https://docs.zeit.sh


oops. will add


sector?


actually updated the intro and installing sections, but i had re-commit and push to fix a merge conflict. closing [issue #3](#3) based on this commit.


Eeeeeee. Eeeeee eee eeeeeee eeeeeeee eeeeeee eeeeeee eeeeee eeeeeeeee eeeee eeeeeeee. Eeeeeeeee eeeeeeeee eeeeeeeeee eeee eeeee eeeeeee eeeeeeeee, eeee. Eeee eeeeee eeeeeeeee eeeee eeee eee. Eeee eeeeee, eeeeeeeee eeeee e eeee eeeee eeeeeee eeeeeeeee eeee eeee eeeeeeee ee, eeeeee. Eeeeeeeeeee ee eeeeee eeeeeeee eeee, eee eeeeee eeeeeee, eeeeeee eeee ee eeeeeeeeeeee eeeeee. Eeee. Eeeeee eeeeeeee eeeeeee eeee eeeeeee ee, ee eeee eeeeee eeeeeee eeeeeeeee eeee eeee eeeeeee ee. Eee eeeeeeeeee eeeeeeeeee ee eeee eeeeeeee eeeeeeeeee eeeeee. Eeee eeee, eee eeeee eee eeeeeeeeee eeeeee, eeee. Ee e eeeeee eeee, eeeeeeeeeeee. Eeee. Eeeeeee eeeeeeeee eee eeeeeee eeeee, eeeee eee eeee eeeeeeee eeeeeeeeeeee, eeeeee eeeee eeeeee. Eeeee eeeeeeeeee eeeeeee eeee.

Eeeeeeeee eeeee ee eeee eeeeeeeee eeeeee, eeeeeeee eeee, eeeeeeeee ee, eeeeeeeee eeee, eeeeeee eeeee. Ee eeeeeee eeee ee eeee eeeee. Eeeee eeee eeee eeeee ee eeeeee eeeeeeee eee eeeee eeee ee eee. Eeee eeeeeeeeee eeeeee, ee eeeee eeeeeeee ee, eeeee. Eeeee ee eeee eeeeeeeee ee. Eeeeeeeeee eeeeeee eee eeeeeeee eeeeeeeee eeeeee eeeeeeeee eeeee ee eeeeee. Eeeeeeeee, eeeeee. Ee eeeee eeeeee eeeeee eeeee eeee eeeeeeeee eeeeee, eeeeeeee eeeeeeeee. Eeeeeeeee eeeee, eeee eeeeeeee. Eeeeee eee, eeeeeeee eeeeeee eeeeeee eeeeee. Eeeee eeee eeeeee, eeeeeeeeee eeeeeeee eeeee eeeee eeeee, e, eeee. Eeeeeeeee eeee eeeee eeeeeeeeeee eee, eeeeee e, eeeeeeee eee, eeeee eeeeeeeee eee, eeee, eeeeeee. Eeeeeeeee eeeee, eeee eeeeeee ee eeeeeeeee eeeee eeeeeee, eeeeee eeeeee eee. Eeeee ee. Ee eeeeeeee eeeeeee, eeeeee eeee eeeee eeeeeeeeeee eeeeeeee eeeeeee eeee ee eeee eeeee. Eeeeeeeee eeeee ee eeeee eeeeee eeee eeeeeeeee eeee eee eeeeeee. Eeeeeee, eeeeeeee eeeeee. E eeeeee eeee eeee eeeeeeeee eeeee, ee eeeee eeeeee eeeee. Eeeeeee eeeee eeee eeeeeeeee eeeee, eeeee eee eeee. Eeeee eeeee e, eeee eeeeeeeeee eeeeee, ee eeee eeeeeeee eeeee.

Ee eeee eeeeeeeeeee eeeeeee eeeeeeeeeee eeee eeeeeeeee eeeeee. Eeeeee eeeeeeeee eeeeeeeeee eeee eeeeee eeeee eeeeeeeeeee eee. Eeeeeeeee eeeeee ee. Eeeee ee eee. Eeeeeee ee, eee eeeeeeeee eee eeeeeeee. Eeeeeee eeeee ee eeeeee. Eeeeeee eee eeeeeee eeeeeeee. Eeeee eeeeeeeeee eeeeeeee eeee eeeeee eee eeeeeee eeee, eeee eeeee eeeeee. Eeeee eeeee eeeeee eeeeeeeeee eeeee eeeeeee.

Eeeeeeeee eeeee. Eeeeeeee eeeeeeeee ee eeeeeeeee e, eeeee ee eeee, eeee eeeeee, eeeeee eeeeeee eeeeeee eeeeee. Eeeeee eeeeeee eeeeeee eeee eeeee ee eeee ee eeee. Eeee eee eeeeeee ee, eeee eeeeeeee eeeee eee eeeee. Eeee eeeee eeeeeeee, eee, eeee eeeeeeee eee, eeeeeee ee, eeeeeeeee. Ee eeeeeeee eeee eee eeeeeeeeeeee ee, eeeeeee. Eee, eeeeeee eeee, eeee, eeeeeee eeee, ee eeeee eeeeee ee. Eeeeeeeeee eeeeeeeee eeee eee eee ee eeee eeee ee. Ee eeeeeee eeee. E, eeeeee eeee eeeeee ee eeeeeeee eeeeee. Eeeeee. Eeee eee eeeee eeeee, eeeeee eeeeeeee eeeeee eeeeee eeeeeeee. Eeeeeeeee eeeeee eeeeeeee eeee, eee eeeee eeeee, eeeeeee eeee, eeeeeeeeeeee. Eeeee eeeee eeeeee eeeeeeee eeeee eeee ee.

Ee eeee eeeeeeeeeee eeeeeee, eeeeeeeeeee eeee eeeeeeeee eee. Eeeee eeeee eeeeeeee. Eeeeeee ee eeeeee eeeeeee eeeeeee eeee eeee, eeeeee, eeeeeee eeee eeeeeeeee eee, eeeeeee eeeeeeee eeee ee eeeee eeeeee. Eeeeeeee eeeee. Eeeee ee. Eeeeeee eeee ee eeeeeeeeeeee eeeeee, ee. Eeeeee eeeeeee, eeeeeee eeeeeeeee. Eeee eeeeeeeee eeeeeeeee eeee. Eeeee. Eeeeeeeee e eeeeeeeee eeeee, eeeeeeeee eeeeeee eeeeee eee eeee eeeeeeeeeeee eeeeeeee eeeee eeeeee, eeeeee eee eeeeeee. Eeeeeeeee ee, eeeee eeeeeeeeeeee eeeeeeee eeeee eee.


Please Am Not Getting How To Use The Mailer
Can I Get The Video Tutorial


Why keep the arguments here?


Note


ok I am also trying to figure this one out.


I wonder if it would work well on my end. Did you see what I did within the hour on my fork? I think it's called?


Our build didn't fail (I think it should), but Danger complained in PRs.
cc @pmusaraj


![](https://github.trello.services/images/mini-trello-icon.png) [See a tower's range by hovering over it](https://trello.com/c/toRRYnY2/62-see-a-towers-range-by-hovering-over-it)


Hi!  This is not a typo ;-)  Apt has been available since Debian 9:
https://manpages.debian.org/stretch/apt/apt.8.en.html

At this time the differences are fairly subtle, but all documentation has shifted (or is shifting) towards using "apt" for general usage instead of "apt-get".  The only oddity is Linux Mint provides its users with a different implementation of `apt`, but in this case I believe it's what Mint users expect.
https://itsfoss.com/apt-vs-apt-get-difference/


Hecked something up and this doesn't work anymore at all.


![script 8 1_small](https://user-images.githubusercontent.com/42807705/49680568-d6f6b980-fa63-11e8-91d1-33674ff5606d.png)


inverse-model (XuanLuoLBL) - Win64-Windows-7-VisualStudio-14: OK (3050 of 3051 tests passed, 0 test warnings)

Failures:

regression Test Summary
 * Passed: 631
 * Failed: 1

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.97%25-yellow.png)


Sorry. One of the problems with `@extend` is that it can rearrange the rules in the output, so inheritance doesn’t necessarily work as it would otherwise.


`Local Unset Universe Polymorphism` before this section seems to make this line go through.


In practice it probably wouldn’t cause a noticeable performance problem, but if any links were added to the page after this function ran, those links wouldn’t get the new styling applied.


ok


Its mine


isn't this superseded by `lia`?


Right I left in support for the old numbers because updating config.info doesn't remove those settings from existing user's configs.


Why are you initializing to zero?  This is very bad for training.  Initialization is very important during training.  I'm going to attempt to ignore this part and continue to pass in the properly-initialized version from the host within `epoch_loop()`.


Thanks both! I have a questions about "require(addy != address(0));"
I am looking this up and it says that address(0) is the zero address where Ether gets burned, so lost. Does this require statement say that the address cannot be the zero address? Or does it is say address can't be null? I've tried a lot of variations, but I can't get a require to work that will check if two addresses are input to the function. Yet when I run the deposit function without any address and without the require it fails regardless with the a 'Error endcoding arguments: Error: invalid address (arg="", type="string", value'""). So it seems that even if I am Alice, I have a value but I don't input addresses (and I don't have a require to check addresses), the function will not do anything. That's very confusing... I am not sure if I need a require to check addresses and if I do how I can check there exactly two addresses inputted!?


See, Slack. v2 has bugs that prevents us from doing host side allocations. So we'll need to figure something out. This was just for testing.


Conceptual models


Successfully aliased the URL <https://anthony-codes-iu1g1b6k9.now.sh> to the following alias.

* https://anthony.codes


Thank you


Fixed the file extension issue in commit 0918134.

I'll try to work in a better error handling when node can't be found... shortly.


Deployed at: https://alva-commits-1b7095940e0ea46123c25f8154bfdcc23465f8bd.surge.sh


![](https://github.trello.services/images/mini-trello-icon.png) [(1) Editar a informação contida no ficheiro XML](https://trello.com/c/2VoNC8zR/26-1-editar-a-informa%C3%A7%C3%A3o-contida-no-ficheiro-xml)


version 2


I disagree with this as a simplification.

1. is_ok calls from_sq and to_sq which are more expensive than checking for equality with a constant.
2. `MOVE_NULL` and `MOVE_NONE` imply subtleties which I feel might be better to leave explicitly clearer. `MOVE_NONE` generally indicates the lack of a move, say in the end of a movepicker list or in the case of a rootNode, a missing move for `(ss-1)`. `MOVE_NULL` indicates something to do with null move pruning, where we try to evaluate a position if one side passes/skips their turn. This is useful for catching that behavior in certain plies, to avoid immediately having a recursion, or to speed up eval.

As an example and also to explain the bench change, it happens somewhere around line 743, `MOVE_NULL` means our opponent passed and so we can speed up the evaluation for this position, by taking the evaluation of the previous position (which remains the same) and add some tempo bonus (line 753). By using `is_ok` here, we start to check also for `MOVE_NONE` which only really happens in the `rootNode` case. Of course, getting the eval from `(ss-1)` wouldn't make sense in that case, since we have not evaluated anything yet.


`PAL_TOWN_00` through `PAL_TOWN_0D` correspond to the original Kanto towns/cities in RBY. Compare the colors with pokered/data/super_palettes.asm; they're route beige, Pallet white, Viridian green, Pewter gray, Cerulean blue, etc, in order. (So either their pairing with Spaceworld's region-towns is coincidental, or they were intentionally designed to go with the same colors.)


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


we don't have table sampling_feature_extension_property anymore, please remove it.


This is not ok.


vhjkjll


the variable ct is not intuitive.

Suggestion: change ct to currentTime


This is unused code which should be deleted.

Suggestion: delete this comment.


Good work figuring out a fix.
Shouldn't this value be 150mA according to the official dts: https://github.com/tissot-dev/Xiaomi_Kernel_OpenSource/blob/tissot-n-oss/arch/arm/boot/dts/qcom/msm-pmi8950.dtsi#L323


Successfully aliased the URL <https://personal-site-gjynflsjqu.now.sh> to the following alias.

* https://site.sergiodxa.com


That is one of the worst possible approaches. :-(
You are changing a global variable as a side-effect.
To make it worse, you add the number to the end of the list. Which means that NCONC traverses the list each time. And each time the list grows longer. So instead of traversing the list 1 or 2 times, you'll end up traversing the list n*n/2 times. Which hits you with larger lists.

But none of this is necessary, since you don't need to create a list, which you then use as args to a plus function. Well, in the general case it also does not work, since + does not take arbitrary long number of arguments. Some implementation take only as much as 50 args.

All you need to do is to get the LOOP above to parse the number and add it up.


Successfully aliased the URL <https://mflow-8zaubiz5v.now.sh> to the following aliases.

* https://www.mflow.tech
* https://mflow.tech


Man that was a nice lunch I'm telling you


**Evaluation:** This method would be empty method, and has no usage.

**Suggestion:** delete this method.


This is the initial version of the game, which is very simple and too much revealing.  Since the move is not encrypted, next player can always see the move of the first one and can take unwanted advantage.
Now as a next iteration, I need to provide encryption to the system and will implement 'commit-release' pattern to safeguard player interest.


I wasn't sure if the name was the issue for onEachFeature, so I deleted the "school" in the original 2013 School Closings geojson file. To see if I could call it. But, alas it didn't matter. So now I have one geojson file with the property of 'name' (2013_School_Closings.geojson) and one file with the property of 'school_name' (2013Closed.geojson) file.


No, it shouldn't. Official dts actually uses "pmi8940"


Empty comment from line 40 to line 42.

Suggestion: delete the empty comment.


Cause of #31, expression always returns NaN when evaluated


Sorry, wrong commit message... :sweat_smile:


Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

- @epruesse was added to this feedstock maintenance team.

You should get push access to this feedstock and CI services.

Feel free to join the community [chat room](https://gitter.im/conda-forge/conda-forge.github.io).

NOTE: Please make sure to not push to the repository directly.
      Use branches in your fork for any changes and send a PR.
      More details [here](https://conda-forge.org/docs/conda-forge_gotchas.html#using-a-fork-vs-a-branch-when-updating-a-recipe)


Ok thanks


NaN + any number = NaN.

Also, NaN != NaN, Double.isNaN() should be used instead so error messages are printed.


LucyLiu99 I'm wondering the same thing. That's the only part that is really having me confused. I think it must have to do with the string value inserted, but I don't understand how it works. Any help from anyone on here would be great. Thanks!


Thank you for continuing to do this.


name g2d is not intuitive.

Suggestion: change g2d to graphics2d.


OK, so now, this commit cd03021d790e0f0f5 is strange and seems to be wrong


That's still the wrong logic. The function allChoicesAreDefault goes over all options and is supposed to check if any of them is not equal to the default.

That's why it's only exiting the loop on finding something unequal, but continues when the values are the same.

For tables, the same must happen. If the tables are equal, continue with the next option. If they aren't equal, we found a option that isn't on the default vaue and should exit that function.

If you don't mind, I'll take your patch and correct that.


Awesome should have time to check this out tomorrow or Monday morning!


You are pushing commits at a very fast pace (accross the whole organization).
Due to that, we cannot deploy the commit 879de04be3a54fe6a9e43c76ce0dbde79966a576.

You can try again later or [upgrade](https://zeit.co/account/plan) your plan.


unnecessary comment

suggestion: delete this comment


right


It'll probably be awhile before it'll be ready for a non-dev to adopt, sadly. I'll take a look at it again later today or tomorrow to see how much more work is required.


Mantai, tiksliai nežinau, gal internetuose taip ir daroma, bet jaučiu iš props'ų setinti į state tai kažkokia painiava gaunasi. Gal Agnis patars šituose reikaluose labiau.


k28 - k28.cpp
Loss of LCD screen

![k28-diff](https://user-images.githubusercontent.com/9075896/49690299-7798b800-fafc-11e8-83fb-3293ce0e688d.png)


You are pushing commits at a very fast pace (accross the whole organization).
Due to that, we cannot deploy the commit 8dfee9da810d661e6b9deea3f4ce4f4f00c3ebec.

You can try again later or [upgrade](https://zeit.co/account/plan) your plan.


TODO: All other filters also have to be updated to not included deleted docs.


Should we show deleted drafts as well?


There's actually an update of the three on staging-next.


Test message


done


merget r52 please


Examples were useful...


It was really a while ... from what I remember I scripted gdb to dump all calls and arguments to openssl functions


 Variable w and h in line 75 and p in line 76 are not intuitive and the declaration in line 75 and line 76 should be one per line.

Suggestion: one declaration per line; change w to imgWidth; change h to imgHeight; change p to pixel!?


it's a standard method of php class. it being used for class initialization.
at the moment i didn't use it, but maybe later it will be used. but if you want I can remove it.


take it up with `dh_virtualenv`'s devs


![](https://github.trello.services/images/mini-trello-icon.png) [Placement ghost does not go through clips](https://trello.com/c/X0CKm396/61-placement-ghost-does-not-go-through-clips)


'cos I haven't got the code to add to the changelog in an automated way yet


but -z9 is the -z for smol :)


ok. old habits die hard :)


This is while we're putting this in beta, it's intended to end up as `matrix-synapse`


what is sx used for!? non descriptive name

Suggestion: use more intuitive name.


The Background property on ItemsRepeater was just recently added to enable a developer to treat it as a drop target by making it Transparent rather than the default of null.  Check with Ranjesh whether this should still have the Background as part of the BasicDemo


i did this


[R/gis.R:59:45:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/gis.R#L59) *style:* **Variable or function name should be lowerCamelCase.**
```r
factorValues2 <- function(x, v, layer, att, append.names, na.rm = FALSE) {
                                            ^~~~~~~~~~~~
```
[R/gis.R:59:59:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/gis.R#L59) *style:* **Variable or function name should be lowerCamelCase.**
```r
factorValues2 <- function(x, v, layer, att, append.names, na.rm = FALSE) {
                                                          ^~~~~
```
[R/LANDIS-II-tables.R:96:1:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L96) *style:* **Lines should not be more than 100 characters.**
```r
  speciesTable <- speciesTable[species %in% equivalentName(sppNameVector, speciesEquivalency, "LANDIS_traits", multi = TRUE) &
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/LANDIS-II-tables.R:100:1:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L100) *style:* **Lines should not be more than 100 characters.**
```r
  speciesTable <- speciesTable[, lapply(.SD, function(x) if (is.numeric(x)) min(x, na.rm = TRUE) else x[1]), by = "species"]
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/LANDIS-II-tables.R:132:16:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L132) *style:* **Commented code should be removed.**
```r
  maxcol <- 13#max(count.fields(file.path(dPath, "species.txt"), sep = ""))
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/LANDIS-II-tables.R:142:46:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L142) *style:* **Commas should always have a space after.**
```r
                   col.names = c(paste("col",1:maxcol, sep = "")),
                                             ^
```
[R/LANDIS-II-tables.R:146:26:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L146) *style:* **Put spaces around all infix operators.**
```r
  species <- species[col1!= "LandisData",]
                        ~^
```
[R/LANDIS-II-tables.R:146:42:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L146) *style:* **Commas should always have a space after.**
```r
  species <- species[col1!= "LandisData",]
                                         ^
```
[R/LANDIS-II-tables.R:147:26:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L147) *style:* **Put spaces around all infix operators.**
```r
  species <- species[col1!= ">>",]
                        ~^
```
[R/LANDIS-II-tables.R:147:34:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L147) *style:* **Commas should always have a space after.**
```r
  species <- species[col1!= ">>",]
                                 ^
```
[R/LANDIS-II-tables.R:153:13:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L153) *style:* **Only use double-quotes.**
```r
  species[, ':='(seeddistance_eff = gsub(",", "", seeddistance_eff),
            ^~~~
```
[R/LANDIS-II-tables.R:153:17:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L153) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  species[, ':='(seeddistance_eff = gsub(",", "", seeddistance_eff),
                ^
```
[R/LANDIS-II-tables.R:166:18:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L166) *style:* **Only use double-quotes.**
```r
  speciesAddon[, ':='(leaflongevity = as.numeric(leaflongevity),
                 ^~~~
```
[R/LANDIS-II-tables.R:166:22:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L166) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  speciesAddon[, ':='(leaflongevity = as.numeric(leaflongevity),
                     ^
```
[R/LANDIS-II-tables.R:178:13:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L178) *style:* **Only use double-quotes.**
```r
  species[, ':='(species = paste0(toupper(substring(species1, 1, 1)),
            ^~~~
```
[R/LANDIS-II-tables.R:178:17:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L178) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  species[, ':='(species = paste0(toupper(substring(species1, 1, 1)),
                ^
```
[R/LANDIS-II-tables.R:182:13:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L182) *style:* **Only use double-quotes.**
```r
  species[, ':='(species1 = NULL, species2 = NULL)]
            ^~~~
```
[R/LANDIS-II-tables.R:182:17:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L182) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  species[, ':='(species1 = NULL, species2 = NULL)]
                ^
```
[R/LANDIS-II-tables.R:210:39:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L210) *style:* **Commas should always have a space after.**
```r
  mainInput <- mainInput[col1 != ">>",]
                                      ^
```
[R/LANDIS-II-tables.R:237:16:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L237) *style:* **Commented code should be removed.**
```r
  maxcol <- 5 #max(count.fields(file.path(dPath, "ecoregions.txt"), sep = ""))
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/LANDIS-II-tables.R:253:47:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L253) *style:* **Commas should always have a space after.**
```r
  ecoregion <- ecoregion[col1 != "LandisData",]
                                              ^
```
[R/LANDIS-II-tables.R:254:39:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L254) *style:* **Commas should always have a space after.**
```r
  ecoregion <- ecoregion[col1 != ">>",]
                                      ^
```
[R/LANDIS-II-tables.R:298:61:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L298) *style:* **Commas should always have a space after.**
```r
  speciesEcoregion <- speciesEcoregion[col1 != "LandisData",]
                                                            ^
```
[R/LANDIS-II-tables.R:299:53:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L299) *style:* **Commas should always have a space after.**
```r
  speciesEcoregion <- speciesEcoregion[col1 != ">>",]
                                                    ^
```
[R/LANDIS-II-tables.R:310:22:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L310) *style:* **Only use double-quotes.**
```r
  speciesEcoregion[, ':='(species = paste0(toupper(substring(species1, 1, 1)),
                     ^~~~
```
[R/LANDIS-II-tables.R:310:26:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L310) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  speciesEcoregion[, ':='(species = paste0(toupper(substring(species1, 1, 1)),
                         ^
```
[R/LANDIS-II-tables.R:313:22:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L313) *style:* **Only use double-quotes.**
```r
  speciesEcoregion[, ':='(species1 = NULL, species2 = NULL)]
                     ^~~~
```
[R/LANDIS-II-tables.R:313:26:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/LANDIS-II-tables.R#L313) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  speciesEcoregion[, ':='(species1 = NULL, species2 = NULL)]
                         ^
```
[R/maps.R:20:29:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/maps.R#L20) *style:* **Variable or function name should be lowerCamelCase.**
```r
defineFlammable <- function(LandCoverClassifiedMap = NULL,
                            ^~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:101:37:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/maps.R#L101) *style:* **Commented code should be removed.**
```r
  sumVegPct <- sum(speciesStack) ## na.rm = TRUE
                                    ^~~~~~~~~~~~
```
[R/maps.R:171:23:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/maps.R#L171) *style:* **Variable or function name should be lowerCamelCase.**
```r
  attritable[ID == 5, Factor := "Mixed"]
                      ^~~~~~
```
[R/maps.R:222:79:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/maps.R#L222) *style:* **Commas should always have a space after.**
```r
  sppEquiv <- speciesEquivalency[!is.na(speciesEquivalency[[sppEndNamesCol]]),]
                                                                              ^
```
[R/maps.R:251:1:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/maps.R#L251) *style:* **Lines should not be more than 100 characters.**
```r
  kNNnames <- as.character(equivalentName(sppNameVector, sppEquiv, column = knnNamesCol, multi = TRUE))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:256:1:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/maps.R#L256) *style:* **Lines should not be more than 100 characters.**
```r
                   knnNamesCol, ".\n Will use remaining matching species, but check if this is correct"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/maps.R:288:47:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/maps.R#L288) *style:* **Put spaces around all infix operators.**
```r
  if (!all(file_path_sans_ext(names(archives))==file_path_sans_ext(targetFiles)))
                                             ~^~~
```
[R/maps.R:423:7:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/maps.R#L423) *style:* **Variable or function name should be lowerCamelCase.**
```r
      LQRastName <- basename(tempfile(fileext = ".tif"))
      ^~~~~~~~~~
```
[R/maps.R:425:9:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/maps.R#L425) *style:* **Variable or function name should be lowerCamelCase.**
```r
        LQCurName <- basename(tempfile(fileext = ".tif"))
        ^~~~~~~~~
```
[R/maps.R:432:7:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/maps.R#L432) *style:* **Variable or function name should be lowerCamelCase.**
```r
      LQRastInHQcrs <- projectExtent(lowQualityStack, crs = crs(highQualityStack))
      ^~~~~~~~~~~~~
```
[R/maps.R:445:7:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/maps.R#L445) *style:* **Variable or function name should be lowerCamelCase.**
```r
      LQRast <- raster(LQRastName)
      ^~~~~~
```
[R/maps.R:463:9:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/maps.R#L463) *style:* **Variable or function name should be lowerCamelCase.**
```r
        HQRast <- raster(tmpHQName)
        ^~~~~~
```
[R/maps.R:468:9:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/maps.R#L468) *style:* **Variable or function name should be lowerCamelCase.**
```r
        HQRast <- highQualityStack[[SPP]]
        ^~~~~~
```
[R/maps.R:471:7:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/maps.R#L471) *style:* **Variable or function name should be lowerCamelCase.**
```r
      LQRast <- lowQualityStack[[SPP]]
      ^~~~~~
```
[R/maps.R:472:7:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/maps.R#L472) *style:* **Variable or function name should be lowerCamelCase.**
```r
      HQRast <- highQualityStack[[SPP]]
      ^~~~~~
```
[R/maps.R:479:5:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/maps.R#L479) *style:* **Variable or function name should be lowerCamelCase.**
```r
    NAs <- is.na(HQRast[])
    ^~~
```
[R/maps.R:483:5:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/maps.R#L483) *style:* **Variable or function name should be lowerCamelCase.**
```r
    HQRast <- writeRaster(HQRast, datatype = "INT1U",
    ^~~~~~
```
[R/maps.R:493:7:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/maps.R#L493) *style:* **Variable or function name should be lowerCamelCase.**
```r
      HQRast <- highQualityStack[[SPP]]
      ^~~~~~
```
[R/maps.R:497:7:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/maps.R#L497) *style:* **Variable or function name should be lowerCamelCase.**
```r
      LQRast <- lowQualityStack[[SPP]]
      ^~~~~~
```
[R/maps.R:501:7:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/maps.R#L501) *style:* **Variable or function name should be lowerCamelCase.**
```r
      HQRast <- highQualityStack[[SPP]]
      ^~~~~~
```
[R/maps.R:529:6:](https://github.com/PredictiveEcology/pemisc/blob/5a7908e479a57527928204cff22c6d8315e009ef/R/maps.R#L529) *style:* **Commented code should be removed.**
```r
    #names(sppMerges) <- equivalentName(names(sppMerges), sppEquiv,  column = sppEndNamesCol)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


not descriptive variable name l.

Suggestion: change l to list or listObjects


Successfully aliased the URL <https://knife-landing-6ylhljxdl.now.sh> to the following alias.

* https://knife.dotmap.co


or rather, https://github.com/Springerle/dh-virtualenv-mold, because writing all this stuff by hand is confusing :)


@andrewshadura you probably want to look at https://github.com/matrix-org/synapse/pull/4212 instead. this was an initial diff for @richvdh 's benefit


not descriptive variable name l.

Suggestion: change g to game


Actually this is also webpack vodoo. Although different one.


we may need to change this to => default(DateTime) and => default(long) depends on the compiler version we are using


not descriptive variable name g and bs.

Suggestion: change g to game; and bs to bufferStrategy


Possible that the other way around the adaptation in the aiograb would be useful, but it works at least again.


Hey happy to help. No PMs on GitHub but no tip needed, thanks anyway though!

If you have any other suggestions let me know (in a new issue) and I'll see what I can do.


Oh cool, thanks! Any particular reason you're sending that update to staging first? These don't really cause massive rebuilds do they?


unnecessary new line.

Suggestion: remove the new line.


лог надо убрать


Empty comment.

Suggestion: remove the comment


Hi,
Could you fix the derps in drivers/input/joystick/xpad.c.
Thanks you for all you do for the samsung community.


Comment


non descriptive variable name, t , mc, tk.

Suggestion: change to more intuitive name.


unnecessary comment.


hi! why did we need to drop iOS 8 and 9? are there any chances to add support back? thanks!


I like getting rid of "ps", but I'm not sure if we can get rid of "env". I think sudo deletes most environment variables before it executes the child process.


Thanks. Just a note - the license is LGPL so everyone can use the plugin.


## Summary
There were 9 violations and 47 warnings found.

Show details
### `my-repo-name/contracts/Migrations.sol`

Show violations and warnings
#### LockedEther
Show results
- on line 2
  ```
  pragma solidity ^0.4.23;

  contract Migrations {    // <--
    address public owner;
    uint public last_completed_migration;
```

#### MissingInputValidation
Show results
##### Violations
- on line 14
  ```
    }

    function setCompleted(uint completed) public restricted {    // <--
      last_completed_migration = completed;
    }
```
##### Warnings
- on line 3
  ```

  contract Migrations {
    address public owner;    // <--
    uint public last_completed_migration;

```
- on line 4
  ```
  contract Migrations {
    address public owner;
    uint public last_completed_migration;    // <--

    constructor() public {
```
- on line 18
  ```
    }

    function upgrade(address new_address) public restricted {    // <--
      Migrations upgraded = Migrations(new_address);
      upgraded.setCompleted(last_completed_migration);
```

#### UnhandledException
Show results
##### Warnings
- on line 20
  ```
    function upgrade(address new_address) public restricted {
      Migrations upgraded = Migrations(new_address);
      upgraded.setCompleted(last_completed_migration);    // <--
    }
  }
```

#### UnrestrictedEtherFlow
Show results
##### Warnings
- on line 20
  ```
    function upgrade(address new_address) public restricted {
      Migrations upgraded = Migrations(new_address);
      upgraded.setCompleted(last_completed_migration);    // <--
    }
  }
```

#### UnrestrictedWrite
Show results
##### Warnings
- on line 15
  ```

    function setCompleted(uint completed) public restricted {
      last_completed_migration = completed;    // <--
    }

```

### `my-repo-name/contracts/Sweeper.sol`

Show violations and warnings
#### LockedEther
Show results
##### Warnings
- in contract

### `my-repo-name/contracts/Sweeper.sol`

Show violations and warnings
#### LockedEther
Show results
##### Warnings
- in contract

### `my-repo-name/contracts/Sweeper.sol`

Show violations and warnings
#### LockedEther
Show results
- on line 96
  ```
  }

  contract Controller is AbstractSweeperList {    // <--
      address public owner;
      address public authorizedCaller;
```

#### MissingInputValidation
Show results
##### Violations
- on line 129
  ```
      }

      function changeAuthorizedCaller(address _newCaller) onlyOwner public {    // <--
          authorizedCaller = _newCaller;
      }
```
- on line 133
  ```
      }

      function changeDestination(address _dest) onlyOwner public {    // <--
          destination = _dest;
      }
```
- on line 137
  ```
      }

      function changeOwner(address _owner) onlyOwner public {    // <--
          owner = _owner;
      }
```
- on line 157
  ```
      mapping (address => address) sweepers;

      function addSweeper(address _token, address _sweeper) onlyOwner public {    // <--
          sweepers[_token] = _sweeper;
      }
```
- on line 161
  ```
      }

      function sweeperOf(address _token) public returns (address) {    // <--
          address sweeper = sweepers[_token];
          if (sweeper == 0) sweeper = defaultSweeper;
```
- on line 167
  ```
      }

      function logSweep(address from, address to, address token, uint amount) public {    // <--
          emit LogSweep(from, to, token, amount);
      }
```
##### Warnings
- on line 96
  ```
  }

  contract Controller is AbstractSweeperList {    // <--
      address public owner;
      address public authorizedCaller;
```
- on line 97
  ```

  contract Controller is AbstractSweeperList {
      address public owner;    // <--
      address public authorizedCaller;

```
- on line 98
  ```
  contract Controller is AbstractSweeperList {
      address public owner;
      address public authorizedCaller;    // <--

      address public destination;
```
- on line 100
  ```
      address public authorizedCaller;

      address public destination;    // <--

      bool public halted;
```
- on line 102
  ```
      address public destination;

      bool public halted;    // <--

      event LogNewWallet(address receiver);
```
- on line 141
  ```
      }

      function makeWallet() onlyAdmins public returns (address wallet) {    // <--
          wallet = address(new UserWallet(this));
          emit LogNewWallet(wallet);
```
- on line 146
  ```
      }

      function halt() onlyAdmins public {    // <--
          halted = true;
      }
```
- on line 150
  ```
      }

      function start() onlyOwner public {    // <--
          halted = false;
      }
```
- on line 154
  ```
      }

      address public defaultSweeper = address(new DefaultSweeper(this));    // <--
      mapping (address => address) sweepers;

```

#### UnrestrictedWrite
Show results
- on line 130
  ```

      function changeAuthorizedCaller(address _newCaller) onlyOwner public {
          authorizedCaller = _newCaller;    // <--
      }

```
- on line 134
  ```

      function changeDestination(address _dest) onlyOwner public {
          destination = _dest;    // <--
      }

```
- on line 138
  ```

      function changeOwner(address _owner) onlyOwner public {
          owner = _owner;    // <--
      }

```
- on line 147
  ```

      function halt() onlyAdmins public {
          halted = true;    // <--
      }

```
- on line 151
  ```

      function start() onlyOwner public {
          halted = false;    // <--
      }

```
- on line 158
  ```

      function addSweeper(address _token, address _sweeper) onlyOwner public {
          sweepers[_token] = _sweeper;    // <--
      }

```

### `my-repo-name/contracts/Sweeper.sol`

Show violations and warnings
#### DAOConstantGas
Show results
##### Warnings
- on line 60
  ```
              }

              success = destination.send(amountInWei);    // <--
          }

```

#### LockedEther
Show results
##### Warnings
- on line 35
  ```
  }

  contract DefaultSweeper is AbstractSweeper {    // <--
      constructor(address controller) AbstractSweeper(controller) public {}

```

#### MissingInputValidation
Show results
##### Warnings
- on line 38
  ```
      constructor(address controller) AbstractSweeper(controller) public {}

      function sweep(address _token, uint _amount)    // <--
      canSweep
      public
```

#### TODAmount
Show results
##### Warnings
- on line 60
  ```
              }

              success = destination.send(amountInWei);    // <--
          }

```

#### TODReceiver
Show results
##### Warnings
- on line 60
  ```
              }

              success = destination.send(amountInWei);    // <--
          }

```

#### UnhandledException
Show results
##### Warnings
- on line 16
  ```

      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());    // <--
          require(!controller.halted());
          _;
```
- on line 17
  ```
      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());
          require(!controller.halted());    // <--
          _;
      }
```
- on line 43
  ```
      returns (bool) {
          bool success = false;
          address destination = controller.destination();    // <--

          if (_token != address(0)) {
```
- on line 48
  ```
              Token token = Token(_token);
              uint amount = _amount;
              if (amount > token.balanceOf(this)) {    // <--
                  return false;
              }
```
- on line 52
  ```
              }

              success = token.transfer(destination, amount);    // <--
          }
          else {
```
- on line 64
  ```

          if (success) {
              controller.logSweep(this, destination, _token, _amount);    // <--
          }
          return success;
```

#### UnrestrictedEtherFlow
Show results
##### Warnings
- on line 16
  ```

      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());    // <--
          require(!controller.halted());
          _;
```
- on line 17
  ```
      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());
          require(!controller.halted());    // <--
          _;
      }
```
- on line 43
  ```
      returns (bool) {
          bool success = false;
          address destination = controller.destination();    // <--

          if (_token != address(0)) {
```
- on line 48
  ```
              Token token = Token(_token);
              uint amount = _amount;
              if (amount > token.balanceOf(this)) {    // <--
                  return false;
              }
```
- on line 52
  ```
              }

              success = token.transfer(destination, amount);    // <--
          }
          else {
```
- on line 64
  ```

          if (success) {
              controller.logSweep(this, destination, _token, _amount);    // <--
          }
          return success;
```
- on line 60
  ```
              }

              success = destination.send(amountInWei);    // <--
          }

```

### `my-repo-name/contracts/Sweeper.sol`

Show violations and warnings
#### LockedEther
Show results
##### Warnings
- on line 22
  ```
  }

  contract Token {    // <--
      function balanceOf(address a) public returns (uint) {
          (a);
```

### `my-repo-name/contracts/Sweeper.sol`

Show violations and warnings
#### LockedEther
Show results
##### Violations
- on line 70
  ```
  }

  contract UserWallet {    // <--
      AbstractSweeperList sweeperList;
      constructor(address _sweeperList) public {
```

#### MissingInputValidation
Show results
##### Violations
- on line 84
  ```
       }

      function sweep(address _token, uint _amount)    // <--
      public
      returns (bool) {
```
##### Warnings
- on line 78
  ```
      function () public payable { }

      function tokenFallback(address _from, uint _value, bytes _data) public {    // <--
          (_from);
          (_value);
```

#### UnhandledException
Show results
##### Warnings
- on line 88
  ```
      returns (bool) {
          (_amount);
          return sweeperList.sweeperOf(_token).delegatecall(msg.data);    // <--
      }
  }
```

#### UnrestrictedEtherFlow
Show results
##### Warnings
- on line 88
  ```
      returns (bool) {
          (_amount);
          return sweeperList.sweeperOf(_token).delegatecall(msg.data);    // <--
      }
  }
```


test comment


We opened that npm account just this year and have been managing packages under it for usage with both some private and open source packages. AFAIK it was always a @ahmadnassri project just inside the GitHub org of Kong. Would gladly take control and begin maintaining this project if he grants access. If it's very important you can point your package.json at the commit hash and your projects will use GitHub instead of npm registry in the meanwhile.


not descriptive variable name.

Suggestion: use more intuitive name gamePanel !?


Nice work :+1:


Would be good to resurrect this plugin it works really well i find with the new plex and new updates to subsonic since started the first time you click to play a track it gives an error to contact the forum , Would love to get this updated


NEVER FORGET TO REWRITE THIS!!!


useless blank line

suggestion: remove the empty line.


the lines from 37-47 are out of alignment.

Suggestion: make them all to the same alignment


Successfully aliased the URL <https://betamalvense-4qidgisjx.now.sh> to the following alias.

* https://beta.malven.se


## Summary
There were 9 violations and 47 warnings found.

Show details

### `my-repo-name/contracts/Migrations.sol`

Show violations and warnings

#### LockedEther

Show results
- on line 2

```
  pragma solidity ^0.4.23;

  contract Migrations {    // <--
    address public owner;
    uint public last_completed_migration;
```

#### MissingInputValidation

Show results

##### Violations
- on line 14

```
    }

    function setCompleted(uint completed) public restricted {    // <--
      last_completed_migration = completed;
    }
```

##### Warnings
- on line 3

```

  contract Migrations {
    address public owner;    // <--
    uint public last_completed_migration;

```
- on line 4

```
  contract Migrations {
    address public owner;
    uint public last_completed_migration;    // <--

    constructor() public {
```
- on line 18

```
    }

    function upgrade(address new_address) public restricted {    // <--
      Migrations upgraded = Migrations(new_address);
      upgraded.setCompleted(last_completed_migration);
```

#### UnhandledException

Show results

##### Warnings
- on line 20

```
    function upgrade(address new_address) public restricted {
      Migrations upgraded = Migrations(new_address);
      upgraded.setCompleted(last_completed_migration);    // <--
    }
  }
```

#### UnrestrictedEtherFlow

Show results

##### Warnings
- on line 20

```
    function upgrade(address new_address) public restricted {
      Migrations upgraded = Migrations(new_address);
      upgraded.setCompleted(last_completed_migration);    // <--
    }
  }
```

#### UnrestrictedWrite

Show results

##### Warnings
- on line 15

```

    function setCompleted(uint completed) public restricted {
      last_completed_migration = completed;    // <--
    }

```

### `my-repo-name/contracts/Sweeper.sol`

Show violations and warnings

#### LockedEther

Show results

##### Warnings
- in contract

### `my-repo-name/contracts/Sweeper.sol`

Show violations and warnings

#### LockedEther

Show results

##### Warnings
- in contract

### `my-repo-name/contracts/Sweeper.sol`

Show violations and warnings

#### LockedEther

Show results
- on line 96

```
  }

  contract Controller is AbstractSweeperList {    // <--
      address public owner;
      address public authorizedCaller;
```

#### MissingInputValidation

Show results

##### Violations
- on line 129

```
      }

      function changeAuthorizedCaller(address _newCaller) onlyOwner public {    // <--
          authorizedCaller = _newCaller;
      }
```
- on line 133

```
      }

      function changeDestination(address _dest) onlyOwner public {    // <--
          destination = _dest;
      }
```
- on line 137

```
      }

      function changeOwner(address _owner) onlyOwner public {    // <--
          owner = _owner;
      }
```
- on line 157

```
      mapping (address => address) sweepers;

      function addSweeper(address _token, address _sweeper) onlyOwner public {    // <--
          sweepers[_token] = _sweeper;
      }
```
- on line 161

```
      }

      function sweeperOf(address _token) public returns (address) {    // <--
          address sweeper = sweepers[_token];
          if (sweeper == 0) sweeper = defaultSweeper;
```
- on line 167

```
      }

      function logSweep(address from, address to, address token, uint amount) public {    // <--
          emit LogSweep(from, to, token, amount);
      }
```

##### Warnings
- on line 96

```
  }

  contract Controller is AbstractSweeperList {    // <--
      address public owner;
      address public authorizedCaller;
```
- on line 97

```

  contract Controller is AbstractSweeperList {
      address public owner;    // <--
      address public authorizedCaller;

```
- on line 98

```
  contract Controller is AbstractSweeperList {
      address public owner;
      address public authorizedCaller;    // <--

      address public destination;
```
- on line 100

```
      address public authorizedCaller;

      address public destination;    // <--

      bool public halted;
```
- on line 102

```
      address public destination;

      bool public halted;    // <--

      event LogNewWallet(address receiver);
```
- on line 141

```
      }

      function makeWallet() onlyAdmins public returns (address wallet) {    // <--
          wallet = address(new UserWallet(this));
          emit LogNewWallet(wallet);
```
- on line 146

```
      }

      function halt() onlyAdmins public {    // <--
          halted = true;
      }
```
- on line 150

```
      }

      function start() onlyOwner public {    // <--
          halted = false;
      }
```
- on line 154

```
      }

      address public defaultSweeper = address(new DefaultSweeper(this));    // <--
      mapping (address => address) sweepers;

```

#### UnrestrictedWrite

Show results
- on line 130

```

      function changeAuthorizedCaller(address _newCaller) onlyOwner public {
          authorizedCaller = _newCaller;    // <--
      }

```
- on line 134

```

      function changeDestination(address _dest) onlyOwner public {
          destination = _dest;    // <--
      }

```
- on line 138

```

      function changeOwner(address _owner) onlyOwner public {
          owner = _owner;    // <--
      }

```
- on line 147

```

      function halt() onlyAdmins public {
          halted = true;    // <--
      }

```
- on line 151

```

      function start() onlyOwner public {
          halted = false;    // <--
      }

```
- on line 158

```

      function addSweeper(address _token, address _sweeper) onlyOwner public {
          sweepers[_token] = _sweeper;    // <--
      }

```

### `my-repo-name/contracts/Sweeper.sol`

Show violations and warnings

#### DAOConstantGas

Show results

##### Warnings
- on line 60

```
              }

              success = destination.send(amountInWei);    // <--
          }

```

#### LockedEther

Show results

##### Warnings
- on line 35

```
  }

  contract DefaultSweeper is AbstractSweeper {    // <--
      constructor(address controller) AbstractSweeper(controller) public {}

```

#### MissingInputValidation

Show results

##### Warnings
- on line 38

```
      constructor(address controller) AbstractSweeper(controller) public {}

      function sweep(address _token, uint _amount)    // <--
      canSweep
      public
```

#### TODAmount

Show results

##### Warnings
- on line 60

```
              }

              success = destination.send(amountInWei);    // <--
          }

```

#### TODReceiver

Show results

##### Warnings
- on line 60

```
              }

              success = destination.send(amountInWei);    // <--
          }

```

#### UnhandledException

Show results

##### Warnings
- on line 16

```

      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());    // <--
          require(!controller.halted());
          _;
```
- on line 17

```
      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());
          require(!controller.halted());    // <--
          _;
      }
```
- on line 43

```
      returns (bool) {
          bool success = false;
          address destination = controller.destination();    // <--

          if (_token != address(0)) {
```
- on line 48

```
              Token token = Token(_token);
              uint amount = _amount;
              if (amount > token.balanceOf(this)) {    // <--
                  return false;
              }
```
- on line 52

```
              }

              success = token.transfer(destination, amount);    // <--
          }
          else {
```
- on line 64

```

          if (success) {
              controller.logSweep(this, destination, _token, _amount);    // <--
          }
          return success;
```

#### UnrestrictedEtherFlow

Show results

##### Warnings
- on line 16

```

      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());    // <--
          require(!controller.halted());
          _;
```
- on line 17

```
      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());
          require(!controller.halted());    // <--
          _;
      }
```
- on line 43

```
      returns (bool) {
          bool success = false;
          address destination = controller.destination();    // <--

          if (_token != address(0)) {
```
- on line 48

```
              Token token = Token(_token);
              uint amount = _amount;
              if (amount > token.balanceOf(this)) {    // <--
                  return false;
              }
```
- on line 52

```
              }

              success = token.transfer(destination, amount);    // <--
          }
          else {
```
- on line 64

```

          if (success) {
              controller.logSweep(this, destination, _token, _amount);    // <--
          }
          return success;
```
- on line 60

```
              }

              success = destination.send(amountInWei);    // <--
          }

```

### `my-repo-name/contracts/Sweeper.sol`

Show violations and warnings

#### LockedEther

Show results

##### Warnings
- on line 22

```
  }

  contract Token {    // <--
      function balanceOf(address a) public returns (uint) {
          (a);
```

### `my-repo-name/contracts/Sweeper.sol`

Show violations and warnings

#### LockedEther

Show results

##### Violations
- on line 70

```
  }

  contract UserWallet {    // <--
      AbstractSweeperList sweeperList;
      constructor(address _sweeperList) public {
```

#### MissingInputValidation

Show results

##### Violations
- on line 84

```
       }

      function sweep(address _token, uint _amount)    // <--
      public
      returns (bool) {
```

##### Warnings
- on line 78

```
      function () public payable { }

      function tokenFallback(address _from, uint _value, bytes _data) public {    // <--
          (_from);
          (_value);
```

#### UnhandledException

Show results

##### Warnings
- on line 88

```
      returns (bool) {
          (_amount);
          return sweeperList.sweeperOf(_token).delegatecall(msg.data);    // <--
      }
  }
```

#### UnrestrictedEtherFlow

Show results

##### Warnings
- on line 88

```
      returns (bool) {
          (_amount);
          return sweeperList.sweeperOf(_token).delegatecall(msg.data);    // <--
      }
  }
```


Thanks for adding that dude, nice work! :) That should fix the Windows 10 issue.


Puzzle `18-b493cd89` discovered in   [`src/main/java/org/llorllale/cactoos/matchers/Assertion.java`](  https://github.com/llorllale/cactoos-matchers/blob/master/src/main/java/org/llorllale/cactoos/matchers/Assertion.java)   and submitted as #52. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


Puzzle `18-a9679abd` discovered in   [`src/main/java/org/llorllale/cactoos/matchers/Assertion.java`](  https://github.com/llorllale/cactoos-matchers/blob/master/src/main/java/org/llorllale/cactoos/matchers/Assertion.java)   and submitted as #53. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


not descriptive variable name.

Suggestion: use more descriptive name gamePlanel !?


> Ups, the advantage of this mistake is that it get's now injected into every website on planet earth. ;)

Nope :rofl:


ขยับไรนักอะ


lines 31- 35 are out of alignment.

Suggestion:  make them all to the same alignment.


small type ttext -> text


Improve warning message text.
From  https://github.com/mbeijen


harmonogramu*


looks good!


Not descriptive variable name.

Suggestion: Use more intuitive variable name, width and height 1?


It does, yeah, I was kinda annoyed by this. The issue itself is very straight forward, setup.exe requires elevation, so it reads and writes HKLM, but the main game goes to virtual store unless launched as admin.
![](https://i.imgur.com/7Eif3x2.png)


multiple declaration in the same line.

Suggestion: make each declaration in a new line.


Not descriptive variable name.

Suggestion: change to more intuitive name data!?


## Summary
There were 9 violations and 47 warnings found.

Show details

### `Sweeper/contracts/Migrations.sol:Migrations`

Show violations and warnings

#### LockedEther

Show results
- on line 2

```
  pragma solidity ^0.4.23;

  contract Migrations {    // <--
    address public owner;
    uint public last_completed_migration;
```

#### MissingInputValidation

Show results

##### Violations
- on line 14

```
    }

    function setCompleted(uint completed) public restricted {    // <--
      last_completed_migration = completed;
    }
```

##### Warnings
- on line 3

```

  contract Migrations {
    address public owner;    // <--
    uint public last_completed_migration;

```
- on line 4

```
  contract Migrations {
    address public owner;
    uint public last_completed_migration;    // <--

    constructor() public {
```
- on line 18

```
    }

    function upgrade(address new_address) public restricted {    // <--
      Migrations upgraded = Migrations(new_address);
      upgraded.setCompleted(last_completed_migration);
```

#### UnhandledException

Show results

##### Warnings
- on line 20

```
    function upgrade(address new_address) public restricted {
      Migrations upgraded = Migrations(new_address);
      upgraded.setCompleted(last_completed_migration);    // <--
    }
  }
```

#### UnrestrictedEtherFlow

Show results

##### Warnings
- on line 20

```
    function upgrade(address new_address) public restricted {
      Migrations upgraded = Migrations(new_address);
      upgraded.setCompleted(last_completed_migration);    // <--
    }
  }
```

#### UnrestrictedWrite

Show results

##### Warnings
- on line 15

```

    function setCompleted(uint completed) public restricted {
      last_completed_migration = completed;    // <--
    }

```

### `Sweeper/contracts/Sweeper.sol:AbstractSweeper`

Show violations and warnings

#### LockedEther

Show results

##### Warnings
- in contract

### `Sweeper/contracts/Sweeper.sol:AbstractSweeperList`

Show violations and warnings

#### LockedEther

Show results

##### Warnings
- in contract

### `Sweeper/contracts/Sweeper.sol:Controller`

Show violations and warnings

#### LockedEther

Show results
- on line 96

```
  }

  contract Controller is AbstractSweeperList {    // <--
      address public owner;
      address public authorizedCaller;
```

#### MissingInputValidation

Show results

##### Violations
- on line 129

```
      }

      function changeAuthorizedCaller(address _newCaller) onlyOwner public {    // <--
          authorizedCaller = _newCaller;
      }
```
- on line 133

```
      }

      function changeDestination(address _dest) onlyOwner public {    // <--
          destination = _dest;
      }
```
- on line 137

```
      }

      function changeOwner(address _owner) onlyOwner public {    // <--
          owner = _owner;
      }
```
- on line 157

```
      mapping (address => address) sweepers;

      function addSweeper(address _token, address _sweeper) onlyOwner public {    // <--
          sweepers[_token] = _sweeper;
      }
```
- on line 161

```
      }

      function sweeperOf(address _token) public returns (address) {    // <--
          address sweeper = sweepers[_token];
          if (sweeper == 0) sweeper = defaultSweeper;
```
- on line 167

```
      }

      function logSweep(address from, address to, address token, uint amount) public {    // <--
          emit LogSweep(from, to, token, amount);
      }
```

##### Warnings
- on line 96

```
  }

  contract Controller is AbstractSweeperList {    // <--
      address public owner;
      address public authorizedCaller;
```
- on line 97

```

  contract Controller is AbstractSweeperList {
      address public owner;    // <--
      address public authorizedCaller;

```
- on line 98

```
  contract Controller is AbstractSweeperList {
      address public owner;
      address public authorizedCaller;    // <--

      address public destination;
```
- on line 100

```
      address public authorizedCaller;

      address public destination;    // <--

      bool public halted;
```
- on line 102

```
      address public destination;

      bool public halted;    // <--

      event LogNewWallet(address receiver);
```
- on line 141

```
      }

      function makeWallet() onlyAdmins public returns (address wallet) {    // <--
          wallet = address(new UserWallet(this));
          emit LogNewWallet(wallet);
```
- on line 146

```
      }

      function halt() onlyAdmins public {    // <--
          halted = true;
      }
```
- on line 150

```
      }

      function start() onlyOwner public {    // <--
          halted = false;
      }
```
- on line 154

```
      }

      address public defaultSweeper = address(new DefaultSweeper(this));    // <--
      mapping (address => address) sweepers;

```

#### UnrestrictedWrite

Show results
- on line 130

```

      function changeAuthorizedCaller(address _newCaller) onlyOwner public {
          authorizedCaller = _newCaller;    // <--
      }

```
- on line 134

```

      function changeDestination(address _dest) onlyOwner public {
          destination = _dest;    // <--
      }

```
- on line 138

```

      function changeOwner(address _owner) onlyOwner public {
          owner = _owner;    // <--
      }

```
- on line 147

```

      function halt() onlyAdmins public {
          halted = true;    // <--
      }

```
- on line 151

```

      function start() onlyOwner public {
          halted = false;    // <--
      }

```
- on line 158

```

      function addSweeper(address _token, address _sweeper) onlyOwner public {
          sweepers[_token] = _sweeper;    // <--
      }

```

### `Sweeper/contracts/Sweeper.sol:DefaultSweeper`

Show violations and warnings

#### DAOConstantGas

Show results

##### Warnings
- on line 60

```
              }

              success = destination.send(amountInWei);    // <--
          }

```

#### LockedEther

Show results

##### Warnings
- on line 35

```
  }

  contract DefaultSweeper is AbstractSweeper {    // <--
      constructor(address controller) AbstractSweeper(controller) public {}

```

#### MissingInputValidation

Show results

##### Warnings
- on line 38

```
      constructor(address controller) AbstractSweeper(controller) public {}

      function sweep(address _token, uint _amount)    // <--
      canSweep
      public
```

#### TODAmount

Show results

##### Warnings
- on line 60

```
              }

              success = destination.send(amountInWei);    // <--
          }

```

#### TODReceiver

Show results

##### Warnings
- on line 60

```
              }

              success = destination.send(amountInWei);    // <--
          }

```

#### UnhandledException

Show results

##### Warnings
- on line 16

```

      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());    // <--
          require(!controller.halted());
          _;
```
- on line 17

```
      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());
          require(!controller.halted());    // <--
          _;
      }
```
- on line 43

```
      returns (bool) {
          bool success = false;
          address destination = controller.destination();    // <--

          if (_token != address(0)) {
```
- on line 48

```
              Token token = Token(_token);
              uint amount = _amount;
              if (amount > token.balanceOf(this)) {    // <--
                  return false;
              }
```
- on line 52

```
              }

              success = token.transfer(destination, amount);    // <--
          }
          else {
```
- on line 64

```

          if (success) {
              controller.logSweep(this, destination, _token, _amount);    // <--
          }
          return success;
```

#### UnrestrictedEtherFlow

Show results

##### Warnings
- on line 16

```

      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());    // <--
          require(!controller.halted());
          _;
```
- on line 17

```
      modifier canSweep() {
          require(msg.sender == controller.authorizedCaller() && msg.sender == controller.owner());
          require(!controller.halted());    // <--
          _;
      }
```
- on line 43

```
      returns (bool) {
          bool success = false;
          address destination = controller.destination();    // <--

          if (_token != address(0)) {
```
- on line 48

```
              Token token = Token(_token);
              uint amount = _amount;
              if (amount > token.balanceOf(this)) {    // <--
                  return false;
              }
```
- on line 52

```
              }

              success = token.transfer(destination, amount);    // <--
          }
          else {
```
- on line 64

```

          if (success) {
              controller.logSweep(this, destination, _token, _amount);    // <--
          }
          return success;
```
- on line 60

```
              }

              success = destination.send(amountInWei);    // <--
          }

```

### `Sweeper/contracts/Sweeper.sol:Token`

Show violations and warnings

#### LockedEther

Show results

##### Warnings
- on line 22

```
  }

  contract Token {    // <--
      function balanceOf(address a) public returns (uint) {
          (a);
```

### `Sweeper/contracts/Sweeper.sol:UserWallet`

Show violations and warnings

#### LockedEther

Show results

##### Violations
- on line 70

```
  }

  contract UserWallet {    // <--
      AbstractSweeperList sweeperList;
      constructor(address _sweeperList) public {
```

#### MissingInputValidation

Show results

##### Violations
- on line 84

```
       }

      function sweep(address _token, uint _amount)    // <--
      public
      returns (bool) {
```

##### Warnings
- on line 78

```
      function () public payable { }

      function tokenFallback(address _from, uint _value, bytes _data) public {    // <--
          (_from);
          (_value);
```

#### UnhandledException

Show results

##### Warnings
- on line 88

```
      returns (bool) {
          (_amount);
          return sweeperList.sweeperOf(_token).delegatecall(msg.data);    // <--
      }
  }
```

#### UnrestrictedEtherFlow

Show results

##### Warnings
- on line 88

```
      returns (bool) {
          (_amount);
          return sweeperList.sweeperOf(_token).delegatecall(msg.data);    // <--
      }
  }
```


noice


Looks good.  Thanks.


IBM Cloud [toolchain](https://console.bluemix.net/devops/toolchains/1076a681-dc89-4362-94c9-40a76fa898b5?env_id=ibm%3Ayp%3Aus-south "lightbluecompute-devops-20181128211932333"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/e45d063e-6aa7-4875-9398-31aee8c65b1f?env_id=ibm%3Ayp%3Aus-south "lightblue-web") deployed [lightblue-web-20181128211932333](https://github.com/dthiesse/lightblue-web-20181128211932333/releases/tag/deploy-ibm-yp-us-south-cldstd01-us.ibm.com-dev-20181208-211349 "deploy-ibm-yp-us-south-cldstd01-us.ibm.com-dev-20181208-211349") to [dev](https://console.bluemix.net/apps/2656ca23-fd9c-40ba-8bc6-80e0f05ac039?env_id=ibm:yp:us-south "ibm:yp:us-south:cldstd01@us.ibm.com:dev"), including this commit


We always expect latest compilers.

Where do you see this not working? We should update the compiler; or the compiler switches as necessary.


Puzzle `16-acf734f9` discovered in   [`src/main/java/org/llorllale/cactoos/matchers/TextMatcherEnvelope.java`](  https://github.com/llorllale/cactoos-matchers/blob/master/src/main/java/org/llorllale/cactoos/matchers/TextMatcherEnvelope.java)   and submitted as #54. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


Successfully aliased the URL <https://mflow-oaf0ju7ue.now.sh> to the following aliases.

* https://www.mflow.tech
* https://mflow.tech


@DavidR86 let's be more careful when submitting code by following these guidelines:

1. Add documentation to the `.hpp` file (there is none at this point).
2. Add unit tests to the `.t..cpp` file (there are none).
3. Remove @TODO strings if you already performed the tasks (otherwise we mistakenly believe we have not done them)

How do we know this implementation is correct?


Unnecessary empty lines 186, 188.

Suggestion: remove empty lines.


@ielvisd


For any support-related questions, we ask that you send a ticket to https://affiliatewp.com/support as we reserve this repository for development purposes.