kiva-high-IR-basement-walls (nealkruis) - x86_64-Linux-Ubuntu-18.04-gcc-7.3-IntegrationCoverage-Debug: OK (2445 of 2447 tests passed, 0 test warnings)

Failures:

integration Test Summary
 * Passed: 636
 * Timeout: 2

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.92%25-yellow.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-72.21%25-green.png)


[R/check_alignment_params.R:32:20:](https://github.com/richelbilderbeek/pirouette/blob/55b74e638b4b6108572661bc73fe42688a2e5864/R/check_alignment_params.R#L32) *warning:* **no visible global function definition for ‘load_tree’**
```r
    phylogeny_2 <- load_tree(tree_model = "mbd", seed = 1)
                   ^~~~~~~~~
```
[R/select_experiments.R:14:26:](https://github.com/richelbilderbeek/pirouette/blob/55b74e638b4b6108572661bc73fe42688a2e5864/R/select_experiments.R#L14) *warning:* **no visible global function definition for ‘select_candidate_evidences’**
```r
  candidate_marg_liks <- select_candidate_evidences(experiments, marg_liks)
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~
```


kiva-high-IR-basement-walls (nealkruis) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (3 of 3 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


이것을 호출을 안해서 에러가 나고 있었음;


selam


Your YUV conversion computing  is being in the cpu now.
I think this calculation should be moved to shader for computing in gpu.(for fast processing)
This is why the vulkan is used.


Hi humans


Ping @hmert


> I didn't contribute models outside artrev mod. The only thing I really contributed were new terrain textures, afair. :)

Fixed now.


This fixes devices higher than 9, but not devices higher than 99 (0x63). Devices with PCI addresses from 0x64-0xFF have 3 digits in decimal. The 12 char limit causes the address sent to Xorg to be incomplete.


Successfully aliased the URL <https://winmine-exe-4rjn2s7k5.now.sh> to the following alias.

* https://winmine-exe.now.sh


I'm probably doing something wrong but I'm getting errors compiling the core with this commit.
I'm using Visual Studio Community 2017 - 15.5.6.
![error](https://user-images.githubusercontent.com/25745474/52619012-c66a2180-2ea0-11e9-95eb-d3cb66f6bec4.png)


@aragonc ?? Tengo otro reporte de error  en BT#15291 debido a estos cambios no se muestran los extra fields, y como indica @AngelFQC se está llamando 2 veces a TrackingCourseLog::get_user_data(), deshacer estos cambios (regresar como estaba una tabla SortableTable ) o corregirlo.

En resumen lo que me han reportado:

1. courseLog.php es mucho más lento
2. no funcionan los sorts de las columnas
3. filtro de extra fields no funcionan

@ywarnier


It's probably better to rebase it out if there's a problem with this file.


Do we have all those available functions documented at the manual? Please make sure the docs are up to date,


Following Points Addressed
* Workflow should be generated only when Indent is in Approved Status
* Workflow should be generated only when Indent has child items in tdisg003
* BaaN Tables dmisg167, dmisg168, dmisg169 should be populated
[TDS Attachment Download Functionality is also Included]


@Trystanosaurus do you have any customisations ?


Thanks for fixing this annoying issue. Does the system now also copy the survey properly if the save button gets clicked or what is the current behavior?


Adding sentence ending syllables for statement and questions


render :not_found will be better :)


这个是基于YYText 通过控制光标位置实现的基础功能。具体项目可能需求不一样，仅供参考。


I'll send a PR to fix it.


Successfully aliased the URL <https://iouome-plro4f8f1.now.sh> to the following alias.

* https://www.iouo.me


I was wondering how difficult would it be to make the Browser (display) the answers? For example, if you were to hover over a question it would be like that is red (apple). My other question I'm kind of new to the C# scene, so could you give me some pointers with to begin with this. Because I wouldn't mind helping perfect it. But, I'm kind of lost in the ocean without guidance or direction atm. So, it's difficult to know where to begin.


```get /api/tags/:id/todos``` will be a better url than ```get /api/tags/:id/find_to_dos ``` since verb in url is not a good practice, url represent resource


It is (js-)wired to the currently active form. So it will trigger create, import, or copy depending on the active tab.


No customisations, I'm using the VAS Autobalance and Individual XP mods though.


- [ ] Imported the sleep() function from the time module to pause the game.

- [ ] Created a new function called ship_hit() that coordinates the response when the ship is hit by an alien.

- [ ]  Inside ship_hit(), the number of ships left is reduced by 1.

- [ ] The existing alien and bullet groups on the screen are emptied.

- [ ] The game is paused after the updates have been made so that the player can see that their ship has been hit.

- [ ] Updated the function definition of update_aliens() to include the parameters stats, screen, and bullets.


Successfully aliased the URL <https://zeit-vue-i4yvimi0q.now.sh> to the following alias.

* https://zeit-vue.now.sh


Since Mountain Lion (released in July 2012) Mac OSX is a full 64-bit system
and the option to start a computer in 32-bit mode is no longer available.


Попробуйте собрать со строкой
log_message(LOG, _("language dir %s"), p->handle->languages[i].dir)
перед строкой
if (p->handle->languages[i].dir != NULL)

Интересно, чтоже такое у вас в p->handle->languages[i].dir, если все время падает...


Successfully aliased the URL <https://pegjs-next-website-2ue16h4um.now.sh> to the following alias.

* https://next.pegjs.org


float /= getWidth()


thank you so much for your support , I am really glad for your always
response and help.
hope one day we can meet and do some work together her in china.
thanks again.
your truly
Zaid Yemeni

On Mon, Feb 4, 2019 at 4:56 AM larchuto <notifications@github.com> wrote:

> Hi,
> Sorry for my late reply.
>
> The model I used is a Thevenin model which is a really simplistic model.
> It comprise a voltage generator in series with a resistor and a
> capacitor//resistor pair in parallel. The voltage generator is here to
> simulate the open circuit voltage (OCV) and the resistors and capacitor are
> here to describe the non ideal behavior of the battery (internal
> resistance, capacitance due to electrode geometry and morphology,
> charge-transfer resistance, double-layer capacitance, etc).
>
> Short writing for the model : OCV + R0 + R1//C1, where OCV stands for
> "open circuit voltage", Rx for resistor x, Cx for capacitor x, + for "in
> series" and // for "in parallel". (a picture is worth thousand words :
> https://www.researchgate.net/publication/258382505/figure/fig3/AS:320549646553113@1453436399923/Thevenin-equivalent-circuit-of-battery-model.png
> )
>
> There is no real data set involved here as the battery is simulated using
> this model. The Kalman filter then tries to guess the state of charge (SoC)
> using the current and voltage measured on the simulated battery. The
> measures are simulated by adding some noise to the "real" current and
> voltage of the simulated setup.
>
> You may want to look into the literature for how to choose your model
> values for real batteries. For the record here are some resources I found
> on my computer:
>
> [1] Fengchun Sun, Rui Xiong, Hongwen He, "Estimation of state-of-charge
> and state-of-power capability of lithium-ion battery considering varying
> health conditions", Journal of Power Sources, vol. 259, 2014, Pages
> 166-176, ISSN 0378-7753,
> http://www.sciencedirect.com/science/article/pii/S0378775314002882
> [2] M. Mastali, J. Vazquez-Arenas, R. Fraser, M. Fowler, S. Afshar, M.
> Stevens, "Battery state of the charge estimation using Kalman filtering",
> Journal of Power Sources, vol. 239, 2013, Pages 294-307, ISSN 0378-7753,
> http://www.sciencedirect.com/science/article/pii/S0378775313005259
> [3] Quanqing Yu, Rui Xiong, Cheng Lin, "Online Estimation of
> State-of-charge Based on the H infinity and Unscented Kalman Filters for
> Lithium Ion Batteries", Energy Procedia, vol. 105, 2017, Pages 2791-2796,
> ISSN 1876-6102,
> http://www.sciencedirect.com/science/article/pii/S1876610217306525
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/larchuto/Battery-Kalman/commit/21ea684e1262c02144c37321ec4d7f2d4b8ba1e9#commitcomment-32175182>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/Ar8f-bg6flUv1cRFKk8TI8Ww3othJ7T5ks5vJ00FgaJpZM4ZmaGi>
> .
>


Tour barcelona


Egypt.setAgencyAddress


wen can we haz google?


private int hotelRating;


Successfully aliased the URL <https://wpcool-hnwhispwir.now.sh> to the following alias.

* https://wpcool.now.sh


do not initialize class with default values


cordova plugin add com.sample.phonecalltrap is not working


stratified_tank_refactor (nmerket) - Win64-Windows-7-VisualStudio-14: OK (3069 of 3077 tests passed, 0 test warnings)

Failures:

regression Test Summary
 * Passed: 625
 * Failed: 8

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.74%25-yellow.png)


Correct, thanks. Changed to a `typeof option.min ==='number' && typeof option.max==='number'`.


ACH INSTANT DEPOSIT


multiple_hvac_fractions (nmerket) - x86_64-Linux-Ubuntu-18.04-gcc-7.3: OK (3107 of 3117 tests passed, 2 test warnings)

Messages:

 * 3 tests had: EIO diffs.
 * 3 tests had: ESO small diffs.
 * 1 test had: MTR small diffs.
 * 1 test had: Table big diffs.
 * 2 tests had: Table small diffs.

Failures:

integration Test Summary
 * Passed: 629
 * Failed: 9

regression Test Summary
 * Passed: 652
 * Failed: 1

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.68%25-yellow.png)


Fixes #9


I'd suggest that you rephrase your commit messages a bit to make them shorter, more descriptive and make the testing environment happy. (```git commit --amend``` and then ```git push --force```)

```
bluez: Move utils with large footprint to separate package

Move non-crucial utilities that depends on glib2, ncurses
and readline to separate package in order to reduce
footprint on devices with limited storage.
```

Have you tried this on a clean buildroot?
My guess is that it'll fail because glib and other libs wont necessarily be available depending on which (other) package(s) you select for compilation as bluez will still try to build all utils but the test-build will tell.

I think you'll need something like this but lets try without first.
```PKG_BUILD_DEPENDS:=glib libncursesw libreadline```


From the already-linked to https://www.gnu.org/software/gnu-c-manual/gnu-c-manual.html#Bit-Shifting :
> Bits shifted off the left side of the value are discarded; new bits added on the right side will all be 0.

According to this, `128<<30` is `0`, and this is not bigger than what a 32-bit signed integer can represent. So no overflow.

> sometimes we assume GNU C semantics

Sometimes assuming one semantics and at other some other sounds like the worst idea.
When in doubt, I will always resort to GNU C semantics as long as the SV-COMP rules contain that sentence. But I also think that a commit that is over 2 years old is not the best place to constructively discuss something like this.


I think in script option (scanner/compiler). If not set - `en-GB` selected.


Agreed.


Привет , у тебя телеграмм есть ?


multiple_hvac_fractions (nmerket) - x86_64-Linux-Ubuntu-18.04-cppcheck-1.82: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


replace public with private


getNameTrees()


return nameTrees;


private String name


That class is not generated, its just a partial class with some custom code in it that would help us get the value of the check boxes instead of the INT values, I have tested them and it works with `Dll` and `PureLive` modes.

We might not need it after all, I see that you pushed a change to the radio buttons, will update the SK and get rid of that Home class.


They were added in commit 88280a595e3025df3e6ff61d252984fb0bfc8fa2, but is not used anymore.


ticketPrize


this.address = address;
	        this.lenght = lenght;
	        this.ticket_prize = ticket_prize;
	        this.name_park = name_park;


Not working for same


[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-10-lfevents-test.pantheonsite.io/)

Created multidev environment [pr-10](https://dashboard.pantheon.io/sites/9b2ca821-4493-42f3-96ee-344c56803739#pr-10) for lfevents-test.


Successfully aliased the URL <https://winmine-exe-1zccb6q0j.now.sh> to the following alias.

* https://winmine-exe.now.sh


Not working


this(address, lenght, ticket_prize, name_trees, null, null, null, null);


Successfully aliased the URL <https://zeit-vue-m35xct3xv.now.sh> to the following alias.

* https://zeit-vue.now.sh


Hi, **Sorrow446**. Thx for Qobuz-DL.
I found one problem. When the album has a faulty cover or album cover simply does not exist, the Qobuz-DL cannot download.
Example:
Album link: https://play.qobuz.com/album/0825646498369
Qobuz-DL  return:
> Traceback (most recent call last):
>   File "Qobuz-DL.py", line 268, in <module>
>   File "urllib\request.py", line 248, in urlretrieve
>   File "urllib\request.py", line 223, in urlopen
>   File "urllib\request.py", line 532, in open
>   File "urllib\request.py", line 642, in http_response
>   File "urllib\request.py", line 570, in error
>   File "urllib\request.py", line 504, in _call_chain
>   File "urllib\request.py", line 650, in http_error_default
> urllib.error.HTTPError: HTTP Error 404: Not Found
> [8884] Failed to execute script Qobuz-DL

Can you fix it in second release.?
Thank you.


I think it should be tree rather than mrl


[Your benchmark job](https://github.com/JuliaLang/julia/commit/236c69b1a53acf4057de830979138765c79aa596#commitcomment-32279218) has completed - possible performance regressions were detected. A full report can be found [here](https://github.com/JuliaCI/BaseBenchmarkReports/blob/5a70ef92cb3fb59eac4b7966f86b6aed9b1ba6df/daily_2019_02_12/report.md). cc @ararslan


The char '<3' make syntax checker confused.


m_ml already sets during setContext


Successfully aliased the URL <https://jameswlanecom-guq7lmisf.now.sh> to the following aliases.

* https://jameswlane.com
* https://www.jameswlane.com


If you have time please take a look at https://openvision.tech/viewtopic.php?f=5&t=128 and add the support 👍


[R/alignment_params_to_posterior_trees.R:32:19:](https://github.com/richelbilderbeek/pirouette/blob/9b8cc6adff2838fc8e2f559fc924b3e4eafb8cbe/R/alignment_params_to_posterior_trees.R#L32) *warning:* **no visible global function definition for ‘is_nested_sampling_mcmc’**
```r
  testit::assert(!is_nested_sampling_mcmc(mcmc))
                  ^~~~~~~~~~~~~~~~~~~~~~~
```
[R/phylo_to_errors.R:27:19:](https://github.com/richelbilderbeek/pirouette/blob/9b8cc6adff2838fc8e2f559fc924b3e4eafb8cbe/R/phylo_to_errors.R#L27) *warning:* **no visible global function definition for ‘is_nested_sampling_mcmc’**
```r
  testit::assert(!is_nested_sampling_mcmc(mcmc))
                  ^~~~~~~~~~~~~~~~~~~~~~~
```
[R/select_experiments.R:14:26:](https://github.com/richelbilderbeek/pirouette/blob/9b8cc6adff2838fc8e2f559fc924b3e4eafb8cbe/R/select_experiments.R#L14) *warning:* **no visible global function definition for ‘select_candidate_evidences’**
```r
  candidate_marg_liks <- select_candidate_evidences(experiments, marg_liks)
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~
```


nb


hp


Printer acer = new Printer("Acer", 15, 5000, "B2019", 2.8, "Black and white", 1000);


 this.name = name;
	            this.numberOfPagesPerMinute = numberOfPagesPerMinute;
	            this.price = price;
	            this.model = model;
	            this.weight = weight;


this(name, numberOfPagesPerMinute, price, model, weight, null, 0.....);


Sehrish, I took a glimpse at your code and I think this part is screaming for the much nicer `dplyr::case_when` which was made for these occasions. It will save you the vector pre-allocation and the `sapply`, meaning you'll just need a single `mutate` - see https://dplyr.tidyverse.org/reference/case_when.html for some examples e.g.

```
starwars %>%
  select(name:mass, gender, species) %>%
  mutate(
    type = case_when(
      height > 200 | mass > 200 ~ "large",
      species == "Droid"        ~ "robot",
      TRUE                      ~ "other"
    )
  )
```

It's a relatively not well known function, so just leaving my $0.02.


Simplest solution:
```
shop.customers
        .groupBy {
            it.city
        }.maxBy {
            it.value.size
        }?.key
```


Puzzle `194-794de429` disappeared from [`test/FakeOptions.h`](https://github.com/DronMDF/zond/blob/master/test/FakeOptions.h), that's why I closed #234. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.


Puzzle `230-28468740` disappeared from [`test/ZoldProtocolEntryTest.cpp`](https://github.com/DronMDF/zond/blob/master/test/ZoldProtocolEntryTest.cpp), that's why I closed #236. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.


Simple solution:
```
shop.customers?.maxBy { it.orders.size }
```


This would be pretty understandable.
![gra](https://user-images.githubusercontent.com/26228275/52620952-0c88aa80-2ecc-11e9-8917-e7fc438e3536.png)


Deployment failed with the following error:

~~~
If you agree with that, please run again with `--public`.
~~~


remove inheritance


fix intendation


It's great to see more Web API bindings added, thanks!.  WebSockets is going to be very handy.


[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-11-lfevents-test.pantheonsite.io/)

Created multidev environment [pr-11](https://dashboard.pantheon.io/sites/9b2ca821-4493-42f3-96ee-344c56803739#pr-11) for lfevents-test.


languague => language


It is better to define static variables for passing as keys to methods
```
companion object {
    const val KEY_COLOR = "key_color"
    ...
}
```


@Kociamber hi there, could you please release a new version with this change?


try


Should onOpen take a EventListener<Event>?  MDN says it takes a regular Event, like onError:

https://developer.mozilla.org/en-US/docs/Web/API/WebSocket/onopen


Evaluation of volunteer transcription systems applied at Natural history collection, realized in 2018 within frame of the project ICEDIG.


Hahahah ist das Geilus!!


There is no need to create a new instance of `HomeworkMain` as it is already in our task.


To avoid future regression, you should use a constant `SECTION_LEGAL_CONTENTS = '6'` and use SECTION_LEGAL_CONTENTS everywhere you use `6`. Same for all section ids.


Not sure why the `as.data.frame` is needed here either (maybe the bed file is awkward?). Another tip: use `readr::read_tsv` (https://readr.tidyverse.org/reference/read_delim.html). Same goes with the `quantized_bed` a bit further down.


![](https://github.trello.services/images/mini-trello-icon.png) [Hello2](https://trello.com/c/4pWIugXa/9-hello2)


tidyverse way:

```
no_coverage <- quantized_bed %>% filter(Callability == "0")
```


Да. Метод нужно вынести в родительский класс, в классе пассажирского вагона переопределить.
```
# Carriage
def load(volume)
  raise self::NO_VOLUME if volume > @free_volume
  @free_volume -= volume
  @occupied_volume += 1
end

# PassengerCarriage
def load(_volume = 1)
  super(1)
end
```


Indeed


You can do it easily with the kotlin way! 😈
```
shop.customers
        .groupBy {
            it.city
        }.maxBy {
            it.value.size
        }?.key
```


You just changed the type to guint, so this cannot be negative.


Hello @kdanilyuk
I would recommend you to follow style guide from very beginning of your programming journey
Here's a link: https://github.com/raywenderlich/c-sharp-style-guide#brace-style
You can surf the Internet to find out another sources

Good luck


Teufel in Menschengestalt!


what does the `only` prop do?


I don't recall changing this (I'll check once in the office since I have the pre-squash commits there), so I hope it's not a merge/rebase-induced problem.
That being said, you are correct


Good!


Or even, [cut](https://www.rdocumentation.org/packages/base/versions/3.5.2/topics/cut)


Teufel in Menschengestalt


> the expected deprecation level at usage of `K1.foo` is error, but actually it'll be warning, as a minimum of warning and error
I don't think sure that it's expected to be an error:
1. It would be a breaking change since before this commit it was a warning
2. I'm concerned that converting `J` to kotlin makes the resulting level to be a warning


Also, in case you need something else patched in future, you can set your Grant fork as dependency directly in your project, and use the [alternative require](https://github.com/simov/grant#alternative-require). This will save you the creation of the additional `grant-koa` project.


Yup, you're right.  Thanks for catching that! Fixed in 010937


Unwanted execution of `IQueryable.Count()`. Better to use IList.Count.

> baseSource.Count()


Restored code that was changed on 545a2c5b89772e4a7cacd3c03a1d70c7c14b2399 commit.


Блок не используется. Явно передавать в качестве параметра нет необходимости.
Лучше назвать `each_train`


См https://github.com/Hatatych/tn-lessons/commit/0a8a4ac135bdc47b144dd542d5011353c34d7a07#r32281118


yes, we need both, constantinople and petersburg


should be declared on some interface, ref https://github.com/nette/application/pull/40


.then() is not a function error encountered in auth.js while using the route => api/auth/register in the line 30.
encountered while testing the route using postman.


You should not modify the `Order` data class and any functions!


should allow for multiple values, i.e. `$res[$name][] = $meta[self::VALUE]`


How did you do?


ok


See comments and video description


Lisensen må følge Nordic sin Zephyr-standard sånn som i at_utils.h


Thankyou sir,
It was an honor hearing from you

On Tue, Feb 12, 2019 at 7:55 AM David Rounce <notifications@github.com>
wrote:

> See responses below:
>
>    1.
>
>    Most of the codes can be run independently (Avalanches...,
>    Landslides..., SLA...), and then you can run the Hazard Assessment script.
>    That said, the input for each file should be clearly specified near the top
>    of each script, so go through each script carefully to ensure you have all
>    the required input.
>    2.
>
>    You can get avalanche trajectories from running the Avalanche...
>    script.
>    3.
>
>    There were 6 different Landsat scenes that covered the glacial lakes
>    in Nepal. It would have been much better if I automated these methods for a
>    given Landsat script, but instead I wrote them out for each Landsat scene.
>    If you are running this in a new area, you can just use one as a guide; for
>    example, for scripts where there is N1 - N6 just look at N1.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/drounce/GlacialLakeHazards/commit/612c84748901352c33e4cb99e0c2cbd9d6268597#commitcomment-32278098>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AsnI0VlDciv7gwyLdWC0lbId0P28zqFJks5vMiYYgaJpZM4ae5vO>
> .
>


Successfully aliased the URL <https://zeit-vue-qx7sxrzr5.now.sh> to the following alias.

* https://zeit-vue.now.sh


make fields private


this(null, null, 0, 0);


protected int alarmCode;


public static int farmAmount;


public String location;


Guard can be added here, same for other header files
```#ifndef AT_CMD_PARSE_H_
#define AT_CMD_PARSE_H_
...
#endif /* AT_CMD_PARSE_H_ */
```


String -> string ?


If you want to merge stuff, use the `_join` functions from `dplyr` - most often I use `left_join`:
https://dplyr.tidyverse.org/reference/join.html
And I wouldn't rely on doing anything with row names - if you want to convert them to a column, you can use `tibble::rownames_to_column`: https://tibble.tidyverse.org/reference/rownames.html

I hope you've noticed by now that I'm pushing you towards the tidyverse :-)


I'm very disappointed by this change.
Why you can not wait calling `driver.Rows.Close()` until application calls `sql.Rows.Close()` or `sql.Rows.Next()`?
For MySQL, cancelling query is heavy task and it is not implemented yet.  There are no merit about hurry calling `driver.Rows.Close()` even if it is implemented.

And we (go-sql-driver/mysql) didn't notice this change until Dec 2018.


`p_` prefixes need to go, as they're not allowed in Zephyr.


@simov Thanks for this too! Between today and tomorrow I will have time to read more documentation and do things right!


they -> there ?


parameter -> parameters


one line solution:
```
shop.customers?.maxBy { it.orders.size }
```


String -> string?


12 Şubat


solution the kotlin way:
```
shop.customers
        .groupBy {
            it.city
        }.maxBy {
            it.value.size
        }?.key
```


C++14 only


Header guard


For the release date on the create new movie, I am getting a 0001/01/01 (I am formatting this according to yyyy/MM/dd). Is there any way to display the textbox as blank if the releasedate == DateTime.MinValue()?


Function name can be removed from description


heat-emission (XuanLuoLBL) - i386-Windows-7-VisualStudio-14: OK (3080 of 3080 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


- Format should be `sort` instead of `list` in UserGuide.adoc
- Maybe can add a JUnit test for SortCommand?


是的  写错了   已更正 https://github.com/KylinDC/JavaOOP/commit/0c8865e8f62a61d7ef7fb4881716723dc5ab63b2


sad but true... I guess we'll copy the vector or add a small context


Functions are not namespaced by prefix in this header file. Perhaps something like `at_params_*`


You should actually rename it to `preferences` so it matches the component name.


As far as I can tell that is no true.
With _repoquery -q_ option seems to not have any effect:

```
# repoquery --qf "%{name} %{version} %{release} %{arch} %{sourcerpm}\n" bash
bash 4.2.46 31.el7 x86_64 bash-4.2.46-31.el7.src.rpm
```
```
# repoquery --qf "%{name} %{version} %{release} %{arch} %{sourcerpm}\n" -q bash
bash 4.2.46 31.el7 x86_64 bash-4.2.46-31.el7.src.rpm
```
And with _dnf repoquery_ it acts as (undocumented) quiet option:
```
# dnf repoquery --qf "%{name} %{version} %{release} %{arch} %{sourcerpm}\n" bash
Last metadata expiration check: 0:00:52 ago on Tue 12 Feb 2019 03:27:45 AM EST.
bash 4.4.23 7.fc30 x86_64 bash-4.4.23-7.fc30.src.rpm
```
```
# dnf repoquery --qf "%{name} %{version} %{release} %{arch} %{sourcerpm}\n" -q bash
bash 4.4.23 6.fc30 x86_64 bash-4.4.23-6.fc30.src.rpm
```
In which case it would be actually appropriate to use _-q_ because _dnf repoquery_ may produce some output to _stdout_ that is not meant to be there on RHEL8 (the 'Last metadata expiration check....' is printed to stderr).


Function name can be removed


Puzzle `27-38242c64` disappeared from [`timeless/restaurants/models.py`](https://github.com/timelesslounge/timelessis/blob/master/timeless/restaurants/models.py), that's why I closed #172. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.


Newline after license


@edoerner could you please have a look at this commit? We had some funny behavior with events being scored outside of the beam.

![image](https://user-images.githubusercontent.com/10157181/52622640-9de72500-2eaa-11e9-8ad0-51e8cafc0d92.png)


Are all these includes needed?


Nice! Great job. Now its time for us to build something awesome.


I think MIN and MAX are builtin zephyr macros


Can these variables have more descriptive names?


Cast not necessary, as they're the same type


hum, yes it was already there


Good catch. We have two initialization paths here: `init(_ value: Any)` and `init(nilLiteral: ())` required by `ExpressibleByNilLiteral`. So I think the two basic tests already present are good enough, since all the other options would simply fall into one of those initializers already tested?


multiple_hvac_fractions (nmerket) - x86_64-Linux-Ubuntu-18.04-gcc-7.3-UnitTestsCoverage-Debug: OK (1809 of 1809 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-41.58%25-green.png)


One of reasons is that I believed no one use this option :D

Nevertheless, the original purpose of this feature was to use the timestamp in the header instead of the time in the rosbag, since the former is the time of the sender, while the latter is the time of the received (robag recorder).

Is this your use case or is another one?


- Betöltőkép felmozgás és fillafter-es megtartás
- Szöveg bounce és formázott szöveg (SpannableString)


The amount of users is [not overwhelming yet](https://github.com/search?q=Doxyfile+filename%3ADoxyfile+language%3AR&type=Code) :smile:


Deployment failed with the following error:

~~~
The property `type` is not allowed in now.json when using Now 2.0 – please remove it.
~~~


Имеете в виду так? https://github.com/orevenat/BlackJack/commit/85aab089393b8d32878419355de331c0d9d5a327


ok


It's in mainline QEMU now.


do u really need a whole package to use only an icon?


@andreashorn Ah, the debug plots. Yeah sure, will disable them later (today hopefully).


maybe --resume is better, since we resume not only weights but also other variables such as lr and lr count


to use an `i` tag is complicated because it has semantic value, I guess in this case you could replace by a `span`


Возможны след случаи:
1 Если у игрока и дилера больше 21, то ничья
2 Иначе если у игрока и дилера равное количество очков, то ничья
3 Иначе если у игрока больше 21, то победил дилер
4 Иначе если у дилера больше 21, то победил игрок
5 Иначе победил тот у кого больше очков

У тебя вроде все правильно, просто забыл комментарий убрать


I will try to double check at the weekend.


deleteing


The `else if` should be on the same line as the closing `}`


plusieurs problèmes en réalité ici:
 - le type de retour. a priori mieux veut renvoyerDictionary<TKey, List<TValue>>
 - les IEqualityComparer. On peut imaginer qu'un dico soit case-insensitive et l'autre non, auquel cas il faut trancher pour le dico en retour, car ça n'aurait pas la même tête
 - les cast firstdico et seconddico. a priori inutiles.
 - nullrefex

En fait, ici il serait sans doute préférable de parcourir les dicos  dans 2 foreach et d'ajouter leurs clés dans un nouveau dico résultat, et de permettre de choisir le equalitycomparer, avec sinon un choix clair sur le par défaut


here is ok


I wasn't able to retrieve PDD puzzles from the code base and submit them to GitHub. If you think that it's a bug on our side, please submit it to [yegor256/0pdd](https://github.com/yegor256/0pdd/issues):

> set -x && set -e && set -o pipefail && cd /tmp/0pdd20190211-4-162a3fc/miroque/fast-cook && pdd -v -f /tmp/20190212-18203-1wwzww4 [1]: bash: warning: setlocale: LC_ALL: cannot change locale (UTF-8) + set -e + set -o pipefail + cd /tmp/0pdd20190211-4-162a3fc/miroque/fast-cook + pdd -v -f...

Please, copy and paste this stack trace to GitHub:

```
UserError
set -x && set -e && set -o pipefail && cd /tmp/0pdd20190211-4-162a3fc/miroque/fast-cook && pdd -v -f /tmp/20190212-18203-1wwzww4 [1]:
bash: warning: setlocale: LC_ALL: cannot change locale (UTF-8)
+ set -e
+ set -o pipefail
+ cd /tmp/0pdd20190211-4-162a3fc/miroque/fast-cook
+ pdd -v -f /tmp/20190212-18203-1wwzww4

My version is 0.20.4
Ruby version is 2.6.0 at x86_64-linux
Reading /tmp/0pdd20190211-4-162a3fc/miroque/fast-cook
11 file(s) found, 56 excluded
Reading src/main/java/ru/miroque/fastcook/domains/Recipe.java...
Reading src/main/java/ru/miroque/fastcook/domains/CookStep.java...
Reading src/main/java/ru/miroque/fastcook/domains/Cook.java...
Reading src/main/java/ru/miroque/fastcook/domains/Dish.java...
Reading src/main/java/ru/miroque/fastcook/domains/Menu.java...
Reading src/main/java/ru/miroque/fastcook/domains/Order.java...
Reading src/main/java/ru/miroque/fastcook/services/ServiceMenu.java...
ERROR: src/main/java/ru/miroque/fastcook/services/ServiceMenu.java; puzzle at line #21; @todo must have a leading space to become a puzzle, as this page explains: https://github.com/yegor256/pdd#how-to-format
If you can't understand the cause of this issue or you don't know how to fix it, please submit a GitHub issue, we will try to help you: https://github.com/yegor256/pdd/issues. This tool is still in its beta version and we will appreciate your feedback. Here is where you can find more documentation: https://github.com/yegor256/pdd/blob/master/README.md.
Exit code is 1

/app/objects/git_repo.rb:66:in `rescue in block in xml'
/app/objects/git_repo.rb:63:in `block in xml'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/tempfile.rb:295:in `open'
/app/objects/git_repo.rb:62:in `xml'
/app/objects/puzzles.rb:36:in `deploy'
/app/objects/job.rb:38:in `proceed'
/app/objects/job_starred.rb:33:in `proceed'
/app/objects/job_recorded.rb:32:in `proceed'
/app/objects/job_emailed.rb:35:in `proceed'
/app/objects/job_commiterrors.rb:36:in `proceed'
/app/objects/job_detached.rb:48:in `exclusive'
/app/objects/job_detached.rb:36:in `block in proceed'
/app/objects/job_detached.rb:36:in `fork'
/app/objects/job_detached.rb:36:in `proceed'
/app/0pdd.rb:354:in `block in <top (required)>'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1635:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1635:in `block in compile!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:992:in `block (3 levels) in route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1011:in `route_eval'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:992:in `block (2 levels) in route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1040:in `block in process_route'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1038:in `catch'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1038:in `process_route'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:990:in `block in route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:989:in `each'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:989:in `route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1097:in `block in dispatch!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `block in invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `catch'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1094:in `dispatch!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:924:in `block in call!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `block in invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `catch'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:924:in `call!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:913:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/xss_header.rb:18:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/path_traversal.rb:16:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/json_csrf.rb:26:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/base.rb:50:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/base.rb:50:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/frame_options.rb:31:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/logger.rb:15:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/common_logger.rb:33:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:231:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:224:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/head.rb:12:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/method_override.rb:22:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:194:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1957:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1502:in `block in call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1729:in `synchronize'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1502:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/handler/webrick.rb:86:in `service'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/webrick/httpserver.rb:140:in `service'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/webrick/httpserver.rb:96:in `run'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/webrick/server.rb:307:in `block in start_thread'
```


here as you are representing a header you could use `header` tag


Successfully aliased the URL <https://metris-j24wwd8xg.now.sh> to the following alias.

* https://metris-frontend.now.sh


啥时候6.6


and here use `footer` tag


Can do `UINT32_MAX - 1` here to make it more readable


default constructor should not initialize values


add pubic visibility modifier


@AmjadAlmu
repository owner should do this
but you can use this :
pod 'StepIndicator', :git => 'https://github.com/MarsXan/StepIndicator'


please ferormat code


Okay, you know what ? We'll leave it here! Let's trust shfmt.


Is cast needed here?


here in placeholder attribute you've used letters in uppercase, I think is not a good idea because for screen readers it'll be read as each letter separately, you could apply uppercase on css.


`if (negative)` is sufficient


why use first letter capitalised here?


this(manufacturerName, memoryCapacity, zoom, numberLens, null, null, null....)


Puzzle `47-f3931a04` disappeared from [`scripts/backup/pg_backup.sh`](https://github.com/timelesslounge/timelessis/blob/master/scripts/backup/pg_backup.sh), that's why I closed #115. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.


Puzzle `115-f221d667` discovered in   [`scripts/backup/pg_restore.sh`](  https://github.com/timelesslounge/timelessis/blob/master/scripts/backup/pg_restore.sh)   and submitted as #224. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


ìndex` can be of type `size_t` to ensure it's large enough to hold any possible index


why use first letter capitalized here?


is this file you could use an `IIFE` and avoid some hacker user 🤪to play around with your code


Declarations should be on top of block


Could the conditions be formatted differently? Quite hard to read


why not use README.md?


Successfully aliased the URL <https://metris-ex8vgsiu1.now.sh> to the following alias.

* https://metris-frontend.now.sh


why not use a `const`?


bon dia, no funciona aquesta ruta. Estic intentación afegir la dependència maven l'ws de portafib.


Is the return here needed? Looks the same as the one below


here you could had used an `IIFE` too


Return in? Also other functions


i think this should be after line 84 when you try import gevent


Negative error codes can't be returned from a `u32_t` function, so I'd change the function's return value to `int`


Would use `size_t` for index


Yes, I'll fix it. This is still in progress, just wanted to get some feedback from Kira.


Seems there are an issue.

1. Menu / Create Survey
2. Tab : copy survey
3. Click on Save : invalid , Save become disable
4. Select a survey, enter something (form is valid)
5. Save still disable

We **must** remove this disabling button part


sorry about that! my node installation was messed up, I didn't see that


This declaration should be on top of scope block


`u8_t` -> `size_t`


Contacta amb otae @ fundaciobit.org


Newline


Puzzle `2-5bc1e27e` discovered in   [`src/main/java/ru/miroque/fastcook/services/ServiceMenu.java`](  https://github.com/miroque/fast-cook/blob/master/src/main/java/ru/miroque/fastcook/services/ServiceMenu.java)   and submitted as #6. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


if we use our own KRATOSprint, we can switch from logger to standard print easily. Why didn't you put this in PR #4084?


Hi is there a pre-requisite for passgen.py file? because i cannot run/open this file.
Passlst is not generated as well. Can you provide commands step by step?


git rm MySQL.pdf


I have made a fix, vectors should be restricted to the original frame area.


@moallemi cool 👍🏻


params -> parameters ?


pics does not work still


getters -> getter, setters -> setter


Inlcude guard


Successfully aliased the URL <https://metris-k5sgjsnny.now.sh> to the following alias.

* https://metris-frontend.now.sh


The raw performance characteristics of Git are very strong when compared to many alternatives. Committing new changes, branching, merging and comparing past versions are all optimized for performance. The algorithms implemented inside Git take advantage of deep knowledge about common attributes of real source code file trees, how they are usually modified over time and what the access patterns are.


are -> is


"to its default value" or something. ANyway, this will be reviewd by tech writers in the end, so no big deal.


Successfully aliased the URL <https://week-notes-ez1tlasj4.now.sh> to the following alias.

* https://notes.jonheslop.com


COnsider `size_t` for the index


Newline


При таком подходе нельзя создать карту без колоды. Слишко сильная связность.
Можно было бы вынести нахождение ценности карты в `extract_card`, т.е инкапсулировать эту логику в колоде. Но сейчас лучше сосредоточиться на правильном проектировании, чем на оптимизации


versions are not compared properly... `'8.10.0' >= '10.0.0'` returns `true`
will need a different approach?


Remove newline


Also redundant whitespace in other places in this file


Breaks production as in "it won't deploy to production now but probably in a few days when they pull the PR and we try deploying again"? Yeah, that sounds fine :)


Puzzle `25-09421710` disappeared from [`customers/models.py`](https://github.com/timelesslounge/timelessis/blob/master/customers/models.py), that's why I closed #102. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.


Puzzle `102-39a9b3fe` discovered in   [`timeless/customers/models.py`](  https://github.com/timelesslounge/timelessis/blob/master/timeless/customers/models.py)   and submitted as #225. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


Unnecessary to set it explicitly to 0, but no harm in it either


Not sure if the API has changed at all but I only got this working with `.doSignInUserWithEmailAndPassword(email, password)` instead of `.doSignInWithEmailAndPassword(email, password)`. Missing the `...User...` part of the method. Hopefully, this may help others.


Consider checking if NULL pointer. Possible this happens elsewhere, haven't checked


用户态和内核的命令字匹配不上。是因为新接口少了一个参数


Muy bien visto que sobraba @sergioreina2002 👍


Длинная строка. Сделай это в отдельном методе, например
```
def initialize
  @all_cards = create_deck
end

private

def create_deck
  ...
end
```


![1c6d2bb61047cf3cd7a77b49e78ef7a4_fitted_740x700_output copy](https://user-images.githubusercontent.com/47556616/52624729-700cdb00-2ec0-11e9-890c-67a13ba8b3e8.png)


Puzzle `1-50a0c233` discovered in   [`src/main/java/ru/miroque/fastcook/services/ServiceDish.java`](  https://github.com/miroque/fast-cook/blob/master/src/main/java/ru/miroque/fastcook/services/ServiceDish.java)   and submitted as #7. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


Puzzle `1-9f187a44` discovered in   [`src/main/java/ru/miroque/fastcook/services/ServiceDish.java`](  https://github.com/miroque/fast-cook/blob/master/src/main/java/ru/miroque/fastcook/services/ServiceDish.java)   and submitted as #8. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


Please upload the ipynb notebook version of this git


Slightly confusing name on this function. Sounds like the whole parameter thing is freed, but then used on the next lines anyway. It makes perfect sense when knowing what it does, but had to check inside the function to ensure we're not working on freed memory


Hey wie lade ich denn Arduino Code Runter


I know plenty of senior non CSS specialists that can be messier than juniors 😅


Successfully aliased the URL <https://shiva-v3-ol2z9pvt0.now.sh> to the following alias.

* https://shiva-v3.now.sh


Is it possible this is causing the failures on travis?


Overall this looks really good. Loads of nitpicking on coding style and naming conventions, but much of that can be safely ignored.
We need to consider merging the parser and params thing, as it looks slightly weird to have them as two separate, independent libraries.


DeepCode analyzed this commit.
There is 1 new warning.1 warning was fixed.

[Click](https://www.deepcode.ai/app/gh/nuxeo/nuxeo-drive/806da660de3d222de78867a4bbaf1b0292d4d10d/nuxeo/nuxeo-drive/5b11f5558da41669a642283d9c6161b9853a1406/_/%2F/code/) to see more details.


DeepCode analyzed this commit.
There is 1 new warning.

[Click](https://www.deepcode.ai/app/gh/nuxeo/nuxeo-drive/3f5fdc8ed1ae45aa0dfe2d93f6b235e6d703aea8/nuxeo/nuxeo-drive/b987971807caafc0c7d176b54e288b67c6aff304/_/%2F/code/) to see more details.


Totally agree.
I realised that the specific phrasing "I cannot expect everybody to have an encyclopedic understanding of CSS" would lead to folks saying "Boo hoo these people do not know CSS so they reinvented it just learn CSS!!!!!!".

That's why I put the "particularly juniors" there, because even people who know CSS very well will have juniors on their team who don't!

Does that make sense?


Not needed, as there are no files to be included here


Дилер должен сделать ход, даже если у игрока перебор


Screen-shot, for current output.

![screen_shot](https://user-images.githubusercontent.com/27287529/52625276-3d280e80-2ee3-11e9-855f-67c0bdf88cc3.png)


This is more readable if the help text is on the next line with an indent


add


Move the newline above the logging include. Anyway, the convention is to keep this include on the line above `LOG_MODULE_REGISTER(...)`


fkasjdfksjadfkasdf


The other defines have descriptive name, but not this one


`u8_t *` -> `char *`


Hello, please elaborate why this change. Please also modify commit to comply with C code style. Thank you for your effort.


Also removed printing "mean" and "ranged" properties when __str__ is called


create a directory


I've updated the genesis.json in cbb3b21a.


@tmat this is currently causing the official build validation jobs to fail. Is this a left-over and should it be removed or did the path simply change?


Deployed at: https://alva-commits-d8788.surge.sh


Reviewer c'est totay @jem-odoo ;)


*edit from const precedence to const order


Note that this is a blocking call, so calling this from for example workqueue context could cause some issues


Можно так:
`array.each.with_index(1) { |item, index| puts "#{index}. #{item}" }`


oh, i forgot about that rule! thanks!


please remove console.log statement, this can cause errors in some browsers


Can be returned directly


Oh putain ! o_0


language: ruby
rvm:
 - 2.2
 - jruby


Can be shortened by `return err ? -EFAULT : 0;`, but your call


Deployed at: https://alva-site-commits-d8788.surge.sh


Длинная строка, оформи через `do/end`


Assign CPU Resources to Containers and Pods


@killerwife ok, I'll check Classic DBCs and none of this is needed because spell effects 1 & 2 do not exist in Classic. They were added in patch 2.3. Effect 0 is already handled.


Cool, didn't know that.


Does it need to be void? Would expect `char *`


I do understand the author's decision, but this is such a pity for all enthousiast users of the Suffusion theme for  WordPress.
Sayontan, thanks for all your great work in the past.
Volunteers, thanks for all your support in the years past and, hopefully, also the years ahead.


`size_t i` ?


- ta remarque sur le type de retour, c'est pour éviter le cast, c'est ça ?
- bonne idée de passer en paramètre un IEqualityComparer. Je n'avais effectivement pas penser qu'ils pouvaient être différents entre les 2 dico.
- Le cast est obligatoire car sinon, j'utilise le concat de NExtends et pas celui de IEnumerable.
- yes, je vais gérer les nullreflex.


Hi, **Sorrow446**. Thx for Qobuz-DL.
I found one problem. When the album has a faulty cover or album cover simply does not exist, the Qobuz-DL cannot download.
Example:
Album link: https://play.qobuz.com/album/0825646498369
Qobuz-DL  return:
> Traceback (most recent call last):
>   File "Qobuz-DL.py", line 268, in <module>
>   File "urllib\request.py", line 248, in urlretrieve
>   File "urllib\request.py", line 223, in urlopen
>   File "urllib\request.py", line 532, in open
>   File "urllib\request.py", line 642, in http_response
>   File "urllib\request.py", line 570, in error
>   File "urllib\request.py", line 504, in _call_chain
>   File "urllib\request.py", line 650, in http_error_default
> urllib.error.HTTPError: HTTP Error 404: Not Found
> [8884] Failed to execute script Qobuz-DL

Can you fix it in second release.?
Thank you.


what dimension/shape is it?


Note that you are not testing wiki admin here but page level admin (on current page). Would be safer to explicitly pass the current wiki reference to hasAccess.


i know this is commented out but i've seen this style in other places, why not just go self.config.get('grayscale')?


As a proof of concept, this is fine. Most data only needs to be sent once, as they're unchanged (?) during connection. Others can be subscribed to. We need to figure this out.


I don't think we need this. We can just get use of ordinal() instead (if needed)


Fixed with https://github.com/dotnet/arcade/commit/513e1f0732b20206dc3272c9ea5090b074657609 to unblock dependency flow


I think the method name is not really accurate anymore. Should probably be something like isAllowed.


Something's up with the indentation levels here. Might be GitHub


cloned your repo and added as module and fixed this issue...

it worked but only after click my spinner third time.. for the first two time i click my spinner it opens up at the bottom and hence invisible...please suggest a fix


Please update your README.md and mention this for your laravel <5.5 support


Actually, all indentations changed in this file look off for me, but possibly only a GitHub thing


Successfully aliased the URL <https://pegjs-next-website-2957nf9wn.now.sh> to the following alias.

* https://next.pegjs.org


Hi Yannick,

How do you update the black looking https://uds-psl.github.io/H10 page as well ?

D.


To cast to bool without warnings on some compilers.


DeepCode analyzed this commit.
There are 2 new info reports.1 info report was fixed.

[Click](https://www.deepcode.ai/app/gh/ITISFoundation/osparc-simcore/540a0e76b412b5c6a111031db57c2fc60b3d5451/ITISFoundation/osparc-simcore/004077a4f37528c0dab2c97b5a82874fb7dc911a/_/%2F/code/) to see more details.


<html>
 <body)
    Hello
</body>
</html>


I'll get those removed.


JC is back ! 😁
Python power !


this is fixed in https://github.com/namin/collapsing-towers/commit/297ad52241622bf7bc4d72c9b6f4b8277879fb79


nit: remove empty line


Такой код не будет работать


Ты то используешь переменную класса (и то будет модуля)


А потом используешь инстанс переменную уровня  класса


Используй что-то одно


@Trystanosaurus ok, please fill an issue and I'll have a look later. Put as much details as possible in your issue (OS version, compiler version, etc...)


initial commit


1. 비지니스캔버스 템플릿
 - https://www.template.net/business/word-templates/business-model-canvas-template/


в текущей реализации(которая не работает) если использовать переменную с двумя @@ будут считаться инстансы всех классов, куда подключен модуль. Например, если он подключен к поездам и станциями, то создание станции будет увеличивать счетчик поездов и наоборот. А так быть не должно. Это происходит потому что ты используешь переменные класса (`@@count`) но на уровне модуля, а сам модуль подключается через extend. Когда модуль подключается через extend, его инстанс-методы становятся методами класса, куда модуль подключен, а инстанс-переменные - переменными класса. Но т.к. у тебя используется сразу класс-переменная, то она становится класс-переменной уровня модуля, т.е. как бы глобальной для всех классов, куда подключен модуль. Это можно еще представить наследованием: когда мы модуль подключаем, он добавляется как базовый класс в цепочку наследования и раз ты используешь класс-переменные уровня модуля, то она становится общей для всех классов-наследников. Решение: нужно использовать инстанс-переменную, можно даже через attr_accessor.


[R/ipf.r:132:15:](https://github.com/statistikat/surveysd/blob/d5b121dc7e555caae3880ef11ef10ef28fea813f/R/ipf.r#L132) *style:* **Variable and function names should not be longer than 30 characters.**
```r
    wValue <- representativeHouseholdForCalibration <- NULL
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ipf.r:213:24:](https://github.com/statistikat/surveysd/blob/d5b121dc7e555caae3880ef11ef10ef28fea813f/R/ipf.r#L213) *style:* **Variable and function names should not be longer than 30 characters.**
```r
    value <- wValue <- representativeHouseholdForCalibration <- NULL
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ipf.r:320:3:](https://github.com/statistikat/surveysd/blob/d5b121dc7e555caae3880ef11ef10ef28fea813f/R/ipf.r#L320) *style:* **Variable and function names should not be longer than 30 characters.**
```r
  representativeHouseholdForCalibration <- OriginalSortingVariable <-
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ipf.r:545:24:](https://github.com/statistikat/surveysd/blob/d5b121dc7e555caae3880ef11ef10ef28fea813f/R/ipf.r#L545) *style:* **Variable and function names should not be longer than 30 characters.**
```r
    value <- wValue <- representativeHouseholdForCalibration <- NULL
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ipf.r:571:11:](https://github.com/statistikat/surveysd/blob/d5b121dc7e555caae3880ef11ef10ef28fea813f/R/ipf.r#L571) *style:* **Variable and function names should not be longer than 30 characters.**
```r
    dat[, representativeHouseholdForCalibration := 1]
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ipf.r:573:11:](https://github.com/statistikat/surveysd/blob/d5b121dc7e555caae3880ef11ef10ef28fea813f/R/ipf.r#L573) *style:* **Variable and function names should not be longer than 30 characters.**
```r
    dat[, representativeHouseholdForCalibration :=
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


Сюда можно добавить data: {breadcrumb: 'name'}. Да и вообще любые данные передавать. Также смотри router.navigate(['courses'], {... что_нибудь})


Yeah pretty sure it's useless


> initial commit

good


这里就给一些调用的例子吧，custom 的部分可以放在 api 文档里说明。


тут есть хорошая статейка, почитай про инстанс-переменные уровня класса: https://habrahabr.ru/post/111781/


POST - http://localhost:9000/cars/rem/{id}
>rimuove un annuncio attravero il suo is


Я переделал немного. Попробуй, посмотри, что он будет выдавать в итоге   ngOnInit() {
    this.router.events.pipe(
        filter(event => event instanceof NavigationEnd),
        map(() => this.activatedRoute),
        map(route => route.firstChild),
        map(route => ({params: route.params, data: route.data}))
    ).subscribe((route) => {
      route.params.subscribe(params => {
        console.log(params);
        this.course = this.coursesService.getCourseById(+params.id);
      });
      route.data.subscribe(data => {
        console.log(data)
      });
    });

  }


JsBridge 是 YTKWebApp 的一部分，只能和 YTKJsBridge 配合


@leleuj Just noticed that 3.6.0 was mentioned in release notes, but wasn't released yet neither on GH, nor on central? The latest release available on Central is still `http://central.maven.org/maven2/org/pac4j/pac4j-core`: 3.5.0.


这部分可以先不写，我们之后会有个整体文档


Oh yeah and now that you mention it I should probably also update /help in
general as well. I'll push something when I'm home.


travis configuration change


When I perform run_regression --func with this commit, following 2 test cases are failed.

```
1) FAIL: astf_basic_tests.CAstfPcapFull_Test.test_astf_caps

   Traceback (most recent call last):
    /proj/ste/users/ejeomoo/etrex-devel/src/upgrade-trex/build/work/trex-core-test/scripts/external_libs/nose-1.3.4/python2/nose/case.py line 197 in runTest
      self.test(*self.arg)
    functional_tests/astf_basic_tests.py line 108 in test_astf_caps
      self.run_astf_gold(False)
    functional_tests/astf_basic_tests.py line 79 in run_astf_gold
      compare_caps(golden = golden, output = output, max_diff_sec = 1)
    functional_tests/stl_basic_tests.py line 112 in compare_caps
      raise AssertionError(errmsg)
   AssertionError: RAW error: output file '../../generated/param_ipv6.generated.pcap', differs from golden 'functional_tests/golden/param_ipv6.cap' in pkt #1

-----------------------------------------------------------------------------
2) FAIL: astf_basic_tests.CAstfPcapFull_Test.test_astf_cc_caps

   Traceback (most recent call last):
    /proj/ste/users/ejeomoo/etrex-devel/src/upgrade-trex/build/work/trex-core-test/scripts/external_libs/nose-1.3.4/python2/nose/case.py line 197 in runTest
      self.test(*self.arg)
    functional_tests/astf_basic_tests.py line 105 in test_astf_cc_caps
      self.run_client_config(False);
    functional_tests/astf_basic_tests.py line 101 in run_client_config
      compare_caps(golden = golden, output = output, max_diff_sec = 1)
    functional_tests/stl_basic_tests.py line 112 in compare_caps
      raise AssertionError(errmsg)
   AssertionError: RAW error: output file '../../generated/http_simple_cc_http_simple.generated.pcap', differs from golden 'functional_tests/golden/http_simple_cc_http_simple.pcap' in pkt #1

-----------------------------------------------------------------------------
102 tests run in 74.9 seconds.
2 FAILED (100 tests passed)

```

Could you check this in your side?


Copy of this build can be found at
https://www.mewbuilds.com/build/2e086962b543698ce3ca74ec2e22778c067ead0d/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmVaiVG1BuscYMFFoBHjdd92QaLFeACB4FCGewoLzCsZtz


> Maybe move the settings observer creation into onViewCreated, there you have already mStatusBar instance and other shit so the context should be always available.
> Doing stuff in the fragment onCreate is always tricky instead, because the activity is not created yet then you get the null context.

Ahh, cool. Let me try :) Thanks :+1:


文档感觉还有部分小问题


ㅠㅠ


rtos


```yaml
   language: ruby
   rvm:
    - 2.2
    - jruby
   ```
   {: data-file=".travis.yml"}


I think we've discussed that we should avoid creating container here


dans l'absolu, on peut enlever les pass qui sont des no-op


Probably, it's better to get `LanguageVersionSettings` from the container.


You are on the bleeding edge. try with latest


На самом деле идея с сервисом адекватная. Ты же не делаешь тут ещё одного get запроса, да и синхронизировано все ок. Я бы даже подумал и положил подобные сервисы прямо в breadcrumbs. Там же просто создал бы Subjects, смержил бы их вместе (и ещё добавил бы туда this.router.events. Потом бы на все это подписался и строил крошки. Тут можно вообще очень круто сделать через rxjs.


Ditto


Why does it matter here in the constructor?


**Good Morning.**
### I am student of one of the best ETEC here in São Paulo and I am with a project to just create a tool for instagram ... But I do not know where to start. I'm in the second half of system development.


Shouldn't all these pointers still be nullable?

> Proposal Edit: nevermind the part about `null`. That's just confusing. Even the C pointers will not be allowed to be null, and `?` interacts with C pointers in the same way as normal pointers.


can you use `validate = FALSE`?


True


@abdielou can you provide a more complete code sample?


teste


Можно нормализовать, и убрать склонение (это вроде и так понятно?)


shouldn't this be `e.NewElement`?


@ccrowley96 I think this should be a 400 status, no?
`res.status(400).send({error: 'Room does not exist})`

Also I feel like we should make your error's consistent throughout the codebase, ie if you return a 400 you should return an object with error. Could help when trying to fix bugs later.
Just a suggestion but let me know what you think!


IBM Cloud [toolchain](https://console.bluemix.net/devops/toolchains/82446196-8719-4fc2-9cd8-947007336475?env_id=ibm%3Ayp%3Aus-south "yp_hotel"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/cca48e5a-73e6-498f-9fb0-a3b28aa25f1a?env_id=ibm%3Ayp%3Aus-south "pipeline_yp_hotel") deployed [yp_hotel](https://github.com/chuckz1321/yp_hotel/releases/tag/deploy-ibm-yp-us-south-zcy960312-gmail.com-dev-20190213-000431 "deploy-ibm-yp-us-south-zcy960312-gmail.com-dev-20190213-000431") to [dev](https://console.bluemix.net/apps/a44bc54e-8c70-46e6-b4bc-a6c0d49cbe21?env_id=ibm:yp:us-south "ibm:yp:us-south:zcy960312@gmail.com:dev"), including this commit


Hi,

I have added the license to this code. its on my GitHub repository.

On Fri, Feb 8, 2019 at 8:07 AM Ilori-Jaiyeola <notifications@github.com>
wrote:

> Please can i get a License on your codes, I am want to make use of the
> code in my Institution.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/Ezi0aaudit0re/P2P-music-sharing/commit/285a7ab615ea2eeca013fe7ac89a4b4dd44183f7#commitcomment-32244925>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ANcmXVlMY4a66NvM3NA6utlp5_pXa9bkks5vLXZ2gaJpZM4avkFK>
> .
>

--
Thanks,
Aman Nagpal

LinkedIn - https://in.linkedin.com/in/aman-nagpal-ba1979a1


kiva-high-IR-basement-walls (nealkruis) - x86_64-Linux-Ubuntu-18.04-gcc-7.3: OK (3116 of 3117 tests passed, 0 test warnings)

Messages:

 * 1 test had: EIO diffs.
 * 1 test had: ESO big diffs.
 * 1 test had: Table big diffs.

Failures:

regression Test Summary
 * Passed: 652
 * Failed: 1

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.97%25-yellow.png)


IBM Cloud [toolchain](https://console.bluemix.net/devops/toolchains/82446196-8719-4fc2-9cd8-947007336475?env_id=ibm%3Ayp%3Aus-south "yp_hotel"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/cca48e5a-73e6-498f-9fb0-a3b28aa25f1a?env_id=ibm%3Ayp%3Aus-south "pipeline_yp_hotel") deployed [yp_hotel](https://github.com/chuckz1321/yp_hotel/releases/tag/deploy-ibm-yp-us-south-zcy960312-gmail.com-dev-20190213-000637 "deploy-ibm-yp-us-south-zcy960312-gmail.com-dev-20190213-000637") to [dev](https://console.bluemix.net/apps/a44bc54e-8c70-46e6-b4bc-a6c0d49cbe21?env_id=ibm:yp:us-south "ibm:yp:us-south:zcy960312@gmail.com:dev"), including this commit


### Visual regression report:

[![Visual report](https://circleci.com/gh/stevector/nerdologues-d8/2442/artifacts/0/artifact/backstop_data/bitmaps_test/20190213-000606/0600294051_podcasts_0_document_0_desktop.png)](https://circleci.com/gh/stevector/nerdologues-d8/2442/artifacts/0/artifact/backstop_data/html_report/index.html)


Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

- @isuruf was added to this feedstock maintenance team.

You should get push access to this feedstock and CI services.

Feel free to join the community [chat room](https://gitter.im/conda-forge/conda-forge.github.io).

NOTE: Please make sure to not push to the repository directly.
      Use branches in your fork for any changes and send a PR.
      More details [here](https://conda-forge.org/docs/conda-forge_gotchas.html#using-a-fork-vs-a-branch-when-updating-a-recipe)


Successfully aliased the URL <https://file-metadata-microservice-bg2nkkxn6.now.sh> to the following alias.

* https://file-metadata-api.now.sh


Copy of this build can be found at
https://www.mewbuilds.com/build/8172b36e65fe74891bbf811097776f87a71ee949/index.html
                       https://www.cloudflare-ipfs.com/ipfs/Qmf9iBdjgBEm6dCD4965fFwnWXpoZDFqLEBXZ7NrVzenes


I think this should be `FD_ERROR` and `file_fd`


kiva-high-IR-basement-walls (nealkruis) - x86_64-Linux-Ubuntu-18.04-cppcheck-1.82: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


more like this style is what I was mentioning above


IBM Cloud [toolchain](https://console.bluemix.net/devops/toolchains/82446196-8719-4fc2-9cd8-947007336475?env_id=ibm%3Ayp%3Aus-south "yp_hotel"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/cca48e5a-73e6-498f-9fb0-a3b28aa25f1a?env_id=ibm%3Ayp%3Aus-south "pipeline_yp_hotel") deployed [yp_hotel](https://github.com/chuckz1321/yp_hotel/releases/tag/deploy-ibm-yp-us-south-zcy960312-gmail.com-dev-20190213-001301 "deploy-ibm-yp-us-south-zcy960312-gmail.com-dev-20190213-001301") to [dev](https://console.bluemix.net/apps/a44bc54e-8c70-46e6-b4bc-a6c0d49cbe21?env_id=ibm:yp:us-south "ibm:yp:us-south:zcy960312@gmail.com:dev"), including this commit


DeepCode analyzed this commit.
There are no new issues.1 info report was fixed.

[Click](https://www.deepcode.ai/app/gh/zerdos/react-mobx-typescript-boilerplate/b9fee4a734363d378451baf6d3639fa1fa138ef2/zerdos/react-mobx-typescript-boilerplate/60e42cdc65ddbe9aabab74c1652e43fea168a240/_/%2F/code/) to see more details.


Copy of this build can be found at
https://www.mewbuilds.com/build/ef64cb047910ef1aa24f7d35103774cce64aff1b/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmTJFzVZcyae7Zxf5BQCna1SiAMcas5tEvGsPeftLp6LgB


Copy of this build can be found at
https://www.mewbuilds.com/build/d3fc1dc283c07f4fcad18eed5cc7f7429b955e5e/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmSeSgoZdQsxb5QiDZEbP4UNkJnRYTU6dSmwa5B457TUKk


DeepCode analyzed this commit.
There are no new issues.1 info report was fixed.

[Click](https://www.deepcode.ai/app/gh/zerdos/react-mobx-typescript-boilerplate/5e70a758687a61ff3fd7b8eefcd1bbf4107b8035/zerdos/react-mobx-typescript-boilerplate/3544c635479507b44852748ef7eebb45cb515aba/_/%2F/code/) to see more details.


@ccrowley96 I know you may dislike this but I feel like this function can be cleaned up with `async/await`

```javascript
if(this.state.roomCode === undefined){
    this.setState({
        errMessage: true
    )};
} else {
    try {
        let res = await axios.get(`/api/isroom/${this.state.roomCode}`)
	if(res.data.roomFound){
	    this.setState({
		goToRoom: true
	    });
	} else{
	    this.setState({
	        errMessage: true
	});
    } catch (e) {
        console.log(e);
    }
```

Something like this^
Brackets are off and whatnot bc it's impossible to write chunks of code as a comment.
My justification for the switch is the code starts to looks like synchronous code (ie we remove the .then and .catch chains) which is more language agnostic when browsing a codebase.


![](https://github.trello.services/images/mini-trello-icon.png) [(1) Add knockback duration [0.25]](https://trello.com/c/he5fmFbN/339-1-add-knockback-duration-025)


I had my Excel formulas set up incorrectly, so it was only reliably counting Away wins, and not Home wins. When testing the completed method, I was getting a failure, and only these two stats were wrong... so I went back and re-checked my assumptions in Excel and discovered the problem was the test, not the method. Oops!


Not working still getting invalid date range error


This isn't really part of this branch, but I realized I wasn't using SimpleCov yet.


Deployment failed with the following error:

~~~
You defined 1 build that did not match any source files (please ensure they are NOT defined in .nowignore):
~~~


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


This method is in desperate need of a refactor, but it's working as expected now.


Successfully aliased the URL <https://file-metadata-microservice-xwvuktcdcj.now.sh> to the following alias.

* https://file-metadata-api.now.sh


Not sure why you dropped the _uniform_ variability here (and below), as orientation *is* uniform?


Você pode colocar seu telefone no site @LuizMarcello


Other than the small comment with the test datafile, this looks great, Alan!


Ok, farei isto.
________________________________
De: ValeriaMiranda <notifications@github.com>
Enviado: terça-feira, 12 de fevereiro de 2019 22:27
Para: LuizMarcello/github-master
Cc: Luiz Marcello; Mention
Assunto: Re: [LuizMarcello/github-master] criação da página sobre #4 (3e5e9a2)

Você pode colocar seu telefone no site @LuizMarcello<https://github.com/LuizMarcello>

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/LuizMarcello/github-master/commit/3e5e9a2155909473280c0e3799564c86a74560f9#commitcomment-32294067>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AYsw8cqGgspn9-5fQC7Sy3NTX9xyj4Dnks5vM1wEgaJpZM4a4Va_>.


Just to be clear on the CKM thing. The CK for LE is only supposed to generate this during the publishing process to Steam Workshop and they're supposed to be deleted after that. There is no legit purpose for them remaining behind and they were never necessary to keep for anyone.


Successfully aliased the URL <https://file-metadata-microservice-kouzufpzwl.now.sh> to the following alias.

* https://file-metadata-api.now.sh


Copy of this build can be found at
https://www.mewbuilds.com/build/74ab9bcb603a2d05ed06becfec4263161057a625/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmbPszC2eg7PT57rotHFAmPcF3FddAwnbZfA72KGiiimZS


What does education stand for?


Would it be possible for you to add some precise instructions on how to use it under Windows for example. I recently started using circuit_macros and it is tiring to compile the codes manually, hence my interest in your tool. Thank you very much!


fkas is not an acceptable title for a commit.


Gabriel created the Events fixture. The Post Create test should be functional now.


Because it was renamed to imitate after updating these slides.


Successfully aliased the URL <https://polyhedron-qcerffxf4.now.sh> to the following alias.

* https://polyhedron.app


@Alexintosh I had to remove Store injecting into pages directly, as it was breaking navigation.
+ I feel like we should move init() method from there into apollo reducers. Feels like we are going against the simplicity of graphql store. Things are started to getting complex.


true, but for sanity reasons I'd keep the two classes of data separate.

Basically it will make more architectural sense to have vectors of SShaderResourceVariant map 1:1 to descriptor set layouts


Плюсую!


but with
https://github.com/Crisspl/IrrlichtBAW/commit/4de89aefdb670dc6e3bb1d90046a763e6d8512ef#diff-74cf18d2f888b48b4d0b5df2272cf59fR45

isn't the base offset redundant?


IBM Cloud [toolchain](https://console.bluemix.net/devops/toolchains/82446196-8719-4fc2-9cd8-947007336475?env_id=ibm%3Ayp%3Aus-south "yp_hotel"): [Delivery Pipeline](https://console.bluemix.net/devops/pipelines/cca48e5a-73e6-498f-9fb0-a3b28aa25f1a?env_id=ibm%3Ayp%3Aus-south "pipeline_yp_hotel") deployed [yp_hotel](https://github.com/chuckz1321/yp_hotel/releases/tag/deploy-ibm-yp-us-south-zcy960312-gmail.com-dev-20190213-004423 "deploy-ibm-yp-us-south-zcy960312-gmail.com-dev-20190213-004423") to [dev](https://console.bluemix.net/apps/a44bc54e-8c70-46e6-b4bc-a6c0d49cbe21?env_id=ibm:yp:us-south "ibm:yp:us-south:zcy960312@gmail.com:dev"), including this commit


funny meme


@gamebet ah thanks: 9c65c842871cd734001b55f6ff0750c3a232171b


Hi @anule!  Thanks for making this change.  Another option for this would be to add info about environmental variables (setting and accessing), rather than removing it altogether.  (You could export the variable into the environment, and access it in the bash script/shell using `$`.)

Here's a guide about this that might be helpful on how to do this => [https://www.digitalocean.com/community/tutorials/how-to-read-and-set-environmental-and-shell-variables-on-a-linux-vps](https://www.digitalocean.com/community/tutorials/how-to-read-and-set-environmental-and-shell-variables-on-a-linux-vps)

I can make the change too, but figured it'd be better to ask you about it than undoing your change. :)


Mopy/Docs/Wrye Bash Advanced Readme.html

@Arthmoor Edited the readme to clarify that they're meant to be temporary.


It does, but it doesn't go far enough.  You need to swap data before you pack it, because in addition to the packet being swapped, the value itself is swapped.

The CRC5 also needs to be swapped.

Swap all the things!

The original patch didn't go far enough, so I added 4dd00095854eea61f6134431e02658e3428ee997.

For reference, I'm using https://www.usb.org/sites/default/files/crcdes.pdf as a reference.  Their example shows an encoding of "0x710", which after the latest patch matches up with their output:

```python
>>> from valentyusb.usbcore.utils.packet import sof_packet
>>> sof_packet(0x710)
'101001010000100011110100'
>>>
```

The reference token in the output is `00000001 10100101 00001000 11110100`.


Created multidev environment [badcamp-2019#ci-19](https://dashboard.pantheon.io/sites/77e169f6-098e-4e68-b9b1-67d0b7cc2f02#ci-19).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-19-badcamp-2019.pantheonsite.io/)


Successfully aliased the URL <https://grxy-a8d1uv0ty.now.sh> to the following alias.

* https://grxy.now.sh


Please pay attention to the style convention. Run gofmt if in doubt.


`player.position.x` or directly `player.position` (BlockPos)


wrong TC


These are specific to TLS authentication provider. This shouldn't be in the Authentication interface


Copy of this build can be found at
https://www.mewbuilds.com/build/256becfcd2e086c49880852a70405c9d770b732a/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmaeSVGBnpb9mj5YGGgDuRQCshF53o3NdE2sXttgDb3Lap


[Core] Fixed not applying intent color for icon inside tree node

Previews: documentation | landing | table


Please refrain from printing debug messages unless absolutely necessary.


I need to access the private key to this address of mine. I typed in the 12 word recovery phrase in BIP39 generator and the QR code it generated did not work


@jeroen This is the most correct way to do this so if you are doing it the old way elsewhere in your code I suggest changing it because otherwise a server may be more likely to return encoded content in a way that is not supported by an arbitrary libcurl. Some servers do it regardless like some yahoo servers may return gzip no matter what accept-encoding says


DeepCode analyzed this commit.
There are no new issues.1 info report was fixed.

[Click](https://www.deepcode.ai/app/gh/zerdos/react-mobx-typescript-boilerplate/af9f7d240d8b75013608745947dd00e1f3293b8a/zerdos/react-mobx-typescript-boilerplate/e281160073dee818435dbe1bb3da724a828123d2/_/%2F/code/) to see more details.


✅ [Jenkins job](https://jenkins.internalx.com/job/macios/job/d16-0/24/display/redirect) (on internal Jenkins) succeeded

✅ [Build succeeded](https://jenkins.internalx.com/job/macios/job/d16-0/24//console)
✅ [API Diff (from stable)](http://xamarin-storage/jenkins/xamarin-macios/d16-0/ad57f87754910d7b5a91ea8ec8648c18fd6d7ac1/24/jenkins-results/api-diff/index.html)
ℹ [API Diff (from PR only)](http://xamarin-storage/jenkins/xamarin-macios/d16-0/ad57f87754910d7b5a91ea8ec8648c18fd6d7ac1/24/jenkins-results/apicomparison/api-diff.html) (please review changes)
✅ [Generator Diff](http://xamarin-storage/jenkins/xamarin-macios/d16-0/ad57f87754910d7b5a91ea8ec8648c18fd6d7ac1/24/jenkins-results/generator-diff/index.html) (no change)
✅ [Test run succeeded](http://xamarin-storage/jenkins/xamarin-macios/d16-0/ad57f87754910d7b5a91ea8ec8648c18fd6d7ac1/24/jenkins-results/tests/index.html)


nvm, large img is not api call


Delete


Pay attention to style convention.


Forgive me for raising the yellow flag on line 238 and 239. But, I couldn't help notice that we're still referring to "php5", while the whole purpose of this branch is the support for v7.


<img src="https://i.imgur.com/rqeTA0k.png">


kiva-high-IR-basement-walls (nealkruis) - x86_64-Linux-Ubuntu-18.04-gcc-7.3-UnitTestsCoverage-Debug: OK (1809 of 1809 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-41.59%25-green.png)


Merge


i'll make a glitch of this soon and give it a try!


hoho


blah


You're the best Qiu!!!


@metasoarous does it make sense to include the _name_ (in addition to the commit) of the system / program they used to process the data if it could theoretically be any? Or would that info be somehow encompassed by the commit string?


@KennethPacheco and @AldairJuarez  Please review


Is this todo done since you've added timepoint_id?


Successfully aliased the URL <https://elsangedycom-66syiyp1a.now.sh> to the following aliases.

* https://elsangedy.com
* https://www.elsangedy.com


Wow Josh, nice work, keep it up, proud of you 🐸


Nice. :)


cc @psathyrella from whom my interpretation was that affinity is relative to the sample / somewhat arbitrarily quantified across all data.


lol


@luiskrieg @AldairJuarez please review


hm then maybe it is possible that introspection data contain actual descriptor set layout (not just data to build from).


Oh, because of bash, if I put exclamation marks it messes it up >:(


Based on my understanding of multiplicity in this context, that makes sense. If you could select that in the scatterplot for example, it would help represent the same concept as multiplicity at the family / cluster level; that is, that a given datum's presence/absence is not the complete picture.


Anyway, this is a big milestone for the simulation. The energy is still wrong though. Organisms still start with always max energy, which they shouldn't. Also, when a creature dies, its energy should be deposited into the tile.


@metasoarous do you mean that the seed sequence can just be annotated as such among the sequences in the reconstruction as opposed to also at the family level?


@AldairJuarez @KriegGamer please review


@KennethPacheco @KriegGamer Please Review


@AldairJuarez please remove Author: Linkin Park


wow ... somehow Haru gains foresight can look into future commits XD ...


Why is correct @luiskrieg & @KennethPacheco ?


@svanegmond, I've heard some do, but I don't know if this source code was ever made to compile. The PHP extension is still untouched, anyway... 😛

Maybe you should check out Haiku sometime, and try it yourself!


@fkleuver Thanx! I may be a maintainer in the future.  And at the end I have to admit I always guarded my words and knowledge to avoid people to avoid to know that I understand things. But now at the end things doesn't really matter.
So my advice to you for speeding up the identifier scanning is that you should Investigate how to avoid string comparison for keyword checking. Just be aware that suffix tree checking will have potentially poor branch prediction and string comparison could be O(mn) worst case, but won't have the JIT boilerplate.

You could also try to avoid normal equality comparisons check (*===*) and use the ASCII table lookup, and force all letters to lower case to avoid potential branching later on. You see how I used `| 32` for numeric scanning to lower the letters.


@KennethPacheco  @AldairJuarez  please review


[R/Chromium.R:93:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L93) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:97:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L97) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:100:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L100) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:103:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L103) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:107:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L107) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:118:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L118) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:121:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L121) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:124:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L124) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:173:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L173) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:190:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L190) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:197:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L197) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:201:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L201) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:211:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L211) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:216:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L216) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:235:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L235) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/extract-methods.R:48:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L48) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~
```
[R/extract-methods.R:51:18:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L51) *warning:* **Avoid 1L:nrow(...) expressions, use seq_len.**
```r
            i <- 1L:nrow(x)
                 ^
```
[R/extract-methods.R:55:18:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L55) *warning:* **Avoid 1L:ncol(...) expressions, use seq_len.**
```r
            j <- 1L:ncol(x)
                 ^
```
[R/extract-methods.R:57:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L57) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~
```
[R/extract-methods.R:64:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L64) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~
```
[R/extract-methods.R:68:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L68) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~
```
[R/extract-methods.R:71:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L71) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~
```
[R/extract-methods.R:79:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L79) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~
```
[R/extract-methods.R:82:9:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L82) *style:* **TODO comments should be removed.**
```r
        # FIXME Need to export this in basejump??
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/extract-methods.R:86:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L86) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~
```
[R/extract-methods.R:89:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L89) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~
```
[R/extract-methods.R:96:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L96) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~
```
[R/extract-methods.R:103:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L103) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~
```
[tests/testthat/test_Chromium.R:3:9:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/tests/testthat/test_Chromium.R#L3) *style:* **Use <-, not =, for assignment.**
```r
    dir = system.file("extdata/cellranger", package = "Chromium")
        ^
```


We are also noticing a breaking change with this change as well. Our automated tests @ https://github.com/formio/formio are failing with the following diff.

https://monosnap.com/file/SfdvtLke4Eehxo4srIPz3PBeaBn28b

This is created with ```getObject()``` method from a nested schema that looks like this.

```
const schema = new mongoose.Schema({
  ...
  ...
  submissionAccess: [{
    _id: false,
    type: {
      type: String,
      enum: [
        'create_all',
        'read_all',
        'update_all',
        'delete_all',
        'create_own',
        'read_own',
        'update_own',
        'delete_own',
        'self'
      ],
      required: 'A permission type is required to associate an available permission with a given role.'
    },
    roles: {
      type: [mongoose.Schema.Types.ObjectId],
      ref: 'role'
    }
  }],
  ...
})
```

If you wish to run the tests to verify this... just do the following.

```
git clone git@github.com:formio/formio.git
cd formio
npm install
npm install mongoose@5.4.11
npm test
```


@KriegGamer @KennethPacheco please review


This program will print Hello World in python


confirm file upload


please add the copyright. use apache license if possible.


@KriegGamer  @luiskrieg pls review


it's debug code. please compile out these debug message when release it.


ditto


You are misspelling "Author". Please correct


please use correct word. Que is ambigious. please use 'queue' correctly


Text-based RPG game skeleton for practice


please add space correctly, after 'if', before "{"
if (priQueue.empty()) {


Looks like that was my silly mistake too.  Out of curiosity, what results in healing from a null healer?


fourx4, hecules, roadrunr, supermap - atari_s2.cpp
gamecom - gamecom.cpp
Fatal error: Circular dependency in device startup!

----

hdrivair, hdrivairp, strtdriv - harddriv.cpp
Forced close due to watchdog timeout

----

CD-based Megadrive Hardware machines
EG 32x_scd, cdx, segacd, megacd, xeye
Forced close due to watchdog timeout

----

Audio regression in some s11x.cpp games:
Examples w/credit or start sound/music:
gmine_l2 - s11.cpp
shfin_l1 - s11.cpp
pb_l5 - s11a.cpp
jokrz_g4 - s11b.cpp


} else {

In case of single if statement, please don't use "{", "}"


Append underbar


Probably want to remove this TODO


And this one, too.


as 'return' is used as above. 'else' doesn't required. just remove it.


Rockin! Thanks for figuring this out.


Need to add '_' in member variable


add copyright.


Standard 규칙에  _ 바를 붙인다는데 구지..... ㅡㅡa


Deployment failed with the following error:

~~~
If you agree with that, please run again with `--public`.
~~~


I can't think of any other reasons. I will pull this out for now, but we can refer back to this commit if we find a reason we need to use it.


please remove one indent.


@KennethPacheco  @KriegGamer  review please


Missing a test case: UTXO with the given txid and vout is a exists, but the given phk does not match.


Use underbar (_) for private member.


wrong indent, please use the same indent style


Commit made no visible changes, lookup proper markdown headings


Please remove "name" from the "Author"


add the underbar at the member variable


please put a space in front of ``(`` and the back of ``)``


Why use file path(./), Just use file name.


could you add the underbar


please put a space in front of `(` and the back of `)`


[R/Chromium.R:93:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L93) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:97:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L97) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:100:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L100) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:103:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L103) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:107:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L107) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:118:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L118) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:121:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L121) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:124:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L124) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:173:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L173) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:190:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L190) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:197:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L197) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:201:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L201) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:211:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L211) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:216:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L216) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/Chromium.R:235:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/Chromium.R#L235) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/extract-methods.R:48:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L48) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~
```
[R/extract-methods.R:51:18:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L51) *warning:* **Avoid 1L:nrow(...) expressions, use seq_len.**
```r
            i <- 1L:nrow(x)
                 ^
```
[R/extract-methods.R:55:18:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L55) *warning:* **Avoid 1L:ncol(...) expressions, use seq_len.**
```r
            j <- 1L:ncol(x)
                 ^
```
[R/extract-methods.R:57:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L57) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~
```
[R/extract-methods.R:64:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L64) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~
```
[R/extract-methods.R:68:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L68) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~
```
[R/extract-methods.R:71:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L71) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~
```
[R/extract-methods.R:79:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L79) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~
```
[R/extract-methods.R:82:9:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L82) *style:* **TODO comments should be removed.**
```r
        # FIXME Need to export this in basejump??
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/extract-methods.R:86:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L86) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~
```
[R/extract-methods.R:89:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L89) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~
```
[R/extract-methods.R:96:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L96) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~
```
[R/extract-methods.R:103:1:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/R/extract-methods.R#L103) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~
```
[tests/testthat/test_Chromium.R:3:9:](https://github.com/steinbaugh/Chromium/blob/1820d156e91d0997cd57be8871991f1f4d6b3364/tests/testthat/test_Chromium.R#L3) *style:* **Use <-, not =, for assignment.**
```r
    dir = system.file("extdata/cellranger", package = "Chromium")
        ^
```


ditto


LGTM


@KriegGamer @KennethPacheco Please Review


@KriegGamer  @luiskrieg please review


@luiskrieg @KennethPacheco @AldairJuarez please review


Are the params being transformed twice here?


클래스 생성자가 없으므로, 디폴트생성자를 만들면서 내부 변수를 함께 초기화하도록 변경하면 좋을 것 같습니다.
Goods::Goods(int index, int price) : goods_index_(index), goods_price_(price){}


naming convention측면 변수 이름 뒤에 under bar로 끝나는 것은  혼동이 있을 수 있지 않을까 합니다.


main 본문에는 클래스 goods가 선언되어있으나, include는 안되어있는 것 같습니다.


This also happens in v11. Can this be backported?


Copy of this build can be found at
https://www.mewbuilds.com/build/5c332371ad2d5bfa046d19409e859ffb193d3cc2/index.html
                       https://www.cloudflare-ipfs.com/ipfs/Qmbdo471HWbAfcJcBNQJMmZCyHTEv48SCbUqdR8NpQERKD


void Goods::SetGoodsInfo(int index, int price)
필요없는 함수로 삭제하면 좋을것 같습니다.


please enter line return befor 'else'.


Successfully aliased the URL <https://docs-nu9w1nxzf.zeit.sh> to the following alias.

* https://docs.zeit.sh


Class이름의 경우 대문자로 시작하는 것을 권장합니다.


Successfully aliased the URL <https://just-another-todo-app-dhlukgdxhp.now.sh> to the following alias.

* https://just-another-todo-app.now.sh


class의 private 변수를 알수 있는 의미로,,  p_variable_goods_index로 표현하는 것은 어떨까요??


You should add an explicit test for this, this could easily be lost in the future in say a refactor.


Successfully aliased the URL <https://gimb-events-n8oanmsge.now.sh> to the following aliases.

* https://dogodki-gimb.now.sh
* https://dogodki.gimb.xyz


stringBuilder에 대해서 NULL 체크 필요하지 않을까요?


[LAB 1 REPORT.docx](https://github.com/Benga22/CS2302-LAB1-/files/2858451/LAB.1.REPORT.docx)


In my opinion, the highest value is ```5```. Could you please check this value?