@vangheem Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.z3cform/147/violations
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/app/__init__.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/captcha.py:6:1: I001 isort found an import in the wrong position
plone/app/z3cform/captcha.py:7:1: I001 isort found an import in the wrong position
plone/app/z3cform/captcha.py:14:1: I001 isort found an import in the wrong position
plone/app/z3cform/captcha.py:35:5: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/captcha.py:36:5: D001 found adapts( replace it with zope.component.adapter
plone/app/z3cform/captcha.py:44:80: E501 line too long (86 > 79 characters)
plone/app/z3cform/converters.py:4:1: I001 isort found an import in the wrong position
plone/app/z3cform/converters.py:5:1: I001 isort found an import in the wrong position
plone/app/z3cform/converters.py:6:1: I001 isort found an import in the wrong position
plone/app/z3cform/converters.py:18:1: I001 isort found an import in the wrong position
plone/app/z3cform/converters.py:19:1: I001 isort found an import in the wrong position
plone/app/z3cform/converters.py:20:1: I001 isort found an import in the wrong position
plone/app/z3cform/converters.py:21:1: I004 isort found an unexpected blank line in imports
plone/app/z3cform/converters.py:23:1: I001 isort found an import in the wrong position
plone/app/z3cform/converters.py:24:1: I004 isort found an unexpected blank line in imports
plone/app/z3cform/converters.py:25:1: I001 isort found an import in the wrong position
plone/app/z3cform/converters.py:26:1: I001 isort found an import in the wrong position
plone/app/z3cform/converters.py:32:5: D001 found adapts( replace it with zope.component.adapter
plone/app/z3cform/converters.py:65:5: D001 found adapts( replace it with zope.component.adapter
plone/app/z3cform/converters.py:101:11: T000 Todo note found.
plone/app/z3cform/converters.py:139:5: D001 found adapts( replace it with zope.component.adapter
plone/app/z3cform/converters.py:144:5: D001 found adapts( replace it with zope.component.adapter
plone/app/z3cform/converters.py:151:5: D001 found adapts( replace it with zope.component.adapter
plone/app/z3cform/converters.py:193:5: D001 found adapts( replace it with zope.component.adapter
plone/app/z3cform/converters.py:218:5: D001 found adapts( replace it with zope.component.adapter
plone/app/z3cform/converters.py:275:5: D001 found adapts( replace it with zope.component.adapter
plone/app/z3cform/csrf.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/csrf.py:15:5: D001 found adapts( replace it with zope.component.adapter
plone/app/z3cform/inline_validation.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/inline_validation.py:14:5: C901 'InlineValidationView.__call__' is too complex (12)
plone/app/z3cform/inline_validation.py:23:12: P002 found "hasattr", consider replacing it
plone/app/z3cform/inline_validation.py:25:16: P002 found "hasattr", consider replacing it
plone/app/z3cform/inline_validation.py:29:26: Q000 Remove bad quotes.
plone/app/z3cform/inline_validation.py:34:9: E265 block comment should start with '# '
plone/app/z3cform/inline_validation.py:41:17: E731 do not assign a lambda expression, use a def
plone/app/z3cform/interfaces.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/interfaces.py:1:80: E501 line too long (85 > 79 characters)
plone/app/z3cform/interfaces.py:3:1: I001 isort found an import in the wrong position
plone/app/z3cform/interfaces.py:11:1: I001 isort found an import in the wrong position
plone/app/z3cform/interfaces.py:59:39: Q000 Remove bad quotes.
plone/app/z3cform/interfaces.py:60:46: W292 no newline at end of file
plone/app/z3cform/layout.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/layout.py:2:1: F401 'plone.z3cform.layout.FormWrapper' imported but unused
plone/app/z3cform/layout.py:2:1: F401 'plone.z3cform.layout.wrap_form' imported but unused
plone/app/z3cform/layout.py:2:1: I001 isort found an import in the wrong position
plone/app/z3cform/object.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/object.py:3:1: I001 isort found an import in the wrong position
plone/app/z3cform/templates.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/templates.py:13:1: E731 do not assign a lambda expression, use a def
plone/app/z3cform/templates.py:16:6: C812 missing trailing comma
plone/app/z3cform/utils.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/utils.py:5:1: I003 isort expected 1 blank line in imports, found 0
plone/app/z3cform/utils.py:5:1: I003 isort expected 1 blank line in imports, found 0
plone/app/z3cform/widget.py:2:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:5:80: E501 line too long (83 > 79 characters)
plone/app/z3cform/widget.py:7:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:9:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:10:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:27:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:34:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:35:1: I004 isort found an unexpected blank line in imports
plone/app/z3cform/widget.py:36:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:37:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:38:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:39:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:40:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:41:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:44:1: I004 isort found an unexpected blank line in imports
plone/app/z3cform/widget.py:45:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:140:29: Q000 Remove bad quotes.
plone/app/z3cform/widget.py:329:26: Q000 Remove bad quotes.
plone/app/z3cform/widget.py:329:26: S001 found module formatter
plone/app/z3cform/widget.py:396:30: Q000 Remove bad quotes.
plone/app/z3cform/widget.py:396:30: S001 found module formatter
plone/app/z3cform/widget.py:466:48: Q000 Remove bad quotes.
plone/app/z3cform/widget.py:516:35: P101 format string does contain unindexed parameters
plone/app/z3cform/widget.py:518:47: C812 missing trailing comma
plone/app/z3cform/widget.py:522:19: T000 Todo note found.
plone/app/z3cform/widget.py:527:42: P101 format string does contain unindexed parameters
plone/app/z3cform/widget.py:528:44: P101 format string does contain unindexed parameters
plone/app/z3cform/widget.py:530:34: P101 format string does contain unindexed parameters
plone/app/z3cform/widget.py:534:47: T000 Todo note found.
plone/app/z3cform/widget.py:538:66: C812 missing trailing comma
plone/app/z3cform/widget.py:539:30: C812 missing trailing comma
plone/app/z3cform/widget.py:540:26: C812 missing trailing comma
plone/app/z3cform/widget.py:553:28: P101 format string does contain unindexed parameters
plone/app/z3cform/widget.py:555:46: C812 missing trailing comma
plone/app/z3cform/queryselect/__init__.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/queryselect/__init__.py:3:1: I003 isort expected 1 blank line in imports, found 0
plone/app/z3cform/queryselect/__init__.py:10:15: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/queryselect/__init__.py:48:24: C812 missing trailing comma
plone/app/z3cform/queryselect/__init__.py:53:15: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/queryselect/__init__.py:61:19: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/tests/example.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/tests/example.py:2:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/example.py:5:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/example.py:11:28: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:16:16: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:20:5: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/tests/example.py:25:13: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:38:34: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:49:13: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:64:30: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:65:55: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:66:52: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:71:13: Q000 Remove bad quotes.
plone/app/z3cform/tests/layer.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/tests/layer.py:1:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/layer.py:33:10: Q000 Remove bad quotes.
plone/app/z3cform/tests/test_csrf.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/tests/test_objectsubform.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/tests/test_objectsubform.py:2:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/test_objectsubform.py:6:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/test_objectsubform.py:8:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/test_objectsubform.py:18:15: Q000 Remove bad quotes.
plone/app/z3cform/tests/test_objectsubform.py:18:33: C812 missing trailing comma
plone/app/z3cform/tests/test_objectsubform.py:23:15: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/tests/test_objectsubform.py:34:16: S001 found module formatter
plone/app/z3cform/tests/test_objectsubform.py:43:15: Q000 Remove bad quotes.
plone/app/z3cform/tests/test_objectsubform.py:46:19: Q000 Remove bad quotes.
plone/app/z3cform/tests/test_objectsubform.py:47:30: C812 missing trailing comma
plone/app/z3cform/tests/test_objectsubform.py:48:10: C812 missing trailing comma
plone/app/z3cform/tests/test_objectsubform.py:54:13: Q000 Remove bad quotes.
plone/app/z3cform/tests/test_objectsubform.py:59:15: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/tests/test_objectsubform.py:107:24: C812 missing trailing comma
plone/app/z3cform/tests/test_objectsubform.py:114:11: T000 Todo note found.
plone/app/z3cform/tests/test_objectsubform.py:130:19: C812 missing trailing comma
plone/app/z3cform/tests/test_widget.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/tests/test_widget.py:11:15: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/tests/test_widget.py:32:80: E501 line too long (126 > 79 characters)
plone/app/z3cform/tests/test_widgets.py:18:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/test_widgets.py:26:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/test_widgets.py:30:1: I003 isort expected 1 blank line in imports, found 0
plone/app/z3cform/tests/test_widgets.py:37:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/test_widgets.py:62:38: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:125:56: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:127:34: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:128:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:216:56: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:221:42: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:222:22: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:223:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:364:43: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:378:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:379:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:396:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:397:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:414:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:415:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:434:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:435:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:453:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:454:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:466:62: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:480:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:481:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:492:62: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:506:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:507:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:519:62: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:533:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:534:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:544:43: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:548:14: D001 found assertEquals( replace it with assertEqual
plone/app/z3cform/tests/test_widgets.py:551:14: D001 found assertEquals( replace it with assertEqual
plone/app/z3cform/tests/test_widgets.py:587:52: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:592:36: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:665:32: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:677:37: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:679:14: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:692:37: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:694:14: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:769:9: D001 found directlyProvides( replace it with zope.interface.provider
plone/app/z3cform/tests/test_widgets.py:790:75: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:907:32: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:940:36: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:961:18: D001 found assertEquals( replace it with assertEqual
plone/app/z3cform/tests/test_widgets.py:961:80: E501 line too long (80 > 79 characters)
plone/app/z3cform/tests/test_widgets.py:977:55: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:984:80: E501 line too long (82 > 79 characters)
plone/app/z3cform/tests/test_widgets.py:1003:80: E501 line too long (81 > 79 characters)
plone/app/z3cform/tests/test_widgets.py:1026:80: E501 line too long (82 > 79 characters)
plone/app/z3cform/tests/test_widgets.py:1091:40: Q000 Remove bad quotes.
plone/app/z3cform/tests/test_widgets.py:1122:14: D001 found assertEquals( replace it with assertEqual
plone/app/z3cform/tests/test_widgets.py:1130:39: Q000 Remove bad quotes.
plone/app/z3cform/tests/tests.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/tests/tests.py:8:1: I003 isort expected 1 blank line in imports, found 0
plone/app/z3cform/tests/tests.py:45:10: C812 missing trailing comma
plone/app/z3cform/wysiwyg/__init__.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/wysiwyg/__init__.py:2:1: F401 'plone.app.z3cform.wysiwyg.widget.WysiwygFieldWidget' imported but unused
plone/app/z3cform/wysiwyg/widget.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/wysiwyg/widget.py:1:1: I003 isort expected 1 blank line in imports, found 0
plone/app/z3cform/wysiwyg/widget.py:4:1: I001 isort found an import in the wrong position
plone/app/z3cform/wysiwyg/widget.py:5:1: I004 isort found an unexpected blank line in imports
plone/app/z3cform/wysiwyg/widget.py:6:1: I001 isort found an import in the wrong position
plone/app/z3cform/wysiwyg/widget.py:7:1: I001 isort found an import in the wrong position
plone/app/z3cform/wysiwyg/widget.py:8:1: I001 isort found an import in the wrong position
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.browserlayer/25/violations
```
plone/browserlayer/__init__.py:0:1: C101 Coding magic comment not found
plone/browserlayer/exportimport.py:96:21: Q000 Remove bad quotes.
plone/browserlayer/exportimport.py:102:20: S001 found module formatter
plone/browserlayer/exportimport.py:115:21: Q000 Remove bad quotes.
plone/browserlayer/exportimport.py:121:20: S001 found module formatter
plone/browserlayer/layer.py:12:31: Q000 Remove bad quotes.
plone/browserlayer/layer.py:29:5: D001 found directlyProvides( replace it with zope.interface.provider
plone/browserlayer/testing.py:20:10: Q000 Remove bad quotes.
plone/browserlayer/testing.py:20:40: C812 missing trailing comma
plone/browserlayer/utils.py:37:24: Q000 Remove bad quotes.
plone/browserlayer/utils.py:37:24: S001 found module formatter
plone/browserlayer/tests/test_doctest.py:30:55: C812 missing trailing comma
plone/browserlayer/tests/test_doctest.py:31:10: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.z3cform/151/violations
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/app/__init__.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/inline_validation.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/inline_validation.py:14:5: C901 'InlineValidationView.__call__' is too complex (12)
plone/app/z3cform/inline_validation.py:23:12: P002 found "hasattr", consider replacing it
plone/app/z3cform/inline_validation.py:25:16: P002 found "hasattr", consider replacing it
plone/app/z3cform/inline_validation.py:29:26: Q000 Remove bad quotes.
plone/app/z3cform/inline_validation.py:34:9: E265 block comment should start with '# '
plone/app/z3cform/inline_validation.py:41:17: E731 do not assign a lambda expression, use a def
plone/app/z3cform/widget.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/widget.py:1:48: T000 Todo note found.
plone/app/z3cform/widget.py:2:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:2:52: T000 Todo note found.
plone/app/z3cform/widget.py:5:1: I001 isort found an import in the wrong position
plone/app/z3cform/csrf.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/csrf.py:15:5: D001 found adapts( replace it with zope.component.adapter
plone/app/z3cform/layout.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/layout.py:2:1: F401 'plone.z3cform.layout.FormWrapper' imported but unused
plone/app/z3cform/layout.py:2:1: F401 'plone.z3cform.layout.wrap_form' imported but unused
plone/app/z3cform/layout.py:2:1: I001 isort found an import in the wrong position
plone/app/z3cform/interfaces.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/templates.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/templates.py:13:1: E731 do not assign a lambda expression, use a def
plone/app/z3cform/templates.py:16:6: C812 missing trailing comma
plone/app/z3cform/utils.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/utils.py:5:1: I003 isort expected 1 blank line in imports, found 0
plone/app/z3cform/utils.py:5:1: I003 isort expected 1 blank line in imports, found 0
plone/app/z3cform/object.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/object.py:3:1: I001 isort found an import in the wrong position
plone/app/z3cform/wysiwyg/widget.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/wysiwyg/widget.py:1:1: I003 isort expected 1 blank line in imports, found 0
plone/app/z3cform/wysiwyg/widget.py:4:1: I001 isort found an import in the wrong position
plone/app/z3cform/wysiwyg/widget.py:5:1: I004 isort found an unexpected blank line in imports
plone/app/z3cform/wysiwyg/widget.py:6:1: I001 isort found an import in the wrong position
plone/app/z3cform/wysiwyg/widget.py:7:1: I001 isort found an import in the wrong position
plone/app/z3cform/wysiwyg/widget.py:8:1: I001 isort found an import in the wrong position
plone/app/z3cform/wysiwyg/__init__.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/wysiwyg/__init__.py:2:1: F401 'plone.app.z3cform.wysiwyg.widget.WysiwygFieldWidget' imported but unused
plone/app/z3cform/queryselect/__init__.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/queryselect/__init__.py:3:1: I003 isort expected 1 blank line in imports, found 0
plone/app/z3cform/queryselect/__init__.py:10:15: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/queryselect/__init__.py:48:24: C812 missing trailing comma
plone/app/z3cform/queryselect/__init__.py:53:15: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/queryselect/__init__.py:61:19: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/tests/tests.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/tests/tests.py:8:1: I003 isort expected 1 blank line in imports, found 0
plone/app/z3cform/tests/tests.py:45:10: C812 missing trailing comma
plone/app/z3cform/tests/test_csrf.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/tests/example.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/tests/example.py:2:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/example.py:5:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/example.py:11:28: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:16:16: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:20:5: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/tests/example.py:25:13: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:38:34: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:49:13: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:64:30: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:65:55: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:66:52: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:71:13: Q000 Remove bad quotes.
plone/app/z3cform/tests/test_objectsubform.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/tests/test_objectsubform.py:2:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/test_objectsubform.py:6:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/test_objectsubform.py:8:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/test_objectsubform.py:18:15: Q000 Remove bad quotes.
plone/app/z3cform/tests/test_objectsubform.py:18:33: C812 missing trailing comma
plone/app/z3cform/tests/test_objectsubform.py:23:15: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/tests/test_objectsubform.py:34:16: S001 found module formatter
plone/app/z3cform/tests/test_objectsubform.py:43:15: Q000 Remove bad quotes.
plone/app/z3cform/tests/test_objectsubform.py:46:19: Q000 Remove bad quotes.
plone/app/z3cform/tests/test_objectsubform.py:47:30: C812 missing trailing comma
plone/app/z3cform/tests/test_objectsubform.py:48:10: C812 missing trailing comma
plone/app/z3cform/tests/test_objectsubform.py:54:13: Q000 Remove bad quotes.
plone/app/z3cform/tests/test_objectsubform.py:59:15: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/tests/test_objectsubform.py:107:24: C812 missing trailing comma
plone/app/z3cform/tests/test_objectsubform.py:114:11: T000 Todo note found.
plone/app/z3cform/tests/test_objectsubform.py:130:19: C812 missing trailing comma
plone/app/z3cform/tests/test_widget.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/tests/test_widget.py:11:15: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/tests/test_widget.py:32:80: E501 line too long (126 > 79 characters)
plone/app/z3cform/tests/layer.py:0:1: C101 Coding magic comment not found
plone/app/z3cform/tests/layer.py:1:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/layer.py:33:10: Q000 Remove bad quotes.
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@jensens Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.z3cform/154/violations
```
plone/app/z3cform/converters.py:106:11: T000 Todo note found.
plone/app/z3cform/inline_validation.py:15:5: C901 'InlineValidationView.__call__' is too complex (15)
plone/app/z3cform/widget.py:5:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:667:19: T000 Todo note found.
plone/app/z3cform/widget.py:681:47: T000 Todo note found.
plone/app/z3cform/tests/test_widgets.py:6:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/test_widgets.py:161:50: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:171:60: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:172:18: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Successfully aliased the URL <https://overreactedio-cgsq6cen8.now.sh> to the following alias.

* https://overreacted.io


@ale-rt Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.z3cform/157/violations
```
plone/app/z3cform/inline_validation.py:15:5: C901 'InlineValidationView.__call__' is too complex (15)
plone/app/z3cform/widget.py:8:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:18:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:150:20: C812 missing trailing comma
plone/app/z3cform/widget.py:357:26: C812 missing trailing comma
plone/app/z3cform/widget.py:460:36: C812 missing trailing comma
plone/app/z3cform/widget.py:471:26: C812 missing trailing comma
plone/app/z3cform/widget.py:570:29: C812 missing trailing comma
plone/app/z3cform/widget.py:572:36: C812 missing trailing comma
plone/app/z3cform/widget.py:603:47: C812 missing trailing comma
plone/app/z3cform/widget.py:607:19: T000 Todo note found.
plone/app/z3cform/widget.py:621:47: T000 Todo note found.
plone/app/z3cform/widget.py:625:66: C812 missing trailing comma
plone/app/z3cform/widget.py:626:30: C812 missing trailing comma
plone/app/z3cform/widget.py:627:26: C812 missing trailing comma
plone/app/z3cform/widget.py:628:22: C812 missing trailing comma
plone/app/z3cform/widget.py:643:46: C812 missing trailing comma
plone/app/z3cform/interfaces.py:4:1: I001 isort found an import in the wrong position
plone/app/z3cform/templates.py:18:17: C812 missing trailing comma
plone/app/z3cform/templates.py:24:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/z3cform/object.py:7:49: C812 missing trailing comma
plone/app/z3cform/converters.py:100:11: T000 Todo note found.
plone/app/z3cform/wysiwyg/widget.py:50:27: C812 missing trailing comma
plone/app/z3cform/tests/tests.py:47:10: C812 missing trailing comma
plone/app/z3cform/tests/example.py:26:5: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/tests/example.py:31:13: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:44:34: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:55:13: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:70:30: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:71:55: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:72:52: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:77:13: Q000 Remove bad quotes.
plone/app/z3cform/tests/test_objectsubform.py:21:15: Q000 Remove bad quotes.
plone/app/z3cform/tests/test_objectsubform.py:21:33: C812 missing trailing comma
plone/app/z3cform/tests/test_objectsubform.py:26:15: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/tests/test_objectsubform.py:46:15: Q000 Remove bad quotes.
plone/app/z3cform/tests/test_objectsubform.py:49:19: Q000 Remove bad quotes.
plone/app/z3cform/tests/test_objectsubform.py:50:30: C812 missing trailing comma
plone/app/z3cform/tests/test_objectsubform.py:51:10: C812 missing trailing comma
plone/app/z3cform/tests/test_objectsubform.py:57:13: Q000 Remove bad quotes.
plone/app/z3cform/tests/test_objectsubform.py:62:15: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/tests/test_objectsubform.py:110:24: C812 missing trailing comma
plone/app/z3cform/tests/test_objectsubform.py:117:11: T000 Todo note found.
plone/app/z3cform/tests/test_objectsubform.py:133:19: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:7:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/test_widgets.py:39:5: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/tests/test_widgets.py:79:38: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:142:56: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:144:34: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:145:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:205:37: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:236:56: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:242:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:243:22: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:244:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:385:43: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:399:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:400:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:417:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:418:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:435:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:436:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:455:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:456:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:474:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:475:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:487:62: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:501:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:502:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:513:62: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:527:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:528:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:540:62: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:554:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:555:18: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:565:43: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:608:52: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:613:36: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:686:32: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:698:37: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:700:14: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:713:37: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:715:14: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:812:75: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:958:32: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:973:24: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1005:50: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1009:60: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1013:55: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1017:59: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1035:46: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1038:19: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1046:24: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1070:74: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1076:50: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1080:60: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1084:55: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1088:59: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1106:46: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1109:19: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1140:51: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1168:30: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1193:39: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:1263:40: Q000 Remove bad quotes.
plone/app/z3cform/tests/test_widgets.py:1282:25: C812 missing trailing comma
plone/app/z3cform/tests/test_widget.py:12:15: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/tests/layer.py:34:41: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@thet Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.z3cform/158/violations
```
plone/app/z3cform/converters.py:113:11: T000 Todo note found.
plone/app/z3cform/inline_validation.py:15:5: C901 'InlineValidationView.__call__' is too complex (15)
plone/app/z3cform/widget.py:5:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:45:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:70:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:167:36: C812 missing trailing comma
plone/app/z3cform/widget.py:703:19: T000 Todo note found.
plone/app/z3cform/widget.py:717:47: T000 Todo note found.
plone/app/z3cform/widget.py:917:1: W391 blank line at end of file
plone/app/z3cform/tests/test_widgets.py:6:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/test_widgets.py:160:50: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:170:60: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:171:18: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.z3cform/160/violations
```
plone/app/z3cform/converters.py:106:11: T000 Todo note found.
plone/app/z3cform/inline_validation.py:15:5: C901 'InlineValidationView.__call__' is too complex (15)
plone/app/z3cform/widget.py:5:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:45:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:70:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:702:19: T000 Todo note found.
plone/app/z3cform/widget.py:716:47: T000 Todo note found.
plone/app/z3cform/tests/test_widgets.py:6:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/test_widgets.py:160:50: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:170:60: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:171:18: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.intelligenttext/30/violations
```
plone/intelligenttext/tests.py:4:1: I003 isort expected 1 blank line in imports, found 0
plone/intelligenttext/tests.py:11:5: T003 print function found.
plone/intelligenttext/tests.py:21:10: C812 missing trailing comma
plone/intelligenttext/transforms.py:4:1: I003 isort expected 1 blank line in imports, found 0
plone/intelligenttext/transforms.py:22:9: P103 other string does contain unindexed parameters
plone/intelligenttext/transforms.py:22:80: E501 line too long (278 > 79 characters)
plone/intelligenttext/transforms.py:23:27: C812 missing trailing comma
plone/intelligenttext/transforms.py:27:27: C812 missing trailing comma
plone/intelligenttext/transforms.py:64:45: Q000 Remove bad quotes.
plone/intelligenttext/transforms.py:69:20: Q000 Remove bad quotes.
plone/intelligenttext/transforms.py:70:32: Q000 Remove bad quotes.
plone/intelligenttext/transforms.py:74:26: Q000 Remove bad quotes.
plone/intelligenttext/transforms.py:80:37: Q000 Remove bad quotes.
plone/intelligenttext/transforms.py:80:54: Q000 Remove bad quotes.
plone/intelligenttext/transforms.py:91:11: T000 Todo note found.
plone/intelligenttext/transforms.py:102:16: S001 found module formatter
plone/intelligenttext/transforms.py:112:16: S001 found module formatter
plone/intelligenttext/transforms.py:155:18: S001 found module formatter
plone/intelligenttext/transforms.py:181:44: C812 missing trailing comma
plone/intelligenttext/transforms.py:184:7: T000 Todo note found.
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Just curious: why did you end up switching from ALE to LanguageClient-neovim for LSP support?


I haven't found it in debian nor ubuntu packages...

BTW, PR welcome to update this list (IMHO, only official repositories, e.g; mine not listed)


Ok, thanks for the explanation.


Hells to the yes 40b2b37


Doesn't this need to be locked if we're going to use the global list directly?


@mikedoan Thank you for raising this. If you're willing, I would love to gather feedback on this usage over at https://travis-ci.community/t/compatibility-with-gopath-and-modules-go-mod-present/2156.


Still, can't use *. reserved.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.schemaeditor/63/violations
```
plone/schemaeditor/testing.py:26:22: C812 missing trailing comma
plone/schemaeditor/interfaces.py:33:26: C812 missing trailing comma
plone/schemaeditor/interfaces.py:48:76: C812 missing trailing comma
plone/schemaeditor/interfaces.py:52:38: C812 missing trailing comma
plone/schemaeditor/interfaces.py:59:30: C812 missing trailing comma
plone/schemaeditor/interfaces.py:68:22: C812 missing trailing comma
plone/schemaeditor/interfaces.py:150:33: C812 missing trailing comma
plone/schemaeditor/interfaces.py:162:22: C812 missing trailing comma
plone/schemaeditor/interfaces.py:175:23: C812 missing trailing comma
plone/schemaeditor/interfaces.py:190:69: C812 missing trailing comma
plone/schemaeditor/interfaces.py:202:80: C812 missing trailing comma
plone/schemaeditor/interfaces.py:207:72: C812 missing trailing comma
plone/schemaeditor/interfaces.py:215:22: C812 missing trailing comma
plone/schemaeditor/interfaces.py:227:23: C812 missing trailing comma
plone/schemaeditor/utils.py:84:9: T000 Todo note found.
plone/schemaeditor/utils.py:100:18: C812 missing trailing comma
plone/schemaeditor/utils.py:104:12: P002 found "hasattr", consider replacing it
plone/schemaeditor/utils.py:115:16: P002 found "hasattr", consider replacing it
plone/schemaeditor/utils.py:125:18: C812 missing trailing comma
plone/schemaeditor/utils.py:149:26: C812 missing trailing comma
plone/schemaeditor/fields.py:71:58: C812 missing trailing comma
plone/schemaeditor/fields.py:72:14: C812 missing trailing comma
plone/schemaeditor/fields.py:130:9: E303 too many blank lines (2)
plone/schemaeditor/fields.py:227:35: C812 missing trailing comma
plone/schemaeditor/fields.py:228:20: C812 missing trailing comma
plone/schemaeditor/browser/field/fieldset.py:4:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/edit.py:28:1: I004 isort found an unexpected blank line in imports
plone/schemaeditor/browser/field/edit.py:179:12: P002 found "hasattr", consider replacing it
plone/schemaeditor/browser/field/edit.py:187:42: C812 missing trailing comma
plone/schemaeditor/browser/schema/add_field.py:79:76: C812 missing trailing comma
plone/schemaeditor/browser/schema/add_field.py:80:18: C812 missing trailing comma
plone/schemaeditor/browser/schema/add_field.py:112:41: C812 missing trailing comma
plone/schemaeditor/browser/schema/listing.py:55:16: P002 found "hasattr", consider replacing it
plone/schemaeditor/browser/schema/listing.py:109:79: C812 missing trailing comma
plone/schemaeditor/browser/schema/add_fieldset.py:34:79: C812 missing trailing comma
plone/schemaeditor/browser/schema/add_fieldset.py:38:33: C812 missing trailing comma
plone/schemaeditor/browser/schema/add_fieldset.py:54:41: C812 missing trailing comma
plone/schemaeditor/browser/schema/traversal.py:9:1: F401 'six' imported but unused
plone/schemaeditor/browser/schema/traversal.py:45:21: C812 missing trailing comma
plone/schemaeditor/tests/tests.py:8:1: I001 isort found an import in the wrong position
plone/schemaeditor/tests/tests.py:42:80: E501 line too long (88 > 79 characters)
plone/schemaeditor/tests/test_fields.py:27:19: C812 missing trailing comma
plone/schemaeditor/tests/test_fields.py:35:45: C812 missing trailing comma
plone/schemaeditor/tests/test_fields.py:40:48: C812 missing trailing comma
plone/schemaeditor/tests/test_fields.py:48:44: C812 missing trailing comma
plone/schemaeditor/tests/test_fields.py:53:47: C812 missing trailing comma
plone/schemaeditor/tests/test_robot.py:26:33: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Collaborator: Review for this commit was created. [Link to review](http://217.170.125.19:40101/ui#review:id=6)


@lrowe Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.subrequest/39/violations
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/subrequest/tests.py:0:1: C101 Coding magic comment not found
plone/subrequest/tests.py:1:1: I003 isort expected 1 blank line in imports, found 0
plone/subrequest/tests.py:6:1: I001 isort found an import in the wrong position
plone/subrequest/tests.py:7:1: I001 isort found an import in the wrong position
plone/subrequest/tests.py:8:1: I001 isort found an import in the wrong position
plone/subrequest/tests.py:9:1: I001 isort found an import in the wrong position
plone/subrequest/tests.py:10:1: I001 isort found an import in the wrong position
plone/subrequest/tests.py:12:1: E302 expected 2 blank lines, found 1
plone/subrequest/tests.py:14:5: F841 local variable 'traversed' is assigned to but never used
plone/subrequest/tests.py:33:15: Q000 Remove bad quotes.
plone/subrequest/tests.py:33:15: S001 found module formatter
plone/subrequest/tests.py:33:80: E501 line too long (126 > 79 characters)
plone/subrequest/tests.py:34:22: S001 found module formatter
plone/subrequest/tests.py:41:15: Q000 Remove bad quotes.
plone/subrequest/tests.py:41:15: S001 found module formatter
plone/subrequest/tests.py:41:80: E501 line too long (126 > 79 characters)
plone/subrequest/tests.py:42:22: S001 found module formatter
plone/subrequest/tests.py:49:15: Q000 Remove bad quotes.
plone/subrequest/tests.py:49:15: S001 found module formatter
plone/subrequest/tests.py:49:80: E501 line too long (126 > 79 characters)
plone/subrequest/tests.py:50:22: S001 found module formatter
plone/subrequest/tests.py:76:15: Q000 Remove bad quotes.
plone/subrequest/tests.py:76:15: S001 found module formatter
plone/subrequest/tests.py:76:80: E501 line too long (137 > 79 characters)
plone/subrequest/tests.py:78:80: E501 line too long (89 > 79 characters)
plone/subrequest/tests.py:81:15: Q000 Remove bad quotes.
plone/subrequest/tests.py:81:15: S001 found module formatter
plone/subrequest/tests.py:81:80: E501 line too long (138 > 79 characters)
plone/subrequest/tests.py:83:80: E501 line too long (89 > 79 characters)
plone/subrequest/tests.py:86:15: Q000 Remove bad quotes.
plone/subrequest/tests.py:86:15: S001 found module formatter
plone/subrequest/tests.py:86:80: E501 line too long (150 > 79 characters)
plone/subrequest/tests.py:88:80: E501 line too long (89 > 79 characters)
plone/subrequest/tests.py:96:15: Q000 Remove bad quotes.
plone/subrequest/tests.py:96:15: S001 found module formatter
plone/subrequest/tests.py:96:80: E501 line too long (113 > 79 characters)
plone/subrequest/tests.py:99:80: E501 line too long (89 > 79 characters)
plone/subrequest/tests.py:103:15: Q000 Remove bad quotes.
plone/subrequest/tests.py:103:15: S001 found module formatter
plone/subrequest/tests.py:103:80: E501 line too long (113 > 79 characters)
plone/subrequest/tests.py:107:80: E501 line too long (99 > 79 characters)
plone/subrequest/tests.py:111:15: Q000 Remove bad quotes.
plone/subrequest/tests.py:111:15: S001 found module formatter
plone/subrequest/tests.py:111:80: E501 line too long (82 > 79 characters)
plone/subrequest/tests.py:120:80: E501 line too long (83 > 79 characters)
plone/subrequest/tests.py:123:9: F841 local variable 'app' is assigned to but never used
plone/subrequest/tests.py:145:46: Q000 Remove bad quotes.
plone/subrequest/tests.py:155:46: Q000 Remove bad quotes.
plone/subrequest/tests.py:165:46: Q000 Remove bad quotes.
plone/subrequest/tests.py:182:80: E501 line too long (109 > 79 characters)
plone/subrequest/testing.py:0:1: C101 Coding magic comment not found
plone/subrequest/testing.py:1:1: F401 'OFS.Folder' imported but unused
plone/subrequest/testing.py:1:1: I001 isort found an import in the wrong position
plone/subrequest/testing.py:2:1: I001 isort found an import in the wrong position
plone/subrequest/testing.py:5:1: I001 isort found an import in the wrong position
plone/subrequest/testing.py:6:1: F401 'zope.globalrequest.getRequest' imported but unused
plone/subrequest/testing.py:6:1: I001 isort found an import in the wrong position
plone/subrequest/testing.py:7:1: I003 isort expected 1 blank line in imports, found 0
plone/subrequest/testing.py:23:9: F841 local variable 'response' is assigned to but never used
plone/subrequest/testing.py:49:16: S001 found module formatter
plone/subrequest/testing.py:85:25: Q000 Remove bad quotes.
plone/subrequest/testing.py:86:17: Q000 Remove bad quotes.
plone/subrequest/testing.py:94:1: E302 expected 2 blank lines, found 1
plone/subrequest/testing.py:100:80: E501 line too long (97 > 79 characters)
plone/subrequest/testing.py:104:80: E501 line too long (112 > 79 characters)
plone/subrequest/testing.py:109:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/subrequest/testing.py:114:80: E501 line too long (81 > 79 characters)
plone/subrequest/testing.py:152:80: E501 line too long (116 > 79 characters)
plone/subrequest/testing.py:152:87: Q000 Remove bad quotes.
plone/subrequest/testing.py:153:80: E501 line too long (110 > 79 characters)
plone/subrequest/testing.py:153:82: Q000 Remove bad quotes.
plone/subrequest/testing.py:154:1: W391 blank line at end of file
plone/subrequest/interfaces.py:0:1: C101 Coding magic comment not found
plone/subrequest/interfaces.py:2:1: I003 isort expected 1 blank line in imports, found 0
plone/subrequest/interfaces.py:3:1: E302 expected 2 blank lines, found 1
plone/subrequest/__init__.py:0:1: C101 Coding magic comment not found
plone/subrequest/__init__.py:1:1: I003 isort expected 1 blank line in imports, found 0
plone/subrequest/__init__.py:3:1: I001 isort found an import in the wrong position
plone/subrequest/__init__.py:4:1: I003 isort expected 1 blank line in imports, found 0
plone/subrequest/__init__.py:10:1: I001 isort found an import in the wrong position
plone/subrequest/__init__.py:11:1: I001 isort found an import in the wrong position
plone/subrequest/__init__.py:12:1: I001 isort found an import in the wrong position
plone/subrequest/__init__.py:13:1: I001 isort found an import in the wrong position
plone/subrequest/__init__.py:14:1: I001 isort found an import in the wrong position
plone/subrequest/__init__.py:15:1: I001 isort found an import in the wrong position
plone/subrequest/__init__.py:16:1: I001 isort found an import in the wrong position
plone/subrequest/__init__.py:17:1: I001 isort found an import in the wrong position
plone/subrequest/__init__.py:17:27: E261 at least two spaces before inline comment
plone/subrequest/__init__.py:18:1: I001 isort found an import in the wrong position
plone/subrequest/__init__.py:19:1: I001 isort found an import in the wrong position
plone/subrequest/__init__.py:25:1: I001 isort found an import in the wrong position
plone/subrequest/__init__.py:26:1: I001 isort found an import in the wrong position
plone/subrequest/__init__.py:37:18: E261 at least two spaces before inline comment
plone/subrequest/__init__.py:59:20: Q000 Remove bad quotes.
plone/subrequest/__init__.py:61:1: E302 expected 2 blank lines, found 1
plone/subrequest/__init__.py:61:1: C901 'subrequest' is too complex (11)
plone/subrequest/__init__.py:62:29: Q000 Remove bad quotes.
plone/subrequest/__init__.py:67:40: Q000 Remove bad quotes.
plone/subrequest/__init__.py:67:80: E501 line too long (109 > 79 characters)
plone/subrequest/__init__.py:80:24: S001 found module formatter
plone/subrequest/__init__.py:82:20: S001 found module formatter
plone/subrequest/__init__.py:97:80: E501 line too long (87 > 79 characters)
plone/subrequest/__init__.py:112:31: E261 at least two spaces before inline comment
plone/subrequest/__init__.py:114:32: E261 at least two spaces before inline comment
plone/subrequest/__init__.py:137:9: B901 blind except: statement
plone/subrequest/__init__.py:138:30: Q000 Remove bad quotes.
plone/subrequest/__init__.py:138:30: S001 found module formatter
plone/subrequest/subresponse.py:0:1: C101 Coding magic comment not found
plone/subrequest/subresponse.py:3:1: I003 isort expected 1 blank line in imports, found 0
plone/subrequest/subresponse.py:3:1: I003 isort expected 1 blank line in imports, found 0
plone/subrequest/subresponse.py:9:1: E302 expected 2 blank lines, found 1
plone/subrequest/subresponse.py:17:29: E261 at least two spaces before inline comment
plone/subrequest/subresponse.py:18:12: P002 found "hasattr", consider replacing it
plone/subrequest/subresponse.py:18:80: E501 line too long (86 > 79 characters)
plone/subrequest/subresponse.py:44:16: P002 found "hasattr", consider replacing it
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@pbauer Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.subrequest/41/violations
```
plone/subrequest/__init__.py:25:1: I003 isort expected 1 blank line in imports, found 0
plone/subrequest/__init__.py:78:1: C901 'subrequest' is too complex (12)
plone/subrequest/__init__.py:96:44: C812 missing trailing comma
plone/subrequest/__init__.py:104:25: C812 missing trailing comma
plone/subrequest/__init__.py:160:23: C812 missing trailing comma
plone/subrequest/subresponse.py:22:12: P002 found "hasattr", consider replacing it
plone/subrequest/subresponse.py:23:16: P002 found "hasattr", consider replacing it
plone/subrequest/subresponse.py:24:12: P002 found "hasattr", consider replacing it
plone/subrequest/subresponse.py:50:16: P002 found "hasattr", consider replacing it
plone/subrequest/testing.py:19:16: Q000 Remove bad quotes.
plone/subrequest/testing.py:125:42: C812 missing trailing comma
plone/subrequest/testing.py:131:45: C812 missing trailing comma
plone/subrequest/testing.py:137:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/subrequest/testing.py:184:39: C812 missing trailing comma
plone/subrequest/testing.py:188:38: C812 missing trailing comma
plone/subrequest/tests.py:72:36: C812 missing trailing comma
plone/subrequest/tests.py:79:45: C812 missing trailing comma
plone/subrequest/tests.py:87:45: C812 missing trailing comma
plone/subrequest/tests.py:94:34: C812 missing trailing comma
plone/subrequest/tests.py:102:61: C812 missing trailing comma
plone/subrequest/tests.py:110:61: C812 missing trailing comma
plone/subrequest/tests.py:118:61: C812 missing trailing comma
plone/subrequest/tests.py:132:61: C812 missing trailing comma
plone/subrequest/tests.py:143:71: C812 missing trailing comma
plone/subrequest/tests.py:157:42: C812 missing trailing comma
plone/subrequest/tests.py:169:61: C812 missing trailing comma
plone/subrequest/tests.py:181:61: C812 missing trailing comma
plone/subrequest/tests.py:194:55: C812 missing trailing comma
plone/subrequest/tests.py:202:55: C812 missing trailing comma
plone/subrequest/tests.py:273:61: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@pbauer Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.subrequest/40/violations
```
plone/subrequest/__init__.py:74:1: C901 'subrequest' is too complex (12)
plone/subrequest/__init__.py:92:44: C812 missing trailing comma
plone/subrequest/__init__.py:100:25: C812 missing trailing comma
plone/subrequest/__init__.py:156:23: C812 missing trailing comma
plone/subrequest/subresponse.py:22:12: P002 found "hasattr", consider replacing it
plone/subrequest/subresponse.py:23:16: P002 found "hasattr", consider replacing it
plone/subrequest/subresponse.py:24:12: P002 found "hasattr", consider replacing it
plone/subrequest/subresponse.py:50:16: P002 found "hasattr", consider replacing it
plone/subrequest/testing.py:19:16: Q000 Remove bad quotes.
plone/subrequest/testing.py:125:42: C812 missing trailing comma
plone/subrequest/testing.py:131:45: C812 missing trailing comma
plone/subrequest/testing.py:137:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/subrequest/testing.py:184:39: C812 missing trailing comma
plone/subrequest/testing.py:188:38: C812 missing trailing comma
plone/subrequest/tests.py:72:36: C812 missing trailing comma
plone/subrequest/tests.py:79:45: C812 missing trailing comma
plone/subrequest/tests.py:87:45: C812 missing trailing comma
plone/subrequest/tests.py:94:34: C812 missing trailing comma
plone/subrequest/tests.py:102:61: C812 missing trailing comma
plone/subrequest/tests.py:110:61: C812 missing trailing comma
plone/subrequest/tests.py:118:61: C812 missing trailing comma
plone/subrequest/tests.py:132:61: C812 missing trailing comma
plone/subrequest/tests.py:143:71: C812 missing trailing comma
plone/subrequest/tests.py:157:42: C812 missing trailing comma
plone/subrequest/tests.py:169:61: C812 missing trailing comma
plone/subrequest/tests.py:181:61: C812 missing trailing comma
plone/subrequest/tests.py:194:55: C812 missing trailing comma
plone/subrequest/tests.py:202:55: C812 missing trailing comma
plone/subrequest/tests.py:273:61: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.subrequest/42/violations
```
plone/subrequest/__init__.py:79:1: C901 'subrequest' is too complex (12)
plone/subrequest/__init__.py:97:44: C812 missing trailing comma
plone/subrequest/__init__.py:105:25: C812 missing trailing comma
plone/subrequest/__init__.py:116:63: C812 missing trailing comma
plone/subrequest/__init__.py:163:23: C812 missing trailing comma
plone/subrequest/subresponse.py:25:12: P002 found "hasattr", consider replacing it
plone/subrequest/subresponse.py:26:16: P002 found "hasattr", consider replacing it
plone/subrequest/subresponse.py:27:12: P002 found "hasattr", consider replacing it
plone/subrequest/subresponse.py:60:16: P002 found "hasattr", consider replacing it
plone/subrequest/testing.py:11:1: F401 'six' imported but unused
plone/subrequest/testing.py:21:16: Q000 Remove bad quotes.
plone/subrequest/testing.py:125:42: C812 missing trailing comma
plone/subrequest/testing.py:131:45: C812 missing trailing comma
plone/subrequest/testing.py:137:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/subrequest/testing.py:184:39: C812 missing trailing comma
plone/subrequest/testing.py:188:38: C812 missing trailing comma
plone/subrequest/tests.py:12:1: I004 isort found an unexpected blank line in imports
plone/subrequest/tests.py:13:1: I001 isort found an import in the wrong position
plone/subrequest/tests.py:28:5: F401 'plone.app.blob.iterators.BlobStreamIterator' imported but unused
plone/subrequest/tests.py:92:37: C812 missing trailing comma
plone/subrequest/tests.py:99:46: C812 missing trailing comma
plone/subrequest/tests.py:107:46: C812 missing trailing comma
plone/subrequest/tests.py:114:35: C812 missing trailing comma
plone/subrequest/tests.py:122:57: C812 missing trailing comma
plone/subrequest/tests.py:130:57: C812 missing trailing comma
plone/subrequest/tests.py:138:57: C812 missing trailing comma
plone/subrequest/tests.py:152:57: C812 missing trailing comma
plone/subrequest/tests.py:163:67: C812 missing trailing comma
plone/subrequest/tests.py:177:38: C812 missing trailing comma
plone/subrequest/tests.py:189:57: C812 missing trailing comma
plone/subrequest/tests.py:201:57: C812 missing trailing comma
plone/subrequest/tests.py:214:51: C812 missing trailing comma
plone/subrequest/tests.py:222:56: C812 missing trailing comma
plone/subrequest/tests.py:301:61: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


👏 👏 thanks


[R/create_mbd_params.R:17:3:](https://github.com/richelbilderbeek/becosys/blob/1a16c97a4615a685249742a08c6fa79d6eb229de/R/create_mbd_params.R#L17) *warning:* **no visible global function definition for ‘check_mbd_params’**
```r
  check_mbd_params(mbd_params)
  ^~~~~~~~~~~~~~~~
```


Добрый день.
Соглашусь с вами по-поводу макросов. Я бы тоже их избегал, но не в ущерб производительности.

По-поводу уровня логирования ...
Я не говорю, что нужно уметь управлять уровнем логирования и уж тем более не возлагаю на вашу обертку такие функции. Проблема в другом ... извините, что повторяюсь ... я не зануда ;)
Если использовать штатные средства log4cplus (или других логеров, например бустовского), то если выключен какой-то уровень логирования или скажем выключена какая-то категория логирования (такое тоже возможно), код который готовит данные для логирования и вызывает ваши функции logger::XXX() вообще не будет работать. С вашей оберткой, даже если вы будете внутри logger проверять IsEnabled(level), то внешний код будет работать в любом случае и результат его работы будет выбрасываться.


The question reputation reduction for gray quests was removed in 2.0.1.
"Fixed an issue where high level players were not being properly credited the right amount of faction reputation."

https://wow.gamepedia.com/index.php?title=Thorium_Brotherhood&oldid=1087106

"As of patch 2.0.1 you get 250 Reputation Points for each of these 7 quests at any level. Note that 6 of these 7 quests can be handed in after reaching honored status with the brotherhood ("What the Flux?" has to be completed before reaching honored, this is explained below)"

https://www.wowhead.com/quest=2881/troll-necklace-bounty
https://wowwiki.fandom.com/wiki/Wildhammer_clan?oldid=414467
"Due to the 2.0 patch the repeatable quest gives 25 reputation per turn in (even with level 60)."

https://classicdb.ch/?quest=7489 (Dire Maul quest)

"Actually this yields 500 rep for horde and 2g 48s @lvl70."


А почему `type`? Нужно же название компании производителя


I think you mean email address?


- [Product Backlog](https://github.com/monica-eisinger/Group9Project/blob/master/sprint1/product_backlog.md)


TeamCity Identity and Access Management / Build IdAM [Build 112-r0F91DEC](https://teamcity.nice.org.uk/viewLog.html?buildId=49352&buildTypeId=IdentityandAccessManagement_BuildIdAM) outcome was **FAILURE**
Summary: Infrastructure\TestBase.cs(5,21): error CS0234: The type or namespace name 'Models' does not exist in the namespace 'NICE.Identity' (are you missing an assembly reference?)
IntegrationTests\AuditTests.cs(1,21): error CS0234: The type or namespace nam... Build time: 00:05:06


I think this could just be called playgroundobservation. A bit more concise and the smokefree status is not too relevant here.


what is getRecordObservation?


Why doesn't it validate all collections?


No it creates the training data for all models. See the documentation. In case there is nothing generated for a given model, it means that your pdf has no content or it is not supported by the current model.


so... is this still a thing? orrrr....


what is recordObservation? please use a more self-explanatory name


*Indeed*, good catch.


Successfully aliased the URL <https://portfolio-ij6bznjy9.now.sh> to the following alias.

* https://trev.work


Url


Just because, it took almost 5 minutes on my PC for the Google Earth engine


Thanks a lot! it counts down now,

a last question I would like to use 2 countdown after each other, how do I check this, I can use the Clock because its private, any idea how to do this at best?

thanks for the help!


s/copy/COPY/


Collaborator: Review for this commit was created. [Link to review](http://217.170.125.19:40101/ui#review:id=8)


![](https://github.trello.services/images/mini-trello-icon.png) [Test Github workflow](https://trello.com/c/ihels7gr/4-test-github-workflow)


TeamCity Identity and Access Management / Build IdAM [Build 113-r0F91DEC](https://teamcity.nice.org.uk/viewLog.html?buildId=49354&buildTypeId=IdentityandAccessManagement_BuildIdAM) outcome was **FAILURE**
Summary: Infrastructure\TestBase.cs(5,21): error CS0234: The type or namespace name 'Models' does not exist in the namespace 'NICE.Identity' (are you missing an assembly reference?)
IntegrationTests\AuditTests.cs(1,21): error CS0234: The type or namespace nam... Build time: 00:04:52


develop (Myoldmopar) - i386-Windows-7-VisualStudio-14: OK (2443 of 2443 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


Usually this runs in a virtual machine (Travis CI) so shouldn't be a problem and for full validation it seems reasonable to check them all. So maybe there should be an command line option to switch between quick and complete validation.


Collaborator: Review for this commit was created. [Link to review](http://217.170.125.19:40101/ui#review:id=9)


test


Successfully aliased the URL <https://og-image-iconless-k63pi4h8e.now.sh> to the following alias.

* https://og-image-iconless.now.sh


develop (Myoldmopar) - x86_64-Linux-Ubuntu-18.04-gcc-7.3: OK (2460 of 2463 tests passed, 0 test warnings)

Failures:

integration Test Summary
 * Passed: 637
 * Timeout: 1

performance Test Summary
 * Passed: 15
 * Timeout: 2

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.png)


new Playground.PlaygroundObservations() -> why not initialise this in the constructor of Playground?


That partial head.html currently doesn't exists :smile:.


![](https://github.trello.services/images/mini-trello-icon.png) [Test github](https://trello.com/c/CwOdq1ZM/3-test-github)


This commit looks so large, because I deleted the old (and-commented out) code in the end of the file. Older code versions (especially the ones before the API changes) are available via the version control and don't need to be inside the main code version.


Why did you create this separate class as opposed to just putting these attributes in the Playground class itself?


Why did you remove all those quotation marks from SelectionTableViewBB.js?


Collaborator: Review for this commit was created. [Link to review](http://217.170.125.19:40101/ui#review:id=10)


Created multidev environment [rescue-x#jan-19](https://dashboard.pantheon.io/sites/c8430b75-4272-4aca-bfcd-206b12279315#jan-19).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://jan-19-rescue-x.pantheonsite.io/)


smokefreeObservationssssssCount vs smokeObservationCount ? Be consistents please. I think the plural form is best here.


Puzzle `666-23eb8556` disappeared from [`shopelectro/management/commands/price.py`](https://github.com/fidals/shopelectro/blob/master/shopelectro/management/commands/price.py), that's why I closed #715. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.


Puzzle `715-4667b26c` discovered in   [`shopelectro/management/commands/price.py`](  https://github.com/fidals/shopelectro/blob/master/shopelectro/management/commands/price.py)   and submitted as #721. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


If `cur_elements` should always equal `prod(dim_elements)`, why not move the line
```Python
cur_elements = int(np.prod(dim_elements))
```
inside the loop (just after `for...`)?


streak is by definition consecutive so should be smokefreeStreak


Puzzle `718-0ce8b03b` discovered in   [`shopelectro/tests/tests_selenium.py`](  https://github.com/fidals/shopelectro/blob/master/shopelectro/tests/tests_selenium.py)   and submitted as #722. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


Well I only call this function to anonymize a **known party**; so in other words, I always call this function and pass a `Party`, so the cast shouldn't be dangerous.


Why is it **citizen**Id and **user**Name?


Successfully aliased the URL <https://yld-storybook-iwwqll37f.now.sh> to the following alias.

* https://yld-storybook.now.sh


он очищает  все  сообщения с другим именем и указанным номером


I agree, and I will.


What happens here is that when the cart is Virtual and has discounts, the discounts are not applied.


เวลาเข้าก็ เช่น localhost:9090/phpmyadmin/ ด้วยล่ะ


why is this commented?


Then I suggest to change the function signature to make this knowledge clear.


why?


.. So for tbc creatures and quests have to be seperated since the it was still degrading on very low level mobs..

Hmmm. Will open a PR in a sec to fix that.


You would need 2 separate instances of the Timer library. Right now everything is T.xxx.

You need to make another copy and have t1 and t2.

// some function or if statement
{
    t1.SetTimer()
    t2.SetTimer()
}

// some other function or if statement
{
    t1.Timer()
    t2.Timer()
}

- Andrew

Sent from my iPhone

> On Feb 6, 2019, at 9:10 AM, BastiaanMDC <notifications@github.com> wrote:
>
> Thanks a lot! it counts down now,
>
> a last question I would like to use 2 countdown after each other, how do I check this, I can use the Clock because its private, any idea how to do this at best?
>
> thanks for the help!
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub, or mute the thread.


Why is the test disabled?


Sorry, that was supposed to be a branch / PR...


Thx =)


pls remove the array


Additionen sind selten. Sobald Sebastian und Andi rückmeldung zum Libfirm-Bug geben, kann ich das schnell ändern. Sollte den Merge aber nicht blockieren.


Вынести `PassengerWagon/CargoWagon` в отдельные файлы
Вынести `PassengerTrain/CargoTrain` в отдельные файлы

При создании поезда сделать выбор типа из меню (1 - грузовой, 2 - пассажирский)
Можно сделать так:

```
# Interface
TRAIN_TYPE_MENU = [
  'Cargo',
  'Passenger'
].freeze

# Controller
def create_train
  @interface.show_limiter
  @interface.show_prompt(Interface::CREATE_TRAIN_MSG)
  train_name = @interface.get_user_input
  @interface.show_prompt(Interface::TRAIN_ID_MSG)
  @interface.show_menu(Interface::TRAIN_TYPES_MENU)
  train_type = Railway::TRAIN_TYPES[@interface.get_user_choice]
  @railway.create_train(train_name, train_type)
  @interface.show_msg(Interface::TRAIN_CREATED_MSG)
  @interface.show_limiter
end

# Railway
TRAIN_TYPES = [CargoTrain, PassengerTrain]

def create_train(id, train_type)
  train = train_type.new(id)
  @trains.push(train)
end
```


Same comment as in https://github.com/openeuropa/drupal-site-template/pull/10


@BarikMorloc Do you enable BetterMiniMap mod? ZiTools BetterMiniMap Addon can't load without it.


That's why i've made a issue request on aurora repo and not on domoticz.. but i referred to this commit.

It's not something for domoticz, but something for aurora ;)


This seems no longer needed


prueb


Put some documentation in the code explaining what these observations actually are and what they are used for


New test added for CarRegNoOK and get/set generated in clsAppointment


I actually didn't know that I could do this! 👍


Hmm... OK. Got it.


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


Because the property parser has a definition cache.  However, this is a moving target, it's quite possible that this merge becomes internal to the property code.


Single command for createTraining Data
Is generareTrainingData .
But it's not giving result. We don't know how to use. Please tell me the
syntax

On 06-Feb-2019 7:38 PM, "Patrice Lopez" <notifications@github.com> wrote:

> No it creates the training data for all models. See the documentation. In
> case there is nothing generated for a given model, it means that your pdf
> has no content or it is not supported by the current model.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/kermitt2/grobid/commit/d5867f7f92506e8bf2ab2e24e0d883c60b089c76#commitcomment-32213970>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AruATN7vxbZ6jbdPLoPOub_ke9gz5Upvks5vKuHLgaJpZM4ak__T>
> .
>


Successfully aliased the URL <https://ohjelmointi-19-krukromvle.now.sh> to the following alias.

* https://ohjelmointi-19.mooc.fi


ok I create an issue


Haha yea. I used to run everything through compose, but I now just run redis and postgres, so I got rid of most of the instructions.


'bindingMode' is not defined in index.d.ts


Successfully aliased the URL <https://strumdog-frontend-maqcdszg5.now.sh> to the following alias.

* https://strum.dog


Already fixed: https://github.com/cmangos/mangos-tbc/commit/cca2dcc0488857f537c16136af29de0d801de085


totally agree with you man, this guy goes to quick and have to keep pausing and rewinding as he does things too quickly


Thank you, sorry for my oversight.


You don't need to explicitly delete it. Just don't declare it.


This apply to the other classes as well.


I don't see the point of extending AbstractFilterableEvent since the EventFilter does not really make much sense for DocumentCopiedEvent. You should just directly implement EndFoldEvent.


FFFFF


this is already handled: https://github.com/pluginsGLPI/formcreator/blob/7f64792564d35d31ac55269b76471b4abf8ce9b4/inc/form.class.php#L1341


Deployed at: https://alva-designkit-commits-4b104.surge.sh


As FMI interface permits to get the variable value, see:
https://doc.froglogic.com/squish/latest/api.fmi.interface.html
I suggest to let the possibility to specify the name of the variable to log also for FMU internal variables.
So not only for input or output variable in the plugin.


That's basically a comment, describing the situation. It's passed form the front-end to back-end via Mutation


I don't like too much having two different event for rename and move since it's actually the same thing from listener point of view: the document reference changed. Makes things more complex IMO.


Just to be sure: here by legacy, you mean it's a legacy behaviour, that should be only triggered if the hierarchyMode is parent-child right? At first sight I wondered why the class wasn't in legacy module...


added in this PR : https://github.com/pluginsGLPI/formcreator/pull/1295/files#diff-99ed7a0fe201cab391776f3fa25f50f5R1311


So is it init_encrypt or encrypt_init...we seem to have both here!!


I agree, a possible idea we can just dump all the variables in the FMU, as this would decrease the complexity in the identification.


That's strange. If you can reproduce that error, I'd be interested to see it.


it looks like you don't verify anymore that copy update links and create redirect by default?


Woof.


Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

- @kiwi0fruit was added to this feedstock maintenance team.

You should get push access to this feedstock and CI services.

Feel free to join the community [chat room](https://gitter.im/conda-forge/conda-forge.github.io).

NOTE: Please make sure to not push to the repository directly.
      Use branches in your fork for any changes and send a PR.
      More details [here](https://conda-forge.org/docs/conda-forge_gotchas.html#using-a-fork-vs-a-branch-when-updating-a-recipe)


@kpu23 empty() includes isset! :)


Move where?

In general, I err on the side of leaving `&` and `*` out until the compiler tells me they're required.


In `openjdk:8u191-jre-alpine` the /opt directory exists. This cause a blocking error on a mkdir command.


I don't know how I feel about references; I think they are evil if they aren't `const &`. In addition, I don't know think the ship should know about the `board` directly. In my opinion, you can use the mediator pattern to solve this problem. Ship is tightly coupled to board. IMO, what you want is an object (a mediator) that knows about both, the current ship and the state of the board and that object will decide if it the ship can move there. The ship should be stupid dumb. If you tell the ship to move, it should move regardless of collision. The mediator will be responsible for making the verification, i.e., if the move is valid or not. In that case, if you unit test your mediator well, then you are 100% sure that the move will be valid.


handled here in 2.7.0 : https://github.com/pluginsGLPI/formcreator/blob/7f64792564d35d31ac55269b76471b4abf8ce9b4/inc/form.class.php#L1359


[R/create_alignment_params.R:44:3:](https://github.com/richelbilderbeek/pirouette/blob/2d8435cb1f114c8421515ac363ec3dc2a68a3e1a/R/create_alignment_params.R#L44) *warning:* **no visible global function definition for ‘create_alignment_params’**
```r
  create_alignment_params(root_sequence = "acgt", mutation_rate = 0.1)
  ^~~~~~~~~~~~~~~~~~~~~~~
```
[R/pir_run.R:147:5:](https://github.com/richelbilderbeek/pirouette/blob/2d8435cb1f114c8421515ac363ec3dc2a68a3e1a/R/pir_run.R#L147) *warning:* **no visible global function definition for ‘check_experiment’**
```r
    check_experiment(experiment)
    ^~~~~~~~~~~~~~~~
```


I recently learned that and I haven't implemented it in my coding yet... `isset()` is so common to me.


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


They could be a lot ... Will it slow the system? Will the user be confused? On the other hand, it could be more easy to configure.


> Thanks your video. It is strange. I cannot reproduce this bug on my Windows 10.
> It would cause by compile corruption, so please rebuild code?

i cant compile code - im noob =)
im here for request new build without this bug.
(im use windows7 x64)


https://github.com/pluginsGLPI/formcreator/blob/7f64792564d35d31ac55269b76471b4abf8ce9b4/inc/section.class.php#L351

needed in 2.7.0.


the repo is still public... FYI


will try tonight


recordObservation  basically holds the comments passed by user during his playground observation.
I believe, just calling it 'comments' can be self-explanatory.

Should I name it 'comment'?


What happens in case the buffer is not empty?


You're right, I need to add something back to validate that the middle token is indeed an operation. Something like:
```rust
        if let Some(Token::OPERATION(_)) = self.current_token.unwrap() {
            self.next_token();
        } else {
            panic("Expected operation token");
        }
```
I just didn't get there yet. I think the validation for the `INT` tokens was redundant, though.


small error here (not by your pr, just noticing because of it), it should read 60 like it does in the actual value.. I thought I corrected this.. https://github.com/cmangos/mangos-classic/pull/123/files <- okay I see I forgot to correct it in the comment section of the config. Perhaps next time the config file is edited. (Think this small mistake is present in tbc config as well)


i already use your db it's show or view just category bro but for food it's
does't show could you suggest to me

ในวันที่ พ. 6 ก.พ. 2019 เวลา 11:33 DAKSH SEMWAL <notifications@github.com>
เขียนว่า:

> @ilyasma5656 <https://github.com/ilyasma5656> use this Eat It Video
> Lecture <https://www.youtube.com/watch?v=Ad41Bh704ms> for further queries
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/DAKSHSEMWAL/Eatit/commit/f34205b7a76d979216185dc7bb2c66fd5106c312#commitcomment-32208087>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AsfTsOWatW8sGfKCDBpLCUbdEHehpu_zks5vKlshgaJpZM4akgjU>
> .
>


I modified the arch file of vtr_reg_qor_chain_depop to assign the pins of the CLB to particular sides rather than using spread:

         <pinlocations pattern="custom">
             <loc side="top">clb.I1 clb.I2 clb.I3 clb.I4 clb.O clb.clk clb.cin clb.cout</loc>
             <loc side="right">clb.I1 clb.I2 clb.I3 clb.I4 clb.O clb.clk clb.cin clb.cout</loc>
         </pinlocations>

On this architecture, the QOR changes are as follows:
vpr.out: FMAX: +2.9%, Wire: -14.5%, Channel Width: -12.3%
vpr.crit_path.out: FMAX: +3.4%, Wire: -15.5%


It's being initialised in the Playground constructor. It's not visible since we are using lombok annotation for constructors, Getters, Setters, etc


May not be relevant to the greater good but I could link this application due to LINK_FLAGS "/SUBSYSTEM:WINDOWS") as their is no WinMain entry point, changing it to. Console subsystem got it linking for me


Because `Token` is `Copy`. We can look at removing that derive and restructuring the code to work with non-Copy types.


I believe this is titled watermark in the agora docs


develop (Myoldmopar) - x86_64-Linux-Ubuntu-18.04-gcc-7.3-UnitTestsCoverage-Debug: OK (1808 of 1808 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-41.6%25-green.png)


Nope it was just my mistake. I will add it back in.


Love the new util function


Successfully aliased the URL <https://web-3tzkuqxxx.now.sh> to the following aliases.

* https://digipiggybank.com
* https://www.digipiggybank.com


https://github.com/pluginsGLPI/formcreator/blob/7f64792564d35d31ac55269b76471b4abf8ce9b4/inc/targetbase.class.php#L1147

handling HTML entities should be useless now : special chars are no longer stored this way


Successfully aliased the URL <https://yld-storybook-oeaohfnse.now.sh> to the following alias.

* https://yld-storybook.now.sh


Better to be set on "Kang" tag


develop (Myoldmopar) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (3 of 3 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


@Shritesh99
why this change was needed?
seems to me does not affect anything
is there some change and design and it looks


Puzzle `15-4d06d88e` discovered in   [`timeless/items/models.py`](  https://github.com/timelesslounge/timelessis/blob/master/timeless/items/models.py)   and submitted as #141. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-14: OK (2443 of 2443 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


Puzzle `15-02768d14` discovered in   [`timeless/items/models.py`](  https://github.com/timelesslounge/timelessis/blob/master/timeless/items/models.py)   and submitted as #142. Please, remember that the puzzle was not   necessarily added in this particular commit. Maybe it was added earlier, but   we discovered it only now.


... until its not.


code to generate a template from tag ##FULLFORM## and to fill a template with questions labels / answers completely rewritten for better maitnenance.

I added some basic unit tests today to avoid regressions with single quotes and new line chars

https://github.com/pluginsGLPI/formcreator/blob/7f64792564d35d31ac55269b76471b4abf8ce9b4/inc/targetticket.class.php#L1139


FWIW: all methods that do not mutate the object should be marked `const`, look into this: https://en.cppreference.com/w/cpp/language/member_functions#const-.2C_volatile-.2C_and_ref-qualified_member_functions


Successfully aliased the URL <https://good-commit-cewmttqcv.now.sh> to the following aliases.

* https://goodcommit.com
* https://www.goodcommit.com


what if someone passes `3+b`, I would say that INT validation is also needed.

I was stuck there because I started the same way, enum type with values, but then when eat had to accept expected type I didn't know what to pass to enum values (eg. `self.eat(Token::INT(VALUE?))`) so that is why I splt it into TokenValue and TokenType, but that solutions seems bad to me


so if Token is `Copy` then `.unwrap()` returns cloned already?


Created readme file


> im here for request new build without this bug.

So are you use v0.1.4? Its version is not support editable step 0.
This feature is available at next release (I think i probably release it in this week).


"?" should be only for v1 with resource param, there is no need to add this char in other case


Are you sure this is correct?
```php
$dataArray = [];
$dataArray[] = $columns;
```
In this case, you clear $dataArray with each iteration! That is, only the last backup file will be found!


`address_allocator_traits_base` wanted access to `free_addr` which is not accessible since `ContiguousPoolAddressAllocator` takes `PoolAddressAllocator` as *protected* base.


ahh! I'm so confused


> just wondering if it might make sense to, additionally, exclude certain combinations.

There is a tradeoff between safety and abstraction here: if we encode those rules in Brig, then Brig is suddenly much more aware of Spar than it should be. (Ideally `ManagedBySCIM` should be a kinda opaque thing, not something that Brig knows the semantics of. It's either "Wire" or "not Wire" for Brig.) I generally don't like the idea of picking two or three flows and enshrining them in the backend, as opposed to building _tools_ that have some invariants but otherwise can be used with relative freedom.

On the other hand, yes, it undeniably makes sense to have those safeguards in place.

Given that `phone_code` doesn't hurt anything, I'm inclined to just leave it be, but I don't have a particularly strong opinion. Adding a `NewUserSpar` newtype is not complicated and the `createUser` endpoint – even the internal one – is rather far from being a general-purpose tool anyway.

> Perhaps `ManagedBySCIM` should be restricted to users with a `newUserOrigin` of being associated to a team

The same point applies: I don't think it's Brig's business to even know that SCIM is supposed to be for team-management (and all this stuff is/has to be tested in Spar anyway), but it's not hard to do either.

---

I will merge this PR as-is but I have noted your suggestions in the SCIM tracking issue. If you or somebody else has a stronger opinion on the topic (or if I change my mind after Thursday), they will be implemented.


[R/create_alignment_params.R:44:3:](https://github.com/richelbilderbeek/pirouette/blob/645c55e99971294f5d1ffb06fec078fb4431e48e/R/create_alignment_params.R#L44) *warning:* **no visible global function definition for ‘create_alignment_params’**
```r
  create_alignment_params(root_sequence = "acgt", mutation_rate = 0.1)
  ^~~~~~~~~~~~~~~~~~~~~~~
```
[R/pir_run.R:147:5:](https://github.com/richelbilderbeek/pirouette/blob/645c55e99971294f5d1ffb06fec078fb4431e48e/R/pir_run.R#L147) *warning:* **no visible global function definition for ‘check_experiment’**
```r
    check_experiment(experiment)
    ^~~~~~~~~~~~~~~~
```


idk, msvc started moaning about this like "cannot convert from std::initiliazer_list to SContext" even though it was perfectly ok before


Member values should have `_` sufix. Eg. `currentIteration_` instead of `currentIteration`.


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


yes. v0.1.4, i download this version here https://github.com/rerrahkr/BambooTracker/releases

okay, im waiting for new version


@pospi this isn't the same `DHTResponse` that can't have an error, is it?  This is just the declarations file, this isn't preventing any errors.  The zome itself has not changed, it is still able to return with an error.  Should the types declared not reflect that?


This function cause a lot of headache for maintainers. The goal for version 2.7.0 is to no longer use it. If some escaping issues still exist, they are now easier to fix, with less risks of regression. Some unit tests added to avoid regressions.


same as above


In one line with access modifier. Eg. `public: void BO_init();`


Missing blank line at the end


Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

- @isuruf-bot was added to conda-forge. Welcome to conda-forge!
  Go to https://github.com/orgs/conda-forge/invitation see your invitation.

You should get push access to this feedstock and CI services.

Feel free to join the community [chat room](https://gitter.im/conda-forge/conda-forge.github.io).

NOTE: Please make sure to not push to the repository directly.
      Use branches in your fork for any changes and send a PR.
      More details [here](https://conda-forge.org/docs/conda-forge_gotchas.html#using-a-fork-vs-a-branch-when-updating-a-recipe)


Deployed at: https://alva-commits-cd704.surge.sh


Use `and` instead `&&`. See https://en.cppreference.com/w/cpp/language/operator_alternative


message typo - Nuxt **( v2.4.2 )**


[R/create_alignment_params.R:44:3:](https://github.com/richelbilderbeek/pirouette/blob/e92325615af71ab0c5a1f1b1123366cf837f706a/R/create_alignment_params.R#L44) *warning:* **no visible global function definition for ‘create_alignment_params’**
```r
  create_alignment_params(root_sequence = "acgt", mutation_rate = 0.1)
  ^~~~~~~~~~~~~~~~~~~~~~~
```
[R/pir_run.R:147:5:](https://github.com/richelbilderbeek/pirouette/blob/e92325615af71ab0c5a1f1b1123366cf837f706a/R/pir_run.R#L147) *warning:* **no visible global function definition for ‘check_experiment’**
```r
    check_experiment(experiment)
    ^~~~~~~~~~~~~~~~
```


What do you mean ?


No Xavier,

Let's say I passed a list that has the following known parties:
Adel
Xavier
Rob
Adel (repeated for some reason)
Lucy
Now my function will loop over those values and for each value it will generate the couple (anonymousMe, anonymousValue) and add it, but before that there's a check that the list doesn't already have a value for a certain key.
So for the first Adel; the function will add (Adel, AnonymousAdel), as for the second value; it will skip it because we already generated a confidential identity couple that we can use in multiple cash states that reference Adel (as an owner or an issuer).
Thus the purpose of this function is to generate confidential identities and re-use them when possible.


ill help u when your up to it


added comments


Yeah, we can still put them in the Playground class.
The reason behind doing so is  just to separate the Playground basic details and it's whole validation part within Playground class.

we can discuss about it what might be the best way of forming Playground Domain Object.


Deployment failed with the following error:

~~~
Missing `start` (or `now-start`) script in `package.json`. See: https://docs.npmjs.com/cli/start
~~~


Okay


Okay.


I have


CSS grid is the hot new thing in market.

https://twitter.com/gitlost/status/1092973924621737984?s=19


Successfully aliased the URL <https://og-image-5sc5cn4jm.now.sh> to the following alias.

* https://og-image.now.sh


Okay. I will write Javadoc comments  for that.


comment


IMO, this code is hard to read. Perhaps some spacing/new line will make it better.


This one's actually wrong, please ignore :P I'm dumb


yup


html entities removed


hi


Tested and works perfectly! Thank you


please use a number after `dev` -> should be `dev.1`


You don't need to do this. Because you are using the default constructor, you can just do the same thing you did to `display` and `length` and do `spaces()`.


start...n


# Commit comment

haha


res.indices


>           I'm not sure; the clusterer probably uses the pins in first-come-first-serve order when it has flexibility, but it would be easier to run it and see than to infer from the code.

It is hard to discern from the runs. For example:
            <port name="I">gnd top.fpu_mul+x4_mul.post_norm+u4^MULTI_PORT_MUX~21524^MUX_2~123979 vcc top.fpu_mul+x4_mul.post_norm+u4^MULTI_PORT_MUX~21524^MUX_2~123981 top.fpu_mul+x4_mul.post_norm+u4^MULTI_PORT_MUX~21524^MUX_2~123983 top.fpu_mul+x4_mul.post_norm+u4^MULTI_PORT_MUX~21524^MUX_2~123972 top.fpu_mul+x4_mul.post_norm+u4^MULTI_PORT_MUX~21524^MUX_2~123974 top.fpu_mul+x4_mul.post_norm+u4^MULTI_PORT_MUX~21524^MUX_2~123985 top.fpu_mul+x4_mul.post_norm+u4^MULTI_PORT_MUX~21524^MUX_2~123987 open open top.fpu_mul+x4_mul.post_norm+u4^MULTI_PORT_MUX~21524^MUX_2~123976 top.fpu_mul+x4_mul.post_norm+u4^MULTI_PORT_MUX~21524^MUX_2~123978 top.fpu_mul+x4_mul.post_norm+u4^MULTI_PORT_MUX~21524^MUX_2~123980 top.fpu_mul+x4_mul.post_norm+u4^MULTI_PORT_MUX~21524^MUX_2~123982 open open open open open open open open top.fpu_mul+x4_mul.post_norm+u4^MULTI_PORT_MUX~21524^MUX_2~123984 top.fpu_mul+x4_mul.post_norm+u4^MULTI_PORT_MUX~21524^MUX_2~123986 top.fpu_mul+x4_mul.post_norm+u4^MULTI_PORT_MUX~21524^MUX_2~123988 top.fpu_mul+x4_mul.post_norm+u4^MULTI_PORT_MUX~21524^MUX_2~123970 top.fpu_mul+x4_mul.post_norm+u4^MULTI_PORT_MUX~21524^MUX_2~123971 top.fpu_mul+x4_mul.post_norm+u4^MULTI_PORT_MUX~21524^MUX_2~123973 top.fpu_mul+x4_mul.post_norm+u4^MULTI_PORT_MUX~21524^MUX_2~123975 top.fpu_mul+x4_mul.post_norm+u4^MULTI_PORT_MUX~21524^MUX_2~123977 open open open open open open open open open</port>

This is for the case where there is a full crossbar at the inputs. It seems like there are opens distributed in batches throughout. So perhaps the algorithm is biased to distribute things in some way (even if it is not intelligent) or it is random. The consecutive opens seem suspicous though if the algorithm is random.


いやー、さすがにREADMEはMarkdownをつかいたいです・・・。


@VladAndroidGamer is this recovery tested in j260g? :)


@ale-rt Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.resourceeditor/42/violations
```
plone/resourceeditor/browser.py:102:56: C812 missing trailing comma
plone/resourceeditor/browser.py:107:55: C812 missing trailing comma
plone/resourceeditor/browser.py:203:71: C812 missing trailing comma
plone/resourceeditor/browser.py:217:32: C812 missing trailing comma
plone/resourceeditor/browser.py:300:60: C812 missing trailing comma
plone/resourceeditor/browser.py:302:45: C812 missing trailing comma
plone/resourceeditor/browser.py:354:25: C812 missing trailing comma
plone/resourceeditor/browser.py:420:60: C812 missing trailing comma
plone/resourceeditor/browser.py:501:5: C901 'FileManagerActions.do_action' is too complex (14)
plone/resourceeditor/browser.py:518:49: C812 missing trailing comma
plone/resourceeditor/browser.py:575:54: C812 missing trailing comma
plone/resourceeditor/browser.py:578:11: T000 Todo note found.
plone/resourceeditor/browser.py:606:27: C812 missing trailing comma
plone/resourceeditor/browser.py:617:25: C812 missing trailing comma
plone/resourceeditor/browser.py:618:14: C812 missing trailing comma
plone/resourceeditor/browser.py:621:5: C901 'FileManager.mode_selector' is too complex (12)
plone/resourceeditor/browser.py:634:65: C812 missing trailing comma
plone/resourceeditor/browser.py:639:63: C812 missing trailing comma
plone/resourceeditor/browser.py:644:56: C812 missing trailing comma
plone/resourceeditor/browser.py:651:58: C812 missing trailing comma
plone/resourceeditor/browser.py:656:56: C812 missing trailing comma
plone/resourceeditor/browser.py:661:58: C812 missing trailing comma
plone/resourceeditor/browser.py:665:56: C812 missing trailing comma
plone/resourceeditor/browser.py:670:66: C812 missing trailing comma
plone/resourceeditor/browser.py:674:56: C812 missing trailing comma
plone/resourceeditor/browser.py:719:44: C812 missing trailing comma
plone/resourceeditor/browser.py:825:75: C812 missing trailing comma
plone/resourceeditor/browser.py:835:29: C812 missing trailing comma
plone/resourceeditor/browser.py:841:33: C812 missing trailing comma
plone/resourceeditor/browser.py:852:25: C812 missing trailing comma
plone/resourceeditor/browser.py:858:29: C812 missing trailing comma
plone/resourceeditor/browser.py:913:60: C812 missing trailing comma
plone/resourceeditor/browser.py:915:45: C812 missing trailing comma
plone/resourceeditor/browser.py:1183:54: C812 missing trailing comma
plone/resourceeditor/browser.py:1186:11: T000 Todo note found.
plone/resourceeditor/browser.py:1256:41: C812 missing trailing comma
plone/resourceeditor/browser.py:1269:48: C812 missing trailing comma
plone/resourceeditor/testing.py:17:41: C812 missing trailing comma
plone/resourceeditor/tests/test_file_manager.py:4:1: F401 'six' imported but unused
plone/resourceeditor/tests/test_file_manager_action.py:3:1: I003 isort expected 1 blank line in imports, found 0
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Dataset is grouped by file id/interaction id before being split. This way we take 20% of the interactions, not 20% of the frames, for testing.


these are being used in order to identity who/when/what observed.


Created multidev environment [gtweb#ci-133](https://dashboard.pantheon.io/sites/48c6fbf0-589a-40de-bda2-16e7cd7c267d#ci-133).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-133-gtweb.pantheonsite.io/)


"doze_always_on_summary">Näytä aika

Näytä aina? Sen jälkeen lause alkais isolla jne?


OMG!! Shinmera!! **He has spoken**!!

PS: Why so self-deprecating? After so many years doing this stuff, I also can't get any pathname mangling right the first time.

Kind regards from the other part of the hemisphere,
defunkydrummer


So Ive followed the steps to trying to get this fixed but i am presented with the following error

head_shortcut_icon does not contain field 'file'

Is this a buggy fix and when is 2.3.1 going to be released?


TeamCity Consultations / "Private Beta" - BuildAndPublish .NET Core 2.1 [Build 0.1.0.2071-EC-773-Document-leve](https://teamcity.nice.org.uk/viewLog.html?buildId=49371&buildTypeId=Consultations_PrivateBetaBuildAndPublish21) outcome was **UNKNOWN**
Summary: Canceled (Exit code 1 (Step: Install client dependencies (Command Line)) (new)) Build time: 00:03:48