@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.z3cform/144/violations
```
plone/app/z3cform/converters.py:106:11: T000 Todo note found.
plone/app/z3cform/inline_validation.py:15:5: C901 'InlineValidationView.__call__' is too complex (15)
plone/app/z3cform/widget.py:5:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:45:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:70:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:702:19: T000 Todo note found.
plone/app/z3cform/widget.py:716:47: T000 Todo note found.
plone/app/z3cform/tests/test_widgets.py:6:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/test_widgets.py:160:50: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:170:60: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:171:18: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


develop (Myoldmopar) - x86_64-MacOS-10.13-clang: OK (2443 of 2443 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


Bien


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.autoform/46/violations
```
plone/autoform/base.py:35:5: C901 'AutoFields.updateFieldsFromSchemata' is too complex (11)
plone/autoform/base.py:57:52: C812 missing trailing comma
plone/autoform/base.py:117:43: C812 missing trailing comma
plone/autoform/base.py:166:5: C901 'AutoFields._calculate_field_moves' is too complex (11)
plone/autoform/base.py:241:72: C812 missing trailing comma
plone/autoform/base.py:259:42: C812 missing trailing comma
plone/autoform/base.py:260:30: C812 missing trailing comma
plone/autoform/directives.py:30:71: C812 missing trailing comma
plone/autoform/directives.py:64:75: C812 missing trailing comma
plone/autoform/directives.py:127:40: C812 missing trailing comma
plone/autoform/directives.py:135:74: C812 missing trailing comma
plone/autoform/form.py:24:34: C812 missing trailing comma
plone/autoform/interfaces.py:46:22: C812 missing trailing comma
plone/autoform/interfaces.py:51:26: C812 missing trailing comma
plone/autoform/interfaces.py:58:30: C812 missing trailing comma
plone/autoform/interfaces.py:60:23: C812 missing trailing comma
plone/autoform/interfaces.py:71:26: C812 missing trailing comma
plone/autoform/interfaces.py:85:46: C812 missing trailing comma
plone/autoform/interfaces.py:89:27: C812 missing trailing comma
plone/autoform/interfaces.py:90:10: C812 missing trailing comma
plone/autoform/interfaces.py:96:35: C812 missing trailing comma
plone/autoform/interfaces.py:100:29: C812 missing trailing comma
plone/autoform/interfaces.py:101:10: C812 missing trailing comma
plone/autoform/supermodel.py:53:78: C812 missing trailing comma
plone/autoform/supermodel.py:71:5: C901 'FormSchema.read' is too complex (11)
plone/autoform/supermodel.py:107:70: C812 missing trailing comma
plone/autoform/supermodel.py:113:5: C901 'FormSchema.write' is too complex (14)
plone/autoform/supermodel.py:160:41: C812 missing trailing comma
plone/autoform/supermodel.py:183:51: C812 missing trailing comma
plone/autoform/supermodel.py:201:37: C812 missing trailing comma
plone/autoform/supermodel.py:205:15: C812 missing trailing comma
plone/autoform/supermodel.py:211:32: C812 missing trailing comma
plone/autoform/supermodel.py:216:33: C812 missing trailing comma
plone/autoform/utils.py:123:1: C901 '_process_fieldsets' is too complex (11)
plone/autoform/utils.py:129:18: C812 missing trailing comma
plone/autoform/utils.py:163:69: C815 missing trailing comma in Python 3.5+
plone/autoform/utils.py:209:29: C812 missing trailing comma
plone/autoform/utils.py:214:30: C812 missing trailing comma
plone/autoform/utils.py:237:37: C812 missing trailing comma
plone/autoform/utils.py:238:22: C812 missing trailing comma
plone/autoform/utils.py:282:36: C812 missing trailing comma
plone/autoform/utils.py:296:38: C812 missing trailing comma
plone/autoform/widgets.py:64:28: C812 missing trailing comma
plone/autoform/widgets.py:89:24: C812 missing trailing comma
plone/autoform/widgets.py:117:43: C812 missing trailing comma
plone/autoform/widgets.py:141:29: C812 missing trailing comma
plone/autoform/widgets.py:154:53: C812 missing trailing comma
plone/autoform/widgets.py:158:52: C812 missing trailing comma
plone/autoform/tests/test_base.py:48:73: C812 missing trailing comma
plone/autoform/tests/test_base.py:50:59: C812 missing trailing comma
plone/autoform/tests/test_base.py:52:18: C812 missing trailing comma
plone/autoform/tests/test_base.py:53:14: C812 missing trailing comma
plone/autoform/tests/test_directives.py:77:49: C812 missing trailing comma
plone/autoform/tests/test_directives.py:171:58: C812 missing trailing comma
plone/autoform/tests/test_directives.py:175:59: C812 missing trailing comma
plone/autoform/tests/test_directives.py:209:45: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:42:60: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:49:60: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:60:47: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:64:47: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:68:45: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:72:45: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:76:23: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:85:60: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:105:47: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:109:47: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:114:45: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:118:45: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:139:47: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:143:45: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:150:52: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:155:50: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:169:46: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:173:47: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:178:44: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:182:49: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:193:71: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:257:57: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:270:79: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:308:46: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:314:44: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:324:56: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:328:59: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:334:56: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:339:59: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:358:37: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:375:24: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:435:56: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:439:57: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:468:66: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:472:67: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:488:66: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:492:67: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:506:66: C812 missing trailing comma
plone/autoform/tests/test_supermodel_handler.py:510:67: C812 missing trailing comma
plone/autoform/tests/test_utils.py:3:1: I001 isort found an import in the wrong position
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.behavior/15/violations
```
plone/behavior/interfaces.py:33:22: C812 missing trailing comma
plone/behavior/interfaces.py:38:23: C812 missing trailing comma
plone/behavior/interfaces.py:46:23: C812 missing trailing comma
plone/behavior/interfaces.py:52:26: C812 missing trailing comma
plone/behavior/interfaces.py:62:26: C812 missing trailing comma
plone/behavior/interfaces.py:68:25: C812 missing trailing comma
plone/behavior/interfaces.py:89:25: C812 missing trailing comma
plone/behavior/metaconfigure.py:83:65: C812 missing trailing comma
plone/behavior/metaconfigure.py:106:71: C812 missing trailing comma
plone/behavior/metaconfigure.py:111:25: C812 missing trailing comma
plone/behavior/metaconfigure.py:137:35: C812 missing trailing comma
plone/behavior/metaconfigure.py:149:35: C812 missing trailing comma
plone/behavior/metaconfigure.py:156:73: C812 missing trailing comma
plone/behavior/metaconfigure.py:169:21: C812 missing trailing comma
plone/behavior/registration.py:56:39: C812 missing trailing comma
plone/behavior/registration.py:57:14: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@wichert Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.browserlayer/21/violations
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/browserlayer/__init__.py:0:1: C101 Coding magic comment not found
plone/browserlayer/exportimport.py:0:1: C101 Coding magic comment not found
plone/browserlayer/exportimport.py:1:1: I001 isort found an import in the wrong position
plone/browserlayer/exportimport.py:2:1: I004 isort found an unexpected blank line in imports
plone/browserlayer/exportimport.py:7:1: I001 isort found an import in the wrong position
plone/browserlayer/exportimport.py:8:1: I004 isort found an unexpected blank line in imports
plone/browserlayer/exportimport.py:9:1: I001 isort found an import in the wrong position
plone/browserlayer/exportimport.py:10:1: I001 isort found an import in the wrong position
plone/browserlayer/exportimport.py:11:1: I001 isort found an import in the wrong position
plone/browserlayer/exportimport.py:12:1: I004 isort found an unexpected blank line in imports
plone/browserlayer/exportimport.py:13:1: I001 isort found an import in the wrong position
plone/browserlayer/exportimport.py:14:1: I001 isort found an import in the wrong position
plone/browserlayer/exportimport.py:15:1: I004 isort found an unexpected blank line in imports
plone/browserlayer/exportimport.py:16:1: I001 isort found an import in the wrong position
plone/browserlayer/exportimport.py:17:1: I001 isort found an import in the wrong position
plone/browserlayer/exportimport.py:18:1: I001 isort found an import in the wrong position
plone/browserlayer/exportimport.py:20:1: E302 expected 2 blank lines, found 1
plone/browserlayer/exportimport.py:23:1: E302 expected 2 blank lines, found 1
plone/browserlayer/exportimport.py:26:5: D001 found implements( replace it with zope.interface.implementer
plone/browserlayer/exportimport.py:27:5: D001 found adapts( replace it with zope.component.adapter
plone/browserlayer/exportimport.py:28:1: W293 blank line contains whitespace
plone/browserlayer/exportimport.py:31:1: W293 blank line contains whitespace
plone/browserlayer/exportimport.py:57:79: W291 trailing whitespace
plone/browserlayer/exportimport.py:68:1: W293 blank line contains whitespace
plone/browserlayer/exportimport.py:71:1: W293 blank line contains whitespace
plone/browserlayer/exportimport.py:72:71: W291 trailing whitespace
plone/browserlayer/exportimport.py:73:29: E127 continuation line over-indented for visual indent
plone/browserlayer/exportimport.py:74:1: W293 blank line contains whitespace
plone/browserlayer/exportimport.py:80:1: W293 blank line contains whitespace
plone/browserlayer/exportimport.py:83:1: E302 expected 2 blank lines, found 1
plone/browserlayer/exportimport.py:89:21: Q000 Remove bad quotes.
plone/browserlayer/exportimport.py:92:80: E501 line too long (82 > 79 characters)
plone/browserlayer/exportimport.py:94:20: S001 found module formatter
plone/browserlayer/exportimport.py:97:41: E261 at least two spaces before inline comment
plone/browserlayer/exportimport.py:100:1: E302 expected 2 blank lines, found 1
plone/browserlayer/exportimport.py:106:21: Q000 Remove bad quotes.
plone/browserlayer/exportimport.py:109:80: E501 line too long (82 > 79 characters)
plone/browserlayer/exportimport.py:111:20: S001 found module formatter
plone/browserlayer/exportimport.py:114:70: W292 no newline at end of file
plone/browserlayer/interfaces.py:0:1: C101 Coding magic comment not found
plone/browserlayer/interfaces.py:2:1: I003 isort expected 1 blank line in imports, found 0
plone/browserlayer/interfaces.py:3:1: E302 expected 2 blank lines, found 1
plone/browserlayer/interfaces.py:5:8: W292 no newline at end of file
plone/browserlayer/layer.py:0:1: C101 Coding magic comment not found
plone/browserlayer/layer.py:1:1: I001 isort found an import in the wrong position
plone/browserlayer/layer.py:3:1: I001 isort found an import in the wrong position
plone/browserlayer/layer.py:4:1: I003 isort expected 1 blank line in imports, found 0
plone/browserlayer/layer.py:5:1: E302 expected 2 blank lines, found 1
plone/browserlayer/layer.py:11:1: W293 blank line contains whitespace
plone/browserlayer/layer.py:12:57: W291 trailing whitespace
plone/browserlayer/layer.py:13:64: W291 trailing whitespace
plone/browserlayer/layer.py:18:5: D001 found directlyProvides( replace it with zope.interface.provider
plone/browserlayer/layer.py:19:1: W391 blank line at end of file
plone/browserlayer/utils.py:0:1: C101 Coding magic comment not found
plone/browserlayer/utils.py:3:1: I001 isort found an import in the wrong position
plone/browserlayer/utils.py:4:1: I001 isort found an import in the wrong position
plone/browserlayer/utils.py:5:1: I001 isort found an import in the wrong position
plone/browserlayer/utils.py:6:1: I004 isort found an unexpected blank line in imports
plone/browserlayer/utils.py:7:1: I001 isort found an import in the wrong position
plone/browserlayer/utils.py:9:1: E302 expected 2 blank lines, found 1
plone/browserlayer/utils.py:14:1: W293 blank line contains whitespace
plone/browserlayer/utils.py:18:1: W293 blank line contains whitespace
plone/browserlayer/utils.py:21:1: W293 blank line contains whitespace
plone/browserlayer/utils.py:24:1: W293 blank line contains whitespace
plone/browserlayer/utils.py:25:50: W291 trailing whitespace
plone/browserlayer/utils.py:26:66: W291 trailing whitespace
plone/browserlayer/utils.py:28:1: W293 blank line contains whitespace
plone/browserlayer/utils.py:29:1: E302 expected 2 blank lines, found 1
plone/browserlayer/utils.py:33:1: W293 blank line contains whitespace
plone/browserlayer/utils.py:36:24: Q000 Remove bad quotes.
plone/browserlayer/utils.py:36:24: S001 found module formatter
plone/browserlayer/utils.py:37:1: W293 blank line contains whitespace
plone/browserlayer/utils.py:40:1: W293 blank line contains whitespace
plone/browserlayer/utils.py:44:1: W293 blank line contains whitespace
plone/browserlayer/utils.py:45:1: E302 expected 2 blank lines, found 1
plone/browserlayer/tests/interfaces.py:0:1: C101 Coding magic comment not found
plone/browserlayer/tests/interfaces.py:2:1: I003 isort expected 1 blank line in imports, found 0
plone/browserlayer/tests/interfaces.py:3:1: E302 expected 2 blank lines, found 1
plone/browserlayer/tests/interfaces.py:5:8: W292 no newline at end of file
plone/browserlayer/tests/test_doctest.py:0:1: C101 Coding magic comment not found
plone/browserlayer/tests/test_doctest.py:1:1: I001 isort found an import in the wrong position
plone/browserlayer/tests/test_doctest.py:2:1: I001 isort found an import in the wrong position
plone/browserlayer/tests/test_doctest.py:3:1: I004 isort found an unexpected blank line in imports
plone/browserlayer/tests/test_doctest.py:5:1: I001 isort found an import in the wrong position
plone/browserlayer/tests/test_doctest.py:6:1: I004 isort found an unexpected blank line in imports
plone/browserlayer/tests/test_doctest.py:13:1: I003 isort expected 1 blank line in imports, found 0
plone/browserlayer/tests/test_doctest.py:16:1: E302 expected 2 blank lines, found 1
plone/browserlayer/tests/test_doctest.py:28:1: W293 blank line contains whitespace
plone/browserlayer/tests/test_doctest.py:33:1: E302 expected 2 blank lines, found 1
plone/browserlayer/tests/test_doctest.py:40:80: E501 line too long (109 > 79 characters)
plone/browserlayer/tests/test_doctest.py:41:1: W293 blank line contains whitespace
plone/browserlayer/tests/test_doctest.py:44:1: E305 expected 2 blank lines after class or function definition, found 1
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.browserlayer/24/violations
```
plone/browserlayer/exportimport.py:96:21: Q000 Remove bad quotes.
plone/browserlayer/exportimport.py:102:20: S001 found module formatter
plone/browserlayer/exportimport.py:115:21: Q000 Remove bad quotes.
plone/browserlayer/exportimport.py:121:20: S001 found module formatter
plone/browserlayer/testing.py:20:10: Q000 Remove bad quotes.
plone/browserlayer/testing.py:20:40: C812 missing trailing comma
plone/browserlayer/__init__.py:0:1: C101 Coding magic comment not found
plone/browserlayer/utils.py:37:24: Q000 Remove bad quotes.
plone/browserlayer/utils.py:37:24: S001 found module formatter
plone/browserlayer/layer.py:12:31: Q000 Remove bad quotes.
plone/browserlayer/layer.py:29:5: D001 found directlyProvides( replace it with zope.interface.provider
plone/browserlayer/tests/test_doctest.py:30:55: C812 missing trailing comma
plone/browserlayer/tests/test_doctest.py:31:10: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.browserlayer/23/violations
```
plone/browserlayer/__init__.py:0:1: C101 Coding magic comment not found
plone/browserlayer/exportimport.py:96:21: Q000 Remove bad quotes.
plone/browserlayer/exportimport.py:102:20: S001 found module formatter
plone/browserlayer/exportimport.py:115:21: Q000 Remove bad quotes.
plone/browserlayer/exportimport.py:121:20: S001 found module formatter
plone/browserlayer/layer.py:12:31: Q000 Remove bad quotes.
plone/browserlayer/layer.py:29:5: D001 found directlyProvides( replace it with zope.interface.provider
plone/browserlayer/testing.py:20:10: Q000 Remove bad quotes.
plone/browserlayer/testing.py:20:40: C812 missing trailing comma
plone/browserlayer/utils.py:37:24: Q000 Remove bad quotes.
plone/browserlayer/utils.py:37:24: S001 found module formatter
plone/browserlayer/tests/test_doctest.py:4:1: I003 isort expected 1 blank line in imports, found 0
plone/browserlayer/tests/test_doctest.py:19:55: C812 missing trailing comma
plone/browserlayer/tests/test_doctest.py:20:10: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.caching/21/violations
```
plone/caching/hooks.py:39:49: Q000 Remove bad quotes.
plone/caching/hooks.py:81:22: C812 missing trailing comma
plone/caching/hooks.py:92:34: C812 missing trailing comma
plone/caching/hooks.py:115:22: C812 missing trailing comma
plone/caching/hooks.py:173:22: C812 missing trailing comma
plone/caching/hooks.py:214:18: C812 missing trailing comma
plone/caching/operations.py:30:15: Q000 Remove bad quotes.
plone/caching/operations.py:31:21: Q000 Remove bad quotes.
plone/caching/operations.py:50:30: C812 missing trailing comma
plone/caching/operations.py:60:47: C812 missing trailing comma
plone/caching/operations.py:75:30: C812 missing trailing comma
plone/caching/utils.py:39:21: C812 missing trailing comma
plone/caching/utils.py:118:27: C812 missing trailing comma
plone/caching/tests/test_hooks.py:190:35: C812 missing trailing comma
plone/caching/tests/test_hooks.py:212:35: C812 missing trailing comma
plone/caching/tests/test_hooks.py:534:35: C812 missing trailing comma
plone/caching/tests/test_hooks.py:558:35: C812 missing trailing comma
plone/caching/tests/test_hooks.py:852:35: C812 missing trailing comma
plone/caching/tests/test_hooks.py:936:28: C812 missing trailing comma
plone/caching/tests/test_hooks.py:942:35: C812 missing trailing comma
plone/caching/tests/test_hooks.py:991:28: C812 missing trailing comma
plone/caching/tests/test_hooks.py:997:35: C812 missing trailing comma
plone/caching/tests/test_hooks.py:1045:28: C812 missing trailing comma
plone/caching/tests/test_hooks.py:1051:35: C812 missing trailing comma
plone/caching/tests/test_operations.py:140:35: C812 missing trailing comma
plone/caching/tests/test_operations.py:151:35: C812 missing trailing comma
plone/caching/tests/test_operations.py:201:35: C812 missing trailing comma
plone/caching/tests/test_operations.py:213:35: C812 missing trailing comma
plone/caching/tests/test_utils.py:31:28: C812 missing trailing comma
plone/caching/tests/test_utils.py:42:28: C812 missing trailing comma
plone/caching/tests/test_utils.py:52:23: C812 missing trailing comma
plone/caching/tests/test_utils.py:59:28: C812 missing trailing comma
plone/caching/tests/test_utils.py:69:23: C812 missing trailing comma
plone/caching/tests/test_utils.py:73:24: C812 missing trailing comma
plone/caching/tests/test_utils.py:80:28: C812 missing trailing comma
plone/caching/tests/test_utils.py:123:19: C812 missing trailing comma
plone/caching/tests/test_utils.py:143:19: C812 missing trailing comma
plone/caching/tests/test_utils.py:147:19: C812 missing trailing comma
plone/caching/tests/test_utils.py:151:19: C812 missing trailing comma
plone/caching/tests/test_utils.py:171:19: C812 missing trailing comma
plone/caching/tests/test_utils.py:187:28: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Successfully aliased the URL <https://ohjelmointi-19-uuvpqsrxoq.now.sh> to the following alias.

* https://ohjelmointi-19.mooc.fi


I don't know exactly how yet, but it brakes inserting code from examples to codeMirror editor.
![image](https://user-images.githubusercontent.com/5370736/52343937-90edb000-2a2a-11e9-8535-2cdc74f8e0f9.png)


Here, `relatedTypeRaw` is an incorrect name. This variable actually contains relationship name.


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-14: OK (2442 of 2442 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


Should we fail if this strdup fails?


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.resourceeditor/41/violations
```
plone/resourceeditor/browser.py:102:56: C812 missing trailing comma
plone/resourceeditor/browser.py:107:55: C812 missing trailing comma
plone/resourceeditor/browser.py:203:71: C812 missing trailing comma
plone/resourceeditor/browser.py:217:32: C812 missing trailing comma
plone/resourceeditor/browser.py:300:60: C812 missing trailing comma
plone/resourceeditor/browser.py:302:45: C812 missing trailing comma
plone/resourceeditor/browser.py:354:25: C812 missing trailing comma
plone/resourceeditor/browser.py:420:60: C812 missing trailing comma
plone/resourceeditor/browser.py:501:5: C901 'FileManagerActions.do_action' is too complex (14)
plone/resourceeditor/browser.py:518:49: C812 missing trailing comma
plone/resourceeditor/browser.py:575:54: C812 missing trailing comma
plone/resourceeditor/browser.py:578:11: T000 Todo note found.
plone/resourceeditor/browser.py:606:27: C812 missing trailing comma
plone/resourceeditor/browser.py:617:25: C812 missing trailing comma
plone/resourceeditor/browser.py:618:14: C812 missing trailing comma
plone/resourceeditor/browser.py:621:5: C901 'FileManager.mode_selector' is too complex (12)
plone/resourceeditor/browser.py:634:65: C812 missing trailing comma
plone/resourceeditor/browser.py:639:63: C812 missing trailing comma
plone/resourceeditor/browser.py:644:56: C812 missing trailing comma
plone/resourceeditor/browser.py:651:58: C812 missing trailing comma
plone/resourceeditor/browser.py:656:56: C812 missing trailing comma
plone/resourceeditor/browser.py:661:58: C812 missing trailing comma
plone/resourceeditor/browser.py:665:56: C812 missing trailing comma
plone/resourceeditor/browser.py:670:66: C812 missing trailing comma
plone/resourceeditor/browser.py:674:56: C812 missing trailing comma
plone/resourceeditor/browser.py:719:44: C812 missing trailing comma
plone/resourceeditor/browser.py:825:75: C812 missing trailing comma
plone/resourceeditor/browser.py:835:29: C812 missing trailing comma
plone/resourceeditor/browser.py:841:33: C812 missing trailing comma
plone/resourceeditor/browser.py:852:25: C812 missing trailing comma
plone/resourceeditor/browser.py:858:29: C812 missing trailing comma
plone/resourceeditor/browser.py:913:60: C812 missing trailing comma
plone/resourceeditor/browser.py:915:45: C812 missing trailing comma
plone/resourceeditor/browser.py:1183:54: C812 missing trailing comma
plone/resourceeditor/browser.py:1186:11: T000 Todo note found.
plone/resourceeditor/browser.py:1256:41: C812 missing trailing comma
plone/resourceeditor/browser.py:1269:48: C812 missing trailing comma
plone/resourceeditor/testing.py:17:41: C812 missing trailing comma
plone/resourceeditor/tests/test_file_manager.py:4:1: F401 'six' imported but unused
plone/resourceeditor/tests/test_file_manager_action.py:3:1: I003 isort expected 1 blank line in imports, found 0
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Seemed like a good choice at the time, but then realised it needs to be non-case sensitive! 😫


I'm sure is a typo. See https://gitlab.gnome.org/GNOME/glade/merge_requests/11#note_402126 for all the elements missing in DTD right now (just checking gtk+.xml catalog)

There're a couple of dtd issues open if anyone want to fix this (using that info collected)


Are you sure that this interface will be implemented in class which will work with DB?))
It's interface ;-)


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.schemaeditor/58/violations
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/schemaeditor/testing.py:15:1: F401 'plone.schemaeditor.tests' imported but unused
plone/schemaeditor/testing.py:47:10: Q000 Remove bad quotes.
plone/schemaeditor/testing.py:47:17: C812 missing trailing comma
plone/schemaeditor/testing.py:54:37: Q000 Remove bad quotes.
plone/schemaeditor/schema.py:0:1: C101 Coding magic comment not found
plone/schemaeditor/schema.py:3:1: I001 isort found an import in the wrong position
plone/schemaeditor/schema.py:4:1: I003 isort expected 1 blank line in imports, found 0
plone/schemaeditor/schema.py:20:1: I001 isort found an import in the wrong position
plone/schemaeditor/schema.py:104:20: Q000 Remove bad quotes.
plone/schemaeditor/interfaces.py:0:1: C101 Coding magic comment not found
plone/schemaeditor/interfaces.py:1:1: I001 isort found an import in the wrong position
plone/schemaeditor/interfaces.py:2:1: I001 isort found an import in the wrong position
plone/schemaeditor/interfaces.py:3:1: I001 isort found an import in the wrong position
plone/schemaeditor/interfaces.py:4:1: I001 isort found an import in the wrong position
plone/schemaeditor/interfaces.py:5:1: I001 isort found an import in the wrong position
plone/schemaeditor/interfaces.py:6:1: I001 isort found an import in the wrong position
plone/schemaeditor/interfaces.py:7:1: I001 isort found an import in the wrong position
plone/schemaeditor/interfaces.py:8:1: I001 isort found an import in the wrong position
plone/schemaeditor/interfaces.py:11:1: I003 isort expected 1 blank line in imports, found 0
plone/schemaeditor/interfaces.py:25:26: C812 missing trailing comma
plone/schemaeditor/interfaces.py:43:30: C812 missing trailing comma
plone/schemaeditor/interfaces.py:53:22: C812 missing trailing comma
plone/schemaeditor/interfaces.py:83:80: E501 line too long (88 > 79 characters)
plone/schemaeditor/interfaces.py:91:80: E501 line too long (90 > 79 characters)
plone/schemaeditor/interfaces.py:94:80: E501 line too long (94 > 79 characters)
plone/schemaeditor/interfaces.py:95:80: E501 line too long (95 > 79 characters)
plone/schemaeditor/interfaces.py:115:1: E305 expected 2 blank lines after class or function definition, found 1
plone/schemaeditor/interfaces.py:116:5: Q000 Remove bad quotes.
plone/schemaeditor/interfaces.py:116:16: Q000 Remove bad quotes.
plone/schemaeditor/interfaces.py:116:26: Q000 Remove bad quotes.
plone/schemaeditor/interfaces.py:116:38: Q000 Remove bad quotes.
plone/schemaeditor/interfaces.py:116:50: Q000 Remove bad quotes.
plone/schemaeditor/interfaces.py:116:66: Q000 Remove bad quotes.
plone/schemaeditor/interfaces.py:117:5: Q000 Remove bad quotes.
plone/schemaeditor/interfaces.py:117:23: Q000 Remove bad quotes.
plone/schemaeditor/interfaces.py:117:40: C812 missing trailing comma
plone/schemaeditor/interfaces.py:127:80: E501 line too long (84 > 79 characters)
plone/schemaeditor/interfaces.py:138:22: C812 missing trailing comma
plone/schemaeditor/interfaces.py:151:23: C812 missing trailing comma
plone/schemaeditor/interfaces.py:155:17: Q000 Remove bad quotes.
plone/schemaeditor/interfaces.py:156:20: Q000 Remove bad quotes.
plone/schemaeditor/interfaces.py:163:29: Q000 Remove bad quotes.
plone/schemaeditor/interfaces.py:164:80: E501 line too long (92 > 79 characters)
plone/schemaeditor/interfaces.py:171:80: E501 line too long (82 > 79 characters)
plone/schemaeditor/interfaces.py:173:80: E501 line too long (80 > 79 characters)
plone/schemaeditor/interfaces.py:174:80: E501 line too long (84 > 79 characters)
plone/schemaeditor/interfaces.py:183:22: C812 missing trailing comma
plone/schemaeditor/interfaces.py:195:23: C812 missing trailing comma
plone/schemaeditor/vocabularies.py:0:1: C101 Coding magic comment not found
plone/schemaeditor/vocabularies.py:3:1: I001 isort found an import in the wrong position
plone/schemaeditor/vocabularies.py:18:44: Q000 Remove bad quotes.
plone/schemaeditor/vocabularies.py:18:44: S001 found module formatter
plone/schemaeditor/__init__.py:0:1: C101 Coding magic comment not found
plone/schemaeditor/__init__.py:2:1: I003 isort expected 1 blank line in imports, found 0
plone/schemaeditor/__init__.py:2:1: I003 isort expected 1 blank line in imports, found 0
plone/schemaeditor/utils.py:0:1: C101 Coding magic comment not found
plone/schemaeditor/utils.py:1:1: I001 isort found an import in the wrong position
plone/schemaeditor/utils.py:2:1: I001 isort found an import in the wrong position
plone/schemaeditor/utils.py:3:1: I001 isort found an import in the wrong position
plone/schemaeditor/utils.py:4:1: I001 isort found an import in the wrong position
plone/schemaeditor/utils.py:5:1: I001 isort found an import in the wrong position
plone/schemaeditor/utils.py:50:9: T000 Todo note found.
plone/schemaeditor/utils.py:52:5: D001 found implements( replace it with zope.interface.implementer
plone/schemaeditor/utils.py:53:5: D001 found adapts( replace it with zope.component.adapter
plone/schemaeditor/utils.py:64:46: W601 .has_key() is deprecated, use 'in'
plone/schemaeditor/utils.py:65:29: W602 deprecated form of raising exception
plone/schemaeditor/utils.py:65:31: S001 found module formatter
plone/schemaeditor/utils.py:69:12: P002 found "hasattr", consider replacing it
plone/schemaeditor/utils.py:80:16: P002 found "hasattr", consider replacing it
plone/schemaeditor/utils.py:86:29: W602 deprecated form of raising exception
plone/schemaeditor/utils.py:86:31: S001 found module formatter
plone/schemaeditor/utils.py:90:80: E501 line too long (90 > 79 characters)
plone/schemaeditor/utils.py:93:80: E501 line too long (94 > 79 characters)
plone/schemaeditor/utils.py:94:80: E501 line too long (95 > 79 characters)
plone/schemaeditor/utils.py:102:29: W602 deprecated form of raising exception
plone/schemaeditor/utils.py:104:29: W602 deprecated form of raising exception
plone/schemaeditor/utils.py:106:29: W602 deprecated form of raising exception
plone/schemaeditor/utils.py:106:80: E501 line too long (94 > 79 characters)
plone/schemaeditor/utils.py:120:80: E501 line too long (81 > 79 characters)
plone/schemaeditor/utils.py:123:80: E501 line too long (80 > 79 characters)
plone/schemaeditor/utils.py:155:5: D001 found implements( replace it with zope.interface.implementer
plone/schemaeditor/fields.py:0:1: C101 Coding magic comment not found
plone/schemaeditor/fields.py:1:1: I001 isort found an import in the wrong position
plone/schemaeditor/fields.py:3:1: I001 isort found an import in the wrong position
plone/schemaeditor/fields.py:7:1: I001 isort found an import in the wrong position
plone/schemaeditor/fields.py:8:1: I001 isort found an import in the wrong position
plone/schemaeditor/fields.py:12:1: I001 isort found an import in the wrong position
plone/schemaeditor/fields.py:14:1: I001 isort found an import in the wrong position
plone/schemaeditor/fields.py:15:1: I004 isort found an unexpected blank line in imports
plone/schemaeditor/fields.py:16:1: I001 isort found an import in the wrong position
plone/schemaeditor/fields.py:17:1: I001 isort found an import in the wrong position
plone/schemaeditor/fields.py:18:1: I001 isort found an import in the wrong position
plone/schemaeditor/fields.py:19:1: I001 isort found an import in the wrong position
plone/schemaeditor/fields.py:30:5: D001 found implements( replace it with zope.interface.implementer
plone/schemaeditor/fields.py:99:15: D001 found implements( replace it with zope.interface.implementer
plone/schemaeditor/fields.py:100:15: D001 found adapts( replace it with zope.component.adapter
plone/schemaeditor/fields.py:149:15: D001 found adapts( replace it with zope.component.adapter
plone/schemaeditor/fields.py:166:80: E501 line too long (94 > 79 characters)
plone/schemaeditor/fields.py:173:80: E501 line too long (94 > 79 characters)
plone/schemaeditor/fields.py:196:80: E501 line too long (84 > 79 characters)
plone/schemaeditor/fields.py:197:27: Q000 Remove bad quotes.
plone/schemaeditor/fields.py:201:1: E305 expected 2 blank lines after class or function definition, found 1
plone/schemaeditor/fields.py:220:15: D001 found adapts( replace it with zope.component.adapter
plone/schemaeditor/fields.py:231:80: E501 line too long (80 > 79 characters)
plone/schemaeditor/browser/__init__.py:0:1: C101 Coding magic comment not found
plone/schemaeditor/browser/field/order.py:0:1: C101 Coding magic comment not found
plone/schemaeditor/browser/field/order.py:2:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/order.py:6:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/order.py:7:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/order.py:8:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/fieldset.py:0:1: C101 Coding magic comment not found
plone/schemaeditor/browser/field/fieldset.py:4:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/fieldset.py:5:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/fieldset.py:6:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/edit.py:0:1: C101 Coding magic comment not found
plone/schemaeditor/browser/field/edit.py:1:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/edit.py:2:1: I004 isort found an unexpected blank line in imports
plone/schemaeditor/browser/field/edit.py:3:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/edit.py:5:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/edit.py:8:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/edit.py:9:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/edit.py:10:1: I004 isort found an unexpected blank line in imports
plone/schemaeditor/browser/field/edit.py:11:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/edit.py:12:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/edit.py:13:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/edit.py:14:1: I004 isort found an unexpected blank line in imports
plone/schemaeditor/browser/field/edit.py:15:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/edit.py:16:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/edit.py:17:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/edit.py:18:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/edit.py:30:17: Q000 Remove bad quotes.
plone/schemaeditor/browser/field/edit.py:36:5: D001 found implements( replace it with zope.interface.implementer
plone/schemaeditor/browser/field/edit.py:37:5: D001 found adapts( replace it with zope.component.adapter
plone/schemaeditor/browser/field/edit.py:51:5: D001 found implements( replace it with zope.interface.implementer
plone/schemaeditor/browser/field/edit.py:116:12: P002 found "hasattr", consider replacing it
plone/schemaeditor/browser/field/traversal.py:0:1: C101 Coding magic comment not found
plone/schemaeditor/browser/field/traversal.py:4:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/traversal.py:5:1: I004 isort found an unexpected blank line in imports
plone/schemaeditor/browser/field/traversal.py:6:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/traversal.py:7:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/field/traversal.py:14:5: D001 found implements( replace it with zope.interface.implementer
plone/schemaeditor/browser/field/traversal.py:33:80: E501 line too long (83 > 79 characters)
plone/schemaeditor/browser/schema/add_field.py:0:1: C101 Coding magic comment not found
plone/schemaeditor/browser/schema/add_field.py:4:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/add_field.py:5:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/add_field.py:6:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/add_field.py:7:1: I004 isort found an unexpected blank line in imports
plone/schemaeditor/browser/schema/add_field.py:8:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/add_field.py:9:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/add_field.py:10:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/add_field.py:11:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/add_field.py:12:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/add_field.py:18:15: Q000 Remove bad quotes.
plone/schemaeditor/browser/schema/add_field.py:42:80: E501 line too long (110 > 79 characters)
plone/schemaeditor/browser/schema/add_field.py:47:25: Q000 Remove bad quotes.
plone/schemaeditor/browser/schema/add_field.py:55:1: E305 expected 2 blank lines after class or function definition, found 1
plone/schemaeditor/browser/schema/__init__.py:0:1: C101 Coding magic comment not found
plone/schemaeditor/browser/schema/listing.py:0:1: C101 Coding magic comment not found
plone/schemaeditor/browser/schema/listing.py:4:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/listing.py:5:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/listing.py:6:1: I004 isort found an unexpected blank line in imports
plone/schemaeditor/browser/schema/listing.py:7:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/listing.py:8:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/listing.py:9:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/listing.py:10:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/listing.py:11:1: I004 isort found an unexpected blank line in imports
plone/schemaeditor/browser/schema/listing.py:12:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/listing.py:13:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/listing.py:14:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/listing.py:18:5: D001 found implements( replace it with zope.interface.implementer
plone/schemaeditor/browser/schema/listing.py:47:16: P002 found "hasattr", consider replacing it
plone/schemaeditor/browser/schema/listing.py:55:28: S001 found module formatter
plone/schemaeditor/browser/schema/listing.py:72:20: S001 found module formatter
plone/schemaeditor/browser/schema/listing.py:75:16: S001 found module formatter
plone/schemaeditor/browser/schema/add_fieldset.py:0:1: C101 Coding magic comment not found
plone/schemaeditor/browser/schema/add_fieldset.py:1:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/add_fieldset.py:2:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/add_fieldset.py:3:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/add_fieldset.py:4:1: I004 isort found an unexpected blank line in imports
plone/schemaeditor/browser/schema/add_fieldset.py:5:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/add_fieldset.py:6:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/add_fieldset.py:7:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/add_fieldset.py:8:1: I004 isort found an unexpected blank line in imports
plone/schemaeditor/browser/schema/add_fieldset.py:13:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/add_fieldset.py:19:15: Q000 Remove bad quotes.
plone/schemaeditor/browser/schema/add_fieldset.py:32:80: E501 line too long (120 > 79 characters)
plone/schemaeditor/browser/schema/add_fieldset.py:38:25: Q000 Remove bad quotes.
plone/schemaeditor/browser/schema/add_fieldset.py:47:1: E305 expected 2 blank lines after class or function definition, found 1
plone/schemaeditor/browser/schema/traversal.py:0:1: C101 Coding magic comment not found
plone/schemaeditor/browser/schema/traversal.py:4:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/traversal.py:5:1: I004 isort found an unexpected blank line in imports
plone/schemaeditor/browser/schema/traversal.py:6:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/traversal.py:7:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/traversal.py:15:80: E501 line too long (88 > 79 characters)
plone/schemaeditor/browser/schema/traversal.py:17:5: D001 found implements( replace it with zope.interface.implementer
plone/schemaeditor/browser/schema/traversal.py:35:80: E501 line too long (80 > 79 characters)
plone/schemaeditor/browser/schema/traversal.py:40:80: E501 line too long (87 > 79 characters)
plone/schemaeditor/browser/schema/traversal.py:43:80: E501 line too long (80 > 79 characters)
plone/schemaeditor/tests/tests.py:0:1: C101 Coding magic comment not found
plone/schemaeditor/tests/tests.py:1:1: I003 isort expected 1 blank line in imports, found 0
plone/schemaeditor/tests/tests.py:3:1: I001 isort found an import in the wrong position
plone/schemaeditor/tests/tests.py:4:1: I004 isort found an unexpected blank line in imports
plone/schemaeditor/tests/tests.py:5:1: I001 isort found an import in the wrong position
plone/schemaeditor/tests/tests.py:6:1: I001 isort found an import in the wrong position
plone/schemaeditor/tests/tests.py:7:1: I001 isort found an import in the wrong position
plone/schemaeditor/tests/tests.py:8:1: I004 isort found an unexpected blank line in imports
plone/schemaeditor/tests/tests.py:9:1: I001 isort found an import in the wrong position
plone/schemaeditor/tests/tests.py:10:1: I001 isort found an import in the wrong position
plone/schemaeditor/tests/tests.py:11:1: I001 isort found an import in the wrong position
plone/schemaeditor/tests/tests.py:12:1: I004 isort found an unexpected blank line in imports
plone/schemaeditor/tests/tests.py:13:1: I001 isort found an import in the wrong position
plone/schemaeditor/tests/tests.py:37:80: E501 line too long (85 > 79 characters)
plone/schemaeditor/tests/tests.py:57:36: C812 missing trailing comma
plone/schemaeditor/tests/tests.py:76:1: E731 do not assign a lambda expression, use a def
plone/schemaeditor/tests/tests.py:78:80: E501 line too long (82 > 79 characters)
plone/schemaeditor/tests/fixtures.py:0:1: C101 Coding magic comment not found
plone/schemaeditor/tests/fixtures.py:1:1: I001 isort found an import in the wrong position
plone/schemaeditor/tests/fixtures.py:2:1: I001 isort found an import in the wrong position
plone/schemaeditor/tests/fixtures.py:3:1: I001 isort found an import in the wrong position
plone/schemaeditor/tests/fixtures.py:28:5: T001 print statement found.
plone/schemaeditor/tests/fixtures.py:28:11: S001 found module formatter
plone/schemaeditor/tests/fixtures.py:32:1: E402 module level import not at top of file
plone/schemaeditor/tests/fixtures.py:32:1: I001 isort found an import in the wrong position
plone/schemaeditor/tests/fixtures.py:33:1: E402 module level import not at top of file
plone/schemaeditor/tests/fixtures.py:33:1: I001 isort found an import in the wrong position
plone/schemaeditor/tests/fixtures.py:34:1: E402 module level import not at top of file
plone/schemaeditor/tests/fixtures.py:34:1: I001 isort found an import in the wrong position
plone/schemaeditor/tests/fixtures.py:46:1: E305 expected 2 blank lines after class or function definition, found 1
plone/schemaeditor/tests/fixtures.py:96:1: W391 blank line at end of file
plone/schemaeditor/tests/test_robot.py:8:1: I001 isort found an import in the wrong position
plone/schemaeditor/tests/test_robot.py:26:33: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.schemaeditor/62/violations
```
plone/schemaeditor/fields.py:71:58: C812 missing trailing comma
plone/schemaeditor/fields.py:72:14: C812 missing trailing comma
plone/schemaeditor/fields.py:130:9: E303 too many blank lines (2)
plone/schemaeditor/fields.py:227:35: C812 missing trailing comma
plone/schemaeditor/fields.py:228:20: C812 missing trailing comma
plone/schemaeditor/interfaces.py:33:26: C812 missing trailing comma
plone/schemaeditor/interfaces.py:48:76: C812 missing trailing comma
plone/schemaeditor/interfaces.py:52:38: C812 missing trailing comma
plone/schemaeditor/interfaces.py:59:30: C812 missing trailing comma
plone/schemaeditor/interfaces.py:68:22: C812 missing trailing comma
plone/schemaeditor/interfaces.py:150:33: C812 missing trailing comma
plone/schemaeditor/interfaces.py:162:22: C812 missing trailing comma
plone/schemaeditor/interfaces.py:175:23: C812 missing trailing comma
plone/schemaeditor/interfaces.py:190:69: C812 missing trailing comma
plone/schemaeditor/interfaces.py:202:80: C812 missing trailing comma
plone/schemaeditor/interfaces.py:207:72: C812 missing trailing comma
plone/schemaeditor/interfaces.py:215:22: C812 missing trailing comma
plone/schemaeditor/interfaces.py:227:23: C812 missing trailing comma
plone/schemaeditor/testing.py:26:22: C812 missing trailing comma
plone/schemaeditor/utils.py:84:9: T000 Todo note found.
plone/schemaeditor/utils.py:100:18: C812 missing trailing comma
plone/schemaeditor/utils.py:104:12: P002 found "hasattr", consider replacing it
plone/schemaeditor/utils.py:115:16: P002 found "hasattr", consider replacing it
plone/schemaeditor/utils.py:125:18: C812 missing trailing comma
plone/schemaeditor/utils.py:149:26: C812 missing trailing comma
plone/schemaeditor/browser/field/edit.py:28:1: I004 isort found an unexpected blank line in imports
plone/schemaeditor/browser/field/edit.py:179:12: P002 found "hasattr", consider replacing it
plone/schemaeditor/browser/field/edit.py:187:42: C812 missing trailing comma
plone/schemaeditor/browser/field/fieldset.py:4:1: I001 isort found an import in the wrong position
plone/schemaeditor/browser/schema/add_field.py:79:76: C812 missing trailing comma
plone/schemaeditor/browser/schema/add_field.py:80:18: C812 missing trailing comma
plone/schemaeditor/browser/schema/add_field.py:112:41: C812 missing trailing comma
plone/schemaeditor/browser/schema/add_fieldset.py:34:79: C812 missing trailing comma
plone/schemaeditor/browser/schema/add_fieldset.py:38:33: C812 missing trailing comma
plone/schemaeditor/browser/schema/add_fieldset.py:54:41: C812 missing trailing comma
plone/schemaeditor/browser/schema/listing.py:55:16: P002 found "hasattr", consider replacing it
plone/schemaeditor/browser/schema/listing.py:109:79: C812 missing trailing comma
plone/schemaeditor/browser/schema/traversal.py:9:1: F401 'six' imported but unused
plone/schemaeditor/browser/schema/traversal.py:45:21: C812 missing trailing comma
plone/schemaeditor/tests/test_fields.py:27:19: C812 missing trailing comma
plone/schemaeditor/tests/test_fields.py:35:45: C812 missing trailing comma
plone/schemaeditor/tests/test_fields.py:40:48: C812 missing trailing comma
plone/schemaeditor/tests/test_fields.py:48:44: C812 missing trailing comma
plone/schemaeditor/tests/test_fields.py:53:47: C812 missing trailing comma
plone/schemaeditor/tests/test_robot.py:26:33: C812 missing trailing comma
plone/schemaeditor/tests/tests.py:8:1: I001 isort found an import in the wrong position
plone/schemaeditor/tests/tests.py:42:80: E501 line too long (88 > 79 characters)
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.subrequest/38/violations
```
plone/subrequest/__init__.py:79:1: C901 'subrequest' is too complex (12)
plone/subrequest/__init__.py:97:44: C812 missing trailing comma
plone/subrequest/__init__.py:105:25: C812 missing trailing comma
plone/subrequest/__init__.py:116:63: C812 missing trailing comma
plone/subrequest/__init__.py:163:23: C812 missing trailing comma
plone/subrequest/subresponse.py:25:12: P002 found "hasattr", consider replacing it
plone/subrequest/subresponse.py:26:16: P002 found "hasattr", consider replacing it
plone/subrequest/subresponse.py:27:12: P002 found "hasattr", consider replacing it
plone/subrequest/subresponse.py:60:16: P002 found "hasattr", consider replacing it
plone/subrequest/testing.py:11:1: F401 'six' imported but unused
plone/subrequest/testing.py:21:16: Q000 Remove bad quotes.
plone/subrequest/testing.py:125:42: C812 missing trailing comma
plone/subrequest/testing.py:131:45: C812 missing trailing comma
plone/subrequest/testing.py:137:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/subrequest/testing.py:184:39: C812 missing trailing comma
plone/subrequest/testing.py:188:38: C812 missing trailing comma
plone/subrequest/tests.py:12:1: I004 isort found an unexpected blank line in imports
plone/subrequest/tests.py:13:1: I001 isort found an import in the wrong position
plone/subrequest/tests.py:28:5: F401 'plone.app.blob.iterators.BlobStreamIterator' imported but unused
plone/subrequest/tests.py:92:37: C812 missing trailing comma
plone/subrequest/tests.py:99:46: C812 missing trailing comma
plone/subrequest/tests.py:107:46: C812 missing trailing comma
plone/subrequest/tests.py:114:35: C812 missing trailing comma
plone/subrequest/tests.py:122:57: C812 missing trailing comma
plone/subrequest/tests.py:130:57: C812 missing trailing comma
plone/subrequest/tests.py:138:57: C812 missing trailing comma
plone/subrequest/tests.py:152:57: C812 missing trailing comma
plone/subrequest/tests.py:163:67: C812 missing trailing comma
plone/subrequest/tests.py:177:38: C812 missing trailing comma
plone/subrequest/tests.py:189:57: C812 missing trailing comma
plone/subrequest/tests.py:201:57: C812 missing trailing comma
plone/subrequest/tests.py:214:51: C812 missing trailing comma
plone/subrequest/tests.py:222:56: C812 missing trailing comma
plone/subrequest/tests.py:301:61: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Why is pointer comparison good enough here? Don't we need strcmp?


Hello


Are we still considering wildcards in the path?


hacked by mr plow team


typo ie. Row2/Right


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.tiles/40/violations
```
plone/tiles/__init__.py:4:1: I003 isort expected 1 blank line in imports, found 0
plone/tiles/absoluteurl.py:11:1: I003 isort expected 1 blank line in imports, found 0
plone/tiles/data.py:207:1: C901 'map_to_pairs' is too complex (14)
plone/tiles/data.py:241:28: C812 missing trailing comma
plone/tiles/data.py:254:24: C812 missing trailing comma
plone/tiles/data.py:259:1: C901 'encode' is too complex (17)
plone/tiles/data.py:284:36: C812 missing trailing comma
plone/tiles/data.py:285:18: C812 missing trailing comma
plone/tiles/data.py:306:51: C812 missing trailing comma
plone/tiles/data.py:307:22: C812 missing trailing comma
plone/tiles/data.py:314:36: C812 missing trailing comma
plone/tiles/data.py:345:1: C901 'decode' is too complex (14)
plone/tiles/esi.py:31:16: Q001 Remove bad quotes from multiline string.
plone/tiles/esi.py:36:65: Q001 Remove bad quotes from multiline string.
plone/tiles/esi.py:53:10: C812 missing trailing comma
plone/tiles/esi.py:58:17: C812 missing trailing comma
plone/tiles/esi.py:68:13: Q000 Remove bad quotes.
plone/tiles/esi.py:80:29: C812 missing trailing comma
plone/tiles/interfaces.py:70:37: C812 missing trailing comma
plone/tiles/meta.py:23:15: Q000 Remove bad quotes.
plone/tiles/meta.py:24:21: Q000 Remove bad quotes.
plone/tiles/meta.py:29:15: Q000 Remove bad quotes.
plone/tiles/meta.py:30:21: Q000 Remove bad quotes.
plone/tiles/meta.py:31:23: C812 missing trailing comma
plone/tiles/meta.py:35:15: Q000 Remove bad quotes.
plone/tiles/meta.py:37:23: C812 missing trailing comma
plone/tiles/meta.py:41:15: Q000 Remove bad quotes.
plone/tiles/meta.py:42:21: Q000 Remove bad quotes.
plone/tiles/meta.py:43:23: C812 missing trailing comma
plone/tiles/meta.py:47:15: Q000 Remove bad quotes.
plone/tiles/meta.py:48:21: Q000 Remove bad quotes.
plone/tiles/meta.py:49:21: Q000 Remove bad quotes.
plone/tiles/meta.py:54:15: Q000 Remove bad quotes.
plone/tiles/meta.py:55:21: Q000 Remove bad quotes.
plone/tiles/meta.py:60:15: Q000 Remove bad quotes.
plone/tiles/meta.py:61:21: Q000 Remove bad quotes.
plone/tiles/meta.py:66:15: Q000 Remove bad quotes.
plone/tiles/meta.py:67:21: Q000 Remove bad quotes.
plone/tiles/meta.py:72:15: Q000 Remove bad quotes.
plone/tiles/meta.py:77:15: Q000 Remove bad quotes.
plone/tiles/meta.py:78:23: C812 missing trailing comma
plone/tiles/meta.py:82:15: Q000 Remove bad quotes.
plone/tiles/meta.py:83:21: Q000 Remove bad quotes.
plone/tiles/meta.py:84:23: C812 missing trailing comma
plone/tiles/meta.py:88:15: Q000 Remove bad quotes.
plone/tiles/meta.py:89:21: Q000 Remove bad quotes.
plone/tiles/meta.py:94:15: Q000 Remove bad quotes.
plone/tiles/meta.py:95:21: Q000 Remove bad quotes.
plone/tiles/meta.py:126:26: C812 missing trailing comma
plone/tiles/meta.py:139:80: C812 missing trailing comma
plone/tiles/testing.py:42:45: C812 missing trailing comma
plone/tiles/testing.py:45:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/tiles/testing.py:47:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/tiles/testing.py:58:33: C812 missing trailing comma
plone/tiles/tile.py:57:29: C812 missing trailing comma
plone/tiles/tile.py:89:48: C812 missing trailing comma
plone/tiles/type.py:21:20: C812 missing trailing comma
plone/tiles/type.py:41:16: Q000 Remove bad quotes.
plone/tiles/type.py:43:23: C812 missing trailing comma
plone/tiles/tests/test_data.py:19:23: C812 missing trailing comma
plone/tiles/tests/test_data.py:25:23: C812 missing trailing comma
plone/tiles/tests/test_data.py:29:23: C812 missing trailing comma
plone/tiles/tests/test_data.py:38:23: C812 missing trailing comma
plone/tiles/tests/test_data.py:47:23: C812 missing trailing comma
plone/tiles/tests/test_data.py:50:1: E305 expected 2 blank lines after class or function definition, found 1
plone/tiles/tests/test_data.py:62:36: C812 missing trailing comma
plone/tiles/tests/test_data.py:68:78: C812 missing trailing comma
plone/tiles/tests/test_data.py:73:36: C812 missing trailing comma
plone/tiles/tests/test_data.py:77:54: C812 missing trailing comma
plone/tiles/tests/test_data.py:82:36: C812 missing trailing comma
plone/tiles/tests/test_data.py:86:15: C812 missing trailing comma
plone/tiles/tests/test_data.py:96:36: C812 missing trailing comma
plone/tiles/tests/test_data.py:101:40: C812 missing trailing comma
plone/tiles/tests/test_data.py:102:14: C812 missing trailing comma
plone/tiles/tests/test_data.py:107:36: C812 missing trailing comma
plone/tiles/tests/test_data.py:111:15: C812 missing trailing comma
plone/tiles/tests/test_doctests.py:35:50: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.transformchain/29/violations
```
plone/transformchain/interfaces.py:28:30: Q000 Remove bad quotes.
plone/transformchain/interfaces.py:77:80: E501 line too long (81 > 79 characters)
plone/transformchain/tests.py:674:40: C812 missing trailing comma
plone/transformchain/tests.py:675:18: C812 missing trailing comma
plone/transformchain/transformer.py:12:1: I001 isort found an import in the wrong position
plone/transformchain/transformer.py:14:1: I001 isort found an import in the wrong position
plone/transformchain/transformer.py:15:1: I003 isort expected 1 blank line in imports, found 0
plone/transformchain/transformer.py:50:34: C812 missing trailing comma
plone/transformchain/transformer.py:70:17: Q000 Remove bad quotes.
plone/transformchain/transformer.py:70:75: C812 missing trailing comma
plone/transformchain/zpublisher.py:25:18: C812 missing trailing comma
plone/transformchain/zpublisher.py:104:24: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Pickea bangalore y lootea rapido


Regression exactly in this commit, called in other places (codeworld.js) `parseSymbolsFromCurrentCode` does not breaks this. Looks like lifecycle of codeMirror broken in some werid way.


Successfully aliased the URL <https://yld-storybook-1vhsf6c9w.now.sh> to the following alias.

* https://yld-storybook.now.sh


Will this back port to 5*?


`data['allele_freq']`  behövs för beaconens `frequency`
`data['allele_count']` behövs för beaconens `variantCount`


It would be hard but you can, I believe in you: come to me in my free time and explain why it's better w/o *


TeamCity Identity and Access Management / Build IdAM [Build 108-r0F91DEC](https://teamcity.nice.org.uk/viewLog.html?buildId=49341&buildTypeId=IdentityandAccessManagement_BuildIdAM) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:45


What if I'll send:
1. null ?
2. empty string: "" ?
3. column name which doesn't exists?


I have an Optiplex 7010 USFF (A25 bios) i3-3225 (HD 4000) with Mojave 10.14.2 upgraded to 10.14.3.

I have found what appears to be a bug when using new **layout-id 21** withe AppleALC 1.3.5 and Lilu 1.3.3

When selecting **HDMI-audio** in **System Preferences -> Sound -> Output**, the setting reverts to '**Headphones**' every time macOS is shut down and restarted.  If I choose '**Line-Out**', it does remember the setting between reboots in 10.14.3 (I don't know if this behaviour existed in 10.14.2).

I also noticed the volume through rear **Line-Out** is Very low when using 10.14.2. However this is fixed when I upgraded to 10.14.3.

When I insert headphones into front headphone socket, I have to manually choose **'Headphones**' in Sound Preferences to listen via headphones.  I presume this is not a bug, and is normal behaviour.  When using **layout-id 1**, inserting headphones automatically disabled HDMI audio and rear Line-Out audio and switched to headphones.

There is also an existing minor issue where HDMI audio does not function through the DisplayPort closest to the LAN socket on USFF model - no HDMI output device is listed.   I think this DP socket may be DisplayPort 2.  HDMI audio does work through the other DP socket which I believe may be DisplayPort 1.

Above reproduced from my post and photos here:
[https://www.tonymacx86.com/threads/guide-install-high-sierra-or-mojave-on-the-dell-optiplex-7010-9010-desktop-pc-revision-ii.251736/page-50#post-1903731](url)


Yahoo! New comments :-)


TeamCity Identity and Access Management / Build IdAM [Build 109-r0F91DEC](https://teamcity.nice.org.uk/viewLog.html?buildId=49342&buildTypeId=IdentityandAccessManagement_BuildIdAM) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:08


This maybe?


Successfully aliased the URL <https://good-commit-b404pk576.now.sh> to the following aliases.

* https://goodcommit.com
* https://www.goodcommit.com


홍홍홍 좋아용


font-familyは一つ一つのプロパティにかけるんじゃなくて全体で統一したほうがいいかな


TeamCity Identity and Access Management / Build IdAM [Build 110-r0F91DEC](https://teamcity.nice.org.uk/viewLog.html?buildId=49343&buildTypeId=IdentityandAccessManagement_BuildIdAM) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:11


Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

- @hoyc1 was added to conda-forge. Welcome to conda-forge!
  Go to https://github.com/orgs/conda-forge/invitation see your invitation.

- @duncanmmacleod was added to this feedstock maintenance team.

You should get push access to this feedstock and CI services.

Feel free to join the community [chat room](https://gitter.im/conda-forge/conda-forge.github.io).

NOTE: Please make sure to not push to the repository directly.
      Use branches in your fork for any changes and send a PR.
      More details [here](https://conda-forge.org/docs/conda-forge_gotchas.html#using-a-fork-vs-a-branch-when-updating-a-recipe)


Yes I do not use git tags for smaller projects with only a few releases. Are there a specific reason why you need them?


Hi,

yes, in a normal container  reference_type should be the same as value_type&

vector<bool> uses a proxy type for return of operator[] instead of the
references, and that proxy type is not bool.

ср, 6 февр. 2019 г., 11:35 niXman <notifications@github.com>:

> Ohh, corrected: std::is_same<C::value_type&, C::reference>::value
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/niXman/yas/commit/62ac0924f8ba91671b591647f9d5f5feed9c3b40#commitcomment-32211133>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABEgUtDeRmoYD-Kh0ZAVSPVcM6G1bokBks5vKq_ngaJpZM4akoIX>
> .
>


@krakjoe to avoid too long README, and also make sense for downstream (pecl and later distro package), as the INSTALL file don't need to be installed... (so role="src")


こういうコメントアウトは特にいらないから消してもいいかな


Ok so I’m not going to go into too much detail but you don’t want to call T.Timer() then immediately call T.StartTimer().

You should set your values first then on maybe a button press or if the encoder values have not changed for X amount of seconds, call T.StartTimer(). Then once that is called, you can then call T.Timer() in the loop.

I have been meaning to redo my library and add more hooks to prevent these type of issues. I just haven’t had the time.

- Andrew

Sent from my iPhone

> On Feb 6, 2019, at 2:15 AM, BastiaanMDC <notifications@github.com> wrote:
>
> so what I would like to do is the following: ill describe it in 5 steps, and each step has its problem minor problem, due to lack of knowledge.
>
> use your countdowntimer
>
> 1 use the myEncoder Function and button debounce to set the Time. encoder jumps problem
> 2 if the Time is set and displayed on the screen, its kinda sluggish, which I dont understand, should I use myTimer to interval the functions? or use Threads to post the data on the screen for more simultanious data?
> 3 during the Timer1 a function is added that allows me to control the PWM of the 96 Leds and switches my LT3760 on.
> 4 after Timer1 the relaxation phase is given that allows the cells to cooldown.
> 5 not implemented yet an BNC connector that allows me to manually override the start stop timer and switches on the LT3760 and uses just PWM to control the intensity ( also shown on the display)
>
> `
> #define ENCODER_OPTIMIZE_INTERRUPTS
> #include <Encoder.h>
> #include <ADC.h>
> #include <Arduino.h>
> #include <SPI.h>
> #include <U8g2lib.h>
> #include <Bounce.h>
> #include <CountUpDownTimer.h>
> #include <avr/io.h>
> #include <avr/interrupt.h>
>
> const int buttonPin = 21;
> Bounce clk = Bounce(buttonPin, 10); // 10 ms debounce
> U8G2_SSD1327_MIDAS_128X128_F_4W_SW_SPI u8g2(U8G2_R2, 13, 11, 10, 9, 8);// clock= 13, data= 11, cs= 10, dc= 9, reset= 8);
> Encoder Timer_1(1, 0);
>
> int lastButtonState=0;
> byte menuCount = 1;
> byte dir = 0;
> bool runState = false;
>
> unsigned long Hours=0;
> unsigned long Minutes=0;
> unsigned int long Seconds=0;
> unsigned int long Hours2=0;
> unsigned int long Minutes2=0;
> unsigned int long Seconds2=0;
>
> unsigned int count = 0; // how many times has it changed to low
> unsigned long countAt = 0; // when count changed
> unsigned int countPrinted = 0;
>
> CountUpDownTimer T(DOWN);
>
> void setup() {
> pinMode(20, INPUT);
> pinMode(21, INPUT);
>
> Serial.begin(115200);
>
> u8g2.begin();
>
> }
>
> long oldPosition = -999;
> long newPosition;
> void loop()
> {
> T.Timer();
> T.StartTimer();
> myEncoder();
> menuCheck();
> staticMenu(); //do here the Processing of the OLED Screen //havent done the refresh rate, depends on the countdownuptimer
>
> }
>
> long myEncoder()
> {
> newPosition = Timer_1.read();
> if (newPosition != oldPosition) {
> oldPosition = newPosition;
> Serial.println(newPosition);
> return newPosition;
> }
>
> }
>
> int menuCheck()
> {
>
> if (clk.update())
> {
> if(clk.fallingEdge())
> {
> Serial.print(" M ");
> Serial.println(menuCount);
> menuCount++; //move statement after pressed
>
>   count++;
>   countAt=millis();
> }else
> {
> if(count!=countPrinted)
> {
> unsigned long nowMillis=millis();
> if(nowMillis - countAt>20) //shortened the bounce interval to increase the speed of the button
> {
> countPrinted=count;
> }
> }
> //do nothing,
> // Serial.print("Button not Pressed ");
> }
>
> }
> if (menuCount>7) //limit the menu
> {
> menuCount = 1;
>
> }
> sei();
> if (menuCount == 1)
> {
>
> Hours = newPosition;
> if(Hours>0&&Hours<59)
> {
> Serial.print(" Hours ");
> Serial.println(Hours);
>
> }
> else newPosition=0; //out of boundary set to zero.
> }
> if (menuCount == 2)
> {
> Minutes = newPosition;
> if(Minutes>0&&Minutes<59)
> {
> Serial.print(" Minutes ");
> Serial.println(Minutes);
> }else newPosition=0;
>
> }
> if (menuCount == 3)
> {
>
> Seconds = newPosition;
>
> if(Seconds>0&&Seconds<59)
> {
>   Serial.print(" Seconds ");
>   Serial.println(Minutes);
>   }else newPosition=0;
> }
> if(menuCount==4)
> {
>
> Hours2 = newPosition;
>
> if(Hours2>0&&Hours2<59)
> {
> Serial.print(" Hours2 ");
> Serial.println(Hours2);
> }
> else newPosition=0;
> }
> if(menuCount==5)
> {
>
> Minutes2 = newPosition;
>
> if(Minutes2>0&&Minutes2<59)
> {
>   Serial.print(" Minutes2 ");
>   Serial.println(Minutes2);
>
> }else newPosition=0;
> }
> if(menuCount==6)
> {
>
> Seconds2 = newPosition;
>
> if(Seconds2>0&&Seconds2<59)
> {
>   Serial.print(" Seconds2 ");
>   Serial.println(Seconds2);
>
>   }else newPosition=0;
> }
> if(menuCount==7)
> {
> T.SetTimer(Hours,Minutes,Seconds); //why cant I set the the Timer in the Void Loop? if placed in the void loop it jams.
>
> T.SetStopTime(Hours2,Minutes2,Seconds2);//supposed to be the relaxation time of the LED
> }
>
> }
>
> void staticMenu()
> {
>
> u8g2.firstPage();
> do {
> /* all graphics commands have to appear within the loop body. /
> u8g2.clearBuffer();
> u8g2.setFont(u8g2_font_helvB08_tr);
> u8g2.setFontMode(0); / activate transparent font mode */
> u8g2.setFontDirection(0);
>
> u8g2.drawStr(0,45,"Set Timer 1");
> u8g2.setCursor(0,60);
> u8g2.print(Hours,DEC);
> u8g2.print(":");
> u8g2.print(Minutes,DEC);
> u8g2.print(":");
> u8g2.print(Seconds,DEC);
>
>
> u8g2.drawStr(60,45,"CountDown 1");
> u8g2.setCursor(60,60);
> u8g2.drawStr(0,80,"Set Timer 2");
> u8g2.setCursor(0,95);
> u8g2.print(Hours2,DEC);
> u8g2.print(":");
> u8g2.print(Minutes2,DEC);
> u8g2.print(":");
> u8g2.print(Seconds2,DEC);
> if (newPosition > 6 && menuCount == 7) {
>
> runState = true;
> if(T.TimeHasChanged())
> {
> u8g2.drawStr(60,80,"CountDown 1");
> u8g2.setCursor(60,95);
> u8g2.print(T.ShowHours(),DEC);
> u8g2.print(":");
> u8g2.print(T.ShowMinutes(),DEC);
> u8g2.print(":");
> u8g2.print(T.ShowSeconds(),DEC);
> u8g2.print(":");
> u8g2.print(T.ShowMilliSeconds(),DEC);
> u8g2.print(":");
> u8g2.print(T.ShowMicroSeconds(),DEC);
>
> Serial.print(T.ShowHours());
> Serial.print(":");
> Serial.print(T.ShowMinutes());
> Serial.print(":");
> Serial.print(T.ShowSeconds());
> Serial.print(":");
> Serial.print(T.ShowMilliSeconds());
> Serial.print(":");
> Serial.println(T.ShowMicroSeconds());
>
> u8g2.println(" RUN ");
>   }
> }
> else {
> u8g2.println(" STOP ");
> runState = false;
> }
> u8g2.setCursor(0,10 ); //just a symbol to show where I am in the Menu
> u8g2.println(menuCount);
> u8g2.display();
> u8g2.sendBuffer();
>
> } while ( u8g2.nextPage() );
> {
> delay(10); //does this matter=?
> }
> }
> ////check condition Start Stop
> void RunTimer()
> {
> if(runState==true)
> {
> Serial.println("run");
> u8g2.println("run");
> }
> else if(Clock == 0 )
> {
> u8g2.print("T2");
> T.SetStopTime(Hours2,Minutes2,Seconds2); //start Timer 2
> }
> else
> {
> T.StopTimer();
> }
> } `
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub, or mute the thread.


特に今の所アクション内に定義するものがないなら　def show; end って書いたほうがいいな


Thanks!


now it compile fine - no error - Thanks a lot


Rule of thumb:
1. STL headers
2. Other libraries headers
3. In project headers
4. #include "DifferentialCPG.h"
Note: All separated by a blank line


develop (Myoldmopar) - x86_64-Linux-Ubuntu-18.04-gcc-7.3-IntegrationCoverage-Debug: OK (2443 of 2445 tests passed, 0 test warnings)

Failures:

integration Test Summary
 * Passed: 636
 * Timeout: 2

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.92%25-yellow.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-72.25%25-green.png)


idタグ使ってる意味とかはある？


develop (Myoldmopar) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (2 of 2 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


simple_formっていうgemがあって優秀やからそっちに変更したほうがいいかも


  store_id_selector: !grond.Crust2StoreIDSelector
    template: 'crust2_${id}'


just testing ...

![image](https://user-images.githubusercontent.com/3283676/52344993-26e10500-2a42-11e9-8679-2ab106a6cf82.png)

my rating 5/10 ... not fit t merge into master ... you can build from UI branch and test it ...


Successfully aliased the URL <https://freddieridellcom-egx9yxtfw.now.sh> to the following aliases.

* https://freddieridell.com
* https://www.freddieridell.com


END GUARD?


This causes the input box to accept inputs such as `-ff` or `-3f`, even though they get cleaned afterwards. It is a bit strange, since if you don't prefix with a -, `3f` cannot even be typed


Good point


Ok, closed.


Maybe also try a quadratic variant like : pos.rule50_count() * pos.rule50_count() / 16


I'm not sure what the proablem really was, but I fixed the issue by simply resetting the `selected` property if the selected button was unselected: https://github.com/highcharts/highcharts/commit/d67859c2df9193d9af8387fbd3f01e7eb8d893ef


Yup, working on that


Yes.  Consider this very much WIP still...  error handling isn't there yet


my rating ... 6/10 ... need to improve color combinations ...

FYI ... i am testing out icons with(square and circular) and without background ... so far only ones without back ground seem to work ...


oof


I saw the restrictions in `fromJSON NewUserPublic`, just wondering if it might make sense to, additionally, exclude certain combinations (e.g. a ManagedByScim user should not also contain a phone_code). I'm not sure it does, currently spar doesn't do this, and we expect spar to not create such users in the future, but I wonder if in some place we should guard against such potential future behaviour?


Just to make merge easier, i removed this in PK Feature branch


I have *no* idea why I wrote it like that.  Will fix


the future of wildcard will be described in an additional PR handling exactly that topic. For know the example should just fit the general model.


Successfully aliased the URL <https://iamstarkovcom-2cz41iw7p.now.sh> to the following alias.

* https://iamstarkov.com


For refcounting.  If we don't have atomics, then we need a refcount lock.


@buskamuza: out of curiosity, was there a particular reason for this change?

We have Magento 2.2.x shops using `zendframework/zend-view` version 2.11.1, but upgrading such a shop to Magento 2.3.0 downgrades the `zendframework/zend-view` package to version 2.10.1.
I just noticed this and it makes me wonder why this constraint was changed. Is there something in 2.11.x which doesn't work correctly with Magento maybe?

Thanks!


動作確認不足。コミット前に気づけるはずであった


Thanks your video. It is strange. I cannot reproduce this bug on my Windows 10.
It would cause by compile corruption, so please rebuild code?


I was thinking boundary on dock only. would you make a picture with only the square?


Successfully aliased the URL <https://whatsupfranky-79dfi7or1.now.sh> to the following aliases.

* https://whatsupfranky.com
* https://whatsupfrankie.com


Please note that this is pre-OPENSSL_CTX code.  I'm working on the latter now.  However yeah, it might be a good idea to have this lock there...  I think.


that fixes will apply on the updates or i have to edit composer.json file manually !


@Till-Dembek I edited this and think it should be like that (Lead-DBS always uses the last entry in these "applied" files). Just wanted you to know in case I overlooked something.


you have to update your composer.json,
normal you just need to `git pull`


[R/create_mbd_params.R:17:3:](https://github.com/richelbilderbeek/becosys/blob/1a16c97a4615a685249742a08c6fa79d6eb229de/R/create_mbd_params.R#L17) *warning:* **no visible global function definition for ‘check_mbd_params’**
```r
  check_mbd_params(mbd_params)
  ^~~~~~~~~~~~~~~~
```


@tszpartaluk czy tam jest błąd czy jest nie dopisane? "I_s = \frac{\pi D_s^4}{64} =  "
                                                                                ^


I thoroughly *dislike* shoving everything in `OPENSSL_cleanup`, it makes for a disconnect of the code, which I find harder to maintain.

Contrary to what you say, I believe there are only a few of things that actually have to be called directly from `OPENSSL_cleanup`...  those bits that everything else depends on, such as ERR, BIO and memory allocation stuff.


True


Menager dysków logicznych w systemach LINUX.txt

co to jest


Perhaps `ManagedBySCIM` should be restricted to users with a `newUserOrigin` of being associated to a team (some or all of the 3 cases [here](https://github.com/wireapp/wire-server/blob/45448d62a6a81f7d7185deab9ab551bb2d605450/libs/brig-types/src/Brig/Types/User.hs#L276-L278) might apply, not sure exactly if all or only a subset)


I actually can't remember


Refer to https://github.com/languagetool-org/languagetool/pull/1407


TeamCity Identity and Access Management / Build IdAM [Build 111-r0F91DEC](https://teamcity.nice.org.uk/viewLog.html?buildId=49350&buildTypeId=IdentityandAccessManagement_BuildIdAM) outcome was **FAILURE**
Summary: Infrastructure\TestBase.cs(5,21): error CS0234: The type or namespace name 'Models' does not exist in the namespace 'NICE.Identity' (are you missing an assembly reference?)
IntegrationTests\AuditTests.cs(1,21): error CS0234: The type or namespace nam... Build time: 00:02:02


Yes, it should be `ossl_inline`.  And yes, there's no danger having this in a public header, because it doesn't refer to any symbol that will cause the linkage problems we've seen in safestack and lhash


ok I have tried that today, and did the following:

if(Menu7==True)
{

    delay(100);
    T.SetTimer(Hours,Minutes,Seconds);
    delay(100);
    T.Timer();

}

for instance I get for the given Timestamp in the SetTimer the following:
for 8Minutes,13seconds,Milliseconds(random value I suppose) and Microseconds as well

0:8:13:349343:349342776
0:8:13:350640:350639329
0:8:13:351936:351935809
0:8:13:353233:353232273
0:8:13:354529:354528772
0:8:13:355826:355825248
0:8:13:357122:357121709
0:8:13:358419:358418170
0:8:13:359715:359714661
0:8:13:361012:361011112

    I suppose I have to set the milliseconds and microseconds as well=?


> typo ie. Row2/Right

ups: corrected with commit https://github.com/w3c/automotive/commit/a4975850889a02d2ee7c29bb38fbd970d5e1bd65


okay this is epic


There are various grammatical improvements to be made but the only one worth commenting on at this time is

> While holding having...


А зачем тут `.send`?


develop (Myoldmopar) - x86_64-Linux-Ubuntu-18.04-cppcheck-1.82: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-Products.statusmessages/43/violations
```
Products/statusmessages/tests/test_adapter.py:35:15: D001 found directlyProvides( replace it with zope.interface.provider
Products/statusmessages/tests/test_adapter.py:221:0: P102 docstring does contain unindexed parameters
Products/statusmessages/tests/test_adapter.py:241:15: D001 found directlyProvides( replace it with zope.interface.provider
Products/statusmessages/tests/test_adapter.py:308:0: P102 docstring does contain unindexed parameters
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.contentmenu/49/violations
```
plone/app/contentmenu/menu.py:39:1: I003 isort expected 1 blank line in imports, found 0
plone/app/contentmenu/menu.py:61:50: C812 missing trailing comma
plone/app/contentmenu/menu.py:68:39: C812 missing trailing comma
plone/app/contentmenu/menu.py:98:39: C812 missing trailing comma
plone/app/contentmenu/menu.py:141:39: C812 missing trailing comma
plone/app/contentmenu/menu.py:149:52: C812 missing trailing comma
plone/app/contentmenu/menu.py:190:21: C812 missing trailing comma
plone/app/contentmenu/menu.py:238:5: C901 'DisplayMenu.getMenuItems' is too complex (22)
plone/app/contentmenu/menu.py:243:55: C812 missing trailing comma
plone/app/contentmenu/menu.py:334:36: C812 missing trailing comma
plone/app/contentmenu/menu.py:405:36: C812 missing trailing comma
plone/app/contentmenu/menu.py:412:80: C812 missing trailing comma
plone/app/contentmenu/menu.py:477:43: C812 missing trailing comma
plone/app/contentmenu/menu.py:504:39: C812 missing trailing comma
plone/app/contentmenu/menu.py:516:25: C812 missing trailing comma
plone/app/contentmenu/menu.py:748:5: C901 'WorkflowMenu.getMenuItems' is too complex (13)
plone/app/contentmenu/menu.py:865:60: C812 missing trailing comma
plone/app/contentmenu/menu.py:879:25: C812 missing trailing comma
plone/app/contentmenu/menu.py:894:25: C812 missing trailing comma
plone/app/contentmenu/menu.py:909:24: C812 missing trailing comma
plone/app/contentmenu/menu.py:939:28: E128 continuation line under-indented for visual indent
plone/app/contentmenu/menu.py:939:80: E501 line too long (80 > 79 characters)
plone/app/contentmenu/testing.py:17:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/contentmenu/tests/test_menu.py:28:1: I001 isort found an import in the wrong position
plone/app/contentmenu/tests/test_menu.py:55:51: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:86:66: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:98:54: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:133:48: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:137:48: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:142:52: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:147:52: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:156:67: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:177:48: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:182:9: D001 found directlyProvides( replace it with zope.interface.provider
plone/app/contentmenu/tests/test_menu.py:267:57: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:329:43: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:444:68: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:450:69: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:467:76: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:470:80: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:482:68: C812 missing trailing comma
plone/app/contentmenu/tests/test_menu.py:487:9: D001 found directlyProvides( replace it with zope.interface.provider
plone/app/contentmenu/tests/test_menu.py:795:9: D001 found directlyProvides( replace it with zope.interface.provider
plone/app/contentmenu/tests/test_menu.py:934:1: C901 'If 934' is too complex (11)
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.contentrules/79/violations
```
plone/app/contentrules/handlers.py:80:12: P002 found "hasattr", consider replacing it
plone/app/contentrules/handlers.py:82:12: P002 found "hasattr", consider replacing it
plone/app/contentrules/handlers.py:89:8: P002 found "hasattr", consider replacing it
plone/app/contentrules/handlers.py:92:8: P002 found "hasattr", consider replacing it
plone/app/contentrules/actions/copy.py:85:45: C812 missing trailing comma
plone/app/contentrules/actions/copy.py:86:18: C812 missing trailing comma
plone/app/contentrules/actions/copy.py:126:56: C812 missing trailing comma
plone/app/contentrules/actions/logger.py:22:60: C812 missing trailing comma
plone/app/contentrules/actions/logger.py:50:10: C812 missing trailing comma
plone/app/contentrules/actions/logger.py:94:18: C812 missing trailing comma
plone/app/contentrules/actions/mail.py:39:22: C812 missing trailing comma
plone/app/contentrules/actions/mail.py:45:57: C812 missing trailing comma
plone/app/contentrules/actions/mail.py:47:23: C812 missing trailing comma
plone/app/contentrules/actions/mail.py:53:67: C812 missing trailing comma
plone/app/contentrules/actions/mail.py:55:22: C812 missing trailing comma
plone/app/contentrules/actions/mail.py:59:80: C812 missing trailing comma
plone/app/contentrules/actions/mail.py:64:22: C812 missing trailing comma
plone/app/contentrules/actions/mail.py:102:5: C901 'MailActionExecutor.__call__' is too complex (13)
plone/app/contentrules/actions/mail.py:106:74: C812 missing trailing comma
plone/app/contentrules/actions/mail.py:129:78: C812 missing trailing comma
plone/app/contentrules/actions/mail.py:152:19: C812 missing trailing comma
plone/app/contentrules/actions/mail.py:165:19: T000 Todo note found.
plone/app/contentrules/actions/mail.py:176:78: C812 missing trailing comma
plone/app/contentrules/actions/move.py:54:52: C812 missing trailing comma
plone/app/contentrules/actions/move.py:91:18: C812 missing trailing comma
plone/app/contentrules/actions/move.py:144:56: C812 missing trailing comma
plone/app/contentrules/browser/assignments.py:24:5: C901 'ManageAssignments.__call__' is too complex (14)
plone/app/contentrules/browser/assignments.py:154:54: C812 missing trailing comma
plone/app/contentrules/browser/controlpanel.py:83:18: C812 missing trailing comma
plone/app/contentrules/browser/elements.py:29:5: C901 'ManageElements.__call__' is too complex (12)
plone/app/contentrules/browser/elements.py:77:45: C812 missing trailing comma
plone/app/contentrules/conditions/fileextension.py:31:22: C812 missing trailing comma
plone/app/contentrules/conditions/fileextension.py:49:50: C812 missing trailing comma
plone/app/contentrules/conditions/fileextension.py:90:78: C812 missing trailing comma
plone/app/contentrules/conditions/fileextension.py:113:78: C812 missing trailing comma
plone/app/contentrules/conditions/group.py:27:77: C812 missing trailing comma
plone/app/contentrules/conditions/group.py:45:60: C812 missing trailing comma
plone/app/contentrules/conditions/group.py:84:70: C812 missing trailing comma
plone/app/contentrules/conditions/group.py:105:70: C812 missing trailing comma
plone/app/contentrules/conditions/portaltype.py:33:72: C812 missing trailing comma
plone/app/contentrules/conditions/portaltype.py:34:10: C812 missing trailing comma
plone/app/contentrules/conditions/portaltype.py:60:50: C812 missing trailing comma
plone/app/contentrules/conditions/portaltype.py:79:16: P002 found "hasattr", consider replacing it
plone/app/contentrules/conditions/portaltype.py:98:34: C812 missing trailing comma
plone/app/contentrules/conditions/portaltype.py:119:26: C812 missing trailing comma
plone/app/contentrules/conditions/role.py:28:76: C812 missing trailing comma
plone/app/contentrules/conditions/role.py:46:59: C812 missing trailing comma
plone/app/contentrules/conditions/role.py:84:51: C812 missing trailing comma
plone/app/contentrules/conditions/role.py:105:51: C812 missing trailing comma
plone/app/contentrules/conditions/wfstate.py:28:63: C812 missing trailing comma
plone/app/contentrules/conditions/wfstate.py:29:10: C812 missing trailing comma
plone/app/contentrules/conditions/wfstate.py:46:59: C812 missing trailing comma
plone/app/contentrules/conditions/wftransition.py:28:68: C812 missing trailing comma
plone/app/contentrules/conditions/wftransition.py:29:10: C812 missing trailing comma
plone/app/contentrules/exportimport/rules.py:30:1: I004 isort found an unexpected blank line in imports
plone/app/contentrules/exportimport/rules.py:138:11: T000 Todo note found.
plone/app/contentrules/exportimport/rules.py:201:5: C901 'RulesXMLAdapter._initRules' is too complex (21)
plone/app/contentrules/tests/test_action_delete.py:12:1: F401 'plone.app.testing.login' imported but unused
plone/app/contentrules/tests/test_action_delete.py:12:1: I001 isort found an import in the wrong position
plone/app/contentrules/tests/test_action_delete.py:13:1: F401 'plone.app.testing.TEST_USER_ID' imported but unused
plone/app/contentrules/tests/test_action_delete.py:13:1: I001 isort found an import in the wrong position
plone/app/contentrules/tests/test_action_delete.py:14:1: F401 'plone.app.testing.TEST_USER_NAME' imported but unused
plone/app/contentrules/tests/test_action_delete.py:14:1: I001 isort found an import in the wrong position
plone/app/contentrules/tests/test_action_delete.py:15:1: F401 'plone.app.testing.setRoles' imported but unused
plone/app/contentrules/tests/test_action_delete.py:15:1: I001 isort found an import in the wrong position
plone/app/contentrules/tests/test_action_logger.py:6:1: F401 'plone.app.testing.TEST_USER_ID' imported but unused
plone/app/contentrules/tests/test_action_mail.py:50:11: T000 Todo note found.
plone/app/contentrules/tests/test_action_mail.py:95:14: C812 missing trailing comma
plone/app/contentrules/tests/test_action_mail.py:250:73: C812 missing trailing comma
plone/app/contentrules/tests/test_action_workflow.py:70:14: C812 missing trailing comma
plone/app/contentrules/tests/test_action_workflow.py:89:14: C812 missing trailing comma
plone/app/contentrules/tests/test_browser.py:2:80: E501 line too long (84 > 79 characters)
plone/app/contentrules/tests/test_cascading_rule.py:3:80: E501 line too long (84 > 79 characters)
plone/app/contentrules/tests/test_condition_wftransition.py:68:18: C812 missing trailing comma
plone/app/contentrules/tests/test_condition_wftransition.py:83:18: C812 missing trailing comma
plone/app/contentrules/tests/test_condition_wftransition.py:98:18: C812 missing trailing comma
plone/app/contentrules/tests/test_configuration.py:90:80: E501 line too long (85 > 79 characters)
plone/app/contentrules/tests/test_events.py:8:11: T000 Todo note found.
plone/app/contentrules/tests/test_events.py:12:11: T000 Todo note found.
plone/app/contentrules/tests/test_rule_assignment_mapping.py:7:1: F401 'plone.app.contentrules.tests.base.ContentRulesTestCase' imported but unused
plone/app/contentrules/tests/test_traversal.py:4:1: I001 isort found an import in the wrong position
plone/app/contentrules/tests/test_traversal.py:5:1: I001 isort found an import in the wrong position
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.customerize/45/violations
```
plone/app/customerize/testing.py:13:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/customerize/testing.py:16:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/customerize/testing.py:19:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/customerize/registration.py:49:15: P002 found "hasattr", consider replacing it
plone/app/customerize/registration.py:51:11: T000 Todo note found.
plone/app/customerize/registration.py:74:15: T000 Todo note found.
plone/app/customerize/registration.py:112:35: C812 missing trailing comma
plone/app/customerize/registration.py:135:31: C812 missing trailing comma
plone/app/customerize/registration.py:155:7: T000 Todo note found.
plone/app/customerize/tests/testDocTests.py:2:1: I001 isort found an import in the wrong position
plone/app/customerize/tests/testDocTests.py:4:1: I001 isort found an import in the wrong position
plone/app/customerize/tests/testDocTests.py:34:14: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Why does this call need to be inside the read lock?


Ты же уже в методе `instances` присваиваешь 0 в случае `nil`, зачем еще здесь?


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.iterate/82/violations
```
plone/app/iterate/copier.py:37:1: I001 isort found an import in the wrong position
plone/app/iterate/policy.py:57:45: C812 missing trailing comma
plone/app/iterate/policy.py:66:11: T000 Todo note found.
plone/app/iterate/permissions.py:26:1: I003 isort expected 1 blank line in imports, found 0
plone/app/iterate/base.py:160:22: W292 no newline at end of file
plone/app/iterate/testing.py:151:80: E501 line too long (83 > 79 characters)
plone/app/iterate/interfaces.py:321:23: C812 missing trailing comma
plone/app/iterate/interfaces.py:328:22: C812 missing trailing comma
plone/app/iterate/__init__.py:48:78: C812 missing trailing comma
plone/app/iterate/setuphandlers.py:11:27: C812 missing trailing comma
plone/app/iterate/event.py:28:1: I004 isort found an unexpected blank line in imports
plone/app/iterate/event.py:29:1: I001 isort found an import in the wrong position
plone/app/iterate/containers.py:72:50: C812 missing trailing comma
plone/app/iterate/containers.py:73:14: C812 missing trailing comma
plone/app/iterate/archiver.py:26:1: I004 isort found an unexpected blank line in imports
plone/app/iterate/archiver.py:27:1: I001 isort found an import in the wrong position
plone/app/iterate/browser/checkout.py:70:33: C812 missing trailing comma
plone/app/iterate/dexterity/copier.py:5:1: I001 isort found an import in the wrong position
plone/app/iterate/dexterity/copier.py:67:19: T000 Todo note found.
plone/app/iterate/dexterity/copier.py:157:50: C812 missing trailing comma
plone/app/iterate/dexterity/utils.py:25:18: C812 missing trailing comma
plone/app/iterate/tests/test_iterate.py:171:80: E501 line too long (97 > 79 characters)
plone/app/iterate/tests/test_iterate_at.py:35:1: I003 isort expected 1 blank line in imports, found 0
plone/app/iterate/tests/test_iterate_at.py:42:5: E301 expected 1 blank line, found 0
plone/app/iterate/tests/test_iterate_at.py:52:80: E501 line too long (85 > 79 characters)
plone/app/iterate/tests/test_iterate_at.py:154:11: T000 Todo note found.
plone/app/iterate/tests/test_iterate_at.py:302:80: E501 line too long (97 > 79 characters)
plone/app/iterate/tests/test_doctests.py:6:1: I003 isort expected 1 blank line in imports, found 0
plone/app/iterate/tests/test_doctests.py:7:1: I003 isort expected 1 blank line in imports, found 0
plone/app/iterate/tests/test_doctests.py:9:5: F401 'Products.ATContentTypes' imported but unused
plone/app/iterate/tests/test_doctests.py:26:54: C812 missing trailing comma
plone/app/iterate/tests/test_doctests.py:34:53: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Hey ... It's time for r60 please update it ASAP!