## Securify Report
There were 75 violations and 41 warnings found. Additionally, there are 28 cases that Securify couldn't identify correctly. To give feedback, please visit [securify.ch](https://securify.ch).

### [contracts/crowdsale/Crowdsale.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/crowdsale/Crowdsale.sol):`Crowdsale`

There were 1 violations and 2 warnings found. Additionally, there are 1 cases that Securify couldn't identify correctly.

TODAmount

- Warning on line [196](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/crowdsale/Crowdsale.sol#L196)
```js
       */
      function _forwardFunds() internal {
          _wallet.transfer(msg.value);    // <===
      }

```

UnrestrictedEtherFlow

- Warning on line [196](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/crowdsale/Crowdsale.sol#L196)
```js
       */
      function _forwardFunds() internal {
          _wallet.transfer(msg.value);    // <===
      }

```

UnrestrictedWrite

- Violation on line [24](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/crowdsale/Crowdsale.sol#L24)
```js
      using SafeERC20 for IERC20;

      // The token being sold    // <===
      IERC20 private _token;

```

- Conflict on line [118](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/crowdsale/Crowdsale.sol#L118)
```js

          // update state
          _weiRaised = _weiRaised.add(weiAmount);    // <===

          _processPurchase(beneficiary, tokens);
```

### [contracts/drafts/ERC1046/ERC20Metadata.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/drafts/ERC1046/ERC20Metadata.sol):`ERC20Metadata`

There were 1 violations and 0 warnings found.

LockedEther

- Violation on line [10](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/drafts/ERC1046/ERC20Metadata.sol#L10)
```js
   * @dev tokenURI must respond with a URI that implements https://eips.ethereum.org/EIPS/eip-1047
   */
  contract ERC20Metadata {    // <===
      string private _tokenURI;

```

### [contracts/drafts/ERC20Migrator.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/drafts/ERC20Migrator.sol):`ERC20Migrator`

There were 2 violations and 0 warnings found.

LockedEther

- Violation on line [34](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/drafts/ERC20Migrator.sol#L34)
```js
   * ```
   */
  contract ERC20Migrator {    // <===
      using SafeERC20 for IERC20;

```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [75](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/drafts/ERC20Migrator.sol#L75)
```js
          require(newToken_.isMinter(address(this)));

          _newToken = newToken_;    // <===
      }

```

</details>

</details>

### [contracts/drafts/ERC20Snapshot.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/drafts/ERC20Snapshot.sol):`ERC20Snapshot`

<details><summary><strong>There were 1 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [27](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/drafts/ERC20Snapshot.sol#L27)
```js

      // Snapshotted values have arrays of ids and the value corresponding to that id. These could be an array of a
      // Snapshot struct, but that would impede usage of functions that work on an array.    // <===
      struct Snapshots {
          uint256[] ids;
```

</details>

</details>

### [contracts/drafts/TokenVesting.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/drafts/TokenVesting.sol):`TokenVesting`

<details><summary><strong>There were 2 violations and 0 warnings found. Additionally, there are 4 cases that Securify couldn't identify correctly.

</strong></summary>

<details><summary><strong>LockedEther</strong></summary>

- Violation on line [13](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/drafts/TokenVesting.sol#L13)
```js
   * owner.
   */
  contract TokenVesting is Ownable {    // <===
      // The vesting schedule is time-based (i.e. using block timestamps as opposed to e.g. block numbers), and is
      // therefore sensitive to timestamp manipulation (which is something miners can do, to a certain degree). Therefore,
```

</details>

<details><summary><strong>RepeatedCall</strong></summary>

- Violation on line [161](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/drafts/TokenVesting.sol#L161)
```js
       */
      function _vestedAmount(IERC20 token) private view returns (uint256) {
          uint256 currentBalance = token.balanceOf(address(this));    // <===
          uint256 totalBalance = currentBalance.add(_released[address(token)]);

```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Conflict on line [41](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/drafts/TokenVesting.sol#L41)
```js
      /**
       * @dev Creates a vesting contract that vests its balance of any ERC20 token to the
       * beneficiary, gradually in a linear fashion until start + duration. By then all    // <===
       * of the balance will have vested.
       * @param beneficiary address of the beneficiary to whom vested tokens are transferred
```

- Conflict on line [49](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/drafts/TokenVesting.sol#L49)
```js
       * @param revocable whether the vesting is revocable or not
       */
      constructor (address beneficiary, uint256 start, uint256 cliffDuration, uint256 duration, bool revocable) public {    // <===
          require(beneficiary != address(0));
          require(cliffDuration <= duration);
```

- Conflict on line [120](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/drafts/TokenVesting.sol#L120)
```js
          require(unreleased > 0);

          _released[address(token)] = _released[address(token)].add(unreleased);    // <===

          token.safeTransfer(_beneficiary, unreleased);
```

- Conflict on line [141](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/drafts/TokenVesting.sol#L141)
```js
          uint256 refund = balance.sub(unreleased);

          _revoked[address(token)] = true;    // <===

          token.safeTransfer(owner(), refund);
```

</details>

</details>

### [contracts/examples/SampleCrowdsale.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/examples/SampleCrowdsale.sol):`SampleCrowdsale`

<details><summary><strong>There were 2 violations and 0 warnings found. Additionally, there are 1 cases that Securify couldn't identify correctly.

</strong></summary>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [25](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/examples/SampleCrowdsale.sol#L25)
```js
   * The way to add new features to a base crowdsale is by multiple inheritance.
   * In this example we are providing following extensions:
   * CappedCrowdsale - sets a max boundary for raised funds    // <===
   * RefundableCrowdsale - set a min goal to be reached and returns funds if it's not met
   * MintedCrowdsale - assumes the token can be minted by the crowdsale, which does so
```

- Violation on line [26](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/examples/SampleCrowdsale.sol#L26)
```js
   * In this example we are providing following extensions:
   * CappedCrowdsale - sets a max boundary for raised funds
   * RefundableCrowdsale - set a min goal to be reached and returns funds if it's not met    // <===
   * MintedCrowdsale - assumes the token can be minted by the crowdsale, which does so
   * when receiving purchases.
```

- Conflict on line [54](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/examples/SampleCrowdsale.sol#L54)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/examples/SampleCrowdsale.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/examples/SampleCrowdsale.sol):`SampleCrowdsaleToken`

<details><summary><strong>There were 1 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>LockedEther</strong></summary>

- Violation on line [14](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/examples/SampleCrowdsale.sol#L14)
```js
   * It is meant to be used in a crowdsale contract.
   */
  contract SampleCrowdsaleToken is ERC20Mintable, ERC20Detailed {    // <===
      constructor () public ERC20Detailed("Sample Crowdsale Token", "SCT", 18) {
          // solhint-disable-previous-line no-empty-blocks
```

</details>

</details>

### [contracts/examples/SimpleToken.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/examples/SimpleToken.sol):`SimpleToken`

<details><summary><strong>There were 1 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>LockedEther</strong></summary>

- Violation on line [12](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/examples/SimpleToken.sol#L12)
```js
   * `ERC20` functions.
   */
  contract SimpleToken is ERC20, ERC20Detailed {    // <===
      uint8 public constant DECIMALS = 18;
      uint256 public constant INITIAL_SUPPLY = 10000 * (10 ** uint256(DECIMALS));
```

</details>

</details>

### [contracts/mocks/Acknowledger.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/Acknowledger.sol):`Acknowledger`

<details><summary><strong>There were 3 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>MissingInputValidation</strong></summary>

- Violation on line [8](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/Acknowledger.sol#L8)
```js
      event AcknowledgeBarDouble(uint256 a, uint256 b);

      function foo(uint256 a) public {    // <===
          emit AcknowledgeFoo(a);
      }
```

- Violation on line [12](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/Acknowledger.sol#L12)
```js
      }

      function bar(uint256 a) public {    // <===
          emit AcknowledgeBarSingle(a);
      }
```

- Violation on line [16](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/Acknowledger.sol#L16)
```js
      }

      function bar(uint256 a, uint256 b) public {    // <===
          emit AcknowledgeBarDouble(a, b);
      }
```

</details>

</details>

### [contracts/mocks/AllowanceCrowdsaleImpl.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/AllowanceCrowdsaleImpl.sol):`AllowanceCrowdsaleImpl`

<details><summary><strong>There were 2 violations and 3 warnings found.

</strong></summary>

<details><summary><strong>RepeatedCall</strong></summary>

- Violation on line [15](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/AllowanceCrowdsaleImpl.sol#L15)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>TODAmount</strong></summary>

- Warning on line [15](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/AllowanceCrowdsaleImpl.sol#L15)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>TODReceiver</strong></summary>

- Warning on line [15](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/AllowanceCrowdsaleImpl.sol#L15)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>UnrestrictedEtherFlow</strong></summary>

- Warning on line [15](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/AllowanceCrowdsaleImpl.sol#L15)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [15](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/AllowanceCrowdsaleImpl.sol#L15)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/mocks/CappedCrowdsaleImpl.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/CappedCrowdsaleImpl.sol):`CappedCrowdsaleImpl`

<details><summary><strong>There were 1 violations and 2 warnings found. Additionally, there are 1 cases that Securify couldn't identify correctly.

</strong></summary>

<details><summary><strong>TODAmount</strong></summary>

- Warning on line [15](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/CappedCrowdsaleImpl.sol#L15)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>UnrestrictedEtherFlow</strong></summary>

- Warning on line [15](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/CappedCrowdsaleImpl.sol#L15)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [15](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/CappedCrowdsaleImpl.sol#L15)
```js
      }
  }
      // <===
```

- Conflict on line [15](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/CappedCrowdsaleImpl.sol#L15)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/mocks/ConditionalEscrowMock.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ConditionalEscrowMock.sol):`ConditionalEscrowMock`

<details><summary><strong>There were 1 violations and 1 warnings found. Additionally, there are 1 cases that Securify couldn't identify correctly.

</strong></summary>

<details><summary><strong>TODAmount</strong></summary>

- Warning on line [17](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ConditionalEscrowMock.sol#L17)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [10](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ConditionalEscrowMock.sol#L10)
```js

      function setAllowed(address payee, bool allowed) public {
          _allowed[payee] = allowed;    // <===
      }

```

- Conflict on line [17](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ConditionalEscrowMock.sol#L17)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/mocks/CountersImpl.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/CountersImpl.sol):`CountersImpl`

<details><summary><strong>There were 1 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [22](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/CountersImpl.sol#L22)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/mocks/CrowdsaleMock.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/CrowdsaleMock.sol):`CrowdsaleMock`

<details><summary><strong>There were 1 violations and 2 warnings found. Additionally, there are 1 cases that Securify couldn't identify correctly.

</strong></summary>

<details><summary><strong>TODAmount</strong></summary>

- Warning on line [10](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/CrowdsaleMock.sol#L10)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>UnrestrictedEtherFlow</strong></summary>

- Warning on line [10](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/CrowdsaleMock.sol#L10)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [10](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/CrowdsaleMock.sol#L10)
```js
      }
  }
      // <===
```

- Conflict on line [10](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/CrowdsaleMock.sol#L10)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/mocks/ERC165/ERC165InterfacesSupported.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC165/ERC165InterfacesSupported.sol):`ERC165InterfacesSupported`

<details><summary><strong>There were 1 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>MissingInputValidation</strong></summary>

- Violation on line [38](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC165/ERC165InterfacesSupported.sol#L38)
```js
       * @dev implement supportsInterface(bytes4) using a lookup table
       */
      function supportsInterface(bytes4 interfaceId) external view returns (bool) {    // <===
          return _supportedInterfaces[interfaceId];
      }
```

</details>

</details>

### [contracts/mocks/ERC165/ERC165InterfacesSupported.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC165/ERC165InterfacesSupported.sol):`SupportsInterfaceWithLookupMock`

<details><summary><strong>There were 1 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>MissingInputValidation</strong></summary>

- Violation on line [38](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC165/ERC165InterfacesSupported.sol#L38)
```js
       * @dev implement supportsInterface(bytes4) using a lookup table
       */
      function supportsInterface(bytes4 interfaceId) external view returns (bool) {    // <===
          return _supportedInterfaces[interfaceId];
      }
```

</details>

</details>

### [contracts/mocks/ERC165CheckerMock.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC165CheckerMock.sol):`ERC165CheckerMock`

<details><summary><strong>There were 1 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>RepeatedCall</strong></summary>

- Violation on line [20](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC165CheckerMock.sol#L20)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/mocks/ERC165Mock.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC165Mock.sol):`ERC165Mock`

<details><summary><strong>There were 2 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>MissingInputValidation</strong></summary>

- Violation on line [10](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC165Mock.sol#L10)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [10](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC165Mock.sol#L10)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/mocks/ERC20DetailedMock.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC20DetailedMock.sol):`ERC20DetailedMock`

<details><summary><strong>There were 1 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>LockedEther</strong></summary>

- Violation on line [6](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC20DetailedMock.sol#L6)
```js
  import "../token/ERC20/ERC20Detailed.sol";

  contract ERC20DetailedMock is ERC20, ERC20Detailed {    // <===
      constructor (string memory name, string memory symbol, uint8 decimals)
          public
```

</details>

</details>

### [contracts/mocks/ERC20MetadataMock.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC20MetadataMock.sol):`ERC20MetadataMock`

<details><summary><strong>There were 2 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>LockedEther</strong></summary>

- Violation on line [6](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC20MetadataMock.sol#L6)
```js
  import "../drafts/ERC1046/ERC20Metadata.sol";

  contract ERC20MetadataMock is ERC20, ERC20Metadata {    // <===
      constructor (string memory tokenURI) public ERC20Metadata(tokenURI) {
          // solhint-disable-previous-line no-empty-blocks
```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [6](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC20MetadataMock.sol#L6)
```js
  import "../drafts/ERC1046/ERC20Metadata.sol";

  contract ERC20MetadataMock is ERC20, ERC20Metadata {    // <===
      constructor (string memory tokenURI) public ERC20Metadata(tokenURI) {
          // solhint-disable-previous-line no-empty-blocks
```

</details>

</details>

### [contracts/mocks/ERC20PausableMock.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC20PausableMock.sol):`ERC20PausableMock`

<details><summary><strong>There were 0 violations and 0 warnings found. Additionally, there are 1 cases that Securify couldn't identify correctly.

</strong></summary>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Conflict on line [12](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC20PausableMock.sol#L12)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/mocks/ERC20SnapshotMock.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC20SnapshotMock.sol):`ERC20SnapshotMock`

<details><summary><strong>There were 0 violations and 1 warnings found.

</strong></summary>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Warning on line [19](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC20SnapshotMock.sol#L19)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/mocks/ERC721FullMock.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC721FullMock.sol):`ERC721FullMock`

<details><summary><strong>There were 1 violations and 1 warnings found.

</strong></summary>

<details><summary><strong>LockedEther</strong></summary>

- Violation on line [13](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC721FullMock.sol#L13)
```js
   * checking token existence, removal of a token from an address
   */
  contract ERC721FullMock is ERC721Full, ERC721Mintable, ERC721MetadataMintable, ERC721Burnable {    // <===
      constructor (string memory name, string memory symbol) public ERC721Mintable() ERC721Full(name, symbol) {
          // solhint-disable-previous-line no-empty-blocks
```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Warning on line [13](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC721FullMock.sol#L13)
```js
   * checking token existence, removal of a token from an address
   */
  contract ERC721FullMock is ERC721Full, ERC721Mintable, ERC721MetadataMintable, ERC721Burnable {    // <===
      constructor (string memory name, string memory symbol) public ERC721Mintable() ERC721Full(name, symbol) {
          // solhint-disable-previous-line no-empty-blocks
```

</details>

</details>

### [contracts/mocks/ERC721MintableBurnableImpl.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC721MintableBurnableImpl.sol):`ERC721MintableBurnableImpl`

<details><summary><strong>There were 1 violations and 1 warnings found.

</strong></summary>

<details><summary><strong>LockedEther</strong></summary>

- Violation on line [11](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC721MintableBurnableImpl.sol#L11)
```js
   * @title ERC721MintableBurnableImpl
   */
  contract ERC721MintableBurnableImpl is ERC721Full, ERC721Mintable, ERC721MetadataMintable, ERC721Burnable {    // <===
      constructor () public ERC721Mintable() ERC721Full("Test", "TEST") {
          // solhint-disable-previous-line no-empty-blocks
```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Warning on line [11](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC721MintableBurnableImpl.sol#L11)
```js
   * @title ERC721MintableBurnableImpl
   */
  contract ERC721MintableBurnableImpl is ERC721Full, ERC721Mintable, ERC721MetadataMintable, ERC721Burnable {    // <===
      constructor () public ERC721Mintable() ERC721Full("Test", "TEST") {
          // solhint-disable-previous-line no-empty-blocks
```

</details>

</details>

### [contracts/mocks/ERC721ReceiverMock.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC721ReceiverMock.sol):`ERC721ReceiverMock`

<details><summary><strong>There were 1 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>MissingInputValidation</strong></summary>

- Violation on line [16](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ERC721ReceiverMock.sol#L16)
```js
      }

      function onERC721Received(address operator, address from, uint256 tokenId, bytes memory data)    // <===
          public returns (bytes4)
      {
```

</details>

</details>

### [contracts/mocks/EventEmitter.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/EventEmitter.sol):`EventEmitter`

<details><summary><strong>There were 1 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>LockedEther</strong></summary>

- Violation on line [3](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/EventEmitter.sol#L3)
```js
  pragma solidity ^0.5.2;

  contract EventEmitter {    // <===
      event Argumentless();
      event ShortUint(uint8 value);
```

</details>

</details>

### [contracts/mocks/Failer.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/Failer.sol):`Failer`

<details><summary><strong>There were 3 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>LockedEther</strong></summary>

- Violation on line [3](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/Failer.sol#L3)
```js
  pragma solidity ^0.5.2;

  contract Failer {    // <===
      uint256[] private array;

```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [4](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/Failer.sol#L4)
```js

  contract Failer {
      uint256[] private array;    // <===

      function dontFail() public pure {
```

- Violation on line [20](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/Failer.sol#L20)
```js
      function failWithOutOfGas() public {
          for (uint256 i = 0; i < 2**200; ++i) {
              array.push(i);    // <===
          }
      }
```

</details>

</details>

### [contracts/mocks/FinalizableCrowdsaleImpl.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/FinalizableCrowdsaleImpl.sol):`FinalizableCrowdsaleImpl`

<details><summary><strong>There were 1 violations and 2 warnings found. Additionally, there are 1 cases that Securify couldn't identify correctly.

</strong></summary>

<details><summary><strong>TODAmount</strong></summary>

- Warning on line [15](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/FinalizableCrowdsaleImpl.sol#L15)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>UnrestrictedEtherFlow</strong></summary>

- Warning on line [15](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/FinalizableCrowdsaleImpl.sol#L15)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [15](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/FinalizableCrowdsaleImpl.sol#L15)
```js
      }
  }
      // <===
```

- Conflict on line [15](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/FinalizableCrowdsaleImpl.sol#L15)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/mocks/IncreasingPriceCrowdsaleImpl.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/IncreasingPriceCrowdsaleImpl.sol):`IncreasingPriceCrowdsaleImpl`

<details><summary><strong>There were 1 violations and 3 warnings found.

</strong></summary>

<details><summary><strong>TODAmount</strong></summary>

- Warning on line [23](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/IncreasingPriceCrowdsaleImpl.sol#L23)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>TODReceiver</strong></summary>

- Warning on line [23](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/IncreasingPriceCrowdsaleImpl.sol#L23)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>UnrestrictedEtherFlow</strong></summary>

- Warning on line [23](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/IncreasingPriceCrowdsaleImpl.sol#L23)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [23](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/IncreasingPriceCrowdsaleImpl.sol#L23)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/mocks/IndividuallyCappedCrowdsaleImpl.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/IndividuallyCappedCrowdsaleImpl.sol):`IndividuallyCappedCrowdsaleImpl`

<details><summary><strong>There were 1 violations and 3 warnings found.

</strong></summary>

<details><summary><strong>RepeatedCall</strong></summary>

- Violation on line [12](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/IndividuallyCappedCrowdsaleImpl.sol#L12)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>TODAmount</strong></summary>

- Warning on line [12](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/IndividuallyCappedCrowdsaleImpl.sol#L12)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>TODReceiver</strong></summary>

- Warning on line [12](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/IndividuallyCappedCrowdsaleImpl.sol#L12)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Warning on line [12](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/IndividuallyCappedCrowdsaleImpl.sol#L12)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/mocks/MerkleProofWrapper.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/MerkleProofWrapper.sol):`MerkleProofWrapper`

<details><summary><strong>There were 0 violations and 1 warnings found.

</strong></summary>

<details><summary><strong>MissingInputValidation</strong></summary>

- Warning on line [6](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/MerkleProofWrapper.sol#L6)
```js

  contract MerkleProofWrapper {
      function verify(bytes32[] memory proof, bytes32 root, bytes32 leaf) public pure returns (bool) {    // <===
          return MerkleProof.verify(proof, root, leaf);
      }
```

</details>

</details>

### [contracts/mocks/MintedCrowdsaleImpl.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/MintedCrowdsaleImpl.sol):`MintedCrowdsaleImpl`

<details><summary><strong>There were 1 violations and 1 warnings found. Additionally, there are 1 cases that Securify couldn't identify correctly.

</strong></summary>

<details><summary><strong>TODAmount</strong></summary>

- Warning on line [11](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/MintedCrowdsaleImpl.sol#L11)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [11](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/MintedCrowdsaleImpl.sol#L11)
```js
      }
  }
      // <===
```

- Conflict on line [11](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/MintedCrowdsaleImpl.sol#L11)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/mocks/OwnableMock.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/OwnableMock.sol):`OwnableMock`

<details><summary><strong>There were 1 violations and 0 warnings found. Additionally, there are 1 cases that Securify couldn't identify correctly.

</strong></summary>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [8](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/OwnableMock.sol#L8)
```js
      // solhint-disable-previous-line no-empty-blocks
  }
      // <===
```

- Conflict on line [8](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/OwnableMock.sol#L8)
```js
      // solhint-disable-previous-line no-empty-blocks
  }
      // <===
```

</details>

</details>

### [contracts/mocks/PausableCrowdsaleImpl.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/PausableCrowdsaleImpl.sol):`PausableCrowdsaleImpl`

<details><summary><strong>There were 1 violations and 2 warnings found. Additionally, there are 1 cases that Securify couldn't identify correctly.

</strong></summary>

<details><summary><strong>TODAmount</strong></summary>

- Warning on line [11](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/PausableCrowdsaleImpl.sol#L11)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>UnrestrictedEtherFlow</strong></summary>

- Warning on line [11](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/PausableCrowdsaleImpl.sol#L11)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [11](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/PausableCrowdsaleImpl.sol#L11)
```js
      }
  }
      // <===
```

- Conflict on line [11](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/PausableCrowdsaleImpl.sol#L11)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/mocks/PausableMock.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/PausableMock.sol):`PausableMock`

<details><summary><strong>There were 2 violations and 0 warnings found. Additionally, there are 1 cases that Securify couldn't identify correctly.

</strong></summary>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [17](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/PausableMock.sol#L17)
```js

      function normalProcess() external whenNotPaused {
          count++;    // <===
      }

```

- Violation on line [21](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/PausableMock.sol#L21)
```js

      function drasticMeasure() external whenPaused {
          drasticMeasureTaken = true;    // <===
      }
  }
```

- Conflict on line [24](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/PausableMock.sol#L24)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/mocks/PostDeliveryCrowdsaleImpl.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/PostDeliveryCrowdsaleImpl.sol):`PostDeliveryCrowdsaleImpl`

<details><summary><strong>There were 1 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [15](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/PostDeliveryCrowdsaleImpl.sol#L15)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/mocks/PullPaymentMock.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/PullPaymentMock.sol):`PullPaymentMock`

<details><summary><strong>There were 3 violations and 3 warnings found.

</strong></summary>

<details><summary><strong>MissingInputValidation</strong></summary>

- Violation on line [12](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/PullPaymentMock.sol#L12)
```js

      // test helper function to call asyncTransfer
      function callTransfer(address dest, uint256 amount) public {    // <===
          _asyncTransfer(dest, amount);
      }
```

- Violation on line [16](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/PullPaymentMock.sol#L16)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>TODAmount</strong></summary>

- Warning on line [16](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/PullPaymentMock.sol#L16)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>TODReceiver</strong></summary>

- Warning on line [16](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/PullPaymentMock.sol#L16)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>UnrestrictedEtherFlow</strong></summary>

- Violation on line [16](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/PullPaymentMock.sol#L16)
```js
      }
  }
      // <===
```

- Warning on line [16](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/PullPaymentMock.sol#L16)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/mocks/ReentrancyAttack.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ReentrancyAttack.sol):`ReentrancyAttack`

<details><summary><strong>There were 1 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>MissingInputValidation</strong></summary>

- Violation on line [4](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ReentrancyAttack.sol#L4)
```js

  contract ReentrancyAttack {
      function callSender(bytes4 data) public {    // <===
          // solhint-disable-next-line avoid-low-level-calls
          (bool success,) = msg.sender.call(abi.encodeWithSelector(data));
```

</details>

</details>

### [contracts/mocks/ReentrancyMock.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ReentrancyMock.sol):`ReentrancyMock`

<details><summary><strong>There were 2 violations and 1 warnings found.

</strong></summary>

<details><summary><strong>MissingInputValidation</strong></summary>

- Warning on line [24](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ReentrancyMock.sol#L24)
```js
      }

      function countThisRecursive(uint256 n) public nonReentrant {    // <===
          if (n > 0) {
              count();
```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [39](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ReentrancyMock.sol#L39)
```js
      }

      function count() private {    // <===
          counter += 1;
      }
```

- Violation on line [40](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/ReentrancyMock.sol#L40)
```js

      function count() private {
          counter += 1;    // <===
      }
  }
```

</details>

</details>

### [contracts/mocks/RefundableCrowdsaleImpl.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/RefundableCrowdsaleImpl.sol):`RefundableCrowdsaleImpl`

<details><summary><strong>There were 1 violations and 1 warnings found. Additionally, there are 1 cases that Securify couldn't identify correctly.

</strong></summary>

<details><summary><strong>UnrestrictedEtherFlow</strong></summary>

- Warning on line [23](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/RefundableCrowdsaleImpl.sol#L23)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [23](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/RefundableCrowdsaleImpl.sol#L23)
```js
      }
  }
      // <===
```

- Conflict on line [23](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/RefundableCrowdsaleImpl.sol#L23)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/mocks/RefundablePostDeliveryCrowdsaleImpl.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/RefundablePostDeliveryCrowdsaleImpl.sol):`RefundablePostDeliveryCrowdsaleImpl`

<details><summary><strong>There were 1 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [23](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/RefundablePostDeliveryCrowdsaleImpl.sol#L23)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/mocks/RolesMock.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/RolesMock.sol):`RolesMock`

<details><summary><strong>There were 2 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [19](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/RolesMock.sol#L19)
```js

      function has(address account) public view returns (bool) {
          return dummyRole.has(account);    // <===
      }
  }
```

- Violation on line [22](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/RolesMock.sol#L22)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/mocks/SafeERC20Helper.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/SafeERC20Helper.sol):`ERC20NoReturnMock`

<details><summary><strong>There were 5 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>MissingInputValidation</strong></summary>

- Violation on line [84](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/SafeERC20Helper.sol#L84)
```js
      }

      function setAllowance(uint256 allowance_) public {    // <===
          _allowances[msg.sender] = allowance_;
      }
```

- Violation on line [88](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/SafeERC20Helper.sol#L88)
```js
      }

      function allowance(address owner, address) public view returns (uint256) {    // <===
          return _allowances[owner];
      }
```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [73](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/SafeERC20Helper.sol#L73)
```js

      function transfer(address, uint256) public {
          _dummy = 0;    // <===
      }

```

- Violation on line [77](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/SafeERC20Helper.sol#L77)
```js

      function transferFrom(address, address, uint256) public {
          _dummy = 0;    // <===
      }

```

- Violation on line [81](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/SafeERC20Helper.sol#L81)
```js

      function approve(address, uint256) public {
          _dummy = 0;    // <===
      }

```

</details>

</details>

### [contracts/mocks/SafeERC20Helper.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/SafeERC20Helper.sol):`ERC20ReturnFalseMock`

<details><summary><strong>There were 3 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [14](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/SafeERC20Helper.sol#L14)
```js

      function transfer(address, uint256) public returns (bool) {
          _dummy = 0;    // <===
          return false;
      }
```

- Violation on line [19](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/SafeERC20Helper.sol#L19)
```js

      function transferFrom(address, address, uint256) public returns (bool) {
          _dummy = 0;    // <===
          return false;
      }
```

- Violation on line [24](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/SafeERC20Helper.sol#L24)
```js

      function approve(address, uint256) public returns (bool) {
          _dummy = 0;    // <===
          return false;
      }
```

</details>

</details>

### [contracts/mocks/SafeERC20Helper.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/SafeERC20Helper.sol):`ERC20ReturnTrueMock`

<details><summary><strong>There were 3 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [42](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/SafeERC20Helper.sol#L42)
```js

      function transfer(address, uint256) public returns (bool) {
          _dummy = 0;    // <===
          return true;
      }
```

- Violation on line [47](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/SafeERC20Helper.sol#L47)
```js

      function transferFrom(address, address, uint256) public returns (bool) {
          _dummy = 0;    // <===
          return true;
      }
```

- Violation on line [52](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/SafeERC20Helper.sol#L52)
```js

      function approve(address, uint256) public returns (bool) {
          _dummy = 0;    // <===
          return true;
      }
```

</details>

</details>

### [contracts/mocks/SafeERC20Helper.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/SafeERC20Helper.sol):`SafeERC20Wrapper`

<details><summary><strong>There were 1 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>LockedEther</strong></summary>

- Violation on line [93](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/SafeERC20Helper.sol#L93)
```js
  }

  contract SafeERC20Wrapper {    // <===
      using SafeERC20 for IERC20;

```

</details>

</details>

### [contracts/mocks/SecondaryMock.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/SecondaryMock.sol):`SecondaryMock`

<details><summary><strong>There were 0 violations and 0 warnings found. Additionally, there are 1 cases that Securify couldn't identify correctly.

</strong></summary>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Conflict on line [10](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/SecondaryMock.sol#L10)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/mocks/TimedCrowdsaleImpl.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/TimedCrowdsaleImpl.sol):`TimedCrowdsaleImpl`

<details><summary><strong>There were 1 violations and 2 warnings found. Additionally, there are 1 cases that Securify couldn't identify correctly.

</strong></summary>

<details><summary><strong>TODAmount</strong></summary>

- Warning on line [19](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/TimedCrowdsaleImpl.sol#L19)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>UnrestrictedEtherFlow</strong></summary>

- Warning on line [19](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/TimedCrowdsaleImpl.sol#L19)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [19](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/TimedCrowdsaleImpl.sol#L19)
```js
      }
  }
      // <===
```

- Conflict on line [19](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/TimedCrowdsaleImpl.sol#L19)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/mocks/WhitelistCrowdsaleImpl.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/WhitelistCrowdsaleImpl.sol):`WhitelistCrowdsaleImpl`

<details><summary><strong>There were 1 violations and 2 warnings found.

</strong></summary>

<details><summary><strong>TODAmount</strong></summary>

- Warning on line [13](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/WhitelistCrowdsaleImpl.sol#L13)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>UnrestrictedEtherFlow</strong></summary>

- Warning on line [13](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/WhitelistCrowdsaleImpl.sol#L13)
```js
      }
  }
      // <===
```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [13](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/mocks/WhitelistCrowdsaleImpl.sol#L13)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/payment/PaymentSplitter.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/payment/PaymentSplitter.sol):`PaymentSplitter`

<details><summary><strong>There were 2 violations and 2 warnings found. Additionally, there are 1 cases that Securify couldn't identify correctly.

</strong></summary>

<details><summary><strong>TODAmount</strong></summary>

- Warning on line [93](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/payment/PaymentSplitter.sol#L93)
```js
          _totalReleased = _totalReleased.add(payment);

          account.transfer(payment);    // <===
          emit PaymentReleased(account, payment);
      }
```

</details>

<details><summary><strong>TODReceiver</strong></summary>

- Conflict on line [93](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/payment/PaymentSplitter.sol#L93)
```js
          _totalReleased = _totalReleased.add(payment);

          account.transfer(payment);    // <===
          emit PaymentReleased(account, payment);
      }
```

</details>

<details><summary><strong>UnrestrictedEtherFlow</strong></summary>

- Warning on line [93](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/payment/PaymentSplitter.sol#L93)
```js
          _totalReleased = _totalReleased.add(payment);

          account.transfer(payment);    // <===
          emit PaymentReleased(account, payment);
      }
```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Violation on line [90](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/payment/PaymentSplitter.sol#L90)
```js
          require(payment != 0);

          _released[account] = _released[account].add(payment);    // <===
          _totalReleased = _totalReleased.add(payment);

```

- Violation on line [91](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/payment/PaymentSplitter.sol#L91)
```js

          _released[account] = _released[account].add(payment);
          _totalReleased = _totalReleased.add(payment);    // <===

          account.transfer(payment);
```

</details>

</details>

### [contracts/payment/escrow/Escrow.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/payment/escrow/Escrow.sol):`Escrow`

<details><summary><strong>There were 0 violations and 1 warnings found. Additionally, there are 3 cases that Securify couldn't identify correctly.

</strong></summary>

<details><summary><strong>TODAmount</strong></summary>

- Warning on line [50](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/payment/escrow/Escrow.sol#L50)
```js
          _deposits[payee] = 0;

          payee.transfer(payment);    // <===

          emit Withdrawn(payee, payment);
```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Conflict on line [26](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/payment/escrow/Escrow.sol#L26)
```js
      mapping(address => uint256) private _deposits;

      function depositsOf(address payee) public view returns (uint256) {    // <===
          return _deposits[payee];
      }
```

- Conflict on line [36](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/payment/escrow/Escrow.sol#L36)
```js
      function deposit(address payee) public onlyPrimary payable {
          uint256 amount = msg.value;
          _deposits[payee] = _deposits[payee].add(amount);    // <===

          emit Deposited(payee, amount);
```

- Conflict on line [48](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/payment/escrow/Escrow.sol#L48)
```js
          uint256 payment = _deposits[payee];

          _deposits[payee] = 0;    // <===

          payee.transfer(payment);
```

</details>

</details>

### [contracts/payment/escrow/RefundEscrow.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/payment/escrow/RefundEscrow.sol):`RefundEscrow`

<details><summary><strong>There were 2 violations and 2 warnings found. Additionally, there are 5 cases that Securify couldn't identify correctly.

</strong></summary>

<details><summary><strong>TODAmount</strong></summary>

- Violation on line [82](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/payment/escrow/RefundEscrow.sol#L82)
```js
      function beneficiaryWithdraw() public {
          require(_state == State.Closed);
          _beneficiary.transfer(address(this).balance);    // <===
      }

```

- Warning on line [59](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/payment/escrow/RefundEscrow.sol#L59)
```js

      /**
       * @dev Allows for the beneficiary to withdraw their funds, rejecting    // <===
       * further deposits.
       */
```

</details>

<details><summary><strong>TODReceiver</strong></summary>

- Violation on line [82](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/payment/escrow/RefundEscrow.sol#L82)
```js
      function beneficiaryWithdraw() public {
          require(_state == State.Closed);
          _beneficiary.transfer(address(this).balance);    // <===
      }

```

</details>

<details><summary><strong>UnrestrictedEtherFlow</strong></summary>

- Warning on line [82](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/payment/escrow/RefundEscrow.sol#L82)
```js
      function beneficiaryWithdraw() public {
          require(_state == State.Closed);
          _beneficiary.transfer(address(this).balance);    // <===
      }

```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Conflict on line [30](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/payment/escrow/RefundEscrow.sol#L30)
```js
       */
      constructor (address payable beneficiary) public {
          require(beneficiary != address(0));    // <===
          _beneficiary = beneficiary;
          _state = State.Active;
```

- Conflict on line [45](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/payment/escrow/RefundEscrow.sol#L45)
```js
       * @return the beneficiary of the escrow.
       */
      function beneficiary() public view returns (address) {    // <===
          return _beneficiary;
      }
```

- Conflict on line [59](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/payment/escrow/RefundEscrow.sol#L59)
```js

      /**
       * @dev Allows for the beneficiary to withdraw their funds, rejecting    // <===
       * further deposits.
       */
```

- Conflict on line [64](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/payment/escrow/RefundEscrow.sol#L64)
```js
      function close() public onlyPrimary {
          require(_state == State.Active);
          _state = State.Closed;    // <===
          emit RefundsClosed();
      }
```

- Conflict on line [73](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/payment/escrow/RefundEscrow.sol#L73)
```js
      function enableRefunds() public onlyPrimary {
          require(_state == State.Active);
          _state = State.Refunding;    // <===
          emit RefundsEnabled();
      }
```

</details>

</details>

### [contracts/token/ERC20/ERC20Pausable.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/token/ERC20/ERC20Pausable.sol):`ERC20Pausable`

<details><summary><strong>There were 0 violations and 0 warnings found. Additionally, there are 1 cases that Securify couldn't identify correctly.

</strong></summary>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Conflict on line [31](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/token/ERC20/ERC20Pausable.sol#L31)
```js
      }
  }
      // <===
```

</details>

</details>

### [contracts/token/ERC20/TokenTimelock.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/token/ERC20/TokenTimelock.sol):`TokenTimelock`

<details><summary><strong>There were 1 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>LockedEther</strong></summary>

- Violation on line [10](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/token/ERC20/TokenTimelock.sol#L10)
```js
   * beneficiary to extract the tokens after a given release time
   */
  contract TokenTimelock {    // <===
      using SafeERC20 for IERC20;

```

</details>

</details>

### [contracts/token/ERC721/ERC721Enumerable.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/token/ERC721/ERC721Enumerable.sol):`ERC721Enumerable`

<details><summary><strong>There were 0 violations and 1 warnings found.

</strong></summary>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Warning on line [11](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/token/ERC721/ERC721Enumerable.sol#L11)
```js
   * @dev See https://eips.ethereum.org/EIPS/eip-721
   */
  contract ERC721Enumerable is ERC165, ERC721, IERC721Enumerable {    // <===
      // Mapping from owner to list of owned token IDs
      mapping(address => uint256[]) private _ownedTokens;
```

</details>

</details>

### [contracts/token/ERC721/ERC721Full.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/token/ERC721/ERC721Full.sol):`ERC721Full`

<details><summary><strong>There were 1 violations and 1 warnings found.

</strong></summary>

<details><summary><strong>LockedEther</strong></summary>

- Violation on line [13](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/token/ERC721/ERC721Full.sol#L13)
```js
   * @dev see https://eips.ethereum.org/EIPS/eip-721
   */
  contract ERC721Full is ERC721, ERC721Enumerable, ERC721Metadata {    // <===
      constructor (string memory name, string memory symbol) public ERC721Metadata(name, symbol) {
          // solhint-disable-previous-line no-empty-blocks
```

</details>

<details><summary><strong>UnrestrictedWrite</strong></summary>

- Warning on line [13](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/token/ERC721/ERC721Full.sol#L13)
```js
   * @dev see https://eips.ethereum.org/EIPS/eip-721
   */
  contract ERC721Full is ERC721, ERC721Enumerable, ERC721Metadata {    // <===
      constructor (string memory name, string memory symbol) public ERC721Metadata(name, symbol) {
          // solhint-disable-previous-line no-empty-blocks
```

</details>

</details>

### [contracts/token/ERC721/ERC721Metadata.sol](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/token/ERC721/ERC721Metadata.sol):`ERC721Metadata`

<details><summary><strong>There were 1 violations and 0 warnings found.

</strong></summary>

<details><summary><strong>LockedEther</strong></summary>

- Violation on line [7](../blob/a0b1289cd61fa67eb4a36fa44f80dabcfc38065d/contracts/token/ERC721/ERC721Metadata.sol#L7)
```js
  import "../../introspection/ERC165.sol";

  contract ERC721Metadata is ERC165, ERC721, IERC721Metadata {    // <===
      // Token name
      string private _name;
```


I wasn't super happy with the word `STRICT` -- any other ideas?


very descriptive commit name


Ahh I thought this was going into master. I'll hold off until we merge then.


Successfully aliased the URL <https://nuxt-firebase-ab3ls0v0w.now.sh> to the following aliases.

* https://nuxt-firebase.officialosorina.now.sh
* https://nuxt-firebase-git-master.officialosorina.now.sh


You can define a default for role. As `regular`, you'll only need only to define `admin`


The encryption library not have  __construct function !
It must be:
`
$this->registry->set('encryption', new Encryption());
`
The same thing in the admin side
https://github.com/opencart/opencart/issues/7340


Successfully aliased the URL <https://este-isbmj75v0.now.sh> to the following aliases.

* https://este.io
* https://este.gh-zzpo.now.sh
* https://este-git-master.gh-zzpo.now.sh


I thought the https://github.com/NixOS/nixpkgs/issues/49405 was fixed a while ago? The above `shell.nix` will not work properly anymore.


![](https://github.trello.services/images/mini-trello-icon.png) [Task #18 - Implement server-side airline company registration. [3h] [US18]](https://trello.com/c/8rcY9KKt/39-task-18-implement-server-side-airline-company-registration-3h-us18)


Puzzle `3-10643be9` disappeared from [`plugin/build.gradle`](https://github.com/nikialeksey/nullfree/blob/master/plugin/build.gradle), that's why I closed #7. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.


BTW it fixes as soon as I press a key, for example C-n or RET.


Fam, why are you querying the database again for the prefixes? The PrefixManager already has them stored in-memory upon instantiation, just grab them from there.


It's just trying to detect if the current process is a unity application or not (if yes, some Unity specific settings will be used). `Type.GetType("UnityEngine.Application")` returns null when run in a C# script of a unity application, so your suggestion doesn't work.

Why would someone have UnityEngine assembly in GAC?


`define-Prog-free-syntax` WOULD allow overloading `define`.


Does !\*.internal.\* need to be added to Import-Package from the location bnd.bnd file?


The problem is that ADQC doesn't have a notion of local functions at all (I'll comment below)


Hi Claus. This line give me somethimes the following error: `Uncaught TYPO3 Exception: Call to a member function getFields() on null`


Also these prefixes never update, you get them once on startup but they don't update like the ones the PrefixManager has.


Successfully aliased the URL <https://rc-tree-6ljbw6ydf.now.sh> to the following aliases.

* https://rc-tree.react-component.now.sh
* https://rc-tree-git-master.react-component.now.sh


Successfully aliased the URL <https://prismic-nextjs-website-bcs0snatr.now.sh> to the following aliases.

* https://prismic-nextjs-website.philsnow.now.sh
* https://prismic-nextjs-website-git-master.philsnow.now.sh


@dkati, a diff between two builds of decompiled camera HALs (one is closed source and the second is an opensource). Since I'm not quite active with this, you probably can ask @ripee for a more details.


Successfully aliased the URL <https://rc-tree-7o9nkqekn.now.sh> to the following aliases.

* https://rc-tree.react-component.now.sh
* https://rc-tree-git-master.react-component.now.sh


I think you are misunderstanding me. If I have the code:

```
(S
 (let ([x : S32 := 1])
  (define-fun (f [y : S32]) : S32 (+ x y))
  (f 1)))
```

Then we will generate bad code (or maybe there will be a type-error), because `x` is a valid Racket binding inside of `f` but it is not a valid ADQC binding.


Add xmldisg xsd version 1.0 and 1.1


Probably best commit


where that C code came from?
I am fine with it. I need to ask noone


initialize the project


Ooooh, I see. my apologies.

I'll throw in thoughts while I'm here. If we are describing:
- Something that has no owner -> unowned or ownerless.
- Something that has had its ownership removed -> disowned (seems close).
- The act of removing ownership -> disown (seems correct).


Lovely thank you very much for your great software :pray:

BTW ever checked [setupmeta](https://github.com/zsimic/setupmeta) module ? Maybe you will like it as much as I do ;)

Have a great day Patrick :sun_with_face:


Адрес сети можно сделать константой, а в идеале вообще сделать метод, который параметризовано создает новую виртуалку, но при этом имеет вменяемые дефолтные значения.
Об этом говорилось в последней презентации в разборе домашек.


Add-Suppl-HeatingCoil-To-VRF-TU (Nigusse) - x86_64-Linux-Ubuntu-18.04-gcc-7.3-IntegrationCoverage-Debug: OK (660 of 660 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-68.41%25-green.png)


https://hg.mozilla.org/l10n-central/ja/rev/cf14cc8c19c33c7d0df3993a6837123005bdfe88
https://hg.mozilla.org/l10n-central/ja-JP-mac/rev/c00e3dccf1ad089b5f3ad791758fac9c49b94f2e


Successfully aliased the URL <https://express-mmistyk80.now.sh> to the following aliases.

* https://express.shasolesoh.now.sh
* https://express-git-master.shasolesoh.now.sh


`autocast` was replaced by `flags` on master:
flags = 0 : Spell not added on enter (must be added manually), not automatically removed on quest update, but removed on leave.
flags = 1 : Spell is automatically applied on enter, not automatically removed on quest update, but removed on leave.
flags = 2 : Spell not added on enter (must be added manually), automatically removed on quest update and removed on leave.
flags = 3 : (Default) Spell is automatically applied on enter, automatically removed on quest update and removed on leave.


Yes, it's fixed in a later commit.


Да, Сергей, спасибо за комментарий!

Всегда готов рассмотреть софтварные решения перед тряской железа. К сожалению, пациент не реанимируется, пишет {"cmd":"get_id_list"}, как и раньше, и нихрена больше. Я уже и роутер новый взял, айпи менял, виртуальные адаптеры отключал - бесполезно.

Шлюз версии 3, куплен на НГ, прилагаю полный скрин.

Заранее спасибо!

![Screenshot_2019-04-29-16-11-18-393_com xiaomi smarthome](https://user-images.githubusercontent.com/50044282/56905079-dfe23900-6a9f-11e9-89a2-f44cc0e02202.png)


This is the AST, so there is nothing more efficient than a `String`.


Got it, thanks for the explanation.  Looks good to me!


I believe so.


@rivera-ernesto @guillermomuntaner @AlejandroRuiz
It didn't work for me.
### Cordova Telerik image picker version is **2.3.2**
![ionic en](https://user-images.githubusercontent.com/21123907/56905149-57729100-6abd-11e9-89ed-ee559104ec51.PNG)
 provide steps as well so can use it properly.


Correct. It's doing too many conversions and even though the conversions are fairly cheap, they will start to add up.


You might also want to test if it returns false if there are no matches.


ok


Successfully aliased the URL <https://krutoy-r24uxe6y1.now.sh> to the following aliases.

* https://krutoy.pavlenkovit.now.sh
* https://krutoy-git-master.pavlenkovit.now.sh


Yes, I think the order will matter (at the moment it doesn't matter too much) when bootstrapping is done properly.


Successfully aliased the URL <https://swiip-26f8q47fw.now.sh> to the following aliases.

* https://swiip.now.sh
* https://swiip.swiip.now.sh
* https://swiip-git-master.swiip.now.sh


sure. i shall do that also

On Mon, 29 Apr 2019 20:30:21 +0530 Filipp Dmytriyenko  wrote
>You might also want to test if it returns false if there are no matches.

—
>You are receiving this because you authored the thread.
>Reply to this email directly, view it on GitHub, or mute the thread.


Вместо циклов лучше сделать метод и вызвать его два раза, это будет нагляднее и проще для понимания.


Адрес сети можно вынести в константу, и менять соотвественно только последнюю цифру как ты тут сделал


I agree. The 220x220 value was taken from runUNDfun's configuration but I ran into problems on a larger print so I set it to 240x240 without testing and promptly forgot about it.

On my late 2018 model the X axis moves right up to 240mm, but I can hear it hitting the end. My Y axis stalls after moving to 235mm.

Based on this I believe 239x234 would be safe without being too limiting, but I'm not sure if this is correct for the earlier model of the A10.


Yes, but the constant *could* change, and then other bits of code would break (in `Frame`). So this is really a super cautious sanity check.


I did not see any additional `*.internal.*` packages getting included in the resulting Import-Package header produced by BND.  I think that instruction from the location bnd.bnd file was no longer needed.


Hi!! Could you please explain me,  how  'return_path' works?


I'm not sure I understand -- there are no hidden values in `Val` (other than the tagged pointers).


Thanks for the pointer.

I guess next time I'll update the package before making a hackage revision for the older versions.


Successfully aliased the URL <https://swiip-b8j99ua5m.now.sh> to the following aliases.

* https://swiip.now.sh
* https://swiip.swiip.now.sh
* https://swiip-git-master.swiip.now.sh


#asking question


n


buton


Thanks @ollyg that's awesome! No hard feelings about not using the other PR, it was probably a bit too invasive just to scratch a corner-case configuration itch.

I just tried the new Permission.pm, unfortunately in the current state the simple eq is only used for the one matching `$item` in the ACL,  every other `$item` still traverses the NetAddr::IP checks.

I think we'd need something like this:

```
*** Permission.pm_2.042007	Mon Apr 29 16:26:26 2019
--- Permission.pm	Mon Apr 29 16:55:14 2019
***************
*** 117,136 ****
--- 117,140 ----
        if (not reftype $item) {
          $neg = ($item =~ s/^!//);

          if ($item eq $real_ip) {
            return 1 if not $neg and not $all;
            return 0 if $neg and $all;
            next INLIST;
          }
        }

+       if (setting('acl_fast_string_match_only')){
+         next INLIST;
+       }
+
        # do this after string compare as it gets expensive
        $addr = ($addr || NetAddr::IP::Lite->new($real_ip));
        return 0 unless $addr;

        if ($qref eq ref $item) {
            $name = ($name || hostname_from_ip($addr->addr, $ropt) || '!!none!!');
            if ($name =~ $item) {
              return 1 if not $all;
            }
            else {
```

to be able to completely opt-out of all the other matching. But again, a very specifc thing that might confuse most other people in the doc, so if you're not comfortable with it I can also just hand-patch it into the two Netdisco installations where we'd need it.


![](https://github.trello.services/images/mini-trello-icon.png) [(3) Dislike a specific video](https://trello.com/c/SKhMrLob/5-3-dislike-a-specific-video)


Why i can see hp in chat, but i couldnt see it on hp bar of boss


I see. I guess this is fine as long as we don't end up asserting too many constants.


Successfully aliased the URL <https://gatsby-blog-erw8rsn5y.now.sh> to the following aliases.

* https://blog.matt.cat
* https://gatsby-blog.matts.now.sh
* https://gatsby-blog-git-master.matts.now.sh


Here I forgot to subtract `self.origin` to the ray direction.  It should be
```rust
Ray::new(self.origin, self.lower_left_corner + u * self.horizontal + v * self.vertical - self.origin)
```
This is not a problem here because origin is fixed to (0, 0, 0).
It will be fixed in [chapter 10](https://github.com/fralken/ray-tracing-in-one-weekend/commit/700914efd9a7428c489f32a402bff13607d13973#diff-0e785b961083ec1c2c5e0f5591553836R26) when implementing positionable camera.


Successfully aliased the URL <https://magento-venia-rtpngiuepw.now.sh> to the following aliases.

* https://magento-venia.now.sh
* https://veniapwa.com


Created multidev environment [hscrb#ci-1068](https://dashboard.pantheon.io/sites/06f9bf1c-27cc-4fe9-8eda-f88f153eb347#ci-1068).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-1068-hscrb.pantheonsite.io/)


I think it's fine, it's comparable to pre-calculated volume slide lookup tables on sound chips instead of a big static table. The only thing I don't like here is that I have 2 separate tables(7bit and 6bit) for sm510d. AFAIK our disasm core doesn't have anything like device_start, so I need to do the init in the constructor. If it had a device_start I could call the page_address_bits() virtual function and go from there.


Successfully aliased the URL <https://fashionmagazinsorder-p1sh4ovlk.now.sh> to the following aliases.

* https://fashionmagazinsorder.nesibf.now.sh
* https://fashionmagazinsorder-git-master.nesibf.now.sh


@JuliaRegistrator register()


I think i misunderstood. Well.. The docstring says the fields are opaque. I'm not sure what that means. That the field is private?


Successfully aliased the URL <https://swiip-evkv7loby.now.sh> to the following aliases.

* https://swiip.now.sh
* https://swiip.swiip.now.sh
* https://swiip-git-master.swiip.now.sh


It's not image ?


> 1. Something that has had its ownership removed -> disowned (seems close).
> 1. The act of removing ownership -> disown (seems correct).

If point 2 is correct, then it seems that, by definition, point 1 is correct.  :wink:

If we want to illustrate a connection between verb and adjective, then these make sense and will probably be easiest for people to both learn (read: guess at) and correlate meaning with when reading code. :+1:


![](https://github.trello.services/images/mini-trello-icon.png) [Dividir el componente de auth en dos pestañas: Una de login, y otra de registro.](https://trello.com/c/dXLByrZx/52-dividir-el-componente-de-auth-en-dos-pesta%C3%B1as-una-de-login-y-otra-de-registro)


Agreed -- this is a pretty unusual situation. But I think it helps readers to see `SELF_VAR` instead of 0, even though `SELF_VAR` can never be anything other than zero!

[The same idiom is used for `GCBOX`, BTW, and for the same reasons.]


Why did you use this module?


Successfully aliased the URL <https://swiip-146baz2i7.now.sh> to the following aliases.

* https://swiip.now.sh
* https://swiip.swiip.now.sh
* https://swiip-git-master.swiip.now.sh


When I  sign up, I get redirected to a home page and after that, when I click on the "YouTube Music" button, I get redirected to a site where there are admin links and I can't use the API, and on top of that, it's giving me an error of wrong number of arguments. You might want to check that out. This has to do with the policies and the controllers.


Since everything is \*.internal.\*, can we just have an empty bundle pretty much?  No one should be importing anything from this bundle.  If you want to keep the source, then I would say for sure we can remove the test directory.


I think I see the confusion! The doc string says "The contents of this struct are deliberately opaque, and may change, but it is guaranteed that this struct will always be `Copy`able." Notice it carefully doesn't mention "fields" :) The idea here is that I can change this to store fat pointers and/or not unbox integers, and the doc string comment and the rest of the interface will remain identical.

[Ironically, the `Copy` part of the comment is wrong: while we use reference counting, the struct can't be `Copy`able. When we have "proper" GC again it can become `Copy`able. I'll raise a PR for that later.]


Also will having the same Activator run in both the service and service.location bundles cause a problem


@Ouvill

If you have time, could you please help to translate it :wink:


Successfully aliased the URL <https://swiip-gri9ils8l.now.sh> to the following aliases.

* https://swiip.now.sh
* https://swiip.swiip.now.sh
* https://swiip-git-master.swiip.now.sh


Didn't you mention an out of tree plugin existing? This would break "abi" no?


I see. So should we revise the comment to clarify any of those points?


Can we use Allocation manager Instead? (At all places)


I think it's best to do that in a separate PR, as I'd better check there aren't other dodgy statements like that one lurking around.


cc @JobJob


@erdoukki
Hi, sorry to bother, can You test this branch https://github.com/tmn505/openwrt/tree/mvebu?


Fixes #1


Successfully aliased the URL <https://swiip-py46okksu.now.sh> to the following aliases.

* https://swiip.now.sh
* https://swiip.swiip.now.sh
* https://swiip-git-master.swiip.now.sh


OK. If you are doing a comments PR, could we add the "conceptually present but hidden" fields to the structs that *do* use that trick. Was it the ThinObj?


Here it is:

> When a :return_path is specified as header, that value will be used as the 'envelope from' address for the Mail message. Setting this is useful when you want delivery notifications sent to a different address than the one in :from. Mail will actually use the :return_path in preference to the :sender in preference to the :from field for the 'envelope from' value.
Source: https://api.rubyonrails.org/v5.1/classes/ActionMailer/Base.html

In short, by adding it to the header, reception notification will be sent to `notifications@myblog.com` and `iamdeyvi@gmail.com` This part will be under close inspection, thanks for sharing it.


Wow, what the heck happened with white space or something here? Sheesh


This would cause a problem if we had any features that still pulled the bundle into the runtime, but I removed all references to the service.location bundle from all of our features (just the kernel feature really).

I can remove the unit tests from the commit, the result right now is that the unit tests run twice until we can delete this project.


If you want to go live on the web, Settings -> GitHub Pages is the place to start... and then remember that it can take up to 5 minutes before you see results. (A small price to pay for a free website, but not always obvious when it's happening.) To tell if GH Pages has figured out that you have a new deployment, you can go to [the repo's home page](https://github.com/pitt-cdm/twine--summer-nights-1) and look for the Deployment tab with the rocket icon.

 : )


Good idea -- I'll do that!


@tgmti Help, bro~

BTW, the `pt-BR` docs is out of date for several versions 😅 I'm afraid it's not a good idea to maintain the `pt-BR` translation is this repo, or you have to update it whenever the docs is updated.

We may:

- Move the translation to another repo, or
- Ask you for help on every update

What's your idea about that?


Dear Poggit user,

This is an automatic message from Poggit-CI. Poggit-CI was triggered by this commit, but failed to create builds due to the following error:

```
Resend this delivery later. This commit is triggered by user
ChampOfGamesYT, who has created 50 Poggit-CI builds in the past 168 hours.

Contact @SOF3 [on Discord](https://discord.gg/NgHf9jt) to request for extra
quota. We will increase your quota for free if you are really contributing
to open-source plugins actively without abusing Git commits.
```

As a result, no builds could be created from this commit. More details might be available for repo admins at [the webhook delivery response log](https://github.com/ChampOfGamesYT/ExtraCommands/settings/hooks) — see the webhook starting with `https://poggit.pmmp.io/webhooks.gh.repo` and look for the delivery with ID `f0b55cf6-6a92-11e9-82e6-eefc5b4ec90c`.

Shall you need any assistance, you may contact us on [on Discord](https://discord.gg/NgHf9jt), or more publicly, [on GitHub](https://github.com/poggit/support/issues). Commenting on this commit directly will **not** notify any Poggit staff.

Regards,
Poggit Bot (@poggit-bot)
The official Poggit automation account


Successfully aliased the URL <https://monorepo-4d8m6xu0t.now.sh> to the following aliases.

* https://monorepo.storybook.now.sh
* https://monorepo-git-next.storybook.now.sh


@apclary  Thanks for setting up travis CI


`Error: while migrating Splitter: Invalid number of parameters for "undefined". Got 0 expected 1!`

is related to

`constructor (bool paused) Pausable(paused) public {}` that wants 1 parameter.

I would be inclined to simplify the constructor as `constructor() public {}` or remove and make it so `Pausable`'s constructor doesn't need any inputs. You can set its default mode without constructor args. If necessary, a migration script could change the setting if you wanted the deployment process to be nicely scripted.


Successfully aliased the URL <https://swiip-ptwac1h3f.now.sh> to the following aliases.

* https://swiip.now.sh
* https://swiip.swiip.now.sh
* https://swiip-git-master.swiip.now.sh


![](https://github.trello.services/images/mini-trello-icon.png) [Finished Scenario Run-Through](https://trello.com/c/jqTYKmkR/40-finished-scenario-run-through)


Successfully aliased the URL <https://swiip-qxuti7gy5.now.sh> to the following aliases.

* https://swiip.now.sh
* https://swiip.swiip.now.sh
* https://swiip-git-master.swiip.now.sh


test ok?


Hi @UdoBretz and @carlosfrodriguez  ,

i just want to mention that this is a really big change and i'm kind of suprised that this change is part of a patch level release. For custom development purposes this could have bad side effects, e.g. if you deploy definitions on package install or something else.

Did the OTRS team change their code policy for the handling of big changes in patch level releases? Normally i would expect structure changes like this (perl -> yaml) only in minor or major releases.

Best regards,
Rolf


Didn't work on ios 12.1.


Successfully aliased the URL <https://prismic-nextjs-website-k1qh3hbbx.now.sh> to the following aliases.

* https://prismic-nextjs-website.philsnow.now.sh
* https://prismic-nextjs-website-git-master.philsnow.now.sh


OK, I will use that then :-)


What is the meaning of this?


Did you copy/replace them?


Successfully aliased the URL <https://blog-8206f7j2d.now.sh> to the following aliases.

* https://www.ahonn.me
* https://blog.ahonn.now.sh
* https://blog-git-master.ahonn.now.sh


![](https://github.trello.services/images/mini-trello-icon.png) [(2) Like a specific video](https://trello.com/c/i5Wsyfjx/4-2-like-a-specific-video)


Because it was causing formatting problems. In the .md version, some lines showing as `code styled` and some lines are not. That's why I renamed as .txt, so everything looks as expected.


Please, the correct syntax is:
`default from: 'email@email.com', return_path: 'another_email@email.com'` or as @diegotc86 considers: `default { from: 'email@email.com', return_path: 'another_email@email.com' }`


Ah, maybe that's what happened. I edited the files and then copied them into my dsrc directory


This is a very odd default. If it's an `Optional`, one would expect `undef` as a default because setting it to undef later isn't possible in pure Puppet code. Maybe hiera can but it still feels off.


Successfully aliased the URL <https://design-docs-a7y7oukdo.now.sh> to the following aliases.

* https://aaptiv.design
* https://design-docs.aaptiv1.now.sh
* https://design-docs-git-master.aaptiv1.now.sh


Password


Is there a distinct advantage to this? I'm not really a fan of completely converting to kotlin as it's not as popular of a language as Java, and I'm much more familiar with java.


(Windows.Web.Http.HttpRequestMessage,Windows.Networking.Socke


confirmed that this is catching the error without f8adaf1139f8d80fef07ff261129dc54757a541b and that the test succeeds with the fix


Yeah, there's two:
1) it's much easier to use than java
2) it's not java


Atom needs to be online to validate from the remote schema linked in the processing instruction. Please when working with Atom offline, either
- *temporarily* change the url in the processing instruction on top of each file to point to your local copy of the schema
- wait to commit until you can validate (= you have internet connection and Atom can look at the remote schema)
The second option is the best even if you are pointing to a local copy of the schema. committing should only occur when you can validate


these are useless...


This is a good looking file!


Helps prevent the Discord client from crashing for errors not caught.


Successfully aliased the URL <https://swiip-e8xd4ustr.now.sh> to the following aliases.

* https://swiip.now.sh
* https://swiip.swiip.now.sh
* https://swiip-git-master.swiip.now.sh


Done. Feel free to submit pull requests for changes :)


test ok?


파일 ex14_input_argv/ex14.py 구문 확인 바랍니다. (자동 생성 메시지 시험중)
Please verify syntax of ex14_input_argv/ex14.py. (Testing auto comments)


파일 ex04_variables/ex04.py 구문 확인 바랍니다. (자동 생성 메시지 시험중)
Please verify syntax of ex04_variables/ex04.py. (Testing auto comments)


파일 ex01_print/ex01.py 구문 확인 바랍니다. (자동 생성 메시지 시험중)
Please verify syntax of ex01_print/ex01.py. (Testing auto comments)


Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

- @aregm was added to conda-forge. Welcome to conda-forge!
  Go to https://github.com/orgs/conda-forge/invitation see your invitation.

- @anton-malakhov was added to this feedstock maintenance team.

You should get push access to this feedstock and CI services.

Feel free to join the community [chat room](https://gitter.im/conda-forge/conda-forge.github.io).

NOTE: Please make sure to not push to the repository directly.
      Use branches in your fork for any changes and send a PR.
      More details [here](https://conda-forge.org/docs/conda-forge_gotchas.html#using-a-fork-vs-a-branch-when-updating-a-recipe)


@JuliaRegistrator register()


Setting state to `success` where context is `xamarin-macios - sample testing (build)`.

Samples issue already known: https://github.com/mono/mono/issues/13483


Registration pull request created: [JuliaRegistries/General/414](https://github.com/JuliaRegistries/General/pull/414)

After the above pull request is merged, it is recommended that you create
a tag on this repository for the registered package version:
```
git tag -a v0.2.0 -m "<description of version>" 97423d22aa0b684cb06ad2d0d82b83e606ba21f5
git push origin v0.2.0
```


Successfully aliased the URL <https://my-website-gatsby-it6sig2i0.now.sh> to the following aliases.

* https://my-website-gatsby.carjimfa.now.sh
* https://my-website-gatsby-git-master.carjimfa.now.sh


It's best practice to wrap lines like these:

```javascript
<CardTextWrapper
  name={this.props.name}
  job={this.props.job}
  company={this.props.company}
  phone={this.props.phone}
  email={this.props.email}
/>
```

As well, to make references to props more readable, destructure them:

```javascript
const { name, job, company, phone, email } = this.props;

// then use the props
<CardTextWrapper name={name} ... />
```


#141 #139


Don't state your plan so much in the comments. Many of your comments say "I will..", "list object should", etc...
In stead, try to just describe what's actually in the code.
Also keep in mind that "self documenting" code is best, and so actually, many of these comments (like the one above) is not necessary. Or you could just say "In this file are tests and implementations for LinkedList and Link".
Try and get the capital letters correct. As you know, the computer reads this and is exact about them; when they're wrong in the comments the computer doesn't care, but people might get confused.


Unless this create-react-app project is configured differently, prefer referencing modules without the `.js` extension:

```javascript
import CardTextContainerTop from './cardTextContainerTop/CardTextContainerTop';
```

Are you linting your code? A lot of these things would be picked up by a good set of linter rules: https://www.npmjs.com/package/eslint-config-airbnb


how about `wf = self.request['ProcessingString']+self.request['RequestName']`, just to make it inclusive


> This file has been generated by the Hex-Rays decompiler.

It's generated with IDA IDE.


I thought one has to set up something properly to use `conda deactivate`? Why using this instead of `source deactivate`?


divide? in the DL book they said multiply right?


Hm, not sure. What's the context?


Fine, sure


Setting state to `success` where context is `VSTS: device tests (iOS)`.

Interpreter issues are knonw: https://github.com/mono/mono/issues/14246


IMHO, this method body is too long. Prefer extracting methods with names that indicate their function rather than using comments. So instead of doing the string conversion in the `handleChange` method, maybe create a method called `getProfileAsString` and call it from `handleChange`.


test ok?


coś czuje, że to dodatkowo blokuje przewijanie i rodo łagodzi.


@JuliaRegistrator register()


Registration pull request created: [JuliaRegistries/General/415](https://github.com/JuliaRegistries/General/pull/415)

After the above pull request is merged, it is recommended that you create
a tag on this repository for the registered package version:
```
git tag -a v0.5.5 -m "<description of version>" c52d58cbedf7074630dff19af108ef350a7dff95
git push origin v0.5.5
```


Setting state to `success` where context is `continuous-integration/jenkins/branch`.

WatchOS crashes are knonw: https://github.com/xamarin/maccore/issues/581


Meh... U don't need that but OK.

Good evening


We've talked about starting with tests first, and I think that this would be a great place to do that.

I would try and write code that does this in a test, and only after I've written the test I'd start working on the LinkedList class.
- create a list
- add "Yotam" to the list
- iterate over the list and make sure that it contains exactly Yotam
- add "Amotz" to the end of the list.
- iterate over the list and make sure that it contains exactly Yotam and Amotz
- add "Anat".
- verify correct as expected ... (after each of these operations)
- Find Amotz.
- Remove Amotz
- Find Anat and add Asaf after Anat.

I think that if you had started this way, you'd see the need for find(..) to return something useful (so that after you've found it you can delete it or add and element after it)


not needed! :)


파일 ex14_input_argv/ex14.py 구문 확인 바랍니다. (자동 생성 메시지 시험중)
Please verify syntax of ex14_input_argv/ex14.py. (Testing auto comments)


파일 ex04_variables/ex04.py 구문 확인 바랍니다. (자동 생성 메시지 시험중)
Please verify syntax of ex04_variables/ex04.py. (Testing auto comments)


파일 ex01_print/ex01.py 구문 확인 바랍니다. (자동 생성 메시지 시험중)
Please verify syntax of ex01_print/ex01.py. (Testing auto comments)


@StephaneGraziano @honfika The reason I removed the throw exception call is to avoid a flood of exceptions which I felt like affecting the performance (exception handling is a lot of work from CLR standpoint).


Here too, maybe create a method called `doesCardContentIncludeUserSearchTerm` whose implementation is something like:

```javascript
doesCardContentIncludeUserSearchTerm(filter) {
  return getProfileAsString().includes(filter);
}
```

That way, you reduce the length of the `handleChange` method and improve its at-a-glance understandability, as well as make the code self-documenting through concise method naming.


Successfully aliased the URL <https://swiip-c7xyh1gky.now.sh> to the following aliases.

* https://swiip.now.sh
* https://swiip.swiip.now.sh
* https://swiip-git-master.swiip.now.sh


I'm not a Python programmer, but I think that there probably is a way to quickly and concisely show what the data members of this class are. We can discuss this..


Successfully aliased the URL <https://andrewebsite-fbl4ojsu9.now.sh> to the following aliases.

* https://andredevries.tech
* https://andredevries.dev
* https://andre-website.aedevries19.now.sh
* https://andre-website-git-master.aedevries19.now.sh


Setting state to `success` where context is `VSTS: device tests (iOS)`.

Interpreter issues are knonw: https://github.com/mono/mono/issues/14246 Created an issue for the new failure, which looks like a random thing: https://github.com/xamarin/maccore/issues/1579


This seems misleading. The constructor doesn't have a head link. Maybe I misunderstood.


Since this `Header` component is stateless, prefer using a function-based component to simplify the markup:

```javascript
const Header = ({ my, prop, names }) => (
  <div>
    Hello, header! Here are some props: {my} {prop} {names}
  </div>
);

export default Header;
```

Again, a good set of linter rules should catch this and enforce it before you can run the app.


FWIW - the bug for Gutenberg can be traced back to the `updateCollection()` function in _`../wp-includes/js/dist/edit-post.js`_ / _`../wp-includes/js/dist/edit-post.min.js`_


Successfully aliased the URL <https://poop-pi-enf0juv4t.now.sh> to the following aliases.

* https://poop-pi.damonsorensen.now.sh
* https://poop-pi-git-master.damonsorensen.now.sh


FWIW - the bug for Gutenberg can be traced back to the `updateCollection()` function.
Located here: _`../wp-includes/js/dist/edit-post.js`_
And here: _`../wp-includes/js/dist/edit-post.min.js`_


test ok?


Successfully aliased the URL <https://swiip-odgey7mgx.now.sh> to the following aliases.

* https://swiip.now.sh
* https://swiip.swiip.now.sh
* https://swiip-git-master.swiip.now.sh


I haven't played with the webpack.config yet, I will try ;)
Thanks! :+1: :heart:


Você pode colocar seu telefone no site @jmarcosrodrigues


Setting state to `success` where context is `continuous-integration/jenkins/branch`.

All tests pass (looked at the run) but build was aborted in the finish step.


This seems wrong or at least confusing.
If add_link adds the link to the end of the list, which is typically what is expected, then it shouldn't change head_link. If it adds it to the begining of the list, then its name should probably be changed.


✅ Device tests passed on TvOS on [Azure DevOps](https://dev.azure.com/devdiv/DevDiv/_build/index?buildId=2630108)(TvOS): [Html Report](http://xamarin-storage/jenkins/xamarin-macios/arm64-dynamic-registrar-wip/1388b6909147809199fc63ad9befd30e502aaa36/2630108/device-tests/jenkins-results/tests/index.html) ✅

# Test results

# No tests selected.


I blame Tyrone.


https://github.com/WWAWing/WinWwaWingmk/commit/fe6074269d79ab40b779cda8097c1d69fac2c514
::memo: この辺の挙動をexe立ち上げて確認する


I don't think libvgio being out of date relative to its dependencies caused a performance loss. I think the performance loss I observed when I first ported over to libvgio was caused by libvgio building itself without -O3, and/or by it building position-independent code and linking itself and its dependencies in dynamically.

When I revised the build to use -O3, and also changed vg to link static, position-dependent versions of libvgio and everything under it, the performance regression went away. I don't know which of those was the real solution, but both are nice to have.


"new_link" is a bad argument name since it's a value and not a link.


改自Nicked


get


I wasn't aware that it was not necessary for python 3+ so thank you for linking that thread. It's something I have been doing for so long just knowing it's necessary because of python 2. You can remove this if you want, but most of our other classes are defined as such. If we want to address this (remove from any classes that only inherit from object) we should probably tackle it across the whole repo and add to our style doc.


"temp" is not a good name for this variable since you'll be storing it permanently in the list.


The return type should be Book not int

public static Book searchByID(int bookId){
                    for(Book book : BookManager.bookList){
                                   if(book.getBookID() == bookId){
                                                return book;
                                   }
                     }
                     return null;
}


Successfully aliased the URL <https://swiip-ltdvjen5t.now.sh> to the following aliases.

* https://swiip.now.sh
* https://swiip.swiip.now.sh
* https://swiip-git-master.swiip.now.sh


Setting state to `success` where context is `VSTS: device tests (iOS)`.

Device tests can be ignored in this branch since they are not ready.


Same as above.


Good use of comments, this is quite useful for those who want to use our project to learn more about Minecraft modding, as well as serving as a reminder to yourself.


Comments like this don't really help.
I mean, it's obvious that the function called "test_link_class" does something to test the link class. The comment is vague, and so I still need to read the code. And the code is pretty easy to read and does more than the comment describes. I'd just delete this comment.


这是什么原理 @ice1000


Newer versions of conda print an error if you do “source deactivate”.


:rocket:


@tchow8  - Why did we remove this? Any specific reason?


Do it like this
Book b = BookManager.searchByID(p);
if(b!=null){
//do something
}else{
//do something
}


![](https://github.trello.services/images/mini-trello-icon.png) [Rewrite Other Features](https://trello.com/c/uAHKuMdS/34-rewrite-other-features)


確かここの辺りは、Windows標準の開くダイアログと保存ダイアログを利用していなかった頃に、作成ツールオリジナルで開くダイアログと保存ダイアログを実装していたようです。
既にマップデータを開くやマップデータの保存についてはWindows標準のものを利用していて、既にそのダイアログは使われていないことから、削除した形としています。


I'm not a Python programmer, but 43 is not a Link, and so that's not great.
Do you know if there is a way to ensure that the "next" member of a Link object is required to be a Link?


Nice implementation!


![](https://github.trello.services/images/mini-trello-icon.png) [Rewrite complète (v2)](https://trello.com/c/Qg4RWbBp/15-rewrite-compl%C3%A8te-v2)


Same as in line 161


@JuliaRegistrator register()


Registration pull request created: [JuliaRegistries/General/416](https://github.com/JuliaRegistries/General/pull/416)

After the above pull request is merged, it is recommended that you create
a tag on this repository for the registered package version:
```
git tag -a v0.5.0 -m "<description of version>" 1bf539fc187a981e10833531d7d4a2d28ec1d06f
git push origin v0.5.0
```


You don't need the "== True". You can just say:
assert (my_list.is_empty())


I agree, this is odd. I believe it's lifted directly from the ntp module, which means it should probably get fixed there too. I'm away from a laptop for a few weeks so won't be suggesting a fix myself, but PR's welcome in the meantime!


Registration pull request updated: [JuliaRegistries/General/396](https://github.com/JuliaRegistries/General/pull/396)

After the above pull request is merged, it is recommended that you create
a tag on this repository for the registered package version:
```
git tag -a v0.5.4 -m "<description of version>" dc8efa9cde657ee2d3db9ce8621b0e81dd41be3c
git push origin v0.5.4
```


It's more common to say this instead of "== False":
assert (not my_list.is_empty())


Nice!!! :)


@mannkind, it looks like the end of your ESPHome yaml got ripped out as it's end on the beginning of the definition of the `switch:` component.  Can you check and see if you can push the complete file?


я понимаю, что если создавать переменные на стеке, то new и delete пропаду. Давайте перепишу, может норм будет.


ちなみに、ここはダイアログの挙動をまとめるダイアログプロシージャの関数になっています。
物体パーツ選択ウインドウや背景パーツ選択ウインドウはそれぞれ専用のプロシージャの関数を設けていますが、基本設定の編集や戦闘予測の計算など、そんなに大きなダイアログでないものについてはここに集約しているようです。


这样的话, `:extensions:paintboard` 就得用 `src/main` 作为 `main` 源集了呀
星野野不想有 `src` 这一层无用的东西


This was wrong initialization of the select dropdown. The proper way to do that is to bind it to the projekt (if you have multiple selects, like here because of the ng-repeat) and initialize it in the controller


E


Successfully aliased the URL <https://battle-g4w6fifaq.now.sh> to the following aliases.

* https://battle.pro808.now.sh
* https://battle-git-master.pro808.now.sh


what do you think about the following:
instead the old:
```
try
{
   ...
   return result;
}
catch
{
   closed = true;
   throw;
}
```

write the fllwoing:
```
bool success = false;
try
{
   ...
   success = true;
   return result;
}
finally
{
   if (!success)
  {
    closed  = true;
  }
}
```

In this case there is no re-thrown exception.


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|