###### :x: Test Failed: `va/phpunit`
  ```bash
  phpunit --exclude-group disabled tests/phpunit --colors=always
  ```
  ```bash
  PHPUnit 6.5.14 by Sebastian Bergmann and contributors.

Testing tests/phpunit
.....................FFF..                                        26 / 26 (100%)

Time: 54.49 seconds, Memory: 114.25MB

There were 3 failures:

1) tests\phpunit\SecurityRolesPermissions::testSecurityRolesPermissions with data set #3 ('content_editor', array('access administration pages', 'access content overview', 'access image_browser entity b... pages', 'access media overview', 'access media_browser entity b... pages', 'access shortcuts', 'access toolbar', 'access user profiles', 'administer menu', 'create alert block content', 'create document media', 'create event content', 'create health_care_local_faci...ontent', 'create health_care_local_heal...ontent', 'create health_care_region_det...ontent', 'create image media', 'create landing_page content', 'create media', 'create news_story content', 'create outreach_asset content', 'create page content', 'create person_profile content', 'create press_release content', 'create promo block content', 'create regional_health_care_s...ontent', 'create support_service content', 'create video media', 'delete media', 'edit any document media', 'edit any documentation_page content', 'edit any event content', 'edit any health_care_local_fa...ontent', 'edit any health_care_local_he...ontent', 'edit any health_care_region_d...ontent', 'edit any health_care_region_p...ontent', 'edit any image media', 'edit any landing_page content', 'edit any news_story content', 'edit any office content', 'edit any outreach_asset content', 'edit any page content', 'edit any person_profile content', 'edit any press_release content', 'edit any regional_health_care...ontent', 'edit any support_service content', 'edit any video media', 'edit own event content', 'edit own health_care_local_fa...ontent', 'edit own health_care_local_he...ontent', 'edit own health_care_region_d...ontent', 'edit own health_care_region_p...ontent', 'edit own landing_page content', 'edit own news_story content', 'edit own office content', 'edit own outreach_asset content', 'edit own page content', 'edit own person_profile content', 'edit own press_release content', 'edit own regional_health_care...ontent', 'edit own support_service content', 'rebuild tablefield', 'schedule editorial transition..._draft', 'update any alert block content', 'update any media', 'update any promo block content', 'update media', 'use editorial transition arch...lished', 'use editorial transition crea..._draft', 'use editorial transition review', 'use moderation dashboard', 'use moderation sidebar', 'use text format rich_text', 'use workbench access', 'view all media revisions', 'view all revisions', 'view any unpublished content', 'view event revisions', 'view health_care_local_facili...isions', 'view health_care_local_health...isions', 'view health_care_region_detai...isions', 'view health_care_region_page revisions', 'view landing_page revisions', 'view latest version', 'view news_story revisions', 'view office revisions', 'view outreach_asset revisions', 'view own unpublished content', 'view page revisions', 'view person_profile revisions', 'view press_release revisions', 'view regional_health_care_ser...isions', 'view sections in toolbar', 'view support_service revisions', 'view the administration theme', 'view unpublished paragraphs', 'view workbench access information'))
The permissions for the content_editor do not match the expected permissions:
 'access administration pages',
 'access content overview',
 'access image_browser entity browser pages',
 'access media overview',
 'access media_browser entity browser pages',
 'access moderation notes',
 'access shortcuts',
 'access toolbar',
 'access user profiles',
 'administer menu',
 'create alert block content',
 'create document media',
 'create event content',
 'create health_care_local_facility content',
 'create health_care_local_health_service content',
 'create health_care_region_detail_page content',
 'create image media',
 'create landing_page content',
 'create media',
 'create moderation notes',
 'create news_story content',
 'create outreach_asset content',
 'create page content',
 'create person_profile content',
 'create press_release content',
 'create promo block content',
 'create regional_health_care_service_des content',
 'create support_service content',
 'create video media',
 'delete media',
 'edit any document media',
 'edit any documentation_page content',
 'edit any event content',
 'edit any health_care_local_facility content',
 'edit any health_care_local_health_service content',
 'edit any health_care_region_detail_page content',
 'edit any health_care_region_page content',
 'edit any image media',
 'edit any landing_page content',
 'edit any news_story content',
 'edit any office content',
 'edit any outreach_asset content',
 'edit any page content',
 'edit any person_profile content',
 'edit any press_release content',
 'edit any regional_health_care_service_des content',
 'edit any support_service content',
 'edit any video media',
 'edit own event content',
 'edit own health_care_local_facility content',
 'edit own health_care_local_health_service content',
 'edit own health_care_region_detail_page content',
 'edit own health_care_region_page content',
 'edit own landing_page content',
 'edit own news_story content',
 'edit own office content',
 'edit own outreach_asset content',
 'edit own page content',
 'edit own person_profile content',
 'edit own press_release content',
 'edit own regional_health_care_service_des content',
 'edit own support_service content',
 'rebuild tablefield',
 'schedule editorial transition create_new_draft',
 'update any alert block content',
 'update any media',
 'update any promo block content',
 'update media',
 'use editorial transition archived_published',
 'use editorial transition create_new_draft',
 'use editorial transition review',
 'use moderation dashboard',
 'use moderation sidebar',
 'use text format rich_text',
 'use workbench access',
 'view all media revisions',
 'view all revisions',
 'view any unpublished content',
 'view event revisions',
 'view health_care_local_facility revisions',
 'view health_care_local_health_service revisions',
 'view health_care_region_detail_page revisions',
 'view health_care_region_page revisions',
 'view landing_page revisions',
 'view latest version',
 'view news_story revisions',
 'view office revisions',
 'view outreach_asset revisions',
 'view own unpublished content',
 'view page revisions',
 'view person_profile revisions',
 'view press_release revisions',
 'view regional_health_care_service_des revisions',
 'view sections in toolbar',
 'view support_service revisions',
 'view the administration theme',
 'view unpublished paragraphs',
 'view workbench access information'

Failed asserting that false is true.

/app/docroot/core/tests/Drupal/KernelTests/AssertLegacyTrait.php:31
/app/tests/phpunit/SecurityRolesPermissionsTest.php:36

2) tests\phpunit\SecurityRolesPermissions::testSecurityRolesPermissions with data set #4 ('content_reviewer', array('access administration pages', 'access content overview', 'access image_browser entity b... pages', 'access media overview', 'access media_browser entity b... pages', 'access shortcuts', 'access toolbar', 'access user profiles', 'administer menu', 'create alert block content', 'create document media', 'create event content', 'create health_care_local_faci...ontent', 'create health_care_local_heal...ontent', 'create health_care_region_det...ontent', 'create image media', 'create landing_page content', 'create media', 'create news_story content', 'create outreach_asset content', 'create page content', 'create person_profile content', 'create press_release content', 'create promo block content', 'create regional_health_care_s...ontent', 'create support_service content', 'create video media', 'delete media', 'edit any document media', 'edit any documentation_page content', 'edit any event content', 'edit any health_care_local_fa...ontent', 'edit any health_care_local_he...ontent', 'edit any health_care_region_d...ontent', 'edit any health_care_region_p...ontent', 'edit any image media', 'edit any landing_page content', 'edit any news_story content', 'edit any office content', 'edit any outreach_asset content', 'edit any page content', 'edit any person_profile content', 'edit any press_release content', 'edit any regional_health_care...ontent', 'edit any support_service content', 'edit any video media', 'edit own event content', 'edit own health_care_local_fa...ontent', 'edit own health_care_local_he...ontent', 'edit own health_care_region_d...ontent', 'edit own health_care_region_p...ontent', 'edit own landing_page content', 'edit own news_story content', 'edit own office content', 'edit own outreach_asset content', 'edit own page content', 'edit own person_profile content', 'edit own press_release content', 'edit own regional_health_care...ontent', 'edit own support_service content', 'rebuild tablefield', 'schedule editorial transition..._draft', 'update any alert block content', 'update any media', 'update any promo block content', 'update media', 'use editorial transition arch...lished', 'use editorial transition crea..._draft', 'use editorial transition review', 'use editorial transition stag...ishing', 'use moderation dashboard', 'use moderation sidebar', 'use text format rich_text', 'use workbench access', 'view all media revisions', 'view all revisions', 'view any unpublished content', 'view event revisions', 'view health_care_local_facili...isions', 'view health_care_local_health...isions', 'view health_care_region_detai...isions', 'view health_care_region_page revisions', 'view landing_page revisions', 'view latest version', 'view news_story revisions', 'view office revisions', 'view outreach_asset revisions', 'view own unpublished content', 'view page revisions', 'view person_profile revisions', 'view press_release revisions', 'view regional_health_care_ser...isions', 'view sections in toolbar', 'view support_service revisions', 'view the administration theme', 'view unpublished paragraphs', 'view workbench access information'))
The permissions for the content_reviewer do not match the expected permissions:
 'access administration pages',
 'access content overview',
 'access image_browser entity browser pages',
 'access media overview',
 'access media_browser entity browser pages',
 'access moderation notes',
 'access shortcuts',
 'access toolbar',
 'access user profiles',
 'administer menu',
 'create alert block content',
 'create document media',
 'create event content',
 'create health_care_local_facility content',
 'create health_care_local_health_service content',
 'create health_care_region_detail_page content',
 'create image media',
 'create landing_page content',
 'create media',
 'create moderation notes',
 'create news_story content',
 'create outreach_asset content',
 'create page content',
 'create person_profile content',
 'create press_release content',
 'create promo block content',
 'create regional_health_care_service_des content',
 'create support_service content',
 'create video media',
 'delete media',
 'edit any document media',
 'edit any documentation_page content',
 'edit any event content',
 'edit any health_care_local_facility content',
 'edit any health_care_local_health_service content',
 'edit any health_care_region_detail_page content',
 'edit any health_care_region_page content',
 'edit any image media',
 'edit any landing_page content',
 'edit any news_story content',
 'edit any office content',
 'edit any outreach_asset content',
 'edit any page content',
 'edit any person_profile content',
 'edit any press_release content',
 'edit any regional_health_care_service_des content',
 'edit any support_service content',
 'edit any video media',
 'edit own event content',
 'edit own health_care_local_facility content',
 'edit own health_care_local_health_service content',
 'edit own health_care_region_detail_page content',
 'edit own health_care_region_page content',
 'edit own landing_page content',
 'edit own news_story content',
 'edit own office content',
 'edit own outreach_asset content',
 'edit own page content',
 'edit own person_profile content',
 'edit own press_release content',
 'edit own regional_health_care_service_des content',
 'edit own support_service content',
 'rebuild tablefield',
 'schedule editorial transition create_new_draft',
 'update any alert block content',
 'update any media',
 'update any promo block content',
 'update media',
 'use editorial transition archived_published',
 'use editorial transition create_new_draft',
 'use editorial transition review',
 'use editorial transition stage_for_publishing',
 'use moderation dashboard',
 'use moderation sidebar',
 'use text format rich_text',
 'use workbench access',
 'view all media revisions',
 'view all revisions',
 'view any unpublished content',
 'view event revisions',
 'view health_care_local_facility revisions',
 'view health_care_local_health_service revisions',
 'view health_care_region_detail_page revisions',
 'view health_care_region_page revisions',
 'view landing_page revisions',
 'view latest version',
 'view news_story revisions',
 'view office revisions',
 'view outreach_asset revisions',
 'view own unpublished content',
 'view page revisions',
 'view person_profile revisions',
 'view press_release revisions',
 'view regional_health_care_service_des revisions',
 'view sections in toolbar',
 'view support_service revisions',
 'view the administration theme',
 'view unpublished paragraphs',
 'view workbench access information'

Failed asserting that false is true.

/app/docroot/core/tests/Drupal/KernelTests/AssertLegacyTrait.php:31
/app/tests/phpunit/SecurityRolesPermissionsTest.php:36

3) tests\phpunit\SecurityRolesPermissions::testSecurityRolesPermissions with data set #5 ('content_publisher', array('access administration pages', 'access content overview', 'access image_browser entity b... pages', 'access media overview', 'access media_browser entity b... pages', 'access shortcuts', 'access toolbar', 'access user profiles', 'administer menu', 'create alert block content', 'create document media', 'create event content', 'create health_care_local_faci...ontent', 'create health_care_local_heal...ontent', 'create health_care_region_det...ontent', 'create health_care_region_page content', 'create image media', 'create landing_page content', 'create media', 'create news_story content', 'create office content', 'create outreach_asset content', 'create page content', 'create person_profile content', 'create press_release content', 'create promo block content', 'create regional_health_care_s...ontent', 'create support_service content', 'create terms in health_care_s...xonomy', 'create url aliases', 'create video media', 'delete any alert block content', 'delete any document media', 'delete any event content', 'delete any health_care_local_...ontent', 'delete any health_care_local_...ontent', 'delete any health_care_region...ontent', 'delete any health_care_region...ontent', 'delete any image media', 'delete any landing_page content', 'delete any media', 'delete any news_story content', 'delete any office content', 'delete any outreach_asset content', 'delete any page content', 'delete any person_profile content', 'delete any press_release content', 'delete any promo block content', 'delete any regional_health_ca...ontent', 'delete any support_service content', 'delete any video media', 'delete media', 'delete own document media', 'delete own event content', 'delete own health_care_local_...ontent', 'delete own health_care_local_...ontent', 'delete own health_care_region...ontent', 'delete own health_care_region...ontent', 'delete own image media', 'delete own landing_page content', 'delete own news_story content', 'delete own office content', 'delete own outreach_asset content', 'delete own page content', 'delete own person_profile content', 'delete own press_release content', 'delete own regional_health_ca...ontent', 'delete own support_service content', 'delete own video media', 'delete terms in health_care_s...xonomy', 'edit any document media', 'edit any documentation_page content', 'edit any event content', 'edit any health_care_local_fa...ontent', 'edit any health_care_local_he...ontent', 'edit any health_care_region_d...ontent', 'edit any health_care_region_p...ontent', 'edit any image media', 'edit any landing_page content', 'edit any news_story content', 'edit any office content', 'edit any outreach_asset content', 'edit any page content', 'edit any person_profile content', 'edit any press_release content', 'edit any regional_health_care...ontent', 'edit any support_service content', 'edit any video media', 'edit own document media', 'edit own event content', 'edit own health_care_local_fa...ontent', 'edit own health_care_local_he...ontent', 'edit own health_care_region_d...ontent', 'edit own health_care_region_p...ontent', 'edit own image media', 'edit own landing_page content', 'edit own news_story content', 'edit own office content', 'edit own outreach_asset content', 'edit own page content', 'edit own person_profile content', 'edit own press_release content', 'edit own regional_health_care...ontent', 'edit own support_service content', 'edit own video media', 'edit terms in health_care_ser...xonomy', 'rebuild tablefield', 'revert all revisions', 'revert event revisions', 'revert health_care_local_faci...isions', 'revert health_care_local_heal...isions', 'revert health_care_region_det...isions', 'revert health_care_region_pag...isions', 'revert landing_page revisions', 'revert news_story revisions', 'revert office revisions', 'revert outreach_asset revisions', 'revert page revisions', 'revert person_profile revisions', 'revert press_release revisions', 'revert regional_health_care_s...isions', 'revert support_service revisions', 'schedule editorial transition archive', 'schedule editorial transition...lished', 'schedule editorial transition..._draft', 'schedule editorial transition publish', 'update any alert block content', 'update any media', 'update any promo block content', 'update media', 'use editorial transition archive', 'use editorial transition arch...lished', 'use editorial transition crea..._draft', 'use editorial transition publish', 'use editorial transition review', 'use editorial transition stag...ishing', 'use moderation dashboard', 'use moderation sidebar', 'use text format rich_text', 'use workbench access', 'view all media revisions', 'view all revisions', 'view any moderation dashboard', 'view any unpublished content', 'view event revisions', 'view health_care_local_facili...isions', 'view health_care_local_health...isions', 'view health_care_region_detai...isions', 'view health_care_region_page revisions', 'view landing_page revisions', 'view latest version', 'view news_story revisions', 'view office revisions', 'view outreach_asset revisions', 'view own unpublished content', 'view page revisions', 'view person_profile revisions', 'view press_release revisions', 'view regional_health_care_ser...isions', 'view sections in toolbar', 'view support_service revisions', 'view the administration theme', 'view unpublished paragraphs', 'view workbench access information'))
The permissions for the content_publisher do not match the expected permissions:
 'access administration pages',
 'access content overview',
 'access image_browser entity browser pages',
 'access media overview',
 'access media_browser entity browser pages',
 'access moderation notes',
 'access shortcuts',
 'access toolbar',
 'access user profiles',
 'administer menu',
 'create alert block content',
 'create document media',
 'create event content',
 'create health_care_local_facility content',
 'create health_care_local_health_service content',
 'create health_care_region_detail_page content',
 'create health_care_region_page content',
 'create image media',
 'create landing_page content',
 'create media',
 'create moderation notes',
 'create news_story content',
 'create office content',
 'create outreach_asset content',
 'create page content',
 'create person_profile content',
 'create press_release content',
 'create promo block content',
 'create regional_health_care_service_des content',
 'create support_service content',
 'create terms in health_care_service_taxonomy',
 'create url aliases',
 'create video media',
 'delete any alert block content',
 'delete any document media',
 'delete any event content',
 'delete any health_care_local_facility content',
 'delete any health_care_local_health_service content',
 'delete any health_care_region_detail_page content',
 'delete any health_care_region_page content',
 'delete any image media',
 'delete any landing_page content',
 'delete any media',
 'delete any news_story content',
 'delete any office content',
 'delete any outreach_asset content',
 'delete any page content',
 'delete any person_profile content',
 'delete any press_release content',
 'delete any promo block content',
 'delete any regional_health_care_service_des content',
 'delete any support_service content',
 'delete any video media',
 'delete media',
 'delete own document media',
 'delete own event content',
 'delete own health_care_local_facility content',
 'delete own health_care_local_health_service content',
 'delete own health_care_region_detail_page content',
 'delete own health_care_region_page content',
 'delete own image media',
 'delete own landing_page content',
 'delete own news_story content',
 'delete own office content',
 'delete own outreach_asset content',
 'delete own page content',
 'delete own person_profile content',
 'delete own press_release content',
 'delete own regional_health_care_service_des content',
 'delete own support_service content',
 'delete own video media',
 'delete terms in health_care_service_taxonomy',
 'edit any document media',
 'edit any documentation_page content',
 'edit any event content',
 'edit any health_care_local_facility content',
 'edit any health_care_local_health_service content',
 'edit any health_care_region_detail_page content',
 'edit any health_care_region_page content',
 'edit any image media',
 'edit any landing_page content',
 'edit any news_story content',
 'edit any office content',
 'edit any outreach_asset content',
 'edit any page content',
 'edit any person_profile content',
 'edit any press_release content',
 'edit any regional_health_care_service_des content',
 'edit any support_service content',
 'edit any video media',
 'edit own document media',
 'edit own event content',
 'edit own health_care_local_facility content',
 'edit own health_care_local_health_service content',
 'edit own health_care_region_detail_page content',
 'edit own health_care_region_page content',
 'edit own image media',
 'edit own landing_page content',
 'edit own news_story content',
 'edit own office content',
 'edit own outreach_asset content',
 'edit own page content',
 'edit own person_profile content',
 'edit own press_release content',
 'edit own regional_health_care_service_des content',
 'edit own support_service content',
 'edit own video media',
 'edit terms in health_care_service_taxonomy',
 'rebuild tablefield',
 'revert all revisions',
 'revert event revisions',
 'revert health_care_local_facility revisions',
 'revert health_care_local_health_service revisions',
 'revert health_care_region_detail_page revisions',
 'revert health_care_region_page revisions',
 'revert landing_page revisions',
 'revert news_story revisions',
 'revert office revisions',
 'revert outreach_asset revisions',
 'revert page revisions',
 'revert person_profile revisions',
 'revert press_release revisions',
 'revert regional_health_care_service_des revisions',
 'revert support_service revisions',
 'schedule editorial transition archive',
 'schedule editorial transition archived_published',
 'schedule editorial transition create_new_draft',
 'schedule editorial transition publish',
 'update any alert block content',
 'update any media',
 'update any promo block content',
 'update media',
 'use editorial transition archive',
 'use editorial transition archived_published',
 'use editorial transition create_new_draft',
 'use editorial transition publish',
 'use editorial transition review',
 'use editorial transition stage_for_publishing',
 'use moderation dashboard',
 'use moderation sidebar',
 'use text format rich_text',
 'use workbench access',
 'view all media revisions',
 'view all revisions',
 'view any moderation dashboard',
 'view any unpublished content',
 'view event revisions',
 'view health_care_local_facility revisions',
 'view health_care_local_health_service revisions',
 'view health_care_region_detail_page revisions',
 'view health_care_region_page revisions',
 'view landing_page revisions',
 'view latest version',
 'view news_story revisions',
 'view office revisions',
 'view outreach_asset revisions',
 'view own unpublished content',
 'view page revisions',
 'view person_profile revisions',
 'view press_release revisions',
 'view regional_health_care_service_des revisions',
 'view sections in toolbar',
 'view support_service revisions',
 'view the administration theme',
 'view unpublished paragraphs',
 'view workbench access information'

Failed asserting that false is true.

/app/docroot/core/tests/Drupal/KernelTests/AssertLegacyTrait.php:31
/app/tests/phpunit/SecurityRolesPermissionsTest.php:36

FAILURES!
Tests: 26, Assertions: 62, Failures: 3.

Operation took 0.656 seconds compared to the benchmark of 2 seconds.

Operation took 0.164 seconds compared to the benchmark of 2 seconds.

Operation took 0.484 seconds compared to the benchmark of 5 seconds.

Operation took 0.099 seconds compared to the benchmark of 5 seconds for type page.

Operation took 0.107 seconds compared to the benchmark of 5 seconds for type landing_page.

Operation took 0.897 seconds compared to the benchmark of 5 seconds.

Operation took 1.542 seconds compared to the benchmark of 5 seconds.

  ```
*AUTOMATED COMMENT FROM provision-ops/yaml-tests, running on pr407.cms.va.gov*


Successfully aliased the URL <https://rancagua-digital-webviews-fggmihdhd.now.sh> to the following aliases.

* https://webviews.now.sh
* https://rancagua-digital-webviews.rancagua-digital.now.sh
* https://rancagua-digital-webviews-git-master.rancagua-digital.now.sh


Successfully aliased the URL <https://my-react-app-5mu8ws52l.now.sh> to the following aliases.

* https://github-clone.now.sh
* https://my-react-app.jola.now.sh
* https://my-react-app-git-master.jola.now.sh


I think that's not correct. The attribute should only be added when requested, but the value depends if `nbSubordinates > 0`, right?


Successfully aliased the URL <https://next-diff-action-dpsnr1552.now.sh> to the following aliases.

* https://next-diff-action.lucleray.now.sh
* https://next-diff-action-git-master.lucleray.now.sh


is this definition needed?


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/548271774?utm_source=github_status&utm_medium=notification


payments remaining


Successfully aliased the URL <https://robins-nest-designs-kclvpty1u.now.sh> to the following aliases.

* https://robins-nest-designs.berkona.now.sh
* https://robins-nest-designs-git-master.berkona.now.sh


Successfully aliased the URL <https://marchworks-ararnbly2.now.sh> to the following aliases.

* https://march-works.marchworks.now.sh
* https://march-works-git-master.marchworks.now.sh


the ~ of static instances is undeterministic from multiple translation units. this manifests into the cub allocator destruction soon after the cuda shared object is unloaded form the process space. the destruction then makes cuda calls which then fails with 'driver already shutdown' (message paraphrased).

i got around this by creating this allocator on the heap.


This was not indented I suppose.


![Снимок экрана (790)](https://user-images.githubusercontent.com/50791221/59865698-61fd2880-9392-11e9-9c19-68e7b8117c19.png)


Successfully aliased the URL <https://monorepo-rgn827tr0.now.sh> to the following aliases.

* https://monorepo.storybook.now.sh
* https://monorepo-git-next.storybook.now.sh


Successfully aliased the URL <https://next-diff-action-eh5h8mvq2.now.sh> to the following aliases.

* https://next-diff-action.lucleray.now.sh
* https://next-diff-action-git-master.lucleray.now.sh


fast-forwarding master to auto = 52f1a03d


since row partitioner now uses caching device allocators, should these be changed to use caching_device_vector instead?


should ulNumOfBlocksToReceive be part of the OTA Context of the file being received ? Further compatibility with multiple file OTA support ?


This commit has quite a few inaccuracies due to problems regarding committing the Yelp dataset. Movielens_predictor.py and test_driver.py were commited by Jonathan C.


Successfully aliased the URL <https://portfolio-site-ny9kjff4z.now.sh> to the following aliases.

* https://carlo-clamucha.me
* https://portfolio-site.carloclamucha.now.sh
* https://portfolio-site-git-master.carloclamucha.now.sh


If it's just not that you're particularly aware of what is performance-friendly and what isn't (besides the obvious notions), I've collected a lot of knowledge of this over the many years that I've been modding publicly for CK2. I would be more than happy to share whatever you'd like to know or give you a crash course (of which you'll certainly already know some of the principles, of course), if you're up for it.

The EMF mission statement is still relevant.  Besides plausibility, performance & stability are cornerstones, and everyone working on EMF should be on the same page about that. It's not personal; it's policy. And if we're not on the same page, my extensive work to carefully design performant mechanics and the like when I could just do something stupidly slow much more easily is a waste, because the mod becomes slow (which begets instability in my experience) regardless.


`run to` --> `run`


On 20/06/2019 18:29, Stefan Seelmann wrote:
>
> I think that's not correct. The attribute should only be added when
> requested, but the value depends if |nbSubordinates > 0|, right?
>

Yes, I just have fixed it. I committed it a bit too early ;-)


nginx wucgi ipset and some package is affected!


Actually, the core-integ LookupIT tests caught the mistake.

On 20/06/2019 18:29, Stefan Seelmann wrote:
>
> I think that's not correct. The attribute should only be added when
> requested, but the value depends if |nbSubordinates > 0|, right?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/directory-server/commit/27a7d90ff96b45f90314bd9eb8d5b00592be9a33?email_source=notifications&email_token=AAWJQFKII5JDSE5NQITESA3P3OWANA5CNFSM4HZW4PM2YY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBAODJ6#commitcomment-34016574>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAWJQFMOBGHAKV4ZI5MGJRDP3OWANANCNFSM4HZW4PMQ>.
>


version 1.00.0 you mean?


Copy of this build can be found at
https://builds.myetherwallet.com/build/105a9c9d277fd6857c911981788d087b7423277e/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmZFbFrrQBxQdFuPJYiCre8NjiNHwiop1pmLi6q5M1jTQV
                       Virus Total analysis
                       https://www.virustotal.com/file/b6432bb901ec2e4c3de70c5da3ee5fbb5dd96b4fb0f14503064a90835365bcd2/analysis/1561048773/


Merge this pull request, really?


🔥 Device tests completed (Failed) on iOS on [Azure DevOps](https://dev.azure.com/devdiv/DevDiv/_build/index?buildId=2784576)(iOS): [Html Report](http://xamarin-storage/jenkins/xamarin-macios/d16-2/3ea877bd915a664dd763a1d0ce9b56701fbfd37a/2784576/device-tests/jenkins-results/tests/index.html) 🔥

🔥 Tests failed catastrophically on iOS  (no summary found)


Copy of this build can be found at
https://builds.myetherwallet.com/build/0f08d3b1f814b73d1620ec0430550ab9202a8ce5/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmR4f5Cp3fYDfRChDGd2GWN9A4ktopBcW7eFnBkYtF2KTp
                       Virus Total analysis
                       https://www.virustotal.com/file/e44276b765b0da392c4da6b9e0baff2f9015c2b65a590b662b41974b453ffc7c/analysis/1561048830/


ScheduleManagerRefactor (Myoldmopar) - x86_64-Linux-Ubuntu-18.04-gcc-7.4: OK (2470 of 2470 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


I think you need to get the deal id from the bid - the other adapters seem to do this - https://github.com/amir-sabbaghi/ht-wrapper-adapters/blob/master/just-premium/just-premium-htb.js#L251 https://github.com/amir-sabbaghi/ht-wrapper-adapters/blob/master/b-real-time/b-real-time-htb.js#L353


@theGleam Нет. Будет еще 0.100.1, 0.100, 2, 0.100.3 и так далее пока мы решим, что настало время выпустить версию 1.0.0


Oh you are right: it could be also something else:
`    <xs:element name='priority' type='xs:byte'/>`


@theGleam Not. There will be another 0.100.1, 0.100, 2, 0.100.3 and so on until we decide that it is time to release version 1.0.0


Nice work! I cannot tell the stuck condition without tests, either. Suggestions & questions are as follows:
1. In state_handler.cpp, why add bulletloaderstuck under the if of STATE_HANDLER_ENABLE_CHASSIS?
2. The back rotating speed is ... too fast and may lead to huge target current as the loader will need some time to move through a certain angle even given a large current.


```
me@host:~$ echo $XDG_CURRENT_DESKTOP
XFCE
```
too


Copy of this build can be found at
https://builds.myetherwallet.com/build/ae4e544b1e3429f1547779fa279df60b5c3a3f03/index.html
                       https://www.cloudflare-ipfs.com/ipfs/Qmb4czWwPfJk8KFAXyQkuGS6q3pBCLHZqwWE7mbb1nH2PJ
                       Virus Total analysis
                       https://www.virustotal.com/file/813cc62955a9183bfbcb8fde5222bfedb4b581f99bf5eea62648a335e36b3e15/analysis/1561049063/


Successfully aliased the URL <https://my-react-app-l7hx899qc.now.sh> to the following aliases.

* https://github-clone.now.sh
* https://my-react-app.jola.now.sh
* https://my-react-app-git-master.jola.now.sh


Er den altid initialiseret til 0 i CUDA/C++ når det er på stakken?


🔥 Device tests completed (Failed) on TvOS on [Azure DevOps](https://dev.azure.com/devdiv/DevDiv/_build/index?buildId=2784511)(TvOS): [Html Report](http://xamarin-storage/jenkins/xamarin-macios/master/ec1490cd5ee52066f0900c7aa289eac42662bcd7/2784511/device-tests/jenkins-results/tests/index.html) 🔥

# Test results

<details>
<summary>1 tests failed, 112 tests passed.</summary>

## Failed tests

 * [xUnit] Mono BCL tests group 4/tvOS - device/Release: TimedOut (HE0041: Error while processing device notifications from fff50:32:37:a1:c8:31fff (0x7f9fc0c973f0): Failed to communicate with the device. Please ensure the cable is properly connected, and try rebooting the device (error: 0xe8000065 kAMDMuxConnectError))
</details>


Copy of this build can be found at
https://builds.myetherwallet.com/build/5002034f1702acbf5e6afb5ce3ec54df5cdad400/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmWkKgaZHUJ35TSqrJYbxtJPZURgTqE66CT9iu5Z6hf6mW
                       Virus Total analysis
                       https://www.virustotal.com/file/2e3e4591be25ead7411bc388a806e6a6ec7951600984ea2926a9b1006384579e/analysis/1561049133/


I have

![image](https://user-images.githubusercontent.com/1038737/59866219-6114c880-938b-11e9-8938-f4d23f9ff27c.png)

and with align=right on the specific cells:

![image](https://user-images.githubusercontent.com/1038737/59866282-8275b480-938b-11e9-85c2-bd9efb055cb2.png)

you probably do not see it because the number of digits before the dot are equal in your case


You should avoid new and delete in code and use smart pointers


Probably a very hacky way to do things, but this is just to get it working. Optimizations will come.


1. Thanks!
2. Should it be defined in `utils` and imported?
3. Where else should this be done? Doesn't `spec` do the translating to be printed, so any string that is destined to be printed will go through here? Or should we have separate checks, one for HTML and one for LaTeX? @JacquesCarette


Thanks for providing an example on how this works :)


Successfully aliased the URL <https://convertmymoney-fzw5wqbk3.now.sh> to the following aliases.

* https://convertmymoney.jhonnipinto.now.sh
* https://convertmymoney-git-master.jhonnipinto.now.sh


Copy of this build can be found at
https://builds.myetherwallet.com/build/ab0321135a706159857c84224b00d342c0660f0d/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmeYErZbqQFNZQahNXJJsPd8bPegLJjxtUo7DhBrJsMZCt
                       Virus Total analysis
                       https://www.virustotal.com/file/41d7954c5d714b9404e3baa814029cfd18b8a3ffc65be1278280f2526134c505/analysis/1561049255/


Now could not deploy this pull request since it contains the following references to invalid secrets in the `env` sections of the `now.json` file:

* `ga-traking-id` (in env: `GA_TRACKING_ID)`

Add those secrets or remove them from the `env` maps in the `now.json` file.


I took special care not to touch anything inside of scopes that I knew were expensive, therefore the `ai = no` limitation would be a performance-saving one. If I accidentally did end up touching one, let me know and I'll revert it, but from my second scan-through, I haven't spotted any outside from the ones I just fixed (where the new filter with AI barons included would have become too lenient). All other events for which `ai = no` was removed were events that fired off of a random list tombola, events that were specifically triggered on certain actions (e.g. inheritance), or events that already fired for AI characters but contained code that was blocked off for them which shouldn't have been blocked off.


@HeaTTheatR Oh ok.. thanks :).


AAAAA


Good Work Uttkarsh


Now could not deploy this pull request since it contains the following references to invalid secrets in the `env` sections of the `now.json` file:

* `github-client-id` (in env: `GITHUB_CLIENT_ID)`
* `github-client-secret` (in env: `GITHUB_CLIENT_SECRET)`
* `session-secret` (in env: `SESSION_SECRET)`
* `domains` (in env: `DOMAINS)`
* `homepage-url` (in env: `HOMEPAGE_URL)`

Add those secrets or remove them from the `env` maps in the `now.json` file.


Looks good. Good job @Tyak99


<details>

<summary>Submitting the task to Taskcluster failed. Details</summary>

Client ID project/taskcluster/tc-github/production-2 does not have sufficient scopes and is missing the following scopes:

```
{
  "AllOf": [
    "docker-worker:capability:privileged",
    {
      "AnyOf": [
        {
          "AnyOf": [
            "queue:create-task:highest:aws-provisioner-v1/releng-svc",
            "queue:create-task:very-high:aws-provisioner-v1/releng-svc",
            "queue:create-task:high:aws-provisioner-v1/releng-svc",
            "queue:create-task:medium:aws-provisioner-v1/releng-svc",
            "queue:create-task:low:aws-provisioner-v1/releng-svc",
            "queue:create-task:very-low:aws-provisioner-v1/releng-svc",
            "queue:create-task:lowest:aws-provisioner-v1/releng-svc"
          ]
        },
        {
          "AnyOf": [
            "queue:create-task:aws-provisioner-v1/releng-svc",
            {
              "AllOf": [
                "queue:define-task:aws-provisioner-v1/releng-svc",
                "queue:task-group-id:taskcluster-github/bPYm9qj0RWe8OVv9TldUww",
                "queue:schedule-task:taskcluster-github/bPYm9qj0RWe8OVv9TldUww/U__RNDHcRBCQ7USj2OOJ1A"
              ]
            }
          ]
        }
      ]
    }
  ]
}
```

This request requires the client to satisfy the following scope expression:

```
{
  "AllOf": [
    "docker-worker:capability:privileged",
    "queue:route:statuses",
    {
      "AnyOf": [
        {
          "AllOf": [
            "queue:scheduler-id:taskcluster-github",
            {
              "AnyOf": [
                "queue:create-task:highest:aws-provisioner-v1/releng-svc",
                "queue:create-task:very-high:aws-provisioner-v1/releng-svc",
                "queue:create-task:high:aws-provisioner-v1/releng-svc",
                "queue:create-task:medium:aws-provisioner-v1/releng-svc",
                "queue:create-task:low:aws-provisioner-v1/releng-svc",
                "queue:create-task:very-low:aws-provisioner-v1/releng-svc",
                "queue:create-task:lowest:aws-provisioner-v1/releng-svc"
              ]
            }
          ]
        },
        {
          "AnyOf": [
            "queue:create-task:aws-provisioner-v1/releng-svc",
            {
              "AllOf": [
                "queue:define-task:aws-provisioner-v1/releng-svc",
                "queue:task-group-id:taskcluster-github/bPYm9qj0RWe8OVv9TldUww",
                "queue:schedule-task:taskcluster-github/bPYm9qj0RWe8OVv9TldUww/U__RNDHcRBCQ7USj2OOJ1A"
              ]
            }
          ]
        }
      ]
    }
  ]
}
```

---

* method:     createTask
* errorCode:  InsufficientScopes
* statusCode: 403
* time:       2019-06-20T16:53:01.305Z

</details>


Successfully aliased the URL <https://unit-converter-iuipnorbi.now.sh> to the following aliases.

* https://unit-converter.jhonnipinto.now.sh
* https://unit-converter-git-master.jhonnipinto.now.sh


Successfully aliased the URL <https://next-diff-action-nilab01zp.now.sh> to the following aliases.

* https://next-diff-action.lucleray.now.sh
* https://next-diff-action-git-master.lucleray.now.sh


<details>

<summary>Submitting the task to Taskcluster failed. Details</summary>

Client ID project/taskcluster/tc-github/production-2 does not have sufficient scopes and is missing the following scopes:

```
{
  "AllOf": [
    "docker-worker:capability:privileged",
    {
      "AnyOf": [
        {
          "AnyOf": [
            "queue:create-task:highest:aws-provisioner-v1/releng-svc",
            "queue:create-task:very-high:aws-provisioner-v1/releng-svc",
            "queue:create-task:high:aws-provisioner-v1/releng-svc",
            "queue:create-task:medium:aws-provisioner-v1/releng-svc",
            "queue:create-task:low:aws-provisioner-v1/releng-svc",
            "queue:create-task:very-low:aws-provisioner-v1/releng-svc",
            "queue:create-task:lowest:aws-provisioner-v1/releng-svc"
          ]
        },
        {
          "AnyOf": [
            "queue:create-task:aws-provisioner-v1/releng-svc",
            {
              "AllOf": [
                "queue:define-task:aws-provisioner-v1/releng-svc",
                "queue:task-group-id:taskcluster-github/Y-rZKsWXQIy9ukgn-LN7FA",
                "queue:schedule-task:taskcluster-github/Y-rZKsWXQIy9ukgn-LN7FA/IkLHeP5ESpmip6ZLKSzuAQ"
              ]
            }
          ]
        }
      ]
    }
  ]
}
```

This request requires the client to satisfy the following scope expression:

```
{
  "AllOf": [
    "docker-worker:capability:privileged",
    "queue:route:statuses",
    {
      "AnyOf": [
        {
          "AllOf": [
            "queue:scheduler-id:taskcluster-github",
            {
              "AnyOf": [
                "queue:create-task:highest:aws-provisioner-v1/releng-svc",
                "queue:create-task:very-high:aws-provisioner-v1/releng-svc",
                "queue:create-task:high:aws-provisioner-v1/releng-svc",
                "queue:create-task:medium:aws-provisioner-v1/releng-svc",
                "queue:create-task:low:aws-provisioner-v1/releng-svc",
                "queue:create-task:very-low:aws-provisioner-v1/releng-svc",
                "queue:create-task:lowest:aws-provisioner-v1/releng-svc"
              ]
            }
          ]
        },
        {
          "AnyOf": [
            "queue:create-task:aws-provisioner-v1/releng-svc",
            {
              "AllOf": [
                "queue:define-task:aws-provisioner-v1/releng-svc",
                "queue:task-group-id:taskcluster-github/Y-rZKsWXQIy9ukgn-LN7FA",
                "queue:schedule-task:taskcluster-github/Y-rZKsWXQIy9ukgn-LN7FA/IkLHeP5ESpmip6ZLKSzuAQ"
              ]
            }
          ]
        }
      ]
    }
  ]
}
```

---

* method:     createTask
* errorCode:  InsufficientScopes
* statusCode: 403
* time:       2019-06-20T16:54:00.999Z

</details>