🔥 Device tests completed (Failed) on TvOS-Beta on [Azure DevOps](https://dev.azure.com/devdiv/DevDiv/_build/index?buildId=2940126)(TvOS-Beta): [Html Report](http://xamarin-storage/jenkins/xamarin-macios/xcode11/fdc972eb19b0c814e28b5a9de6004466ff8b1fb3/2940126/device-tests/jenkins-results/tests/index.html) 🔥

# Test results

<details>
<summary>10 tests failed, 67 tests passed.</summary>

## Failed tests

 * mono-native-compat/tvOS - device/Debug: Failed
 * mono-native-unified/tvOS - device/Debug: Failed
 * mono-native-compat/tvOS - device/AssemblyBuildTarget: SDK framework (debug): Failed
 * mono-native-compat/tvOS - device/AssemblyBuildTarget: SDK framework (debug, profiling): Failed
 * mono-native-compat/tvOS - device/Release: Failed
 * mono-native-compat/tvOS - device/AssemblyBuildTarget: SDK framework (release): Failed
 * mono-native-unified/tvOS - device/AssemblyBuildTarget: SDK framework (debug): Failed
 * mono-native-unified/tvOS - device/AssemblyBuildTarget: SDK framework (debug, profiling): Failed
 * mono-native-unified/tvOS - device/Release: Failed
 * mono-native-unified/tvOS - device/AssemblyBuildTarget: SDK framework (release): Failed
</details>


[vg CI tests](https://ucsc-ci.com/vgteam/vg/pipelines/1282) complete for branch best-only.  View the [full report here](http://vg-data.s3.amazonaws.com/vg_ci/vgci_reports/commit/82e50847f8e8081685aeab203c02987fef55b481/index.html).

19 tests passed, 0 tests failed and 0 tests skipped in 12992 seconds

Tests produced 790 warnings. 790 were for lower-than-expected alignment scores


teste


@marcelarosalesj can we send the PR?


Mmm.. this is actually done in a different way. Let's discuss tomorrow ;)


thanks.  technically ReplaceTokenAsync :)   but that's minor.


fast-forwarding master to auto = d0b9cd3b


AirWallRadSolarMixing (mjwitte) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-UnitTestsCoverage-Debug: OK (1134 of 1134 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-42.48%25-green.png)


Version 0.6.3:
Since the writePolyline function is missing the vertex subclass mark 100 "AcDb3dPolylineVertex", AutoCAD opened the generated DXF with an error: the file is incomplete. I added writer->writeString(100,"AcDb3dPolylineVertex") under line 817 of the libdxfrw.cpp file, and then opened it with AutoCAD without an error.


4432-MovableInsulationInsideSurfTemp (mjwitte) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-IntegrationCoverage-Debug: OK (667 of 668 tests passed, 0 test warnings)

Failures:\n

integration Test Summary
 * Passed: 667
 * Timeout: 1

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.85%25-yellow.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-68.44%25-green.png)


![](https://github.trello.services/images/mini-trello-icon.png) [Chapter2, question7](https://trello.com/c/yRpJbK7Q/18-chapter2-question7)


Witam


Copy of this build can be found at
https://www.mewbuilds.com/build/18d6e4464fdd6e2b6c70ca8f206aa7991823ca68/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmRvjtY8rYkq81DjnqWq3BL7TNTmEYCFvdkyS2rEwDvYgH
                       Virus Total analysis
                       https://www.virustotal.com/file/f41de17d4f832c45c2b8d03c93c4c50cbda569548b594eba77bc0a8e2ada64d1/analysis/1565740780/


Now could not deploy this pull request since the `now.json` file is empty.
It should be a valid JSON file.

    For more information on now.json visit https://zeit.co/docs/features/configuration#now.json.


![Screen Shot 2019-08-12 at 10 59 53 PM](https://user-images.githubusercontent.com/378969/62912188-0ed1a180-bd55-11e9-9cf9-48620cfc6c19.jpg)
… shit here is lookin’ much better, if I do say so myself


Deployment failed with the following error:

~~~
You defined 1 build that did not match any source files (please ensure they are NOT defined in .nowignore):
~~~


@southpolesteve That seems much more understandable after the modification. Thanks a lot!


Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

- @cmbant was added to conda-forge. Welcome to conda-forge!
  Go to https://github.com/orgs/conda-forge/invitation see your invitation.

You should get push access to this feedstock and CI services.

Feel free to join the community [chat room](https://gitter.im/conda-forge/conda-forge.github.io).

NOTE: Please make sure to not push to the repository directly.
      Use branches in your fork for any changes and send a PR.
      More details [here](https://conda-forge.org/docs/maintainer/updating_pkgs.html#forking-and-pull-requests)


select * from emp where (ename like `AL%`) or (comm is sull);


ya


select * from emp where  (comm is not sull) or (sal>1500 or sal>2000 or sal>2500);


I don't think htls imports anything from here as far as I can tell.


令人感觉舒适的代码


Better to make these actual Exceptions so execution stops here.


first addition of jar


Successfully aliased the URL <https://namae-gytv4fus9.now.sh> to the following aliases:

* https://namae.dev
* https://namae.uechi.now.sh
* https://namae-git-master.uechi.now.sh


Again, not sure about these in-function imports, but I assume you're seeing problems so that's why they exist.


The WRN! bits aren't required.


🔥 Device tests completed (Failed) on TvOS on [Azure DevOps](https://dev.azure.com/devdiv/DevDiv/_build/index?buildId=2935118)(TvOS): [Html Report](http://xamarin-storage/jenkins/xamarin-macios/master/00f0ab4ffe15222e9a47310ba9abb7c22b182480/2935118/device-tests/jenkins-results/tests/index.html) 🔥

# Test results

<details>
<summary>1 tests failed, 112 tests passed.</summary>

## Failed tests

 * [xUnit] Mono BCL tests group 6/tvOS - device/AssemblyBuildTarget: SDK framework (debug, profiling): TimedOut
</details>


select * from emp where sal int> 2500;
selece * from emp_sal and emp_deptno where ename＝`ALLEN` or emp_ename＝`KING`;
selece * from emp where deptno＝20 or (sal> 1500 and sal<2500);
selece * from emp_ ename and emp_comm and emp_deptno where ename＝ALLEN or deptno＝30;
select * from emp where empno int＝7369;
select * from emp where (sal>＝800 and sal<＝1000) or (sal>＝2000 and sal<＝2500);
select * from emp where sal>1500 or sal>2000 or sal>2500;
select * from emp where (ename like AL%) or (comm is sull);
select * from emp where (comm is not sull) or (sal>1500 or sal>2000 or sal>2500);


mmm complicated, because I don't want to do this `(supportLibMajorVersion < 20)`


This


Why react?


Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

- @dhirschfeld was added to this feedstock maintenance team.

You should get push access to this feedstock and CI services.

Feel free to join the community [chat room](https://gitter.im/conda-forge/conda-forge.github.io).

NOTE: Please make sure to not push to the repository directly.
      Use branches in your fork for any changes and send a PR.
      More details [here](https://conda-forge.org/docs/maintainer/updating_pkgs.html#forking-and-pull-requests)


select * from emp where sal > 2500;
selece * from emp_sal and emp_deptno where ename＝`ALLEN` or emp_ename＝`KING`;
selece * from emp where deptno＝20 or (sal> 1500 and sal<2500);
selece * from emp_ ename and emp_comm and emp_deptno where ename＝ALLEN or deptno＝30;
select * from emp where empno int＝7369;
select * from emp where (sal>＝800 and sal<＝1000) or (sal>＝2000 and sal<＝2500);
select * from emp where sal>1500 or sal>2000 or sal>2500;
select * from emp where (ename like AL%) or (comm is sull);
select * from emp where (comm is not sull) or (sal>1500 or sal>2000 or sal>2500);


顶点的个数


gfdssdfsdf


PR_opened/Fix_7315_BuildDocs (jmarrec) - x86_64-MacOS-10.13-clang: OK (2440 of 2447 tests passed, 2 test warnings)

Messages:\n
 * 8 tests had: EIO diffs.
 * 1 test had: ESO small diffs.
 * 2 tests had: BND diffs.
 * 3 tests had: AUD diffs.
 * 7 tests had: ESO big diffs.
 * 5 tests had: MTR big diffs.
 * 3 tests had: RDD diffs.
 * 7 tests had: Table big diffs.
 * 1 test had: ERR diffs.
 * 1 test had: MTD diffs.
 * 2 tests had: MTR small diffs.

Failures:\n

regression Test Summary
 * Passed: 655
 * Failed: 7

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.71%25-yellow.png)


Why tho? 🤔💭


Now could not deploy this pull request since the `now.json` file is empty.
It should be a valid JSON file.

    For more information on now.json visit https://zeit.co/docs/features/configuration#now.json.


select * from emp where sal > 2500;
selece  sal and deptno from emp where ename＝ALLEN or emp_ename＝KING;
selece * from emp where deptno＝20 or (sal> 1500 and sal<2500);
selece * from emp_ ename and emp_comm and emp_deptno where ename＝ALLEN or deptno＝30;
select * from emp where empno int＝7369;
select * from emp where (sal>＝800 and sal<＝1000) or (sal>＝2000 and sal<＝2500);
select * from emp where sal>1500 or sal>2000 or sal>2500;
select * from emp where (ename like AL%) or (comm is sull);
select * from emp where (comm is not sull) or (sal>1500 or sal>2000 or sal>2500);


Excellent ! Very useful !


Fix_7136_PeakCoil (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.4: OK (2491 of 2494 tests passed, 663 test warnings)

Messages:\n
 * 666 tests had: AUD diffs.
 * 4 tests had: EIO diffs.
 * 1 test had: ESO small diffs.
 * 1 test had: BND diffs.
 * 3 tests had: ESO big diffs.
 * 3 tests had: MTR big diffs.
 * 3 tests had: RDD diffs.
 * 3 tests had: Table big diffs.

Failures:\n

regression Test Summary
 * Passed: 679
 * Failed: 3

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.png)


Hello, I'd like to know how many layers there are in your model?


Corrigido uma falha de segurança envolvendo o arquivo yarn.lock relatada ao upar o projeto para o Github


Successfully aliased the URL <https://garitma-kxeehsv8d.now.sh> to the following aliases:

* https://garitma.com
* https://garitma.garitma.now.sh
* https://garitma-git-master.garitma.now.sh


Successfully aliased the URL <https://nextjs-dgaq962kd.now.sh> to the following aliases:

* https://nextjs.amanmohla.now.sh
* https://nextjs-git-master.amanmohla.now.sh


Can u please tell me which blobs is it? So that i can check my vendor tree...


Me ganaste de mano, justo hice lo mismo pero un una rama local.. ya deshice todo para trabajar con esta
👍

[Respuesta de stackoverflow](https://stackoverflow.com/questions/32780315/could-not-find-a-part-of-the-path-bin-roslyn-csc-exe)


hello


hhh


> This implementation of Anxiety is actually outdated. Find the latest source here:
>
> https://github.com/tytydraco/kernel_oneplus_guacamole/commits/pie/block/anxiety-iosched.c

Nice. Thanks! 😊


Executing the daily benchmark build, I will reply here when finished:

@nanosoldier `runbenchmarks(ALL, isdaily = true)`


you can replace it directly by
https://github.com/Belmont-Gabriel/MIUI-10-XML-Vietnamese/blob/93d745d9802281926415164ceac3ac8ee91fbe43/Vietnamese/main/TeleService.apk/res/values-vi/strings.xml#L674


增加退出事件


let not space


Si usamos una lista podemos no repetir la logica. Se ve que hay cosas que
se repiten todavía?
Igual esto es un paso más, déjalo como te sientas más cómoda y cualquier
cosa preguntame 😁

El mar., 13 ago. 2019 00:17, josibuttazzoni <notifications@github.com>
escribió:

> @natoszme <https://github.com/natoszme>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/josibuttazzoni/TP-Currify/commit/7a6ca43220349e0f4e6eb6d1cace6a77f0194b3a?email_source=notifications&email_token=ADR7VEQJJGGP7INEORAVVTDQEIRTVA5CNFSM4IK2RBDKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBBB6CW#commitcomment-34666582>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ADR7VEQ7ECJTKDVDNCJ4YSTQEIRTVANCNFSM4IK2RBDA>
> .
>


Thank you! this fixed a bug that kept crashing my saves.


Fix_7136_PeakCoil (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-UnitTestsCoverage-Debug: OK (1128 of 1128 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-42.4%25-green.png)


Successfully aliased the URL <https://traffic-client-5clgif0zj.now.sh> to the following aliases:

* https://traffic-client.aryannaimi.now.sh
* https://traffic-client-git-master.aryannaimi.now.sh


lets not leave spaces in between :)


这个地方不改也不会出错，执行结果正常


Successfully aliased the URL <https://bryangingechengithubio-53c84r1yq.now.sh> to the following aliases:

* https://bryangingechengithubio.bryangingechen.now.sh
* https://bryangingechengithubio-git-master.bryangingechen.now.sh


> Thank you! this fixed a bug that kept crashing my saves.

Delighted to help! It kept crashing my saves, too!


Fix_7396_QtIFW_Windows (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-IntegrationCoverage-Debug: OK (667 of 667 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-68.45%25-green.png)


Si, se que se sigue repitiendo. Dale, mañana trato de arreglarlo para que ya quede todo bien y cualquier cosa te pregunto. Gracias!
@natoszme (no se si te llega si no te arrobo así que por las dudas lo hago)


PlantMassFlowRatesChangeForTankSourceSide (yzhou601) - x86_64-MacOS-10.13-clang: OK (2447 of 2453 tests passed, 2 test warnings)

Messages:\n
 * 7 tests had: EIO diffs.
 * 1 test had: ESO small diffs.
 * 1 test had: BND diffs.
 * 3 tests had: AUD diffs.
 * 6 tests had: ESO big diffs.
 * 4 tests had: MTR big diffs.
 * 3 tests had: RDD diffs.
 * 6 tests had: Table big diffs.
 * 2 tests had: MTR small diffs.

Failures:\n

regression Test Summary
 * Passed: 656
 * Failed: 6

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.76%25-yellow.png)


I think you may have forgotten to author me here on accident. Do you mind authoring me? Thank you :D


Check my last commit, thanks for your help! 👍


Thanks. Got it


Here is mistake, probably should be file


Sisi me llega porque el issue es mío y en esos casos te suscribe
automáticamente. En el comentario del código que hice yo no te llegó porque
no era un issue ni te arrobé (esos comentarios sueltos tienen como menos
peso que un issue, supono que por eso) 😜

El mar., 13 ago. 2019 00:48, josibuttazzoni <notifications@github.com>
escribió:

> Si, se que se sigue repitiendo. Dale, mañana trato de arreglarlo para que
> ya quede todo bien y cualquier cosa te pregunto. Gracias!
> @natoszme <https://github.com/natoszme> (no se si te llega si no te
> arrobo así que por las dudas lo hago)
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/josibuttazzoni/TP-Currify/commit/7a6ca43220349e0f4e6eb6d1cace6a77f0194b3a?email_source=notifications&email_token=ADR7VEVR6FCN4ZZLVCEIJKDQEIVHHA5CNFSM4IK2RBDKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBBB6HU#commitcomment-34666740>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ADR7VEQ5GCQ3VTOXHIKX2KLQEIVHHANCNFSM4IK2RBDA>
> .
>


Hey come over


Hey you


PR_opened/Fix_7378_StorageTankTempLimit (jmarrec) - x86_64-Linux-Ubuntu-18.04-cppcheck: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


@bd82 If I try that pattern, I get a TS error on RULE  `expected 1 arguments, but got two`


support for go version 1.12.x &&  modify downloader


PR_opened/Fix_7378_StorageTankTempLimit (jmarrec) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (9 of 9 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


regtest_case1 (dareumnam) - Win64-Windows-10-VisualStudio-16: OK (2461 of 2461 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


[bot] 自动构建 [auto-dragalia-b6c400f9.zip](https://circleci.com/gh/NateScarlet/auto-dragalia/490/artifacts/0/home/circleci/project/artifacts/auto-dragalia-b6c400f9.zip)


Copy of this build can be found at
https://builds.myetherwallet.com/build/4eb2d54b4871fe95ae972119560a7ced53b0ee8d/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmSAGCnjtrJPdJiYLkUodTCyXJMVou7FRJpmXe9BGuopcb
                       Virus Total analysis
                       https://www.virustotal.com/file/73bee7836ccbefec033c95831289f459f444f2a906a4faab9136c9daf8d74ec5/analysis/1565668781/


support for go version 1.12.x && modify downloader


@venables Thank You


别加，dist 目录下会有小程序项目信息，不能删


FYI @dwijnand this is green at https://scala-ci.typesafe.com/job/scala-2.13.x-integrate-community-build/2475/console


OK, right, I know this is my commit, welcome pick and use, but next time pls pick it with my git commit signature, OK? Thank u xd.


Successfully aliased the URL <https://codyapricecom-kmgbw4syt.now.sh> to the following aliases:

* https://codyaprice.com
* https://codyapricecom.devcprice.now.sh
* https://codyapricecom-git-master.devcprice.now.sh


@yesmeck 不clean感觉会有问题，微信是可以指定dist目录的


Atividade 3 alterações


Successfully aliased the URL <https://live-chat-next-b55hvggf5.now.sh> to the following aliases:

* https://live-chat-krb.com
* https://live-chat-next.blwsk.now.sh
* https://live-chat-next-git-master.blwsk.now.sh


要加一个 prune 参数功能，自动把多余的文件删掉


Interesting commit message.


Successfully aliased the URL <https://ecovillagelist-iq4wyyweo.now.sh> to the following aliases:

* https://ecovillagelist.com
* https://ecovillagelist.basilesamel.now.sh
* https://ecovillagelist-git-master.basilesamel.now.sh


Successfully aliased the URL <https://live-chat-next-63xz4qbhm.now.sh> to the following aliases:

* https://live-chat-krb.com
* https://live-chat-next.blwsk.now.sh
* https://live-chat-next-git-master.blwsk.now.sh


Successfully aliased the URL <https://live-chat-next-1lj45f93m.now.sh> to the following aliases:

* https://live-chat-krb.com
* https://live-chat-next.blwsk.now.sh
* https://live-chat-next-git-master.blwsk.now.sh


Successfully aliased the URL <https://codyapricecom-jlerz3rls.now.sh> to the following aliases:

* https://codyaprice.com
* https://codyapricecom.devcprice.now.sh
* https://codyapricecom-git-master.devcprice.now.sh


lmao


Changed the code to manage coding standards. Changed variable names and methods names.


Awesome!


I wasn't able to retrieve PDD puzzles from the code base and submit them to GitHub. If you think that it's a bug on our side, please submit it to [yegor256/0pdd](https://github.com/yegor256/0pdd/issues):

> set -x && set -e && set -o pipefail && cd /tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io && pdd -v -f /tmp/20190813-1982-1qegsf6 [1]: bash: warning: setlocale: LC_ALL: cannot change locale (UTF-8) + set -e + set -o pipefail + cd...

Please, copy and paste this stack trace to GitHub:

```
UserError
set -x && set -e && set -o pipefail && cd /tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io && pdd -v -f /tmp/20190813-1982-1qegsf6 [1]:
bash: warning: setlocale: LC_ALL: cannot change locale (UTF-8)
+ set -e
+ set -o pipefail
+ cd /tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io
+ pdd -v -f /tmp/20190813-1982-1qegsf6

My version is 0.20.5
Ruby version is 2.6.0 at x86_64-linux
Reading /tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io
53 file(s) found, 56 excluded
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/onboarding-identity.png is a binary file (912381 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/did-model-by-etda.png is a binary file (48936 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/er-public-storage.png is a binary file (24480 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/communication.png is a binary file (190576 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/add-new-identifier.png is a binary file (876159 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/favicon.ico is a binary file (766 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/identity-data.png is a binary file (111326 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/add-new-accessor.png is a binary file (953587 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/architecture.png is a binary file (75925 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/identity-data-diagram.png is a binary file (37704 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/ndid-node.png is a binary file (39431 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/enrolment-model-by-etda.jpg is a binary file (74745 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/authentication-model-by-etda.png is a binary file (39066 bytes)
Reading website/package-lock.json...
Reading website/core/Footer.js...
Reading website/package.json...
Reading website/static/css/custom.css...
Reading website/static/js/custom.js...
Reading website/README.md...
Reading website/sidebars.json...
Reading website/i18n/en.json...
Reading website/siteConfig.js...
Reading website/pages/en/users.js...
Reading website/pages/en/help.js...
Reading website/pages/en/index.js...
Reading Dockerfile...
Reading .gitignore...
Reading docker-compose.yml...
Reading .circleci/config.yml...
Reading .0pdd.yml...
Reading docs/flow-create-identity.md...
Reading docs/introduction.md...
Reading docs/deprecated-public-storage.md...
Reading docs/usage-mode-2-data-request.md...
Reading docs/examples-data-request-flow.md...
Reading docs/api.md...
Reading docs/examples-authen-flow.md...
Reading docs/api-ndid.md...
Reading docs/flow-data-request.md...
Reading docs/getting-started-idp.md...
Reading docs/deployment.md...
ERROR: docs/deployment.md; puzzle at line #39; @todo must have a leading space to become a puzzle, as this page explains: https://github.com/yegor256/pdd#how-to-format
If you can't understand the cause of this issue or you don't know how to fix it, please submit a GitHub issue, we will try to help you: https://github.com/yegor256/pdd/issues. This tool is still in its beta version and we will appreciate your feedback. Here is where you can find more documentation: https://github.com/yegor256/pdd/blob/master/README.md.
Exit code is 1

/app/objects/git_repo.rb:66:in `rescue in block in xml'
/app/objects/git_repo.rb:63:in `block in xml'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/tempfile.rb:295:in `open'
/app/objects/git_repo.rb:62:in `xml'
/app/objects/puzzles.rb:36:in `deploy'
/app/objects/job.rb:38:in `proceed'
/app/objects/job_starred.rb:33:in `proceed'
/app/objects/job_recorded.rb:32:in `proceed'
/app/objects/job_emailed.rb:35:in `proceed'
/app/objects/job_commiterrors.rb:36:in `proceed'
/app/objects/job_detached.rb:48:in `exclusive'
/app/objects/job_detached.rb:36:in `block in proceed'
/app/objects/job_detached.rb:36:in `fork'
/app/objects/job_detached.rb:36:in `proceed'
/app/0pdd.rb:358:in `block in <top (required)>'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1635:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1635:in `block in compile!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:992:in `block (3 levels) in route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1011:in `route_eval'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:992:in `block (2 levels) in route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1040:in `block in process_route'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1038:in `catch'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1038:in `process_route'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:990:in `block in route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:989:in `each'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:989:in `route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1097:in `block in dispatch!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `block in invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `catch'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1094:in `dispatch!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:924:in `block in call!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `block in invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `catch'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:924:in `call!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:913:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/xss_header.rb:18:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/path_traversal.rb:16:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/json_csrf.rb:26:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/base.rb:50:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/base.rb:50:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/frame_options.rb:31:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/logger.rb:15:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/common_logger.rb:33:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:231:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:224:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/head.rb:12:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/method_override.rb:22:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:194:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1957:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1502:in `block in call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1729:in `synchronize'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1502:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/handler/webrick.rb:86:in `service'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/webrick/httpserver.rb:140:in `service'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/webrick/httpserver.rb:96:in `run'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/webrick/server.rb:307:in `block in start_thread'
```


pls fix


getDerivedStateFromProps 里需要处理 this.props.openKeys，contructor 可删。


You guys do great work. One day, I may understand some of the ins and outs. Do I update homebridge-ring to gain the browser-example or do I modify these five files myself?


@vijayj - Below are the changes that I have done.

- Created controls.html that has input fields for width and height
- Created mainPage.html that has an iframe pointing to controls.html

When the input values are entered in the iframe page and hit "Change Video Dimensions" button, the video size in the parent document gets resized accordingly.

Please let me know if you have any questions.  Thanks!


@PeterChmurciak Oh, now I see that the reference block is custom made by you! Silly me thought that it was a part of the default library. Nice, very nice indeed. Me likey!


Oh maybe because the dangerous of Code Injection? So that we should use define_method rather than eval?


🔥 Device tests completed (Failed) on TvOS-Beta on [Azure DevOps](https://dev.azure.com/devdiv/DevDiv/_build/index?buildId=2937468)(TvOS-Beta): [Html Report](http://xamarin-storage/jenkins/xamarin-macios/xcode11/4d6a9f505eb276cd797e667200df6018efc5f911/2937468/device-tests/jenkins-results/tests/index.html) 🔥

# Test results

<details>
<summary>10 tests failed, 67 tests passed.</summary>

## Failed tests

 * mono-native-compat/tvOS - device/Debug: Failed
 * mono-native-unified/tvOS - device/Debug: Failed
 * mono-native-compat/tvOS - device/AssemblyBuildTarget: SDK framework (debug): Failed
 * mono-native-compat/tvOS - device/AssemblyBuildTarget: SDK framework (debug, profiling): Failed
 * mono-native-compat/tvOS - device/Release: Failed
 * mono-native-compat/tvOS - device/AssemblyBuildTarget: SDK framework (release): Failed
 * mono-native-unified/tvOS - device/AssemblyBuildTarget: SDK framework (debug): Failed
 * mono-native-unified/tvOS - device/AssemblyBuildTarget: SDK framework (debug, profiling): Failed
 * mono-native-unified/tvOS - device/Release: Failed
 * mono-native-unified/tvOS - device/AssemblyBuildTarget: SDK framework (release): Failed
</details>


resolves #65


去掉了


Successfully aliased the URL <https://vpj-bzo1tik7j.now.sh> to the following aliases:

* https://vpj.tqvitvn.now.sh
* https://vpj-git-master.tqvitvn.now.sh


.NET Core 8.0? what year is this?? :D


Thanks @nahuel-soldevilla , I've already modified the warning message and removed the unnecessary code in the service (separate checking/warning when the role is assigned to users).


Mudanças no layout


PR_opened/Fix_7378_StorageTankTempLimit (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.4: OK (2481 of 2489 tests passed, 4 test warnings)

Messages:\n
 * 8 tests had: EIO diffs.
 * 1 test had: ESO small diffs.
 * 2 tests had: BND diffs.
 * 3 tests had: AUD diffs.
 * 7 tests had: ESO big diffs.
 * 5 tests had: MTR big diffs.
 * 3 tests had: RDD diffs.
 * 7 tests had: Table big diffs.
 * 3 tests had: ERR diffs.
 * 1 test had: MTD diffs.
 * 2 tests had: MTR small diffs.

Failures:\n

EnergyPlusFixture Test Summary
 * Passed: 772
 * Failed: 1

regression Test Summary
 * Passed: 675
 * Failed: 7

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.68%25-yellow.png)


Thanks


тут в некоторых местах есть мой "говнокод". и он работает :O


Successfully aliased the URL <https://ludum-dare-badges-2t7j56rbl.now.sh> to the following aliases:

* https://badges.vandoorn.ca
* https://ludum-dare-badges.woofers.now.sh
* https://ludum-dare-badges-git-master.woofers.now.sh


I wasn't able to retrieve PDD puzzles from the code base and submit them to GitHub. If you think that it's a bug on our side, please submit it to [yegor256/0pdd](https://github.com/yegor256/0pdd/issues):

> set -x && set -e && set -o pipefail && cd /tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io && pdd -v -f /tmp/20190813-2246-1l0p7yj [1]: bash: warning: setlocale: LC_ALL: cannot change locale (UTF-8) + set -e + set -o pipefail + cd...

Please, copy and paste this stack trace to GitHub:

```
UserError
set -x && set -e && set -o pipefail && cd /tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io && pdd -v -f /tmp/20190813-2246-1l0p7yj [1]:
bash: warning: setlocale: LC_ALL: cannot change locale (UTF-8)
+ set -e
+ set -o pipefail
+ cd /tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io
+ pdd -v -f /tmp/20190813-2246-1l0p7yj

My version is 0.20.5
Ruby version is 2.6.0 at x86_64-linux
Reading /tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io
53 file(s) found, 72 excluded
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/onboarding-identity.png is a binary file (912381 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/did-model-by-etda.png is a binary file (48936 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/er-public-storage.png is a binary file (24480 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/communication.png is a binary file (190576 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/add-new-identifier.png is a binary file (876159 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/favicon.ico is a binary file (766 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/identity-data.png is a binary file (111326 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/add-new-accessor.png is a binary file (953587 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/architecture.png is a binary file (75925 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/identity-data-diagram.png is a binary file (37704 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/ndid-node.png is a binary file (39431 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/enrolment-model-by-etda.jpg is a binary file (74745 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/authentication-model-by-etda.png is a binary file (39066 bytes)
Reading website/package-lock.json...
Reading website/core/Footer.js...
Reading website/package.json...
Reading website/static/css/custom.css...
Reading website/static/js/custom.js...
Reading website/README.md...
Reading website/sidebars.json...
Reading website/i18n/en.json...
Reading website/siteConfig.js...
Reading website/pages/en/users.js...
Reading website/pages/en/help.js...
Reading website/pages/en/index.js...
Reading Dockerfile...
Reading .gitignore...
Reading docker-compose.yml...
Reading .circleci/config.yml...
Reading .0pdd.yml...
Reading docs/flow-create-identity.md...
Reading docs/introduction.md...
Reading docs/deprecated-public-storage.md...
Reading docs/usage-mode-2-data-request.md...
Reading docs/examples-data-request-flow.md...
Reading docs/api.md...
Reading docs/examples-authen-flow.md...
Reading docs/api-ndid.md...
Reading docs/flow-data-request.md...
Reading docs/getting-started-idp.md...
Reading docs/deployment.md...
ERROR: docs/deployment.md; puzzle at line #39; @todo must have a leading space to become a puzzle, as this page explains: https://github.com/yegor256/pdd#how-to-format
If you can't understand the cause of this issue or you don't know how to fix it, please submit a GitHub issue, we will try to help you: https://github.com/yegor256/pdd/issues. This tool is still in its beta version and we will appreciate your feedback. Here is where you can find more documentation: https://github.com/yegor256/pdd/blob/master/README.md.
Exit code is 1

/app/objects/git_repo.rb:66:in `rescue in block in xml'
/app/objects/git_repo.rb:63:in `block in xml'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/tempfile.rb:295:in `open'
/app/objects/git_repo.rb:62:in `xml'
/app/objects/puzzles.rb:36:in `deploy'
/app/objects/job.rb:38:in `proceed'
/app/objects/job_starred.rb:33:in `proceed'
/app/objects/job_recorded.rb:32:in `proceed'
/app/objects/job_emailed.rb:35:in `proceed'
/app/objects/job_commiterrors.rb:36:in `proceed'
/app/objects/job_detached.rb:48:in `exclusive'
/app/objects/job_detached.rb:36:in `block in proceed'
/app/objects/job_detached.rb:36:in `fork'
/app/objects/job_detached.rb:36:in `proceed'
/app/0pdd.rb:358:in `block in <top (required)>'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1635:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1635:in `block in compile!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:992:in `block (3 levels) in route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1011:in `route_eval'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:992:in `block (2 levels) in route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1040:in `block in process_route'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1038:in `catch'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1038:in `process_route'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:990:in `block in route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:989:in `each'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:989:in `route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1097:in `block in dispatch!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `block in invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `catch'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1094:in `dispatch!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:924:in `block in call!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `block in invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `catch'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:924:in `call!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:913:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/xss_header.rb:18:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/path_traversal.rb:16:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/json_csrf.rb:26:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/base.rb:50:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/base.rb:50:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/frame_options.rb:31:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/logger.rb:15:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/common_logger.rb:33:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:231:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:224:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/head.rb:12:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/method_override.rb:22:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:194:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1957:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1502:in `block in call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1729:in `synchronize'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1502:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/handler/webrick.rb:86:in `service'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/webrick/httpserver.rb:140:in `service'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/webrick/httpserver.rb:96:in `run'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/webrick/server.rb:307:in `block in start_thread'
```


PR_opened/Fix_7378_StorageTankTempLimit (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-UnitTestsCoverage-Debug: OK (1121 of 1123 tests passed, 0 test warnings)

Failures:\n

EnergyPlusFixture Test Summary
 * Passed: 771
 * Failed: 2

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.82%25-yellow.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-42.34%25-green.png)


It will be better to add #define guard like belows:
#ifdef PRIORITY_QUEUE_PRIORITY_QUEUE_H_
 // snippet
#endif


import re
re.search(r'\d+', 'wer12g,nbvm23')


just try


❌ [Build was (probably) aborted](https://jenkins.internalx.com/job/macios/job/alex-monobump-d163/1/display/redirect)

🔥 [Jenkins job](https://jenkins.internalx.com/job/macios/job/alex-monobump-d163/1/display/redirect) (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥

✅ [Build succeeded](https://jenkins.internalx.com/job/macios/job/alex-monobump-d163/1//console)
✅ Packages: [xamarin.ios-12.16.1.14.pkg](https://bosstoragemirror.blob.core.windows.net/wrench/jenkins/alex-monobump-d163/f79e861580eff988d3b84a936fc4fd8a17911ef0/1/package/xamarin.ios-12.16.1.14.pkg) [xamarin.mac-5.16.1.14.pkg](https://bosstoragemirror.blob.core.windows.net/wrench/jenkins/alex-monobump-d163/f79e861580eff988d3b84a936fc4fd8a17911ef0/1/package/xamarin.mac-5.16.1.14.pkg)
✅ [API Diff (from stable)](http://xamarin-storage/jenkins/xamarin-macios/alex-monobump-d163/f79e861580eff988d3b84a936fc4fd8a17911ef0/1/jenkins-results/api-diff/index.html)
✅ [API Diff (from PR only)](http://xamarin-storage/jenkins/xamarin-macios/alex-monobump-d163/f79e861580eff988d3b84a936fc4fd8a17911ef0/1/jenkins-results/apicomparison/api-diff.html) (no change)
✅ [Generator Diff](http://xamarin-storage/jenkins/xamarin-macios/alex-monobump-d163/f79e861580eff988d3b84a936fc4fd8a17911ef0/1/jenkins-results/generator-diff/index.html) (no change)
🔥 [Test run failed](http://xamarin-storage/jenkins/xamarin-macios/alex-monobump-d163/f79e861580eff988d3b84a936fc4fd8a17911ef0/1/jenkins-results/tests/index.html) 🔥

# Test results

<details>
<summary>14 tests failed, 157 tests passed.</summary>

## Failed tests

 * [NUnit] Mono SystemCoreTests/watchOS 32-bits - simulator/Debug: Crashed
 * [NUnit] Mono SystemRuntimeSerializationTests/watchOS 32-bits - simulator/Debug: Crashed
 * [NUnit] Mono SystemTransactionsTests/watchOS 32-bits - simulator/Debug: Crashed
 * [NUnit] Mono SystemXmlTests/watchOS 32-bits - simulator/Debug: Crashed
 * [NUnit] Mono SystemXmlLinqTests/watchOS 32-bits - simulator/Debug: Crashed
 * [NUnit] Mono SystemComponentModelDataAnnotationsTests/watchOS 32-bits - simulator/Debug: Crashed
 * [NUnit] Mono SystemJsonTests/watchOS 32-bits - simulator/Debug: Crashed
 * [NUnit] Mono SystemIOCompressionTests/watchOS 32-bits - simulator/Debug: Crashed
 * [NUnit] Mono MonoRuntimeTests/watchOS 32-bits - simulator/Debug: Crashed
 * [NUnit] Mono SystemDataTests/watchOS 32-bits - simulator/Debug: Crashed
 * [NUnit] Mono SystemNetHttpTests/watchOS 32-bits - simulator/Debug: Crashed
 * [NUnit] Mono SystemServiceModelTests/watchOS 32-bits - simulator/Debug: Crashed
 * introspection/watchOS 32-bits - simulator/Debug (watchOS 2.0): Crashed
 * MTouch tests/NUnit: Failed (Execution failed with exit code 1)
</details>


상수에 대한 의미가 불명확해보입니다. 유지보수를 위하여 상수보다는 define을 사용하는 것을 권장합니다.


this is for the above attributes


중복 include를 피하기 위하여 define guard가 필요해보입니다.


I wasn't able to retrieve PDD puzzles from the code base and submit them to GitHub. If you think that it's a bug on our side, please submit it to [yegor256/0pdd](https://github.com/yegor256/0pdd/issues):

> set -x && set -e && set -o pipefail && cd /tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io && pdd -v -f /tmp/20190813-2447-fl8ovb [1]: bash: warning: setlocale: LC_ALL: cannot change locale (UTF-8) + set -e + set -o pipefail + cd...

Please, copy and paste this stack trace to GitHub:

```
UserError
set -x && set -e && set -o pipefail && cd /tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io && pdd -v -f /tmp/20190813-2447-fl8ovb [1]:
bash: warning: setlocale: LC_ALL: cannot change locale (UTF-8)
+ set -e
+ set -o pipefail
+ cd /tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io
+ pdd -v -f /tmp/20190813-2447-fl8ovb

My version is 0.20.5
Ruby version is 2.6.0 at x86_64-linux
Reading /tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io
53 file(s) found, 84 excluded
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/onboarding-identity.png is a binary file (912381 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/did-model-by-etda.png is a binary file (48936 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/er-public-storage.png is a binary file (24480 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/communication.png is a binary file (190576 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/add-new-identifier.png is a binary file (876159 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/favicon.ico is a binary file (766 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/identity-data.png is a binary file (111326 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/add-new-accessor.png is a binary file (953587 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/architecture.png is a binary file (75925 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/identity-data-diagram.png is a binary file (37704 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/ndid-node.png is a binary file (39431 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/enrolment-model-by-etda.jpg is a binary file (74745 bytes)
/tmp/0pdd20190812-4-914gao/ndidplatform/ndidplatform.github.io/website/static/img/authentication-model-by-etda.png is a binary file (39066 bytes)
Reading website/package-lock.json...
Reading website/core/Footer.js...
Reading website/package.json...
Reading website/static/css/custom.css...
Reading website/static/js/custom.js...
Reading website/README.md...
Reading website/sidebars.json...
Reading website/i18n/en.json...
Reading website/siteConfig.js...
Reading website/pages/en/users.js...
Reading website/pages/en/help.js...
Reading website/pages/en/index.js...
Reading Dockerfile...
Reading .gitignore...
Reading docker-compose.yml...
Reading .circleci/config.yml...
Reading .0pdd.yml...
Reading docs/flow-create-identity.md...
Reading docs/introduction.md...
Reading docs/deprecated-public-storage.md...
Reading docs/usage-mode-2-data-request.md...
Reading docs/examples-data-request-flow.md...
Reading docs/api.md...
Reading docs/examples-authen-flow.md...
Reading docs/api-ndid.md...
Reading docs/flow-data-request.md...
Reading docs/getting-started-idp.md...
Reading docs/deployment.md...
ERROR: docs/deployment.md; puzzle at line #39; @todo must have a leading space to become a puzzle, as this page explains: https://github.com/yegor256/pdd#how-to-format
If you can't understand the cause of this issue or you don't know how to fix it, please submit a GitHub issue, we will try to help you: https://github.com/yegor256/pdd/issues. This tool is still in its beta version and we will appreciate your feedback. Here is where you can find more documentation: https://github.com/yegor256/pdd/blob/master/README.md.
Exit code is 1

/app/objects/git_repo.rb:66:in `rescue in block in xml'
/app/objects/git_repo.rb:63:in `block in xml'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/tempfile.rb:295:in `open'
/app/objects/git_repo.rb:62:in `xml'
/app/objects/puzzles.rb:36:in `deploy'
/app/objects/job.rb:38:in `proceed'
/app/objects/job_starred.rb:33:in `proceed'
/app/objects/job_recorded.rb:32:in `proceed'
/app/objects/job_emailed.rb:35:in `proceed'
/app/objects/job_commiterrors.rb:36:in `proceed'
/app/objects/job_detached.rb:48:in `exclusive'
/app/objects/job_detached.rb:36:in `block in proceed'
/app/objects/job_detached.rb:36:in `fork'
/app/objects/job_detached.rb:36:in `proceed'
/app/0pdd.rb:358:in `block in <top (required)>'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1635:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1635:in `block in compile!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:992:in `block (3 levels) in route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1011:in `route_eval'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:992:in `block (2 levels) in route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1040:in `block in process_route'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1038:in `catch'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1038:in `process_route'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:990:in `block in route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:989:in `each'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:989:in `route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1097:in `block in dispatch!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `block in invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `catch'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1094:in `dispatch!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:924:in `block in call!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `block in invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `catch'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:924:in `call!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:913:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/xss_header.rb:18:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/path_traversal.rb:16:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/json_csrf.rb:26:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/base.rb:50:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/base.rb:50:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/frame_options.rb:31:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/logger.rb:15:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/common_logger.rb:33:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:231:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:224:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/head.rb:12:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/method_override.rb:22:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:194:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1957:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1502:in `block in call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1729:in `synchronize'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1502:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/handler/webrick.rb:86:in `service'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/webrick/httpserver.rb:140:in `service'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/webrick/httpserver.rb:96:in `run'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/webrick/server.rb:307:in `block in start_thread'
```


if statement에 일관성이 필요해보입니다.
예) if( argc > 1 ) -> if(argc > 1) 또는 반대


The processed position at which Draw will be called for this Drawable


oh what the parody


## Build with nsim on ARCJenkins

\nJOBS: 4


// 또는 /* */ 중 하나로 일관성을 맞추는 것이 좋아보입니다.


https://google.github.io/styleguide/cppguide.html#Class_Format
Class Format 지침에 따라 public, protected, private 순서로 멤버를 선언하도록 변경하였으면 합니다.


Опять же, не нужно называть излишне сложно `cargo_volume`, потому что и так понятно, это переменная вагона.
Просто `@volume`


i, don't think these comments are necessary? lmao


Facebook/profile/fabian.rodriguez
1865


Successfully aliased the URL <https://nextjs-kkxrkvyir.now.sh> to the following aliases:

* https://nextjs.aksingh1493.now.sh
* https://nextjs-git-master.aksingh1493.now.sh


input variable(index, price)은 const로 처리하는게 좋을 것 같습니다.


I recommend to use const when we don't change variable to clarify meaning of it
void Goods::SetGoodsInfo(const int index, const int price)


К тому же, переменная типа у тебя названа просто `type`. Запомни, что нужно всегда придерживаться единого стиля. Если так хочется давать длинные названия переменным, тогда это нужно делать для всех. Но лучше называть переменные как можно более кратко и понятно.


Code has been completed changing to manage coding standards....


Successfully aliased the URL <https://gatsby-theme-documentation-apgpqediu.now.sh> to the following aliases:

* https://docs-theme.johno.com
* https://gatsby-theme-documentation.johno1.now.sh
* https://gatsby-theme-documentation-git-master.johno1.now.sh


It doesn't look like the rest of the tutorial actually uses geometry shaders. I had to disable the geometry shaders check so I could continue this tutorial on my 2013 MacBook Pro. Also, I had to allow VK_PHYSICAL_DEVICE_TYPE_INTEGRATED_GPU as well. 😁


Height, not Length (length could be refered for both width and height so it's ambiguous)


https://google.github.io/styleguide/cppguide.html#Variable_Names
변수명 끝에 '_'를 붙여 멤버 변수임을 알 수 있도록 합니다.


header와 마찬가지로 return을 const로 하는 게 좋을 것 같습니다.


Never mind, that's a misleading TS error when the rest of the file is malformed


Facebook-password-link/open /private/profile/open/fabian.rodriguez.,1865


Goods와 { 사이에 whitespace를 넣는 것이 우리 회사 스타일에 맞을 것 같습니다.


This also fixes the UVs on Heroes of the Storm models


typo in commit message: s/offroad/offred/


클래스 이름은 코딩 가이드에 따라 대문자로 변경 부탁드립니다


There are like


index와 price의 자료형에 const를 추가하는 것이 명확해 보입니다.


Get the real screen position from the Drawable position that is relative to the base resolution.


12-13 라인 함수의 return 형에 const를 추가하는 것이 좋을 것 같습니다


멤버 함수 empty, top, size, push, pop 등도 코딩 스타일 가이드에 따라 대문자로 시작하는 Camel 타입으로 변경해주세요.

예) empty -> Empty, top -> Top


#define guard의 형식은 <project>_<path>_<file>_H로 맞춰 주는게 좋을 것 같습니다.
ex) PROJECT2_GOODS_H


flav2626@gmail.com/Facebook profile/open/public/profile/open/


헤더 파일이 경로를 참고하도록 make를 명확히하고, ./는 삭제하는게 낫지 않을까요


This p is not used anywhere. Please check it is used or not. And if it is used, please change variable name based on its meaning


소문자가 아닌 대문자로 시작하는것이 좋겠습니다.


size()는 String에 존재하지 않는 method로 String의 길이를 확인 하고자 하면 size() 대신 length() 를 사용하면 됩니다.
https://docs.oracle.com/javase/7/docs/api/java/lang/String.html#length()


- 모든 파일에 license 관련 내용을 추가했으면 좋겠습니다.
- class type 이름을 구체적으로 이름으로 변경했으면 합니다.


https://google.github.io/styleguide/cppguide.html#Function_Names
각각의 멤버함수는 Pascal Case(대문자로 시작하는 Camel Case)로 작성하도록 합니다.


google java style에 따라 여는 중괄호 '{' 로 줄바꿈을 하지 않는게 좋을 것 같습니다.


same here, not needed


18-26라인의 불필요한 개행문자는 삭제하는게 좋을 것 같습니다.


https://google.github.io/styleguide/cppguide.html#General_Naming_Rules
함수의 의도를 파악할 수 있도록 변경합니다.
Queue를 비우는 것인지 Empty를 확인하는지 용도에 따라 바로 이해할 수 있도록 변경되었으면 합니다.


Used to **store** the ...

(the keystyle is 'determined' by the BeatmapHelper while parsing the file)


Ooops...without this fix the app can lock up after setting a real time effect parameter with a combo box.


Successfully aliased the URL <https://ecovillagelist-oq46e068i.now.sh> to the following aliases:

* https://ecovillagelist.com
* https://ecovillagelist.basilesamel.now.sh
* https://ecovillagelist-git-master.basilesamel.now.sh


class name은 대문자로 시작해 주세요


특별한 이유가 없다면 최상단에 package명이 포함되어야 할 것 같습니다.


Поправил.


필수정 사항은 아니지만 1,2,3 순서로 초기화를 하는게 낫지 않을까요.


private member/method는 public 선언 이후에 선언해주세요


Getter의 경우 멤버 변수를 변경하지 않을 것이므로 명시적으로 const를 붙여주는게 좋을 것 같습니다.
(GetIndex, GetPrice 모두 수정 필요)


class member 변수 끝에 underscore 붙여주세요


-클래스 멤버변수의 초기화는 생성자에서 처리하는 것이 적절할 것 같습니다.
-멤버 변수의 이름에 클래스 이름이 중복되어 있으니 goods_를 빼는 것이 어떻까요


Wildcard 기반의 Import는 선호되지 않는 것으로 알고 있습니다.
특별한 이유가 있다면 설명 부탁드리겠습니다.
혹은 개별 Class를 Import하는 것으로 수정하는 것이 어떨까요?


현재 dir를 나타내는 ./가 불필요해 보입니다.


1. I recommend to make this function const to clarify meaning of it
  int Goods::GetIndex() const {


Class name과 중괄호 사이에는 space가 있는게 가독성에 더 좋을 것 같습니다.


readability를 위해서 tab 대신 space 사용해 주세요.
coding rule에 따라 public 멤버 우선 선언후 private 멤버 선언해 주세요.


是显式吗


templatePriorityQueue 이 변수명은 TemplatePriorityQueue로 변경되는 것이 더 좋을것 같습니다.


I recommend to make this function const to clarify meaning of it
int Goods::GetPrice() const {


Handle the currently queued Inputs that may affect the gameplay


ok


전체 헤더 파일에서
#define guard의 형식은 _H로 맞춰 주는게 좋을 것 같습니다.
ex) PROJECT2_GOODS_H


not needed


还原


j= array.length인 경우 array[j + 1] 참조시 잘못된 address 참조가 일어날 수 있습니다.
array 참조시 max값 확인이 필요해 보입니다.


是自然的空格么

xinxin189876 <notifications@github.com> 于2019年8月12日周一 下午8:59写道：

> 非常开心可以收到您的回复
> 我的数据是中间带有空格
> 这样会有影响吗 对最后的输出
>
>
> ------------------ 原始邮件 ------------------
> 发件人: "Cheng Zhang"<notifications@github.com>;
> 发送时间: 2019年8月12日(星期一) 晚上8:57
> 收件人: "sing1ee/dict_build"<dict_build@noreply.github.com>;
> 抄送: "倾心绝恋"<759600724@qq.com>;"Mention"<mention@noreply.github.com>;
> 主题: Re: [sing1ee/dict_build] 重新编译生成jar文件，修复了words.data和words_sort.data为空问题
> (dd848fc)
>
>
>
>
> @xinxin189876 文件的编码对么？
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/sing1ee/dict_build/commit/dd848fc7de1aeceec91b4a645c8e16f45548fabe?email_source=notifications&email_token=AAICIWWMFVVOPOTKXYJY7EDQEFNBRA5CNFSM4ILALFQKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBBBU65#commitcomment-34657245>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAICIWWYEBALS4YMBMSYTL3QEFNBRANCNFSM4ILALFQA>
> .
>


I recommend to use const when we don't change variable to clarify meaning of it
void SetGoodsInfo(const int index, const int price);


index와 price가 따로 설정되는 경우는 없나요? 만약 그런 경우가 있다면
메소드를 2개로 분리하는게 좋을 것 같습니다.


https://google.github.io/styleguide/cppguide.html#Use_of_const
size 함수 내부에서 내부 상태 변경이 없음을 const 를 사용하여 명시합니다.


Google Style을 기본 가이드로 전제한다면,
여는 괄호는 class명과 동일 라인에 와야 할 것 같습니다.
이는 아래 다른 블록들에도 공통된 코멘트 입니다.


Удалил.


Mengerjakan Back nya saja


iterator의 변수명 p, min, i를 의미를 보여줄 수 있도록 수정하는게 좋을 것 같습니다.


It would be better to use all lower cases for variable name to make consistency


Open되는 중괄호 ("{") 는 K&R style 적용하여 기존 line 마지막에 표시하면 좀더 가독성이 좋아 질수 있다고 생각 됩니다.
 for (int i = 1; i < src.length(); i++) {


是自然有空格，后来发现是空的问题，然后可以跑通了嘿嘿嘿
后来出现内存不足，检测到是linux存储temp文件不够
就是用来排序的函数 所以只能换个内存大的机器了

------------------ 原始邮件 ------------------
发件人: "Cheng Zhang"<notifications@github.com>;
发送时间: 2019年8月13日(星期二) 中午12:58
收件人: "sing1ee/dict_build"<dict_build@noreply.github.com>;
抄送: "倾心绝恋"<759600724@qq.com>;"Mention"<mention@noreply.github.com>;
主题: Re: [sing1ee/dict_build] 重新编译生成jar文件，修复了words.data和words_sort.data为空问题 (dd848fc)

是自然的空格么

 xinxin189876 <notifications@github.com> 于2019年8月12日周一 下午8:59写道：

 > 非常开心可以收到您的回复
 > 我的数据是中间带有空格
 > 这样会有影响吗 对最后的输出
 >
 >
 > ------------------ 原始邮件 ------------------
 > 发件人: "Cheng Zhang"<notifications@github.com>;
 > 发送时间: 2019年8月12日(星期一) 晚上8:57
 > 收件人: "sing1ee/dict_build"<dict_build@noreply.github.com>;
 > 抄送: "倾心绝恋"<759600724@qq.com>;"Mention"<mention@noreply.github.com>;
 > 主题: Re: [sing1ee/dict_build] 重新编译生成jar文件，修复了words.data和words_sort.data为空问题
 > (dd848fc)
 >
 >
 >
 >
 > @xinxin189876 文件的编码对么？
 >
 > —
 > You are receiving this because you were mentioned.
 > Reply to this email directly, view it on GitHub, or mute the thread.
 >
 > —
 > You are receiving this because you commented.
 > Reply to this email directly, view it on GitHub
 > <https://github.com/sing1ee/dict_build/commit/dd848fc7de1aeceec91b4a645c8e16f45548fabe?email_source=notifications&email_token=AAICIWWMFVVOPOTKXYJY7EDQEFNBRA5CNFSM4ILALFQKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBBBU65#commitcomment-34657245>,
 > or mute the thread
 > <https://github.com/notifications/unsubscribe-auth/AAICIWWYEBALS4YMBMSYTL3QEFNBRANCNFSM4ILALFQA>
 > .
 >

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


第二次


Get the JudgementValue above (better than) the provided JudgementValue.


I recommend to make this function const to clarify meaning of it
int GetIndex() const;


const는 불필요하지 않나요?


I recommend to make this function const to clarify meaning of it
int GetPrice() const;


Опять зачем такое длинное название переменной?
Если изменить на просто `manufacturer`, менее понятной она не станет, зато намного короче.


class 이름은 Camel Case로 TemplatePriorityQueue 로 작성하는 것이 좋을 것 같습니다.


ch 변수가 입력의 수로 생각되는데,
조금 더 가독성 높은 변수명 사용이 필요할 것 같습니다.


It would be better to use all lower cases for consistency


#### Atualização completa no arquivo PACMAN master.

- Atualização na função Score (dividida em front e backend);
- Atualização no Mapa;
- Atualização no README.md, relacionado a mudança do mapa;


현재 생성자 및 소멸자가 명시적으로 선언되어 있지 않습니다.
의도적으로 기본 생성자/소멸자를 사용하도록 한 것인가요?
그게 아니라면 명시적으로 생성자/소멸자 선언이 필요해 보이고,
Copyable/Movable 확인 가능하도록 복사 생성자 및 할당연산자(=)에 대한 것도 명시하는게 좋을 것 같습니다.


MiSetting habe ich so übernommen, die Übersetzungen sind nicht von mir.


Remoção de arquivos não utilizáveis!


변수 선언 시 초기화를 병행하는 것이 더 좋을 것 같습니다.


1. 인자가 상수이며 앞으로 여러 번 반복 사용될 수 있다면 상수 변수를 사용하는 것이 좋겠습니다.
2. 인자의 의미를 명확하게 설명하기 위해 주석을 포함하는 것이 좋겠습니다.


test 코드의 body가 없어 실제 이 코드에 어떤 기능이 포함되어 있는지 알수 없습니다.
test code를 추가해주면 코드 파악에도 도움이 되지만, 실제 구현한 코드의 동작을 확인하는데 도움이 될 것 같습니다.


Formatting은 public, protected, private 순서대로 선언하는 것이 좋을 것 같습니다.


push test 와 pop test를 분리해서 어떤 test에서 fail이 발생하는지 쉽게 찾을수 있으면 좋지 않을까요?


return값을 함수 선언과 같은 줄로 만들어 주세요.


Camel Case로 TemplatePriorityQueue 로 작성하는 것이 좋을 것 같습니다.


Simple text editor using _document.execCommand_


Camel Case로 ~TemplatePriorityQueue 로 작성하는 것이 좋을 것 같습니다.


변수명을 flag가 아닌 용도를 나타내는 변수명이명이면 좋을 것 같습니다. (ex. needToSort)


함수 내의 iterator 변수 명 p, min, i, j 등을 내용을 알 수 있도록 명확히 하면 더 좋겠습니다.


这个怎么通过审核？


Project 2의 Class 선언부에서
Class name과 중괄호 사이에는 space가 있는게 가독성에 더 좋을 것 같습니다.


Project 2의 각 Class에서
현재 생성자 및 소멸자가 명시적으로 선언되어 있지 않습니다.
의도적으로 기본 생성자/소멸자를 사용하도록 한 것인가요?
그게 아니라면 명시적으로 생성자/소멸자 선언이 필요해 보이고,
Copyable/Movable 확인 가능하도록 복사 생성자 및 할당연산자(=)에 대한 것도 명시하는게 좋을 것 같습니다.


Совершенно неправильно. Глобальные переменные – не решение всех проблем. Во-первых, сначала подумай, чем отличаются глобальные переменные от переменных класса?
Во-вторых, на заметку – мы можем задавать геттеры и сеттеры и для переменных класса. Для этого достаточно объявить например геттер в секции `class << self`.
А в данном случае мы можем сделать просто:
```
module InstanceCounter
  module ClassMethods
    attr_accessor :instances
  end
end
```
Это будет значить, что мы сможем на КЛАССЕ вызывать этот метод, чтобы получить и задать значение переменной. Но эту переменную все же надо сначала инициализировать. Это можно сделать как раз в методе `register_instance`.
```
module InstanceMethods
  def register_instance
    self.class.instances ||= 0 # инициализируем переменную когда она еще не определена
    self.class.instances += 1 # увеличиваем счетчик во все следующие разы
  end
end
```


코멘트 이기는 하지만, test.GetPrice --> test.GetPrice()로 수정하면 좋을 것 같습니다.
endl 혹은


회사의 styling 규칙 상 현재 폴더의 선언을 제일 위로 올리는 것이 좋을 것 같습니다. "./"도 삭제하는게 좋을 것 같습니다.


Indent가 Space 8칸으로 되어 있습니다. Code Style 문서상 Space 2칸으로 되어 있어서 수정 부탁 드립니다.
(문서 전체, 참고: https://google.github.io/styleguide/cppguide.html#Spaces_vs._Tabs)


뒤쪽 const 뒤에 공백 추가해 주세요.

const int& templatePriorityQueue<int>::top() const {


Просто `all`


Successfully aliased the URL <https://crm-lite-f6mhir7fk.now.sh> to the following aliases:

* https://crm-lite.aguerrerodev.now.sh
* https://crm-lite-git-master.aguerrerodev.now.sh


rf_46 plot #1


들여쓰기는 스페이스 2칸으로 요청드립니다.


만약 여는 괄호를 do와 동일한 라인에 두지 않는 스타일로 간다고 하더라도, Indentation 조정이 필요할 것 같습니다.


Shopping과 { 사이에 whitespace 넣어주는게 좋을 것 같습니다.


public, protected, private 키워드는 Space 한 칸 만큼 들여쓰기를 하면 좋을 것 같습니다.


코드 가독성 측면에서 개별 라인 출력을 별도의 println 함수로 처리하는 것이 어떨지요?


getter/setter에 대한 test case는 필요 없겠지만, class의 설명에 sample code를 작성하기 보다는 test code에 작성하는게 어떨가요?
로직이 변경된 상황에도 test code에서 검증이 되는게 좋을것 같습니다.


기존과 동일합니다.
src.size() 를 src.length()로 변경 필요합니다.


1라인이면 충분해 보입니다.


templatePriorityQueue는 std::priority_queue의 wrapper격 class로 보이는데요~
외부에서 std::priority_qeue를 직접 사용하지 않고 templatePriorityQueue를 한꺼풀 씌워서 하는 이유가 있는지 문의 드립니다.


선언 다음에 빈줄로 구분하는 것이 가독성이 좋을 것 같습니다.


get 이기떄문에 const로 고려하는 것을 권장합니다.
 int size() const;


Thanks for fixing this :tada:


Exception 예외처리 필요할 것 같습니다.
특히 NumberFormatException 필수로 생각됩니다.


1) Class Type 이기 때문에 이름이 대문자로 시작 해야 할듯 하고.
	 * template 임을 따로 명명에 넣는것보다는 하는 것은 ProrityQueue 형태의 이름이 괜찮을것 같습니다.


Project 2의 각 파일에서 header file include 시 "./"를 이용하여
현재 폴더에서 탐색하도록 되어 있으나,
추후 확장과 호환을 위해 제거하는게 좋을 것 같습니다.
헤더와 소스 코드가 다른 폴더로 분리되거나,
다른 path separator를 사용하는 경우(ex> Windows의 경우 \ 사용) 문제가 될 수 있을 것 같습니다.


I recommend following rule
 header file related with current file
 blank
 C system library header file
 C++ system library header file

So, I recommend to change as following
#include "./shopping.h"

#include <iostream>


empty일 때 size가 0인지 확인하는 TC가 필요하지 않을까요..?


const가 필요할까요?


Class 내의 멤버 선언 순서가 public -> protected -> private으로 되는게 좋겠습니다.


Откуда взялось `station_name`?
Запомните – если вы что-то присваиваете переменной, вы должны знать, что именно вы присваиваете и откуда этот объект берется. Здесь вы забыли добавить аргумент к методу `initialize`. Но такое вы уже забывать просто не должны, это должно к вам автоматически приходить.


delete


example


현재 dir를 나타내는 ./가 불필요해 보입니다.


Getter의 역할이 명확하여 주석이 불필요할 것 같습니다.


가독성 향상을 위해 if 구문내 한줄만 있고 else가 없다면 괄호를 없애는 것이 좋겠습니다.


https://google.github.io/styleguide/cppguide.html#Use_of_const
  int GetIndex() / int GetPrice();함수 내부에서 내부 상태 변경이 없음을 const 를 사용하여 했으면 합니다.


위 6개의 데이터 뿐만 아니라 랜덤하게 데이터를 넣고 이 중 MAX에 대해 top으로 확인하는 등의 TC가 필요하지 않을까 제안해봅니다.


java doc 에 param에 대한 정보가 누락되었습니다.


shopping_list_ 가 비어있는 경우에 대한 예외 경우를 고려하면 좋겠습니다.


🔥 Device tests completed (Failed) on iOS on [Azure DevOps](https://dev.azure.com/devdiv/DevDiv/_build/index?buildId=2936795)(iOS): [Html Report](http://xamarin-storage/jenkins/xamarin-macios/alex-monobump-master/bd6eaf7534c5e9bcfe6030d1b3ce8bf8d037f5ea/2936795/device-tests/jenkins-results/tests/index.html) 🔥

# Test results

<details>
<summary>110 tests failed, 3 tests passed.</summary>

## Failed tests

 * monotouch-test/iOS Unified 64-bits - device/Debug: Crashed
 * framework-test/iOS Unified 64-bits - device/Debug: Crashed
 * interdependent-binding-projects/iOS Unified 64-bits - device/Debug: Crashed
 * fsharp/iOS Unified 64-bits - device/Debug: Crashed
 * dont link/iOS Unified 64-bits - device/Debug: Crashed
 * link all/iOS Unified 64-bits - device/Debug: Crashed
 * link sdk/iOS Unified 64-bits - device/Debug: Crashed
 * mono-native-compat/iOS Unified 64-bits - device/Debug: Crashed
 * mono-native-unified/iOS Unified 64-bits - device/Debug: Crashed
 * [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - device/Debug: Crashed
 * [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/Debug: Crashed
 * [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - device/Debug: Crashed
 * [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - device/Debug: Crashed
 * mscorlib/iOS Unified 64-bits - device/Debug: Crashed
 * [xUnit] Mono BCL tests group 6/iOS Unified 64-bits - device/Debug: Crashed
 * monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): TimedOut
 * monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * monotouch-test/iOS Unified 64-bits - device/Release: Crashed
 * monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * monotouch-test/iOS Unified 64-bits - device/Debug (dynamic registrar): Crashed
 * monotouch-test/iOS Unified 64-bits - device/Release (all optimizations): Crashed
 * monotouch-test/iOS Unified 64-bits - device/Debug (all optimizations): TimedOut
 * monotouch-test/iOS Unified 64-bits - device/Debug: SGenConc: Crashed
 * monotouch-test/iOS Unified 64-bits - device/Debug (interpreter): TimedOut
 * monotouch-test/iOS Unified 64-bits - device/Debug (interpreter -mscorlib): Crashed
 * monotouch-test/iOS Unified 64-bits - device/Release (interpreter -mscorlib): Crashed
 * framework-test/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * framework-test/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * framework-test/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * framework-test/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * framework-test/iOS Unified 64-bits - device/Release: Crashed
 * framework-test/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * interdependent-binding-projects/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * interdependent-binding-projects/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * interdependent-binding-projects/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * interdependent-binding-projects/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * interdependent-binding-projects/iOS Unified 64-bits - device/Release: Crashed
 * interdependent-binding-projects/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * fsharp/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * fsharp/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * fsharp/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * fsharp/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * fsharp/iOS Unified 64-bits - device/Release: Crashed
 * fsharp/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * dont link/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * dont link/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * dont link/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * dont link/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * dont link/iOS Unified 64-bits - device/Release: Crashed
 * dont link/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * link all/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * link all/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * link all/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * link all/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * link all/iOS Unified 64-bits - device/Release: Crashed
 * link all/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * link sdk/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * link sdk/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * link sdk/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * link sdk/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * link sdk/iOS Unified 64-bits - device/Release: Crashed
 * link sdk/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * mono-native-compat/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * mono-native-compat/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * mono-native-compat/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * mono-native-compat/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * mono-native-compat/iOS Unified 64-bits - device/Release: Crashed
 * mono-native-compat/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * mono-native-unified/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * mono-native-unified/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * mono-native-unified/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * mono-native-unified/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * mono-native-unified/iOS Unified 64-bits - device/Release: Crashed
 * mono-native-unified/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - device/Release: Crashed
 * [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/Release: Crashed
 * [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - device/Release: Crashed
 * [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Failed
 * [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - device/Release: Crashed
 * [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * mscorlib/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Failed
 * mscorlib/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): TimedOut
 * mscorlib/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * mscorlib/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Failed
 * mscorlib/iOS Unified 64-bits - device/Release: Crashed
 * mscorlib/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Failed
 * mscorlib/iOS Unified 64-bits - device/Debug: SGenConc: Crashed
 * [xUnit] Mono BCL tests group 6/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * [xUnit] Mono BCL tests group 6/iOS Unified 64-bits - device/Release: Crashed
 * [xUnit] Mono BCL tests group 6/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
</details>


void가 아닌 int& 로 return value가 필요하지 않을까요?


Класс принимает аргументы, или все-таки метод `initialize`?
Я понимаю, вы путаетесь, но такие простые вещи вы уже просто обязаны помнить.
Тем более, если бы вы проверили код (запустили в консоли и попробовали создать объекты классов) вы бы сразу увидели синтаксическую ошибку.


I recommend to make this function const to clarify meaning of it
Goods Shopping::GetLastElement() const {


Без `puts`


w


index 와 price에서 유효한 값의 범위는 없을가요??
예를 들어 index가 음수값이 되어도 문제 없는건가요?? 문제가 된다면 test case에서 확인이 되면 좋겠습니다.


Successfully aliased the URL <https://mishwong-e9ue7u9nq.now.sh> to the following aliases:

* https://mishwong.com
* https://www.mishwong.com
* https://mishwong.johnkueh.now.sh
* https://mishwong-git-master.johnkueh.now.sh


Test되는 대상이 PriorityQueue이므로 해당 대상이 명확하게 드러나도록 exp_priority_queue로 변경하는 것이 어떨까요?
Coding style상 중간에 대문자가 들어가는 것보다는 _로 구분되도록 변경해주세요~
-----------------------------------------------------------
변수 이름은 전부 소문자로 작성하며 단어 사이에 “_”를 붙일 수 있습니다.


Еще раз пересмотреть скринкаст и перечитать доп. материалы. + почитать о методах и аргументах


"node-side rebroadcast", to avoid conflating wallet-triggered and node-triggered rebroadcast


hlo chowdary


변수들은 space 두 칸 들여쓰기를 하면 좋을 것 같습니다.


comment로 작성한 예시 코드에 문제가 있어 보이며 수정하는게 좋을 것 같습니다.
- std namespace는 cout과 endl에서 모두 사용하거나 모두 사용하지 않도록 수정이 필요합니다.
- GetPrice 호출 시 괄호가 빠져 있습니다.


 pop하고 top으로 값을 확인하는 TC가 있어야 아래와 같은 오류를 확인할 수 있어 보입니다.
정상: 8, 5, 4, 3, 2, 1
오류: 8, 4, 5, 3, 2, 1


index가 같은 경우 또는 price가 같은 경우처럼 예외 test case가 더 추가되었으면 합니다.


"templatePriorityQueue<int>::top() const{"
에서 const가 왜 필요할지 설명을 부탁드립니다.


header에서는 <typename T>로 template을 적용하고 있지만, 구현체에는 <int>로 한정하여 적용되고 있습니다.


n 변수명 보다 가독성 있게 수정되면 좋겠습니다.


getter와 setter는 하는 일이 명확하니 java doc을 삭제 하는게 좋을것 같습니다.
java doc을 쓴다면, format에 따라 @return 을 추가하는게 필요합니다.


Successfully aliased the URL <https://advanced-react-course-with-platzi-lagtnkcmw.now.sh> to the following aliases:

* https://advanced-react-course-with-platzi.beto23.now.sh
* https://advanced-react-course-with-platzi-git-master.beto23.now.sh


Perhaps adding a linebreak after every variable would improve readability.


parseInt 사용에 따라 NumberFormatException 예외처리 필요할 것으로 생각됩니다.


templatePriorityQueue 이 변수명은 TemplatePriorityQueue로 변경되는 것이 더 좋을것 같습니다.


已经修改了


a 변수명 보다 가독성 있게 수정되면 좋겠습니다.


Fix_7136_PeakCoil (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-IntegrationCoverage-Debug: OK (666 of 667 tests passed, 0 test warnings)

Failures:\n

integration Test Summary
 * Passed: 666
 * Timeout: 1

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.85%25-yellow.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-68.44%25-green.png)


변수 이름은 priority queue라는 것이 드러나면 좋겠습니다.
priority_queue_는 어떨까요?
class의 멤버 변수이므로 맨 마지막에 _추가해주세요~
---------------------------------------------------------------------
class의 member 변수는 이름 끝에 추가로 “_”를 붙입니다.


Successfully aliased the URL <https://mishwong-81iqpbu6v.now.sh> to the following aliases:

* https://mishwong.com
* https://www.mishwong.com
* https://mishwong.johnkueh.now.sh
* https://mishwong-git-master.johnkueh.now.sh


template class 구현도 header에서 함께 해주세요


size() 멤버변수도 const 제한자를 같이 주는게 맞는거 같습니다.


PR_opened/Fix_7151_GeneratorPVAvailSched (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.4: OK (2482 of 2489 tests passed, 8 test warnings)

Messages:\n
 * 8 tests had: EIO diffs.
 * 1 test had: ESO small diffs.
 * 2 tests had: BND diffs.
 * 7 tests had: ERR diffs.
 * 3 tests had: AUD diffs.
 * 7 tests had: ESO big diffs.
 * 5 tests had: MTR big diffs.
 * 3 tests had: RDD diffs.
 * 7 tests had: Table big diffs.
 * 1 test had: MTD diffs.
 * 2 tests had: MTR small diffs.

Failures:\n

regression Test Summary
 * Passed: 675
 * Failed: 7

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.png)


c++ System library(vector) include 이후에는 한 줄 비우고
현재 Project의 헤더 파일(goods.h)을 include하는게 가독성에 좋을 것 같습니다.


const 제한자 필요 할것 같습니다.


)와 { 사이에 space 추가해주세요


Hi . musamarcusso
I know that the noise in the Gauss Markov Process is Gaussian white noise.
Is there a reason to use uniform distribution?? Or am I wrong?


I recommend to combine two lines together because merged line is under 80 characters


개행문자 추가하시는게 좋을 것 같습니다.


Perhaps use multiple lines for longer descriptions like these.


<distributionManagement>
<repository> <id>releases</id> <name>Releases</name> <url>http://18.224.72.141:8081/nexus/content/repositories/releases</url> </repository>
<snapshotRepository> <id>snapshots</id> <name>Snapshots</name> <url>http://18.224.72.141:8081/nexus/content/repositories/snapshots</url> </snapshotRepository>
</distributionManagement>


함수 시작시 )와 { 사이에 space 추가해주세요


PR_opened/Fix_7151_GeneratorPVAvailSched (jmarrec) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (9 of 9 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


코드 내 모든 Indent가 Tab입니다. Whitespace로 변경 고려 부탁드립니다.


<server> <id>releases</id> <username>admin</username> <password>admin123</password> </server>
<server> <id>snapshots</id> <username>admin</username> <password>admin123</password> </server>


thereIsNoMoreWordToCompress 는 함수 내부에서 사용이 되지 않는 variable입니다. 의도한게 아니면 삭제하는것이 가독성이 높아질 수 있을것 같습니다.


T 가 복합형태로 구성된 경우 push, pop 시 T 내부 데이터를 어떻게 관리할지 고려되어야 합니다.
- T, T*, T& 혹은 deep copy, swallow copy 등


현재  templatePriorityQueue 해당 Class는 현재 priority_queue를 연결해주는 기능만을 담당하고.
별도로 제공하는 method도 priority_queue 에서 제공하는 method만 연결하고 있습니다.
추가적으로 필요한 정보 및 기능이 없다면 해당 Class는 없이 코드를 작성하는게 맞아 보입니다.


Goods instance가 복사되어 넘어가고 있습니다.
const reference가 더 좋지 않을까요?


Switch 문 닫기 전, default case에 대한 처리가 추가되어야 할 것 같습니다.


변수 이름은 coding style에 따라 소문자로 작성해주세요~
Que는 queue와 읽을 때는 동일하나 queue로 쓰는 것이 다른 사람들이 큐로 인식하기에도 좋을 것 같습니다.


I recommend to make separate goods print function and call it here for clear functionality and readability.


@OpportunityLiu 因为变动太大，popup.ts文件你上次的提交被我覆盖了


public, private 키워드는 space 1개로 indentation하고 나머지 definition 부는 space2개로 indentation 하면 보기 좋을것같습니다.


SetGoodsInfo 의 사용처를 보니, 중간에 값이 변경되는것도 아니므로 생성자에서 처리해도 충분할것 같습니다.
나중을 위해 method를 사용하기보다는 현재에 불필요해 보이는 method를 삭제 하고 추후 요구사항이 생기면 그때 다시 만드는것을 제안드립니다.


Also I think that using regular comment `// comment` is fine for variables. Summary is more fitting for classes and methods.


member 변수명은 underscore로 끝나는 소문자 이름으로 정해주시면 구분하기 좋을것같습니다.


ZEIT Now cannot deploy this project to production due to following domain related issues:

 * `tmdb.idiot.design`(for alias `tmdb.idiot.design`) is not found inside your account. [Add it](https://zeit.co/dashboard/domains?action=add&domain=tmdb.idiot.design).


I recommend to make this function const to clarify meaning of it
void Shopping::PrintList() const {


A few things combined:
- lives_get_current_dir() should always free the return value.
- adds a checkbutton to enable selection of apply / dont apply effects when transcoding.
- if the button is checked we also apply audio effects (needs testing)
- adds a new "filewrite" layout element in RFX
-  - prompt the user whenever possible when an existing file is selected for an element of this type
- all plugins making use of RFX can now have trigger code, either on init or when a parameter is altered, not just rendered effects
- address a kludge which was added to force "threaded" dialogs to show Enough rather than Cancel. It can now be done simply by setting mainw->cancel_type to CANCEL_SOFT before creating the dialog. The value must always be reset back to the default CANCEL_KILL after calling do_threaded_dialog()
- pass relative time of the frame / audio rather than absolute time when transcoding


using namespace 지시자를 사용하지 않을것을 권유 드립니다


여기서 min = i를 선언하면, Line 31~34과 Line 40을 삭제할 수 있습니다.


input 인자인 Goods를 const로 선언하는게 좋을 것 같습니다. 확인 해주세요.
마찬가지로, GetLastElement() 함수 return 시와 vector<Goods> 자료형도 이에 맞추어 수정하는게 좋을 것 같습니다.
그리고, 이에 따라 cc파일도 수정해주세요.


需要怎么做才能合并呢？


PR_opened/Fix_7151_GeneratorPVAvailSched (jmarrec) - x86_64-Linux-Ubuntu-18.04-cppcheck: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


class 이름은 대문자로 시작하는 camel style로 지어주시면 보기좋을것같습니다.


Test data에서 최상위 값은 5이므로 아래와 같이 수정 필요합니다.
ASSERT_EQ(expTarget.top(),5);  // The highest pushed value is 5


template metaprogramming을 사용하지 않기를 권유 드립니다.


https://github.com/salsaman/LiVES/commit/27e3a6a6ecfb32b91ec634f06ce5240d781ab221

is related.


네. 수정하여 다시 commit하겠습니다.


const가 필요하지 않을까요?


네. 참고 링크대로 수정하여 다시 commit하겠습니다.


Test data에서 최상위 값은 2이므로 아래와 같이 수정 필요합니다.
ASSERT_EQ(expTarget.top(),2); // The highest pushed value is 2


BinarySort, SelectionSort, InsertionSort의 경우에는 해당 메소드 내에서 print(a,n) 메소드를 호출하는 반면,
InsertionSort, QuickSort의 경우 main의 switch문 내에 위치합니다.
일관성을 위해 공통된 방식으로 적용 필요할 것 같습니다.


#ifndef PRIORITY_QUEUE_H_
#define PRIORITY_QUEUE_H_


Class name은 대문자로 시작해 주세요.
참조: https://google.github.io/styleguide/cppguide.html#Type_Names


아래 "Test 0 - Last element test" 의 return 값이 element가 없는 경우에 대한 테스트가 추가 되면 좋을 것 같습니다.
하여, shopping_object.PuschList(xxx) 수행 전에 TC를 추가하길 제안 드립니다.


이 위에 min = i를 선언하면, Line 52~55와 Line 61을 삭제할 수 있습니다.
for (std::vector::iterator j = i; ~~ ) 역시 j=i+1 로 수정하여 계산을 줄일 수 있습니다.


추가로, pop을 다 하지 않고 push했을 때에도 top의 값이 정상인지 확인하는 TC도 필요해 보이긴 하네요~


사용하지 않는 코드는 삭제 하는게 좋을 것 같습니다.
이후 디버깅시 필요하다면, 주석 처리가 아니라 debug flag로 enable/disable처리 할 수 있도록 하면 어떨까요?

if(DEBUG) System.out.println("flag=" + flag);


Fix_7396_QtIFW_Windows (jmarrec) - Win64-Windows-10-VisualStudio-16: OK (2446 of 2452 tests passed, 2 test warnings)

Messages:\n
 * 7 tests had: EIO diffs.
 * 1 test had: ESO small diffs.
 * 1 test had: BND diffs.
 * 3 tests had: AUD diffs.
 * 6 tests had: ESO big diffs.
 * 4 tests had: MTR big diffs.
 * 3 tests had: RDD diffs.
 * 6 tests had: Table big diffs.
 * 2 tests had: MTR small diffs.

Failures:\n

regression Test Summary
 * Passed: 656
 * Failed: 6

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.76%25-yellow.png)


Goods instance가 새로 생성되어 return됩니다.
reference로 return해주는 게 성능이나 비용 상 더 좋지 않을까요?
일반적으로 STL에 있는 자료구조의 getter의 경우 아래와 같이 메소드 오버로딩하여
reference와 const reference 2가지 버전을 제공합니다.
ex> std::vector의 front() 메소드
reference front();
const_reference front() const;


Successfully aliased the URL <https://sindre-is-gvlnidqgp.now.sh> to the following aliases:

* https://sindre.is
* https://sindre-is.boyum.now.sh
* https://sindre-is-git-master.boyum.now.sh


![](https://github.trello.services/images/mini-trello-icon.png) [Refreshing the edit job page causes an error.](https://trello.com/c/oAyG48aK/64-refreshing-the-edit-job-page-causes-an-error)


rescan too? need to be checked not sure


do while 에서 while 부분은 중괄호와 같은 라인에 두는 것이 가독성이 더 좋을 것 같습니다.


Header Guard를 추가해 주세요.
참조: https://google.github.io/styleguide/cppguide.html#The__define_Guard


addCharCounter(StringBuilder builder, int count) method를 하나 생성 해서 대체한다면 addChar와 동일 하게 가독성이 좀더 나아질수 있을것 같습니다.


Google style 가이드에 따라
class 내 멤버 메소드 사이에는 blank line을 두는 것이 가독성에 더 좋을 것 같습니다.


공란 제거 부탁드립니다


const 함수로 만드는 것도 좋을 것 같습니다.
int size() const;


type은 대문자로 시작해야 합니다.


Class 이름은 대문자로 시작하는게 좋아보입니다.
https://google.github.io/styleguide/cppguide.html#Type_Names


사용되지 않는 코드는 주석으로 남기지 말고 제거 요청드립니다


shopping.h가 include 순서 상 가장 먼저 오는게 좋을 것 같습니다.


현재 TEST 1개에서 여러가지 TEST를 수행하고 있습니다.
  - push
  - size
  - top
  - empty

각각에 맞는 TEST 작석하는게 맞을것 같습니다.


함수 이름은 대문자로 시작해 주세요

* 참고 : Google Style Guide.pptx / 5page


Submit을 위한 Code에서는 Debugging용 코드는 삭제하는 것이 좋을 것 같습니다.
63번 라인의 Comment도 동일합니다.


"/" 누락으로 comment가 종료되지 않아 이 줄 아래의 코드가 block 처리 됩니다.
의도된 동작인지요?


헤더 파일에서는 class에 대한 설명과 사용예시를 표기하는 것이 좋을 것 같습니다.


I recommend to comment properties of this function by using selection sort as follows
 - best / average / worst O(N^2) time, so when N is big it will be slow
 - swap operation is O(N) time, so if swap operation cost is low and cpu is fast, this function works fast


현재 생성되어 있는 addChar method와 동일 기능을 하므로 대체를 하는것이 좋을것 같습니다.

addChar(stringBuilder, src.charAt(index));


@sandy081 ah yeah, you are right. How about moving it into `src/vs/workbench/services/files` then?


의미없는 주석이라면 지우는게 좋아보입니다.


I'm sorry bro, I forgot to tag me :(

Pada tanggal Sel, 13 Agt 2019 11.02, Keternal <notifications@github.com>
menulis:

> OK, right, I know this is my commit, welcome pick and use, but next time
> pls pick it with my git commit signature, OK? Thank u xd.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/fiqri15072019/android_kernel_xiaomi_vince-4.9/commit/663fa3f9a2d77b6a797559d9f75ac4e2767e6d49?email_source=notifications&email_token=AMTXODAUZJ5TFTUAWGPH2G3QEIW6ZA5CNFSM4ILG4IWKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBBB6KK#commitcomment-34666826>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AMTXODACGS2ZH2SCPS7M5C3QEIW6ZANCNFSM4ILG4IWA>
> .
>


Successfully aliased the URL <https://static-build-example-react-9oh3154pw.now.sh> to the following aliases:

* https://static-build-example-react.moviedb.now.sh
* https://static-build-example-react-git-master.moviedb.now.sh


We may have two choices. To minimize memory foot print, use one Goods variable and push it into shoppingList one by one each or locate PushList under each goods variable for better readability.


I recommend to combine two lines together because merged line is under 80 characters


std::priority_queue<T> 의 size 반환값이 int형이 맞나요~?
보통 size는 unsigned로 되어 있는 것 같은데, 한번 확인을 해볼 필요가 있어 보입니다.


"{" 전에 한칸을 띄는 것이 좋을 것 같습니다.


Successfully aliased the URL <https://avroralepnina-87p5vbbxc.now.sh> to the following aliases:

* https://avroralepnina.ru
* https://avroralepnina.prakula.now.sh
* https://avroralepnina-git-master.prakula.now.sh


Argument명들(a,n)을 가독성 있게 바꾸는 게 더 좋을 것 같습니다.


Yes, I allow you :)

Pada tanggal Sel, 13 Agt 2019 10.49, tytydraco <notifications@github.com>
menulis:

> I think you may have forgotten to author me here on accident. Do you mind
> authoring me? Thank you :D
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/fiqri15072019/android_kernel_xiaomi_vince-4.9/commit/aa2d9a510decc645e496bdf26e5f7027fc89ad68?email_source=notifications&email_token=AMTXODGPINA3MMBEMUYOUCDQEIVMNA5CNFSM4ILG2U52YY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBBB6H5#commitcomment-34666749>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AMTXODBT7P6F4RN66UNIGQDQEIVMNANCNFSM4ILG2U5Q>
> .
>


Test1 , Test2 ... comment 처리보다는 의미를 전달할 수 있는 함수로 빼는게 어떨까요?


Header 파일명과 Class명은 일치하는 것이 좋습니다.
Class name도 그냥 PriorityQueue로 해도 될 것 같습니다.


의미없는 테스트코드 주석이라면 지워버리는게 나아보입니다.


사용되지 않는 iterator 인듯 합니다.


들여쓰기를 std::cout << 뒤쪽으로 맞추는게 가독성에 더 좋을 것 같습니다.


각 함수에 대한 Document를 추가해 주세요.


Indent가 Tab으로 되어 있습니다. Code Style 문서상 Space 2칸으로 되어 있어서 수정 부탁 드립니다.
(코드 내 전체확인 부탁드립니다.)
참고: https://google.github.io/styleguide/cppguide.html#Spaces_vs._Tabs 참고하세요.


@param 에 대한 설명이 누락되었습니다


범위기반 for문으로 사용하면 좀더 가독성이 편하지 않을까요?
ex) for (std::vector<Goods>::iterator i : shopping_list_)
참조 : https://blockdmask.tistory.com/319


Given that `GetRebroadcastTransaction` is called by `SendMessages` which is running in `ThreadMessageHandler` that should be ok, no need to lock I would say


push/pop에 대한 return value는 필요 없을까요? 실패에 대한 return이 어떤 식으로 알 수 있나요?


I recommend to remove variable p because it is not used


public member가 먼저 오고 private member가 오도록 순서를 바꾸는것이 좋을것 같습니다.


Could you document the 3/4 value which seems like a magic number


Goods 클래스에 PrintGoods()와 같이 출력용 함수를 정의하고 여기에서는 i->PrintGoods()를 호출하도록 단순화하는 것이 좋을 거 같습니다. 현재 구현에서는 Goods 클래스의 멤버변수가 바뀔 때마다 PrintList() 함수를 수정해줘야 합니다.


Shopping::SortByPrice() 와 내용이 중복되고 있어, Performance 등을 고려하여 함수화 하는 방법도 검토하시면 좋을듯 합니다.


@NonNull 또는 array가 null 일 경우를 대비해서 exception handling이 필요해 보입니다.


I recommend to change i/j variable to more meaningful ones.


함수는 대문자로 시작해야 합니다.


제가 c++는 익숙하지가 않아서요, 적용하도록할게요


Is this return type correct?
in priority_queue.h, the type is "const T&" and it seems to make more sense.
   // const T& top() const;


동일한 sort algorithm이 중복으로 코드가 작성되어 있습니다.
기준을 Price로 할 지 Index로 할 지만 다르기 때문에 공통부를 다른 함수나 메소드로 빼는게 좋을 것 같습니다.


단일 Statement이더라도 중괄호를 사용하는 것이 더 권장될 것 같습니다.
아래 유사한 구문들에 공통으로 적용됩니다.


이 경우 shopping_list_vector 의 이름이 변경된다면 주석도 변경해야 하니 주석에 shopping_list_vector 를 기술할 필요는 없어 보입니다.
대신 push Goods object to list 정도면 충분할 것 같습니다. 만약 list대신에 다른 type을 써야 하는경우가 있다면 다른 이름을 고려하는게 좋겠습니다.

참고로 위의 shopping_list_ vector << 에서 vector앞에 space가 포함되었습니다.


addCharCounter(StringBuilder builder, int count) method를 하나 생성 해서 대체한다면 addChar와 동일 하게 가독성이 좀더 나아질수 있을것 같습니다.