[](url)


images/a.jpg


@shanecs the diffs are perfect. I’ll go back and change the instructions to say to fork - thanks for letting me know


Did we add it to the environment yaml files (so Travis will install it)?


7423-CeilingDiffuserConvectionRegimeTransition (RKStrand) - x86_64-Linux-Ubuntu-18.04-gcc-7.4: OK (2497 of 2498 tests passed, 0 test warnings)

Messages:\n
 * 1 test had: EIO diffs.
 * 1 test had: ERR diffs.
 * 1 test had: ESO big diffs.
 * 1 test had: MTR big diffs.
 * 1 test had: SSZ big diffs.
 * 1 test had: ZSZ big diffs.
 * 1 test had: Table big diffs.

Failures:\n

regression Test Summary
 * Passed: 682
 * Failed: 1

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.96%25-yellow.png)


Successfully aliased the URL <https://robert-portfolio-1ycmzl1ln.now.sh> to the following aliases:

* https://robert-portfolio.olivernordlund.now.sh
* https://robert-portfolio-git-master.olivernordlund.now.sh


@mwittgen Can you explain this change again. This is causing all of our release builds to show up as dirty. Its not clear to me why this is required as cmake should be initiated from within the tree.


Successfully aliased the URL <https://photocontest-bo9z1l7ds.now.sh> to the following aliases:

* https://uragan-fotosoutez.now.sh
* https://photocontest.matejkriz.now.sh
* https://photocontest-git-master.matejkriz.now.sh


Successfully aliased the URL <https://blog-a4nog4zw1.now.sh> to the following aliases:

* https://blog.snesjhon.now.sh
* https://blog-git-master.snesjhon.now.sh


Very well, that is good enough for me. I consider opening a pull request tomorrow for your suggested change (unless you feel like doing it yourself), but I also presume that it will need to be validated by the MS Docs staff before being added to the source.


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


7423-CeilingDiffuserConvectionRegimeTransition (RKStrand) - x86_64-Linux-Ubuntu-18.04-cppcheck: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


OK, thanks for all your help

jim


7423-CeilingDiffuserConvectionRegimeTransition (RKStrand) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (9 of 9 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


fwiw, can you make this non-optional.  it woudl be helpful to see what callers pass in null, and if that's ok.


Successfully aliased the URL <https://notes-muf5nypma.now.sh> to the following aliases:

* https://theorem.space
* https://notes.n6g7.now.sh
* https://notes-git-master.n6g7.now.sh


I think the only people to check it with, if possible, are the Intune people. This is how it actually works, but whether it is meant to work like this only they will know. If they don't respond, then go with it, because it IS how it actually works.


Please replace "German" with "Deutsche".


The following doc(s) have been deployed to the [configurer](https://configurer-static-docs.pantheonsite.io/docs) Multidev environment:
- [source/partials/_redirects.md](https://github.com/pantheon-systems/documentation/commit/76cf51ce5afaa87ccef2d2857545e5f94118c676/source/partials/_redirects.md)


Ask


Successfully aliased the URL <https://ecommerce-project-5mzp4bvmr.now.sh> to the following aliases:

* https://ecommerce-project.tivler.now.sh
* https://ecommerce-project-git-master.tivler.now.sh


Also "Japanese" -> "日本語".


Successfully aliased the URL <https://trello-clone-l5ua08vzd.now.sh> to the following aliases:

* https://trello-clone.richifg.now.sh
* https://trello-clone-git-master.richifg.now.sh


Successfully aliased the URL <https://landingpagereact-40yqxanpf.now.sh> to the following aliases:

* https://landingpagereact.danekehu.now.sh
* https://landingpagereact-git-master.danekehu.now.sh


Ok. I figured it out. It needs to be:

COMMAND ${GIT_EXECUTABLE} --git-dir=${CMAKE_SOURCE_DIR}/.git  --work-tree=${CMAKE_SOURCE_DIR} describe --tags --dirty


wen enable


TeamCity Bvcms / Build [Build 1646](https://builds.tpsdb.com/viewLog.html?buildId=7588&buildTypeId=Bvcms_Build) outcome was **SUCCESS**
Summary: Tests passed: 49 Build time: 00:17:39


@johndoubleday1

this comment


fix-kiva-init (matthew-larson) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-IntegrationCoverage-Debug: OK (669 of 669 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-68.47%25-green.png)


I accidentally did two commits


@eisa1212 What's your ask exactly? This PR is pending because this feature hasn't shipped just yet.


Thanks for doing this!


This is the code from TBC client (feel free to recheck wotlk):
`
v43[1] = *(float *)(*(_DWORD *)(v25 + 8) + 16);
sub_536DC0(v43[1]); // apply scale to all variables of v45
v45[0] = v45[0] - maxRange;
  v45[1] = v45[1] - maxRange;
  v45[2] = v45[2] - maxRange;
  v45[3] = v45[3] + maxRange;
  v45[4] = v45[4] + maxRange;
  v45[5] = maxRange + v45[5];
  v43[1] = 1.0 / v43[1];
  sub_460450(v43[1]); // remove scale from v45 variables
`
This would imply its supposed to be:
displayInfo->minX - radius * (1.0 / scale )
instead. @Shauren maybe jump to my aid here ^^


Successfully aliased the URL <https://jstntrnr-pb8zzuajf.now.sh> to the following aliases:

* https://jstntrnr.com
* https://jstntrnr.jstntrnr.now.sh
* https://jstntrnr-git-master.jstntrnr.now.sh


Ридеры-аксессоры должны идти сразу послед объявления класса


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


Мое мнение - лучше образаться по имени переменной. Но на некоторых проектах это не так.


Лучше чтобы поезд останавливался, а не станция командовала ему остановиться


Thank you. I wonder if this will involve visiting the MS Intune Docs pages or if it is enough to open the PR for review. Oh well. That's a future dilemma.


Commit message is "fix indentation". How is indentation fixed?


В одну строку -  `@trains.push(train) unless @trains.include?(train)`


Мы в дальнейшем будем писать интерфейс. Сейчас обхекты не должны ничего выводить в консоль, они оперируют только данными


Поправь везде это


update on the original code


I didn't pay attention to this part when this was initially commited, 'cause my `Spell::CheckRange` is from the past and is majorly different from current TC's and doesn't even check for distance to GO targets... Yes, that would be a sane idea. Also the minrange check is gone, which is probably not relevant for most, if not all, spells, but it could be implemented like that as well. But it would additionally require moving some code from `GameObject::IsAtInteractDistance(Player const*, SpellInfo const* spell)` to `GameObject::IsAtInteractDistance(Player const*, float radius)`, namely the special case for `GAMEOBJECT_TYPE_SPELL_FOCUS` (and `GAMEOBJECT_TYPE_DOOR`, which isn't implemented, the remark about which was omitted in this commit).


166330897_Issue6707 (mjwitte) - x86_64-MacOS-10.13-clang: OK (2453 of 2458 tests passed, 2 test warnings)

Messages:\n
 * 5 tests had: MTR big diffs.
 * 4 tests had: Table big diffs.
 * 3 tests had: AUD diffs.
 * 3 tests had: EIO diffs.
 * 3 tests had: ESO big diffs.
 * 3 tests had: RDD diffs.
 * 2 tests had: ESO small diffs.

Failures:\n

regression Test Summary
 * Passed: 658
 * Failed: 5

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.8%25-yellow.png)


Можно этим сейчас не заморачиваться, нет задачи сделать стейт-машину с конечным количеством состояний.


Тоже лучше в одну строку


Successfully aliased the URL <https://reactrello-4ugc39tva.now.sh> to the following aliases:

* https://reactrello.richifg.now.sh
* https://reactrello-git-master.richifg.now.sh


Типы лучше обозначать символами, а не строками


Лишняя строка, не надо do-end отбивать строками. Поправь везде


fvrggrgbrb


У тебя есть ридер на поезда.
Можно сделать метод `trains_by_type(type)`, который будет возвращать массив поездов по их типу - этого будет более чем достаточно


Лишняя строка, везде поправь


v243-rc1 includes this.


можно просто сделать attr_reader


:hourglass_flowing_sand: Waiting for custom rule data to be resolved
:point_right: click here to view a full list of the events :point_left:


Этот метод не нужен


:white_check_mark: All Rules (2 / 2) Passed

      :crown: Good job! this pull request is aligned with your organization's best practices!

      :point_right: You can review your rules settings at smart policy management :point_left:

:point_right: click here to view a full list of the events :point_left:


Thanks, Yiming!


А почему route - массив? У нас же есть специальный класс для этого?


The setup and workflow was for you to use the controllers


А точно current_station и prev_station должны быть переменными? Их стоит считать динамически


Если уже есть переменная current_station_index - зачем нам переменная current_station? Можно сделать такой метод который будет возвращать станцию на основе индекса


(Note to commit message: Of course the buttons are changed only if the lrcUri is known)


next_station и previous_station тоже должны быть методами


лучше чтобы название метода коррелировало с изменяемой переменной - add_carriage


в одну строку лучше


Mostly the `internal` package is just a simple way of [restricting what we generate javadoc for](https://github.com/jhalterman/failsafe/blob/master/pom.xml#L151). This could probably still be accomplished even if these classes were in the top level package though.

When it comes to not having to expose behavior publicly while still exposing it to the internal packages, I've gotten around this a few ways so far, ex:

https://github.com/jhalterman/failsafe/blob/master/src/main/java/net/jodah/failsafe/CircuitBreaker.java#L431
https://github.com/jhalterman/failsafe/blob/master/src/main/java/net/jodah/failsafe/PolicyExecutor.java#L148


Да, можно отправлять


self необязателен


fffff


Successfully aliased the URL <https://markedjs-jc86l7b92.now.sh> to the following aliases:

* https://markedjs.now.sh
* https://markedjs.markedjs.now.sh
* https://markedjs-git-master.markedjs.now.sh


`queue.take()` works. However, `queue.poll(5, TimeUnit.SECONDS)` could still be used to reduce CPU spinning when there is nothing in the queue but more things will be coming in the future, because it is completely threadsafe when sentinels are used. Not a big issue though, either works, particularly if processMedia and addRawOccurrenceBatch are much slower than the provider.


Actually, scale doesnt even seem to affect it after all. Feel free to doublecheck my claims.


Created multidev environment [sfgov#pr-352](https://dashboard.pantheon.io/sites/91d50373-c4cf-40e4-a646-cb73e16a140c#pr-352).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-352-sfgov.pantheonsite.io/)


Successfully aliased the URL <https://tumiserver-1xyjdnuh8.now.sh> to the following aliases:

* https://tumiserver.swss.now.sh
* https://tumiserver-git-master.swss.now.sh


Disregard my comment ^^


It's heartening that you chose to work on this PR ___ON YOUR BIRTHDAY!___ Happy Birthday @jseraf


Successfully aliased the URL <https://lambda-api-dev-env-nn2ttxx30.now.sh> to the following aliases:

* https://lambda-api-dev-env.dalisoft.now.sh
* https://lambda-api-dev-env-git-master.dalisoft.now.sh


Successfully aliased the URL <https://expo-universal-starter-cdg905sno.now.sh> to the following aliases:

* https://expo-universal-starter.briandombrowski.now.sh
* https://expo-universal-starter-git-master.briandombrowski.now.sh


Next:
Three CLM subroutines for calculating daily avg lightning using the "accumulMod" routines.


Build version: __`3.2.0-master.625`__ :crossed_fingers: [`master`](https://github.com/streamich/md-mdast/tree/master) on [*CircleCI*](https://circleci.com/gh/streamich/md-mdast/625) :tada:


Successfully aliased the URL <https://jstntrnr-98pml78kz.now.sh> to the following aliases:

* https://jstntrnr.com
* https://jstntrnr.jstntrnr.now.sh
* https://jstntrnr-git-master.jstntrnr.now.sh


Comments on the procedures declared here follow below.


input type should remain the same thruoghout


Successfully aliased the URL <https://markedjs-hkw01j0x3.now.sh> to the following aliases:

* https://markedjs.now.sh
* https://markedjs.markedjs.now.sh
* https://markedjs-git-master.markedjs.now.sh


I followed existing templates for this, such as the one found in /src/biogeophys/TemperatureType.F90


@rob-Hitchens Any chance to get the exam assignment when we're done with this review?


- weird bug where lines only show up on node click


Successfully aliased the URL <https://ext-test-site-o1vnr25sx.now.sh> to the following aliases:

* https://ext-test-site.qqq.now.sh
* https://ext-test-site-git-master.qqq.now.sh