🔥 Device tests completed (Failed) on iOS on [Azure DevOps](https://dev.azure.com/devdiv/DevDiv/_build/index?buildId=2937233)(iOS): [Html Report](http://xamarin-storage/jenkins/xamarin-macios/alex-monobump-d163/f79e861580eff988d3b84a936fc4fd8a17911ef0/2937233/device-tests/jenkins-results/tests/index.html) 🔥

# Test results

<details>
<summary>113 tests failed, 0 tests passed.</summary>

## Failed tests

 * monotouch-test/iOS Unified 64-bits - device/Debug: Crashed
 * framework-test/iOS Unified 64-bits - device/Debug: Crashed
 * interdependent-binding-projects/iOS Unified 64-bits - device/Debug: Crashed
 * fsharp/iOS Unified 64-bits - device/Debug: Crashed
 * dont link/iOS Unified 64-bits - device/Debug: Crashed
 * link all/iOS Unified 64-bits - device/Debug: Crashed
 * link sdk/iOS Unified 64-bits - device/Debug: Crashed
 * mono-native-compat/iOS Unified 64-bits - device/Debug: Crashed
 * mono-native-unified/iOS Unified 64-bits - device/Debug: Crashed
 * [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - device/Debug: Crashed
 * [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/Debug: Crashed
 * [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - device/Debug: Crashed
 * [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - device/Debug: Crashed
 * mscorlib/iOS Unified 64-bits - device/Debug: Crashed
 * [xUnit] Mono BCL tests group 6/iOS Unified 64-bits - device/Debug: Crashed
 * monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * monotouch-test/iOS Unified 64-bits - device/Release: Crashed
 * monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * monotouch-test/iOS Unified 64-bits - device/Debug (dynamic registrar): Crashed
 * monotouch-test/iOS Unified 64-bits - device/Release (all optimizations): Crashed
 * monotouch-test/iOS Unified 64-bits - device/Debug (all optimizations): Crashed
 * monotouch-test/iOS Unified 64-bits - device/Debug: SGenConc: Crashed
 * monotouch-test/iOS Unified 64-bits - device/Debug (interpreter): Crashed
 * monotouch-test/iOS Unified 64-bits - device/Debug (interpreter -mscorlib): Crashed
 * monotouch-test/iOS Unified 64-bits - device/Release (interpreter -mscorlib): Crashed
 * framework-test/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * framework-test/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * framework-test/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * framework-test/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * framework-test/iOS Unified 64-bits - device/Release: Crashed
 * framework-test/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * interdependent-binding-projects/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * interdependent-binding-projects/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * interdependent-binding-projects/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * interdependent-binding-projects/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * interdependent-binding-projects/iOS Unified 64-bits - device/Release: Crashed
 * interdependent-binding-projects/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * fsharp/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * fsharp/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * fsharp/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * fsharp/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * fsharp/iOS Unified 64-bits - device/Release: Crashed
 * fsharp/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * dont link/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * dont link/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * dont link/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * dont link/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * dont link/iOS Unified 64-bits - device/Release: Crashed
 * dont link/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * link all/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * link all/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * link all/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * link all/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * link all/iOS Unified 64-bits - device/Release: Crashed
 * link all/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * link sdk/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * link sdk/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * link sdk/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * link sdk/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * link sdk/iOS Unified 64-bits - device/Release: Crashed
 * link sdk/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * mono-native-compat/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * mono-native-compat/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * mono-native-compat/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * mono-native-compat/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * mono-native-compat/iOS Unified 64-bits - device/Release: Crashed
 * mono-native-compat/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * mono-native-unified/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * mono-native-unified/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * mono-native-unified/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * mono-native-unified/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * mono-native-unified/iOS Unified 64-bits - device/Release: Crashed
 * mono-native-unified/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - device/Release: Crashed
 * [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/Release: Crashed
 * [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - device/Release: Crashed
 * [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - device/Release: Crashed
 * [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * mscorlib/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * mscorlib/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * mscorlib/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * mscorlib/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * mscorlib/iOS Unified 64-bits - device/Release: Crashed
 * mscorlib/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * mscorlib/iOS Unified 64-bits - device/Debug: SGenConc: Crashed
 * [xUnit] Mono BCL tests group 6/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
 * [xUnit] Mono BCL tests group 6/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
 * [xUnit] Mono BCL tests group 6/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
 * [xUnit] Mono BCL tests group 6/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed
 * [xUnit] Mono BCL tests group 6/iOS Unified 64-bits - device/Release: Crashed
 * [xUnit] Mono BCL tests group 6/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
</details>


Change angle to angles not radians.
It could help to have the angle only go to 180 perhaps.


79~81 라인에 Indent 조정 필요해 보입니다.


public, protected, private의 순서로 선언되어야 합니다.
키워드 들여쓰기는 1칸입니다.


사용하지 않는 지역변수는 삭제하는게 좋을 것 같습니다.


놓쳤네요, 적용할게요


addCharCounter(StringBuilder builder, int count) method를 하나 생성 해서 대체한다면 addChar와 동일 하게 가독성이 좀더 나아질수 있을것 같습니다.


can't you use the already existent `PoissonNextSend`, what's time granularity do you need?


들여쓰기는 모두 스페이스 2로 통일 부탁드립니다


size()도 storage를 변경하는 것이 아니니 empty()와 마찬가지로 const로 선언해도 괜찮지 않을까요?
// int templatePriorityQueue<int>::size() const {


Deployment failed with the following error:

~~~
You defined 1 build that did not match any source files (please ensure they are NOT defined in .nowignore):
~~~


탭 대신 스페이스 2칸을 사용해야 합니다.


위의 코멘트와 동일하게 shopping_list_vector 의 이름이 변경된다면 주석도 변경해야 하니 주석에 shopping_list_vector 를 기술할 필요는 없어 보입니다.
// Get Goods object from end of list 정도면 충분할 것 같습니다.


I recommend to add compare function in Goods class and call it here.


제가 c++는 익숙하지가 않아서요, 적용하도록할게요


복사 연산자가 사용되니 이에 대해 명시적으로 구현을 하는 것이 어떨까요?
"copyable and Movable type"-모든 class의 public API는 class 가 복사 가능한지, 이동 전용인지 또는 복사 및 이동 전부 불가능 한지에 대해 명시해야 합니다.


내용이 없는 함수 이니, 두 라인이 아닌, 한 라인으로 표기하는 것은 어떨까요?


불필요한 Blank line 정리되면 더 좋을 것 같습니다.
115번도 동일합니다.


databasenya ada ga mas


size()도 storage를 변경하는 것이 아니니 empty()와 마찬가지로 const로 선언해도 괜찮지 않을까요?
int size() const;


push_back method 자체는 exception safe 하다고 합니다.
http://www.cplusplus.com/reference/vector/vector/push_back/

다만 한가지 제안은, 현재 코드가 shopping 몰을 위한 library를 작성하는 것이 목적이라면,
user가 shopping goods를 shopping list에 담지 못한 상황에 대해 noti를 주는 것이 좋지 않을까 하는게 제안입니다.
For example:
try {
 shopping_list_.push_back(object);
} catch (...) {
 //TODO : Excption handling, e.g., alert to user
}


155~157 라인 Indent 조정 필요할 것 같습니다.


Cool, let's see how it goes.


const가 필요하지 않을까요?

int size() const;


vaya


이 부분은 생소한데요, 혹시 참고할만한 레퍼런스가 있을까요??^^;;


Successfully aliased the URL <https://resume-528a9ii6r.now.sh> to the following aliases:

* https://resume.ljlm0402.now.sh
* https://resume-git-master.ljlm0402.now.sh


Note, I think you do a rebroadcast randomly once per day, should be updated in comment. Not once per day at fixed hour


Style Guide에 따라 if/else 구문에서는 두 블록 모두 중괄호를 이용하는 것이 좋을 것 같습니다.


// 로 주석을 다는 것으로 통일하는 것은 어떨까요?


그런데, std::priority_queue를 그대로 wrapping 하고 있는데, std::priority_queue를 쓰지 않고 wrapping template을 작성한 이유는 무엇인가요?


ZEIT Now cannot deploy this project to production due to following domain related issues:

 * `tmdb.idiot.design`(for alias `tmdb.idiot.design`) is not found inside your account. [Add it](https://zeit.co/dashboard/domains?action=add&domain=tmdb.idiot.design).


불필요한 라인은 제거하는 것이 좋을 것 같습니다.


I recommend to delete this function or change because the body is same compared to SortByPrice function.
I recommend to refer to comments of SortByPrice function.


끝에 "*/"로 주석문을 닫아야 하지 않을가요?


첫번째 Review 코멘트 남겼습니다. 확인 부탁 드립니다.


This check is done in the CLI. I don't quite understand why we need it here as well? if the error message is not good enough then I'll change it the CLI.


173~176 라인의 Indent 조정 필요해 보입니다.
또한 172 라인의 주석은 아래 코드로 쉽게 파악 가능하므로 굳이 필요해 보이지 않습니다.


80줄을 넘어갔습니다. 줄을 변경해 주시기 바랍니다.


Instead of
std::vector<Goods>::iterator min = shopping_list_.end();
...
      if (min == shopping_list_.end()) {
        min = j;
        continue;
      }
...
    min = shopping_list_.end();

std::vector<Goods>::iterator min;
...
  for (std::vector<Goods>::iterator i = shopping_list_.begin();
      i != shopping_list_.end()-1; i++) {
    min = i;
    for (std::vector<Goods>::iterator j = i; j != shopping_list_.end(); j++) {
...
can be simpler.


179~182 라인 Indent 조정 필요해 보입니다.


This can be part of the CLI as defaults.


불필요한 주석 같습니다. 삭제 부탁드립니다.


선언 직후에 prio. queue가 비어 있는지 확인 하는 테스트라면 ASSERT_FALSE가 적절할 것 같습니다.

참고 링크 : https://github.com/google/googletest/blob/master/googletest/docs/primer.md
Assertions / Basic Assertion 챕터


that's a behavior change I think


do while() 중괄호를 public static void main(String args[])throws IOException{ 내 들여쓰기(space 2칸) 을 적용하여 코드의 가독성을 높혀주십시요.

public static void main(String args[])throws IOException{
  do {
    System.out.println("\n\n\n1.Bubble Sort\n2.Selection Sort\n3.Insertion Sort.\n4.Quick Sort.\n5.Merge Sort.\n6.Exit.");
    ch=Integer.parseInt(br.readLine());
    if(ch==6) return;
    (중략)
  }
}


It seems it would be better to include shopping.h before then iostream


generally, we don't put spaces inside parentheses.


Now we relay whatever happens, should be documented :)


앗. 코멘트를 삭제 했습니다. :-)
리뷰 코멘트가 바로바로 올라가는 것이였군요. 모아서 한꺼번에 올라가는 줄 알았네요.
위에 코멘트는 무시 하셔도 됩니다.


It seems it would be better to include goods.h before then vector


I think it was much cleaner to indicate Zen/Zen+/Zen2. Now if you look at README it is not obvious whether Ryzen 3XXX are supported or not, but it is clear that TR & Athlon 2XXGE are compatible. Should you add Ryzen 1XXX, 2XXX, 3XXX here?


불필요한 주석인것 같습니다. 삭제 부탁드립니다.


Successfully aliased the URL <https://estimateonline-l0nsabn0f.now.sh> to the following aliases:

* https://estimateonline.ivanlori.now.sh
* https://estimateonline-git-master.ivanlori.now.sh


This functions and https://github.com/kjk/prometheus/commit/7e4cd7b2d2cb96202219dc7ba1e81d7faf1f1c89
contains a lot of duplicate code imho. it can be the same function just with --local flag set when regression is called, this is the only difference.


return 에 대한 의미가 명확하지만 java doc 포맷을 지키는게 필요합니다.

PushList 와 GetLastElement 를 봤을때 이름의 포맷을 유지하면 어떨가요?
PushElement/GetLastElement 또는 PushToList/GetFromList ?


I recommend following rule
C system library header file
C++ system library header file
blank
header file not related with this file

#include "./goods.h"

#include <vector>

So, I recommend to change as following
#include "./shopping.h"

#include


generally, we don't put spaces inside parentheses. (https://google.github.io/styleguide/cppguide.html#Formatting)


Are you trying to port this too?


Sir please send your mobile number. i am facing some error in this code. please call me once 7015927404


sir please provide your number


ZEIT Now cannot deploy this project to production due to following domain related issues:

 * `tmdb.idiot.design`(for alias `tmdb.idiot.design`) is not found inside your account. [Add it](https://zeit.co/dashboard/domains?action=add&domain=tmdb.idiot.design).


단일 statement만 포함되어 있지만, 가이드 상 for 문 블럭 가독성을 위해 중괄호를 추가하는 것이 좋을 것 같습니다.


생성자와 소멸자에서 하는 일이 없는데, 굳이 만들어준 이유가 있을까요~?


shopping_list가 empty일때의 behavior가 정의되어야 하지 않을까 싶습니다.
이러한 경우, 아래 문서에 따르면 "Calling this function on an empty container causes undefined behavior."
인 경우가 되어, 동작 예측이 안될 것으로 생각됩니다.
(ref: http://www.cplusplus.com/reference/vector/vector/back/)
아래와 같이 return을 수행하기 전에 size를 확인하면 어떨까 합니다.
if (shopping_list_.size() != ) {
 return shopping_lilst_.back();
} else {
 // TODO : return defined error action or throw error
}


Enable


space 추가해주세요
1. ,과 Trivial 사이
2. )와 { 문자 사이


cc @schrodit


I recommend to make this function const to clarify meaning of it
 Goods GetLastElement() const
 void PrintList() const;


Successfully aliased the URL <https://sindre-is-mxyt4j8xg.now.sh> to the following aliases:

* https://sindre.is
* https://sindre-is.boyum.now.sh
* https://sindre-is-git-master.boyum.now.sh


i always love these commits


Style 가이드 상 메소드명을 소문자로 시작하는 CamelCase 형태로 수정하는 것이 필요할 것 같습니다.
아래 메소드들 전체에 해당하는 내용입니다.


I recommend following rule
header file related with current file
blank
C system library header file
C++ system library header file

So, I recommend to change as following
#include "./shopping.h"

#include <gtest/gtest.h>


else if문이 있어 중괄호를 사용하는게 가독성 향상에 도움이 될 것 같습니다.


아래의 빈 라인이 필요할까요?
필요하지 않다면 삭제 부탁드립니다.


Space 2칸을 들여쓰기로 사용합니다.
 : Coding Guide 권고


아직 모르겟네요


shopping_list_.begin()/end()의 return값이 변하지 않는 값이라면 for loop내에서 함수 호출형태가 아닌 변수(p, min)으로 변경하는 것이 좋겠습니다.


MergeSort 메소드만을 위한 메소드로서 private 멤버로 선언하는 것이 더 좋지 않을지 고려 부탁드립니다.


Successfully aliased the URL <https://portfolio-es3utu836.now.sh> to the following aliases:

* https://nuot.io
* https://portfolio.laurin.now.sh
* https://portfolio-git-master.laurin.now.sh


Thanks. Windows 10 Home and XAMPP 3.2.2 installed. What should i install? Help me, please.

[cid:fa3692ed-ec3c-4047-89d3-04954359eaa6]

Get Outlook for Android<https://aka.ms/ghei36>
________________________________
From: Evg <notifications@github.com>
Sent: Sunday, August 11, 2019 7:57:39 PM
To: SugataRu/sugata.ru <sugata.ru@noreply.github.com>
Cc: serkanatsiz <serkanatsiz@hotmail.com>; Comment <comment@noreply.github.com>
Subject: Re: [SugataRu/sugata.ru] Update README.md (fd371bf)

Take a closer look at these settings. Perhaps the whole thing is in them.

https://github.com/SugataRu/sugata.ru/blob/master/vendor/crodas/haanga/lib/Haanga/Compiler/Tokenizer.php#L561
https://github.com/SugataRu/sugata.ru/blob/master/www/config.php#L278

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<https://github.com/SugataRu/sugata.ru/commit/fd371bfcde683034c45c12860eb6a1a86e2c9fa4?email_source=notifications&email_token=AHNZDPBEPI54FKLWDTMHSHTQEBAIHA5CNFSM4IKYUH62YY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBBBNSM#commitcomment-34649676>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AHNZDPFZ5MFTLLZ2POUOWILQEBAIHANCNFSM4IKYUH6Q>.


minor : 위의 코멘트처럼 이름을 바꾼다면, PrintElementsInList 로 이름 변경은 어떨가요?


I recommended some Google C++ styles.


#include <algorithm> should be added if you want to use iter_swap


@nonnull 또는 array가 null 일 경우를 대비해서 exception handling이 필요해 보입니다.


조건문 이후 단일 오퍼레이션 수행시에는 동일한 라인으로 적용하는 것을 검토해봐주십시요.
if(ch==6) return;


QuickSort만을 위한 메소드로서 private 멤버로 두는 것이 어떨지 고려 부탁드립니다.


Deployment failed with the following error:

~~~
You defined 1 build that did not match any source files (please ensure they are NOT defined in .nowignore):
~~~


Successfully aliased the URL <https://sindre-is-4uppbvdjz.now.sh> to the following aliases:

* https://sindre.is
* https://sindre-is.boyum.now.sh
* https://sindre-is-git-master.boyum.now.sh


header file include 순서 확인 필요


I have cleaned up and rewritten the algorithm to account for the changes above. I was wondering if in these lines:

if (dest_y - pos_y) > self.rate change_rate(1)
if (dest_y - pos_y) < self.rate change_rate(-1)

self.rate was supposed to be self.pos_y instead of self.rate, as we are comparing it to the difference in elevations (dest_y - pos_y) rather than rates of movement. I could be wrong though and you can look at what I mean in my next commit.


Поправил.


변수에 대한 설명 필요, 사용되는 곳이 없음?


1. Class name은 Camel case로 작성 필요
2. Public -> Private 순으로 작성 필요
3. 함수이름은 대문자로 시작 필요
4.  size() 함수는 멤버변수를 변경하지 않으니 뒤에 const 붙이는게 좋을 듯


slowest report ever, but shouldn't it be isAir? (:


Priority_queue.h에 작성된 comment에 따라 아래 일괄 수정


readability 를 auto 를 사용하면 좋을것 같습니다.


:white_check_mark: All Rules (5 / 5) Passed

      :crown: Good job! this pull request is aligned with your organization's best practices!

      :point_right: You can review your rules settings at smart policy management :point_left:

:point_right: click here to view a full list of the events :point_left:


Nice work, mate.


Successfully aliased the URL <https://tmdb-10uu3aifm.now.sh> to the following aliases:

* https://tmdb.shit1.now.sh
* https://tmdb-git-master.shit1.now.sh


변수에 대한 설명 추가


My bad:D your comment was correct, I just somehow wrongly assumed we are talking about the whole "retain confirmation" logic... In that case I agree it's completely fine to move it into PostModel.


해당 파일과 직접적인 연관있는 헤더를 맨위로 올리고 한줄 띄우고 나머지 파일 include


reference로 전달되는 parameter에 대해 const 선언


함수 이름은 Camel case로 작성


변수명과 상수명을 좀 더 가독성 쉽게 좀 더 직관적인 변수명으로 변경 하는 것은 어떨까요?
 예를 들어.
 1) br 을 buffer_reader 로,
 2) n을 num으로,
 3) a[] 를 array[] 로


template metaprogramming을 사용하지 않기를 권유 드립니다.


변수 이름은 모두 소문자로 작성


위 SortByPrice와 같은 로직이 사용되어 코드가 중복으로 보입니다.
하나의 함수로 작성하시면 좋지 않을까 합니다.


코드에 6이라고 하드코딩이 되어있는데.. 가능하면 상수(EXIT)로 정의하여 활용하면 가독성이 더 좋아질 것 같습니다.
 eg) while(ch!=6);  -> while(ch!= EXIT)


data push 횟수가 변경되었을때도 TC가 정상동작하도록 코드가 변경되는게 좋을 것 같습니다.


숨겨진 의존성을 피하기 위한 header file의 include 순서는 다음과 같습니다.
현재 파일의 구현과 관련 있는 header file
빈 줄
C system library header file
C++ system library header file
빈 줄
다른 project library header file
현재 project library header file


SortByPrice, SortByIndex를 하나의 함수로 만드는 것을 고려해 주시면 좋을것 같습니다.


push 되는 data의 최대값이 변경되었을때도 TC가 정상동작하도록 변경되는게 좋을 것 같습니다.


조건문을 간단한 함수로 표현하는 것을 권유합니다.


Does this removed, really delete the entry from the vlan table?


들여쓰기는 2칸입니다.


만일 SortByIndex 및 SortByPrice를 수정하신다면 test도 같이 update 요청드립니다.


상수 값으로 top value와 prio. queue size를 비교하면 queue에 push되는 data 를 변경했을때 TC가 오동작할 가능성이 높아 보입니다.
data가 변경되더라도 TC가 올바르게 동작할 수 있도록 수정 필요해 보입니다.


if (left >= right) return; 으로 함수 조기 종료를 시키면 어떨까요?


전반적으로 함수에 대한 주석이 동작그대로의 설명입니다.


@nziokaivy  Resolve conflict


SortByPrice 와 SortByIndex 가 비교하는것을 제외하고는 유사한데요,
STL의 sort를 사용하고, compare하는 부분만 재정의를 하면 중복된 코드를 삭제하고 simple하게 구현이 가능해보입니다.
```
boolean compareByPrice(Goods a, Goods b)
boolean compareByIndex(Goods a, Goods b)
를 정의하고

void Shopping::SortByPrice() {
 sort(shopping_list_.begin(), shopping_list_.end(), compareByPrice))
}
```


Hi.
I think the sample source file was deleted. How can I download the code?
thanks.


위의 STL을 이용한 sort와 동일


@nziokaivy  New line required


will remove. the intent was to have an error message as descriptive as possible.


header파일을 중복해서 포함하는걸 방지하기 위해서 #ifdef 추가 필요합니다.
#ifdef PRIORITY_QUEUE_H_
#define PRIORITY_QUEUE_H_
....
#endif


https://google.github.io/styleguide/cppguide.html#The__define_Guard
헤더파일 처음과 끝에 내용이 중복되어 적용되지 않도록 #define guard를 추가합니다.


agreed it would be even better in cli. should I remove it?


확장성을 고려하여 n 개의 Goods 를 만드는 base code를 만들고,
44번 처럼 숫자 자체를 사용하기 보단, base code에서 만들어진 값을 통해 test 결과를 확인하면 좋을것 같습니다.


Deployment failed with the following error:

~~~
You defined 1 build that did not match any source files (please ensure they are NOT defined in .nowignore):
~~~


PR_opened/Fix_7151_GeneratorPVAvailSched (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-UnitTestsCoverage-Debug: OK (1123 of 1123 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-42.35%25-green.png)


1. p value는 i value와 중복코드로 삭제하겠습니다.
2. min value는 중간에 변경되기 때문에 그대로 유지하는 것이 필요합니다.


will try to improve. writing non-trivial shell scripts is not my forte but will look it up.


수정하겠습니다.


import


주석 포함하겠습니다.


Лучше выбрать один подход к именованию и придерживаться его, хотя бы в рамках одного проекта


테스트 코멘트


> That would work in fixing this symptom, but it felt like it indirectly addressed the problem far away from the source.

But then on the other hand it *is* a workaround of a sort, and it'd keep the message system and its collected workarounds nice and separate.

Unlike the Choas thing, which has tenure.


테스트 코멘트 하단


@AmaurX, I believe there is but my interpretation of the PiCamera documentation is that these modes are dynamic, i.e. it will adjust the shutter speed in low-light conditions (don't trust me on this). So, this should be more reliable for consistent performance than fixing the shutter speed directly.
And indeed, we can have a watchtower config file.


`StackStateMachine.cs(250,21): warning CS0162: Unreachable code detected`


У тебя название функции и комментарий говорят о разной реализуемой функциональности. На мой взгляд, лучше, когда название функции "говорит" само за себя, без быстро устаревающих комментов


https://echarts-maps.github.io/echarts-geomapping-book-en/
https://echarts-maps.github.io/echarts-geomapping-book-zh/


how download the module only?


`StackStateMachine.cs(250,21): warning CS0162: Unreachable code detected` - [MSBuild](https://ci.appveyor.com/project/liu-wenyuan/hackerbomberscript/builds/26655123#L27)


반영 하겠습니다.


Добавьте в gitignore папку .idea/ можно взять полностью гитигнор из моих примеров.
Лишние служебаные файлы сильно усложняют восприятие кода.


const 로 수정하겠습니다.
{는 모두 한칸 띄는 것으로 수정하겠습니다.


비교할 문자열이 없는 조기종료 조건으로, length() < 2 로 조건 수정했습니다.


I think it will be to avoid duplication.

#ifndef PRIORITY_QUEUE_PRIORITY_QUEUE_H_
#define PRIORITY_QUEUE_PRIORITY_QUEUE_H_
....
#endif


수정하겠습니다.


예 .수정하겠습니다.


SetGoodsInfo 로 전달 되는 파라미터는 call by value로
해당 class 멤버 변수를 set하는 함수로 파라미터 const 이 없어도 되는거 아닌지요?


Чисто с точки зрения тестирования проверка /all не самая удачная, так как мы тут ничем не урпалвяем и от нас ничего не зависит, каждый раз когда кто-то решит добавить или убрать что-то нужно будет переделывать тест, хотя апи по сути будет работать правильно.


주옥같은 리뷰 감사드립니다.

wild card 대신 필요한 package를 명시하도록 수정하였고
불필요한 import구문은 삭제 하였습니다.
 import java.lang.*;


예 . 추가하겠습니다.


No, I mean self.rate

If the change in distance is less than the rate (which is distance
travelled per unit time) then we're close enough to stop.

Change 1m/s to 2m/s for your rate. How close do you have to be to your
destination to stop? Is it still 1m or is it 2m?

On Mon., Aug. 12, 2019, 22:49 Stemist, <notifications@github.com> wrote:

> I have cleaned up and rewritten the algorithm to account for the changes
> above. I was wondering if in these lines:
>
> if (dest_y - pos_y) > self.rate change_rate(1)
> if (dest_y - pos_y) < self.rate change_rate(-1)
>
> self.rate was supposed to be self.pos_y instead of self.rate, as we are
> comparing it to the difference in elevations (dest_y - pos_y) rather than
> rates of movement. I could be wrong though and you can look at what I mean
> in my next commit.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/pachocanadian/sole/commit/2075c10dc2d7450e9c7264461ec00ebe8750eea7?email_source=notifications&email_token=AJBVIOTAMBZAASRYOGTVC4LQEJDQBA5CNFSM4ILFF44KYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBBB7KW#commitcomment-34667862>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AJBVIOXALAFPD2XDZIO55E3QEJDQBANCNFSM4ILFF44A>
> .
>


Здесь аналогично комментарию про /all


중괄호의 경우 line의 마지막에 위치 하도록 소스 전반적으로 수정 하였습니다.


define_once('NUKE_TITANIUM', '3.0.0');


Вот этот скрипт я не совсем понял что делает :)


삭제하겠습니다.


Copy of this build can be found at
https://builds.myetherwallet.com/build/e3bb10375f0c361602faa96c5b89c93330022c04/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmeUMWMprwL2p7bNkMgPuHYHPrLEFtuEXvjgi1jFJnqBXN
                       Virus Total analysis
                       https://www.virustotal.com/file/1e91ddcb2b2c789f8be84012a70195f914f46df0b0810c9809357338a1f2e575/analysis/1565676710/


I wasn't able to retrieve PDD puzzles from the code base and submit them to GitHub. If you think that it's a bug on our side, please submit it to [yegor256/0pdd](https://github.com/yegor256/0pdd/issues):

> set -x && set -e && set -o pipefail && cd /tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area && pdd -v -f /tmp/20190813-390-ui8oii [1]: bash: warning: setlocale: LC_ALL: cannot change locale (UTF-8) + set -e + set -o pipefail + cd /tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area + pdd...

Please, copy and paste this stack trace to GitHub:

```
UserError
set -x && set -e && set -o pipefail && cd /tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area && pdd -v -f /tmp/20190813-390-ui8oii [1]:
bash: warning: setlocale: LC_ALL: cannot change locale (UTF-8)
+ set -e
+ set -o pipefail
+ cd /tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area
+ pdd -v -f /tmp/20190813-390-ui8oii

My version is 0.20.5
Ruby version is 2.6.0 at x86_64-linux
Reading /tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area
160 file(s) found, 56 excluded
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/gradle/wrapper/gradle-wrapper.jar is a binary file (54329 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/gradle/wrapper/gradle-wrapper.jar is a binary file (54329 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/.idea/caches/build_file_checksums.ser is a binary file (525 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/release-key.jks is a binary file (2258 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/mipmap-hdpi/ic_launcher.png is a binary file (2963 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/mipmap-hdpi/ic_launcher_round.png is a binary file (4905 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/mipmap-xxhdpi/ic_launcher.png is a binary file (6387 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/mipmap-xxhdpi/ic_launcher_round.png is a binary file (10413 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/mipmap-mdpi/ic_launcher.png is a binary file (2060 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/mipmap-mdpi/ic_launcher_round.png is a binary file (2783 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/mipmap-xhdpi/ic_launcher.png is a binary file (4490 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/mipmap-xhdpi/ic_launcher_round.png is a binary file (6895 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/drawable/doctor_image.jpg is a binary file (12959 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/drawable/research_image_2.jpg is a binary file (30704 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/drawable/research_image_3.jpg is a binary file (14664 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/drawable/researches_image_2.jpg is a binary file (13496 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/drawable/change_photo.png is a binary file (2651 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/drawable/research_image_1.jpg is a binary file (13483 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/drawable/image.jpg is a binary file (158122 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/mipmap-xxxhdpi/ic_launcher.png is a binary file (9128 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/mipmap-xxxhdpi/ic_launcher_round.png is a binary file (15132 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/drawable-v24/collapse_image.png is a binary file (588 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/drawable-v24/eagle.png is a binary file (106848 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/drawable-v24/expand.png is a binary file (655 bytes)
Reading .gitignore...
Reading Source/gradle/wrapper/gradle-wrapper.properties...
Reading Source/.gitignore...
Reading Source/gradlew...
Reading Source/app/proguard-rules.pro...
Reading Source/app/gradle/wrapper/gradle-wrapper.properties...
Reading Source/app/.gitignore...
Reading Source/app/gradlew...
Reading Source/app/gradlew.bat...
Reading Source/app/google-services.json...
Reading Source/app/.idea/encodings.xml...
Reading Source/app/.idea/gradle.xml...
Reading Source/app/.idea/modules.xml...
Reading Source/app/.idea/misc.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_lifecycle_lifecycle_runtime_2_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_print_print_1_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_appcompat_appcompat_1_0_2_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_fragment_fragment_1_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_loader_loader_1_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_annotation_annotation_1_0_2_jar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_vectordrawable_vectordrawable_animated_1_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_cardview_cardview_1_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_customview_customview_1_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_arch_core_core_common_2_0_0_jar.xml...
Reading Source/app/.idea/libraries/Gradle__net_sf_kxml_kxml2_2_3_0_jar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_cursoradapter_cursoradapter_1_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__org_jetbrains_annotations_13_0_jar.xml...
Reading Source/app/.idea/libraries/Gradle__org_jetbrains_kotlin_kotlin_android_extensions_runtime_1_3_31_jar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_lifecycle_lifecycle_livedata_2_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__org_jetbrains_kotlin_kotlin_stdlib_jdk7_1_3_31_jar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_lifecycle_lifecycle_livedata_core_2_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__org_jetbrains_kotlin_kotlin_stdlib_common_1_3_31_jar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_test_monitor_1_2_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_arch_core_core_runtime_2_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__org_hamcrest_hamcrest_library_1_3_jar.xml...
Reading Source/app/.idea/libraries/Gradle__org_hamcrest_hamcrest_core_1_3_jar.xml...
Reading Source/app/.idea/libraries/Gradle__com_microsoft_appcenter_appcenter_analytics_2_1_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_viewpager_viewpager_1_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_recyclerview_recyclerview_1_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_navigation_navigation_ui_ktx_2_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_constraintlayout_constraintlayout_1_1_3_aar.xml...
Reading Source/app/.idea/libraries/Gradle__junit_junit_4_12_jar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_slidingpanelayout_slidingpanelayout_1_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__javax_inject_javax_inject_1_jar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_interpolator_interpolator_1_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_navigation_navigation_common_2_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_legacy_legacy_support_core_ui_1_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_core_core_ktx_1_0_2_aar.xml...
Reading Source/app/.idea/libraries/Gradle__org_hamcrest_hamcrest_integration_1_3_jar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_navigation_navigation_fragment_ktx_2_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__com_microsoft_appcenter_appcenter_2_1_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_navigation_navigation_ui_2_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_localbroadcastmanager_localbroadcastmanager_1_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_drawerlayout_drawerlayout_1_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_versionedparcelable_versionedparcelable_1_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__org_jetbrains_kotlin_kotlin_stdlib_1_3_31_jar.xml...
Reading Source/app/.idea/libraries/Gradle__com_microsoft_appcenter_appcenter_crashes_2_1_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_transition_transition_1_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_swiperefreshlayout_swiperefreshlayout_1_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_collection_collection_1_0_0_jar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_navigation_navigation_runtime_2_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_lifecycle_lifecycle_common_2_0_0_jar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_constraintlayout_constraintlayout_solver_1_1_3_jar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_lifecycle_lifecycle_viewmodel_2_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_test_runner_1_2_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_navigation_navigation_fragment_2_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_documentfile_documentfile_1_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_asynclayoutinflater_asynclayoutinflater_1_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_navigation_navigation_common_ktx_2_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__com_squareup_javawriter_2_1_1_jar.xml...
Reading Source/app/.idea/libraries/Gradle__com_google_code_findbugs_jsr305_2_0_1_jar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_navigation_navigation_runtime_ktx_2_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__com_google_android_material_material_1_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_vectordrawable_vectordrawable_1_0_1_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_legacy_legacy_support_core_utils_1_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_core_core_1_0_2_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_test_espresso_espresso_idling_resource_3_2_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_coordinatorlayout_coordinatorlayout_1_0_0_aar.xml...
Reading Source/app/.idea/libraries/Gradle__androidx_test_espresso_espresso_core_3_2_0_aar.xml...
Reading Source/app/.idea/workspace.xml...
ERROR: Source/app/.idea/workspace.xml; puzzle at line #357; TODO must have a leading space to become a puzzle, as this page explains: https://github.com/yegor256/pdd#how-to-format
If you can't understand the cause of this issue or you don't know how to fix it, please submit a GitHub issue, we will try to help you: https://github.com/yegor256/pdd/issues. This tool is still in its beta version and we will appreciate your feedback. Here is where you can find more documentation: https://github.com/yegor256/pdd/blob/master/README.md.
Exit code is 1

/app/objects/git_repo.rb:66:in `rescue in block in xml'
/app/objects/git_repo.rb:63:in `block in xml'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/tempfile.rb:295:in `open'
/app/objects/git_repo.rb:62:in `xml'
/app/objects/puzzles.rb:36:in `deploy'
/app/objects/job.rb:38:in `proceed'
/app/objects/job_starred.rb:33:in `proceed'
/app/objects/job_recorded.rb:32:in `proceed'
/app/objects/job_emailed.rb:35:in `proceed'
/app/objects/job_commiterrors.rb:36:in `proceed'
/app/objects/job_detached.rb:48:in `exclusive'
/app/objects/job_detached.rb:36:in `block in proceed'
/app/objects/job_detached.rb:36:in `fork'
/app/objects/job_detached.rb:36:in `proceed'
/app/0pdd.rb:358:in `block in <top (required)>'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1635:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1635:in `block in compile!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:992:in `block (3 levels) in route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1011:in `route_eval'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:992:in `block (2 levels) in route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1040:in `block in process_route'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1038:in `catch'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1038:in `process_route'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:990:in `block in route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:989:in `each'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:989:in `route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1097:in `block in dispatch!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `block in invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `catch'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1094:in `dispatch!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:924:in `block in call!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `block in invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `catch'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:924:in `call!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:913:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/xss_header.rb:18:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/path_traversal.rb:16:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/json_csrf.rb:26:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/base.rb:50:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/base.rb:50:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/frame_options.rb:31:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/logger.rb:15:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/common_logger.rb:33:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:231:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:224:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/head.rb:12:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/method_override.rb:22:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:194:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1957:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1502:in `block in call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1729:in `synchronize'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1502:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/handler/webrick.rb:86:in `service'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/webrick/httpserver.rb:140:in `service'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/webrick/httpserver.rb:96:in `run'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/webrick/server.rb:307:in `block in start_thread'
```


Yes I'm pushing this change in the next hour.


> Wildcard 기반의 Import는 선호되지 않는 것으로 알고 있습니다.
> 특별한 이유가 있다면 설명 부탁드리겠습니다.
> 혹은 개별 Class를 Import하는 것으로 수정하는 것이 어떨까요?

주옥같은 리뷰 감사드립니다.

wild card 대신 필요한 package를 명시하도록 수정하였고
불필요한 import구문은 삭제 하였습니다.
import java.lang.*;


Sir,
Can you explain a little bit about the quintuple? We are confusing with the positions of the operators in the crossing equation matrices. We put some data in PyCFTBoot but it shows the same error every time, like(for three correlators bootstrap)
sdp.add_point([0, 0], eps, [[0, 1], sig, [1, 2], [0, 0], 1.0])

Traceback (most recent call last):
File "./EqualityOPE.py", line 71, in
result = sdp.iterate()
File "/home/pycftboot-master/bootstrap.py", line 1242, in iterate
self.write_xml(obj, self.unit, name)
File "/home/pycftboot-master/bootstrap.py", line 1063, in write_xml
if quint[3][0] != r or quint[3][1] != s:
IndexError: list index out of range


Yes, pushing this default now as well.


I think a release is still missing... at least I can't find any in npm.


1) 해당 명명에 이미 index, price라는 변수명에 포함된 의미가 있습니다.ㅣ
2) 해당 변수는 private으로 외부에서 사용하는 측에서는 GetIndex, GetPrice 를 통해서 접근 하도록 되어 있습니다.
해당 method에서 의미를 충분히 가져 올수 있지 않을까 싶습니다.


Successfully aliased the URL <https://alea-fngou61m6.now.sh> to the following aliases:

* https://alea.cogito.study
* https://alea.cogito-study.now.sh
* https://alea-git-development.cogito-study.now.sh


Copy of this build can be found at
https://builds.myetherwallet.com/build/7beabc3eae135193eab203bacb7b8ca9e92e2c05/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmdBbZ6dPMjv9DzWemH9MHtndacf9CsAcX2dyLfhe5bbV9
                       Virus Total analysis
                       https://www.virustotal.com/file/a60be109e6e01f6064d6da1c6eb4a174618ca664a8e37a138ebdbf7f3f9c9c42/analysis/1565676854/


This breaks our code. What if $id is not string, an array for example?
```php
$query()->where('_id', 'mod', [2, 1]);
```


불필요한 코드로 삭제하겠습니다.


Deployment failed with the following error:

~~~
You defined 1 build that did not match any source files (please ensure they are NOT defined in .nowignore):
~~~


index와 price값이 0 이상일 값일때만 추가되도록 수정하겠습니다.


✅ Device tests passed on TvOS on [Azure DevOps](https://dev.azure.com/devdiv/DevDiv/_build/index?buildId=2936630)(TvOS): [Html Report](http://xamarin-storage/jenkins/xamarin-macios/master/ed8252f12de51edc5125c9b9cb55ff64c255b1cb/2936630/device-tests/jenkins-results/tests/index.html) ✅

# Test results

# All 113 tests passed


Successfully aliased the URL <https://sindre-is-5pq4qw0h7.now.sh> to the following aliases:

* https://sindre.is
* https://sindre-is.boyum.now.sh
* https://sindre-is-git-master.boyum.now.sh


자바에 익숙해서..c++는 메소드 대문자로 시작하는군요,
이것도 수정할게요


这是真的


PR_opened/Fix_7378_StorageTankTempLimit (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-IntegrationCoverage-Debug: OK (665 of 667 tests passed, 0 test warnings)

Failures:\n

integration Test Summary
 * Passed: 665
 * Timeout: 2

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.7%25-yellow.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-68.43%25-green.png)


parameter 이름이 명확하므로 param값에 대한 정보를 comment에 추가 안해도 될 것 같습니다.


please restore this log message, or provide something similar. When using timed autosave, this would be helpful in notifying user that save is already synced to disk before closing the app.


리뷰 코멘트 남겼습니다. 참고하여 검토 부탁드립니다


Agreed. Adding an issue not to forget


private StringBuilder addCharCounter(StringBuilder stringBuilder, int repeatedCharCounter) 를 추가해서 가독성을 높였습니다.


Lgtm


오~ 예리하십니다. 뒤의 goods_price_에서도 goods를 제거하도록 할께요~


굳이 Example이 필요하지 않으므로 삭제하겠습니다.


아래와 같이 수정하겠습니다.

#include "./shopping.h"

#include <iostream>


Awesome. right?


> ch 변수가 선택된 Sorting 방법의 번호로 생각되는데,
> 조금 더 가독성 높은 변수명 사용이 필요할 것 같습니다.

selectedNum 으로 변경하였습니다.


edit


> 변수 선언 시 초기화를 병행하는 것이 더 좋을 것 같습니다.

변수 선언시 0으로 초기화 하도록 수정하였습니다.


> 만약 여는 괄호를 do와 동일한 라인에 두지 않는 스타일로 간다고 하더라도, Indentation 조정이 필요할 것 같습니다.

중괄호에 대해서 전반적으로 수정하였습니다.


> 코드 가독성 측면에서 개별 라인 출력을 별도의 println 함수로 처리하는 것이 어떨지요?

일부를 아래쪽 line으로 내렸습니다.


Comment 감사합니다.
다만, main은 금번에 수정은 (대상이 아니라서) 어려울 것 같습니다.


위 코드와 중복되어, method로 변경했습니다.
	private boolean noNeedToCompare(String src) {
		return src.length() < 2;
	}


cache-psy (energy-plus) - x86_64-Linux-Ubuntu-18.04-cppcheck: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


생성자에서 값을 할당하기 보다는 기능을 명확히 하기 위해서 별도 method로 구현했습니다.


dead code로 삭제/Comment 처리하였습니다.


This is a difference


수정하였습니다. 감사합니다.


made some changes


Successfully aliased the URL <https://peter-pshp5i06t.now.sh> to the following aliases:

* https://peter.peter-s1.now.sh
* https://peter-git-master.peter-s1.now.sh


cache-psy (energy-plus) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (9 of 9 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


Deployment failed with the following error:

~~~
You defined 1 build that did not match any source files (please ensure they are NOT defined in .nowignore):
~~~


Successfully aliased the URL <https://peter-hrd6hy03a.now.sh> to the following aliases:

* https://peter.peter-s1.now.sh
* https://peter-git-master.peter-s1.now.sh


말씀하신대로 동일한 method를 사용하도록 수정했습니다.


Thanks for the feedback, i will keep that in mind next time.

On Mon, Aug 12, 2019 at 3:03 PM Hiroyoshi NORO <notifications@github.com>
wrote:

> @winterdev001 <https://github.com/winterdev001> This is also...
>
> Not cool
>
> ,class:
>
> Cool
>
> , class:
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/winterdev001/Twitter_clone/commit/3b6f2bc9f727882eee06cbb8a44feaccba1ea0ba?email_source=notifications&email_token=ALDJZJE37BFYMPVRVXGUHNDQEFNS5A5CNFSM4ILA62X2YY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBBBVA3#commitcomment-34657307>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ALDJZJDPAY3AWIHAN2I3GZ3QEFNS5ANCNFSM4ILA62XQ>
> .
>


Поправил.


주석에 특정 type 대신에 lis로 이름 변경하겠습니다.


주석에 특정 type 대신에 list로 이름 변경하겠습니다.


`FOLDER` typo error


Hi Tapani, why does it need to disable sync for Iris driver? is there still defects? It is reported that on first enalbing Android, the UI is stuck after boot, I am not sure if that is caused by this.


needToSort로 변경하였습니다.


iterator p는 미사용되고 있어서 삭제 가능한지 검토 필요합니다.


좋은 comment입니다.  Size라는 함수를 두어, 사용하는 쪽에서 한번 체크할 수 있도록 제공하도록 할께요


말씀하신대로 addCharCounterIfNeeded(sb, charCounter) method를 동일하게 사용하도록 수정했습니다.


Successfully aliased the URL <https://yiddishe-kop-7g49mc8qz.now.sh> to the following aliases:

* https://yiddishe-kop.newgraph.now.sh
* https://yiddishe-kop-git-master.newgraph.now.sh


Ah right, that makes sense! :) I changed "rate" to "velocity" in the algorithm as velocity associates with movement (even though we're not really working in vectors right now) better in my mind.


괄호 전반적으로 수정하였습니다.


Naming의 일관성을 위해 PushElement/GetLastElement로 변경하겠습니다.


전체 project의 tab을 space 로 변경하였습니다.

기존 project에서는 변수끼리 그리고 method 들끼리 순서를 유지하였으나, comment 처럼 수정하겠습니다.


대체 하도록 수정했습니다.


I removed the note since @joakimk fixed the issue with the binwrappers. 6be276ca38a922db330caef7962bf986b0e05b36


네 일단 주석 부분은 삭제하였습니다.


array가 null인 케이스 전반적으로 수정하였습니다.


구현파일(shopping.cc)에 있는 메서드 에 붙은 주석의 내용 설명은
메서드 이름으로 유추할수 있고, Sorting 내부 로직과 같은 경우는 따로 caller 가 알 필요가 없을 내용으로 판단하여 같이 삭제 하였습니다.
추후 필요시 header파일에 설명을 작성 하도록 하겠습니다.


1. print("hello")


Line 63 should be "self.carrying.append(people)"


수정하였습니다. 감사합니다.


formatting을 한번 수행했습니다.


print("hello world)


addCharCounter method생성 및 대체하도록 수정했습니다.


어차피 한번의 비교로 내부 로직 필요한지 판별하므로 동일한 효과가 아닐까 생각합니다. 추가 논의 후 수정토록 하겠습니다.


Yes, if you look at the internals document then I'm fairly sure it uses
velocity exclusively

On Mon., Aug. 12, 2019, 23:26 Stemist, <notifications@github.com> wrote:

> Ah right, that makes sense! :) I changed "rate" to "velocity" in the
> algorithm as velocity associates with movement (even though we're not
> really working in vectors right now) better in my mind.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/pachocanadian/sole/commit/2075c10dc2d7450e9c7264461ec00ebe8750eea7?email_source=notifications&email_token=AJBVIOUM674L3JVCWMRK7QTQEJHY7A5CNFSM4ILFF44KYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBBB7WV#commitcomment-34668245>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AJBVIOXYR3R7ARDJ2MHIVIDQEJHY7ANCNFSM4ILFF44A>
> .
>


서로 다른 물건들에 대해 가격은 동일할 수 있지만, 하나의 물품에 대해 서로 다른 가격이 있는 것이 가능하지는 않을 것 같네요


불필요한 변수는 삭제하여 반영했습니다.


20번 라인의 `expTarget.push(8);` 에 의해 highest value 는 8 이 맞습니다.
혹시 제가 잘못이해한거라면 다시 코멘트 부탁드립니다.


Successfully aliased the URL <https://plantel-educativo-api-3jhwtb1kh.now.sh> to the following aliases:

* https://plantel-educativo-api.adriantobon.now.sh
* https://plantel-educativo-api-git-master.adriantobon.now.sh


Successfully aliased the URL <https://andi1984social-mzgjngmmo.now.sh> to the following aliases:

* https://andi1984.social
* https://andi1984social.andi1984.now.sh
* https://andi1984social-git-master.andi1984.now.sh


而付出的


No


Submitting improvements to website.


In pseudo code, probably.

In reality it'd get pulled out with get, manipulated and pushed back in
with set

On Mon., Aug. 12, 2019, 23:28 Stemist, <notifications@github.com> wrote:

> Line 63 should be "self.carrying.append(people)"
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/pachocanadian/sole/commit/c23f7a773f8a820a1672376ef925354f8602896f?email_source=notifications&email_token=AJBVIOXHDNAOTO5GX7HV7O3QEJIBZA5CNFSM4ILHP7ZKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBBB7XI#commitcomment-34668264>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AJBVIOVYPAAXW7DJD6MBWE3QEJIBZANCNFSM4ILHP7ZA>
> .
>


j가 가질 수 있는 최대 값이 array.length-2 로 보여 괜찮지 않을까 생각합니다.
추가 논의 후 수정토록 하겠습니다.


I think we should probably change some of these to GND ontology. E.g. https://d-nb.info/standards/elementset/gnd2012-06-30#arranger


Successfully aliased the URL <https://yiddishe-kop-jw0wnbq1r.now.sh> to the following aliases:

* https://yiddishe-kop.newgraph.now.sh
* https://yiddishe-kop-git-master.newgraph.now.sh


모든 리뷰에 대해서 업데이트를 했습니다.


Iris driver has not enabled EGL_ANDROID_native_fence_sync support so that is why we need to disable usage of it here when using Iris.


priority_queue.h 는 직접 연관있는 헤더가 아닌 라이브러리 헤더로 현재 위치를 유지하는 게 맞을 것 같습니다. 다만, 위의 헤더 파일과는 한 줄 띄우도록 변경하였습니다.


수정 요청사항 반영 완료하였습니다.


@szotp
Cześć,
czy to znaczy, że już nie trzeba dodawać FirebaseAppDelegateProxyEnabled=NO do Info.plist?


Successfully aliased the URL <https://static-build-example-react-3zfgrc9pg.now.sh> to the following aliases:

* https://static-build-example-react.moviedb.now.sh
* https://static-build-example-react-git-master.moviedb.now.sh


Perfect, was gonna suggest that!


현재 시점에서는 추후 기능 추가 가능성과 확장성을 class 선언 유지하겠습니다.


Make sure we are not spamming grass walk sounds on top of each other.


revert commit


수정하다보니....동일한 index에 대해 다른 가격을 넣는 것은 안되도록 변경하긴 하였는데, index에 대한 가격 변경이 있을 때에 대한 대응이 인터페이스 적으로는 안되어 있네요~ 나중에 stakeholder와의 협의를 통해서 그러한 요구 사항이 있는지 확인하고, 만약 있다면 뒤에 flag를 두는 방향으로 가겠습니다.

예: bool PushList(Goods object, bool force = false);


code style은 나중에 code formatter 적용해서 위에꺼 합쳐서 한방에 해결해보이는게 좋겠네요


I'd like to see "Storage Class" in this message since there is no concept of a bucket class. Eg:
`logger.Infof("Object Bucket Storage Class created successfully")`


사용자 50명 임의 선택 조회 리스트 개발
-controller 추가
-dao 메소드추가
-user mapper추가
-userListOnlyHalf.jsp 추가

*rownum 가상컬럼


@LaetitiaDaCosta il semblerait que tu n'aies pas copié le .gitignore initial


I made a new patch according to your review comment.
Thank you.


okay


Поправил.


Deployment failed with the following error:

~~~
You defined 1 build that did not match any source files (please ensure they are NOT defined in .nowignore):
~~~


nit: uppercase "Class"


okay, i thought i could use a CDN


네. 삭제하겠습니다.


Successfully aliased the URL <https://yiddishe-kop-a63yzz1in.now.sh> to the following aliases:

* https://yiddishe-kop.newgraph.now.sh
* https://yiddishe-kop-git-master.newgraph.now.sh


vse ok


fixed #5


Comment 감사합니다.
Main 코드관련 내용이라 금번에 수정은 조금 어려울 것 같습니다.


> NumberFormatException 예외처리 필요할 것 같습니다.
> 코드 내 모든 parseInt() 사용에 해당됩니다.

runtime exception에 대한 처리를 완료 하였습니다.


PrintList method명으로도 충분히 해당 기능을 설명한다고 판단됩니다.


Successfully aliased the URL <https://newhackernews-cmm50wp78.now.sh> to the following aliases:

* https://newhackernews.dvd.now.sh
* https://newhackernews-git-master.dvd.now.sh


감사합니다.
Review 해주신 내용은 'a8fb0384caf4fff531332c8546ae9d9dc219224f' commit으로 반영 하였습니다.


cache-psy (energy-plus) - x86_64-Linux-Ubuntu-18.04-gcc-7.4: OK (2461 of 2492 tests passed, 583 test warnings)

Messages:\n
 * 602 tests had: EIO diffs.
 * 574 tests had: ESO small diffs.
 * 466 tests had: Table small diffs.
 * 444 tests had: MTR small diffs.
 * 183 tests had: ZSZ small diffs.
 * 22 tests had: ESO big diffs.
 * 12 tests had: MTR big diffs.
 * 29 tests had: Table big diffs.
 * 22 tests had: ERR diffs.
 * 31 tests had: SSZ small diffs.
 * 1 test had: BND diffs.
 * 3 tests had: AUD diffs.
 * 3 tests had: RDD diffs.

Failures:\n

regression Test Summary
 * Passed: 651
 * Failed: 31

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.76%25-yellow.png)


why use f32 add for double precision element?


감사합니다.
public, private 순으로 변경하였습니다.
Review 해주신 내용은 'a8fb0384caf4fff531332c8546ae9d9dc219224f' commit으로 반영 하였습니다.


제가 잘못봤네요. 괜찮을 것 같습니다.


auto보다는 type을 명확히 해 주는게 readability가 더 좋을 것으로 판단됩니다.


@PiotrWpl please keep in mind that Github as such, including this Project is considered to be used by all and thus, I'd ask you to continue the conversation in english language.

Thank you very much :thumbsup:


Поправил.


감사합니다. 전체적인 indentation 을 수정하였습니다.
Review 해주신 내용은 'a8fb0384caf4fff531332c8546ae9d9dc219224f' commit으로 반영 하였습니다.


cannot use 1 field for alpha only?


동의합니다. 그렇게 수정하겠습니다.


shopping_test.cc 파일 중복되므로 unit_test_main.cc 파일을 삭제처리하겠습니다.


@lordgreg
Sorry ;)

My question was:
> Hi,
> Does this mean that we no longer need to add FirebaseAppDelegateProxyEnabled=NO to Info.plist?


현재 if문 내용이 한눈에 보이긴 하는데, 길어지는 경우 함수의 끝을 확인하지 않고 첫줄을 보고 이후 조건 실행여부를 알 수 있어 가독성이 향상될 것 같습니다.


작업한 내용에 대해서 결과를 찍어보려고 한 것이라
shoppingList에 대해 변경하고 print할 때를 한 묶음으로 해서 개행문자 내용을 변경하였습니다~


price, index를 enum으로 정의하여, 소팅하는 함수를 만들면 좋을거 같습니다.


source file 전체에 대해 indentation 수정하였습니다.


This is my idea
```bash
fuzzit() {
   LOCAL=""
    if [ "regression" == "${1}" ]; then
        LOCAL="--local"
    fi
    build_fuzzing_targets
    install_fuzzit
    for TARGET in "${TARGETS[@]}"
    do
        # this also take into account the new cli
        ./fuzzit create job ${LOCAL} prometheus/${TARGET} ${TARGET}
    done

}
```


Сделал помягче.


> 단일 Statement이더라도 중괄호를 사용하는 것이 더 권장될 것 같습니다.
> 아래 유사한 구문들에 공통으로 적용됩니다.

전반적으로 수정하였습니다.


Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

- @silvester747, @r1chardj0n3s were added to conda-forge. Welcome to conda-forge!
  Go to https://github.com/orgs/conda-forge/invitation see your invitation.

You should get push access to this feedstock and CI services.

Feel free to join the community [chat room](https://gitter.im/conda-forge/conda-forge.github.io).

NOTE: Please make sure to not push to the repository directly.
      Use branches in your fork for any changes and send a PR.
      More details [here](https://conda-forge.org/docs/maintainer/updating_pkgs.html#forking-and-pull-requests)


It seems like the shopping_list_ iterator is treated as a constant. (it makes compiler error)
Please refer
https://stackoverflow.com/questions/4132091/about-iterator-and-const-problem-in-c


Successfully aliased the URL <https://nextsimplestarter-nfdg1tthh.now.sh> to the following aliases:

* https://nextss.now.sh
* https://nextsimplestarter.ademola.now.sh
* https://nextsimplestarter-git-master.ademola.now.sh


For better python2 compatibility I suggest to inherit from `object`, so that it is not a old-style-class. So `class Game(object):`


Copy of this build can be found at
https://builds.myetherwallet.com/build/84a8e38015bdad777697824373f4649796080b6d/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmbpDqBEhHivKWsTDaAE6VUpRoYw9EhstuRhbMuCCfyCn9
                       Virus Total analysis
                       https://www.virustotal.com/file/3cf5a26fb3523fb8fbcc6475f97e7c4d54b4de6b798b52352e57affc53cea866/analysis/1565678981/


Hiii


Instead of `Class.method(self)` you can just write `self.method()`.


Could've made a method
```
fun playConsecutiveAudio(music: Music) {
    if (!music.isPlaying) // only music have an isPlaying method
        music.play()
}
```

Which can be called like this: `playConsecutiveAudio(walkInGrassAudio)` instead.


8 5 4 3 2 1 이 push 된 상태에서 3번의 pop 이 있으므로 highest value 는 3이 맞습니다.
제가 잘못이해 한거라면 코멘트 부탁드립니다.


Fix_7136_PeakCoil (jmarrec) - Win64-Windows-10-VisualStudio-16: OK (2451 of 2454 tests passed, 659 test warnings)

Messages:\n
 * 662 tests had: AUD diffs.
 * 4 tests had: EIO diffs.
 * 1 test had: ESO small diffs.
 * 1 test had: BND diffs.
 * 3 tests had: ESO big diffs.
 * 3 tests had: MTR big diffs.
 * 3 tests had: RDD diffs.
 * 3 tests had: Table big diffs.

Failures:\n

regression Test Summary
 * Passed: 659
 * Failed: 3

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.png)


> n 변수명 보다 가독성 있게 수정되면 좋겠습니다.

lineNum 으로 좀더 명확히 수정.


> a 변수명 보다 가독성 있게 수정되면 좋겠습니다.

array로 수정


네 주시 의견에 따라,
    if (left >= right) {
      return;
    } else {
       //기존 Block
    }
으로 수정하였습니다.


네 수정하여 다시 commit하겠습니다.


> 我对这个项目很感兴趣？怎么联系你呢？我的邮箱是[gaussdeng@163.com](mailto:gaussdeng@163.com)，欢迎及时回复。

可以联系我QQ：708900875


review 내용 중 Copyable and Movable types 에 대한 내용은 시간 관계상 수정하지 못했습니다.


하는 일이 없어서 destructor를 제거 하였습니다.


말씀하신대로 변경하였습니다.


스타일 가이드에 따라 이름 변경 하였습니다.


评论


Successfully aliased the URL <https://xblocnotas-mqsreoko2.now.sh> to the following aliases:

* https://xblocnotas.cretrok.now.sh
* https://xblocnotas-git-master.cretrok.now.sh


수정하였습니다.


마지막 라인의 *와
주석 마지막의 /*로 인해 오해를 줄수 있을것 같습니다.
수정하겠습니다.


template type에 대한 definition 추가 하였습니다.


I was still investigating also before I chat to you about it. I can't seem
to find where the issue is. When you're on the home screen, the back button
closes the app, which it's not supposed to be

On Tue, Aug 13, 2019 at 2:50 AM Parshav <notifications@github.com> wrote:

> @sduduzog <https://github.com/sduduzog> Hey, was looking around the
> project again, was there any reason for this revert ?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/sduduzog/slim-launcher/commit/ffba39af76862f0b7696c1ba3f8e213330dc4edf?email_source=notifications&email_token=ALPFTAKVOEYDRK4MJP2LI7TQEIANRA5CNFSM4ILGDZE2YY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBBB5J3#commitcomment-34665787>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ALPFTAPA6FZJUK5BJJM34CDQEIANRANCNFSM4ILGDZEQ>
> .
>


말씀하신대로 분리하여 작성하였습니다.


수정하엿습니다.


if(left >= right) {
  return;
}

//기존 block(without if() condition

이 더 좋을 것 같은데 확인 부탁드립니다.


불필요한 code block을 제거하였습니다.


Deployment failed with the following error:

~~~
You defined 1 build that did not match any source files (please ensure they are NOT defined in .nowignore):
~~~


You have to remember to create also production build file cause this won't work for github pages.


why  multiply 2 only?


IMO you should add output filename with hash to prevent caching.


Successfully aliased the URL <https://newhackernews-cmy1d9t1a.now.sh> to the following aliases:

* https://newhackernews.dvd.now.sh
* https://newhackernews-git-master.dvd.now.sh


Test case를 int와 double에 대해 수행하도록 추가하였습니다.
Trivial_int


Test case를 int와 double에 대해 수행하도록 추가하였습니다.
Trivial_double


Schon klar, aber strings, die nicht übersetzt werden, weil es nichts zu übersetzen gibt, brauchen wir doch nicht in der dt. Übersetzung.


@logaretm line 537 still says: "When using the object format in your HTML template, you need to escape all backslashes" I think that should go as well.


Class명 대문자 시작 PriorityQueue로 변경하였습니다.


네 document 를 추가하겠습니다.


I know that index.html is a default index file for webpack dev server but IMO you should still add `index: index.html` option to devServer dict.


좋은 의견이시만.. 현재 유지해도 큰 문제 없어 보입니다. 유지 해도 될까요?


검토해주신 의견 반영하겠습니다.


Empty Check반영 하겠습니다.


Commit


네 명명이 그렇긴한데, index가 단순 상품 코드인지, 유니크한 값인지 등에 대한 설명이 있으면 좋을 것 같습니다.


There are 3 changes when printing CAMI results:

1. change the `@Version:0.9.1` to `@Version:0.9.3`
2. change:
```
@Ranks:superkingdom|phylum|class|order|family|genus|species|strain
```
to
```
@Ranks:superkingdom|phylum|class|order|family|genus|species
```
as default and added `--remove_strain_from_cami_profile` to print only till `species`
3. Added possibility to remove all comments at the beginning of the cami profiles with `--remove_cami_comments`


jaja que sencillo


What about fonts and images?


현재 SortByPrice, SortByIndex 모두 selection sort를 사용하지만 향후 성능 개선을 위해서 별도의 sorting 방법을 사용할 수 있습니다.
따라서, 향후 확장성을 위해 각각 따로 구현하는게 좋을 것 같습니다.


You can leave out the brackets here!


동의합니다~
다른 review comment에 대한 수정을 진행하다가 이 점이 수정되면 TC등도 의미가 없을 것 같아 수정 멈추고 2차 수정에서 다시 정리하도록 하겠습니다.


사용하지 않는 변수 p는 제거하였습니다.
i, j는 임시 iterator이고 min은 최소값이라 의미상 괜찮은 것 같습니다. ^^;;
혹시 제안하시는 이름이 있으시면 알려주세요~


![](https://github.trello.services/images/mini-trello-icon.png) [機械学習の学習](https://trello.com/c/T9Kb3wz3/21-%E6%A9%9F%E6%A2%B0%E5%AD%A6%E7%BF%92%E3%81%AE%E5%AD%A6%E7%BF%92)


[SamSaffron posted](https://review.discourse.org/t/fix-remove-the-tmp-inventory-files-after-the-s3-uploads-check/5187/2):

I recommend leaning less on stubbing and mocking here for the testing, the only real stuff you need to mock in an integration test is going to be the HTTP request to get the inventory. Then the integration test can write it to the file system and nuke it.


> BinarySort, SelectionSort, InsertionSort의 경우에는 해당 메소드 내에서 print(a,n) 메소드를 호출하는 반면,
> InsertionSort, QuickSort의 경우 main의 switch문 내에 위치합니다.
> 일관성을 위해 공통된 방식으로 적용 필요할 것 같습니다.

method명이 잘못 된게 발견되어 small char로 시작하도록 변경하였고 전반적으로 동일 형태로 통일하여 변경 하였습니다.


Successfully aliased the URL <https://write-once-run-everywhere-otw4x36m1.now.sh> to the following aliases:

* https://write-once-run-everywhere.lucarge.now.sh
* https://write-once-run-everywhere-git-master.lucarge.now.sh


> Switch 문 닫기 전, default case에 대한 처리가 추가되어야 할 것 같습니다.

default 추가 하였습니다.


아 그러네요.


coolio


> do while 에서 while 부분은 중괄호와 같은 라인에 두는 것이 가독성이 더 좋을 것 같습니다.

수정하였습니다.


> Style 가이드 상 메소드명을 소문자로 시작하는 CamelCase 형태로 수정하는 것이 필요할 것 같습니다.
> 아래 메소드들 전체에 해당하는 내용입니다.

반영 되었습니다.


Yes, a GTE :-)
This value is a little weird, I don't know what it represents exactly.

No acceleration = 1200
Regenerative braking = 0 to 1200
Accelerating = 1200 to ~5000


When you open a file, you should close it when you are ready with it (e.g. via `f.close()`).
Otherwise the file is opened the whole program run time and consumes memory and unnecessarily opened file descriptors. There is in python a nice syntax to let it be closed automatically: You can use the context manager of `open()` which can be invoked via the following pattern:
```python
with open(filename) as fd:
    fd.write(...) # do something with the file
# here the file is closed then
```


I'm trying to create a path which is equal to the deployment name, so that each deployment can have its own path. Not sure how generally applicable that is.


❌ [Build was (probably) aborted](https://jenkins.internalx.com/job/macios/job/xcode11/203/display/redirect)

🔥 [Jenkins job](https://jenkins.internalx.com/job/macios/job/xcode11/203/display/redirect) (on internal Jenkins) failed in stage(s) 'Running XM tests on '10.15', Running XM tests on '10.15'' 🔥

✅ [Build succeeded](https://jenkins.internalx.com/job/macios/job/xcode11/203//console)
✅ Packages: [xamarin.ios-12.99.2.66.pkg](https://bosstoragemirror.blob.core.windows.net/wrench/jenkins/xcode11/4d6a9f505eb276cd797e667200df6018efc5f911/203/package/xamarin.ios-12.99.2.66.pkg) [xamarin.mac-5.99.2.66.pkg](https://bosstoragemirror.blob.core.windows.net/wrench/jenkins/xcode11/4d6a9f505eb276cd797e667200df6018efc5f911/203/package/xamarin.mac-5.99.2.66.pkg)
✅ [API Diff (from stable)](http://xamarin-storage/jenkins/xamarin-macios/xcode11/4d6a9f505eb276cd797e667200df6018efc5f911/203/jenkins-results/api-diff/index.html)
ℹ [API Diff (from PR only)](http://xamarin-storage/jenkins/xamarin-macios/xcode11/4d6a9f505eb276cd797e667200df6018efc5f911/203/jenkins-results/apicomparison/api-diff.html) (please review changes)
ℹ [Generator Diff](http://xamarin-storage/jenkins/xamarin-macios/xcode11/4d6a9f505eb276cd797e667200df6018efc5f911/203/jenkins-results/generator-diff/index.html) (please review changes)
🔥 [Xamarin.Mac tests on 10.15 failed: Xamarin.Mac tests on macOS 10.15 failed (introspection)](https://jenkins.internalx.com/job/macios/job/xcode11/203/display/redirect) 🔥
🔥 [Test run failed](http://xamarin-storage/jenkins/xamarin-macios/xcode11/4d6a9f505eb276cd797e667200df6018efc5f911/203/jenkins-results/tests/index.html) 🔥

# Test results

<details>
<summary>1 tests failed, 233 tests passed.</summary>

## Failed tests

 * monotouch-test/watchOS 32-bits - simulator/Debug: Crashed
</details>


LGTM
고생하셨습니다.


Change has been made based on your comment


@SimpleBinary how do you plan on interpreting a given sentence to keywords that the computer can "understand"?


please use a enum class that we discussed earlier?


There is a way without calling `str()` and using `+` called `string interpolation`. Can you use that instead?


> Argument명들(a,n)을 가독성 있게 바꾸는 게 더 좋을 것 같습니다.
> 아래 메소드들 전체에 해당되는 내용입니다.

전반적으로 수정하였습니다.


Siemka |Pracuję teraz nad tym gdy na planszy dojedziemy do np. x = 0 to wtedy za nastepnym ruchem małpka przeskakuje do końca rzedu wymyśliłem na to sposób że gdy x = 0 to w naszym programie jak chcemy się ruszyć to zmienia się wartość do -1 to ja chce do tego -1 + 1 co wtedy da nam zero zapetle to i poprostu postaci nie bedzie mogła się ruszyć tak samo z 20 gdy bedzie 21 - 1 to bedzie 20


> Google style 가이드에 따라
> class 내 멤버 메소드 사이에는 blank line을 두는 것이 가독성에 더 좋을 것 같습니다.
> 아래에 이어지는 메소드들에도 동이하게 적용되는 코멘트입니다.

수정하였습니다.


PR_opened/Fix_7151_GeneratorPVAvailSched (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-IntegrationCoverage-Debug: OK (666 of 667 tests passed, 0 test warnings)

Failures:\n

integration Test Summary
 * Passed: 666
 * Timeout: 1

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.85%25-yellow.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-68.45%25-green.png)


> 79~81 라인에 Indent 조정 필요해 보입니다.

전반적으로 수정완료


> Submit을 위한 Code에서는 Debugging용 코드는 삭제하는 것이 좋을 것 같습니다.
> 63번 라인의 Comment도 동일합니다.

수정완료


When I press `Ctrl-C` anywhere in the application, a traceback is printed:
```
Errate die Zahl! Versuch: 1, Dein Tipp: ^CTraceback (most recent call last):
  File "funnygameV3_ohneGUI.py", line 55, in <module>
    Game.start_game(Game)
  File "funnygameV3_ohneGUI.py", line 15, in start_game
    Game.get_input(self)
  File "funnygameV3_ohneGUI.py", line 34, in get_input
    Game.check_input_number(self)
  File "funnygameV3_ohneGUI.py", line 25, in check_input_number
    Game.get_input(self)
  File "funnygameV3_ohneGUI.py", line 30, in get_input
    self.inpt = int(input("Errate die Zahl! Versuch: "+str(self.counter)+", Dein Tipp: "))
KeyboardInterrupt
```
Can you instead print a nice message, that one ended the game?


4 spaces 띄어쓰기가 되어있습니다. (기준: 2 spaces)


좋은 의견 감사드립니다. 함수 가독성을 위해 유지 하겠습니다.
유사 pattern 함수 추가시 통합 검토하겠습니다.


Successfully aliased the URL <https://start-page-i6qolgf5f.now.sh> to the following aliases:

* https://avdemeisen.now.sh
* https://start-page.devinedanielwork.now.sh
* https://start-page-git-master.devinedanielwork.now.sh


반영하겠습니다.


hello


Successfully aliased the URL <https://agrobot-3jo1n0tih.now.sh> to the following aliases:

* https://agrobot.martinsabiodun94.now.sh
* https://agrobot-git-master.martinsabiodun94.now.sh


Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

- @agcopenhaver was added to this feedstock maintenance team.

You should get push access to this feedstock and CI services.

Feel free to join the community [chat room](https://gitter.im/conda-forge/conda-forge.github.io).

NOTE: Please make sure to not push to the repository directly.
      Use branches in your fork for any changes and send a PR.
      More details [here](https://conda-forge.org/docs/maintainer/updating_pkgs.html#forking-and-pull-requests)


test를 단위기능으로 더 분할하면 좋을 것 같습니다.


实验品，玩玩看


> MergeSort 메소드만을 위한 메소드로서 private 멤버로 선언하는 것이 더 좋지 않을지 고려 부탁드립니다.

전반적으로 권한을 최소화 open하도록 수정하였습니다.


This not required


> 불필요한 Blank line 정리되면 더 좋을 것 같습니다.
> 115번도 동일합니다.

정리하였습니다.


제가 잘못 이해했네요. 정상적으로 작성되어 있습니다.


ZEIT Now cannot deploy this project to production due to following domain related issues:

 * `snuggsi.com`(for alias `snuggsi.com`) is not found inside your account. [Add it](https://zeit.co/dashboard/domains?action=add&domain=snuggsi.com).


> 155~157 라인 Indent 조정 필요할 것 같습니다.

수정완료


> Style Guide에 따라 if/else 구문에서는 두 블록 모두 중괄호를 이용하는 것이 좋을 것 같습니다.

수정완료


TEST 함수 반영하겠습니다.


> QuickSort만을 위한 메소드로서 private 멤버로 두는 것이 어떨지 고려 부탁드립니다.

수정완료


> 173~176 라인의 Indent 조정 필요해 보입니다.
> 또한 172 라인의 주석은 해당 코드로 쉽게 파악 가능하므로 굳이 필요해 보이지 않습니다.

수정완료


LGTM ;)


> 179~182 라인 Indent 조정 필요해 보입니다.

수정완료


> 단일 statement만 포함되어 있지만, 가이드 상 for 문 블럭 가독성을 위해 중괄호를 추가하는 것이 좋을 것 같습니다.

수정완료


> 코드 내 모든 Indent가 Tab입니다. Whitespace로 변경 고려 부탁드립니다.

전반적으로 수정완료


cache-psy (energy-plus) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-UnitTestsCoverage-Debug: OK (1126 of 1126 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-42.39%25-green.png)


Successfully aliased the URL <https://weather-forecast-demo-app-6bcrka9tr.now.sh> to the following aliases:

* https://weather-forecast-demo-app.now.sh
* https://weather-forecast-demo-app.robhowell.now.sh
* https://weather-forecast-demo-app-git-master.robhowell.now.sh


Looks Good To Me


Yes, that makes sense. Thanks 🙂


The solution based on SelectedIndex turned out to be ugly. And this file now causes a conflict, making it impossible to automatically merge the pull request.


I wasn't able to retrieve PDD puzzles from the code base and submit them to GitHub. If you think that it's a bug on our side, please submit it to [yegor256/0pdd](https://github.com/yegor256/0pdd/issues):

> set -x && set -e && set -o pipefail && cd /tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area && pdd -v -f /tmp/20190813-5861-1ngfsro [1]: bash: warning: setlocale: LC_ALL: cannot change locale (UTF-8) + set -e + set -o pipefail + cd /tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area +...

Please, copy and paste this stack trace to GitHub:

```
UserError
set -x && set -e && set -o pipefail && cd /tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area && pdd -v -f /tmp/20190813-5861-1ngfsro [1]:
bash: warning: setlocale: LC_ALL: cannot change locale (UTF-8)
+ set -e
+ set -o pipefail
+ cd /tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area
+ pdd -v -f /tmp/20190813-5861-1ngfsro

My version is 0.20.5
Ruby version is 2.6.0 at x86_64-linux
Reading /tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area
87 file(s) found, 138 excluded
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/gradle/wrapper/gradle-wrapper.jar is a binary file (54329 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/gradle/wrapper/gradle-wrapper.jar is a binary file (54329 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/release-key.jks is a binary file (2258 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/mipmap-hdpi/ic_launcher.png is a binary file (2963 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/mipmap-hdpi/ic_launcher_round.png is a binary file (4905 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/mipmap-xxhdpi/ic_launcher.png is a binary file (6387 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/mipmap-xxhdpi/ic_launcher_round.png is a binary file (10413 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/mipmap-mdpi/ic_launcher.png is a binary file (2060 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/mipmap-mdpi/ic_launcher_round.png is a binary file (2783 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/mipmap-xhdpi/ic_launcher.png is a binary file (4490 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/mipmap-xhdpi/ic_launcher_round.png is a binary file (6895 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/drawable/doctor_image.jpg is a binary file (12959 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/drawable/research_image_2.jpg is a binary file (30704 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/drawable/research_image_3.jpg is a binary file (14664 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/drawable/researches_image_2.jpg is a binary file (13496 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/drawable/change_photo.png is a binary file (2651 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/drawable/research_image_1.jpg is a binary file (13483 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/drawable/image.jpg is a binary file (158122 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/mipmap-xxxhdpi/ic_launcher.png is a binary file (9128 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/mipmap-xxxhdpi/ic_launcher_round.png is a binary file (15132 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/drawable-v24/collapse_image.png is a binary file (588 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/drawable-v24/eagle.png is a binary file (106848 bytes)
/tmp/0pdd20190813-4-1ky4a19/arri1/officer-personal-area/Source/app/src/main/res/drawable-v24/expand.png is a binary file (655 bytes)
Reading .gitignore...
Reading Source/gradle/wrapper/gradle-wrapper.properties...
Reading Source/.gitignore...
Reading Source/gradlew...
Reading Source/app/proguard-rules.pro...
Reading Source/app/gradle/wrapper/gradle-wrapper.properties...
Reading Source/app/.gitignore...
Reading Source/app/gradlew...
Reading Source/app/gradlew.bat...
Reading Source/app/google-services.json...
Reading Source/app/local.properties...
Reading Source/app/src/main/AndroidManifest.xml...
Reading Source/app/src/main/res/xml/network_security_config.xml...
Reading Source/app/src/main/res/values/strings.xml...
Reading Source/app/src/main/res/values/styles.xml...
Reading Source/app/src/main/res/values/colors.xml...
Reading Source/app/src/main/res/layout/fragment_researches_item.xml...
Reading Source/app/src/main/res/layout/activity_login.xml...
Reading Source/app/src/main/res/layout/content_main.xml...
Reading Source/app/src/main/res/layout/activity_main.xml...
Reading Source/app/src/main/res/layout/fragment_doctor_item.xml...
Reading Source/app/src/main/res/layout/activity_splach.xml...
Reading Source/app/src/main/res/layout/doctors_fragment_layout.xml...
Reading Source/app/src/main/res/layout/my_profile_fragment_layout.xml...
Reading Source/app/src/main/res/layout/researches_fragment_layout.xml...
Reading Source/app/src/main/res/drawable/ic_dashboard_black_24dp.xml...
Reading Source/app/src/main/res/drawable/ic_notifications_black_24dp.xml...
Reading Source/app/src/main/res/drawable/ic_home_black_24dp.xml...
Reading Source/app/src/main/res/drawable/ic_launcher_background.xml...
Reading Source/app/src/main/res/drawable/horizontal_progress_bar.xml...
Reading Source/app/src/main/res/drawable/round_shape_btn.xml...
Reading Source/app/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml...
Reading Source/app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml...
Reading Source/app/src/main/res/drawable-v24/ic_launcher_foreground.xml...
Reading Source/app/src/main/res/menu/bottom_nav_menu.xml...
Reading Source/app/src/main/java/com/victorx64/officerpersonalarea/apapters/MyResearchesRecyclerViewAdapter.kt...
Reading Source/app/src/main/java/com/victorx64/officerpersonalarea/apapters/PageAdapter.kt...
Reading Source/app/src/main/java/com/victorx64/officerpersonalarea/apapters/MyDoctorRecyclerViewAdapter.kt...
Reading Source/app/src/main/java/com/victorx64/officerpersonalarea/activities/LoginActivity.kt...
Puzzle 13-c84ea7aa 0/DEV at Source/app/src/main/java/com/victorx64/officerpersonalarea/activities/LoginActivity.kt
Reading Source/app/src/main/java/com/victorx64/officerpersonalarea/activities/SplashActivity.kt...
Reading Source/app/src/main/java/com/victorx64/officerpersonalarea/activities/MainActivity.kt...
Reading Source/app/src/main/java/com/victorx64/officerpersonalarea/dummyContents/ResearchesContent.kt...
Reading Source/app/src/main/java/com/victorx64/officerpersonalarea/dummyContents/DoctorsContent.kt...
Reading Source/app/src/main/java/com/victorx64/officerpersonalarea/fragments/ProfileFragment.kt...
ERROR: Source/app/src/main/java/com/victorx64/officerpersonalarea/fragments/ProfileFragment.kt; puzzle at line #22; TODO found, but puzzle can't be parsed, most probably because TODO is not followed by a puzzle marker, as this page explains: https://github.com/yegor256/pdd#how-to-format
If you can't understand the cause of this issue or you don't know how to fix it, please submit a GitHub issue, we will try to help you: https://github.com/yegor256/pdd/issues. This tool is still in its beta version and we will appreciate your feedback. Here is where you can find more documentation: https://github.com/yegor256/pdd/blob/master/README.md.
Exit code is 1

/app/objects/git_repo.rb:66:in `rescue in block in xml'
/app/objects/git_repo.rb:63:in `block in xml'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/tempfile.rb:295:in `open'
/app/objects/git_repo.rb:62:in `xml'
/app/objects/puzzles.rb:36:in `deploy'
/app/objects/job.rb:38:in `proceed'
/app/objects/job_starred.rb:33:in `proceed'
/app/objects/job_recorded.rb:32:in `proceed'
/app/objects/job_emailed.rb:35:in `proceed'
/app/objects/job_commiterrors.rb:36:in `proceed'
/app/objects/job_detached.rb:48:in `exclusive'
/app/objects/job_detached.rb:36:in `block in proceed'
/app/objects/job_detached.rb:36:in `fork'
/app/objects/job_detached.rb:36:in `proceed'
/app/0pdd.rb:358:in `block in <top (required)>'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1635:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1635:in `block in compile!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:992:in `block (3 levels) in route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1011:in `route_eval'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:992:in `block (2 levels) in route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1040:in `block in process_route'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1038:in `catch'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1038:in `process_route'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:990:in `block in route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:989:in `each'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:989:in `route!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1097:in `block in dispatch!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `block in invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `catch'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1094:in `dispatch!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:924:in `block in call!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `block in invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `catch'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1076:in `invoke'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:924:in `call!'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:913:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/xss_header.rb:18:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/path_traversal.rb:16:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/json_csrf.rb:26:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/base.rb:50:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/base.rb:50:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-protection-2.0.4/lib/rack/protection/frame_options.rb:31:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/logger.rb:15:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/common_logger.rb:33:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:231:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:224:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/head.rb:12:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/method_override.rb:22:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:194:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1957:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1502:in `block in call'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1729:in `synchronize'
/app/vendor/bundle/ruby/2.6.0/gems/sinatra-2.0.4/lib/sinatra/base.rb:1502:in `call'
/app/vendor/bundle/ruby/2.6.0/gems/rack-2.0.6/lib/rack/handler/webrick.rb:86:in `service'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/webrick/httpserver.rb:140:in `service'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/webrick/httpserver.rb:96:in `run'
/app/vendor/ruby-2.6.0/lib/ruby/2.6.0/webrick/server.rb:307:in `block in start_thread'
```


LGTM
 단, 추후 priority_queue.cc 에서 제공하는 MyPriorityQueue 가 추가 작업이 필요 하다는 것으로 이해하겠습니다.
  --> 만약 현재 구현된 기준이 맞다면 MyPriorityQueue Class는 따로 하는 역할이 없고 std::priority_queue 에 대한 연결 Class로만 보입니다.


coding style에 있는 것 처럼 아래와 같이 #endif 에도 주석으로 추가해주면 좋을 것 같습니다.
#ifndef PRIORITY_QUEUE_H_
#define PRIORITY_QUEUE_H_
...
#endif // PRIORITY_QUEUE_H_


Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

- @roederja2 was added to this feedstock maintenance team.

You should get push access to this feedstock and CI services.

Feel free to join the community [chat room](https://gitter.im/conda-forge/conda-forge.github.io).

NOTE: Please make sure to not push to the repository directly.
      Use branches in your fork for any changes and send a PR.
      More details [here](https://conda-forge.org/docs/maintainer/updating_pkgs.html#forking-and-pull-requests)


I'm looking through the code and not seeing how "have played at least 30 rated games in a given rating" is required; but also don't see a need to require it as long as RD < 80.


oh! nice work!


Yes that is my idea too, I want to include the ontology as a prefix


the modules are no longer compatible with darkbot so I no longer update them and they can not be downloaded


select g.goods_name from ecs_category c,ecs_goods g
		where c.cat_id=g.cat_id
		and c.cat_name='3G手机' or c.cat_name='服装';


Increase the readability of the code


저도 잘 모르지만 참고삼아 남깁니다.
Goods GetLastElement() const; 와 같이 const를 뒤로 빼는 것이 가능한 것 같습니다.


Successfully aliased the URL <https://ifgladleegithubio-j2w21o09g.now.sh> to the following aliases:

* https://ifgladleegithubio.lorenzoli.now.sh
* https://ifgladleegithubio-git-master.lorenzoli.now.sh


LGTM ;)


select distinct c.cat_name from ecs_category c,ecs_goods g
		where c.cat_id=g.cat_id
		and g.shop_price between 2000 and 3000;


네, 확인 감사합니다


네, 제가 단순히 코드 기반으로만 확인하고 요구사항에 대해서는 고려가 부족했던 것 같습니다. 요구 사항이 없다면 추가 커멘트는 없습니다.


수정하였습니다


Yeahh


Nooo


Cyril can fix the problem that we cannot add anymore protocols :)?
Tx


Copy of this build can be found at
https://builds.myetherwallet.com/build/e4783580c174529fb0cae31df64e5381e5454b2d/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmcwE5nLwk4TVfEXhdZqESrwo6K69hCBxGHKNjchtagfsq
                       Virus Total analysis
                       https://www.virustotal.com/file/8f549458026c811e45da342744e6ce3683620396359d74e3586c630c1c5ad8b6/analysis/1565680652/


일관성을 위해 { 전에 한칸 띄우는 것은 어떤가요?


![](https://github.trello.services/images/mini-trello-icon.png) [Travis integration on github](https://trello.com/c/0gtnrFXt/6-travis-integration-on-github)


PR_opened/Fix_7315_BuildDocs (jmarrec) - x86_64-Linux-Ubuntu-18.04-cppcheck: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


We don't, envoy exists only as a docker image which is being downloaded on `docker build`.


Successfully aliased the URL <https://agrobot-8i9iaqu93.now.sh> to the following aliases:

* https://agrobot.martinsabiodun94.now.sh
* https://agrobot-git-master.martinsabiodun94.now.sh


TAB 문자 삭제 필요합니다.
indent는 space 2로 설정 필요합니다.


네 사실 현재로는 index는 상품 번호로 추측(?)이 됩니다.
아래 commit으로 index --> serialNumber로 변경 하였습니다.
https://github.com/depari/code_review/commit/3e854cdc7a5c321e94d19b4da57fdb4431dee36d


Thanks, fixed now!


Successfully aliased the URL <https://xblocnotas-1ab9222uz.now.sh> to the following aliases:

* https://xblocnotas.cretrok.now.sh
* https://xblocnotas-git-master.cretrok.now.sh


NASCA로 암호화 되어 있어서 확인이 안 되네요. 다시 올려 주세요~


PR_opened/Fix_7315_BuildDocs (jmarrec) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (9 of 9 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


LGTM. 고생하셨습니다.


변수 선언부와 for문 사이에 공백 한줄 넣으면 가독성이 더 좋아 질 수 있을것 같습니다.


[Your benchmark job](https://github.com/JuliaLang/julia/commit/6527de0c0fe8120531df9b439fd89e9480e3a652#commitcomment-34666689) has completed - possible performance regressions were detected. A full report can be found [here](https://github.com/JuliaCI/BaseBenchmarkReports/blob/5f38d99c8aa43a8182cd83de2a319be19b9fb1ea/daily_2019_08_13/report.md). cc @ararslan


Compiled in Release mode : Segfaults immediately
~/GOMC/RE_VALIDATION/GEMC_NVT/pure_fluid$  ~/GOMC/bin/GOMC_CPU_GEMC +p1 equilibration_confs.txt

Compiled in Debug mode : Doesn't Segfault

~/GOMC/RE_VALIDATION/GEMC_NVT/pure_fluid$  ~/GOMC/bin/GOMC_CPU_GEMC +p1 equilibration_confs.txt


@JuliaRegistrator register


Registration pull request created: [JuliaRegistries/General/2655](https://github.com/JuliaRegistries/General/pull/2655)

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if [Julia TagBot](https://github.com/apps/julia-tagbot) is installed, or can be done manually through the github interface, or via:
```
git tag -a v0.1.1 -m "<description of version>" 62d2cfb961eba74a4242dc7e25a37123807f2458
git push origin v0.1.1
```
Also, note the warning: This looks like a new registration that registers version 0.1.1.
Ideally, you should register an initial release with 0.0.1, 0.1.0 or 1.0.0 version numbers
This can be safely ignored. However, if you want to fix this you can do so. Call register() again after making the fix. This will update the Pull request.


even simpler.

https://github.com/fuzzitdev/example-go/blob/master/fuzzit.sh


1. 정확한 출처는 확인이 필요하나, 일반적인 구현이 STL 보다 빠르긴 힘들것 같습니다. 성능을 위한다면 STL을 사용하는게 좋을것 같습니다.
2. 향후 확장성을 측면에서도 제가 제안 드린 방법이 좋을것 같습니다. 현재의 코드처럼 확장을 하게 되면 중복된 코드가 많이 산재되게 되고, 조금의 수정이 필요할때 여기저기 수정이 되어야 하므로
https://refactoring.guru/smells/shotgun-surgery 와 같은 문제가 발생할 것입니다.


@szotp
Great! Thanks for answer (and of course for this project! - it helped me a lot).

I wasn't sure about this method swizzling, because there is still an information about disabling it in the Readme.md file.

Cheers!


Successfully aliased the URL <https://xkcd-why-5pn8zopv2.now.sh> to the following aliases:

* https://xkcd-why.now.sh
* https://xkcd-why.kidonng.now.sh
* https://xkcd-why-git-master.kidonng.now.sh


변수 선언부 대비 공백 line 추가시 가독성이 더 높아 질수 있을것 같습니다.


p가 어디서 쓰였는지 찾지 못해서 모호했었는데 사용하지 않던 코드군요.
임시 interator에 대해서는 말씀하신데로 현상태 유지하는게 좋겠습니다.

수고하셨습니다!


why multiply 2


I agree, that it is ugly (but don't understand, why it makes conflict :( ). So I will revert it to use SelectedTag (and will not fix this, as this is out of my knowledge)


제가 전달을 잘 못드렸나봅니다. 뒤에 함수 호출 예제에 "()"이 빠진것을 말씀드렸었습니다. :)
//    std::cout << test.GetIndex() << " - " << test.GetPrice() << endl;


if 나 for문 등에는 기본적으로 중괄호로 처리 하면 실수 확률이 줄어 들고 가독성이 더 높아 질수 있습니다. 아래와 같이 수정 검토 부탁드립니다.

if (noNeedToCompare(src)) {
  return src;
}


수정하겠습니다.


말씀하신 부분에 동의 합니다. 소문자 queue로 수정했습니다.


deadcode로 comment 처리하였습니다.


debugging 용 주석은 삭제 부탁드립니다.


값의 유효성 체크가 추가되었으므로, 음수값에 대한 test case가 필요해보입니다.
또한 &&를 사용하였는데, 이건 의도하신건가요??

만약 index가 음수이고 price 가 양수일경우 default 값을 사용할순 없을가요?? (다른 Goods 의 index와 겹칠수도 있겠네요..)


Here's the change I had to make to get the output to match https://github.com/adobe-type-tools/afdko/pull/900/commits/39dcb27a1428bb45569e9baae4357b957dad15ae


class member 변수에 _ 추가해야 하는 것을 놓치고 있었습니다. 말씀주신데로 변수명을 수정하였습니다.


Interesting implementation. In general, you can use. Just try to keep the existing text without loss, excluding the necessary corrections of the outdated.
1. In which tool did you edit the images and draw arrows and ovals?
2. What font and size was used for the numbers?
3. A way to select colors for markers?
4. As for the visual design, you need to formalize and draw up a plan instruction, so that if I make similar pictures, everything should coincide in the same style.
5. The separator in the names of image files should be replaced with an underscore.

I approve. Let's try :)
You are well done. And I reprimanded myself - I always forget about updating help :(


말씀 주신데로 exp_priority_queue를 수정했습니다.


기본적으로 single statement라 하더라도 중괄호로 묶으면 가독성이 더 높아질수 있습니다. 검토 부탁드립니다.

if (noNeedToCompare(src)) {
  return src;
}


> there is still an information about disabling it in the Readme.md file.
It shouldn't be there, I removed it. Thanks for feedback.


BranchOnPermissions is under it so I'm not sure we want to compare injectAuthorized with it.


변수 선언부 대비 한줄 띄우면 가독성이 더 높아 질수 있습니다. 검토 부탁드립니다.


@duracell80: A comment on an old commit like this is likely to get overlooked (pretend I am not commenting on it 🙈) and is hard to evaluate when divorced from context. Instead, I'd suggest discussing this in an issue (or linking to it from one) — were you thinking about this in the context of the discussion happening on #1298?


Why does GigTypeMeta hava a name? The name of an argument should already be present in the ArgMap entry and is not in any way type metainfo.


LGTM ^^


if (shopping_list_.size() != ) 여기에 0이 빠진게 아닌가 합니다.


수정하신 내용들 LGTM 입니다. :)


I'd make these two function-style macros, but you do you.


Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

- @akarve was added to conda-forge. Welcome to conda-forge!
  Go to https://github.com/orgs/conda-forge/invitation see your invitation.

- @knaaptime was added to this feedstock maintenance team.

You should get push access to this feedstock and CI services.

Feel free to join the community [chat room](https://gitter.im/conda-forge/conda-forge.github.io).

NOTE: Please make sure to not push to the repository directly.
      Use branches in your fork for any changes and send a PR.
      More details [here](https://conda-forge.org/docs/maintainer/updating_pkgs.html#forking-and-pull-requests)


@primenumbers1 Sorry, I don't really play GTA anymore and I have no time to work on it 😞


You could also use `document.getElementById('filename').textContent` which is already the filename without extension.


Successfully aliased the URL <https://node-rockets-lzurqql4r.now.sh> to the following aliases:

* https://node-rockets.com
* https://www.node-rockets.com
* https://node-rockets.tvalletta.now.sh
* https://node-rockets-git-master.tvalletta.now.sh