That's right, a pull request allows for discussion & further modification before a change is accepted (or not) into the master branch.


#**环境依赖**: clion 2019.1
#**项目语言**: c++
#**运行方式**
--只需要将main.cpp文件选择用clion打开后编译运行即可
#**操作说明**
1. 编译运行成功后，进入主界面，显示当前系统月的日历
2. 输入年、月，直接跳转
3. 输入"++++"进入日期推算
4.
2019.7.23-支持显示1900-2050年农历及所有年份星座-更新了干支纪年法输出
2019.7.25-新增了二十四节气的输出
2019.8.20-新增了备忘系统
2019.8.25-新增了日期推算
2019.8.27更新了农历阳历重大节日判别
联系邮箱: yuanyanghao2022@163.com


Let's start


I am happy with this change, I did manage to fix it in 97ecbffca08ac22bcd0193be24031c8443f67409, although this one makes things a bit clearer.


Justin, Ideally we should change the limit in sonic-port.yang model so that such config is rejected in REST, GNMI as well.

                        leaf mtu{
                                type uint32 {
range "64..9216";
}
                        }


> it's a dep of a dep (of a dep).

```
% port rdeps libshout2
The following ports are dependencies of libshout2 @2.4.3_0:
  pkgconfig
    libiconv
      gperf
  libvorbis
    libogg
      xz
        gettext
          ncurses
  speex
  libtheora
```

I guess it must be used opportunistically, which means another rev bump is needed after adding the dep (sigh).


1-10*

No lab tenho uma resposta pra questao 1, mas incompleta (apenas pontos de discussao)


Build version: __`0.10.0-renovate/node-8.16.1044`__ :crossed_fingers: [`renovate/node-8.16`](https://github.com/streamich/ci-scripts/tree/renovate/node-8.16) on [*CircleCI*](https://circleci.com/gh/streamich/ci-scripts/1044) :tada:


Build version: __`0.10.0-renovate/node-8.16.1616`__ :crossed_fingers: [`renovate/node-8.16`](https://github.com/streamich/ci-scripts/tree/renovate/node-8.16) on [*Travis*](https://travis-ci.org/streamich/ci-scripts/builds/582957212) :tada:


Either this is missing a ``junit_xml_output = False`` default value
or ``HarosVizRunner``'s call to ``HarosRunner.__init__(self, haros_dir, config_path, log, run_from_source)``  (line 853) requires a ``junit_xml_output = False`` parameter.
As it is now, HarosVizRunner doesn't work because the number of parameters don't match.


Ok, sry I dont now either why it's not working, well at least mouse movements and the other buttons work fine now.. ^^"


#13 Fixed syntax error in `if` statement causing false negatives.


Successfully aliased the URL <https://out-dudowptm3.now.sh> to the following aliases:

* https://out.mfioca.now.sh
* https://out-git-master.mfioca.now.sh


Successfully aliased the URL <https://react-starter-h8apu87nw.now.sh> to the following aliases:

* https://react-starter.lukeandersen.now.sh
* https://react-starter-git-master.lukeandersen.now.sh


var left = [MAX_PAGE];

これはMAX_PAGEを入れる必要はないですね！

var left = [];

として、まず空の配列を作ってあげればいいと思います。


Like it's on the commit title, to make it simpler.


you are defining what it is, this is a comment section.. you could put anything pertaining to the code regardless of the redundancy.


このfor文の中の変数はiにしちゃってfor文の中でのみ使うようにしたほうがわかりやすいかも！


what is this bug about?


ここで始めてpageという変数を宣言してあげましょう！
var page = 0;
ですね。


cccc


<details>

<summary>Submitting the task to Taskcluster failed. Details</summary>

end of the stream or a document separator is expected at line 12, column 1:
    -
    ^

</details>


Successfully aliased the URL <https://vilnius-ca3so0cob.now.sh> to the following aliases:

* https://mansurov.me
* https://vilnius.mjolnir.now.sh
* https://vilnius-git-master.mjolnir.now.sh


Successfully aliased the URL <https://fieri-bot-58axpy3t9.now.sh> to the following aliases:

* https://fieri-bot.hodorswit.now.sh
* https://fieri-bot-git-master.hodorswit.now.sh


Added project_scope file


[bot] 自动构建 [auto-dragalia-4243814e.zip](https://circleci.com/gh/NateScarlet/auto-dragalia/569/artifacts/0/home/circleci/project/artifacts/auto-dragalia-4243814e.zip)


Build version: __`3.2.0-master.750`__ :crossed_fingers: [`master`](https://github.com/streamich/md-mdast/tree/master) on [*CircleCI*](https://circleci.com/gh/streamich/md-mdast/750) :tada:


Successfully aliased the URL <https://fieri-bot-ccooyiox4.now.sh> to the following aliases:

* https://fieri-bot.hodorswit.now.sh
* https://fieri-bot-git-master.hodorswit.now.sh


Oooof isn't this a bit too much? We could conflate the upload disabling into pypi=no.

pypy=no - no badge, upload disabled metadata
pypy=yes - badge, upload works

Doesn't that satisfy all usecases?


Successfully aliased the URL <https://wedding-i1dsl74zw.now.sh> to the following aliases:

* https://dylanandspencer.wedding
* https://wedding.spencer.now.sh
* https://wedding-git-master.spencer.now.sh


You are pushing commits at a very fast pace (accross the whole organization).
Due to that, we cannot deploy the commit 3caccf3b5c12575f3871c0a9884a7f67a7705ad1.

You can try again later or [upgrade](https://zeit.co/account/plan) your plan.


<details>

<summary>Submitting the task to Taskcluster failed. Details</summary>

InterpreterError at template.tasks[0]: unknown context value push

</details>


I need it for some other stuff

On Mon 9 Sep, 2019, 9:00 PM Ritik kumar, <notifications@github.com> wrote:

> Maybe, use Github gist for things like these 🤔
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/rishabjn/Valid-Sudoko/commit/b68092d2031405987892b5bc69e31377c19a3199?email_source=notifications&email_token=AIYCDB4TSPFDEQ6YIVJQV3LQIZTUPA5CNFSM4IU4XXI2YY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBBMKNE#commitcomment-35006884>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AIYCDB6GFDSEAXWFJVB3S7DQIZTUPANCNFSM4IU4XXIQ>
> .
>


Successfully aliased the URL <https://hex22org-m8u9dk7qq.now.sh> to the following aliases:

* https://tom.org.nz
* https://hex22org.tomupom.now.sh
* https://hex22org-git-master.tomupom.now.sh


added new echo test


queryset is required for ModelMultipleChoiceField (by django docks: https://docs.djangoproject.com/en/2.2/ref/forms/fields/#fields-which-handle-relationships) and should be defined in parameters or in __init__ method


Remove bin folder from tracking..
Add /bin in .gitignore


[R/check_pir_out.R:17:1:](https://github.com/richelbilderbeek/pirouette/blob/2c12440b3a204340e3e5b200b6aa09e8bb86f4a9/R/check_pir_out.R#L17) *style:* **functions should have cyclomatic complexity of less than 15, this has 20.**
```r
check_pir_out <- function(
^
```
[R/create_alignment_impl.R:34:1:](https://github.com/richelbilderbeek/pirouette/blob/2c12440b3a204340e3e5b200b6aa09e8bb86f4a9/R/create_alignment_impl.R#L34) *style:* **functions should have cyclomatic complexity of less than 15, this has 18.**
```r
create_alignment_impl <- function(
^
```
[R/create_all_experiments.R:24:1:](https://github.com/richelbilderbeek/pirouette/blob/2c12440b3a204340e3e5b200b6aa09e8bb86f4a9/R/create_all_experiments.R#L24) *style:* **functions should have cyclomatic complexity of less than 15, this has 30.**
```r
create_all_experiments <- function(
^
```
[R/est_evidences.R:35:1:](https://github.com/richelbilderbeek/pirouette/blob/2c12440b3a204340e3e5b200b6aa09e8bb86f4a9/R/est_evidences.R#L35) *style:* **functions should have cyclomatic complexity of less than 15, this has 24.**
```r
est_evidences <- function(
^
```
[R/select_candidate_evidences.R:25:1:](https://github.com/richelbilderbeek/pirouette/blob/2c12440b3a204340e3e5b200b6aa09e8bb86f4a9/R/select_candidate_evidences.R#L25) *style:* **functions should have cyclomatic complexity of less than 15, this has 20.**
```r
select_candidate_evidences <- function(
^
```


keyi


Successfully aliased the URL <https://itchio-godot-scraper-puw4w2r67.now.sh> to the following aliases:

* https://itchio-godot-scraper.now.sh
* https://itchio-godot-scraper.hiulit.now.sh
* https://itchio-godot-scraper-git-master.hiulit.now.sh


Successfully aliased the URL <https://info-qky8s3rub.now.sh> to the following aliases:

* https://t7s.hellorusk.net
* https://info.7xrusk.now.sh
* https://info-git-master.7xrusk.now.sh


几个月都没法使用，这服务也太差劲了吧


Successfully aliased the URL <https://surname-site-h4dzjlpas.now.sh> to the following aliases:

* https://stickajones.org
* https://surname-site.keplersj.now.sh
* https://surname-site-git-master.keplersj.now.sh


Successfully aliased the URL <https://website-8a875kx9y.now.sh> to the following aliases:

* https://www.takeoffgo.com
* https://website.takeoffgo.now.sh
* https://website-git-master.takeoffgo.now.sh


Successfully aliased the URL <https://kendraio-app-csqq3h6ui.now.sh> to the following aliases:

* https://dev.app.kendra.io
* https://kendraio-app.kendraio.now.sh
* https://kendraio-app-git-develop.kendraio.now.sh


[R/are_mrca_taxa_names_in_fastas.R:7:1:](https://github.com/ropensci/beautier/blob/9ac1a463f652f91ed2ec95fbaf41dc483766def6/R/are_mrca_taxa_names_in_fastas.R#L7) *style:* **functions should have cyclomatic complexity of less than 15, this has 18.**
```r
are_mrca_taxa_names_in_fastas <- function(
^
```
[R/are_mrca_taxa_non_intersecting.R:13:1:](https://github.com/ropensci/beautier/blob/9ac1a463f652f91ed2ec95fbaf41dc483766def6/R/are_mrca_taxa_non_intersecting.R#L13) *style:* **functions should have cyclomatic complexity of less than 15, this has 20.**
```r
are_mrca_taxa_non_intersecting <- function(mrca_priors) {
^
```
[R/check_mrca_prior.R:27:1:](https://github.com/ropensci/beautier/blob/9ac1a463f652f91ed2ec95fbaf41dc483766def6/R/check_mrca_prior.R#L27) *style:* **functions should have cyclomatic complexity of less than 15, this has 31.**
```r
check_mrca_prior <- function(mrca_prior) {
^
```
[R/create_beast2_input.R:18:1:](https://github.com/ropensci/beautier/blob/9ac1a463f652f91ed2ec95fbaf41dc483766def6/R/create_beast2_input.R#L18) *style:* **functions should have cyclomatic complexity of less than 15, this has 36.**
```r
create_beast2_input <- function(
^
```
[R/create_beast2_input.R:223:1:](https://github.com/ropensci/beautier/blob/9ac1a463f652f91ed2ec95fbaf41dc483766def6/R/create_beast2_input.R#L223) *style:* **Lines should not be more than 80 characters.**
```r
    ids = get_alignment_ids_from_fasta_filenames(fasta_filenames = input_filenames),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_beast2_input.R:235:1:](https://github.com/ropensci/beautier/blob/9ac1a463f652f91ed2ec95fbaf41dc483766def6/R/create_beast2_input.R#L235) *style:* **Lines should not be more than 80 characters.**
```r
    ids = get_alignment_ids_from_fasta_filenames(fasta_filenames = input_filenames),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/get_alignment_ids.R:53:1:](https://github.com/ropensci/beautier/blob/9ac1a463f652f91ed2ec95fbaf41dc483766def6/R/get_alignment_ids.R#L53) *style:* **Variable and function names should not be longer than 30 characters.**
```r
get_alignment_ids_from_fasta_filenames <- function(fasta_filenames) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/get_alignment_ids.R:58:1:](https://github.com/ropensci/beautier/blob/9ac1a463f652f91ed2ec95fbaf41dc483766def6/R/get_alignment_ids.R#L58) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/init_distr.R:9:1:](https://github.com/ropensci/beautier/blob/9ac1a463f652f91ed2ec95fbaf41dc483766def6/R/init_distr.R#L9) *style:* **functions should have cyclomatic complexity of less than 15, this has 25.**
```r
init_distr <- function(
^
```
[R/is_distr.R:37:1:](https://github.com/ropensci/beautier/blob/9ac1a463f652f91ed2ec95fbaf41dc483766def6/R/is_distr.R#L37) *style:* **functions should have cyclomatic complexity of less than 15, this has 21.**
```r
is_distr <- function(
^
```
[R/is_inference_model.R:8:5:](https://github.com/ropensci/beautier/blob/9ac1a463f652f91ed2ec95fbaf41dc483766def6/R/is_inference_model.R#L8) *warning:* **no visible global function definition for ‘check_inference_model’**
```r
    check_inference_model(x)
    ^~~~~~~~~~~~~~~~~~~~~
```
[R/is_init_site_model.R:36:1:](https://github.com/ropensci/beautier/blob/9ac1a463f652f91ed2ec95fbaf41dc483766def6/R/is_init_site_model.R#L36) *style:* **functions should have cyclomatic complexity of less than 15, this has 27.**
```r
is_init_gtr_site_model <- function(
^
```
[R/is_mcmc.R:11:1:](https://github.com/ropensci/beautier/blob/9ac1a463f652f91ed2ec95fbaf41dc483766def6/R/is_mcmc.R#L11) *style:* **functions should have cyclomatic complexity of less than 15, this has 19.**
```r
is_mcmc <- function(
^
```
[R/is_site_model.R:55:1:](https://github.com/ropensci/beautier/blob/9ac1a463f652f91ed2ec95fbaf41dc483766def6/R/is_site_model.R#L55) *style:* **functions should have cyclomatic complexity of less than 15, this has 22.**
```r
is_gtr_site_model <- function(
^
```
[R/is_site_model.R:171:1:](https://github.com/ropensci/beautier/blob/9ac1a463f652f91ed2ec95fbaf41dc483766def6/R/is_site_model.R#L171) *style:* **functions should have cyclomatic complexity of less than 15, this has 23.**
```r
is_tn93_site_model <- function(
^
```
[R/parameter_to_xml.R:11:1:](https://github.com/ropensci/beautier/blob/9ac1a463f652f91ed2ec95fbaf41dc483766def6/R/parameter_to_xml.R#L11) *style:* **functions should have cyclomatic complexity of less than 15, this has 20.**
```r
parameter_to_xml <- function(
^
```
[R/site_model_to_xml_subst_model.R:7:1:](https://github.com/ropensci/beautier/blob/9ac1a463f652f91ed2ec95fbaf41dc483766def6/R/site_model_to_xml_subst_model.R#L7) *style:* **functions should have cyclomatic complexity of less than 15, this has 21.**
```r
site_model_to_xml_subst_model <- function(
^
```
[tests/testthat/test-create_nested_sampling_mcmc.R:44:71:](https://github.com/ropensci/beautier/blob/9ac1a463f652f91ed2ec95fbaf41dc483766def6/tests/testthat/test-create_nested_sampling_mcmc.R#L44) *style:* **Commas should always have a space after.**
```r
  nss_line <- na.omit(stringr::str_match(text, ".*beast.gss.NS.*"))[1,1 ]
                                                                      ^
```
[tests/testthat/test-create_nested_sampling_mcmc.R:44:72:](https://github.com/ropensci/beautier/blob/9ac1a463f652f91ed2ec95fbaf41dc483766def6/tests/testthat/test-create_nested_sampling_mcmc.R#L44) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  nss_line <- na.omit(stringr::str_match(text, ".*beast.gss.NS.*"))[1,1 ]
                                                                       ^
```


Successfully aliased the URL <https://kstar-n6i7c0iy9.now.sh> to the following aliases:

* https://kstar.hanterokun.now.sh
* https://kstar-git-master.hanterokun.now.sh


testtttcan


выглядит как ненужное


Successfully aliased the URL <https://nestjs-mongodb-1n28g0kvy.now.sh> to the following aliases:

* https://nestjs-mongodb.webmasterdevlin.now.sh
* https://nestjs-mongodb-git-master.webmasterdevlin.now.sh


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


Successfully aliased the URL <https://kendraio-app-6z6a4qvf3.now.sh> to the following aliases:

* https://dev.app.kendra.io
* https://kendraio-app.kendraio.now.sh
* https://kendraio-app-git-develop.kendraio.now.sh


Successfully aliased the URL <https://surname-site-lpobf5nxg.now.sh> to the following aliases:

* https://stickajones.org
* https://surname-site.keplersj.now.sh
* https://surname-site-git-master.keplersj.now.sh


IBM Cloud [toolchain](https://cloud.ibm.com/devops/toolchains/df0c7817-429a-41c5-9238-61f1a97aab02?env_id=ibm%3Ayp%3Aus-south "cloud-native-toolchain-tutorial-20190909101857998"): [Delivery Pipeline](https://cloud.ibm.com/devops/pipelines/9c474975-d718-48b2-9274-77b8b894abf6 "sample-cloud-native-toolchain-tutorial-20190909101857998") deployed [sample-cloud-native-toolchain-tutorial-20190909101857998](https://github.com/jauninb/sample-cloud-native-toolchain-tutorial-20190909101857998/releases/tag/deploy-ibm-yp-us-south-jaunin.b-fr.ibm.com-qa-20190910-100840 "deploy-ibm-yp-us-south-jaunin.b-fr.ibm.com-qa-20190910-100840") to [qa](https://console.bluemix.net/apps/13574d27-3972-4928-be6c-2a39f29db2ca?env_id=ibm:yp:us-south "ibm:yp:us-south:jaunin.b@fr.ibm.com:qa"), including this commit


testtttcane


Successfully aliased the URL <https://dotgallery-gz94ttqvx.now.sh> to the following aliases:

* https://dot.gallery
* https://dotgallery.xlnt.now.sh
* https://dotgallery-git-master.xlnt.now.sh


Successfully aliased the URL <https://frontend-hsddd92t6.now.sh> to the following aliases:

* https://niyonapp-staging.now.sh
* https://niyonapp.now.sh
* https://niyon-frontend-dev.now.sh
* https://niyonapp.com
* https://frontend.labseu2-niyon.now.sh
* https://frontend-git-master.labseu2-niyon.now.sh


won't this result in 2 pageviews? One from here and the "real" one


remove this comment


Good


my node to this line


ok


I write the CUDALFLAGS as follow
CUDALDFLAGS=-L${CUDA_INSTALL_PATH}/lib64 -lcuda
when I use -lcudart the following error appear

> mpicc -o ../bin/jacobi_cuda_normal_mpi jacobi.o input.o host.o device.o  cuda_normal_mpi.o -L/lib64 -lcudart
/usr/bin/ld: cannot find -lcudart
collect2: error: ld returned 1 exit status
make: *** [../bin/jacobi_cuda_normal_mpi] Error 1

How I can set CUDA_INSATLL_PATH

thank you


@lijojosephk remove this comment


Successfully aliased the URL <https://nestjs-mongodb-jdo3iswj2.now.sh> to the following aliases:

* https://nestjs-mongodb.webmasterdevlin.now.sh
* https://nestjs-mongodb-git-master.webmasterdevlin.now.sh


assuming a pointer was created successfully needs to be changed:

After successfully persisting the Pointer, the NRL will inform the Provider client of this in the returned response which will include the address of the new Pointer.

If there were any problems that meant the Pointer could not be created the NRL will inform the client of this in the returned response.


Successfully aliased the URL <https://website-n1v703u5g.now.sh> to the following aliases:

* https://www.takeoffgo.com
* https://website.takeoffgo.now.sh
* https://website-git-master.takeoffgo.now.sh


can I use `QMetaObject::invokeMethod(this, "deleteLater");` to keep it compile in lower version qt?


Change this to be inline with what is suggested for 'create'


providing DISCONNECT information.


Deployment failed with the following error:

~~~
You defined 1 build that did not match any source files (please ensure they are NOT defined in .nowignore):
~~~


ConnectInboundInterceptor -> DisconnectInboundInterceptor


Why are this <> tags here?


But if you use swap on sdcard the sd will be broken much faster ?!


Nice idea :-)


Successfully aliased the URL <https://website-avyw3deql.now.sh> to the following aliases:

* https://www.takeoffgo.com
* https://website.takeoffgo.now.sh
* https://website-git-master.takeoffgo.now.sh


{@link ModifiableDisconnectPacket}


Successfully aliased the URL <https://nestjs-mongodb-38zjgy4ac.now.sh> to the following aliases:

* https://nestjs-mongodb.webmasterdevlin.now.sh
* https://nestjs-mongodb-git-master.webmasterdevlin.now.sh


|`line 27`|
|---|
AsyncOutput methods are missing.


You are pushing commits at a very fast pace (accross the whole organization).
Due to that, we cannot deploy the commit 33c0e1ff216b540c3fd433e2e7e5789ab30f7ec6.

You can try again later or [upgrade](https://zeit.co/account/plan) your plan.


DoNotImplement Annotation is missing


Successfully aliased the URL <https://kstar-jkks7exud.now.sh> to the following aliases:

* https://kstar.hanterokun.now.sh
* https://kstar-git-master.hanterokun.now.sh


Successfully aliased the URL <https://static-8pp6pdu6u.now.sh> to the following aliases:

* https://statik.now.sh
* https://static.typi.tk
* https://thesorrymind.now.sh
* https://static.ooh.now.sh
* https://static-git-master.ooh.now.sh


Successfully aliased the URL <https://nestjs-mongodb-hngjt4cdn.now.sh> to the following aliases:

* https://nestjs-mongodb.webmasterdevlin.now.sh
* https://nestjs-mongodb-git-master.webmasterdevlin.now.sh


DoNotImplementAnnotation is missing


<details>

<summary>Submitting the task to Taskcluster failed. Details</summary>

end of the stream or a document separator is expected at line 12, column 1:
    -
    ^

</details>


`CUDA_INSATLL_PATH` is an environment variable that should point to your CUDA installation. E.g. with the default install path and bash as your shell use:
`export CUDA_INSATLL_PATH=/usr/local/cuda`
Hope this helps


Successfully aliased the URL <https://kendraio-app-9c624ptn7.now.sh> to the following aliases:

* https://dev.app.kendra.io
* https://kendraio-app.kendraio.now.sh
* https://kendraio-app-git-develop.kendraio.now.sh


will return the value outside the finally


Successfully aliased the URL <https://static-kd0weq63j.now.sh> to the following aliases:

* https://statik.now.sh
* https://static.typi.tk
* https://thesorrymind.now.sh
* https://static.ooh.now.sh
* https://static-git-master.ooh.now.sh


|`line 24`|
|---|
{@link ModifiableDisconnectPacket}


Agree with Sachin's last comment. But was there any specific reason 'drop_counter' was not made related to 'ifhp' structure ? Was 'drop_counter' added to help with rate limiting the log to syslog ?


Wow this is amazing


Successfully aliased the URL <https://dailyrandomphotogithubio-ddi8v8eld.now.sh> to the following aliases:

* https://dailyrandomphoto.now.sh
* https://photooftheday.now.sh
* https://randomphoto.now.sh
* https://dailyphoto.now.sh
* https://picoftheday.now.sh
* https://todayphoto.now.sh
* https://dailyrandomphotogithubio.dailyrandomphoto.now.sh
* https://dailyrandomphotogithubio-git-master.dailyrandomphoto.now.sh


Successfully aliased the URL <https://main-site-ly50prxnf.now.sh> to the following aliases:

* https://fcc-mcr.now.sh
* https://main-site.fcc-mcr.now.sh
* https://main-site-git-master.fcc-mcr.now.sh


not sure whether we need to log the exception here. will ask from Amila (logging project log the exception for unsuccessful logging might complicate things)


Can you use proper doxygen comments for function documentation
```
/**
*/
```
Note that your @params are out of step with the actual parameters for your function.


ignoreEnviormentReport is always false, so GPU mode is never enabled.


will remove protected and keep the method package private


Successfully aliased the URL <https://static-43vmqe0jm.now.sh> to the following aliases:

* https://statik.now.sh
* https://static.typi.tk
* https://thesorrymind.now.sh
* https://static.ooh.now.sh
* https://static-git-master.ooh.now.sh


will remove public and keep the method package private


I don't think this is good behaviour: When the async call times out, you should discard the changes to the packet and send the unmodified version.


cane


Successfully aliased the URL <https://itchio-godot-scraper-gbjdh18mg.now.sh> to the following aliases:

* https://itchio-godot-scraper.now.sh
* https://itchio-godot-scraper.hiulit.now.sh
* https://itchio-godot-scraper-git-master.hiulit.now.sh


@ankitasangodkar why is this gitignore in the theme folder?


Now could not deploy this pull request since the "files" configuration in `now.json` lists these files or directories which do not exist:

* `dist`

These paths may be missing from the GitHub repository because of a `.gitignore` file.
Consider committing them to GitHub or removing them from the "files" list and generating the paths on Now instead using a [build script for a Node.js deployment](https://zeit.co/docs/deployment-types/node), or within your `Dockerfile` for a [docker deployment](https://zeit.co/docs/deployment-types/docker).

For more information on the "files" configuration in now.json, visit [https://zeit.co/docs/features/configuration#files(array)](https://zeit.co/docs/features/configuration#files(array))


Good 👍 for ascii description.

Note that pixels do not live directly below Rectangular banks. There are Columns to which vertical columns of pixels are attached. I don't know if that is important to your test. Just thought I'd point it out.


Successfully aliased the URL <https://kstar-9ynw4igkc.now.sh> to the following aliases:

* https://kstar.hanterokun.now.sh
* https://kstar-git-master.hanterokun.now.sh


Using


Successfully aliased the URL <https://static-pt6qee8pm.now.sh> to the following aliases:

* https://statik.now.sh
* https://static.typi.tk
* https://thesorrymind.now.sh
* https://static.ooh.now.sh
* https://static-git-master.ooh.now.sh


will call the printlog method within logResponseProperties2 method


I would not test `isSaveableBank` as part of `isAncestorOf`. You should test `isAncestorOf` in isolation.


will call the printlog method within logRequestProperties2 method


will call the printlog method within logErrorProperties2 method


Successfully aliased the URL <https://itchio-godot-scraper-c636hxjh1.now.sh> to the following aliases:

* https://itchio-godot-scraper.now.sh
* https://itchio-godot-scraper.hiulit.now.sh
* https://itchio-godot-scraper-git-master.hiulit.now.sh


signed apk: [armv7](https://www.dropbox.com/s/rr5i90ofz4p9iaw/input-gps_ios_fix-50ee8cce8c60ffe6ec1e25a521d2b175744f94a8-armv7-signed.apk?dl=0) (SDK: [android-2](https://github.com/lutraconsulting/input-sdk/releases/tag/android-2))


signed apk: [arm64_v8a](https://www.dropbox.com/s/y1njzktolasbucc/input-gps_ios_fix-50ee8cce8c60ffe6ec1e25a521d2b175744f94a8-arm64_v8a-signed.apk?dl=0) (SDK: [android-2](https://github.com/lutraconsulting/input-sdk/releases/tag/android-2))


change "whether the error on the" to "whether the error is on the"


Testing shortcuts - unfinished work


Successfully aliased the URL <https://kstar-nuqftoh36.now.sh> to the following aliases:

* https://kstar.hanterokun.now.sh
* https://kstar-git-master.hanterokun.now.sh


[R/check_beast2_options.R:19:1:](https://github.com/ropensci/beastier/blob/e032ac2861e84a35ee9a146c8157695c1572d48f/R/check_beast2_options.R#L19) *style:* **functions should have cyclomatic complexity of less than 15, this has 20.**
```r
check_beast2_options <- function(
^
```
[R/get_alignment_ids.R:12:1:](https://github.com/ropensci/beastier/blob/e032ac2861e84a35ee9a146c8157695c1572d48f/R/get_alignment_ids.R#L12) *style:* **Lines should not be more than 80 characters.**
```r
#'    get_alignment_ids_from_xml_filename(get_beastier_path("anthus_15_15.xml")),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/get_alignment_ids.R:17:1:](https://github.com/ropensci/beastier/blob/e032ac2861e84a35ee9a146c8157695c1572d48f/R/get_alignment_ids.R#L17) *style:* **Variable and function names should not be longer than 30 characters.**
```r
get_alignment_ids_from_xml_filename <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/get_beast2_version.R:27:11:](https://github.com/ropensci/beastier/blob/e032ac2861e84a35ee9a146c8157695c1572d48f/R/get_beast2_version.R#L27) *warning:* **no visible global function definition for ‘create_beast2_version_cmd’**
```r
  cmds <- create_beast2_version_cmd(beast2_path)
          ^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/get_beast2_version.R:32:5:](https://github.com/ropensci/beastier/blob/e032ac2861e84a35ee9a146c8157695c1572d48f/R/get_beast2_version.R#L32) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
    {
    ^
```
[R/get_beast2_version.R:69:5:](https://github.com/ropensci/beastier/blob/e032ac2861e84a35ee9a146c8157695c1572d48f/R/get_beast2_version.R#L69) *style:* **Commented code should be removed.**
```r
  # ./beast -version
    ^~~~~~~~~~~~~~~~
```
[R/get_beast2_version.R:74:1:](https://github.com/ropensci/beastier/blob/e032ac2861e84a35ee9a146c8157695c1572d48f/R/get_beast2_version.R#L74) *style:* **Lines should not be more than 80 characters.**
```r
  # [java, -Xms8g, -Xms256m, -Djava.library.path=/usr/local/lib:/usr/java/packages/lib:/usr/lib/x86_64-linux-gnu/jni:/lib/x86_64-linux-gnu:/usr/lib/x86_64-linux-gnu:/usr/lib/jni:/lib:/usr/lib, -cp, ::/home/richel/.beast/2.5/BEASTLabs/lib/BEASTlabs.addon.jar:/home/richel/.beast/2.5/NS/lib/NS.addon.jar:/home/richel/.beast/2.5/MODEL_SELECTION/lib/MODEL_SELECTION.addon.jar:/home/richel/.beast/2.5/BEAST/lib/beast.jar:/home/richel/.beast/2.5/BEAST/lib/beast.src.jar, beast.app.beastapp.BeastMain, -version]
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/get_beast2_version.R:76:24:](https://github.com/ropensci/beastier/blob/e032ac2861e84a35ee9a146c8157695c1572d48f/R/get_beast2_version.R#L76) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  last_lines <- output[ length(output) ]
                       ^
```
[R/get_beast2_version.R:76:39:](https://github.com/ropensci/beastier/blob/e032ac2861e84a35ee9a146c8157695c1572d48f/R/get_beast2_version.R#L76) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  last_lines <- output[ length(output) ]
                                      ^
```
[R/run_beast2.R:34:1:](https://github.com/ropensci/beastier/blob/e032ac2861e84a35ee9a146c8157695c1572d48f/R/run_beast2.R#L34) *style:* **functions should have cyclomatic complexity of less than 15, this has 26.**
```r
run_beast2 <- function(
^
```
[R/upgrade_beast2.R:29:3:](https://github.com/ropensci/beastier/blob/e032ac2861e84a35ee9a146c8157695c1572d48f/R/upgrade_beast2.R#L29) *warning:* **no visible global function definition for ‘uninstall_beast2’**
```r
  uninstall_beast2()
  ^~~~~~~~~~~~~~~~
```
[R/upgrade_beast2.R:30:3:](https://github.com/ropensci/beastier/blob/e032ac2861e84a35ee9a146c8157695c1572d48f/R/upgrade_beast2.R#L30) *warning:* **no visible global function definition for ‘install_beast2’**
```r
  install_beast2()
  ^~~~~~~~~~~~~~
```


👍 good testing.


Similar to create this should be changed as no assumptions should be made.


will call the printlog method within captureErrorProperties method


Again change references to "assume"


No hay problema @AbigailCP. Si tienes libres las mañanas, o algunas mañanas, las PC del SIGCART (el aula de clases) están disponibles. Puedes concertar con Cabrera o Edwin. Por otra parte, algunas tardes es posible también usar el aula; no recuerdo qué días, pero eso igualmente lo puedes concertar con ellos.


|`line 19`|
|---|
Why did you add this Annotation?


Hi


Can you please declare `using namespace Geometry::ComponentInfoBankHelpers` at the start of this function. Avoids long scope-resolved names.


Successfully aliased the URL <https://nestjs-mongodb-8xe43t11w.now.sh> to the following aliases:

* https://nestjs-mongodb.webmasterdevlin.now.sh
* https://nestjs-mongodb-git-master.webmasterdevlin.now.sh


Successfully aliased the URL <https://naterad-8eo3czp6k.now.sh> to the following aliases:

* https://naterad.now.sh
* https://naterad.nateradebaugh.now.sh
* https://naterad-git-master.nateradebaugh.now.sh


Successfully aliased the URL <https://static-1a82bpxrf.now.sh> to the following aliases:

* https://statik.now.sh
* https://static.typi.tk
* https://thesorrymind.now.sh
* https://static.ooh.now.sh
* https://static-git-master.ooh.now.sh


![](https://github.trello.services/images/mini-trello-icon.png) [After insert a note, drag and drop select will cause the empty note remains. by HaK](https://trello.com/c/1zi5JpnQ/42-after-insert-a-note-drag-and-drop-select-will-cause-the-empty-note-remains-by-hak)


Shouldn't we only add to `nxDetectorCandidates` once we have also done the `isAncestorOf` check?


Notes for the future: this is now referencing [ChunkProviderServerBridge](https://github.com/SpongePowered/SpongeCommon/blob/stable-7/src/main/java/org/spongepowered/common/bridge/world/chunk/ChunkProviderServerBridge.java) in Sponge.

That was added to Sponge in an [August 4, 2019 commit](https://github.com/SpongePowered/SpongeCommon/commit/da40458a2c60c8114fd567dc0dd35e5bb3799147).


comparing of different types. you will need a casting here


![](https://github.trello.services/images/mini-trello-icon.png) [When multiple selecting note, Press "backspace" to delete selected notes.](https://trello.com/c/4vN5pHEj/27-when-multiple-selecting-note-press-backspace-to-delete-selected-notes)


I think it is worth keeping reference to the fact that the NRL does not guarantee a record can be retrieved. Maybe not as detailed as this but a brief few lines.


coooo, prosze jakiś log albo co przynajmniej


Successfully aliased the URL <https://itchio-godot-scraper-l2zvyhyi3.now.sh> to the following aliases:

* https://itchio-godot-scraper.now.sh
* https://itchio-godot-scraper.hiulit.now.sh
* https://itchio-godot-scraper-git-master.hiulit.now.sh


This is the same code as pointer access


Successfully aliased the URL <https://nestjs-mongodb-5fi19ejus.now.sh> to the following aliases:

* https://nestjs-mongodb.webmasterdevlin.now.sh
* https://nestjs-mongodb-git-master.webmasterdevlin.now.sh


@allouis  Hi Fabien, I have been following your commits and observe that you have removed references to `members-theme-binding` and `members-auth-pages` modules. Shall I know if there is any plan to add them back. Otherwise, what is the way for authentication moving forward?

Thank you.


ты про пробелы или про новые тесты?


Successfully aliased the URL <https://kendraio-app-9c624ptn7.now.sh> to the following aliases:

* https://dev.app.kendra.io
* https://kendraio-app.kendraio.now.sh
* https://kendraio-app-git-develop.kendraio.now.sh


Pretty much there. Make easier by creating bool directly,

```const auto saveable = nxDetectorCandidates.end() == std::find_if...```

Also, rename `nxDetectorCandiates` to `saved_indices` and only add indexes to it when an NXDetector is actually made.


will use Boolean.parseBoolean() instead of Boolean.valueOf()
https://stackoverflow.com/questions/5697790/why-java-has-a-lot-of-duplicate-methods


What do we need the name for?


will remove public and keep the method package private


@boldtrn was there a specifc reason you put this check inside this while loop ? would it not be sufficient to put it one level up into the outer while loop ?


Looks good.


Successfully aliased the URL <https://kendraio-app-pvdlrqa4r.now.sh> to the following aliases:

* https://dev.app.kendra.io
* https://kendraio-app.kendraio.now.sh
* https://kendraio-app-git-develop.kendraio.now.sh


Also removed unused _lc_first, which really only existed to force me to think about how there was reused code to eliminate.


Typo in "exixtingVdc" in this commit.


Successfully aliased the URL <https://static-r8mw09otf.now.sh> to the following aliases:

* https://statik.now.sh
* https://static.typi.tk
* https://thesorrymind.now.sh
* https://static.ooh.now.sh
* https://static-git-master.ooh.now.sh


Is it worth changing this slightly so as not to mention MHCP:

The RBAC codes listed in the mapping table above is limited by the number of Record Types currently available on the NRL but as additional Record Types are added to the NRL the associated RBAC codes will be added to this table.


![Screenshot 2019-09-10 at 13 30 26](https://user-images.githubusercontent.com/14391797/64606809-c814ad00-d3cf-11e9-884c-73e12d678c2c.png)

as mentioned use 2 terminals:
# in terminal 1
python3 seeker.py -t manual
# in terminal 2
./ngrok http 8080

screenshot attached


Hi
With this commit **b052d61** applied on search.class.php part of a 9.4.3
**If a profile don't have the "see private tasks option checked"** the user that use this profile can't see tickets list on the tickets page.
Just no results at all on the page.
Without this commit, all is fine again.


signed apk: [armv7](https://www.dropbox.com/s/ymo7hlry7xqhkma/input-master-e0628dfa698facc0962be60b1f0aeb1565eefaeb-armv7-signed.apk?dl=0) (SDK: [android-2](https://github.com/lutraconsulting/input-sdk/releases/tag/android-2))


lic


### TinyCI build failure:
Missing artifact: [EmptyEpsilon.zip] after build


Successfully aliased the URL <https://website-kl60xariq.now.sh> to the following aliases:

* https://www.takeoffgo.com
* https://website.takeoffgo.now.sh
* https://website-git-master.takeoffgo.now.sh


signed apk: [arm64_v8a](https://www.dropbox.com/s/1dq62bttrruh4bm/input-master-e0628dfa698facc0962be60b1f0aeb1565eefaeb-arm64_v8a-signed.apk?dl=0) (SDK: [android-2](https://github.com/lutraconsulting/input-sdk/releases/tag/android-2))


Successfully aliased the URL <https://static-ad01ol023.now.sh> to the following aliases:

* https://statik.now.sh
* https://static.typi.tk
* https://thesorrymind.now.sh
* https://static.ooh.now.sh
* https://static-git-master.ooh.now.sh


Мне надо чтобы на termux работал на termux покажи


signed apk: [armv7](https://www.dropbox.com/s/f79avlza76dt001/input-master-46eac7c01787d99c08389071d1e692fbf2197467-armv7-signed.apk?dl=0) (SDK: [android-2](https://github.com/lutraconsulting/input-sdk/releases/tag/android-2))


why do we have this in dev? was this reviewed? if its not used then should be removed


same as comment above


Successfully aliased the URL <https://vst1nk-lr7zw8kcl.now.sh> to the following aliases:

* https://vst1nk.now.sh
* https://vst1nk.vista1nik.now.sh
* https://vst1nk-git-master.vista1nik.now.sh


Successfully aliased the URL <https://nodes-26inqktrq.now.sh> to the following aliases:

* https://nodes.ws
* https://nodes.timpchelintsev.now.sh
* https://nodes-git-master.timpchelintsev.now.sh


i do not see this commit being reviewed or any comments


Не совсем понял, что не устраивает в регулярке для номера телефона. Регулярка "поддерживает" несколько вариантов ввода номера, включая указанный в подсказке.


Successfully aliased the URL <https://xadamyxyz-ggds2lnba.now.sh> to the following aliases:

* https://xadamyxyz.adamyeats.now.sh
* https://xadamyxyz-git-master.adamyeats.now.sh


Successfully aliased the URL <https://nohai-app-qdyho2b8f.now.sh> to the following aliases:

* https://nohai-app.nohai.now.sh
* https://nohai-app-git-master.nohai.now.sh


Shouldn't this be just `(find-class new-class)`? If `new-class` does not name an existing class, an error will be signaled. Also, if a non-`nil` `new-class` was supplied, I don't think we want to fall back to `(class-of event)`.


it's superfluous to use different libraries with such basic functionality. toString generation is suitable here


Good


Successfully aliased the URL <https://static-p8hvbnd3x.now.sh> to the following aliases:

* https://statik.now.sh
* https://static.typi.tk
* https://thesorrymind.now.sh
* https://static.ooh.now.sh
* https://static-git-master.ooh.now.sh


Usual rate limited messages don't have structure related fields, but they mostly depend on static things like this + plus time factor. Getting rate limited code into ntirpc is heavy weight, so I decided to log less and chose 1000.


just generate equals, hashCode and toString with default generation mechanism


I'd love to test this on my ATtiny416 Xplaned nano. How would auto-reset wok for this board? The UPDI line is connected to the mEDBG, so does the pin has to be turned into RST by setting the SYSCFG0 fuse? I think avrdude has some built-in safety to prevent the UUDP pin from beind disabled by a programmer that doesn't support 12V UPDI, as mentioned by me [here](https://github.com/SpenceKonde/ATTinyCore/issues/288#issuecomment-529192938).


Successfully aliased the URL <https://xadamyxyz-q84g2yth4.now.sh> to the following aliases:

* https://xadamyxyz.adamyeats.now.sh
* https://xadamyxyz-git-master.adamyeats.now.sh


signed apk: [arm64_v8a](https://www.dropbox.com/s/y5r8i5yenuorh7x/input-master-46eac7c01787d99c08389071d1e692fbf2197467-arm64_v8a-signed.apk?dl=0) (SDK: [android-2](https://github.com/lutraconsulting/input-sdk/releases/tag/android-2))


![](https://github.trello.services/images/mini-trello-icon.png) [Criando do projeto - commmit e Diagrama](https://trello.com/c/OFWfW153/2-criando-do-projeto-commmit-e-diagrama)


Successfully aliased the URL <https://next-6s7g6nyvs.now.sh> to the following aliases:

* https://oacore.now.sh
* https://next.oacore.now.sh
* https://next-git-content.oacore.now.sh


|`line 17`|
|---|
Why did you add this Annotation?


You add revievs to toString method, when runtime env will call this, each review in this collection will call their Tour fields, which will call collection of reviews ... StackOwerflowException


Successfully aliased the URL <https://kstar-e6opjonuv.now.sh> to the following aliases:

* https://kstar.hanterokun.now.sh
* https://kstar-git-master.hanterokun.now.sh


Gets the server reference


I don't think this message is really needed as netstat should show it. Customers should use it to track clients having slow recv sockets. Maybe, logging once every 5 minutes at the most should be good. I will try that route.


Successfully aliased the URL <https://igu-a7elkn2wt.now.sh> to the following aliases:

* https://startigu.nu
* https://igu.ahmad106107.now.sh
* https://igu-git-master.ahmad106107.now.sh


Я видать забыл коментарий отправить.
В поле с номером телефона шаблон из задания "+7 925-900-90-90" не проходит проверку.
Нужно доделать регулярку, чтобы этот шаблон был валидным.


read about maven BOM, it's better to provide bom functionality here


It might be that one iteration of it takes relative long for world wide and the last nodes?

Is this a performance problem? If yes, we should move it out of this loop.


|`line 28`|
|---|
String


|`line 30`|
|---|
String


Successfully aliased the URL <https://xadamyxyz-5t3pnlnby.now.sh> to the following aliases:

* https://xadamyxyz.adamyeats.now.sh
* https://xadamyxyz-git-master.adamyeats.now.sh


|`hivemq-extension-sdk/src/main/java/com/hivemq/extension/sdk/api/packets/disconnect/DisconnectPacket.java:37-38`|
|---|
Optional?


> #576

The issue is relative to an old version of the esp8266 Arduino core.
I don't think it's O.K to use a different input type just to be compatible with an old version to solve an old issue.

Thanks.


Second occurrence of a hard coded string.


it's more convenient to scan each logical package(e.g. model, service, dao, etc.) since application context will initialization faze will be executed faster


string -> String


the same errors with new values :-(


it's worse to write big conditions as if statement, exception will be thrown even if your values will be null


It got freaking speedy, like calculation time went from 8 sec to 0.01 sec or something
Optimization of multiplication of sparse matrices is very important I tell ya


|`line 127`|
|---|
wierd formatting


The intention here is just to make sure the thread is interrupted not too long after setting the interrupt flag ? I wouldn't expect this time becomes too long if we move the check one level up. And yes for performance it should be better outside (but also not sure if this is relevant).


Successfully aliased the URL <https://xadamyxyz-17bv6bqjt.now.sh> to the following aliases:

* https://xadamyxyz.adamyeats.now.sh
* https://xadamyxyz-git-master.adamyeats.now.sh


IBM Cloud [toolchain](https://cloud.ibm.com/devops/toolchains/df0c7817-429a-41c5-9238-61f1a97aab02?env_id=ibm%3Ayp%3Aus-south "cloud-native-toolchain-tutorial-20190909101857998"): [Delivery Pipeline](https://cloud.ibm.com/devops/pipelines/9c474975-d718-48b2-9274-77b8b894abf6 "sample-cloud-native-toolchain-tutorial-20190909101857998") deployed [sample-cloud-native-toolchain-tutorial-20190909101857998](https://github.com/jauninb/sample-cloud-native-toolchain-tutorial-20190909101857998/releases/tag/deploy-ibm-yp-us-south-jaunin.b-fr.ibm.com-prod-20190910-105340 "deploy-ibm-yp-us-south-jaunin.b-fr.ibm.com-prod-20190910-105340") to [prod](https://console.bluemix.net/apps/becaccde-f2ab-4ee8-88f5-072c98c48d9f?env_id=ibm:yp:us-south "ibm:yp:us-south:jaunin.b@fr.ibm.com:prod"), including this commit


@daN4cat

Doesn't this just refer to stock location id = 1?

I guess it will be fine in case no stock locations have been added and removed.  But what if stock location 1 has deleted = true and a new one was added after that?


handlser -> handler


create method should return unwrapped T value


$ minikube ssh
$ journalctl -f
```
Aug 02 04:25:38 minikube kernel: hpet1: lost 319 rtc interrupts
Aug 02 04:25:43 minikube kernel: hpet1: lost 318 rtc interrupts
Aug 02 04:25:48 minikube kernel: hpet1: lost 317 rtc interrupts
Aug 02 04:25:53 minikube kernel: hpet1: lost 319 rtc interrupts
Aug 02 04:25:58 minikube kernel: hpet1: lost 318 rtc interrupts
...
```


|`src/main/java/com/hivemq/extensions/client/ClientContextImpl.java:129-130`|
|---|
revert formatting change


it's worse to create bean with such constructor since you can provide SessionFactory here and retrieve Session each time


|`src/main/java/com/hivemq/extensions/client/ClientContextImpl.java:161-162`|
|---|
revert formatting change


<details>

<summary>Submitting the task to Taskcluster failed. Details</summary>

end of the stream or a document separator is expected at line 12, column 1:
    -
    ^

</details>


you can create abstract method with return type Class<T> and implement this method in each repository implementation


Successfully aliased the URL <https://static-j95pvaxh7.now.sh> to the following aliases:

* https://statik.now.sh
* https://static.typi.tk
* https://thesorrymind.now.sh
* https://static.ooh.now.sh
* https://static-git-master.ooh.now.sh


- #2149


Updated new image. @navyaganduri @dostiharise @milindmantri


why do you need to import this


|`src/main/java/com/hivemq/extensions/handler/DisconnectInboundInterceptorHandler.java:38`|
|---|
Maybe refactor this into a ChannelDuplexHandler


nice, you can also use the print syntax like this
`print("average speed of the .....", (distance_km/hours))
where it will actually execute code right there.


"com.epam.training" scaning will also accept "com.epam.training.util" package


[Bianca Nenciu posted](https://review.discourse.org/t/fix-award-first-onebox-badge-just-for-oneboxed-urls-7974/5125/4):

 https://review.discourse.org/t/fix-improve-onebox-detection-8019/5590


#### `terraform plan` Success

<details><summary>Show Output</summary>

```diff

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
+ create

Terraform will perform the following actions:

  # aws_vpc.VPC will be created
+ resource "aws_vpc" "VPC" {
      + arn                              = (known after apply)
      + assign_generated_ipv6_cidr_block = false
      + cidr_block                       = "192.168.0.0/24"
      + default_network_acl_id           = (known after apply)
      + default_route_table_id           = (known after apply)
      + default_security_group_id        = (known after apply)
      + dhcp_options_id                  = (known after apply)
      + enable_classiclink               = (known after apply)
      + enable_classiclink_dns_support   = (known after apply)
      + enable_dns_hostnames             = true
      + enable_dns_support               = true
      + id                               = (known after apply)
      + instance_tenancy                 = "default"
      + ipv6_association_id              = (known after apply)
      + ipv6_cidr_block                  = (known after apply)
      + main_route_table_id              = (known after apply)
      + owner_id                         = (known after apply)
      + tags                             = {
          + "Name" = "cane.test.vpc"
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.
```

</details>

*Workflow: `Terraform-Plan`, Action: `canelkatmisterraform-github-actions`*


Aici trebuie punct si virgula !


Если это возможно на termux зделат


Successfully aliased the URL <https://react-sports-poll-qgluytwux.now.sh> to the following aliases:

* https://react-sports-poll.dantegr.now.sh
* https://react-sports-poll-git-master.dantegr.now.sh


Successfully aliased the URL <https://xadamyxyz-ivyic0kg2.now.sh> to the following aliases:

* https://xadamyxyz.adamyeats.now.sh
* https://xadamyxyz-git-master.adamyeats.now.sh


|`src/main/java/com/hivemq/extensions/handler/DisconnectInboundInterceptorHandler.java:156-157`|
|---|
add check for async Timeout


this kind of `end=''` syntax is new to me.
Not sure what you are going for? Can you tell me what you are trying to accomplish?


Well. that's good. Keep it up!


1. What is 19, magic number?
2. You don't need to validate with constraints you dto object since it will be created from validated model object
3. Your dto object is too complex, it should contains fields + getter/setter -s


@derekcollison It seems this method's signature is exactly the same as the preceding method. Maybe `msg` should be removed here?


|`src/main/java/com/hivemq/extensions/handler/DisconnectOutboundInterceptorHandler.java:153`|
|---|
add check for async Timeout -> discard changes to DisconnectPacket


`_reporter_password ` is twice instead of the `_reporter_user_name`
I think maybe we should do a test call to validate the config? that we can really send a valid request to the API


what is profit of this class?


Nice work @mossplix, the tests are good but I would recommend you adapt unittest so that each part of the application is tested.
For example, you could assert "amount" in status.keys() as an individual test. and or the level of assertions should be up to two so that you can have more test case which is independent.


wierd formatting


Hi, in my case, after running the `go mod tidy`, the 10th line `git.apache.org/thrift.git v0.0.0-20180902110319-2566ecd5d999/go.mod h1:fPE2ZNJGynbRyZ4dJvy6G277gSllfV2HJqblrnkyeyg=` has been removed. Could you please recheck this? Thank you. 😄


楼主这个是啥呀？


Successfully aliased the URL <https://xadamyxyz-nxy5pnyy0.now.sh> to the following aliases:

* https://xadamyxyz.adamyeats.now.sh
* https://xadamyxyz-git-master.adamyeats.now.sh


Do you really need this fields?


Oh ok, you are trying to get it to print on the same line.
Yea so what I wrote earlier is probably easier

`print (round(Celsius,1), 'Degree Celsius')` should work fine


```
>>> a = 5
>>> print (a, 'hi')
5 hi
```
and so does

```
>>> print ('hi', a)
hi 5
```


Pardon to bother, just wondering whether you intent to push a new release with the updated strings soon?


Successfully aliased the URL <https://static-2jzcunj6x.now.sh> to the following aliases:

* https://statik.now.sh
* https://static.typi.tk
* https://thesorrymind.now.sh
* https://static.ooh.now.sh
* https://static-git-master.ooh.now.sh


Do you really need this fields to be protected? If it is so that means you abstraction is not enough abstract:)


I think it should be 'Tenant'


Successfully aliased the URL <https://code2go-1mvcett55.now.sh> to the following aliases:

* https://code2go.dev
* https://code2go.medienwerk.now.sh
* https://code2go-git-master.medienwerk.now.sh


changed to `(if (null new-class) (class-of event) (find-class new-class))`


We should use `https` with certificates


Why? it's case sensitive?


WHAT DOES THIS CODE DO ?


|`src/main/java/com/hivemq/extensions/handler/DisconnectOutboundInterceptorHandler.java:154`|
|---|
here is a deep copy of the packet required


wierd formatting


> The intention here is just to make sure the thread is interrupted not too long after setting the interrupt flag?

I think this was the reason yes.

I just found the [discussion](https://github.com/graphhopper/graphhopper/pull/980#discussion_r105111178) about this :).


Nullability Annotation missing


Nullability annotation missing


No one will run it manually, so it's the same like checking this works via the endpoint or via the logs will be


|`src/main/java/com/hivemq/extensions/interceptor/disconnect/DisconnectInboundInputImpl.java:52`|
|---|
Nullability Annotation missing


|`line 39`|
|---|
Nullability Annotation missing


And [here](https://github.com/graphhopper/graphhopper/pull/980#discussion_r106829541)


We need to think about which venv the script will run in, to make sure it will have access to `cfy_manager`


uwu


Would had been nicer to just define it to 1. Just bisected mysterious compiler errors to this change, and I indeed need to change my `#if`s for it.. But this frustration could had been saved


Approved


There shouldn't be any forward slashes in there, and snapshot & generation should be seperate from their asset IDs as they are seperare params. It shouldnt even have run cleanly like that because the call should be specific for the input params


The second parameter of the callexpr is wrong. The code calls sizeof() on a malloced pointer type, which always returns the size of the pointer, not the size of an allocated buffer.  For details, see https://cwe.mitre.org/data/definitions/467.html

This parameter must be related to the magic number '1024'


|`line 26`|
|---|
Nullability Annotation missing


Is this a Pimcore 5 compatibility thing?


hi.


Is it intentional to have references to proposed APIs in the docs of stable ones?


|`line 46`|
|---|
this.modified


#### `terraform plan` Success

<details><summary>Show Output</summary>

```diff

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
+ create

Terraform will perform the following actions:

  # aws_vpc.VPC will be created
+ resource "aws_vpc" "VPC" {
      + arn                              = (known after apply)
      + assign_generated_ipv6_cidr_block = false
      + cidr_block                       = "192.168.0.0/24"
      + default_network_acl_id           = (known after apply)
      + default_route_table_id           = (known after apply)
      + default_security_group_id        = (known after apply)
      + dhcp_options_id                  = (known after apply)
      + enable_classiclink               = (known after apply)
      + enable_classiclink_dns_support   = (known after apply)
      + enable_dns_hostnames             = true
      + enable_dns_support               = true
      + id                               = (known after apply)
      + instance_tenancy                 = "default"
      + ipv6_association_id              = (known after apply)
      + ipv6_cidr_block                  = (known after apply)
      + main_route_table_id              = (known after apply)
      + owner_id                         = (known after apply)
      + tags                             = {
          + "Name" = "cane.test.vpc"
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.
```

</details>

*Workflow: `Terraform-Plan`, Action: `canelkatmisterraform-github-actions`*


Should add the ssl certificate


|`src/main/java/com/hivemq/extensions/packets/disconnect/ModifiableDisconnectPacketImpl.java:57`|
|---|
this.modified


If there are no comments I will post the draft tomorrow to avoid expiration.


boom, you got it! thanks for the super quick fix on this!