[R/ods_find_higher_geographies.R:17:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_find_higher_geographies.R#L17) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_find_higher_geographies.R:19:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_find_higher_geographies.R#L19) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_find_higher_geographies.R:22:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_find_higher_geographies.R#L22) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_find_higher_geographies.R:25:60:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_find_higher_geographies.R#L25) *style:* **Commented code should be removed.**
```r
    ?data <http://purl.org/linked-data/sdmx/2009/dimension#refArea> ?geographyURI.
                                                           ^~~~~~~~~~~~~~~~~~~~~~~
```
[R/ods_find_higher_geographies.R:33:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_find_higher_geographies.R#L33) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_find_higher_geographies.R:35:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_find_higher_geographies.R#L35) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_find_higher_geographies.R:37:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_find_higher_geographies.R#L37) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_find_lower_geographies.R:17:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_find_lower_geographies.R#L17) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_find_lower_geographies.R:19:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_find_lower_geographies.R#L19) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_find_lower_geographies.R:22:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_find_lower_geographies.R#L22) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~~~~~~~~~~~
```
[R/ods_find_lower_geographies.R:25:74:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_find_lower_geographies.R#L25) *style:* **Commented code should be removed.**
```r
                  ?data <http://purl.org/linked-data/sdmx/2009/dimension#refArea> ?geographyURI.
                                                                         ^~~~~~~~~~~~~~~~~~~~~~~
```
[R/ods_find_lower_geographies.R:33:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_find_lower_geographies.R#L33) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_find_lower_geographies.R:35:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_find_lower_geographies.R#L35) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_find_lower_geographies.R:37:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_find_lower_geographies.R#L37) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_get_csv.R:30:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_get_csv.R#L30) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/ods_print_query.R:21:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L21) *style:* **functions should have cyclomatic complexity of less than 15, this has 16.**
```r
ods_print_query <- function(dataset,
^
```
[R/ods_print_query.R:26:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L26) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:43:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L43) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:56:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L56) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:63:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L63) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:75:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L75) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/ods_print_query.R:78:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L78) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:81:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L81) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:101:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L101) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:103:5:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L103) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!is.null(geography)) {
    ^
```
[R/ods_print_query.R:104:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L104) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/ods_print_query.R:106:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L106) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/ods_print_query.R:112:58:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L112) *style:* **Only use double-quotes.**
```r
                                                   (stop('Geography code not in sc, la, hd, iz, or dz'))
                                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ods_print_query.R:114:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L114) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/ods_print_query.R:115:151:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L115) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
    query_addition <- paste0("filter (strstarts(strafter(str(?refAreaURI),'http://statistics.gov.scot/id/statistical-geography/'),'", geo_code, "'))." )
                                                                                ^
```
[R/ods_print_query.R:116:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L116) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/ods_print_query.R:119:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L119) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:123:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L123) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:129:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L129) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:131:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L131) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/ods_print_query.R:134:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L134) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/ods_print_query.R:142:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L142) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~
```
[R/ods_print_query.R:159:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L159) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/ods_print_query.R:161:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L161) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/ods_print_query.R:163:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L163) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:166:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L166) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:169:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L169) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:171:1:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/R/ods_print_query.R#L171) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[tests/testthat/test_ods_dataset.R:39:4:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/tests/testthat/test_ods_dataset.R#L39) *style:* **Commented code should be removed.**
```r
#  skip_on_cran()
   ^~~~~~~~~~~~~~
```
[tests/testthat/test_ods_dataset.R:40:4:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/tests/testthat/test_ods_dataset.R#L40) *style:* **Commented code should be removed.**
```r
#  expect_equal(ods_dataset(dataset = "average-household-size", geography = "S12000039")$refArea[1], "West Dunbartonshire")
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_dataset.R:44:4:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/tests/testthat/test_ods_dataset.R#L44) *style:* **Commented code should be removed.**
```r
#  skip_on_cran()
   ^~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:1:2:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/tests/testthat/test_ods_print_query.R#L1) *style:* **Commented code should be removed.**
```r
#context("ods_print_query")
 ^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:3:2:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/tests/testthat/test_ods_print_query.R#L3) *style:* **Commented code should be removed.**
```r
#expected_return_value1 <- "PREFIX qb: <http://purl.org/linked-data/cube#>"
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:4:2:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/tests/testthat/test_ods_print_query.R#L4) *style:* **Commented code should be removed.**
```r
#expected_return_value2 <- "PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>"
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:5:2:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/tests/testthat/test_ods_print_query.R#L5) *style:* **Commented code should be removed.**
```r
#expected_return_value3 <- "PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>"
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:6:2:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/tests/testthat/test_ods_print_query.R#L6) *style:* **Commented code should be removed.**
```r
#expected_return_value4 <- "select  \\?value where \\{ \\?data qb:dataSet <http://statistics\\.gov\\.scot/data/average-house-size>\\. \\?data  \\.  rdfs:label \\. \\?data  \\.  rdfs:label \\. \\?data \\?measureTypeURI \\?value\\. \\}"
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:7:2:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/tests/testthat/test_ods_print_query.R#L7) *style:* **Commented code should be removed.**
```r
#expected_return_value5 <- "select  \\?value where \\{ \\?data qb:dataSet <http://statistics\\.gov\\.scot/data/average-house-size>\\. \\?data  \\.  rdfs:label \\. \\?data  \\.  rdfs:label \\. FILTER \\(\\?refPeriod >= '2017'\\^\\^xsd:date && \\?refPeriod <= '2018'\\^\\^xsd:date\\) \\?data \\?measureTypeURI \\?value\\. \\}"
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:9:2:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/tests/testthat/test_ods_print_query.R#L9) *style:* **Commented code should be removed.**
```r
#printed_query <- ods_print_query("average-house-size")
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:15:4:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/tests/testthat/test_ods_print_query.R#L15) *style:* **Commented code should be removed.**
```r
#  skip_on_cran()
   ^~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:16:4:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/tests/testthat/test_ods_print_query.R#L16) *style:* **Commented code should be removed.**
```r
#  expect_match(printed_query, expected_return_value1)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:17:4:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/tests/testthat/test_ods_print_query.R#L17) *style:* **Commented code should be removed.**
```r
#  expect_match(printed_query, expected_return_value2)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:18:4:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/tests/testthat/test_ods_print_query.R#L18) *style:* **Commented code should be removed.**
```r
#  expect_match(printed_query, expected_return_value3)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:19:4:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/tests/testthat/test_ods_print_query.R#L19) *style:* **Commented code should be removed.**
```r
#  expect_match(printed_query, expected_return_value4)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:23:4:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/tests/testthat/test_ods_print_query.R#L23) *style:* **Commented code should be removed.**
```r
#  skip_on_cran()
   ^~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:24:4:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/tests/testthat/test_ods_print_query.R#L24) *style:* **Commented code should be removed.**
```r
#  expect_match(printed_query_with_filter, expected_return_value1)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:25:4:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/tests/testthat/test_ods_print_query.R#L25) *style:* **Commented code should be removed.**
```r
#  expect_match(printed_query_with_filter, expected_return_value2)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:26:4:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/tests/testthat/test_ods_print_query.R#L26) *style:* **Commented code should be removed.**
```r
#  expect_match(printed_query_with_filter, expected_return_value3)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:27:4:](https://github.com/DataScienceScotland/opendatascot/blob/f221515ca1c7d3de04f0c1ac659f10bba6eb32fb/tests/testthat/test_ods_print_query.R#L27) *style:* **Commented code should be removed.**
```r
#  expect_match(printed_query_with_filter, expected_return_value5)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


update


@{622f5493-b6d1-4ca6-8b46-4c8294a61258,Robin Atherton} you did not fix any of the issues i mentioned. Please fix them and then resolve them in upsource.


Wow, this is a tragic move. So much documentation needs to be updated.

Everything here is broken: https://firebaseopensource.com/projects/flutter/plugins/


Oh, good point :)


This commit has been mentioned on **Duplicati**. There might be relevant details there:

https://forum.duplicati.com/t/bug-regular-expression-filter-operator-or-does-not-work-inside-parenthesis/7950/8


add test scope for the streams, this isn't a runtime dependency


@KPrasch we have to be careful here - remember that the ws-port can be specified from the cli. If a different port is specified from the cli then this value needs to be updated. There may have been a better way but this is was why I opted for the html to be in the `status_page.py` file.


Successfully aliased the URL <https://airship-rescue-mp6id4xgl.now.sh> to the following aliases:

* https://airship-rescue.org
* https://airship-rescue.saschametzger.now.sh
* https://airship-rescue-git-master.saschametzger.now.sh


I added: "They decouple testing code from the application."


Successfully aliased the URL <https://app-3rvmh8748.now.sh> to the following aliases:

* https://app.communiteths.now.sh
* https://app-git-master.communiteths.now.sh


Gaussian?


How about building this example app: https://github.com/flutter/plugins/tree/master/packages/firebase_auth/example

Oh right... someone deleted it.

@collinjackson


Hi, Xavier asked me to have a look; so I'll leave a general comment here:
**Pausable**
1. Rename `IsPaused()` to `isPaused()` (camelCase naming convention).
2. Rename `whenNotKilled` to `whenAlive` (less mental overload).

**Remittance**
1. Inside `deposit()` it's enough to check `balances[puzzle].from == address(0x0)` to make sure that the hash hasn't been used before.
2. Inside `withdraw()` do not zero `balances[solution].from` this way you can implement point #1. If you have questions, ask here 🙂
3. Inside `refund()` start with validating that the remittance has expired; then proceed to checking the amount, etc...because that's the most important factor.
4. Inside `refund()` do not zero `balances[solution].from` so you can implement point #1.
5. Inside `drainBalance()` no need to check `whenPaused` because you already require pausing the contract before killing it, so if `whenKilled` is valid; it means the contract is paused.

Other than that; you did a great job.


```diff
-                      <h1>NOS SERVICES</h1>
+                      <h2>NOS SERVICES</h2>
```

Sémantiquement, tu ne dois avoir qu'un seul tag `<h1>` dans chaque page. D'ailleurs, dans les consoles des moteurs de recherche, pour tout ce qui est SEO, ça remonte comme une erreur.

Tu dois respecter la hiérarchie de tes titres dans tes balises. Par contre, tu peux en effet tout à fait les afficher de la même façon, police ou taille. Tout ça, ce sera dans ton css, mais dans ta construction de page, c'est un `<h2>` ici (et pour les suivants aussi, évidemment).


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


Successfully aliased the URL <https://ronsenrock-cl9ztipqc.now.sh> to the following aliases:

* https://ronsenrock.hanshenrik.now.sh
* https://ronsenrock-git-master.hanshenrik.now.sh


commit 69969696


Successfully aliased the URL <https://lizwiki-48w9fyhha.now.sh> to the following aliases:

* https://liz.wiki
* https://lizwiki.lizhengnacl.now.sh
* https://lizwiki-git-master.lizhengnacl.now.sh


@gorhill Can you add `requestAnimationFrame-if.js` alias to make it more descriptive? I have problems deciphering these abbreviations sometimes (std/sid/raf).


please resolve the javadoc issues then it is a very nice work.


Good job, Ben! Looks great.


https://github.com/Jkeehan5/git-lab

This is the updated repository. For some reason it won't let me comment like it did last time.

Thanks,
Jake Keehan
________________________________
From: Mark May <notifications@github.com>
Sent: Wednesday, September 4, 2019 8:50 PM
To: Jkeehan5/git-lab <git-lab@noreply.github.com>
Cc: Keehan, Jake <jk414119@ohio.edu>; Mention <mention@noreply.github.com>
Subject: Re: [Jkeehan5/git-lab] update (345f307)

@Jkeehan5<https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJkeehan5&data=02%7C01%7Cjk414119%40ohio.edu%7C262d4ab16bd743f94bb608d7319b1916%7Cf3308007477c4a70888934611817c55a%7C0%7C0%7C637032414517246891&sdata=FrRlfI%2Fua0qB7poR%2BlPZxAWNcDEmO0atiC2Kf%2F2X81g%3D&reserved=0> You seem to be missing both answers.md on this repository and git-lab-program.cc on the git-lab-2 repository. Did you remember to push your changes? If you update this and tag and/or email me when you do I'll give you partial credit (90/100)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJkeehan5%2Fgit-lab%2Fcommit%2F345f307957654f987362edd9c014bafdf0ed0503%3Femail_source%3Dnotifications%26email_token%3DANA5ISPEWGLUOLMTOKGJEQLQIBJWTA5CNFSM4ITWUH62YY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBBKZIG%23commitcomment-34956550&data=02%7C01%7Cjk414119%40ohio.edu%7C262d4ab16bd743f94bb608d7319b1916%7Cf3308007477c4a70888934611817c55a%7C0%7C0%7C637032414517246891&sdata=s7FOBHdczsGJifdB6KsH2yXiLREuaEHbGhWCVrvv2tM%3D&reserved=0>, or mute the thread<https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FANA5ISO2XMTZQCTD35QRH3TQIBJWTANCNFSM4ITWUH6Q&data=02%7C01%7Cjk414119%40ohio.edu%7C262d4ab16bd743f94bb608d7319b1916%7Cf3308007477c4a70888934611817c55a%7C0%7C0%7C637032414517256890&sdata=7R6zx%2Byu8xphpeNkOC2gPhxg5mlM3PPS5OjOiyUenWU%3D&reserved=0>.


if this is outdated and not used, please remove this review from upsource.


Still need to figure out how to do this. Probably will need to abandon the use of URLs and use Files instead (as cross-references can only be resolved against file system locations).


[R/data_dates_holidays.r:30:43:](https://github.com/folkehelseinstituttet/fhidata/blob/b15a55309349d95959677c288d404498dbc982df/R/data_dates_holidays.r#L30) *style:* **Put spaces around all infix operators.**
```r
  norway_dates_holidays <- data.table(date=seq.Date(date_min, date_max, by=1))
                                         ~^~
```
[R/data_dates_holidays.r:30:75:](https://github.com/folkehelseinstituttet/fhidata/blob/b15a55309349d95959677c288d404498dbc982df/R/data_dates_holidays.r#L30) *style:* **Put spaces around all infix operators.**
```r
  norway_dates_holidays <- data.table(date=seq.Date(date_min, date_max, by=1))
                                                                         ~^~
```
[R/data_dates_holidays.r:31:26:](https://github.com/folkehelseinstituttet/fhidata/blob/b15a55309349d95959677c288d404498dbc982df/R/data_dates_holidays.r#L31) *style:* **Commas should always have a space after.**
```r
  norway_dates_holidays[,is_holiday:=FALSE]
                         ^
```
[R/data_dates_holidays.r:31:36:](https://github.com/folkehelseinstituttet/fhidata/blob/b15a55309349d95959677c288d404498dbc982df/R/data_dates_holidays.r#L31) *style:* **Put spaces around all infix operators.**
```r
  norway_dates_holidays[,is_holiday:=FALSE]
                                  ~^~~
```
[R/data_dates_holidays.r:32:33:](https://github.com/folkehelseinstituttet/fhidata/blob/b15a55309349d95959677c288d404498dbc982df/R/data_dates_holidays.r#L32) *style:* **Put spaces around all infix operators.**
```r
  norway_dates_holidays[info, on="date", is_holiday:=TRUE]
                               ~^~
```
[R/data_dates_holidays.r:32:52:](https://github.com/folkehelseinstituttet/fhidata/blob/b15a55309349d95959677c288d404498dbc982df/R/data_dates_holidays.r#L32) *style:* **Put spaces around all infix operators.**
```r
  norway_dates_holidays[info, on="date", is_holiday:=TRUE]
                                                  ~^~~
```
[R/data_gen_all.r:20:1:](https://github.com/folkehelseinstituttet/fhidata/blob/b15a55309349d95959677c288d404498dbc982df/R/data_gen_all.r#L20) *style:* **lines should not be more than 120 characters.**
```r
  save(norway_locations_long_current, file = file.path(base_loc, "norway_locations_long_current.rda"), compress = "bzip2")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/data_gen_all.r:22:1:](https://github.com/folkehelseinstituttet/fhidata/blob/b15a55309349d95959677c288d404498dbc982df/R/data_gen_all.r#L22) *style:* **lines should not be more than 120 characters.**
```r
  save(norway_locations_long_original, file = file.path(base_loc, "norway_locations_long_original.rda"), compress = "bzip2")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/data_gen_all.r:38:5:](https://github.com/folkehelseinstituttet/fhidata/blob/b15a55309349d95959677c288d404498dbc982df/R/data_gen_all.r#L38) *style:* **Commented code should be removed.**
```r
  # norway_map_counties <- gen_norway_map_counties()
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/data_gen_all.r:39:5:](https://github.com/folkehelseinstituttet/fhidata/blob/b15a55309349d95959677c288d404498dbc982df/R/data_gen_all.r#L39) *style:* **Commented code should be removed.**
```r
  # save(norway_map_counties, file=file.path("/git","/fhidata","data","norway_map_counties.rda"), compress = "xz")
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/data_gen_all.r:40:5:](https://github.com/folkehelseinstituttet/fhidata/blob/b15a55309349d95959677c288d404498dbc982df/R/data_gen_all.r#L40) *style:* **Commented code should be removed.**
```r
  # norway_map_municips <-  gen_norway_map_municips()
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/data_gen_all.r:41:5:](https://github.com/folkehelseinstituttet/fhidata/blob/b15a55309349d95959677c288d404498dbc982df/R/data_gen_all.r#L41) *style:* **Commented code should be removed.**
```r
  # save(norway_map_municips, file=file.path("/git","/fhidata","data","norway_map_municips.rda"), compress = "xz")
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/data_gen_all.r:43:5:](https://github.com/folkehelseinstituttet/fhidata/blob/b15a55309349d95959677c288d404498dbc982df/R/data_gen_all.r#L43) *style:* **Commented code should be removed.**
```r
  # load(file.path(base_loc,"norway_locations_current.rda"))
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/data_gen_all.r:44:5:](https://github.com/folkehelseinstituttet/fhidata/blob/b15a55309349d95959677c288d404498dbc982df/R/data_gen_all.r#L44) *style:* **Commented code should be removed.**
```r
  # load(file.path(base_loc,"norway_map_municips.rda"))
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/data_gen_all.r:45:5:](https://github.com/folkehelseinstituttet/fhidata/blob/b15a55309349d95959677c288d404498dbc982df/R/data_gen_all.r#L45) *style:* **Commented code should be removed.**
```r
  # senorge <- gen_senorge(norway_locations_current, norway_map_municips)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/data_gen_all.r:46:5:](https://github.com/folkehelseinstituttet/fhidata/blob/b15a55309349d95959677c288d404498dbc982df/R/data_gen_all.r#L46) *style:* **Commented code should be removed.**
```r
  # save(senorge, file=file.path(base_loc,"senorge.rda"), compress = "xz")
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/data_norway_map.R:79:12:](https://github.com/folkehelseinstituttet/fhidata/blob/b15a55309349d95959677c288d404498dbc982df/R/data_norway_map.R#L79) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  spgeo <- as.data.table(spgeo)
           ^~~~~~~~~~~~~
```
[R/data_norway_map.R:111:12:](https://github.com/folkehelseinstituttet/fhidata/blob/b15a55309349d95959677c288d404498dbc982df/R/data_norway_map.R#L111) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  spgeo <- as.data.table(spgeo)
           ^~~~~~~~~~~~~
```
[R/data_norway_municip_merging.r:43:1:](https://github.com/folkehelseinstituttet/fhidata/blob/b15a55309349d95959677c288d404498dbc982df/R/data_norway_municip_merging.r#L43) *style:* **lines should not be more than 120 characters.**
```r
  skeleton <- expand.grid(year = as.numeric(2006:maxYear), municip_code = unique(masterData$municip_code), stringsAsFactors = FALSE)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/data_norway_population.r:82:17:](https://github.com/folkehelseinstituttet/fhidata/blob/b15a55309349d95959677c288d404498dbc982df/R/data_norway_population.r#L82) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
    pop[[i]] <- melt.data.table(pop[[i]], id.vars = c("region", "age"))
                ^~~~~~~~~~~~~~~
```
[R/data_norway_population.r:228:1:](https://github.com/folkehelseinstituttet/fhidata/blob/b15a55309349d95959677c288d404498dbc982df/R/data_norway_population.r#L228) *style:* **lines should not be more than 120 characters.**
```r
  norway <- data.table(utils::read.csv(url("https://data.ssb.no/api/v0/dataset/59322.csv?lang=en"), stringsAsFactors = FALSE))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/require_namespace.r:9:1:](https://github.com/folkehelseinstituttet/fhidata/blob/b15a55309349d95959677c288d404498dbc982df/R/require_namespace.r#L9) *style:* **lines should not be more than 120 characters.**
```r
    stop(sprintf("Package(s) %s needed for this function to work. Please install it.", paste0(failure, collapse = ", ")), call. = FALSE)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


[R/download_classes.R:32:1:](https://github.com/russHyde/miiq/blob/f85ad0056bb0196bb0ff40ad6bb7468e156f745e/R/download_classes.R#L32) *style:* **functions should have cyclomatic complexity of less than 15, this has 27.**
```r
.check_marray_dl_config <- function(
^
```
[R/download_classes.R:125:25:](https://github.com/russHyde/miiq/blob/f85ad0056bb0196bb0ff40ad6bb7468e156f745e/R/download_classes.R#L125) *style:* **Variable and function name style should be snake_case.**
```r
  definition = function(.Object, ...) methods::callNextMethod()
                        ^~~~~~~
```
[R/import_classes.R:52:25:](https://github.com/russHyde/miiq/blob/f85ad0056bb0196bb0ff40ad6bb7468e156f745e/R/import_classes.R#L52) *style:* **Variable and function name style should be snake_case.**
```r
                        .Object,
                        ^~~~~~~
```
[R/import_classes.R:54:5:](https://github.com/russHyde/miiq/blob/f85ad0056bb0196bb0ff40ad6bb7468e156f745e/R/import_classes.R#L54) *style:* **Variable and function name style should be snake_case.**
```r
    .Object <- methods::callNextMethod()
    ^~~~~~~
```
[R/import_classes.R:132:1:](https://github.com/russHyde/miiq/blob/f85ad0056bb0196bb0ff40ad6bb7468e156f745e/R/import_classes.R#L132) *style:* **Variable and function name style should be snake_case.**
```r
MicroarrayImportConfig <- function(
^~~~~~~~~~~~~~~~~~~~~~
```
[R/list_manipulation.R:24:1:](https://github.com/russHyde/miiq/blob/f85ad0056bb0196bb0ff40ad6bb7468e156f745e/R/list_manipulation.R#L24) *style:* **functions should have cyclomatic complexity of less than 15, this has 18.**
```r
get_or_else <- function(
^
```
[R/microarray_classes.R:228:1:](https://github.com/russHyde/miiq/blob/f85ad0056bb0196bb0ff40ad6bb7468e156f745e/R/microarray_classes.R#L228) *style:* **Variable and function name style should be snake_case.**
```r
gld_fnBuilder_keepSample <- function(
^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/microarray_classes.R:265:1:](https://github.com/russHyde/miiq/blob/f85ad0056bb0196bb0ff40ad6bb7468e156f745e/R/microarray_classes.R#L265) *style:* **Variable and function name style should be snake_case.**
```r
gld_fnDefault_keepSample <- gld_fnBuilder_keepSample(
^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/microarray_classes.R:287:1:](https://github.com/russHyde/miiq/blob/f85ad0056bb0196bb0ff40ad6bb7468e156f745e/R/microarray_classes.R#L287) *style:* **Variable and function name style should be snake_case.**
```r
gld_fnDefault_keepProbe <- function(
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/microarray_classes.R:326:1:](https://github.com/russHyde/miiq/blob/f85ad0056bb0196bb0ff40ad6bb7468e156f745e/R/microarray_classes.R#L326) *style:* **Variable and function name style should be snake_case.**
```r
gld_fnBuilder_exptDesign <- function(
^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/microarray_classes.R:327:38:](https://github.com/russHyde/miiq/blob/f85ad0056bb0196bb0ff40ad6bb7468e156f745e/R/microarray_classes.R#L327) *style:* **Variable and function name style should be snake_case.**
```r
                                     treatment.cols = NULL,
                                     ^~~~~~~~~~~~~~
```
[R/microarray_classes.R:328:38:](https://github.com/russHyde/miiq/blob/f85ad0056bb0196bb0ff40ad6bb7468e156f745e/R/microarray_classes.R#L328) *style:* **Variable and function name style should be snake_case.**
```r
                                     design.fn = NULL) {
                                     ^~~~~~~~~
```
[R/microarray_classes.R:389:1:](https://github.com/russHyde/miiq/blob/f85ad0056bb0196bb0ff40ad6bb7468e156f745e/R/microarray_classes.R#L389) *style:* **Variable and function name style should be snake_case.**
```r
gld_fnDefault_exptDesign <- gld_fnBuilder_exptDesign(
^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/microarray_classes.R:413:1:](https://github.com/russHyde/miiq/blob/f85ad0056bb0196bb0ff40ad6bb7468e156f745e/R/microarray_classes.R#L413) *style:* **Variable and function name style should be snake_case.**
```r
gld_fnDefault_esetAnnotation <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/microarray_classes.R:462:1:](https://github.com/russHyde/miiq/blob/f85ad0056bb0196bb0ff40ad6bb7468e156f745e/R/microarray_classes.R#L462) *style:* **Variable and function name style should be snake_case.**
```r
gld_fnDefault_transformAndProbeFilter <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/microarray_functions.R:323:37:](https://github.com/russHyde/miiq/blob/f85ad0056bb0196bb0ff40ad6bb7468e156f745e/R/microarray_functions.R#L323) *style:* **Variable and function name style should be snake_case.**
```r
                                    entrezgene.db) {
                                    ^~~~~~~~~~~~~
```
[R/microarray_functions.R:437:30:](https://github.com/russHyde/miiq/blob/f85ad0056bb0196bb0ff40ad6bb7468e156f745e/R/microarray_functions.R#L437) *style:* **Variable and function name style should be snake_case.**
```r
    Biobase::featureData(es)$entrez.id <- es_entrez_id
                             ^~~~~~~~~
```


Successfully aliased the URL <https://codesandbox-client-kl4hlekfb.now.sh> to the following aliases:

* https://storybook-codesandbox.now.sh
* https://codesandbox-client.codesandbox1.now.sh
* https://codesandbox-client-git-master.codesandbox1.now.sh


I'd && them.


0 oder freilassen für nichts? oder 0/1?


Это не скомпилированные файлы, очевидно.


Successfully aliased the URL <https://main-site-okv93mgoe.now.sh> to the following aliases:

* https://fcc-mcr.now.sh
* https://main-site.fcc-mcr.now.sh
* https://main-site-git-master.fcc-mcr.now.sh


Successfully aliased the URL <https://markslide-di6ig36ee.now.sh> to the following aliases:

* https://markslide.now.sh
* https://dev.markslide.now.sh
* https://markslide.markslide.now.sh
* https://markslide-git-master.markslide.now.sh


I tested it without the CA cert, and it worked. However I do see in the helm docs --tls-ca-cert flag is always included.


Dear @PoorGT,
> I regret to inform you that your plugin "**NameUI**" (v1.2 submitted on 2019-09-06T11:32:30.000Z) has been rejected.

B3 — No useless messages in startup/shutdown:
> Plugins must not output unnecessary status messages like "I have been enabled", "Author: Xxx", etc., unless the plugin startup/shutdown takes really much time (more than 1 second) such that the user may become impatient. See https://forums.pmmp.io/threads/clean-up-our-consoles.5656/

Please resolve these issues and submit the plugin again.

> This comment is posted here because this is the last commit when the released build was created.


First commit for functClust


Type is `VersionPolicy`, not `String`


Alors, moi, je me répète, je suis une grosse pine en css, MAIS:
 ```diff
- <div class="separateur">
-     <div class="first"></div>
-     <div class="point"></div>
-     <div class="second"></div>
- </div>
+ <div class="separator"></div>
```

Bon, déjà, à la place du `<div>`, potentiellement tu peux mettre un `<pan>`, mais c'est à confirmer. Dans tous les cas, pour moi, sémantiquement, il ne devrait y avoir qu'**un seul élément**. C'est ton css qui devrait modéliser tes deux traits et ton point.
Je pense que c'est faisable, si tu utilises des `::before`, `::after` et des `background-images`.


Any reason to use `(try <code> (catch Exception e (raise e)))` instead of `<code>`? Why catching the exception if we just re-throw it?


Successfully aliased the URL <https://api-95ls46x7i.now.sh> to the following aliases:

* https://api.lokibai.com
* https://api.uniquexiaobai.now.sh
* https://api-git-master.uniquexiaobai.now.sh


@JuliaRegistrator register


```diff
- <span>
+<p>
```
Un paragraphe de texte devrait je pense être représenté par un tag paragraphe.


Registration pull request updated: [JuliaRegistries/General/3197](https://github.com/JuliaRegistries/General/pull/3197)

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if [Julia TagBot](https://github.com/apps/julia-tagbot) is installed, or can be done manually through the github interface, or via:
```
git tag -a v0.1.0 -m "<description of version>" da0b75838baffa15a09d7c800468ba881b9efce0
git push origin v0.1.0
```


Deployment failed with the following error:

~~~
The chosen alias "niyon-app.now.sh" is already in use by another account.
~~~


Successfully aliased the URL <https://gotermux-7m71uq31y.now.sh> to the following aliases:

* https://gotermux.mysh.now.sh
* https://gotermux-git-master.mysh.now.sh


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


Successfully aliased the URL <https://eusy-je8oa70l6.now.sh> to the following aliases:

* https://eusy.briandombrowski.now.sh
* https://eusy-git-master.briandombrowski.now.sh


```diff
- <h2>UX design</h2>
- <span class="text">Prendre en considération l'Experience ...
+<h3 class="text text-features__title">UX design</h3>
+ <p class="text text-features__content">Prendre en considération l'Experience ...
```

* Même remarque pour que tout à l'heure pour la hiérarchie des titres, c'est global à la page.
* Mêmes remarques pour le span et les class, c'était pour l'exemple !


you don't use the enum here; condition test must be of the form `versionPolicy == VersionPolicy.RELEASE`
also you can use a switch case:
```
		switch (versionPolicy) {
		case VersionPolicy.RELEASE:
			repository.createMavenHosted(name, blobstore, true, VersionPolicy.RELEASE, WritePolicy.ALLOW, LayoutPolicy.STRICT);
			break;

		case VersionPolicy.SNAPSHOT:
			repository.createMavenHosted(name, blobstore, true, VersionPolicy.SNAPSHOT, WritePolicy.ALLOW, LayoutPolicy.STRICT);
			break;

		default:
			repository.createMavenHosted(name, blobstore, true, VersionPolicy.MIXED, WritePolicy.ALLOW, LayoutPolicy.STRICT);
			break;
```

Default to mixed rather than explicit?
It sounds ok but I would have used explicit MIXED enum and no default (ie mandatory option).


accessibilité, mais on en a déjà parlé ^^


Коммит содержит много различных изменений, и тем самым не соответствует названию.


Change this to Token is disabled.


Что это за километровые отступы? Должно быть 4 пробела.
Слишком много пустых строк. Во круг классов должно быть 2 пустые строки.


Guess I'm missing something but these are different then the interface json descriptions, right? These are more plugin descriptions.
Where is for example the DeviceIdentificationAPI.json located it refers to?


Successfully aliased the URL <https://app-acoa8egmg.now.sh> to the following aliases:

* https://app.communiteths.now.sh
* https://app-git-master.communiteths.now.sh


Registration pull request created: [JuliaRegistries/General/3327](https://github.com/JuliaRegistries/General/pull/3327)

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if [Julia TagBot](https://github.com/apps/julia-tagbot) is installed, or can be done manually through the github interface, or via:
```
git tag -a v0.2.0 -m "<description of version>" 91459e00e70c9f29bfd593d0702b3899b1adbf0d
git push origin v0.2.0
```


Successfully aliased the URL <https://portfolio-1iy1bf03m.now.sh> to the following aliases:

* https://dustinhaefele.com
* https://portfolio.dustinhaefele.now.sh
* https://portfolio-git-master.dustinhaefele.now.sh


Снова, что с отступами? Они в этом языке часть синтаксиса.
Зачем в этом коммите добавляются пустые строки? Это не относится к тому, что этот коммит заявляет в названии.


Oops, didn't mean to do this... but meh, should work


Successfully aliased the URL <https://amp-ffassunln.now.sh> to the following aliases:

* https://amp.ahoirilaila.now.sh
* https://amp-git-master.ahoirilaila.now.sh


삭제된 글입니다.


Successfully aliased the URL <https://airship-rescue-kqei3pjnm.now.sh> to the following aliases:

* https://airship-rescue.org
* https://airship-rescue.saschametzger.now.sh
* https://airship-rescue-git-master.saschametzger.now.sh


Successfully aliased the URL <https://amp-j2yiufxvc.now.sh> to the following aliases:

* https://amp.ahoirilaila.now.sh
* https://amp-git-master.ahoirilaila.now.sh


Successfully aliased the URL <https://portfolio-fmc62cb1y.now.sh> to the following aliases:

* https://dustinhaefele.com
* https://portfolio.dustinhaefele.now.sh
* https://portfolio-git-master.dustinhaefele.now.sh


Successfully aliased the URL <https://lokibai-dkjnl1odm.now.sh> to the following aliases:

* https://lokibai.com
* https://lokibai.uniquexiaobai.now.sh
* https://lokibai-git-master.uniquexiaobai.now.sh


Oh, sure. Good catch!:)


Коммит должен приводить проект в рабочее состояния. Ты же добавляешь рут на html, которого не существует в проекте.


Successfully aliased the URL <https://codesandbox-client-20ga8h0sg.now.sh> to the following aliases:

* https://storybook-codesandbox.now.sh
* https://codesandbox-client.codesandbox1.now.sh
* https://codesandbox-client-git-master.codesandbox1.now.sh


Это можно было бы объединить с предыдущим коммитом. По логике они очень близки.


This seems bad. This should default to false.


Successfully aliased the URL <https://frontend-8qjlacf6v.now.sh> to the following aliases:

* https://niyon-frontend-dev.now.sh
* https://frontend.labseu2-niyon.now.sh
* https://frontend-git-master.labseu2-niyon.now.sh


Hi @kl0u! I wonder what the backwards compatibility concerns here? I cannot find any usage and don't know how backwards compatibility breaks here.


Опять отступы в километр. Еще и не консистентные. Откуда они?
Syntax, а не sintaxsis.


> Breaks forks (it's their issue tho.)
> Does it also handle the .update issue for GayRoku peeps ?


Successfully aliased the URL <https://amp-8zgvg5szu.now.sh> to the following aliases:

* https://amp.ahoirilaila.now.sh
* https://amp-git-master.ahoirilaila.now.sh


@hex2a not sure if you noticed, but the latest release addresses this issue along with a few other fixes: https://github.com/weaveworks/eksctl/releases/tag/0.5.2


Successfully aliased the URL <https://sandbarandislandgrill-n6wc4lors.now.sh> to the following aliases:

* https://sandbarandislandgrill.unspecified.now.sh
* https://sandbarandislandgrill-git-master.unspecified.now.sh


```diff
- <p>
-    <input type="text" name="nom" id="nom" placeholder='Name' />
+    <input type="text" name="contact[name]" id="contact-name" placeholder="Nom" />
-</p>
```

Les balises `<p>` sont là pour délimiter des paragraphes de texte. Tu peux très bien mettre des inputs sans les encadrer, ou si tu veux les regrouper, utiliser les tags `<fieldset>` qui servent à ça (et dans ce cas peut-être personnaliser leur apparence dans le css).

Aussi, méfies toi du franglais (ici, ton site entier est en français mais le placeholder est en anglais).


> hmm okey

yes, i say this error in gamepedia :)


@JordiVilaTRSB  pourquoi le supprimer ?


I agree @TisonKun but @zentol pointed out that some users are programming directly again the `ClusterClient` and this would be a breaking change for them.


Extract all storage logic to a service (let's say `ICookieProvider`) and inject it to `UsersController`'s ctor


hmm


Don't store parts, but instead create a model with all fields and store it in cookies (hint: use `JsonConvert.SerializeObject` to store the model as a string)


Successfully aliased the URL <https://homepage-8zyr6uqyw.now.sh> to the following aliases:

* https://ethicalcode.com.au
* https://homepage.ethicalcode.now.sh
* https://homepage-git-master.ethicalcode.now.sh


I would rename the method to `Result`


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


```diff
- <input type="button" id="button" value='Send Messsage' />
+ <input type="submit" class="btn btn--submit" value="Send Messsage" />
```

Plusieurs remarques :
* Pour le `type` du bouton: j'ai mis submit, mais dans un contexte d'intégration pur, je pense que `type="button"` serait carrément correct (voire plus ?)
* On est dans un contexte ou l'ID ne te sert pas vraiment. L'idée, c'est d'utiliser la même classe "globale" que pour ton bouton "Plus d'informations" de tout à l'heure, et de le customiser avec la classe `btn__submit`
* Fais bien attention, à part peut-être quand on met du javascript, dans certains cas, on utilise toujours des double quotes (les guillemets) et pas des simples quotes (apostrophes) en HTML/CSS.


Be careful not to ship this without checking that

playlist.durationUs - playlist.targetDurationUs * 2 >= 0


Successfully aliased the URL <https://sandbarandislandgrill-gdz45l3ig.now.sh> to the following aliases:

* https://sandbarandislandgrill.unspecified.now.sh
* https://sandbarandislandgrill-git-master.unspecified.now.sh


Closes #36


Try to create the following routes:
/users/register/step1
/users/register/step2
...
/users/register/stepN
/users/register/complete


Hello, I was wondering if you could help me with an issue with this task you added.
When deploying the build the origin, dest, and destDisplay variables of this line:
const shoutTasks = function(res, data, origin, dest, destDisplay)
Throw a no unused variable warning. I was wondering if they serve an actual purpose or if they can just be removed.


Thanks, I missed that (updated contacts page with new names only)


Interesting, TIL.


related issues https://github.com/kmagiera/react-native-gesture-handler/issues/749


All the validation should go to one place. Restrict the user only on Complete page if the registration is not finished


In general I agree. However, addition of references ``` [`compute_Mlincomb`](@ref) ``` does not work otherwise. As discussed in #204 and (partially) implemented in [224b9c0](224b9c09f263818f604692416c5681d7272727f0)


Redirect to `Continue`


The method should take no parameters


Do you really need lines 23-24?


Use `AddSingleton`


Je ne comprends pas trop


هلا


Do you have test for this specific case? Do we need to return non empty optional here?


Ce sont les problèmes de connexion


Use some service instead, don't talk to cookies directly from views


Thank you very much for this little tweak! Now I think I'll add the little sequence even on the airship, should make sense (so a grate will open to let us sail the ship). Looking forward to your Portal project too, cool stuff :smiley:


Il serait plus judicieux d'utiliser un fichier `fonts.css` dédié et de l'importer dans ton `<head>`, comme le premier.

Pour un projet de cette taille là, je t'accorde que ça n'a pas un énorme impact, mais en réalité, c'est quand même une bonne pratique de regrouper les "fonctionnalités" par fichier, même pour le css.

![Capture d’écran 2019-09-06 à 16 04 46](https://user-images.githubusercontent.com/9444448/64434081-12d8b100-d0c0-11e9-8d42-c48b5193f42a.png)

Je te mets une image d'un projet existant chez moi, mais par exemple, nous, tout notre css il est dans un dossier `assets\css` (ça, c'est inhérent à Symfony ou à des projets plus importants, c'est aussi là qu'on met le javascript).
Comme tu le vois, on sépare tous nos css en différentes catégories/fonctions pour pouvoir s'y retrouver même si on ne connait pas trop le projet et pour avoir des fichiers de 3000 lignes.

>Chez nous, le CSS, il a une extensio, `.scss`, on peut en reparler plus tard, te prends pas la tête la dessus, c'est une librairie spéciale. Dans notre cas, on importe tout dans `app.scss` et on importe ce fichier là dans le `<head>`, mais pour toi, importer les deux fichiers séparément directement dans le HTML suffira LARGEMENT.


Minuscule détail, pense à sauter des lignes entre différents éléments.


Observações implementadas


Could you add a test where corr_sym > constant literal?


Why is it removed, make sure before you remove anything, please cross-check with me.


Imho we could add more JS magic here and thus create some kind of framework to generalise how confirmation dialogs are handled.

I think here about something like
* User klicks delete
* If JS is enabled
  * It has already replaced the link (which should be a form anyway -> XSS) to catch the klick
  * JS Shows a confirmation Popup
  * User klicks OK
  * XHR request to the form destination
  * Destination responds with JSON "ok"
  * Popup/confirmation message shows up (what about small popups in the right bottom corner for example?)
* Else
  * POST to a confirmation page (should be the same target)
  * User klicks confirm which get send to the same page
  * User gets redirected to the page where he deleted the item
  * Page shows confirmation message
  * And removes the deleted rows from a table / does whatever action is required


Rename this class to something like `UserDetails` or `UserFullName`


Recette rapide de l'houmous

Cette recette permet d'obtenir rapidement un houmous savoureux, sans complications. C'est une adaptation de plusieurs recettes différentes que j'ai essayées au fil des ans.

L'houmous est une délicieuse pâte épaisse utilisée dans les plats en Grèce et au moyen-orient. Il s'accorde très bien avec la salade, les viandes grillées et du pain calabrais.

Ingrédients

1 boîte (400 g) de pois chiches (garbanzos)

175g de crème de sésame

6 tomates séchées

un demi poivron rouge

une pincée de piment de Cayenne

1 gousse d'ail

un trait d'huile d'olive

Instructions

Ôter la peau de l'ail et le hacher grossièrement.

Enlever les graines et la tige du poivron, le hacher grossièrement.

Mettre tous les ingrédients dans un robot mixer jusqu'à l'obtention d'une pâte.

Si vous voulez un houmous grenu, ne le mixez pas trop longtemps.

Si vous voulez un houmous lisse, mixez-le plus longtemps.

Pour des saveurs différentes, vous pouvez essayer d'y mettre un peu de jus de citron et de coriandre, du tabasco, de la limette et du chipotle, de la harissa et de la menthe ou des épinards et de la feta. Essayez et voyez ce qui vous va.

Conservation

Mettez l'houmous fini au réfrigérateur dans un récipient fermé. Vous le garderez ainsi pendant environ une semaine. S'il se met à fermenter, jettez‑le sans hésiter.

L'houmous peut être congelé ; consommez‑le dans les deux mois qui suivent sa congélation.


L'aggiunta dell'oggetto sidebar per la configurazione della sidebar prelude al fetch dei dati da un db


Thanks for your explanation @kl0u. In fact my colleagues develop a platform based on Flink and they also program directly against `ClusterClient` for what we propose to be changed in client apis side. However, when we bump to a new version, it is planned we make some corresponding adaptations.

Also I'd like to point out that `ClusterClient` is not an interface marked as `@Public` or `@PublicEvolving`. Given that we are blocked by some legacy code accidentally marked as `@Public(Evolving)` while some interfaces we want to provide backward compatibility are not marked. I think it could be the time or so to discuss our InterfaceAudience policy. At least it would be a pity if we don't address this InterfaceAudience issue towards 2.0.


Same here


Successfully aliased the URL <https://top-api-aeacc7wz9.now.sh> to the following aliases:

* https://top-api.lokibai.com
* https://top-api.uniquexiaobai.now.sh
* https://top-api-git-master.uniquexiaobai.now.sh


---
layout:     post
title:      ReactiveCocoa 进阶
subtitle:   函数式编程框架 ReactiveCocoa 进阶
date:       2017-01-06
author:     BY
header-img: img/post-bg-ios9-web.jpg
catalog: true
tags:
    - iOS
    - ReactiveCocoa
    - 函数式编程
    - 开源框架
---
# 前言

>在[上篇文章](http://qiubaiying.github.io/2016/12/26/ReactiveCocoa-基础/)中介绍了**ReactiveCocoa**的基础知识,接下来我们来深入介绍**ReactiveCocoa**及其在**MVVM**中的用法。

![ReactiveCocoa进阶思维导图](https://ww3.sinaimg.cn/large/006y8lVagw1fbgye3re5xj30je0iomz8.jpg)
# 常见操作方法介绍

#### 操作须知

所有的信号（RACSignal）都可以进行操作处理，因为所有操作方法都定义在RACStream.h中，因此只要继承RACStream就有了操作处理方法。
#### 操作思想

运用的是Hook（钩子）思想，Hook是一种用于改变API(应用程序编程接口：方法)执行结果的技术.

Hook用处：截获API调用的技术。

有关Hook的知识可以看我的这篇博客[《Objective-C Runtime 的一些基本使用》](http://www.jianshu.com/p/ff114e69cc0a)中的 *更换代码的实现方法* 一节,

Hook原理：在每次调用一个API返回结果之前，先执行你自己的方法，改变结果的输出。

#### 操作方法


Tu as fait un sacré boulot, je t'ai mis plein de notes évidemment, mais franchement c'est solide.

Je te rajoute quelques remarque de Tof et moi que je ne savais pas où mettre :
* Pour quelle raison redéfinir régulièrement la font-family pour chaque ID ?
* Pourquoi intégrer une iframe qui contient un google maps plutôt qu'un screen de google maps ? Ca fait lourd pour pas grand chose sachant qu'il y a un overlay qui empeche de l'utiliser
* L'affichage des projets n'est pas conforme à la maquette (j'en ai 5 et 3 sur respectivement la première et deuxième ligne sur mon écran 24").


1. Заменить compile на implementation в строке 216.
2. Никогда не использовать '+' в зависимостях (об этом даже студия говорит). Заменить на 1.1.0 в строке 216
3. Не понял, зачем добавлен репозиторий mavenCentral ? Без него все собралось нормально. Если он все таки нужен, то переместить это обьявление в файл xabber-android/buil.gradle туда же, где все репозитории обьявлены. Здесь этому не место.


Successfully aliased the URL <https://nodejs-fuuyz6xzv.now.sh> to the following aliases:

* https://nodejs.jessetijsma.now.sh
* https://nodejs-git-master.jessetijsma.now.sh


/home/mukul/sample of journal website/1.css
/home/mukul/sample of journal website/1.html
/home/mukul/sample of journal website/9.html
/home/mukul/sample of journal website/834657be44ec30b2de6d92d4326ea090.ico.zip
/home/mukul/sample of journal website/about.html
/home/mukul/sample of journal website/android-icon-36x36.png
/home/mukul/sample of journal website/android-icon-48x48.png
/home/mukul/sample of journal website/android-icon-72x72.png
/home/mukul/sample of journal website/android-icon-96x96.png
/home/mukul/sample of journal website/android-icon-144x144.png
/home/mukul/sample of journal website/android-icon-192x192.png
/home/mukul/sample of journal website/apple-icon.png
/home/mukul/sample of journal website/apple-icon-57x57.png
/home/mukul/sample of journal website/apple-icon-60x60.png
/home/mukul/sample of journal website/apple-icon-72x72.png
/home/mukul/sample of journal website/apple-icon-76x76.png
/home/mukul/sample of journal website/apple-icon-114x114.png
/home/mukul/sample of journal website/apple-icon-120x120.png
/home/mukul/sample of journal website/apple-icon-144x144.png
/home/mukul/sample of journal website/apple-icon-152x152.png
/home/mukul/sample of journal website/apple-icon-180x180.png
/home/mukul/sample of journal website/apple-icon-precomposed.png
/home/mukul/sample of journal website/Blog.jpg
/home/mukul/sample of journal website/book.png
/home/mukul/sample of journal website/browserconfig.xml
/home/mukul/sample of journal website/contact.html
/home/mukul/sample of journal website/cs.html
/home/mukul/sample of journal website/faq.html
/home/mukul/sample of journal website/favicon.ico
/home/mukul/sample of journal website/favicon-16x16.png
/home/mukul/sample of journal website/favicon-32x32.png
/home/mukul/sample of journal website/favicon-96x96.png
/home/mukul/sample of journal website/footer.css
/home/mukul/sample of journal website/journal.png
/home/mukul/sample of journal website/journalb.jpg
/home/mukul/sample of journal website/load.js
/home/mukul/sample of journal website/loading.css
/home/mukul/sample of journal website/loading.html
/home/mukul/sample of journal website/login.html
/home/mukul/sample of journal website/logo.png
/home/mukul/sample of journal website/manifest.json
/home/mukul/sample of journal website/math.html
/home/mukul/sample of journal website/ms-icon-70x70.png
/home/mukul/sample of journal website/ms-icon-144x144.png
/home/mukul/sample of journal website/ms-icon-150x150.png
/home/mukul/sample of journal website/ms-icon-310x310.png
/home/mukul/sample of journal website/search.css
/home/mukul/sample of journal website/signup.html


[R/ods_find_higher_geographies.R:17:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_find_higher_geographies.R#L17) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_find_higher_geographies.R:19:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_find_higher_geographies.R#L19) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_find_higher_geographies.R:22:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_find_higher_geographies.R#L22) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_find_higher_geographies.R:25:60:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_find_higher_geographies.R#L25) *style:* **Commented code should be removed.**
```r
    ?data <http://purl.org/linked-data/sdmx/2009/dimension#refArea> ?geographyURI.
                                                           ^~~~~~~~~~~~~~~~~~~~~~~
```
[R/ods_find_higher_geographies.R:33:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_find_higher_geographies.R#L33) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_find_higher_geographies.R:35:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_find_higher_geographies.R#L35) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_find_higher_geographies.R:37:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_find_higher_geographies.R#L37) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_find_lower_geographies.R:17:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_find_lower_geographies.R#L17) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_find_lower_geographies.R:19:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_find_lower_geographies.R#L19) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_find_lower_geographies.R:22:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_find_lower_geographies.R#L22) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~~~~~~~~~~~
```
[R/ods_find_lower_geographies.R:25:74:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_find_lower_geographies.R#L25) *style:* **Commented code should be removed.**
```r
                  ?data <http://purl.org/linked-data/sdmx/2009/dimension#refArea> ?geographyURI.
                                                                         ^~~~~~~~~~~~~~~~~~~~~~~
```
[R/ods_find_lower_geographies.R:33:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_find_lower_geographies.R#L33) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_find_lower_geographies.R:35:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_find_lower_geographies.R#L35) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_find_lower_geographies.R:37:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_find_lower_geographies.R#L37) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_get_csv.R:30:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_get_csv.R#L30) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/ods_print_query.R:21:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L21) *style:* **functions should have cyclomatic complexity of less than 15, this has 16.**
```r
ods_print_query <- function(dataset,
^
```
[R/ods_print_query.R:26:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L26) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:43:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L43) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:56:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L56) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:63:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L63) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:75:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L75) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/ods_print_query.R:78:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L78) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:81:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L81) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:101:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L101) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:103:5:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L103) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!is.null(geography)) {
    ^
```
[R/ods_print_query.R:104:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L104) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/ods_print_query.R:106:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L106) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/ods_print_query.R:112:58:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L112) *style:* **Only use double-quotes.**
```r
                                                   (stop('Geography code not in sc, la, hd, iz, or dz'))
                                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ods_print_query.R:114:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L114) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/ods_print_query.R:115:151:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L115) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
    query_addition <- paste0("filter (strstarts(strafter(str(?refAreaURI),'http://statistics.gov.scot/id/statistical-geography/'),'", geo_code, "'))." )
                                                                                ^
```
[R/ods_print_query.R:116:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L116) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/ods_print_query.R:119:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L119) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:123:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L123) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:129:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L129) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:131:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L131) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/ods_print_query.R:134:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L134) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/ods_print_query.R:142:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L142) *style:* **Trailing whitespace is superfluous.**
```r

^~~~~~~~
```
[R/ods_print_query.R:159:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L159) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/ods_print_query.R:161:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L161) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/ods_print_query.R:163:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L163) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:166:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L166) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:169:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L169) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/ods_print_query.R:171:1:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/R/ods_print_query.R#L171) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[tests/testthat/test_ods_dataset.R:39:4:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/tests/testthat/test_ods_dataset.R#L39) *style:* **Commented code should be removed.**
```r
#  skip_on_cran()
   ^~~~~~~~~~~~~~
```
[tests/testthat/test_ods_dataset.R:40:4:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/tests/testthat/test_ods_dataset.R#L40) *style:* **Commented code should be removed.**
```r
#  expect_equal(ods_dataset(dataset = "average-household-size", geography = "S12000039")$refArea[1], "West Dunbartonshire")
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_dataset.R:44:4:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/tests/testthat/test_ods_dataset.R#L44) *style:* **Commented code should be removed.**
```r
#  skip_on_cran()
   ^~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:1:2:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/tests/testthat/test_ods_print_query.R#L1) *style:* **Commented code should be removed.**
```r
#context("ods_print_query")
 ^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:3:2:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/tests/testthat/test_ods_print_query.R#L3) *style:* **Commented code should be removed.**
```r
#expected_return_value1 <- "PREFIX qb: <http://purl.org/linked-data/cube#>"
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:4:2:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/tests/testthat/test_ods_print_query.R#L4) *style:* **Commented code should be removed.**
```r
#expected_return_value2 <- "PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>"
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:5:2:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/tests/testthat/test_ods_print_query.R#L5) *style:* **Commented code should be removed.**
```r
#expected_return_value3 <- "PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>"
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:6:2:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/tests/testthat/test_ods_print_query.R#L6) *style:* **Commented code should be removed.**
```r
#expected_return_value4 <- "select  \\?value where \\{ \\?data qb:dataSet <http://statistics\\.gov\\.scot/data/average-house-size>\\. \\?data  \\.  rdfs:label \\. \\?data  \\.  rdfs:label \\. \\?data \\?measureTypeURI \\?value\\. \\}"
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:7:2:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/tests/testthat/test_ods_print_query.R#L7) *style:* **Commented code should be removed.**
```r
#expected_return_value5 <- "select  \\?value where \\{ \\?data qb:dataSet <http://statistics\\.gov\\.scot/data/average-house-size>\\. \\?data  \\.  rdfs:label \\. \\?data  \\.  rdfs:label \\. FILTER \\(\\?refPeriod >= '2017'\\^\\^xsd:date && \\?refPeriod <= '2018'\\^\\^xsd:date\\) \\?data \\?measureTypeURI \\?value\\. \\}"
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:9:2:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/tests/testthat/test_ods_print_query.R#L9) *style:* **Commented code should be removed.**
```r
#printed_query <- ods_print_query("average-house-size")
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:15:4:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/tests/testthat/test_ods_print_query.R#L15) *style:* **Commented code should be removed.**
```r
#  skip_on_cran()
   ^~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:16:4:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/tests/testthat/test_ods_print_query.R#L16) *style:* **Commented code should be removed.**
```r
#  expect_match(printed_query, expected_return_value1)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:17:4:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/tests/testthat/test_ods_print_query.R#L17) *style:* **Commented code should be removed.**
```r
#  expect_match(printed_query, expected_return_value2)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:18:4:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/tests/testthat/test_ods_print_query.R#L18) *style:* **Commented code should be removed.**
```r
#  expect_match(printed_query, expected_return_value3)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:19:4:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/tests/testthat/test_ods_print_query.R#L19) *style:* **Commented code should be removed.**
```r
#  expect_match(printed_query, expected_return_value4)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:23:4:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/tests/testthat/test_ods_print_query.R#L23) *style:* **Commented code should be removed.**
```r
#  skip_on_cran()
   ^~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:24:4:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/tests/testthat/test_ods_print_query.R#L24) *style:* **Commented code should be removed.**
```r
#  expect_match(printed_query_with_filter, expected_return_value1)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:25:4:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/tests/testthat/test_ods_print_query.R#L25) *style:* **Commented code should be removed.**
```r
#  expect_match(printed_query_with_filter, expected_return_value2)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:26:4:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/tests/testthat/test_ods_print_query.R#L26) *style:* **Commented code should be removed.**
```r
#  expect_match(printed_query_with_filter, expected_return_value3)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_ods_print_query.R:27:4:](https://github.com/DataScienceScotland/opendatascot/blob/645420bcd5dadc3ad90d7cbb7a453f5ed85d35f1/tests/testthat/test_ods_print_query.R#L27) *style:* **Commented code should be removed.**
```r
#  expect_match(printed_query_with_filter, expected_return_value5)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


VALUE 타입으로 변경해야 제대로 동작한다.


Successfully aliased the URL <https://spacedos-gui-3czyioe4n.now.sh> to the following aliases:

* https://gui.spacedos.com
* https://spacedos-gui.spacedos.now.sh
* https://spacedos-gui-git-master.spacedos.now.sh


I would say no rewrite needed as there is effectively no correlation


Successfully aliased the URL <https://parafuso-kljyrdrjy.now.sh> to the following aliases:

* https://parafuso.renatoelysiqueira.now.sh
* https://parafuso-git-master.renatoelysiqueira.now.sh


И еще зависимости для котлина выделить в отдельную группу и не смешивать с тестами:
```
// kotlin
implementation "androidx.core:core-ktx:1.1.0"
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
```


First Comment


Dear Poggit user,

This is an automatic message from Poggit-CI. Poggit-CI was triggered by this commit, but failed to create builds due to the following error:

```
Error parsing .poggit.yml: Level 0: yaml_parse(): scanning error
encountered during parsing: mapping values are not allowed in this context
(line 3, column 9) in /poggit/src/poggit/webhook/PushHandler.php#85
```

As a result, no builds could be created from this commit. More details might be available for repo admins at [the webhook delivery response log](https://github.com/davidlouis101/TutorialPlugin/settings/hooks) — see the webhook starting with `https://poggit.pmmp.io/webhooks.gh.repo` and look for the delivery with ID `246e402e-d0b1-11e9-8ee2-748cc6bc4130`.

Shall you need any assistance, you may contact us on [on Discord](https://discord.gg/NgHf9jt), or more publicly, [on GitHub](https://github.com/poggit/support/issues). Commenting on this commit directly will **not** notify any Poggit staff.

Regards,
Poggit Bot (@poggit-bot)
The official Poggit automation account


201502019 김기범


Now could not deploy this pull request since the "files" configuration in `now.json` lists these files or directories which do not exist:

* `dist`

These paths may be missing from the GitHub repository because of a `.gitignore` file.
Consider committing them to GitHub or removing them from the "files" list and generating the paths on Now instead using a [build script for a Node.js deployment](https://zeit.co/docs/deployment-types/node), or within your `Dockerfile` for a [docker deployment](https://zeit.co/docs/deployment-types/docker).

For more information on the "files" configuration in now.json, visit [https://zeit.co/docs/features/configuration#files(array)](https://zeit.co/docs/features/configuration#files(array))


Successfully aliased the URL <https://cassandra-92yayjv7i.now.sh> to the following aliases:

* https://cassandra.now.sh
* https://cassandra.merelinguist.now.sh
* https://cassandra-git-master.merelinguist.now.sh


Why not use mapper as in previous code version?


God please no...NOOOOOOOOOOOOOOOOOOOO


Dear Poggit user,

This is an automatic message from Poggit-CI. Poggit-CI was triggered by this commit, but failed to create builds due to the following error:

```
Error parsing .poggit.yml: Level 0: yaml_parse(): scanning error
encountered during parsing: mapping values are not allowed in this context
(line 3, column 9) in /poggit/src/poggit/webhook/PullRequestHandler.php#72
```

As a result, no builds could be created from this commit. More details might be available for repo admins at [the webhook delivery response log](https://github.com/davidlouis101/TutorialPlugin/settings/hooks) — see the webhook starting with `https://poggit.pmmp.io/webhooks.gh.repo` and look for the delivery with ID `6723a990-d0b1-11e9-87ea-76791e878870`.

Shall you need any assistance, you may contact us on [on Discord](https://discord.gg/NgHf9jt), or more publicly, [on GitHub](https://github.com/poggit/support/issues). Commenting on this commit directly will **not** notify any Poggit staff.

Regards,
Poggit Bot (@poggit-bot)
The official Poggit automation account


Successfully aliased the URL <https://homepage-c6ex4rp1p.now.sh> to the following aliases:

* https://ethicalcode.com.au
* https://homepage.ethicalcode.now.sh
* https://homepage-git-master.ethicalcode.now.sh


Successfully aliased the URL <https://spacedos-gui-9vwm9kljz.now.sh> to the following aliases:

* https://gui.spacedos.com
* https://spacedos-gui.spacedos.now.sh
* https://spacedos-gui-git-master.spacedos.now.sh


> Everything here is broken: https://firebaseopensource.com/projects/flutter/plugins/

Dang that's horrible. For anyone who stumbles on this flutter/flutter#39975 is the issue for this.


I expect that "--rsync-get-flags" prints only rsync valid flags, not a phrase/comment.


True. I'll extract the regexp for classes and use that in both places to fix this issue as well.


Failed to alias the deployment: Deployment not found.

[Click here](https://zeit.co/dagike/catchreactstore/54kw2g2br) to access the non-aliased deployment.


Successfully aliased the URL <https://coderplex-q8h0lu63l.now.sh> to the following aliases:

* https://coderplex-app.now.sh
* https://coderplex.coderplex.now.sh
* https://coderplex-git-develop.coderplex.now.sh


Just call the other method


Hmm master isn't protected...?  Let me do some digging and see if I'm missing something.


o vm está sendo usado para receber a referencia do component, para que na hora do registro no serviço pegue referencias diferentes


This is not needed as you can rewrite order by correlated symbols with constants


Successfully aliased the URL <https://cassandra-auabhk35o.now.sh> to the following aliases:

* https://cassandra.now.sh
* https://cassandra.merelinguist.now.sh
* https://cassandra-git-master.merelinguist.now.sh


VOLTEIIIIIIIIIIIIII


I will share only after yours change have be added to dev-2 branch and we had closed the issue. no rush the workaround I have today works just fine.


opaaaaaaa
@Alsloredo557 SALVE


@Felpopinho13  Brota ihuuuuuuuuuuuuuuuuu


Might have had to do with your permissions (write).  I made you an admin for now.  See if you can force push now.


Nope, won't fit in one line.


Technically constants could also be literals (I'm not sure its supported atm), which could be used to rewrite correlated order by.


BUTTONS passado para minusculo


这个程序应该是错的。因为sockfd 是edge trigger, accept()必须要放进一个循环里，直到所有的request全部被接受。

如果像现在这么写，并发高了程序会卡住。


My point is that this $self usage in an "out" typemap only works for python and also is undocumented. Anyway, it's merged, so we can relax until it breaks ;)


Now could not deploy this pull request since the `package.json` file does not contain valid JSON.

  Click here to see the contents of `package.json`

{
  "name": "frontend",
  "version": "1.0.0",
  "scripts": {
    "start": "npm server.js",
  },
  "dependencies": {},
  "devDependencies": {
    "static": "^2.0.0"
  }
}


Now could not deploy this pull request since the `now.json` file is empty.
It should be a valid JSON file.

    For more information on now.json visit https://zeit.co/docs/features/configuration#now.json.


Successfully aliased the URL <https://parafuso-fq6pqijr9.now.sh> to the following aliases:

* https://parafuso.renatoelysiqueira.now.sh
* https://parafuso-git-master.renatoelysiqueira.now.sh


Yup, good catch.


Successfully aliased the URL <https://ose-7laaf20x7.now.sh> to the following aliases:

* https://ose.phenomen.now.sh
* https://ose-git-master.phenomen.now.sh


Successfully aliased the URL <https://movie-demo-1-3zdro88oi.now.sh> to the following aliases:

* https://movie-demo-1.paigen11.now.sh
* https://movie-demo-1-git-master.paigen11.now.sh


include unstid.h
hello word


Successfully aliased the URL <https://kistauri-hknpo42kr.now.sh> to the following aliases:

* https://davidkistauri.now.sh
* https://kistauri.dtroode.now.sh
* https://kistauri-git-master.dtroode.now.sh


Successfully aliased the URL <https://frontend-j3d02519u.now.sh> to the following aliases:

* https://niyon-frontend-dev.now.sh
* https://frontend.labseu2-niyon.now.sh
* https://frontend-git-master.labseu2-niyon.now.sh


Into failed in tvOS 9.0 simulator
```
16:13:23.8514770 error HE0046: Failed to install the app 'com.xamarin.introspection' on the device 'tvOS 9.0 (13T395) - Apple TV': The operation couldn???t be completed. (Cocoa error -102.)
```
https://github.com/xamarin/maccore/issues/1906


That was an artifact from an older version... I used to save the numbers in a different order.
Now the numbers are saved from lowest word to highest word, while previously the highest word was located in arr[0].


adicionado info no controller e replicado no template


Which test?

On the online builds:
https://travis-ci.org/josephjaspers/BlackCat_Tensors
and
https://travis-ci.org/josephjaspers/blackcat_tensors/builds/581307706

the error seems to be the same.


Thanks.


We should also support "order by outer_relation.id"


Cuando la ruta de esta pagina esta activa pues aplicame la clase 'active' de bootstrap


I agree, I was also confused. This is why I removed the `shutdown()` in the first place. I agree that we should discuss about our interface stability guarantees for some parts of the codebase.


**开发分支**


@JuliaRegistrator register


Registration pull request created: [JuliaRegistries/General/3328](https://github.com/JuliaRegistries/General/pull/3328)

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if [Julia TagBot](https://github.com/apps/julia-tagbot) is installed, or can be done manually through the github interface, or via:
```
git tag -a v0.19.4 -m "<description of version>" 8e79a5c19a04b079a8f1a29e43b5151259ab58d1
git push origin v0.19.4
```


Successfully aliased the URL <https://kendraio-app-1vyl0x9kn.now.sh> to the following aliases:

* https://dev.app.kendra.io
* https://kendraio-app.kendraio.now.sh
* https://kendraio-app-git-develop.kendraio.now.sh


Successfully aliased the URL <https://dotgov-components-7il9v7sos.now.sh> to the following aliases:

* https://dotgov-components.baltimorecounty.now.sh
* https://dotgov-components-git-integration.baltimorecounty.now.sh


Successfully aliased the URL <https://spacedos-gui-ehhp0efn7.now.sh> to the following aliases:

* https://gui.spacedos.com
* https://spacedos-gui.spacedos.now.sh
* https://spacedos-gui-git-master.spacedos.now.sh


Successfully aliased the URL <https://movie-demo-1-44igluw8q.now.sh> to the following aliases:

* https://movie-demo-1.paigen11.now.sh
* https://movie-demo-1-git-master.paigen11.now.sh


Successfully aliased the URL <https://mcs-new-version-ns83gffxk.now.sh> to the following aliases:

* https://mcs-new-version.m-c-s.now.sh
* https://mcs-new-version-git-master.m-c-s.now.sh


It should, yes.

On Fri, Sep 6, 2019 at 9:16 AM James Sayer <notifications@github.com> wrote:

> Does this fix the issue of the scores of all teams being 0.00 in the
> Friday morning score update?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/dtcarls/fantasy_football_chat_bot/commit/939c5dd757889660ad5921b2cb1085c027ec5154?email_source=notifications&email_token=ACWGOWLXI26WD6VEUKWLQKDQIJJZJA5CNFSM4IUI4RAKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBBLPYO#commitcomment-34979598>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ACWGOWPEBIVVEE6JR4SNTTDQIJJZJANCNFSM4IUI4RAA>
> .
>


No sirvio este commit.. En el traspaso al master hay que borrarlo..


That's fabulous :-) thanks!


public function handleMagicLoginLink, two times?


test_1 should use module-scoped provider along with the parametrized fixture fix_mod, but each time the fix_mod parameter changes, the provider is torn down and re-setup:

```
$ miq-runtest --setup-show cfme/tests/test_tpapaioa.py
[...]
cfme/tests/test_tpapaioa.py
SETUP    S appliance
SETUP    S ensure_websocket_role_disabled (fixtures used: appliance)
SETUP    S fix_merkyl_workaround (fixtures used: appliance)
SETUP    S fix_missing_hostname (fixtures used: appliance)
      SETUP    F appliance_police (fixtures used: appliance)
  SETUP    M provider[VMwareProvider(endpoints={'default': <cfme.infrastructure.provider.virtualcenter.VirtualCenterEndpoint object at 0x7f6fe61a7790>}, name='X', key='Y', zone='default', start_ip='N.N.N.N', end_ip='N.N.N.N', provider_data=None)]
  SETUP    M fix_mod[A]
        cfme/tests/test_tpapaioa.py::test_1[A-Z] (fixtures used: appliance, appliance_police, ensure_websocket_role_disabled, fix_merkyl_workaround, fix_missing_hostname, fix_mod, provider).
      TEARDOWN F appliance_police
      SETUP    F appliance_police (fixtures used: appliance)
  TEARDOWN M provider[VMwareProvider(endpoints={'default': <cfme.infrastructure.provider.virtualcenter.VirtualCenterEndpoint object at 0x7f6fe61a7790>}, name='X', key='Y', zone='default', start_ip='N.N.N.N', end_ip='N.N.N.N', provider_data=None)]
  SETUP    M provider[VMwareProvider(endpoints={'default': <cfme.infrastructure.provider.virtualcenter.VirtualCenterEndpoint object at 0x7f6fe746c9d0>}, name='X', key='Y', zone='default', start_ip='N.N.N.N', end_ip='N.N.N.N', provider_data=None)]
  TEARDOWN M fix_mod[A]
  SETUP    M fix_mod[B]
        cfme/tests/test_tpapaioa.py::test_1[B-Z] (fixtures used: appliance, appliance_police, ensure_websocket_role_disabled, fix_merkyl_workaround, fix_missing_hostname, fix_mod, provider).
      TEARDOWN F appliance_police
  TEARDOWN M fix_mod[B]
  TEARDOWN M provider[VMwareProvider(endpoints={'default': <cfme.infrastructure.provider.virtualcenter.VirtualCenterEndpoint object at 0x7f6fe746c9d0>}, name='X', key='Y', zone='default', start_ip='N.N.N.N', end_ip='N.N.N.N', provider_data=None)]
TEARDOWN S fix_missing_hostname
TEARDOWN S fix_merkyl_workaround
TEARDOWN S ensure_websocket_role_disabled
TEARDOWN S appliance
```

I've tracked down the cause to how pytest sets up the callspecs when there is a combination of fixture-level and test-level parameters:

1.) In _pytest/python.py, the collector calls fixtures.add_funcarg_pseudo_fixture_def():

```
class PyCollector(PyobjMixin, nodes.Collector):
[...]
    def _genfunctions(self, name, funcobj):
[...]
        self.ihook.pytest_generate_tests.call_extra(methods, dict(metafunc=metafunc))
[...]
            fixtures.add_funcarg_pseudo_fixture_def(self, metafunc, fm)
```

2.) In _pytest/fixtures.py, add_funcarg_pseudo_fixture_def() removes each test-level parameter from callspec.funcargs and adds it to callspec.params. If the test-level parameter has already appeared once with the same value, then it is given an incremented index value:

```
    for callspec in metafunc._calls:
        for argname, argvalue in callspec.funcargs.items():
            assert argname not in callspec.params
            callspec.params[argname] = argvalue
            arg2params_list = arg2params.setdefault(argname, [])
            callspec.indices[argname] = len(arg2params_list)
            arg2params_list.append(argvalue)
```
After this processing is complete, the callspecs look like this, for example:

```
(Pdb) p metafunc._calls[0].__dict__
{'funcargs': {},
 '_idlist': ['A', 'virtualcenter-6.5'],
 'params': {'fix_mod': 0, 'provider': DataProvider(category='infra', type_name='virtualcenter', version=6.5, klass=<class 'cfme.infrastructure.provider.virtualcenter.VMwareProvider'>)},
 'indices': {'fix_mod': 0, 'provider': 0}}

(Pdb) p metafunc._calls[1].__dict__
{'funcargs': {},
 '_idlist': ['B', 'virtualcenter-6.5'],
 'params': {'fix_mod': 1, 'provider': DataProvider(category='infra', type_name='virtualcenter', version=6.5, klass=<class 'cfme.infrastructure.provider.virtualcenter.VMwareProvider'>)},
 'indices': {'fix_mod': 1, 'provider': 1}}

```
So, even though the DataProvider looks the same in both cases, callspec.indices['provider'] is different.

3.) During test execution, this index value in callspec.indices is used to determine whether the cached value can be used, or whether a new one is needed:

_pytest/fixtures.py:

```
    def execute(self, request):
[...]
        my_cache_key = request.param_index
        cached_result = getattr(self, "cached_result", None)
        if cached_result is not None:
            result, cache_key, err = cached_result
            if my_cache_key == cache_key:
                if err is not None:
                    py.builtin._reraise(*err)
                else:
                    return result
            # we have a previous but differently parametrized fixture instance
            # so we need to tear it down before creating a new one
            self.finish(request)
            assert not hasattr(self, "cached_result")

        hook = self._fixturemanager.session.gethookproxy(request.node.fspath)
        return hook.pytest_fixture_setup(fixturedef=self, request=request)
```

I guess this unique index value logic for test-level parameters makes sense under normal conditions where these parameters are simple objects like strings, but when they are provider markers, this means that we can't rely on their scope to be respected when we also have parametrized fixtures present.


1. We don't support forks
2. No, unless we made .update also rebuilding the Heroku instance, with their API maybe?


С точки зрения методологии и синтаксиса - ошибок нет.
С точки зрения архитектуры - не вижу тут отдельной от шапки БЭМ-сущности, переиспользуемой где-то еще. Возможно, ты увидел больше.


Successfully aliased the URL <https://main-site-5qtpvkdf5.now.sh> to the following aliases:

* https://fcc-mcr.now.sh
* https://main-site.fcc-mcr.now.sh
* https://main-site-git-master.fcc-mcr.now.sh


Опечатка по БЭМ


Successfully aliased the URL <https://app-abwm0giki.now.sh> to the following aliases:

* https://app.communiteths.now.sh
* https://app-git-master.communiteths.now.sh


Successfully aliased the URL <https://kendraio-app-ciak1v8v9.now.sh> to the following aliases:

* https://dev.app.kendra.io
* https://kendraio-app.kendraio.now.sh
* https://kendraio-app-git-develop.kendraio.now.sh


@Sur3 I just updated my branch with the fix, can you please test again?


@taylorotwell this change is not required anymore ? Do we need to remove the `parent::register` from the custom controller then ? And the event dispatching ? 😛


Successfully aliased the URL <https://python-practice-obsteydpw.now.sh> to the following aliases:

* https://info.cc7w.cf
* https://python-practice.c7w.now.sh
* https://python-practice-git-master.c7w.now.sh