[R/clock_model_to_xml_prior_distr.R:14:23:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/clock_model_to_xml_prior_distr.R#L14) *warning:* **no visible global function definition for ‘rln_clock_model_to_xml_mean_rate_prior’**
```r
      text <- c(text, rln_clock_model_to_xml_mean_rate_prior(clock_model)) # nolint beautier function
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/clock_models_to_xml_state.R:32:23:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/clock_models_to_xml_state.R#L32) *warning:* **no visible global function definition for ‘clock_model_to_xml_state’**
```r
    line_to_remove <- clock_model_to_xml_state(clock_models[[1]]) # nolint
                      ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_beast2_input_distr.R:9:19:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_beast2_input_distr.R#L9) *warning:* **no visible global function definition for ‘tree_priors_to_xml_prior_distr’**
```r
  text <- c(text, tree_priors_to_xml_prior_distr(tree_priors)) # nolint beautier function
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_beast2_input_distr.R:10:19:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_beast2_input_distr.R#L10) *warning:* **no visible global function definition for ‘gamma_site_models_to_xml_prior_distr’**
```r
  text <- c(text, gamma_site_models_to_xml_prior_distr(site_models)) # nolint beautier function
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_beast2_input_distr.R:11:19:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_beast2_input_distr.R#L11) *warning:* **no visible global function definition for ‘site_models_to_xml_prior_distr’**
```r
  text <- c(text, site_models_to_xml_prior_distr(site_models)) # nolint beautier function
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_beast2_input_operators.R:27:19:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_beast2_input_operators.R#L27) *warning:* **no visible global function definition for ‘site_models_to_xml_operators’**
```r
  text <- c(text, site_models_to_xml_operators(site_models)) # nolint beautier function
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_beast2_input_run.R:23:11:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_beast2_input_run.R#L23) *warning:* **no visible global function definition for ‘mcmc_to_xml_run’**
```r
  text <- mcmc_to_xml_run(mcmc) # nolint beautier function
          ^~~~~~~~~~~~~~~
```
[R/create_beast2_input_state.R:24:19:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_beast2_input_state.R#L24) *warning:* **no visible global function definition for ‘site_models_to_xml_state’**
```r
  text <- c(text, site_models_to_xml_state(site_models)) # nolint beautier function
                  ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_beast2_input_state.R:33:19:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_beast2_input_state.R#L33) *warning:* **no visible global function definition for ‘tree_priors_to_xml_state’**
```r
  text <- c(text, tree_priors_to_xml_state(tree_priors)) # nolint beautier function
                  ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_clock_models_from_names.R:5:26:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_clock_models_from_names.R#L5) *warning:* **no visible global function definition for ‘create_clock_model_from_name’**
```r
    clock_models[[i]] <- create_clock_model_from_name(clock_model_name) # nolint beautier function
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_mcmc_nested_sampling.R:41:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_mcmc_nested_sampling.R#L41) *style:* **Lines should not be more than 80 characters.**
```r
#' @aliases create_ns_mcmc create_nested_sampling_mcmc create_mcmc_nested_sampling
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_mcmc_nested_sampling.R:42:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_mcmc_nested_sampling.R#L42) *style:* **Lines should not be more than 80 characters.**
```r
#' @export create_ns_mcmc create_nested_sampling_mcmc create_mcmc_nested_sampling
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_site_models_from_names.R:5:25:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_site_models_from_names.R#L5) *warning:* **no visible global function definition for ‘create_site_model_from_name’**
```r
    site_models[[i]] <- create_site_model_from_name(site_model_name) # nolint beautier function
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_tracelog_xml.R:17:19:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_tracelog_xml.R#L17) *warning:* **no visible global function definition for ‘tree_models_to_xml_tracelog’**
```r
  text <- c(text, tree_models_to_xml_tracelog(site_models)) # nolint beautier function
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_tracelog_xml.R:32:19:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_tracelog_xml.R#L32) *warning:* **no visible global function definition for ‘tree_priors_to_xml_tracelog’**
```r
  text <- c(text, tree_priors_to_xml_tracelog(tree_priors)) # nolint beautier function
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/extract_xml_operators_from_lines.R:13:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/extract_xml_operators_from_lines.R#L13) *style:* **Lines should not be more than 80 characters.**
```r
  last_line <- beautier::find_last_regex_line(lines, "(<operator id=\")|(</operator>)")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/extract_xml_section_from_lines.R:7:12:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/extract_xml_section_from_lines.R#L7) *warning:* **no visible global function definition for ‘extract_xml_operators_from_lines’**
```r
    return(extract_xml_operators_from_lines(lines)) # nolint beautier function
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/find_last_xml_closing_tag_line.R:6:3:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/find_last_xml_closing_tag_line.R#L6) *warning:* **no visible global function definition for ‘find_last_regex_line’**
```r
  find_last_regex_line(lines, paste0("</", section, ">")) # nolint beautier function
  ^~~~~~~~~~~~~~~~~~~~
```
[R/get_alignment_id.R:5:9:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/get_alignment_id.R#L5) *warning:* **no visible global function definition for ‘get_file_base_sans_ext’**
```r
  id <- get_file_base_sans_ext(fasta_filename) # nolint beautier function
        ^~~~~~~~~~~~~~~~~~~~~~
```
[R/get_alignment_id.R:9:3:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/get_alignment_id.R#L9) *warning:* **no visible global function definition for ‘check_alignment_id’**
```r
  check_alignment_id(id)
  ^~~~~~~~~~~~~~~~~~
```
[R/has_xml_opening_tag.R:11:12:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/has_xml_opening_tag.R#L11) *warning:* **no visible global function definition for ‘get_xml_opening_tag’**
```r
    tag <- get_xml_opening_tag(lines) # nolint
           ^~~~~~~~~~~~~~~~~~~
```
[R/has_xml_opening_tag.R:14:24:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/has_xml_opening_tag.R#L14) *warning:* **no visible global function definition for ‘find_first_xml_opening_tag_line’**
```r
  !beautier::is_one_na(find_first_xml_opening_tag_line(lines, section))
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/init_clock_models.R:10:10:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_clock_models.R#L10) *warning:* **no visible global function definition for ‘get_alignment_ids_from_fasta_filenames’**
```r
  ids <- get_alignment_ids_from_fasta_filenames(fasta_filenames) # nolint beautier function
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/init_clock_models.R:13:26:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_clock_models.R#L13) *warning:* **no visible global function definition for ‘get_distr_n_params’**
```r
  param_id <- param_id + get_distr_n_params(ucldstdev_distr) # nolint beautier function
                         ^~~~~~~~~~~~~~~~~~
```
[R/init_clock_models.R:20:26:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_clock_models.R#L20) *warning:* **no visible global function definition for ‘get_distr_n_params’**
```r
  param_id <- param_id + get_distr_n_params(mean_rate_prior_distr) # nolint beautier function
                         ^~~~~~~~~~~~~~~~~~
```
[R/init_distr.R:9:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_distr.R#L9) *style:* **functions should have cyclomatic complexity of less than 15, this has 25.**
```r
init_distr <- function(
^
```
[R/init_inference_model.R:39:22:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_inference_model.R#L39) *warning:* **no visible global function definition for ‘init_mrca_prior’**
```r
  inference_model <- init_mrca_prior(input_filename, inference_model)
                     ^~~~~~~~~~~~~~~
```
[R/init_mrca_prior.R:8:50:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_mrca_prior.R#L8) *warning:* **no visible global function definition for ‘get_alignment_id’**
```r
      inference_model$mrca_prior$alignment_id <- get_alignment_id(input_filename) # nolint beautier function
                                                 ^~~~~~~~~~~~~~~~
```
[R/init_mrca_prior.R:11:48:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_mrca_prior.R#L11) *warning:* **no visible global function definition for ‘get_taxa_names’**
```r
      inference_model$mrca_prior$taxa_names <- get_taxa_names(input_filename) # nolint beautier function
                                               ^~~~~~~~~~~~~~
```
[R/init_site_models.R:44:28:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_site_models.R#L44) *warning:* **no visible global function definition for ‘get_site_model_n_params’**
```r
    param_id <- param_id + get_site_model_n_params(site_model) # nolint beautier function
                           ^~~~~~~~~~~~~~~~~~~~~~~
```
[R/init_site_models.R:198:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_site_models.R#L198) *style:* **Lines should not be more than 80 characters.**
```r
  testit::assert(beautier::is_init_gamma_site_model(gtr_site_model$gamma_site_model))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/init_site_models.R:220:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_site_models.R#L220) *style:* **Lines should not be more than 80 characters.**
```r
  if (!beautier::is_one_na(hky_site_model$gamma_site_model$gamma_shape_prior_distr)) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/init_site_models.R:299:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_site_models.R#L299) *style:* **Lines should not be more than 80 characters.**
```r
  testit::assert(beautier::is_init_gamma_site_model(jc69_site_model$gamma_site_model))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/init_site_models.R:327:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_site_models.R#L327) *style:* **Lines should not be more than 80 characters.**
```r
    !beautier::is_one_na(tn93_site_model$gamma_site_model$gamma_shape_prior_distr)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/interspace.R:6:11:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/interspace.R#L6) *warning:* **no visible global function definition for ‘count_trailing_spaces’**
```r
  nsni <- count_trailing_spaces(lines[1]) # nolint beautier function
          ^~~~~~~~~~~~~~~~~~~~~
```
[R/is_clock_model_name.R:2:13:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_clock_model_name.R#L2) *warning:* **no visible global function definition for ‘get_clock_model_names’**
```r
  name %in% get_clock_model_names() # nolint beautier function
            ^~~~~~~~~~~~~~~~~~~~~
```
[R/is_default_mcmc.R:2:8:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_default_mcmc.R#L2) *warning:* **no visible global function definition for ‘is_mcmc’**
```r
  if (!is_mcmc(mcmc)) return(FALSE) # nolint beautier function
       ^~~~~~~
```
[R/is_default_mcmc.R:3:39:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_default_mcmc.R#L3) *warning:* **no visible global function definition for ‘create_mcmc’**
```r
  length(names(mcmc)) == length(names(create_mcmc()))
                                      ^~~~~~~~~~~
```
[R/is_distr.R:37:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_distr.R#L37) *style:* **functions should have cyclomatic complexity of less than 15, this has 21.**
```r
is_distr <- function(
^
```
[R/is_freq_equilibrium_name.R:4:13:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_freq_equilibrium_name.R#L4) *warning:* **no visible global function definition for ‘get_freq_equilibrium_names’**
```r
  name %in% get_freq_equilibrium_names() # nolint beautier function
            ^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/is_id.R:4:32:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_id.R#L4) *warning:* **no visible global function definition for ‘is_one_int’**
```r
  assertive::is_a_string(x) || is_one_int(x) # nolint beautier function
                               ^~~~~~~~~~
```
[R/is_init_distr.R:26:20:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_init_distr.R#L26) *warning:* **no visible global function definition for ‘is_uniform_distr’**
```r
    testit::assert(is_uniform_distr(x))
                   ^~~~~~~~~~~~~~~~
```
[R/is_init_site_model.R:36:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_init_site_model.R#L36) *style:* **functions should have cyclomatic complexity of less than 15, this has 27.**
```r
is_init_gtr_site_model <- function(
^
```
[R/is_mrca_align_id_in_fasta.R:6:9:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_mrca_align_id_in_fasta.R#L6) *warning:* **no visible global function definition for ‘get_alignment_id’**
```r
  id <- get_alignment_id(fasta_filename)
        ^~~~~~~~~~~~~~~~
```
[R/is_mrca_align_ids_in_fastas.R:6:10:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_mrca_align_ids_in_fastas.R#L6) *warning:* **no visible global function definition for ‘get_alignment_ids_from_fasta_filenames’**
```r
  ids <- get_alignment_ids_from_fasta_filenames(fasta_filenames)
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/is_site_model.R:8:8:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_site_model.R#L8) *warning:* **no visible global function definition for ‘is_distr’**
```r
  if (!is_distr(x$kappa_prior_distr)) return(FALSE) # nolint beautier function
       ^~~~~~~~
```
[R/is_site_model.R:10:8:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_site_model.R#L10) *warning:* **no visible global function definition for ‘is_freq_equilibrium_name’**
```r
  if (!is_freq_equilibrium_name(x$freq_equilibrium)) return(FALSE) # nolint beautier function
       ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/is_site_model.R:18:10:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_site_model.R#L18) *warning:* **no visible global function definition for ‘is_distr’**
```r
    if (!is_distr(expected_distr)) return(FALSE) # nolint beautier function
         ^~~~~~~~
```
[R/is_site_model.R:24:10:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_site_model.R#L24) *warning:* **no visible global function definition for ‘is_param’**
```r
    if (!is_param(expected_param)) return(FALSE) # nolint beautier function
         ^~~~~~~~
```
[R/is_site_model.R:27:8:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_site_model.R#L27) *warning:* **no visible global function definition for ‘is_freq_equilibrium_name’**
```r
  if (!is_freq_equilibrium_name(x$freq_equilibrium)) return(FALSE) # nolint beautier function
       ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/is_site_model.R:55:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_site_model.R#L55) *style:* **functions should have cyclomatic complexity of less than 15, this has 22.**
```r
is_gtr_site_model <- function(
^
```
[R/is_site_model.R:171:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_site_model.R#L171) *style:* **functions should have cyclomatic complexity of less than 15, this has 23.**
```r
is_tn93_site_model <- function(
^
```
[R/is_tree_prior_name.R:2:13:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_tree_prior_name.R#L2) *warning:* **no visible global function definition for ‘get_tree_prior_names’**
```r
  name %in% get_tree_prior_names() # nolint beautier function
            ^~~~~~~~~~~~~~~~~~~~
```
[R/is_tree_prior.R:5:8:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_tree_prior.R#L5) *warning:* **no visible global function definition for ‘is_tree_prior_name’**
```r
  if (!is_tree_prior_name(x$name)) return(FALSE) # nolint beautier function
       ^~~~~~~~~~~~~~~~~~
```
[R/is_xml.R:3:8:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_xml.R#L3) *warning:* **no visible global function definition for ‘has_xml_opening_tag’**
```r
  if (!has_xml_opening_tag(text)) return(FALSE) # nolint beautier function
       ^~~~~~~~~~~~~~~~~~~
```
[R/is_xml.R:4:7:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_xml.R#L4) *warning:* **no visible global function definition for ‘has_xml_short_closing_tag’**
```r
  if (has_xml_short_closing_tag(text)) return(TRUE) # nolint beautier function
      ^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/is_xml.R:5:18:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_xml.R#L5) *warning:* **no visible global function definition for ‘get_xml_opening_tag’**
```r
  opening_tag <- get_xml_opening_tag(text) # nolint beautier function
                 ^~~~~~~~~~~~~~~~~~~
```
[R/is_xml.R:6:18:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_xml.R#L6) *warning:* **no visible global function definition for ‘get_xml_closing_tag’**
```r
  closing_tag <- get_xml_closing_tag(text) # nolint beautier function
                 ^~~~~~~~~~~~~~~~~~~
```
[R/mcmc_to_xml_run.R:47:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/mcmc_to_xml_run.R#L47) *style:* **Lines should not be more than 80 characters.**
```r
    xml <- paste0(xml, " numInitializationAttempts=\"", mcmc$n_init_attempts, "\"")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/mrca_prior_to_xml_lh_distr.R:6:34:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/mrca_prior_to_xml_lh_distr.R#L6) *warning:* **no visible global function definition for ‘is_one_na’**
```r
  if (length(mrca_prior) == 1 && is_one_na(mrca_prior)) return(NULL) # nolint beautier function
                                 ^~~~~~~~~
```
[R/mrca_priors_to_xml_state.R:6:35:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/mrca_priors_to_xml_state.R#L6) *warning:* **no visible global function definition for ‘is_one_na’**
```r
  if (length(mrca_priors) == 1 && is_one_na(mrca_priors)) return(NULL) # nolint beautier function
                                  ^~~~~~~~~
```
[R/parameter_to_xml.R:13:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/parameter_to_xml.R#L13) *style:* **functions should have cyclomatic complexity of less than 15, this has 20.**
```r
parameter_to_xml <- function(
^
```
[R/site_model_to_xml_state.R:22:23:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/site_model_to_xml_state.R#L22) *warning:* **no visible global function definition for ‘parameter_to_xml’**
```r
      text <- c(text, parameter_to_xml(site_model$rate_ac_param)) # nolint beautier function
                      ^~~~~~~~~~~~~~~~
```
[R/site_model_to_xml_state.R:25:23:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/site_model_to_xml_state.R#L25) *warning:* **no visible global function definition for ‘parameter_to_xml’**
```r
      text <- c(text, parameter_to_xml(site_model$rate_ag_param)) # nolint beautier function
                      ^~~~~~~~~~~~~~~~
```
[R/site_model_to_xml_state.R:47:23:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/site_model_to_xml_state.R#L47) *warning:* **no visible global function definition for ‘parameter_to_xml’**
```r
      text <- c(text, parameter_to_xml(site_model$kappa_1_param)) # nolint beautier function
                      ^~~~~~~~~~~~~~~~
```
[R/site_model_to_xml_state.R:51:23:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/site_model_to_xml_state.R#L51) *warning:* **no visible global function definition for ‘parameter_to_xml’**
```r
      text <- c(text, parameter_to_xml(site_model$kappa_2_param)) # nolint beautier function
                      ^~~~~~~~~~~~~~~~
```
[R/site_model_to_xml_subst_model.R:6:18:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/site_model_to_xml_subst_model.R#L6) *warning:* **no visible global function definition for ‘is_id’**
```r
  testit::assert(is_id(id))
                 ^~~~~
```
[R/site_model_to_xml_subst_model.R:7:18:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/site_model_to_xml_subst_model.R#L7) *warning:* **no visible global function definition for ‘is_jc69_site_model’**
```r
  testit::assert(is_jc69_site_model(site_model))
                 ^~~~~~~~~~~~~~~~~~
```
[R/site_models_to_xml_operators.R:4:18:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/site_models_to_xml_operators.R#L4) *warning:* **no visible global function definition for ‘are_site_models’**
```r
  testit::assert(are_site_models(site_models)) # nolint beautier function
                 ^~~~~~~~~~~~~~~
```
[R/site_models_to_xml_tracelog.R:6:21:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/site_models_to_xml_tracelog.R#L6) *warning:* **no visible global function definition for ‘site_model_to_xml_tracelog’**
```r
    text <- c(text, site_model_to_xml_tracelog(site_model)) # nolint beautier function
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/tree_prior_to_xml_operators.R:10:22:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/tree_prior_to_xml_operators.R#L10) *warning:* **no visible global function definition for ‘get_operator_id_pre’**
```r
  operator_id_pre <- get_operator_id_pre(tree_prior) # nolint beautier function
                     ^~~~~~~~~~~~~~~~~~~
```
[R/tree_prior_to_xml_prior_distr.R:7:21:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/tree_prior_to_xml_prior_distr.R#L7) *warning:* **no visible global function definition for ‘bd_tree_prior_to_xml_prior_distr’**
```r
    text <- c(text, bd_tree_prior_to_xml_prior_distr(tree_prior)) # nolint beautier function
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/tree_prior_to_xml_prior_distr.R:9:21:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/tree_prior_to_xml_prior_distr.R#L9) *warning:* **no visible global function definition for ‘cbs_tree_prior_to_xml_prior_distr’**
```r
    text <- c(text, cbs_tree_prior_to_xml_prior_distr(tree_prior)) # nolint beautier function
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/tree_prior_to_xml_prior_distr.R:11:21:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/tree_prior_to_xml_prior_distr.R#L11) *warning:* **no visible global function definition for ‘ccp_tree_prior_to_xml_prior_distr’**
```r
    text <- c(text, ccp_tree_prior_to_xml_prior_distr(tree_prior)) # nolint beautier function
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/tree_prior_to_xml_prior_distr.R:13:21:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/tree_prior_to_xml_prior_distr.R#L13) *warning:* **no visible global function definition for ‘cep_tree_prior_to_xml_prior_distr’**
```r
    text <- c(text, cep_tree_prior_to_xml_prior_distr(tree_prior)) # nolint beautier function
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/tree_prior_to_xml_prior_distr.R:16:21:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/tree_prior_to_xml_prior_distr.R#L16) *warning:* **no visible global function definition for ‘yule_tree_prior_to_xml_prior_distr’**
```r
    text <- c(text, yule_tree_prior_to_xml_prior_distr(tree_prior)) # nolint beautier function
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/tree_priors_to_xml_distr.R:8:21:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/tree_priors_to_xml_distr.R#L8) *warning:* **no visible global function definition for ‘tree_prior_to_xml_prior_distr’**
```r
    text <- c(text, tree_prior_to_xml_prior_distr(tree_prior)) # nolint beautier function
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/tree_priors_to_xml_operators.R:6:18:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/tree_priors_to_xml_operators.R#L6) *warning:* **no visible global function definition for ‘are_tree_priors’**
```r
  testit::assert(are_tree_priors(tree_priors)) # nolint beautier function
                 ^~~~~~~~~~~~~~~
```
[tests/testthat/test-are_equal_mcmcs.R:57:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/tests/testthat/test-are_equal_mcmcs.R#L57) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test-check_file_and_model_agree.R:16:19:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/tests/testthat/test-check_file_and_model_agree.R#L16) *style:* **Use <-, not =, for assignment.**
```r
  inference_model = create_inference_model(
                  ^
```
[tests/testthat/test-check_file_and_model_agree.R:35:19:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/tests/testthat/test-check_file_and_model_agree.R#L35) *style:* **Use <-, not =, for assignment.**
```r
  inference_model = create_inference_model(
                  ^
```
[tests/testthat/test-create_treelog_xml.R:15:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/tests/testthat/test-create_treelog_xml.R#L15) *style:* **Lines should not be more than 80 characters.**
```r
    "    <log id=\"TreeWithMetaDataLogger.t:test_output_0\" spec=\"beast.evolution.tree.TreeWithMetaDataLogger\" tree=\"@Tree.t:test_output_0\"/>",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


input Element or Matrix ?


[分支限界法.zip](https://github.com/xumin99/-/files/3891461/default.zip)


Why Matrix, if Column?


Vector is common name for one-dimensional array (but it's better to call it Array in this case).
If this class represents Matrix - please call it Matrix


method name should start from lower letter


What does "sMatix" mean? if it's "sortMatrix", just name it like this


nah


@Estebastien  Could you please append `Comment[fr]` to gpxsee.desktop file as well:
https://github.com/tumic0/GPXSee/blob/b61c39ea4616045fb8e973d0b27b5855cb70bb89/pkg/gpxsee.desktop#L3-L8


Successfully deployed to following URLs:

* https://lyon-0919-projet2-eldebaran3000-lmwlid1b6.now.sh
* https://lyon-0919-projet2-eldebaran3000.now.sh
* https://lyon-0919-projet2-eldebaran3000.amauryneury.now.sh
* https://lyon-0919-projet2-eldebaran3000-git-master.amauryneury.now.sh


Successfully deployed to following URLs:

* https://chrome-dashboard-1tsho8f6o.now.sh
* https://chrome-dashboard.now.sh
* https://chrome-dashboard.whyour.now.sh
* https://chrome-dashboard-git-master.whyour.now.sh


почему убрали const?


cp


Dev version "connection stalls", master version stable. Using Clang.


Successfully deployed to following URLs:

* https://itchio-godot-scraper-legc51el2.now.sh
* https://itchio-godot-scraper.now.sh
* https://itchio-godot-scraper.hiulit.now.sh
* https://itchio-godot-scraper-git-master.hiulit.now.sh


Successfully deployed to following URLs:

* https://futuhul-gayb-react-book-project-7ccc2g00f.now.sh
* https://futuhul-gayb-react-book-project-tau-plum.now.sh
* https://geylani.muratumutlu.com
* https://futuhul-gayb-react-book-project.muradjs.now.sh
* https://futuhul-gayb-react-book-project-git-master.muradjs.now.sh


Successfully deployed to following URLs:

* https://react-awesome-reveal-1jqo599vj.now.sh
* https://react-awesome-reveal.now.sh
* https://react-awesome-reveal.dennismorello.now.sh
* https://react-awesome-reveal-git-master.dennismorello.now.sh


cp bikeshare.py


Vector is common name for one-dimensional array


Which element should I input? Element of the Matrix or another one?


глобальная переменна = не очень приятно
возможно стоит ее инкапсулировать


в объект, связанный с работой стореджа


чтобы проверить на пустоту, можно сократить до `(!controls.input.value.trim())`


а зачем тернарный?
readStatus = document.getElementById('modal-read').value === "+";


by including Remittance address in the hashing process


![](https://github.trello.services/images/mini-trello-icon.png) [подскажите пожалуйста, заголовки (верхняя строка) в табличках выводятся не очень ровно. Скрины прилагаю.](https://trello.com/c/U2TCop8c/267-%D0%BF%D0%BE%D0%B4%D1%81%D0%BA%D0%B0%D0%B6%D0%B8%D1%82%D0%B5-%D0%BF%D0%BE%D0%B6%D0%B0%D0%BB%D1%83%D0%B9%D1%81%D1%82%D0%B0-%D0%B7%D0%B0%D0%B3%D0%BE%D0%BB%D0%BE%D0%B2%D0%BA%D0%B8-%D0%B2%D0%B5%D1%80%D1%85%D0%BD%D1%8F%D1%8F-%D1%81%D1%82%D1%80%D0%BE%D0%BA%D0%B0-%D0%B2-%D1%82%D0%B0%D0%B1%D0%BB%D0%B8%D1%87%D0%BA%D0%B0%D1%85-%D0%B2%D1%8B%D0%B2%D0%BE%D0%B4%D1%8F%D1%82%D1%81%D1%8F-%D0%BD%D0%B5-%D0%BE%D1%87%D0%B5%D0%BD%D1%8C-%D1%80%D0%BE%D0%B2%D0%BD%D0%BE-%D1%81%D0%BA%D1%80%D0%B8%D0%BD%D1%8B-%D0%BF%D1%80%D0%B8%D0%BB%D0%B0%D0%B3%D0%B0%D1%8E)


speak to David should we allow foreign cust's here


const, если объект нигде не меняется


use one of the code name cases: snake_case, or camelCase


메소드를 생성해보고 만든 메소드를 활용해보는 코드


what should do this function?. Name should be self-described!!!


лучше сделай так, ибо функции внутри функции не всегда удобно читать
```
const id = localStorage.getItem('linkForJson');
axios.get(id)...
```


Function_f  - name convention is violated: either functionF or function_f (depends on selected convention
Vector Row[], int row - all variable names should start from small letter
Never use same name for two different variables


Приятно написанный код. Все четко и ясно. По мелким моментам отписал.


Successfully deployed to following URLs:

* https://cviceni-test-88y7m47cw.now.sh
* https://cviceni-test.historylab.now.sh
* https://cviceni-test-git-master.historylab.now.sh


Merge what?


вместо того, чтобы каждый раз создавать новый json на серваке - обновляй старый, посмотри в апишке на метод `.update()`


On a side note: Expanding on the "Never have a struct in a bad state" idea, the borrow checker lets you do some pretty cool stuff to enforce this. In C++, if we have a function that can bork our class, it probably would look like this:

```c++
class MyClass {
public:
    void CanBorkMe();
    void IsBorked();
private:
    bool mIsBorked;
}
```
A naive way to rewrite this in rust would be:
```rust
struct MyStruct {
   isBorked : bool;
}
impl MyStruct {
    pub fn can_bork_me(&mut self);
    pub fn is_borked(&self) -> bool;
}
```

However, even if you error handle correctly you can be left with a borked struct. The more idiomatic way to do this is:

```rust
impl MyStruct {
pub fn can_bork_me(self) -> Result<Self, Err>;
}
```

That way, you lose ownership of the struct every time you do a "risky" thing, and gain it back if it went well. This actually composes pretty nicely, even if you have multiple such calls:
```rust
let my_thing = my_thing.can_bork_me()?.can_also_bork_me()?;
```

You can take this even further with typestates and some crazy stuff, so you can't even fathom calling a method that doesn't make sense (e.g. making it "type-impossible" to call "write()" on a device that is in read mode). But that's a story for another day :)


🔥 Device tests completed (Failed) on iOS32b on [Azure DevOps](https://dev.azure.com/devdiv/DevDiv/_build/index?buildId=3272990)(iOS32b): [Html Report](http://xamarin-storage/jenkins/xamarin-macios/master-fix-vsts-32b-testing/c98e667386205352efd1c801b6684be8ed339c11/3272990/device-tests/jenkins-results/tests/index.html) 🔥

# Test results

<details>
<summary>26 tests failed, 98 tests passed.</summary>

## Failed tests

 * dont link/iOS Unified 32-bits - device/Debug: BuildFailure
 * [xUnit] Mono BCL tests group 4/iOS Unified 32-bits - device/Debug: BuildFailure
 * mscorlib/iOS Unified 32-bits - device/Debug: BuildFailure
 * dont link/iOS Unified 32-bits - device/AssemblyBuildTarget: dylib (debug): BuildFailure
 * dont link/iOS Unified 32-bits - device/AssemblyBuildTarget: SDK framework (debug): BuildFailure
 * dont link/iOS Unified 32-bits - device/AssemblyBuildTarget: dylib (debug, profiling): BuildFailure
 * dont link/iOS Unified 32-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): BuildFailure
 * dont link/iOS Unified 32-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
 * [NUnit] Mono BCL tests group 1/iOS Unified 32-bits - device/Release: UseThumb: TimedOut
 * [NUnit] Mono BCL tests group 2/iOS Unified 32-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Failed
 * [NUnit] Mono BCL tests group 2/iOS Unified 32-bits - device/Release: TimedOut
 * [NUnit] Mono BCL tests group 2/iOS Unified 32-bits - device/Release: UseThumb: TimedOut
 * [NUnit] Mono BCL tests group 2/iOS Unified 32-bits - device/AssemblyBuildTarget: SDK framework (release): TimedOut
 * [xUnit] Mono BCL tests group 4/iOS Unified 32-bits - device/AssemblyBuildTarget: dylib (debug): BuildFailure
 * [xUnit] Mono BCL tests group 4/iOS Unified 32-bits - device/AssemblyBuildTarget: SDK framework (debug): BuildFailure
 * [xUnit] Mono BCL tests group 4/iOS Unified 32-bits - device/AssemblyBuildTarget: dylib (debug, profiling): BuildFailure
 * [xUnit] Mono BCL tests group 4/iOS Unified 32-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): BuildFailure
 * [xUnit] Mono BCL tests group 4/iOS Unified 32-bits - device/Release: UseThumb: TimedOut
 * mscorlib/iOS Unified 32-bits - device/AssemblyBuildTarget: dylib (debug): BuildFailure
 * mscorlib/iOS Unified 32-bits - device/AssemblyBuildTarget: SDK framework (debug): BuildFailure
 * mscorlib/iOS Unified 32-bits - device/AssemblyBuildTarget: dylib (debug, profiling): BuildFailure
 * mscorlib/iOS Unified 32-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): BuildFailure
 * mscorlib/iOS Unified 32-bits - device/Release: TimedOut
 * mscorlib/iOS Unified 32-bits - device/Release: UseThumb: Failed
 * mscorlib/iOS Unified 32-bits - device/AssemblyBuildTarget: SDK framework (release): TimedOut
 * mscorlib/iOS Unified 32-bits - device/Debug: SGenConc: BuildFailure
</details>


Function should be named by same method


тут у тебя явное повторение кода идет, можешь вынести этот функционал в отдельную функцию


gitignore bikeshare.py


Successfully deployed to following URLs:

* https://blog-k44gousau.now.sh
* https://blog-zeta-liart.now.sh
* https://blog.adexoming.now.sh
* https://blog-git-gh-pages.adexoming.now.sh


What means variable "A". Are "left, middle, right" indexes of elements?


Successfully deployed to following URLs:

* https://knowledge-base-5l3ulyvec.now.sh
* https://knowledge-base.now.sh
* https://lovepp.org
* https://www.lovepp.org
* https://knowledge-base.cenzhipeng.now.sh
* https://knowledge-base-git-master.cenzhipeng.now.sh


never call variables by single letter (try to avoid this even in for cycle)


What means variable "T".


What is i,j,k?


don't call variables by single letter


what is T


Successfully deployed to following URLs:

* https://ui-5n7k3h7f0.now.sh
* https://ui.roleypoly.com
* https://ui.roleypoly.now.sh
* https://ui-git-master.roleypoly.now.sh


what is A


첫번째 수정을했습니다 -현우-


Commit should be self-described.


.gitignore bikeshare.py


Successfully deployed to following URLs:

* https://entrepreneur-site-next-3tq5xscuk.now.sh
* https://wealthmack.com
* https://www.wealthmack.com
* https://entrepreneur-site-next.hacker-tom.now.sh
* https://entrepreneur-site-next-git-master.hacker-tom.now.sh


what is merge?


ls


mtx[5] it is not clear, that is is "matrix"


웹에서 바꿔버렸어용


Successfully deployed to following URLs:

* https://scratchpay-coding-challenge-5df2omfqx.now.sh
* https://scratchpay-coding-challenge.now.sh
* https://scratchpayusermanagementui.now.sh
* https://scratchpay-coding-challenge.kumarabhirup1.now.sh
* https://scratchpay-coding-challenge-git-master.kumarabhirup1.now.sh


Successfully deployed to following URLs:

* https://pple2-front-1kfigi921.now.sh
* https://pple2-front.now.sh
* https://pple2-front.pple.now.sh
* https://pple2-front-git-master.pple.now.sh


What does "my first commit" mean?


class should be named in upper camel case style - "ComputerGame"


✅ Device tests passed on iOS32b on [Azure DevOps](https://dev.azure.com/devdiv/DevDiv/_build/index?buildId=3273298)(iOS32b): [Html Report](http://xamarin-storage/jenkins/xamarin-macios/master/532059daf6a9a066cf0677b61fc1602d48eebc2f/3273298/device-tests/jenkins-results/tests/index.html) ✅

# No tests selected.


names should be self-descriptive. What does M stands for in InpM? Names for functions should start with small letter.


ссылку лучше сохранить в какую-нибудь константу
так же по поводу локалстореджа, не храни там целую ссылку на гет запрос, будет круто, если сможешь срезать айдишку и хранить только ее
дальше можешь их использовать вместе, типа такого:
```
const id = localStorage.getItem('id');
const url = 'https://api.myjson.com/bins/';
//get query
axios.get(url + id)...

//post query
axios.post(url)...

//update query
axios.update(url + id)...
```


Fix: bug in
account_groups = [accounts[d]["account_type"] for d in accounts if accounts[d]['is_group'] not in ('', 1)]
is wrong.

The correct way to determine if an account is 'is_group' can be if accounts[d]['is_group'] not in ('', 0)
However, the correction
   if accounts[d]['is_group'] == 1
is more consistent with the prior test for non-group account types.


same as InpM


Спасибо за весь фидбек, будет исправлено


Which sort?(column)
Second merge, it’s hard to understand, which one is responsible for what


what for this line?


If I remember correctly, this package shouldn't be used starting from java 8+ because it's replaced by something in the standard lib


dont name variables with 1 letter


The first word should begin with a small letter.


Use one cod name writing cases snake_case or camelCase


Fixed.


Again Matrix, should be column


`System.out.println(warrior);' or  `System.out.println(warrior.toString);` - is enough, information about God should be printed by toString() method


thanks, Stephen, you have saved me a lot of time searching. Could you explain more? I would like to understand the switch from invokable to factories.


commit is supposed to beself-describing


git reset


Utilizamos el printlne como MethodReference


What is i,j? (should write column or row


input what?


What does it mean “FiAij” ?


@cmahond1 @cwelchmi

Fixed capitalization issues.

These are the final TechComm edits.


add information about health and name


output what?


Inappropriate name for variable


Why Matrix


Ovaj repo je **public**, treba da bude private.


method name should start from lower letter.


Please name class appropriatly: Matrix, Mat ...


the name of mathod has to be self-describing


What means pt ?


Why are you using this name “dobutock”? You can rename it better, but “dobutok” is also good :)


Nope, that's not weird at all :) that's usually idiomatic. A given struct can have one impl block and as many "impl trait" blocks as you like.

That's one of the beauties of Rust's module system, nothing stops you from adding functionality to existing types:

```
pub trait Doubler {
    fn print_double(&self);
}

impl Doubler for &str {
    fn print_double(&self) { println!("{}{}", self, self) }
}

pub fn main() {
    "Hello World".print_double();
}

// Prints "Hello WorldHello World"
```

But if you want your mind truly blown, you can implement them for Traits too!
```
use std::fmt::Display;

pub trait Doubler {
    fn print_double(&self);
}

// Anything that implements "Display" (whether you did that or not) automagically implements this

impl<T: Display> Doubler for T {
    fn print_double(&self) { println!("{}{}", self, self) }
}

pub fn main() {
    "Hello World".print_double();
    3.print_double();
}
// Prints "Hello WorldHello World\n33"
```


What is A? should be used array or other name


What are values?


method names should start with an lower case letter - "sort", "inputMatrix"


What does it mean “i”?


The word that is written after the underscore should begin with a small letter.


It is better to name variables like "rows" and "columns" instead of "i" and "j"


Matrix -> Column -> Matrix??


One letter variables are unacceptable


pizdec


What does you mean “n”?


Which sort?


variable shouldnt be named with 1 letter


Do we really need this id ? Can't we just have a composed key between `bam_id`, `target_name`, `seq_start` and `seq_end` ? Just asking if it would make sense.


#What
投稿機能を実装する。railsのscaffoldを用いてarticleモデルを作成し、titleカラム、authorカラム、textカラムを作成した。

＃Why
記事投稿機能は本アプリケーションの根幹機能であるため。


"mj" is not a self-explanatory name for a variable


и подсказка по поводу создания
когда страница загрузилась, то надо сразу найти в локал сторедже айдишку, если ее нет, то тогда ты сразу кидаешь `.post()` запрос и сохраняешь эту айдишку себе, если же ее сразу нашло в локал сторедже, то запрос кидать не нужно, просто сохрание ее в переменную


No control-freec/11.5/test-cmds.txt (test file) present, skipping tests


in this case, we need to use an additional input for the hashing function, for example, a timestamp (now) but Calor need to know what was the time stamp that was used to generate the hash value. Also, Alice needs to remember the timestamp with other inputs to be able to reclaim money


what is find_f?


Successfully deployed to following URLs:

* https://personal-4ak4fvfde.now.sh
* https://www.connordav.is
* https://personal.connordavis.now.sh
* https://personal-git-master.connordavis.now.sh


Where is _?


names for variables should be mor original. whats the difference between a and A?


I would have created a package under `store`.


Yes, that's very typical :) even if the struct contains nothing, having a struct has many benefits like leveraging the borrow checker to make sure things happen in the right order/with the right access. Coming from C/C++ it may look like an empty struct is useless, but a lot of information is encoded in the type system thanks to it.


Do your c++ code have been beautified? Everything seems to be good!


Use one cod name writing cases snake_case or camelCase


This would likely be part of the constructor (returning Self).


applies to all methods


Use define


s


1.the name of mathod has to be self-describing
2.what is arr
3.why not use const instead of 5 as size of array


Why 5? What if i asked you to sort matrix 3x3.


this one would be a method taking &mut self.


applies to most variable names


Does the response match with `IRestApiResponse` interface? If so, you could use `IRestApiResponse<string>`.


add setters and getters


Looks like after this change it's impossible to override `singleSpaConfig` in here because `options` is never used, so f.e. `library: 'app3'` is hard-coded forever


That belongs to the dependency strategy in main.


Why did you started name of variable from symbol?


Int called "A", what do you mean? Don't make the name a single letter.


What does you mean “j”?


In name of this function, please describe what are you sorting: columns, lines. ascending or descending


You can rename your void “SumOfColumn” to “SummaryColumn”, it will be better :)


IBM Cloud [toolchain](https://cloud.ibm.com/devops/toolchains/2ffd1377-c49a-48fc-a383-59ce469869f8?env_id=ibm%3Ayp%3Aus-south "empty-toolchain-my-tch"): [Delivery Pipeline](https://cloud.ibm.com/devops/pipelines/b5d0563e-fdff-479e-9e68-1063cd9a1193 "goapp") deployed [goapp](https://github.com/Hy6axa/goapp/releases/tag/deploy-mycluster-20191126-112035 "deploy-mycluster-20191126-112035") to [mycluster](https://console.bluemix.net/kubernetes/clusters/bnb5dmpd0ku82n3q2e30/overview "There was a problem retrieving the space name"), including this commit


This part of code is badly optimized, you could make it much more shorter


Function names should start with lowercase.
Never call variables by single letter (e.g. i j)
Function names should have single style (mergeSort, not mergesort).
What is the difference between "merge" and "mergesort"?
Divide complicated functions into different functions.
What is the purpose of FunctionMain?
Use define to set matrix size (what if i wanted to change 5 to 3)


you should have either specified it in main, even better - it should have been requested into a variable every time program is started


@AndyGrant: found the problem and fixed it. It was really stupid. What would I do without `cutechess-cli -debug` :)


Bear in mind that you need to write another `Store` implementation that uses diesel to write into a database.


revert


use #define instead of writing 5, 4 ... etc


In this function and further, please  replace Vector with another name: Matrix, Mat.....


Int called "A" and "T", what do you mean? Don't make the name a single letter.


Vector line?Change  name of that variable🙂


in  this case will be better use "inputMatrix" as a name of function.


Variables "beginning" and "end" does not review what they do


Successfully deployed to following URLs:

* https://scratchpay-coding-challenge-bjoiha042.now.sh
* https://scratchpay-coding-challenge.now.sh
* https://scratchpayusermanagementui.now.sh
* https://scratchpay-coding-challenge.kumarabhirup1.now.sh
* https://scratchpay-coding-challenge-git-master.kumarabhirup1.now.sh


all comments should be rid of after you finish


Use define


for all Vector.cpp
variables shouldnt be named with 1 letter


In name of this func pleas describe what you are calculating


[R/check_pir_out.R:17:1:](https://github.com/richelbilderbeek/pirouette/blob/afa317077e5ed68b900d601df6595f9762b8720a/R/check_pir_out.R#L17) *style:* **functions should have cyclomatic complexity of less than 15, this has 17.**
```r
check_pir_out <- function(
^
```
[R/create_alignment_with_std_site_model.R:5:1:](https://github.com/richelbilderbeek/pirouette/blob/afa317077e5ed68b900d601df6595f9762b8720a/R/create_alignment_with_std_site_model.R#L5) *style:* **Variable and function names should not be longer than 30 characters.**
```r
create_alignment_with_std_site_model <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_all_experiments.R:24:1:](https://github.com/richelbilderbeek/pirouette/blob/afa317077e5ed68b900d601df6595f9762b8720a/R/create_all_experiments.R#L24) *style:* **functions should have cyclomatic complexity of less than 15, this has 30.**
```r
create_all_experiments <- function(
^
```
[R/create_copy_twin_tree_from_true_fun.R:21:1:](https://github.com/richelbilderbeek/pirouette/blob/afa317077e5ed68b900d601df6595f9762b8720a/R/create_copy_twin_tree_from_true_fun.R#L21) *style:* **Variable and function names should not be longer than 30 characters.**
```r
create_copy_twin_tree_from_true_fun <- function() {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/est_evidences.R:35:1:](https://github.com/richelbilderbeek/pirouette/blob/afa317077e5ed68b900d601df6595f9762b8720a/R/est_evidences.R#L35) *style:* **functions should have cyclomatic complexity of less than 15, this has 20.**
```r
est_evidences <- function(
^
```
[R/get_sim_true_alignment_with_lns_site_model_fun.R:23:1:](https://github.com/richelbilderbeek/pirouette/blob/afa317077e5ed68b900d601df6595f9762b8720a/R/get_sim_true_alignment_with_lns_site_model_fun.R#L23) *style:* **Variable and function names should not be longer than 30 characters.**
```r
get_sim_true_alignment_with_lns_site_model_fun <-
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/get_sim_true_alignment_with_std_site_model_fun.R:21:1:](https://github.com/richelbilderbeek/pirouette/blob/afa317077e5ed68b900d601df6595f9762b8720a/R/get_sim_true_alignment_with_std_site_model_fun.R#L21) *style:* **Variable and function names should not be longer than 30 characters.**
```r
get_sim_true_alignment_with_std_site_model_fun <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/get_sim_true_alignment_with_uns_site_model_fun.R:20:1:](https://github.com/richelbilderbeek/pirouette/blob/afa317077e5ed68b900d601df6595f9762b8720a/R/get_sim_true_alignment_with_uns_site_model_fun.R#L20) *style:* **Variable and function names should not be longer than 30 characters.**
```r
get_sim_true_alignment_with_uns_site_model_fun <-
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/get_sim_twin_alignment_with_same_n_mutation_fun.R:29:1:](https://github.com/richelbilderbeek/pirouette/blob/afa317077e5ed68b900d601df6595f9762b8720a/R/get_sim_twin_alignment_with_same_n_mutation_fun.R#L29) *style:* **Variable and function names should not be longer than 30 characters.**
```r
get_sim_twin_alignment_with_same_n_mutation_fun <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/get_sim_twin_alignment_with_std_site_model_fun.R:30:1:](https://github.com/richelbilderbeek/pirouette/blob/afa317077e5ed68b900d601df6595f9762b8720a/R/get_sim_twin_alignment_with_std_site_model_fun.R#L30) *style:* **Variable and function names should not be longer than 30 characters.**
```r
get_sim_twin_alignment_with_std_site_model_fun <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/select_candidate_evidences.R:25:1:](https://github.com/richelbilderbeek/pirouette/blob/afa317077e5ed68b900d601df6595f9762b8720a/R/select_candidate_evidences.R#L25) *style:* **functions should have cyclomatic complexity of less than 15, this has 20.**
```r
select_candidate_evidences <- function(
^
```
[R/sim_alignment_with_std_site_model.R:15:1:](https://github.com/richelbilderbeek/pirouette/blob/afa317077e5ed68b900d601df6595f9762b8720a/R/sim_alignment_with_std_site_model.R#L15) *style:* **Variable and function names should not be longer than 30 characters.**
```r
sim_alignment_with_std_site_model <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_true_alignment_with_lns_site_model.R:12:1:](https://github.com/richelbilderbeek/pirouette/blob/afa317077e5ed68b900d601df6595f9762b8720a/R/sim_true_alignment_with_lns_site_model.R#L12) *style:* **Variable and function names should not be longer than 30 characters.**
```r
sim_true_alignment_with_lns_site_model <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_true_alignment_with_std_site_model.R:21:1:](https://github.com/richelbilderbeek/pirouette/blob/afa317077e5ed68b900d601df6595f9762b8720a/R/sim_true_alignment_with_std_site_model.R#L21) *style:* **Variable and function names should not be longer than 30 characters.**
```r
sim_true_alignment_with_std_site_model <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_true_alignment_with_uns_site_model.R:13:1:](https://github.com/richelbilderbeek/pirouette/blob/afa317077e5ed68b900d601df6595f9762b8720a/R/sim_true_alignment_with_uns_site_model.R#L13) *style:* **Variable and function names should not be longer than 30 characters.**
```r
sim_true_alignment_with_uns_site_model <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_twin_alignment_with_lns_site_model.R:11:1:](https://github.com/richelbilderbeek/pirouette/blob/afa317077e5ed68b900d601df6595f9762b8720a/R/sim_twin_alignment_with_lns_site_model.R#L11) *style:* **Variable and function names should not be longer than 30 characters.**
```r
sim_twin_alignment_with_lns_site_model <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_twin_alignment_with_same_n_mutation.R:30:1:](https://github.com/richelbilderbeek/pirouette/blob/afa317077e5ed68b900d601df6595f9762b8720a/R/sim_twin_alignment_with_same_n_mutation.R#L30) *style:* **Variable and function names should not be longer than 30 characters.**
```r
sim_twin_alignment_with_same_n_mutation <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_twin_alignment_with_std_site_model_raw.R:5:1:](https://github.com/richelbilderbeek/pirouette/blob/afa317077e5ed68b900d601df6595f9762b8720a/R/sim_twin_alignment_with_std_site_model_raw.R#L5) *style:* **Variable and function names should not be longer than 30 characters.**
```r
sim_twin_alignment_with_std_site_model_raw <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_twin_alignment_with_std_site_model.R:29:1:](https://github.com/richelbilderbeek/pirouette/blob/afa317077e5ed68b900d601df6595f9762b8720a/R/sim_twin_alignment_with_std_site_model.R#L29) *style:* **Variable and function names should not be longer than 30 characters.**
```r
sim_twin_alignment_with_std_site_model <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_twin_alignment_with_uns_site_model.R:11:1:](https://github.com/richelbilderbeek/pirouette/blob/afa317077e5ed68b900d601df6595f9762b8720a/R/sim_twin_alignment_with_uns_site_model.R#L11) *style:* **Variable and function names should not be longer than 30 characters.**
```r
sim_twin_alignment_with_uns_site_model <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


1.the name of mathod has to be self-describing
2.what is arr
3. the names of arguments of method have to be self-describing(the name of variable mustn't constist of only 1 letter)


what does "n" mean? Is it size or so?


the name of variable mustn't constist of only 1 letter


Int called "A", what do you mean? Don't make the name a single letter.


what do this function?  don't use single symbol as a name.


what is this loop used for?


Все input теперь обернуты в label


I don't think it is a good idea to default to particular engine inside the library function. Should be done outside of the library and explicitly passed as a parameter from `src/ostree/ot-builtin-static-delta.c`.


Variable "mid" does not review what it mean


If we are able to generate the same hash value as generated before (with passwordBob, carol) with this means that this carol is the intended carol of the hash


don't use single symbol as a name.


What is massive1?


what is "a"? is it size or so?


Successfully deployed to following URLs:

* https://wanders-pfdr1ll24.now.sh
* https://wanders-omega-six.now.sh
* https://vadrouilles.co
* https://wanders.ys1.now.sh
* https://wanders-git-master.ys1.now.sh


in general code could be tidier - no skipped lines, proper whitespace


Code is identical to https://github.com/MaxZvarych/project_1


Looks Good you added case Statments


what is size1?


what is size2?


You have fixed Probability ok


Code is identical to https://github.com/KhrystynaVysotska/IoT-intotospecialty


lifeline
khushi
avantika
12345678
87654321
friends
FRIEND
friend
Friend
Love
love
Luv
uh
you
faimly
Faimly
FAIMLY
everything
Everything
sister
Sister
SISTER
7088217182
7088712182
BBULUVU
bbuluvu
lattuluvu
Army
danish
Danish
kishore
bijalwan
Bijalwan
momdad
mummypapa
Life
seemababbi
ritika
khushi
Khushi
KHUSHI
AASTHA
Astha
aastha
Aastha
avantika
Avantika
shraddha
hateuh


please  do not name variables with single letter, and change to ; column, row or something else


[Régis Hanol posted](https://review.discourse.org/t/fix-oneboxer-js-infinitely-retrying-failed-requests-8414/7300/3):

I think that's worthy of a test. That's bad behavior enough we don't want it to happen again.


edited for test


it would be better for a user to see the number [i][j] of element they are entering


The word that is written after the underscore should begin with a small letter.


don't use single symbol as a name.


Successfully deployed to following URLs:

* https://projet3-eldebaran3000-dn8w7teb5.now.sh
* https://projet-3-eldebaran3000.now.sh
* https://projet-3-eldebaran3000.clementsiche.now.sh
* https://projet-3-eldebaran3000-git-master.clementsiche.now.sh


From The Odin Project's [curriculum](http://www.theodinproject.com/courses/web-development-101/lessons/html-css)


Overall, mergeSort you can rename to steps. Or do something with that “void mergeSort”


use {} when writing if statements or use "enter" to go to next line.
if(statement){
*code goes here*
}

OR

if(statement)
*single line of code*


What is F?


Variables shouldn't start with single letter.


what is left and right?


What is f?


Telegram made some server-side changes, set [this setting](https://docs.madelineproto.xyz/docs/SETTINGS.html#settingsconnection_settingsallpfs) to false to fix.


t[k] - what is this?


methods can't be named <single letter>, <function or any iteration of that word>

applies for other methods


variable is supposed to be sefl-describing


don't use single letter as variable name, even in cycles


Variables should be self-descriptive. Please consider using easy-understandable names afterwards.


"merge" is very close to "mergeSort". You should name it differently.


If we set `own = 1`, only `1` *value* can be slashed. (slash > 1, here)

But in `Self::slash_individual(stash, Perbill::from_rational_approximation(own_slash, exposure.own));`, `Perbill` will always be `1`. So we always slash `100% active_ring/kton`.

Test case: https://github.com/darwinia-network/substrate/blob/d2c4b0dbd89d9588adcbe97320e27f49ee251411/srml/staking/src/tests.rs#L1663.


In the latest models, machine name has been modified to **RB2011UiAS** (note the RB that was not there before)

`machine                 : Mikrotik RouterBOARD RB2011UiAS`

Content in file _target/linux/ar71xx/base-files/lib/ar71xx.sh_ has to be modified adding the new terms:

```
        *"RouterBOARD RB2011UiAS")
                name="rb-2011uias"
                ;;
        *"RouterBOARD RB2011UiAS-2HnD")
                name="rb-2011uias-2hnd"
                ;;
        *"RouterBOARD RB2011UiAS-2HnD r2")
                name="rb-2011uias-2hnd-r2"
                ;;
```


Here.


Why did you include elevator ID creation in this it should be in constructor


It's fine, yeah :) though the control flow there is a bit awkward. Can be rewritten like:

```rust
        if let Ok(destination_position) = (source_position - buffer.width + 1).checked_sub(decay) {
            buffer.buffer[destination_position] = pixel - (decay as i32 & 1);
        }
```

The refutable binding (if let) only handles the Ok() case, so there's no need to unwrap (the Err case is just ignored).


It is better to name variables like "rows" and "columns" instead of "i" and "j"


Function should be self-described.


what is a ?


what is b?


What is x?


Rewrite this to a better sentence “All sums multiplied: “ — “All summary multiplied: “


use #define instead of writing 5, 4 ... etc


Variebles shouldn't start with single letter.


The word that is written after the underscore should begin with a small letter.


User @hareve is reporting that this line was removed and has broken their usage of jetty-maven-plugin, and is wondering why it was removed.


methods should be explicit enough to understand what they are doing - it would be better as "mergeSort"


what is a,k?


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


Please in comment tell what does the variable h really do!


don't use single symbol as a name.


Successfully deployed to following URLs:

* https://docspyvecorg-f5y62txve.now.sh
* https://docspyvecorg.pyvec.now.sh
* https://docspyvecorg-git-master.pyvec.now.sh


"array" is very close to "arr". You should name it differently


again so


what is i?


res mean result?


again


what is i??


Please , change name Vector, i don't know what does it mean


The first word and the word that is written after the underscore should begin with a small letter.


IBM Cloud [toolchain](https://cloud.ibm.com/devops/toolchains/215cc15b-945a-45de-8a9f-17d223232290?env_id=ibm%3Ayp%3Aeu-de "mixin-react-todo"): [Delivery Pipeline](https://cloud.ibm.com/devops/pipelines/690e729d-ec09-42c0-ab34-68c7f0d0a1b7 "mixin-react-todo") deployed [awesome-mixin](https://github.com/cerasela-iordan/awesome-mixin/releases/tag/deploy-ibm-yp-eu-gb-flutterbyez-gmail.com-dev-20191126-113028 "deploy-ibm-yp-eu-gb-flutterbyez-gmail.com-dev-20191126-113028") to [dev](https://console.bluemix.net/apps/74b83403-81ee-4bf1-9078-b4569744a346?env_id=ibm:yp:eu-gb "ibm:yp:eu-gb:flutterbyez@gmail.com:dev"), including this commit


Successfully deployed to following URLs:

* https://more-kzm7bza9p.now.sh
* https://more.617754841.now.sh
* https://more-git-master.617754841.now.sh


what does it mean t[i - start] ?


what is h?


Successfully deployed to following URLs:

* https://new-york-times-d2j20r5u5.now.sh
* https://new-york-times-eta-one.now.sh
* https://new-york-times.char502.now.sh
* https://new-york-times-git-master.char502.now.sh


You want this to be a [drop()](https://doc.rust-lang.org/rust-by-example/trait/drop.html) unless you plan to call it separately (other than when disposing of it).


run


what does t[k] mean?


what is j?


Variable "merge" does not review what it mean


eer


dadfa


one letter variables is bad,man


don't use single symbol as a name.


Hello. Thanks for the work you've done.  Does this method only work for cc2531?
I tried to flash cc2530 through the STM32F1xx board. There is a problem after startup flash.sh.
flash.log:
 :020000040000FA
flashing segment starting at 00000
:10000000021305022003FFFFFFFFFF02200BFFFF8B
unknown chip ID A5, aborting.


what is f_n?


nope


"min" what is it? What do you mean?


Добавил в #634 подробностей, надеюсь, поможет. Ща соберу мастер, проверю 99%.


names of variables and functions should be self descriptive and understandable.


"start", "mid", "end" of what? Just add "startOfMatrix" or "end_of_matrix" ...


what is V[n]


Successfully deployed to following URLs:

* https://knowledge-base-76bpwuelk.now.sh
* https://knowledge-base.now.sh
* https://lovepp.org
* https://www.lovepp.org
* https://knowledge-base.cenzhipeng.now.sh
* https://knowledge-base-git-master.cenzhipeng.now.sh


Preferably, try to change some circumstances


a very bad way to call variable,the name of variable mustn't constist of only 1 letter


What is y?


Awesome 🎉


The first word should begin with a small letter.


"k" does not review what it mean


Please do not name variable as "a"


what is A[i] and V[j]?


"p" does not review what it mean


in  this case will be better use "inputMatrix" as a name of function.


Name A is not understandable, the name should say what does is means. Names should start from short letter


run


Variables named as single letters!!!


sure looks like one ;)

Often when you see "collection" mods like this, you often see them reexport things with friendlier names, e.g.

```rust
pub use fire_engine::thing as thing;
```
So people can call doom_fire::thing.


use one of the code name cases: snake_case, or camelCase


The word that is written after the underscore should begin with a small letter.


What does mean "res"


Variebles should be self-descriptive.Pleas consider using easy-understandable names afterwards.


Variables should be named from short letter


what is b[h]


This was used to record the length of an execution.


Have you been able to test that these changes work successfully? I'd be willing to merge them if they are definitely working!


See other posts about initialization and such :)


Rename this “sortMatrixRows”


What does mean "sum"


the name of variable mustn't constist of only 1 letter, the name of variable is supposed to be self-describing


what is str[n]


IBM Cloud [toolchain](https://cloud.ibm.com/devops/toolchains/215cc15b-945a-45de-8a9f-17d223232290?env_id=ibm%3Ayp%3Aeu-de "mixin-react-todo"): [Delivery Pipeline](https://cloud.ibm.com/devops/pipelines/690e729d-ec09-42c0-ab34-68c7f0d0a1b7 "mixin-react-todo") deployed [awesome-mixin](https://github.com/cerasela-iordan/awesome-mixin/releases/tag/deploy-ibm-yp-eu-gb-flutterbyez-gmail.com-dev-20191126-113548 "deploy-ibm-yp-eu-gb-flutterbyez-gmail.com-dev-20191126-113548") to [dev](https://console.bluemix.net/apps/74b83403-81ee-4bf1-9078-b4569744a346?env_id=ibm:yp:eu-gb "ibm:yp:eu-gb:flutterbyez@gmail.com:dev"), including this commit


what is trmp_mass?


Successfully deployed to following URLs:

* https://galtier-nuxt-offers-6yefvh1uj.now.sh
* https://galtier.info53.now.sh
* https://galtier-nuxt-offers.info53.now.sh
* https://galtier-nuxt-offers-git-master.info53.now.sh


Rewrite this “mergeSort” as I have noticed below at the comments


What does k means? Variables should say what they mean.


What does mean "n"


OK, It just me or this is overlooked by Josh. It should be "using high_resolution_clock = std::chrono::high_resolution_clock" instead "using clock", because next few commits depends on "dxvk::high_resolution_clock", and I'm guess you will get big fat ERROR on non _WIN32 builds. Or I'm missing something. Sorry If I'm wrong.


По баге с editor'ом выделил более простой sample, достаточно открыть в editore и подвигать курсор кнопками-стрелками по всей строке. ИЧСХ, он даже не ругается на некорректные символы при открытии этого файла как UTF8.

Пожалуй, это стоит отдельного тикета, чтоб не потерялось. #638


if you are writing about old matrix, pleas rename your class


>
>
> What does mean "sum"

[https://www.youtube.com/watch?v=HbvYeLxMKN8](CLICK)


what is arr[i]?


Variables should say what they mean


You have to finish the builder with `ot_variant_builder_end()` to get the data for signing. After the successful signing  you need to reconstruct the variant.


IBM Cloud [toolchain](https://cloud.ibm.com/devops/toolchains/2ffd1377-c49a-48fc-a383-59ce469869f8?env_id=ibm%3Ayp%3Aus-south "empty-toolchain-my-tch"): [Delivery Pipeline](https://cloud.ibm.com/devops/pipelines/b5d0563e-fdff-479e-9e68-1063cd9a1193 "goapp") deployed [goapp](https://github.com/Hy6axa/goapp/releases/tag/deploy-mycluster-20191126-113838 "deploy-mycluster-20191126-113838") to [mycluster](https://console.bluemix.net/kubernetes/clusters/bnb5dmpd0ku82n3q2e30/overview "There was a problem retrieving the space name"), including this commit


the name of method isn't self-describing


method name should start from lower letter.


file commit "adding my Lab #5 with topic as merge sort" isn't very informative, I advice you to change it


No test-ci/0.0.2/test-cmds.txt (test file) present, skipping tests


Deployment failed with the following error:

~~~
You defined 1 build that did not match any source files (please ensure they are NOT defined in .nowignore):
~~~


You can try and combine this two lines (79-81) to use less lines of your code (this also will beautify the code)


dasd


The names of the variables i and j should be informative


♂what♂is♂arr?♂


Yes - I think that $errno lines up with PHP error codes (all, warning, etc.). I was thinking this strategy should be a backstop - wherever possible logical errors should probably be handled more explicitly with a try and catch. So I was thinking it would be ok to hard code these as 500 errors....


Не, осталось 99% на UTF-8 во viewer'e на конце vmlinuz, увы.

О, новую особенность нашёл: если нажать стрелку вниз, таки прокручивается до 100%. Т.е. нажатие End кидает не на конец файла, а на конец файла минус одну строку.


Successfully deployed to following URLs:

* https://picker-7221peme2.now.sh
* https://picker-omega-five.now.sh
* https://picker.react-component.now.sh
* https://picker-git-master.react-component.now.sh


what is "i"?


[R/clock_model_to_xml_prior_distr.R:14:23:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/clock_model_to_xml_prior_distr.R#L14) *warning:* **no visible global function definition for ‘rln_clock_model_to_xml_mean_rate_prior’**
```r
      text <- c(text, rln_clock_model_to_xml_mean_rate_prior(clock_model)) # nolint beautier function
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/clock_models_to_xml_state.R:32:23:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/clock_models_to_xml_state.R#L32) *warning:* **no visible global function definition for ‘clock_model_to_xml_state’**
```r
    line_to_remove <- clock_model_to_xml_state(clock_models[[1]]) # nolint
                      ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_beast2_input_distr.R:9:19:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_beast2_input_distr.R#L9) *warning:* **no visible global function definition for ‘tree_priors_to_xml_prior_distr’**
```r
  text <- c(text, tree_priors_to_xml_prior_distr(tree_priors)) # nolint beautier function
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_beast2_input_distr.R:10:19:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_beast2_input_distr.R#L10) *warning:* **no visible global function definition for ‘gamma_site_models_to_xml_prior_distr’**
```r
  text <- c(text, gamma_site_models_to_xml_prior_distr(site_models)) # nolint beautier function
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_beast2_input_distr.R:11:19:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_beast2_input_distr.R#L11) *warning:* **no visible global function definition for ‘site_models_to_xml_prior_distr’**
```r
  text <- c(text, site_models_to_xml_prior_distr(site_models)) # nolint beautier function
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_beast2_input_operators.R:27:19:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_beast2_input_operators.R#L27) *warning:* **no visible global function definition for ‘site_models_to_xml_operators’**
```r
  text <- c(text, site_models_to_xml_operators(site_models)) # nolint beautier function
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_beast2_input_run.R:23:11:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_beast2_input_run.R#L23) *warning:* **no visible global function definition for ‘mcmc_to_xml_run’**
```r
  text <- mcmc_to_xml_run(mcmc) # nolint beautier function
          ^~~~~~~~~~~~~~~
```
[R/create_beast2_input_state.R:24:19:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_beast2_input_state.R#L24) *warning:* **no visible global function definition for ‘site_models_to_xml_state’**
```r
  text <- c(text, site_models_to_xml_state(site_models)) # nolint beautier function
                  ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_beast2_input_state.R:33:19:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_beast2_input_state.R#L33) *warning:* **no visible global function definition for ‘tree_priors_to_xml_state’**
```r
  text <- c(text, tree_priors_to_xml_state(tree_priors)) # nolint beautier function
                  ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_clock_models_from_names.R:5:26:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_clock_models_from_names.R#L5) *warning:* **no visible global function definition for ‘create_clock_model_from_name’**
```r
    clock_models[[i]] <- create_clock_model_from_name(clock_model_name) # nolint beautier function
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_mcmc_nested_sampling.R:41:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_mcmc_nested_sampling.R#L41) *style:* **Lines should not be more than 80 characters.**
```r
#' @aliases create_ns_mcmc create_nested_sampling_mcmc create_mcmc_nested_sampling
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_mcmc_nested_sampling.R:42:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_mcmc_nested_sampling.R#L42) *style:* **Lines should not be more than 80 characters.**
```r
#' @export create_ns_mcmc create_nested_sampling_mcmc create_mcmc_nested_sampling
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_site_models_from_names.R:5:25:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_site_models_from_names.R#L5) *warning:* **no visible global function definition for ‘create_site_model_from_name’**
```r
    site_models[[i]] <- create_site_model_from_name(site_model_name) # nolint beautier function
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_tracelog_xml.R:17:19:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_tracelog_xml.R#L17) *warning:* **no visible global function definition for ‘tree_models_to_xml_tracelog’**
```r
  text <- c(text, tree_models_to_xml_tracelog(site_models)) # nolint beautier function
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_tracelog_xml.R:32:19:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/create_tracelog_xml.R#L32) *warning:* **no visible global function definition for ‘tree_priors_to_xml_tracelog’**
```r
  text <- c(text, tree_priors_to_xml_tracelog(tree_priors)) # nolint beautier function
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/extract_xml_operators_from_lines.R:13:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/extract_xml_operators_from_lines.R#L13) *style:* **Lines should not be more than 80 characters.**
```r
  last_line <- beautier::find_last_regex_line(lines, "(<operator id=\")|(</operator>)")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/extract_xml_section_from_lines.R:7:12:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/extract_xml_section_from_lines.R#L7) *warning:* **no visible global function definition for ‘extract_xml_operators_from_lines’**
```r
    return(extract_xml_operators_from_lines(lines)) # nolint beautier function
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/find_last_xml_closing_tag_line.R:6:3:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/find_last_xml_closing_tag_line.R#L6) *warning:* **no visible global function definition for ‘find_last_regex_line’**
```r
  find_last_regex_line(lines, paste0("</", section, ">")) # nolint beautier function
  ^~~~~~~~~~~~~~~~~~~~
```
[R/get_alignment_id.R:5:9:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/get_alignment_id.R#L5) *warning:* **no visible global function definition for ‘get_file_base_sans_ext’**
```r
  id <- get_file_base_sans_ext(fasta_filename) # nolint beautier function
        ^~~~~~~~~~~~~~~~~~~~~~
```
[R/get_alignment_id.R:9:3:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/get_alignment_id.R#L9) *warning:* **no visible global function definition for ‘check_alignment_id’**
```r
  check_alignment_id(id)
  ^~~~~~~~~~~~~~~~~~
```
[R/has_xml_opening_tag.R:11:12:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/has_xml_opening_tag.R#L11) *warning:* **no visible global function definition for ‘get_xml_opening_tag’**
```r
    tag <- get_xml_opening_tag(lines) # nolint
           ^~~~~~~~~~~~~~~~~~~
```
[R/has_xml_opening_tag.R:14:24:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/has_xml_opening_tag.R#L14) *warning:* **no visible global function definition for ‘find_first_xml_opening_tag_line’**
```r
  !beautier::is_one_na(find_first_xml_opening_tag_line(lines, section))
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/init_clock_models.R:10:10:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_clock_models.R#L10) *warning:* **no visible global function definition for ‘get_alignment_ids_from_fasta_filenames’**
```r
  ids <- get_alignment_ids_from_fasta_filenames(fasta_filenames) # nolint beautier function
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/init_clock_models.R:13:26:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_clock_models.R#L13) *warning:* **no visible global function definition for ‘get_distr_n_params’**
```r
  param_id <- param_id + get_distr_n_params(ucldstdev_distr) # nolint beautier function
                         ^~~~~~~~~~~~~~~~~~
```
[R/init_clock_models.R:20:26:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_clock_models.R#L20) *warning:* **no visible global function definition for ‘get_distr_n_params’**
```r
  param_id <- param_id + get_distr_n_params(mean_rate_prior_distr) # nolint beautier function
                         ^~~~~~~~~~~~~~~~~~
```
[R/init_distr.R:9:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_distr.R#L9) *style:* **functions should have cyclomatic complexity of less than 15, this has 25.**
```r
init_distr <- function(
^
```
[R/init_inference_model.R:39:22:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_inference_model.R#L39) *warning:* **no visible global function definition for ‘init_mrca_prior’**
```r
  inference_model <- init_mrca_prior(input_filename, inference_model)
                     ^~~~~~~~~~~~~~~
```
[R/init_mrca_prior.R:8:50:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_mrca_prior.R#L8) *warning:* **no visible global function definition for ‘get_alignment_id’**
```r
      inference_model$mrca_prior$alignment_id <- get_alignment_id(input_filename) # nolint beautier function
                                                 ^~~~~~~~~~~~~~~~
```
[R/init_mrca_prior.R:11:48:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_mrca_prior.R#L11) *warning:* **no visible global function definition for ‘get_taxa_names’**
```r
      inference_model$mrca_prior$taxa_names <- get_taxa_names(input_filename) # nolint beautier function
                                               ^~~~~~~~~~~~~~
```
[R/init_site_models.R:44:28:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_site_models.R#L44) *warning:* **no visible global function definition for ‘get_site_model_n_params’**
```r
    param_id <- param_id + get_site_model_n_params(site_model) # nolint beautier function
                           ^~~~~~~~~~~~~~~~~~~~~~~
```
[R/init_site_models.R:198:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_site_models.R#L198) *style:* **Lines should not be more than 80 characters.**
```r
  testit::assert(beautier::is_init_gamma_site_model(gtr_site_model$gamma_site_model))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/init_site_models.R:220:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_site_models.R#L220) *style:* **Lines should not be more than 80 characters.**
```r
  if (!beautier::is_one_na(hky_site_model$gamma_site_model$gamma_shape_prior_distr)) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/init_site_models.R:299:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_site_models.R#L299) *style:* **Lines should not be more than 80 characters.**
```r
  testit::assert(beautier::is_init_gamma_site_model(jc69_site_model$gamma_site_model))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/init_site_models.R:327:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/init_site_models.R#L327) *style:* **Lines should not be more than 80 characters.**
```r
    !beautier::is_one_na(tn93_site_model$gamma_site_model$gamma_shape_prior_distr)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/interspace.R:6:11:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/interspace.R#L6) *warning:* **no visible global function definition for ‘count_trailing_spaces’**
```r
  nsni <- count_trailing_spaces(lines[1]) # nolint beautier function
          ^~~~~~~~~~~~~~~~~~~~~
```
[R/is_clock_model_name.R:2:13:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_clock_model_name.R#L2) *warning:* **no visible global function definition for ‘get_clock_model_names’**
```r
  name %in% get_clock_model_names() # nolint beautier function
            ^~~~~~~~~~~~~~~~~~~~~
```
[R/is_default_mcmc.R:2:8:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_default_mcmc.R#L2) *warning:* **no visible global function definition for ‘is_mcmc’**
```r
  if (!is_mcmc(mcmc)) return(FALSE) # nolint beautier function
       ^~~~~~~
```
[R/is_default_mcmc.R:3:39:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_default_mcmc.R#L3) *warning:* **no visible global function definition for ‘create_mcmc’**
```r
  length(names(mcmc)) == length(names(create_mcmc()))
                                      ^~~~~~~~~~~
```
[R/is_distr.R:37:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_distr.R#L37) *style:* **functions should have cyclomatic complexity of less than 15, this has 21.**
```r
is_distr <- function(
^
```
[R/is_freq_equilibrium_name.R:4:13:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_freq_equilibrium_name.R#L4) *warning:* **no visible global function definition for ‘get_freq_equilibrium_names’**
```r
  name %in% get_freq_equilibrium_names() # nolint beautier function
            ^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/is_id.R:4:32:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_id.R#L4) *warning:* **no visible global function definition for ‘is_one_int’**
```r
  assertive::is_a_string(x) || is_one_int(x) # nolint beautier function
                               ^~~~~~~~~~
```
[R/is_init_distr.R:26:20:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_init_distr.R#L26) *warning:* **no visible global function definition for ‘is_uniform_distr’**
```r
    testit::assert(is_uniform_distr(x))
                   ^~~~~~~~~~~~~~~~
```
[R/is_init_site_model.R:36:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_init_site_model.R#L36) *style:* **functions should have cyclomatic complexity of less than 15, this has 27.**
```r
is_init_gtr_site_model <- function(
^
```
[R/is_mrca_align_id_in_fasta.R:6:9:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_mrca_align_id_in_fasta.R#L6) *warning:* **no visible global function definition for ‘get_alignment_id’**
```r
  id <- get_alignment_id(fasta_filename)
        ^~~~~~~~~~~~~~~~
```
[R/is_mrca_align_ids_in_fastas.R:6:10:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_mrca_align_ids_in_fastas.R#L6) *warning:* **no visible global function definition for ‘get_alignment_ids_from_fasta_filenames’**
```r
  ids <- get_alignment_ids_from_fasta_filenames(fasta_filenames)
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/is_site_model.R:8:8:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_site_model.R#L8) *warning:* **no visible global function definition for ‘is_distr’**
```r
  if (!is_distr(x$kappa_prior_distr)) return(FALSE) # nolint beautier function
       ^~~~~~~~
```
[R/is_site_model.R:10:8:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_site_model.R#L10) *warning:* **no visible global function definition for ‘is_freq_equilibrium_name’**
```r
  if (!is_freq_equilibrium_name(x$freq_equilibrium)) return(FALSE) # nolint beautier function
       ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/is_site_model.R:18:10:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_site_model.R#L18) *warning:* **no visible global function definition for ‘is_distr’**
```r
    if (!is_distr(expected_distr)) return(FALSE) # nolint beautier function
         ^~~~~~~~
```
[R/is_site_model.R:24:10:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_site_model.R#L24) *warning:* **no visible global function definition for ‘is_param’**
```r
    if (!is_param(expected_param)) return(FALSE) # nolint beautier function
         ^~~~~~~~
```
[R/is_site_model.R:27:8:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_site_model.R#L27) *warning:* **no visible global function definition for ‘is_freq_equilibrium_name’**
```r
  if (!is_freq_equilibrium_name(x$freq_equilibrium)) return(FALSE) # nolint beautier function
       ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/is_site_model.R:55:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_site_model.R#L55) *style:* **functions should have cyclomatic complexity of less than 15, this has 22.**
```r
is_gtr_site_model <- function(
^
```
[R/is_site_model.R:171:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_site_model.R#L171) *style:* **functions should have cyclomatic complexity of less than 15, this has 23.**
```r
is_tn93_site_model <- function(
^
```
[R/is_tree_prior_name.R:2:13:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_tree_prior_name.R#L2) *warning:* **no visible global function definition for ‘get_tree_prior_names’**
```r
  name %in% get_tree_prior_names() # nolint beautier function
            ^~~~~~~~~~~~~~~~~~~~
```
[R/is_tree_prior.R:5:8:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_tree_prior.R#L5) *warning:* **no visible global function definition for ‘is_tree_prior_name’**
```r
  if (!is_tree_prior_name(x$name)) return(FALSE) # nolint beautier function
       ^~~~~~~~~~~~~~~~~~
```
[R/is_xml.R:3:8:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_xml.R#L3) *warning:* **no visible global function definition for ‘has_xml_opening_tag’**
```r
  if (!has_xml_opening_tag(text)) return(FALSE) # nolint beautier function
       ^~~~~~~~~~~~~~~~~~~
```
[R/is_xml.R:4:7:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_xml.R#L4) *warning:* **no visible global function definition for ‘has_xml_short_closing_tag’**
```r
  if (has_xml_short_closing_tag(text)) return(TRUE) # nolint beautier function
      ^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/is_xml.R:5:18:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_xml.R#L5) *warning:* **no visible global function definition for ‘get_xml_opening_tag’**
```r
  opening_tag <- get_xml_opening_tag(text) # nolint beautier function
                 ^~~~~~~~~~~~~~~~~~~
```
[R/is_xml.R:6:18:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/is_xml.R#L6) *warning:* **no visible global function definition for ‘get_xml_closing_tag’**
```r
  closing_tag <- get_xml_closing_tag(text) # nolint beautier function
                 ^~~~~~~~~~~~~~~~~~~
```
[R/mcmc_to_xml_run.R:47:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/mcmc_to_xml_run.R#L47) *style:* **Lines should not be more than 80 characters.**
```r
    xml <- paste0(xml, " numInitializationAttempts=\"", mcmc$n_init_attempts, "\"")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/mrca_prior_to_xml_lh_distr.R:6:34:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/mrca_prior_to_xml_lh_distr.R#L6) *warning:* **no visible global function definition for ‘is_one_na’**
```r
  if (length(mrca_prior) == 1 && is_one_na(mrca_prior)) return(NULL) # nolint beautier function
                                 ^~~~~~~~~
```
[R/mrca_priors_to_xml_state.R:6:35:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/mrca_priors_to_xml_state.R#L6) *warning:* **no visible global function definition for ‘is_one_na’**
```r
  if (length(mrca_priors) == 1 && is_one_na(mrca_priors)) return(NULL) # nolint beautier function
                                  ^~~~~~~~~
```
[R/parameter_to_xml.R:13:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/parameter_to_xml.R#L13) *style:* **functions should have cyclomatic complexity of less than 15, this has 20.**
```r
parameter_to_xml <- function(
^
```
[R/site_model_to_xml_state.R:22:23:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/site_model_to_xml_state.R#L22) *warning:* **no visible global function definition for ‘parameter_to_xml’**
```r
      text <- c(text, parameter_to_xml(site_model$rate_ac_param)) # nolint beautier function
                      ^~~~~~~~~~~~~~~~
```
[R/site_model_to_xml_state.R:25:23:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/site_model_to_xml_state.R#L25) *warning:* **no visible global function definition for ‘parameter_to_xml’**
```r
      text <- c(text, parameter_to_xml(site_model$rate_ag_param)) # nolint beautier function
                      ^~~~~~~~~~~~~~~~
```
[R/site_model_to_xml_state.R:47:23:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/site_model_to_xml_state.R#L47) *warning:* **no visible global function definition for ‘parameter_to_xml’**
```r
      text <- c(text, parameter_to_xml(site_model$kappa_1_param)) # nolint beautier function
                      ^~~~~~~~~~~~~~~~
```
[R/site_model_to_xml_state.R:51:23:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/site_model_to_xml_state.R#L51) *warning:* **no visible global function definition for ‘parameter_to_xml’**
```r
      text <- c(text, parameter_to_xml(site_model$kappa_2_param)) # nolint beautier function
                      ^~~~~~~~~~~~~~~~
```
[R/site_model_to_xml_subst_model.R:6:18:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/site_model_to_xml_subst_model.R#L6) *warning:* **no visible global function definition for ‘is_id’**
```r
  testit::assert(is_id(id))
                 ^~~~~
```
[R/site_model_to_xml_subst_model.R:7:18:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/site_model_to_xml_subst_model.R#L7) *warning:* **no visible global function definition for ‘is_jc69_site_model’**
```r
  testit::assert(is_jc69_site_model(site_model))
                 ^~~~~~~~~~~~~~~~~~
```
[R/site_models_to_xml_operators.R:4:18:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/site_models_to_xml_operators.R#L4) *warning:* **no visible global function definition for ‘are_site_models’**
```r
  testit::assert(are_site_models(site_models)) # nolint beautier function
                 ^~~~~~~~~~~~~~~
```
[R/site_models_to_xml_tracelog.R:6:21:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/site_models_to_xml_tracelog.R#L6) *warning:* **no visible global function definition for ‘site_model_to_xml_tracelog’**
```r
    text <- c(text, site_model_to_xml_tracelog(site_model)) # nolint beautier function
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/tree_prior_to_xml_operators.R:10:22:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/tree_prior_to_xml_operators.R#L10) *warning:* **no visible global function definition for ‘get_operator_id_pre’**
```r
  operator_id_pre <- get_operator_id_pre(tree_prior) # nolint beautier function
                     ^~~~~~~~~~~~~~~~~~~
```
[R/tree_prior_to_xml_prior_distr.R:7:21:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/tree_prior_to_xml_prior_distr.R#L7) *warning:* **no visible global function definition for ‘bd_tree_prior_to_xml_prior_distr’**
```r
    text <- c(text, bd_tree_prior_to_xml_prior_distr(tree_prior)) # nolint beautier function
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/tree_prior_to_xml_prior_distr.R:9:21:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/tree_prior_to_xml_prior_distr.R#L9) *warning:* **no visible global function definition for ‘cbs_tree_prior_to_xml_prior_distr’**
```r
    text <- c(text, cbs_tree_prior_to_xml_prior_distr(tree_prior)) # nolint beautier function
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/tree_prior_to_xml_prior_distr.R:11:21:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/tree_prior_to_xml_prior_distr.R#L11) *warning:* **no visible global function definition for ‘ccp_tree_prior_to_xml_prior_distr’**
```r
    text <- c(text, ccp_tree_prior_to_xml_prior_distr(tree_prior)) # nolint beautier function
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/tree_prior_to_xml_prior_distr.R:13:21:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/tree_prior_to_xml_prior_distr.R#L13) *warning:* **no visible global function definition for ‘cep_tree_prior_to_xml_prior_distr’**
```r
    text <- c(text, cep_tree_prior_to_xml_prior_distr(tree_prior)) # nolint beautier function
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/tree_prior_to_xml_prior_distr.R:16:21:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/tree_prior_to_xml_prior_distr.R#L16) *warning:* **no visible global function definition for ‘yule_tree_prior_to_xml_prior_distr’**
```r
    text <- c(text, yule_tree_prior_to_xml_prior_distr(tree_prior)) # nolint beautier function
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/tree_priors_to_xml_distr.R:8:21:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/tree_priors_to_xml_distr.R#L8) *warning:* **no visible global function definition for ‘tree_prior_to_xml_prior_distr’**
```r
    text <- c(text, tree_prior_to_xml_prior_distr(tree_prior)) # nolint beautier function
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/tree_priors_to_xml_operators.R:6:18:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/R/tree_priors_to_xml_operators.R#L6) *warning:* **no visible global function definition for ‘are_tree_priors’**
```r
  testit::assert(are_tree_priors(tree_priors)) # nolint beautier function
                 ^~~~~~~~~~~~~~~
```
[tests/testthat/test-are_equal_mcmcs.R:57:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/tests/testthat/test-are_equal_mcmcs.R#L57) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test-check_file_and_model_agree.R:16:19:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/tests/testthat/test-check_file_and_model_agree.R#L16) *style:* **Use <-, not =, for assignment.**
```r
  inference_model = create_inference_model(
                  ^
```
[tests/testthat/test-check_file_and_model_agree.R:35:19:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/tests/testthat/test-check_file_and_model_agree.R#L35) *style:* **Use <-, not =, for assignment.**
```r
  inference_model = create_inference_model(
                  ^
```
[tests/testthat/test-create_treelog_xml.R:15:1:](https://github.com/ropensci/beautier/blob/82893a6e7282568d4c91e7f5bba7fb241d9d8ff5/tests/testthat/test-create_treelog_xml.R#L15) *style:* **Lines should not be more than 80 characters.**
```r
    "    <log id=\"TreeWithMetaDataLogger.t:test_output_0\" spec=\"beast.evolution.tree.TreeWithMetaDataLogger\" tree=\"@Tree.t:test_output_0\"/>",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```