Successfully deployed to following URLs:

* https://mrrobot-comments-itnjpo0ge.now.sh
* https://mrrobot-comments.now.sh
* https://mrrobot.now.sh
* https://mrrobot-comments.amio1.now.sh
* https://mrrobot-comments-git-master.amio1.now.sh


i'll drop this from my local branch -- my branch is very different to this one now.


Ah OK.


@vkarak  Thank you. Sorry for the late response. It was Thanksgiving holidays last week.  This is project-specific change. We run a subset of ReFrame tests  monthly. Then the job scripts of the successful tests are provided for users as job examples. So I made this change to match our batch environment.


Yes, I have only tested on Firefox stable/nightly, so a browser bug or by-design ?


signed apk: [arm64_v8a](https://www.dropbox.com/s/ih41zsc0vri2k3p/input-master-ab4625831a3dc1495fddf8e45a794641eb4fa47f-arm64_v8a-signed.apk?dl=0) (SDK: [android-5](https://github.com/lutraconsulting/input-sdk/releases/tag/android-5))


Yes, you are correct


I have fixed my copy.


Deployment failed with the following error:

~~~
Your `package.json` file is missing a `build` property inside the `scripts` property.
~~~


Hallo Sinan, bitte in Zukunft nicht "merge" als Kommentar, sondern eine Beschreibung, was Du konkret gemacht hast.
Danke


Измени lang на ru


Successfully deployed to following URLs:

* https://dynamic-routing-app-n404yphs2.now.sh
* https://dynamic-routing-app.now.sh
* https://dynamic-routing-app.smovzhsergey.now.sh
* https://dynamic-routing-app-git-links.smovzhsergey.now.sh


[Circle has built](https://circleci.com/gh/cypress-io/cypress/207957) the `darwin x64` version of the Test Runner.

You can install this pre-release platform-specific build using instructions at [https://on.cypress.io/installing-cypress#Install-pre-release-version](https://on.cypress.io/installing-cypress#Install-pre-release-version).

You will need to use custom `CYPRESS_INSTALL_BINARY` url and install Cypress using an url instead of the version.

    export CYPRESS_INSTALL_BINARY=https://cdn.cypress.io/beta/binary/3.8.0/darwin-x64/circle-develop-ab816d81ae9e7e4728d7a92bd7835086fda25bd8-207926/cypress.zip
    npm install https://cdn.cypress.io/beta/npm/3.8.0/circle-develop-ab816d81ae9e7e4728d7a92bd7835086fda25bd8-207921/cypress.tgz


> Yes, it's failing for me too. I was guessing there's some alignment restriction on the DMA start address that's being violated on the prefix send, but I was just looking through the docs to see if such a restriction exists.

As we discussed, there's no such restriction.  It's possible to write from any source address, to any destination address, without restriction i.e. writing 0xFF bytes from 0x7 to target address 0x1002 is legal.

I will see if I can get this change working on my system too.


Done certain fixes from comments you had made


Successfully deployed to following URLs:

* https://portfoliov2-iu7i7nk0q.now.sh
* https://portfoliov2.now.sh
* https://portfoliov2.nursultansharsheev.now.sh
* https://portfoliov2-git-master.nursultansharsheev.now.sh


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


Deployment failed with the following error:

~~~
DeploymentError: An internal error occurred with ZEIT Now.
~~~


I believe that's only if we run it with no arguments. If you run it with an
empty (i.e. containing no dicom, wav, etc.) directory, it quits.

On Thu, Dec 5, 2019, 7:46 AM Jonathan Washington <notifications@github.com>
wrote:

> I still think explicit is much more maintainable (e.g. there was no way I
> could tell where Treeview was supposed to come from).
>
> Yep, that's probably right. Just make sure to test when you make
> changes—especially ones like this.
>
> [^1]: Maybe this is an argument for not failing if we "don't find any
> matching files".
>
> Isn't the behaviour we've had to bring up an "open directory" dialogue?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/SwatPhonLab/UltraTrace/commit/2396355b5fad6f4baad40d05ca8646001866586c?email_source=notifications&email_token=ACLOIIHDATH2YAPOVRRD35LQXEO6TA5CNFSM4JV3DBX2YY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBCTM23#commitcomment-36287323>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACLOIICIQTC5PWBJOFXGMB3QXEO6TANCNFSM4JV3DBXQ>
> .
>


Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

- @afloren was added to conda-forge. Welcome to conda-forge!
  Go to https://github.com/orgs/conda-forge/invitation see your invitation.

You should get push access to this feedstock and CI services.

Feel free to join the community [chat room](https://gitter.im/conda-forge/conda-forge.github.io).

NOTE: Please make sure to not push to the repository directly.
      Use branches in your fork for any changes and send a PR.
      More details [here](https://conda-forge.org/docs/maintainer/updating_pkgs.html#forking-and-pull-requests)


XALT can and should require the curl/curl.h and curl library to build so it is not necessary to replace the #if 0 with #ifdef HAVE_CURL_CURL_H.  I just put the #if 0 #endif around this section of code to not break things while you and I sort out what to do about allowing "curl" transport.


Successfully deployed to following URLs:

* https://hack-open-t8i0inxrb.now.sh
* https://hack-open.now.sh
* https://hack-open.jvi.now.sh
* https://hack-open-git-master.jvi.now.sh


@souravzzz you can go ahead


DON'T MESS UP MY SNAKE **PLEASE**


Code Review Comment Test


Lockup is apparently normal, seems to clear up after ~30 minutes


__[API Description file `pathwar`](https://app.apiary.io/pathwar/editor) has not been updated in Apiary.io__ due to server timeout.
Please try it later by trying to redeliver the associated [web hook in settings](api.github.com/pathwar/pathwar/settings/hooks) of this repository. (Autogenerated message from apiary.io)


Doesn't look like this can be fixed in Firefox, `effectiveDirective` always report `default-src` in the current case while in Chromium `img-src` is being reported. I feel like Chromium's implementation is correct as "effective" suggest that the actual policy needs to be returned, not the one inherited from. I will need to investigate if anything can be done, or maybe an issue should be opened on bugzilla but I am not sure which browser implemented the spec properly.


Successfully deployed to following URLs:

* https://console-game-viz-6hptjyfzo.now.sh
* https://console-game-viz.now.sh
* https://console-game.steins.live
* https://console-game-viz.wenhe.now.sh
* https://console-game-viz-git-master.wenhe.now.sh


Could you make this and the method under it private


npm i react-navigation-stack


@prescod Josh already covered this in RUNNING.rst


Successfully deployed to following URLs:

* https://ohjelmointi-s19-jgfktf8y4.now.sh
* https://ohjelmointi-s19.mooc.fi
* https://ohjelmointi-s19.mooc.now.sh
* https://ohjelmointi-s19-git-master.mooc.now.sh


Successfully deployed to following URLs:

* https://backend-infraction-yoxfwutrcy.now.sh
* https://backend-infraction.now.sh
* https://backend-infraction.tandil.dev


Successfully deployed to following URLs:

* https://dynamic-routing-app-qi8qbyzri.now.sh
* https://dynamic-routing-app.now.sh
* https://dynamic-routing-app.smovzhsergey.now.sh
* https://dynamic-routing-app-git-links.smovzhsergey.now.sh


Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

- @pp-mo was added to conda-forge. Welcome to conda-forge!
  Go to https://github.com/orgs/conda-forge/invitation see your invitation.

- @lbdreyer was added to this feedstock maintenance team.

You should get push access to this feedstock and CI services.

Feel free to join the community [chat room](https://gitter.im/conda-forge/conda-forge.github.io).

NOTE: Please make sure to not push to the repository directly.
      Use branches in your fork for any changes and send a PR.
      More details [here](https://conda-forge.org/docs/maintainer/updating_pkgs.html#forking-and-pull-requests)


[R/check_pir_out.R:17:1:](https://github.com/richelbilderbeek/pirouette/blob/20305f877447a00bffb847cb76d4cf1be93679fd/R/check_pir_out.R#L17) *style:* **functions should have cyclomatic complexity of less than 15, this has 17.**
```r
check_pir_out <- function(
^
```
[R/create_all_experiments.R:24:1:](https://github.com/richelbilderbeek/pirouette/blob/20305f877447a00bffb847cb76d4cf1be93679fd/R/create_all_experiments.R#L24) *style:* **functions should have cyclomatic complexity of less than 15, this has 30.**
```r
create_all_experiments <- function(
^
```
[R/create_copy_twin_tree_from_true_fun.R:21:1:](https://github.com/richelbilderbeek/pirouette/blob/20305f877447a00bffb847cb76d4cf1be93679fd/R/create_copy_twin_tree_from_true_fun.R#L21) *style:* **Variable and function names should not be longer than 30 characters.**
```r
create_copy_twin_tree_from_true_fun <- function() {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/est_evidences.R:35:1:](https://github.com/richelbilderbeek/pirouette/blob/20305f877447a00bffb847cb76d4cf1be93679fd/R/est_evidences.R#L35) *style:* **functions should have cyclomatic complexity of less than 15, this has 20.**
```r
est_evidences <- function(
^
```
[R/get_sim_true_alignment_with_lns_site_model_fun.R:23:1:](https://github.com/richelbilderbeek/pirouette/blob/20305f877447a00bffb847cb76d4cf1be93679fd/R/get_sim_true_alignment_with_lns_site_model_fun.R#L23) *style:* **Variable and function names should not be longer than 30 characters.**
```r
get_sim_true_alignment_with_lns_nsm_fun <-
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/get_sim_true_alignment_with_std_nsm_fun.R:21:1:](https://github.com/richelbilderbeek/pirouette/blob/20305f877447a00bffb847cb76d4cf1be93679fd/R/get_sim_true_alignment_with_std_nsm_fun.R#L21) *style:* **Variable and function names should not be longer than 30 characters.**
```r
get_sim_true_alignment_with_std_nsm_fun <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/get_sim_true_alignment_with_uns_site_model_fun.R:20:1:](https://github.com/richelbilderbeek/pirouette/blob/20305f877447a00bffb847cb76d4cf1be93679fd/R/get_sim_true_alignment_with_uns_site_model_fun.R#L20) *style:* **Variable and function names should not be longer than 30 characters.**
```r
get_sim_true_alignment_with_uns_nsm_fun <-
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/get_sim_twin_alignment_with_same_n_mutation_fun.R:29:1:](https://github.com/richelbilderbeek/pirouette/blob/20305f877447a00bffb847cb76d4cf1be93679fd/R/get_sim_twin_alignment_with_same_n_mutation_fun.R#L29) *style:* **Variable and function names should not be longer than 30 characters.**
```r
get_sim_twin_alignment_with_same_n_mutation_fun <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/get_sim_twin_alignment_with_std_nsm_fun.R:30:1:](https://github.com/richelbilderbeek/pirouette/blob/20305f877447a00bffb847cb76d4cf1be93679fd/R/get_sim_twin_alignment_with_std_nsm_fun.R#L30) *style:* **Variable and function names should not be longer than 30 characters.**
```r
get_sim_twin_alignment_with_std_nsm_fun <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/select_candidate_evidences.R:25:1:](https://github.com/richelbilderbeek/pirouette/blob/20305f877447a00bffb847cb76d4cf1be93679fd/R/select_candidate_evidences.R#L25) *style:* **functions should have cyclomatic complexity of less than 15, this has 20.**
```r
select_candidate_evidences <- function(
^
```
[R/sim_true_alignment_with_lns_site_model.R:12:1:](https://github.com/richelbilderbeek/pirouette/blob/20305f877447a00bffb847cb76d4cf1be93679fd/R/sim_true_alignment_with_lns_site_model.R#L12) *style:* **Variable and function names should not be longer than 30 characters.**
```r
sim_true_alignment_with_lns_nsm <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_true_alignment_with_nsm.R:21:1:](https://github.com/richelbilderbeek/pirouette/blob/20305f877447a00bffb847cb76d4cf1be93679fd/R/sim_true_alignment_with_nsm.R#L21) *style:* **Variable and function names should not be longer than 30 characters.**
```r
sim_true_alignment_with_std_nsm <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_true_alignment_with_uns_site_model.R:13:1:](https://github.com/richelbilderbeek/pirouette/blob/20305f877447a00bffb847cb76d4cf1be93679fd/R/sim_true_alignment_with_uns_site_model.R#L13) *style:* **Variable and function names should not be longer than 30 characters.**
```r
sim_true_alignment_with_uns_nsm <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_twin_alignment_with_lns_site_model.R:11:1:](https://github.com/richelbilderbeek/pirouette/blob/20305f877447a00bffb847cb76d4cf1be93679fd/R/sim_twin_alignment_with_lns_site_model.R#L11) *style:* **Variable and function names should not be longer than 30 characters.**
```r
sim_twin_alignment_with_lns_nsm <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_twin_alignment_with_nsm.R:29:1:](https://github.com/richelbilderbeek/pirouette/blob/20305f877447a00bffb847cb76d4cf1be93679fd/R/sim_twin_alignment_with_nsm.R#L29) *style:* **Variable and function names should not be longer than 30 characters.**
```r
sim_twin_alignment_with_std_nsm <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_twin_alignment_with_same_n_mutation.R:30:1:](https://github.com/richelbilderbeek/pirouette/blob/20305f877447a00bffb847cb76d4cf1be93679fd/R/sim_twin_alignment_with_same_n_mutation.R#L30) *style:* **Variable and function names should not be longer than 30 characters.**
```r
sim_twin_alignment_with_same_n_mutation <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_twin_alignment_with_std_nsm_raw.R:5:1:](https://github.com/richelbilderbeek/pirouette/blob/20305f877447a00bffb847cb76d4cf1be93679fd/R/sim_twin_alignment_with_std_nsm_raw.R#L5) *style:* **Variable and function names should not be longer than 30 characters.**
```r
sim_twin_alignment_with_std_nsm_raw <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_twin_alignment_with_uns_site_model.R:11:1:](https://github.com/richelbilderbeek/pirouette/blob/20305f877447a00bffb847cb76d4cf1be93679fd/R/sim_twin_alignment_with_uns_site_model.R#L11) *style:* **Variable and function names should not be longer than 30 characters.**
```r
sim_twin_alignment_with_uns_nsm <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


TeamCity Bvcms / Build [Build 2972](https://builds.tpsdb.com/viewLog.html?buildId=10222&buildTypeId=Bvcms_Build) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 171 Build time: 00:26:06
### Failed tests
```
Webapp collection (1): IntegrationTests.Areas.People.Views.Person.PersonViewsTests.Should_Show_Combine_Giving_Summaries: OpenQA.Selenium.WebDriverTimeoutException : Timed out after 10 seconds
   at OpenQA.Selenium.Support.UI.DefaultWait`1.ThrowTimeoutException(String exceptionMessage, Exception lastException)
   at OpenQA.Selenium.Support.UI.DefaultWait`1.Until[TResult](Func`2 condition)
   at IntegrationTests.Support.FeatureTestBase.WaitForElement(String css, Int32 maxWaitTimeInSeconds, Boolean visible) in C:\TeamCity\buildAgent\work\de2c4e6ef697cb99\IntegrationTests\Support\FeatureTestBase.cs:line 553
   at IntegrationTests.Areas.People.Views.Person.PersonViewsTests.Should_Show_Combine_Giving_Summaries() in C:\TeamCity\buildAgent\work\de2c4e6ef697cb99\IntegrationTests\Areas\People\Views\Person\PersonViewsTests.cs:line 82

```


Successfully deployed to following URLs:

* https://portfoliov2-2uaw5tb6j.now.sh
* https://portfoliov2.now.sh
* https://portfoliov2.nursultansharsheev.now.sh
* https://portfoliov2-git-master.nursultansharsheev.now.sh


ha


@pat-s @lorenzwalthert: auto-styler!


Not sure this is necessary. `Car.all` would return an empty array if there are no cars which you can test against. We shouldn't return an error in that case, just test that the array count is zero


I see. With the new changes we introduced in the job scheduler design in https://github.com/eth-cscs/reframe/pull/1074, it should be easy to add configuration options to the backend and perhaps accommodate also this one.


TeamCity MAS / MAS [Build 1.0.0.253-MAS-110-NewFieldsInE](https://teamcity.nice.org.uk/viewLog.html?buildId=62823&buildTypeId=Mas_Mas) outcome was **SUCCESS**
Summary: Running Build time: 00:02:58


4. Membuat List kelebihan Smart Lamp


Guessing you were trying to handle a case where a user tries to delete a car that doesn't exist here. If yes, please confirm so I can try to provide a better solution


You don't use this Random rand. You are simply importing the Random from outside this class.

You could either:
1. Instantiate this Random when you create the class and not import a different one in the Roll method
2. Delete this Random and only use the one imported into Roll


4. Membuat list kelebihan smart lamp


Tai błąd jest powodują go zdjęcia w CSS' próbuje z nim walczyć
Module parse failed: Unexpected character '�' (1:0)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders


Use `find!` here instead so it raises an exception if the car isn't found


The `--` has to go after exec, as to properly support args that is `dune exec -- lambdapi`


Successfully deployed to following URLs:

* https://hack-open-9a8onkmab.now.sh
* https://hack-open.now.sh
* https://hack-open.jvi.now.sh
* https://hack-open-git-master.jvi.now.sh


OutgoingMessage is an implementation detail of PubsubIO and not exposed to clients.

None of the changes in this PR should have any client-visible effects.


Successfully deployed to following URLs:

* https://gorocketshoes-rocketseat-7mnz4tigf.now.sh
* https://gorocketshoes-rocketseat.now.sh
* https://gorocketshoes-rocketseat.maanolfi.now.sh
* https://gorocketshoes-rocketseat-git-master.maanolfi.now.sh


Caveat: None of the java changes in this cl should have client visible effects. the library version changes might.


You could make this class static so you can reference this class without creating an instance of it.

Call it like this:
var = HitOrMiss.Compare(x,y);

Note: you would also need to make the Compare method static


я придумала так:
range = (10..100)
my_array = []

range.step(5) do|x|
  my_array << x
end

где там можно использовать to_a?


Fixed: An FTP server running on your provisioning machine that is accessible to the machines you create.


Note that `universal_variant no` is implied, both by `use_configure no` and by having only a single entry in `supported_archs`.


Original docs, will not change.


Method parameters with '_' is a bit unusual, although it is common practice to use '_' preceding the  private variable name of a class.


![](https://github.trello.services/images/mini-trello-icon.png) [JavaDoc for CounterSystem class](https://trello.com/c/zBKgWAn9/88-javadoc-for-countersystem-class)


Successfully deployed to following URLs:

* https://convertmymoney-9y21mhj9j.now.sh
* https://convertmymoney-nu-liard.now.sh
* https://convertmymoney.rafaelfaria.now.sh
* https://convertmymoney-git-master.rafaelfaria.now.sh


Deployment failed with the following error:

~~~
Your `package.json` file is missing a `build` property inside the `scripts` property.
~~~


You could do `assert_response 201` here


Modifier in DND is like a boost to your roll. If you have an amazing sword your attack modifier would be +1.

I think it should be a variable in the class. 👍


I'll keep it as is - there's a good chance whoever is reviewing prefers this way to using "\".


Better, but I think it would be best to break each of the actions into public methods.
Please review the following pull request:
https://github.com/OverlakeRobotics/Nocturnal-2019-SkyStone/pull/44


What does ProcessRound do?


Code to develop genetic algorithm to solve Data Set 1


changing the fetchPolicy to cache-and-network on the carList query didn't help


Successfully deployed to following URLs:

* https://nuxtfire-nje1fc218.now.sh
* https://nuxtfire.now.sh
* https://nuxtfire.droyer.now.sh
* https://nuxtfire-git-master.droyer.now.sh


Minor improvement here.
It helps if the text following `it` reads like a regular sentence. You could do

```
context "when car submission is invalid" do
  it "results in a failure" do
    .....
  end
end
```


Will change this testcase (same for other comment)


what does ProcessRound() do?


Commit nhớ check qua các file xem sửa gì rồi push nha man, chỗ này là méo chịu xem qua thêm thừa nè!


develop (mitchute) - x86_64-Linux-Ubuntu-18.04-gcc-7.4: OK (1941 of 1941 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


develop (mitchute) - Win64-Windows-10-VisualStudio-16: OK (1921 of 1921 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


Successfully deployed to following URLs:

* https://hack-open-n77z2tl2x.now.sh
* https://hack-open.now.sh
* https://hack-open.jvi.now.sh
* https://hack-open-git-master.jvi.now.sh


20 seems like a magic number. It would be nice if you made a new variable called Monster Armor and set that to 20.

var monsterArmor = 20;


Setting state to `success` where context is `VSTS: device tests (iOS32b)`.

Only 🤥 (gred) issues found.


Successfully deployed to following URLs:

* https://gorocketshoes-rocketseat-mohm8ud6m.now.sh
* https://gorocketshoes-rocketseat.now.sh
* https://gorocketshoes-rocketseat.maanolfi.now.sh
* https://gorocketshoes-rocketseat-git-master.maanolfi.now.sh


TeamCity MAS / MAS [Build 1.0.0.254](https://teamcity.nice.org.uk/viewLog.html?buildId=62824&buildTypeId=Mas_Mas) outcome was **FAILURE**
Summary: Exit code 1 (Step: Set build number (Command Line)) (new) Build time: 00:01:07


Critical Hit is usually when the a 20 is rolled with the die. 🥇


No. I'm trying to delete a Car that is marked as `available`. If the Car is marked as `sold` and the person trying to delete it is an `admin` then I'm trying to update the `deleted_at` column. The else condition is for when the car is `sold` and the person trying to delete it is the not the `admin`


Congratulations!!!


Looks good. Most of my comments were about DVD rules that I think you were confused on.


Think you could do `put car_path(car.id)` here. It's usually neater than specifying the route itself


It is my personal coding convention :(


TeamCity MAS / MAS [Build 1.0.0.255-MAS-128-StaticSiteAl](https://teamcity.nice.org.uk/viewLog.html?buildId=62825&buildTypeId=Mas_Mas) outcome was **SUCCESS**
Summary: Running Build time: 00:02:30


develop (mitchute) - x86_64-Linux-Ubuntu-18.04-cppcheck: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


typo


develop (mitchute) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (11 of 11 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


Successfully deployed to following URLs:

* https://react-github-user-card-486kale2n.now.sh
* https://react-github-user-card-beta-opal.now.sh
* https://react-github-user-card.lukasjaronis.now.sh
* https://react-github-user-card-git-lukas-jaronis2.lukasjaronis.now.sh


@vinitkumar I can create new issue and change formatDate() to moment() in all pug files?


Successfully deployed to following URLs:

* https://devplenoconvertmymoney-85reb32r0.now.sh
* https://devplenoconvertmymoney.leovictorcvo.now.sh
* https://devplenoconvertmymoney-git-master.leovictorcvo.now.sh


added you on skype


Successfully deployed to following URLs:

* https://website-7pfig8vpr.now.sh
* https://davam.cz
* https://www.davam.cz
* https://website.davam.now.sh
* https://website-git-master.davam.now.sh


Did we do the same in 1.16?


Successfully deployed to following URLs:

* https://portfoliowebsite-ccmehenzo.now.sh
* https://portfoliowebsite.now.sh
* https://portfoliowebsite.bensolt.now.sh
* https://portfoliowebsite-git-master.bensolt.now.sh


good


This causes warnings when building wxWidgets:
```
include/wx/osx/core/cfstring.h:46:35: warning: '__bridge_retained' casts have no effect when not using ARC [-Warc-bridge-casts-disallowed-in-nonarc]
```


TeamCity Glyssen / Glyssen pull requests [Build *.*.738.6444eadfb4c5b51f0cf8a8d2be4ed06c80d1a6bf](https://build.palaso.org/viewLog.html?buildId=173257&buildTypeId=Glyssen_GlyssenPullRequests2) outcome was **SUCCESS**
Summary: Tests passed: 2393, ignored: 18 Build time: 00:13:01


Successfully deployed to following URLs:

* https://praca-velha-frontend-aalfneaic.now.sh
* https://praca-velha-frontend.ikas.now.sh
* https://praca-velha-frontend-git-master.ikas.now.sh


Successfully deployed to following URLs:

* https://dreams-2lnsyzmgq.now.sh
* https://dreams-kappa-sandy.now.sh
* https://dreams.wtf
* https://*.dreams.wtf
* https://dreams.participio.now.sh
* https://dreams-git-master.participio.now.sh


NO. You need to use the right `gameId` which must be the same as `.id` to be able to retrieve game data in `joinGame()`, `commitMove()` and  `revealMove()` !!

The reason to store gameId in .id is to enable


@rtmclay, I was wondering if this `#ifdef HAVE_CURL_CURL_H` would perform the change number 1 that you proposed on #22.


Poner titulo este es i villano fav


Entiendo por que agregaste a deadshot,, lo necesitaremos :|


Successfully deployed to following URLs:

* https://teste-rockeshoes-guodtkqcc.now.sh
* https://teste-rockeshoes.now.sh
* https://teste-rockeshoes.maanolfi.now.sh
* https://teste-rockeshoes-git-master.maanolfi.now.sh


Could you add an `is_sold?(car)` method and use it here


Created multidev environment [sfgov#pr-422](https://dashboard.pantheon.io/sites/91d50373-c4cf-40e4-a646-cb73e16a140c#pr-422).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-422-sfgov.pantheonsite.io/)


Seems like unnecessary extra code to have the intermediate vector of strings.


❌ Status for 'xamarin-macios - sample testing (build)': [failure](https://devdiv.visualstudio.com//DevDiv/_build/results?buildId=3297363).

* ❌ Debug_iPhone_AF: Failed
* ❌ Debug_iPhone_GR: Failed
* ❌ Debug_iPhone_SZ: Failed
* ❌ Debug_iPhoneSimulator: Failed
* ❌ Release_iPhone_AF: Failed
* ❌ Release_iPhone_GR: Failed
* ❌ Release_iPhone_SZ: Failed
* ❌ Release_iPhoneSimulator: Failed
* ✅ Debug_Mac: Succeeded
* ✅ Release_Mac: Succeeded


fixing layouts


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


Quickstarter on how to use PyTorch


Successfully deployed to following URLs:

* https://smurygin-cp7r7d6qx.now.sh
* https://smurygin.com
* https://smurygin.smurygin.now.sh
* https://smurygin-git-master.smurygin.now.sh


Successfully deployed to following URLs:

* https://devplenoconvertmymoney-p2vc97lhu.now.sh
* https://devplenoconvertmymoney.leovictorcvo.now.sh
* https://devplenoconvertmymoney-git-master.leovictorcvo.now.sh


TeamCity Identity and Access Management / Identity - ManagementPortal [Build 915](https://teamcity.nice.org.uk/viewLog.html?buildId=62826&buildTypeId=IdentityandAccessManagement_BuildRoleManagementPortal) outcome was **FAILURE**
Summary: Exit code 1 (Step: Set build number (Command Line)) Build time: 00:00:31


This commit adds dotted and dashed styles to ties in the Humdrum-to-MEI converter.

<img width="702" alt="Screen Shot 2019-12-05 at 8 37 46 AM" src="https://user-images.githubusercontent.com/3487289/70255065-01448b00-173b-11ea-9ced-6d5373f10fe2.png">

```
**kern
*M4/4
=1
!LO:T:dash
([1g
=2
1g]
=3
!LO:T:dot
[1g
=4
1g])
==
*-
```

MEI conversion:

```xml
<?xml version="1.0" encoding="UTF-8"?>
<?xml-model href="https://music-encoding.org/schema/4.0.0/mei-all.rng" type="application/xml" schematypens="http://relaxng.org/ns/structure/1.0"?>
<?xml-model href="https://music-encoding.org/schema/4.0.0/mei-all.rng" type="application/xml" schematypens="http://purl.oclc.org/dsdl/schematron"?>
<mei xmlns="http://www.music-encoding.org/ns/mei" meiversion="4.0.0">
 <meiHead>
  <fileDesc>
   <titleStmt>
    <title />
   </titleStmt>
   <pubStmt />
  </fileDesc>
  <encodingDesc>
   <appInfo>
    <application isodate="2019-12-05T08:42:18" version="2.4.0-dev-aa6f36e">
     <name>Verovio</name>
     <p>Transcoded from Humdrum</p>
    </application>
   </appInfo>
  </encodingDesc>
  <workList>
   <work>
    <title />
   </work>
  </workList>
 </meiHead>
 <music>
  <body>
   <mdiv xml:id="mdiv-0000000360660749">
    <score xml:id="score-0000001426356609">
     <scoreDef xml:id="scoredef-0000001605363551" midi.bpm="400">
      <staffGrp xml:id="staffgrp-0000002007892808">
       <staffDef xml:id="staffdef-0000000969045570" n="1" lines="5">
        <clef xml:id="clef-0000000548469143" shape="G" line="2" />
        <meterSig xml:id="metersig-L2F1" count="4" unit="4" />
       </staffDef>
      </staffGrp>
     </scoreDef>
     <section xml:id="section-L1F1">
      <measure xml:id="measure-L1" n="0">
       <staff xml:id="staff-0000000962674351" n="1">
        <layer xml:id="layer-L1F1N1" n="1">
         <note xml:id="note-L5F1" dur="1" oct="4" pname="g" accid.ges="n" />
        </layer>
       </staff>
       <tie xml:id="tie-L5F1-L7F1" startid="#note-L5F1" endid="#note-L7F1" lform="dashed" />
       <slur xml:id="slur-L5F1-L12F1" staff="1" startid="#note-L5F1" endid="#note-L12F1" />
      </measure>
      <measure xml:id="measure-L6" n="2">
       <staff xml:id="staff-L6F1N1" n="1">
        <layer xml:id="layer-L6F1N1" n="1">
         <note xml:id="note-L7F1" dur="1" oct="4" pname="g" accid.ges="n" />
        </layer>
       </staff>
      </measure>
      <measure xml:id="measure-L8" n="3">
       <staff xml:id="staff-L8F1N1" n="1">
        <layer xml:id="layer-L8F1N1" n="1">
         <note xml:id="note-L10F1" dur="1" oct="4" pname="g" accid.ges="n" />
        </layer>
       </staff>
       <tie xml:id="tie-L10F1-L12F1" startid="#note-L10F1" endid="#note-L12F1" lform="dotted" />
      </measure>
      <measure xml:id="measure-L11" right="end" n="4">
       <staff xml:id="staff-L11F1N1" n="1">
        <layer xml:id="layer-L11F1N1" n="1">
         <note xml:id="note-L12F1" dur="1" oct="4" pname="g" accid.ges="n" />
        </layer>
       </staff>
      </measure>
     </section>
    </score>
   </mdiv>
  </body>
 </music>
</mei>
```

Ties on chords currently have all the same style (all plain, dotted, or dashed).  Implement later individual styles with the `n=2` sort of parameter (for the second slur in the chord).


I NEED HELP!!!


[R/hello.R:16:7:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/hello.R#L16) *style:* **Use <-, not =, for assignment.**
```r
hello = function() {
      ^
```
[R/safer_joins.R:3:1:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L3) *style:* **Lines should not be more than 80 characters.**
```r
#' This augments \code{left_join} from the \code{dplyr} package with important quality control checks.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:4:1:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L4) *style:* **Lines should not be more than 80 characters.**
```r
#' When \code{by} is not NULL, then it checks for duplicated IDs (e.g., join variables).
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:5:1:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L5) *style:* **Lines should not be more than 80 characters.**
```r
#' When \code{by} is NULL, if there is only one column in common between \code{x} and \code{y}, then it checks for duplicated IDs using that single column as the join variable.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:6:1:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L6) *style:* **Lines should not be more than 80 characters.**
```r
#' Also checks if the resulting join has more records than the input table \code{x}.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:13:1:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L13) *style:* **Lines should not be more than 80 characters.**
```r
#' @param copy If x and y are not from the same data source, and copy is TRUE, then y will be copied into the same src as x.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:14:1:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L14) *style:* **Lines should not be more than 80 characters.**
```r
#' @param suffix If there are non-joined duplicate variables in x and y, these suffixes will be added to the output to disambiguate them. Should be a character vector of length 2.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:25:1:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L25) *style:* **Lines should not be more than 80 characters.**
```r
left_join_check <- function(x, y, by = NULL, copy = FALSE, suffix = c(".x", ".y"), ...) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:29:9:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L29) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.x = sum(duplicated(x[,by]))
        ^~~~~~~~~
```
[R/safer_joins.R:29:19:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L29) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.x = sum(duplicated(x[,by]))
                  ^
```
[R/safer_joins.R:29:39:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L29) *style:* **Commas should always have a space after.**
```r
        ndupIDs.x = sum(duplicated(x[,by]))
                                      ^
```
[R/safer_joins.R:31:56:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L31) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in x in the ",by, " column"))
                                                       ^
```
[R/safer_joins.R:33:9:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L33) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
        ^~~~~~~~~
```
[R/safer_joins.R:33:19:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L33) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
                  ^
```
[R/safer_joins.R:33:39:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L33) *style:* **Commas should always have a space after.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
                                      ^
```
[R/safer_joins.R:35:56:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L35) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in y in the ",by, " column"))
                                                       ^
```
[R/safer_joins.R:39:9:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L39) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.x = sum(duplicated(x[,names(by)]))
        ^~~~~~~~~
```
[R/safer_joins.R:39:19:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L39) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.x = sum(duplicated(x[,names(by)]))
                  ^
```
[R/safer_joins.R:39:39:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L39) *style:* **Commas should always have a space after.**
```r
        ndupIDs.x = sum(duplicated(x[,names(by)]))
                                      ^
```
[R/safer_joins.R:40:10:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L40) *warning:* **no visible global function definition for 'left_join'**
```r
    r <- left_join(x, y, by, copy, suffix)
         ^~~~~~~~~
```
[R/safer_joins.R:41:56:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L41) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in x in the ",names(by), " column"))
                                                       ^
```
[R/safer_joins.R:43:9:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L43) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
        ^~~~~~~~~
```
[R/safer_joins.R:43:19:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L43) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
                  ^
```
[R/safer_joins.R:43:39:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L43) *style:* **Commas should always have a space after.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
                                      ^
```
[R/safer_joins.R:45:56:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L45) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in y in the ",by, " column"))
                                                       ^
```
[R/safer_joins.R:49:33:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L49) *style:* **Commas should always have a space after.**
```r
      by1 <- intersect(names(x),names(y))
                                ^
```
[R/safer_joins.R:52:9:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L52) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.x = sum(duplicated(x[,by1]))
        ^~~~~~~~~
```
[R/safer_joins.R:52:19:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L52) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.x = sum(duplicated(x[,by1]))
                  ^
```
[R/safer_joins.R:52:39:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L52) *style:* **Commas should always have a space after.**
```r
        ndupIDs.x = sum(duplicated(x[,by1]))
                                      ^
```
[R/safer_joins.R:54:56:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L54) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in x in the ",by1, " column"))
                                                       ^
```
[R/safer_joins.R:56:9:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L56) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.y = sum(duplicated(y[,by1]))
        ^~~~~~~~~
```
[R/safer_joins.R:56:19:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L56) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.y = sum(duplicated(y[,by1]))
                  ^
```
[R/safer_joins.R:56:39:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L56) *style:* **Commas should always have a space after.**
```r
        ndupIDs.y = sum(duplicated(y[,by1]))
                                      ^
```
[R/safer_joins.R:58:56:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L58) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in y in the ",by1, " column"))
                                                       ^
```
[R/safer_joins.R:63:5:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L63) *style:* **Variable and function name style should be snake_case.**
```r
    d.x <- nrow(x)
    ^~~
```
[R/safer_joins.R:65:5:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L65) *style:* **Variable and function name style should be snake_case.**
```r
    d.r <- nrow(r)
    ^~~
```
[R/safer_joins.R:67:33:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L67) *style:* **Commas should always have a space after.**
```r
      warning(paste0("nrow(x)=",d.x," != nrow(join)=",d.r))
                                ^
```
[R/safer_joins.R:67:37:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L67) *style:* **Commas should always have a space after.**
```r
      warning(paste0("nrow(x)=",d.x," != nrow(join)=",d.r))
                                    ^
```
[R/safer_joins.R:67:55:](https://github.com/DanielEWeeks/dweeks/blob/76e17ddacb3d90ead35dd682d4f07a10cc148c09/R/safer_joins.R#L67) *style:* **Commas should always have a space after.**
```r
      warning(paste0("nrow(x)=",d.x," != nrow(join)=",d.r))
                                                      ^
```


Deployment failed with the following error:

~~~
Your `package.json` file is missing a `build` property inside the `scripts` property.
~~~


#7 #5


gameId games[gameId].state :(


Not necessarily. Even when the tone only starts after the 100th sample (12.5 ms) the detector can still pick it up. Subtracting the frame duration would then be as inaccurate as not doing so. For more accuracy, more analysis of the frame will be needed.

But I agree, that it's a reasonable default to assume that a detected tone was present for the whole frame and subtracting the frame duration thus makes sense. I'm currently re-writing this library from scratch and I think I will calculate the start time as you proposed :)


TeamCity Bvcms / Build [Build 2973](https://builds.tpsdb.com/viewLog.html?buildId=10223&buildTypeId=Bvcms_Build) is now running


Successfully deployed to following URLs:

* https://tableautim-m10xcok24.now.sh
* https://tableautim.now.sh
* https://tableautim.ngwena.now.sh
* https://tableautim-git-master.ngwena.now.sh


Successfully deployed to following URLs:

* https://smurygin-kieac455i.now.sh
* https://smurygin.com
* https://smurygin.smurygin.now.sh
* https://smurygin-git-master.smurygin.now.sh


TeamCity MAS / MAS [Build 1.0.0.256-MAS-110-NewFieldsInE](https://teamcity.nice.org.uk/viewLog.html?buildId=62827&buildTypeId=Mas_Mas) outcome was **SUCCESS**
Summary: Running Build time: 00:02:38


buenos dias ...
el usuario para ingresar es juank92@gmail.com
pass:jk123456789

solo se realizo la parte del back ... por falta de disponibilidad de tiempo .. me disculpo y de igual forma pido otra prueba si se es mucha molestia para un fin de semana en el cual tenga mas disponibilidad ...


Successfully deployed to following URLs:

* https://aperoweb-i5lr1jdiw.now.sh
* https://aperoweb.euregan.now.sh
* https://aperoweb-git-master.euregan.now.sh


I think you meant #56 there.


[R/hello.R:16:7:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/hello.R#L16) *style:* **Use <-, not =, for assignment.**
```r
hello = function() {
      ^
```
[R/safer_joins.R:3:1:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L3) *style:* **Lines should not be more than 80 characters.**
```r
#' This augments \code{left_join} from the \code{dplyr} package with important quality control checks.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:4:1:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L4) *style:* **Lines should not be more than 80 characters.**
```r
#' When \code{by} is not NULL, then it checks for duplicated IDs (e.g., join variables).
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:5:1:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L5) *style:* **Lines should not be more than 80 characters.**
```r
#' When \code{by} is NULL, if there is only one column in common between \code{x} and \code{y}, then it checks for duplicated IDs using that single column as the join variable.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:6:1:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L6) *style:* **Lines should not be more than 80 characters.**
```r
#' Also checks if the resulting join has more records than the input table \code{x}.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:13:1:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L13) *style:* **Lines should not be more than 80 characters.**
```r
#' @param copy If x and y are not from the same data source, and copy is TRUE, then y will be copied into the same src as x.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:14:1:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L14) *style:* **Lines should not be more than 80 characters.**
```r
#' @param suffix If there are non-joined duplicate variables in x and y, these suffixes will be added to the output to disambiguate them. Should be a character vector of length 2.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:25:1:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L25) *style:* **Lines should not be more than 80 characters.**
```r
left_join_check <- function(x, y, by = NULL, copy = FALSE, suffix = c(".x", ".y"), ...) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:29:9:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L29) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.x = sum(duplicated(x[,by]))
        ^~~~~~~~~
```
[R/safer_joins.R:29:19:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L29) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.x = sum(duplicated(x[,by]))
                  ^
```
[R/safer_joins.R:29:39:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L29) *style:* **Commas should always have a space after.**
```r
        ndupIDs.x = sum(duplicated(x[,by]))
                                      ^
```
[R/safer_joins.R:31:56:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L31) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in x in the ",by, " column"))
                                                       ^
```
[R/safer_joins.R:33:9:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L33) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
        ^~~~~~~~~
```
[R/safer_joins.R:33:19:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L33) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
                  ^
```
[R/safer_joins.R:33:39:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L33) *style:* **Commas should always have a space after.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
                                      ^
```
[R/safer_joins.R:35:56:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L35) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in y in the ",by, " column"))
                                                       ^
```
[R/safer_joins.R:39:9:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L39) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.x = sum(duplicated(x[,names(by)]))
        ^~~~~~~~~
```
[R/safer_joins.R:39:19:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L39) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.x = sum(duplicated(x[,names(by)]))
                  ^
```
[R/safer_joins.R:39:39:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L39) *style:* **Commas should always have a space after.**
```r
        ndupIDs.x = sum(duplicated(x[,names(by)]))
                                      ^
```
[R/safer_joins.R:40:10:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L40) *warning:* **no visible global function definition for 'left_join'**
```r
    r <- left_join(x, y, by, copy, suffix)
         ^~~~~~~~~
```
[R/safer_joins.R:41:56:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L41) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in x in the ",names(by), " column"))
                                                       ^
```
[R/safer_joins.R:43:9:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L43) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
        ^~~~~~~~~
```
[R/safer_joins.R:43:19:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L43) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
                  ^
```
[R/safer_joins.R:43:39:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L43) *style:* **Commas should always have a space after.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
                                      ^
```
[R/safer_joins.R:45:56:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L45) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in y in the ",by, " column"))
                                                       ^
```
[R/safer_joins.R:49:33:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L49) *style:* **Commas should always have a space after.**
```r
      by1 <- intersect(names(x),names(y))
                                ^
```
[R/safer_joins.R:52:9:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L52) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.x = sum(duplicated(x[,by1]))
        ^~~~~~~~~
```
[R/safer_joins.R:52:19:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L52) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.x = sum(duplicated(x[,by1]))
                  ^
```
[R/safer_joins.R:52:39:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L52) *style:* **Commas should always have a space after.**
```r
        ndupIDs.x = sum(duplicated(x[,by1]))
                                      ^
```
[R/safer_joins.R:54:56:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L54) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in x in the ",by1, " column"))
                                                       ^
```
[R/safer_joins.R:56:9:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L56) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.y = sum(duplicated(y[,by1]))
        ^~~~~~~~~
```
[R/safer_joins.R:56:19:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L56) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.y = sum(duplicated(y[,by1]))
                  ^
```
[R/safer_joins.R:56:39:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L56) *style:* **Commas should always have a space after.**
```r
        ndupIDs.y = sum(duplicated(y[,by1]))
                                      ^
```
[R/safer_joins.R:58:56:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L58) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in y in the ",by1, " column"))
                                                       ^
```
[R/safer_joins.R:63:5:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L63) *style:* **Variable and function name style should be snake_case.**
```r
    d.x <- nrow(x)
    ^~~
```
[R/safer_joins.R:65:5:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L65) *style:* **Variable and function name style should be snake_case.**
```r
    d.r <- nrow(r)
    ^~~
```
[R/safer_joins.R:67:33:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L67) *style:* **Commas should always have a space after.**
```r
      warning(paste0("nrow(x)=",d.x," != nrow(join)=",d.r))
                                ^
```
[R/safer_joins.R:67:37:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L67) *style:* **Commas should always have a space after.**
```r
      warning(paste0("nrow(x)=",d.x," != nrow(join)=",d.r))
                                    ^
```
[R/safer_joins.R:67:55:](https://github.com/DanielEWeeks/dweeks/blob/6fa75434eb0aab89140941f3f51d08197d366ed1/R/safer_joins.R#L67) *style:* **Commas should always have a space after.**
```r
      warning(paste0("nrow(x)=",d.x," != nrow(join)=",d.r))
                                                      ^
```


Added the link in my message above


Successfully deployed to following URLs:

* https://aperoweb-hw8b9j4hf.now.sh
* https://aperoweb.euregan.now.sh
* https://aperoweb-git-master.euregan.now.sh


TeamCity MAS / MAS [Build 1.0.0.257-MAS-128-StaticSiteAl](https://teamcity.nice.org.uk/viewLog.html?buildId=62828&buildTypeId=Mas_Mas) outcome was **SUCCESS**
Summary: Running Build time: 00:03:11


Successfully deployed to following URLs:

* https://lelite-iirezs1gd.now.sh
* https://lelite.now.sh
* https://lelite.tirdy.now.sh
* https://lelite-git-master.tirdy.now.sh


Hi,

I intent to change the license of xEdit from MPL 1.1 to MPL 2.0.

https://www.mozilla.org/en-US/MPL/1.1/
https://www.mozilla.org/en-US/MPL/2.0/

In this (and possible other) commit(s) you've contributed to xEdit under the terms of MPL 1.1

The upgrading from version 1.1 to 2.0 of the license is covered clause 6.2. Effect of New Versions of MPL 1.1 and does not require the agreement of contributors.

At the same time, such an upgrade can not be used to force previous contributors to grant additional rights, as such, under clause 1.5 of MPL 2.0, such an upgrade must be marked with a "Incompatible With Secondary Licenses" notice.

That is, without the explicit permission of all contributors that previously contributed under MPL 1.1, the clauses in MPL 2.0 that create compatibility with GPL 2.0, LGPL 2.1, and AGPL 3.0 will be invalid.

Would you please indicate if you agree to re-license your contributions to xEdit (in this and any other commits) under the MPL 2.0 with requiring an "Incompatible With Secondary Licenses" notice?


Thanks For Sharing Such An Interesting Article, It Is Really Worthy To Read. I Have Subscribed To You And From Now On I'll Check Your Profile Daily For Interesting Stuffs. [agents of shield jacket](http://www.celebstyleoutfits.com/brett-dalton-agent-shield-brown-jacket)


TeamCity Glyssen / Glyssen pull requests [Build *.*.739.f01359f07c7c2323a1c31fe3fbb39f3494a8b07e](https://build.palaso.org/viewLog.html?buildId=173261&buildTypeId=Glyssen_GlyssenPullRequests2) outcome was **SUCCESS**
Summary: Tests passed: 2377, ignored: 18 Build time: 00:11:16


Era pra ser o issue 26, mas ao enviar no commit enviei para o 24.


You are pushing commits at a very fast pace (across the whole organization).
Due to that, we cannot deploy the commit 64c15f1b442799d89399b89e8d58fa55725e3520.

You can try again later or [upgrade](https://zeit.co/account/plan) your plan.


Waiting on Asher's part to finish so this script can be applied.


Successfully deployed to following URLs:

* https://builder-nirsncvfbh.now.sh
* https://builder-staging.now.sh


[Circle has built](https://circleci.com/gh/cypress-io/cypress/208204) the `linux x64` version of the Test Runner.

You can install this pre-release platform-specific build using instructions at [https://on.cypress.io/installing-cypress#Install-pre-release-version](https://on.cypress.io/installing-cypress#Install-pre-release-version).

You will need to use custom `CYPRESS_INSTALL_BINARY` url and install Cypress using an url instead of the version.

    export CYPRESS_INSTALL_BINARY=https://cdn.cypress.io/beta/binary/3.8.0/linux-x64/circle-develop-13aa496476fa5cd3ebf8db552673fa39c52b8076-208191/cypress.zip
    npm install https://cdn.cypress.io/beta/npm/3.8.0/circle-develop-13aa496476fa5cd3ebf8db552673fa39c52b8076-208185/cypress.tgz


Successfully deployed to following URLs:

* https://lelite-6z1rnb7u9.now.sh
* https://lelite.now.sh
* https://lelite.tirdy.now.sh
* https://lelite-git-master.tirdy.now.sh


Waiting on Asher's part to finish so script can be applied.


Only in my dreams :-D ... Nice catch, hoping to do something more robust, primarily wanted to get a workaround out there.


Successfully deployed to following URLs:

* https://marina-hppfrl1ni.now.sh
* https://marina-iota-three.now.sh
* https://marina.davkat.now.sh
* https://marina-git-master.davkat.now.sh


Successfully deployed to following URLs:

* https://quartz-qahbew4pf.now.sh
* https://quartz.connctd.now.sh
* https://quartz-git-master.connctd.now.sh


I am fine with relicensing my contributions under the MPL 2.0 👍


you cannot declare something like this here
if you want to include such safety check - you could write:
`tags && tags.map()`


Same here -- just updated to find this `merge` method removed. What's the reasoning?


Hi,

I intent to change the license of xEdit from MPL 1.1 to MPL 2.0.

https://www.mozilla.org/en-US/MPL/1.1/
https://www.mozilla.org/en-US/MPL/2.0/

In this (and possible other) commit(s) you've contributed to xEdit under the terms of MPL 1.1

The upgrading from version 1.1 to 2.0 of the license is covered clause 6.2. Effect of New Versions of MPL 1.1 and does not require the agreement of contributors.

At the same time, such an upgrade can not be used to force previous contributors to grant additional rights, as such, under clause 1.5 of MPL 2.0, such an upgrade must be marked with a "Incompatible With Secondary Licenses" notice.

That is, without the explicit permission of all contributors that previously contributed under MPL 1.1, the clauses in MPL 2.0 that create compatibility with GPL 2.0, LGPL 2.1, and AGPL 3.0 will be invalid.

It is my believe that none of your commits are present anymore in the branch which will be re-licensed under MPL 2.0 and as such your agreement should not be required.

Please let me know if you disagree with this assessment.


Hi Adrien Destugues!

On Thu, 05 Dec 2019 08:48:44 -0800 Adrien Destugues wrote:
> Added the link in my message above

Sorry, I only saw the email notification, which ended after: "...
contributed by Vanisha Keshwani during Google Code-In."
Perfect :)

Regards,
Humdinger

--
Help translating 3rd party Haiku applications
Go to Polyglot at https://i18n.kacperkasper.pl


jnojnojj


if you include such safety check (as above) -> this test won't work now because  `tags.map()` won't be executed.


![](https://github.trello.services/images/mini-trello-icon.png) [Detecao Defeitos regras](https://trello.com/c/z34dSu3U/12-detecao-defeitos-regras)


po


Hi,

I intent to change the license of xEdit from MPL 1.1 to MPL 2.0.

https://www.mozilla.org/en-US/MPL/1.1/
https://www.mozilla.org/en-US/MPL/2.0/

In this (and possible other) commit(s) you've contributed to xEdit under the terms of MPL 1.1

The upgrading from version 1.1 to 2.0 of the license is covered clause 6.2. Effect of New Versions of MPL 1.1 and does not require the agreement of contributors.

At the same time, such an upgrade can not be used to force previous contributors to grant additional rights, as such, under clause 1.5 of MPL 2.0, such an upgrade must be marked with a "Incompatible With Secondary Licenses" notice.

That is, without the explicit permission of all contributors that previously contributed under MPL 1.1, the clauses in MPL 2.0 that create compatibility with GPL 2.0, LGPL 2.1, and AGPL 3.0 will be invalid.

Would you please indicate if you agree to re-license your contributions to xEdit (in this and any other commits) under the MPL 2.0 without requiring an "Incompatible With Secondary Licenses" notice?


You are pushing commits at a very fast pace (across the whole organization).
Due to that, we cannot deploy the commit 64c15f1b442799d89399b89e8d58fa55725e3520.

You can try again later or [upgrade](https://zeit.co/account/plan) your plan.


ç


thanks! I thought I've removed this.


Instead of creating variable 'yatzee', you can just write 'return false' here and outside the loop, at the end, 'return true'.


I had to search for one of my contributions, but I do not have any issue with the change of license from MPL 1.1 to MPL 2.0


Couldn't you use ex de,hl instead?


@vkarak  I keep the checks for the presence stdout and stderr just for insurance. This might be redundant. The state check is all I need.

Actually using 'qstat` is not the best solution on our site. The `qstat` result for a complete job is only staged in PBS directory for 3 minutes. If the polling interval is longer than 3 mins, my test could be falsely failed due to empty `qstat` result. I am working on integration with our  local python Torque library (written in python 2.7). I hope I can get rid of this polling issue.


I made a mistake and the last sentence above should be:

Would you please indicate if you agree to re-license your contributions to xEdit (in this and any other commits) under the MPL 2.0 with**_out_** requiring an "Incompatible With Secondary Licenses" notice?

Please confirm that your answer remains unchanged. (Sorry for the inconvenience.)


[Circle has built](https://circleci.com/gh/cypress-io/cypress/208209) the `darwin x64` version of the Test Runner.

You can install this pre-release platform-specific build using instructions at [https://on.cypress.io/installing-cypress#Install-pre-release-version](https://on.cypress.io/installing-cypress#Install-pre-release-version).

You will need to use custom `CYPRESS_INSTALL_BINARY` url and install Cypress using an url instead of the version.

    export CYPRESS_INSTALL_BINARY=https://cdn.cypress.io/beta/binary/3.8.0/darwin-x64/circle-develop-692a3c07d99db45874fee6d80d96e35cb29dab07-208208/cypress.zip
    npm install https://cdn.cypress.io/beta/npm/3.8.0/circle-develop-692a3c07d99db45874fee6d80d96e35cb29dab07-208124/cypress.tgz


Successfully deployed to following URLs:

* https://nuxt-book-k0sbeh99e.now.sh
* https://nuxt-book.now.sh
* https://learningnuxt.tech
* https://nuxt-book.droyer.now.sh
* https://nuxt-book-git-master.droyer.now.sh


Yes, I am fine with that.


Successfully deployed to following URLs:

* https://nateradebaughreact-datetime-gi6b6gqyw.now.sh
* https://nateradebaugh-datetime.now.sh
* https://react-datetime.now.sh
* https://nateradebaugh-react-datetime.nateradebaugh.now.sh
* https://nateradebaugh-react-datetime-git-master.nateradebaugh.now.sh


[R/hello.R:16:7:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/hello.R#L16) *style:* **Use <-, not =, for assignment.**
```r
hello = function() {
      ^
```
[R/safer_joins.R:3:1:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L3) *style:* **Lines should not be more than 80 characters.**
```r
#' This augments \code{left_join} from the \code{dplyr} package with important quality control checks.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:4:1:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L4) *style:* **Lines should not be more than 80 characters.**
```r
#' When \code{by} is not NULL, then it checks for duplicated IDs (e.g., join variables).
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:5:1:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L5) *style:* **Lines should not be more than 80 characters.**
```r
#' When \code{by} is NULL, if there is only one column in common between \code{x} and \code{y}, then it checks for duplicated IDs using that single column as the join variable.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:6:1:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L6) *style:* **Lines should not be more than 80 characters.**
```r
#' Also checks if the resulting join has more records than the input table \code{x}.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:13:1:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L13) *style:* **Lines should not be more than 80 characters.**
```r
#' @param copy If x and y are not from the same data source, and copy is TRUE, then y will be copied into the same src as x.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:14:1:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L14) *style:* **Lines should not be more than 80 characters.**
```r
#' @param suffix If there are non-joined duplicate variables in x and y, these suffixes will be added to the output to disambiguate them. Should be a character vector of length 2.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:25:1:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L25) *style:* **Lines should not be more than 80 characters.**
```r
left_join_check <- function(x, y, by = NULL, copy = FALSE, suffix = c(".x", ".y"), ...) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:29:9:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L29) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.x = sum(duplicated(x[,by]))
        ^~~~~~~~~
```
[R/safer_joins.R:29:19:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L29) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.x = sum(duplicated(x[,by]))
                  ^
```
[R/safer_joins.R:29:39:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L29) *style:* **Commas should always have a space after.**
```r
        ndupIDs.x = sum(duplicated(x[,by]))
                                      ^
```
[R/safer_joins.R:31:56:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L31) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in x in the ",by, " column. "))
                                                       ^
```
[R/safer_joins.R:33:9:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L33) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
        ^~~~~~~~~
```
[R/safer_joins.R:33:19:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L33) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
                  ^
```
[R/safer_joins.R:33:39:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L33) *style:* **Commas should always have a space after.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
                                      ^
```
[R/safer_joins.R:35:56:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L35) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in y in the ",by, " column. "))
                                                       ^
```
[R/safer_joins.R:39:9:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L39) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.x = sum(duplicated(x[,names(by)]))
        ^~~~~~~~~
```
[R/safer_joins.R:39:19:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L39) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.x = sum(duplicated(x[,names(by)]))
                  ^
```
[R/safer_joins.R:39:39:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L39) *style:* **Commas should always have a space after.**
```r
        ndupIDs.x = sum(duplicated(x[,names(by)]))
                                      ^
```
[R/safer_joins.R:40:10:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L40) *warning:* **no visible global function definition for 'left_join'**
```r
    r <- left_join(x, y, by, copy, suffix)
         ^~~~~~~~~
```
[R/safer_joins.R:41:56:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L41) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in x in the ",names(by), " column. "))
                                                       ^
```
[R/safer_joins.R:43:9:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L43) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
        ^~~~~~~~~
```
[R/safer_joins.R:43:19:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L43) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
                  ^
```
[R/safer_joins.R:43:39:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L43) *style:* **Commas should always have a space after.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
                                      ^
```
[R/safer_joins.R:45:56:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L45) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in y in the ",by, " column. "))
                                                       ^
```
[R/safer_joins.R:49:33:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L49) *style:* **Commas should always have a space after.**
```r
      by1 <- intersect(names(x),names(y))
                                ^
```
[R/safer_joins.R:52:9:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L52) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.x = sum(duplicated(x[,by1]))
        ^~~~~~~~~
```
[R/safer_joins.R:52:19:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L52) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.x = sum(duplicated(x[,by1]))
                  ^
```
[R/safer_joins.R:52:39:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L52) *style:* **Commas should always have a space after.**
```r
        ndupIDs.x = sum(duplicated(x[,by1]))
                                      ^
```
[R/safer_joins.R:54:56:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L54) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in x in the ",by1, " column. "))
                                                       ^
```
[R/safer_joins.R:56:9:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L56) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.y = sum(duplicated(y[,by1]))
        ^~~~~~~~~
```
[R/safer_joins.R:56:19:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L56) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.y = sum(duplicated(y[,by1]))
                  ^
```
[R/safer_joins.R:56:39:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L56) *style:* **Commas should always have a space after.**
```r
        ndupIDs.y = sum(duplicated(y[,by1]))
                                      ^
```
[R/safer_joins.R:58:56:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L58) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in y in the ",by1, " column. "))
                                                       ^
```
[R/safer_joins.R:63:5:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L63) *style:* **Variable and function name style should be snake_case.**
```r
    d.x <- nrow(x)
    ^~~
```
[R/safer_joins.R:65:5:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L65) *style:* **Variable and function name style should be snake_case.**
```r
    d.r <- nrow(r)
    ^~~
```
[R/safer_joins.R:67:33:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L67) *style:* **Commas should always have a space after.**
```r
      warning(paste0("nrow(x)=",d.x," != nrow(join)=",d.r))
                                ^
```
[R/safer_joins.R:67:37:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L67) *style:* **Commas should always have a space after.**
```r
      warning(paste0("nrow(x)=",d.x," != nrow(join)=",d.r))
                                    ^
```
[R/safer_joins.R:67:55:](https://github.com/DanielEWeeks/dweeks/blob/0d81e23258627a519a617432acc1587246c0c5a4/R/safer_joins.R#L67) *style:* **Commas should always have a space after.**
```r
      warning(paste0("nrow(x)=",d.x," != nrow(join)=",d.r))
                                                      ^
```


Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

- @kylebgorman was added to conda-forge. Welcome to conda-forge!
  Go to https://github.com/orgs/conda-forge/invitation see your invitation.

You should get push access to this feedstock and CI services.

Feel free to join the community [chat room](https://gitter.im/conda-forge/conda-forge.github.io).

NOTE: Please make sure to not push to the repository directly.
      Use branches in your fork for any changes and send a PR.
      More details [here](https://conda-forge.org/docs/maintainer/updating_pkgs.html#forking-and-pull-requests)


Oops, I seem to have answered in somebody's else question. ;) Sorry.


I made a comment about an optimization possibly? I just think I recall being able to do it instead of the way your doing it. Idk


> I made a mistake and the last sentence above should be:
> Would you please indicate if you agree to re-license your contributions to xEdit (in this and any other commits) under the MPL 2.0 with**out** requiring an "Incompatible With Secondary Licenses" notice?

I kind of suspected that 😛 my answer remains unchanged, I'm fine with relicensing them.


LGTM reading the code I will test it during next two days.


Successfully deployed to following URLs:

* https://nuxt-book-937t2rbkx.now.sh
* https://nuxt-book.now.sh
* https://learningnuxt.tech
* https://nuxt-book.droyer.now.sh
* https://nuxt-book-git-master.droyer.now.sh


TeamCity Glyssen / Glyssen pull requests [Build *.*.740.7446e72532c6c616e1fcccd262daeb2ca77516d3](https://build.palaso.org/viewLog.html?buildId=173263&buildTypeId=Glyssen_GlyssenPullRequests2) outcome was **SUCCESS**
Summary: Tests passed: 2377, ignored: 18 Build time: 00:10:47


Damm nice commit deamon


Successfully deployed to following URLs:

* https://github-e2e-tests-dev-alias-v2-with-alias-6h630dcqk.now.sh
* https://z-github-e2e-tests-dev-alias-v2-with-alias.now.sh
* https://github-e2e-tests-dev-alias-v2-with-alias.zeit-github-test-dev1.now.sh
* https://github-e2e-tests-dev-alias-v2-with-alias-git-master.zeit-github-test-dev1.now.sh


Deployment failed with the following error:

~~~
You defined 1 build that did not match any source files (please ensure they are NOT defined in .nowignore):
~~~


Successfully deployed to following URLs:

* https://ccc-h90or0rae.now.sh
* https://ccc.zeit-github-test-dev1.now.sh
* https://ccc-git-master.zeit-github-test-dev1.now.sh


Successfully deployed to following URLs:

* https://github-e2e-tests-dev-alias-v2-without-alias-l2r8wb5m5.now.sh
* https://github-e2e-tests-dev-alias-v2-without-alias.zeit-github-test-dev1.now.sh
* https://github-e2e-tests-dev-alias-v2-without-alias-git-master.zeit-github-test-dev1.now.sh


Successfully deployed to following URLs:

* https://github-e2e-tests-dev-alias-v1-with-alias-xdcndkcgoa.now.sh
* https://z-github-e2e-tests-dev-only.now.sh


Over max line length; consider new line character where a natural word break occurs before column 79.


invert


Successfully deployed to following URLs:

* https://lelite-pzkvroexh.now.sh
* https://lelite.now.sh
* https://lelite.tirdy.now.sh
* https://lelite-git-master.tirdy.now.sh


You are pushing commits at a very fast pace (across the whole organization).
Due to that, we cannot deploy the commit 29b64a28619f48e50be91327562953fd76b85165.

You can try again later or [upgrade](https://zeit.co/account/plan) your plan.


[AppVeyor has built](https://ci.appveyor.com/project/cypress-io/cypress/builds/29342015/job/5o5k7pxu4mxf8gwy) the `win32 x64` version of the Test Runner.

You can install this pre-release platform-specific build using instructions at [https://on.cypress.io/installing-cypress#Install-pre-release-version](https://on.cypress.io/installing-cypress#Install-pre-release-version).

You will need to use custom `CYPRESS_INSTALL_BINARY` url and install Cypress using an url instead of the version.

    set CYPRESS_INSTALL_BINARY=https://cdn.cypress.io/beta/binary/3.8.0/win32-x64/appveyor-develop-692a3c07d99db45874fee6d80d96e35cb29dab07-29342015/cypress.zip
    npm install https://cdn.cypress.io/beta/binary/3.8.0/win32-x64/appveyor-develop-692a3c07d99db45874fee6d80d96e35cb29dab07-29342015/cypress.zip


Thank you for explanations, these borderline cases are important due to short typical duration of DTMF tones.


Check spelling of "directory"


Successfully deployed to following URLs:

* https://goodjobteam-omli1l3t3.now.sh
* https://gooodjob.team
* https://goodjobteam.burba.now.sh
* https://goodjobteam-git-master.burba.now.sh


Hi,

I intent to change the license of xEdit from MPL 1.1 to MPL 2.0.

https://www.mozilla.org/en-US/MPL/1.1/
https://www.mozilla.org/en-US/MPL/2.0/

In this (and possible other) commit(s) you've contributed to xEdit under the terms of MPL 1.1

The upgrading from version 1.1 to 2.0 of the license is covered clause 6.2. Effect of New Versions of MPL 1.1 and does not require the agreement of contributors.

At the same time, such an upgrade can not be used to force previous contributors to grant additional rights, as such, under clause 1.5 of MPL 2.0, such an upgrade must be marked with a "Incompatible With Secondary Licenses" notice.

That is, without the explicit permission of all contributors that previously contributed under MPL 1.1, the clauses in MPL 2.0 that create compatibility with GPL 2.0, LGPL 2.1, and AGPL 3.0 will be invalid.

Would you please indicate if you agree to re-license your contributions to xEdit (in this and any other commits) under the MPL 2.0 without requiring an "Incompatible With Secondary Licenses" notice?


The test case shouldn't change to accommodate your driver, your driver should change to accommodate the test case.


[AppVeyor has built](https://ci.appveyor.com/project/cypress-io/cypress/builds/29342015/job/n86j4u9hpe940jyk) the `win32 ia32` version of the Test Runner.

You can install this pre-release platform-specific build using instructions at [https://on.cypress.io/installing-cypress#Install-pre-release-version](https://on.cypress.io/installing-cypress#Install-pre-release-version).

You will need to use custom `CYPRESS_INSTALL_BINARY` url and install Cypress using an url instead of the version.

    set CYPRESS_INSTALL_BINARY=https://cdn.cypress.io/beta/binary/3.8.0/win32-ia32/appveyor-develop-692a3c07d99db45874fee6d80d96e35cb29dab07-29342015/cypress.zip
    npm install https://cdn.cypress.io/beta/binary/3.8.0/win32-ia32/appveyor-develop-692a3c07d99db45874fee6d80d96e35cb29dab07-29342015/cypress.zip


Looks good to me. Classes are defined properly, each carrying out its own responsibility. Good job!


woowwwwwww....my friend can I find unlimited results>?and please tell me the webbbbbbbb!!!pleaseeeeeeeeee


[R/hello.R:16:7:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/hello.R#L16) *style:* **Use <-, not =, for assignment.**
```r
hello = function() {
      ^
```
[R/safer_joins.R:3:1:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L3) *style:* **Lines should not be more than 80 characters.**
```r
#' This augments \code{left_join} from the \code{dplyr} package with important quality control checks.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:4:1:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L4) *style:* **Lines should not be more than 80 characters.**
```r
#' When \code{by} is not NULL, then it checks for duplicated IDs (e.g., join variables).
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:5:1:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L5) *style:* **Lines should not be more than 80 characters.**
```r
#' When \code{by} is NULL, if there is only one column in common between \code{x} and \code{y}, then it checks for duplicated IDs using that single column as the join variable.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:6:1:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L6) *style:* **Lines should not be more than 80 characters.**
```r
#' Also checks if the resulting join has more records than the input table \code{x}.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:13:1:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L13) *style:* **Lines should not be more than 80 characters.**
```r
#' @param copy If x and y are not from the same data source, and copy is TRUE, then y will be copied into the same src as x.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:14:1:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L14) *style:* **Lines should not be more than 80 characters.**
```r
#' @param suffix If there are non-joined duplicate variables in x and y, these suffixes will be added to the output to disambiguate them. Should be a character vector of length 2.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:25:1:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L25) *style:* **Lines should not be more than 80 characters.**
```r
left_join_check <- function(x, y, by = NULL, copy = FALSE, suffix = c(".x", ".y"), ...) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/safer_joins.R:29:9:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L29) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.x = sum(duplicated(x[,by]))
        ^~~~~~~~~
```
[R/safer_joins.R:29:19:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L29) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.x = sum(duplicated(x[,by]))
                  ^
```
[R/safer_joins.R:29:39:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L29) *style:* **Commas should always have a space after.**
```r
        ndupIDs.x = sum(duplicated(x[,by]))
                                      ^
```
[R/safer_joins.R:31:56:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L31) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in x in the ",by, " column. "))
                                                       ^
```
[R/safer_joins.R:33:9:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L33) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
        ^~~~~~~~~
```
[R/safer_joins.R:33:19:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L33) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
                  ^
```
[R/safer_joins.R:33:39:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L33) *style:* **Commas should always have a space after.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
                                      ^
```
[R/safer_joins.R:35:56:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L35) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in y in the ",by, " column. "))
                                                       ^
```
[R/safer_joins.R:39:9:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L39) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.x = sum(duplicated(x[,names(by)]))
        ^~~~~~~~~
```
[R/safer_joins.R:39:19:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L39) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.x = sum(duplicated(x[,names(by)]))
                  ^
```
[R/safer_joins.R:39:39:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L39) *style:* **Commas should always have a space after.**
```r
        ndupIDs.x = sum(duplicated(x[,names(by)]))
                                      ^
```
[R/safer_joins.R:40:10:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L40) *warning:* **no visible global function definition for 'left_join'**
```r
    r <- left_join(x, y, by, copy, suffix)
         ^~~~~~~~~
```
[R/safer_joins.R:41:56:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L41) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in x in the ",names(by), " column. "))
                                                       ^
```
[R/safer_joins.R:43:9:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L43) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
        ^~~~~~~~~
```
[R/safer_joins.R:43:19:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L43) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
                  ^
```
[R/safer_joins.R:43:39:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L43) *style:* **Commas should always have a space after.**
```r
        ndupIDs.y = sum(duplicated(y[,by]))
                                      ^
```
[R/safer_joins.R:45:56:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L45) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in y in the ",by, " column. "))
                                                       ^
```
[R/safer_joins.R:49:33:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L49) *style:* **Commas should always have a space after.**
```r
      by1 <- intersect(names(x),names(y))
                                ^
```
[R/safer_joins.R:52:9:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L52) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.x = sum(duplicated(x[,by1]))
        ^~~~~~~~~
```
[R/safer_joins.R:52:19:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L52) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.x = sum(duplicated(x[,by1]))
                  ^
```
[R/safer_joins.R:52:39:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L52) *style:* **Commas should always have a space after.**
```r
        ndupIDs.x = sum(duplicated(x[,by1]))
                                      ^
```
[R/safer_joins.R:54:56:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L54) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in x in the ",by1, " column. "))
                                                       ^
```
[R/safer_joins.R:56:9:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L56) *style:* **Variable and function name style should be snake_case.**
```r
        ndupIDs.y = sum(duplicated(y[,by1]))
        ^~~~~~~~~
```
[R/safer_joins.R:56:19:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L56) *style:* **Use <-, not =, for assignment.**
```r
        ndupIDs.y = sum(duplicated(y[,by1]))
                  ^
```
[R/safer_joins.R:56:39:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L56) *style:* **Commas should always have a space after.**
```r
        ndupIDs.y = sum(duplicated(y[,by1]))
                                      ^
```
[R/safer_joins.R:58:56:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L58) *style:* **Commas should always have a space after.**
```r
          warning(paste0("Duplicated IDs in y in the ",by1, " column. "))
                                                       ^
```
[R/safer_joins.R:63:5:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L63) *style:* **Variable and function name style should be snake_case.**
```r
    d.x <- nrow(x)
    ^~~
```
[R/safer_joins.R:65:5:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L65) *style:* **Variable and function name style should be snake_case.**
```r
    d.r <- nrow(r)
    ^~~
```
[R/safer_joins.R:67:33:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L67) *style:* **Commas should always have a space after.**
```r
      warning(paste0("nrow(x)=",d.x," != nrow(join)=",d.r,". "))
                                ^
```
[R/safer_joins.R:67:37:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L67) *style:* **Commas should always have a space after.**
```r
      warning(paste0("nrow(x)=",d.x," != nrow(join)=",d.r,". "))
                                    ^
```
[R/safer_joins.R:67:55:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L67) *style:* **Commas should always have a space after.**
```r
      warning(paste0("nrow(x)=",d.x," != nrow(join)=",d.r,". "))
                                                      ^
```
[R/safer_joins.R:67:59:](https://github.com/DanielEWeeks/dweeks/blob/501e3323de2d395f5a38e100e8c4868faae87fc2/R/safer_joins.R#L67) *style:* **Commas should always have a space after.**
```r
      warning(paste0("nrow(x)=",d.x," != nrow(join)=",d.r,". "))
                                                          ^
```


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


Successfully deployed to following URLs:

* https://hs19-ivis-rae-2j9f6hmpb.now.sh
* https://hs19-ivis-rae.now.sh
* https://hs19-ivis-rae.retobornhauser.now.sh
* https://hs19-ivis-rae-git-master.retobornhauser.now.sh


@deads2k please take a look at this commit