[R/calc_rel_contr_node_time.R:61:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/calc_rel_contr_node_time.R#L61) *style:* **Lines should not be more than 80 characters.**
```r
                                   ((1 - s) * (    num_nodes + num_hidden_nodes))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/calc_rel_contr_node_time.R:61:48:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/calc_rel_contr_node_time.R#L61) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                                   ((1 - s) * (    num_nodes + num_hidden_nodes))
                                               ^
```
[R/calc_rel_contr_node_time.R:63:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/calc_rel_contr_node_time.R#L63) *style:* **Lines should not be more than 80 characters.**
```r
                                   ((1 - s) * (2 * num_nodes + num_hidden_nodes))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/calc_rel_contr_node_time.R:75:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/calc_rel_contr_node_time.R#L75) *style:* **Variable and function names should not be longer than 30 characters.**
```r
calc_expected_hidden_nodes_per_branch <- function(bl, lambda, mu) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/calc_rel_contr_node_time.R:125:3:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/calc_rel_contr_node_time.R#L125) *style:* **Variable and function names should not be longer than 30 characters.**
```r
  calc_expected_hidden_nodes_per_dt <- function(t, lambda, mu) {
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/calc_summary_statistics.R:64:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/calc_summary_statistics.R#L64) *style:* **Lines should not be more than 80 characters.**
```r
    # this is rather inefficient off course, RPANDA can do all pairwise comparisons?
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/calc_summary_statistics.R:65:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/calc_summary_statistics.R#L65) *style:* **Lines should not be more than 80 characters.**
```r
    local_jsd <- tryCatch(RPANDA::JSDtree(list(true_tree, trees[[i]]), meth = "standard")[1,2],
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/calc_summary_statistics.R:65:93:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/calc_summary_statistics.R#L65) *style:* **Commas should always have a space after.**
```r
    local_jsd <- tryCatch(RPANDA::JSDtree(list(true_tree, trees[[i]]), meth = "standard")[1,2],
                                                                                ^
```
[R/calc_summary_statistics.R:79:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/calc_summary_statistics.R#L79) *style:* **Lines should not be more than 80 characters.**
```r
                                 "mean_branch_length", "nLTT", "jsd", "topo_dist")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/count_hidden.R:7:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/count_hidden.R#L7) *style:* **functions should have cyclomatic complexity of less than 15, this has 16.**
```r
reduce_tree <- function(tree) {
^
```
[R/create_equal_alignment.R:4:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/create_equal_alignment.R#L4) *style:* **Lines should not be more than 80 characters.**
```r
#' @param node_model model used to generate substitutions on the nodes (linked or unlinked)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_equal_alignment.R:14:23:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/create_equal_alignment.R#L14) *warning:* **no visible global function definition for ‘count_hidden’**
```r
  num_hidden_nodes <- count_hidden(input_tree)
                      ^~~~~~~~~~~~
```
[R/infer_phylogeny.R:8:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/infer_phylogeny.R#L8) *style:* **Lines should not be more than 80 characters.**
```r
#' @param sub_rate substitution rate used to generate the original alignment (if available), default is 1
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/infer_phylogeny.R:32:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/infer_phylogeny.R#L32) *style:* **Lines should not be more than 80 characters.**
```r
          clock_rate_param = beautier::create_clock_rate_param(value = sub_rate),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_dual_independent.R:1:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_independent.R#L1) *style:* **Lines should not be more than 80 characters.**
```r
#' simulate a sequence assuming node substitutions are shared among the offspring
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_dual_independent.R:13:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_independent.R#L13) *style:* **functions should have cyclomatic complexity of less than 15, this has 23.**
```r
sim_dual_independent <- function(phy,
^
```
[R/sim_dual_independent.R:14:34:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_independent.R#L14) *style:* **Variable and function name style should be snake_case.**
```r
                                 Q1 = NULL,
                                 ^~
```
[R/sim_dual_independent.R:15:34:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_independent.R#L15) *style:* **Variable and function name style should be snake_case.**
```r
                                 Q2 = NULL,
                                 ^~
```
[R/sim_dual_independent.R:37:20:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_independent.R#L37) *style:* **Variable and function name style should be snake_case.**
```r
  if (is.null(Q1)) Q1 <- rep(1, lbf * (lbf - 1) / 2) # default is JC69
                   ^~
```
[R/sim_dual_independent.R:38:20:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_independent.R#L38) *style:* **Variable and function name style should be snake_case.**
```r
  if (is.null(Q2)) Q2 <- rep(1, lbf * (lbf - 1) / 2) # default is JC69
                   ^~
```
[R/sim_dual_independent.R:41:22:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_independent.R#L41) *style:* **Variable and function name style should be snake_case.**
```r
  if (is.matrix(Q1)) Q1 <- Q1[lower.tri(Q1)]
                     ^~
```
[R/sim_dual_independent.R:42:22:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_independent.R#L42) *style:* **Variable and function name style should be snake_case.**
```r
  if (is.matrix(Q2)) Q2 <- Q2[lower.tri(Q2)]
                     ^~
```
[R/sim_dual_independent.R:69:7:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_independent.R#L69) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(number > length(phy$tip.label)) return(TRUE)
      ^
```
[R/sim_dual_independent.R:70:7:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_independent.R#L70) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(number <= length(phy_no_extinct$tip.label)) return(TRUE)
      ^
```
[R/sim_dual_independent.R:79:5:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_independent.R#L79) *style:* **Variable and function name style should be snake_case.**
```r
    P <- get_p_matrix(node_time, eig_q2, rate2)
    ^
```
[R/sim_dual_independent.R:80:6:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_independent.R#L80) *style:* **Commented code should be removed.**
```r
   # P <- nodeSub::slow_matrix(eig_q2, node_time, rate2)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_dual_independent.R:92:5:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_independent.R#L92) *style:* **Variable and function name style should be snake_case.**
```r
    P <- get_p_matrix(tl[i], eig_q1, rate1)
    ^
```
[R/sim_dual_independent.R:93:6:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_independent.R#L93) *style:* **Commented code should be removed.**
```r
    #P <- nodeSub::slow_matrix(eig_q1, tl[i], rate1)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_dual_independent.R:105:7:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_independent.R#L105) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(check_to_extinct_tip(to)) {
      ^
```
[R/sim_dual_independent.R:114:42:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_independent.R#L114) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  label <- c(phy$tip.label, as.character( (k + 1):num_nodes))
                                         ^
```
[R/sim_dual_independent.R:117:34:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_independent.R#L117) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  alignment_phydat <- phyDat.DNA( as.data.frame(res, stringsAsFactors = FALSE))
                                 ^
```
[R/sim_dual_linked.R:35:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_linked.R#L35) *style:* **functions should have cyclomatic complexity of less than 15, this has 17.**
```r
make_transition_matrix <- function(mut_double) {
^
```
[R/sim_dual_linked.R:111:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_linked.R#L111) *style:* **functions should have cyclomatic complexity of less than 15, this has 23.**
```r
sim_dual_linked <- function(phy,
^
```
[R/sim_dual_linked.R:112:29:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_linked.R#L112) *style:* **Variable and function name style should be snake_case.**
```r
                            Q = NULL,
                            ^
```
[R/sim_dual_linked.R:132:19:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_linked.R#L132) *style:* **Variable and function name style should be snake_case.**
```r
  if (is.null(Q)) Q <- rep(1, lbf * (lbf - 1) / 2) # default is JC69
                  ^
```
[R/sim_dual_linked.R:135:21:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_linked.R#L135) *style:* **Variable and function name style should be snake_case.**
```r
  if (is.matrix(Q)) Q <- Q[lower.tri(Q)]
                    ^
```
[R/sim_dual_linked.R:171:7:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_linked.R#L171) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(number > length(phy$tip.label)) return(TRUE)
      ^
```
[R/sim_dual_linked.R:172:7:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_linked.R#L172) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(number <= length(phy_no_extinct$tip.label)) return(TRUE)
      ^
```
[R/sim_dual_linked.R:191:6:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_linked.R#L191) *style:* **Commented code should be removed.**
```r
   # total_node_subs <- total_node_subs + node_subs_1 + node_subs_2
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_dual_linked.R:196:7:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_linked.R#L196) *style:* **Variable and function name style should be snake_case.**
```r
      P <- get_p_matrix(branch_length, eig_q, rate)
      ^
```
[R/sim_dual_linked.R:210:9:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_linked.R#L210) *style:* **Place a space before left parenthesis, except in a function call.**
```r
      if(check_to_extinct_tip(offspring[i])) {
        ^
```
[R/sim_dual_linked.R:220:42:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_linked.R#L220) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  label <- c(phy$tip.label, as.character( (k + 1):num_nodes))
                                         ^
```
[R/sim_dual_parent.R:1:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_parent.R#L1) *style:* **Lines should not be more than 80 characters.**
```r
#' simulate a sequence assuming node substitutions are shared among the offspring
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_dual_parent.R:13:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_parent.R#L13) *style:* **functions should have cyclomatic complexity of less than 15, this has 18.**
```r
sim_dual_parent <- function(phy,
^
```
[R/sim_dual_parent.R:14:27:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_parent.R#L14) *style:* **Variable and function name style should be snake_case.**
```r
                          Q1 = NULL,
                          ^~
```
[R/sim_dual_parent.R:15:27:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_parent.R#L15) *style:* **Variable and function name style should be snake_case.**
```r
                          Q2 = NULL,
                          ^~
```
[R/sim_dual_parent.R:29:20:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_parent.R#L29) *style:* **Variable and function name style should be snake_case.**
```r
  if (is.null(Q1)) Q1 <- rep(1, lbf * (lbf - 1) / 2) # default is JC69
                   ^~
```
[R/sim_dual_parent.R:30:20:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_parent.R#L30) *style:* **Variable and function name style should be snake_case.**
```r
  if (is.null(Q2)) Q2 <- rep(1, lbf * (lbf - 1) / 2) # default is JC69
                   ^~
```
[R/sim_dual_parent.R:33:22:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_parent.R#L33) *style:* **Variable and function name style should be snake_case.**
```r
  if (is.matrix(Q1)) Q1 <- Q1[lower.tri(Q1)]
                     ^~
```
[R/sim_dual_parent.R:34:22:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_parent.R#L34) *style:* **Variable and function name style should be snake_case.**
```r
  if (is.matrix(Q2)) Q2 <- Q2[lower.tri(Q2)]
                     ^~
```
[R/sim_dual_parent.R:64:5:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_parent.R#L64) *style:* **Variable and function name style should be snake_case.**
```r
    P <- get_p_matrix(node_time, eig_q2, rate2)
    ^
```
[R/sim_dual_parent.R:86:7:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_parent.R#L86) *style:* **Variable and function name style should be snake_case.**
```r
      P <- get_p_matrix(branch_length, eig_q1, rate1)
      ^
```
[R/sim_dual_parent.R:105:42:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_dual_parent.R#L105) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  label <- c(phy$tip.label, as.character( (k + 1):num_nodes))
                                         ^
```
[R/sim_linked.R:12:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_linked.R#L12) *style:* **functions should have cyclomatic complexity of less than 15, this has 16.**
```r
sim_linked <- function(phy,
^
```
[R/sim_linked.R:13:24:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_linked.R#L13) *style:* **Variable and function name style should be snake_case.**
```r
                       Q = NULL,
                       ^
```
[R/sim_linked.R:33:19:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_linked.R#L33) *style:* **Variable and function name style should be snake_case.**
```r
  if (is.null(Q)) Q <- rep(1, lbf * (lbf - 1) / 2) # default is JC69
                  ^
```
[R/sim_linked.R:36:21:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_linked.R#L36) *style:* **Variable and function name style should be snake_case.**
```r
  if (is.matrix(Q)) Q <- Q[lower.tri(Q)]
                    ^
```
[R/sim_linked.R:88:7:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_linked.R#L88) *style:* **Variable and function name style should be snake_case.**
```r
      P <- get_p_matrix(branch_length, eig_q, rate)
      ^
```
[R/sim_linked.R:108:42:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_linked.R#L108) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  label <- c(phy$tip.label, as.character( (k + 1):num_nodes))
                                         ^
```
[R/sim_normal.R:31:24:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_normal.R#L31) *style:* **Variable and function name style should be snake_case.**
```r
                       Q = NULL,
                       ^
```
[R/sim_normal.R:43:5:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_normal.R#L43) *style:* **Variable and function name style should be snake_case.**
```r
    Q <- rep(1, lbf * (lbf - 1) / 2)
    ^
```
[R/sim_normal.R:45:21:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_normal.R#L45) *style:* **Variable and function name style should be snake_case.**
```r
  if (is.matrix(Q)) Q <- Q[lower.tri(Q)]
                    ^
```
[R/sim_normal.R:67:5:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_normal.R#L67) *style:* **Variable and function name style should be snake_case.**
```r
    P <- get_p_matrix(tl[i], eig, rate)
    ^
```
[R/sim_normal.R:81:40:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_normal.R#L81) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  label <- c(x$tip.label, as.character( (k + 1):num_nodes))
                                       ^
```
[R/sim_unlinked_tree.R:10:5:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L10) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(class(phy) != "phylo") {
    ^
```
[R/sim_unlinked_tree.R:34:51:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L34) *style:* **Put spaces around all infix operators.**
```r
      to_add <- c(start_node, end_node, t0, t1, t0-t1)
                                                 ~^~
```
[R/sim_unlinked_tree.R:40:3:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L40) *style:* **Variable and function names should not be longer than 30 characters.**
```r
  calc_expected_hidden_nodes_per_dt <- function(t, lambda, mu) {
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_unlinked_tree.R:50:35:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L50) *style:* **Commas should always have a space after.**
```r
                  apply(branches[,c(3,4)], 1,
                                  ^
```
[R/sim_unlinked_tree.R:50:39:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L50) *style:* **Commas should always have a space after.**
```r
                  apply(branches[,c(3,4)], 1,
                                      ^
```
[R/sim_unlinked_tree.R:52:36:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L52) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                        lambda, mu) )
                                   ^
```
[R/sim_unlinked_tree.R:63:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L63) *style:* **Lines should not be more than 80 characters.**
```r
#' simulate a sequence assuming node substitutions are shared among the offspring
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_unlinked_tree.R:77:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L77) *style:* **functions should have cyclomatic complexity of less than 15, this has 43.**
```r
sim_unlinked_tree <- function(phy,
^
```
[R/sim_unlinked_tree.R:78:31:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L78) *style:* **Variable and function name style should be snake_case.**
```r
                              Q1 = NULL,
                              ^~
```
[R/sim_unlinked_tree.R:79:31:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L79) *style:* **Variable and function name style should be snake_case.**
```r
                              Q2 = NULL,
                              ^~
```
[R/sim_unlinked_tree.R:104:10:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L104) *style:* **Only use double-quotes.**
```r
    stop('lambda and mu have to be provided')
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_unlinked_tree.R:113:20:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L113) *style:* **Variable and function name style should be snake_case.**
```r
  if (is.null(Q1)) Q1 <- rep(1, lbf * (lbf - 1) / 2) # default is JC69
                   ^~
```
[R/sim_unlinked_tree.R:114:20:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L114) *style:* **Variable and function name style should be snake_case.**
```r
  if (is.null(Q2)) Q2 <- rep(1, lbf * (lbf - 1) / 2) # default is JC69
                   ^~
```
[R/sim_unlinked_tree.R:117:22:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L117) *style:* **Variable and function name style should be snake_case.**
```r
  if (is.matrix(Q1)) Q1 <- Q1[lower.tri(Q1)]
                     ^~
```
[R/sim_unlinked_tree.R:118:22:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L118) *style:* **Variable and function name style should be snake_case.**
```r
  if (is.matrix(Q2)) Q2 <- Q2[lower.tri(Q2)]
                     ^~
```
[R/sim_unlinked_tree.R:131:51:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L131) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  hidden_nodes <- add_hidden_nodes(phy, lambda, mu )
                                                  ^
```
[R/sim_unlinked_tree.R:146:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L146) *style:* **Lines should not be more than 80 characters.**
```r
  P_n <- nodeSub::slow_matrix(eig_q2, node_time, rate2)    #get_p_matrix(node_time, eig_q2, rate2)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_unlinked_tree.R:146:3:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L146) *style:* **Variable and function name style should be snake_case.**
```r
  P_n <- nodeSub::slow_matrix(eig_q2, node_time, rate2)    #get_p_matrix(node_time, eig_q2, rate2)
  ^~~
```
[R/sim_unlinked_tree.R:146:61:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L146) *style:* **Commented code should be removed.**
```r
  P_n <- nodeSub::slow_matrix(eig_q2, node_time, rate2)    #get_p_matrix(node_time, eig_q2, rate2)
                                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_unlinked_tree.R:151:7:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L151) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(number > length(phy$tip.label)) return(TRUE)
      ^
```
[R/sim_unlinked_tree.R:152:7:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L152) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(number <= length(phy_no_extinct$tip.label)) return(TRUE)
      ^
```
[R/sim_unlinked_tree.R:181:9:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L181) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
    if ( obs_hidden_nodes[i] > 0) {
        ^
```
[R/sim_unlinked_tree.R:186:10:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L186) *style:* **Place a space before left parenthesis, except in a function call.**
```r
      for(j in 1:obs_hidden_nodes[i]) {
         ^
```
[R/sim_unlinked_tree.R:188:14:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L188) *style:* **Place a space before left parenthesis, except in a function call.**
```r
        while(focal_t + dt >= total_bl) {
             ^
```
[R/sim_unlinked_tree.R:198:8:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L198) *style:* **Commented code should be removed.**
```r
      #P_b <- get_p_matrix(bl[1], eig_q1, rate1)
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_unlinked_tree.R:199:7:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L199) *style:* **Variable and function name style should be snake_case.**
```r
      P_b <-  nodeSub::slow_matrix(eig_q1, bl[1], rate1)
      ^~~
```
[R/sim_unlinked_tree.R:214:10:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L214) *style:* **Place a space before left parenthesis, except in a function call.**
```r
      for(h in 1:obs_hidden_nodes[i]) {
         ^
```
[R/sim_unlinked_tree.R:227:10:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L227) *style:* **Commented code should be removed.**
```r
        #P_b <- get_p_matrix(bl[1], eig_q1, rate1)
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_unlinked_tree.R:228:9:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L228) *style:* **Variable and function name style should be snake_case.**
```r
        P_b <-  nodeSub::slow_matrix(eig_q1, bl[1], rate1)
        ^~~
```
[R/sim_unlinked_tree.R:247:8:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L247) *style:* **Commented code should be removed.**
```r
      #P <- get_p_matrix(tl[i], eig_q1, rate1)
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_unlinked_tree.R:248:7:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L248) *style:* **Variable and function name style should be snake_case.**
```r
      P <-  nodeSub::slow_matrix(eig_q1, tl[i], rate1)
      ^
```
[R/sim_unlinked_tree.R:263:7:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L263) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(check_to_extinct_tip(to)) {
      ^
```
[R/sim_unlinked_tree.R:270:42:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L270) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  label <- c(phy$tip.label, as.character( (k + 1):num_nodes))
                                         ^
```
[R/sim_unlinked_tree.R:273:34:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L273) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  alignment_phydat <- phyDat.DNA( as.data.frame(res, stringsAsFactors = FALSE))
                                 ^
```
[R/sim_unlinked_tree.R:282:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L282) *style:* **Lines should not be more than 80 characters.**
```r
#' simulate a sequence assuming node substitutions are shared among the offspring
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_unlinked_tree.R:301:40:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L301) *style:* **Variable and function name style should be snake_case.**
```r
                                       Q1 = NULL,
                                       ^~
```
[R/sim_unlinked_tree.R:302:40:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L302) *style:* **Variable and function name style should be snake_case.**
```r
                                       Q2 = NULL,
                                       ^~
```
[R/sim_unlinked_tree.R:313:5:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L313) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(geiger::is.extinct(input_tree)) > 0) {
    ^
```
[R/sim_unlinked_tree.R:320:5:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L320) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(is.null(focal_alignment)) {
    ^
```
[R/sim_unlinked_tree.R:322:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L322) *style:* **Lines should not be more than 80 characters.**
```r
    focal_alignment <- nodeSub::sim_normal(input_tree, l = l, Q = Q1, bf = bf, rootseq = rootseq, rate = rate1)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_unlinked_tree.R:336:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L336) *style:* **Lines should not be more than 80 characters.**
```r
    proposed_alignment <- nodeSub::sim_unlinked_tree(input_tree, Q1 = Q1, Q2 = Q2,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_unlinked_tree.R:337:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L337) *style:* **Lines should not be more than 80 characters.**
```r
                                                     rate1 = focal_rate, rate2 = focal_rate, l = l, bf = bf, rootseq = rootseq,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_unlinked_tree.R:338:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L338) *style:* **Lines should not be more than 80 characters.**
```r
                                                     node_time = node_time, lambda = lambda, mu = mu)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_unlinked_tree.R:347:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked_tree.R#L347) *style:* **Lines should not be more than 80 characters.**
```r
  proposed_alignment <- propose_alignments(buffer = c(), focal_rate = adjusted_rate)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_unlinked.R:1:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked.R#L1) *style:* **Lines should not be more than 80 characters.**
```r
#' simulate a sequence assuming node substitutions are shared among the offspring
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sim_unlinked.R:13:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked.R#L13) *style:* **functions should have cyclomatic complexity of less than 15, this has 18.**
```r
sim_unlinked <- function(phy,
^
```
[R/sim_unlinked.R:14:26:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked.R#L14) *style:* **Variable and function name style should be snake_case.**
```r
                         Q1 = NULL,
                         ^~
```
[R/sim_unlinked.R:15:26:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked.R#L15) *style:* **Variable and function name style should be snake_case.**
```r
                         Q2 = NULL,
                         ^~
```
[R/sim_unlinked.R:37:20:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked.R#L37) *style:* **Variable and function name style should be snake_case.**
```r
  if (is.null(Q1)) Q1 <- rep(1, lbf * (lbf - 1) / 2) # default is JC69
                   ^~
```
[R/sim_unlinked.R:38:20:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked.R#L38) *style:* **Variable and function name style should be snake_case.**
```r
  if (is.null(Q2)) Q2 <- rep(1, lbf * (lbf - 1) / 2) # default is JC69
                   ^~
```
[R/sim_unlinked.R:41:22:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked.R#L41) *style:* **Variable and function name style should be snake_case.**
```r
  if (is.matrix(Q1)) Q1 <- Q1[lower.tri(Q1)]
                     ^~
```
[R/sim_unlinked.R:42:22:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked.R#L42) *style:* **Variable and function name style should be snake_case.**
```r
  if (is.matrix(Q2)) Q2 <- Q2[lower.tri(Q2)]
                     ^~
```
[R/sim_unlinked.R:71:5:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked.R#L71) *style:* **Variable and function name style should be snake_case.**
```r
    P <- get_p_matrix(node_time, eig_q2, rate2)
    ^
```
[R/sim_unlinked.R:84:5:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked.R#L84) *style:* **Variable and function name style should be snake_case.**
```r
    P <- get_p_matrix(tl[i], eig_q1, rate1)
    ^
```
[R/sim_unlinked.R:104:42:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked.R#L104) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  label <- c(phy$tip.label, as.character( (k + 1):num_nodes))
                                         ^
```
[R/sim_unlinked.R:107:34:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/sim_unlinked.R#L107) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  alignment_phydat <- phyDat.DNA( as.data.frame(res, stringsAsFactors = FALSE))
                                 ^
```
[R/util.R:2:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/util.R#L2) *style:* **Variable and function name style should be snake_case.**
```r
fast.table <- function(data) {
^~~~~~~~~~
```
[R/util.R:20:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/util.R#L20) *style:* **Variable and function name style should be snake_case.**
```r
phyDat.DNA <- function(data) {
^~~~~~~~~~
```
[R/util.R:35:3:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/util.R#L35) *style:* **Variable and function name style should be snake_case.**
```r
  AC <- matrix(c(c(1, 0, 0, 0, 0, 1, 1, 1, 0, 0, 0, 1, 1, 1, 0, 1, 1, 1),
  ^~
```
[R/util.R:108:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/util.R#L108) *style:* **functions should have cyclomatic complexity of less than 15, this has 23.**
```r
slow_matrix <- function(eig, branch_length, rate) {
^
```
[R/util.R:116:3:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/R/util.R#L116) *style:* **Variable and function name style should be snake_case.**
```r
  P <- matrix(NA, nrow = dim_size, ncol = dim_size)
  ^
```
[tests/testthat/test-dual_independent.R:10:3:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/tests/testthat/test-dual_independent.R#L10) *style:* **Variable and function name style should be snake_case.**
```r
  Q_JC <- matrix(1, nrow = 4, ncol = 4)
  ^~~~
```
[tests/testthat/test-dual_parent.R:9:3:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/tests/testthat/test-dual_parent.R#L9) *style:* **Variable and function name style should be snake_case.**
```r
  Q_JC <- matrix(1, nrow = 4, ncol = 4)
  ^~~~
```
[tests/testthat/test-dual-linked.R:9:3:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/tests/testthat/test-dual-linked.R#L9) *style:* **Variable and function name style should be snake_case.**
```r
  Q_JC <- matrix(1, nrow = 4, ncol = 4)
  ^~~~
```
[tests/testthat/test-relative_node_time.R:22:1:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/tests/testthat/test-relative_node_time.R#L22) *style:* **Lines should not be more than 80 characters.**
```r
  obs_fraction <- ali$total_node_substitutions / (ali$total_node_substitutions + ali$total_branch_substitutions)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sim_normal.R:20:3:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/tests/testthat/test-sim_normal.R#L20) *style:* **Variable and function name style should be snake_case.**
```r
  Q_JC <- matrix(1, nrow = 4, ncol = 4)
  ^~~~
```
[tests/testthat/test-substitution.R:10:3:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/tests/testthat/test-substitution.R#L10) *style:* **Variable and function name style should be snake_case.**
```r
  Q <- rep(1, lbf * (lbf - 1) / 2) # default is JC69
  ^
```
[tests/testthat/test-substitution.R:13:21:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/tests/testthat/test-substitution.R#L13) *style:* **Variable and function name style should be snake_case.**
```r
  if (is.matrix(Q)) Q <- Q[lower.tri(Q)]
                    ^
```
[tests/testthat/test-substitution.R:29:5:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/tests/testthat/test-substitution.R#L29) *style:* **Variable and function name style should be snake_case.**
```r
    P <- nodeSub::slow_matrix(eig = eig_q,
    ^
```
[tests/testthat/test-substitution.R:84:3:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/tests/testthat/test-substitution.R#L84) *style:* **Variable and function name style should be snake_case.**
```r
  Q <- rep(1, lbf * (lbf - 1) / 2) # default is JC69
  ^
```
[tests/testthat/test-substitution.R:87:21:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/tests/testthat/test-substitution.R#L87) *style:* **Variable and function name style should be snake_case.**
```r
  if (is.matrix(Q)) Q <- Q[lower.tri(Q)]
                    ^
```
[tests/testthat/test-substitution.R:94:3:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/tests/testthat/test-substitution.R#L94) *style:* **Variable and function name style should be snake_case.**
```r
  P1 <- nodeSub::slow_matrix(eig = eig_q,
  ^~
```
[tests/testthat/test-substitution.R:98:3:](https://github.com/thijsjanzen/nodeSub/blob/8dad26e6c7b340d175be9acfecba586aa584e011/tests/testthat/test-substitution.R#L98) *style:* **Variable and function name style should be snake_case.**
```r
  P2 <- get_p_matrix(branch_length, eig_q, rate)
  ^~
```


`options` darf durch ? ja undefined sein, aber dann crasht `options.operatorType`


what do you mean? 1.0.2 was released in c00a71bb


Successfully deployed to following URLs:

* https://dotcom-8quf2g1qe.now.sh
* https://smokeyfro.com
* https://dotcom.smokeyfro.now.sh
* https://dotcom-git-master.smokeyfro.now.sh


@james77777778
我改了後發現沒有解決問題。
我覺得是zeros怎麼alloc gpu記憶體空間的問題。
因為就算沒有pre_list，final_image所指向的空間也會更新。


Yes?

On Tue, Dec 17, 2019, 10:24 tawannacab87 <notifications@github.com> wrote:

> "url": "https://github.com/Paget96/LSpeed/releases/tag/v2.1.2-beta1patch1
> ",
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/Paget96/LSpeed/commit/dc0e2bc55c1a57b93ac704f7e55371b5becbf2aa?email_source=notifications&email_token=ACQHFBI5DFCNSTO5RFUGWBDQZCLGLA5CNFSM4J3YJQNKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBCYWPW#commitcomment-36461046>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACQHFBM5U53YCNFHGXTML73QZCLGLANCNFSM4J3YJQNA>
> .
>


Thanks!


Thanks a lot! You were right and I got it done.


Yep, I'll validate this using my different labs.


Successfully deployed to following URLs:

* https://hackinthenorthgithubio-qwhnogr32.now.sh


Deploy preview for _website_ ready!

Built with commit c8c7348cf23eef10c9562b3b53bbebd01196597a

https://shopware-pwa-6aka9hrpw.now.sh


We should always use `armv[56]*|mips*|ppc*)` for `libatomic-devel` patches.


可以考虑生成parameter的时候对Page做特殊处理。
还需要考虑PageRange的处理


I'm not sure I follow your comments about this change.

My original rationale was this:
- TriggerableDag.finalizeTriggerables() throws an exception if there are cycles.
- TriggerbleDag.finalizeTriggerables() is called in two times:
  - When parsing a form in XFormParser.addMainInstance.

    Here, we call the checkDependencyCycles method and then we call finalizeTriggerables, which should make the first cycle check redundant.

  - When deserializing a form, which is a scenario where there can be no cycles, since the form was parsed and serialized in the first place.

Maybe the cycle check in the finalizeTriggerables method allows for self references? If so, should we fix this and make it throw an exception too if that happens?


Successfully deployed to following URLs:

* https://ctrl-tab-api-fnj851ren.now.sh
* https://api.ctrltab.io
* https://ctrl-tab-api.ludicrous.now.sh
* https://ctrl-tab-api-git-master.ludicrous.now.sh


Again, this needs to be lowercased :)


hi hello


gggggggg


:white_check_mark: All Rules (5 / 5) Passed

      :crown: Good job! this pull request is aligned with your organization's best practices!

      :point_right: You can review your rules settings at smart policy management :point_left:

:point_right: click here to view a full list of the events :point_left:


Only one of these equalities holds for negative binomial, since `var` is different.


@saroehr I've reproduced it with:

```

public interface Issuer extends Resource {}

@Entity(name = IssuerImpl.ENTITY_NAME)
@SecondaryTable(name = IssuerImpl.TABLE_NAME)
@NamedQuery(name = IssuerImpl.SELECT_RESOURCES_BY_ISSUER, query = "SELECT resource.identifier FROM " + ResourceImpl.ENTITY_NAME + " resource WHERE resource.identifier.issuer IN (SELECT issuer.identifier.issuer FROM " + IssuerImpl.ENTITY_NAME + " issuer WHERE issuer.parentIssuer = :issuer OR issuer = :issuer)")
public static class IssuerImpl extends ResourceImpl implements Issuer {

	private static final String SELECT_RESOURCES_BY_ISSUER = "SELECT_RESOURCES_BY_ISSUER";
	private static final String ENTITY_NAME = "Issuer";
	public static final String PARENT_ISSUER_COLUMN = "parent_issuer";
	public static final String PARENT_IDENTIFIER_COLUMN = "parent_identifier";
	public static final String TABLE_NAME = "issuer_impl";

	@ManyToOne(targetEntity = IssuerImpl.class)
	@JoinColumns({
			@JoinColumn(name = PARENT_ISSUER_COLUMN, table = TABLE_NAME, referencedColumnName = "issuer"),
			@JoinColumn(name = PARENT_IDENTIFIER_COLUMN, table = TABLE_NAME, referencedColumnName = "identifier")
	})
	private Issuer parentIssuer;

	public Identifier getIdentifier() {
		return identifier;
	}

	public void setIdentifier(Identifier identifier) {
		this.identifier = identifier;
	}

	public Issuer getParentIssuer() {
		return parentIssuer;
	}

	public void setParentIssuer(Issuer parentIssuer) {
		this.parentIssuer = parentIssuer;
	}
}

@Embeddable
public static class Identifier implements Serializable {
	Long issuer;
	String identifier;

	public Long getIssuer() {
		return issuer;
	}

	public void setIssuer(Long issuer) {
		this.issuer = issuer;
	}

	public String getIdentifier() {
		return identifier;
	}

	public void setIdentifier(String identifier) {
		this.identifier = identifier;
	}

	public Identifier() {

	}

	public Identifier(Long issuer, String identifier) {
		this.issuer = issuer;
		this.identifier = identifier;
	}

	@Override
	public boolean equals(Object o) {
		if (this == o) return true;
		if (o == null || getClass() != o.getClass()) return false;
		Identifier that = (Identifier) o;
		return Objects.equals(issuer, that.issuer) &&
				Objects.equals(identifier, that.identifier);
	}

	@Override
	public int hashCode() {
		return Objects.hash(issuer, identifier);
	}
}

public interface Resource {

}

@Entity(name = ResourceImpl.ENTITY_NAME)
@Inheritance(strategy = InheritanceType.SINGLE_TABLE)
public static class ResourceImpl implements Resource {

	private static final String ENTITY_NAME = "Resource";

	@EmbeddedId
	Identifier identifier;

	public Identifier getIdentifier() {
		return identifier;
	}

	public void setIdentifier(Identifier identifier) {
		this.identifier = identifier;
	}
}
```

Looking into it now. No need to share further details.


Спасибо) Сделал, посмотрим, как будет работать.

--
Leonid Shagabutdinov,
+7 905 937 6988

On Mon, 16 Dec 2019 at 16:23, Egor Kovetskiy <notifications@github.com>
wrote:

> ну и сервисы стартануть не забудь
> systemctl enable --now dnsmasq stubby
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/shagabutdinov/dotfiles/commit/18da0c0836a93c08ea720425bce6e3f0f911c98a?email_source=notifications&email_token=AAMPKHP26YWKY6OU7FY5ADTQY56M7A5CNFSM4J2WYUJ2YY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBCYHN6#commitcomment-36445630>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAMPKHIXH44GYTFZGHYWDUTQY56M7ANCNFSM4J2WYUJQ>
> .
>


❌ Status for 'xamarin-macios - sample testing (build)': [failure](https://devdiv.visualstudio.com//DevDiv/_build/results?buildId=3327492).

* ❌ Debug_iPhone_AF: Failed
* ❌ Debug_iPhone_GR: Failed
* ❌ Debug_iPhone_SZ: Failed
* ❌ Debug_iPhoneSimulator: Failed
* ❌ Release_iPhone_AF: Failed
* ❌ Release_iPhone_GR: Failed
* ❌ Release_iPhone_SZ: Failed
* ❌ Release_iPhoneSimulator: Failed
* ❌ Debug_Mac: Failed
* ❌ Release_Mac: Failed


``` suggestion
import { MailAddressBlock } from 'ddp-sdk';
```
Probably we have to update SDK's `public-api.ts`


Curly braces require spaces around them.


As do binary operators.


Spaces.


Also, should be private and marked `@Transient`.


Successfully deployed to following URLs:

* https://kauri-serverless-migration-rk61z6cpv.now.sh
* https://kauri-serverless-migration-omega-ten.now.sh
* https://dev.kauri.io
* https://kauri-serverless-migration.kauri.now.sh
* https://kauri-serverless-migration-git-development.kauri.now.sh


```suggestion
import { MailAddressBlock } from 'ddp-sdk';
```


Fixed, thank you for the review.


Successfully deployed to following URLs:

* https://ctrl-tab-api-hfhoi6d56.now.sh
* https://api.ctrltab.io
* https://ctrl-tab-api.ludicrous.now.sh
* https://ctrl-tab-api-git-master.ludicrous.now.sh


The predictor is log mean, not mean.


thanks @josephhearnshaw


Hm, code suggestion doesn't work...
And probably we have to update SDK's `public-api.ts`


I tried to use R2.4.1, but this not fix the problem "infinite loops when no NFC device" for me. With the function nfcManager_doInitialize I don't have a return value. My log:

NxpFunc:    phNxpLog_InitializeLogLevel: global =3, Fwdnld =0, extns =0,                     hal =0, tml =0, ncir =0,                     ncix =0
NxpFunc:    Nfc: NFC_SetTraceLevel () new_level = 0

NxpFunc:    NfcAdaptation::HalDeviceContextCallback: event=6

Please, can you help me?


[R/check_pir_out.R:17:1:](https://github.com/richelbilderbeek/pirouette/blob/c4ab506982ca1531efd9ad09c2278bf314a7a7a7/R/check_pir_out.R#L17) *style:* **functions should have cyclomatic complexity of less than 15, this has 17.**
```r
check_pir_out <- function(
^
```
[R/create_all_experiments.R:24:1:](https://github.com/richelbilderbeek/pirouette/blob/c4ab506982ca1531efd9ad09c2278bf314a7a7a7/R/create_all_experiments.R#L24) *style:* **functions should have cyclomatic complexity of less than 15, this has 30.**
```r
create_all_experiments <- function(
^
```
[R/create_copy_twin_tree_from_true_fun.R:21:1:](https://github.com/richelbilderbeek/pirouette/blob/c4ab506982ca1531efd9ad09c2278bf314a7a7a7/R/create_copy_twin_tree_from_true_fun.R#L21) *style:* **Variable and function names should not be longer than 30 characters.**
```r
create_copy_twin_tree_from_true_fun <- function() {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/est_evidences.R:35:1:](https://github.com/richelbilderbeek/pirouette/blob/c4ab506982ca1531efd9ad09c2278bf314a7a7a7/R/est_evidences.R#L35) *style:* **functions should have cyclomatic complexity of less than 15, this has 20.**
```r
est_evidences <- function(
^
```
[R/get_sim_twal_with_same_n_mutation_fun.R:29:1:](https://github.com/richelbilderbeek/pirouette/blob/c4ab506982ca1531efd9ad09c2278bf314a7a7a7/R/get_sim_twal_with_same_n_mutation_fun.R#L29) *style:* **Variable and function names should not be longer than 30 characters.**
```r
get_sim_twal_with_same_n_mutation_fun <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/select_candidate_evidences.R:25:1:](https://github.com/richelbilderbeek/pirouette/blob/c4ab506982ca1531efd9ad09c2278bf314a7a7a7/R/select_candidate_evidences.R#L25) *style:* **functions should have cyclomatic complexity of less than 15, this has 20.**
```r
select_candidate_evidences <- function(
^
```


reedits


The value is only used in one `when` branch, thus should be defined there.


Successfully deployed to following URLs:

* https://pizzaprocloud-ui-o3885k1os.now.sh
* https://pizzaprocloud.now.sh
* https://pizzaprocloud-ui.dolf99.now.sh
* https://pizzaprocloud-ui-git-master.dolf99.now.sh


Successfully deployed to following URLs:

* https://tsx-css-4dnckbhlj.now.sh
* https://tsx-css.cbdyzj.now.sh
* https://tsx-css-git-master.cbdyzj.now.sh


Why `Float` and not `Double`?


getRecordsEvenly


Successfully deployed to following URLs:

* https://notes-gub0lfplx.now.sh
* https://theorem.space
* https://notes.n6g7.now.sh
* https://notes-git-master.n6g7.now.sh


Spaces.


Please document this function here!


Use row_count


Do we need this? I thought the below else condition would take care of the LetsInvest contract call.


Also fixed error in style.css


creat


Hi,

Thanks for using libphonenumber and taking time to improve.
Gabon metadata has been updated and released in last push.
Please let us know if the results are still not as expected in our demo:
https://libphonenumber.appspot.com/


I would suggest you implement two classes: `SingleSeqAminoAcidVCFSeqExtractor` and
`SingleVariantAminoAcidVCFSeqExtractor`, which could inherit from a class called `AminoAcidVCFSeqExtractor` all the common functionality.


Is this an optimization? Because I don't think we can send a COMMIT in this situation. Here, we need to check if the PRE-PREPARE message is valid (we should add a method that checks the pre-prepare validity and returns a bool) and send a PREPARE if it is so.


Successfully deployed to following URLs:

* https://hackinthenorthgithubio-njcqn41ad.now.sh


In this branch, the hypothesis is that ordering a potentially smaller set of triggerables each time some of them is eval'ed could be faster than ordering them first and then having to manage bigger sets each time something is eval'ed. I haven't got the chance to test this enough to be sure. Also, it feels like there will be tradeoffs that would have to be assesed.

Overall, this is the part of the DAG that I have studied less. I think that, with more time, we could devise specific tests and scenarios to decide which is the best strategy to follow, but there's a risk of arriving to the conclusion that the current strategy is the best.


Since `a = abs(a)` hack only happens at the beginning of the iteration, `aNext` can potentially be negative here.


Rename to delete() or even cancel()


Please disentangle the test code from your classes. As it used to be before.


↑当問題の場合横幅は20%と指定するのが良いと思います。
理由：メニュー1～4と空白部分が同等のサイズとなる様にする為。


The [`usethis::use_data()`](https://usethis.r-lib.org/reference/use_data.html) function is really helpful for this since it defaults to version 2.


Unused import


Successfully deployed to following URLs:

* https://kybervirtualhackathon-2dgrpw9s4.now.sh
* https://defizap.com
* https://kybervirtualhackathon.botforkybergang.now.sh
* https://kybervirtualhackathon-git-master.botforkybergang.now.sh


I'll add your test from to the test suite and will add another test with cycles that have no self references to be absolutely sure that our code absolutely prevents forms with cycles.


imports should be at the top!


Just id


↑当問題の場合横幅は20%と指定するのが良いと思います。
理由：メニュー1～4と空白部分が同等のサイズとなる様にする為。
（20%×5=100%）


[R/check_pir_out.R:17:1:](https://github.com/richelbilderbeek/pirouette/blob/c4ab506982ca1531efd9ad09c2278bf314a7a7a7/R/check_pir_out.R#L17) *style:* **functions should have cyclomatic complexity of less than 15, this has 17.**
```r
check_pir_out <- function(
^
```
[R/create_all_experiments.R:24:1:](https://github.com/richelbilderbeek/pirouette/blob/c4ab506982ca1531efd9ad09c2278bf314a7a7a7/R/create_all_experiments.R#L24) *style:* **functions should have cyclomatic complexity of less than 15, this has 30.**
```r
create_all_experiments <- function(
^
```
[R/create_copy_twin_tree_from_true_fun.R:21:1:](https://github.com/richelbilderbeek/pirouette/blob/c4ab506982ca1531efd9ad09c2278bf314a7a7a7/R/create_copy_twin_tree_from_true_fun.R#L21) *style:* **Variable and function names should not be longer than 30 characters.**
```r
create_copy_twin_tree_from_true_fun <- function() {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/est_evidences.R:35:1:](https://github.com/richelbilderbeek/pirouette/blob/c4ab506982ca1531efd9ad09c2278bf314a7a7a7/R/est_evidences.R#L35) *style:* **functions should have cyclomatic complexity of less than 15, this has 20.**
```r
est_evidences <- function(
^
```
[R/get_sim_twal_with_same_n_mutation_fun.R:29:1:](https://github.com/richelbilderbeek/pirouette/blob/c4ab506982ca1531efd9ad09c2278bf314a7a7a7/R/get_sim_twal_with_same_n_mutation_fun.R#L29) *style:* **Variable and function names should not be longer than 30 characters.**
```r
get_sim_twal_with_same_n_mutation_fun <- function(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/select_candidate_evidences.R:25:1:](https://github.com/richelbilderbeek/pirouette/blob/c4ab506982ca1531efd9ad09c2278bf314a7a7a7/R/select_candidate_evidences.R#L25) *style:* **functions should have cyclomatic complexity of less than 15, this has 20.**
```r
select_candidate_evidences <- function(
^
```


I think the problem can be that inside canonical_mutation::to_mutation there is a check:
```
auto mv = ser::deserialize(in, boost::type<ser::canonical_mutation_view>());
if (mv.schema_version() == m.schema()->version()) {
  // use m.schema()
} else {
  // use converting_mutation_partition_applier
}
```
because we fake the schema when broadcasting it to the cluster, it might be that we enter the "equal" branch and don't use converting_mutation_partition_applier. I will verify.


ka change kelas


Use row_count to check if your query affects rows


Also spaces.


Re-added etc/rear/local.conf via
https://github.com/rear/rear/commit/7150bd3cab026c49203b302827454711ad098c98
that had been accidentally removed by this commit here
https://github.com/rear/rear/commit/2e3ff0fbacaf15055ebf4fcfab75f29ee58fe838


An encrypted password should be used


Please also generate the corresponding output files containing the resulting Amino-Acid sequences.
(one for the singleSeq and one for the singleVariant data loader)


written by madhu


from errors import errors


raise errors.StoreError


OK!


You should check row_count


Re-added etc/rear/local.conf via
https://github.com/rear/rear/commit/7150bd3cab026c49203b302827454711ad098c98
that had been removed by accitend via this commit here.


Kernel booting sir?


More "Djang-onic": `assert not Recipe.objects.filter(id=recipe.id).exists()`


↓OK!


Lucas, what is the best way for me to contact you in the future? I was intending to start a small discord server for those on OpenBench, so we can all be on the same page somewhere, and since at some point I have to force client updates (whenever I get an auto-updater) in place.


Copy of this build can be found at
https://www.mewbuilds.com/build/a90a67b4b3e12b12aa6b7f9a1d04c86a9eb25022/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmSh4birhVDFXGCKEWizYvRqtTTzjGB8UAK2jVrgNe1fRZ
                       Virus Total analysis
                       https://www.virustotal.com/file/717474e21c2963dadf253eff37968d0f2c73f635522ec7fc2fec8e610e771e83/analysis/1576627236/


Copy of this build can be found at
https://www.mewbuilds.com/build/b54880702b12c849b87b4712b3c048fff0508df2/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmYu7BEEtsDnAQgHnszVrHsNkmF3NKz9Yf78v79BHuGZ33
                       Virus Total analysis
                       https://www.virustotal.com/file/6fdd150cddbe44aee29c73ea76494c51ce146f56bff128a8d8cd04bf98569061/analysis/1576627252/


Successfully deployed to following URLs:

* https://gitlab-pipelines-itut1o8a8.now.sh
* https://gitlab-pipelines.now.sh
* https://gitlab-pipelines.miloshinjo.now.sh
* https://gitlab-pipelines-git-master.miloshinjo.now.sh


TeamCity Campaign Reporting Api :: Pull Requests [Build 23](http://tc.rsci.co/viewLog.html?buildId=90655&buildTypeId=CampaignReportingApi_PullRequests) is now running


TeamCity Campaign Reporting Api :: Pull Requests [Build 23](http://tc.rsci.co/viewLog.html?buildId=90655&buildTypeId=CampaignReportingApi_PullRequests) outcome was **FAILURE**
Summary: Exit code 2 Build time: 00:00:10


[tests/testthat/test-generics.R:34:7:](https://github.com/IndrajeetPatil/broomExtra/blob/42fda9ca9fc1481394795e029b6ee472a1e4c00c/tests/testthat/test-generics.R#L34) *style:* **Commented code should be removed.**
```r
    # testthat::expect_equal(dim(broomExtra::tidy(mtcars)), c(32L, 12L))
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-generics.R:35:7:](https://github.com/IndrajeetPatil/broomExtra/blob/42fda9ca9fc1481394795e029b6ee472a1e4c00c/tests/testthat/test-generics.R#L35) *style:* **Commented code should be removed.**
```r
    # testthat::expect_identical(names(broomExtra::tidy(mtcars))[1], "rownames")
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


Successfully deployed to following URLs:

* https://chatkartweb-9o19yoo88.now.sh
* https://chatkartweb.now.sh
* https://chatkart.in
* https://www.chatkart.in
* https://chatkartweb.chatkart.now.sh
* https://chatkartweb-git-master.chatkart.now.sh


Parsing and then generating the action from the indecomposable action is
much slower than directly parsing. The main step I would be concerned about
is generating the action. Perhaps it would be fine to just have a separate
type of modules for very large ones if we ever end up wanting them.

On Tue, Dec 17, 2019 at 6:42 PM Dexter Chua <notifications@github.com>
wrote:

> Fair enough. I would still like to convert things to use the new way to
> describe relations, though. I don't think parsing time is a concern,
> since JSON is also something that requires parsing (and I don't think it
> will ever be the bottleneck).
>
> Similar things can be done for finitely presented modules.
>
> On Tue, Dec 17, 2019 at 03:25:56PM -0800, Hood Chatham wrote:
> >My only worry is that for large enough modules, it might take a noticeable
> >amount of time for it to compute the actions. Robert in particular likes
> >compute the cohomology of some very big things. Oftentimes they are fast
> to
> >resolve because they don't have that much cohomology by design. Seems like
> >it would be good to at least support an encoding that isn't super
> >inefficient for large modules.
> >
> >My thinking was to make tools that make it convenient to do a lot of
> module
> >manipulations and then make it annoying to write the files by hand in
> order
> >to encourage people to use the tools.
> >
> >On Tue, Dec 17, 2019 at 6:20 PM Dexter Chua <notifications@github.com>
> >wrote:
> >
> >> Simplify module definition
> >>
> >> This commit provides a simpler way to define actions in the module
> >> files. For example, the following defines C2:
> >>
> >> {
> >> "type": "finite dimensional module",
> >> "name": "$C(2)$",
> >> "p": 2,
> >> "generic": false,
> >> "gens": {"x0": 0, "x1": 1},
> >> "actions": [
> >> "Sq1 x0 = x1"
> >> ]
> >> }
> >>
> >> This makes it feasible to edit module files by hand.
> >>
> >> Some notes:
> >>
> >> - This uses nom to parse the actions. This does not reuse the code in
> >> steenrod_parser since the requirements are slightly different. This
> >> should be tidied up at some point.
> >>
> >> - This only requires specifying the action of the generators of the
> >> algebra. This doesn't work so well when the MilnorAlgebra has a
> >> non-trivial profile, since the decomposition algorithm doesn't know
> >> that, say,
> >>
> >> Sq^1 Sq^4 Sq^1 = Sq^1 Sq^2 Sq^1 Sq^2
> >>
> >> I need to figure out what to do with this.
> >>
> >> - At the moment, the old method of specifying modules is still
> >> supported. I will write a script to convert existing modules to
> >> the new format. Afterwards, I would like to drop support for the old
> >> method to clean up the codebase. How many users do we actually have?
> >>
> >> (to_minimal_json can probably be dropped too)
> >>
> >> - The module constructor etc. should be converted to the new format.
> >>
> >> @hoodmane any comments?
> >>
> >> --
> >> You are receiving this because you were mentioned.
> >> Reply to this email directly or view it on GitHub:
> >>
> >>
> https://github.com/hoodmane/rust_ext/commit/805a31617bd88320ad05da42ca7c7f641acc5424
> >>
> >
> >
> >--
> >You are receiving this because you authored the thread.
> >Reply to this email directly or view it on GitHub:
> >
> https://github.com/hoodmane/rust_ext/commit/805a31617bd88320ad05da42ca7c7f641acc5424#commitcomment-36474711
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/hoodmane/rust_ext/commit/805a31617bd88320ad05da42ca7c7f641acc5424?email_source=notifications&email_token=ACCVWKTFPCJVWJ74XHZAY6DQZFPVZA5CNFSM4J4C5EB2YY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBCZEAO#commitcomment-36474894>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACCVWKWDVNOKQXOR5M2KVI3QZFPVZANCNFSM4J4C5EBQ>
> .
>


Successfully deployed to following URLs:

* https://pablopink-caau7qpe9.now.sh
* https://pablo.pink
* https://pablovarela.es
* https://pablo.life
* https://pablopink.pablopunk.now.sh
* https://pablopink-git-master.pablopunk.now.sh


Successfully deployed to following URLs:

* https://bryanjswift-com-827q271ei.now.sh


Successfully deployed to following URLs:

* https://gitlab-pipelines-82omr0g1t.now.sh
* https://gitlab-pipelines.now.sh
* https://gitlab-pipelines.miloshinjo.now.sh
* https://gitlab-pipelines-git-master.miloshinjo.now.sh


You mean with 4 vs 6 bytes? I have tried to change that part of the logic very little, but I think I have a good idea of what would need to change to support 6 byte character points. I can make the change in a next commit. I think we could afford to keep it on the C++ side. What do you think?


✅ Status for 'xamarin-macios - sample testing (build)': [success](https://devdiv.visualstudio.com//DevDiv/_build/results?buildId=3329982).

* ✅ Debug_iPhone_AF: Succeeded
* ✅ Debug_iPhone_GR: Succeeded
* ✅ Debug_iPhone_SZ: Succeeded
* ✅ Debug_iPhoneSimulator: Succeeded
* ✅ Release_iPhone_AF: Succeeded
* ✅ Release_iPhone_GR: Succeeded
* ✅ Release_iPhone_SZ: Succeeded
* ✅ Release_iPhoneSimulator: Succeeded
* ✅ Debug_Mac: Succeeded
* ✅ Release_Mac: Succeeded


[tests/testthat/test-generics.R:34:7:](https://github.com/IndrajeetPatil/broomExtra/blob/9960a5675145b63ebfe0a79a733d779708edd457/tests/testthat/test-generics.R#L34) *style:* **Commented code should be removed.**
```r
    # testthat::expect_equal(dim(broomExtra::tidy(mtcars)), c(32L, 12L))
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-generics.R:35:7:](https://github.com/IndrajeetPatil/broomExtra/blob/9960a5675145b63ebfe0a79a733d779708edd457/tests/testthat/test-generics.R#L35) *style:* **Commented code should be removed.**
```r
    # testthat::expect_identical(names(broomExtra::tidy(mtcars))[1], "rownames")
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


Right! Thanks for the notice – I'll fix it


Successfully deployed to following URLs:

* https://main-site-ll1w8cfsh.now.sh
* https://fcc-mcr.now.sh
* https://fccmanchester.com
* https://main-site.fcc-mcr.now.sh
* https://main-site-git-master.fcc-mcr.now.sh


also closes #155


Successfully deployed to following URLs:

* https://baseweb-k2bgwgk0b.now.sh
* https://baseweb.uber-ui-platform.now.sh
* https://baseweb-git-master.uber-ui-platform.now.sh


TeamCity Campaign Reporting Api :: Pull Requests [Build 24](http://tc.rsci.co/viewLog.html?buildId=90660&buildTypeId=CampaignReportingApi_PullRequests) is now running


TeamCity Campaign Reporting Api :: Pull Requests [Build 24](http://tc.rsci.co/viewLog.html?buildId=90660&buildTypeId=CampaignReportingApi_PullRequests) outcome was **FAILURE**
Summary: Exit code 2 Build time: 00:00:06


ChillerPlantComponentAgain (Myoldmopar) - Win64-Windows-10-VisualStudio-16: OK (2589 of 2596 tests passed, 2 test warnings)

Messages:\n
 * 7 tests had: EIO diffs.
 * 6 tests had: ESO small diffs.
 * 5 tests had: MTR small diffs.
 * 7 tests had: Table big diffs.
 * 3 tests had: ESO big diffs.
 * 3 tests had: MTR big diffs.
 * 1 test had: Table small diffs.

Failures:\n

regression Test Summary
 * Passed: 663
 * Failed: 7

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.73%25-yellow.png)


[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/terminus-build-tools-plugin/master/assets/images/visit-site-36.png)](https://pr-23-darwin-d8-composer-project.pantheonsite.io/)

Created multidev environment [pr-23](https://dashboard.pantheon.io/sites/52355ac1-d072-476c-a395-9c94b630e74e#pr-23) for darwin-d8-composer-project.


Successfully deployed to following URLs:

* https://bryanjswift-com-4liwjsjjo.now.sh


[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-246-mtcv.pantheonsite.io/)

Created multidev environment [pr-246](https://dashboard.pantheon.io/sites/ad79477c-5d06-4234-b6b8-582ebeee0e5c#pr-246) for mtcv.


[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/terminus-build-tools-plugin/master/assets/images/visit-site-36.png)](https://pr-19-conftool.pantheonsite.io/)

Created multidev environment [pr-19](https://dashboard.pantheon.io/sites/3b0044e5-7502-4c55-b197-f149b25ac699#pr-19) for conftool.


[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/terminus-build-tools-plugin/master/assets/images/visit-site-36.png)](https://pr-40-rooseveltedu.pantheonsite.io/)

Created multidev environment [pr-40](https://dashboard.pantheon.io/sites/bd787532-7df1-43fd-9b09-ca162d2c4bab#pr-40) for rooseveltedu.


Successfully deployed to following URLs:

* https://dockerdemo-q9iyvkyx4.now.sh
* https://dockerdemo.fydy.now.sh
* https://dockerdemo-git-master.fydy.now.sh


Copy of this build can be found at
https://www.mewbuilds.com/build/f5a50c4c586a2af569222e0a9bfbbe744d0aaa0e/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmTafEFkV6RYHUZX5QYYrWaDH2Aeu5zE6162cL8B6Lvkqi
                       Virus Total analysis
                       https://www.virustotal.com/file/0250799bbbd34a74d0eda8a304055b5072c2a11da666d69cf8bec295f515274f/analysis/1576627979/


@gnzlbg @davidMcneil missing semicolon, it is breaking the build


[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/terminus-build-tools-plugin/master/assets/images/visit-site-36.png)](https://pr-40-pantheon-d8-composer-project-mmafe.pantheonsite.io/)

Created multidev environment [pr-40](https://dashboard.pantheon.io/sites/04c3e265-efbf-4120-84af-f029c7b6535b#pr-40) for pantheon-d8-composer-project-mmafe.


[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/terminus-build-tools-plugin/master/assets/images/visit-site-36.png)](https://pr-148-newupstream.pantheonsite.io/)

Created multidev environment [pr-148](https://dashboard.pantheon.io/sites/8be50dbc-4463-43b5-bd18-d83046623820#pr-148) for newupstream.


Successfully deployed to following URLs:

* https://supercard-cra-psiyzs9u3.now.sh
* https://supercard-cra.now.sh
* https://supercard-cra.aarnadlr.now.sh
* https://supercard-cra-git-master.aarnadlr.now.sh


Successfully deployed to following URLs:

* https://carbon-website-dwm7qlmcp.now.sh
* https://carbondesignsystem.now.sh
* https://carbon-website.carbon-design-system.now.sh
* https://carbon-website-git-master.carbon-design-system.now.sh


[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/terminus-build-tools-plugin/master/assets/images/visit-site-36.png)](https://pr-22-codejourneymen.pantheonsite.io/)

Created multidev environment [pr-22](https://dashboard.pantheon.io/sites/9c8b3599-3fde-4228-88b0-2e3d5b592955#pr-22) for codejourneymen.


@JuliaRegistrator register


Registration pull request updated: [JuliaRegistries/General/6811](https://github.com/JuliaRegistries/General/pull/6811)

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if [Julia TagBot](https://github.com/apps/julia-tagbot) is installed, or can be done manually through the github interface, or via:
```
git tag -a v2.5.0 -m "<description of version>" 8bee71b4501b42d360edb81f8d422219a8c3e0fa
git push origin v2.5.0
```


Copy of this build can be found at
https://www.mewbuilds.com/build/972814f584cb6c58869709df8c6bb58e3ee82e53/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmSNRU41cummLF2CZ87KFQWGQTrpcEr3F9aByYFRRLrgcW
                       Virus Total analysis
                       https://www.virustotal.com/file/9d456c7ad465fe2fe34b05b66521d75c904e660cc987003b6578ce61ce89bf18/analysis/1576628166/


Successfully deployed to following URLs:

* https://pablopink-j13mr5lkb.now.sh
* https://pablo.pink
* https://pablovarela.es
* https://pablo.life
* https://pablopink.pablopunk.now.sh
* https://pablopink-git-master.pablopunk.now.sh


Нужна ещё документация к этим функциям


[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/terminus-build-tools-plugin/master/assets/images/visit-site-36.png)](https://pr-323-ci-example-d8-composer.pantheonsite.io/)

Created multidev environment [pr-323](https://dashboard.pantheon.io/sites/c401fd14-f745-4e51-9af2-f30b45146a0c#pr-323) for ci-example-d8-composer.


[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/terminus-build-tools-plugin/master/assets/images/visit-site-36.png)](https://pr-31-bb-megasite-d8.pantheonsite.io/)

Created multidev environment [pr-31](https://dashboard.pantheon.io/sites/f4c5c116-0f1c-4c9d-8b49-62d99e1ff6c2#pr-31) for bb-megasite-d8.


[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/terminus-build-tools-plugin/master/assets/images/visit-site-36.png)](https://pr-48-ecdemo.pantheonsite.io/)

Created multidev environment [pr-48](https://dashboard.pantheon.io/sites/8194d45a-1eec-4bca-bf52-e2b9ee0a0eff#pr-48) for ecdemo.


# Specs execution successful
:scroll: [View logs](http://bamboo.comnull)
### Plans updated

Bamboo specs have been successfully imported and the following plans have been updated.

Project | Plan | Build
---|---|---
[Test](http://bamboo.com/browse/TEST) | [Comment test](http://bamboo.com/browse/TEST-CTEST)  | :white_check_mark: [\#1](http://bamboo.com/browse/TEST-CTEST-1)
[New project](http://bamboo.com/browse/NEW) | [Disabled plan](http://bamboo.com/browse/NEW-DISABLED) **disabled** | :white_check_mark: [\#1](http://bamboo.com/browse/NEW-DISABLED-1)

### Deployments updated

Bamboo specs have been successfully imported and the following deployment projects have been updated.

|Deployment project |
----|
[Deployment test](http://bamboo.com/deploy/viewDeploymentProjectVersions.action?id=2162689)|


@eadamsintel I have changed this to `image permissions` instead.


[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/terminus-build-tools-plugin/master/assets/images/visit-site-36.png)](https://pr-23-circlecitesting.pantheonsite.io/)

Created multidev environment [pr-23](https://dashboard.pantheon.io/sites/b3a23884-e410-4cba-8d0d-94acff20cc8f#pr-23) for circlecitesting.


Successfully deployed to following URLs:

* https://supercard-cra-ckuj0vqb6.now.sh
* https://supercard-cra.now.sh
* https://supercard-cra.aarnadlr.now.sh
* https://supercard-cra-git-master.aarnadlr.now.sh


[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/terminus-build-tools-plugin/master/assets/images/visit-site-36.png)](https://pr-14-freshdrupalmi.pantheonsite.io/)

Created multidev environment [pr-14](https://dashboard.pantheon.io/sites/3f2a3ea1-fe0b-478b-9c9f-55b30cc10325#pr-14) for freshdrupalmi.


Copy of this build can be found at
https://www.mewbuilds.com/build/c7185a3e0e4a178674c9add05333e1f5e380d11c/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmcFA44VG2xukeS94mNJiwXcTEH3BRpE1wJ5tvwXq4d7QM
                       Virus Total analysis
                       https://www.virustotal.com/file/f9613762ddcef7f78575e783385ecfdc5bf37d98f9f63077d8ed5610ac5382c2/analysis/1576628653/


Successfully deployed to following URLs:

* https://leebyron-hmjy1ovnr.now.sh
* https://leebyron.now.sh
* https://lwb.io
* https://leebyron.leebyron.now.sh
* https://leebyron-git-master.leebyron.now.sh


[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/terminus-build-tools-plugin/master/assets/images/visit-site-36.png)](https://pr-10-plantd8.pantheonsite.io/)

Created multidev environment [pr-10](https://dashboard.pantheon.io/sites/3d3bf61c-b78f-4e66-91ae-d562622b6c8b#pr-10) for plantd8.


Successfully deployed to following URLs:

* https://pablopink-dpsyvea2i.now.sh
* https://pablo.pink
* https://pablovarela.es
* https://pablo.life
* https://pablopink.pablopunk.now.sh
* https://pablopink-git-master.pablopunk.now.sh


Revisado


Copy of this build can be found at
https://www.mewbuilds.com/build/0cdf9b2994005b34c10c91ee2a4e5b8d5f99b9a1/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmRHgLaHDCfzcUbJsmpfYMZ5TuErE3RJ1FvbZPEkUDncyK
                       Virus Total analysis
                       https://www.virustotal.com/file/802746e86014477fc5536edce9058dc20c36a6ec7b2e7f14ec6ffb5c5eef4d8c/analysis/1576628850/


Copy of this build can be found at
https://www.mewbuilds.com/build/1c30abcf4846b9c3f96e38370c3360410599263b/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmQMkvarYUd29UebouzzLohuiWUQL1KKkUu9t1ENF1G9cM
                       Virus Total analysis
                       https://www.virustotal.com/file/0216505f04a488174319a1af293084ab49fbf68bf8b2ab9f1519c966dbd96fbe/analysis/1576628857/


Es necesario el data-turbolinks... ?


Successfully deployed to following URLs:

* https://chatkartweb-ewb54unv3.now.sh
* https://chatkartweb.now.sh
* https://chatkart.in
* https://www.chatkart.in
* https://chatkartweb.chatkart.now.sh
* https://chatkartweb-git-master.chatkart.now.sh


[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/terminus-build-tools-plugin/master/assets/images/visit-site-36.png)](https://pr-4-hillwoodd8.pantheonsite.io/)

Created multidev environment [pr-4](https://dashboard.pantheon.io/sites/44408f15-59f1-46e0-9b9a-27440ea57b90#pr-4) for hillwoodd8.


Successfully deployed to following URLs:

* https://pablopink-642njvo2d.now.sh
* https://pablo.pink
* https://pablovarela.es
* https://pablo.life
* https://pablopink.pablopunk.now.sh
* https://pablopink-git-master.pablopunk.now.sh


Eliminar una salto de línea.


width y heigh de primero


Eliminar salto de línea


Too many implicit 'any' definitions (parameters on onEnd, onStart, onPauseResume, onReset, onUpdate)


Muy bien Alberto, buen trabajo


Successfully deployed to following URLs:

* https://vanillafunctions-avbncuyfl.now.sh
* https://hukamnama.amandeep.tech
* https://khalsa.tech
* https://www.khalsa.tech
* https://hukamnama.khalsa.tech
* https://vanillafunctions.khalsa.now.sh
* https://vanillafunctions-git-master.khalsa.now.sh


Es necesario ?


Successfully deployed to following URLs:

* https://openship-j6sp27bus.now.sh
* https://openship.now.sh
* https://openship.openship.now.sh
* https://openship-git-master.openship.now.sh


Missing the backslashes on the ends of the new lines?


Successfully deployed to following URLs:

* https://longpnguyengithubio-7ec02acaz.now.sh
* https://longpnguyen.now.sh
* https://longpnguyengithubio.nguy4227.now.sh
* https://longpnguyengithubio-git-master.nguy4227.now.sh


❌ [Build was (probably) aborted](https://jenkins.internalx.com/job/macios/job/reenable-mscorlib-tests/1/display/redirect)

🔥 [Jenkins job](https://jenkins.internalx.com/job/macios/job/reenable-mscorlib-tests/1/display/redirect) (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥

✅ [Build succeeded](https://jenkins.internalx.com/job/macios/job/reenable-mscorlib-tests/1//console)
✅ Packages:
* [xamarin.ios-13.15.0.134.pkg (Not notarized)](https://bosstoragemirror.blob.core.windows.net/wrench/jenkins/reenable-mscorlib-tests/eeb8e8404835a9bdfc0a15c86de5513b453420e4/1/package/xamarin.ios-13.15.0.134.pkg)
* [xamarin.mac-6.15.0.134.pkg (Not notarized)](https://bosstoragemirror.blob.core.windows.net/wrench/jenkins/reenable-mscorlib-tests/eeb8e8404835a9bdfc0a15c86de5513b453420e4/1/package/xamarin.mac-6.15.0.134.pkg)
* [xamarin.ios-13.15.0.134.pkg (Notarized)](https://bosstoragemirror.blob.core.windows.net/wrench/jenkins/reenable-mscorlib-tests/eeb8e8404835a9bdfc0a15c86de5513b453420e4/1/package/notarized/xamarin.ios-13.15.0.134.pkg)
* [xamarin.mac-6.15.0.134.pkg (Notarized)](https://bosstoragemirror.blob.core.windows.net/wrench/jenkins/reenable-mscorlib-tests/eeb8e8404835a9bdfc0a15c86de5513b453420e4/1/package/notarized/xamarin.mac-6.15.0.134.pkg)

✅ [API Diff (from stable)](http://xamarin-storage/jenkins/xamarin-macios/reenable-mscorlib-tests/eeb8e8404835a9bdfc0a15c86de5513b453420e4/1/jenkins-results/api-diff/index.html)
✅ [API Diff (from PR only)](http://xamarin-storage/jenkins/xamarin-macios/reenable-mscorlib-tests/eeb8e8404835a9bdfc0a15c86de5513b453420e4/1/jenkins-results/apicomparison/api-diff.html) (no change)
✅ [Generator Diff](http://xamarin-storage/jenkins/xamarin-macios/reenable-mscorlib-tests/eeb8e8404835a9bdfc0a15c86de5513b453420e4/1/jenkins-results/generator-diff/index.html) (no change)
🔥 [Test run failed](http://xamarin-storage/jenkins/xamarin-macios/reenable-mscorlib-tests/eeb8e8404835a9bdfc0a15c86de5513b453420e4/1/jenkins-results/tests/index.html) 🔥

# Test results

<details>
<summary>3 tests failed, 161 tests passed.</summary>

## Failed tests

 * [NUnit] Mono Mac OS X BCL tests group 2/Mac Modern/Debug: Failed (Test run failed.)
 * monotouch-test/watchOS 32-bits - simulator/Debug: Crashed
 * mscorlib/watchOS 32-bits - simulator/Debug: Crashed
</details>


Comentario en Commit


Para este tipo de dato, recomiendo usar el Enum de estado


The script / plugin source added the feature for cs1.6 weapons.
You can use above APIs to achieve many things like adding weapon's damage depend on its level.
if any problems, just contact me.


<Crisis Averted>


Misma observación para todos los estados, manejar el Enum


Successfully deployed to following URLs:

* https://supercard-cra-8wqz79nru.now.sh
* https://supercard-cra.now.sh
* https://supercard-cra.aarnadlr.now.sh
* https://supercard-cra-git-master.aarnadlr.now.sh


Misma observación del estado. Adicionalmente debe colocarse una anotación para que convierta el valor a string cuando se van a insertar valores


Enum + Anotación


Does this work for you @matahariku or is it still WIP?


report


Successfully deployed to following URLs:

* https://longpnguyengithubio-es6stpgdr.now.sh
* https://longpnguyen.now.sh
* https://longpnguyengithubio.nguy4227.now.sh
* https://longpnguyengithubio-git-master.nguy4227.now.sh


Red and understood.


Muy buen trabajo, lo felicito, tiene un buen estilo para documentar. Lo único que hizo falta fueron los scripts de la creación de la tabla de rol, y el de modificación del nombre del personaje para que sea único


Noted on the alias change


Successfully deployed to following URLs:

* https://chatkartweb-nihvskhkz.now.sh
* https://chatkartweb.now.sh
* https://chatkart.in
* https://www.chatkart.in
* https://chatkartweb.chatkart.now.sh
* https://chatkartweb-git-master.chatkart.now.sh


Successfully deployed to following URLs:

* https://pablopink-kap31y3we.now.sh
* https://pablo.pink
* https://pablovarela.es
* https://pablo.life
* https://www.pablo.pink
* https://pablopink.pablopunk.now.sh
* https://pablopink-git-master.pablopunk.now.sh


Build version: __`0.11.0-renovate/node-8.16.1251`__ :crossed_fingers: [`renovate/node-8.16`](https://github.com/streamich/ci-scripts/tree/renovate/node-8.16) on [*CircleCI*](https://circleci.com/gh/streamich/ci-scripts/1251) :tada:


Build version: __`0.11.0-renovate/node-8.16.1935`__ :crossed_fingers: [`renovate/node-8.16`](https://github.com/streamich/ci-scripts/tree/renovate/node-8.16) on [*Travis*](https://travis-ci.org/streamich/ci-scripts/builds/626471310) :tada:


Buen trabajo


Yeah I meant we still have a mode where people specify all actions, but in the new way.

From a mathematical point of view, in general we need all the P^s_t's to generate the subalgebras, but sometimes we can do with less. Is it known what the minimal sets of generators are?


Successfully deployed to following URLs:

* https://crm-frontend-30189zahx.now.sh
* https://crm-frontend-omega-ten.now.sh
* https://crm-frontend.khansen0415.now.sh
* https://crm-frontend-git-master.khansen0415.now.sh


Successfully deployed to following URLs:

* https://openship-lexcg1x2p.now.sh
* https://openship.now.sh
* https://openship.openship.now.sh
* https://openship-git-master.openship.now.sh


Hey! Thanks!
What exactly do you mean by unlimited results? Apple has a limit on how many results are returned.


ChillerPlantComponentAgain (Myoldmopar) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-IntegrationCoverage-Debug: OK (674 of 675 tests passed, 0 test warnings)

Failures:\n

integration Test Summary
 * Passed: 674
 * Timeout: 1

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.85%25-yellow.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-68.38%25-yellow.png)


Successfully deployed to following URLs:

* https://genhubco-f0zc4c7et.now.sh
* https://genhub.co
* https://genhubco.genhub.now.sh
* https://genhubco-git-master.genhub.now.sh


删除.iml文件


Thanks @langerhans


Successfully deployed to following URLs:

* https://portfolio-bcjdppr4n.now.sh
* https://justinweb.dev
* https://portfolio.jtmccutcheon.now.sh
* https://portfolio-git-master.jtmccutcheon.now.sh


🔥 Device tests completed (Failed) on TvOS on [Azure DevOps](https://dev.azure.com/devdiv/DevDiv/_build/index?buildId=3330194)(TvOS): [Html Report](http://xamarin-storage/jenkins/xamarin-macios/updatenotarize/d153611f32a9084336a1eb3594c7f0985547feac/3330194/device-tests/jenkins-results/tests/index.html) 🔥

🔥 Tests failed catastrophically on TvOS  (no summary found)


Successfully deployed to following URLs:

* https://theworldorg-7k5gq0pf0.now.sh
* https://theworldorg.prx-tech.now.sh
* https://theworldorg-git-master.prx-tech.now.sh


Buen trabajo, le recomiendo que linkee el comentario de la interface al método que lo implementa, esto se logra con una configuración de eclipse. Pero a modo general todo ok.


🔥 Device tests completed (Failed) on iOS on [Azure DevOps](https://dev.azure.com/devdiv/DevDiv/_build/index?buildId=3330192)(iOS): [Html Report](http://xamarin-storage/jenkins/xamarin-macios/updatenotarize/d153611f32a9084336a1eb3594c7f0985547feac/3330192/device-tests/jenkins-results/tests/index.html) 🔥

🔥 Tests failed catastrophically on iOS  (no summary found)


Sounds ok actually. I did have a scala 2.11 bug the other day also, it was simple enough that I was able to just change the code without bothering to switch over the IDE. Of course my bug had a universal fix.  Your problem here you were not so lucky. But I don't know that we'll be that unlucky again or often. So I would defer worry about smoothing the 2.11 IDE configuration issues until we need it.


Successfully deployed to following URLs:

* https://chatkartweb-has74681z.now.sh
* https://chatkartweb.now.sh
* https://chatkart.in
* https://www.chatkart.in
* https://chatkartweb.chatkart.now.sh
* https://chatkartweb-git-master.chatkart.now.sh


Successfully deployed to following URLs:

* https://personal-website-qf8k5xkog.now.sh
* https://personal-website-two-kappa.now.sh
* https://johnkueh.com
* https://www.johnkueh.com
* https://personal-website.johnkueh.now.sh
* https://personal-website-git-master.johnkueh.now.sh


🔥 Device tests completed (Failed) on iOS on [Azure DevOps](https://dev.azure.com/devdiv/DevDiv/_build/index?buildId=3329225)(iOS): [Html Report](http://xamarin-storage/jenkins/xamarin-macios/reenable-mscorlib-tests/eeb8e8404835a9bdfc0a15c86de5513b453420e4/3329225/device-tests/jenkins-results/tests/index.html) 🔥

# Test results

<details>
<summary>2 tests failed, 111 tests passed.</summary>

## Failed tests

 * mscorlib/iOS Unified 64-bits - device/Release: Failed
 * mscorlib/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Failed
</details>


Build version: __`3.3.0-renovate/node-8.16.1029`__ :crossed_fingers: [`renovate/node-8.16`](https://github.com/streamich/md-mdast/tree/renovate/node-8.16) on [*CircleCI*](https://circleci.com/gh/streamich/md-mdast/1029) :tada:


Successfully deployed to following URLs:

* https://react-fridgescavenger-project-rcco5gn71.now.sh
* https://react-fridgescavenger-project.now.sh
* https://fridgescavenger.com
* https://react-fridgescavenger-project.williamblacknall.now.sh
* https://react-fridgescavenger-project-git-master.williamblacknall.now.sh


Este método es de prueba, hay que dejar solo lo que se necesita y cambiar bien los datos cuando se copia y se pega


Successfully deployed to following URLs:

* https://personal-website-b1bxukr06.now.sh
* https://personal-website-two-kappa.now.sh
* https://johnkueh.com
* https://www.johnkueh.com
* https://personal-website.johnkueh.now.sh
* https://personal-website-git-master.johnkueh.now.sh


Speaking of very big modules, I think we will run into problems with memory if we want to store all the actions. For the Adem algebra, storing the actions of the Sq^i's only might be a good compromise since we can decompose this way rather quickly, and we are also unlikely to have a very long list of Sqi's since the degrees grow exponentially.


comit


test =
1.GET   /currents에서
2.header
3.Authorization
4. bearer = token 값;


> Tu peux juste ajouter les attributs de ton fichier markdown avec les meta données de ton article (titre, description, tags, auteur, ...) stp ?
>
> Comme dans cet article (tout en haut en commençant par 3 tirets et finissant par 3 tirets) par exemple : https://raw.githubusercontent.com/ismailnguyen/a-software-crafter-s-journey/master/articles/2018/05/ton-code-fait-partie-du-patrimoine-culturel.md

Désolé, j'avais vu ça, j'ai complètement zappé de le mettre. Tu me diras si mes tags sont bon (j'ai pas vraiment d'idées)

> Et pourquoi uploader un package-default.json ?

Je voulais faire un exemple en construisant au fur et à mesure un `package.json` pour montrer à quoi ça ressemble, mais je pense que je pourrais le supprimer, ça apporte rien à l'article en l'état. :)


Successfully deployed to following URLs:

* https://personal-website-d9h0kvwke.now.sh
* https://personal-website-two-kappa.now.sh
* https://johnkueh.com
* https://www.johnkueh.com
* https://personal-website.johnkueh.now.sh
* https://personal-website-git-master.johnkueh.now.sh


Successfully deployed to following URLs:

* https://verysimpletodoapp-kivxkvxuc.now.sh
* https://verysimpletodoapp.now.sh
* https://verysimpletodoapp.dflores7237.now.sh
* https://verysimpletodoapp-git-master.dflores7237.now.sh


That's what I get for using i3 and it resizing my code editor to hide the full line :(

https://github.com/rayzorben/bluecherry-docker/commit/7479ffe6ab1e889f98c24934f425f1e8a6cd69a6


@tomquisel Didn't mean to push this to the actual repo, wanted this to be a PR. Can't seem to remove the commit though as it's a protected repo. :/ Sorry.


@james77777778
如果不疊，單純在比task4的時候，應該還是會遇到相同的問題？
還是說你是整格演算法跑五次，然後用累加的方式去計算每個task的時間ＸＤ


Copy of this build can be found at
https://www.mewbuilds.com/build/7652b8590e875a66a6481913da13d142f4d0569f/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmUEWWe35UeyDdLH4DATTBeoNbYcvF8RZ1cZpKBu9iejwx
                       Virus Total analysis
                       https://www.virustotal.com/file/53f97fd21e4707410105bb28b915a2a9f87e4105179d805d3fd70e5a4d3b6c1a/analysis/1576630641/


TeamCity Bvcms / Build [Build 3182](https://builds.tpsdb.com/viewLog.html?buildId=10673&buildTypeId=Bvcms_Build) is now running


ul.onclick = function(event){
	var target = event.target;
	target.classList.toggle("done");
}

this part confuses me. Can anybody explain event.target?


Successfully deployed to following URLs:

* https://pablopink-f4zuru59g.now.sh
* https://pablo.pink
* https://pablovarela.es
* https://pablo.life
* https://www.pablo.pink
* https://pablopink.pablopunk.now.sh
* https://pablopink-git-master.pablopunk.now.sh


Hi Saracmelo,

Sorry for the delay in response. Octopart was removed due to the reason that they removed my API key - because they are no longer free. I'm in the process of adding some new code to use the Mouser - and some day the Digi-key api's to pull in sourcing information. In the mean time you're also welcome to refer to some of the old code in previous commits if you'd like to add the ability to pull in Octopart again.

It's a huge bummer and I wish Octopart would let us continue to use their API.

Mike


reconfiguramos o requirements.txt


Copy of this build can be found at
https://www.mewbuilds.com/build/f66025c32a47cc5f6b11d77588805efaabf6dfa3/index.html
                       https://www.cloudflare-ipfs.com/ipfs/QmSS9EpU8oWYtCyBLhjPiXbwa7LkHqGsnLXMn8iFe7oBgD
                       Virus Total analysis
                       https://www.virustotal.com/file/d73a3536ee63bf1973a0394bfb3259c2a7bd865b6b05375ced0b3e6857b2c0f3/analysis/1576630752/


Hi, Mr. Igriski.
About your valuables concepts on "Demystifying makeVector()", would you please help me to understand how must be de source file: cachemean.R, you mention as: " source ("C:/users/......../cachemean.R)"?
Do this file contentes the vectors: > a <- makeVector(1:100), and > b <- makeVector(1:100) ?
I´m a beginer at R and I´ll gratly apreciate your help.
Thanks in advance.


@tyvdh can you just `git revert` it? It's a little messy in the history, but safer probably.


@james77777778  @SalviaJason
了解，我看到code了ＸＤＤ


I added a link to the post and a couple comments.


develop (punyasloka95) - x86_64-Linux-Ubuntu-18.04-cppcheck: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


Successfully deployed to following URLs:

* https://elliotevanssite-djt4ry9xe.now.sh
* https://elliotevans.site
* https://elliotevanssite.elliotevans.now.sh
* https://elliotevanssite-git-master.elliotevans.now.sh


Haha! I see you already did 😄


Buen trabajo.


@tomquisel I tried, however the CI isn't passing.


develop (punyasloka95) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (11 of 11 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png)


Successfully deployed to following URLs:

* https://react-fridgescavenger-project-l3xg414x6.now.sh
* https://react-fridgescavenger-project.now.sh
* https://fridgescavenger.com
* https://react-fridgescavenger-project.williamblacknall.now.sh
* https://react-fridgescavenger-project-git-master.williamblacknall.now.sh


Only checks the first element? Also hmm `element, ...elements` vs `elements` and `elements[0]`


Snap build available: `snap refresh multipass --channel beta/1.0`


Successfully deployed to following URLs:

* https://modely-hq06dcpq1.now.sh
* https://modely.now.sh
* https://modely.bdesselle1.now.sh
* https://modely-git-master.bdesselle1.now.sh


Successfully deployed to following URLs:

* https://demo-qdgctfj7p.now.sh
* https://demo-neon-nu.now.sh
* https://demo.fydy.now.sh
* https://demo-git-master.fydy.now.sh


Oh, `super.add` recursively calls `this.add` which calls the overridden method instead; scary!


EL autor debe ser quién crea la clase. Cuidado con el copiar y pegar


TeamCity Bvcms / Build [Build 3182](https://builds.tpsdb.com/viewLog.html?buildId=10673&buildTypeId=Bvcms_Build) outcome was **FAILURE**
Summary: Compilation error: UnitTests\CMSWebTests\CMSWebTests.csproj Build time: 00:05:27


Los comentarios no están acordes a lo que hace el método, está indicando que se trabaja con persona pero indica el coemntario que es comic


this no longer works because there is an "OKS" product area - if you let me know what belongs there in `epic_area_to_tag_and_writer`, i can fix that up.


Debe prestar atención a la documentación en cuanto a el autor, y la documentación de lo que hace la clase, los métodos, y demás. Cuidado al copiar y pegar


Automatically uploaded by WorldServer on behalf of Joern Elligsen on Dec 18, 2019 at 01:04:44 UTC.


TeamCity Campaign Reporting Api :: Pull Requests [Build 25](http://tc.rsci.co/viewLog.html?buildId=90668&buildTypeId=CampaignReportingApi_PullRequests) is now running


TeamCity Campaign Reporting Api :: Pull Requests [Build 25](http://tc.rsci.co/viewLog.html?buildId=90668&buildTypeId=CampaignReportingApi_PullRequests) outcome was **FAILURE**
Summary: Exit code 2 Build time: 00:00:06


Successfully deployed to following URLs:

* https://0012-own-blog-hmdunr4kx.now.sh
* https://khranovsky.com
* https://0012-own-blog.xronosd.now.sh
* https://0012-own-blog-git-master.xronosd.now.sh


Successfully deployed to following URLs:

* https://pablopink-6l2tkis9x.now.sh
* https://pablo.pink
* https://pablovarela.es
* https://pablo.life
* https://www.pablo.pink
* https://pablopink.pablopunk.now.sh
* https://pablopink-git-master.pablopunk.now.sh


Successfully deployed to following URLs:

* https://clickbecausenet-qm4d1algg.now.sh
* https://clickbecausenet.now.sh
* https://clickbecause.net
* https://clickbecausenet.clickbecause.now.sh
* https://clickbecausenet-git-master.clickbecause.now.sh


[R/helpers_anova_expressions.R:80:1:](https://github.com/IndrajeetPatil/statsExpressions/blob/f69a392c6cf881a293310cdde0cf8f18b2056bfc/R/helpers_anova_expressions.R#L80) *style:* **functions should have cyclomatic complexity of less than 15, this has 19.**
```r
expr_anova_parametric <- function(data,
^
```
[R/helpers_effsize_ci.R:101:1:](https://github.com/IndrajeetPatil/statsExpressions/blob/f69a392c6cf881a293310cdde0cf8f18b2056bfc/R/helpers_effsize_ci.R#L101) *style:* **functions should have cyclomatic complexity of less than 15, this has 20.**
```r
effsize_t_parametric <- function(formula = NULL,
^
```


develop (punyasloka95) - x86_64-Linux-Ubuntu-18.04-gcc-7.4: OK (1915 of 1915 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


Los comentarios TODO, deben eliminarse tan pronto se finaliza la implementación de los métodos


EasyWebshopFeedDeserializer probably needs to be moved to a service. Also, desperately needing some tests.